diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-01-25 16:17:16 -0500 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2008-01-25 16:17:16 -0500 |
commit | 57d7366b78b74a9eef873e8212c03d8c2033a764 (patch) | |
tree | 5b3cefe3c08e765bf83050ddaf21e98b15f7949d /include/linux/ide.h | |
parent | 1192e528e064ebb9a578219731d2b0f78ca3c1ec (diff) |
ide: remove 'handler' field from ide_task_t (take 2)
* Add IDE_TFLAG_CUSTOM_HANDLER taskfile flag and use it for internal requests
which require custom handlers. Check the flag in do_rw_taskfile() and set
handler accordingly.
* Cleanup ide_init_{specify,restore,setmult}_cmd() and rename it to
ide_tf_set_{specify,restore,setmult}_cmd().
* Make {set_geometry,recal,set_multmode}_intr() static.
* Remove no longer needed 'handler' field from ide_task_t.
v2:
* 'handler' in do_rw_taskfile() must be set to NULL initially.
There should be no functionality changes caused by this patch.
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'include/linux/ide.h')
-rw-r--r-- | include/linux/ide.h | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/include/linux/ide.h b/include/linux/ide.h index 5d675f172037..721c9d8f41a2 100644 --- a/include/linux/ide.h +++ b/include/linux/ide.h | |||
@@ -911,6 +911,7 @@ enum { | |||
911 | IDE_TFLAG_WRITE = (1 << 15), | 911 | IDE_TFLAG_WRITE = (1 << 15), |
912 | IDE_TFLAG_FLAGGED_SET_IN_FLAGS = (1 << 16), | 912 | IDE_TFLAG_FLAGGED_SET_IN_FLAGS = (1 << 16), |
913 | IDE_TFLAG_IN_DATA = (1 << 17), | 913 | IDE_TFLAG_IN_DATA = (1 << 17), |
914 | IDE_TFLAG_CUSTOM_HANDLER = (1 << 18), | ||
914 | }; | 915 | }; |
915 | 916 | ||
916 | struct ide_taskfile { | 917 | struct ide_taskfile { |
@@ -949,7 +950,6 @@ typedef struct ide_task_s { | |||
949 | }; | 950 | }; |
950 | u32 tf_flags; | 951 | u32 tf_flags; |
951 | int data_phase; | 952 | int data_phase; |
952 | ide_handler_t *handler; | ||
953 | struct request *rq; /* copy of request */ | 953 | struct request *rq; /* copy of request */ |
954 | void *special; /* valid_t generally */ | 954 | void *special; /* valid_t generally */ |
955 | } ide_task_t; | 955 | } ide_task_t; |
@@ -970,9 +970,6 @@ void ide_pktcmd_tf_load(ide_drive_t *, u32, u16, u8); | |||
970 | */ | 970 | */ |
971 | extern ide_startstop_t do_rw_taskfile(ide_drive_t *, ide_task_t *); | 971 | extern ide_startstop_t do_rw_taskfile(ide_drive_t *, ide_task_t *); |
972 | 972 | ||
973 | extern ide_startstop_t set_multmode_intr(ide_drive_t *); | ||
974 | extern ide_startstop_t set_geometry_intr(ide_drive_t *); | ||
975 | extern ide_startstop_t recal_intr(ide_drive_t *); | ||
976 | extern ide_startstop_t task_in_intr(ide_drive_t *); | 973 | extern ide_startstop_t task_in_intr(ide_drive_t *); |
977 | extern ide_startstop_t pre_task_out_intr(ide_drive_t *, struct request *); | 974 | extern ide_startstop_t pre_task_out_intr(ide_drive_t *, struct request *); |
978 | 975 | ||