diff options
author | Sergei Shtylyov <sshtylyov@ru.mvista.com> | 2009-04-08 08:13:03 -0400 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-04-08 08:13:03 -0400 |
commit | c9ff9e7b64138d87023b733e618f29a1d58543f7 (patch) | |
tree | e0697999409235309c578d3c8a7ecc031be2eda0 /include/linux/ide.h | |
parent | 30881b9ac91e7c23e0ceb8414ab7de1961809bdd (diff) |
ide: refactor tf_load() method
Simplify tf_load() method, making it deal only with 'struct ide_taskfile' and
the validity flags that the upper layer passes, and moving the code that deals
with the high order bytes into the only function interested, do_rw_taskfile().
This should stop the needless code duplication in this method and so make
it about twice smaller than it was; along with simplifying the setup for the
method call, this should save both time and space...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'include/linux/ide.h')
-rw-r--r-- | include/linux/ide.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/ide.h b/include/linux/ide.h index e2ea38df26bc..0ba1c6ab97f8 100644 --- a/include/linux/ide.h +++ b/include/linux/ide.h | |||
@@ -624,7 +624,7 @@ struct ide_tp_ops { | |||
624 | void (*write_devctl)(struct hwif_s *, u8); | 624 | void (*write_devctl)(struct hwif_s *, u8); |
625 | 625 | ||
626 | void (*dev_select)(ide_drive_t *); | 626 | void (*dev_select)(ide_drive_t *); |
627 | void (*tf_load)(ide_drive_t *, struct ide_cmd *); | 627 | void (*tf_load)(ide_drive_t *, struct ide_taskfile *, u8); |
628 | void (*tf_read)(ide_drive_t *, struct ide_cmd *); | 628 | void (*tf_read)(ide_drive_t *, struct ide_cmd *); |
629 | 629 | ||
630 | void (*input_data)(ide_drive_t *, struct ide_cmd *, | 630 | void (*input_data)(ide_drive_t *, struct ide_cmd *, |
@@ -1132,7 +1132,7 @@ u8 ide_read_altstatus(ide_hwif_t *); | |||
1132 | void ide_write_devctl(ide_hwif_t *, u8); | 1132 | void ide_write_devctl(ide_hwif_t *, u8); |
1133 | 1133 | ||
1134 | void ide_dev_select(ide_drive_t *); | 1134 | void ide_dev_select(ide_drive_t *); |
1135 | void ide_tf_load(ide_drive_t *, struct ide_cmd *); | 1135 | void ide_tf_load(ide_drive_t *, struct ide_taskfile *, u8); |
1136 | void ide_tf_read(ide_drive_t *, struct ide_cmd *); | 1136 | void ide_tf_read(ide_drive_t *, struct ide_cmd *); |
1137 | 1137 | ||
1138 | void ide_input_data(ide_drive_t *, struct ide_cmd *, void *, unsigned int); | 1138 | void ide_input_data(ide_drive_t *, struct ide_cmd *, void *, unsigned int); |