diff options
author | Kirill A. Shutemov <kirill.shutemov@linux.intel.com> | 2015-04-15 19:13:08 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-04-15 19:35:17 -0400 |
commit | e8c6158fef15a1532bd5242a0cd88565eedabe61 (patch) | |
tree | 82f931e8dc18bd776ea32e745a7706574186ded8 /include/linux/hugetlb.h | |
parent | 64d37a2baf5e5c0f1009c0ef290a9027de721d66 (diff) |
mm: consolidate all page-flags helpers in <linux/page-flags.h>
Currently we take a naive approach to page flags on compound pages - we
set the flag on the page without consideration if the flag makes sense
for tail page or for compound page in general. This patchset try to
sort this out by defining per-flag policy on what need to be done if
page-flag helper operate on compound page.
The last patch in the patchset also sanitizes usege of page->mapping for
tail pages. We don't define the meaning of page->mapping for tail
pages. Currently it's always NULL, which can be inconsistent with head
page and potentially lead to problems.
For now I caught one case of illegal usage of page flags or ->mapping:
sound subsystem allocates pages with __GFP_COMP and maps them with PTEs.
It leads to setting dirty bit on tail pages and access to tail_page's
->mapping. I don't see any bad behaviour caused by this, but worth
fixing anyway.
This patchset makes more sense if you take my THP refcounting into
account: we will see more compound pages mapped with PTEs and we need to
define behaviour of flags on compound pages to avoid bugs.
This patch (of 16):
We have page-flags helper function declarations/definitions spread over
several header files. Let's consolidate them in <linux/page-flags.h>.
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Acked-by: Hugh Dickins <hughd@google.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Rik van Riel <riel@redhat.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Christoph Lameter <cl@linux.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Steve Capper <steve.capper@linaro.org>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Jerome Marchand <jmarchan@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/hugetlb.h')
-rw-r--r-- | include/linux/hugetlb.h | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index 7b5785032049..1a782733a420 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h | |||
@@ -41,8 +41,6 @@ extern int hugetlb_max_hstate __read_mostly; | |||
41 | struct hugepage_subpool *hugepage_new_subpool(long nr_blocks); | 41 | struct hugepage_subpool *hugepage_new_subpool(long nr_blocks); |
42 | void hugepage_put_subpool(struct hugepage_subpool *spool); | 42 | void hugepage_put_subpool(struct hugepage_subpool *spool); |
43 | 43 | ||
44 | int PageHuge(struct page *page); | ||
45 | |||
46 | void reset_vma_resv_huge_pages(struct vm_area_struct *vma); | 44 | void reset_vma_resv_huge_pages(struct vm_area_struct *vma); |
47 | int hugetlb_sysctl_handler(struct ctl_table *, int, void __user *, size_t *, loff_t *); | 45 | int hugetlb_sysctl_handler(struct ctl_table *, int, void __user *, size_t *, loff_t *); |
48 | int hugetlb_overcommit_handler(struct ctl_table *, int, void __user *, size_t *, loff_t *); | 46 | int hugetlb_overcommit_handler(struct ctl_table *, int, void __user *, size_t *, loff_t *); |
@@ -109,11 +107,6 @@ unsigned long hugetlb_change_protection(struct vm_area_struct *vma, | |||
109 | 107 | ||
110 | #else /* !CONFIG_HUGETLB_PAGE */ | 108 | #else /* !CONFIG_HUGETLB_PAGE */ |
111 | 109 | ||
112 | static inline int PageHuge(struct page *page) | ||
113 | { | ||
114 | return 0; | ||
115 | } | ||
116 | |||
117 | static inline void reset_vma_resv_huge_pages(struct vm_area_struct *vma) | 110 | static inline void reset_vma_resv_huge_pages(struct vm_area_struct *vma) |
118 | { | 111 | { |
119 | } | 112 | } |