aboutsummaryrefslogtreecommitdiffstats
path: root/include/linux/fs.h
diff options
context:
space:
mode:
authorSukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>2009-03-04 15:06:34 -0500
committerAl Viro <viro@zeniv.linux.org.uk>2009-03-27 14:44:03 -0400
commita3ec947c85ec339884b30ef6a08133e9311fdae1 (patch)
treec3cc5859a6b6d8986547405b6c5bd11bc8916114 /include/linux/fs.h
parent585d3bc06f4ca57f975a5a1f698f65a45ea66225 (diff)
vfs: simple_set_mnt() should return void
simple_set_mnt() is defined as returning 'int' but always returns 0. Callers assume simple_set_mnt() never fails and don't properly cleanup if it were to _ever_ fail. For instance, get_sb_single() and get_sb_nodev() should: up_write(sb->s_unmount); deactivate_super(sb); if simple_set_mnt() fails. Since simple_set_mnt() never fails, would be cleaner if it did not return anything. [akpm@linux-foundation.org: fix build] Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> Acked-by: Serge Hallyn <serue@us.ibm.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Christoph Hellwig <hch@lst.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'include/linux/fs.h')
-rw-r--r--include/linux/fs.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/fs.h b/include/linux/fs.h
index c2c4454a268a..a7d73914a9f7 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1719,7 +1719,7 @@ struct super_block *sget(struct file_system_type *type,
1719extern int get_sb_pseudo(struct file_system_type *, char *, 1719extern int get_sb_pseudo(struct file_system_type *, char *,
1720 const struct super_operations *ops, unsigned long, 1720 const struct super_operations *ops, unsigned long,
1721 struct vfsmount *mnt); 1721 struct vfsmount *mnt);
1722extern int simple_set_mnt(struct vfsmount *mnt, struct super_block *sb); 1722extern void simple_set_mnt(struct vfsmount *mnt, struct super_block *sb);
1723int __put_super_and_need_restart(struct super_block *sb); 1723int __put_super_and_need_restart(struct super_block *sb);
1724 1724
1725/* Alas, no aliases. Too much hassle with bringing module.h everywhere */ 1725/* Alas, no aliases. Too much hassle with bringing module.h everywhere */