diff options
| author | Russell King <rmk+lkml@arm.linux.org.uk> | 2006-10-22 10:57:18 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-23 14:01:33 -0400 |
| commit | 04fed361dadb7921507a470947ac23d2f26352cf (patch) | |
| tree | 32ba7e6c1f75159914dd3311e1cdc4243a84de27 /include/linux/device.h | |
| parent | dee6515b6d12188f4b9bbe76613371f7840a8a53 (diff) | |
[PATCH] Remove __must_check for device_for_each_child()
Eliminate more __must_check madness.
The return code from device_for_each_child() depends on the values
which the helper function returns. If the helper function always
returns zero, it's utterly pointless to check the return code from
device_for_each_child().
The only code which knows if the return value should be checked is
the caller itself, so forcing the return code to always be checked
is silly. Hence, remove the __must_check annotation.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'include/linux/device.h')
| -rw-r--r-- | include/linux/device.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/device.h b/include/linux/device.h index 662e6a10144e..9d4f6a963936 100644 --- a/include/linux/device.h +++ b/include/linux/device.h | |||
| @@ -393,7 +393,7 @@ extern void device_unregister(struct device * dev); | |||
| 393 | extern void device_initialize(struct device * dev); | 393 | extern void device_initialize(struct device * dev); |
| 394 | extern int __must_check device_add(struct device * dev); | 394 | extern int __must_check device_add(struct device * dev); |
| 395 | extern void device_del(struct device * dev); | 395 | extern void device_del(struct device * dev); |
| 396 | extern int __must_check device_for_each_child(struct device *, void *, | 396 | extern int device_for_each_child(struct device *, void *, |
| 397 | int (*fn)(struct device *, void *)); | 397 | int (*fn)(struct device *, void *)); |
| 398 | extern int device_rename(struct device *dev, char *new_name); | 398 | extern int device_rename(struct device *dev, char *new_name); |
| 399 | 399 | ||
