diff options
author | Gautham R Shenoy <ego@in.ibm.com> | 2008-01-25 15:08:02 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-01-25 15:08:02 -0500 |
commit | 86ef5c9a8edd78e6bf92879f32329d89b2d55b5a (patch) | |
tree | 7bf46885326a6fdbb0c3596855408e9a5634dd3a /include/linux/cpu.h | |
parent | d221938c049f4845da13c8593132595a6b9222a8 (diff) |
cpu-hotplug: replace lock_cpu_hotplug() with get_online_cpus()
Replace all lock_cpu_hotplug/unlock_cpu_hotplug from the kernel and use
get_online_cpus and put_online_cpus instead as it highlights the
refcount semantics in these operations.
The new API guarantees protection against the cpu-hotplug operation, but
it doesn't guarantee serialized access to any of the local data
structures. Hence the changes needs to be reviewed.
In case of pseries_add_processor/pseries_remove_processor, use
cpu_maps_update_begin()/cpu_maps_update_done() as we're modifying the
cpu_present_map there.
Signed-off-by: Gautham R Shenoy <ego@in.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'include/linux/cpu.h')
-rw-r--r-- | include/linux/cpu.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/include/linux/cpu.h b/include/linux/cpu.h index a40247e4d462..3a3ff1c5cbef 100644 --- a/include/linux/cpu.h +++ b/include/linux/cpu.h | |||
@@ -100,8 +100,8 @@ static inline void cpuhotplug_mutex_unlock(struct mutex *cpu_hp_mutex) | |||
100 | mutex_unlock(cpu_hp_mutex); | 100 | mutex_unlock(cpu_hp_mutex); |
101 | } | 101 | } |
102 | 102 | ||
103 | extern void lock_cpu_hotplug(void); | 103 | extern void get_online_cpus(void); |
104 | extern void unlock_cpu_hotplug(void); | 104 | extern void put_online_cpus(void); |
105 | #define hotcpu_notifier(fn, pri) { \ | 105 | #define hotcpu_notifier(fn, pri) { \ |
106 | static struct notifier_block fn##_nb = \ | 106 | static struct notifier_block fn##_nb = \ |
107 | { .notifier_call = fn, .priority = pri }; \ | 107 | { .notifier_call = fn, .priority = pri }; \ |
@@ -118,8 +118,8 @@ static inline void cpuhotplug_mutex_lock(struct mutex *cpu_hp_mutex) | |||
118 | static inline void cpuhotplug_mutex_unlock(struct mutex *cpu_hp_mutex) | 118 | static inline void cpuhotplug_mutex_unlock(struct mutex *cpu_hp_mutex) |
119 | { } | 119 | { } |
120 | 120 | ||
121 | #define lock_cpu_hotplug() do { } while (0) | 121 | #define get_online_cpus() do { } while (0) |
122 | #define unlock_cpu_hotplug() do { } while (0) | 122 | #define put_online_cpus() do { } while (0) |
123 | #define hotcpu_notifier(fn, pri) do { (void)(fn); } while (0) | 123 | #define hotcpu_notifier(fn, pri) do { (void)(fn); } while (0) |
124 | /* These aren't inline functions due to a GCC bug. */ | 124 | /* These aren't inline functions due to a GCC bug. */ |
125 | #define register_hotcpu_notifier(nb) ({ (void)(nb); 0; }) | 125 | #define register_hotcpu_notifier(nb) ({ (void)(nb); 0; }) |