aboutsummaryrefslogtreecommitdiffstats
path: root/include/linux/async.h
diff options
context:
space:
mode:
authorDan Williams <dan.j.williams@intel.com>2012-07-09 22:33:30 -0400
committerJames Bottomley <JBottomley@Parallels.com>2012-07-20 04:07:37 -0400
commita4683487f90bfe3049686fc5c566bdc1ad03ace6 (patch)
treeb5aeadd3155256378804c04571febeee9f77c5fb /include/linux/async.h
parent2955b47d2c1983998a8c5915cb96884e67f7cb53 (diff)
[SCSI] async: make async_synchronize_full() flush all work regardless of domain
In response to an async related regression James noted: "My theory is that this is an init problem: The assumption in a lot of our code is that async_synchronize_full() waits for everything ... even the domain specific async schedules, which isn't true." ...so make this assumption true. Each domain, including the default one, registers itself on a global domain list when work is scheduled. Once all entries complete it exits that list. Waiting for the list to be empty syncs all in-flight work across all domains. Domains can opt-out of global syncing if they are declared as exclusive ASYNC_DOMAIN_EXCLUSIVE(). All stack-based domains have been declared exclusive since the domain may go out of scope as soon as the last work item completes. Statically declared domains are mostly ok, but async_unregister_domain() is there to close any theoretical races with pending async_synchronize_full waiters at module removal time. Signed-off-by: Dan Williams <dan.j.williams@intel.com> Acked-by: Arjan van de Ven <arjan@linux.intel.com> Reported-by: Meelis Roos <mroos@linux.ee> Reported-by: Eldad Zack <eldadzack@gmail.com> Tested-by: Eldad Zack <eldad@fogrefinery.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'include/linux/async.h')
-rw-r--r--include/linux/async.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/include/linux/async.h b/include/linux/async.h
index 364e7ff16c08..7a24fe9b44b4 100644
--- a/include/linux/async.h
+++ b/include/linux/async.h
@@ -46,6 +46,7 @@ struct async_domain {
46extern async_cookie_t async_schedule(async_func_ptr *ptr, void *data); 46extern async_cookie_t async_schedule(async_func_ptr *ptr, void *data);
47extern async_cookie_t async_schedule_domain(async_func_ptr *ptr, void *data, 47extern async_cookie_t async_schedule_domain(async_func_ptr *ptr, void *data,
48 struct async_domain *domain); 48 struct async_domain *domain);
49void async_unregister_domain(struct async_domain *domain);
49extern void async_synchronize_full(void); 50extern void async_synchronize_full(void);
50extern void async_synchronize_full_domain(struct async_domain *domain); 51extern void async_synchronize_full_domain(struct async_domain *domain);
51extern void async_synchronize_cookie(async_cookie_t cookie); 52extern void async_synchronize_cookie(async_cookie_t cookie);