diff options
author | Jeremy Fitzhardinge <jeremy@goop.org> | 2008-07-22 01:59:42 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-07-22 04:43:44 -0400 |
commit | 59438c9fc4f7a92c808c9049bc6b396f98bf954c (patch) | |
tree | b86d6072612075bc256038a3430d86ab04778d51 /include/asm-x86/page.h | |
parent | c2e3277f875b83e5adc34e96989d6d87ec5f80f7 (diff) |
x86: rename PTE_MASK to PTE_PFN_MASK
Rusty, in his peevish way, complained that macros defining constants
should have a name which somewhat accurately reflects the actual
purpose of the constant.
Aside from the fact that PTE_MASK gives no clue as to what's actually
being masked, and is misleadingly similar to the functionally entirely
different PMD_MASK, PUD_MASK and PGD_MASK, I don't really see what the
problem is.
But if this patch silences the incessent noise, then it will have
achieved its goal (TODO: write test-case).
Signed-off-by: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'include/asm-x86/page.h')
-rw-r--r-- | include/asm-x86/page.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/include/asm-x86/page.h b/include/asm-x86/page.h index 05d9bea2bfd5..e99fb9fe6f8a 100644 --- a/include/asm-x86/page.h +++ b/include/asm-x86/page.h | |||
@@ -18,8 +18,8 @@ | |||
18 | (ie, 32-bit PAE). */ | 18 | (ie, 32-bit PAE). */ |
19 | #define PHYSICAL_PAGE_MASK (((signed long)PAGE_MASK) & __PHYSICAL_MASK) | 19 | #define PHYSICAL_PAGE_MASK (((signed long)PAGE_MASK) & __PHYSICAL_MASK) |
20 | 20 | ||
21 | /* PTE_MASK extracts the PFN from a (pte|pmd|pud|pgd)val_t */ | 21 | /* PTE_PFN_MASK extracts the PFN from a (pte|pmd|pud|pgd)val_t */ |
22 | #define PTE_MASK ((pteval_t)PHYSICAL_PAGE_MASK) | 22 | #define PTE_PFN_MASK ((pteval_t)PHYSICAL_PAGE_MASK) |
23 | 23 | ||
24 | #define PMD_PAGE_SIZE (_AC(1, UL) << PMD_SHIFT) | 24 | #define PMD_PAGE_SIZE (_AC(1, UL) << PMD_SHIFT) |
25 | #define PMD_PAGE_MASK (~(PMD_PAGE_SIZE-1)) | 25 | #define PMD_PAGE_MASK (~(PMD_PAGE_SIZE-1)) |
@@ -146,7 +146,7 @@ static inline pteval_t native_pte_val(pte_t pte) | |||
146 | 146 | ||
147 | static inline pteval_t native_pte_flags(pte_t pte) | 147 | static inline pteval_t native_pte_flags(pte_t pte) |
148 | { | 148 | { |
149 | return native_pte_val(pte) & ~PTE_MASK; | 149 | return native_pte_val(pte) & ~PTE_PFN_MASK; |
150 | } | 150 | } |
151 | 151 | ||
152 | #define pgprot_val(x) ((x).pgprot) | 152 | #define pgprot_val(x) ((x).pgprot) |