diff options
author | David S. Miller <davem@sunset.davemloft.net> | 2007-07-12 17:16:22 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-07-16 07:04:33 -0400 |
commit | 83292e0a9c3f1c326b28fbf8cb70a8ce81a98163 (patch) | |
tree | 38794e806ba5fe8d10234c5c24a4efa22180c05c /include/asm-sparc64/vio.h | |
parent | 43fdf27470b216ebdef47e09ff83bed2f2894b13 (diff) |
[SPARC64]: Fix MD property lifetime bugs.
Property values cannot be referenced outside of
mdesc_grab()/mdesc_release() pairs. The only major
offender was the VIO bus layer, easily fixed.
Add some commentary to mdesc.h describing these rules.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/asm-sparc64/vio.h')
-rw-r--r-- | include/asm-sparc64/vio.h | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/include/asm-sparc64/vio.h b/include/asm-sparc64/vio.h index a8a53e6fc250..83c96422e9d6 100644 --- a/include/asm-sparc64/vio.h +++ b/include/asm-sparc64/vio.h | |||
@@ -264,12 +264,15 @@ static inline u32 vio_dring_avail(struct vio_dring_state *dr, | |||
264 | ((dr->prod - dr->cons) & (ring_size - 1))); | 264 | ((dr->prod - dr->cons) & (ring_size - 1))); |
265 | } | 265 | } |
266 | 266 | ||
267 | #define VIO_MAX_TYPE_LEN 64 | ||
268 | #define VIO_MAX_COMPAT_LEN 64 | ||
269 | |||
267 | struct vio_dev { | 270 | struct vio_dev { |
268 | u64 mp; | 271 | u64 mp; |
269 | struct device_node *dp; | 272 | struct device_node *dp; |
270 | 273 | ||
271 | const char *type; | 274 | char type[VIO_MAX_TYPE_LEN]; |
272 | const char *compat; | 275 | char compat[VIO_MAX_COMPAT_LEN]; |
273 | int compat_len; | 276 | int compat_len; |
274 | 277 | ||
275 | unsigned long channel_id; | 278 | unsigned long channel_id; |