diff options
author | Dave Hansen <haveblue@us.ibm.com> | 2005-06-23 03:07:37 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-06-23 12:45:00 -0400 |
commit | 408fde81c1bff15c875a3618481e93a01dcc79ea (patch) | |
tree | 89b173c5cccd69a17aa64bff8916c54bdcb2d6fe /include/asm-ppc64/mmzone.h | |
parent | 29c31a3bf257e0723423f1f0f9afd1b840434c75 (diff) |
[PATCH] remove non-DISCONTIG use of pgdat->node_mem_map
This patch effectively eliminates direct use of pgdat->node_mem_map outside
of the DISCONTIG code. On a flat memory system, these fields aren't
currently used, neither are they on a sparsemem system.
There was also a node_mem_map(nid) macro on many architectures. Its use
along with the use of ->node_mem_map itself was not consistent. It has
been removed in favor of two new, more explicit, arch-independent macros:
pgdat_page_nr(pgdat, pagenr)
nid_page_nr(nid, pagenr)
I called them "pgdat" and "nid" because we overload the term "node" to mean
"NUMA node", "DISCONTIG node" or "pg_data_t" in very confusing ways. I
believe the newer names are much clearer.
These macros can be overridden in the sparsemem case with a theoretically
slower operation using node_start_pfn and pfn_to_page(), instead. We could
make this the only behavior if people want, but I don't want to change too
much at once. One thing at a time.
This patch removes more code than it adds.
Compile tested on alpha, alpha discontig, arm, arm-discontig, i386, i386
generic, NUMAQ, Summit, ppc64, ppc64 discontig, and x86_64. Full list
here: http://sr71.net/patches/2.6.12/2.6.12-rc1-mhp2/configs/
Boot tested on NUMAQ, x86 SMP and ppc64 power4/5 LPARs.
Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
Signed-off-by: Martin J. Bligh <mbligh@aracnet.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'include/asm-ppc64/mmzone.h')
-rw-r--r-- | include/asm-ppc64/mmzone.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/include/asm-ppc64/mmzone.h b/include/asm-ppc64/mmzone.h index 0619a41a3c9d..cbfc5ecfe875 100644 --- a/include/asm-ppc64/mmzone.h +++ b/include/asm-ppc64/mmzone.h | |||
@@ -65,7 +65,6 @@ static inline int pa_to_nid(unsigned long pa) | |||
65 | */ | 65 | */ |
66 | #define kvaddr_to_nid(kaddr) pa_to_nid(__pa(kaddr)) | 66 | #define kvaddr_to_nid(kaddr) pa_to_nid(__pa(kaddr)) |
67 | 67 | ||
68 | #define node_mem_map(nid) (NODE_DATA(nid)->node_mem_map) | ||
69 | #define node_start_pfn(nid) (NODE_DATA(nid)->node_start_pfn) | 68 | #define node_start_pfn(nid) (NODE_DATA(nid)->node_start_pfn) |
70 | #define node_end_pfn(nid) (NODE_DATA(nid)->node_end_pfn) | 69 | #define node_end_pfn(nid) (NODE_DATA(nid)->node_end_pfn) |
71 | 70 | ||
@@ -76,7 +75,7 @@ static inline int pa_to_nid(unsigned long pa) | |||
76 | #define discontigmem_pfn_to_page(pfn) \ | 75 | #define discontigmem_pfn_to_page(pfn) \ |
77 | ({ \ | 76 | ({ \ |
78 | unsigned long __tmp = pfn; \ | 77 | unsigned long __tmp = pfn; \ |
79 | (node_mem_map(pfn_to_nid(__tmp)) + \ | 78 | (NODE_DATA(pfn_to_nid(__tmp))->node_mem_map + \ |
80 | node_localnr(__tmp, pfn_to_nid(__tmp))); \ | 79 | node_localnr(__tmp, pfn_to_nid(__tmp))); \ |
81 | }) | 80 | }) |
82 | 81 | ||