diff options
author | Sergei Shtylyov <sshtylyov@ru.mvista.com> | 2008-04-30 15:27:20 -0400 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2008-05-12 11:46:54 -0400 |
commit | 2091a17ff7f32432976d1eacbb79a06819d95301 (patch) | |
tree | 10743b88ff85a5be44512ffd11d8323285c4ba5f /include/asm-mips | |
parent | be1c3c1ed13f31ae8f9d5d043d96d2e56b5ee1d5 (diff) |
[MIPS] Pb1500 code style cleanup
Fix several errors and warnings given by checkpatch.pl:
- use of C99 // comments;
- printk() without KERN_* facility level;
- unnecessary braces for single-statement block;
- using simple_strtol() where strict_strtol() could be used.
In addition to these changes, also do the following:
- replace numeric literals/expressions with the matching macros;
- insert spaces between operator and its operands;
- properly indent the code and the array initializers;
- remove useless #if dirctive from board_setup();
- remove needless parentheses;
- remove unneeded type casts;
- remove excess new lines;
- make hexadecimal literals all lower case;
- remove space after the type cast's closing parenthesis;
- insert missing space before closing brace in the array initializers;
- replace spaces after the macro name with tabs in the #define directives,
also sometimes insert space there for better looks;
- fix typos/errors, capitalize acronyms, etc. in the comments;
- update MontaVista copyright;
- remove Pete Popov's old email address...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'include/asm-mips')
-rw-r--r-- | include/asm-mips/mach-pb1x00/pb1500.h | 38 |
1 files changed, 18 insertions, 20 deletions
diff --git a/include/asm-mips/mach-pb1x00/pb1500.h b/include/asm-mips/mach-pb1x00/pb1500.h index ff6d40c87a25..da51a2eb7b82 100644 --- a/include/asm-mips/mach-pb1x00/pb1500.h +++ b/include/asm-mips/mach-pb1x00/pb1500.h | |||
@@ -1,9 +1,8 @@ | |||
1 | /* | 1 | /* |
2 | * Alchemy Semi PB1500 Referrence Board | 2 | * Alchemy Semi Pb1500 Referrence Board |
3 | * | 3 | * |
4 | * Copyright 2001 MontaVista Software Inc. | 4 | * Copyright 2001, 2008 MontaVista Software Inc. |
5 | * Author: MontaVista Software, Inc. | 5 | * Author: MontaVista Software, Inc. <source@mvista.com> |
6 | * ppopov@mvista.com or source@mvista.com | ||
7 | * | 6 | * |
8 | * ######################################################################## | 7 | * ######################################################################## |
9 | * | 8 | * |
@@ -27,25 +26,24 @@ | |||
27 | #ifndef __ASM_PB1500_H | 26 | #ifndef __ASM_PB1500_H |
28 | #define __ASM_PB1500_H | 27 | #define __ASM_PB1500_H |
29 | 28 | ||
29 | #define IDENT_BOARD_REG 0xAE000000 | ||
30 | #define BOARD_STATUS_REG 0xAE000004 | ||
31 | #define PCI_BOARD_REG 0xAE000010 | ||
32 | #define PCMCIA_BOARD_REG 0xAE000010 | ||
33 | # define PC_DEASSERT_RST 0x80 | ||
34 | # define PC_DRV_EN 0x10 | ||
35 | #define PB1500_G_CONTROL 0xAE000014 | ||
36 | #define PB1500_RST_VDDI 0xAE00001C | ||
37 | #define PB1500_LEDS 0xAE000018 | ||
30 | 38 | ||
31 | #define IDENT_BOARD_REG 0xAE000000 | 39 | #define PB1500_HEX_LED 0xAF000004 |
32 | #define BOARD_STATUS_REG 0xAE000004 | 40 | #define PB1500_HEX_LED_BLANK 0xAF000008 |
33 | #define PCI_BOARD_REG 0xAE000010 | ||
34 | #define PCMCIA_BOARD_REG 0xAE000010 | ||
35 | #define PC_DEASSERT_RST 0x80 | ||
36 | #define PC_DRV_EN 0x10 | ||
37 | #define PB1500_G_CONTROL 0xAE000014 | ||
38 | #define PB1500_RST_VDDI 0xAE00001C | ||
39 | #define PB1500_LEDS 0xAE000018 | ||
40 | 41 | ||
41 | #define PB1500_HEX_LED 0xAF000004 | 42 | /* PCMCIA Pb1500 specific defines */ |
42 | #define PB1500_HEX_LED_BLANK 0xAF000008 | 43 | #define PCMCIA_MAX_SOCK 0 |
43 | 44 | #define PCMCIA_NUM_SOCKS (PCMCIA_MAX_SOCK + 1) | |
44 | /* PCMCIA PB1500 specific defines */ | ||
45 | #define PCMCIA_MAX_SOCK 0 | ||
46 | #define PCMCIA_NUM_SOCKS (PCMCIA_MAX_SOCK+1) | ||
47 | 45 | ||
48 | /* VPP/VCC */ | 46 | /* VPP/VCC */ |
49 | #define SET_VCC_VPP(VCC, VPP) (((VCC)<<2) | ((VPP)<<0)) | 47 | #define SET_VCC_VPP(VCC, VPP) (((VCC) << 2) | ((VPP) << 0)) |
50 | 48 | ||
51 | #endif /* __ASM_PB1500_H */ | 49 | #endif /* __ASM_PB1500_H */ |