diff options
author | Atsushi Nemoto <anemo@mba.ocn.ne.jp> | 2007-02-14 00:41:01 -0500 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2007-02-18 16:31:33 -0500 |
commit | 755f21bb894d3fe57017f5aa8f7ace8808fcb1e3 (patch) | |
tree | cac47514d12483302e2a4180d15c639e241b120c /include/asm-mips/compat-signal.h | |
parent | 8a03d9a498eaf02c8a118752050a5154852c13bf (diff) |
[MIPS] Fix sigset_t endianess swapping issues in 32-bit compat code.
access_ok in compat-signal.h is wrong (checking destination instead of
source) and redundant (already checked before calling this function).
Also sf_mask in struct sigframe32 should be compat_sigset_t type.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'include/asm-mips/compat-signal.h')
-rw-r--r-- | include/asm-mips/compat-signal.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/include/asm-mips/compat-signal.h b/include/asm-mips/compat-signal.h index 672077084aa1..d6e7c3b4119a 100644 --- a/include/asm-mips/compat-signal.h +++ b/include/asm-mips/compat-signal.h | |||
@@ -33,9 +33,6 @@ static inline int __copy_conv_sigset_from_user(sigset_t *d, | |||
33 | BUG_ON(sizeof(*d) != sizeof(*s)); | 33 | BUG_ON(sizeof(*d) != sizeof(*s)); |
34 | BUG_ON(_NSIG_WORDS != 2); | 34 | BUG_ON(_NSIG_WORDS != 2); |
35 | 35 | ||
36 | if (unlikely(!access_ok(VERIFY_READ, d, sizeof(*d)))) | ||
37 | return -EFAULT; | ||
38 | |||
39 | #ifdef CONFIG_CPU_BIG_ENDIAN | 36 | #ifdef CONFIG_CPU_BIG_ENDIAN |
40 | err = __get_user(u->c.sig[1], &s->sig[0]); | 37 | err = __get_user(u->c.sig[1], &s->sig[0]); |
41 | err |= __get_user(u->c.sig[0], &s->sig[1]); | 38 | err |= __get_user(u->c.sig[0], &s->sig[1]); |