diff options
author | Joerg Roedel <joerg.roedel@amd.com> | 2007-05-11 01:22:14 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-05-11 11:29:32 -0400 |
commit | 6041b57c6c99dcb59524f1bb0db0628c2689a464 (patch) | |
tree | 0509eb54f13e94b08afab9fb6bd2947fca73492c /include/asm-i386/tsc.h | |
parent | 129a84de2347002f09721cda3155ccfd19fade40 (diff) |
i386: work around miscompilation of alternatives code
A recent change makes my Dell 1501 hang on boot. It's an AMD MK-36. I use
an x86_64 kernel. It is 100% reproducible.
I debugged this problem a bit and my compiler[1]interprets the =A constraint
as %rax instead of %edx:%eax on x86_64 which causes the problem. The appended
patch provides a workaround for this and fixed the hang on my machine.
[1] gcc version 4.1.3 20070429 (prerelease) (Debian 4.1.2-5)
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
Cc: Andi Kleen <ak@suse.de>
Cc: Benny Halevy <bhalevy@panasas.com>
Cc: Pete Zaitcev <zaitcev@redhat.com>
Cc: "Joerg Roedel" <joerg.roedel@amd.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/asm-i386/tsc.h')
-rw-r--r-- | include/asm-i386/tsc.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/include/asm-i386/tsc.h b/include/asm-i386/tsc.h index 3f3c1fa000b4..62c091ffcccc 100644 --- a/include/asm-i386/tsc.h +++ b/include/asm-i386/tsc.h | |||
@@ -35,14 +35,16 @@ static inline cycles_t get_cycles(void) | |||
35 | static __always_inline cycles_t get_cycles_sync(void) | 35 | static __always_inline cycles_t get_cycles_sync(void) |
36 | { | 36 | { |
37 | unsigned long long ret; | 37 | unsigned long long ret; |
38 | unsigned eax; | 38 | unsigned eax, edx; |
39 | 39 | ||
40 | /* | 40 | /* |
41 | * Use RDTSCP if possible; it is guaranteed to be synchronous | 41 | * Use RDTSCP if possible; it is guaranteed to be synchronous |
42 | * and doesn't cause a VMEXIT on Hypervisors | 42 | * and doesn't cause a VMEXIT on Hypervisors |
43 | */ | 43 | */ |
44 | alternative_io(ASM_NOP3, ".byte 0x0f,0x01,0xf9", X86_FEATURE_RDTSCP, | 44 | alternative_io(ASM_NOP3, ".byte 0x0f,0x01,0xf9", X86_FEATURE_RDTSCP, |
45 | "=A" (ret), "0" (0ULL) : "ecx", "memory"); | 45 | ASM_OUTPUT2("=a" (eax), "=d" (edx)), |
46 | "a" (0U), "d" (0U) : "ecx", "memory"); | ||
47 | ret = (((unsigned long long)edx) << 32) | ((unsigned long long)eax); | ||
46 | if (ret) | 48 | if (ret) |
47 | return ret; | 49 | return ret; |
48 | 50 | ||