diff options
author | Zachary Amsden <zach@vmware.com> | 2006-10-01 02:29:36 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-01 03:39:34 -0400 |
commit | d6d861e3c963b4077c83e078e3e300c4b81f93e7 (patch) | |
tree | 842071ac905575aa0ea8bedd3a1ac5db29416bcf /include/asm-i386/pgtable.h | |
parent | 23002d88be309a7c78db69363c9d933a29a3b0bb (diff) |
[PATCH] paravirt: optimize ptep establish for pae
The ptep_establish macro is only used on user-level PTEs, for P->P mapping
changes. Since these always happen under protection of the pagetable lock,
the strong synchronization of a 64-bit cmpxchg is not needed, in fact, not
even a lock prefix needs to be used. We can simply instead clear the P-bit,
followed by a normal set. The write ordering is still important to avoid the
possibility of the TLB snooping a partially written PTE and getting a bad
mapping installed.
Signed-off-by: Zachary Amsden <zach@vmware.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Jeremy Fitzhardinge <jeremy@xensource.com>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'include/asm-i386/pgtable.h')
-rw-r--r-- | include/asm-i386/pgtable.h | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/include/asm-i386/pgtable.h b/include/asm-i386/pgtable.h index ee9696d2f67f..8cb708a6bed0 100644 --- a/include/asm-i386/pgtable.h +++ b/include/asm-i386/pgtable.h | |||
@@ -269,6 +269,17 @@ do { \ | |||
269 | #define __HAVE_ARCH_PTEP_TEST_AND_CLEAR_DIRTY | 269 | #define __HAVE_ARCH_PTEP_TEST_AND_CLEAR_DIRTY |
270 | #define __HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG | 270 | #define __HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG |
271 | 271 | ||
272 | /* | ||
273 | * Rules for using ptep_establish: the pte MUST be a user pte, and | ||
274 | * must be a present->present transition. | ||
275 | */ | ||
276 | #define __HAVE_ARCH_PTEP_ESTABLISH | ||
277 | #define ptep_establish(vma, address, ptep, pteval) \ | ||
278 | do { \ | ||
279 | set_pte_present((vma)->vm_mm, address, ptep, pteval); \ | ||
280 | flush_tlb_page(vma, address); \ | ||
281 | } while (0) | ||
282 | |||
272 | #define __HAVE_ARCH_PTEP_CLEAR_DIRTY_FLUSH | 283 | #define __HAVE_ARCH_PTEP_CLEAR_DIRTY_FLUSH |
273 | #define ptep_clear_flush_dirty(vma, address, ptep) \ | 284 | #define ptep_clear_flush_dirty(vma, address, ptep) \ |
274 | ({ \ | 285 | ({ \ |