diff options
author | Jeremy Fitzhardinge <jeremy@goop.org> | 2007-05-02 13:27:15 -0400 |
---|---|---|
committer | Andi Kleen <andi@basil.nowhere.org> | 2007-05-02 13:27:15 -0400 |
commit | 4cdd9c8931767e1c56a51a1078d33a8c340f4405 (patch) | |
tree | bf8b49009011bb2dffe9683dffdcbfe3b90375f9 /include/asm-i386/paravirt.h | |
parent | 1a45b7aaa5051489b46afbc48509bd91f8b4a1ba (diff) |
[PATCH] i386: PARAVIRT: drop unused ptep_get_and_clear
In shadow mode hypervisors, ptep_get_and_clear achieves the desired
purpose of keeping the shadows in sync by issuing a native_get_and_clear,
followed by a call to pte_update, which indicates the PTE has been
modified.
Direct mode hypervisors (Xen) have no need for this anyway, and will trap
the update using writable pagetables.
This means no hypervisor makes use of ptep_get_and_clear; there is no
reason to have it in the paravirt-ops structure. Change confusing
terminology about raw vs. native functions into consistent use of
native_pte_xxx for operations which do not invoke paravirt-ops.
Signed-off-by: Zachary Amsden <zach@vmware.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Diffstat (limited to 'include/asm-i386/paravirt.h')
-rw-r--r-- | include/asm-i386/paravirt.h | 13 |
1 files changed, 1 insertions, 12 deletions
diff --git a/include/asm-i386/paravirt.h b/include/asm-i386/paravirt.h index 2ba18963e114..e2e7f98723c5 100644 --- a/include/asm-i386/paravirt.h +++ b/include/asm-i386/paravirt.h | |||
@@ -188,8 +188,6 @@ struct paravirt_ops | |||
188 | void (*pte_update_defer)(struct mm_struct *mm, | 188 | void (*pte_update_defer)(struct mm_struct *mm, |
189 | unsigned long addr, pte_t *ptep); | 189 | unsigned long addr, pte_t *ptep); |
190 | 190 | ||
191 | pte_t (*ptep_get_and_clear)(pte_t *ptep); | ||
192 | |||
193 | #ifdef CONFIG_HIGHPTE | 191 | #ifdef CONFIG_HIGHPTE |
194 | void *(*kmap_atomic_pte)(struct page *page, enum km_type type); | 192 | void *(*kmap_atomic_pte)(struct page *page, enum km_type type); |
195 | #endif | 193 | #endif |
@@ -859,12 +857,8 @@ static inline void pmd_clear(pmd_t *pmdp) | |||
859 | PVOP_VCALL1(pmd_clear, pmdp); | 857 | PVOP_VCALL1(pmd_clear, pmdp); |
860 | } | 858 | } |
861 | 859 | ||
862 | static inline pte_t raw_ptep_get_and_clear(pte_t *p) | ||
863 | { | ||
864 | unsigned long long val = PVOP_CALL1(unsigned long long, ptep_get_and_clear, p); | ||
865 | return (pte_t) { val, val >> 32 }; | ||
866 | } | ||
867 | #else /* !CONFIG_X86_PAE */ | 860 | #else /* !CONFIG_X86_PAE */ |
861 | |||
868 | static inline pte_t __pte(unsigned long val) | 862 | static inline pte_t __pte(unsigned long val) |
869 | { | 863 | { |
870 | return (pte_t) { PVOP_CALL1(unsigned long, make_pte, val) }; | 864 | return (pte_t) { PVOP_CALL1(unsigned long, make_pte, val) }; |
@@ -900,11 +894,6 @@ static inline void set_pmd(pmd_t *pmdp, pmd_t pmdval) | |||
900 | { | 894 | { |
901 | PVOP_VCALL2(set_pmd, pmdp, pmdval.pud.pgd.pgd); | 895 | PVOP_VCALL2(set_pmd, pmdp, pmdval.pud.pgd.pgd); |
902 | } | 896 | } |
903 | |||
904 | static inline pte_t raw_ptep_get_and_clear(pte_t *p) | ||
905 | { | ||
906 | return (pte_t) { PVOP_CALL1(unsigned long, ptep_get_and_clear, p) }; | ||
907 | } | ||
908 | #endif /* CONFIG_X86_PAE */ | 897 | #endif /* CONFIG_X86_PAE */ |
909 | 898 | ||
910 | #define __HAVE_ARCH_ENTER_LAZY_CPU_MODE | 899 | #define __HAVE_ARCH_ENTER_LAZY_CPU_MODE |