diff options
author | Arnaud Patard <arnaud.patard@rtp-net.org> | 2006-12-27 16:56:44 -0500 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2006-12-30 12:05:07 -0500 |
commit | 431d2cd99f9721ad09f859dc65895f30385cc5c6 (patch) | |
tree | 435519efb5f8633243decae79095e56ba4ec36bb /include/asm-arm/arch-s3c2410 | |
parent | eb3b4783ba664fd80d337ae6649f6489493b2387 (diff) |
[ARM] 4073/1: Prevent s3c24xx drivers from including asm/arch/hardware.h and asm/arch/irqs.h
As reminded in http://lkml.org/lkml/2006/12/23/26, one should use
asm/hardware.h and asm/irq.h but absent-minded devs like me tends to use
asm/arch/hardware.h and/or asm/arch/irqs.h.
This patch aims at preventing such things.
In order to make it work, I had to modify asm-arm/irq.h too so that it can
be included from assembly files.
Also, as a side effect, I had to modify some headers who were using the
asm/arch/hardware.h or asm/arch/irqs.h.
Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'include/asm-arm/arch-s3c2410')
-rw-r--r-- | include/asm-arm/arch-s3c2410/dma.h | 2 | ||||
-rw-r--r-- | include/asm-arm/arch-s3c2410/entry-macro.S | 2 | ||||
-rw-r--r-- | include/asm-arm/arch-s3c2410/hardware.h | 4 | ||||
-rw-r--r-- | include/asm-arm/arch-s3c2410/irqs.h | 3 |
4 files changed, 9 insertions, 2 deletions
diff --git a/include/asm-arm/arch-s3c2410/dma.h b/include/asm-arm/arch-s3c2410/dma.h index 7ac224836971..58ffa7ba3c88 100644 --- a/include/asm-arm/arch-s3c2410/dma.h +++ b/include/asm-arm/arch-s3c2410/dma.h | |||
@@ -14,7 +14,7 @@ | |||
14 | #define __ASM_ARCH_DMA_H __FILE__ | 14 | #define __ASM_ARCH_DMA_H __FILE__ |
15 | 15 | ||
16 | #include <linux/sysdev.h> | 16 | #include <linux/sysdev.h> |
17 | #include "hardware.h" | 17 | #include <asm/hardware.h> |
18 | 18 | ||
19 | /* | 19 | /* |
20 | * This is the maximum DMA address(physical address) that can be DMAd to. | 20 | * This is the maximum DMA address(physical address) that can be DMAd to. |
diff --git a/include/asm-arm/arch-s3c2410/entry-macro.S b/include/asm-arm/arch-s3c2410/entry-macro.S index e09a6b8ec153..1eb4e6b8d249 100644 --- a/include/asm-arm/arch-s3c2410/entry-macro.S +++ b/include/asm-arm/arch-s3c2410/entry-macro.S | |||
@@ -20,7 +20,7 @@ | |||
20 | #define INTOFFSET (0x14) | 20 | #define INTOFFSET (0x14) |
21 | 21 | ||
22 | #include <asm/hardware.h> | 22 | #include <asm/hardware.h> |
23 | #include <asm/arch/irqs.h> | 23 | #include <asm/irq.h> |
24 | 24 | ||
25 | .macro get_irqnr_and_base, irqnr, irqstat, base, tmp | 25 | .macro get_irqnr_and_base, irqnr, irqstat, base, tmp |
26 | 26 | ||
diff --git a/include/asm-arm/arch-s3c2410/hardware.h b/include/asm-arm/arch-s3c2410/hardware.h index 729565e5cdf4..6dadf58ff984 100644 --- a/include/asm-arm/arch-s3c2410/hardware.h +++ b/include/asm-arm/arch-s3c2410/hardware.h | |||
@@ -13,6 +13,10 @@ | |||
13 | #ifndef __ASM_ARCH_HARDWARE_H | 13 | #ifndef __ASM_ARCH_HARDWARE_H |
14 | #define __ASM_ARCH_HARDWARE_H | 14 | #define __ASM_ARCH_HARDWARE_H |
15 | 15 | ||
16 | #ifndef __ASM_HARDWARE_H | ||
17 | #error "Do not include this directly, instead #include <asm/hardware.h>" | ||
18 | #endif | ||
19 | |||
16 | #ifndef __ASSEMBLY__ | 20 | #ifndef __ASSEMBLY__ |
17 | 21 | ||
18 | /* external functions for GPIO support | 22 | /* external functions for GPIO support |
diff --git a/include/asm-arm/arch-s3c2410/irqs.h b/include/asm-arm/arch-s3c2410/irqs.h index 39a69829d163..4b7cff456c4e 100644 --- a/include/asm-arm/arch-s3c2410/irqs.h +++ b/include/asm-arm/arch-s3c2410/irqs.h | |||
@@ -12,6 +12,9 @@ | |||
12 | #ifndef __ASM_ARCH_IRQS_H | 12 | #ifndef __ASM_ARCH_IRQS_H |
13 | #define __ASM_ARCH_IRQS_H __FILE__ | 13 | #define __ASM_ARCH_IRQS_H __FILE__ |
14 | 14 | ||
15 | #ifndef __ASM_ARM_IRQ_H | ||
16 | #error "Do not include this directly, instead #include <asm/irq.h>" | ||
17 | #endif | ||
15 | 18 | ||
16 | /* we keep the first set of CPU IRQs out of the range of | 19 | /* we keep the first set of CPU IRQs out of the range of |
17 | * the ISA space, so that the PC104 has them to itself | 20 | * the ISA space, so that the PC104 has them to itself |