diff options
author | Jan Kara <jack@suse.cz> | 2013-07-05 21:57:22 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2013-07-05 21:57:22 -0400 |
commit | 27d7c4ed1f7dfa3fc462e870dc60a4c9c2253f3e (patch) | |
tree | 3fee0d413a5bbf4adcd3bdccac40ba4b4ba3b2a3 /fs | |
parent | 6ae06ff51eab5dcbbf959b05ce0f11003a305ba5 (diff) |
ext4: silence warning in ext4_writepages()
The loop in mpage_map_and_submit_extent() is guaranteed to always run
at least once since the caller of mpage_map_and_submit_extent() makes
sure map->m_len > 0. So make that explicit using do-while instead of
pure while which also silences the compiler warning about
uninitialized 'err' variable.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/ext4/inode.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 0188e65e1f58..19a1643cbdfa 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
@@ -2163,7 +2163,7 @@ static int mpage_map_and_submit_extent(handle_t *handle, | |||
2163 | 2163 | ||
2164 | mpd->io_submit.io_end->offset = | 2164 | mpd->io_submit.io_end->offset = |
2165 | ((loff_t)map->m_lblk) << inode->i_blkbits; | 2165 | ((loff_t)map->m_lblk) << inode->i_blkbits; |
2166 | while (map->m_len) { | 2166 | do { |
2167 | err = mpage_map_one_extent(handle, mpd); | 2167 | err = mpage_map_one_extent(handle, mpd); |
2168 | if (err < 0) { | 2168 | if (err < 0) { |
2169 | struct super_block *sb = inode->i_sb; | 2169 | struct super_block *sb = inode->i_sb; |
@@ -2201,7 +2201,7 @@ static int mpage_map_and_submit_extent(handle_t *handle, | |||
2201 | err = mpage_map_and_submit_buffers(mpd); | 2201 | err = mpage_map_and_submit_buffers(mpd); |
2202 | if (err < 0) | 2202 | if (err < 0) |
2203 | return err; | 2203 | return err; |
2204 | } | 2204 | } while (map->m_len); |
2205 | 2205 | ||
2206 | /* Update on-disk size after IO is submitted */ | 2206 | /* Update on-disk size after IO is submitted */ |
2207 | disksize = ((loff_t)mpd->first_page) << PAGE_CACHE_SHIFT; | 2207 | disksize = ((loff_t)mpd->first_page) << PAGE_CACHE_SHIFT; |