aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorJoel Becker <joel.becker@oracle.com>2008-10-09 20:20:33 -0400
committerMark Fasheh <mfasheh@suse.com>2008-10-14 14:58:11 -0400
commit5e0b3dec0107540244ba343f983ef4f972db20de (patch)
treeb279c196c84abc01b61fcd70ec7aaa7f6e74e78b /fs
parent07446dc72cffcc6e2672d0e54061dcd1858725ba (diff)
ocfs2: Kill the last naked wait_on_buffer() for cached reads.
ocfs2's cached buffer I/O goes through ocfs2_read_block(s)(). dir.c had a naked wait_on_buffer() to wait for some readahead, but it should use ocfs2_read_block() instead. Signed-off-by: Joel Becker <joel.becker@oracle.com> Signed-off-by: Mark Fasheh <mfasheh@suse.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/ocfs2/dir.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
index ef2bb856f731..60be3ba1f5dc 100644
--- a/fs/ocfs2/dir.c
+++ b/fs/ocfs2/dir.c
@@ -302,14 +302,13 @@ restart:
302 } 302 }
303 if ((bh = bh_use[ra_ptr++]) == NULL) 303 if ((bh = bh_use[ra_ptr++]) == NULL)
304 goto next; 304 goto next;
305 wait_on_buffer(bh); 305 if (ocfs2_read_block(dir, block, &bh)) {
306 if (!buffer_uptodate(bh)) { 306 /* read error, skip block & hope for the best.
307 /* read error, skip block & hope for the best */ 307 * ocfs2_read_block() has released the bh. */
308 ocfs2_error(dir->i_sb, "reading directory %llu, " 308 ocfs2_error(dir->i_sb, "reading directory %llu, "
309 "offset %lu\n", 309 "offset %lu\n",
310 (unsigned long long)OCFS2_I(dir)->ip_blkno, 310 (unsigned long long)OCFS2_I(dir)->ip_blkno,
311 block); 311 block);
312 brelse(bh);
313 goto next; 312 goto next;
314 } 313 }
315 i = ocfs2_search_dirblock(bh, dir, name, namelen, 314 i = ocfs2_search_dirblock(bh, dir, name, namelen,