diff options
author | J. Bruce Fields <bfields@redhat.com> | 2012-08-14 16:16:34 -0400 |
---|---|---|
committer | J. Bruce Fields <bfields@redhat.com> | 2012-08-21 17:07:49 -0400 |
commit | 38af2cabb6285e1c44d2cc3165f150d2aa5f38a8 (patch) | |
tree | 92d32f93a16adabcc016e87a28bf0ea6e6df4a12 /fs | |
parent | 39b553013719fe6495cf5e496b827b2d712e4265 (diff) |
nfsd: remove redundant "port" argument
"port" in all these functions is always NFS_PORT.
nfsd can already be run on a nonstandard port using the "nfsd/portlist"
interface.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/nfsd/nfsctl.c | 2 | ||||
-rw-r--r-- | fs/nfsd/nfsd.h | 2 | ||||
-rw-r--r-- | fs/nfsd/nfssvc.c | 14 |
3 files changed, 9 insertions, 9 deletions
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index 009632a68f31..89be13c9e769 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c | |||
@@ -406,7 +406,7 @@ static ssize_t write_threads(struct file *file, char *buf, size_t size) | |||
406 | return rv; | 406 | return rv; |
407 | if (newthreads < 0) | 407 | if (newthreads < 0) |
408 | return -EINVAL; | 408 | return -EINVAL; |
409 | rv = nfsd_svc(NFS_PORT, newthreads); | 409 | rv = nfsd_svc(newthreads); |
410 | if (rv < 0) | 410 | if (rv < 0) |
411 | return rv; | 411 | return rv; |
412 | } else | 412 | } else |
diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h index 36243a33f193..80d5ce40aadb 100644 --- a/fs/nfsd/nfsd.h +++ b/fs/nfsd/nfsd.h | |||
@@ -65,7 +65,7 @@ extern const struct seq_operations nfs_exports_op; | |||
65 | /* | 65 | /* |
66 | * Function prototypes. | 66 | * Function prototypes. |
67 | */ | 67 | */ |
68 | int nfsd_svc(unsigned short port, int nrservs); | 68 | int nfsd_svc(int nrservs); |
69 | int nfsd_dispatch(struct svc_rqst *rqstp, __be32 *statp); | 69 | int nfsd_dispatch(struct svc_rqst *rqstp, __be32 *statp); |
70 | 70 | ||
71 | int nfsd_nrthreads(void); | 71 | int nfsd_nrthreads(void); |
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c index 240473cb708f..dd2b7343d741 100644 --- a/fs/nfsd/nfssvc.c +++ b/fs/nfsd/nfssvc.c | |||
@@ -183,18 +183,18 @@ int nfsd_nrthreads(void) | |||
183 | return rv; | 183 | return rv; |
184 | } | 184 | } |
185 | 185 | ||
186 | static int nfsd_init_socks(int port) | 186 | static int nfsd_init_socks(void) |
187 | { | 187 | { |
188 | int error; | 188 | int error; |
189 | if (!list_empty(&nfsd_serv->sv_permsocks)) | 189 | if (!list_empty(&nfsd_serv->sv_permsocks)) |
190 | return 0; | 190 | return 0; |
191 | 191 | ||
192 | error = svc_create_xprt(nfsd_serv, "udp", &init_net, PF_INET, port, | 192 | error = svc_create_xprt(nfsd_serv, "udp", &init_net, PF_INET, NFS_PORT, |
193 | SVC_SOCK_DEFAULTS); | 193 | SVC_SOCK_DEFAULTS); |
194 | if (error < 0) | 194 | if (error < 0) |
195 | return error; | 195 | return error; |
196 | 196 | ||
197 | error = svc_create_xprt(nfsd_serv, "tcp", &init_net, PF_INET, port, | 197 | error = svc_create_xprt(nfsd_serv, "tcp", &init_net, PF_INET, NFS_PORT, |
198 | SVC_SOCK_DEFAULTS); | 198 | SVC_SOCK_DEFAULTS); |
199 | if (error < 0) | 199 | if (error < 0) |
200 | return error; | 200 | return error; |
@@ -204,7 +204,7 @@ static int nfsd_init_socks(int port) | |||
204 | 204 | ||
205 | static bool nfsd_up = false; | 205 | static bool nfsd_up = false; |
206 | 206 | ||
207 | static int nfsd_startup(unsigned short port, int nrservs) | 207 | static int nfsd_startup(int nrservs) |
208 | { | 208 | { |
209 | int ret; | 209 | int ret; |
210 | 210 | ||
@@ -218,7 +218,7 @@ static int nfsd_startup(unsigned short port, int nrservs) | |||
218 | ret = nfsd_racache_init(2*nrservs); | 218 | ret = nfsd_racache_init(2*nrservs); |
219 | if (ret) | 219 | if (ret) |
220 | return ret; | 220 | return ret; |
221 | ret = nfsd_init_socks(port); | 221 | ret = nfsd_init_socks(); |
222 | if (ret) | 222 | if (ret) |
223 | goto out_racache; | 223 | goto out_racache; |
224 | ret = lockd_up(&init_net); | 224 | ret = lockd_up(&init_net); |
@@ -436,7 +436,7 @@ int nfsd_set_nrthreads(int n, int *nthreads) | |||
436 | * this is the first time nrservs is nonzero. | 436 | * this is the first time nrservs is nonzero. |
437 | */ | 437 | */ |
438 | int | 438 | int |
439 | nfsd_svc(unsigned short port, int nrservs) | 439 | nfsd_svc(int nrservs) |
440 | { | 440 | { |
441 | int error; | 441 | int error; |
442 | bool nfsd_up_before; | 442 | bool nfsd_up_before; |
@@ -458,7 +458,7 @@ nfsd_svc(unsigned short port, int nrservs) | |||
458 | 458 | ||
459 | nfsd_up_before = nfsd_up; | 459 | nfsd_up_before = nfsd_up; |
460 | 460 | ||
461 | error = nfsd_startup(port, nrservs); | 461 | error = nfsd_startup(nrservs); |
462 | if (error) | 462 | if (error) |
463 | goto out_destroy; | 463 | goto out_destroy; |
464 | error = svc_set_num_threads(nfsd_serv, NULL, nrservs); | 464 | error = svc_set_num_threads(nfsd_serv, NULL, nrservs); |