diff options
author | David Sterba <dsterba@suse.cz> | 2015-02-16 12:44:34 -0500 |
---|---|---|
committer | David Sterba <dsterba@suse.cz> | 2015-02-16 12:48:47 -0500 |
commit | a4f3d2c4efe2628329249b64fd5799468e025b9d (patch) | |
tree | f1d56e1e6945e20d98b1102591bf427d1dc1c37c /fs | |
parent | 6f0110581911623df08bf4b65fdef4548ebcda0a (diff) |
btrfs: cleanup, reduce temporary variables in btrfs_read_roots
Signed-off-by: David Sterba <dsterba@suse.cz>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/btrfs/disk-io.c | 54 |
1 files changed, 25 insertions, 29 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 29cb50b4981e..f770e8b5cb86 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c | |||
@@ -2357,11 +2357,7 @@ static int btrfs_replay_log(struct btrfs_fs_info *fs_info, | |||
2357 | static int btrfs_read_roots(struct btrfs_fs_info *fs_info, | 2357 | static int btrfs_read_roots(struct btrfs_fs_info *fs_info, |
2358 | struct btrfs_root *tree_root) | 2358 | struct btrfs_root *tree_root) |
2359 | { | 2359 | { |
2360 | struct btrfs_root *extent_root; | 2360 | struct btrfs_root *root; |
2361 | struct btrfs_root *dev_root; | ||
2362 | struct btrfs_root *csum_root; | ||
2363 | struct btrfs_root *quota_root; | ||
2364 | struct btrfs_root *uuid_root; | ||
2365 | struct btrfs_key location; | 2361 | struct btrfs_key location; |
2366 | int ret; | 2362 | int ret; |
2367 | 2363 | ||
@@ -2369,45 +2365,45 @@ static int btrfs_read_roots(struct btrfs_fs_info *fs_info, | |||
2369 | location.type = BTRFS_ROOT_ITEM_KEY; | 2365 | location.type = BTRFS_ROOT_ITEM_KEY; |
2370 | location.offset = 0; | 2366 | location.offset = 0; |
2371 | 2367 | ||
2372 | extent_root = btrfs_read_tree_root(tree_root, &location); | 2368 | root = btrfs_read_tree_root(tree_root, &location); |
2373 | if (IS_ERR(extent_root)) | 2369 | if (IS_ERR(root)) |
2374 | return PTR_ERR(extent_root); | 2370 | return PTR_ERR(root); |
2375 | set_bit(BTRFS_ROOT_TRACK_DIRTY, &extent_root->state); | 2371 | set_bit(BTRFS_ROOT_TRACK_DIRTY, &root->state); |
2376 | fs_info->extent_root = extent_root; | 2372 | fs_info->extent_root = root; |
2377 | 2373 | ||
2378 | location.objectid = BTRFS_DEV_TREE_OBJECTID; | 2374 | location.objectid = BTRFS_DEV_TREE_OBJECTID; |
2379 | dev_root = btrfs_read_tree_root(tree_root, &location); | 2375 | root = btrfs_read_tree_root(tree_root, &location); |
2380 | if (IS_ERR(dev_root)) | 2376 | if (IS_ERR(root)) |
2381 | return PTR_ERR(dev_root); | 2377 | return PTR_ERR(root); |
2382 | set_bit(BTRFS_ROOT_TRACK_DIRTY, &dev_root->state); | 2378 | set_bit(BTRFS_ROOT_TRACK_DIRTY, &root->state); |
2383 | fs_info->dev_root = dev_root; | 2379 | fs_info->dev_root = root; |
2384 | btrfs_init_devices_late(fs_info); | 2380 | btrfs_init_devices_late(fs_info); |
2385 | 2381 | ||
2386 | location.objectid = BTRFS_CSUM_TREE_OBJECTID; | 2382 | location.objectid = BTRFS_CSUM_TREE_OBJECTID; |
2387 | csum_root = btrfs_read_tree_root(tree_root, &location); | 2383 | root = btrfs_read_tree_root(tree_root, &location); |
2388 | if (IS_ERR(csum_root)) | 2384 | if (IS_ERR(root)) |
2389 | return PTR_ERR(csum_root); | 2385 | return PTR_ERR(root); |
2390 | set_bit(BTRFS_ROOT_TRACK_DIRTY, &csum_root->state); | 2386 | set_bit(BTRFS_ROOT_TRACK_DIRTY, &root->state); |
2391 | fs_info->csum_root = csum_root; | 2387 | fs_info->csum_root = root; |
2392 | 2388 | ||
2393 | location.objectid = BTRFS_QUOTA_TREE_OBJECTID; | 2389 | location.objectid = BTRFS_QUOTA_TREE_OBJECTID; |
2394 | quota_root = btrfs_read_tree_root(tree_root, &location); | 2390 | root = btrfs_read_tree_root(tree_root, &location); |
2395 | if (!IS_ERR(quota_root)) { | 2391 | if (!IS_ERR(root)) { |
2396 | set_bit(BTRFS_ROOT_TRACK_DIRTY, "a_root->state); | 2392 | set_bit(BTRFS_ROOT_TRACK_DIRTY, &root->state); |
2397 | fs_info->quota_enabled = 1; | 2393 | fs_info->quota_enabled = 1; |
2398 | fs_info->pending_quota_state = 1; | 2394 | fs_info->pending_quota_state = 1; |
2399 | fs_info->quota_root = quota_root; | 2395 | fs_info->quota_root = root; |
2400 | } | 2396 | } |
2401 | 2397 | ||
2402 | location.objectid = BTRFS_UUID_TREE_OBJECTID; | 2398 | location.objectid = BTRFS_UUID_TREE_OBJECTID; |
2403 | uuid_root = btrfs_read_tree_root(tree_root, &location); | 2399 | root = btrfs_read_tree_root(tree_root, &location); |
2404 | if (IS_ERR(uuid_root)) { | 2400 | if (IS_ERR(root)) { |
2405 | ret = PTR_ERR(uuid_root); | 2401 | ret = PTR_ERR(root); |
2406 | if (ret != -ENOENT) | 2402 | if (ret != -ENOENT) |
2407 | return ret; | 2403 | return ret; |
2408 | } else { | 2404 | } else { |
2409 | set_bit(BTRFS_ROOT_TRACK_DIRTY, &uuid_root->state); | 2405 | set_bit(BTRFS_ROOT_TRACK_DIRTY, &root->state); |
2410 | fs_info->uuid_root = uuid_root; | 2406 | fs_info->uuid_root = root; |
2411 | } | 2407 | } |
2412 | 2408 | ||
2413 | return 0; | 2409 | return 0; |