diff options
author | Wu Fengguang <fengguang.wu@gmail.com> | 2009-12-03 07:54:25 -0500 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2009-12-03 07:54:25 -0500 |
commit | 0d99519efef15fd0cf84a849492c7b1deee1e4b7 (patch) | |
tree | d0f9d922ef73f6b9c4529826878f3cc5567848fd /fs | |
parent | b17621fed6aa039387e35f9b4d34d98f213e5673 (diff) |
writeback: remove unused nonblocking and congestion checks
- no one is calling wb_writeback and write_cache_pages with
wbc.nonblocking=1 any more
- lumpy pageout will want to do nonblocking writeback without the
congestion wait
So remove the congestion checks as suggested by Chris.
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Cc: Chris Mason <chris.mason@oracle.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Alex Elder <aelder@sgi.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/fs-writeback.c | 9 | ||||
-rw-r--r-- | fs/xfs/linux-2.6/xfs_aops.c | 9 |
2 files changed, 1 insertions, 17 deletions
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 0793961f7699..49bc1b8e8f19 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c | |||
@@ -639,14 +639,6 @@ static void writeback_inodes_wb(struct bdi_writeback *wb, | |||
639 | continue; | 639 | continue; |
640 | } | 640 | } |
641 | 641 | ||
642 | if (wbc->nonblocking && bdi_write_congested(wb->bdi)) { | ||
643 | wbc->encountered_congestion = 1; | ||
644 | if (!is_blkdev_sb) | ||
645 | break; /* Skip a congested fs */ | ||
646 | requeue_io(inode); | ||
647 | continue; /* Skip a congested blockdev */ | ||
648 | } | ||
649 | |||
650 | /* | 642 | /* |
651 | * Was this inode dirtied after sync_sb_inodes was called? | 643 | * Was this inode dirtied after sync_sb_inodes was called? |
652 | * This keeps sync from extra jobs and livelock. | 644 | * This keeps sync from extra jobs and livelock. |
@@ -770,7 +762,6 @@ static long wb_writeback(struct bdi_writeback *wb, | |||
770 | break; | 762 | break; |
771 | 763 | ||
772 | wbc.more_io = 0; | 764 | wbc.more_io = 0; |
773 | wbc.encountered_congestion = 0; | ||
774 | wbc.nr_to_write = MAX_WRITEBACK_PAGES; | 765 | wbc.nr_to_write = MAX_WRITEBACK_PAGES; |
775 | wbc.pages_skipped = 0; | 766 | wbc.pages_skipped = 0; |
776 | writeback_inodes_wb(wb, &wbc); | 767 | writeback_inodes_wb(wb, &wbc); |
diff --git a/fs/xfs/linux-2.6/xfs_aops.c b/fs/xfs/linux-2.6/xfs_aops.c index c2e30eea74dc..70f989895d15 100644 --- a/fs/xfs/linux-2.6/xfs_aops.c +++ b/fs/xfs/linux-2.6/xfs_aops.c | |||
@@ -904,16 +904,9 @@ xfs_convert_page( | |||
904 | 904 | ||
905 | if (startio) { | 905 | if (startio) { |
906 | if (count) { | 906 | if (count) { |
907 | struct backing_dev_info *bdi; | ||
908 | |||
909 | bdi = inode->i_mapping->backing_dev_info; | ||
910 | wbc->nr_to_write--; | 907 | wbc->nr_to_write--; |
911 | if (bdi_write_congested(bdi)) { | 908 | if (wbc->nr_to_write <= 0) |
912 | wbc->encountered_congestion = 1; | ||
913 | done = 1; | ||
914 | } else if (wbc->nr_to_write <= 0) { | ||
915 | done = 1; | 909 | done = 1; |
916 | } | ||
917 | } | 910 | } |
918 | xfs_start_page_writeback(page, !page_dirty, count); | 911 | xfs_start_page_writeback(page, !page_dirty, count); |
919 | } | 912 | } |