aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorBenjamin Marzinski <bmarzins@redhat.com>2007-06-01 15:21:38 -0400
committerSteven Whitehouse <swhiteho@redhat.com>2007-07-09 03:23:08 -0400
commitddf4b426aababdae4cb96326d7aeb9d119f42c50 (patch)
tree26aceb619f34e7b58e50a0ad0dc4db4e69664edc /fs
parentafb853fb4eec380b492a3c369f837359359c28e8 (diff)
[GFS2] fix jdata issues
This is a patch for the first three issues of RHBZ #238162 The first issue is that when you allocate a new page for a file, it will not start off uptodate. This makes sense, since you haven't written anything to that part of the file yet. Unfortunately, gfs2_pin() checks to make sure that the buffers are uptodate. The solution to this is to mark the buffers uptodate in gfs2_commit_write(), after they have been zeroed out and have the data written into them. I'm pretty confident with this fix, although it's not completely obvious that there is no problem with marking the buffers uptodate here. The second issue is simply that you can try to pin a data buffer that is already on the incore log, and thus, already pinned. This patch checks to see if this buffer is already on the log, and exits databuf_lo_add() if it is, just like buf_lo_add() does. The third issue is that gfs2_log_flush() doesn't do it's block accounting correctly. Both metadata and journaled data are logged, but gfs2_log_flush() only compares the number of metadata blocks with the number of blocks to commit to the ondisk journal. This patch also counts the journaled data blocks. Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/gfs2/log.c2
-rw-r--r--fs/gfs2/lops.c2
-rw-r--r--fs/gfs2/ops_address.c2
3 files changed, 5 insertions, 1 deletions
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index 586923d24e6e..1fb846fc545e 100644
--- a/fs/gfs2/log.c
+++ b/fs/gfs2/log.c
@@ -566,7 +566,7 @@ void gfs2_log_flush(struct gfs2_sbd *sdp, struct gfs2_glock *gl)
566 INIT_LIST_HEAD(&ai->ai_ail1_list); 566 INIT_LIST_HEAD(&ai->ai_ail1_list);
567 INIT_LIST_HEAD(&ai->ai_ail2_list); 567 INIT_LIST_HEAD(&ai->ai_ail2_list);
568 568
569 gfs2_assert_withdraw(sdp, sdp->sd_log_num_buf == sdp->sd_log_commited_buf); 569 gfs2_assert_withdraw(sdp, sdp->sd_log_num_buf + sdp->sd_log_num_jdata == sdp->sd_log_commited_buf);
570 gfs2_assert_withdraw(sdp, 570 gfs2_assert_withdraw(sdp,
571 sdp->sd_log_num_revoke == sdp->sd_log_commited_revoke); 571 sdp->sd_log_num_revoke == sdp->sd_log_commited_revoke);
572 572
diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
index f82d84d05d23..3e971f25120d 100644
--- a/fs/gfs2/lops.c
+++ b/fs/gfs2/lops.c
@@ -475,6 +475,8 @@ static void databuf_lo_add(struct gfs2_sbd *sdp, struct gfs2_log_element *le)
475 tr->tr_num_buf++; 475 tr->tr_num_buf++;
476 list_add(&bd->bd_list_tr, &tr->tr_list_buf); 476 list_add(&bd->bd_list_tr, &tr->tr_list_buf);
477 gfs2_log_unlock(sdp); 477 gfs2_log_unlock(sdp);
478 if (!list_empty(&le->le_list))
479 return;
478 gfs2_pin(sdp, bd->bd_bh); 480 gfs2_pin(sdp, bd->bd_bh);
479 tr->tr_num_buf_new++; 481 tr->tr_num_buf_new++;
480 } else { 482 } else {
diff --git a/fs/gfs2/ops_address.c b/fs/gfs2/ops_address.c
index fb84478e1df6..ac5659521386 100644
--- a/fs/gfs2/ops_address.c
+++ b/fs/gfs2/ops_address.c
@@ -50,6 +50,8 @@ static void gfs2_page_add_databufs(struct gfs2_inode *ip, struct page *page,
50 end = start + bsize; 50 end = start + bsize;
51 if (end <= from || start >= to) 51 if (end <= from || start >= to)
52 continue; 52 continue;
53 if (gfs2_is_jdata(ip))
54 set_buffer_uptodate(bh);
53 gfs2_trans_add_bh(ip->i_gl, bh, 0); 55 gfs2_trans_add_bh(ip->i_gl, bh, 0);
54 } 56 }
55} 57}