aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2013-02-21 12:25:23 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2013-02-21 12:25:23 -0500
commit850cb82b754c931c570c9cb7f10c9f2181bac617 (patch)
tree54cc46d13277cb919637763c731ab8d5b667c139 /fs
parent2171ee8f43968e8d6a2b4712d495e352e881c446 (diff)
parentf11722834605a155022a8098ad7d8adacf44b22f (diff)
Merge tag 'dlm-3.9' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm
Pull dlm update from David Teigland: "This includes a single patch to avoid excessive and unnecessary scanning of rsbs to free." * tag 'dlm-3.9' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm: dlm: avoid scanning unchanged toss lists
Diffstat (limited to 'fs')
-rw-r--r--fs/dlm/dlm_internal.h3
-rw-r--r--fs/dlm/lock.c15
2 files changed, 18 insertions, 0 deletions
diff --git a/fs/dlm/dlm_internal.h b/fs/dlm/dlm_internal.h
index 77c0f70f8fe8..e7665c31f7b1 100644
--- a/fs/dlm/dlm_internal.h
+++ b/fs/dlm/dlm_internal.h
@@ -96,10 +96,13 @@ do { \
96} 96}
97 97
98 98
99#define DLM_RTF_SHRINK 0x00000001
100
99struct dlm_rsbtable { 101struct dlm_rsbtable {
100 struct rb_root keep; 102 struct rb_root keep;
101 struct rb_root toss; 103 struct rb_root toss;
102 spinlock_t lock; 104 spinlock_t lock;
105 uint32_t flags;
103}; 106};
104 107
105 108
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index a579f30f237d..f7501651762d 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
@@ -1132,6 +1132,7 @@ static void toss_rsb(struct kref *kref)
1132 rb_erase(&r->res_hashnode, &ls->ls_rsbtbl[r->res_bucket].keep); 1132 rb_erase(&r->res_hashnode, &ls->ls_rsbtbl[r->res_bucket].keep);
1133 rsb_insert(r, &ls->ls_rsbtbl[r->res_bucket].toss); 1133 rsb_insert(r, &ls->ls_rsbtbl[r->res_bucket].toss);
1134 r->res_toss_time = jiffies; 1134 r->res_toss_time = jiffies;
1135 ls->ls_rsbtbl[r->res_bucket].flags |= DLM_RTF_SHRINK;
1135 if (r->res_lvbptr) { 1136 if (r->res_lvbptr) {
1136 dlm_free_lvb(r->res_lvbptr); 1137 dlm_free_lvb(r->res_lvbptr);
1137 r->res_lvbptr = NULL; 1138 r->res_lvbptr = NULL;
@@ -1659,11 +1660,18 @@ static void shrink_bucket(struct dlm_ls *ls, int b)
1659 char *name; 1660 char *name;
1660 int our_nodeid = dlm_our_nodeid(); 1661 int our_nodeid = dlm_our_nodeid();
1661 int remote_count = 0; 1662 int remote_count = 0;
1663 int need_shrink = 0;
1662 int i, len, rv; 1664 int i, len, rv;
1663 1665
1664 memset(&ls->ls_remove_lens, 0, sizeof(int) * DLM_REMOVE_NAMES_MAX); 1666 memset(&ls->ls_remove_lens, 0, sizeof(int) * DLM_REMOVE_NAMES_MAX);
1665 1667
1666 spin_lock(&ls->ls_rsbtbl[b].lock); 1668 spin_lock(&ls->ls_rsbtbl[b].lock);
1669
1670 if (!(ls->ls_rsbtbl[b].flags & DLM_RTF_SHRINK)) {
1671 spin_unlock(&ls->ls_rsbtbl[b].lock);
1672 return;
1673 }
1674
1667 for (n = rb_first(&ls->ls_rsbtbl[b].toss); n; n = next) { 1675 for (n = rb_first(&ls->ls_rsbtbl[b].toss); n; n = next) {
1668 next = rb_next(n); 1676 next = rb_next(n);
1669 r = rb_entry(n, struct dlm_rsb, res_hashnode); 1677 r = rb_entry(n, struct dlm_rsb, res_hashnode);
@@ -1679,6 +1687,8 @@ static void shrink_bucket(struct dlm_ls *ls, int b)
1679 continue; 1687 continue;
1680 } 1688 }
1681 1689
1690 need_shrink = 1;
1691
1682 if (!time_after_eq(jiffies, r->res_toss_time + 1692 if (!time_after_eq(jiffies, r->res_toss_time +
1683 dlm_config.ci_toss_secs * HZ)) { 1693 dlm_config.ci_toss_secs * HZ)) {
1684 continue; 1694 continue;
@@ -1710,6 +1720,11 @@ static void shrink_bucket(struct dlm_ls *ls, int b)
1710 rb_erase(&r->res_hashnode, &ls->ls_rsbtbl[b].toss); 1720 rb_erase(&r->res_hashnode, &ls->ls_rsbtbl[b].toss);
1711 dlm_free_rsb(r); 1721 dlm_free_rsb(r);
1712 } 1722 }
1723
1724 if (need_shrink)
1725 ls->ls_rsbtbl[b].flags |= DLM_RTF_SHRINK;
1726 else
1727 ls->ls_rsbtbl[b].flags &= ~DLM_RTF_SHRINK;
1713 spin_unlock(&ls->ls_rsbtbl[b].lock); 1728 spin_unlock(&ls->ls_rsbtbl[b].lock);
1714 1729
1715 /* 1730 /*