diff options
author | J. Bruce Fields <bfields@citi.umich.edu> | 2010-03-09 17:22:08 -0500 |
---|---|---|
committer | J. Bruce Fields <bfields@citi.umich.edu> | 2010-03-09 17:22:08 -0500 |
commit | e739cf1da48e841bc5d744a99764c1a668b4bdd2 (patch) | |
tree | 1d39318bbbcdd66ad8cd34823ad9befb7af08b1f /fs | |
parent | e7b184f199fd3c80b618ec8244cbda70857d2779 (diff) | |
parent | 57d54889cd00db2752994b389ba714138652e60c (diff) |
Merge commit 'v2.6.34-rc1' into for-2.6.35-incoming
Diffstat (limited to 'fs')
356 files changed, 19022 insertions, 7881 deletions
diff --git a/fs/9p/fid.c b/fs/9p/fid.c index 14d944204571..08b2eb157048 100644 --- a/fs/9p/fid.c +++ b/fs/9p/fid.c | |||
@@ -151,7 +151,7 @@ struct p9_fid *v9fs_fid_lookup(struct dentry *dentry) | |||
151 | if (access == V9FS_ACCESS_SINGLE) | 151 | if (access == V9FS_ACCESS_SINGLE) |
152 | return ERR_PTR(-EPERM); | 152 | return ERR_PTR(-EPERM); |
153 | 153 | ||
154 | if (v9fs_extended(v9ses)) | 154 | if (v9fs_proto_dotu(v9ses)) |
155 | uname = NULL; | 155 | uname = NULL; |
156 | else | 156 | else |
157 | uname = v9ses->uname; | 157 | uname = v9ses->uname; |
diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c index 7d6c2139891d..6c7f6a251115 100644 --- a/fs/9p/v9fs.c +++ b/fs/9p/v9fs.c | |||
@@ -241,7 +241,7 @@ struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses, | |||
241 | list_add(&v9ses->slist, &v9fs_sessionlist); | 241 | list_add(&v9ses->slist, &v9fs_sessionlist); |
242 | spin_unlock(&v9fs_sessionlist_lock); | 242 | spin_unlock(&v9fs_sessionlist_lock); |
243 | 243 | ||
244 | v9ses->flags = V9FS_EXTENDED | V9FS_ACCESS_USER; | 244 | v9ses->flags = V9FS_PROTO_2000U | V9FS_ACCESS_USER; |
245 | strcpy(v9ses->uname, V9FS_DEFUSER); | 245 | strcpy(v9ses->uname, V9FS_DEFUSER); |
246 | strcpy(v9ses->aname, V9FS_DEFANAME); | 246 | strcpy(v9ses->aname, V9FS_DEFANAME); |
247 | v9ses->uid = ~0; | 247 | v9ses->uid = ~0; |
@@ -262,13 +262,13 @@ struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses, | |||
262 | goto error; | 262 | goto error; |
263 | } | 263 | } |
264 | 264 | ||
265 | if (!v9ses->clnt->dotu) | 265 | if (!p9_is_proto_dotu(v9ses->clnt)) |
266 | v9ses->flags &= ~V9FS_EXTENDED; | 266 | v9ses->flags &= ~V9FS_PROTO_2000U; |
267 | 267 | ||
268 | v9ses->maxdata = v9ses->clnt->msize - P9_IOHDRSZ; | 268 | v9ses->maxdata = v9ses->clnt->msize - P9_IOHDRSZ; |
269 | 269 | ||
270 | /* for legacy mode, fall back to V9FS_ACCESS_ANY */ | 270 | /* for legacy mode, fall back to V9FS_ACCESS_ANY */ |
271 | if (!v9fs_extended(v9ses) && | 271 | if (!v9fs_proto_dotu(v9ses) && |
272 | ((v9ses->flags&V9FS_ACCESS_MASK) == V9FS_ACCESS_USER)) { | 272 | ((v9ses->flags&V9FS_ACCESS_MASK) == V9FS_ACCESS_USER)) { |
273 | 273 | ||
274 | v9ses->flags &= ~V9FS_ACCESS_MASK; | 274 | v9ses->flags &= ~V9FS_ACCESS_MASK; |
diff --git a/fs/9p/v9fs.h b/fs/9p/v9fs.h index 019f4ccb70c1..79000bf62491 100644 --- a/fs/9p/v9fs.h +++ b/fs/9p/v9fs.h | |||
@@ -23,7 +23,8 @@ | |||
23 | 23 | ||
24 | /** | 24 | /** |
25 | * enum p9_session_flags - option flags for each 9P session | 25 | * enum p9_session_flags - option flags for each 9P session |
26 | * @V9FS_EXTENDED: whether or not to use 9P2000.u extensions | 26 | * @V9FS_PROTO_2000U: whether or not to use 9P2000.u extensions |
27 | * @V9FS_PROTO_2010L: whether or not to use 9P2010.l extensions | ||
27 | * @V9FS_ACCESS_SINGLE: only the mounting user can access the hierarchy | 28 | * @V9FS_ACCESS_SINGLE: only the mounting user can access the hierarchy |
28 | * @V9FS_ACCESS_USER: a new attach will be issued for every user (default) | 29 | * @V9FS_ACCESS_USER: a new attach will be issued for every user (default) |
29 | * @V9FS_ACCESS_ANY: use a single attach for all users | 30 | * @V9FS_ACCESS_ANY: use a single attach for all users |
@@ -32,11 +33,12 @@ | |||
32 | * Session flags reflect options selected by users at mount time | 33 | * Session flags reflect options selected by users at mount time |
33 | */ | 34 | */ |
34 | enum p9_session_flags { | 35 | enum p9_session_flags { |
35 | V9FS_EXTENDED = 0x01, | 36 | V9FS_PROTO_2000U = 0x01, |
36 | V9FS_ACCESS_SINGLE = 0x02, | 37 | V9FS_PROTO_2010L = 0x02, |
37 | V9FS_ACCESS_USER = 0x04, | 38 | V9FS_ACCESS_SINGLE = 0x04, |
38 | V9FS_ACCESS_ANY = 0x06, | 39 | V9FS_ACCESS_USER = 0x08, |
39 | V9FS_ACCESS_MASK = 0x06, | 40 | V9FS_ACCESS_ANY = 0x0C, |
41 | V9FS_ACCESS_MASK = 0x0C, | ||
40 | }; | 42 | }; |
41 | 43 | ||
42 | /* possible values of ->cache */ | 44 | /* possible values of ->cache */ |
@@ -121,7 +123,12 @@ static inline struct v9fs_session_info *v9fs_inode2v9ses(struct inode *inode) | |||
121 | return (inode->i_sb->s_fs_info); | 123 | return (inode->i_sb->s_fs_info); |
122 | } | 124 | } |
123 | 125 | ||
124 | static inline int v9fs_extended(struct v9fs_session_info *v9ses) | 126 | static inline int v9fs_proto_dotu(struct v9fs_session_info *v9ses) |
125 | { | 127 | { |
126 | return v9ses->flags & V9FS_EXTENDED; | 128 | return v9ses->flags & V9FS_PROTO_2000U; |
129 | } | ||
130 | |||
131 | static inline int v9fs_proto_dotl(struct v9fs_session_info *v9ses) | ||
132 | { | ||
133 | return v9ses->flags & V9FS_PROTO_2010L; | ||
127 | } | 134 | } |
diff --git a/fs/9p/vfs_dir.c b/fs/9p/vfs_dir.c index 15cce53bf61e..6580aa449541 100644 --- a/fs/9p/vfs_dir.c +++ b/fs/9p/vfs_dir.c | |||
@@ -135,7 +135,7 @@ static int v9fs_dir_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
135 | while (rdir->head < rdir->tail) { | 135 | while (rdir->head < rdir->tail) { |
136 | err = p9stat_read(rdir->buf + rdir->head, | 136 | err = p9stat_read(rdir->buf + rdir->head, |
137 | buflen - rdir->head, &st, | 137 | buflen - rdir->head, &st, |
138 | fid->clnt->dotu); | 138 | fid->clnt->proto_version); |
139 | if (err) { | 139 | if (err) { |
140 | P9_DPRINTK(P9_DEBUG_VFS, "returned %d\n", err); | 140 | P9_DPRINTK(P9_DEBUG_VFS, "returned %d\n", err); |
141 | err = -EIO; | 141 | err = -EIO; |
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c index 74a0461a9ac0..36122683fae8 100644 --- a/fs/9p/vfs_file.c +++ b/fs/9p/vfs_file.c | |||
@@ -61,7 +61,7 @@ int v9fs_file_open(struct inode *inode, struct file *file) | |||
61 | 61 | ||
62 | P9_DPRINTK(P9_DEBUG_VFS, "inode: %p file: %p \n", inode, file); | 62 | P9_DPRINTK(P9_DEBUG_VFS, "inode: %p file: %p \n", inode, file); |
63 | v9ses = v9fs_inode2v9ses(inode); | 63 | v9ses = v9fs_inode2v9ses(inode); |
64 | omode = v9fs_uflags2omode(file->f_flags, v9fs_extended(v9ses)); | 64 | omode = v9fs_uflags2omode(file->f_flags, v9fs_proto_dotu(v9ses)); |
65 | fid = file->private_data; | 65 | fid = file->private_data; |
66 | if (!fid) { | 66 | if (!fid) { |
67 | fid = v9fs_fid_clone(file->f_path.dentry); | 67 | fid = v9fs_fid_clone(file->f_path.dentry); |
@@ -77,7 +77,7 @@ int v9fs_file_open(struct inode *inode, struct file *file) | |||
77 | i_size_write(inode, 0); | 77 | i_size_write(inode, 0); |
78 | inode->i_blocks = 0; | 78 | inode->i_blocks = 0; |
79 | } | 79 | } |
80 | if ((file->f_flags & O_APPEND) && (!v9fs_extended(v9ses))) | 80 | if ((file->f_flags & O_APPEND) && (!v9fs_proto_dotu(v9ses))) |
81 | generic_file_llseek(file, 0, SEEK_END); | 81 | generic_file_llseek(file, 0, SEEK_END); |
82 | } | 82 | } |
83 | 83 | ||
diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c index a407fa3388c0..5fe45d692c9f 100644 --- a/fs/9p/vfs_inode.c +++ b/fs/9p/vfs_inode.c | |||
@@ -60,7 +60,7 @@ static int unixmode2p9mode(struct v9fs_session_info *v9ses, int mode) | |||
60 | res = mode & 0777; | 60 | res = mode & 0777; |
61 | if (S_ISDIR(mode)) | 61 | if (S_ISDIR(mode)) |
62 | res |= P9_DMDIR; | 62 | res |= P9_DMDIR; |
63 | if (v9fs_extended(v9ses)) { | 63 | if (v9fs_proto_dotu(v9ses)) { |
64 | if (S_ISLNK(mode)) | 64 | if (S_ISLNK(mode)) |
65 | res |= P9_DMSYMLINK; | 65 | res |= P9_DMSYMLINK; |
66 | if (v9ses->nodev == 0) { | 66 | if (v9ses->nodev == 0) { |
@@ -102,21 +102,21 @@ static int p9mode2unixmode(struct v9fs_session_info *v9ses, int mode) | |||
102 | 102 | ||
103 | if ((mode & P9_DMDIR) == P9_DMDIR) | 103 | if ((mode & P9_DMDIR) == P9_DMDIR) |
104 | res |= S_IFDIR; | 104 | res |= S_IFDIR; |
105 | else if ((mode & P9_DMSYMLINK) && (v9fs_extended(v9ses))) | 105 | else if ((mode & P9_DMSYMLINK) && (v9fs_proto_dotu(v9ses))) |
106 | res |= S_IFLNK; | 106 | res |= S_IFLNK; |
107 | else if ((mode & P9_DMSOCKET) && (v9fs_extended(v9ses)) | 107 | else if ((mode & P9_DMSOCKET) && (v9fs_proto_dotu(v9ses)) |
108 | && (v9ses->nodev == 0)) | 108 | && (v9ses->nodev == 0)) |
109 | res |= S_IFSOCK; | 109 | res |= S_IFSOCK; |
110 | else if ((mode & P9_DMNAMEDPIPE) && (v9fs_extended(v9ses)) | 110 | else if ((mode & P9_DMNAMEDPIPE) && (v9fs_proto_dotu(v9ses)) |
111 | && (v9ses->nodev == 0)) | 111 | && (v9ses->nodev == 0)) |
112 | res |= S_IFIFO; | 112 | res |= S_IFIFO; |
113 | else if ((mode & P9_DMDEVICE) && (v9fs_extended(v9ses)) | 113 | else if ((mode & P9_DMDEVICE) && (v9fs_proto_dotu(v9ses)) |
114 | && (v9ses->nodev == 0)) | 114 | && (v9ses->nodev == 0)) |
115 | res |= S_IFBLK; | 115 | res |= S_IFBLK; |
116 | else | 116 | else |
117 | res |= S_IFREG; | 117 | res |= S_IFREG; |
118 | 118 | ||
119 | if (v9fs_extended(v9ses)) { | 119 | if (v9fs_proto_dotu(v9ses)) { |
120 | if ((mode & P9_DMSETUID) == P9_DMSETUID) | 120 | if ((mode & P9_DMSETUID) == P9_DMSETUID) |
121 | res |= S_ISUID; | 121 | res |= S_ISUID; |
122 | 122 | ||
@@ -265,7 +265,7 @@ struct inode *v9fs_get_inode(struct super_block *sb, int mode) | |||
265 | case S_IFBLK: | 265 | case S_IFBLK: |
266 | case S_IFCHR: | 266 | case S_IFCHR: |
267 | case S_IFSOCK: | 267 | case S_IFSOCK: |
268 | if (!v9fs_extended(v9ses)) { | 268 | if (!v9fs_proto_dotu(v9ses)) { |
269 | P9_DPRINTK(P9_DEBUG_ERROR, | 269 | P9_DPRINTK(P9_DEBUG_ERROR, |
270 | "special files without extended mode\n"); | 270 | "special files without extended mode\n"); |
271 | err = -EINVAL; | 271 | err = -EINVAL; |
@@ -278,7 +278,7 @@ struct inode *v9fs_get_inode(struct super_block *sb, int mode) | |||
278 | inode->i_fop = &v9fs_file_operations; | 278 | inode->i_fop = &v9fs_file_operations; |
279 | break; | 279 | break; |
280 | case S_IFLNK: | 280 | case S_IFLNK: |
281 | if (!v9fs_extended(v9ses)) { | 281 | if (!v9fs_proto_dotu(v9ses)) { |
282 | P9_DPRINTK(P9_DEBUG_ERROR, | 282 | P9_DPRINTK(P9_DEBUG_ERROR, |
283 | "extended modes used w/o 9P2000.u\n"); | 283 | "extended modes used w/o 9P2000.u\n"); |
284 | err = -EINVAL; | 284 | err = -EINVAL; |
@@ -288,7 +288,7 @@ struct inode *v9fs_get_inode(struct super_block *sb, int mode) | |||
288 | break; | 288 | break; |
289 | case S_IFDIR: | 289 | case S_IFDIR: |
290 | inc_nlink(inode); | 290 | inc_nlink(inode); |
291 | if (v9fs_extended(v9ses)) | 291 | if (v9fs_proto_dotu(v9ses)) |
292 | inode->i_op = &v9fs_dir_inode_operations_ext; | 292 | inode->i_op = &v9fs_dir_inode_operations_ext; |
293 | else | 293 | else |
294 | inode->i_op = &v9fs_dir_inode_operations; | 294 | inode->i_op = &v9fs_dir_inode_operations; |
@@ -575,7 +575,8 @@ v9fs_vfs_create(struct inode *dir, struct dentry *dentry, int mode, | |||
575 | flags = O_RDWR; | 575 | flags = O_RDWR; |
576 | 576 | ||
577 | fid = v9fs_create(v9ses, dir, dentry, NULL, perm, | 577 | fid = v9fs_create(v9ses, dir, dentry, NULL, perm, |
578 | v9fs_uflags2omode(flags, v9fs_extended(v9ses))); | 578 | v9fs_uflags2omode(flags, |
579 | v9fs_proto_dotu(v9ses))); | ||
579 | if (IS_ERR(fid)) { | 580 | if (IS_ERR(fid)) { |
580 | err = PTR_ERR(fid); | 581 | err = PTR_ERR(fid); |
581 | fid = NULL; | 582 | fid = NULL; |
@@ -858,7 +859,7 @@ static int v9fs_vfs_setattr(struct dentry *dentry, struct iattr *iattr) | |||
858 | if (iattr->ia_valid & ATTR_SIZE) | 859 | if (iattr->ia_valid & ATTR_SIZE) |
859 | wstat.length = iattr->ia_size; | 860 | wstat.length = iattr->ia_size; |
860 | 861 | ||
861 | if (v9fs_extended(v9ses)) { | 862 | if (v9fs_proto_dotu(v9ses)) { |
862 | if (iattr->ia_valid & ATTR_UID) | 863 | if (iattr->ia_valid & ATTR_UID) |
863 | wstat.n_uid = iattr->ia_uid; | 864 | wstat.n_uid = iattr->ia_uid; |
864 | 865 | ||
@@ -886,6 +887,8 @@ v9fs_stat2inode(struct p9_wstat *stat, struct inode *inode, | |||
886 | struct super_block *sb) | 887 | struct super_block *sb) |
887 | { | 888 | { |
888 | char ext[32]; | 889 | char ext[32]; |
890 | char tag_name[14]; | ||
891 | unsigned int i_nlink; | ||
889 | struct v9fs_session_info *v9ses = sb->s_fs_info; | 892 | struct v9fs_session_info *v9ses = sb->s_fs_info; |
890 | 893 | ||
891 | inode->i_nlink = 1; | 894 | inode->i_nlink = 1; |
@@ -897,11 +900,26 @@ v9fs_stat2inode(struct p9_wstat *stat, struct inode *inode, | |||
897 | inode->i_uid = v9ses->dfltuid; | 900 | inode->i_uid = v9ses->dfltuid; |
898 | inode->i_gid = v9ses->dfltgid; | 901 | inode->i_gid = v9ses->dfltgid; |
899 | 902 | ||
900 | if (v9fs_extended(v9ses)) { | 903 | if (v9fs_proto_dotu(v9ses)) { |
901 | inode->i_uid = stat->n_uid; | 904 | inode->i_uid = stat->n_uid; |
902 | inode->i_gid = stat->n_gid; | 905 | inode->i_gid = stat->n_gid; |
903 | } | 906 | } |
904 | 907 | if ((S_ISREG(inode->i_mode)) || (S_ISDIR(inode->i_mode))) { | |
908 | if (v9fs_proto_dotu(v9ses) && (stat->extension[0] != '\0')) { | ||
909 | /* | ||
910 | * Hadlink support got added later to | ||
911 | * to the .u extension. So there can be | ||
912 | * server out there that doesn't support | ||
913 | * this even with .u extension. So check | ||
914 | * for non NULL stat->extension | ||
915 | */ | ||
916 | strncpy(ext, stat->extension, sizeof(ext)); | ||
917 | /* HARDLINKCOUNT %u */ | ||
918 | sscanf(ext, "%13s %u", tag_name, &i_nlink); | ||
919 | if (!strncmp(tag_name, "HARDLINKCOUNT", 13)) | ||
920 | inode->i_nlink = i_nlink; | ||
921 | } | ||
922 | } | ||
905 | inode->i_mode = p9mode2unixmode(v9ses, stat->mode); | 923 | inode->i_mode = p9mode2unixmode(v9ses, stat->mode); |
906 | if ((S_ISBLK(inode->i_mode)) || (S_ISCHR(inode->i_mode))) { | 924 | if ((S_ISBLK(inode->i_mode)) || (S_ISCHR(inode->i_mode))) { |
907 | char type = 0; | 925 | char type = 0; |
@@ -976,7 +994,7 @@ static int v9fs_readlink(struct dentry *dentry, char *buffer, int buflen) | |||
976 | if (IS_ERR(fid)) | 994 | if (IS_ERR(fid)) |
977 | return PTR_ERR(fid); | 995 | return PTR_ERR(fid); |
978 | 996 | ||
979 | if (!v9fs_extended(v9ses)) | 997 | if (!v9fs_proto_dotu(v9ses)) |
980 | return -EBADF; | 998 | return -EBADF; |
981 | 999 | ||
982 | st = p9_client_stat(fid); | 1000 | st = p9_client_stat(fid); |
@@ -1066,7 +1084,7 @@ static int v9fs_vfs_mkspecial(struct inode *dir, struct dentry *dentry, | |||
1066 | struct p9_fid *fid; | 1084 | struct p9_fid *fid; |
1067 | 1085 | ||
1068 | v9ses = v9fs_inode2v9ses(dir); | 1086 | v9ses = v9fs_inode2v9ses(dir); |
1069 | if (!v9fs_extended(v9ses)) { | 1087 | if (!v9fs_proto_dotu(v9ses)) { |
1070 | P9_DPRINTK(P9_DEBUG_ERROR, "not extended\n"); | 1088 | P9_DPRINTK(P9_DEBUG_ERROR, "not extended\n"); |
1071 | return -EPERM; | 1089 | return -EPERM; |
1072 | } | 1090 | } |
diff --git a/fs/Kconfig b/fs/Kconfig index 64d44efad7a5..7405f071be67 100644 --- a/fs/Kconfig +++ b/fs/Kconfig | |||
@@ -177,6 +177,7 @@ source "fs/efs/Kconfig" | |||
177 | source "fs/jffs2/Kconfig" | 177 | source "fs/jffs2/Kconfig" |
178 | # UBIFS File system configuration | 178 | # UBIFS File system configuration |
179 | source "fs/ubifs/Kconfig" | 179 | source "fs/ubifs/Kconfig" |
180 | source "fs/logfs/Kconfig" | ||
180 | source "fs/cramfs/Kconfig" | 181 | source "fs/cramfs/Kconfig" |
181 | source "fs/squashfs/Kconfig" | 182 | source "fs/squashfs/Kconfig" |
182 | source "fs/freevxfs/Kconfig" | 183 | source "fs/freevxfs/Kconfig" |
diff --git a/fs/Makefile b/fs/Makefile index af6d04700d9c..c3633aa46911 100644 --- a/fs/Makefile +++ b/fs/Makefile | |||
@@ -99,6 +99,7 @@ obj-$(CONFIG_NTFS_FS) += ntfs/ | |||
99 | obj-$(CONFIG_UFS_FS) += ufs/ | 99 | obj-$(CONFIG_UFS_FS) += ufs/ |
100 | obj-$(CONFIG_EFS_FS) += efs/ | 100 | obj-$(CONFIG_EFS_FS) += efs/ |
101 | obj-$(CONFIG_JFFS2_FS) += jffs2/ | 101 | obj-$(CONFIG_JFFS2_FS) += jffs2/ |
102 | obj-$(CONFIG_LOGFS) += logfs/ | ||
102 | obj-$(CONFIG_UBIFS_FS) += ubifs/ | 103 | obj-$(CONFIG_UBIFS_FS) += ubifs/ |
103 | obj-$(CONFIG_AFFS_FS) += affs/ | 104 | obj-$(CONFIG_AFFS_FS) += affs/ |
104 | obj-$(CONFIG_ROMFS_FS) += romfs/ | 105 | obj-$(CONFIG_ROMFS_FS) += romfs/ |
diff --git a/fs/adfs/adfs.h b/fs/adfs/adfs.h index 9cc18775b832..2ff622f6f547 100644 --- a/fs/adfs/adfs.h +++ b/fs/adfs/adfs.h | |||
@@ -121,7 +121,7 @@ struct adfs_discmap { | |||
121 | 121 | ||
122 | /* Inode stuff */ | 122 | /* Inode stuff */ |
123 | struct inode *adfs_iget(struct super_block *sb, struct object_info *obj); | 123 | struct inode *adfs_iget(struct super_block *sb, struct object_info *obj); |
124 | int adfs_write_inode(struct inode *inode,int unused); | 124 | int adfs_write_inode(struct inode *inode, struct writeback_control *wbc); |
125 | int adfs_notify_change(struct dentry *dentry, struct iattr *attr); | 125 | int adfs_notify_change(struct dentry *dentry, struct iattr *attr); |
126 | 126 | ||
127 | /* map.c */ | 127 | /* map.c */ |
diff --git a/fs/adfs/inode.c b/fs/adfs/inode.c index 3f57ce4bee5d..0f5e30978135 100644 --- a/fs/adfs/inode.c +++ b/fs/adfs/inode.c | |||
@@ -9,6 +9,7 @@ | |||
9 | */ | 9 | */ |
10 | #include <linux/smp_lock.h> | 10 | #include <linux/smp_lock.h> |
11 | #include <linux/buffer_head.h> | 11 | #include <linux/buffer_head.h> |
12 | #include <linux/writeback.h> | ||
12 | #include "adfs.h" | 13 | #include "adfs.h" |
13 | 14 | ||
14 | /* | 15 | /* |
@@ -360,7 +361,7 @@ out: | |||
360 | * The adfs-specific inode data has already been updated by | 361 | * The adfs-specific inode data has already been updated by |
361 | * adfs_notify_change() | 362 | * adfs_notify_change() |
362 | */ | 363 | */ |
363 | int adfs_write_inode(struct inode *inode, int wait) | 364 | int adfs_write_inode(struct inode *inode, struct writeback_control *wbc) |
364 | { | 365 | { |
365 | struct super_block *sb = inode->i_sb; | 366 | struct super_block *sb = inode->i_sb; |
366 | struct object_info obj; | 367 | struct object_info obj; |
@@ -375,7 +376,7 @@ int adfs_write_inode(struct inode *inode, int wait) | |||
375 | obj.attr = ADFS_I(inode)->attr; | 376 | obj.attr = ADFS_I(inode)->attr; |
376 | obj.size = inode->i_size; | 377 | obj.size = inode->i_size; |
377 | 378 | ||
378 | ret = adfs_dir_update(sb, &obj, wait); | 379 | ret = adfs_dir_update(sb, &obj, wbc->sync_mode == WB_SYNC_ALL); |
379 | unlock_kernel(); | 380 | unlock_kernel(); |
380 | return ret; | 381 | return ret; |
381 | } | 382 | } |
diff --git a/fs/affs/affs.h b/fs/affs/affs.h index 0e40caaba456..861dae68ac12 100644 --- a/fs/affs/affs.h +++ b/fs/affs/affs.h | |||
@@ -175,7 +175,8 @@ extern void affs_delete_inode(struct inode *inode); | |||
175 | extern void affs_clear_inode(struct inode *inode); | 175 | extern void affs_clear_inode(struct inode *inode); |
176 | extern struct inode *affs_iget(struct super_block *sb, | 176 | extern struct inode *affs_iget(struct super_block *sb, |
177 | unsigned long ino); | 177 | unsigned long ino); |
178 | extern int affs_write_inode(struct inode *inode, int); | 178 | extern int affs_write_inode(struct inode *inode, |
179 | struct writeback_control *wbc); | ||
179 | extern int affs_add_entry(struct inode *dir, struct inode *inode, struct dentry *dentry, s32 type); | 180 | extern int affs_add_entry(struct inode *dir, struct inode *inode, struct dentry *dentry, s32 type); |
180 | 181 | ||
181 | /* file.c */ | 182 | /* file.c */ |
diff --git a/fs/affs/inode.c b/fs/affs/inode.c index 3c4ec7d864c4..c9744d771d98 100644 --- a/fs/affs/inode.c +++ b/fs/affs/inode.c | |||
@@ -166,7 +166,7 @@ bad_inode: | |||
166 | } | 166 | } |
167 | 167 | ||
168 | int | 168 | int |
169 | affs_write_inode(struct inode *inode, int unused) | 169 | affs_write_inode(struct inode *inode, struct writeback_control *wbc) |
170 | { | 170 | { |
171 | struct super_block *sb = inode->i_sb; | 171 | struct super_block *sb = inode->i_sb; |
172 | struct buffer_head *bh; | 172 | struct buffer_head *bh; |
diff --git a/fs/afs/internal.h b/fs/afs/internal.h index 6ece2a13bf71..c54dad4e6063 100644 --- a/fs/afs/internal.h +++ b/fs/afs/internal.h | |||
@@ -733,7 +733,6 @@ extern int afs_write_end(struct file *file, struct address_space *mapping, | |||
733 | struct page *page, void *fsdata); | 733 | struct page *page, void *fsdata); |
734 | extern int afs_writepage(struct page *, struct writeback_control *); | 734 | extern int afs_writepage(struct page *, struct writeback_control *); |
735 | extern int afs_writepages(struct address_space *, struct writeback_control *); | 735 | extern int afs_writepages(struct address_space *, struct writeback_control *); |
736 | extern int afs_write_inode(struct inode *, int); | ||
737 | extern void afs_pages_written_back(struct afs_vnode *, struct afs_call *); | 736 | extern void afs_pages_written_back(struct afs_vnode *, struct afs_call *); |
738 | extern ssize_t afs_file_write(struct kiocb *, const struct iovec *, | 737 | extern ssize_t afs_file_write(struct kiocb *, const struct iovec *, |
739 | unsigned long, loff_t); | 738 | unsigned long, loff_t); |
diff --git a/fs/afs/super.c b/fs/afs/super.c index e1ea1c240b6a..14f6431598ad 100644 --- a/fs/afs/super.c +++ b/fs/afs/super.c | |||
@@ -48,7 +48,6 @@ struct file_system_type afs_fs_type = { | |||
48 | static const struct super_operations afs_super_ops = { | 48 | static const struct super_operations afs_super_ops = { |
49 | .statfs = afs_statfs, | 49 | .statfs = afs_statfs, |
50 | .alloc_inode = afs_alloc_inode, | 50 | .alloc_inode = afs_alloc_inode, |
51 | .write_inode = afs_write_inode, | ||
52 | .destroy_inode = afs_destroy_inode, | 51 | .destroy_inode = afs_destroy_inode, |
53 | .clear_inode = afs_clear_inode, | 52 | .clear_inode = afs_clear_inode, |
54 | .put_super = afs_put_super, | 53 | .put_super = afs_put_super, |
diff --git a/fs/afs/write.c b/fs/afs/write.c index 5e15a21dbf9f..3bed54a294d4 100644 --- a/fs/afs/write.c +++ b/fs/afs/write.c | |||
@@ -585,27 +585,6 @@ int afs_writepages(struct address_space *mapping, | |||
585 | } | 585 | } |
586 | 586 | ||
587 | /* | 587 | /* |
588 | * write an inode back | ||
589 | */ | ||
590 | int afs_write_inode(struct inode *inode, int sync) | ||
591 | { | ||
592 | struct afs_vnode *vnode = AFS_FS_I(inode); | ||
593 | int ret; | ||
594 | |||
595 | _enter("{%x:%u},", vnode->fid.vid, vnode->fid.vnode); | ||
596 | |||
597 | ret = 0; | ||
598 | if (sync) { | ||
599 | ret = filemap_fdatawait(inode->i_mapping); | ||
600 | if (ret < 0) | ||
601 | __mark_inode_dirty(inode, I_DIRTY_DATASYNC); | ||
602 | } | ||
603 | |||
604 | _leave(" = %d", ret); | ||
605 | return ret; | ||
606 | } | ||
607 | |||
608 | /* | ||
609 | * completion of write to server | 588 | * completion of write to server |
610 | */ | 589 | */ |
611 | void afs_pages_written_back(struct afs_vnode *vnode, struct afs_call *call) | 590 | void afs_pages_written_back(struct afs_vnode *vnode, struct afs_call *call) |
@@ -12,7 +12,6 @@ | |||
12 | #include <linux/capability.h> | 12 | #include <linux/capability.h> |
13 | #include <linux/fsnotify.h> | 13 | #include <linux/fsnotify.h> |
14 | #include <linux/fcntl.h> | 14 | #include <linux/fcntl.h> |
15 | #include <linux/quotaops.h> | ||
16 | #include <linux/security.h> | 15 | #include <linux/security.h> |
17 | 16 | ||
18 | /* Taken over from the old code... */ | 17 | /* Taken over from the old code... */ |
@@ -82,7 +81,7 @@ int inode_newsize_ok(const struct inode *inode, loff_t offset) | |||
82 | if (inode->i_size < offset) { | 81 | if (inode->i_size < offset) { |
83 | unsigned long limit; | 82 | unsigned long limit; |
84 | 83 | ||
85 | limit = current->signal->rlim[RLIMIT_FSIZE].rlim_cur; | 84 | limit = rlimit(RLIMIT_FSIZE); |
86 | if (limit != RLIM_INFINITY && offset > limit) | 85 | if (limit != RLIM_INFINITY && offset > limit) |
87 | goto out_sig; | 86 | goto out_sig; |
88 | if (offset > inode->i_sb->s_maxbytes) | 87 | if (offset > inode->i_sb->s_maxbytes) |
@@ -212,14 +211,8 @@ int notify_change(struct dentry * dentry, struct iattr * attr) | |||
212 | error = inode->i_op->setattr(dentry, attr); | 211 | error = inode->i_op->setattr(dentry, attr); |
213 | } else { | 212 | } else { |
214 | error = inode_change_ok(inode, attr); | 213 | error = inode_change_ok(inode, attr); |
215 | if (!error) { | 214 | if (!error) |
216 | if ((ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid) || | 215 | error = inode_setattr(inode, attr); |
217 | (ia_valid & ATTR_GID && attr->ia_gid != inode->i_gid)) | ||
218 | error = vfs_dq_transfer(inode, attr) ? | ||
219 | -EDQUOT : 0; | ||
220 | if (!error) | ||
221 | error = inode_setattr(inode, attr); | ||
222 | } | ||
223 | } | 216 | } |
224 | 217 | ||
225 | if (ia_valid & ATTR_SIZE) | 218 | if (ia_valid & ATTR_SIZE) |
diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h index 0118d67221b2..3d283abf67d7 100644 --- a/fs/autofs4/autofs_i.h +++ b/fs/autofs4/autofs_i.h | |||
@@ -60,11 +60,6 @@ do { \ | |||
60 | current->pid, __func__, ##args); \ | 60 | current->pid, __func__, ##args); \ |
61 | } while (0) | 61 | } while (0) |
62 | 62 | ||
63 | struct rehash_entry { | ||
64 | struct task_struct *task; | ||
65 | struct list_head list; | ||
66 | }; | ||
67 | |||
68 | /* Unified info structure. This is pointed to by both the dentry and | 63 | /* Unified info structure. This is pointed to by both the dentry and |
69 | inode structures. Each file in the filesystem has an instance of this | 64 | inode structures. Each file in the filesystem has an instance of this |
70 | structure. It holds a reference to the dentry, so dentries are never | 65 | structure. It holds a reference to the dentry, so dentries are never |
@@ -81,7 +76,6 @@ struct autofs_info { | |||
81 | 76 | ||
82 | struct list_head active; | 77 | struct list_head active; |
83 | int active_count; | 78 | int active_count; |
84 | struct list_head rehash_list; | ||
85 | 79 | ||
86 | struct list_head expiring; | 80 | struct list_head expiring; |
87 | 81 | ||
@@ -104,7 +98,6 @@ struct autofs_info { | |||
104 | #define AUTOFS_INF_EXPIRING (1<<0) /* dentry is in the process of expiring */ | 98 | #define AUTOFS_INF_EXPIRING (1<<0) /* dentry is in the process of expiring */ |
105 | #define AUTOFS_INF_MOUNTPOINT (1<<1) /* mountpoint status for direct expire */ | 99 | #define AUTOFS_INF_MOUNTPOINT (1<<1) /* mountpoint status for direct expire */ |
106 | #define AUTOFS_INF_PENDING (1<<2) /* dentry pending mount */ | 100 | #define AUTOFS_INF_PENDING (1<<2) /* dentry pending mount */ |
107 | #define AUTOFS_INF_REHASH (1<<3) /* dentry in transit to ->lookup() */ | ||
108 | 101 | ||
109 | struct autofs_wait_queue { | 102 | struct autofs_wait_queue { |
110 | wait_queue_head_t queue; | 103 | wait_queue_head_t queue; |
diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c index 00bf8fcb245f..c8a80dffb455 100644 --- a/fs/autofs4/dev-ioctl.c +++ b/fs/autofs4/dev-ioctl.c | |||
@@ -544,10 +544,9 @@ static int autofs_dev_ioctl_ismountpoint(struct file *fp, | |||
544 | goto out; | 544 | goto out; |
545 | devid = new_encode_dev(path.mnt->mnt_sb->s_dev); | 545 | devid = new_encode_dev(path.mnt->mnt_sb->s_dev); |
546 | err = 0; | 546 | err = 0; |
547 | if (path.dentry->d_inode && | 547 | if (path.mnt->mnt_root == path.dentry) { |
548 | path.mnt->mnt_root == path.dentry) { | ||
549 | err = 1; | 548 | err = 1; |
550 | magic = path.dentry->d_inode->i_sb->s_magic; | 549 | magic = path.mnt->mnt_sb->s_magic; |
551 | } | 550 | } |
552 | } else { | 551 | } else { |
553 | dev_t dev = sbi->sb->s_dev; | 552 | dev_t dev = sbi->sb->s_dev; |
@@ -560,10 +559,8 @@ static int autofs_dev_ioctl_ismountpoint(struct file *fp, | |||
560 | 559 | ||
561 | err = have_submounts(path.dentry); | 560 | err = have_submounts(path.dentry); |
562 | 561 | ||
563 | if (path.mnt->mnt_mountpoint != path.mnt->mnt_root) { | 562 | if (follow_down(&path)) |
564 | if (follow_down(&path)) | 563 | magic = path.mnt->mnt_sb->s_magic; |
565 | magic = path.mnt->mnt_sb->s_magic; | ||
566 | } | ||
567 | } | 564 | } |
568 | 565 | ||
569 | param->ismountpoint.out.devid = devid; | 566 | param->ismountpoint.out.devid = devid; |
diff --git a/fs/autofs4/expire.c b/fs/autofs4/expire.c index 74bc9aa6df31..a796c9417fb1 100644 --- a/fs/autofs4/expire.c +++ b/fs/autofs4/expire.c | |||
@@ -279,7 +279,6 @@ struct dentry *autofs4_expire_direct(struct super_block *sb, | |||
279 | root->d_mounted--; | 279 | root->d_mounted--; |
280 | } | 280 | } |
281 | ino->flags |= AUTOFS_INF_EXPIRING; | 281 | ino->flags |= AUTOFS_INF_EXPIRING; |
282 | autofs4_add_expiring(root); | ||
283 | init_completion(&ino->expire_complete); | 282 | init_completion(&ino->expire_complete); |
284 | spin_unlock(&sbi->fs_lock); | 283 | spin_unlock(&sbi->fs_lock); |
285 | return root; | 284 | return root; |
@@ -407,7 +406,6 @@ found: | |||
407 | expired, (int)expired->d_name.len, expired->d_name.name); | 406 | expired, (int)expired->d_name.len, expired->d_name.name); |
408 | ino = autofs4_dentry_ino(expired); | 407 | ino = autofs4_dentry_ino(expired); |
409 | ino->flags |= AUTOFS_INF_EXPIRING; | 408 | ino->flags |= AUTOFS_INF_EXPIRING; |
410 | autofs4_add_expiring(expired); | ||
411 | init_completion(&ino->expire_complete); | 409 | init_completion(&ino->expire_complete); |
412 | spin_unlock(&sbi->fs_lock); | 410 | spin_unlock(&sbi->fs_lock); |
413 | spin_lock(&dcache_lock); | 411 | spin_lock(&dcache_lock); |
@@ -435,7 +433,7 @@ int autofs4_expire_wait(struct dentry *dentry) | |||
435 | 433 | ||
436 | DPRINTK("expire done status=%d", status); | 434 | DPRINTK("expire done status=%d", status); |
437 | 435 | ||
438 | if (d_unhashed(dentry) && IS_DEADDIR(dentry->d_inode)) | 436 | if (d_unhashed(dentry)) |
439 | return -EAGAIN; | 437 | return -EAGAIN; |
440 | 438 | ||
441 | return status; | 439 | return status; |
@@ -475,7 +473,6 @@ int autofs4_expire_run(struct super_block *sb, | |||
475 | spin_lock(&sbi->fs_lock); | 473 | spin_lock(&sbi->fs_lock); |
476 | ino = autofs4_dentry_ino(dentry); | 474 | ino = autofs4_dentry_ino(dentry); |
477 | ino->flags &= ~AUTOFS_INF_EXPIRING; | 475 | ino->flags &= ~AUTOFS_INF_EXPIRING; |
478 | autofs4_del_expiring(dentry); | ||
479 | complete_all(&ino->expire_complete); | 476 | complete_all(&ino->expire_complete); |
480 | spin_unlock(&sbi->fs_lock); | 477 | spin_unlock(&sbi->fs_lock); |
481 | 478 | ||
@@ -506,7 +503,6 @@ int autofs4_do_expire_multi(struct super_block *sb, struct vfsmount *mnt, | |||
506 | ino->flags &= ~AUTOFS_INF_MOUNTPOINT; | 503 | ino->flags &= ~AUTOFS_INF_MOUNTPOINT; |
507 | } | 504 | } |
508 | ino->flags &= ~AUTOFS_INF_EXPIRING; | 505 | ino->flags &= ~AUTOFS_INF_EXPIRING; |
509 | autofs4_del_expiring(dentry); | ||
510 | complete_all(&ino->expire_complete); | 506 | complete_all(&ino->expire_complete); |
511 | spin_unlock(&sbi->fs_lock); | 507 | spin_unlock(&sbi->fs_lock); |
512 | dput(dentry); | 508 | dput(dentry); |
diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c index d0a3de247458..821b2b955dac 100644 --- a/fs/autofs4/inode.c +++ b/fs/autofs4/inode.c | |||
@@ -49,7 +49,6 @@ struct autofs_info *autofs4_init_ino(struct autofs_info *ino, | |||
49 | ino->dentry = NULL; | 49 | ino->dentry = NULL; |
50 | ino->size = 0; | 50 | ino->size = 0; |
51 | INIT_LIST_HEAD(&ino->active); | 51 | INIT_LIST_HEAD(&ino->active); |
52 | INIT_LIST_HEAD(&ino->rehash_list); | ||
53 | ino->active_count = 0; | 52 | ino->active_count = 0; |
54 | INIT_LIST_HEAD(&ino->expiring); | 53 | INIT_LIST_HEAD(&ino->expiring); |
55 | atomic_set(&ino->count, 0); | 54 | atomic_set(&ino->count, 0); |
@@ -97,63 +96,6 @@ void autofs4_free_ino(struct autofs_info *ino) | |||
97 | kfree(ino); | 96 | kfree(ino); |
98 | } | 97 | } |
99 | 98 | ||
100 | /* | ||
101 | * Deal with the infamous "Busy inodes after umount ..." message. | ||
102 | * | ||
103 | * Clean up the dentry tree. This happens with autofs if the user | ||
104 | * space program goes away due to a SIGKILL, SIGSEGV etc. | ||
105 | */ | ||
106 | static void autofs4_force_release(struct autofs_sb_info *sbi) | ||
107 | { | ||
108 | struct dentry *this_parent = sbi->sb->s_root; | ||
109 | struct list_head *next; | ||
110 | |||
111 | if (!sbi->sb->s_root) | ||
112 | return; | ||
113 | |||
114 | spin_lock(&dcache_lock); | ||
115 | repeat: | ||
116 | next = this_parent->d_subdirs.next; | ||
117 | resume: | ||
118 | while (next != &this_parent->d_subdirs) { | ||
119 | struct dentry *dentry = list_entry(next, struct dentry, d_u.d_child); | ||
120 | |||
121 | /* Negative dentry - don`t care */ | ||
122 | if (!simple_positive(dentry)) { | ||
123 | next = next->next; | ||
124 | continue; | ||
125 | } | ||
126 | |||
127 | if (!list_empty(&dentry->d_subdirs)) { | ||
128 | this_parent = dentry; | ||
129 | goto repeat; | ||
130 | } | ||
131 | |||
132 | next = next->next; | ||
133 | spin_unlock(&dcache_lock); | ||
134 | |||
135 | DPRINTK("dentry %p %.*s", | ||
136 | dentry, (int)dentry->d_name.len, dentry->d_name.name); | ||
137 | |||
138 | dput(dentry); | ||
139 | spin_lock(&dcache_lock); | ||
140 | } | ||
141 | |||
142 | if (this_parent != sbi->sb->s_root) { | ||
143 | struct dentry *dentry = this_parent; | ||
144 | |||
145 | next = this_parent->d_u.d_child.next; | ||
146 | this_parent = this_parent->d_parent; | ||
147 | spin_unlock(&dcache_lock); | ||
148 | DPRINTK("parent dentry %p %.*s", | ||
149 | dentry, (int)dentry->d_name.len, dentry->d_name.name); | ||
150 | dput(dentry); | ||
151 | spin_lock(&dcache_lock); | ||
152 | goto resume; | ||
153 | } | ||
154 | spin_unlock(&dcache_lock); | ||
155 | } | ||
156 | |||
157 | void autofs4_kill_sb(struct super_block *sb) | 99 | void autofs4_kill_sb(struct super_block *sb) |
158 | { | 100 | { |
159 | struct autofs_sb_info *sbi = autofs4_sbi(sb); | 101 | struct autofs_sb_info *sbi = autofs4_sbi(sb); |
@@ -170,15 +112,12 @@ void autofs4_kill_sb(struct super_block *sb) | |||
170 | /* Free wait queues, close pipe */ | 112 | /* Free wait queues, close pipe */ |
171 | autofs4_catatonic_mode(sbi); | 113 | autofs4_catatonic_mode(sbi); |
172 | 114 | ||
173 | /* Clean up and release dangling references */ | ||
174 | autofs4_force_release(sbi); | ||
175 | |||
176 | sb->s_fs_info = NULL; | 115 | sb->s_fs_info = NULL; |
177 | kfree(sbi); | 116 | kfree(sbi); |
178 | 117 | ||
179 | out_kill_sb: | 118 | out_kill_sb: |
180 | DPRINTK("shutting down"); | 119 | DPRINTK("shutting down"); |
181 | kill_anon_super(sb); | 120 | kill_litter_super(sb); |
182 | } | 121 | } |
183 | 122 | ||
184 | static int autofs4_show_options(struct seq_file *m, struct vfsmount *mnt) | 123 | static int autofs4_show_options(struct seq_file *m, struct vfsmount *mnt) |
diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c index 30cc9ddf4b70..a015b49891df 100644 --- a/fs/autofs4/root.c +++ b/fs/autofs4/root.c | |||
@@ -104,99 +104,6 @@ static void autofs4_del_active(struct dentry *dentry) | |||
104 | return; | 104 | return; |
105 | } | 105 | } |
106 | 106 | ||
107 | static void autofs4_add_rehash_entry(struct autofs_info *ino, | ||
108 | struct rehash_entry *entry) | ||
109 | { | ||
110 | entry->task = current; | ||
111 | INIT_LIST_HEAD(&entry->list); | ||
112 | list_add(&entry->list, &ino->rehash_list); | ||
113 | return; | ||
114 | } | ||
115 | |||
116 | static void autofs4_remove_rehash_entry(struct autofs_info *ino) | ||
117 | { | ||
118 | struct list_head *head = &ino->rehash_list; | ||
119 | struct rehash_entry *entry; | ||
120 | list_for_each_entry(entry, head, list) { | ||
121 | if (entry->task == current) { | ||
122 | list_del(&entry->list); | ||
123 | kfree(entry); | ||
124 | break; | ||
125 | } | ||
126 | } | ||
127 | return; | ||
128 | } | ||
129 | |||
130 | static void autofs4_remove_rehash_entrys(struct autofs_info *ino) | ||
131 | { | ||
132 | struct autofs_sb_info *sbi = ino->sbi; | ||
133 | struct rehash_entry *entry, *next; | ||
134 | struct list_head *head; | ||
135 | |||
136 | spin_lock(&sbi->fs_lock); | ||
137 | spin_lock(&sbi->lookup_lock); | ||
138 | if (!(ino->flags & AUTOFS_INF_REHASH)) { | ||
139 | spin_unlock(&sbi->lookup_lock); | ||
140 | spin_unlock(&sbi->fs_lock); | ||
141 | return; | ||
142 | } | ||
143 | ino->flags &= ~AUTOFS_INF_REHASH; | ||
144 | head = &ino->rehash_list; | ||
145 | list_for_each_entry_safe(entry, next, head, list) { | ||
146 | list_del(&entry->list); | ||
147 | kfree(entry); | ||
148 | } | ||
149 | spin_unlock(&sbi->lookup_lock); | ||
150 | spin_unlock(&sbi->fs_lock); | ||
151 | dput(ino->dentry); | ||
152 | |||
153 | return; | ||
154 | } | ||
155 | |||
156 | static void autofs4_revalidate_drop(struct dentry *dentry, | ||
157 | struct rehash_entry *entry) | ||
158 | { | ||
159 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); | ||
160 | struct autofs_info *ino = autofs4_dentry_ino(dentry); | ||
161 | /* | ||
162 | * Add to the active list so we can pick this up in | ||
163 | * ->lookup(). Also add an entry to a rehash list so | ||
164 | * we know when there are no dentrys in flight so we | ||
165 | * know when we can rehash the dentry. | ||
166 | */ | ||
167 | spin_lock(&sbi->lookup_lock); | ||
168 | if (list_empty(&ino->active)) | ||
169 | list_add(&ino->active, &sbi->active_list); | ||
170 | autofs4_add_rehash_entry(ino, entry); | ||
171 | spin_unlock(&sbi->lookup_lock); | ||
172 | if (!(ino->flags & AUTOFS_INF_REHASH)) { | ||
173 | ino->flags |= AUTOFS_INF_REHASH; | ||
174 | dget(dentry); | ||
175 | spin_lock(&dentry->d_lock); | ||
176 | __d_drop(dentry); | ||
177 | spin_unlock(&dentry->d_lock); | ||
178 | } | ||
179 | return; | ||
180 | } | ||
181 | |||
182 | static void autofs4_revalidate_rehash(struct dentry *dentry) | ||
183 | { | ||
184 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); | ||
185 | struct autofs_info *ino = autofs4_dentry_ino(dentry); | ||
186 | if (ino->flags & AUTOFS_INF_REHASH) { | ||
187 | spin_lock(&sbi->lookup_lock); | ||
188 | autofs4_remove_rehash_entry(ino); | ||
189 | if (list_empty(&ino->rehash_list)) { | ||
190 | spin_unlock(&sbi->lookup_lock); | ||
191 | ino->flags &= ~AUTOFS_INF_REHASH; | ||
192 | d_rehash(dentry); | ||
193 | dput(ino->dentry); | ||
194 | } else | ||
195 | spin_unlock(&sbi->lookup_lock); | ||
196 | } | ||
197 | return; | ||
198 | } | ||
199 | |||
200 | static unsigned int autofs4_need_mount(unsigned int flags) | 107 | static unsigned int autofs4_need_mount(unsigned int flags) |
201 | { | 108 | { |
202 | unsigned int res = 0; | 109 | unsigned int res = 0; |
@@ -236,7 +143,7 @@ out: | |||
236 | return dcache_dir_open(inode, file); | 143 | return dcache_dir_open(inode, file); |
237 | } | 144 | } |
238 | 145 | ||
239 | static int try_to_fill_dentry(struct dentry *dentry) | 146 | static int try_to_fill_dentry(struct dentry *dentry, int flags) |
240 | { | 147 | { |
241 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); | 148 | struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb); |
242 | struct autofs_info *ino = autofs4_dentry_ino(dentry); | 149 | struct autofs_info *ino = autofs4_dentry_ino(dentry); |
@@ -249,17 +156,55 @@ static int try_to_fill_dentry(struct dentry *dentry) | |||
249 | * Wait for a pending mount, triggering one if there | 156 | * Wait for a pending mount, triggering one if there |
250 | * isn't one already | 157 | * isn't one already |
251 | */ | 158 | */ |
252 | DPRINTK("waiting for mount name=%.*s", | 159 | if (dentry->d_inode == NULL) { |
253 | dentry->d_name.len, dentry->d_name.name); | 160 | DPRINTK("waiting for mount name=%.*s", |
161 | dentry->d_name.len, dentry->d_name.name); | ||
254 | 162 | ||
255 | status = autofs4_wait(sbi, dentry, NFY_MOUNT); | 163 | status = autofs4_wait(sbi, dentry, NFY_MOUNT); |
256 | 164 | ||
257 | DPRINTK("mount done status=%d", status); | 165 | DPRINTK("mount done status=%d", status); |
258 | 166 | ||
259 | /* Update expiry counter */ | 167 | /* Turn this into a real negative dentry? */ |
260 | ino->last_used = jiffies; | 168 | if (status == -ENOENT) { |
169 | spin_lock(&sbi->fs_lock); | ||
170 | ino->flags &= ~AUTOFS_INF_PENDING; | ||
171 | spin_unlock(&sbi->fs_lock); | ||
172 | return status; | ||
173 | } else if (status) { | ||
174 | /* Return a negative dentry, but leave it "pending" */ | ||
175 | return status; | ||
176 | } | ||
177 | /* Trigger mount for path component or follow link */ | ||
178 | } else if (ino->flags & AUTOFS_INF_PENDING || | ||
179 | autofs4_need_mount(flags) || | ||
180 | current->link_count) { | ||
181 | DPRINTK("waiting for mount name=%.*s", | ||
182 | dentry->d_name.len, dentry->d_name.name); | ||
261 | 183 | ||
262 | return status; | 184 | spin_lock(&sbi->fs_lock); |
185 | ino->flags |= AUTOFS_INF_PENDING; | ||
186 | spin_unlock(&sbi->fs_lock); | ||
187 | status = autofs4_wait(sbi, dentry, NFY_MOUNT); | ||
188 | |||
189 | DPRINTK("mount done status=%d", status); | ||
190 | |||
191 | if (status) { | ||
192 | spin_lock(&sbi->fs_lock); | ||
193 | ino->flags &= ~AUTOFS_INF_PENDING; | ||
194 | spin_unlock(&sbi->fs_lock); | ||
195 | return status; | ||
196 | } | ||
197 | } | ||
198 | |||
199 | /* Initialize expiry counter after successful mount */ | ||
200 | if (ino) | ||
201 | ino->last_used = jiffies; | ||
202 | |||
203 | spin_lock(&sbi->fs_lock); | ||
204 | ino->flags &= ~AUTOFS_INF_PENDING; | ||
205 | spin_unlock(&sbi->fs_lock); | ||
206 | |||
207 | return 0; | ||
263 | } | 208 | } |
264 | 209 | ||
265 | /* For autofs direct mounts the follow link triggers the mount */ | 210 | /* For autofs direct mounts the follow link triggers the mount */ |
@@ -313,16 +258,10 @@ static void *autofs4_follow_link(struct dentry *dentry, struct nameidata *nd) | |||
313 | */ | 258 | */ |
314 | if (ino->flags & AUTOFS_INF_PENDING || | 259 | if (ino->flags & AUTOFS_INF_PENDING || |
315 | (!d_mountpoint(dentry) && list_empty(&dentry->d_subdirs))) { | 260 | (!d_mountpoint(dentry) && list_empty(&dentry->d_subdirs))) { |
316 | ino->flags |= AUTOFS_INF_PENDING; | ||
317 | spin_unlock(&dcache_lock); | 261 | spin_unlock(&dcache_lock); |
318 | spin_unlock(&sbi->fs_lock); | 262 | spin_unlock(&sbi->fs_lock); |
319 | 263 | ||
320 | status = try_to_fill_dentry(dentry); | 264 | status = try_to_fill_dentry(dentry, 0); |
321 | |||
322 | spin_lock(&sbi->fs_lock); | ||
323 | ino->flags &= ~AUTOFS_INF_PENDING; | ||
324 | spin_unlock(&sbi->fs_lock); | ||
325 | |||
326 | if (status) | 265 | if (status) |
327 | goto out_error; | 266 | goto out_error; |
328 | 267 | ||
@@ -361,47 +300,18 @@ static int autofs4_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
361 | { | 300 | { |
362 | struct inode *dir = dentry->d_parent->d_inode; | 301 | struct inode *dir = dentry->d_parent->d_inode; |
363 | struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); | 302 | struct autofs_sb_info *sbi = autofs4_sbi(dir->i_sb); |
364 | struct autofs_info *ino = autofs4_dentry_ino(dentry); | 303 | int oz_mode = autofs4_oz_mode(sbi); |
365 | struct rehash_entry *entry; | ||
366 | int flags = nd ? nd->flags : 0; | 304 | int flags = nd ? nd->flags : 0; |
367 | unsigned int mutex_aquired; | 305 | int status = 1; |
368 | 306 | ||
369 | DPRINTK("name = %.*s oz_mode = %d", | ||
370 | dentry->d_name.len, dentry->d_name.name, oz_mode); | ||
371 | |||
372 | /* Daemon never causes a mount to trigger */ | ||
373 | if (autofs4_oz_mode(sbi)) | ||
374 | return 1; | ||
375 | |||
376 | entry = kmalloc(sizeof(struct rehash_entry), GFP_KERNEL); | ||
377 | if (!entry) | ||
378 | return -ENOMEM; | ||
379 | |||
380 | mutex_aquired = mutex_trylock(&dir->i_mutex); | ||
381 | |||
382 | spin_lock(&sbi->fs_lock); | ||
383 | spin_lock(&dcache_lock); | ||
384 | /* Pending dentry */ | 307 | /* Pending dentry */ |
308 | spin_lock(&sbi->fs_lock); | ||
385 | if (autofs4_ispending(dentry)) { | 309 | if (autofs4_ispending(dentry)) { |
386 | int status; | 310 | /* The daemon never causes a mount to trigger */ |
387 | |||
388 | /* | ||
389 | * We can only unhash and send this to ->lookup() if | ||
390 | * the directory mutex is held over d_revalidate() and | ||
391 | * ->lookup(). This prevents the VFS from incorrectly | ||
392 | * seeing the dentry as non-existent. | ||
393 | */ | ||
394 | ino->flags |= AUTOFS_INF_PENDING; | ||
395 | if (!mutex_aquired) { | ||
396 | autofs4_revalidate_drop(dentry, entry); | ||
397 | spin_unlock(&dcache_lock); | ||
398 | spin_unlock(&sbi->fs_lock); | ||
399 | return 0; | ||
400 | } | ||
401 | spin_unlock(&dcache_lock); | ||
402 | spin_unlock(&sbi->fs_lock); | 311 | spin_unlock(&sbi->fs_lock); |
403 | mutex_unlock(&dir->i_mutex); | 312 | |
404 | kfree(entry); | 313 | if (oz_mode) |
314 | return 1; | ||
405 | 315 | ||
406 | /* | 316 | /* |
407 | * If the directory has gone away due to an expire | 317 | * If the directory has gone away due to an expire |
@@ -415,82 +325,45 @@ static int autofs4_revalidate(struct dentry *dentry, struct nameidata *nd) | |||
415 | * A zero status is success otherwise we have a | 325 | * A zero status is success otherwise we have a |
416 | * negative error code. | 326 | * negative error code. |
417 | */ | 327 | */ |
418 | status = try_to_fill_dentry(dentry); | 328 | status = try_to_fill_dentry(dentry, flags); |
419 | |||
420 | spin_lock(&sbi->fs_lock); | ||
421 | ino->flags &= ~AUTOFS_INF_PENDING; | ||
422 | spin_unlock(&sbi->fs_lock); | ||
423 | |||
424 | if (status == 0) | 329 | if (status == 0) |
425 | return 1; | 330 | return 1; |
426 | 331 | ||
427 | return status; | 332 | return status; |
428 | } | 333 | } |
334 | spin_unlock(&sbi->fs_lock); | ||
335 | |||
336 | /* Negative dentry.. invalidate if "old" */ | ||
337 | if (dentry->d_inode == NULL) | ||
338 | return 0; | ||
429 | 339 | ||
430 | /* Check for a non-mountpoint directory with no contents */ | 340 | /* Check for a non-mountpoint directory with no contents */ |
341 | spin_lock(&dcache_lock); | ||
431 | if (S_ISDIR(dentry->d_inode->i_mode) && | 342 | if (S_ISDIR(dentry->d_inode->i_mode) && |
432 | !d_mountpoint(dentry) && list_empty(&dentry->d_subdirs)) { | 343 | !d_mountpoint(dentry) && list_empty(&dentry->d_subdirs)) { |
433 | DPRINTK("dentry=%p %.*s, emptydir", | 344 | DPRINTK("dentry=%p %.*s, emptydir", |
434 | dentry, dentry->d_name.len, dentry->d_name.name); | 345 | dentry, dentry->d_name.len, dentry->d_name.name); |
346 | spin_unlock(&dcache_lock); | ||
435 | 347 | ||
436 | if (autofs4_need_mount(flags) || current->link_count) { | 348 | /* The daemon never causes a mount to trigger */ |
437 | int status; | 349 | if (oz_mode) |
438 | 350 | return 1; | |
439 | /* | ||
440 | * We can only unhash and send this to ->lookup() if | ||
441 | * the directory mutex is held over d_revalidate() and | ||
442 | * ->lookup(). This prevents the VFS from incorrectly | ||
443 | * seeing the dentry as non-existent. | ||
444 | */ | ||
445 | ino->flags |= AUTOFS_INF_PENDING; | ||
446 | if (!mutex_aquired) { | ||
447 | autofs4_revalidate_drop(dentry, entry); | ||
448 | spin_unlock(&dcache_lock); | ||
449 | spin_unlock(&sbi->fs_lock); | ||
450 | return 0; | ||
451 | } | ||
452 | spin_unlock(&dcache_lock); | ||
453 | spin_unlock(&sbi->fs_lock); | ||
454 | mutex_unlock(&dir->i_mutex); | ||
455 | kfree(entry); | ||
456 | |||
457 | /* | ||
458 | * A zero status is success otherwise we have a | ||
459 | * negative error code. | ||
460 | */ | ||
461 | status = try_to_fill_dentry(dentry); | ||
462 | |||
463 | spin_lock(&sbi->fs_lock); | ||
464 | ino->flags &= ~AUTOFS_INF_PENDING; | ||
465 | spin_unlock(&sbi->fs_lock); | ||
466 | 351 | ||
467 | if (status == 0) | 352 | /* |
468 | return 1; | 353 | * A zero status is success otherwise we have a |
354 | * negative error code. | ||
355 | */ | ||
356 | status = try_to_fill_dentry(dentry, flags); | ||
357 | if (status == 0) | ||
358 | return 1; | ||
469 | 359 | ||
470 | return status; | 360 | return status; |
471 | } | ||
472 | } | 361 | } |
473 | spin_unlock(&dcache_lock); | 362 | spin_unlock(&dcache_lock); |
474 | spin_unlock(&sbi->fs_lock); | ||
475 | |||
476 | if (mutex_aquired) | ||
477 | mutex_unlock(&dir->i_mutex); | ||
478 | |||
479 | kfree(entry); | ||
480 | 363 | ||
481 | return 1; | 364 | return 1; |
482 | } | 365 | } |
483 | 366 | ||
484 | static void autofs4_free_rehash_entrys(struct autofs_info *inf) | ||
485 | { | ||
486 | struct list_head *head = &inf->rehash_list; | ||
487 | struct rehash_entry *entry, *next; | ||
488 | list_for_each_entry_safe(entry, next, head, list) { | ||
489 | list_del(&entry->list); | ||
490 | kfree(entry); | ||
491 | } | ||
492 | } | ||
493 | |||
494 | void autofs4_dentry_release(struct dentry *de) | 367 | void autofs4_dentry_release(struct dentry *de) |
495 | { | 368 | { |
496 | struct autofs_info *inf; | 369 | struct autofs_info *inf; |
@@ -509,8 +382,6 @@ void autofs4_dentry_release(struct dentry *de) | |||
509 | list_del(&inf->active); | 382 | list_del(&inf->active); |
510 | if (!list_empty(&inf->expiring)) | 383 | if (!list_empty(&inf->expiring)) |
511 | list_del(&inf->expiring); | 384 | list_del(&inf->expiring); |
512 | if (!list_empty(&inf->rehash_list)) | ||
513 | autofs4_free_rehash_entrys(inf); | ||
514 | spin_unlock(&sbi->lookup_lock); | 385 | spin_unlock(&sbi->lookup_lock); |
515 | } | 386 | } |
516 | 387 | ||
@@ -543,7 +414,6 @@ static struct dentry *autofs4_lookup_active(struct dentry *dentry) | |||
543 | const unsigned char *str = name->name; | 414 | const unsigned char *str = name->name; |
544 | struct list_head *p, *head; | 415 | struct list_head *p, *head; |
545 | 416 | ||
546 | restart: | ||
547 | spin_lock(&dcache_lock); | 417 | spin_lock(&dcache_lock); |
548 | spin_lock(&sbi->lookup_lock); | 418 | spin_lock(&sbi->lookup_lock); |
549 | head = &sbi->active_list; | 419 | head = &sbi->active_list; |
@@ -561,19 +431,6 @@ restart: | |||
561 | if (atomic_read(&active->d_count) == 0) | 431 | if (atomic_read(&active->d_count) == 0) |
562 | goto next; | 432 | goto next; |
563 | 433 | ||
564 | if (active->d_inode && IS_DEADDIR(active->d_inode)) { | ||
565 | if (!list_empty(&ino->rehash_list)) { | ||
566 | dget(active); | ||
567 | spin_unlock(&active->d_lock); | ||
568 | spin_unlock(&sbi->lookup_lock); | ||
569 | spin_unlock(&dcache_lock); | ||
570 | autofs4_remove_rehash_entrys(ino); | ||
571 | dput(active); | ||
572 | goto restart; | ||
573 | } | ||
574 | goto next; | ||
575 | } | ||
576 | |||
577 | qstr = &active->d_name; | 434 | qstr = &active->d_name; |
578 | 435 | ||
579 | if (active->d_name.hash != hash) | 436 | if (active->d_name.hash != hash) |
@@ -586,11 +443,13 @@ restart: | |||
586 | if (memcmp(qstr->name, str, len)) | 443 | if (memcmp(qstr->name, str, len)) |
587 | goto next; | 444 | goto next; |
588 | 445 | ||
589 | dget(active); | 446 | if (d_unhashed(active)) { |
590 | spin_unlock(&active->d_lock); | 447 | dget(active); |
591 | spin_unlock(&sbi->lookup_lock); | 448 | spin_unlock(&active->d_lock); |
592 | spin_unlock(&dcache_lock); | 449 | spin_unlock(&sbi->lookup_lock); |
593 | return active; | 450 | spin_unlock(&dcache_lock); |
451 | return active; | ||
452 | } | ||
594 | next: | 453 | next: |
595 | spin_unlock(&active->d_lock); | 454 | spin_unlock(&active->d_lock); |
596 | } | 455 | } |
@@ -639,11 +498,13 @@ static struct dentry *autofs4_lookup_expiring(struct dentry *dentry) | |||
639 | if (memcmp(qstr->name, str, len)) | 498 | if (memcmp(qstr->name, str, len)) |
640 | goto next; | 499 | goto next; |
641 | 500 | ||
642 | dget(expiring); | 501 | if (d_unhashed(expiring)) { |
643 | spin_unlock(&expiring->d_lock); | 502 | dget(expiring); |
644 | spin_unlock(&sbi->lookup_lock); | 503 | spin_unlock(&expiring->d_lock); |
645 | spin_unlock(&dcache_lock); | 504 | spin_unlock(&sbi->lookup_lock); |
646 | return expiring; | 505 | spin_unlock(&dcache_lock); |
506 | return expiring; | ||
507 | } | ||
647 | next: | 508 | next: |
648 | spin_unlock(&expiring->d_lock); | 509 | spin_unlock(&expiring->d_lock); |
649 | } | 510 | } |
@@ -653,48 +514,6 @@ next: | |||
653 | return NULL; | 514 | return NULL; |
654 | } | 515 | } |
655 | 516 | ||
656 | static struct autofs_info *init_new_dentry(struct autofs_sb_info *sbi, | ||
657 | struct dentry *dentry, int oz_mode) | ||
658 | { | ||
659 | struct autofs_info *ino; | ||
660 | |||
661 | /* | ||
662 | * Mark the dentry incomplete but don't hash it. We do this | ||
663 | * to serialize our inode creation operations (symlink and | ||
664 | * mkdir) which prevents deadlock during the callback to | ||
665 | * the daemon. Subsequent user space lookups for the same | ||
666 | * dentry are placed on the wait queue while the daemon | ||
667 | * itself is allowed passage unresticted so the create | ||
668 | * operation itself can then hash the dentry. Finally, | ||
669 | * we check for the hashed dentry and return the newly | ||
670 | * hashed dentry. | ||
671 | */ | ||
672 | dentry->d_op = &autofs4_root_dentry_operations; | ||
673 | |||
674 | /* | ||
675 | * And we need to ensure that the same dentry is used for | ||
676 | * all following lookup calls until it is hashed so that | ||
677 | * the dentry flags are persistent throughout the request. | ||
678 | */ | ||
679 | ino = autofs4_init_ino(NULL, sbi, 0555); | ||
680 | if (!ino) | ||
681 | return ERR_PTR(-ENOMEM); | ||
682 | |||
683 | dentry->d_fsdata = ino; | ||
684 | ino->dentry = dentry; | ||
685 | |||
686 | /* | ||
687 | * Only set the mount pending flag for new dentrys not created | ||
688 | * by the daemon. | ||
689 | */ | ||
690 | if (!oz_mode) | ||
691 | ino->flags |= AUTOFS_INF_PENDING; | ||
692 | |||
693 | d_instantiate(dentry, NULL); | ||
694 | |||
695 | return ino; | ||
696 | } | ||
697 | |||
698 | /* Lookups in the root directory */ | 517 | /* Lookups in the root directory */ |
699 | static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 518 | static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) |
700 | { | 519 | { |
@@ -702,7 +521,6 @@ static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, s | |||
702 | struct autofs_info *ino; | 521 | struct autofs_info *ino; |
703 | struct dentry *expiring, *active; | 522 | struct dentry *expiring, *active; |
704 | int oz_mode; | 523 | int oz_mode; |
705 | int status = 0; | ||
706 | 524 | ||
707 | DPRINTK("name = %.*s", | 525 | DPRINTK("name = %.*s", |
708 | dentry->d_name.len, dentry->d_name.name); | 526 | dentry->d_name.len, dentry->d_name.name); |
@@ -717,26 +535,44 @@ static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, s | |||
717 | DPRINTK("pid = %u, pgrp = %u, catatonic = %d, oz_mode = %d", | 535 | DPRINTK("pid = %u, pgrp = %u, catatonic = %d, oz_mode = %d", |
718 | current->pid, task_pgrp_nr(current), sbi->catatonic, oz_mode); | 536 | current->pid, task_pgrp_nr(current), sbi->catatonic, oz_mode); |
719 | 537 | ||
720 | spin_lock(&sbi->fs_lock); | ||
721 | active = autofs4_lookup_active(dentry); | 538 | active = autofs4_lookup_active(dentry); |
722 | if (active) { | 539 | if (active) { |
723 | dentry = active; | 540 | dentry = active; |
724 | ino = autofs4_dentry_ino(dentry); | 541 | ino = autofs4_dentry_ino(dentry); |
725 | /* If this came from revalidate, rehash it */ | ||
726 | autofs4_revalidate_rehash(dentry); | ||
727 | spin_unlock(&sbi->fs_lock); | ||
728 | } else { | 542 | } else { |
729 | spin_unlock(&sbi->fs_lock); | 543 | /* |
730 | ino = init_new_dentry(sbi, dentry, oz_mode); | 544 | * Mark the dentry incomplete but don't hash it. We do this |
731 | if (IS_ERR(ino)) | 545 | * to serialize our inode creation operations (symlink and |
732 | return (struct dentry *) ino; | 546 | * mkdir) which prevents deadlock during the callback to |
733 | } | 547 | * the daemon. Subsequent user space lookups for the same |
548 | * dentry are placed on the wait queue while the daemon | ||
549 | * itself is allowed passage unresticted so the create | ||
550 | * operation itself can then hash the dentry. Finally, | ||
551 | * we check for the hashed dentry and return the newly | ||
552 | * hashed dentry. | ||
553 | */ | ||
554 | dentry->d_op = &autofs4_root_dentry_operations; | ||
555 | |||
556 | /* | ||
557 | * And we need to ensure that the same dentry is used for | ||
558 | * all following lookup calls until it is hashed so that | ||
559 | * the dentry flags are persistent throughout the request. | ||
560 | */ | ||
561 | ino = autofs4_init_ino(NULL, sbi, 0555); | ||
562 | if (!ino) | ||
563 | return ERR_PTR(-ENOMEM); | ||
734 | 564 | ||
735 | autofs4_add_active(dentry); | 565 | dentry->d_fsdata = ino; |
566 | ino->dentry = dentry; | ||
567 | |||
568 | autofs4_add_active(dentry); | ||
569 | |||
570 | d_instantiate(dentry, NULL); | ||
571 | } | ||
736 | 572 | ||
737 | if (!oz_mode) { | 573 | if (!oz_mode) { |
738 | expiring = autofs4_lookup_expiring(dentry); | ||
739 | mutex_unlock(&dir->i_mutex); | 574 | mutex_unlock(&dir->i_mutex); |
575 | expiring = autofs4_lookup_expiring(dentry); | ||
740 | if (expiring) { | 576 | if (expiring) { |
741 | /* | 577 | /* |
742 | * If we are racing with expire the request might not | 578 | * If we are racing with expire the request might not |
@@ -744,22 +580,23 @@ static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, s | |||
744 | * so it must have been successful, so just wait for it. | 580 | * so it must have been successful, so just wait for it. |
745 | */ | 581 | */ |
746 | autofs4_expire_wait(expiring); | 582 | autofs4_expire_wait(expiring); |
583 | autofs4_del_expiring(expiring); | ||
747 | dput(expiring); | 584 | dput(expiring); |
748 | } | 585 | } |
749 | status = try_to_fill_dentry(dentry); | 586 | |
750 | mutex_lock(&dir->i_mutex); | ||
751 | spin_lock(&sbi->fs_lock); | 587 | spin_lock(&sbi->fs_lock); |
752 | ino->flags &= ~AUTOFS_INF_PENDING; | 588 | ino->flags |= AUTOFS_INF_PENDING; |
753 | spin_unlock(&sbi->fs_lock); | 589 | spin_unlock(&sbi->fs_lock); |
590 | if (dentry->d_op && dentry->d_op->d_revalidate) | ||
591 | (dentry->d_op->d_revalidate)(dentry, nd); | ||
592 | mutex_lock(&dir->i_mutex); | ||
754 | } | 593 | } |
755 | 594 | ||
756 | autofs4_del_active(dentry); | ||
757 | |||
758 | /* | 595 | /* |
759 | * If we had a mount fail, check if we had to handle | 596 | * If we are still pending, check if we had to handle |
760 | * a signal. If so we can force a restart.. | 597 | * a signal. If so we can force a restart.. |
761 | */ | 598 | */ |
762 | if (status) { | 599 | if (ino->flags & AUTOFS_INF_PENDING) { |
763 | /* See if we were interrupted */ | 600 | /* See if we were interrupted */ |
764 | if (signal_pending(current)) { | 601 | if (signal_pending(current)) { |
765 | sigset_t *sigset = ¤t->pending.signal; | 602 | sigset_t *sigset = ¤t->pending.signal; |
@@ -771,46 +608,43 @@ static struct dentry *autofs4_lookup(struct inode *dir, struct dentry *dentry, s | |||
771 | return ERR_PTR(-ERESTARTNOINTR); | 608 | return ERR_PTR(-ERESTARTNOINTR); |
772 | } | 609 | } |
773 | } | 610 | } |
774 | } | 611 | if (!oz_mode) { |
775 | 612 | spin_lock(&sbi->fs_lock); | |
776 | /* | 613 | ino->flags &= ~AUTOFS_INF_PENDING; |
777 | * User space can (and has done in the past) remove and re-create | 614 | spin_unlock(&sbi->fs_lock); |
778 | * this directory during the callback. This can leave us with an | ||
779 | * unhashed dentry, but a successful mount! So we need to | ||
780 | * perform another cached lookup in case the dentry now exists. | ||
781 | */ | ||
782 | if (!oz_mode && !have_submounts(dentry)) { | ||
783 | struct dentry *new; | ||
784 | new = d_lookup(dentry->d_parent, &dentry->d_name); | ||
785 | if (new) { | ||
786 | if (active) | ||
787 | dput(active); | ||
788 | return new; | ||
789 | } else { | ||
790 | if (!status) | ||
791 | status = -ENOENT; | ||
792 | } | 615 | } |
793 | } | 616 | } |
794 | 617 | ||
795 | /* | 618 | /* |
796 | * If we had a mount failure, return status to user space. | 619 | * If this dentry is unhashed, then we shouldn't honour this |
797 | * If the mount succeeded and we used a dentry from the active queue | 620 | * lookup. Returning ENOENT here doesn't do the right thing |
798 | * return it. | 621 | * for all system calls, but it should be OK for the operations |
622 | * we permit from an autofs. | ||
799 | */ | 623 | */ |
800 | if (status) { | 624 | if (!oz_mode && d_unhashed(dentry)) { |
801 | dentry = ERR_PTR(status); | ||
802 | if (active) | ||
803 | dput(active); | ||
804 | return dentry; | ||
805 | } else { | ||
806 | /* | 625 | /* |
807 | * Valid successful mount, return active dentry or NULL | 626 | * A user space application can (and has done in the past) |
808 | * for a new dentry. | 627 | * remove and re-create this directory during the callback. |
628 | * This can leave us with an unhashed dentry, but a | ||
629 | * successful mount! So we need to perform another | ||
630 | * cached lookup in case the dentry now exists. | ||
809 | */ | 631 | */ |
632 | struct dentry *parent = dentry->d_parent; | ||
633 | struct dentry *new = d_lookup(parent, &dentry->d_name); | ||
634 | if (new != NULL) | ||
635 | dentry = new; | ||
636 | else | ||
637 | dentry = ERR_PTR(-ENOENT); | ||
638 | |||
810 | if (active) | 639 | if (active) |
811 | return active; | 640 | dput(active); |
641 | |||
642 | return dentry; | ||
812 | } | 643 | } |
813 | 644 | ||
645 | if (active) | ||
646 | return active; | ||
647 | |||
814 | return NULL; | 648 | return NULL; |
815 | } | 649 | } |
816 | 650 | ||
@@ -834,6 +668,8 @@ static int autofs4_dir_symlink(struct inode *dir, | |||
834 | if (!ino) | 668 | if (!ino) |
835 | return -ENOMEM; | 669 | return -ENOMEM; |
836 | 670 | ||
671 | autofs4_del_active(dentry); | ||
672 | |||
837 | ino->size = strlen(symname); | 673 | ino->size = strlen(symname); |
838 | cp = kmalloc(ino->size + 1, GFP_KERNEL); | 674 | cp = kmalloc(ino->size + 1, GFP_KERNEL); |
839 | if (!cp) { | 675 | if (!cp) { |
@@ -910,6 +746,7 @@ static int autofs4_dir_unlink(struct inode *dir, struct dentry *dentry) | |||
910 | dir->i_mtime = CURRENT_TIME; | 746 | dir->i_mtime = CURRENT_TIME; |
911 | 747 | ||
912 | spin_lock(&dcache_lock); | 748 | spin_lock(&dcache_lock); |
749 | autofs4_add_expiring(dentry); | ||
913 | spin_lock(&dentry->d_lock); | 750 | spin_lock(&dentry->d_lock); |
914 | __d_drop(dentry); | 751 | __d_drop(dentry); |
915 | spin_unlock(&dentry->d_lock); | 752 | spin_unlock(&dentry->d_lock); |
@@ -935,6 +772,7 @@ static int autofs4_dir_rmdir(struct inode *dir, struct dentry *dentry) | |||
935 | spin_unlock(&dcache_lock); | 772 | spin_unlock(&dcache_lock); |
936 | return -ENOTEMPTY; | 773 | return -ENOTEMPTY; |
937 | } | 774 | } |
775 | autofs4_add_expiring(dentry); | ||
938 | spin_lock(&dentry->d_lock); | 776 | spin_lock(&dentry->d_lock); |
939 | __d_drop(dentry); | 777 | __d_drop(dentry); |
940 | spin_unlock(&dentry->d_lock); | 778 | spin_unlock(&dentry->d_lock); |
@@ -972,6 +810,8 @@ static int autofs4_dir_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
972 | if (!ino) | 810 | if (!ino) |
973 | return -ENOMEM; | 811 | return -ENOMEM; |
974 | 812 | ||
813 | autofs4_del_active(dentry); | ||
814 | |||
975 | inode = autofs4_get_inode(dir->i_sb, ino); | 815 | inode = autofs4_get_inode(dir->i_sb, ino); |
976 | if (!inode) { | 816 | if (!inode) { |
977 | if (!dentry->d_fsdata) | 817 | if (!dentry->d_fsdata) |
diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c index 8f3d9fd89604..f22a7d3dc362 100644 --- a/fs/bfs/inode.c +++ b/fs/bfs/inode.c | |||
@@ -15,6 +15,7 @@ | |||
15 | #include <linux/smp_lock.h> | 15 | #include <linux/smp_lock.h> |
16 | #include <linux/buffer_head.h> | 16 | #include <linux/buffer_head.h> |
17 | #include <linux/vfs.h> | 17 | #include <linux/vfs.h> |
18 | #include <linux/writeback.h> | ||
18 | #include <asm/uaccess.h> | 19 | #include <asm/uaccess.h> |
19 | #include "bfs.h" | 20 | #include "bfs.h" |
20 | 21 | ||
@@ -98,7 +99,7 @@ error: | |||
98 | return ERR_PTR(-EIO); | 99 | return ERR_PTR(-EIO); |
99 | } | 100 | } |
100 | 101 | ||
101 | static int bfs_write_inode(struct inode *inode, int wait) | 102 | static int bfs_write_inode(struct inode *inode, struct writeback_control *wbc) |
102 | { | 103 | { |
103 | struct bfs_sb_info *info = BFS_SB(inode->i_sb); | 104 | struct bfs_sb_info *info = BFS_SB(inode->i_sb); |
104 | unsigned int ino = (u16)inode->i_ino; | 105 | unsigned int ino = (u16)inode->i_ino; |
@@ -147,7 +148,7 @@ static int bfs_write_inode(struct inode *inode, int wait) | |||
147 | di->i_eoffset = cpu_to_le32(i_sblock * BFS_BSIZE + inode->i_size - 1); | 148 | di->i_eoffset = cpu_to_le32(i_sblock * BFS_BSIZE + inode->i_size - 1); |
148 | 149 | ||
149 | mark_buffer_dirty(bh); | 150 | mark_buffer_dirty(bh); |
150 | if (wait) { | 151 | if (wbc->sync_mode == WB_SYNC_ALL) { |
151 | sync_dirty_buffer(bh); | 152 | sync_dirty_buffer(bh); |
152 | if (buffer_req(bh) && !buffer_uptodate(bh)) | 153 | if (buffer_req(bh) && !buffer_uptodate(bh)) |
153 | err = -EIO; | 154 | err = -EIO; |
diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c index fdd397099172..15d80bb35d6f 100644 --- a/fs/binfmt_aout.c +++ b/fs/binfmt_aout.c | |||
@@ -24,6 +24,7 @@ | |||
24 | #include <linux/binfmts.h> | 24 | #include <linux/binfmts.h> |
25 | #include <linux/personality.h> | 25 | #include <linux/personality.h> |
26 | #include <linux/init.h> | 26 | #include <linux/init.h> |
27 | #include <linux/coredump.h> | ||
27 | 28 | ||
28 | #include <asm/system.h> | 29 | #include <asm/system.h> |
29 | #include <asm/uaccess.h> | 30 | #include <asm/uaccess.h> |
@@ -60,26 +61,6 @@ static int set_brk(unsigned long start, unsigned long end) | |||
60 | } | 61 | } |
61 | 62 | ||
62 | /* | 63 | /* |
63 | * These are the only things you should do on a core-file: use only these | ||
64 | * macros to write out all the necessary info. | ||
65 | */ | ||
66 | |||
67 | static int dump_write(struct file *file, const void *addr, int nr) | ||
68 | { | ||
69 | return file->f_op->write(file, addr, nr, &file->f_pos) == nr; | ||
70 | } | ||
71 | |||
72 | #define DUMP_WRITE(addr, nr) \ | ||
73 | if (!dump_write(file, (void *)(addr), (nr))) \ | ||
74 | goto end_coredump; | ||
75 | |||
76 | #define DUMP_SEEK(offset) \ | ||
77 | if (file->f_op->llseek) { \ | ||
78 | if (file->f_op->llseek(file,(offset),0) != (offset)) \ | ||
79 | goto end_coredump; \ | ||
80 | } else file->f_pos = (offset) | ||
81 | |||
82 | /* | ||
83 | * Routine writes a core dump image in the current directory. | 64 | * Routine writes a core dump image in the current directory. |
84 | * Currently only a stub-function. | 65 | * Currently only a stub-function. |
85 | * | 66 | * |
@@ -130,26 +111,31 @@ static int aout_core_dump(struct coredump_params *cprm) | |||
130 | 111 | ||
131 | set_fs(KERNEL_DS); | 112 | set_fs(KERNEL_DS); |
132 | /* struct user */ | 113 | /* struct user */ |
133 | DUMP_WRITE(&dump,sizeof(dump)); | 114 | if (!dump_write(file, &dump, sizeof(dump))) |
115 | goto end_coredump; | ||
134 | /* Now dump all of the user data. Include malloced stuff as well */ | 116 | /* Now dump all of the user data. Include malloced stuff as well */ |
135 | DUMP_SEEK(PAGE_SIZE); | 117 | if (!dump_seek(cprm->file, PAGE_SIZE - sizeof(dump))) |
118 | goto end_coredump; | ||
136 | /* now we start writing out the user space info */ | 119 | /* now we start writing out the user space info */ |
137 | set_fs(USER_DS); | 120 | set_fs(USER_DS); |
138 | /* Dump the data area */ | 121 | /* Dump the data area */ |
139 | if (dump.u_dsize != 0) { | 122 | if (dump.u_dsize != 0) { |
140 | dump_start = START_DATA(dump); | 123 | dump_start = START_DATA(dump); |
141 | dump_size = dump.u_dsize << PAGE_SHIFT; | 124 | dump_size = dump.u_dsize << PAGE_SHIFT; |
142 | DUMP_WRITE(dump_start,dump_size); | 125 | if (!dump_write(file, dump_start, dump_size)) |
126 | goto end_coredump; | ||
143 | } | 127 | } |
144 | /* Now prepare to dump the stack area */ | 128 | /* Now prepare to dump the stack area */ |
145 | if (dump.u_ssize != 0) { | 129 | if (dump.u_ssize != 0) { |
146 | dump_start = START_STACK(dump); | 130 | dump_start = START_STACK(dump); |
147 | dump_size = dump.u_ssize << PAGE_SHIFT; | 131 | dump_size = dump.u_ssize << PAGE_SHIFT; |
148 | DUMP_WRITE(dump_start,dump_size); | 132 | if (!dump_write(file, dump_start, dump_size)) |
133 | goto end_coredump; | ||
149 | } | 134 | } |
150 | /* Finally dump the task struct. Not be used by gdb, but could be useful */ | 135 | /* Finally dump the task struct. Not be used by gdb, but could be useful */ |
151 | set_fs(KERNEL_DS); | 136 | set_fs(KERNEL_DS); |
152 | DUMP_WRITE(current,sizeof(*current)); | 137 | if (!dump_write(file, current, sizeof(*current))) |
138 | goto end_coredump; | ||
153 | end_coredump: | 139 | end_coredump: |
154 | set_fs(fs); | 140 | set_fs(fs); |
155 | return has_dumped; | 141 | return has_dumped; |
@@ -247,7 +233,7 @@ static int load_aout_binary(struct linux_binprm * bprm, struct pt_regs * regs) | |||
247 | * size limits imposed on them by creating programs with large | 233 | * size limits imposed on them by creating programs with large |
248 | * arrays in the data or bss. | 234 | * arrays in the data or bss. |
249 | */ | 235 | */ |
250 | rlim = current->signal->rlim[RLIMIT_DATA].rlim_cur; | 236 | rlim = rlimit(RLIMIT_DATA); |
251 | if (rlim >= RLIM_INFINITY) | 237 | if (rlim >= RLIM_INFINITY) |
252 | rlim = ~0; | 238 | rlim = ~0; |
253 | if (ex.a_data + ex.a_bss > rlim) | 239 | if (ex.a_data + ex.a_bss > rlim) |
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index fd5b2ea5d299..535e763ab1a6 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c | |||
@@ -31,6 +31,7 @@ | |||
31 | #include <linux/random.h> | 31 | #include <linux/random.h> |
32 | #include <linux/elf.h> | 32 | #include <linux/elf.h> |
33 | #include <linux/utsname.h> | 33 | #include <linux/utsname.h> |
34 | #include <linux/coredump.h> | ||
34 | #include <asm/uaccess.h> | 35 | #include <asm/uaccess.h> |
35 | #include <asm/param.h> | 36 | #include <asm/param.h> |
36 | #include <asm/page.h> | 37 | #include <asm/page.h> |
@@ -1085,36 +1086,6 @@ out: | |||
1085 | * Modelled on fs/exec.c:aout_core_dump() | 1086 | * Modelled on fs/exec.c:aout_core_dump() |
1086 | * Jeremy Fitzhardinge <jeremy@sw.oz.au> | 1087 | * Jeremy Fitzhardinge <jeremy@sw.oz.au> |
1087 | */ | 1088 | */ |
1088 | /* | ||
1089 | * These are the only things you should do on a core-file: use only these | ||
1090 | * functions to write out all the necessary info. | ||
1091 | */ | ||
1092 | static int dump_write(struct file *file, const void *addr, int nr) | ||
1093 | { | ||
1094 | return file->f_op->write(file, addr, nr, &file->f_pos) == nr; | ||
1095 | } | ||
1096 | |||
1097 | static int dump_seek(struct file *file, loff_t off) | ||
1098 | { | ||
1099 | if (file->f_op->llseek && file->f_op->llseek != no_llseek) { | ||
1100 | if (file->f_op->llseek(file, off, SEEK_CUR) < 0) | ||
1101 | return 0; | ||
1102 | } else { | ||
1103 | char *buf = (char *)get_zeroed_page(GFP_KERNEL); | ||
1104 | if (!buf) | ||
1105 | return 0; | ||
1106 | while (off > 0) { | ||
1107 | unsigned long n = off; | ||
1108 | if (n > PAGE_SIZE) | ||
1109 | n = PAGE_SIZE; | ||
1110 | if (!dump_write(file, buf, n)) | ||
1111 | return 0; | ||
1112 | off -= n; | ||
1113 | } | ||
1114 | free_page((unsigned long)buf); | ||
1115 | } | ||
1116 | return 1; | ||
1117 | } | ||
1118 | 1089 | ||
1119 | /* | 1090 | /* |
1120 | * Decide what to dump of a segment, part, all or none. | 1091 | * Decide what to dump of a segment, part, all or none. |
@@ -1249,11 +1220,6 @@ static int writenote(struct memelfnote *men, struct file *file, | |||
1249 | } | 1220 | } |
1250 | #undef DUMP_WRITE | 1221 | #undef DUMP_WRITE |
1251 | 1222 | ||
1252 | #define DUMP_WRITE(addr, nr) \ | ||
1253 | if ((size += (nr)) > cprm->limit || \ | ||
1254 | !dump_write(cprm->file, (addr), (nr))) \ | ||
1255 | goto end_coredump; | ||
1256 | |||
1257 | static void fill_elf_header(struct elfhdr *elf, int segs, | 1223 | static void fill_elf_header(struct elfhdr *elf, int segs, |
1258 | u16 machine, u32 flags, u8 osabi) | 1224 | u16 machine, u32 flags, u8 osabi) |
1259 | { | 1225 | { |
@@ -1872,6 +1838,34 @@ static struct vm_area_struct *next_vma(struct vm_area_struct *this_vma, | |||
1872 | return gate_vma; | 1838 | return gate_vma; |
1873 | } | 1839 | } |
1874 | 1840 | ||
1841 | static void fill_extnum_info(struct elfhdr *elf, struct elf_shdr *shdr4extnum, | ||
1842 | elf_addr_t e_shoff, int segs) | ||
1843 | { | ||
1844 | elf->e_shoff = e_shoff; | ||
1845 | elf->e_shentsize = sizeof(*shdr4extnum); | ||
1846 | elf->e_shnum = 1; | ||
1847 | elf->e_shstrndx = SHN_UNDEF; | ||
1848 | |||
1849 | memset(shdr4extnum, 0, sizeof(*shdr4extnum)); | ||
1850 | |||
1851 | shdr4extnum->sh_type = SHT_NULL; | ||
1852 | shdr4extnum->sh_size = elf->e_shnum; | ||
1853 | shdr4extnum->sh_link = elf->e_shstrndx; | ||
1854 | shdr4extnum->sh_info = segs; | ||
1855 | } | ||
1856 | |||
1857 | static size_t elf_core_vma_data_size(struct vm_area_struct *gate_vma, | ||
1858 | unsigned long mm_flags) | ||
1859 | { | ||
1860 | struct vm_area_struct *vma; | ||
1861 | size_t size = 0; | ||
1862 | |||
1863 | for (vma = first_vma(current, gate_vma); vma != NULL; | ||
1864 | vma = next_vma(vma, gate_vma)) | ||
1865 | size += vma_dump_size(vma, mm_flags); | ||
1866 | return size; | ||
1867 | } | ||
1868 | |||
1875 | /* | 1869 | /* |
1876 | * Actual dumper | 1870 | * Actual dumper |
1877 | * | 1871 | * |
@@ -1888,8 +1882,11 @@ static int elf_core_dump(struct coredump_params *cprm) | |||
1888 | struct vm_area_struct *vma, *gate_vma; | 1882 | struct vm_area_struct *vma, *gate_vma; |
1889 | struct elfhdr *elf = NULL; | 1883 | struct elfhdr *elf = NULL; |
1890 | loff_t offset = 0, dataoff, foffset; | 1884 | loff_t offset = 0, dataoff, foffset; |
1891 | unsigned long mm_flags; | ||
1892 | struct elf_note_info info; | 1885 | struct elf_note_info info; |
1886 | struct elf_phdr *phdr4note = NULL; | ||
1887 | struct elf_shdr *shdr4extnum = NULL; | ||
1888 | Elf_Half e_phnum; | ||
1889 | elf_addr_t e_shoff; | ||
1893 | 1890 | ||
1894 | /* | 1891 | /* |
1895 | * We no longer stop all VM operations. | 1892 | * We no longer stop all VM operations. |
@@ -1912,20 +1909,25 @@ static int elf_core_dump(struct coredump_params *cprm) | |||
1912 | * Please check DEFAULT_MAX_MAP_COUNT definition when you modify here. | 1909 | * Please check DEFAULT_MAX_MAP_COUNT definition when you modify here. |
1913 | */ | 1910 | */ |
1914 | segs = current->mm->map_count; | 1911 | segs = current->mm->map_count; |
1915 | #ifdef ELF_CORE_EXTRA_PHDRS | 1912 | segs += elf_core_extra_phdrs(); |
1916 | segs += ELF_CORE_EXTRA_PHDRS; | ||
1917 | #endif | ||
1918 | 1913 | ||
1919 | gate_vma = get_gate_vma(current); | 1914 | gate_vma = get_gate_vma(current); |
1920 | if (gate_vma != NULL) | 1915 | if (gate_vma != NULL) |
1921 | segs++; | 1916 | segs++; |
1922 | 1917 | ||
1918 | /* for notes section */ | ||
1919 | segs++; | ||
1920 | |||
1921 | /* If segs > PN_XNUM(0xffff), then e_phnum overflows. To avoid | ||
1922 | * this, kernel supports extended numbering. Have a look at | ||
1923 | * include/linux/elf.h for further information. */ | ||
1924 | e_phnum = segs > PN_XNUM ? PN_XNUM : segs; | ||
1925 | |||
1923 | /* | 1926 | /* |
1924 | * Collect all the non-memory information about the process for the | 1927 | * Collect all the non-memory information about the process for the |
1925 | * notes. This also sets up the file header. | 1928 | * notes. This also sets up the file header. |
1926 | */ | 1929 | */ |
1927 | if (!fill_note_info(elf, segs + 1, /* including notes section */ | 1930 | if (!fill_note_info(elf, e_phnum, &info, cprm->signr, cprm->regs)) |
1928 | &info, cprm->signr, cprm->regs)) | ||
1929 | goto cleanup; | 1931 | goto cleanup; |
1930 | 1932 | ||
1931 | has_dumped = 1; | 1933 | has_dumped = 1; |
@@ -1934,31 +1936,47 @@ static int elf_core_dump(struct coredump_params *cprm) | |||
1934 | fs = get_fs(); | 1936 | fs = get_fs(); |
1935 | set_fs(KERNEL_DS); | 1937 | set_fs(KERNEL_DS); |
1936 | 1938 | ||
1937 | DUMP_WRITE(elf, sizeof(*elf)); | ||
1938 | offset += sizeof(*elf); /* Elf header */ | 1939 | offset += sizeof(*elf); /* Elf header */ |
1939 | offset += (segs + 1) * sizeof(struct elf_phdr); /* Program headers */ | 1940 | offset += segs * sizeof(struct elf_phdr); /* Program headers */ |
1940 | foffset = offset; | 1941 | foffset = offset; |
1941 | 1942 | ||
1942 | /* Write notes phdr entry */ | 1943 | /* Write notes phdr entry */ |
1943 | { | 1944 | { |
1944 | struct elf_phdr phdr; | ||
1945 | size_t sz = get_note_info_size(&info); | 1945 | size_t sz = get_note_info_size(&info); |
1946 | 1946 | ||
1947 | sz += elf_coredump_extra_notes_size(); | 1947 | sz += elf_coredump_extra_notes_size(); |
1948 | 1948 | ||
1949 | fill_elf_note_phdr(&phdr, sz, offset); | 1949 | phdr4note = kmalloc(sizeof(*phdr4note), GFP_KERNEL); |
1950 | if (!phdr4note) | ||
1951 | goto end_coredump; | ||
1952 | |||
1953 | fill_elf_note_phdr(phdr4note, sz, offset); | ||
1950 | offset += sz; | 1954 | offset += sz; |
1951 | DUMP_WRITE(&phdr, sizeof(phdr)); | ||
1952 | } | 1955 | } |
1953 | 1956 | ||
1954 | dataoff = offset = roundup(offset, ELF_EXEC_PAGESIZE); | 1957 | dataoff = offset = roundup(offset, ELF_EXEC_PAGESIZE); |
1955 | 1958 | ||
1956 | /* | 1959 | offset += elf_core_vma_data_size(gate_vma, cprm->mm_flags); |
1957 | * We must use the same mm->flags while dumping core to avoid | 1960 | offset += elf_core_extra_data_size(); |
1958 | * inconsistency between the program headers and bodies, otherwise an | 1961 | e_shoff = offset; |
1959 | * unusable core file can be generated. | 1962 | |
1960 | */ | 1963 | if (e_phnum == PN_XNUM) { |
1961 | mm_flags = current->mm->flags; | 1964 | shdr4extnum = kmalloc(sizeof(*shdr4extnum), GFP_KERNEL); |
1965 | if (!shdr4extnum) | ||
1966 | goto end_coredump; | ||
1967 | fill_extnum_info(elf, shdr4extnum, e_shoff, segs); | ||
1968 | } | ||
1969 | |||
1970 | offset = dataoff; | ||
1971 | |||
1972 | size += sizeof(*elf); | ||
1973 | if (size > cprm->limit || !dump_write(cprm->file, elf, sizeof(*elf))) | ||
1974 | goto end_coredump; | ||
1975 | |||
1976 | size += sizeof(*phdr4note); | ||
1977 | if (size > cprm->limit | ||
1978 | || !dump_write(cprm->file, phdr4note, sizeof(*phdr4note))) | ||
1979 | goto end_coredump; | ||
1962 | 1980 | ||
1963 | /* Write program headers for segments dump */ | 1981 | /* Write program headers for segments dump */ |
1964 | for (vma = first_vma(current, gate_vma); vma != NULL; | 1982 | for (vma = first_vma(current, gate_vma); vma != NULL; |
@@ -1969,7 +1987,7 @@ static int elf_core_dump(struct coredump_params *cprm) | |||
1969 | phdr.p_offset = offset; | 1987 | phdr.p_offset = offset; |
1970 | phdr.p_vaddr = vma->vm_start; | 1988 | phdr.p_vaddr = vma->vm_start; |
1971 | phdr.p_paddr = 0; | 1989 | phdr.p_paddr = 0; |
1972 | phdr.p_filesz = vma_dump_size(vma, mm_flags); | 1990 | phdr.p_filesz = vma_dump_size(vma, cprm->mm_flags); |
1973 | phdr.p_memsz = vma->vm_end - vma->vm_start; | 1991 | phdr.p_memsz = vma->vm_end - vma->vm_start; |
1974 | offset += phdr.p_filesz; | 1992 | offset += phdr.p_filesz; |
1975 | phdr.p_flags = vma->vm_flags & VM_READ ? PF_R : 0; | 1993 | phdr.p_flags = vma->vm_flags & VM_READ ? PF_R : 0; |
@@ -1979,12 +1997,14 @@ static int elf_core_dump(struct coredump_params *cprm) | |||
1979 | phdr.p_flags |= PF_X; | 1997 | phdr.p_flags |= PF_X; |
1980 | phdr.p_align = ELF_EXEC_PAGESIZE; | 1998 | phdr.p_align = ELF_EXEC_PAGESIZE; |
1981 | 1999 | ||
1982 | DUMP_WRITE(&phdr, sizeof(phdr)); | 2000 | size += sizeof(phdr); |
2001 | if (size > cprm->limit | ||
2002 | || !dump_write(cprm->file, &phdr, sizeof(phdr))) | ||
2003 | goto end_coredump; | ||
1983 | } | 2004 | } |
1984 | 2005 | ||
1985 | #ifdef ELF_CORE_WRITE_EXTRA_PHDRS | 2006 | if (!elf_core_write_extra_phdrs(cprm->file, offset, &size, cprm->limit)) |
1986 | ELF_CORE_WRITE_EXTRA_PHDRS; | 2007 | goto end_coredump; |
1987 | #endif | ||
1988 | 2008 | ||
1989 | /* write out the notes section */ | 2009 | /* write out the notes section */ |
1990 | if (!write_note_info(&info, cprm->file, &foffset)) | 2010 | if (!write_note_info(&info, cprm->file, &foffset)) |
@@ -2002,7 +2022,7 @@ static int elf_core_dump(struct coredump_params *cprm) | |||
2002 | unsigned long addr; | 2022 | unsigned long addr; |
2003 | unsigned long end; | 2023 | unsigned long end; |
2004 | 2024 | ||
2005 | end = vma->vm_start + vma_dump_size(vma, mm_flags); | 2025 | end = vma->vm_start + vma_dump_size(vma, cprm->mm_flags); |
2006 | 2026 | ||
2007 | for (addr = vma->vm_start; addr < end; addr += PAGE_SIZE) { | 2027 | for (addr = vma->vm_start; addr < end; addr += PAGE_SIZE) { |
2008 | struct page *page; | 2028 | struct page *page; |
@@ -2023,15 +2043,24 @@ static int elf_core_dump(struct coredump_params *cprm) | |||
2023 | } | 2043 | } |
2024 | } | 2044 | } |
2025 | 2045 | ||
2026 | #ifdef ELF_CORE_WRITE_EXTRA_DATA | 2046 | if (!elf_core_write_extra_data(cprm->file, &size, cprm->limit)) |
2027 | ELF_CORE_WRITE_EXTRA_DATA; | 2047 | goto end_coredump; |
2028 | #endif | 2048 | |
2049 | if (e_phnum == PN_XNUM) { | ||
2050 | size += sizeof(*shdr4extnum); | ||
2051 | if (size > cprm->limit | ||
2052 | || !dump_write(cprm->file, shdr4extnum, | ||
2053 | sizeof(*shdr4extnum))) | ||
2054 | goto end_coredump; | ||
2055 | } | ||
2029 | 2056 | ||
2030 | end_coredump: | 2057 | end_coredump: |
2031 | set_fs(fs); | 2058 | set_fs(fs); |
2032 | 2059 | ||
2033 | cleanup: | 2060 | cleanup: |
2034 | free_note_info(&info); | 2061 | free_note_info(&info); |
2062 | kfree(shdr4extnum); | ||
2063 | kfree(phdr4note); | ||
2035 | kfree(elf); | 2064 | kfree(elf); |
2036 | out: | 2065 | out: |
2037 | return has_dumped; | 2066 | return has_dumped; |
diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c index 18d77297ccc8..6d6a16c5e9bb 100644 --- a/fs/binfmt_elf_fdpic.c +++ b/fs/binfmt_elf_fdpic.c | |||
@@ -34,6 +34,7 @@ | |||
34 | #include <linux/elf.h> | 34 | #include <linux/elf.h> |
35 | #include <linux/elf-fdpic.h> | 35 | #include <linux/elf-fdpic.h> |
36 | #include <linux/elfcore.h> | 36 | #include <linux/elfcore.h> |
37 | #include <linux/coredump.h> | ||
37 | 38 | ||
38 | #include <asm/uaccess.h> | 39 | #include <asm/uaccess.h> |
39 | #include <asm/param.h> | 40 | #include <asm/param.h> |
@@ -1216,26 +1217,6 @@ static int elf_fdpic_map_file_by_direct_mmap(struct elf_fdpic_params *params, | |||
1216 | #ifdef CONFIG_ELF_CORE | 1217 | #ifdef CONFIG_ELF_CORE |
1217 | 1218 | ||
1218 | /* | 1219 | /* |
1219 | * These are the only things you should do on a core-file: use only these | ||
1220 | * functions to write out all the necessary info. | ||
1221 | */ | ||
1222 | static int dump_write(struct file *file, const void *addr, int nr) | ||
1223 | { | ||
1224 | return file->f_op->write(file, addr, nr, &file->f_pos) == nr; | ||
1225 | } | ||
1226 | |||
1227 | static int dump_seek(struct file *file, loff_t off) | ||
1228 | { | ||
1229 | if (file->f_op->llseek) { | ||
1230 | if (file->f_op->llseek(file, off, SEEK_SET) != off) | ||
1231 | return 0; | ||
1232 | } else { | ||
1233 | file->f_pos = off; | ||
1234 | } | ||
1235 | return 1; | ||
1236 | } | ||
1237 | |||
1238 | /* | ||
1239 | * Decide whether a segment is worth dumping; default is yes to be | 1220 | * Decide whether a segment is worth dumping; default is yes to be |
1240 | * sure (missing info is worse than too much; etc). | 1221 | * sure (missing info is worse than too much; etc). |
1241 | * Personally I'd include everything, and use the coredump limit... | 1222 | * Personally I'd include everything, and use the coredump limit... |
@@ -1313,35 +1294,35 @@ static int notesize(struct memelfnote *en) | |||
1313 | 1294 | ||
1314 | /* #define DEBUG */ | 1295 | /* #define DEBUG */ |
1315 | 1296 | ||
1316 | #define DUMP_WRITE(addr, nr) \ | 1297 | #define DUMP_WRITE(addr, nr, foffset) \ |
1317 | do { if (!dump_write(file, (addr), (nr))) return 0; } while(0) | 1298 | do { if (!dump_write(file, (addr), (nr))) return 0; *foffset += (nr); } while(0) |
1318 | #define DUMP_SEEK(off) \ | ||
1319 | do { if (!dump_seek(file, (off))) return 0; } while(0) | ||
1320 | 1299 | ||
1321 | static int writenote(struct memelfnote *men, struct file *file) | 1300 | static int alignfile(struct file *file, loff_t *foffset) |
1322 | { | 1301 | { |
1323 | struct elf_note en; | 1302 | static const char buf[4] = { 0, }; |
1303 | DUMP_WRITE(buf, roundup(*foffset, 4) - *foffset, foffset); | ||
1304 | return 1; | ||
1305 | } | ||
1324 | 1306 | ||
1307 | static int writenote(struct memelfnote *men, struct file *file, | ||
1308 | loff_t *foffset) | ||
1309 | { | ||
1310 | struct elf_note en; | ||
1325 | en.n_namesz = strlen(men->name) + 1; | 1311 | en.n_namesz = strlen(men->name) + 1; |
1326 | en.n_descsz = men->datasz; | 1312 | en.n_descsz = men->datasz; |
1327 | en.n_type = men->type; | 1313 | en.n_type = men->type; |
1328 | 1314 | ||
1329 | DUMP_WRITE(&en, sizeof(en)); | 1315 | DUMP_WRITE(&en, sizeof(en), foffset); |
1330 | DUMP_WRITE(men->name, en.n_namesz); | 1316 | DUMP_WRITE(men->name, en.n_namesz, foffset); |
1331 | /* XXX - cast from long long to long to avoid need for libgcc.a */ | 1317 | if (!alignfile(file, foffset)) |
1332 | DUMP_SEEK(roundup((unsigned long)file->f_pos, 4)); /* XXX */ | 1318 | return 0; |
1333 | DUMP_WRITE(men->data, men->datasz); | 1319 | DUMP_WRITE(men->data, men->datasz, foffset); |
1334 | DUMP_SEEK(roundup((unsigned long)file->f_pos, 4)); /* XXX */ | 1320 | if (!alignfile(file, foffset)) |
1321 | return 0; | ||
1335 | 1322 | ||
1336 | return 1; | 1323 | return 1; |
1337 | } | 1324 | } |
1338 | #undef DUMP_WRITE | 1325 | #undef DUMP_WRITE |
1339 | #undef DUMP_SEEK | ||
1340 | |||
1341 | #define DUMP_WRITE(addr, nr) \ | ||
1342 | if ((size += (nr)) > cprm->limit || \ | ||
1343 | !dump_write(cprm->file, (addr), (nr))) \ | ||
1344 | goto end_coredump; | ||
1345 | 1326 | ||
1346 | static inline void fill_elf_fdpic_header(struct elfhdr *elf, int segs) | 1327 | static inline void fill_elf_fdpic_header(struct elfhdr *elf, int segs) |
1347 | { | 1328 | { |
@@ -1524,6 +1505,22 @@ static int elf_dump_thread_status(long signr, struct elf_thread_status *t) | |||
1524 | return sz; | 1505 | return sz; |
1525 | } | 1506 | } |
1526 | 1507 | ||
1508 | static void fill_extnum_info(struct elfhdr *elf, struct elf_shdr *shdr4extnum, | ||
1509 | elf_addr_t e_shoff, int segs) | ||
1510 | { | ||
1511 | elf->e_shoff = e_shoff; | ||
1512 | elf->e_shentsize = sizeof(*shdr4extnum); | ||
1513 | elf->e_shnum = 1; | ||
1514 | elf->e_shstrndx = SHN_UNDEF; | ||
1515 | |||
1516 | memset(shdr4extnum, 0, sizeof(*shdr4extnum)); | ||
1517 | |||
1518 | shdr4extnum->sh_type = SHT_NULL; | ||
1519 | shdr4extnum->sh_size = elf->e_shnum; | ||
1520 | shdr4extnum->sh_link = elf->e_shstrndx; | ||
1521 | shdr4extnum->sh_info = segs; | ||
1522 | } | ||
1523 | |||
1527 | /* | 1524 | /* |
1528 | * dump the segments for an MMU process | 1525 | * dump the segments for an MMU process |
1529 | */ | 1526 | */ |
@@ -1552,7 +1549,7 @@ static int elf_fdpic_dump_segments(struct file *file, size_t *size, | |||
1552 | err = -EIO; | 1549 | err = -EIO; |
1553 | kunmap(page); | 1550 | kunmap(page); |
1554 | page_cache_release(page); | 1551 | page_cache_release(page); |
1555 | } else if (!dump_seek(file, file->f_pos + PAGE_SIZE)) | 1552 | } else if (!dump_seek(file, PAGE_SIZE)) |
1556 | err = -EFBIG; | 1553 | err = -EFBIG; |
1557 | if (err) | 1554 | if (err) |
1558 | goto out; | 1555 | goto out; |
@@ -1588,6 +1585,17 @@ static int elf_fdpic_dump_segments(struct file *file, size_t *size, | |||
1588 | } | 1585 | } |
1589 | #endif | 1586 | #endif |
1590 | 1587 | ||
1588 | static size_t elf_core_vma_data_size(unsigned long mm_flags) | ||
1589 | { | ||
1590 | struct vm_area_struct *vma; | ||
1591 | size_t size = 0; | ||
1592 | |||
1593 | for (vma = current->mm->mmap; vma; vma->vm_next) | ||
1594 | if (maydump(vma, mm_flags)) | ||
1595 | size += vma->vm_end - vma->vm_start; | ||
1596 | return size; | ||
1597 | } | ||
1598 | |||
1591 | /* | 1599 | /* |
1592 | * Actual dumper | 1600 | * Actual dumper |
1593 | * | 1601 | * |
@@ -1605,7 +1613,7 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1605 | int i; | 1613 | int i; |
1606 | struct vm_area_struct *vma; | 1614 | struct vm_area_struct *vma; |
1607 | struct elfhdr *elf = NULL; | 1615 | struct elfhdr *elf = NULL; |
1608 | loff_t offset = 0, dataoff; | 1616 | loff_t offset = 0, dataoff, foffset; |
1609 | int numnote; | 1617 | int numnote; |
1610 | struct memelfnote *notes = NULL; | 1618 | struct memelfnote *notes = NULL; |
1611 | struct elf_prstatus *prstatus = NULL; /* NT_PRSTATUS */ | 1619 | struct elf_prstatus *prstatus = NULL; /* NT_PRSTATUS */ |
@@ -1618,7 +1626,10 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1618 | #endif | 1626 | #endif |
1619 | int thread_status_size = 0; | 1627 | int thread_status_size = 0; |
1620 | elf_addr_t *auxv; | 1628 | elf_addr_t *auxv; |
1621 | unsigned long mm_flags; | 1629 | struct elf_phdr *phdr4note = NULL; |
1630 | struct elf_shdr *shdr4extnum = NULL; | ||
1631 | Elf_Half e_phnum; | ||
1632 | elf_addr_t e_shoff; | ||
1622 | 1633 | ||
1623 | /* | 1634 | /* |
1624 | * We no longer stop all VM operations. | 1635 | * We no longer stop all VM operations. |
@@ -1683,12 +1694,18 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1683 | elf_core_copy_regs(&prstatus->pr_reg, cprm->regs); | 1694 | elf_core_copy_regs(&prstatus->pr_reg, cprm->regs); |
1684 | 1695 | ||
1685 | segs = current->mm->map_count; | 1696 | segs = current->mm->map_count; |
1686 | #ifdef ELF_CORE_EXTRA_PHDRS | 1697 | segs += elf_core_extra_phdrs(); |
1687 | segs += ELF_CORE_EXTRA_PHDRS; | 1698 | |
1688 | #endif | 1699 | /* for notes section */ |
1700 | segs++; | ||
1701 | |||
1702 | /* If segs > PN_XNUM(0xffff), then e_phnum overflows. To avoid | ||
1703 | * this, kernel supports extended numbering. Have a look at | ||
1704 | * include/linux/elf.h for further information. */ | ||
1705 | e_phnum = segs > PN_XNUM ? PN_XNUM : segs; | ||
1689 | 1706 | ||
1690 | /* Set up header */ | 1707 | /* Set up header */ |
1691 | fill_elf_fdpic_header(elf, segs + 1); /* including notes section */ | 1708 | fill_elf_fdpic_header(elf, e_phnum); |
1692 | 1709 | ||
1693 | has_dumped = 1; | 1710 | has_dumped = 1; |
1694 | current->flags |= PF_DUMPCORE; | 1711 | current->flags |= PF_DUMPCORE; |
@@ -1727,13 +1744,12 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1727 | fs = get_fs(); | 1744 | fs = get_fs(); |
1728 | set_fs(KERNEL_DS); | 1745 | set_fs(KERNEL_DS); |
1729 | 1746 | ||
1730 | DUMP_WRITE(elf, sizeof(*elf)); | ||
1731 | offset += sizeof(*elf); /* Elf header */ | 1747 | offset += sizeof(*elf); /* Elf header */ |
1732 | offset += (segs+1) * sizeof(struct elf_phdr); /* Program headers */ | 1748 | offset += segs * sizeof(struct elf_phdr); /* Program headers */ |
1749 | foffset = offset; | ||
1733 | 1750 | ||
1734 | /* Write notes phdr entry */ | 1751 | /* Write notes phdr entry */ |
1735 | { | 1752 | { |
1736 | struct elf_phdr phdr; | ||
1737 | int sz = 0; | 1753 | int sz = 0; |
1738 | 1754 | ||
1739 | for (i = 0; i < numnote; i++) | 1755 | for (i = 0; i < numnote; i++) |
@@ -1741,20 +1757,38 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1741 | 1757 | ||
1742 | sz += thread_status_size; | 1758 | sz += thread_status_size; |
1743 | 1759 | ||
1744 | fill_elf_note_phdr(&phdr, sz, offset); | 1760 | phdr4note = kmalloc(sizeof(*phdr4note), GFP_KERNEL); |
1761 | if (!phdr4note) | ||
1762 | goto end_coredump; | ||
1763 | |||
1764 | fill_elf_note_phdr(phdr4note, sz, offset); | ||
1745 | offset += sz; | 1765 | offset += sz; |
1746 | DUMP_WRITE(&phdr, sizeof(phdr)); | ||
1747 | } | 1766 | } |
1748 | 1767 | ||
1749 | /* Page-align dumped data */ | 1768 | /* Page-align dumped data */ |
1750 | dataoff = offset = roundup(offset, ELF_EXEC_PAGESIZE); | 1769 | dataoff = offset = roundup(offset, ELF_EXEC_PAGESIZE); |
1751 | 1770 | ||
1752 | /* | 1771 | offset += elf_core_vma_data_size(cprm->mm_flags); |
1753 | * We must use the same mm->flags while dumping core to avoid | 1772 | offset += elf_core_extra_data_size(); |
1754 | * inconsistency between the program headers and bodies, otherwise an | 1773 | e_shoff = offset; |
1755 | * unusable core file can be generated. | 1774 | |
1756 | */ | 1775 | if (e_phnum == PN_XNUM) { |
1757 | mm_flags = current->mm->flags; | 1776 | shdr4extnum = kmalloc(sizeof(*shdr4extnum), GFP_KERNEL); |
1777 | if (!shdr4extnum) | ||
1778 | goto end_coredump; | ||
1779 | fill_extnum_info(elf, shdr4extnum, e_shoff, segs); | ||
1780 | } | ||
1781 | |||
1782 | offset = dataoff; | ||
1783 | |||
1784 | size += sizeof(*elf); | ||
1785 | if (size > cprm->limit || !dump_write(cprm->file, elf, sizeof(*elf))) | ||
1786 | goto end_coredump; | ||
1787 | |||
1788 | size += sizeof(*phdr4note); | ||
1789 | if (size > cprm->limit | ||
1790 | || !dump_write(cprm->file, phdr4note, sizeof(*phdr4note))) | ||
1791 | goto end_coredump; | ||
1758 | 1792 | ||
1759 | /* write program headers for segments dump */ | 1793 | /* write program headers for segments dump */ |
1760 | for (vma = current->mm->mmap; vma; vma = vma->vm_next) { | 1794 | for (vma = current->mm->mmap; vma; vma = vma->vm_next) { |
@@ -1767,7 +1801,7 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1767 | phdr.p_offset = offset; | 1801 | phdr.p_offset = offset; |
1768 | phdr.p_vaddr = vma->vm_start; | 1802 | phdr.p_vaddr = vma->vm_start; |
1769 | phdr.p_paddr = 0; | 1803 | phdr.p_paddr = 0; |
1770 | phdr.p_filesz = maydump(vma, mm_flags) ? sz : 0; | 1804 | phdr.p_filesz = maydump(vma, cprm->mm_flags) ? sz : 0; |
1771 | phdr.p_memsz = sz; | 1805 | phdr.p_memsz = sz; |
1772 | offset += phdr.p_filesz; | 1806 | offset += phdr.p_filesz; |
1773 | phdr.p_flags = vma->vm_flags & VM_READ ? PF_R : 0; | 1807 | phdr.p_flags = vma->vm_flags & VM_READ ? PF_R : 0; |
@@ -1777,16 +1811,18 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1777 | phdr.p_flags |= PF_X; | 1811 | phdr.p_flags |= PF_X; |
1778 | phdr.p_align = ELF_EXEC_PAGESIZE; | 1812 | phdr.p_align = ELF_EXEC_PAGESIZE; |
1779 | 1813 | ||
1780 | DUMP_WRITE(&phdr, sizeof(phdr)); | 1814 | size += sizeof(phdr); |
1815 | if (size > cprm->limit | ||
1816 | || !dump_write(cprm->file, &phdr, sizeof(phdr))) | ||
1817 | goto end_coredump; | ||
1781 | } | 1818 | } |
1782 | 1819 | ||
1783 | #ifdef ELF_CORE_WRITE_EXTRA_PHDRS | 1820 | if (!elf_core_write_extra_phdrs(cprm->file, offset, &size, cprm->limit)) |
1784 | ELF_CORE_WRITE_EXTRA_PHDRS; | 1821 | goto end_coredump; |
1785 | #endif | ||
1786 | 1822 | ||
1787 | /* write out the notes section */ | 1823 | /* write out the notes section */ |
1788 | for (i = 0; i < numnote; i++) | 1824 | for (i = 0; i < numnote; i++) |
1789 | if (!writenote(notes + i, cprm->file)) | 1825 | if (!writenote(notes + i, cprm->file, &foffset)) |
1790 | goto end_coredump; | 1826 | goto end_coredump; |
1791 | 1827 | ||
1792 | /* write out the thread status notes section */ | 1828 | /* write out the thread status notes section */ |
@@ -1795,20 +1831,27 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm) | |||
1795 | list_entry(t, struct elf_thread_status, list); | 1831 | list_entry(t, struct elf_thread_status, list); |
1796 | 1832 | ||
1797 | for (i = 0; i < tmp->num_notes; i++) | 1833 | for (i = 0; i < tmp->num_notes; i++) |
1798 | if (!writenote(&tmp->notes[i], cprm->file)) | 1834 | if (!writenote(&tmp->notes[i], cprm->file, &foffset)) |
1799 | goto end_coredump; | 1835 | goto end_coredump; |
1800 | } | 1836 | } |
1801 | 1837 | ||
1802 | if (!dump_seek(cprm->file, dataoff)) | 1838 | if (!dump_seek(cprm->file, dataoff - foffset)) |
1803 | goto end_coredump; | 1839 | goto end_coredump; |
1804 | 1840 | ||
1805 | if (elf_fdpic_dump_segments(cprm->file, &size, &cprm->limit, | 1841 | if (elf_fdpic_dump_segments(cprm->file, &size, &cprm->limit, |
1806 | mm_flags) < 0) | 1842 | cprm->mm_flags) < 0) |
1807 | goto end_coredump; | 1843 | goto end_coredump; |
1808 | 1844 | ||
1809 | #ifdef ELF_CORE_WRITE_EXTRA_DATA | 1845 | if (!elf_core_write_extra_data(cprm->file, &size, cprm->limit)) |
1810 | ELF_CORE_WRITE_EXTRA_DATA; | 1846 | goto end_coredump; |
1811 | #endif | 1847 | |
1848 | if (e_phnum == PN_XNUM) { | ||
1849 | size += sizeof(*shdr4extnum); | ||
1850 | if (size > cprm->limit | ||
1851 | || !dump_write(cprm->file, shdr4extnum, | ||
1852 | sizeof(*shdr4extnum))) | ||
1853 | goto end_coredump; | ||
1854 | } | ||
1812 | 1855 | ||
1813 | if (cprm->file->f_pos != offset) { | 1856 | if (cprm->file->f_pos != offset) { |
1814 | /* Sanity check */ | 1857 | /* Sanity check */ |
@@ -1826,7 +1869,7 @@ cleanup: | |||
1826 | list_del(tmp); | 1869 | list_del(tmp); |
1827 | kfree(list_entry(tmp, struct elf_thread_status, list)); | 1870 | kfree(list_entry(tmp, struct elf_thread_status, list)); |
1828 | } | 1871 | } |
1829 | 1872 | kfree(phdr4note); | |
1830 | kfree(elf); | 1873 | kfree(elf); |
1831 | kfree(prstatus); | 1874 | kfree(prstatus); |
1832 | kfree(psinfo); | 1875 | kfree(psinfo); |
diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index 42c6b4a54445..e0e769bdca59 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c | |||
@@ -501,7 +501,7 @@ static int load_flat_file(struct linux_binprm * bprm, | |||
501 | * size limits imposed on them by creating programs with large | 501 | * size limits imposed on them by creating programs with large |
502 | * arrays in the data or bss. | 502 | * arrays in the data or bss. |
503 | */ | 503 | */ |
504 | rlim = current->signal->rlim[RLIMIT_DATA].rlim_cur; | 504 | rlim = rlimit(RLIMIT_DATA); |
505 | if (rlim >= RLIM_INFINITY) | 505 | if (rlim >= RLIM_INFINITY) |
506 | rlim = ~0; | 506 | rlim = ~0; |
507 | if (data_len + bss_len > rlim) { | 507 | if (data_len + bss_len > rlim) { |
@@ -507,10 +507,8 @@ int bio_get_nr_vecs(struct block_device *bdev) | |||
507 | int nr_pages; | 507 | int nr_pages; |
508 | 508 | ||
509 | nr_pages = ((queue_max_sectors(q) << 9) + PAGE_SIZE - 1) >> PAGE_SHIFT; | 509 | nr_pages = ((queue_max_sectors(q) << 9) + PAGE_SIZE - 1) >> PAGE_SHIFT; |
510 | if (nr_pages > queue_max_phys_segments(q)) | 510 | if (nr_pages > queue_max_segments(q)) |
511 | nr_pages = queue_max_phys_segments(q); | 511 | nr_pages = queue_max_segments(q); |
512 | if (nr_pages > queue_max_hw_segments(q)) | ||
513 | nr_pages = queue_max_hw_segments(q); | ||
514 | 512 | ||
515 | return nr_pages; | 513 | return nr_pages; |
516 | } | 514 | } |
@@ -575,8 +573,7 @@ static int __bio_add_page(struct request_queue *q, struct bio *bio, struct page | |||
575 | * make this too complex. | 573 | * make this too complex. |
576 | */ | 574 | */ |
577 | 575 | ||
578 | while (bio->bi_phys_segments >= queue_max_phys_segments(q) | 576 | while (bio->bi_phys_segments >= queue_max_segments(q)) { |
579 | || bio->bi_phys_segments >= queue_max_hw_segments(q)) { | ||
580 | 577 | ||
581 | if (retried_segments) | 578 | if (retried_segments) |
582 | return 0; | 579 | return 0; |
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index 2aa8ec6a0981..8b5cfdd4bfc1 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h | |||
@@ -2326,7 +2326,7 @@ int btrfs_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf); | |||
2326 | int btrfs_readpage(struct file *file, struct page *page); | 2326 | int btrfs_readpage(struct file *file, struct page *page); |
2327 | void btrfs_delete_inode(struct inode *inode); | 2327 | void btrfs_delete_inode(struct inode *inode); |
2328 | void btrfs_put_inode(struct inode *inode); | 2328 | void btrfs_put_inode(struct inode *inode); |
2329 | int btrfs_write_inode(struct inode *inode, int wait); | 2329 | int btrfs_write_inode(struct inode *inode, struct writeback_control *wbc); |
2330 | void btrfs_dirty_inode(struct inode *inode); | 2330 | void btrfs_dirty_inode(struct inode *inode); |
2331 | struct inode *btrfs_alloc_inode(struct super_block *sb); | 2331 | struct inode *btrfs_alloc_inode(struct super_block *sb); |
2332 | void btrfs_destroy_inode(struct inode *inode); | 2332 | void btrfs_destroy_inode(struct inode *inode); |
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 4deb280f8969..c41db6d45ab6 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c | |||
@@ -3968,7 +3968,7 @@ err: | |||
3968 | return ret; | 3968 | return ret; |
3969 | } | 3969 | } |
3970 | 3970 | ||
3971 | int btrfs_write_inode(struct inode *inode, int wait) | 3971 | int btrfs_write_inode(struct inode *inode, struct writeback_control *wbc) |
3972 | { | 3972 | { |
3973 | struct btrfs_root *root = BTRFS_I(inode)->root; | 3973 | struct btrfs_root *root = BTRFS_I(inode)->root; |
3974 | struct btrfs_trans_handle *trans; | 3974 | struct btrfs_trans_handle *trans; |
@@ -3977,7 +3977,7 @@ int btrfs_write_inode(struct inode *inode, int wait) | |||
3977 | if (root->fs_info->btree_inode == inode) | 3977 | if (root->fs_info->btree_inode == inode) |
3978 | return 0; | 3978 | return 0; |
3979 | 3979 | ||
3980 | if (wait) { | 3980 | if (wbc->sync_mode == WB_SYNC_ALL) { |
3981 | trans = btrfs_join_transaction(root, 1); | 3981 | trans = btrfs_join_transaction(root, 1); |
3982 | btrfs_set_trans_block_group(trans, inode); | 3982 | btrfs_set_trans_block_group(trans, inode); |
3983 | ret = btrfs_commit_transaction(trans, root); | 3983 | ret = btrfs_commit_transaction(trans, root); |
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index a240b6fa81df..4ce16ef702a3 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c | |||
@@ -164,12 +164,12 @@ static void btrfs_root_release(struct kobject *kobj) | |||
164 | complete(&root->kobj_unregister); | 164 | complete(&root->kobj_unregister); |
165 | } | 165 | } |
166 | 166 | ||
167 | static struct sysfs_ops btrfs_super_attr_ops = { | 167 | static const struct sysfs_ops btrfs_super_attr_ops = { |
168 | .show = btrfs_super_attr_show, | 168 | .show = btrfs_super_attr_show, |
169 | .store = btrfs_super_attr_store, | 169 | .store = btrfs_super_attr_store, |
170 | }; | 170 | }; |
171 | 171 | ||
172 | static struct sysfs_ops btrfs_root_attr_ops = { | 172 | static const struct sysfs_ops btrfs_root_attr_ops = { |
173 | .show = btrfs_root_attr_show, | 173 | .show = btrfs_root_attr_show, |
174 | .store = btrfs_root_attr_store, | 174 | .store = btrfs_root_attr_store, |
175 | }; | 175 | }; |
diff --git a/fs/cifs/CHANGES b/fs/cifs/CHANGES index 49503d2edc7e..bc0025cdd1c9 100644 --- a/fs/cifs/CHANGES +++ b/fs/cifs/CHANGES | |||
@@ -1,6 +1,7 @@ | |||
1 | Version 1.62 | 1 | Version 1.62 |
2 | ------------ | 2 | ------------ |
3 | Add sockopt=TCP_NODELAY mount option. | 3 | Add sockopt=TCP_NODELAY mount option. EA (xattr) routines hardened |
4 | to more strictly handle corrupt frames. | ||
4 | 5 | ||
5 | Version 1.61 | 6 | Version 1.61 |
6 | ------------ | 7 | ------------ |
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h index ed751bb657db..a1c817eb291a 100644 --- a/fs/cifs/cifsglob.h +++ b/fs/cifs/cifsglob.h | |||
@@ -205,7 +205,7 @@ struct cifsUidInfo { | |||
205 | struct cifsSesInfo { | 205 | struct cifsSesInfo { |
206 | struct list_head smb_ses_list; | 206 | struct list_head smb_ses_list; |
207 | struct list_head tcon_list; | 207 | struct list_head tcon_list; |
208 | struct semaphore sesSem; | 208 | struct mutex session_mutex; |
209 | #if 0 | 209 | #if 0 |
210 | struct cifsUidInfo *uidInfo; /* pointer to user info */ | 210 | struct cifsUidInfo *uidInfo; /* pointer to user info */ |
211 | #endif | 211 | #endif |
diff --git a/fs/cifs/cifspdu.h b/fs/cifs/cifspdu.h index 3877737f96a6..14d036d8db11 100644 --- a/fs/cifs/cifspdu.h +++ b/fs/cifs/cifspdu.h | |||
@@ -415,10 +415,10 @@ struct smb_hdr { | |||
415 | __u8 WordCount; | 415 | __u8 WordCount; |
416 | } __attribute__((packed)); | 416 | } __attribute__((packed)); |
417 | /* given a pointer to an smb_hdr retrieve the value of byte count */ | 417 | /* given a pointer to an smb_hdr retrieve the value of byte count */ |
418 | #define BCC(smb_var) (*(__u16 *)((char *)smb_var + sizeof(struct smb_hdr) + (2 * smb_var->WordCount))) | 418 | #define BCC(smb_var) (*(__u16 *)((char *)(smb_var) + sizeof(struct smb_hdr) + (2 * (smb_var)->WordCount))) |
419 | #define BCC_LE(smb_var) (*(__le16 *)((char *)smb_var + sizeof(struct smb_hdr) + (2 * smb_var->WordCount))) | 419 | #define BCC_LE(smb_var) (*(__le16 *)((char *)(smb_var) + sizeof(struct smb_hdr) + (2 * (smb_var)->WordCount))) |
420 | /* given a pointer to an smb_hdr retrieve the pointer to the byte area */ | 420 | /* given a pointer to an smb_hdr retrieve the pointer to the byte area */ |
421 | #define pByteArea(smb_var) ((unsigned char *)smb_var + sizeof(struct smb_hdr) + (2 * smb_var->WordCount) + 2) | 421 | #define pByteArea(smb_var) ((unsigned char *)(smb_var) + sizeof(struct smb_hdr) + (2 * (smb_var)->WordCount) + 2) |
422 | 422 | ||
423 | /* | 423 | /* |
424 | * Computer Name Length (since Netbios name was length 16 with last byte 0x20) | 424 | * Computer Name Length (since Netbios name was length 16 with last byte 0x20) |
diff --git a/fs/cifs/cifsproto.h b/fs/cifs/cifsproto.h index 5646727e33f5..88e2bc44ac58 100644 --- a/fs/cifs/cifsproto.h +++ b/fs/cifs/cifsproto.h | |||
@@ -363,13 +363,10 @@ extern int CIFSSMBNotify(const int xid, struct cifsTconInfo *tcon, | |||
363 | __u32 filter, struct file *file, int multishot, | 363 | __u32 filter, struct file *file, int multishot, |
364 | const struct nls_table *nls_codepage); | 364 | const struct nls_table *nls_codepage); |
365 | extern ssize_t CIFSSMBQAllEAs(const int xid, struct cifsTconInfo *tcon, | 365 | extern ssize_t CIFSSMBQAllEAs(const int xid, struct cifsTconInfo *tcon, |
366 | const unsigned char *searchName, char *EAData, | 366 | const unsigned char *searchName, |
367 | const unsigned char *ea_name, char *EAData, | ||
367 | size_t bufsize, const struct nls_table *nls_codepage, | 368 | size_t bufsize, const struct nls_table *nls_codepage, |
368 | int remap_special_chars); | 369 | int remap_special_chars); |
369 | extern ssize_t CIFSSMBQueryEA(const int xid, struct cifsTconInfo *tcon, | ||
370 | const unsigned char *searchName, const unsigned char *ea_name, | ||
371 | unsigned char *ea_value, size_t buf_size, | ||
372 | const struct nls_table *nls_codepage, int remap_special_chars); | ||
373 | extern int CIFSSMBSetEA(const int xid, struct cifsTconInfo *tcon, | 370 | extern int CIFSSMBSetEA(const int xid, struct cifsTconInfo *tcon, |
374 | const char *fileName, const char *ea_name, | 371 | const char *fileName, const char *ea_name, |
375 | const void *ea_value, const __u16 ea_value_len, | 372 | const void *ea_value, const __u16 ea_value_len, |
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index 941441d3e386..9d17df3e0768 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c | |||
@@ -170,19 +170,19 @@ cifs_reconnect_tcon(struct cifsTconInfo *tcon, int smb_command) | |||
170 | * need to prevent multiple threads trying to simultaneously | 170 | * need to prevent multiple threads trying to simultaneously |
171 | * reconnect the same SMB session | 171 | * reconnect the same SMB session |
172 | */ | 172 | */ |
173 | down(&ses->sesSem); | 173 | mutex_lock(&ses->session_mutex); |
174 | if (ses->need_reconnect) | 174 | if (ses->need_reconnect) |
175 | rc = cifs_setup_session(0, ses, nls_codepage); | 175 | rc = cifs_setup_session(0, ses, nls_codepage); |
176 | 176 | ||
177 | /* do we need to reconnect tcon? */ | 177 | /* do we need to reconnect tcon? */ |
178 | if (rc || !tcon->need_reconnect) { | 178 | if (rc || !tcon->need_reconnect) { |
179 | up(&ses->sesSem); | 179 | mutex_unlock(&ses->session_mutex); |
180 | goto out; | 180 | goto out; |
181 | } | 181 | } |
182 | 182 | ||
183 | mark_open_files_invalid(tcon); | 183 | mark_open_files_invalid(tcon); |
184 | rc = CIFSTCon(0, ses, tcon->treeName, tcon, nls_codepage); | 184 | rc = CIFSTCon(0, ses, tcon->treeName, tcon, nls_codepage); |
185 | up(&ses->sesSem); | 185 | mutex_unlock(&ses->session_mutex); |
186 | cFYI(1, ("reconnect tcon rc = %d", rc)); | 186 | cFYI(1, ("reconnect tcon rc = %d", rc)); |
187 | 187 | ||
188 | if (rc) | 188 | if (rc) |
@@ -700,13 +700,13 @@ CIFSSMBLogoff(const int xid, struct cifsSesInfo *ses) | |||
700 | if (!ses || !ses->server) | 700 | if (!ses || !ses->server) |
701 | return -EIO; | 701 | return -EIO; |
702 | 702 | ||
703 | down(&ses->sesSem); | 703 | mutex_lock(&ses->session_mutex); |
704 | if (ses->need_reconnect) | 704 | if (ses->need_reconnect) |
705 | goto session_already_dead; /* no need to send SMBlogoff if uid | 705 | goto session_already_dead; /* no need to send SMBlogoff if uid |
706 | already closed due to reconnect */ | 706 | already closed due to reconnect */ |
707 | rc = small_smb_init(SMB_COM_LOGOFF_ANDX, 2, NULL, (void **)&pSMB); | 707 | rc = small_smb_init(SMB_COM_LOGOFF_ANDX, 2, NULL, (void **)&pSMB); |
708 | if (rc) { | 708 | if (rc) { |
709 | up(&ses->sesSem); | 709 | mutex_unlock(&ses->session_mutex); |
710 | return rc; | 710 | return rc; |
711 | } | 711 | } |
712 | 712 | ||
@@ -721,7 +721,7 @@ CIFSSMBLogoff(const int xid, struct cifsSesInfo *ses) | |||
721 | pSMB->AndXCommand = 0xFF; | 721 | pSMB->AndXCommand = 0xFF; |
722 | rc = SendReceiveNoRsp(xid, ses, (struct smb_hdr *) pSMB, 0); | 722 | rc = SendReceiveNoRsp(xid, ses, (struct smb_hdr *) pSMB, 0); |
723 | session_already_dead: | 723 | session_already_dead: |
724 | up(&ses->sesSem); | 724 | mutex_unlock(&ses->session_mutex); |
725 | 725 | ||
726 | /* if session dead then we do not need to do ulogoff, | 726 | /* if session dead then we do not need to do ulogoff, |
727 | since server closed smb session, no sense reporting | 727 | since server closed smb session, no sense reporting |
@@ -5269,22 +5269,34 @@ int CIFSSMBNotify(const int xid, struct cifsTconInfo *tcon, | |||
5269 | cifs_buf_release(pSMB); | 5269 | cifs_buf_release(pSMB); |
5270 | return rc; | 5270 | return rc; |
5271 | } | 5271 | } |
5272 | |||
5272 | #ifdef CONFIG_CIFS_XATTR | 5273 | #ifdef CONFIG_CIFS_XATTR |
5274 | /* | ||
5275 | * Do a path-based QUERY_ALL_EAS call and parse the result. This is a common | ||
5276 | * function used by listxattr and getxattr type calls. When ea_name is set, | ||
5277 | * it looks for that attribute name and stuffs that value into the EAData | ||
5278 | * buffer. When ea_name is NULL, it stuffs a list of attribute names into the | ||
5279 | * buffer. In both cases, the return value is either the length of the | ||
5280 | * resulting data or a negative error code. If EAData is a NULL pointer then | ||
5281 | * the data isn't copied to it, but the length is returned. | ||
5282 | */ | ||
5273 | ssize_t | 5283 | ssize_t |
5274 | CIFSSMBQAllEAs(const int xid, struct cifsTconInfo *tcon, | 5284 | CIFSSMBQAllEAs(const int xid, struct cifsTconInfo *tcon, |
5275 | const unsigned char *searchName, | 5285 | const unsigned char *searchName, const unsigned char *ea_name, |
5276 | char *EAData, size_t buf_size, | 5286 | char *EAData, size_t buf_size, |
5277 | const struct nls_table *nls_codepage, int remap) | 5287 | const struct nls_table *nls_codepage, int remap) |
5278 | { | 5288 | { |
5279 | /* BB assumes one setup word */ | 5289 | /* BB assumes one setup word */ |
5280 | TRANSACTION2_QPI_REQ *pSMB = NULL; | 5290 | TRANSACTION2_QPI_REQ *pSMB = NULL; |
5281 | TRANSACTION2_QPI_RSP *pSMBr = NULL; | 5291 | TRANSACTION2_QPI_RSP *pSMBr = NULL; |
5282 | int rc = 0; | 5292 | int rc = 0; |
5283 | int bytes_returned; | 5293 | int bytes_returned; |
5284 | int name_len; | 5294 | int list_len; |
5295 | struct fealist *ea_response_data; | ||
5285 | struct fea *temp_fea; | 5296 | struct fea *temp_fea; |
5286 | char *temp_ptr; | 5297 | char *temp_ptr; |
5287 | __u16 params, byte_count; | 5298 | char *end_of_smb; |
5299 | __u16 params, byte_count, data_offset; | ||
5288 | 5300 | ||
5289 | cFYI(1, ("In Query All EAs path %s", searchName)); | 5301 | cFYI(1, ("In Query All EAs path %s", searchName)); |
5290 | QAllEAsRetry: | 5302 | QAllEAsRetry: |
@@ -5294,22 +5306,22 @@ QAllEAsRetry: | |||
5294 | return rc; | 5306 | return rc; |
5295 | 5307 | ||
5296 | if (pSMB->hdr.Flags2 & SMBFLG2_UNICODE) { | 5308 | if (pSMB->hdr.Flags2 & SMBFLG2_UNICODE) { |
5297 | name_len = | 5309 | list_len = |
5298 | cifsConvertToUCS((__le16 *) pSMB->FileName, searchName, | 5310 | cifsConvertToUCS((__le16 *) pSMB->FileName, searchName, |
5299 | PATH_MAX, nls_codepage, remap); | 5311 | PATH_MAX, nls_codepage, remap); |
5300 | name_len++; /* trailing null */ | 5312 | list_len++; /* trailing null */ |
5301 | name_len *= 2; | 5313 | list_len *= 2; |
5302 | } else { /* BB improve the check for buffer overruns BB */ | 5314 | } else { /* BB improve the check for buffer overruns BB */ |
5303 | name_len = strnlen(searchName, PATH_MAX); | 5315 | list_len = strnlen(searchName, PATH_MAX); |
5304 | name_len++; /* trailing null */ | 5316 | list_len++; /* trailing null */ |
5305 | strncpy(pSMB->FileName, searchName, name_len); | 5317 | strncpy(pSMB->FileName, searchName, list_len); |
5306 | } | 5318 | } |
5307 | 5319 | ||
5308 | params = 2 /* level */ + 4 /* reserved */ + name_len /* includes NUL */; | 5320 | params = 2 /* level */ + 4 /* reserved */ + list_len /* includes NUL */; |
5309 | pSMB->TotalDataCount = 0; | 5321 | pSMB->TotalDataCount = 0; |
5310 | pSMB->MaxParameterCount = cpu_to_le16(2); | 5322 | pSMB->MaxParameterCount = cpu_to_le16(2); |
5311 | /* BB find exact max SMB PDU from sess structure BB */ | 5323 | /* BB find exact max SMB PDU from sess structure BB */ |
5312 | pSMB->MaxDataCount = cpu_to_le16(4000); | 5324 | pSMB->MaxDataCount = cpu_to_le16(CIFSMaxBufSize); |
5313 | pSMB->MaxSetupCount = 0; | 5325 | pSMB->MaxSetupCount = 0; |
5314 | pSMB->Reserved = 0; | 5326 | pSMB->Reserved = 0; |
5315 | pSMB->Flags = 0; | 5327 | pSMB->Flags = 0; |
@@ -5334,237 +5346,117 @@ QAllEAsRetry: | |||
5334 | (struct smb_hdr *) pSMBr, &bytes_returned, 0); | 5346 | (struct smb_hdr *) pSMBr, &bytes_returned, 0); |
5335 | if (rc) { | 5347 | if (rc) { |
5336 | cFYI(1, ("Send error in QueryAllEAs = %d", rc)); | 5348 | cFYI(1, ("Send error in QueryAllEAs = %d", rc)); |
5337 | } else { /* decode response */ | 5349 | goto QAllEAsOut; |
5338 | rc = validate_t2((struct smb_t2_rsp *)pSMBr); | 5350 | } |
5339 | 5351 | ||
5340 | /* BB also check enough total bytes returned */ | 5352 | |
5341 | /* BB we need to improve the validity checking | 5353 | /* BB also check enough total bytes returned */ |
5342 | of these trans2 responses */ | 5354 | /* BB we need to improve the validity checking |
5343 | if (rc || (pSMBr->ByteCount < 4)) | 5355 | of these trans2 responses */ |
5344 | rc = -EIO; /* bad smb */ | 5356 | |
5345 | /* else if (pFindData){ | 5357 | rc = validate_t2((struct smb_t2_rsp *)pSMBr); |
5346 | memcpy((char *) pFindData, | 5358 | if (rc || (pSMBr->ByteCount < 4)) { |
5347 | (char *) &pSMBr->hdr.Protocol + | 5359 | rc = -EIO; /* bad smb */ |
5348 | data_offset, kl); | 5360 | goto QAllEAsOut; |
5349 | }*/ else { | ||
5350 | /* check that length of list is not more than bcc */ | ||
5351 | /* check that each entry does not go beyond length | ||
5352 | of list */ | ||
5353 | /* check that each element of each entry does not | ||
5354 | go beyond end of list */ | ||
5355 | __u16 data_offset = le16_to_cpu(pSMBr->t2.DataOffset); | ||
5356 | struct fealist *ea_response_data; | ||
5357 | rc = 0; | ||
5358 | /* validate_trans2_offsets() */ | ||
5359 | /* BB check if start of smb + data_offset > &bcc+ bcc */ | ||
5360 | ea_response_data = (struct fealist *) | ||
5361 | (((char *) &pSMBr->hdr.Protocol) + | ||
5362 | data_offset); | ||
5363 | name_len = le32_to_cpu(ea_response_data->list_len); | ||
5364 | cFYI(1, ("ea length %d", name_len)); | ||
5365 | if (name_len <= 8) { | ||
5366 | /* returned EA size zeroed at top of function */ | ||
5367 | cFYI(1, ("empty EA list returned from server")); | ||
5368 | } else { | ||
5369 | /* account for ea list len */ | ||
5370 | name_len -= 4; | ||
5371 | temp_fea = ea_response_data->list; | ||
5372 | temp_ptr = (char *)temp_fea; | ||
5373 | while (name_len > 0) { | ||
5374 | __u16 value_len; | ||
5375 | name_len -= 4; | ||
5376 | temp_ptr += 4; | ||
5377 | rc += temp_fea->name_len; | ||
5378 | /* account for prefix user. and trailing null */ | ||
5379 | rc = rc + 5 + 1; | ||
5380 | if (rc < (int)buf_size) { | ||
5381 | memcpy(EAData, "user.", 5); | ||
5382 | EAData += 5; | ||
5383 | memcpy(EAData, temp_ptr, | ||
5384 | temp_fea->name_len); | ||
5385 | EAData += temp_fea->name_len; | ||
5386 | /* null terminate name */ | ||
5387 | *EAData = 0; | ||
5388 | EAData = EAData + 1; | ||
5389 | } else if (buf_size == 0) { | ||
5390 | /* skip copy - calc size only */ | ||
5391 | } else { | ||
5392 | /* stop before overrun buffer */ | ||
5393 | rc = -ERANGE; | ||
5394 | break; | ||
5395 | } | ||
5396 | name_len -= temp_fea->name_len; | ||
5397 | temp_ptr += temp_fea->name_len; | ||
5398 | /* account for trailing null */ | ||
5399 | name_len--; | ||
5400 | temp_ptr++; | ||
5401 | value_len = | ||
5402 | le16_to_cpu(temp_fea->value_len); | ||
5403 | name_len -= value_len; | ||
5404 | temp_ptr += value_len; | ||
5405 | /* BB check that temp_ptr is still | ||
5406 | within the SMB BB*/ | ||
5407 | |||
5408 | /* no trailing null to account for | ||
5409 | in value len */ | ||
5410 | /* go on to next EA */ | ||
5411 | temp_fea = (struct fea *)temp_ptr; | ||
5412 | } | ||
5413 | } | ||
5414 | } | ||
5415 | } | 5361 | } |
5416 | cifs_buf_release(pSMB); | ||
5417 | if (rc == -EAGAIN) | ||
5418 | goto QAllEAsRetry; | ||
5419 | 5362 | ||
5420 | return (ssize_t)rc; | 5363 | /* check that length of list is not more than bcc */ |
5421 | } | 5364 | /* check that each entry does not go beyond length |
5365 | of list */ | ||
5366 | /* check that each element of each entry does not | ||
5367 | go beyond end of list */ | ||
5368 | /* validate_trans2_offsets() */ | ||
5369 | /* BB check if start of smb + data_offset > &bcc+ bcc */ | ||
5422 | 5370 | ||
5423 | ssize_t CIFSSMBQueryEA(const int xid, struct cifsTconInfo *tcon, | 5371 | data_offset = le16_to_cpu(pSMBr->t2.DataOffset); |
5424 | const unsigned char *searchName, const unsigned char *ea_name, | 5372 | ea_response_data = (struct fealist *) |
5425 | unsigned char *ea_value, size_t buf_size, | 5373 | (((char *) &pSMBr->hdr.Protocol) + data_offset); |
5426 | const struct nls_table *nls_codepage, int remap) | ||
5427 | { | ||
5428 | TRANSACTION2_QPI_REQ *pSMB = NULL; | ||
5429 | TRANSACTION2_QPI_RSP *pSMBr = NULL; | ||
5430 | int rc = 0; | ||
5431 | int bytes_returned; | ||
5432 | int name_len; | ||
5433 | struct fea *temp_fea; | ||
5434 | char *temp_ptr; | ||
5435 | __u16 params, byte_count; | ||
5436 | 5374 | ||
5437 | cFYI(1, ("In Query EA path %s", searchName)); | 5375 | list_len = le32_to_cpu(ea_response_data->list_len); |
5438 | QEARetry: | 5376 | cFYI(1, ("ea length %d", list_len)); |
5439 | rc = smb_init(SMB_COM_TRANSACTION2, 15, tcon, (void **) &pSMB, | 5377 | if (list_len <= 8) { |
5440 | (void **) &pSMBr); | 5378 | cFYI(1, ("empty EA list returned from server")); |
5441 | if (rc) | 5379 | goto QAllEAsOut; |
5442 | return rc; | 5380 | } |
5443 | 5381 | ||
5444 | if (pSMB->hdr.Flags2 & SMBFLG2_UNICODE) { | 5382 | /* make sure list_len doesn't go past end of SMB */ |
5445 | name_len = | 5383 | end_of_smb = (char *)pByteArea(&pSMBr->hdr) + BCC(&pSMBr->hdr); |
5446 | cifsConvertToUCS((__le16 *) pSMB->FileName, searchName, | 5384 | if ((char *)ea_response_data + list_len > end_of_smb) { |
5447 | PATH_MAX, nls_codepage, remap); | 5385 | cFYI(1, ("EA list appears to go beyond SMB")); |
5448 | name_len++; /* trailing null */ | 5386 | rc = -EIO; |
5449 | name_len *= 2; | 5387 | goto QAllEAsOut; |
5450 | } else { /* BB improve the check for buffer overruns BB */ | ||
5451 | name_len = strnlen(searchName, PATH_MAX); | ||
5452 | name_len++; /* trailing null */ | ||
5453 | strncpy(pSMB->FileName, searchName, name_len); | ||
5454 | } | 5388 | } |
5455 | 5389 | ||
5456 | params = 2 /* level */ + 4 /* reserved */ + name_len /* includes NUL */; | 5390 | /* account for ea list len */ |
5457 | pSMB->TotalDataCount = 0; | 5391 | list_len -= 4; |
5458 | pSMB->MaxParameterCount = cpu_to_le16(2); | 5392 | temp_fea = ea_response_data->list; |
5459 | /* BB find exact max SMB PDU from sess structure BB */ | 5393 | temp_ptr = (char *)temp_fea; |
5460 | pSMB->MaxDataCount = cpu_to_le16(4000); | 5394 | while (list_len > 0) { |
5461 | pSMB->MaxSetupCount = 0; | 5395 | unsigned int name_len; |
5462 | pSMB->Reserved = 0; | 5396 | __u16 value_len; |
5463 | pSMB->Flags = 0; | 5397 | |
5464 | pSMB->Timeout = 0; | 5398 | list_len -= 4; |
5465 | pSMB->Reserved2 = 0; | 5399 | temp_ptr += 4; |
5466 | pSMB->ParameterOffset = cpu_to_le16(offsetof( | 5400 | /* make sure we can read name_len and value_len */ |
5467 | struct smb_com_transaction2_qpi_req, InformationLevel) - 4); | 5401 | if (list_len < 0) { |
5468 | pSMB->DataCount = 0; | 5402 | cFYI(1, ("EA entry goes beyond length of list")); |
5469 | pSMB->DataOffset = 0; | 5403 | rc = -EIO; |
5470 | pSMB->SetupCount = 1; | 5404 | goto QAllEAsOut; |
5471 | pSMB->Reserved3 = 0; | 5405 | } |
5472 | pSMB->SubCommand = cpu_to_le16(TRANS2_QUERY_PATH_INFORMATION); | ||
5473 | byte_count = params + 1 /* pad */ ; | ||
5474 | pSMB->TotalParameterCount = cpu_to_le16(params); | ||
5475 | pSMB->ParameterCount = pSMB->TotalParameterCount; | ||
5476 | pSMB->InformationLevel = cpu_to_le16(SMB_INFO_QUERY_ALL_EAS); | ||
5477 | pSMB->Reserved4 = 0; | ||
5478 | pSMB->hdr.smb_buf_length += byte_count; | ||
5479 | pSMB->ByteCount = cpu_to_le16(byte_count); | ||
5480 | 5406 | ||
5481 | rc = SendReceive(xid, tcon->ses, (struct smb_hdr *) pSMB, | 5407 | name_len = temp_fea->name_len; |
5482 | (struct smb_hdr *) pSMBr, &bytes_returned, 0); | 5408 | value_len = le16_to_cpu(temp_fea->value_len); |
5483 | if (rc) { | 5409 | list_len -= name_len + 1 + value_len; |
5484 | cFYI(1, ("Send error in Query EA = %d", rc)); | 5410 | if (list_len < 0) { |
5485 | } else { /* decode response */ | 5411 | cFYI(1, ("EA entry goes beyond length of list")); |
5486 | rc = validate_t2((struct smb_t2_rsp *)pSMBr); | 5412 | rc = -EIO; |
5413 | goto QAllEAsOut; | ||
5414 | } | ||
5487 | 5415 | ||
5488 | /* BB also check enough total bytes returned */ | 5416 | if (ea_name) { |
5489 | /* BB we need to improve the validity checking | 5417 | if (strncmp(ea_name, temp_ptr, name_len) == 0) { |
5490 | of these trans2 responses */ | 5418 | temp_ptr += name_len + 1; |
5491 | if (rc || (pSMBr->ByteCount < 4)) | 5419 | rc = value_len; |
5492 | rc = -EIO; /* bad smb */ | 5420 | if (buf_size == 0) |
5493 | /* else if (pFindData){ | 5421 | goto QAllEAsOut; |
5494 | memcpy((char *) pFindData, | 5422 | if ((size_t)value_len > buf_size) { |
5495 | (char *) &pSMBr->hdr.Protocol + | 5423 | rc = -ERANGE; |
5496 | data_offset, kl); | 5424 | goto QAllEAsOut; |
5497 | }*/ else { | ||
5498 | /* check that length of list is not more than bcc */ | ||
5499 | /* check that each entry does not go beyond length | ||
5500 | of list */ | ||
5501 | /* check that each element of each entry does not | ||
5502 | go beyond end of list */ | ||
5503 | __u16 data_offset = le16_to_cpu(pSMBr->t2.DataOffset); | ||
5504 | struct fealist *ea_response_data; | ||
5505 | rc = -ENODATA; | ||
5506 | /* validate_trans2_offsets() */ | ||
5507 | /* BB check if start of smb + data_offset > &bcc+ bcc*/ | ||
5508 | ea_response_data = (struct fealist *) | ||
5509 | (((char *) &pSMBr->hdr.Protocol) + | ||
5510 | data_offset); | ||
5511 | name_len = le32_to_cpu(ea_response_data->list_len); | ||
5512 | cFYI(1, ("ea length %d", name_len)); | ||
5513 | if (name_len <= 8) { | ||
5514 | /* returned EA size zeroed at top of function */ | ||
5515 | cFYI(1, ("empty EA list returned from server")); | ||
5516 | } else { | ||
5517 | /* account for ea list len */ | ||
5518 | name_len -= 4; | ||
5519 | temp_fea = ea_response_data->list; | ||
5520 | temp_ptr = (char *)temp_fea; | ||
5521 | /* loop through checking if we have a matching | ||
5522 | name and then return the associated value */ | ||
5523 | while (name_len > 0) { | ||
5524 | __u16 value_len; | ||
5525 | name_len -= 4; | ||
5526 | temp_ptr += 4; | ||
5527 | value_len = | ||
5528 | le16_to_cpu(temp_fea->value_len); | ||
5529 | /* BB validate that value_len falls within SMB, | ||
5530 | even though maximum for name_len is 255 */ | ||
5531 | if (memcmp(temp_fea->name, ea_name, | ||
5532 | temp_fea->name_len) == 0) { | ||
5533 | /* found a match */ | ||
5534 | rc = value_len; | ||
5535 | /* account for prefix user. and trailing null */ | ||
5536 | if (rc <= (int)buf_size) { | ||
5537 | memcpy(ea_value, | ||
5538 | temp_fea->name+temp_fea->name_len+1, | ||
5539 | rc); | ||
5540 | /* ea values, unlike ea | ||
5541 | names, are not null | ||
5542 | terminated */ | ||
5543 | } else if (buf_size == 0) { | ||
5544 | /* skip copy - calc size only */ | ||
5545 | } else { | ||
5546 | /* stop before overrun buffer */ | ||
5547 | rc = -ERANGE; | ||
5548 | } | ||
5549 | break; | ||
5550 | } | ||
5551 | name_len -= temp_fea->name_len; | ||
5552 | temp_ptr += temp_fea->name_len; | ||
5553 | /* account for trailing null */ | ||
5554 | name_len--; | ||
5555 | temp_ptr++; | ||
5556 | name_len -= value_len; | ||
5557 | temp_ptr += value_len; | ||
5558 | /* No trailing null to account for in | ||
5559 | value_len. Go on to next EA */ | ||
5560 | temp_fea = (struct fea *)temp_ptr; | ||
5561 | } | 5425 | } |
5426 | memcpy(EAData, temp_ptr, value_len); | ||
5427 | goto QAllEAsOut; | ||
5428 | } | ||
5429 | } else { | ||
5430 | /* account for prefix user. and trailing null */ | ||
5431 | rc += (5 + 1 + name_len); | ||
5432 | if (rc < (int) buf_size) { | ||
5433 | memcpy(EAData, "user.", 5); | ||
5434 | EAData += 5; | ||
5435 | memcpy(EAData, temp_ptr, name_len); | ||
5436 | EAData += name_len; | ||
5437 | /* null terminate name */ | ||
5438 | *EAData = 0; | ||
5439 | ++EAData; | ||
5440 | } else if (buf_size == 0) { | ||
5441 | /* skip copy - calc size only */ | ||
5442 | } else { | ||
5443 | /* stop before overrun buffer */ | ||
5444 | rc = -ERANGE; | ||
5445 | break; | ||
5562 | } | 5446 | } |
5563 | } | 5447 | } |
5448 | temp_ptr += name_len + 1 + value_len; | ||
5449 | temp_fea = (struct fea *)temp_ptr; | ||
5564 | } | 5450 | } |
5451 | |||
5452 | /* didn't find the named attribute */ | ||
5453 | if (ea_name) | ||
5454 | rc = -ENODATA; | ||
5455 | |||
5456 | QAllEAsOut: | ||
5565 | cifs_buf_release(pSMB); | 5457 | cifs_buf_release(pSMB); |
5566 | if (rc == -EAGAIN) | 5458 | if (rc == -EAGAIN) |
5567 | goto QEARetry; | 5459 | goto QAllEAsRetry; |
5568 | 5460 | ||
5569 | return (ssize_t)rc; | 5461 | return (ssize_t)rc; |
5570 | } | 5462 | } |
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 2e9e09ca0e30..45eb6cba793f 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c | |||
@@ -2388,13 +2388,13 @@ try_mount_again: | |||
2388 | */ | 2388 | */ |
2389 | cifs_put_tcp_session(srvTcp); | 2389 | cifs_put_tcp_session(srvTcp); |
2390 | 2390 | ||
2391 | down(&pSesInfo->sesSem); | 2391 | mutex_lock(&pSesInfo->session_mutex); |
2392 | if (pSesInfo->need_reconnect) { | 2392 | if (pSesInfo->need_reconnect) { |
2393 | cFYI(1, ("Session needs reconnect")); | 2393 | cFYI(1, ("Session needs reconnect")); |
2394 | rc = cifs_setup_session(xid, pSesInfo, | 2394 | rc = cifs_setup_session(xid, pSesInfo, |
2395 | cifs_sb->local_nls); | 2395 | cifs_sb->local_nls); |
2396 | } | 2396 | } |
2397 | up(&pSesInfo->sesSem); | 2397 | mutex_unlock(&pSesInfo->session_mutex); |
2398 | } else if (!rc) { | 2398 | } else if (!rc) { |
2399 | cFYI(1, ("Existing smb sess not found")); | 2399 | cFYI(1, ("Existing smb sess not found")); |
2400 | pSesInfo = sesInfoAlloc(); | 2400 | pSesInfo = sesInfoAlloc(); |
@@ -2437,12 +2437,12 @@ try_mount_again: | |||
2437 | } | 2437 | } |
2438 | pSesInfo->linux_uid = volume_info->linux_uid; | 2438 | pSesInfo->linux_uid = volume_info->linux_uid; |
2439 | pSesInfo->overrideSecFlg = volume_info->secFlg; | 2439 | pSesInfo->overrideSecFlg = volume_info->secFlg; |
2440 | down(&pSesInfo->sesSem); | 2440 | mutex_lock(&pSesInfo->session_mutex); |
2441 | 2441 | ||
2442 | /* BB FIXME need to pass vol->secFlgs BB */ | 2442 | /* BB FIXME need to pass vol->secFlgs BB */ |
2443 | rc = cifs_setup_session(xid, pSesInfo, | 2443 | rc = cifs_setup_session(xid, pSesInfo, |
2444 | cifs_sb->local_nls); | 2444 | cifs_sb->local_nls); |
2445 | up(&pSesInfo->sesSem); | 2445 | mutex_unlock(&pSesInfo->session_mutex); |
2446 | } | 2446 | } |
2447 | 2447 | ||
2448 | /* search for existing tcon to this server share */ | 2448 | /* search for existing tcon to this server share */ |
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 057e1dae12ab..3d8f8a96f5a3 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c | |||
@@ -2289,9 +2289,9 @@ cifs_oplock_break(struct slow_work *work) | |||
2289 | if (inode && S_ISREG(inode->i_mode)) { | 2289 | if (inode && S_ISREG(inode->i_mode)) { |
2290 | #ifdef CONFIG_CIFS_EXPERIMENTAL | 2290 | #ifdef CONFIG_CIFS_EXPERIMENTAL |
2291 | if (cinode->clientCanCacheAll == 0) | 2291 | if (cinode->clientCanCacheAll == 0) |
2292 | break_lease(inode, FMODE_READ); | 2292 | break_lease(inode, O_RDONLY); |
2293 | else if (cinode->clientCanCacheRead == 0) | 2293 | else if (cinode->clientCanCacheRead == 0) |
2294 | break_lease(inode, FMODE_WRITE); | 2294 | break_lease(inode, O_WRONLY); |
2295 | #endif | 2295 | #endif |
2296 | rc = filemap_fdatawrite(inode->i_mapping); | 2296 | rc = filemap_fdatawrite(inode->i_mapping); |
2297 | if (cinode->clientCanCacheRead == 0) { | 2297 | if (cinode->clientCanCacheRead == 0) { |
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index e3fda978f481..8bdbc818164c 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c | |||
@@ -111,6 +111,7 @@ cifs_fattr_to_inode(struct inode *inode, struct cifs_fattr *fattr) | |||
111 | 111 | ||
112 | cifs_i->delete_pending = fattr->cf_flags & CIFS_FATTR_DELETE_PENDING; | 112 | cifs_i->delete_pending = fattr->cf_flags & CIFS_FATTR_DELETE_PENDING; |
113 | 113 | ||
114 | cifs_i->server_eof = fattr->cf_eof; | ||
114 | /* | 115 | /* |
115 | * Can't safely change the file size here if the client is writing to | 116 | * Can't safely change the file size here if the client is writing to |
116 | * it due to potential races. | 117 | * it due to potential races. |
@@ -366,7 +367,7 @@ static int cifs_sfu_mode(struct cifs_fattr *fattr, const unsigned char *path, | |||
366 | char ea_value[4]; | 367 | char ea_value[4]; |
367 | __u32 mode; | 368 | __u32 mode; |
368 | 369 | ||
369 | rc = CIFSSMBQueryEA(xid, cifs_sb->tcon, path, "SETFILEBITS", | 370 | rc = CIFSSMBQAllEAs(xid, cifs_sb->tcon, path, "SETFILEBITS", |
370 | ea_value, 4 /* size of buf */, cifs_sb->local_nls, | 371 | ea_value, 4 /* size of buf */, cifs_sb->local_nls, |
371 | cifs_sb->mnt_cifs_flags & | 372 | cifs_sb->mnt_cifs_flags & |
372 | CIFS_MOUNT_MAP_SPECIAL_CHR); | 373 | CIFS_MOUNT_MAP_SPECIAL_CHR); |
diff --git a/fs/cifs/misc.c b/fs/cifs/misc.c index d27d4ec6579b..d1474996a812 100644 --- a/fs/cifs/misc.c +++ b/fs/cifs/misc.c | |||
@@ -79,7 +79,7 @@ sesInfoAlloc(void) | |||
79 | ++ret_buf->ses_count; | 79 | ++ret_buf->ses_count; |
80 | INIT_LIST_HEAD(&ret_buf->smb_ses_list); | 80 | INIT_LIST_HEAD(&ret_buf->smb_ses_list); |
81 | INIT_LIST_HEAD(&ret_buf->tcon_list); | 81 | INIT_LIST_HEAD(&ret_buf->tcon_list); |
82 | init_MUTEX(&ret_buf->sesSem); | 82 | mutex_init(&ret_buf->session_mutex); |
83 | } | 83 | } |
84 | return ret_buf; | 84 | return ret_buf; |
85 | } | 85 | } |
diff --git a/fs/cifs/xattr.c b/fs/cifs/xattr.c index a75afa3dd9e1..3e2ef0de1209 100644 --- a/fs/cifs/xattr.c +++ b/fs/cifs/xattr.c | |||
@@ -244,7 +244,7 @@ ssize_t cifs_getxattr(struct dentry *direntry, const char *ea_name, | |||
244 | /* revalidate/getattr then populate from inode */ | 244 | /* revalidate/getattr then populate from inode */ |
245 | } /* BB add else when above is implemented */ | 245 | } /* BB add else when above is implemented */ |
246 | ea_name += 5; /* skip past user. prefix */ | 246 | ea_name += 5; /* skip past user. prefix */ |
247 | rc = CIFSSMBQueryEA(xid, pTcon, full_path, ea_name, ea_value, | 247 | rc = CIFSSMBQAllEAs(xid, pTcon, full_path, ea_name, ea_value, |
248 | buf_size, cifs_sb->local_nls, | 248 | buf_size, cifs_sb->local_nls, |
249 | cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR); | 249 | cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR); |
250 | } else if (strncmp(ea_name, CIFS_XATTR_OS2_PREFIX, 4) == 0) { | 250 | } else if (strncmp(ea_name, CIFS_XATTR_OS2_PREFIX, 4) == 0) { |
@@ -252,7 +252,7 @@ ssize_t cifs_getxattr(struct dentry *direntry, const char *ea_name, | |||
252 | goto get_ea_exit; | 252 | goto get_ea_exit; |
253 | 253 | ||
254 | ea_name += 4; /* skip past os2. prefix */ | 254 | ea_name += 4; /* skip past os2. prefix */ |
255 | rc = CIFSSMBQueryEA(xid, pTcon, full_path, ea_name, ea_value, | 255 | rc = CIFSSMBQAllEAs(xid, pTcon, full_path, ea_name, ea_value, |
256 | buf_size, cifs_sb->local_nls, | 256 | buf_size, cifs_sb->local_nls, |
257 | cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR); | 257 | cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR); |
258 | } else if (strncmp(ea_name, POSIX_ACL_XATTR_ACCESS, | 258 | } else if (strncmp(ea_name, POSIX_ACL_XATTR_ACCESS, |
@@ -364,8 +364,8 @@ ssize_t cifs_listxattr(struct dentry *direntry, char *data, size_t buf_size) | |||
364 | /* if proc/fs/cifs/streamstoxattr is set then | 364 | /* if proc/fs/cifs/streamstoxattr is set then |
365 | search server for EAs or streams to | 365 | search server for EAs or streams to |
366 | returns as xattrs */ | 366 | returns as xattrs */ |
367 | rc = CIFSSMBQAllEAs(xid, pTcon, full_path, data, buf_size, | 367 | rc = CIFSSMBQAllEAs(xid, pTcon, full_path, NULL, data, |
368 | cifs_sb->local_nls, | 368 | buf_size, cifs_sb->local_nls, |
369 | cifs_sb->mnt_cifs_flags & | 369 | cifs_sb->mnt_cifs_flags & |
370 | CIFS_MOUNT_MAP_SPECIAL_CHR); | 370 | CIFS_MOUNT_MAP_SPECIAL_CHR); |
371 | 371 | ||
diff --git a/fs/compat_binfmt_elf.c b/fs/compat_binfmt_elf.c index 0adced2f296f..112e45a17e99 100644 --- a/fs/compat_binfmt_elf.c +++ b/fs/compat_binfmt_elf.c | |||
@@ -28,10 +28,12 @@ | |||
28 | 28 | ||
29 | #undef elfhdr | 29 | #undef elfhdr |
30 | #undef elf_phdr | 30 | #undef elf_phdr |
31 | #undef elf_shdr | ||
31 | #undef elf_note | 32 | #undef elf_note |
32 | #undef elf_addr_t | 33 | #undef elf_addr_t |
33 | #define elfhdr elf32_hdr | 34 | #define elfhdr elf32_hdr |
34 | #define elf_phdr elf32_phdr | 35 | #define elf_phdr elf32_phdr |
36 | #define elf_shdr elf32_shdr | ||
35 | #define elf_note elf32_note | 37 | #define elf_note elf32_note |
36 | #define elf_addr_t Elf32_Addr | 38 | #define elf_addr_t Elf32_Addr |
37 | 39 | ||
diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c index 0ca9ec4a79c3..6d55b61bfa79 100644 --- a/fs/compat_ioctl.c +++ b/fs/compat_ioctl.c | |||
@@ -545,7 +545,7 @@ static int mt_ioctl_trans(unsigned int fd, unsigned int cmd, void __user *argp) | |||
545 | kcmd = MTIOCPOS; | 545 | kcmd = MTIOCPOS; |
546 | karg = &pos; | 546 | karg = &pos; |
547 | break; | 547 | break; |
548 | case MTIOCGET32: | 548 | default: /* MTIOCGET32 */ |
549 | kcmd = MTIOCGET; | 549 | kcmd = MTIOCGET; |
550 | karg = &get; | 550 | karg = &get; |
551 | break; | 551 | break; |
@@ -663,7 +663,7 @@ static int raw_ioctl(unsigned fd, unsigned cmd, | |||
663 | 663 | ||
664 | switch (cmd) { | 664 | switch (cmd) { |
665 | case RAW_SETBIND: | 665 | case RAW_SETBIND: |
666 | case RAW_GETBIND: { | 666 | default: { /* RAW_GETBIND */ |
667 | struct raw_config_request req; | 667 | struct raw_config_request req; |
668 | mm_segment_t oldfs = get_fs(); | 668 | mm_segment_t oldfs = get_fs(); |
669 | 669 | ||
diff --git a/fs/dcache.c b/fs/dcache.c index 953173a293a9..f1358e5c3a59 100644 --- a/fs/dcache.c +++ b/fs/dcache.c | |||
@@ -257,6 +257,7 @@ kill_it: | |||
257 | if (dentry) | 257 | if (dentry) |
258 | goto repeat; | 258 | goto repeat; |
259 | } | 259 | } |
260 | EXPORT_SYMBOL(dput); | ||
260 | 261 | ||
261 | /** | 262 | /** |
262 | * d_invalidate - invalidate a dentry | 263 | * d_invalidate - invalidate a dentry |
@@ -314,6 +315,7 @@ int d_invalidate(struct dentry * dentry) | |||
314 | spin_unlock(&dcache_lock); | 315 | spin_unlock(&dcache_lock); |
315 | return 0; | 316 | return 0; |
316 | } | 317 | } |
318 | EXPORT_SYMBOL(d_invalidate); | ||
317 | 319 | ||
318 | /* This should be called _only_ with dcache_lock held */ | 320 | /* This should be called _only_ with dcache_lock held */ |
319 | 321 | ||
@@ -328,6 +330,7 @@ struct dentry * dget_locked(struct dentry *dentry) | |||
328 | { | 330 | { |
329 | return __dget_locked(dentry); | 331 | return __dget_locked(dentry); |
330 | } | 332 | } |
333 | EXPORT_SYMBOL(dget_locked); | ||
331 | 334 | ||
332 | /** | 335 | /** |
333 | * d_find_alias - grab a hashed alias of inode | 336 | * d_find_alias - grab a hashed alias of inode |
@@ -384,6 +387,7 @@ struct dentry * d_find_alias(struct inode *inode) | |||
384 | } | 387 | } |
385 | return de; | 388 | return de; |
386 | } | 389 | } |
390 | EXPORT_SYMBOL(d_find_alias); | ||
387 | 391 | ||
388 | /* | 392 | /* |
389 | * Try to kill dentries associated with this inode. | 393 | * Try to kill dentries associated with this inode. |
@@ -408,6 +412,7 @@ restart: | |||
408 | } | 412 | } |
409 | spin_unlock(&dcache_lock); | 413 | spin_unlock(&dcache_lock); |
410 | } | 414 | } |
415 | EXPORT_SYMBOL(d_prune_aliases); | ||
411 | 416 | ||
412 | /* | 417 | /* |
413 | * Throw away a dentry - free the inode, dput the parent. This requires that | 418 | * Throw away a dentry - free the inode, dput the parent. This requires that |
@@ -610,6 +615,7 @@ void shrink_dcache_sb(struct super_block * sb) | |||
610 | { | 615 | { |
611 | __shrink_dcache_sb(sb, NULL, 0); | 616 | __shrink_dcache_sb(sb, NULL, 0); |
612 | } | 617 | } |
618 | EXPORT_SYMBOL(shrink_dcache_sb); | ||
613 | 619 | ||
614 | /* | 620 | /* |
615 | * destroy a single subtree of dentries for unmount | 621 | * destroy a single subtree of dentries for unmount |
@@ -792,6 +798,7 @@ positive: | |||
792 | spin_unlock(&dcache_lock); | 798 | spin_unlock(&dcache_lock); |
793 | return 1; | 799 | return 1; |
794 | } | 800 | } |
801 | EXPORT_SYMBOL(have_submounts); | ||
795 | 802 | ||
796 | /* | 803 | /* |
797 | * Search the dentry child list for the specified parent, | 804 | * Search the dentry child list for the specified parent, |
@@ -876,6 +883,7 @@ void shrink_dcache_parent(struct dentry * parent) | |||
876 | while ((found = select_parent(parent)) != 0) | 883 | while ((found = select_parent(parent)) != 0) |
877 | __shrink_dcache_sb(sb, &found, 0); | 884 | __shrink_dcache_sb(sb, &found, 0); |
878 | } | 885 | } |
886 | EXPORT_SYMBOL(shrink_dcache_parent); | ||
879 | 887 | ||
880 | /* | 888 | /* |
881 | * Scan `nr' dentries and return the number which remain. | 889 | * Scan `nr' dentries and return the number which remain. |
@@ -968,6 +976,7 @@ struct dentry *d_alloc(struct dentry * parent, const struct qstr *name) | |||
968 | 976 | ||
969 | return dentry; | 977 | return dentry; |
970 | } | 978 | } |
979 | EXPORT_SYMBOL(d_alloc); | ||
971 | 980 | ||
972 | struct dentry *d_alloc_name(struct dentry *parent, const char *name) | 981 | struct dentry *d_alloc_name(struct dentry *parent, const char *name) |
973 | { | 982 | { |
@@ -1012,6 +1021,7 @@ void d_instantiate(struct dentry *entry, struct inode * inode) | |||
1012 | spin_unlock(&dcache_lock); | 1021 | spin_unlock(&dcache_lock); |
1013 | security_d_instantiate(entry, inode); | 1022 | security_d_instantiate(entry, inode); |
1014 | } | 1023 | } |
1024 | EXPORT_SYMBOL(d_instantiate); | ||
1015 | 1025 | ||
1016 | /** | 1026 | /** |
1017 | * d_instantiate_unique - instantiate a non-aliased dentry | 1027 | * d_instantiate_unique - instantiate a non-aliased dentry |
@@ -1108,6 +1118,7 @@ struct dentry * d_alloc_root(struct inode * root_inode) | |||
1108 | } | 1118 | } |
1109 | return res; | 1119 | return res; |
1110 | } | 1120 | } |
1121 | EXPORT_SYMBOL(d_alloc_root); | ||
1111 | 1122 | ||
1112 | static inline struct hlist_head *d_hash(struct dentry *parent, | 1123 | static inline struct hlist_head *d_hash(struct dentry *parent, |
1113 | unsigned long hash) | 1124 | unsigned long hash) |
@@ -1211,7 +1222,6 @@ struct dentry *d_splice_alias(struct inode *inode, struct dentry *dentry) | |||
1211 | BUG_ON(!(new->d_flags & DCACHE_DISCONNECTED)); | 1222 | BUG_ON(!(new->d_flags & DCACHE_DISCONNECTED)); |
1212 | spin_unlock(&dcache_lock); | 1223 | spin_unlock(&dcache_lock); |
1213 | security_d_instantiate(new, inode); | 1224 | security_d_instantiate(new, inode); |
1214 | d_rehash(dentry); | ||
1215 | d_move(new, dentry); | 1225 | d_move(new, dentry); |
1216 | iput(inode); | 1226 | iput(inode); |
1217 | } else { | 1227 | } else { |
@@ -1225,6 +1235,7 @@ struct dentry *d_splice_alias(struct inode *inode, struct dentry *dentry) | |||
1225 | d_add(dentry, inode); | 1235 | d_add(dentry, inode); |
1226 | return new; | 1236 | return new; |
1227 | } | 1237 | } |
1238 | EXPORT_SYMBOL(d_splice_alias); | ||
1228 | 1239 | ||
1229 | /** | 1240 | /** |
1230 | * d_add_ci - lookup or allocate new dentry with case-exact name | 1241 | * d_add_ci - lookup or allocate new dentry with case-exact name |
@@ -1314,6 +1325,7 @@ err_out: | |||
1314 | iput(inode); | 1325 | iput(inode); |
1315 | return ERR_PTR(error); | 1326 | return ERR_PTR(error); |
1316 | } | 1327 | } |
1328 | EXPORT_SYMBOL(d_add_ci); | ||
1317 | 1329 | ||
1318 | /** | 1330 | /** |
1319 | * d_lookup - search for a dentry | 1331 | * d_lookup - search for a dentry |
@@ -1357,6 +1369,7 @@ struct dentry * d_lookup(struct dentry * parent, struct qstr * name) | |||
1357 | } while (read_seqretry(&rename_lock, seq)); | 1369 | } while (read_seqretry(&rename_lock, seq)); |
1358 | return dentry; | 1370 | return dentry; |
1359 | } | 1371 | } |
1372 | EXPORT_SYMBOL(d_lookup); | ||
1360 | 1373 | ||
1361 | struct dentry * __d_lookup(struct dentry * parent, struct qstr * name) | 1374 | struct dentry * __d_lookup(struct dentry * parent, struct qstr * name) |
1362 | { | 1375 | { |
@@ -1483,6 +1496,7 @@ int d_validate(struct dentry *dentry, struct dentry *dparent) | |||
1483 | out: | 1496 | out: |
1484 | return 0; | 1497 | return 0; |
1485 | } | 1498 | } |
1499 | EXPORT_SYMBOL(d_validate); | ||
1486 | 1500 | ||
1487 | /* | 1501 | /* |
1488 | * When a file is deleted, we have two options: | 1502 | * When a file is deleted, we have two options: |
@@ -1528,6 +1542,7 @@ void d_delete(struct dentry * dentry) | |||
1528 | 1542 | ||
1529 | fsnotify_nameremove(dentry, isdir); | 1543 | fsnotify_nameremove(dentry, isdir); |
1530 | } | 1544 | } |
1545 | EXPORT_SYMBOL(d_delete); | ||
1531 | 1546 | ||
1532 | static void __d_rehash(struct dentry * entry, struct hlist_head *list) | 1547 | static void __d_rehash(struct dentry * entry, struct hlist_head *list) |
1533 | { | 1548 | { |
@@ -1556,6 +1571,7 @@ void d_rehash(struct dentry * entry) | |||
1556 | spin_unlock(&entry->d_lock); | 1571 | spin_unlock(&entry->d_lock); |
1557 | spin_unlock(&dcache_lock); | 1572 | spin_unlock(&dcache_lock); |
1558 | } | 1573 | } |
1574 | EXPORT_SYMBOL(d_rehash); | ||
1559 | 1575 | ||
1560 | /* | 1576 | /* |
1561 | * When switching names, the actual string doesn't strictly have to | 1577 | * When switching names, the actual string doesn't strictly have to |
@@ -1702,6 +1718,7 @@ void d_move(struct dentry * dentry, struct dentry * target) | |||
1702 | d_move_locked(dentry, target); | 1718 | d_move_locked(dentry, target); |
1703 | spin_unlock(&dcache_lock); | 1719 | spin_unlock(&dcache_lock); |
1704 | } | 1720 | } |
1721 | EXPORT_SYMBOL(d_move); | ||
1705 | 1722 | ||
1706 | /** | 1723 | /** |
1707 | * d_ancestor - search for an ancestor | 1724 | * d_ancestor - search for an ancestor |
@@ -1868,6 +1885,7 @@ shouldnt_be_hashed: | |||
1868 | spin_unlock(&dcache_lock); | 1885 | spin_unlock(&dcache_lock); |
1869 | BUG(); | 1886 | BUG(); |
1870 | } | 1887 | } |
1888 | EXPORT_SYMBOL_GPL(d_materialise_unique); | ||
1871 | 1889 | ||
1872 | static int prepend(char **buffer, int *buflen, const char *str, int namelen) | 1890 | static int prepend(char **buffer, int *buflen, const char *str, int namelen) |
1873 | { | 1891 | { |
@@ -2005,6 +2023,7 @@ char *d_path(const struct path *path, char *buf, int buflen) | |||
2005 | path_put(&root); | 2023 | path_put(&root); |
2006 | return res; | 2024 | return res; |
2007 | } | 2025 | } |
2026 | EXPORT_SYMBOL(d_path); | ||
2008 | 2027 | ||
2009 | /* | 2028 | /* |
2010 | * Helper function for dentry_operations.d_dname() members | 2029 | * Helper function for dentry_operations.d_dname() members |
@@ -2171,6 +2190,30 @@ int is_subdir(struct dentry *new_dentry, struct dentry *old_dentry) | |||
2171 | return result; | 2190 | return result; |
2172 | } | 2191 | } |
2173 | 2192 | ||
2193 | int path_is_under(struct path *path1, struct path *path2) | ||
2194 | { | ||
2195 | struct vfsmount *mnt = path1->mnt; | ||
2196 | struct dentry *dentry = path1->dentry; | ||
2197 | int res; | ||
2198 | spin_lock(&vfsmount_lock); | ||
2199 | if (mnt != path2->mnt) { | ||
2200 | for (;;) { | ||
2201 | if (mnt->mnt_parent == mnt) { | ||
2202 | spin_unlock(&vfsmount_lock); | ||
2203 | return 0; | ||
2204 | } | ||
2205 | if (mnt->mnt_parent == path2->mnt) | ||
2206 | break; | ||
2207 | mnt = mnt->mnt_parent; | ||
2208 | } | ||
2209 | dentry = mnt->mnt_mountpoint; | ||
2210 | } | ||
2211 | res = is_subdir(dentry, path2->dentry); | ||
2212 | spin_unlock(&vfsmount_lock); | ||
2213 | return res; | ||
2214 | } | ||
2215 | EXPORT_SYMBOL(path_is_under); | ||
2216 | |||
2174 | void d_genocide(struct dentry *root) | 2217 | void d_genocide(struct dentry *root) |
2175 | { | 2218 | { |
2176 | struct dentry *this_parent = root; | 2219 | struct dentry *this_parent = root; |
@@ -2228,6 +2271,7 @@ ino_t find_inode_number(struct dentry *dir, struct qstr *name) | |||
2228 | } | 2271 | } |
2229 | return ino; | 2272 | return ino; |
2230 | } | 2273 | } |
2274 | EXPORT_SYMBOL(find_inode_number); | ||
2231 | 2275 | ||
2232 | static __initdata unsigned long dhash_entries; | 2276 | static __initdata unsigned long dhash_entries; |
2233 | static int __init set_dhash_entries(char *str) | 2277 | static int __init set_dhash_entries(char *str) |
@@ -2297,6 +2341,7 @@ static void __init dcache_init(void) | |||
2297 | 2341 | ||
2298 | /* SLAB cache for __getname() consumers */ | 2342 | /* SLAB cache for __getname() consumers */ |
2299 | struct kmem_cache *names_cachep __read_mostly; | 2343 | struct kmem_cache *names_cachep __read_mostly; |
2344 | EXPORT_SYMBOL(names_cachep); | ||
2300 | 2345 | ||
2301 | EXPORT_SYMBOL(d_genocide); | 2346 | EXPORT_SYMBOL(d_genocide); |
2302 | 2347 | ||
@@ -2326,26 +2371,3 @@ void __init vfs_caches_init(unsigned long mempages) | |||
2326 | bdev_cache_init(); | 2371 | bdev_cache_init(); |
2327 | chrdev_init(); | 2372 | chrdev_init(); |
2328 | } | 2373 | } |
2329 | |||
2330 | EXPORT_SYMBOL(d_alloc); | ||
2331 | EXPORT_SYMBOL(d_alloc_root); | ||
2332 | EXPORT_SYMBOL(d_delete); | ||
2333 | EXPORT_SYMBOL(d_find_alias); | ||
2334 | EXPORT_SYMBOL(d_instantiate); | ||
2335 | EXPORT_SYMBOL(d_invalidate); | ||
2336 | EXPORT_SYMBOL(d_lookup); | ||
2337 | EXPORT_SYMBOL(d_move); | ||
2338 | EXPORT_SYMBOL_GPL(d_materialise_unique); | ||
2339 | EXPORT_SYMBOL(d_path); | ||
2340 | EXPORT_SYMBOL(d_prune_aliases); | ||
2341 | EXPORT_SYMBOL(d_rehash); | ||
2342 | EXPORT_SYMBOL(d_splice_alias); | ||
2343 | EXPORT_SYMBOL(d_add_ci); | ||
2344 | EXPORT_SYMBOL(d_validate); | ||
2345 | EXPORT_SYMBOL(dget_locked); | ||
2346 | EXPORT_SYMBOL(dput); | ||
2347 | EXPORT_SYMBOL(find_inode_number); | ||
2348 | EXPORT_SYMBOL(have_submounts); | ||
2349 | EXPORT_SYMBOL(names_cachep); | ||
2350 | EXPORT_SYMBOL(shrink_dcache_parent); | ||
2351 | EXPORT_SYMBOL(shrink_dcache_sb); | ||
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index 274ac865bae8..049d6c36da09 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c | |||
@@ -496,7 +496,7 @@ struct dentry *debugfs_rename(struct dentry *old_dir, struct dentry *old_dentry, | |||
496 | } | 496 | } |
497 | d_move(old_dentry, dentry); | 497 | d_move(old_dentry, dentry); |
498 | fsnotify_move(old_dir->d_inode, new_dir->d_inode, old_name, | 498 | fsnotify_move(old_dir->d_inode, new_dir->d_inode, old_name, |
499 | old_dentry->d_name.name, S_ISDIR(old_dentry->d_inode->i_mode), | 499 | S_ISDIR(old_dentry->d_inode->i_mode), |
500 | NULL, old_dentry); | 500 | NULL, old_dentry); |
501 | fsnotify_oldname_free(old_name); | 501 | fsnotify_oldname_free(old_name); |
502 | unlock_rename(new_dir, old_dir); | 502 | unlock_rename(new_dir, old_dir); |
diff --git a/fs/dlm/ast.c b/fs/dlm/ast.c index dc2ad6008b2d..4314f0d48d85 100644 --- a/fs/dlm/ast.c +++ b/fs/dlm/ast.c | |||
@@ -2,7 +2,7 @@ | |||
2 | ******************************************************************************* | 2 | ******************************************************************************* |
3 | ** | 3 | ** |
4 | ** Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. | 4 | ** Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. |
5 | ** Copyright (C) 2004-2008 Red Hat, Inc. All rights reserved. | 5 | ** Copyright (C) 2004-2010 Red Hat, Inc. All rights reserved. |
6 | ** | 6 | ** |
7 | ** This copyrighted material is made available to anyone wishing to use, | 7 | ** This copyrighted material is made available to anyone wishing to use, |
8 | ** modify, copy, or redistribute it subject to the terms and conditions | 8 | ** modify, copy, or redistribute it subject to the terms and conditions |
@@ -33,10 +33,10 @@ void dlm_del_ast(struct dlm_lkb *lkb) | |||
33 | spin_unlock(&ast_queue_lock); | 33 | spin_unlock(&ast_queue_lock); |
34 | } | 34 | } |
35 | 35 | ||
36 | void dlm_add_ast(struct dlm_lkb *lkb, int type, int bastmode) | 36 | void dlm_add_ast(struct dlm_lkb *lkb, int type, int mode) |
37 | { | 37 | { |
38 | if (lkb->lkb_flags & DLM_IFL_USER) { | 38 | if (lkb->lkb_flags & DLM_IFL_USER) { |
39 | dlm_user_add_ast(lkb, type, bastmode); | 39 | dlm_user_add_ast(lkb, type, mode); |
40 | return; | 40 | return; |
41 | } | 41 | } |
42 | 42 | ||
@@ -44,10 +44,21 @@ void dlm_add_ast(struct dlm_lkb *lkb, int type, int bastmode) | |||
44 | if (!(lkb->lkb_ast_type & (AST_COMP | AST_BAST))) { | 44 | if (!(lkb->lkb_ast_type & (AST_COMP | AST_BAST))) { |
45 | kref_get(&lkb->lkb_ref); | 45 | kref_get(&lkb->lkb_ref); |
46 | list_add_tail(&lkb->lkb_astqueue, &ast_queue); | 46 | list_add_tail(&lkb->lkb_astqueue, &ast_queue); |
47 | lkb->lkb_ast_first = type; | ||
47 | } | 48 | } |
49 | |||
50 | /* sanity check, this should not happen */ | ||
51 | |||
52 | if ((type == AST_COMP) && (lkb->lkb_ast_type & AST_COMP)) | ||
53 | log_print("repeat cast %d castmode %d lock %x %s", | ||
54 | mode, lkb->lkb_castmode, | ||
55 | lkb->lkb_id, lkb->lkb_resource->res_name); | ||
56 | |||
48 | lkb->lkb_ast_type |= type; | 57 | lkb->lkb_ast_type |= type; |
49 | if (bastmode) | 58 | if (type == AST_BAST) |
50 | lkb->lkb_bastmode = bastmode; | 59 | lkb->lkb_bastmode = mode; |
60 | else | ||
61 | lkb->lkb_castmode = mode; | ||
51 | spin_unlock(&ast_queue_lock); | 62 | spin_unlock(&ast_queue_lock); |
52 | 63 | ||
53 | set_bit(WAKE_ASTS, &astd_wakeflags); | 64 | set_bit(WAKE_ASTS, &astd_wakeflags); |
@@ -59,9 +70,9 @@ static void process_asts(void) | |||
59 | struct dlm_ls *ls = NULL; | 70 | struct dlm_ls *ls = NULL; |
60 | struct dlm_rsb *r = NULL; | 71 | struct dlm_rsb *r = NULL; |
61 | struct dlm_lkb *lkb; | 72 | struct dlm_lkb *lkb; |
62 | void (*cast) (void *astparam); | 73 | void (*castfn) (void *astparam); |
63 | void (*bast) (void *astparam, int mode); | 74 | void (*bastfn) (void *astparam, int mode); |
64 | int type = 0, bastmode; | 75 | int type, first, bastmode, castmode, do_bast, do_cast, last_castmode; |
65 | 76 | ||
66 | repeat: | 77 | repeat: |
67 | spin_lock(&ast_queue_lock); | 78 | spin_lock(&ast_queue_lock); |
@@ -75,17 +86,48 @@ repeat: | |||
75 | list_del(&lkb->lkb_astqueue); | 86 | list_del(&lkb->lkb_astqueue); |
76 | type = lkb->lkb_ast_type; | 87 | type = lkb->lkb_ast_type; |
77 | lkb->lkb_ast_type = 0; | 88 | lkb->lkb_ast_type = 0; |
89 | first = lkb->lkb_ast_first; | ||
90 | lkb->lkb_ast_first = 0; | ||
78 | bastmode = lkb->lkb_bastmode; | 91 | bastmode = lkb->lkb_bastmode; |
79 | 92 | castmode = lkb->lkb_castmode; | |
93 | castfn = lkb->lkb_astfn; | ||
94 | bastfn = lkb->lkb_bastfn; | ||
80 | spin_unlock(&ast_queue_lock); | 95 | spin_unlock(&ast_queue_lock); |
81 | cast = lkb->lkb_astfn; | ||
82 | bast = lkb->lkb_bastfn; | ||
83 | |||
84 | if ((type & AST_COMP) && cast) | ||
85 | cast(lkb->lkb_astparam); | ||
86 | 96 | ||
87 | if ((type & AST_BAST) && bast) | 97 | do_cast = (type & AST_COMP) && castfn; |
88 | bast(lkb->lkb_astparam, bastmode); | 98 | do_bast = (type & AST_BAST) && bastfn; |
99 | |||
100 | /* Skip a bast if its blocking mode is compatible with the | ||
101 | granted mode of the preceding cast. */ | ||
102 | |||
103 | if (do_bast) { | ||
104 | if (first == AST_COMP) | ||
105 | last_castmode = castmode; | ||
106 | else | ||
107 | last_castmode = lkb->lkb_castmode_done; | ||
108 | if (dlm_modes_compat(bastmode, last_castmode)) | ||
109 | do_bast = 0; | ||
110 | } | ||
111 | |||
112 | if (first == AST_COMP) { | ||
113 | if (do_cast) | ||
114 | castfn(lkb->lkb_astparam); | ||
115 | if (do_bast) | ||
116 | bastfn(lkb->lkb_astparam, bastmode); | ||
117 | } else if (first == AST_BAST) { | ||
118 | if (do_bast) | ||
119 | bastfn(lkb->lkb_astparam, bastmode); | ||
120 | if (do_cast) | ||
121 | castfn(lkb->lkb_astparam); | ||
122 | } else { | ||
123 | log_error(ls, "bad ast_first %d ast_type %d", | ||
124 | first, type); | ||
125 | } | ||
126 | |||
127 | if (do_cast) | ||
128 | lkb->lkb_castmode_done = castmode; | ||
129 | if (do_bast) | ||
130 | lkb->lkb_bastmode_done = bastmode; | ||
89 | 131 | ||
90 | /* this removes the reference added by dlm_add_ast | 132 | /* this removes the reference added by dlm_add_ast |
91 | and may result in the lkb being freed */ | 133 | and may result in the lkb being freed */ |
diff --git a/fs/dlm/ast.h b/fs/dlm/ast.h index 1b5fc5f428fd..bcb1aaba519d 100644 --- a/fs/dlm/ast.h +++ b/fs/dlm/ast.h | |||
@@ -1,7 +1,7 @@ | |||
1 | /****************************************************************************** | 1 | /****************************************************************************** |
2 | ******************************************************************************* | 2 | ******************************************************************************* |
3 | ** | 3 | ** |
4 | ** Copyright (C) 2005-2008 Red Hat, Inc. All rights reserved. | 4 | ** Copyright (C) 2005-2010 Red Hat, Inc. All rights reserved. |
5 | ** | 5 | ** |
6 | ** This copyrighted material is made available to anyone wishing to use, | 6 | ** This copyrighted material is made available to anyone wishing to use, |
7 | ** modify, copy, or redistribute it subject to the terms and conditions | 7 | ** modify, copy, or redistribute it subject to the terms and conditions |
@@ -13,7 +13,7 @@ | |||
13 | #ifndef __ASTD_DOT_H__ | 13 | #ifndef __ASTD_DOT_H__ |
14 | #define __ASTD_DOT_H__ | 14 | #define __ASTD_DOT_H__ |
15 | 15 | ||
16 | void dlm_add_ast(struct dlm_lkb *lkb, int type, int bastmode); | 16 | void dlm_add_ast(struct dlm_lkb *lkb, int type, int mode); |
17 | void dlm_del_ast(struct dlm_lkb *lkb); | 17 | void dlm_del_ast(struct dlm_lkb *lkb); |
18 | 18 | ||
19 | void dlm_astd_wake(void); | 19 | void dlm_astd_wake(void); |
diff --git a/fs/dlm/debug_fs.c b/fs/dlm/debug_fs.c index 375a2359b3bf..29d6139c35fc 100644 --- a/fs/dlm/debug_fs.c +++ b/fs/dlm/debug_fs.c | |||
@@ -256,7 +256,7 @@ static int print_format3_lock(struct seq_file *s, struct dlm_lkb *lkb, | |||
256 | lkb->lkb_status, | 256 | lkb->lkb_status, |
257 | lkb->lkb_grmode, | 257 | lkb->lkb_grmode, |
258 | lkb->lkb_rqmode, | 258 | lkb->lkb_rqmode, |
259 | lkb->lkb_highbast, | 259 | lkb->lkb_bastmode, |
260 | rsb_lookup, | 260 | rsb_lookup, |
261 | lkb->lkb_wait_type, | 261 | lkb->lkb_wait_type, |
262 | lkb->lkb_lvbseq, | 262 | lkb->lkb_lvbseq, |
diff --git a/fs/dlm/dlm_internal.h b/fs/dlm/dlm_internal.h index 826d3dc6e0ab..f632b58cd222 100644 --- a/fs/dlm/dlm_internal.h +++ b/fs/dlm/dlm_internal.h | |||
@@ -2,7 +2,7 @@ | |||
2 | ******************************************************************************* | 2 | ******************************************************************************* |
3 | ** | 3 | ** |
4 | ** Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. | 4 | ** Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved. |
5 | ** Copyright (C) 2004-2008 Red Hat, Inc. All rights reserved. | 5 | ** Copyright (C) 2004-2010 Red Hat, Inc. All rights reserved. |
6 | ** | 6 | ** |
7 | ** This copyrighted material is made available to anyone wishing to use, | 7 | ** This copyrighted material is made available to anyone wishing to use, |
8 | ** modify, copy, or redistribute it subject to the terms and conditions | 8 | ** modify, copy, or redistribute it subject to the terms and conditions |
@@ -232,11 +232,17 @@ struct dlm_lkb { | |||
232 | int8_t lkb_status; /* granted, waiting, convert */ | 232 | int8_t lkb_status; /* granted, waiting, convert */ |
233 | int8_t lkb_rqmode; /* requested lock mode */ | 233 | int8_t lkb_rqmode; /* requested lock mode */ |
234 | int8_t lkb_grmode; /* granted lock mode */ | 234 | int8_t lkb_grmode; /* granted lock mode */ |
235 | int8_t lkb_bastmode; /* requested mode */ | ||
236 | int8_t lkb_highbast; /* highest mode bast sent for */ | 235 | int8_t lkb_highbast; /* highest mode bast sent for */ |
236 | |||
237 | int8_t lkb_wait_type; /* type of reply waiting for */ | 237 | int8_t lkb_wait_type; /* type of reply waiting for */ |
238 | int8_t lkb_wait_count; | 238 | int8_t lkb_wait_count; |
239 | int8_t lkb_ast_type; /* type of ast queued for */ | 239 | int8_t lkb_ast_type; /* type of ast queued for */ |
240 | int8_t lkb_ast_first; /* type of first ast queued */ | ||
241 | |||
242 | int8_t lkb_bastmode; /* req mode of queued bast */ | ||
243 | int8_t lkb_castmode; /* gr mode of queued cast */ | ||
244 | int8_t lkb_bastmode_done; /* last delivered bastmode */ | ||
245 | int8_t lkb_castmode_done; /* last delivered castmode */ | ||
240 | 246 | ||
241 | struct list_head lkb_idtbl_list; /* lockspace lkbtbl */ | 247 | struct list_head lkb_idtbl_list; /* lockspace lkbtbl */ |
242 | struct list_head lkb_statequeue; /* rsb g/c/w list */ | 248 | struct list_head lkb_statequeue; /* rsb g/c/w list */ |
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 9c0c1db1e105..46ffd3eeaaf7 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c | |||
@@ -1,7 +1,7 @@ | |||
1 | /****************************************************************************** | 1 | /****************************************************************************** |
2 | ******************************************************************************* | 2 | ******************************************************************************* |
3 | ** | 3 | ** |
4 | ** Copyright (C) 2005-2008 Red Hat, Inc. All rights reserved. | 4 | ** Copyright (C) 2005-2010 Red Hat, Inc. All rights reserved. |
5 | ** | 5 | ** |
6 | ** This copyrighted material is made available to anyone wishing to use, | 6 | ** This copyrighted material is made available to anyone wishing to use, |
7 | ** modify, copy, or redistribute it subject to the terms and conditions | 7 | ** modify, copy, or redistribute it subject to the terms and conditions |
@@ -307,7 +307,7 @@ static void queue_cast(struct dlm_rsb *r, struct dlm_lkb *lkb, int rv) | |||
307 | lkb->lkb_lksb->sb_status = rv; | 307 | lkb->lkb_lksb->sb_status = rv; |
308 | lkb->lkb_lksb->sb_flags = lkb->lkb_sbflags; | 308 | lkb->lkb_lksb->sb_flags = lkb->lkb_sbflags; |
309 | 309 | ||
310 | dlm_add_ast(lkb, AST_COMP, 0); | 310 | dlm_add_ast(lkb, AST_COMP, lkb->lkb_grmode); |
311 | } | 311 | } |
312 | 312 | ||
313 | static inline void queue_cast_overlap(struct dlm_rsb *r, struct dlm_lkb *lkb) | 313 | static inline void queue_cast_overlap(struct dlm_rsb *r, struct dlm_lkb *lkb) |
@@ -320,10 +320,12 @@ static void queue_bast(struct dlm_rsb *r, struct dlm_lkb *lkb, int rqmode) | |||
320 | { | 320 | { |
321 | lkb->lkb_time_bast = ktime_get(); | 321 | lkb->lkb_time_bast = ktime_get(); |
322 | 322 | ||
323 | if (is_master_copy(lkb)) | 323 | if (is_master_copy(lkb)) { |
324 | lkb->lkb_bastmode = rqmode; /* printed by debugfs */ | ||
324 | send_bast(r, lkb, rqmode); | 325 | send_bast(r, lkb, rqmode); |
325 | else | 326 | } else { |
326 | dlm_add_ast(lkb, AST_BAST, rqmode); | 327 | dlm_add_ast(lkb, AST_BAST, rqmode); |
328 | } | ||
327 | } | 329 | } |
328 | 330 | ||
329 | /* | 331 | /* |
@@ -2280,20 +2282,30 @@ static int do_request(struct dlm_rsb *r, struct dlm_lkb *lkb) | |||
2280 | if (can_be_queued(lkb)) { | 2282 | if (can_be_queued(lkb)) { |
2281 | error = -EINPROGRESS; | 2283 | error = -EINPROGRESS; |
2282 | add_lkb(r, lkb, DLM_LKSTS_WAITING); | 2284 | add_lkb(r, lkb, DLM_LKSTS_WAITING); |
2283 | send_blocking_asts(r, lkb); | ||
2284 | add_timeout(lkb); | 2285 | add_timeout(lkb); |
2285 | goto out; | 2286 | goto out; |
2286 | } | 2287 | } |
2287 | 2288 | ||
2288 | error = -EAGAIN; | 2289 | error = -EAGAIN; |
2289 | if (force_blocking_asts(lkb)) | ||
2290 | send_blocking_asts_all(r, lkb); | ||
2291 | queue_cast(r, lkb, -EAGAIN); | 2290 | queue_cast(r, lkb, -EAGAIN); |
2292 | |||
2293 | out: | 2291 | out: |
2294 | return error; | 2292 | return error; |
2295 | } | 2293 | } |
2296 | 2294 | ||
2295 | static void do_request_effects(struct dlm_rsb *r, struct dlm_lkb *lkb, | ||
2296 | int error) | ||
2297 | { | ||
2298 | switch (error) { | ||
2299 | case -EAGAIN: | ||
2300 | if (force_blocking_asts(lkb)) | ||
2301 | send_blocking_asts_all(r, lkb); | ||
2302 | break; | ||
2303 | case -EINPROGRESS: | ||
2304 | send_blocking_asts(r, lkb); | ||
2305 | break; | ||
2306 | } | ||
2307 | } | ||
2308 | |||
2297 | static int do_convert(struct dlm_rsb *r, struct dlm_lkb *lkb) | 2309 | static int do_convert(struct dlm_rsb *r, struct dlm_lkb *lkb) |
2298 | { | 2310 | { |
2299 | int error = 0; | 2311 | int error = 0; |
@@ -2304,7 +2316,6 @@ static int do_convert(struct dlm_rsb *r, struct dlm_lkb *lkb) | |||
2304 | if (can_be_granted(r, lkb, 1, &deadlk)) { | 2316 | if (can_be_granted(r, lkb, 1, &deadlk)) { |
2305 | grant_lock(r, lkb); | 2317 | grant_lock(r, lkb); |
2306 | queue_cast(r, lkb, 0); | 2318 | queue_cast(r, lkb, 0); |
2307 | grant_pending_locks(r); | ||
2308 | goto out; | 2319 | goto out; |
2309 | } | 2320 | } |
2310 | 2321 | ||
@@ -2334,7 +2345,6 @@ static int do_convert(struct dlm_rsb *r, struct dlm_lkb *lkb) | |||
2334 | if (_can_be_granted(r, lkb, 1)) { | 2345 | if (_can_be_granted(r, lkb, 1)) { |
2335 | grant_lock(r, lkb); | 2346 | grant_lock(r, lkb); |
2336 | queue_cast(r, lkb, 0); | 2347 | queue_cast(r, lkb, 0); |
2337 | grant_pending_locks(r); | ||
2338 | goto out; | 2348 | goto out; |
2339 | } | 2349 | } |
2340 | /* else fall through and move to convert queue */ | 2350 | /* else fall through and move to convert queue */ |
@@ -2344,28 +2354,47 @@ static int do_convert(struct dlm_rsb *r, struct dlm_lkb *lkb) | |||
2344 | error = -EINPROGRESS; | 2354 | error = -EINPROGRESS; |
2345 | del_lkb(r, lkb); | 2355 | del_lkb(r, lkb); |
2346 | add_lkb(r, lkb, DLM_LKSTS_CONVERT); | 2356 | add_lkb(r, lkb, DLM_LKSTS_CONVERT); |
2347 | send_blocking_asts(r, lkb); | ||
2348 | add_timeout(lkb); | 2357 | add_timeout(lkb); |
2349 | goto out; | 2358 | goto out; |
2350 | } | 2359 | } |
2351 | 2360 | ||
2352 | error = -EAGAIN; | 2361 | error = -EAGAIN; |
2353 | if (force_blocking_asts(lkb)) | ||
2354 | send_blocking_asts_all(r, lkb); | ||
2355 | queue_cast(r, lkb, -EAGAIN); | 2362 | queue_cast(r, lkb, -EAGAIN); |
2356 | |||
2357 | out: | 2363 | out: |
2358 | return error; | 2364 | return error; |
2359 | } | 2365 | } |
2360 | 2366 | ||
2367 | static void do_convert_effects(struct dlm_rsb *r, struct dlm_lkb *lkb, | ||
2368 | int error) | ||
2369 | { | ||
2370 | switch (error) { | ||
2371 | case 0: | ||
2372 | grant_pending_locks(r); | ||
2373 | /* grant_pending_locks also sends basts */ | ||
2374 | break; | ||
2375 | case -EAGAIN: | ||
2376 | if (force_blocking_asts(lkb)) | ||
2377 | send_blocking_asts_all(r, lkb); | ||
2378 | break; | ||
2379 | case -EINPROGRESS: | ||
2380 | send_blocking_asts(r, lkb); | ||
2381 | break; | ||
2382 | } | ||
2383 | } | ||
2384 | |||
2361 | static int do_unlock(struct dlm_rsb *r, struct dlm_lkb *lkb) | 2385 | static int do_unlock(struct dlm_rsb *r, struct dlm_lkb *lkb) |
2362 | { | 2386 | { |
2363 | remove_lock(r, lkb); | 2387 | remove_lock(r, lkb); |
2364 | queue_cast(r, lkb, -DLM_EUNLOCK); | 2388 | queue_cast(r, lkb, -DLM_EUNLOCK); |
2365 | grant_pending_locks(r); | ||
2366 | return -DLM_EUNLOCK; | 2389 | return -DLM_EUNLOCK; |
2367 | } | 2390 | } |
2368 | 2391 | ||
2392 | static void do_unlock_effects(struct dlm_rsb *r, struct dlm_lkb *lkb, | ||
2393 | int error) | ||
2394 | { | ||
2395 | grant_pending_locks(r); | ||
2396 | } | ||
2397 | |||
2369 | /* returns: 0 did nothing, -DLM_ECANCEL canceled lock */ | 2398 | /* returns: 0 did nothing, -DLM_ECANCEL canceled lock */ |
2370 | 2399 | ||
2371 | static int do_cancel(struct dlm_rsb *r, struct dlm_lkb *lkb) | 2400 | static int do_cancel(struct dlm_rsb *r, struct dlm_lkb *lkb) |
@@ -2375,12 +2404,18 @@ static int do_cancel(struct dlm_rsb *r, struct dlm_lkb *lkb) | |||
2375 | error = revert_lock(r, lkb); | 2404 | error = revert_lock(r, lkb); |
2376 | if (error) { | 2405 | if (error) { |
2377 | queue_cast(r, lkb, -DLM_ECANCEL); | 2406 | queue_cast(r, lkb, -DLM_ECANCEL); |
2378 | grant_pending_locks(r); | ||
2379 | return -DLM_ECANCEL; | 2407 | return -DLM_ECANCEL; |
2380 | } | 2408 | } |
2381 | return 0; | 2409 | return 0; |
2382 | } | 2410 | } |
2383 | 2411 | ||
2412 | static void do_cancel_effects(struct dlm_rsb *r, struct dlm_lkb *lkb, | ||
2413 | int error) | ||
2414 | { | ||
2415 | if (error) | ||
2416 | grant_pending_locks(r); | ||
2417 | } | ||
2418 | |||
2384 | /* | 2419 | /* |
2385 | * Four stage 3 varieties: | 2420 | * Four stage 3 varieties: |
2386 | * _request_lock(), _convert_lock(), _unlock_lock(), _cancel_lock() | 2421 | * _request_lock(), _convert_lock(), _unlock_lock(), _cancel_lock() |
@@ -2402,11 +2437,15 @@ static int _request_lock(struct dlm_rsb *r, struct dlm_lkb *lkb) | |||
2402 | goto out; | 2437 | goto out; |
2403 | } | 2438 | } |
2404 | 2439 | ||
2405 | if (is_remote(r)) | 2440 | if (is_remote(r)) { |
2406 | /* receive_request() calls do_request() on remote node */ | 2441 | /* receive_request() calls do_request() on remote node */ |
2407 | error = send_request(r, lkb); | 2442 | error = send_request(r, lkb); |
2408 | else | 2443 | } else { |
2409 | error = do_request(r, lkb); | 2444 | error = do_request(r, lkb); |
2445 | /* for remote locks the request_reply is sent | ||
2446 | between do_request and do_request_effects */ | ||
2447 | do_request_effects(r, lkb, error); | ||
2448 | } | ||
2410 | out: | 2449 | out: |
2411 | return error; | 2450 | return error; |
2412 | } | 2451 | } |
@@ -2417,11 +2456,15 @@ static int _convert_lock(struct dlm_rsb *r, struct dlm_lkb *lkb) | |||
2417 | { | 2456 | { |
2418 | int error; | 2457 | int error; |
2419 | 2458 | ||
2420 | if (is_remote(r)) | 2459 | if (is_remote(r)) { |
2421 | /* receive_convert() calls do_convert() on remote node */ | 2460 | /* receive_convert() calls do_convert() on remote node */ |
2422 | error = send_convert(r, lkb); | 2461 | error = send_convert(r, lkb); |
2423 | else | 2462 | } else { |
2424 | error = do_convert(r, lkb); | 2463 | error = do_convert(r, lkb); |
2464 | /* for remote locks the convert_reply is sent | ||
2465 | between do_convert and do_convert_effects */ | ||
2466 | do_convert_effects(r, lkb, error); | ||
2467 | } | ||
2425 | 2468 | ||
2426 | return error; | 2469 | return error; |
2427 | } | 2470 | } |
@@ -2432,11 +2475,15 @@ static int _unlock_lock(struct dlm_rsb *r, struct dlm_lkb *lkb) | |||
2432 | { | 2475 | { |
2433 | int error; | 2476 | int error; |
2434 | 2477 | ||
2435 | if (is_remote(r)) | 2478 | if (is_remote(r)) { |
2436 | /* receive_unlock() calls do_unlock() on remote node */ | 2479 | /* receive_unlock() calls do_unlock() on remote node */ |
2437 | error = send_unlock(r, lkb); | 2480 | error = send_unlock(r, lkb); |
2438 | else | 2481 | } else { |
2439 | error = do_unlock(r, lkb); | 2482 | error = do_unlock(r, lkb); |
2483 | /* for remote locks the unlock_reply is sent | ||
2484 | between do_unlock and do_unlock_effects */ | ||
2485 | do_unlock_effects(r, lkb, error); | ||
2486 | } | ||
2440 | 2487 | ||
2441 | return error; | 2488 | return error; |
2442 | } | 2489 | } |
@@ -2447,11 +2494,15 @@ static int _cancel_lock(struct dlm_rsb *r, struct dlm_lkb *lkb) | |||
2447 | { | 2494 | { |
2448 | int error; | 2495 | int error; |
2449 | 2496 | ||
2450 | if (is_remote(r)) | 2497 | if (is_remote(r)) { |
2451 | /* receive_cancel() calls do_cancel() on remote node */ | 2498 | /* receive_cancel() calls do_cancel() on remote node */ |
2452 | error = send_cancel(r, lkb); | 2499 | error = send_cancel(r, lkb); |
2453 | else | 2500 | } else { |
2454 | error = do_cancel(r, lkb); | 2501 | error = do_cancel(r, lkb); |
2502 | /* for remote locks the cancel_reply is sent | ||
2503 | between do_cancel and do_cancel_effects */ | ||
2504 | do_cancel_effects(r, lkb, error); | ||
2505 | } | ||
2455 | 2506 | ||
2456 | return error; | 2507 | return error; |
2457 | } | 2508 | } |
@@ -3191,6 +3242,7 @@ static void receive_request(struct dlm_ls *ls, struct dlm_message *ms) | |||
3191 | attach_lkb(r, lkb); | 3242 | attach_lkb(r, lkb); |
3192 | error = do_request(r, lkb); | 3243 | error = do_request(r, lkb); |
3193 | send_request_reply(r, lkb, error); | 3244 | send_request_reply(r, lkb, error); |
3245 | do_request_effects(r, lkb, error); | ||
3194 | 3246 | ||
3195 | unlock_rsb(r); | 3247 | unlock_rsb(r); |
3196 | put_rsb(r); | 3248 | put_rsb(r); |
@@ -3226,15 +3278,19 @@ static void receive_convert(struct dlm_ls *ls, struct dlm_message *ms) | |||
3226 | goto out; | 3278 | goto out; |
3227 | 3279 | ||
3228 | receive_flags(lkb, ms); | 3280 | receive_flags(lkb, ms); |
3281 | |||
3229 | error = receive_convert_args(ls, lkb, ms); | 3282 | error = receive_convert_args(ls, lkb, ms); |
3230 | if (error) | 3283 | if (error) { |
3231 | goto out_reply; | 3284 | send_convert_reply(r, lkb, error); |
3285 | goto out; | ||
3286 | } | ||
3287 | |||
3232 | reply = !down_conversion(lkb); | 3288 | reply = !down_conversion(lkb); |
3233 | 3289 | ||
3234 | error = do_convert(r, lkb); | 3290 | error = do_convert(r, lkb); |
3235 | out_reply: | ||
3236 | if (reply) | 3291 | if (reply) |
3237 | send_convert_reply(r, lkb, error); | 3292 | send_convert_reply(r, lkb, error); |
3293 | do_convert_effects(r, lkb, error); | ||
3238 | out: | 3294 | out: |
3239 | unlock_rsb(r); | 3295 | unlock_rsb(r); |
3240 | put_rsb(r); | 3296 | put_rsb(r); |
@@ -3266,13 +3322,16 @@ static void receive_unlock(struct dlm_ls *ls, struct dlm_message *ms) | |||
3266 | goto out; | 3322 | goto out; |
3267 | 3323 | ||
3268 | receive_flags(lkb, ms); | 3324 | receive_flags(lkb, ms); |
3325 | |||
3269 | error = receive_unlock_args(ls, lkb, ms); | 3326 | error = receive_unlock_args(ls, lkb, ms); |
3270 | if (error) | 3327 | if (error) { |
3271 | goto out_reply; | 3328 | send_unlock_reply(r, lkb, error); |
3329 | goto out; | ||
3330 | } | ||
3272 | 3331 | ||
3273 | error = do_unlock(r, lkb); | 3332 | error = do_unlock(r, lkb); |
3274 | out_reply: | ||
3275 | send_unlock_reply(r, lkb, error); | 3333 | send_unlock_reply(r, lkb, error); |
3334 | do_unlock_effects(r, lkb, error); | ||
3276 | out: | 3335 | out: |
3277 | unlock_rsb(r); | 3336 | unlock_rsb(r); |
3278 | put_rsb(r); | 3337 | put_rsb(r); |
@@ -3307,6 +3366,7 @@ static void receive_cancel(struct dlm_ls *ls, struct dlm_message *ms) | |||
3307 | 3366 | ||
3308 | error = do_cancel(r, lkb); | 3367 | error = do_cancel(r, lkb); |
3309 | send_cancel_reply(r, lkb, error); | 3368 | send_cancel_reply(r, lkb, error); |
3369 | do_cancel_effects(r, lkb, error); | ||
3310 | out: | 3370 | out: |
3311 | unlock_rsb(r); | 3371 | unlock_rsb(r); |
3312 | put_rsb(r); | 3372 | put_rsb(r); |
diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c index c010ecfc0d29..f994a7dfda85 100644 --- a/fs/dlm/lockspace.c +++ b/fs/dlm/lockspace.c | |||
@@ -148,7 +148,7 @@ static void lockspace_kobj_release(struct kobject *k) | |||
148 | kfree(ls); | 148 | kfree(ls); |
149 | } | 149 | } |
150 | 150 | ||
151 | static struct sysfs_ops dlm_attr_ops = { | 151 | static const struct sysfs_ops dlm_attr_ops = { |
152 | .show = dlm_attr_show, | 152 | .show = dlm_attr_show, |
153 | .store = dlm_attr_store, | 153 | .store = dlm_attr_store, |
154 | }; | 154 | }; |
@@ -191,6 +191,18 @@ static int do_uevent(struct dlm_ls *ls, int in) | |||
191 | return error; | 191 | return error; |
192 | } | 192 | } |
193 | 193 | ||
194 | static int dlm_uevent(struct kset *kset, struct kobject *kobj, | ||
195 | struct kobj_uevent_env *env) | ||
196 | { | ||
197 | struct dlm_ls *ls = container_of(kobj, struct dlm_ls, ls_kobj); | ||
198 | |||
199 | add_uevent_var(env, "LOCKSPACE=%s", ls->ls_name); | ||
200 | return 0; | ||
201 | } | ||
202 | |||
203 | static struct kset_uevent_ops dlm_uevent_ops = { | ||
204 | .uevent = dlm_uevent, | ||
205 | }; | ||
194 | 206 | ||
195 | int __init dlm_lockspace_init(void) | 207 | int __init dlm_lockspace_init(void) |
196 | { | 208 | { |
@@ -199,7 +211,7 @@ int __init dlm_lockspace_init(void) | |||
199 | INIT_LIST_HEAD(&lslist); | 211 | INIT_LIST_HEAD(&lslist); |
200 | spin_lock_init(&lslist_lock); | 212 | spin_lock_init(&lslist_lock); |
201 | 213 | ||
202 | dlm_kset = kset_create_and_add("dlm", NULL, kernel_kobj); | 214 | dlm_kset = kset_create_and_add("dlm", &dlm_uevent_ops, kernel_kobj); |
203 | if (!dlm_kset) { | 215 | if (!dlm_kset) { |
204 | printk(KERN_WARNING "%s: can not create kset\n", __func__); | 216 | printk(KERN_WARNING "%s: can not create kset\n", __func__); |
205 | return -ENOMEM; | 217 | return -ENOMEM; |
diff --git a/fs/dlm/user.c b/fs/dlm/user.c index e73a4bb572aa..a4bfd31ac45b 100644 --- a/fs/dlm/user.c +++ b/fs/dlm/user.c | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright (C) 2006-2009 Red Hat, Inc. All rights reserved. | 2 | * Copyright (C) 2006-2010 Red Hat, Inc. All rights reserved. |
3 | * | 3 | * |
4 | * This copyrighted material is made available to anyone wishing to use, | 4 | * This copyrighted material is made available to anyone wishing to use, |
5 | * modify, copy, or redistribute it subject to the terms and conditions | 5 | * modify, copy, or redistribute it subject to the terms and conditions |
@@ -173,7 +173,7 @@ static int lkb_is_endoflife(struct dlm_lkb *lkb, int sb_status, int type) | |||
173 | /* we could possibly check if the cancel of an orphan has resulted in the lkb | 173 | /* we could possibly check if the cancel of an orphan has resulted in the lkb |
174 | being removed and then remove that lkb from the orphans list and free it */ | 174 | being removed and then remove that lkb from the orphans list and free it */ |
175 | 175 | ||
176 | void dlm_user_add_ast(struct dlm_lkb *lkb, int type, int bastmode) | 176 | void dlm_user_add_ast(struct dlm_lkb *lkb, int type, int mode) |
177 | { | 177 | { |
178 | struct dlm_ls *ls; | 178 | struct dlm_ls *ls; |
179 | struct dlm_user_args *ua; | 179 | struct dlm_user_args *ua; |
@@ -206,8 +206,10 @@ void dlm_user_add_ast(struct dlm_lkb *lkb, int type, int bastmode) | |||
206 | 206 | ||
207 | ast_type = lkb->lkb_ast_type; | 207 | ast_type = lkb->lkb_ast_type; |
208 | lkb->lkb_ast_type |= type; | 208 | lkb->lkb_ast_type |= type; |
209 | if (bastmode) | 209 | if (type == AST_BAST) |
210 | lkb->lkb_bastmode = bastmode; | 210 | lkb->lkb_bastmode = mode; |
211 | else | ||
212 | lkb->lkb_castmode = mode; | ||
211 | 213 | ||
212 | if (!ast_type) { | 214 | if (!ast_type) { |
213 | kref_get(&lkb->lkb_ref); | 215 | kref_get(&lkb->lkb_ref); |
diff --git a/fs/dlm/user.h b/fs/dlm/user.h index 1c9686492286..f196091dd7ff 100644 --- a/fs/dlm/user.h +++ b/fs/dlm/user.h | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright (C) 2006-2008 Red Hat, Inc. All rights reserved. | 2 | * Copyright (C) 2006-2010 Red Hat, Inc. All rights reserved. |
3 | * | 3 | * |
4 | * This copyrighted material is made available to anyone wishing to use, | 4 | * This copyrighted material is made available to anyone wishing to use, |
5 | * modify, copy, or redistribute it subject to the terms and conditions | 5 | * modify, copy, or redistribute it subject to the terms and conditions |
@@ -9,7 +9,7 @@ | |||
9 | #ifndef __USER_DOT_H__ | 9 | #ifndef __USER_DOT_H__ |
10 | #define __USER_DOT_H__ | 10 | #define __USER_DOT_H__ |
11 | 11 | ||
12 | void dlm_user_add_ast(struct dlm_lkb *lkb, int type, int bastmode); | 12 | void dlm_user_add_ast(struct dlm_lkb *lkb, int type, int mode); |
13 | int dlm_user_init(void); | 13 | int dlm_user_init(void); |
14 | void dlm_user_exit(void); | 14 | void dlm_user_exit(void); |
15 | int dlm_device_deregister(struct dlm_ls *ls); | 15 | int dlm_device_deregister(struct dlm_ls *ls); |
@@ -195,7 +195,7 @@ static struct page *get_arg_page(struct linux_binprm *bprm, unsigned long pos, | |||
195 | * to work from. | 195 | * to work from. |
196 | */ | 196 | */ |
197 | rlim = current->signal->rlim; | 197 | rlim = current->signal->rlim; |
198 | if (size > rlim[RLIMIT_STACK].rlim_cur / 4) { | 198 | if (size > ACCESS_ONCE(rlim[RLIMIT_STACK].rlim_cur) / 4) { |
199 | put_page(page); | 199 | put_page(page); |
200 | return NULL; | 200 | return NULL; |
201 | } | 201 | } |
@@ -246,6 +246,7 @@ static int __bprm_mm_init(struct linux_binprm *bprm) | |||
246 | vma->vm_start = vma->vm_end - PAGE_SIZE; | 246 | vma->vm_start = vma->vm_end - PAGE_SIZE; |
247 | vma->vm_flags = VM_STACK_FLAGS; | 247 | vma->vm_flags = VM_STACK_FLAGS; |
248 | vma->vm_page_prot = vm_get_page_prot(vma->vm_flags); | 248 | vma->vm_page_prot = vm_get_page_prot(vma->vm_flags); |
249 | INIT_LIST_HEAD(&vma->anon_vma_chain); | ||
249 | err = insert_vm_struct(mm, vma); | 250 | err = insert_vm_struct(mm, vma); |
250 | if (err) | 251 | if (err) |
251 | goto err; | 252 | goto err; |
@@ -516,7 +517,8 @@ static int shift_arg_pages(struct vm_area_struct *vma, unsigned long shift) | |||
516 | /* | 517 | /* |
517 | * cover the whole range: [new_start, old_end) | 518 | * cover the whole range: [new_start, old_end) |
518 | */ | 519 | */ |
519 | vma_adjust(vma, new_start, old_end, vma->vm_pgoff, NULL); | 520 | if (vma_adjust(vma, new_start, old_end, vma->vm_pgoff, NULL)) |
521 | return -ENOMEM; | ||
520 | 522 | ||
521 | /* | 523 | /* |
522 | * move the page tables downwards, on failure we rely on | 524 | * move the page tables downwards, on failure we rely on |
@@ -547,15 +549,13 @@ static int shift_arg_pages(struct vm_area_struct *vma, unsigned long shift) | |||
547 | tlb_finish_mmu(tlb, new_end, old_end); | 549 | tlb_finish_mmu(tlb, new_end, old_end); |
548 | 550 | ||
549 | /* | 551 | /* |
550 | * shrink the vma to just the new range. | 552 | * Shrink the vma to just the new range. Always succeeds. |
551 | */ | 553 | */ |
552 | vma_adjust(vma, new_start, new_end, vma->vm_pgoff, NULL); | 554 | vma_adjust(vma, new_start, new_end, vma->vm_pgoff, NULL); |
553 | 555 | ||
554 | return 0; | 556 | return 0; |
555 | } | 557 | } |
556 | 558 | ||
557 | #define EXTRA_STACK_VM_PAGES 20 /* random */ | ||
558 | |||
559 | /* | 559 | /* |
560 | * Finalizes the stack vm_area_struct. The flags and permissions are updated, | 560 | * Finalizes the stack vm_area_struct. The flags and permissions are updated, |
561 | * the stack is optionally relocated, and some extra space is added. | 561 | * the stack is optionally relocated, and some extra space is added. |
@@ -577,7 +577,7 @@ int setup_arg_pages(struct linux_binprm *bprm, | |||
577 | 577 | ||
578 | #ifdef CONFIG_STACK_GROWSUP | 578 | #ifdef CONFIG_STACK_GROWSUP |
579 | /* Limit stack size to 1GB */ | 579 | /* Limit stack size to 1GB */ |
580 | stack_base = current->signal->rlim[RLIMIT_STACK].rlim_max; | 580 | stack_base = rlimit_max(RLIMIT_STACK); |
581 | if (stack_base > (1 << 30)) | 581 | if (stack_base > (1 << 30)) |
582 | stack_base = 1 << 30; | 582 | stack_base = 1 << 30; |
583 | 583 | ||
@@ -630,7 +630,7 @@ int setup_arg_pages(struct linux_binprm *bprm, | |||
630 | goto out_unlock; | 630 | goto out_unlock; |
631 | } | 631 | } |
632 | 632 | ||
633 | stack_expand = EXTRA_STACK_VM_PAGES * PAGE_SIZE; | 633 | stack_expand = 131072UL; /* randomly 32*4k (or 2*64k) pages */ |
634 | stack_size = vma->vm_end - vma->vm_start; | 634 | stack_size = vma->vm_end - vma->vm_start; |
635 | /* | 635 | /* |
636 | * Align this down to a page boundary as expand_stack | 636 | * Align this down to a page boundary as expand_stack |
@@ -718,6 +718,7 @@ static int exec_mmap(struct mm_struct *mm) | |||
718 | /* Notify parent that we're no longer interested in the old VM */ | 718 | /* Notify parent that we're no longer interested in the old VM */ |
719 | tsk = current; | 719 | tsk = current; |
720 | old_mm = current->mm; | 720 | old_mm = current->mm; |
721 | sync_mm_rss(tsk, old_mm); | ||
721 | mm_release(tsk, old_mm); | 722 | mm_release(tsk, old_mm); |
722 | 723 | ||
723 | if (old_mm) { | 724 | if (old_mm) { |
@@ -1532,7 +1533,7 @@ static int format_corename(char *corename, long signr) | |||
1532 | /* core limit size */ | 1533 | /* core limit size */ |
1533 | case 'c': | 1534 | case 'c': |
1534 | rc = snprintf(out_ptr, out_end - out_ptr, | 1535 | rc = snprintf(out_ptr, out_end - out_ptr, |
1535 | "%lu", current->signal->rlim[RLIMIT_CORE].rlim_cur); | 1536 | "%lu", rlimit(RLIMIT_CORE)); |
1536 | if (rc > out_end - out_ptr) | 1537 | if (rc > out_end - out_ptr) |
1537 | goto out; | 1538 | goto out; |
1538 | out_ptr += rc; | 1539 | out_ptr += rc; |
@@ -1560,12 +1561,13 @@ out: | |||
1560 | return ispipe; | 1561 | return ispipe; |
1561 | } | 1562 | } |
1562 | 1563 | ||
1563 | static int zap_process(struct task_struct *start) | 1564 | static int zap_process(struct task_struct *start, int exit_code) |
1564 | { | 1565 | { |
1565 | struct task_struct *t; | 1566 | struct task_struct *t; |
1566 | int nr = 0; | 1567 | int nr = 0; |
1567 | 1568 | ||
1568 | start->signal->flags = SIGNAL_GROUP_EXIT; | 1569 | start->signal->flags = SIGNAL_GROUP_EXIT; |
1570 | start->signal->group_exit_code = exit_code; | ||
1569 | start->signal->group_stop_count = 0; | 1571 | start->signal->group_stop_count = 0; |
1570 | 1572 | ||
1571 | t = start; | 1573 | t = start; |
@@ -1590,8 +1592,7 @@ static inline int zap_threads(struct task_struct *tsk, struct mm_struct *mm, | |||
1590 | spin_lock_irq(&tsk->sighand->siglock); | 1592 | spin_lock_irq(&tsk->sighand->siglock); |
1591 | if (!signal_group_exit(tsk->signal)) { | 1593 | if (!signal_group_exit(tsk->signal)) { |
1592 | mm->core_state = core_state; | 1594 | mm->core_state = core_state; |
1593 | tsk->signal->group_exit_code = exit_code; | 1595 | nr = zap_process(tsk, exit_code); |
1594 | nr = zap_process(tsk); | ||
1595 | } | 1596 | } |
1596 | spin_unlock_irq(&tsk->sighand->siglock); | 1597 | spin_unlock_irq(&tsk->sighand->siglock); |
1597 | if (unlikely(nr < 0)) | 1598 | if (unlikely(nr < 0)) |
@@ -1640,7 +1641,7 @@ static inline int zap_threads(struct task_struct *tsk, struct mm_struct *mm, | |||
1640 | if (p->mm) { | 1641 | if (p->mm) { |
1641 | if (unlikely(p->mm == mm)) { | 1642 | if (unlikely(p->mm == mm)) { |
1642 | lock_task_sighand(p, &flags); | 1643 | lock_task_sighand(p, &flags); |
1643 | nr += zap_process(p); | 1644 | nr += zap_process(p, exit_code); |
1644 | unlock_task_sighand(p, &flags); | 1645 | unlock_task_sighand(p, &flags); |
1645 | } | 1646 | } |
1646 | break; | 1647 | break; |
@@ -1747,14 +1748,19 @@ void set_dumpable(struct mm_struct *mm, int value) | |||
1747 | } | 1748 | } |
1748 | } | 1749 | } |
1749 | 1750 | ||
1750 | int get_dumpable(struct mm_struct *mm) | 1751 | static int __get_dumpable(unsigned long mm_flags) |
1751 | { | 1752 | { |
1752 | int ret; | 1753 | int ret; |
1753 | 1754 | ||
1754 | ret = mm->flags & 0x3; | 1755 | ret = mm_flags & MMF_DUMPABLE_MASK; |
1755 | return (ret >= 2) ? 2 : ret; | 1756 | return (ret >= 2) ? 2 : ret; |
1756 | } | 1757 | } |
1757 | 1758 | ||
1759 | int get_dumpable(struct mm_struct *mm) | ||
1760 | { | ||
1761 | return __get_dumpable(mm->flags); | ||
1762 | } | ||
1763 | |||
1758 | static void wait_for_dump_helpers(struct file *file) | 1764 | static void wait_for_dump_helpers(struct file *file) |
1759 | { | 1765 | { |
1760 | struct pipe_inode_info *pipe; | 1766 | struct pipe_inode_info *pipe; |
@@ -1797,7 +1803,13 @@ void do_coredump(long signr, int exit_code, struct pt_regs *regs) | |||
1797 | struct coredump_params cprm = { | 1803 | struct coredump_params cprm = { |
1798 | .signr = signr, | 1804 | .signr = signr, |
1799 | .regs = regs, | 1805 | .regs = regs, |
1800 | .limit = current->signal->rlim[RLIMIT_CORE].rlim_cur, | 1806 | .limit = rlimit(RLIMIT_CORE), |
1807 | /* | ||
1808 | * We must use the same mm->flags while dumping core to avoid | ||
1809 | * inconsistency of bit flags, since this flag is not protected | ||
1810 | * by any locks. | ||
1811 | */ | ||
1812 | .mm_flags = mm->flags, | ||
1801 | }; | 1813 | }; |
1802 | 1814 | ||
1803 | audit_core_dumps(signr); | 1815 | audit_core_dumps(signr); |
@@ -1816,7 +1828,7 @@ void do_coredump(long signr, int exit_code, struct pt_regs *regs) | |||
1816 | /* | 1828 | /* |
1817 | * If another thread got here first, or we are not dumpable, bail out. | 1829 | * If another thread got here first, or we are not dumpable, bail out. |
1818 | */ | 1830 | */ |
1819 | if (mm->core_state || !get_dumpable(mm)) { | 1831 | if (mm->core_state || !__get_dumpable(cprm.mm_flags)) { |
1820 | up_write(&mm->mmap_sem); | 1832 | up_write(&mm->mmap_sem); |
1821 | put_cred(cred); | 1833 | put_cred(cred); |
1822 | goto fail; | 1834 | goto fail; |
@@ -1827,7 +1839,8 @@ void do_coredump(long signr, int exit_code, struct pt_regs *regs) | |||
1827 | * process nor do we know its entire history. We only know it | 1839 | * process nor do we know its entire history. We only know it |
1828 | * was tainted so we dump it as root in mode 2. | 1840 | * was tainted so we dump it as root in mode 2. |
1829 | */ | 1841 | */ |
1830 | if (get_dumpable(mm) == 2) { /* Setuid core dump mode */ | 1842 | if (__get_dumpable(cprm.mm_flags) == 2) { |
1843 | /* Setuid core dump mode */ | ||
1831 | flag = O_EXCL; /* Stop rewrite attacks */ | 1844 | flag = O_EXCL; /* Stop rewrite attacks */ |
1832 | cred->fsuid = 0; /* Dump root private */ | 1845 | cred->fsuid = 0; /* Dump root private */ |
1833 | } | 1846 | } |
@@ -1923,8 +1936,9 @@ void do_coredump(long signr, int exit_code, struct pt_regs *regs) | |||
1923 | /* | 1936 | /* |
1924 | * Dont allow local users get cute and trick others to coredump | 1937 | * Dont allow local users get cute and trick others to coredump |
1925 | * into their pre-created files: | 1938 | * into their pre-created files: |
1939 | * Note, this is not relevant for pipes | ||
1926 | */ | 1940 | */ |
1927 | if (inode->i_uid != current_fsuid()) | 1941 | if (!ispipe && (inode->i_uid != current_fsuid())) |
1928 | goto close_fail; | 1942 | goto close_fail; |
1929 | if (!cprm.file->f_op) | 1943 | if (!cprm.file->f_op) |
1930 | goto close_fail; | 1944 | goto close_fail; |
diff --git a/fs/exofs/common.h b/fs/exofs/common.h index b1b178e61718..f0d520312d8b 100644 --- a/fs/exofs/common.h +++ b/fs/exofs/common.h | |||
@@ -55,6 +55,8 @@ | |||
55 | /* exofs Application specific page/attribute */ | 55 | /* exofs Application specific page/attribute */ |
56 | # define EXOFS_APAGE_FS_DATA (OSD_APAGE_APP_DEFINED_FIRST + 3) | 56 | # define EXOFS_APAGE_FS_DATA (OSD_APAGE_APP_DEFINED_FIRST + 3) |
57 | # define EXOFS_ATTR_INODE_DATA 1 | 57 | # define EXOFS_ATTR_INODE_DATA 1 |
58 | # define EXOFS_ATTR_INODE_FILE_LAYOUT 2 | ||
59 | # define EXOFS_ATTR_INODE_DIR_LAYOUT 3 | ||
58 | 60 | ||
59 | /* | 61 | /* |
60 | * The maximum number of files we can have is limited by the size of the | 62 | * The maximum number of files we can have is limited by the size of the |
@@ -206,4 +208,41 @@ enum { | |||
206 | (((name_len) + offsetof(struct exofs_dir_entry, name) + \ | 208 | (((name_len) + offsetof(struct exofs_dir_entry, name) + \ |
207 | EXOFS_DIR_ROUND) & ~EXOFS_DIR_ROUND) | 209 | EXOFS_DIR_ROUND) & ~EXOFS_DIR_ROUND) |
208 | 210 | ||
211 | /* | ||
212 | * The on-disk (optional) layout structure. | ||
213 | * sits in an EXOFS_ATTR_INODE_FILE_LAYOUT or EXOFS_ATTR_INODE_DIR_LAYOUT | ||
214 | * attribute, attached to any inode, usually to a directory. | ||
215 | */ | ||
216 | |||
217 | enum exofs_inode_layout_gen_functions { | ||
218 | LAYOUT_MOVING_WINDOW = 0, | ||
219 | LAYOUT_IMPLICT = 1, | ||
220 | }; | ||
221 | |||
222 | struct exofs_on_disk_inode_layout { | ||
223 | __le16 gen_func; /* One of enum exofs_inode_layout_gen_functions */ | ||
224 | __le16 pad; | ||
225 | union { | ||
226 | /* gen_func == LAYOUT_MOVING_WINDOW (default) */ | ||
227 | struct exofs_layout_sliding_window { | ||
228 | __le32 num_devices; /* first n devices in global-table*/ | ||
229 | } sliding_window __packed; | ||
230 | |||
231 | /* gen_func == LAYOUT_IMPLICT */ | ||
232 | struct exofs_layout_implict_list { | ||
233 | struct exofs_dt_data_map data_map; | ||
234 | /* Variable array of size data_map.cb_num_comps. These | ||
235 | * are device indexes of the devices in the global table | ||
236 | */ | ||
237 | __le32 dev_indexes[]; | ||
238 | } implict __packed; | ||
239 | }; | ||
240 | } __packed; | ||
241 | |||
242 | static inline size_t exofs_on_disk_inode_layout_size(unsigned max_devs) | ||
243 | { | ||
244 | return sizeof(struct exofs_on_disk_inode_layout) + | ||
245 | max_devs * sizeof(__le32); | ||
246 | } | ||
247 | |||
209 | #endif /*ifndef __EXOFS_COM_H__*/ | 248 | #endif /*ifndef __EXOFS_COM_H__*/ |
diff --git a/fs/exofs/exofs.h b/fs/exofs/exofs.h index c35fd4623986..8442e353309f 100644 --- a/fs/exofs/exofs.h +++ b/fs/exofs/exofs.h | |||
@@ -55,12 +55,28 @@ | |||
55 | /* u64 has problems with printk this will cast it to unsigned long long */ | 55 | /* u64 has problems with printk this will cast it to unsigned long long */ |
56 | #define _LLU(x) (unsigned long long)(x) | 56 | #define _LLU(x) (unsigned long long)(x) |
57 | 57 | ||
58 | struct exofs_layout { | ||
59 | osd_id s_pid; /* partition ID of file system*/ | ||
60 | |||
61 | /* Our way of looking at the data_map */ | ||
62 | unsigned stripe_unit; | ||
63 | unsigned mirrors_p1; | ||
64 | |||
65 | unsigned group_width; | ||
66 | u64 group_depth; | ||
67 | unsigned group_count; | ||
68 | |||
69 | enum exofs_inode_layout_gen_functions lay_func; | ||
70 | |||
71 | unsigned s_numdevs; /* Num of devices in array */ | ||
72 | struct osd_dev *s_ods[0]; /* Variable length */ | ||
73 | }; | ||
74 | |||
58 | /* | 75 | /* |
59 | * our extension to the in-memory superblock | 76 | * our extension to the in-memory superblock |
60 | */ | 77 | */ |
61 | struct exofs_sb_info { | 78 | struct exofs_sb_info { |
62 | struct exofs_fscb s_fscb; /* Written often, pre-allocate*/ | 79 | struct exofs_fscb s_fscb; /* Written often, pre-allocate*/ |
63 | osd_id s_pid; /* partition ID of file system*/ | ||
64 | int s_timeout; /* timeout for OSD operations */ | 80 | int s_timeout; /* timeout for OSD operations */ |
65 | uint64_t s_nextid; /* highest object ID used */ | 81 | uint64_t s_nextid; /* highest object ID used */ |
66 | uint32_t s_numfiles; /* number of files on fs */ | 82 | uint32_t s_numfiles; /* number of files on fs */ |
@@ -69,22 +85,27 @@ struct exofs_sb_info { | |||
69 | atomic_t s_curr_pending; /* number of pending commands */ | 85 | atomic_t s_curr_pending; /* number of pending commands */ |
70 | uint8_t s_cred[OSD_CAP_LEN]; /* credential for the fscb */ | 86 | uint8_t s_cred[OSD_CAP_LEN]; /* credential for the fscb */ |
71 | 87 | ||
72 | struct pnfs_osd_data_map data_map; /* Default raid to use */ | 88 | struct pnfs_osd_data_map data_map; /* Default raid to use |
73 | unsigned s_numdevs; /* Num of devices in array */ | 89 | * FIXME: Needed ? |
74 | struct osd_dev *s_ods[1]; /* Variable length, minimum 1 */ | 90 | */ |
91 | /* struct exofs_layout dir_layout;*/ /* Default dir layout */ | ||
92 | struct exofs_layout layout; /* Default files layout, | ||
93 | * contains the variable osd_dev | ||
94 | * array. Keep last */ | ||
95 | struct osd_dev *_min_one_dev[1]; /* Place holder for one dev */ | ||
75 | }; | 96 | }; |
76 | 97 | ||
77 | /* | 98 | /* |
78 | * our extension to the in-memory inode | 99 | * our extension to the in-memory inode |
79 | */ | 100 | */ |
80 | struct exofs_i_info { | 101 | struct exofs_i_info { |
102 | struct inode vfs_inode; /* normal in-memory inode */ | ||
103 | wait_queue_head_t i_wq; /* wait queue for inode */ | ||
81 | unsigned long i_flags; /* various atomic flags */ | 104 | unsigned long i_flags; /* various atomic flags */ |
82 | uint32_t i_data[EXOFS_IDATA];/*short symlink names and device #s*/ | 105 | uint32_t i_data[EXOFS_IDATA];/*short symlink names and device #s*/ |
83 | uint32_t i_dir_start_lookup; /* which page to start lookup */ | 106 | uint32_t i_dir_start_lookup; /* which page to start lookup */ |
84 | wait_queue_head_t i_wq; /* wait queue for inode */ | ||
85 | uint64_t i_commit_size; /* the object's written length */ | 107 | uint64_t i_commit_size; /* the object's written length */ |
86 | uint8_t i_cred[OSD_CAP_LEN];/* all-powerful credential */ | 108 | uint8_t i_cred[OSD_CAP_LEN];/* all-powerful credential */ |
87 | struct inode vfs_inode; /* normal in-memory inode */ | ||
88 | }; | 109 | }; |
89 | 110 | ||
90 | static inline osd_id exofs_oi_objno(struct exofs_i_info *oi) | 111 | static inline osd_id exofs_oi_objno(struct exofs_i_info *oi) |
@@ -101,7 +122,7 @@ struct exofs_io_state { | |||
101 | void *private; | 122 | void *private; |
102 | exofs_io_done_fn done; | 123 | exofs_io_done_fn done; |
103 | 124 | ||
104 | struct exofs_sb_info *sbi; | 125 | struct exofs_layout *layout; |
105 | struct osd_obj_id obj; | 126 | struct osd_obj_id obj; |
106 | u8 *cred; | 127 | u8 *cred; |
107 | 128 | ||
@@ -109,7 +130,11 @@ struct exofs_io_state { | |||
109 | loff_t offset; | 130 | loff_t offset; |
110 | unsigned long length; | 131 | unsigned long length; |
111 | void *kern_buff; | 132 | void *kern_buff; |
112 | struct bio *bio; | 133 | |
134 | struct page **pages; | ||
135 | unsigned nr_pages; | ||
136 | unsigned pgbase; | ||
137 | unsigned pages_consumed; | ||
113 | 138 | ||
114 | /* Attributes */ | 139 | /* Attributes */ |
115 | unsigned in_attr_len; | 140 | unsigned in_attr_len; |
@@ -122,6 +147,9 @@ struct exofs_io_state { | |||
122 | struct exofs_per_dev_state { | 147 | struct exofs_per_dev_state { |
123 | struct osd_request *or; | 148 | struct osd_request *or; |
124 | struct bio *bio; | 149 | struct bio *bio; |
150 | loff_t offset; | ||
151 | unsigned length; | ||
152 | unsigned dev; | ||
125 | } per_dev[]; | 153 | } per_dev[]; |
126 | }; | 154 | }; |
127 | 155 | ||
@@ -175,6 +203,12 @@ static inline struct exofs_i_info *exofs_i(struct inode *inode) | |||
175 | } | 203 | } |
176 | 204 | ||
177 | /* | 205 | /* |
206 | * Given a layout, object_number and stripe_index return the associated global | ||
207 | * dev_index | ||
208 | */ | ||
209 | unsigned exofs_layout_od_id(struct exofs_layout *layout, | ||
210 | osd_id obj_no, unsigned layout_index); | ||
211 | /* | ||
178 | * Maximum count of links to a file | 212 | * Maximum count of links to a file |
179 | */ | 213 | */ |
180 | #define EXOFS_LINK_MAX 32000 | 214 | #define EXOFS_LINK_MAX 32000 |
@@ -189,7 +223,8 @@ void exofs_make_credential(u8 cred_a[OSD_CAP_LEN], | |||
189 | int exofs_read_kern(struct osd_dev *od, u8 *cred, struct osd_obj_id *obj, | 223 | int exofs_read_kern(struct osd_dev *od, u8 *cred, struct osd_obj_id *obj, |
190 | u64 offset, void *p, unsigned length); | 224 | u64 offset, void *p, unsigned length); |
191 | 225 | ||
192 | int exofs_get_io_state(struct exofs_sb_info *sbi, struct exofs_io_state** ios); | 226 | int exofs_get_io_state(struct exofs_layout *layout, |
227 | struct exofs_io_state **ios); | ||
193 | void exofs_put_io_state(struct exofs_io_state *ios); | 228 | void exofs_put_io_state(struct exofs_io_state *ios); |
194 | 229 | ||
195 | int exofs_check_io(struct exofs_io_state *ios, u64 *resid); | 230 | int exofs_check_io(struct exofs_io_state *ios, u64 *resid); |
@@ -226,7 +261,7 @@ int exofs_write_begin(struct file *file, struct address_space *mapping, | |||
226 | struct page **pagep, void **fsdata); | 261 | struct page **pagep, void **fsdata); |
227 | extern struct inode *exofs_iget(struct super_block *, unsigned long); | 262 | extern struct inode *exofs_iget(struct super_block *, unsigned long); |
228 | struct inode *exofs_new_inode(struct inode *, int); | 263 | struct inode *exofs_new_inode(struct inode *, int); |
229 | extern int exofs_write_inode(struct inode *, int); | 264 | extern int exofs_write_inode(struct inode *, struct writeback_control *wbc); |
230 | extern void exofs_delete_inode(struct inode *); | 265 | extern void exofs_delete_inode(struct inode *); |
231 | 266 | ||
232 | /* dir.c: */ | 267 | /* dir.c: */ |
diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c index 2afbcebeda71..a17e4b733e35 100644 --- a/fs/exofs/inode.c +++ b/fs/exofs/inode.c | |||
@@ -41,16 +41,18 @@ | |||
41 | 41 | ||
42 | enum { BIO_MAX_PAGES_KMALLOC = | 42 | enum { BIO_MAX_PAGES_KMALLOC = |
43 | (PAGE_SIZE - sizeof(struct bio)) / sizeof(struct bio_vec), | 43 | (PAGE_SIZE - sizeof(struct bio)) / sizeof(struct bio_vec), |
44 | MAX_PAGES_KMALLOC = | ||
45 | PAGE_SIZE / sizeof(struct page *), | ||
44 | }; | 46 | }; |
45 | 47 | ||
46 | struct page_collect { | 48 | struct page_collect { |
47 | struct exofs_sb_info *sbi; | 49 | struct exofs_sb_info *sbi; |
48 | struct request_queue *req_q; | ||
49 | struct inode *inode; | 50 | struct inode *inode; |
50 | unsigned expected_pages; | 51 | unsigned expected_pages; |
51 | struct exofs_io_state *ios; | 52 | struct exofs_io_state *ios; |
52 | 53 | ||
53 | struct bio *bio; | 54 | struct page **pages; |
55 | unsigned alloc_pages; | ||
54 | unsigned nr_pages; | 56 | unsigned nr_pages; |
55 | unsigned long length; | 57 | unsigned long length; |
56 | loff_t pg_first; /* keep 64bit also in 32-arches */ | 58 | loff_t pg_first; /* keep 64bit also in 32-arches */ |
@@ -62,15 +64,12 @@ static void _pcol_init(struct page_collect *pcol, unsigned expected_pages, | |||
62 | struct exofs_sb_info *sbi = inode->i_sb->s_fs_info; | 64 | struct exofs_sb_info *sbi = inode->i_sb->s_fs_info; |
63 | 65 | ||
64 | pcol->sbi = sbi; | 66 | pcol->sbi = sbi; |
65 | /* Create master bios on first Q, later on cloning, each clone will be | ||
66 | * allocated on it's destination Q | ||
67 | */ | ||
68 | pcol->req_q = osd_request_queue(sbi->s_ods[0]); | ||
69 | pcol->inode = inode; | 67 | pcol->inode = inode; |
70 | pcol->expected_pages = expected_pages; | 68 | pcol->expected_pages = expected_pages; |
71 | 69 | ||
72 | pcol->ios = NULL; | 70 | pcol->ios = NULL; |
73 | pcol->bio = NULL; | 71 | pcol->pages = NULL; |
72 | pcol->alloc_pages = 0; | ||
74 | pcol->nr_pages = 0; | 73 | pcol->nr_pages = 0; |
75 | pcol->length = 0; | 74 | pcol->length = 0; |
76 | pcol->pg_first = -1; | 75 | pcol->pg_first = -1; |
@@ -80,7 +79,8 @@ static void _pcol_reset(struct page_collect *pcol) | |||
80 | { | 79 | { |
81 | pcol->expected_pages -= min(pcol->nr_pages, pcol->expected_pages); | 80 | pcol->expected_pages -= min(pcol->nr_pages, pcol->expected_pages); |
82 | 81 | ||
83 | pcol->bio = NULL; | 82 | pcol->pages = NULL; |
83 | pcol->alloc_pages = 0; | ||
84 | pcol->nr_pages = 0; | 84 | pcol->nr_pages = 0; |
85 | pcol->length = 0; | 85 | pcol->length = 0; |
86 | pcol->pg_first = -1; | 86 | pcol->pg_first = -1; |
@@ -90,38 +90,43 @@ static void _pcol_reset(struct page_collect *pcol) | |||
90 | * it might not end here. don't be left with nothing | 90 | * it might not end here. don't be left with nothing |
91 | */ | 91 | */ |
92 | if (!pcol->expected_pages) | 92 | if (!pcol->expected_pages) |
93 | pcol->expected_pages = BIO_MAX_PAGES_KMALLOC; | 93 | pcol->expected_pages = MAX_PAGES_KMALLOC; |
94 | } | 94 | } |
95 | 95 | ||
96 | static int pcol_try_alloc(struct page_collect *pcol) | 96 | static int pcol_try_alloc(struct page_collect *pcol) |
97 | { | 97 | { |
98 | int pages = min_t(unsigned, pcol->expected_pages, | 98 | unsigned pages = min_t(unsigned, pcol->expected_pages, |
99 | BIO_MAX_PAGES_KMALLOC); | 99 | MAX_PAGES_KMALLOC); |
100 | 100 | ||
101 | if (!pcol->ios) { /* First time allocate io_state */ | 101 | if (!pcol->ios) { /* First time allocate io_state */ |
102 | int ret = exofs_get_io_state(pcol->sbi, &pcol->ios); | 102 | int ret = exofs_get_io_state(&pcol->sbi->layout, &pcol->ios); |
103 | 103 | ||
104 | if (ret) | 104 | if (ret) |
105 | return ret; | 105 | return ret; |
106 | } | 106 | } |
107 | 107 | ||
108 | /* TODO: easily support bio chaining */ | ||
109 | pages = min_t(unsigned, pages, | ||
110 | pcol->sbi->layout.group_width * BIO_MAX_PAGES_KMALLOC); | ||
111 | |||
108 | for (; pages; pages >>= 1) { | 112 | for (; pages; pages >>= 1) { |
109 | pcol->bio = bio_kmalloc(GFP_KERNEL, pages); | 113 | pcol->pages = kmalloc(pages * sizeof(struct page *), |
110 | if (likely(pcol->bio)) | 114 | GFP_KERNEL); |
115 | if (likely(pcol->pages)) { | ||
116 | pcol->alloc_pages = pages; | ||
111 | return 0; | 117 | return 0; |
118 | } | ||
112 | } | 119 | } |
113 | 120 | ||
114 | EXOFS_ERR("Failed to bio_kmalloc expected_pages=%u\n", | 121 | EXOFS_ERR("Failed to kmalloc expected_pages=%u\n", |
115 | pcol->expected_pages); | 122 | pcol->expected_pages); |
116 | return -ENOMEM; | 123 | return -ENOMEM; |
117 | } | 124 | } |
118 | 125 | ||
119 | static void pcol_free(struct page_collect *pcol) | 126 | static void pcol_free(struct page_collect *pcol) |
120 | { | 127 | { |
121 | if (pcol->bio) { | 128 | kfree(pcol->pages); |
122 | bio_put(pcol->bio); | 129 | pcol->pages = NULL; |
123 | pcol->bio = NULL; | ||
124 | } | ||
125 | 130 | ||
126 | if (pcol->ios) { | 131 | if (pcol->ios) { |
127 | exofs_put_io_state(pcol->ios); | 132 | exofs_put_io_state(pcol->ios); |
@@ -132,11 +137,10 @@ static void pcol_free(struct page_collect *pcol) | |||
132 | static int pcol_add_page(struct page_collect *pcol, struct page *page, | 137 | static int pcol_add_page(struct page_collect *pcol, struct page *page, |
133 | unsigned len) | 138 | unsigned len) |
134 | { | 139 | { |
135 | int added_len = bio_add_pc_page(pcol->req_q, pcol->bio, page, len, 0); | 140 | if (unlikely(pcol->nr_pages >= pcol->alloc_pages)) |
136 | if (unlikely(len != added_len)) | ||
137 | return -ENOMEM; | 141 | return -ENOMEM; |
138 | 142 | ||
139 | ++pcol->nr_pages; | 143 | pcol->pages[pcol->nr_pages++] = page; |
140 | pcol->length += len; | 144 | pcol->length += len; |
141 | return 0; | 145 | return 0; |
142 | } | 146 | } |
@@ -181,7 +185,6 @@ static void update_write_page(struct page *page, int ret) | |||
181 | */ | 185 | */ |
182 | static int __readpages_done(struct page_collect *pcol, bool do_unlock) | 186 | static int __readpages_done(struct page_collect *pcol, bool do_unlock) |
183 | { | 187 | { |
184 | struct bio_vec *bvec; | ||
185 | int i; | 188 | int i; |
186 | u64 resid; | 189 | u64 resid; |
187 | u64 good_bytes; | 190 | u64 good_bytes; |
@@ -193,13 +196,13 @@ static int __readpages_done(struct page_collect *pcol, bool do_unlock) | |||
193 | else | 196 | else |
194 | good_bytes = pcol->length - resid; | 197 | good_bytes = pcol->length - resid; |
195 | 198 | ||
196 | EXOFS_DBGMSG("readpages_done(0x%lx) good_bytes=0x%llx" | 199 | EXOFS_DBGMSG2("readpages_done(0x%lx) good_bytes=0x%llx" |
197 | " length=0x%lx nr_pages=%u\n", | 200 | " length=0x%lx nr_pages=%u\n", |
198 | pcol->inode->i_ino, _LLU(good_bytes), pcol->length, | 201 | pcol->inode->i_ino, _LLU(good_bytes), pcol->length, |
199 | pcol->nr_pages); | 202 | pcol->nr_pages); |
200 | 203 | ||
201 | __bio_for_each_segment(bvec, pcol->bio, i, 0) { | 204 | for (i = 0; i < pcol->nr_pages; i++) { |
202 | struct page *page = bvec->bv_page; | 205 | struct page *page = pcol->pages[i]; |
203 | struct inode *inode = page->mapping->host; | 206 | struct inode *inode = page->mapping->host; |
204 | int page_stat; | 207 | int page_stat; |
205 | 208 | ||
@@ -218,11 +221,11 @@ static int __readpages_done(struct page_collect *pcol, bool do_unlock) | |||
218 | ret = update_read_page(page, page_stat); | 221 | ret = update_read_page(page, page_stat); |
219 | if (do_unlock) | 222 | if (do_unlock) |
220 | unlock_page(page); | 223 | unlock_page(page); |
221 | length += bvec->bv_len; | 224 | length += PAGE_SIZE; |
222 | } | 225 | } |
223 | 226 | ||
224 | pcol_free(pcol); | 227 | pcol_free(pcol); |
225 | EXOFS_DBGMSG("readpages_done END\n"); | 228 | EXOFS_DBGMSG2("readpages_done END\n"); |
226 | return ret; | 229 | return ret; |
227 | } | 230 | } |
228 | 231 | ||
@@ -238,11 +241,10 @@ static void readpages_done(struct exofs_io_state *ios, void *p) | |||
238 | 241 | ||
239 | static void _unlock_pcol_pages(struct page_collect *pcol, int ret, int rw) | 242 | static void _unlock_pcol_pages(struct page_collect *pcol, int ret, int rw) |
240 | { | 243 | { |
241 | struct bio_vec *bvec; | ||
242 | int i; | 244 | int i; |
243 | 245 | ||
244 | __bio_for_each_segment(bvec, pcol->bio, i, 0) { | 246 | for (i = 0; i < pcol->nr_pages; i++) { |
245 | struct page *page = bvec->bv_page; | 247 | struct page *page = pcol->pages[i]; |
246 | 248 | ||
247 | if (rw == READ) | 249 | if (rw == READ) |
248 | update_read_page(page, ret); | 250 | update_read_page(page, ret); |
@@ -260,13 +262,14 @@ static int read_exec(struct page_collect *pcol, bool is_sync) | |||
260 | struct page_collect *pcol_copy = NULL; | 262 | struct page_collect *pcol_copy = NULL; |
261 | int ret; | 263 | int ret; |
262 | 264 | ||
263 | if (!pcol->bio) | 265 | if (!pcol->pages) |
264 | return 0; | 266 | return 0; |
265 | 267 | ||
266 | /* see comment in _readpage() about sync reads */ | 268 | /* see comment in _readpage() about sync reads */ |
267 | WARN_ON(is_sync && (pcol->nr_pages != 1)); | 269 | WARN_ON(is_sync && (pcol->nr_pages != 1)); |
268 | 270 | ||
269 | ios->bio = pcol->bio; | 271 | ios->pages = pcol->pages; |
272 | ios->nr_pages = pcol->nr_pages; | ||
270 | ios->length = pcol->length; | 273 | ios->length = pcol->length; |
271 | ios->offset = pcol->pg_first << PAGE_CACHE_SHIFT; | 274 | ios->offset = pcol->pg_first << PAGE_CACHE_SHIFT; |
272 | 275 | ||
@@ -290,7 +293,7 @@ static int read_exec(struct page_collect *pcol, bool is_sync) | |||
290 | 293 | ||
291 | atomic_inc(&pcol->sbi->s_curr_pending); | 294 | atomic_inc(&pcol->sbi->s_curr_pending); |
292 | 295 | ||
293 | EXOFS_DBGMSG("read_exec obj=0x%llx start=0x%llx length=0x%lx\n", | 296 | EXOFS_DBGMSG2("read_exec obj=0x%llx start=0x%llx length=0x%lx\n", |
294 | ios->obj.id, _LLU(ios->offset), pcol->length); | 297 | ios->obj.id, _LLU(ios->offset), pcol->length); |
295 | 298 | ||
296 | /* pages ownership was passed to pcol_copy */ | 299 | /* pages ownership was passed to pcol_copy */ |
@@ -366,7 +369,7 @@ try_again: | |||
366 | goto try_again; | 369 | goto try_again; |
367 | } | 370 | } |
368 | 371 | ||
369 | if (!pcol->bio) { | 372 | if (!pcol->pages) { |
370 | ret = pcol_try_alloc(pcol); | 373 | ret = pcol_try_alloc(pcol); |
371 | if (unlikely(ret)) | 374 | if (unlikely(ret)) |
372 | goto fail; | 375 | goto fail; |
@@ -448,7 +451,6 @@ static int exofs_readpage(struct file *file, struct page *page) | |||
448 | static void writepages_done(struct exofs_io_state *ios, void *p) | 451 | static void writepages_done(struct exofs_io_state *ios, void *p) |
449 | { | 452 | { |
450 | struct page_collect *pcol = p; | 453 | struct page_collect *pcol = p; |
451 | struct bio_vec *bvec; | ||
452 | int i; | 454 | int i; |
453 | u64 resid; | 455 | u64 resid; |
454 | u64 good_bytes; | 456 | u64 good_bytes; |
@@ -462,13 +464,13 @@ static void writepages_done(struct exofs_io_state *ios, void *p) | |||
462 | else | 464 | else |
463 | good_bytes = pcol->length - resid; | 465 | good_bytes = pcol->length - resid; |
464 | 466 | ||
465 | EXOFS_DBGMSG("writepages_done(0x%lx) good_bytes=0x%llx" | 467 | EXOFS_DBGMSG2("writepages_done(0x%lx) good_bytes=0x%llx" |
466 | " length=0x%lx nr_pages=%u\n", | 468 | " length=0x%lx nr_pages=%u\n", |
467 | pcol->inode->i_ino, _LLU(good_bytes), pcol->length, | 469 | pcol->inode->i_ino, _LLU(good_bytes), pcol->length, |
468 | pcol->nr_pages); | 470 | pcol->nr_pages); |
469 | 471 | ||
470 | __bio_for_each_segment(bvec, pcol->bio, i, 0) { | 472 | for (i = 0; i < pcol->nr_pages; i++) { |
471 | struct page *page = bvec->bv_page; | 473 | struct page *page = pcol->pages[i]; |
472 | struct inode *inode = page->mapping->host; | 474 | struct inode *inode = page->mapping->host; |
473 | int page_stat; | 475 | int page_stat; |
474 | 476 | ||
@@ -485,12 +487,12 @@ static void writepages_done(struct exofs_io_state *ios, void *p) | |||
485 | EXOFS_DBGMSG2(" writepages_done(0x%lx, 0x%lx) status=%d\n", | 487 | EXOFS_DBGMSG2(" writepages_done(0x%lx, 0x%lx) status=%d\n", |
486 | inode->i_ino, page->index, page_stat); | 488 | inode->i_ino, page->index, page_stat); |
487 | 489 | ||
488 | length += bvec->bv_len; | 490 | length += PAGE_SIZE; |
489 | } | 491 | } |
490 | 492 | ||
491 | pcol_free(pcol); | 493 | pcol_free(pcol); |
492 | kfree(pcol); | 494 | kfree(pcol); |
493 | EXOFS_DBGMSG("writepages_done END\n"); | 495 | EXOFS_DBGMSG2("writepages_done END\n"); |
494 | } | 496 | } |
495 | 497 | ||
496 | static int write_exec(struct page_collect *pcol) | 498 | static int write_exec(struct page_collect *pcol) |
@@ -500,7 +502,7 @@ static int write_exec(struct page_collect *pcol) | |||
500 | struct page_collect *pcol_copy = NULL; | 502 | struct page_collect *pcol_copy = NULL; |
501 | int ret; | 503 | int ret; |
502 | 504 | ||
503 | if (!pcol->bio) | 505 | if (!pcol->pages) |
504 | return 0; | 506 | return 0; |
505 | 507 | ||
506 | pcol_copy = kmalloc(sizeof(*pcol_copy), GFP_KERNEL); | 508 | pcol_copy = kmalloc(sizeof(*pcol_copy), GFP_KERNEL); |
@@ -512,9 +514,8 @@ static int write_exec(struct page_collect *pcol) | |||
512 | 514 | ||
513 | *pcol_copy = *pcol; | 515 | *pcol_copy = *pcol; |
514 | 516 | ||
515 | pcol_copy->bio->bi_rw |= (1 << BIO_RW); /* FIXME: bio_set_dir() */ | 517 | ios->pages = pcol_copy->pages; |
516 | 518 | ios->nr_pages = pcol_copy->nr_pages; | |
517 | ios->bio = pcol_copy->bio; | ||
518 | ios->offset = pcol_copy->pg_first << PAGE_CACHE_SHIFT; | 519 | ios->offset = pcol_copy->pg_first << PAGE_CACHE_SHIFT; |
519 | ios->length = pcol_copy->length; | 520 | ios->length = pcol_copy->length; |
520 | ios->done = writepages_done; | 521 | ios->done = writepages_done; |
@@ -527,7 +528,7 @@ static int write_exec(struct page_collect *pcol) | |||
527 | } | 528 | } |
528 | 529 | ||
529 | atomic_inc(&pcol->sbi->s_curr_pending); | 530 | atomic_inc(&pcol->sbi->s_curr_pending); |
530 | EXOFS_DBGMSG("write_exec(0x%lx, 0x%llx) start=0x%llx length=0x%lx\n", | 531 | EXOFS_DBGMSG2("write_exec(0x%lx, 0x%llx) start=0x%llx length=0x%lx\n", |
531 | pcol->inode->i_ino, pcol->pg_first, _LLU(ios->offset), | 532 | pcol->inode->i_ino, pcol->pg_first, _LLU(ios->offset), |
532 | pcol->length); | 533 | pcol->length); |
533 | /* pages ownership was passed to pcol_copy */ | 534 | /* pages ownership was passed to pcol_copy */ |
@@ -605,7 +606,7 @@ try_again: | |||
605 | goto try_again; | 606 | goto try_again; |
606 | } | 607 | } |
607 | 608 | ||
608 | if (!pcol->bio) { | 609 | if (!pcol->pages) { |
609 | ret = pcol_try_alloc(pcol); | 610 | ret = pcol_try_alloc(pcol); |
610 | if (unlikely(ret)) | 611 | if (unlikely(ret)) |
611 | goto fail; | 612 | goto fail; |
@@ -616,7 +617,7 @@ try_again: | |||
616 | 617 | ||
617 | ret = pcol_add_page(pcol, page, len); | 618 | ret = pcol_add_page(pcol, page, len); |
618 | if (unlikely(ret)) { | 619 | if (unlikely(ret)) { |
619 | EXOFS_DBGMSG("Failed pcol_add_page " | 620 | EXOFS_DBGMSG2("Failed pcol_add_page " |
620 | "nr_pages=%u total_length=0x%lx\n", | 621 | "nr_pages=%u total_length=0x%lx\n", |
621 | pcol->nr_pages, pcol->length); | 622 | pcol->nr_pages, pcol->length); |
622 | 623 | ||
@@ -663,7 +664,7 @@ static int exofs_writepages(struct address_space *mapping, | |||
663 | if (expected_pages < 32L) | 664 | if (expected_pages < 32L) |
664 | expected_pages = 32L; | 665 | expected_pages = 32L; |
665 | 666 | ||
666 | EXOFS_DBGMSG("inode(0x%lx) wbc->start=0x%llx wbc->end=0x%llx " | 667 | EXOFS_DBGMSG2("inode(0x%lx) wbc->start=0x%llx wbc->end=0x%llx " |
667 | "nrpages=%lu start=0x%lx end=0x%lx expected_pages=%ld\n", | 668 | "nrpages=%lu start=0x%lx end=0x%lx expected_pages=%ld\n", |
668 | mapping->host->i_ino, wbc->range_start, wbc->range_end, | 669 | mapping->host->i_ino, wbc->range_start, wbc->range_end, |
669 | mapping->nrpages, start, end, expected_pages); | 670 | mapping->nrpages, start, end, expected_pages); |
@@ -859,20 +860,33 @@ int exofs_setattr(struct dentry *dentry, struct iattr *iattr) | |||
859 | return error; | 860 | return error; |
860 | } | 861 | } |
861 | 862 | ||
863 | static const struct osd_attr g_attr_inode_file_layout = ATTR_DEF( | ||
864 | EXOFS_APAGE_FS_DATA, | ||
865 | EXOFS_ATTR_INODE_FILE_LAYOUT, | ||
866 | 0); | ||
867 | static const struct osd_attr g_attr_inode_dir_layout = ATTR_DEF( | ||
868 | EXOFS_APAGE_FS_DATA, | ||
869 | EXOFS_ATTR_INODE_DIR_LAYOUT, | ||
870 | 0); | ||
871 | |||
862 | /* | 872 | /* |
863 | * Read an inode from the OSD, and return it as is. We also return the size | 873 | * Read the Linux inode info from the OSD, and return it as is. In exofs the |
864 | * attribute in the 'obj_size' argument. | 874 | * inode info is in an application specific page/attribute of the osd-object. |
865 | */ | 875 | */ |
866 | static int exofs_get_inode(struct super_block *sb, struct exofs_i_info *oi, | 876 | static int exofs_get_inode(struct super_block *sb, struct exofs_i_info *oi, |
867 | struct exofs_fcb *inode, uint64_t *obj_size) | 877 | struct exofs_fcb *inode) |
868 | { | 878 | { |
869 | struct exofs_sb_info *sbi = sb->s_fs_info; | 879 | struct exofs_sb_info *sbi = sb->s_fs_info; |
870 | struct osd_attr attrs[2]; | 880 | struct osd_attr attrs[] = { |
881 | [0] = g_attr_inode_data, | ||
882 | [1] = g_attr_inode_file_layout, | ||
883 | [2] = g_attr_inode_dir_layout, | ||
884 | }; | ||
871 | struct exofs_io_state *ios; | 885 | struct exofs_io_state *ios; |
886 | struct exofs_on_disk_inode_layout *layout; | ||
872 | int ret; | 887 | int ret; |
873 | 888 | ||
874 | *obj_size = ~0; | 889 | ret = exofs_get_io_state(&sbi->layout, &ios); |
875 | ret = exofs_get_io_state(sbi, &ios); | ||
876 | if (unlikely(ret)) { | 890 | if (unlikely(ret)) { |
877 | EXOFS_ERR("%s: exofs_get_io_state failed.\n", __func__); | 891 | EXOFS_ERR("%s: exofs_get_io_state failed.\n", __func__); |
878 | return ret; | 892 | return ret; |
@@ -882,14 +896,25 @@ static int exofs_get_inode(struct super_block *sb, struct exofs_i_info *oi, | |||
882 | exofs_make_credential(oi->i_cred, &ios->obj); | 896 | exofs_make_credential(oi->i_cred, &ios->obj); |
883 | ios->cred = oi->i_cred; | 897 | ios->cred = oi->i_cred; |
884 | 898 | ||
885 | attrs[0] = g_attr_inode_data; | 899 | attrs[1].len = exofs_on_disk_inode_layout_size(sbi->layout.s_numdevs); |
886 | attrs[1] = g_attr_logical_length; | 900 | attrs[2].len = exofs_on_disk_inode_layout_size(sbi->layout.s_numdevs); |
901 | |||
887 | ios->in_attr = attrs; | 902 | ios->in_attr = attrs; |
888 | ios->in_attr_len = ARRAY_SIZE(attrs); | 903 | ios->in_attr_len = ARRAY_SIZE(attrs); |
889 | 904 | ||
890 | ret = exofs_sbi_read(ios); | 905 | ret = exofs_sbi_read(ios); |
891 | if (ret) | 906 | if (unlikely(ret)) { |
907 | EXOFS_ERR("object(0x%llx) corrupted, return empty file=>%d\n", | ||
908 | _LLU(ios->obj.id), ret); | ||
909 | memset(inode, 0, sizeof(*inode)); | ||
910 | inode->i_mode = 0040000 | (0777 & ~022); | ||
911 | /* If object is lost on target we might as well enable it's | ||
912 | * delete. | ||
913 | */ | ||
914 | if ((ret == -ENOENT) || (ret == -EINVAL)) | ||
915 | ret = 0; | ||
892 | goto out; | 916 | goto out; |
917 | } | ||
893 | 918 | ||
894 | ret = extract_attr_from_ios(ios, &attrs[0]); | 919 | ret = extract_attr_from_ios(ios, &attrs[0]); |
895 | if (ret) { | 920 | if (ret) { |
@@ -901,11 +926,33 @@ static int exofs_get_inode(struct super_block *sb, struct exofs_i_info *oi, | |||
901 | 926 | ||
902 | ret = extract_attr_from_ios(ios, &attrs[1]); | 927 | ret = extract_attr_from_ios(ios, &attrs[1]); |
903 | if (ret) { | 928 | if (ret) { |
904 | EXOFS_ERR("%s: extract_attr of logical_length failed\n", | 929 | EXOFS_ERR("%s: extract_attr of inode_data failed\n", __func__); |
905 | __func__); | 930 | goto out; |
931 | } | ||
932 | if (attrs[1].len) { | ||
933 | layout = attrs[1].val_ptr; | ||
934 | if (layout->gen_func != cpu_to_le16(LAYOUT_MOVING_WINDOW)) { | ||
935 | EXOFS_ERR("%s: unsupported files layout %d\n", | ||
936 | __func__, layout->gen_func); | ||
937 | ret = -ENOTSUPP; | ||
938 | goto out; | ||
939 | } | ||
940 | } | ||
941 | |||
942 | ret = extract_attr_from_ios(ios, &attrs[2]); | ||
943 | if (ret) { | ||
944 | EXOFS_ERR("%s: extract_attr of inode_data failed\n", __func__); | ||
906 | goto out; | 945 | goto out; |
907 | } | 946 | } |
908 | *obj_size = get_unaligned_be64(attrs[1].val_ptr); | 947 | if (attrs[2].len) { |
948 | layout = attrs[2].val_ptr; | ||
949 | if (layout->gen_func != cpu_to_le16(LAYOUT_MOVING_WINDOW)) { | ||
950 | EXOFS_ERR("%s: unsupported meta-data layout %d\n", | ||
951 | __func__, layout->gen_func); | ||
952 | ret = -ENOTSUPP; | ||
953 | goto out; | ||
954 | } | ||
955 | } | ||
909 | 956 | ||
910 | out: | 957 | out: |
911 | exofs_put_io_state(ios); | 958 | exofs_put_io_state(ios); |
@@ -925,7 +972,6 @@ struct inode *exofs_iget(struct super_block *sb, unsigned long ino) | |||
925 | struct exofs_i_info *oi; | 972 | struct exofs_i_info *oi; |
926 | struct exofs_fcb fcb; | 973 | struct exofs_fcb fcb; |
927 | struct inode *inode; | 974 | struct inode *inode; |
928 | uint64_t obj_size; | ||
929 | int ret; | 975 | int ret; |
930 | 976 | ||
931 | inode = iget_locked(sb, ino); | 977 | inode = iget_locked(sb, ino); |
@@ -937,7 +983,7 @@ struct inode *exofs_iget(struct super_block *sb, unsigned long ino) | |||
937 | __oi_init(oi); | 983 | __oi_init(oi); |
938 | 984 | ||
939 | /* read the inode from the osd */ | 985 | /* read the inode from the osd */ |
940 | ret = exofs_get_inode(sb, oi, &fcb, &obj_size); | 986 | ret = exofs_get_inode(sb, oi, &fcb); |
941 | if (ret) | 987 | if (ret) |
942 | goto bad_inode; | 988 | goto bad_inode; |
943 | 989 | ||
@@ -958,13 +1004,6 @@ struct inode *exofs_iget(struct super_block *sb, unsigned long ino) | |||
958 | inode->i_blkbits = EXOFS_BLKSHIFT; | 1004 | inode->i_blkbits = EXOFS_BLKSHIFT; |
959 | inode->i_generation = le32_to_cpu(fcb.i_generation); | 1005 | inode->i_generation = le32_to_cpu(fcb.i_generation); |
960 | 1006 | ||
961 | if ((inode->i_size != obj_size) && | ||
962 | (!exofs_inode_is_fast_symlink(inode))) { | ||
963 | EXOFS_ERR("WARNING: Size of inode=%llu != object=%llu\n", | ||
964 | inode->i_size, _LLU(obj_size)); | ||
965 | /* FIXME: call exofs_inode_recovery() */ | ||
966 | } | ||
967 | |||
968 | oi->i_dir_start_lookup = 0; | 1007 | oi->i_dir_start_lookup = 0; |
969 | 1008 | ||
970 | if ((inode->i_nlink == 0) && (inode->i_mode == 0)) { | 1009 | if ((inode->i_nlink == 0) && (inode->i_mode == 0)) { |
@@ -1043,7 +1082,7 @@ static void create_done(struct exofs_io_state *ios, void *p) | |||
1043 | 1082 | ||
1044 | if (unlikely(ret)) { | 1083 | if (unlikely(ret)) { |
1045 | EXOFS_ERR("object=0x%llx creation faild in pid=0x%llx", | 1084 | EXOFS_ERR("object=0x%llx creation faild in pid=0x%llx", |
1046 | _LLU(exofs_oi_objno(oi)), _LLU(sbi->s_pid)); | 1085 | _LLU(exofs_oi_objno(oi)), _LLU(sbi->layout.s_pid)); |
1047 | /*TODO: When FS is corrupted creation can fail, object already | 1086 | /*TODO: When FS is corrupted creation can fail, object already |
1048 | * exist. Get rid of this asynchronous creation, if exist | 1087 | * exist. Get rid of this asynchronous creation, if exist |
1049 | * increment the obj counter and try the next object. Until we | 1088 | * increment the obj counter and try the next object. Until we |
@@ -1104,7 +1143,7 @@ struct inode *exofs_new_inode(struct inode *dir, int mode) | |||
1104 | 1143 | ||
1105 | mark_inode_dirty(inode); | 1144 | mark_inode_dirty(inode); |
1106 | 1145 | ||
1107 | ret = exofs_get_io_state(sbi, &ios); | 1146 | ret = exofs_get_io_state(&sbi->layout, &ios); |
1108 | if (unlikely(ret)) { | 1147 | if (unlikely(ret)) { |
1109 | EXOFS_ERR("exofs_new_inode: exofs_get_io_state failed\n"); | 1148 | EXOFS_ERR("exofs_new_inode: exofs_get_io_state failed\n"); |
1110 | return ERR_PTR(ret); | 1149 | return ERR_PTR(ret); |
@@ -1170,8 +1209,10 @@ static int exofs_update_inode(struct inode *inode, int do_sync) | |||
1170 | int ret; | 1209 | int ret; |
1171 | 1210 | ||
1172 | args = kzalloc(sizeof(*args), GFP_KERNEL); | 1211 | args = kzalloc(sizeof(*args), GFP_KERNEL); |
1173 | if (!args) | 1212 | if (!args) { |
1213 | EXOFS_DBGMSG("Faild kzalloc of args\n"); | ||
1174 | return -ENOMEM; | 1214 | return -ENOMEM; |
1215 | } | ||
1175 | 1216 | ||
1176 | fcb = &args->fcb; | 1217 | fcb = &args->fcb; |
1177 | 1218 | ||
@@ -1200,7 +1241,7 @@ static int exofs_update_inode(struct inode *inode, int do_sync) | |||
1200 | } else | 1241 | } else |
1201 | memcpy(fcb->i_data, oi->i_data, sizeof(fcb->i_data)); | 1242 | memcpy(fcb->i_data, oi->i_data, sizeof(fcb->i_data)); |
1202 | 1243 | ||
1203 | ret = exofs_get_io_state(sbi, &ios); | 1244 | ret = exofs_get_io_state(&sbi->layout, &ios); |
1204 | if (unlikely(ret)) { | 1245 | if (unlikely(ret)) { |
1205 | EXOFS_ERR("%s: exofs_get_io_state failed.\n", __func__); | 1246 | EXOFS_ERR("%s: exofs_get_io_state failed.\n", __func__); |
1206 | goto free_args; | 1247 | goto free_args; |
@@ -1234,13 +1275,14 @@ static int exofs_update_inode(struct inode *inode, int do_sync) | |||
1234 | free_args: | 1275 | free_args: |
1235 | kfree(args); | 1276 | kfree(args); |
1236 | out: | 1277 | out: |
1237 | EXOFS_DBGMSG("ret=>%d\n", ret); | 1278 | EXOFS_DBGMSG("(0x%lx) do_sync=%d ret=>%d\n", |
1279 | inode->i_ino, do_sync, ret); | ||
1238 | return ret; | 1280 | return ret; |
1239 | } | 1281 | } |
1240 | 1282 | ||
1241 | int exofs_write_inode(struct inode *inode, int wait) | 1283 | int exofs_write_inode(struct inode *inode, struct writeback_control *wbc) |
1242 | { | 1284 | { |
1243 | return exofs_update_inode(inode, wait); | 1285 | return exofs_update_inode(inode, wbc->sync_mode == WB_SYNC_ALL); |
1244 | } | 1286 | } |
1245 | 1287 | ||
1246 | /* | 1288 | /* |
@@ -1283,7 +1325,7 @@ void exofs_delete_inode(struct inode *inode) | |||
1283 | 1325 | ||
1284 | clear_inode(inode); | 1326 | clear_inode(inode); |
1285 | 1327 | ||
1286 | ret = exofs_get_io_state(sbi, &ios); | 1328 | ret = exofs_get_io_state(&sbi->layout, &ios); |
1287 | if (unlikely(ret)) { | 1329 | if (unlikely(ret)) { |
1288 | EXOFS_ERR("%s: exofs_get_io_state failed\n", __func__); | 1330 | EXOFS_ERR("%s: exofs_get_io_state failed\n", __func__); |
1289 | return; | 1331 | return; |
diff --git a/fs/exofs/ios.c b/fs/exofs/ios.c index 5bad01fa1f9f..5293bc411d17 100644 --- a/fs/exofs/ios.c +++ b/fs/exofs/ios.c | |||
@@ -23,9 +23,13 @@ | |||
23 | */ | 23 | */ |
24 | 24 | ||
25 | #include <scsi/scsi_device.h> | 25 | #include <scsi/scsi_device.h> |
26 | #include <asm/div64.h> | ||
26 | 27 | ||
27 | #include "exofs.h" | 28 | #include "exofs.h" |
28 | 29 | ||
30 | #define EXOFS_DBGMSG2(M...) do {} while (0) | ||
31 | /* #define EXOFS_DBGMSG2 EXOFS_DBGMSG */ | ||
32 | |||
29 | void exofs_make_credential(u8 cred_a[OSD_CAP_LEN], const struct osd_obj_id *obj) | 33 | void exofs_make_credential(u8 cred_a[OSD_CAP_LEN], const struct osd_obj_id *obj) |
30 | { | 34 | { |
31 | osd_sec_init_nosec_doall_caps(cred_a, obj, false, true); | 35 | osd_sec_init_nosec_doall_caps(cred_a, obj, false, true); |
@@ -64,21 +68,24 @@ out: | |||
64 | return ret; | 68 | return ret; |
65 | } | 69 | } |
66 | 70 | ||
67 | int exofs_get_io_state(struct exofs_sb_info *sbi, struct exofs_io_state** pios) | 71 | int exofs_get_io_state(struct exofs_layout *layout, |
72 | struct exofs_io_state **pios) | ||
68 | { | 73 | { |
69 | struct exofs_io_state *ios; | 74 | struct exofs_io_state *ios; |
70 | 75 | ||
71 | /*TODO: Maybe use kmem_cach per sbi of size | 76 | /*TODO: Maybe use kmem_cach per sbi of size |
72 | * exofs_io_state_size(sbi->s_numdevs) | 77 | * exofs_io_state_size(layout->s_numdevs) |
73 | */ | 78 | */ |
74 | ios = kzalloc(exofs_io_state_size(sbi->s_numdevs), GFP_KERNEL); | 79 | ios = kzalloc(exofs_io_state_size(layout->s_numdevs), GFP_KERNEL); |
75 | if (unlikely(!ios)) { | 80 | if (unlikely(!ios)) { |
81 | EXOFS_DBGMSG("Faild kzalloc bytes=%d\n", | ||
82 | exofs_io_state_size(layout->s_numdevs)); | ||
76 | *pios = NULL; | 83 | *pios = NULL; |
77 | return -ENOMEM; | 84 | return -ENOMEM; |
78 | } | 85 | } |
79 | 86 | ||
80 | ios->sbi = sbi; | 87 | ios->layout = layout; |
81 | ios->obj.partition = sbi->s_pid; | 88 | ios->obj.partition = layout->s_pid; |
82 | *pios = ios; | 89 | *pios = ios; |
83 | return 0; | 90 | return 0; |
84 | } | 91 | } |
@@ -101,6 +108,29 @@ void exofs_put_io_state(struct exofs_io_state *ios) | |||
101 | } | 108 | } |
102 | } | 109 | } |
103 | 110 | ||
111 | unsigned exofs_layout_od_id(struct exofs_layout *layout, | ||
112 | osd_id obj_no, unsigned layout_index) | ||
113 | { | ||
114 | /* switch (layout->lay_func) { | ||
115 | case LAYOUT_MOVING_WINDOW: | ||
116 | {*/ | ||
117 | unsigned dev_mod = obj_no; | ||
118 | |||
119 | return (layout_index + dev_mod * layout->mirrors_p1) % | ||
120 | layout->s_numdevs; | ||
121 | /* } | ||
122 | case LAYOUT_FUNC_IMPLICT: | ||
123 | return layout->devs[layout_index]; | ||
124 | }*/ | ||
125 | } | ||
126 | |||
127 | static inline struct osd_dev *exofs_ios_od(struct exofs_io_state *ios, | ||
128 | unsigned layout_index) | ||
129 | { | ||
130 | return ios->layout->s_ods[ | ||
131 | exofs_layout_od_id(ios->layout, ios->obj.id, layout_index)]; | ||
132 | } | ||
133 | |||
104 | static void _sync_done(struct exofs_io_state *ios, void *p) | 134 | static void _sync_done(struct exofs_io_state *ios, void *p) |
105 | { | 135 | { |
106 | struct completion *waiting = p; | 136 | struct completion *waiting = p; |
@@ -168,6 +198,21 @@ static int exofs_io_execute(struct exofs_io_state *ios) | |||
168 | return ret; | 198 | return ret; |
169 | } | 199 | } |
170 | 200 | ||
201 | static void _clear_bio(struct bio *bio) | ||
202 | { | ||
203 | struct bio_vec *bv; | ||
204 | unsigned i; | ||
205 | |||
206 | __bio_for_each_segment(bv, bio, i, 0) { | ||
207 | unsigned this_count = bv->bv_len; | ||
208 | |||
209 | if (likely(PAGE_SIZE == this_count)) | ||
210 | clear_highpage(bv->bv_page); | ||
211 | else | ||
212 | zero_user(bv->bv_page, bv->bv_offset, this_count); | ||
213 | } | ||
214 | } | ||
215 | |||
171 | int exofs_check_io(struct exofs_io_state *ios, u64 *resid) | 216 | int exofs_check_io(struct exofs_io_state *ios, u64 *resid) |
172 | { | 217 | { |
173 | enum osd_err_priority acumulated_osd_err = 0; | 218 | enum osd_err_priority acumulated_osd_err = 0; |
@@ -176,16 +221,25 @@ int exofs_check_io(struct exofs_io_state *ios, u64 *resid) | |||
176 | 221 | ||
177 | for (i = 0; i < ios->numdevs; i++) { | 222 | for (i = 0; i < ios->numdevs; i++) { |
178 | struct osd_sense_info osi; | 223 | struct osd_sense_info osi; |
179 | int ret = osd_req_decode_sense(ios->per_dev[i].or, &osi); | 224 | struct osd_request *or = ios->per_dev[i].or; |
225 | int ret; | ||
226 | |||
227 | if (unlikely(!or)) | ||
228 | continue; | ||
180 | 229 | ||
230 | ret = osd_req_decode_sense(or, &osi); | ||
181 | if (likely(!ret)) | 231 | if (likely(!ret)) |
182 | continue; | 232 | continue; |
183 | 233 | ||
184 | if (unlikely(ret == -EFAULT)) { | 234 | if (OSD_ERR_PRI_CLEAR_PAGES == osi.osd_err_pri) { |
185 | EXOFS_DBGMSG("%s: EFAULT Need page clear\n", __func__); | 235 | /* start read offset passed endof file */ |
186 | /*FIXME: All the pages in this device range should: | 236 | _clear_bio(ios->per_dev[i].bio); |
187 | * clear_highpage(page); | 237 | EXOFS_DBGMSG("start read offset passed end of file " |
188 | */ | 238 | "offset=0x%llx, length=0x%llx\n", |
239 | _LLU(ios->per_dev[i].offset), | ||
240 | _LLU(ios->per_dev[i].length)); | ||
241 | |||
242 | continue; /* we recovered */ | ||
189 | } | 243 | } |
190 | 244 | ||
191 | if (osi.osd_err_pri >= acumulated_osd_err) { | 245 | if (osi.osd_err_pri >= acumulated_osd_err) { |
@@ -205,14 +259,259 @@ int exofs_check_io(struct exofs_io_state *ios, u64 *resid) | |||
205 | return acumulated_lin_err; | 259 | return acumulated_lin_err; |
206 | } | 260 | } |
207 | 261 | ||
262 | /* | ||
263 | * L - logical offset into the file | ||
264 | * | ||
265 | * U - The number of bytes in a stripe within a group | ||
266 | * | ||
267 | * U = stripe_unit * group_width | ||
268 | * | ||
269 | * T - The number of bytes striped within a group of component objects | ||
270 | * (before advancing to the next group) | ||
271 | * | ||
272 | * T = stripe_unit * group_width * group_depth | ||
273 | * | ||
274 | * S - The number of bytes striped across all component objects | ||
275 | * before the pattern repeats | ||
276 | * | ||
277 | * S = stripe_unit * group_width * group_depth * group_count | ||
278 | * | ||
279 | * M - The "major" (i.e., across all components) stripe number | ||
280 | * | ||
281 | * M = L / S | ||
282 | * | ||
283 | * G - Counts the groups from the beginning of the major stripe | ||
284 | * | ||
285 | * G = (L - (M * S)) / T [or (L % S) / T] | ||
286 | * | ||
287 | * H - The byte offset within the group | ||
288 | * | ||
289 | * H = (L - (M * S)) % T [or (L % S) % T] | ||
290 | * | ||
291 | * N - The "minor" (i.e., across the group) stripe number | ||
292 | * | ||
293 | * N = H / U | ||
294 | * | ||
295 | * C - The component index coresponding to L | ||
296 | * | ||
297 | * C = (H - (N * U)) / stripe_unit + G * group_width | ||
298 | * [or (L % U) / stripe_unit + G * group_width] | ||
299 | * | ||
300 | * O - The component offset coresponding to L | ||
301 | * | ||
302 | * O = L % stripe_unit + N * stripe_unit + M * group_depth * stripe_unit | ||
303 | */ | ||
304 | struct _striping_info { | ||
305 | u64 obj_offset; | ||
306 | u64 group_length; | ||
307 | u64 total_group_length; | ||
308 | u64 Major; | ||
309 | unsigned dev; | ||
310 | unsigned unit_off; | ||
311 | }; | ||
312 | |||
313 | static void _calc_stripe_info(struct exofs_io_state *ios, u64 file_offset, | ||
314 | struct _striping_info *si) | ||
315 | { | ||
316 | u32 stripe_unit = ios->layout->stripe_unit; | ||
317 | u32 group_width = ios->layout->group_width; | ||
318 | u64 group_depth = ios->layout->group_depth; | ||
319 | |||
320 | u32 U = stripe_unit * group_width; | ||
321 | u64 T = U * group_depth; | ||
322 | u64 S = T * ios->layout->group_count; | ||
323 | u64 M = div64_u64(file_offset, S); | ||
324 | |||
325 | /* | ||
326 | G = (L - (M * S)) / T | ||
327 | H = (L - (M * S)) % T | ||
328 | */ | ||
329 | u64 LmodS = file_offset - M * S; | ||
330 | u32 G = div64_u64(LmodS, T); | ||
331 | u64 H = LmodS - G * T; | ||
332 | |||
333 | u32 N = div_u64(H, U); | ||
334 | |||
335 | /* "H - (N * U)" is just "H % U" so it's bound to u32 */ | ||
336 | si->dev = (u32)(H - (N * U)) / stripe_unit + G * group_width; | ||
337 | si->dev *= ios->layout->mirrors_p1; | ||
338 | |||
339 | div_u64_rem(file_offset, stripe_unit, &si->unit_off); | ||
340 | |||
341 | si->obj_offset = si->unit_off + (N * stripe_unit) + | ||
342 | (M * group_depth * stripe_unit); | ||
343 | |||
344 | si->group_length = T - H; | ||
345 | si->total_group_length = T; | ||
346 | si->Major = M; | ||
347 | } | ||
348 | |||
349 | static int _add_stripe_unit(struct exofs_io_state *ios, unsigned *cur_pg, | ||
350 | unsigned pgbase, struct exofs_per_dev_state *per_dev, | ||
351 | int cur_len) | ||
352 | { | ||
353 | unsigned pg = *cur_pg; | ||
354 | struct request_queue *q = | ||
355 | osd_request_queue(exofs_ios_od(ios, per_dev->dev)); | ||
356 | |||
357 | per_dev->length += cur_len; | ||
358 | |||
359 | if (per_dev->bio == NULL) { | ||
360 | unsigned pages_in_stripe = ios->layout->group_width * | ||
361 | (ios->layout->stripe_unit / PAGE_SIZE); | ||
362 | unsigned bio_size = (ios->nr_pages + pages_in_stripe) / | ||
363 | ios->layout->group_width; | ||
364 | |||
365 | per_dev->bio = bio_kmalloc(GFP_KERNEL, bio_size); | ||
366 | if (unlikely(!per_dev->bio)) { | ||
367 | EXOFS_DBGMSG("Faild to allocate BIO size=%u\n", | ||
368 | bio_size); | ||
369 | return -ENOMEM; | ||
370 | } | ||
371 | } | ||
372 | |||
373 | while (cur_len > 0) { | ||
374 | unsigned pglen = min_t(unsigned, PAGE_SIZE - pgbase, cur_len); | ||
375 | unsigned added_len; | ||
376 | |||
377 | BUG_ON(ios->nr_pages <= pg); | ||
378 | cur_len -= pglen; | ||
379 | |||
380 | added_len = bio_add_pc_page(q, per_dev->bio, ios->pages[pg], | ||
381 | pglen, pgbase); | ||
382 | if (unlikely(pglen != added_len)) | ||
383 | return -ENOMEM; | ||
384 | pgbase = 0; | ||
385 | ++pg; | ||
386 | } | ||
387 | BUG_ON(cur_len); | ||
388 | |||
389 | *cur_pg = pg; | ||
390 | return 0; | ||
391 | } | ||
392 | |||
393 | static int _prepare_one_group(struct exofs_io_state *ios, u64 length, | ||
394 | struct _striping_info *si, unsigned first_comp) | ||
395 | { | ||
396 | unsigned stripe_unit = ios->layout->stripe_unit; | ||
397 | unsigned mirrors_p1 = ios->layout->mirrors_p1; | ||
398 | unsigned devs_in_group = ios->layout->group_width * mirrors_p1; | ||
399 | unsigned dev = si->dev; | ||
400 | unsigned first_dev = dev - (dev % devs_in_group); | ||
401 | unsigned comp = first_comp + (dev - first_dev); | ||
402 | unsigned max_comp = ios->numdevs ? ios->numdevs - mirrors_p1 : 0; | ||
403 | unsigned cur_pg = ios->pages_consumed; | ||
404 | int ret = 0; | ||
405 | |||
406 | while (length) { | ||
407 | struct exofs_per_dev_state *per_dev = &ios->per_dev[comp]; | ||
408 | unsigned cur_len, page_off = 0; | ||
409 | |||
410 | if (!per_dev->length) { | ||
411 | per_dev->dev = dev; | ||
412 | if (dev < si->dev) { | ||
413 | per_dev->offset = si->obj_offset + stripe_unit - | ||
414 | si->unit_off; | ||
415 | cur_len = stripe_unit; | ||
416 | } else if (dev == si->dev) { | ||
417 | per_dev->offset = si->obj_offset; | ||
418 | cur_len = stripe_unit - si->unit_off; | ||
419 | page_off = si->unit_off & ~PAGE_MASK; | ||
420 | BUG_ON(page_off && (page_off != ios->pgbase)); | ||
421 | } else { /* dev > si->dev */ | ||
422 | per_dev->offset = si->obj_offset - si->unit_off; | ||
423 | cur_len = stripe_unit; | ||
424 | } | ||
425 | |||
426 | if (max_comp < comp) | ||
427 | max_comp = comp; | ||
428 | |||
429 | dev += mirrors_p1; | ||
430 | dev = (dev % devs_in_group) + first_dev; | ||
431 | } else { | ||
432 | cur_len = stripe_unit; | ||
433 | } | ||
434 | if (cur_len >= length) | ||
435 | cur_len = length; | ||
436 | |||
437 | ret = _add_stripe_unit(ios, &cur_pg, page_off , per_dev, | ||
438 | cur_len); | ||
439 | if (unlikely(ret)) | ||
440 | goto out; | ||
441 | |||
442 | comp += mirrors_p1; | ||
443 | comp = (comp % devs_in_group) + first_comp; | ||
444 | |||
445 | length -= cur_len; | ||
446 | } | ||
447 | out: | ||
448 | ios->numdevs = max_comp + mirrors_p1; | ||
449 | ios->pages_consumed = cur_pg; | ||
450 | return ret; | ||
451 | } | ||
452 | |||
453 | static int _prepare_for_striping(struct exofs_io_state *ios) | ||
454 | { | ||
455 | u64 length = ios->length; | ||
456 | struct _striping_info si; | ||
457 | unsigned devs_in_group = ios->layout->group_width * | ||
458 | ios->layout->mirrors_p1; | ||
459 | unsigned first_comp = 0; | ||
460 | int ret = 0; | ||
461 | |||
462 | _calc_stripe_info(ios, ios->offset, &si); | ||
463 | |||
464 | if (!ios->pages) { | ||
465 | if (ios->kern_buff) { | ||
466 | struct exofs_per_dev_state *per_dev = &ios->per_dev[0]; | ||
467 | |||
468 | per_dev->offset = si.obj_offset; | ||
469 | per_dev->dev = si.dev; | ||
470 | |||
471 | /* no cross device without page array */ | ||
472 | BUG_ON((ios->layout->group_width > 1) && | ||
473 | (si.unit_off + ios->length > | ||
474 | ios->layout->stripe_unit)); | ||
475 | } | ||
476 | ios->numdevs = ios->layout->mirrors_p1; | ||
477 | return 0; | ||
478 | } | ||
479 | |||
480 | while (length) { | ||
481 | if (length < si.group_length) | ||
482 | si.group_length = length; | ||
483 | |||
484 | ret = _prepare_one_group(ios, si.group_length, &si, first_comp); | ||
485 | if (unlikely(ret)) | ||
486 | goto out; | ||
487 | |||
488 | length -= si.group_length; | ||
489 | |||
490 | si.group_length = si.total_group_length; | ||
491 | si.unit_off = 0; | ||
492 | ++si.Major; | ||
493 | si.obj_offset = si.Major * ios->layout->stripe_unit * | ||
494 | ios->layout->group_depth; | ||
495 | |||
496 | si.dev = (si.dev - (si.dev % devs_in_group)) + devs_in_group; | ||
497 | si.dev %= ios->layout->s_numdevs; | ||
498 | |||
499 | first_comp += devs_in_group; | ||
500 | first_comp %= ios->layout->s_numdevs; | ||
501 | } | ||
502 | |||
503 | out: | ||
504 | return ret; | ||
505 | } | ||
506 | |||
208 | int exofs_sbi_create(struct exofs_io_state *ios) | 507 | int exofs_sbi_create(struct exofs_io_state *ios) |
209 | { | 508 | { |
210 | int i, ret; | 509 | int i, ret; |
211 | 510 | ||
212 | for (i = 0; i < ios->sbi->s_numdevs; i++) { | 511 | for (i = 0; i < ios->layout->s_numdevs; i++) { |
213 | struct osd_request *or; | 512 | struct osd_request *or; |
214 | 513 | ||
215 | or = osd_start_request(ios->sbi->s_ods[i], GFP_KERNEL); | 514 | or = osd_start_request(exofs_ios_od(ios, i), GFP_KERNEL); |
216 | if (unlikely(!or)) { | 515 | if (unlikely(!or)) { |
217 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | 516 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); |
218 | ret = -ENOMEM; | 517 | ret = -ENOMEM; |
@@ -233,10 +532,10 @@ int exofs_sbi_remove(struct exofs_io_state *ios) | |||
233 | { | 532 | { |
234 | int i, ret; | 533 | int i, ret; |
235 | 534 | ||
236 | for (i = 0; i < ios->sbi->s_numdevs; i++) { | 535 | for (i = 0; i < ios->layout->s_numdevs; i++) { |
237 | struct osd_request *or; | 536 | struct osd_request *or; |
238 | 537 | ||
239 | or = osd_start_request(ios->sbi->s_ods[i], GFP_KERNEL); | 538 | or = osd_start_request(exofs_ios_od(ios, i), GFP_KERNEL); |
240 | if (unlikely(!or)) { | 539 | if (unlikely(!or)) { |
241 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | 540 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); |
242 | ret = -ENOMEM; | 541 | ret = -ENOMEM; |
@@ -253,51 +552,74 @@ out: | |||
253 | return ret; | 552 | return ret; |
254 | } | 553 | } |
255 | 554 | ||
256 | int exofs_sbi_write(struct exofs_io_state *ios) | 555 | static int _sbi_write_mirror(struct exofs_io_state *ios, int cur_comp) |
257 | { | 556 | { |
258 | int i, ret; | 557 | struct exofs_per_dev_state *master_dev = &ios->per_dev[cur_comp]; |
558 | unsigned dev = ios->per_dev[cur_comp].dev; | ||
559 | unsigned last_comp = cur_comp + ios->layout->mirrors_p1; | ||
560 | int ret = 0; | ||
259 | 561 | ||
260 | for (i = 0; i < ios->sbi->s_numdevs; i++) { | 562 | if (ios->pages && !master_dev->length) |
563 | return 0; /* Just an empty slot */ | ||
564 | |||
565 | for (; cur_comp < last_comp; ++cur_comp, ++dev) { | ||
566 | struct exofs_per_dev_state *per_dev = &ios->per_dev[cur_comp]; | ||
261 | struct osd_request *or; | 567 | struct osd_request *or; |
262 | 568 | ||
263 | or = osd_start_request(ios->sbi->s_ods[i], GFP_KERNEL); | 569 | or = osd_start_request(exofs_ios_od(ios, dev), GFP_KERNEL); |
264 | if (unlikely(!or)) { | 570 | if (unlikely(!or)) { |
265 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | 571 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); |
266 | ret = -ENOMEM; | 572 | ret = -ENOMEM; |
267 | goto out; | 573 | goto out; |
268 | } | 574 | } |
269 | ios->per_dev[i].or = or; | 575 | per_dev->or = or; |
270 | ios->numdevs++; | 576 | per_dev->offset = master_dev->offset; |
271 | 577 | ||
272 | if (ios->bio) { | 578 | if (ios->pages) { |
273 | struct bio *bio; | 579 | struct bio *bio; |
274 | 580 | ||
275 | if (i != 0) { | 581 | if (per_dev != master_dev) { |
276 | bio = bio_kmalloc(GFP_KERNEL, | 582 | bio = bio_kmalloc(GFP_KERNEL, |
277 | ios->bio->bi_max_vecs); | 583 | master_dev->bio->bi_max_vecs); |
278 | if (unlikely(!bio)) { | 584 | if (unlikely(!bio)) { |
585 | EXOFS_DBGMSG( | ||
586 | "Faild to allocate BIO size=%u\n", | ||
587 | master_dev->bio->bi_max_vecs); | ||
279 | ret = -ENOMEM; | 588 | ret = -ENOMEM; |
280 | goto out; | 589 | goto out; |
281 | } | 590 | } |
282 | 591 | ||
283 | __bio_clone(bio, ios->bio); | 592 | __bio_clone(bio, master_dev->bio); |
284 | bio->bi_bdev = NULL; | 593 | bio->bi_bdev = NULL; |
285 | bio->bi_next = NULL; | 594 | bio->bi_next = NULL; |
286 | ios->per_dev[i].bio = bio; | 595 | per_dev->length = master_dev->length; |
596 | per_dev->bio = bio; | ||
597 | per_dev->dev = dev; | ||
287 | } else { | 598 | } else { |
288 | bio = ios->bio; | 599 | bio = master_dev->bio; |
600 | /* FIXME: bio_set_dir() */ | ||
601 | bio->bi_rw |= (1 << BIO_RW); | ||
289 | } | 602 | } |
290 | 603 | ||
291 | osd_req_write(or, &ios->obj, ios->offset, bio, | 604 | osd_req_write(or, &ios->obj, per_dev->offset, bio, |
292 | ios->length); | 605 | per_dev->length); |
293 | /* EXOFS_DBGMSG("write sync=%d\n", sync);*/ | 606 | EXOFS_DBGMSG("write(0x%llx) offset=0x%llx " |
607 | "length=0x%llx dev=%d\n", | ||
608 | _LLU(ios->obj.id), _LLU(per_dev->offset), | ||
609 | _LLU(per_dev->length), dev); | ||
294 | } else if (ios->kern_buff) { | 610 | } else if (ios->kern_buff) { |
295 | osd_req_write_kern(or, &ios->obj, ios->offset, | 611 | ret = osd_req_write_kern(or, &ios->obj, per_dev->offset, |
296 | ios->kern_buff, ios->length); | 612 | ios->kern_buff, ios->length); |
297 | /* EXOFS_DBGMSG("write_kern sync=%d\n", sync);*/ | 613 | if (unlikely(ret)) |
614 | goto out; | ||
615 | EXOFS_DBGMSG2("write_kern(0x%llx) offset=0x%llx " | ||
616 | "length=0x%llx dev=%d\n", | ||
617 | _LLU(ios->obj.id), _LLU(per_dev->offset), | ||
618 | _LLU(ios->length), dev); | ||
298 | } else { | 619 | } else { |
299 | osd_req_set_attributes(or, &ios->obj); | 620 | osd_req_set_attributes(or, &ios->obj); |
300 | /* EXOFS_DBGMSG("set_attributes sync=%d\n", sync);*/ | 621 | EXOFS_DBGMSG2("obj(0x%llx) set_attributes=%d dev=%d\n", |
622 | _LLU(ios->obj.id), ios->out_attr_len, dev); | ||
301 | } | 623 | } |
302 | 624 | ||
303 | if (ios->out_attr) | 625 | if (ios->out_attr) |
@@ -308,54 +630,93 @@ int exofs_sbi_write(struct exofs_io_state *ios) | |||
308 | osd_req_add_get_attr_list(or, ios->in_attr, | 630 | osd_req_add_get_attr_list(or, ios->in_attr, |
309 | ios->in_attr_len); | 631 | ios->in_attr_len); |
310 | } | 632 | } |
311 | ret = exofs_io_execute(ios); | ||
312 | 633 | ||
313 | out: | 634 | out: |
314 | return ret; | 635 | return ret; |
315 | } | 636 | } |
316 | 637 | ||
317 | int exofs_sbi_read(struct exofs_io_state *ios) | 638 | int exofs_sbi_write(struct exofs_io_state *ios) |
318 | { | 639 | { |
319 | int i, ret; | 640 | int i; |
641 | int ret; | ||
320 | 642 | ||
321 | for (i = 0; i < 1; i++) { | 643 | ret = _prepare_for_striping(ios); |
322 | struct osd_request *or; | 644 | if (unlikely(ret)) |
323 | unsigned first_dev = (unsigned)ios->obj.id; | 645 | return ret; |
324 | 646 | ||
325 | first_dev %= ios->sbi->s_numdevs; | 647 | for (i = 0; i < ios->numdevs; i += ios->layout->mirrors_p1) { |
326 | or = osd_start_request(ios->sbi->s_ods[first_dev], GFP_KERNEL); | 648 | ret = _sbi_write_mirror(ios, i); |
327 | if (unlikely(!or)) { | 649 | if (unlikely(ret)) |
328 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | 650 | return ret; |
329 | ret = -ENOMEM; | 651 | } |
330 | goto out; | ||
331 | } | ||
332 | ios->per_dev[i].or = or; | ||
333 | ios->numdevs++; | ||
334 | 652 | ||
335 | if (ios->bio) { | 653 | ret = exofs_io_execute(ios); |
336 | osd_req_read(or, &ios->obj, ios->offset, ios->bio, | 654 | return ret; |
337 | ios->length); | 655 | } |
338 | /* EXOFS_DBGMSG("read sync=%d\n", sync);*/ | ||
339 | } else if (ios->kern_buff) { | ||
340 | osd_req_read_kern(or, &ios->obj, ios->offset, | ||
341 | ios->kern_buff, ios->length); | ||
342 | /* EXOFS_DBGMSG("read_kern sync=%d\n", sync);*/ | ||
343 | } else { | ||
344 | osd_req_get_attributes(or, &ios->obj); | ||
345 | /* EXOFS_DBGMSG("get_attributes sync=%d\n", sync);*/ | ||
346 | } | ||
347 | 656 | ||
348 | if (ios->out_attr) | 657 | static int _sbi_read_mirror(struct exofs_io_state *ios, unsigned cur_comp) |
349 | osd_req_add_set_attr_list(or, ios->out_attr, | 658 | { |
350 | ios->out_attr_len); | 659 | struct osd_request *or; |
660 | struct exofs_per_dev_state *per_dev = &ios->per_dev[cur_comp]; | ||
661 | unsigned first_dev = (unsigned)ios->obj.id; | ||
351 | 662 | ||
352 | if (ios->in_attr) | 663 | if (ios->pages && !per_dev->length) |
353 | osd_req_add_get_attr_list(or, ios->in_attr, | 664 | return 0; /* Just an empty slot */ |
354 | ios->in_attr_len); | 665 | |
666 | first_dev = per_dev->dev + first_dev % ios->layout->mirrors_p1; | ||
667 | or = osd_start_request(exofs_ios_od(ios, first_dev), GFP_KERNEL); | ||
668 | if (unlikely(!or)) { | ||
669 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | ||
670 | return -ENOMEM; | ||
355 | } | 671 | } |
356 | ret = exofs_io_execute(ios); | 672 | per_dev->or = or; |
673 | |||
674 | if (ios->pages) { | ||
675 | osd_req_read(or, &ios->obj, per_dev->offset, | ||
676 | per_dev->bio, per_dev->length); | ||
677 | EXOFS_DBGMSG("read(0x%llx) offset=0x%llx length=0x%llx" | ||
678 | " dev=%d\n", _LLU(ios->obj.id), | ||
679 | _LLU(per_dev->offset), _LLU(per_dev->length), | ||
680 | first_dev); | ||
681 | } else if (ios->kern_buff) { | ||
682 | int ret = osd_req_read_kern(or, &ios->obj, per_dev->offset, | ||
683 | ios->kern_buff, ios->length); | ||
684 | EXOFS_DBGMSG2("read_kern(0x%llx) offset=0x%llx " | ||
685 | "length=0x%llx dev=%d ret=>%d\n", | ||
686 | _LLU(ios->obj.id), _LLU(per_dev->offset), | ||
687 | _LLU(ios->length), first_dev, ret); | ||
688 | if (unlikely(ret)) | ||
689 | return ret; | ||
690 | } else { | ||
691 | osd_req_get_attributes(or, &ios->obj); | ||
692 | EXOFS_DBGMSG2("obj(0x%llx) get_attributes=%d dev=%d\n", | ||
693 | _LLU(ios->obj.id), ios->in_attr_len, first_dev); | ||
694 | } | ||
695 | if (ios->out_attr) | ||
696 | osd_req_add_set_attr_list(or, ios->out_attr, ios->out_attr_len); | ||
357 | 697 | ||
358 | out: | 698 | if (ios->in_attr) |
699 | osd_req_add_get_attr_list(or, ios->in_attr, ios->in_attr_len); | ||
700 | |||
701 | return 0; | ||
702 | } | ||
703 | |||
704 | int exofs_sbi_read(struct exofs_io_state *ios) | ||
705 | { | ||
706 | int i; | ||
707 | int ret; | ||
708 | |||
709 | ret = _prepare_for_striping(ios); | ||
710 | if (unlikely(ret)) | ||
711 | return ret; | ||
712 | |||
713 | for (i = 0; i < ios->numdevs; i += ios->layout->mirrors_p1) { | ||
714 | ret = _sbi_read_mirror(ios, i); | ||
715 | if (unlikely(ret)) | ||
716 | return ret; | ||
717 | } | ||
718 | |||
719 | ret = exofs_io_execute(ios); | ||
359 | return ret; | 720 | return ret; |
360 | } | 721 | } |
361 | 722 | ||
@@ -380,42 +741,82 @@ int extract_attr_from_ios(struct exofs_io_state *ios, struct osd_attr *attr) | |||
380 | return -EIO; | 741 | return -EIO; |
381 | } | 742 | } |
382 | 743 | ||
744 | static int _truncate_mirrors(struct exofs_io_state *ios, unsigned cur_comp, | ||
745 | struct osd_attr *attr) | ||
746 | { | ||
747 | int last_comp = cur_comp + ios->layout->mirrors_p1; | ||
748 | |||
749 | for (; cur_comp < last_comp; ++cur_comp) { | ||
750 | struct exofs_per_dev_state *per_dev = &ios->per_dev[cur_comp]; | ||
751 | struct osd_request *or; | ||
752 | |||
753 | or = osd_start_request(exofs_ios_od(ios, cur_comp), GFP_KERNEL); | ||
754 | if (unlikely(!or)) { | ||
755 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | ||
756 | return -ENOMEM; | ||
757 | } | ||
758 | per_dev->or = or; | ||
759 | |||
760 | osd_req_set_attributes(or, &ios->obj); | ||
761 | osd_req_add_set_attr_list(or, attr, 1); | ||
762 | } | ||
763 | |||
764 | return 0; | ||
765 | } | ||
766 | |||
383 | int exofs_oi_truncate(struct exofs_i_info *oi, u64 size) | 767 | int exofs_oi_truncate(struct exofs_i_info *oi, u64 size) |
384 | { | 768 | { |
385 | struct exofs_sb_info *sbi = oi->vfs_inode.i_sb->s_fs_info; | 769 | struct exofs_sb_info *sbi = oi->vfs_inode.i_sb->s_fs_info; |
386 | struct exofs_io_state *ios; | 770 | struct exofs_io_state *ios; |
387 | struct osd_attr attr; | 771 | struct exofs_trunc_attr { |
388 | __be64 newsize; | 772 | struct osd_attr attr; |
773 | __be64 newsize; | ||
774 | } *size_attrs; | ||
775 | struct _striping_info si; | ||
389 | int i, ret; | 776 | int i, ret; |
390 | 777 | ||
391 | if (exofs_get_io_state(sbi, &ios)) | 778 | ret = exofs_get_io_state(&sbi->layout, &ios); |
392 | return -ENOMEM; | 779 | if (unlikely(ret)) |
780 | return ret; | ||
781 | |||
782 | size_attrs = kcalloc(ios->layout->group_width, sizeof(*size_attrs), | ||
783 | GFP_KERNEL); | ||
784 | if (unlikely(!size_attrs)) { | ||
785 | ret = -ENOMEM; | ||
786 | goto out; | ||
787 | } | ||
393 | 788 | ||
394 | ios->obj.id = exofs_oi_objno(oi); | 789 | ios->obj.id = exofs_oi_objno(oi); |
395 | ios->cred = oi->i_cred; | 790 | ios->cred = oi->i_cred; |
396 | 791 | ||
397 | newsize = cpu_to_be64(size); | 792 | ios->numdevs = ios->layout->s_numdevs; |
398 | attr = g_attr_logical_length; | 793 | _calc_stripe_info(ios, size, &si); |
399 | attr.val_ptr = &newsize; | ||
400 | 794 | ||
401 | for (i = 0; i < sbi->s_numdevs; i++) { | 795 | for (i = 0; i < ios->layout->group_width; ++i) { |
402 | struct osd_request *or; | 796 | struct exofs_trunc_attr *size_attr = &size_attrs[i]; |
797 | u64 obj_size; | ||
403 | 798 | ||
404 | or = osd_start_request(sbi->s_ods[i], GFP_KERNEL); | 799 | if (i < si.dev) |
405 | if (unlikely(!or)) { | 800 | obj_size = si.obj_offset + |
406 | EXOFS_ERR("%s: osd_start_request failed\n", __func__); | 801 | ios->layout->stripe_unit - si.unit_off; |
407 | ret = -ENOMEM; | 802 | else if (i == si.dev) |
408 | goto out; | 803 | obj_size = si.obj_offset; |
409 | } | 804 | else /* i > si.dev */ |
410 | ios->per_dev[i].or = or; | 805 | obj_size = si.obj_offset - si.unit_off; |
411 | ios->numdevs++; | ||
412 | 806 | ||
413 | osd_req_set_attributes(or, &ios->obj); | 807 | size_attr->newsize = cpu_to_be64(obj_size); |
414 | osd_req_add_set_attr_list(or, &attr, 1); | 808 | size_attr->attr = g_attr_logical_length; |
809 | size_attr->attr.val_ptr = &size_attr->newsize; | ||
810 | |||
811 | ret = _truncate_mirrors(ios, i * ios->layout->mirrors_p1, | ||
812 | &size_attr->attr); | ||
813 | if (unlikely(ret)) | ||
814 | goto out; | ||
415 | } | 815 | } |
416 | ret = exofs_io_execute(ios); | 816 | ret = exofs_io_execute(ios); |
417 | 817 | ||
418 | out: | 818 | out: |
819 | kfree(size_attrs); | ||
419 | exofs_put_io_state(ios); | 820 | exofs_put_io_state(ios); |
420 | return ret; | 821 | return ret; |
421 | } | 822 | } |
diff --git a/fs/exofs/super.c b/fs/exofs/super.c index a1d1e77b12eb..6cf5e4e84d61 100644 --- a/fs/exofs/super.c +++ b/fs/exofs/super.c | |||
@@ -210,7 +210,7 @@ int exofs_sync_fs(struct super_block *sb, int wait) | |||
210 | sbi = sb->s_fs_info; | 210 | sbi = sb->s_fs_info; |
211 | fscb = &sbi->s_fscb; | 211 | fscb = &sbi->s_fscb; |
212 | 212 | ||
213 | ret = exofs_get_io_state(sbi, &ios); | 213 | ret = exofs_get_io_state(&sbi->layout, &ios); |
214 | if (ret) | 214 | if (ret) |
215 | goto out; | 215 | goto out; |
216 | 216 | ||
@@ -264,12 +264,12 @@ static void _exofs_print_device(const char *msg, const char *dev_path, | |||
264 | 264 | ||
265 | void exofs_free_sbi(struct exofs_sb_info *sbi) | 265 | void exofs_free_sbi(struct exofs_sb_info *sbi) |
266 | { | 266 | { |
267 | while (sbi->s_numdevs) { | 267 | while (sbi->layout.s_numdevs) { |
268 | int i = --sbi->s_numdevs; | 268 | int i = --sbi->layout.s_numdevs; |
269 | struct osd_dev *od = sbi->s_ods[i]; | 269 | struct osd_dev *od = sbi->layout.s_ods[i]; |
270 | 270 | ||
271 | if (od) { | 271 | if (od) { |
272 | sbi->s_ods[i] = NULL; | 272 | sbi->layout.s_ods[i] = NULL; |
273 | osduld_put_device(od); | 273 | osduld_put_device(od); |
274 | } | 274 | } |
275 | } | 275 | } |
@@ -298,7 +298,8 @@ static void exofs_put_super(struct super_block *sb) | |||
298 | msecs_to_jiffies(100)); | 298 | msecs_to_jiffies(100)); |
299 | } | 299 | } |
300 | 300 | ||
301 | _exofs_print_device("Unmounting", NULL, sbi->s_ods[0], sbi->s_pid); | 301 | _exofs_print_device("Unmounting", NULL, sbi->layout.s_ods[0], |
302 | sbi->layout.s_pid); | ||
302 | 303 | ||
303 | exofs_free_sbi(sbi); | 304 | exofs_free_sbi(sbi); |
304 | sb->s_fs_info = NULL; | 305 | sb->s_fs_info = NULL; |
@@ -307,6 +308,8 @@ static void exofs_put_super(struct super_block *sb) | |||
307 | static int _read_and_match_data_map(struct exofs_sb_info *sbi, unsigned numdevs, | 308 | static int _read_and_match_data_map(struct exofs_sb_info *sbi, unsigned numdevs, |
308 | struct exofs_device_table *dt) | 309 | struct exofs_device_table *dt) |
309 | { | 310 | { |
311 | u64 stripe_length; | ||
312 | |||
310 | sbi->data_map.odm_num_comps = | 313 | sbi->data_map.odm_num_comps = |
311 | le32_to_cpu(dt->dt_data_map.cb_num_comps); | 314 | le32_to_cpu(dt->dt_data_map.cb_num_comps); |
312 | sbi->data_map.odm_stripe_unit = | 315 | sbi->data_map.odm_stripe_unit = |
@@ -320,14 +323,63 @@ static int _read_and_match_data_map(struct exofs_sb_info *sbi, unsigned numdevs, | |||
320 | sbi->data_map.odm_raid_algorithm = | 323 | sbi->data_map.odm_raid_algorithm = |
321 | le32_to_cpu(dt->dt_data_map.cb_raid_algorithm); | 324 | le32_to_cpu(dt->dt_data_map.cb_raid_algorithm); |
322 | 325 | ||
323 | /* FIXME: Hard coded mirror only for now. if not so do not mount */ | 326 | /* FIXME: Only raid0 for now. if not so, do not mount */ |
324 | if ((sbi->data_map.odm_num_comps != numdevs) || | 327 | if (sbi->data_map.odm_num_comps != numdevs) { |
325 | (sbi->data_map.odm_stripe_unit != EXOFS_BLKSIZE) || | 328 | EXOFS_ERR("odm_num_comps(%u) != numdevs(%u)\n", |
326 | (sbi->data_map.odm_raid_algorithm != PNFS_OSD_RAID_0) || | 329 | sbi->data_map.odm_num_comps, numdevs); |
327 | (sbi->data_map.odm_mirror_cnt != (numdevs - 1))) | ||
328 | return -EINVAL; | 330 | return -EINVAL; |
329 | else | 331 | } |
330 | return 0; | 332 | if (sbi->data_map.odm_raid_algorithm != PNFS_OSD_RAID_0) { |
333 | EXOFS_ERR("Only RAID_0 for now\n"); | ||
334 | return -EINVAL; | ||
335 | } | ||
336 | if (0 != (numdevs % (sbi->data_map.odm_mirror_cnt + 1))) { | ||
337 | EXOFS_ERR("Data Map wrong, numdevs=%d mirrors=%d\n", | ||
338 | numdevs, sbi->data_map.odm_mirror_cnt); | ||
339 | return -EINVAL; | ||
340 | } | ||
341 | |||
342 | if (0 != (sbi->data_map.odm_stripe_unit & ~PAGE_MASK)) { | ||
343 | EXOFS_ERR("Stripe Unit(0x%llx)" | ||
344 | " must be Multples of PAGE_SIZE(0x%lx)\n", | ||
345 | _LLU(sbi->data_map.odm_stripe_unit), PAGE_SIZE); | ||
346 | return -EINVAL; | ||
347 | } | ||
348 | |||
349 | sbi->layout.stripe_unit = sbi->data_map.odm_stripe_unit; | ||
350 | sbi->layout.mirrors_p1 = sbi->data_map.odm_mirror_cnt + 1; | ||
351 | |||
352 | if (sbi->data_map.odm_group_width) { | ||
353 | sbi->layout.group_width = sbi->data_map.odm_group_width; | ||
354 | sbi->layout.group_depth = sbi->data_map.odm_group_depth; | ||
355 | if (!sbi->layout.group_depth) { | ||
356 | EXOFS_ERR("group_depth == 0 && group_width != 0\n"); | ||
357 | return -EINVAL; | ||
358 | } | ||
359 | sbi->layout.group_count = sbi->data_map.odm_num_comps / | ||
360 | sbi->layout.mirrors_p1 / | ||
361 | sbi->data_map.odm_group_width; | ||
362 | } else { | ||
363 | if (sbi->data_map.odm_group_depth) { | ||
364 | printk(KERN_NOTICE "Warning: group_depth ignored " | ||
365 | "group_width == 0 && group_depth == %d\n", | ||
366 | sbi->data_map.odm_group_depth); | ||
367 | sbi->data_map.odm_group_depth = 0; | ||
368 | } | ||
369 | sbi->layout.group_width = sbi->data_map.odm_num_comps / | ||
370 | sbi->layout.mirrors_p1; | ||
371 | sbi->layout.group_depth = -1; | ||
372 | sbi->layout.group_count = 1; | ||
373 | } | ||
374 | |||
375 | stripe_length = (u64)sbi->layout.group_width * sbi->layout.stripe_unit; | ||
376 | if (stripe_length >= (1ULL << 32)) { | ||
377 | EXOFS_ERR("Total Stripe length(0x%llx)" | ||
378 | " >= 32bit is not supported\n", _LLU(stripe_length)); | ||
379 | return -EINVAL; | ||
380 | } | ||
381 | |||
382 | return 0; | ||
331 | } | 383 | } |
332 | 384 | ||
333 | /* @odi is valid only as long as @fscb_dev is valid */ | 385 | /* @odi is valid only as long as @fscb_dev is valid */ |
@@ -361,7 +413,7 @@ static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi, | |||
361 | { | 413 | { |
362 | struct exofs_sb_info *sbi = *psbi; | 414 | struct exofs_sb_info *sbi = *psbi; |
363 | struct osd_dev *fscb_od; | 415 | struct osd_dev *fscb_od; |
364 | struct osd_obj_id obj = {.partition = sbi->s_pid, | 416 | struct osd_obj_id obj = {.partition = sbi->layout.s_pid, |
365 | .id = EXOFS_DEVTABLE_ID}; | 417 | .id = EXOFS_DEVTABLE_ID}; |
366 | struct exofs_device_table *dt; | 418 | struct exofs_device_table *dt; |
367 | unsigned table_bytes = table_count * sizeof(dt->dt_dev_table[0]) + | 419 | unsigned table_bytes = table_count * sizeof(dt->dt_dev_table[0]) + |
@@ -376,9 +428,9 @@ static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi, | |||
376 | return -ENOMEM; | 428 | return -ENOMEM; |
377 | } | 429 | } |
378 | 430 | ||
379 | fscb_od = sbi->s_ods[0]; | 431 | fscb_od = sbi->layout.s_ods[0]; |
380 | sbi->s_ods[0] = NULL; | 432 | sbi->layout.s_ods[0] = NULL; |
381 | sbi->s_numdevs = 0; | 433 | sbi->layout.s_numdevs = 0; |
382 | ret = exofs_read_kern(fscb_od, sbi->s_cred, &obj, 0, dt, table_bytes); | 434 | ret = exofs_read_kern(fscb_od, sbi->s_cred, &obj, 0, dt, table_bytes); |
383 | if (unlikely(ret)) { | 435 | if (unlikely(ret)) { |
384 | EXOFS_ERR("ERROR: reading device table\n"); | 436 | EXOFS_ERR("ERROR: reading device table\n"); |
@@ -397,14 +449,15 @@ static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi, | |||
397 | goto out; | 449 | goto out; |
398 | 450 | ||
399 | if (likely(numdevs > 1)) { | 451 | if (likely(numdevs > 1)) { |
400 | unsigned size = numdevs * sizeof(sbi->s_ods[0]); | 452 | unsigned size = numdevs * sizeof(sbi->layout.s_ods[0]); |
401 | 453 | ||
402 | sbi = krealloc(sbi, sizeof(*sbi) + size, GFP_KERNEL); | 454 | sbi = krealloc(sbi, sizeof(*sbi) + size, GFP_KERNEL); |
403 | if (unlikely(!sbi)) { | 455 | if (unlikely(!sbi)) { |
404 | ret = -ENOMEM; | 456 | ret = -ENOMEM; |
405 | goto out; | 457 | goto out; |
406 | } | 458 | } |
407 | memset(&sbi->s_ods[1], 0, size - sizeof(sbi->s_ods[0])); | 459 | memset(&sbi->layout.s_ods[1], 0, |
460 | size - sizeof(sbi->layout.s_ods[0])); | ||
408 | *psbi = sbi; | 461 | *psbi = sbi; |
409 | } | 462 | } |
410 | 463 | ||
@@ -427,8 +480,8 @@ static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi, | |||
427 | * line. We always keep them in device-table order. | 480 | * line. We always keep them in device-table order. |
428 | */ | 481 | */ |
429 | if (fscb_od && osduld_device_same(fscb_od, &odi)) { | 482 | if (fscb_od && osduld_device_same(fscb_od, &odi)) { |
430 | sbi->s_ods[i] = fscb_od; | 483 | sbi->layout.s_ods[i] = fscb_od; |
431 | ++sbi->s_numdevs; | 484 | ++sbi->layout.s_numdevs; |
432 | fscb_od = NULL; | 485 | fscb_od = NULL; |
433 | continue; | 486 | continue; |
434 | } | 487 | } |
@@ -441,8 +494,8 @@ static int exofs_read_lookup_dev_table(struct exofs_sb_info **psbi, | |||
441 | goto out; | 494 | goto out; |
442 | } | 495 | } |
443 | 496 | ||
444 | sbi->s_ods[i] = od; | 497 | sbi->layout.s_ods[i] = od; |
445 | ++sbi->s_numdevs; | 498 | ++sbi->layout.s_numdevs; |
446 | 499 | ||
447 | /* Read the fscb of the other devices to make sure the FS | 500 | /* Read the fscb of the other devices to make sure the FS |
448 | * partition is there. | 501 | * partition is there. |
@@ -499,9 +552,15 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) | |||
499 | goto free_sbi; | 552 | goto free_sbi; |
500 | } | 553 | } |
501 | 554 | ||
502 | sbi->s_ods[0] = od; | 555 | /* Default layout in case we do not have a device-table */ |
503 | sbi->s_numdevs = 1; | 556 | sbi->layout.stripe_unit = PAGE_SIZE; |
504 | sbi->s_pid = opts->pid; | 557 | sbi->layout.mirrors_p1 = 1; |
558 | sbi->layout.group_width = 1; | ||
559 | sbi->layout.group_depth = -1; | ||
560 | sbi->layout.group_count = 1; | ||
561 | sbi->layout.s_ods[0] = od; | ||
562 | sbi->layout.s_numdevs = 1; | ||
563 | sbi->layout.s_pid = opts->pid; | ||
505 | sbi->s_timeout = opts->timeout; | 564 | sbi->s_timeout = opts->timeout; |
506 | 565 | ||
507 | /* fill in some other data by hand */ | 566 | /* fill in some other data by hand */ |
@@ -514,7 +573,7 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) | |||
514 | sb->s_bdev = NULL; | 573 | sb->s_bdev = NULL; |
515 | sb->s_dev = 0; | 574 | sb->s_dev = 0; |
516 | 575 | ||
517 | obj.partition = sbi->s_pid; | 576 | obj.partition = sbi->layout.s_pid; |
518 | obj.id = EXOFS_SUPER_ID; | 577 | obj.id = EXOFS_SUPER_ID; |
519 | exofs_make_credential(sbi->s_cred, &obj); | 578 | exofs_make_credential(sbi->s_cred, &obj); |
520 | 579 | ||
@@ -578,13 +637,13 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) | |||
578 | goto free_sbi; | 637 | goto free_sbi; |
579 | } | 638 | } |
580 | 639 | ||
581 | _exofs_print_device("Mounting", opts->dev_name, sbi->s_ods[0], | 640 | _exofs_print_device("Mounting", opts->dev_name, sbi->layout.s_ods[0], |
582 | sbi->s_pid); | 641 | sbi->layout.s_pid); |
583 | return 0; | 642 | return 0; |
584 | 643 | ||
585 | free_sbi: | 644 | free_sbi: |
586 | EXOFS_ERR("Unable to mount exofs on %s pid=0x%llx err=%d\n", | 645 | EXOFS_ERR("Unable to mount exofs on %s pid=0x%llx err=%d\n", |
587 | opts->dev_name, sbi->s_pid, ret); | 646 | opts->dev_name, sbi->layout.s_pid, ret); |
588 | exofs_free_sbi(sbi); | 647 | exofs_free_sbi(sbi); |
589 | return ret; | 648 | return ret; |
590 | } | 649 | } |
@@ -627,7 +686,7 @@ static int exofs_statfs(struct dentry *dentry, struct kstatfs *buf) | |||
627 | uint8_t cred_a[OSD_CAP_LEN]; | 686 | uint8_t cred_a[OSD_CAP_LEN]; |
628 | int ret; | 687 | int ret; |
629 | 688 | ||
630 | ret = exofs_get_io_state(sbi, &ios); | 689 | ret = exofs_get_io_state(&sbi->layout, &ios); |
631 | if (ret) { | 690 | if (ret) { |
632 | EXOFS_DBGMSG("exofs_get_io_state failed.\n"); | 691 | EXOFS_DBGMSG("exofs_get_io_state failed.\n"); |
633 | return ret; | 692 | return ret; |
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c index 7f8d2e5a7ea6..1d081f0cfec2 100644 --- a/fs/ext2/balloc.c +++ b/fs/ext2/balloc.c | |||
@@ -570,7 +570,7 @@ do_more: | |||
570 | error_return: | 570 | error_return: |
571 | brelse(bitmap_bh); | 571 | brelse(bitmap_bh); |
572 | release_blocks(sb, freed); | 572 | release_blocks(sb, freed); |
573 | vfs_dq_free_block(inode, freed); | 573 | dquot_free_block(inode, freed); |
574 | } | 574 | } |
575 | 575 | ||
576 | /** | 576 | /** |
@@ -1236,6 +1236,7 @@ ext2_fsblk_t ext2_new_blocks(struct inode *inode, ext2_fsblk_t goal, | |||
1236 | unsigned short windowsz = 0; | 1236 | unsigned short windowsz = 0; |
1237 | unsigned long ngroups; | 1237 | unsigned long ngroups; |
1238 | unsigned long num = *count; | 1238 | unsigned long num = *count; |
1239 | int ret; | ||
1239 | 1240 | ||
1240 | *errp = -ENOSPC; | 1241 | *errp = -ENOSPC; |
1241 | sb = inode->i_sb; | 1242 | sb = inode->i_sb; |
@@ -1247,8 +1248,9 @@ ext2_fsblk_t ext2_new_blocks(struct inode *inode, ext2_fsblk_t goal, | |||
1247 | /* | 1248 | /* |
1248 | * Check quota for allocation of this block. | 1249 | * Check quota for allocation of this block. |
1249 | */ | 1250 | */ |
1250 | if (vfs_dq_alloc_block(inode, num)) { | 1251 | ret = dquot_alloc_block(inode, num); |
1251 | *errp = -EDQUOT; | 1252 | if (ret) { |
1253 | *errp = ret; | ||
1252 | return 0; | 1254 | return 0; |
1253 | } | 1255 | } |
1254 | 1256 | ||
@@ -1409,7 +1411,7 @@ allocated: | |||
1409 | 1411 | ||
1410 | *errp = 0; | 1412 | *errp = 0; |
1411 | brelse(bitmap_bh); | 1413 | brelse(bitmap_bh); |
1412 | vfs_dq_free_block(inode, *count-num); | 1414 | dquot_free_block(inode, *count-num); |
1413 | *count = num; | 1415 | *count = num; |
1414 | return ret_block; | 1416 | return ret_block; |
1415 | 1417 | ||
@@ -1420,7 +1422,7 @@ out: | |||
1420 | * Undo the block allocation | 1422 | * Undo the block allocation |
1421 | */ | 1423 | */ |
1422 | if (!performed_allocation) | 1424 | if (!performed_allocation) |
1423 | vfs_dq_free_block(inode, *count); | 1425 | dquot_free_block(inode, *count); |
1424 | brelse(bitmap_bh); | 1426 | brelse(bitmap_bh); |
1425 | return 0; | 1427 | return 0; |
1426 | } | 1428 | } |
diff --git a/fs/ext2/ext2.h b/fs/ext2/ext2.h index 061914add3cf..0b038e47ad2f 100644 --- a/fs/ext2/ext2.h +++ b/fs/ext2/ext2.h | |||
@@ -118,7 +118,7 @@ extern unsigned long ext2_count_free (struct buffer_head *, unsigned); | |||
118 | 118 | ||
119 | /* inode.c */ | 119 | /* inode.c */ |
120 | extern struct inode *ext2_iget (struct super_block *, unsigned long); | 120 | extern struct inode *ext2_iget (struct super_block *, unsigned long); |
121 | extern int ext2_write_inode (struct inode *, int); | 121 | extern int ext2_write_inode (struct inode *, struct writeback_control *); |
122 | extern void ext2_delete_inode (struct inode *); | 122 | extern void ext2_delete_inode (struct inode *); |
123 | extern int ext2_sync_inode (struct inode *); | 123 | extern int ext2_sync_inode (struct inode *); |
124 | extern int ext2_get_block(struct inode *, sector_t, struct buffer_head *, int); | 124 | extern int ext2_get_block(struct inode *, sector_t, struct buffer_head *, int); |
diff --git a/fs/ext2/file.c b/fs/ext2/file.c index 586e3589d4c2..5d198d0697fb 100644 --- a/fs/ext2/file.c +++ b/fs/ext2/file.c | |||
@@ -20,6 +20,7 @@ | |||
20 | 20 | ||
21 | #include <linux/time.h> | 21 | #include <linux/time.h> |
22 | #include <linux/pagemap.h> | 22 | #include <linux/pagemap.h> |
23 | #include <linux/quotaops.h> | ||
23 | #include "ext2.h" | 24 | #include "ext2.h" |
24 | #include "xattr.h" | 25 | #include "xattr.h" |
25 | #include "acl.h" | 26 | #include "acl.h" |
@@ -70,7 +71,7 @@ const struct file_operations ext2_file_operations = { | |||
70 | .compat_ioctl = ext2_compat_ioctl, | 71 | .compat_ioctl = ext2_compat_ioctl, |
71 | #endif | 72 | #endif |
72 | .mmap = generic_file_mmap, | 73 | .mmap = generic_file_mmap, |
73 | .open = generic_file_open, | 74 | .open = dquot_file_open, |
74 | .release = ext2_release_file, | 75 | .release = ext2_release_file, |
75 | .fsync = ext2_fsync, | 76 | .fsync = ext2_fsync, |
76 | .splice_read = generic_file_splice_read, | 77 | .splice_read = generic_file_splice_read, |
@@ -87,7 +88,7 @@ const struct file_operations ext2_xip_file_operations = { | |||
87 | .compat_ioctl = ext2_compat_ioctl, | 88 | .compat_ioctl = ext2_compat_ioctl, |
88 | #endif | 89 | #endif |
89 | .mmap = xip_file_mmap, | 90 | .mmap = xip_file_mmap, |
90 | .open = generic_file_open, | 91 | .open = dquot_file_open, |
91 | .release = ext2_release_file, | 92 | .release = ext2_release_file, |
92 | .fsync = ext2_fsync, | 93 | .fsync = ext2_fsync, |
93 | }; | 94 | }; |
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c index 15387c9c17d8..ad7d572ee8dc 100644 --- a/fs/ext2/ialloc.c +++ b/fs/ext2/ialloc.c | |||
@@ -121,8 +121,8 @@ void ext2_free_inode (struct inode * inode) | |||
121 | if (!is_bad_inode(inode)) { | 121 | if (!is_bad_inode(inode)) { |
122 | /* Quota is already initialized in iput() */ | 122 | /* Quota is already initialized in iput() */ |
123 | ext2_xattr_delete_inode(inode); | 123 | ext2_xattr_delete_inode(inode); |
124 | vfs_dq_free_inode(inode); | 124 | dquot_free_inode(inode); |
125 | vfs_dq_drop(inode); | 125 | dquot_drop(inode); |
126 | } | 126 | } |
127 | 127 | ||
128 | es = EXT2_SB(sb)->s_es; | 128 | es = EXT2_SB(sb)->s_es; |
@@ -586,10 +586,10 @@ got: | |||
586 | goto fail_drop; | 586 | goto fail_drop; |
587 | } | 587 | } |
588 | 588 | ||
589 | if (vfs_dq_alloc_inode(inode)) { | 589 | dquot_initialize(inode); |
590 | err = -EDQUOT; | 590 | err = dquot_alloc_inode(inode); |
591 | if (err) | ||
591 | goto fail_drop; | 592 | goto fail_drop; |
592 | } | ||
593 | 593 | ||
594 | err = ext2_init_acl(inode, dir); | 594 | err = ext2_init_acl(inode, dir); |
595 | if (err) | 595 | if (err) |
@@ -605,10 +605,10 @@ got: | |||
605 | return inode; | 605 | return inode; |
606 | 606 | ||
607 | fail_free_drop: | 607 | fail_free_drop: |
608 | vfs_dq_free_inode(inode); | 608 | dquot_free_inode(inode); |
609 | 609 | ||
610 | fail_drop: | 610 | fail_drop: |
611 | vfs_dq_drop(inode); | 611 | dquot_drop(inode); |
612 | inode->i_flags |= S_NOQUOTA; | 612 | inode->i_flags |= S_NOQUOTA; |
613 | inode->i_nlink = 0; | 613 | inode->i_nlink = 0; |
614 | unlock_new_inode(inode); | 614 | unlock_new_inode(inode); |
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 71b032c65a02..fc13cc119aad 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c | |||
@@ -41,6 +41,8 @@ MODULE_AUTHOR("Remy Card and others"); | |||
41 | MODULE_DESCRIPTION("Second Extended Filesystem"); | 41 | MODULE_DESCRIPTION("Second Extended Filesystem"); |
42 | MODULE_LICENSE("GPL"); | 42 | MODULE_LICENSE("GPL"); |
43 | 43 | ||
44 | static int __ext2_write_inode(struct inode *inode, int do_sync); | ||
45 | |||
44 | /* | 46 | /* |
45 | * Test whether an inode is a fast symlink. | 47 | * Test whether an inode is a fast symlink. |
46 | */ | 48 | */ |
@@ -58,13 +60,15 @@ static inline int ext2_inode_is_fast_symlink(struct inode *inode) | |||
58 | */ | 60 | */ |
59 | void ext2_delete_inode (struct inode * inode) | 61 | void ext2_delete_inode (struct inode * inode) |
60 | { | 62 | { |
63 | if (!is_bad_inode(inode)) | ||
64 | dquot_initialize(inode); | ||
61 | truncate_inode_pages(&inode->i_data, 0); | 65 | truncate_inode_pages(&inode->i_data, 0); |
62 | 66 | ||
63 | if (is_bad_inode(inode)) | 67 | if (is_bad_inode(inode)) |
64 | goto no_delete; | 68 | goto no_delete; |
65 | EXT2_I(inode)->i_dtime = get_seconds(); | 69 | EXT2_I(inode)->i_dtime = get_seconds(); |
66 | mark_inode_dirty(inode); | 70 | mark_inode_dirty(inode); |
67 | ext2_write_inode(inode, inode_needs_sync(inode)); | 71 | __ext2_write_inode(inode, inode_needs_sync(inode)); |
68 | 72 | ||
69 | inode->i_size = 0; | 73 | inode->i_size = 0; |
70 | if (inode->i_blocks) | 74 | if (inode->i_blocks) |
@@ -1335,7 +1339,7 @@ bad_inode: | |||
1335 | return ERR_PTR(ret); | 1339 | return ERR_PTR(ret); |
1336 | } | 1340 | } |
1337 | 1341 | ||
1338 | int ext2_write_inode(struct inode *inode, int do_sync) | 1342 | static int __ext2_write_inode(struct inode *inode, int do_sync) |
1339 | { | 1343 | { |
1340 | struct ext2_inode_info *ei = EXT2_I(inode); | 1344 | struct ext2_inode_info *ei = EXT2_I(inode); |
1341 | struct super_block *sb = inode->i_sb; | 1345 | struct super_block *sb = inode->i_sb; |
@@ -1440,6 +1444,11 @@ int ext2_write_inode(struct inode *inode, int do_sync) | |||
1440 | return err; | 1444 | return err; |
1441 | } | 1445 | } |
1442 | 1446 | ||
1447 | int ext2_write_inode(struct inode *inode, struct writeback_control *wbc) | ||
1448 | { | ||
1449 | return __ext2_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL); | ||
1450 | } | ||
1451 | |||
1443 | int ext2_sync_inode(struct inode *inode) | 1452 | int ext2_sync_inode(struct inode *inode) |
1444 | { | 1453 | { |
1445 | struct writeback_control wbc = { | 1454 | struct writeback_control wbc = { |
@@ -1457,9 +1466,12 @@ int ext2_setattr(struct dentry *dentry, struct iattr *iattr) | |||
1457 | error = inode_change_ok(inode, iattr); | 1466 | error = inode_change_ok(inode, iattr); |
1458 | if (error) | 1467 | if (error) |
1459 | return error; | 1468 | return error; |
1469 | |||
1470 | if (iattr->ia_valid & ATTR_SIZE) | ||
1471 | dquot_initialize(inode); | ||
1460 | if ((iattr->ia_valid & ATTR_UID && iattr->ia_uid != inode->i_uid) || | 1472 | if ((iattr->ia_valid & ATTR_UID && iattr->ia_uid != inode->i_uid) || |
1461 | (iattr->ia_valid & ATTR_GID && iattr->ia_gid != inode->i_gid)) { | 1473 | (iattr->ia_valid & ATTR_GID && iattr->ia_gid != inode->i_gid)) { |
1462 | error = vfs_dq_transfer(inode, iattr) ? -EDQUOT : 0; | 1474 | error = dquot_transfer(inode, iattr); |
1463 | if (error) | 1475 | if (error) |
1464 | return error; | 1476 | return error; |
1465 | } | 1477 | } |
diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c index dd7175ce5606..71efb0e9a3f2 100644 --- a/fs/ext2/namei.c +++ b/fs/ext2/namei.c | |||
@@ -31,6 +31,7 @@ | |||
31 | */ | 31 | */ |
32 | 32 | ||
33 | #include <linux/pagemap.h> | 33 | #include <linux/pagemap.h> |
34 | #include <linux/quotaops.h> | ||
34 | #include "ext2.h" | 35 | #include "ext2.h" |
35 | #include "xattr.h" | 36 | #include "xattr.h" |
36 | #include "acl.h" | 37 | #include "acl.h" |
@@ -99,24 +100,27 @@ struct dentry *ext2_get_parent(struct dentry *child) | |||
99 | */ | 100 | */ |
100 | static int ext2_create (struct inode * dir, struct dentry * dentry, int mode, struct nameidata *nd) | 101 | static int ext2_create (struct inode * dir, struct dentry * dentry, int mode, struct nameidata *nd) |
101 | { | 102 | { |
102 | struct inode * inode = ext2_new_inode (dir, mode); | 103 | struct inode *inode; |
103 | int err = PTR_ERR(inode); | 104 | |
104 | if (!IS_ERR(inode)) { | 105 | dquot_initialize(dir); |
105 | inode->i_op = &ext2_file_inode_operations; | 106 | |
106 | if (ext2_use_xip(inode->i_sb)) { | 107 | inode = ext2_new_inode(dir, mode); |
107 | inode->i_mapping->a_ops = &ext2_aops_xip; | 108 | if (IS_ERR(inode)) |
108 | inode->i_fop = &ext2_xip_file_operations; | 109 | return PTR_ERR(inode); |
109 | } else if (test_opt(inode->i_sb, NOBH)) { | 110 | |
110 | inode->i_mapping->a_ops = &ext2_nobh_aops; | 111 | inode->i_op = &ext2_file_inode_operations; |
111 | inode->i_fop = &ext2_file_operations; | 112 | if (ext2_use_xip(inode->i_sb)) { |
112 | } else { | 113 | inode->i_mapping->a_ops = &ext2_aops_xip; |
113 | inode->i_mapping->a_ops = &ext2_aops; | 114 | inode->i_fop = &ext2_xip_file_operations; |
114 | inode->i_fop = &ext2_file_operations; | 115 | } else if (test_opt(inode->i_sb, NOBH)) { |
115 | } | 116 | inode->i_mapping->a_ops = &ext2_nobh_aops; |
116 | mark_inode_dirty(inode); | 117 | inode->i_fop = &ext2_file_operations; |
117 | err = ext2_add_nondir(dentry, inode); | 118 | } else { |
119 | inode->i_mapping->a_ops = &ext2_aops; | ||
120 | inode->i_fop = &ext2_file_operations; | ||
118 | } | 121 | } |
119 | return err; | 122 | mark_inode_dirty(inode); |
123 | return ext2_add_nondir(dentry, inode); | ||
120 | } | 124 | } |
121 | 125 | ||
122 | static int ext2_mknod (struct inode * dir, struct dentry *dentry, int mode, dev_t rdev) | 126 | static int ext2_mknod (struct inode * dir, struct dentry *dentry, int mode, dev_t rdev) |
@@ -127,6 +131,8 @@ static int ext2_mknod (struct inode * dir, struct dentry *dentry, int mode, dev_ | |||
127 | if (!new_valid_dev(rdev)) | 131 | if (!new_valid_dev(rdev)) |
128 | return -EINVAL; | 132 | return -EINVAL; |
129 | 133 | ||
134 | dquot_initialize(dir); | ||
135 | |||
130 | inode = ext2_new_inode (dir, mode); | 136 | inode = ext2_new_inode (dir, mode); |
131 | err = PTR_ERR(inode); | 137 | err = PTR_ERR(inode); |
132 | if (!IS_ERR(inode)) { | 138 | if (!IS_ERR(inode)) { |
@@ -151,6 +157,8 @@ static int ext2_symlink (struct inode * dir, struct dentry * dentry, | |||
151 | if (l > sb->s_blocksize) | 157 | if (l > sb->s_blocksize) |
152 | goto out; | 158 | goto out; |
153 | 159 | ||
160 | dquot_initialize(dir); | ||
161 | |||
154 | inode = ext2_new_inode (dir, S_IFLNK | S_IRWXUGO); | 162 | inode = ext2_new_inode (dir, S_IFLNK | S_IRWXUGO); |
155 | err = PTR_ERR(inode); | 163 | err = PTR_ERR(inode); |
156 | if (IS_ERR(inode)) | 164 | if (IS_ERR(inode)) |
@@ -194,6 +202,8 @@ static int ext2_link (struct dentry * old_dentry, struct inode * dir, | |||
194 | if (inode->i_nlink >= EXT2_LINK_MAX) | 202 | if (inode->i_nlink >= EXT2_LINK_MAX) |
195 | return -EMLINK; | 203 | return -EMLINK; |
196 | 204 | ||
205 | dquot_initialize(dir); | ||
206 | |||
197 | inode->i_ctime = CURRENT_TIME_SEC; | 207 | inode->i_ctime = CURRENT_TIME_SEC; |
198 | inode_inc_link_count(inode); | 208 | inode_inc_link_count(inode); |
199 | atomic_inc(&inode->i_count); | 209 | atomic_inc(&inode->i_count); |
@@ -216,6 +226,8 @@ static int ext2_mkdir(struct inode * dir, struct dentry * dentry, int mode) | |||
216 | if (dir->i_nlink >= EXT2_LINK_MAX) | 226 | if (dir->i_nlink >= EXT2_LINK_MAX) |
217 | goto out; | 227 | goto out; |
218 | 228 | ||
229 | dquot_initialize(dir); | ||
230 | |||
219 | inode_inc_link_count(dir); | 231 | inode_inc_link_count(dir); |
220 | 232 | ||
221 | inode = ext2_new_inode (dir, S_IFDIR | mode); | 233 | inode = ext2_new_inode (dir, S_IFDIR | mode); |
@@ -262,6 +274,8 @@ static int ext2_unlink(struct inode * dir, struct dentry *dentry) | |||
262 | struct page * page; | 274 | struct page * page; |
263 | int err = -ENOENT; | 275 | int err = -ENOENT; |
264 | 276 | ||
277 | dquot_initialize(dir); | ||
278 | |||
265 | de = ext2_find_entry (dir, &dentry->d_name, &page); | 279 | de = ext2_find_entry (dir, &dentry->d_name, &page); |
266 | if (!de) | 280 | if (!de) |
267 | goto out; | 281 | goto out; |
@@ -304,6 +318,9 @@ static int ext2_rename (struct inode * old_dir, struct dentry * old_dentry, | |||
304 | struct ext2_dir_entry_2 * old_de; | 318 | struct ext2_dir_entry_2 * old_de; |
305 | int err = -ENOENT; | 319 | int err = -ENOENT; |
306 | 320 | ||
321 | dquot_initialize(old_dir); | ||
322 | dquot_initialize(new_dir); | ||
323 | |||
307 | old_de = ext2_find_entry (old_dir, &old_dentry->d_name, &old_page); | 324 | old_de = ext2_find_entry (old_dir, &old_dentry->d_name, &old_page); |
308 | if (!old_de) | 325 | if (!old_de) |
309 | goto out; | 326 | goto out; |
diff --git a/fs/ext2/super.c b/fs/ext2/super.c index f9cb54a585ce..42e4a303b675 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c | |||
@@ -194,6 +194,8 @@ static void destroy_inodecache(void) | |||
194 | static void ext2_clear_inode(struct inode *inode) | 194 | static void ext2_clear_inode(struct inode *inode) |
195 | { | 195 | { |
196 | struct ext2_block_alloc_info *rsv = EXT2_I(inode)->i_block_alloc_info; | 196 | struct ext2_block_alloc_info *rsv = EXT2_I(inode)->i_block_alloc_info; |
197 | |||
198 | dquot_drop(inode); | ||
197 | ext2_discard_reservation(inode); | 199 | ext2_discard_reservation(inode); |
198 | EXT2_I(inode)->i_block_alloc_info = NULL; | 200 | EXT2_I(inode)->i_block_alloc_info = NULL; |
199 | if (unlikely(rsv)) | 201 | if (unlikely(rsv)) |
diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c index 904f00642f84..e44dc92609be 100644 --- a/fs/ext2/xattr.c +++ b/fs/ext2/xattr.c | |||
@@ -644,8 +644,8 @@ ext2_xattr_set2(struct inode *inode, struct buffer_head *old_bh, | |||
644 | the inode. */ | 644 | the inode. */ |
645 | ea_bdebug(new_bh, "reusing block"); | 645 | ea_bdebug(new_bh, "reusing block"); |
646 | 646 | ||
647 | error = -EDQUOT; | 647 | error = dquot_alloc_block(inode, 1); |
648 | if (vfs_dq_alloc_block(inode, 1)) { | 648 | if (error) { |
649 | unlock_buffer(new_bh); | 649 | unlock_buffer(new_bh); |
650 | goto cleanup; | 650 | goto cleanup; |
651 | } | 651 | } |
@@ -702,7 +702,7 @@ ext2_xattr_set2(struct inode *inode, struct buffer_head *old_bh, | |||
702 | * as if nothing happened and cleanup the unused block */ | 702 | * as if nothing happened and cleanup the unused block */ |
703 | if (error && error != -ENOSPC) { | 703 | if (error && error != -ENOSPC) { |
704 | if (new_bh && new_bh != old_bh) | 704 | if (new_bh && new_bh != old_bh) |
705 | vfs_dq_free_block(inode, 1); | 705 | dquot_free_block(inode, 1); |
706 | goto cleanup; | 706 | goto cleanup; |
707 | } | 707 | } |
708 | } else | 708 | } else |
@@ -734,7 +734,7 @@ ext2_xattr_set2(struct inode *inode, struct buffer_head *old_bh, | |||
734 | le32_add_cpu(&HDR(old_bh)->h_refcount, -1); | 734 | le32_add_cpu(&HDR(old_bh)->h_refcount, -1); |
735 | if (ce) | 735 | if (ce) |
736 | mb_cache_entry_release(ce); | 736 | mb_cache_entry_release(ce); |
737 | vfs_dq_free_block(inode, 1); | 737 | dquot_free_block(inode, 1); |
738 | mark_buffer_dirty(old_bh); | 738 | mark_buffer_dirty(old_bh); |
739 | ea_bdebug(old_bh, "refcount now=%d", | 739 | ea_bdebug(old_bh, "refcount now=%d", |
740 | le32_to_cpu(HDR(old_bh)->h_refcount)); | 740 | le32_to_cpu(HDR(old_bh)->h_refcount)); |
@@ -797,7 +797,7 @@ ext2_xattr_delete_inode(struct inode *inode) | |||
797 | mark_buffer_dirty(bh); | 797 | mark_buffer_dirty(bh); |
798 | if (IS_SYNC(inode)) | 798 | if (IS_SYNC(inode)) |
799 | sync_dirty_buffer(bh); | 799 | sync_dirty_buffer(bh); |
800 | vfs_dq_free_block(inode, 1); | 800 | dquot_free_block(inode, 1); |
801 | } | 801 | } |
802 | EXT2_I(inode)->i_file_acl = 0; | 802 | EXT2_I(inode)->i_file_acl = 0; |
803 | 803 | ||
diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c index 27967f92e820..161da2d3f890 100644 --- a/fs/ext3/balloc.c +++ b/fs/ext3/balloc.c | |||
@@ -676,7 +676,7 @@ void ext3_free_blocks(handle_t *handle, struct inode *inode, | |||
676 | } | 676 | } |
677 | ext3_free_blocks_sb(handle, sb, block, count, &dquot_freed_blocks); | 677 | ext3_free_blocks_sb(handle, sb, block, count, &dquot_freed_blocks); |
678 | if (dquot_freed_blocks) | 678 | if (dquot_freed_blocks) |
679 | vfs_dq_free_block(inode, dquot_freed_blocks); | 679 | dquot_free_block(inode, dquot_freed_blocks); |
680 | return; | 680 | return; |
681 | } | 681 | } |
682 | 682 | ||
@@ -1502,8 +1502,9 @@ ext3_fsblk_t ext3_new_blocks(handle_t *handle, struct inode *inode, | |||
1502 | /* | 1502 | /* |
1503 | * Check quota for allocation of this block. | 1503 | * Check quota for allocation of this block. |
1504 | */ | 1504 | */ |
1505 | if (vfs_dq_alloc_block(inode, num)) { | 1505 | err = dquot_alloc_block(inode, num); |
1506 | *errp = -EDQUOT; | 1506 | if (err) { |
1507 | *errp = err; | ||
1507 | return 0; | 1508 | return 0; |
1508 | } | 1509 | } |
1509 | 1510 | ||
@@ -1713,7 +1714,7 @@ allocated: | |||
1713 | 1714 | ||
1714 | *errp = 0; | 1715 | *errp = 0; |
1715 | brelse(bitmap_bh); | 1716 | brelse(bitmap_bh); |
1716 | vfs_dq_free_block(inode, *count-num); | 1717 | dquot_free_block(inode, *count-num); |
1717 | *count = num; | 1718 | *count = num; |
1718 | return ret_block; | 1719 | return ret_block; |
1719 | 1720 | ||
@@ -1728,7 +1729,7 @@ out: | |||
1728 | * Undo the block allocation | 1729 | * Undo the block allocation |
1729 | */ | 1730 | */ |
1730 | if (!performed_allocation) | 1731 | if (!performed_allocation) |
1731 | vfs_dq_free_block(inode, *count); | 1732 | dquot_free_block(inode, *count); |
1732 | brelse(bitmap_bh); | 1733 | brelse(bitmap_bh); |
1733 | return 0; | 1734 | return 0; |
1734 | } | 1735 | } |
diff --git a/fs/ext3/file.c b/fs/ext3/file.c index 388bbdfa0b4e..f55df0e61cbd 100644 --- a/fs/ext3/file.c +++ b/fs/ext3/file.c | |||
@@ -21,6 +21,7 @@ | |||
21 | #include <linux/time.h> | 21 | #include <linux/time.h> |
22 | #include <linux/fs.h> | 22 | #include <linux/fs.h> |
23 | #include <linux/jbd.h> | 23 | #include <linux/jbd.h> |
24 | #include <linux/quotaops.h> | ||
24 | #include <linux/ext3_fs.h> | 25 | #include <linux/ext3_fs.h> |
25 | #include <linux/ext3_jbd.h> | 26 | #include <linux/ext3_jbd.h> |
26 | #include "xattr.h" | 27 | #include "xattr.h" |
@@ -33,9 +34,9 @@ | |||
33 | */ | 34 | */ |
34 | static int ext3_release_file (struct inode * inode, struct file * filp) | 35 | static int ext3_release_file (struct inode * inode, struct file * filp) |
35 | { | 36 | { |
36 | if (EXT3_I(inode)->i_state & EXT3_STATE_FLUSH_ON_CLOSE) { | 37 | if (ext3_test_inode_state(inode, EXT3_STATE_FLUSH_ON_CLOSE)) { |
37 | filemap_flush(inode->i_mapping); | 38 | filemap_flush(inode->i_mapping); |
38 | EXT3_I(inode)->i_state &= ~EXT3_STATE_FLUSH_ON_CLOSE; | 39 | ext3_clear_inode_state(inode, EXT3_STATE_FLUSH_ON_CLOSE); |
39 | } | 40 | } |
40 | /* if we are the last writer on the inode, drop the block reservation */ | 41 | /* if we are the last writer on the inode, drop the block reservation */ |
41 | if ((filp->f_mode & FMODE_WRITE) && | 42 | if ((filp->f_mode & FMODE_WRITE) && |
@@ -62,7 +63,7 @@ const struct file_operations ext3_file_operations = { | |||
62 | .compat_ioctl = ext3_compat_ioctl, | 63 | .compat_ioctl = ext3_compat_ioctl, |
63 | #endif | 64 | #endif |
64 | .mmap = generic_file_mmap, | 65 | .mmap = generic_file_mmap, |
65 | .open = generic_file_open, | 66 | .open = dquot_file_open, |
66 | .release = ext3_release_file, | 67 | .release = ext3_release_file, |
67 | .fsync = ext3_sync_file, | 68 | .fsync = ext3_sync_file, |
68 | .splice_read = generic_file_splice_read, | 69 | .splice_read = generic_file_splice_read, |
diff --git a/fs/ext3/ialloc.c b/fs/ext3/ialloc.c index b39991285136..ef9008b885b5 100644 --- a/fs/ext3/ialloc.c +++ b/fs/ext3/ialloc.c | |||
@@ -123,10 +123,10 @@ void ext3_free_inode (handle_t *handle, struct inode * inode) | |||
123 | * Note: we must free any quota before locking the superblock, | 123 | * Note: we must free any quota before locking the superblock, |
124 | * as writing the quota to disk may need the lock as well. | 124 | * as writing the quota to disk may need the lock as well. |
125 | */ | 125 | */ |
126 | vfs_dq_init(inode); | 126 | dquot_initialize(inode); |
127 | ext3_xattr_delete_inode(handle, inode); | 127 | ext3_xattr_delete_inode(handle, inode); |
128 | vfs_dq_free_inode(inode); | 128 | dquot_free_inode(inode); |
129 | vfs_dq_drop(inode); | 129 | dquot_drop(inode); |
130 | 130 | ||
131 | is_directory = S_ISDIR(inode->i_mode); | 131 | is_directory = S_ISDIR(inode->i_mode); |
132 | 132 | ||
@@ -588,10 +588,10 @@ got: | |||
588 | sizeof(struct ext3_inode) - EXT3_GOOD_OLD_INODE_SIZE : 0; | 588 | sizeof(struct ext3_inode) - EXT3_GOOD_OLD_INODE_SIZE : 0; |
589 | 589 | ||
590 | ret = inode; | 590 | ret = inode; |
591 | if (vfs_dq_alloc_inode(inode)) { | 591 | dquot_initialize(inode); |
592 | err = -EDQUOT; | 592 | err = dquot_alloc_inode(inode); |
593 | if (err) | ||
593 | goto fail_drop; | 594 | goto fail_drop; |
594 | } | ||
595 | 595 | ||
596 | err = ext3_init_acl(handle, inode, dir); | 596 | err = ext3_init_acl(handle, inode, dir); |
597 | if (err) | 597 | if (err) |
@@ -619,10 +619,10 @@ really_out: | |||
619 | return ret; | 619 | return ret; |
620 | 620 | ||
621 | fail_free_drop: | 621 | fail_free_drop: |
622 | vfs_dq_free_inode(inode); | 622 | dquot_free_inode(inode); |
623 | 623 | ||
624 | fail_drop: | 624 | fail_drop: |
625 | vfs_dq_drop(inode); | 625 | dquot_drop(inode); |
626 | inode->i_flags |= S_NOQUOTA; | 626 | inode->i_flags |= S_NOQUOTA; |
627 | inode->i_nlink = 0; | 627 | inode->i_nlink = 0; |
628 | unlock_new_inode(inode); | 628 | unlock_new_inode(inode); |
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c index 455e6e6e5cb9..7f920b7263a4 100644 --- a/fs/ext3/inode.c +++ b/fs/ext3/inode.c | |||
@@ -196,6 +196,9 @@ void ext3_delete_inode (struct inode * inode) | |||
196 | { | 196 | { |
197 | handle_t *handle; | 197 | handle_t *handle; |
198 | 198 | ||
199 | if (!is_bad_inode(inode)) | ||
200 | dquot_initialize(inode); | ||
201 | |||
199 | truncate_inode_pages(&inode->i_data, 0); | 202 | truncate_inode_pages(&inode->i_data, 0); |
200 | 203 | ||
201 | if (is_bad_inode(inode)) | 204 | if (is_bad_inode(inode)) |
@@ -1378,7 +1381,7 @@ static int ext3_journalled_write_end(struct file *file, | |||
1378 | */ | 1381 | */ |
1379 | if (pos + len > inode->i_size && ext3_can_truncate(inode)) | 1382 | if (pos + len > inode->i_size && ext3_can_truncate(inode)) |
1380 | ext3_orphan_add(handle, inode); | 1383 | ext3_orphan_add(handle, inode); |
1381 | EXT3_I(inode)->i_state |= EXT3_STATE_JDATA; | 1384 | ext3_set_inode_state(inode, EXT3_STATE_JDATA); |
1382 | if (inode->i_size > EXT3_I(inode)->i_disksize) { | 1385 | if (inode->i_size > EXT3_I(inode)->i_disksize) { |
1383 | EXT3_I(inode)->i_disksize = inode->i_size; | 1386 | EXT3_I(inode)->i_disksize = inode->i_size; |
1384 | ret2 = ext3_mark_inode_dirty(handle, inode); | 1387 | ret2 = ext3_mark_inode_dirty(handle, inode); |
@@ -1417,7 +1420,7 @@ static sector_t ext3_bmap(struct address_space *mapping, sector_t block) | |||
1417 | journal_t *journal; | 1420 | journal_t *journal; |
1418 | int err; | 1421 | int err; |
1419 | 1422 | ||
1420 | if (EXT3_I(inode)->i_state & EXT3_STATE_JDATA) { | 1423 | if (ext3_test_inode_state(inode, EXT3_STATE_JDATA)) { |
1421 | /* | 1424 | /* |
1422 | * This is a REALLY heavyweight approach, but the use of | 1425 | * This is a REALLY heavyweight approach, but the use of |
1423 | * bmap on dirty files is expected to be extremely rare: | 1426 | * bmap on dirty files is expected to be extremely rare: |
@@ -1436,7 +1439,7 @@ static sector_t ext3_bmap(struct address_space *mapping, sector_t block) | |||
1436 | * everything they get. | 1439 | * everything they get. |
1437 | */ | 1440 | */ |
1438 | 1441 | ||
1439 | EXT3_I(inode)->i_state &= ~EXT3_STATE_JDATA; | 1442 | ext3_clear_inode_state(inode, EXT3_STATE_JDATA); |
1440 | journal = EXT3_JOURNAL(inode); | 1443 | journal = EXT3_JOURNAL(inode); |
1441 | journal_lock_updates(journal); | 1444 | journal_lock_updates(journal); |
1442 | err = journal_flush(journal); | 1445 | err = journal_flush(journal); |
@@ -1528,6 +1531,7 @@ static int ext3_ordered_writepage(struct page *page, | |||
1528 | int err; | 1531 | int err; |
1529 | 1532 | ||
1530 | J_ASSERT(PageLocked(page)); | 1533 | J_ASSERT(PageLocked(page)); |
1534 | WARN_ON_ONCE(IS_RDONLY(inode)); | ||
1531 | 1535 | ||
1532 | /* | 1536 | /* |
1533 | * We give up here if we're reentered, because it might be for a | 1537 | * We give up here if we're reentered, because it might be for a |
@@ -1600,6 +1604,9 @@ static int ext3_writeback_writepage(struct page *page, | |||
1600 | int ret = 0; | 1604 | int ret = 0; |
1601 | int err; | 1605 | int err; |
1602 | 1606 | ||
1607 | J_ASSERT(PageLocked(page)); | ||
1608 | WARN_ON_ONCE(IS_RDONLY(inode)); | ||
1609 | |||
1603 | if (ext3_journal_current_handle()) | 1610 | if (ext3_journal_current_handle()) |
1604 | goto out_fail; | 1611 | goto out_fail; |
1605 | 1612 | ||
@@ -1642,6 +1649,9 @@ static int ext3_journalled_writepage(struct page *page, | |||
1642 | int ret = 0; | 1649 | int ret = 0; |
1643 | int err; | 1650 | int err; |
1644 | 1651 | ||
1652 | J_ASSERT(PageLocked(page)); | ||
1653 | WARN_ON_ONCE(IS_RDONLY(inode)); | ||
1654 | |||
1645 | if (ext3_journal_current_handle()) | 1655 | if (ext3_journal_current_handle()) |
1646 | goto no_write; | 1656 | goto no_write; |
1647 | 1657 | ||
@@ -1670,7 +1680,7 @@ static int ext3_journalled_writepage(struct page *page, | |||
1670 | PAGE_CACHE_SIZE, NULL, write_end_fn); | 1680 | PAGE_CACHE_SIZE, NULL, write_end_fn); |
1671 | if (ret == 0) | 1681 | if (ret == 0) |
1672 | ret = err; | 1682 | ret = err; |
1673 | EXT3_I(inode)->i_state |= EXT3_STATE_JDATA; | 1683 | ext3_set_inode_state(inode, EXT3_STATE_JDATA); |
1674 | unlock_page(page); | 1684 | unlock_page(page); |
1675 | } else { | 1685 | } else { |
1676 | /* | 1686 | /* |
@@ -1785,8 +1795,9 @@ retry: | |||
1785 | handle = ext3_journal_start(inode, 2); | 1795 | handle = ext3_journal_start(inode, 2); |
1786 | if (IS_ERR(handle)) { | 1796 | if (IS_ERR(handle)) { |
1787 | /* This is really bad luck. We've written the data | 1797 | /* This is really bad luck. We've written the data |
1788 | * but cannot extend i_size. Bail out and pretend | 1798 | * but cannot extend i_size. Truncate allocated blocks |
1789 | * the write failed... */ | 1799 | * and pretend the write failed... */ |
1800 | ext3_truncate(inode); | ||
1790 | ret = PTR_ERR(handle); | 1801 | ret = PTR_ERR(handle); |
1791 | goto out; | 1802 | goto out; |
1792 | } | 1803 | } |
@@ -2402,7 +2413,7 @@ void ext3_truncate(struct inode *inode) | |||
2402 | goto out_notrans; | 2413 | goto out_notrans; |
2403 | 2414 | ||
2404 | if (inode->i_size == 0 && ext3_should_writeback_data(inode)) | 2415 | if (inode->i_size == 0 && ext3_should_writeback_data(inode)) |
2405 | ei->i_state |= EXT3_STATE_FLUSH_ON_CLOSE; | 2416 | ext3_set_inode_state(inode, EXT3_STATE_FLUSH_ON_CLOSE); |
2406 | 2417 | ||
2407 | /* | 2418 | /* |
2408 | * We have to lock the EOF page here, because lock_page() nests | 2419 | * We have to lock the EOF page here, because lock_page() nests |
@@ -2721,7 +2732,7 @@ int ext3_get_inode_loc(struct inode *inode, struct ext3_iloc *iloc) | |||
2721 | { | 2732 | { |
2722 | /* We have all inode data except xattrs in memory here. */ | 2733 | /* We have all inode data except xattrs in memory here. */ |
2723 | return __ext3_get_inode_loc(inode, iloc, | 2734 | return __ext3_get_inode_loc(inode, iloc, |
2724 | !(EXT3_I(inode)->i_state & EXT3_STATE_XATTR)); | 2735 | !ext3_test_inode_state(inode, EXT3_STATE_XATTR)); |
2725 | } | 2736 | } |
2726 | 2737 | ||
2727 | void ext3_set_inode_flags(struct inode *inode) | 2738 | void ext3_set_inode_flags(struct inode *inode) |
@@ -2893,7 +2904,7 @@ struct inode *ext3_iget(struct super_block *sb, unsigned long ino) | |||
2893 | EXT3_GOOD_OLD_INODE_SIZE + | 2904 | EXT3_GOOD_OLD_INODE_SIZE + |
2894 | ei->i_extra_isize; | 2905 | ei->i_extra_isize; |
2895 | if (*magic == cpu_to_le32(EXT3_XATTR_MAGIC)) | 2906 | if (*magic == cpu_to_le32(EXT3_XATTR_MAGIC)) |
2896 | ei->i_state |= EXT3_STATE_XATTR; | 2907 | ext3_set_inode_state(inode, EXT3_STATE_XATTR); |
2897 | } | 2908 | } |
2898 | } else | 2909 | } else |
2899 | ei->i_extra_isize = 0; | 2910 | ei->i_extra_isize = 0; |
@@ -2955,7 +2966,7 @@ again: | |||
2955 | 2966 | ||
2956 | /* For fields not not tracking in the in-memory inode, | 2967 | /* For fields not not tracking in the in-memory inode, |
2957 | * initialise them to zero for new inodes. */ | 2968 | * initialise them to zero for new inodes. */ |
2958 | if (ei->i_state & EXT3_STATE_NEW) | 2969 | if (ext3_test_inode_state(inode, EXT3_STATE_NEW)) |
2959 | memset(raw_inode, 0, EXT3_SB(inode->i_sb)->s_inode_size); | 2970 | memset(raw_inode, 0, EXT3_SB(inode->i_sb)->s_inode_size); |
2960 | 2971 | ||
2961 | ext3_get_inode_flags(ei); | 2972 | ext3_get_inode_flags(ei); |
@@ -3052,7 +3063,7 @@ again: | |||
3052 | rc = ext3_journal_dirty_metadata(handle, bh); | 3063 | rc = ext3_journal_dirty_metadata(handle, bh); |
3053 | if (!err) | 3064 | if (!err) |
3054 | err = rc; | 3065 | err = rc; |
3055 | ei->i_state &= ~EXT3_STATE_NEW; | 3066 | ext3_clear_inode_state(inode, EXT3_STATE_NEW); |
3056 | 3067 | ||
3057 | atomic_set(&ei->i_sync_tid, handle->h_transaction->t_tid); | 3068 | atomic_set(&ei->i_sync_tid, handle->h_transaction->t_tid); |
3058 | out_brelse: | 3069 | out_brelse: |
@@ -3096,7 +3107,7 @@ out_brelse: | |||
3096 | * `stuff()' is running, and the new i_size will be lost. Plus the inode | 3107 | * `stuff()' is running, and the new i_size will be lost. Plus the inode |
3097 | * will no longer be on the superblock's dirty inode list. | 3108 | * will no longer be on the superblock's dirty inode list. |
3098 | */ | 3109 | */ |
3099 | int ext3_write_inode(struct inode *inode, int wait) | 3110 | int ext3_write_inode(struct inode *inode, struct writeback_control *wbc) |
3100 | { | 3111 | { |
3101 | if (current->flags & PF_MEMALLOC) | 3112 | if (current->flags & PF_MEMALLOC) |
3102 | return 0; | 3113 | return 0; |
@@ -3107,7 +3118,7 @@ int ext3_write_inode(struct inode *inode, int wait) | |||
3107 | return -EIO; | 3118 | return -EIO; |
3108 | } | 3119 | } |
3109 | 3120 | ||
3110 | if (!wait) | 3121 | if (wbc->sync_mode != WB_SYNC_ALL) |
3111 | return 0; | 3122 | return 0; |
3112 | 3123 | ||
3113 | return ext3_force_commit(inode->i_sb); | 3124 | return ext3_force_commit(inode->i_sb); |
@@ -3140,6 +3151,8 @@ int ext3_setattr(struct dentry *dentry, struct iattr *attr) | |||
3140 | if (error) | 3151 | if (error) |
3141 | return error; | 3152 | return error; |
3142 | 3153 | ||
3154 | if (ia_valid & ATTR_SIZE) | ||
3155 | dquot_initialize(inode); | ||
3143 | if ((ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid) || | 3156 | if ((ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid) || |
3144 | (ia_valid & ATTR_GID && attr->ia_gid != inode->i_gid)) { | 3157 | (ia_valid & ATTR_GID && attr->ia_gid != inode->i_gid)) { |
3145 | handle_t *handle; | 3158 | handle_t *handle; |
@@ -3152,7 +3165,7 @@ int ext3_setattr(struct dentry *dentry, struct iattr *attr) | |||
3152 | error = PTR_ERR(handle); | 3165 | error = PTR_ERR(handle); |
3153 | goto err_out; | 3166 | goto err_out; |
3154 | } | 3167 | } |
3155 | error = vfs_dq_transfer(inode, attr) ? -EDQUOT : 0; | 3168 | error = dquot_transfer(inode, attr); |
3156 | if (error) { | 3169 | if (error) { |
3157 | ext3_journal_stop(handle); | 3170 | ext3_journal_stop(handle); |
3158 | return error; | 3171 | return error; |
@@ -3237,7 +3250,7 @@ static int ext3_writepage_trans_blocks(struct inode *inode) | |||
3237 | ret = 2 * (bpp + indirects) + 2; | 3250 | ret = 2 * (bpp + indirects) + 2; |
3238 | 3251 | ||
3239 | #ifdef CONFIG_QUOTA | 3252 | #ifdef CONFIG_QUOTA |
3240 | /* We know that structure was already allocated during vfs_dq_init so | 3253 | /* We know that structure was already allocated during dquot_initialize so |
3241 | * we will be updating only the data blocks + inodes */ | 3254 | * we will be updating only the data blocks + inodes */ |
3242 | ret += EXT3_MAXQUOTAS_TRANS_BLOCKS(inode->i_sb); | 3255 | ret += EXT3_MAXQUOTAS_TRANS_BLOCKS(inode->i_sb); |
3243 | #endif | 3256 | #endif |
@@ -3328,7 +3341,7 @@ int ext3_mark_inode_dirty(handle_t *handle, struct inode *inode) | |||
3328 | * i_size has been changed by generic_commit_write() and we thus need | 3341 | * i_size has been changed by generic_commit_write() and we thus need |
3329 | * to include the updated inode in the current transaction. | 3342 | * to include the updated inode in the current transaction. |
3330 | * | 3343 | * |
3331 | * Also, vfs_dq_alloc_space() will always dirty the inode when blocks | 3344 | * Also, dquot_alloc_space() will always dirty the inode when blocks |
3332 | * are allocated to the file. | 3345 | * are allocated to the file. |
3333 | * | 3346 | * |
3334 | * If the inode is marked synchronous, we don't honour that here - doing | 3347 | * If the inode is marked synchronous, we don't honour that here - doing |
diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c index 7b0e44f7d66f..ee184084ca42 100644 --- a/fs/ext3/namei.c +++ b/fs/ext3/namei.c | |||
@@ -1696,6 +1696,8 @@ static int ext3_create (struct inode * dir, struct dentry * dentry, int mode, | |||
1696 | struct inode * inode; | 1696 | struct inode * inode; |
1697 | int err, retries = 0; | 1697 | int err, retries = 0; |
1698 | 1698 | ||
1699 | dquot_initialize(dir); | ||
1700 | |||
1699 | retry: | 1701 | retry: |
1700 | handle = ext3_journal_start(dir, EXT3_DATA_TRANS_BLOCKS(dir->i_sb) + | 1702 | handle = ext3_journal_start(dir, EXT3_DATA_TRANS_BLOCKS(dir->i_sb) + |
1701 | EXT3_INDEX_EXTRA_TRANS_BLOCKS + 3 + | 1703 | EXT3_INDEX_EXTRA_TRANS_BLOCKS + 3 + |
@@ -1730,6 +1732,8 @@ static int ext3_mknod (struct inode * dir, struct dentry *dentry, | |||
1730 | if (!new_valid_dev(rdev)) | 1732 | if (!new_valid_dev(rdev)) |
1731 | return -EINVAL; | 1733 | return -EINVAL; |
1732 | 1734 | ||
1735 | dquot_initialize(dir); | ||
1736 | |||
1733 | retry: | 1737 | retry: |
1734 | handle = ext3_journal_start(dir, EXT3_DATA_TRANS_BLOCKS(dir->i_sb) + | 1738 | handle = ext3_journal_start(dir, EXT3_DATA_TRANS_BLOCKS(dir->i_sb) + |
1735 | EXT3_INDEX_EXTRA_TRANS_BLOCKS + 3 + | 1739 | EXT3_INDEX_EXTRA_TRANS_BLOCKS + 3 + |
@@ -1766,6 +1770,8 @@ static int ext3_mkdir(struct inode * dir, struct dentry * dentry, int mode) | |||
1766 | if (dir->i_nlink >= EXT3_LINK_MAX) | 1770 | if (dir->i_nlink >= EXT3_LINK_MAX) |
1767 | return -EMLINK; | 1771 | return -EMLINK; |
1768 | 1772 | ||
1773 | dquot_initialize(dir); | ||
1774 | |||
1769 | retry: | 1775 | retry: |
1770 | handle = ext3_journal_start(dir, EXT3_DATA_TRANS_BLOCKS(dir->i_sb) + | 1776 | handle = ext3_journal_start(dir, EXT3_DATA_TRANS_BLOCKS(dir->i_sb) + |
1771 | EXT3_INDEX_EXTRA_TRANS_BLOCKS + 3 + | 1777 | EXT3_INDEX_EXTRA_TRANS_BLOCKS + 3 + |
@@ -2060,7 +2066,9 @@ static int ext3_rmdir (struct inode * dir, struct dentry *dentry) | |||
2060 | 2066 | ||
2061 | /* Initialize quotas before so that eventual writes go in | 2067 | /* Initialize quotas before so that eventual writes go in |
2062 | * separate transaction */ | 2068 | * separate transaction */ |
2063 | vfs_dq_init(dentry->d_inode); | 2069 | dquot_initialize(dir); |
2070 | dquot_initialize(dentry->d_inode); | ||
2071 | |||
2064 | handle = ext3_journal_start(dir, EXT3_DELETE_TRANS_BLOCKS(dir->i_sb)); | 2072 | handle = ext3_journal_start(dir, EXT3_DELETE_TRANS_BLOCKS(dir->i_sb)); |
2065 | if (IS_ERR(handle)) | 2073 | if (IS_ERR(handle)) |
2066 | return PTR_ERR(handle); | 2074 | return PTR_ERR(handle); |
@@ -2119,7 +2127,9 @@ static int ext3_unlink(struct inode * dir, struct dentry *dentry) | |||
2119 | 2127 | ||
2120 | /* Initialize quotas before so that eventual writes go | 2128 | /* Initialize quotas before so that eventual writes go |
2121 | * in separate transaction */ | 2129 | * in separate transaction */ |
2122 | vfs_dq_init(dentry->d_inode); | 2130 | dquot_initialize(dir); |
2131 | dquot_initialize(dentry->d_inode); | ||
2132 | |||
2123 | handle = ext3_journal_start(dir, EXT3_DELETE_TRANS_BLOCKS(dir->i_sb)); | 2133 | handle = ext3_journal_start(dir, EXT3_DELETE_TRANS_BLOCKS(dir->i_sb)); |
2124 | if (IS_ERR(handle)) | 2134 | if (IS_ERR(handle)) |
2125 | return PTR_ERR(handle); | 2135 | return PTR_ERR(handle); |
@@ -2174,6 +2184,8 @@ static int ext3_symlink (struct inode * dir, | |||
2174 | if (l > dir->i_sb->s_blocksize) | 2184 | if (l > dir->i_sb->s_blocksize) |
2175 | return -ENAMETOOLONG; | 2185 | return -ENAMETOOLONG; |
2176 | 2186 | ||
2187 | dquot_initialize(dir); | ||
2188 | |||
2177 | retry: | 2189 | retry: |
2178 | handle = ext3_journal_start(dir, EXT3_DATA_TRANS_BLOCKS(dir->i_sb) + | 2190 | handle = ext3_journal_start(dir, EXT3_DATA_TRANS_BLOCKS(dir->i_sb) + |
2179 | EXT3_INDEX_EXTRA_TRANS_BLOCKS + 5 + | 2191 | EXT3_INDEX_EXTRA_TRANS_BLOCKS + 5 + |
@@ -2228,6 +2240,9 @@ static int ext3_link (struct dentry * old_dentry, | |||
2228 | 2240 | ||
2229 | if (inode->i_nlink >= EXT3_LINK_MAX) | 2241 | if (inode->i_nlink >= EXT3_LINK_MAX) |
2230 | return -EMLINK; | 2242 | return -EMLINK; |
2243 | |||
2244 | dquot_initialize(dir); | ||
2245 | |||
2231 | /* | 2246 | /* |
2232 | * Return -ENOENT if we've raced with unlink and i_nlink is 0. Doing | 2247 | * Return -ENOENT if we've raced with unlink and i_nlink is 0. Doing |
2233 | * otherwise has the potential to corrupt the orphan inode list. | 2248 | * otherwise has the potential to corrupt the orphan inode list. |
@@ -2278,12 +2293,15 @@ static int ext3_rename (struct inode * old_dir, struct dentry *old_dentry, | |||
2278 | struct ext3_dir_entry_2 * old_de, * new_de; | 2293 | struct ext3_dir_entry_2 * old_de, * new_de; |
2279 | int retval, flush_file = 0; | 2294 | int retval, flush_file = 0; |
2280 | 2295 | ||
2296 | dquot_initialize(old_dir); | ||
2297 | dquot_initialize(new_dir); | ||
2298 | |||
2281 | old_bh = new_bh = dir_bh = NULL; | 2299 | old_bh = new_bh = dir_bh = NULL; |
2282 | 2300 | ||
2283 | /* Initialize quotas before so that eventual writes go | 2301 | /* Initialize quotas before so that eventual writes go |
2284 | * in separate transaction */ | 2302 | * in separate transaction */ |
2285 | if (new_dentry->d_inode) | 2303 | if (new_dentry->d_inode) |
2286 | vfs_dq_init(new_dentry->d_inode); | 2304 | dquot_initialize(new_dentry->d_inode); |
2287 | handle = ext3_journal_start(old_dir, 2 * | 2305 | handle = ext3_journal_start(old_dir, 2 * |
2288 | EXT3_DATA_TRANS_BLOCKS(old_dir->i_sb) + | 2306 | EXT3_DATA_TRANS_BLOCKS(old_dir->i_sb) + |
2289 | EXT3_INDEX_EXTRA_TRANS_BLOCKS + 2); | 2307 | EXT3_INDEX_EXTRA_TRANS_BLOCKS + 2); |
diff --git a/fs/ext3/super.c b/fs/ext3/super.c index afa2b569da10..e844accbf55d 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c | |||
@@ -181,7 +181,7 @@ static void ext3_handle_error(struct super_block *sb) | |||
181 | if (!test_opt (sb, ERRORS_CONT)) { | 181 | if (!test_opt (sb, ERRORS_CONT)) { |
182 | journal_t *journal = EXT3_SB(sb)->s_journal; | 182 | journal_t *journal = EXT3_SB(sb)->s_journal; |
183 | 183 | ||
184 | EXT3_SB(sb)->s_mount_opt |= EXT3_MOUNT_ABORT; | 184 | set_opt(EXT3_SB(sb)->s_mount_opt, ABORT); |
185 | if (journal) | 185 | if (journal) |
186 | journal_abort(journal, -EIO); | 186 | journal_abort(journal, -EIO); |
187 | } | 187 | } |
@@ -296,7 +296,7 @@ void ext3_abort (struct super_block * sb, const char * function, | |||
296 | "error: remounting filesystem read-only"); | 296 | "error: remounting filesystem read-only"); |
297 | EXT3_SB(sb)->s_mount_state |= EXT3_ERROR_FS; | 297 | EXT3_SB(sb)->s_mount_state |= EXT3_ERROR_FS; |
298 | sb->s_flags |= MS_RDONLY; | 298 | sb->s_flags |= MS_RDONLY; |
299 | EXT3_SB(sb)->s_mount_opt |= EXT3_MOUNT_ABORT; | 299 | set_opt(EXT3_SB(sb)->s_mount_opt, ABORT); |
300 | if (EXT3_SB(sb)->s_journal) | 300 | if (EXT3_SB(sb)->s_journal) |
301 | journal_abort(EXT3_SB(sb)->s_journal, -EIO); | 301 | journal_abort(EXT3_SB(sb)->s_journal, -EIO); |
302 | } | 302 | } |
@@ -528,6 +528,8 @@ static void destroy_inodecache(void) | |||
528 | static void ext3_clear_inode(struct inode *inode) | 528 | static void ext3_clear_inode(struct inode *inode) |
529 | { | 529 | { |
530 | struct ext3_block_alloc_info *rsv = EXT3_I(inode)->i_block_alloc_info; | 530 | struct ext3_block_alloc_info *rsv = EXT3_I(inode)->i_block_alloc_info; |
531 | |||
532 | dquot_drop(inode); | ||
531 | ext3_discard_reservation(inode); | 533 | ext3_discard_reservation(inode); |
532 | EXT3_I(inode)->i_block_alloc_info = NULL; | 534 | EXT3_I(inode)->i_block_alloc_info = NULL; |
533 | if (unlikely(rsv)) | 535 | if (unlikely(rsv)) |
@@ -562,10 +564,10 @@ static inline void ext3_show_quota_options(struct seq_file *seq, struct super_bl | |||
562 | if (sbi->s_qf_names[GRPQUOTA]) | 564 | if (sbi->s_qf_names[GRPQUOTA]) |
563 | seq_printf(seq, ",grpjquota=%s", sbi->s_qf_names[GRPQUOTA]); | 565 | seq_printf(seq, ",grpjquota=%s", sbi->s_qf_names[GRPQUOTA]); |
564 | 566 | ||
565 | if (sbi->s_mount_opt & EXT3_MOUNT_USRQUOTA) | 567 | if (test_opt(sb, USRQUOTA)) |
566 | seq_puts(seq, ",usrquota"); | 568 | seq_puts(seq, ",usrquota"); |
567 | 569 | ||
568 | if (sbi->s_mount_opt & EXT3_MOUNT_GRPQUOTA) | 570 | if (test_opt(sb, GRPQUOTA)) |
569 | seq_puts(seq, ",grpquota"); | 571 | seq_puts(seq, ",grpquota"); |
570 | #endif | 572 | #endif |
571 | } | 573 | } |
@@ -656,8 +658,7 @@ static int ext3_show_options(struct seq_file *seq, struct vfsmount *vfs) | |||
656 | if (test_opt(sb, NOBH)) | 658 | if (test_opt(sb, NOBH)) |
657 | seq_puts(seq, ",nobh"); | 659 | seq_puts(seq, ",nobh"); |
658 | 660 | ||
659 | seq_printf(seq, ",data=%s", data_mode_string(sbi->s_mount_opt & | 661 | seq_printf(seq, ",data=%s", data_mode_string(test_opt(sb, DATA_FLAGS))); |
660 | EXT3_MOUNT_DATA_FLAGS)); | ||
661 | if (test_opt(sb, DATA_ERR_ABORT)) | 662 | if (test_opt(sb, DATA_ERR_ABORT)) |
662 | seq_puts(seq, ",data_err=abort"); | 663 | seq_puts(seq, ",data_err=abort"); |
663 | 664 | ||
@@ -751,13 +752,6 @@ static ssize_t ext3_quota_write(struct super_block *sb, int type, | |||
751 | const char *data, size_t len, loff_t off); | 752 | const char *data, size_t len, loff_t off); |
752 | 753 | ||
753 | static const struct dquot_operations ext3_quota_operations = { | 754 | static const struct dquot_operations ext3_quota_operations = { |
754 | .initialize = dquot_initialize, | ||
755 | .drop = dquot_drop, | ||
756 | .alloc_space = dquot_alloc_space, | ||
757 | .alloc_inode = dquot_alloc_inode, | ||
758 | .free_space = dquot_free_space, | ||
759 | .free_inode = dquot_free_inode, | ||
760 | .transfer = dquot_transfer, | ||
761 | .write_dquot = ext3_write_dquot, | 755 | .write_dquot = ext3_write_dquot, |
762 | .acquire_dquot = ext3_acquire_dquot, | 756 | .acquire_dquot = ext3_acquire_dquot, |
763 | .release_dquot = ext3_release_dquot, | 757 | .release_dquot = ext3_release_dquot, |
@@ -896,6 +890,63 @@ static ext3_fsblk_t get_sb_block(void **data, struct super_block *sb) | |||
896 | return sb_block; | 890 | return sb_block; |
897 | } | 891 | } |
898 | 892 | ||
893 | #ifdef CONFIG_QUOTA | ||
894 | static int set_qf_name(struct super_block *sb, int qtype, substring_t *args) | ||
895 | { | ||
896 | struct ext3_sb_info *sbi = EXT3_SB(sb); | ||
897 | char *qname; | ||
898 | |||
899 | if (sb_any_quota_loaded(sb) && | ||
900 | !sbi->s_qf_names[qtype]) { | ||
901 | ext3_msg(sb, KERN_ERR, | ||
902 | "Cannot change journaled " | ||
903 | "quota options when quota turned on"); | ||
904 | return 0; | ||
905 | } | ||
906 | qname = match_strdup(args); | ||
907 | if (!qname) { | ||
908 | ext3_msg(sb, KERN_ERR, | ||
909 | "Not enough memory for storing quotafile name"); | ||
910 | return 0; | ||
911 | } | ||
912 | if (sbi->s_qf_names[qtype] && | ||
913 | strcmp(sbi->s_qf_names[qtype], qname)) { | ||
914 | ext3_msg(sb, KERN_ERR, | ||
915 | "%s quota file already specified", QTYPE2NAME(qtype)); | ||
916 | kfree(qname); | ||
917 | return 0; | ||
918 | } | ||
919 | sbi->s_qf_names[qtype] = qname; | ||
920 | if (strchr(sbi->s_qf_names[qtype], '/')) { | ||
921 | ext3_msg(sb, KERN_ERR, | ||
922 | "quotafile must be on filesystem root"); | ||
923 | kfree(sbi->s_qf_names[qtype]); | ||
924 | sbi->s_qf_names[qtype] = NULL; | ||
925 | return 0; | ||
926 | } | ||
927 | set_opt(sbi->s_mount_opt, QUOTA); | ||
928 | return 1; | ||
929 | } | ||
930 | |||
931 | static int clear_qf_name(struct super_block *sb, int qtype) { | ||
932 | |||
933 | struct ext3_sb_info *sbi = EXT3_SB(sb); | ||
934 | |||
935 | if (sb_any_quota_loaded(sb) && | ||
936 | sbi->s_qf_names[qtype]) { | ||
937 | ext3_msg(sb, KERN_ERR, "Cannot change journaled quota options" | ||
938 | " when quota turned on"); | ||
939 | return 0; | ||
940 | } | ||
941 | /* | ||
942 | * The space will be released later when all options are confirmed | ||
943 | * to be correct | ||
944 | */ | ||
945 | sbi->s_qf_names[qtype] = NULL; | ||
946 | return 1; | ||
947 | } | ||
948 | #endif | ||
949 | |||
899 | static int parse_options (char *options, struct super_block *sb, | 950 | static int parse_options (char *options, struct super_block *sb, |
900 | unsigned int *inum, unsigned long *journal_devnum, | 951 | unsigned int *inum, unsigned long *journal_devnum, |
901 | ext3_fsblk_t *n_blocks_count, int is_remount) | 952 | ext3_fsblk_t *n_blocks_count, int is_remount) |
@@ -906,8 +957,7 @@ static int parse_options (char *options, struct super_block *sb, | |||
906 | int data_opt = 0; | 957 | int data_opt = 0; |
907 | int option; | 958 | int option; |
908 | #ifdef CONFIG_QUOTA | 959 | #ifdef CONFIG_QUOTA |
909 | int qtype, qfmt; | 960 | int qfmt; |
910 | char *qname; | ||
911 | #endif | 961 | #endif |
912 | 962 | ||
913 | if (!options) | 963 | if (!options) |
@@ -1065,20 +1115,19 @@ static int parse_options (char *options, struct super_block *sb, | |||
1065 | data_opt = EXT3_MOUNT_WRITEBACK_DATA; | 1115 | data_opt = EXT3_MOUNT_WRITEBACK_DATA; |
1066 | datacheck: | 1116 | datacheck: |
1067 | if (is_remount) { | 1117 | if (is_remount) { |
1068 | if ((sbi->s_mount_opt & EXT3_MOUNT_DATA_FLAGS) | 1118 | if (test_opt(sb, DATA_FLAGS) == data_opt) |
1069 | == data_opt) | ||
1070 | break; | 1119 | break; |
1071 | ext3_msg(sb, KERN_ERR, | 1120 | ext3_msg(sb, KERN_ERR, |
1072 | "error: cannot change " | 1121 | "error: cannot change " |
1073 | "data mode on remount. The filesystem " | 1122 | "data mode on remount. The filesystem " |
1074 | "is mounted in data=%s mode and you " | 1123 | "is mounted in data=%s mode and you " |
1075 | "try to remount it in data=%s mode.", | 1124 | "try to remount it in data=%s mode.", |
1076 | data_mode_string(sbi->s_mount_opt & | 1125 | data_mode_string(test_opt(sb, |
1077 | EXT3_MOUNT_DATA_FLAGS), | 1126 | DATA_FLAGS)), |
1078 | data_mode_string(data_opt)); | 1127 | data_mode_string(data_opt)); |
1079 | return 0; | 1128 | return 0; |
1080 | } else { | 1129 | } else { |
1081 | sbi->s_mount_opt &= ~EXT3_MOUNT_DATA_FLAGS; | 1130 | clear_opt(sbi->s_mount_opt, DATA_FLAGS); |
1082 | sbi->s_mount_opt |= data_opt; | 1131 | sbi->s_mount_opt |= data_opt; |
1083 | } | 1132 | } |
1084 | break; | 1133 | break; |
@@ -1090,62 +1139,20 @@ static int parse_options (char *options, struct super_block *sb, | |||
1090 | break; | 1139 | break; |
1091 | #ifdef CONFIG_QUOTA | 1140 | #ifdef CONFIG_QUOTA |
1092 | case Opt_usrjquota: | 1141 | case Opt_usrjquota: |
1093 | qtype = USRQUOTA; | 1142 | if (!set_qf_name(sb, USRQUOTA, &args[0])) |
1094 | goto set_qf_name; | ||
1095 | case Opt_grpjquota: | ||
1096 | qtype = GRPQUOTA; | ||
1097 | set_qf_name: | ||
1098 | if (sb_any_quota_loaded(sb) && | ||
1099 | !sbi->s_qf_names[qtype]) { | ||
1100 | ext3_msg(sb, KERN_ERR, | ||
1101 | "error: cannot change journaled " | ||
1102 | "quota options when quota turned on."); | ||
1103 | return 0; | ||
1104 | } | ||
1105 | qname = match_strdup(&args[0]); | ||
1106 | if (!qname) { | ||
1107 | ext3_msg(sb, KERN_ERR, | ||
1108 | "error: not enough memory for " | ||
1109 | "storing quotafile name."); | ||
1110 | return 0; | 1143 | return 0; |
1111 | } | 1144 | break; |
1112 | if (sbi->s_qf_names[qtype] && | 1145 | case Opt_grpjquota: |
1113 | strcmp(sbi->s_qf_names[qtype], qname)) { | 1146 | if (!set_qf_name(sb, GRPQUOTA, &args[0])) |
1114 | ext3_msg(sb, KERN_ERR, | ||
1115 | "error: %s quota file already " | ||
1116 | "specified.", QTYPE2NAME(qtype)); | ||
1117 | kfree(qname); | ||
1118 | return 0; | ||
1119 | } | ||
1120 | sbi->s_qf_names[qtype] = qname; | ||
1121 | if (strchr(sbi->s_qf_names[qtype], '/')) { | ||
1122 | ext3_msg(sb, KERN_ERR, | ||
1123 | "error: quotafile must be on " | ||
1124 | "filesystem root."); | ||
1125 | kfree(sbi->s_qf_names[qtype]); | ||
1126 | sbi->s_qf_names[qtype] = NULL; | ||
1127 | return 0; | 1147 | return 0; |
1128 | } | ||
1129 | set_opt(sbi->s_mount_opt, QUOTA); | ||
1130 | break; | 1148 | break; |
1131 | case Opt_offusrjquota: | 1149 | case Opt_offusrjquota: |
1132 | qtype = USRQUOTA; | 1150 | if (!clear_qf_name(sb, USRQUOTA)) |
1133 | goto clear_qf_name; | 1151 | return 0; |
1152 | break; | ||
1134 | case Opt_offgrpjquota: | 1153 | case Opt_offgrpjquota: |
1135 | qtype = GRPQUOTA; | 1154 | if (!clear_qf_name(sb, GRPQUOTA)) |
1136 | clear_qf_name: | ||
1137 | if (sb_any_quota_loaded(sb) && | ||
1138 | sbi->s_qf_names[qtype]) { | ||
1139 | ext3_msg(sb, KERN_ERR, "error: cannot change " | ||
1140 | "journaled quota options when " | ||
1141 | "quota turned on."); | ||
1142 | return 0; | 1155 | return 0; |
1143 | } | ||
1144 | /* | ||
1145 | * The space will be released later when all options | ||
1146 | * are confirmed to be correct | ||
1147 | */ | ||
1148 | sbi->s_qf_names[qtype] = NULL; | ||
1149 | break; | 1156 | break; |
1150 | case Opt_jqfmt_vfsold: | 1157 | case Opt_jqfmt_vfsold: |
1151 | qfmt = QFMT_VFS_OLD; | 1158 | qfmt = QFMT_VFS_OLD; |
@@ -1244,18 +1251,12 @@ set_qf_format: | |||
1244 | } | 1251 | } |
1245 | #ifdef CONFIG_QUOTA | 1252 | #ifdef CONFIG_QUOTA |
1246 | if (sbi->s_qf_names[USRQUOTA] || sbi->s_qf_names[GRPQUOTA]) { | 1253 | if (sbi->s_qf_names[USRQUOTA] || sbi->s_qf_names[GRPQUOTA]) { |
1247 | if ((sbi->s_mount_opt & EXT3_MOUNT_USRQUOTA) && | 1254 | if (test_opt(sb, USRQUOTA) && sbi->s_qf_names[USRQUOTA]) |
1248 | sbi->s_qf_names[USRQUOTA]) | ||
1249 | clear_opt(sbi->s_mount_opt, USRQUOTA); | 1255 | clear_opt(sbi->s_mount_opt, USRQUOTA); |
1250 | 1256 | if (test_opt(sb, GRPQUOTA) && sbi->s_qf_names[GRPQUOTA]) | |
1251 | if ((sbi->s_mount_opt & EXT3_MOUNT_GRPQUOTA) && | ||
1252 | sbi->s_qf_names[GRPQUOTA]) | ||
1253 | clear_opt(sbi->s_mount_opt, GRPQUOTA); | 1257 | clear_opt(sbi->s_mount_opt, GRPQUOTA); |
1254 | 1258 | ||
1255 | if ((sbi->s_qf_names[USRQUOTA] && | 1259 | if (test_opt(sb, GRPQUOTA) || test_opt(sb, USRQUOTA)) { |
1256 | (sbi->s_mount_opt & EXT3_MOUNT_GRPQUOTA)) || | ||
1257 | (sbi->s_qf_names[GRPQUOTA] && | ||
1258 | (sbi->s_mount_opt & EXT3_MOUNT_USRQUOTA))) { | ||
1259 | ext3_msg(sb, KERN_ERR, "error: old and new quota " | 1260 | ext3_msg(sb, KERN_ERR, "error: old and new quota " |
1260 | "format mixing."); | 1261 | "format mixing."); |
1261 | return 0; | 1262 | return 0; |
@@ -1478,7 +1479,7 @@ static void ext3_orphan_cleanup (struct super_block * sb, | |||
1478 | } | 1479 | } |
1479 | 1480 | ||
1480 | list_add(&EXT3_I(inode)->i_orphan, &EXT3_SB(sb)->s_orphan); | 1481 | list_add(&EXT3_I(inode)->i_orphan, &EXT3_SB(sb)->s_orphan); |
1481 | vfs_dq_init(inode); | 1482 | dquot_initialize(inode); |
1482 | if (inode->i_nlink) { | 1483 | if (inode->i_nlink) { |
1483 | printk(KERN_DEBUG | 1484 | printk(KERN_DEBUG |
1484 | "%s: truncating inode %lu to %Ld bytes\n", | 1485 | "%s: truncating inode %lu to %Ld bytes\n", |
@@ -1671,11 +1672,11 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
1671 | set_opt(sbi->s_mount_opt, POSIX_ACL); | 1672 | set_opt(sbi->s_mount_opt, POSIX_ACL); |
1672 | #endif | 1673 | #endif |
1673 | if ((def_mount_opts & EXT3_DEFM_JMODE) == EXT3_DEFM_JMODE_DATA) | 1674 | if ((def_mount_opts & EXT3_DEFM_JMODE) == EXT3_DEFM_JMODE_DATA) |
1674 | sbi->s_mount_opt |= EXT3_MOUNT_JOURNAL_DATA; | 1675 | set_opt(sbi->s_mount_opt, JOURNAL_DATA); |
1675 | else if ((def_mount_opts & EXT3_DEFM_JMODE) == EXT3_DEFM_JMODE_ORDERED) | 1676 | else if ((def_mount_opts & EXT3_DEFM_JMODE) == EXT3_DEFM_JMODE_ORDERED) |
1676 | sbi->s_mount_opt |= EXT3_MOUNT_ORDERED_DATA; | 1677 | set_opt(sbi->s_mount_opt, ORDERED_DATA); |
1677 | else if ((def_mount_opts & EXT3_DEFM_JMODE) == EXT3_DEFM_JMODE_WBACK) | 1678 | else if ((def_mount_opts & EXT3_DEFM_JMODE) == EXT3_DEFM_JMODE_WBACK) |
1678 | sbi->s_mount_opt |= EXT3_MOUNT_WRITEBACK_DATA; | 1679 | set_opt(sbi->s_mount_opt, WRITEBACK_DATA); |
1679 | 1680 | ||
1680 | if (le16_to_cpu(sbi->s_es->s_errors) == EXT3_ERRORS_PANIC) | 1681 | if (le16_to_cpu(sbi->s_es->s_errors) == EXT3_ERRORS_PANIC) |
1681 | set_opt(sbi->s_mount_opt, ERRORS_PANIC); | 1682 | set_opt(sbi->s_mount_opt, ERRORS_PANIC); |
@@ -1694,7 +1695,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent) | |||
1694 | goto failed_mount; | 1695 | goto failed_mount; |
1695 | 1696 | ||
1696 | sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | | 1697 | sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | |
1697 | ((sbi->s_mount_opt & EXT3_MOUNT_POSIX_ACL) ? MS_POSIXACL : 0); | 1698 | (test_opt(sb, POSIX_ACL) ? MS_POSIXACL : 0); |
1698 | 1699 | ||
1699 | if (le32_to_cpu(es->s_rev_level) == EXT3_GOOD_OLD_REV && | 1700 | if (le32_to_cpu(es->s_rev_level) == EXT3_GOOD_OLD_REV && |
1700 | (EXT3_HAS_COMPAT_FEATURE(sb, ~0U) || | 1701 | (EXT3_HAS_COMPAT_FEATURE(sb, ~0U) || |
@@ -2561,11 +2562,11 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) | |||
2561 | goto restore_opts; | 2562 | goto restore_opts; |
2562 | } | 2563 | } |
2563 | 2564 | ||
2564 | if (sbi->s_mount_opt & EXT3_MOUNT_ABORT) | 2565 | if (test_opt(sb, ABORT)) |
2565 | ext3_abort(sb, __func__, "Abort forced by user"); | 2566 | ext3_abort(sb, __func__, "Abort forced by user"); |
2566 | 2567 | ||
2567 | sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | | 2568 | sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | |
2568 | ((sbi->s_mount_opt & EXT3_MOUNT_POSIX_ACL) ? MS_POSIXACL : 0); | 2569 | (test_opt(sb, POSIX_ACL) ? MS_POSIXACL : 0); |
2569 | 2570 | ||
2570 | es = sbi->s_es; | 2571 | es = sbi->s_es; |
2571 | 2572 | ||
@@ -2573,7 +2574,7 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) | |||
2573 | 2574 | ||
2574 | if ((*flags & MS_RDONLY) != (sb->s_flags & MS_RDONLY) || | 2575 | if ((*flags & MS_RDONLY) != (sb->s_flags & MS_RDONLY) || |
2575 | n_blocks_count > le32_to_cpu(es->s_blocks_count)) { | 2576 | n_blocks_count > le32_to_cpu(es->s_blocks_count)) { |
2576 | if (sbi->s_mount_opt & EXT3_MOUNT_ABORT) { | 2577 | if (test_opt(sb, ABORT)) { |
2577 | err = -EROFS; | 2578 | err = -EROFS; |
2578 | goto restore_opts; | 2579 | goto restore_opts; |
2579 | } | 2580 | } |
@@ -2734,7 +2735,7 @@ static int ext3_statfs (struct dentry * dentry, struct kstatfs * buf) | |||
2734 | * Process 1 Process 2 | 2735 | * Process 1 Process 2 |
2735 | * ext3_create() quota_sync() | 2736 | * ext3_create() quota_sync() |
2736 | * journal_start() write_dquot() | 2737 | * journal_start() write_dquot() |
2737 | * vfs_dq_init() down(dqio_mutex) | 2738 | * dquot_initialize() down(dqio_mutex) |
2738 | * down(dqio_mutex) journal_start() | 2739 | * down(dqio_mutex) journal_start() |
2739 | * | 2740 | * |
2740 | */ | 2741 | */ |
@@ -2942,9 +2943,7 @@ static ssize_t ext3_quota_write(struct super_block *sb, int type, | |||
2942 | sector_t blk = off >> EXT3_BLOCK_SIZE_BITS(sb); | 2943 | sector_t blk = off >> EXT3_BLOCK_SIZE_BITS(sb); |
2943 | int err = 0; | 2944 | int err = 0; |
2944 | int offset = off & (sb->s_blocksize - 1); | 2945 | int offset = off & (sb->s_blocksize - 1); |
2945 | int tocopy; | ||
2946 | int journal_quota = EXT3_SB(sb)->s_qf_names[type] != NULL; | 2946 | int journal_quota = EXT3_SB(sb)->s_qf_names[type] != NULL; |
2947 | size_t towrite = len; | ||
2948 | struct buffer_head *bh; | 2947 | struct buffer_head *bh; |
2949 | handle_t *handle = journal_current_handle(); | 2948 | handle_t *handle = journal_current_handle(); |
2950 | 2949 | ||
@@ -2955,53 +2954,54 @@ static ssize_t ext3_quota_write(struct super_block *sb, int type, | |||
2955 | (unsigned long long)off, (unsigned long long)len); | 2954 | (unsigned long long)off, (unsigned long long)len); |
2956 | return -EIO; | 2955 | return -EIO; |
2957 | } | 2956 | } |
2957 | |||
2958 | /* | ||
2959 | * Since we account only one data block in transaction credits, | ||
2960 | * then it is impossible to cross a block boundary. | ||
2961 | */ | ||
2962 | if (sb->s_blocksize - offset < len) { | ||
2963 | ext3_msg(sb, KERN_WARNING, "Quota write (off=%llu, len=%llu)" | ||
2964 | " cancelled because not block aligned", | ||
2965 | (unsigned long long)off, (unsigned long long)len); | ||
2966 | return -EIO; | ||
2967 | } | ||
2958 | mutex_lock_nested(&inode->i_mutex, I_MUTEX_QUOTA); | 2968 | mutex_lock_nested(&inode->i_mutex, I_MUTEX_QUOTA); |
2959 | while (towrite > 0) { | 2969 | bh = ext3_bread(handle, inode, blk, 1, &err); |
2960 | tocopy = sb->s_blocksize - offset < towrite ? | 2970 | if (!bh) |
2961 | sb->s_blocksize - offset : towrite; | 2971 | goto out; |
2962 | bh = ext3_bread(handle, inode, blk, 1, &err); | 2972 | if (journal_quota) { |
2963 | if (!bh) | 2973 | err = ext3_journal_get_write_access(handle, bh); |
2974 | if (err) { | ||
2975 | brelse(bh); | ||
2964 | goto out; | 2976 | goto out; |
2965 | if (journal_quota) { | ||
2966 | err = ext3_journal_get_write_access(handle, bh); | ||
2967 | if (err) { | ||
2968 | brelse(bh); | ||
2969 | goto out; | ||
2970 | } | ||
2971 | } | ||
2972 | lock_buffer(bh); | ||
2973 | memcpy(bh->b_data+offset, data, tocopy); | ||
2974 | flush_dcache_page(bh->b_page); | ||
2975 | unlock_buffer(bh); | ||
2976 | if (journal_quota) | ||
2977 | err = ext3_journal_dirty_metadata(handle, bh); | ||
2978 | else { | ||
2979 | /* Always do at least ordered writes for quotas */ | ||
2980 | err = ext3_journal_dirty_data(handle, bh); | ||
2981 | mark_buffer_dirty(bh); | ||
2982 | } | 2977 | } |
2983 | brelse(bh); | ||
2984 | if (err) | ||
2985 | goto out; | ||
2986 | offset = 0; | ||
2987 | towrite -= tocopy; | ||
2988 | data += tocopy; | ||
2989 | blk++; | ||
2990 | } | 2978 | } |
2979 | lock_buffer(bh); | ||
2980 | memcpy(bh->b_data+offset, data, len); | ||
2981 | flush_dcache_page(bh->b_page); | ||
2982 | unlock_buffer(bh); | ||
2983 | if (journal_quota) | ||
2984 | err = ext3_journal_dirty_metadata(handle, bh); | ||
2985 | else { | ||
2986 | /* Always do at least ordered writes for quotas */ | ||
2987 | err = ext3_journal_dirty_data(handle, bh); | ||
2988 | mark_buffer_dirty(bh); | ||
2989 | } | ||
2990 | brelse(bh); | ||
2991 | out: | 2991 | out: |
2992 | if (len == towrite) { | 2992 | if (err) { |
2993 | mutex_unlock(&inode->i_mutex); | 2993 | mutex_unlock(&inode->i_mutex); |
2994 | return err; | 2994 | return err; |
2995 | } | 2995 | } |
2996 | if (inode->i_size < off+len-towrite) { | 2996 | if (inode->i_size < off + len) { |
2997 | i_size_write(inode, off+len-towrite); | 2997 | i_size_write(inode, off + len); |
2998 | EXT3_I(inode)->i_disksize = inode->i_size; | 2998 | EXT3_I(inode)->i_disksize = inode->i_size; |
2999 | } | 2999 | } |
3000 | inode->i_version++; | 3000 | inode->i_version++; |
3001 | inode->i_mtime = inode->i_ctime = CURRENT_TIME; | 3001 | inode->i_mtime = inode->i_ctime = CURRENT_TIME; |
3002 | ext3_mark_inode_dirty(handle, inode); | 3002 | ext3_mark_inode_dirty(handle, inode); |
3003 | mutex_unlock(&inode->i_mutex); | 3003 | mutex_unlock(&inode->i_mutex); |
3004 | return len - towrite; | 3004 | return len; |
3005 | } | 3005 | } |
3006 | 3006 | ||
3007 | #endif | 3007 | #endif |
diff --git a/fs/ext3/xattr.c b/fs/ext3/xattr.c index 66895ccf76c7..534a94c3a933 100644 --- a/fs/ext3/xattr.c +++ b/fs/ext3/xattr.c | |||
@@ -274,7 +274,7 @@ ext3_xattr_ibody_get(struct inode *inode, int name_index, const char *name, | |||
274 | void *end; | 274 | void *end; |
275 | int error; | 275 | int error; |
276 | 276 | ||
277 | if (!(EXT3_I(inode)->i_state & EXT3_STATE_XATTR)) | 277 | if (!ext3_test_inode_state(inode, EXT3_STATE_XATTR)) |
278 | return -ENODATA; | 278 | return -ENODATA; |
279 | error = ext3_get_inode_loc(inode, &iloc); | 279 | error = ext3_get_inode_loc(inode, &iloc); |
280 | if (error) | 280 | if (error) |
@@ -403,7 +403,7 @@ ext3_xattr_ibody_list(struct dentry *dentry, char *buffer, size_t buffer_size) | |||
403 | void *end; | 403 | void *end; |
404 | int error; | 404 | int error; |
405 | 405 | ||
406 | if (!(EXT3_I(inode)->i_state & EXT3_STATE_XATTR)) | 406 | if (!ext3_test_inode_state(inode, EXT3_STATE_XATTR)) |
407 | return 0; | 407 | return 0; |
408 | error = ext3_get_inode_loc(inode, &iloc); | 408 | error = ext3_get_inode_loc(inode, &iloc); |
409 | if (error) | 409 | if (error) |
@@ -500,7 +500,7 @@ ext3_xattr_release_block(handle_t *handle, struct inode *inode, | |||
500 | error = ext3_journal_dirty_metadata(handle, bh); | 500 | error = ext3_journal_dirty_metadata(handle, bh); |
501 | if (IS_SYNC(inode)) | 501 | if (IS_SYNC(inode)) |
502 | handle->h_sync = 1; | 502 | handle->h_sync = 1; |
503 | vfs_dq_free_block(inode, 1); | 503 | dquot_free_block(inode, 1); |
504 | ea_bdebug(bh, "refcount now=%d; releasing", | 504 | ea_bdebug(bh, "refcount now=%d; releasing", |
505 | le32_to_cpu(BHDR(bh)->h_refcount)); | 505 | le32_to_cpu(BHDR(bh)->h_refcount)); |
506 | if (ce) | 506 | if (ce) |
@@ -775,8 +775,8 @@ inserted: | |||
775 | else { | 775 | else { |
776 | /* The old block is released after updating | 776 | /* The old block is released after updating |
777 | the inode. */ | 777 | the inode. */ |
778 | error = -EDQUOT; | 778 | error = dquot_alloc_block(inode, 1); |
779 | if (vfs_dq_alloc_block(inode, 1)) | 779 | if (error) |
780 | goto cleanup; | 780 | goto cleanup; |
781 | error = ext3_journal_get_write_access(handle, | 781 | error = ext3_journal_get_write_access(handle, |
782 | new_bh); | 782 | new_bh); |
@@ -850,7 +850,7 @@ cleanup: | |||
850 | return error; | 850 | return error; |
851 | 851 | ||
852 | cleanup_dquot: | 852 | cleanup_dquot: |
853 | vfs_dq_free_block(inode, 1); | 853 | dquot_free_block(inode, 1); |
854 | goto cleanup; | 854 | goto cleanup; |
855 | 855 | ||
856 | bad_block: | 856 | bad_block: |
@@ -882,7 +882,7 @@ ext3_xattr_ibody_find(struct inode *inode, struct ext3_xattr_info *i, | |||
882 | is->s.base = is->s.first = IFIRST(header); | 882 | is->s.base = is->s.first = IFIRST(header); |
883 | is->s.here = is->s.first; | 883 | is->s.here = is->s.first; |
884 | is->s.end = (void *)raw_inode + EXT3_SB(inode->i_sb)->s_inode_size; | 884 | is->s.end = (void *)raw_inode + EXT3_SB(inode->i_sb)->s_inode_size; |
885 | if (EXT3_I(inode)->i_state & EXT3_STATE_XATTR) { | 885 | if (ext3_test_inode_state(inode, EXT3_STATE_XATTR)) { |
886 | error = ext3_xattr_check_names(IFIRST(header), is->s.end); | 886 | error = ext3_xattr_check_names(IFIRST(header), is->s.end); |
887 | if (error) | 887 | if (error) |
888 | return error; | 888 | return error; |
@@ -914,10 +914,10 @@ ext3_xattr_ibody_set(handle_t *handle, struct inode *inode, | |||
914 | header = IHDR(inode, ext3_raw_inode(&is->iloc)); | 914 | header = IHDR(inode, ext3_raw_inode(&is->iloc)); |
915 | if (!IS_LAST_ENTRY(s->first)) { | 915 | if (!IS_LAST_ENTRY(s->first)) { |
916 | header->h_magic = cpu_to_le32(EXT3_XATTR_MAGIC); | 916 | header->h_magic = cpu_to_le32(EXT3_XATTR_MAGIC); |
917 | EXT3_I(inode)->i_state |= EXT3_STATE_XATTR; | 917 | ext3_set_inode_state(inode, EXT3_STATE_XATTR); |
918 | } else { | 918 | } else { |
919 | header->h_magic = cpu_to_le32(0); | 919 | header->h_magic = cpu_to_le32(0); |
920 | EXT3_I(inode)->i_state &= ~EXT3_STATE_XATTR; | 920 | ext3_clear_inode_state(inode, EXT3_STATE_XATTR); |
921 | } | 921 | } |
922 | return 0; | 922 | return 0; |
923 | } | 923 | } |
@@ -967,10 +967,10 @@ ext3_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index, | |||
967 | if (error) | 967 | if (error) |
968 | goto cleanup; | 968 | goto cleanup; |
969 | 969 | ||
970 | if (EXT3_I(inode)->i_state & EXT3_STATE_NEW) { | 970 | if (ext3_test_inode_state(inode, EXT3_STATE_NEW)) { |
971 | struct ext3_inode *raw_inode = ext3_raw_inode(&is.iloc); | 971 | struct ext3_inode *raw_inode = ext3_raw_inode(&is.iloc); |
972 | memset(raw_inode, 0, EXT3_SB(inode->i_sb)->s_inode_size); | 972 | memset(raw_inode, 0, EXT3_SB(inode->i_sb)->s_inode_size); |
973 | EXT3_I(inode)->i_state &= ~EXT3_STATE_NEW; | 973 | ext3_clear_inode_state(inode, EXT3_STATE_NEW); |
974 | } | 974 | } |
975 | 975 | ||
976 | error = ext3_xattr_ibody_find(inode, &i, &is); | 976 | error = ext3_xattr_ibody_find(inode, &i, &is); |
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c index 22bc7435d913..d2f37a5516c7 100644 --- a/fs/ext4/balloc.c +++ b/fs/ext4/balloc.c | |||
@@ -97,8 +97,8 @@ unsigned ext4_init_block_bitmap(struct super_block *sb, struct buffer_head *bh, | |||
97 | /* If checksum is bad mark all blocks used to prevent allocation | 97 | /* If checksum is bad mark all blocks used to prevent allocation |
98 | * essentially implementing a per-group read-only flag. */ | 98 | * essentially implementing a per-group read-only flag. */ |
99 | if (!ext4_group_desc_csum_verify(sbi, block_group, gdp)) { | 99 | if (!ext4_group_desc_csum_verify(sbi, block_group, gdp)) { |
100 | ext4_error(sb, __func__, | 100 | ext4_error(sb, "Checksum bad for group %u", |
101 | "Checksum bad for group %u", block_group); | 101 | block_group); |
102 | ext4_free_blks_set(sb, gdp, 0); | 102 | ext4_free_blks_set(sb, gdp, 0); |
103 | ext4_free_inodes_set(sb, gdp, 0); | 103 | ext4_free_inodes_set(sb, gdp, 0); |
104 | ext4_itable_unused_set(sb, gdp, 0); | 104 | ext4_itable_unused_set(sb, gdp, 0); |
@@ -130,8 +130,7 @@ unsigned ext4_init_block_bitmap(struct super_block *sb, struct buffer_head *bh, | |||
130 | * to make sure we calculate the right free blocks | 130 | * to make sure we calculate the right free blocks |
131 | */ | 131 | */ |
132 | group_blocks = ext4_blocks_count(sbi->s_es) - | 132 | group_blocks = ext4_blocks_count(sbi->s_es) - |
133 | le32_to_cpu(sbi->s_es->s_first_data_block) - | 133 | ext4_group_first_block_no(sb, ngroups - 1); |
134 | (EXT4_BLOCKS_PER_GROUP(sb) * (ngroups - 1)); | ||
135 | } else { | 134 | } else { |
136 | group_blocks = EXT4_BLOCKS_PER_GROUP(sb); | 135 | group_blocks = EXT4_BLOCKS_PER_GROUP(sb); |
137 | } | 136 | } |
@@ -189,9 +188,6 @@ unsigned ext4_init_block_bitmap(struct super_block *sb, struct buffer_head *bh, | |||
189 | * when a file system is mounted (see ext4_fill_super). | 188 | * when a file system is mounted (see ext4_fill_super). |
190 | */ | 189 | */ |
191 | 190 | ||
192 | |||
193 | #define in_range(b, first, len) ((b) >= (first) && (b) <= (first) + (len) - 1) | ||
194 | |||
195 | /** | 191 | /** |
196 | * ext4_get_group_desc() -- load group descriptor from disk | 192 | * ext4_get_group_desc() -- load group descriptor from disk |
197 | * @sb: super block | 193 | * @sb: super block |
@@ -210,10 +206,8 @@ struct ext4_group_desc * ext4_get_group_desc(struct super_block *sb, | |||
210 | struct ext4_sb_info *sbi = EXT4_SB(sb); | 206 | struct ext4_sb_info *sbi = EXT4_SB(sb); |
211 | 207 | ||
212 | if (block_group >= ngroups) { | 208 | if (block_group >= ngroups) { |
213 | ext4_error(sb, "ext4_get_group_desc", | 209 | ext4_error(sb, "block_group >= groups_count - block_group = %u," |
214 | "block_group >= groups_count - " | 210 | " groups_count = %u", block_group, ngroups); |
215 | "block_group = %u, groups_count = %u", | ||
216 | block_group, ngroups); | ||
217 | 211 | ||
218 | return NULL; | 212 | return NULL; |
219 | } | 213 | } |
@@ -221,8 +215,7 @@ struct ext4_group_desc * ext4_get_group_desc(struct super_block *sb, | |||
221 | group_desc = block_group >> EXT4_DESC_PER_BLOCK_BITS(sb); | 215 | group_desc = block_group >> EXT4_DESC_PER_BLOCK_BITS(sb); |
222 | offset = block_group & (EXT4_DESC_PER_BLOCK(sb) - 1); | 216 | offset = block_group & (EXT4_DESC_PER_BLOCK(sb) - 1); |
223 | if (!sbi->s_group_desc[group_desc]) { | 217 | if (!sbi->s_group_desc[group_desc]) { |
224 | ext4_error(sb, "ext4_get_group_desc", | 218 | ext4_error(sb, "Group descriptor not loaded - " |
225 | "Group descriptor not loaded - " | ||
226 | "block_group = %u, group_desc = %u, desc = %u", | 219 | "block_group = %u, group_desc = %u, desc = %u", |
227 | block_group, group_desc, offset); | 220 | block_group, group_desc, offset); |
228 | return NULL; | 221 | return NULL; |
@@ -282,9 +275,7 @@ static int ext4_valid_block_bitmap(struct super_block *sb, | |||
282 | return 1; | 275 | return 1; |
283 | 276 | ||
284 | err_out: | 277 | err_out: |
285 | ext4_error(sb, __func__, | 278 | ext4_error(sb, "Invalid block bitmap - block_group = %d, block = %llu", |
286 | "Invalid block bitmap - " | ||
287 | "block_group = %d, block = %llu", | ||
288 | block_group, bitmap_blk); | 279 | block_group, bitmap_blk); |
289 | return 0; | 280 | return 0; |
290 | } | 281 | } |
@@ -311,8 +302,7 @@ ext4_read_block_bitmap(struct super_block *sb, ext4_group_t block_group) | |||
311 | bitmap_blk = ext4_block_bitmap(sb, desc); | 302 | bitmap_blk = ext4_block_bitmap(sb, desc); |
312 | bh = sb_getblk(sb, bitmap_blk); | 303 | bh = sb_getblk(sb, bitmap_blk); |
313 | if (unlikely(!bh)) { | 304 | if (unlikely(!bh)) { |
314 | ext4_error(sb, __func__, | 305 | ext4_error(sb, "Cannot read block bitmap - " |
315 | "Cannot read block bitmap - " | ||
316 | "block_group = %u, block_bitmap = %llu", | 306 | "block_group = %u, block_bitmap = %llu", |
317 | block_group, bitmap_blk); | 307 | block_group, bitmap_blk); |
318 | return NULL; | 308 | return NULL; |
@@ -354,8 +344,7 @@ ext4_read_block_bitmap(struct super_block *sb, ext4_group_t block_group) | |||
354 | set_bitmap_uptodate(bh); | 344 | set_bitmap_uptodate(bh); |
355 | if (bh_submit_read(bh) < 0) { | 345 | if (bh_submit_read(bh) < 0) { |
356 | put_bh(bh); | 346 | put_bh(bh); |
357 | ext4_error(sb, __func__, | 347 | ext4_error(sb, "Cannot read block bitmap - " |
358 | "Cannot read block bitmap - " | ||
359 | "block_group = %u, block_bitmap = %llu", | 348 | "block_group = %u, block_bitmap = %llu", |
360 | block_group, bitmap_blk); | 349 | block_group, bitmap_blk); |
361 | return NULL; | 350 | return NULL; |
@@ -419,8 +408,7 @@ void ext4_add_groupblocks(handle_t *handle, struct super_block *sb, | |||
419 | in_range(block, ext4_inode_table(sb, desc), sbi->s_itb_per_group) || | 408 | in_range(block, ext4_inode_table(sb, desc), sbi->s_itb_per_group) || |
420 | in_range(block + count - 1, ext4_inode_table(sb, desc), | 409 | in_range(block + count - 1, ext4_inode_table(sb, desc), |
421 | sbi->s_itb_per_group)) { | 410 | sbi->s_itb_per_group)) { |
422 | ext4_error(sb, __func__, | 411 | ext4_error(sb, "Adding blocks in system zones - " |
423 | "Adding blocks in system zones - " | ||
424 | "Block = %llu, count = %lu", | 412 | "Block = %llu, count = %lu", |
425 | block, count); | 413 | block, count); |
426 | goto error_return; | 414 | goto error_return; |
@@ -453,8 +441,7 @@ void ext4_add_groupblocks(handle_t *handle, struct super_block *sb, | |||
453 | BUFFER_TRACE(bitmap_bh, "clear bit"); | 441 | BUFFER_TRACE(bitmap_bh, "clear bit"); |
454 | if (!ext4_clear_bit_atomic(ext4_group_lock_ptr(sb, block_group), | 442 | if (!ext4_clear_bit_atomic(ext4_group_lock_ptr(sb, block_group), |
455 | bit + i, bitmap_bh->b_data)) { | 443 | bit + i, bitmap_bh->b_data)) { |
456 | ext4_error(sb, __func__, | 444 | ext4_error(sb, "bit already cleared for block %llu", |
457 | "bit already cleared for block %llu", | ||
458 | (ext4_fsblk_t)(block + i)); | 445 | (ext4_fsblk_t)(block + i)); |
459 | BUFFER_TRACE(bitmap_bh, "bit already cleared"); | 446 | BUFFER_TRACE(bitmap_bh, "bit already cleared"); |
460 | } else { | 447 | } else { |
diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c index a60ab9aad57d..983f0e127493 100644 --- a/fs/ext4/block_validity.c +++ b/fs/ext4/block_validity.c | |||
@@ -205,14 +205,14 @@ void ext4_release_system_zone(struct super_block *sb) | |||
205 | entry = rb_entry(n, struct ext4_system_zone, node); | 205 | entry = rb_entry(n, struct ext4_system_zone, node); |
206 | kmem_cache_free(ext4_system_zone_cachep, entry); | 206 | kmem_cache_free(ext4_system_zone_cachep, entry); |
207 | if (!parent) | 207 | if (!parent) |
208 | EXT4_SB(sb)->system_blks.rb_node = NULL; | 208 | EXT4_SB(sb)->system_blks = RB_ROOT; |
209 | else if (parent->rb_left == n) | 209 | else if (parent->rb_left == n) |
210 | parent->rb_left = NULL; | 210 | parent->rb_left = NULL; |
211 | else if (parent->rb_right == n) | 211 | else if (parent->rb_right == n) |
212 | parent->rb_right = NULL; | 212 | parent->rb_right = NULL; |
213 | n = parent; | 213 | n = parent; |
214 | } | 214 | } |
215 | EXT4_SB(sb)->system_blks.rb_node = NULL; | 215 | EXT4_SB(sb)->system_blks = RB_ROOT; |
216 | } | 216 | } |
217 | 217 | ||
218 | /* | 218 | /* |
diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c index 9dc93168e262..86cb6d86a048 100644 --- a/fs/ext4/dir.c +++ b/fs/ext4/dir.c | |||
@@ -83,10 +83,12 @@ int ext4_check_dir_entry(const char *function, struct inode *dir, | |||
83 | error_msg = "inode out of bounds"; | 83 | error_msg = "inode out of bounds"; |
84 | 84 | ||
85 | if (error_msg != NULL) | 85 | if (error_msg != NULL) |
86 | ext4_error(dir->i_sb, function, | 86 | __ext4_error(dir->i_sb, function, |
87 | "bad entry in directory #%lu: %s - " | 87 | "bad entry in directory #%lu: %s - block=%llu" |
88 | "offset=%u, inode=%u, rec_len=%d, name_len=%d", | 88 | "offset=%u(%u), inode=%u, rec_len=%d, name_len=%d", |
89 | dir->i_ino, error_msg, offset, | 89 | dir->i_ino, error_msg, |
90 | (unsigned long long) bh->b_blocknr, | ||
91 | (unsigned) (offset%bh->b_size), offset, | ||
90 | le32_to_cpu(de->inode), | 92 | le32_to_cpu(de->inode), |
91 | rlen, de->name_len); | 93 | rlen, de->name_len); |
92 | return error_msg == NULL ? 1 : 0; | 94 | return error_msg == NULL ? 1 : 0; |
@@ -150,7 +152,7 @@ static int ext4_readdir(struct file *filp, | |||
150 | */ | 152 | */ |
151 | if (!bh) { | 153 | if (!bh) { |
152 | if (!dir_has_error) { | 154 | if (!dir_has_error) { |
153 | ext4_error(sb, __func__, "directory #%lu " | 155 | ext4_error(sb, "directory #%lu " |
154 | "contains a hole at offset %Lu", | 156 | "contains a hole at offset %Lu", |
155 | inode->i_ino, | 157 | inode->i_ino, |
156 | (unsigned long long) filp->f_pos); | 158 | (unsigned long long) filp->f_pos); |
@@ -303,7 +305,7 @@ static void free_rb_tree_fname(struct rb_root *root) | |||
303 | kfree(old); | 305 | kfree(old); |
304 | } | 306 | } |
305 | if (!parent) | 307 | if (!parent) |
306 | root->rb_node = NULL; | 308 | *root = RB_ROOT; |
307 | else if (parent->rb_left == n) | 309 | else if (parent->rb_left == n) |
308 | parent->rb_left = NULL; | 310 | parent->rb_left = NULL; |
309 | else if (parent->rb_right == n) | 311 | else if (parent->rb_right == n) |
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 874d169a193e..bf938cf7c5f0 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h | |||
@@ -53,6 +53,12 @@ | |||
53 | #define ext4_debug(f, a...) do {} while (0) | 53 | #define ext4_debug(f, a...) do {} while (0) |
54 | #endif | 54 | #endif |
55 | 55 | ||
56 | #define EXT4_ERROR_INODE(inode, fmt, a...) \ | ||
57 | ext4_error_inode(__func__, (inode), (fmt), ## a); | ||
58 | |||
59 | #define EXT4_ERROR_FILE(file, fmt, a...) \ | ||
60 | ext4_error_file(__func__, (file), (fmt), ## a); | ||
61 | |||
56 | /* data type for block offset of block group */ | 62 | /* data type for block offset of block group */ |
57 | typedef int ext4_grpblk_t; | 63 | typedef int ext4_grpblk_t; |
58 | 64 | ||
@@ -133,14 +139,14 @@ struct mpage_da_data { | |||
133 | int pages_written; | 139 | int pages_written; |
134 | int retval; | 140 | int retval; |
135 | }; | 141 | }; |
136 | #define DIO_AIO_UNWRITTEN 0x1 | 142 | #define EXT4_IO_UNWRITTEN 0x1 |
137 | typedef struct ext4_io_end { | 143 | typedef struct ext4_io_end { |
138 | struct list_head list; /* per-file finished AIO list */ | 144 | struct list_head list; /* per-file finished AIO list */ |
139 | struct inode *inode; /* file being written to */ | 145 | struct inode *inode; /* file being written to */ |
140 | unsigned int flag; /* unwritten or not */ | 146 | unsigned int flag; /* unwritten or not */ |
141 | int error; /* I/O error code */ | 147 | struct page *page; /* page struct for buffer write */ |
142 | ext4_lblk_t offset; /* offset in the file */ | 148 | loff_t offset; /* offset in the file */ |
143 | size_t size; /* size of the extent */ | 149 | ssize_t size; /* size of the extent */ |
144 | struct work_struct work; /* data work queue */ | 150 | struct work_struct work; /* data work queue */ |
145 | } ext4_io_end_t; | 151 | } ext4_io_end_t; |
146 | 152 | ||
@@ -284,10 +290,12 @@ struct flex_groups { | |||
284 | #define EXT4_TOPDIR_FL 0x00020000 /* Top of directory hierarchies*/ | 290 | #define EXT4_TOPDIR_FL 0x00020000 /* Top of directory hierarchies*/ |
285 | #define EXT4_HUGE_FILE_FL 0x00040000 /* Set to each huge file */ | 291 | #define EXT4_HUGE_FILE_FL 0x00040000 /* Set to each huge file */ |
286 | #define EXT4_EXTENTS_FL 0x00080000 /* Inode uses extents */ | 292 | #define EXT4_EXTENTS_FL 0x00080000 /* Inode uses extents */ |
293 | #define EXT4_EA_INODE_FL 0x00200000 /* Inode used for large EA */ | ||
294 | #define EXT4_EOFBLOCKS_FL 0x00400000 /* Blocks allocated beyond EOF */ | ||
287 | #define EXT4_RESERVED_FL 0x80000000 /* reserved for ext4 lib */ | 295 | #define EXT4_RESERVED_FL 0x80000000 /* reserved for ext4 lib */ |
288 | 296 | ||
289 | #define EXT4_FL_USER_VISIBLE 0x000BDFFF /* User visible flags */ | 297 | #define EXT4_FL_USER_VISIBLE 0x004BDFFF /* User visible flags */ |
290 | #define EXT4_FL_USER_MODIFIABLE 0x000B80FF /* User modifiable flags */ | 298 | #define EXT4_FL_USER_MODIFIABLE 0x004B80FF /* User modifiable flags */ |
291 | 299 | ||
292 | /* Flags that should be inherited by new inodes from their parent. */ | 300 | /* Flags that should be inherited by new inodes from their parent. */ |
293 | #define EXT4_FL_INHERITED (EXT4_SECRM_FL | EXT4_UNRM_FL | EXT4_COMPR_FL |\ | 301 | #define EXT4_FL_INHERITED (EXT4_SECRM_FL | EXT4_UNRM_FL | EXT4_COMPR_FL |\ |
@@ -313,17 +321,6 @@ static inline __u32 ext4_mask_flags(umode_t mode, __u32 flags) | |||
313 | return flags & EXT4_OTHER_FLMASK; | 321 | return flags & EXT4_OTHER_FLMASK; |
314 | } | 322 | } |
315 | 323 | ||
316 | /* | ||
317 | * Inode dynamic state flags | ||
318 | */ | ||
319 | #define EXT4_STATE_JDATA 0x00000001 /* journaled data exists */ | ||
320 | #define EXT4_STATE_NEW 0x00000002 /* inode is newly created */ | ||
321 | #define EXT4_STATE_XATTR 0x00000004 /* has in-inode xattrs */ | ||
322 | #define EXT4_STATE_NO_EXPAND 0x00000008 /* No space for expansion */ | ||
323 | #define EXT4_STATE_DA_ALLOC_CLOSE 0x00000010 /* Alloc DA blks on close */ | ||
324 | #define EXT4_STATE_EXT_MIGRATE 0x00000020 /* Inode is migrating */ | ||
325 | #define EXT4_STATE_DIO_UNWRITTEN 0x00000040 /* need convert on dio done*/ | ||
326 | |||
327 | /* Used to pass group descriptor data when online resize is done */ | 324 | /* Used to pass group descriptor data when online resize is done */ |
328 | struct ext4_new_group_input { | 325 | struct ext4_new_group_input { |
329 | __u32 group; /* Group number for this data */ | 326 | __u32 group; /* Group number for this data */ |
@@ -364,19 +361,20 @@ struct ext4_new_group_data { | |||
364 | /* caller is from the direct IO path, request to creation of an | 361 | /* caller is from the direct IO path, request to creation of an |
365 | unitialized extents if not allocated, split the uninitialized | 362 | unitialized extents if not allocated, split the uninitialized |
366 | extent if blocks has been preallocated already*/ | 363 | extent if blocks has been preallocated already*/ |
367 | #define EXT4_GET_BLOCKS_DIO 0x0008 | 364 | #define EXT4_GET_BLOCKS_PRE_IO 0x0008 |
368 | #define EXT4_GET_BLOCKS_CONVERT 0x0010 | 365 | #define EXT4_GET_BLOCKS_CONVERT 0x0010 |
369 | #define EXT4_GET_BLOCKS_DIO_CREATE_EXT (EXT4_GET_BLOCKS_DIO|\ | 366 | #define EXT4_GET_BLOCKS_IO_CREATE_EXT (EXT4_GET_BLOCKS_PRE_IO|\ |
367 | EXT4_GET_BLOCKS_CREATE_UNINIT_EXT) | ||
368 | /* Convert extent to initialized after IO complete */ | ||
369 | #define EXT4_GET_BLOCKS_IO_CONVERT_EXT (EXT4_GET_BLOCKS_CONVERT|\ | ||
370 | EXT4_GET_BLOCKS_CREATE_UNINIT_EXT) | 370 | EXT4_GET_BLOCKS_CREATE_UNINIT_EXT) |
371 | /* Convert extent to initialized after direct IO complete */ | ||
372 | #define EXT4_GET_BLOCKS_DIO_CONVERT_EXT (EXT4_GET_BLOCKS_CONVERT|\ | ||
373 | EXT4_GET_BLOCKS_DIO_CREATE_EXT) | ||
374 | 371 | ||
375 | /* | 372 | /* |
376 | * Flags used by ext4_free_blocks | 373 | * Flags used by ext4_free_blocks |
377 | */ | 374 | */ |
378 | #define EXT4_FREE_BLOCKS_METADATA 0x0001 | 375 | #define EXT4_FREE_BLOCKS_METADATA 0x0001 |
379 | #define EXT4_FREE_BLOCKS_FORGET 0x0002 | 376 | #define EXT4_FREE_BLOCKS_FORGET 0x0002 |
377 | #define EXT4_FREE_BLOCKS_VALIDATED 0x0004 | ||
380 | 378 | ||
381 | /* | 379 | /* |
382 | * ioctl commands | 380 | * ioctl commands |
@@ -630,7 +628,7 @@ struct ext4_inode_info { | |||
630 | * near to their parent directory's inode. | 628 | * near to their parent directory's inode. |
631 | */ | 629 | */ |
632 | ext4_group_t i_block_group; | 630 | ext4_group_t i_block_group; |
633 | __u32 i_state; /* Dynamic state flags for ext4 */ | 631 | unsigned long i_state_flags; /* Dynamic state flags */ |
634 | 632 | ||
635 | ext4_lblk_t i_dir_start_lookup; | 633 | ext4_lblk_t i_dir_start_lookup; |
636 | #ifdef CONFIG_EXT4_FS_XATTR | 634 | #ifdef CONFIG_EXT4_FS_XATTR |
@@ -708,8 +706,9 @@ struct ext4_inode_info { | |||
708 | qsize_t i_reserved_quota; | 706 | qsize_t i_reserved_quota; |
709 | #endif | 707 | #endif |
710 | 708 | ||
711 | /* completed async DIOs that might need unwritten extents handling */ | 709 | /* completed IOs that might need unwritten extents handling */ |
712 | struct list_head i_aio_dio_complete_list; | 710 | struct list_head i_completed_io_list; |
711 | spinlock_t i_completed_io_lock; | ||
713 | /* current io_end structure for async DIO write*/ | 712 | /* current io_end structure for async DIO write*/ |
714 | ext4_io_end_t *cur_aio_dio; | 713 | ext4_io_end_t *cur_aio_dio; |
715 | 714 | ||
@@ -760,6 +759,7 @@ struct ext4_inode_info { | |||
760 | #define EXT4_MOUNT_QUOTA 0x80000 /* Some quota option set */ | 759 | #define EXT4_MOUNT_QUOTA 0x80000 /* Some quota option set */ |
761 | #define EXT4_MOUNT_USRQUOTA 0x100000 /* "old" user quota */ | 760 | #define EXT4_MOUNT_USRQUOTA 0x100000 /* "old" user quota */ |
762 | #define EXT4_MOUNT_GRPQUOTA 0x200000 /* "old" group quota */ | 761 | #define EXT4_MOUNT_GRPQUOTA 0x200000 /* "old" group quota */ |
762 | #define EXT4_MOUNT_DIOREAD_NOLOCK 0x400000 /* Enable support for dio read nolocking */ | ||
763 | #define EXT4_MOUNT_JOURNAL_CHECKSUM 0x800000 /* Journal checksums */ | 763 | #define EXT4_MOUNT_JOURNAL_CHECKSUM 0x800000 /* Journal checksums */ |
764 | #define EXT4_MOUNT_JOURNAL_ASYNC_COMMIT 0x1000000 /* Journal Async Commit */ | 764 | #define EXT4_MOUNT_JOURNAL_ASYNC_COMMIT 0x1000000 /* Journal Async Commit */ |
765 | #define EXT4_MOUNT_I_VERSION 0x2000000 /* i_version support */ | 765 | #define EXT4_MOUNT_I_VERSION 0x2000000 /* i_version support */ |
@@ -1014,7 +1014,7 @@ struct ext4_sb_info { | |||
1014 | atomic_t s_lock_busy; | 1014 | atomic_t s_lock_busy; |
1015 | 1015 | ||
1016 | /* locality groups */ | 1016 | /* locality groups */ |
1017 | struct ext4_locality_group *s_locality_groups; | 1017 | struct ext4_locality_group __percpu *s_locality_groups; |
1018 | 1018 | ||
1019 | /* for write statistics */ | 1019 | /* for write statistics */ |
1020 | unsigned long s_sectors_written_start; | 1020 | unsigned long s_sectors_written_start; |
@@ -1050,6 +1050,34 @@ static inline int ext4_valid_inum(struct super_block *sb, unsigned long ino) | |||
1050 | (ino >= EXT4_FIRST_INO(sb) && | 1050 | (ino >= EXT4_FIRST_INO(sb) && |
1051 | ino <= le32_to_cpu(EXT4_SB(sb)->s_es->s_inodes_count)); | 1051 | ino <= le32_to_cpu(EXT4_SB(sb)->s_es->s_inodes_count)); |
1052 | } | 1052 | } |
1053 | |||
1054 | /* | ||
1055 | * Inode dynamic state flags | ||
1056 | */ | ||
1057 | enum { | ||
1058 | EXT4_STATE_JDATA, /* journaled data exists */ | ||
1059 | EXT4_STATE_NEW, /* inode is newly created */ | ||
1060 | EXT4_STATE_XATTR, /* has in-inode xattrs */ | ||
1061 | EXT4_STATE_NO_EXPAND, /* No space for expansion */ | ||
1062 | EXT4_STATE_DA_ALLOC_CLOSE, /* Alloc DA blks on close */ | ||
1063 | EXT4_STATE_EXT_MIGRATE, /* Inode is migrating */ | ||
1064 | EXT4_STATE_DIO_UNWRITTEN, /* need convert on dio done*/ | ||
1065 | }; | ||
1066 | |||
1067 | static inline int ext4_test_inode_state(struct inode *inode, int bit) | ||
1068 | { | ||
1069 | return test_bit(bit, &EXT4_I(inode)->i_state_flags); | ||
1070 | } | ||
1071 | |||
1072 | static inline void ext4_set_inode_state(struct inode *inode, int bit) | ||
1073 | { | ||
1074 | set_bit(bit, &EXT4_I(inode)->i_state_flags); | ||
1075 | } | ||
1076 | |||
1077 | static inline void ext4_clear_inode_state(struct inode *inode, int bit) | ||
1078 | { | ||
1079 | clear_bit(bit, &EXT4_I(inode)->i_state_flags); | ||
1080 | } | ||
1053 | #else | 1081 | #else |
1054 | /* Assume that user mode programs are passing in an ext4fs superblock, not | 1082 | /* Assume that user mode programs are passing in an ext4fs superblock, not |
1055 | * a kernel struct super_block. This will allow us to call the feature-test | 1083 | * a kernel struct super_block. This will allow us to call the feature-test |
@@ -1126,6 +1154,8 @@ static inline int ext4_valid_inum(struct super_block *sb, unsigned long ino) | |||
1126 | #define EXT4_FEATURE_INCOMPAT_64BIT 0x0080 | 1154 | #define EXT4_FEATURE_INCOMPAT_64BIT 0x0080 |
1127 | #define EXT4_FEATURE_INCOMPAT_MMP 0x0100 | 1155 | #define EXT4_FEATURE_INCOMPAT_MMP 0x0100 |
1128 | #define EXT4_FEATURE_INCOMPAT_FLEX_BG 0x0200 | 1156 | #define EXT4_FEATURE_INCOMPAT_FLEX_BG 0x0200 |
1157 | #define EXT4_FEATURE_INCOMPAT_EA_INODE 0x0400 /* EA in inode */ | ||
1158 | #define EXT4_FEATURE_INCOMPAT_DIRDATA 0x1000 /* data in dirent */ | ||
1129 | 1159 | ||
1130 | #define EXT4_FEATURE_COMPAT_SUPP EXT2_FEATURE_COMPAT_EXT_ATTR | 1160 | #define EXT4_FEATURE_COMPAT_SUPP EXT2_FEATURE_COMPAT_EXT_ATTR |
1131 | #define EXT4_FEATURE_INCOMPAT_SUPP (EXT4_FEATURE_INCOMPAT_FILETYPE| \ | 1161 | #define EXT4_FEATURE_INCOMPAT_SUPP (EXT4_FEATURE_INCOMPAT_FILETYPE| \ |
@@ -1416,7 +1446,7 @@ int ext4_get_block(struct inode *inode, sector_t iblock, | |||
1416 | struct buffer_head *bh_result, int create); | 1446 | struct buffer_head *bh_result, int create); |
1417 | 1447 | ||
1418 | extern struct inode *ext4_iget(struct super_block *, unsigned long); | 1448 | extern struct inode *ext4_iget(struct super_block *, unsigned long); |
1419 | extern int ext4_write_inode(struct inode *, int); | 1449 | extern int ext4_write_inode(struct inode *, struct writeback_control *); |
1420 | extern int ext4_setattr(struct dentry *, struct iattr *); | 1450 | extern int ext4_setattr(struct dentry *, struct iattr *); |
1421 | extern int ext4_getattr(struct vfsmount *mnt, struct dentry *dentry, | 1451 | extern int ext4_getattr(struct vfsmount *mnt, struct dentry *dentry, |
1422 | struct kstat *stat); | 1452 | struct kstat *stat); |
@@ -1439,7 +1469,7 @@ extern int ext4_block_truncate_page(handle_t *handle, | |||
1439 | struct address_space *mapping, loff_t from); | 1469 | struct address_space *mapping, loff_t from); |
1440 | extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf); | 1470 | extern int ext4_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf); |
1441 | extern qsize_t *ext4_get_reserved_space(struct inode *inode); | 1471 | extern qsize_t *ext4_get_reserved_space(struct inode *inode); |
1442 | extern int flush_aio_dio_completed_IO(struct inode *inode); | 1472 | extern int flush_completed_IO(struct inode *inode); |
1443 | extern void ext4_da_update_reserve_space(struct inode *inode, | 1473 | extern void ext4_da_update_reserve_space(struct inode *inode, |
1444 | int used, int quota_claim); | 1474 | int used, int quota_claim); |
1445 | /* ioctl.c */ | 1475 | /* ioctl.c */ |
@@ -1465,13 +1495,20 @@ extern int ext4_group_extend(struct super_block *sb, | |||
1465 | ext4_fsblk_t n_blocks_count); | 1495 | ext4_fsblk_t n_blocks_count); |
1466 | 1496 | ||
1467 | /* super.c */ | 1497 | /* super.c */ |
1468 | extern void ext4_error(struct super_block *, const char *, const char *, ...) | 1498 | extern void __ext4_error(struct super_block *, const char *, const char *, ...) |
1499 | __attribute__ ((format (printf, 3, 4))); | ||
1500 | #define ext4_error(sb, message...) __ext4_error(sb, __func__, ## message) | ||
1501 | extern void ext4_error_inode(const char *, struct inode *, const char *, ...) | ||
1502 | __attribute__ ((format (printf, 3, 4))); | ||
1503 | extern void ext4_error_file(const char *, struct file *, const char *, ...) | ||
1469 | __attribute__ ((format (printf, 3, 4))); | 1504 | __attribute__ ((format (printf, 3, 4))); |
1470 | extern void __ext4_std_error(struct super_block *, const char *, int); | 1505 | extern void __ext4_std_error(struct super_block *, const char *, int); |
1471 | extern void ext4_abort(struct super_block *, const char *, const char *, ...) | 1506 | extern void ext4_abort(struct super_block *, const char *, const char *, ...) |
1472 | __attribute__ ((format (printf, 3, 4))); | 1507 | __attribute__ ((format (printf, 3, 4))); |
1473 | extern void ext4_warning(struct super_block *, const char *, const char *, ...) | 1508 | extern void __ext4_warning(struct super_block *, const char *, |
1509 | const char *, ...) | ||
1474 | __attribute__ ((format (printf, 3, 4))); | 1510 | __attribute__ ((format (printf, 3, 4))); |
1511 | #define ext4_warning(sb, message...) __ext4_warning(sb, __func__, ## message) | ||
1475 | extern void ext4_msg(struct super_block *, const char *, const char *, ...) | 1512 | extern void ext4_msg(struct super_block *, const char *, const char *, ...) |
1476 | __attribute__ ((format (printf, 3, 4))); | 1513 | __attribute__ ((format (printf, 3, 4))); |
1477 | extern void ext4_grp_locked_error(struct super_block *, ext4_group_t, | 1514 | extern void ext4_grp_locked_error(struct super_block *, ext4_group_t, |
@@ -1744,7 +1781,7 @@ extern void ext4_ext_release(struct super_block *); | |||
1744 | extern long ext4_fallocate(struct inode *inode, int mode, loff_t offset, | 1781 | extern long ext4_fallocate(struct inode *inode, int mode, loff_t offset, |
1745 | loff_t len); | 1782 | loff_t len); |
1746 | extern int ext4_convert_unwritten_extents(struct inode *inode, loff_t offset, | 1783 | extern int ext4_convert_unwritten_extents(struct inode *inode, loff_t offset, |
1747 | loff_t len); | 1784 | ssize_t len); |
1748 | extern int ext4_get_blocks(handle_t *handle, struct inode *inode, | 1785 | extern int ext4_get_blocks(handle_t *handle, struct inode *inode, |
1749 | sector_t block, unsigned int max_blocks, | 1786 | sector_t block, unsigned int max_blocks, |
1750 | struct buffer_head *bh, int flags); | 1787 | struct buffer_head *bh, int flags); |
@@ -1756,6 +1793,15 @@ extern int ext4_move_extents(struct file *o_filp, struct file *d_filp, | |||
1756 | __u64 len, __u64 *moved_len); | 1793 | __u64 len, __u64 *moved_len); |
1757 | 1794 | ||
1758 | 1795 | ||
1796 | /* BH_Uninit flag: blocks are allocated but uninitialized on disk */ | ||
1797 | enum ext4_state_bits { | ||
1798 | BH_Uninit /* blocks are allocated but uninitialized on disk */ | ||
1799 | = BH_JBDPrivateStart, | ||
1800 | }; | ||
1801 | |||
1802 | BUFFER_FNS(Uninit, uninit) | ||
1803 | TAS_BUFFER_FNS(Uninit, uninit) | ||
1804 | |||
1759 | /* | 1805 | /* |
1760 | * Add new method to test wether block and inode bitmaps are properly | 1806 | * Add new method to test wether block and inode bitmaps are properly |
1761 | * initialized. With uninit_bg reading the block from disk is not enough | 1807 | * initialized. With uninit_bg reading the block from disk is not enough |
@@ -1773,6 +1819,8 @@ static inline void set_bitmap_uptodate(struct buffer_head *bh) | |||
1773 | set_bit(BH_BITMAP_UPTODATE, &(bh)->b_state); | 1819 | set_bit(BH_BITMAP_UPTODATE, &(bh)->b_state); |
1774 | } | 1820 | } |
1775 | 1821 | ||
1822 | #define in_range(b, first, len) ((b) >= (first) && (b) <= (first) + (len) - 1) | ||
1823 | |||
1776 | #endif /* __KERNEL__ */ | 1824 | #endif /* __KERNEL__ */ |
1777 | 1825 | ||
1778 | #endif /* _EXT4_H */ | 1826 | #endif /* _EXT4_H */ |
diff --git a/fs/ext4/ext4_jbd2.c b/fs/ext4/ext4_jbd2.c index b57e5c711b6d..53d2764d71ca 100644 --- a/fs/ext4/ext4_jbd2.c +++ b/fs/ext4/ext4_jbd2.c | |||
@@ -125,14 +125,14 @@ int __ext4_handle_dirty_metadata(const char *where, handle_t *handle, | |||
125 | ext4_journal_abort_handle(where, __func__, bh, | 125 | ext4_journal_abort_handle(where, __func__, bh, |
126 | handle, err); | 126 | handle, err); |
127 | } else { | 127 | } else { |
128 | if (inode && bh) | 128 | if (inode) |
129 | mark_buffer_dirty_inode(bh, inode); | 129 | mark_buffer_dirty_inode(bh, inode); |
130 | else | 130 | else |
131 | mark_buffer_dirty(bh); | 131 | mark_buffer_dirty(bh); |
132 | if (inode && inode_needs_sync(inode)) { | 132 | if (inode && inode_needs_sync(inode)) { |
133 | sync_dirty_buffer(bh); | 133 | sync_dirty_buffer(bh); |
134 | if (buffer_req(bh) && !buffer_uptodate(bh)) { | 134 | if (buffer_req(bh) && !buffer_uptodate(bh)) { |
135 | ext4_error(inode->i_sb, __func__, | 135 | ext4_error(inode->i_sb, |
136 | "IO error syncing inode, " | 136 | "IO error syncing inode, " |
137 | "inode=%lu, block=%llu", | 137 | "inode=%lu, block=%llu", |
138 | inode->i_ino, | 138 | inode->i_ino, |
diff --git a/fs/ext4/ext4_jbd2.h b/fs/ext4/ext4_jbd2.h index 05eca817d704..b79ad5126468 100644 --- a/fs/ext4/ext4_jbd2.h +++ b/fs/ext4/ext4_jbd2.h | |||
@@ -304,4 +304,28 @@ static inline int ext4_should_writeback_data(struct inode *inode) | |||
304 | return 0; | 304 | return 0; |
305 | } | 305 | } |
306 | 306 | ||
307 | /* | ||
308 | * This function controls whether or not we should try to go down the | ||
309 | * dioread_nolock code paths, which makes it safe to avoid taking | ||
310 | * i_mutex for direct I/O reads. This only works for extent-based | ||
311 | * files, and it doesn't work for nobh or if data journaling is | ||
312 | * enabled, since the dioread_nolock code uses b_private to pass | ||
313 | * information back to the I/O completion handler, and this conflicts | ||
314 | * with the jbd's use of b_private. | ||
315 | */ | ||
316 | static inline int ext4_should_dioread_nolock(struct inode *inode) | ||
317 | { | ||
318 | if (!test_opt(inode->i_sb, DIOREAD_NOLOCK)) | ||
319 | return 0; | ||
320 | if (test_opt(inode->i_sb, NOBH)) | ||
321 | return 0; | ||
322 | if (!S_ISREG(inode->i_mode)) | ||
323 | return 0; | ||
324 | if (!(EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL)) | ||
325 | return 0; | ||
326 | if (ext4_should_journal_data(inode)) | ||
327 | return 0; | ||
328 | return 1; | ||
329 | } | ||
330 | |||
307 | #endif /* _EXT4_JBD2_H */ | 331 | #endif /* _EXT4_JBD2_H */ |
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 765a4826b118..94c8ee81f5e1 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c | |||
@@ -195,8 +195,7 @@ static ext4_fsblk_t ext4_ext_find_goal(struct inode *inode, | |||
195 | if (S_ISREG(inode->i_mode)) | 195 | if (S_ISREG(inode->i_mode)) |
196 | block_group++; | 196 | block_group++; |
197 | } | 197 | } |
198 | bg_start = (block_group * EXT4_BLOCKS_PER_GROUP(inode->i_sb)) + | 198 | bg_start = ext4_group_first_block_no(inode->i_sb, block_group); |
199 | le32_to_cpu(EXT4_SB(inode->i_sb)->s_es->s_first_data_block); | ||
200 | last_block = ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es) - 1; | 199 | last_block = ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es) - 1; |
201 | 200 | ||
202 | /* | 201 | /* |
@@ -440,7 +439,7 @@ static int __ext4_ext_check(const char *function, struct inode *inode, | |||
440 | return 0; | 439 | return 0; |
441 | 440 | ||
442 | corrupted: | 441 | corrupted: |
443 | ext4_error(inode->i_sb, function, | 442 | __ext4_error(inode->i_sb, function, |
444 | "bad header/extent in inode #%lu: %s - magic %x, " | 443 | "bad header/extent in inode #%lu: %s - magic %x, " |
445 | "entries %u, max %u(%u), depth %u(%u)", | 444 | "entries %u, max %u(%u), depth %u(%u)", |
446 | inode->i_ino, error_msg, le16_to_cpu(eh->eh_magic), | 445 | inode->i_ino, error_msg, le16_to_cpu(eh->eh_magic), |
@@ -703,7 +702,12 @@ ext4_ext_find_extent(struct inode *inode, ext4_lblk_t block, | |||
703 | } | 702 | } |
704 | eh = ext_block_hdr(bh); | 703 | eh = ext_block_hdr(bh); |
705 | ppos++; | 704 | ppos++; |
706 | BUG_ON(ppos > depth); | 705 | if (unlikely(ppos > depth)) { |
706 | put_bh(bh); | ||
707 | EXT4_ERROR_INODE(inode, | ||
708 | "ppos %d > depth %d", ppos, depth); | ||
709 | goto err; | ||
710 | } | ||
707 | path[ppos].p_bh = bh; | 711 | path[ppos].p_bh = bh; |
708 | path[ppos].p_hdr = eh; | 712 | path[ppos].p_hdr = eh; |
709 | i--; | 713 | i--; |
@@ -749,7 +753,12 @@ int ext4_ext_insert_index(handle_t *handle, struct inode *inode, | |||
749 | if (err) | 753 | if (err) |
750 | return err; | 754 | return err; |
751 | 755 | ||
752 | BUG_ON(logical == le32_to_cpu(curp->p_idx->ei_block)); | 756 | if (unlikely(logical == le32_to_cpu(curp->p_idx->ei_block))) { |
757 | EXT4_ERROR_INODE(inode, | ||
758 | "logical %d == ei_block %d!", | ||
759 | logical, le32_to_cpu(curp->p_idx->ei_block)); | ||
760 | return -EIO; | ||
761 | } | ||
753 | len = EXT_MAX_INDEX(curp->p_hdr) - curp->p_idx; | 762 | len = EXT_MAX_INDEX(curp->p_hdr) - curp->p_idx; |
754 | if (logical > le32_to_cpu(curp->p_idx->ei_block)) { | 763 | if (logical > le32_to_cpu(curp->p_idx->ei_block)) { |
755 | /* insert after */ | 764 | /* insert after */ |
@@ -779,9 +788,17 @@ int ext4_ext_insert_index(handle_t *handle, struct inode *inode, | |||
779 | ext4_idx_store_pblock(ix, ptr); | 788 | ext4_idx_store_pblock(ix, ptr); |
780 | le16_add_cpu(&curp->p_hdr->eh_entries, 1); | 789 | le16_add_cpu(&curp->p_hdr->eh_entries, 1); |
781 | 790 | ||
782 | BUG_ON(le16_to_cpu(curp->p_hdr->eh_entries) | 791 | if (unlikely(le16_to_cpu(curp->p_hdr->eh_entries) |
783 | > le16_to_cpu(curp->p_hdr->eh_max)); | 792 | > le16_to_cpu(curp->p_hdr->eh_max))) { |
784 | BUG_ON(ix > EXT_LAST_INDEX(curp->p_hdr)); | 793 | EXT4_ERROR_INODE(inode, |
794 | "logical %d == ei_block %d!", | ||
795 | logical, le32_to_cpu(curp->p_idx->ei_block)); | ||
796 | return -EIO; | ||
797 | } | ||
798 | if (unlikely(ix > EXT_LAST_INDEX(curp->p_hdr))) { | ||
799 | EXT4_ERROR_INODE(inode, "ix > EXT_LAST_INDEX!"); | ||
800 | return -EIO; | ||
801 | } | ||
785 | 802 | ||
786 | err = ext4_ext_dirty(handle, inode, curp); | 803 | err = ext4_ext_dirty(handle, inode, curp); |
787 | ext4_std_error(inode->i_sb, err); | 804 | ext4_std_error(inode->i_sb, err); |
@@ -819,7 +836,10 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode, | |||
819 | 836 | ||
820 | /* if current leaf will be split, then we should use | 837 | /* if current leaf will be split, then we should use |
821 | * border from split point */ | 838 | * border from split point */ |
822 | BUG_ON(path[depth].p_ext > EXT_MAX_EXTENT(path[depth].p_hdr)); | 839 | if (unlikely(path[depth].p_ext > EXT_MAX_EXTENT(path[depth].p_hdr))) { |
840 | EXT4_ERROR_INODE(inode, "p_ext > EXT_MAX_EXTENT!"); | ||
841 | return -EIO; | ||
842 | } | ||
823 | if (path[depth].p_ext != EXT_MAX_EXTENT(path[depth].p_hdr)) { | 843 | if (path[depth].p_ext != EXT_MAX_EXTENT(path[depth].p_hdr)) { |
824 | border = path[depth].p_ext[1].ee_block; | 844 | border = path[depth].p_ext[1].ee_block; |
825 | ext_debug("leaf will be split." | 845 | ext_debug("leaf will be split." |
@@ -860,7 +880,11 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode, | |||
860 | 880 | ||
861 | /* initialize new leaf */ | 881 | /* initialize new leaf */ |
862 | newblock = ablocks[--a]; | 882 | newblock = ablocks[--a]; |
863 | BUG_ON(newblock == 0); | 883 | if (unlikely(newblock == 0)) { |
884 | EXT4_ERROR_INODE(inode, "newblock == 0!"); | ||
885 | err = -EIO; | ||
886 | goto cleanup; | ||
887 | } | ||
864 | bh = sb_getblk(inode->i_sb, newblock); | 888 | bh = sb_getblk(inode->i_sb, newblock); |
865 | if (!bh) { | 889 | if (!bh) { |
866 | err = -EIO; | 890 | err = -EIO; |
@@ -880,7 +904,14 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode, | |||
880 | ex = EXT_FIRST_EXTENT(neh); | 904 | ex = EXT_FIRST_EXTENT(neh); |
881 | 905 | ||
882 | /* move remainder of path[depth] to the new leaf */ | 906 | /* move remainder of path[depth] to the new leaf */ |
883 | BUG_ON(path[depth].p_hdr->eh_entries != path[depth].p_hdr->eh_max); | 907 | if (unlikely(path[depth].p_hdr->eh_entries != |
908 | path[depth].p_hdr->eh_max)) { | ||
909 | EXT4_ERROR_INODE(inode, "eh_entries %d != eh_max %d!", | ||
910 | path[depth].p_hdr->eh_entries, | ||
911 | path[depth].p_hdr->eh_max); | ||
912 | err = -EIO; | ||
913 | goto cleanup; | ||
914 | } | ||
884 | /* start copy from next extent */ | 915 | /* start copy from next extent */ |
885 | /* TODO: we could do it by single memmove */ | 916 | /* TODO: we could do it by single memmove */ |
886 | m = 0; | 917 | m = 0; |
@@ -927,7 +958,11 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode, | |||
927 | 958 | ||
928 | /* create intermediate indexes */ | 959 | /* create intermediate indexes */ |
929 | k = depth - at - 1; | 960 | k = depth - at - 1; |
930 | BUG_ON(k < 0); | 961 | if (unlikely(k < 0)) { |
962 | EXT4_ERROR_INODE(inode, "k %d < 0!", k); | ||
963 | err = -EIO; | ||
964 | goto cleanup; | ||
965 | } | ||
931 | if (k) | 966 | if (k) |
932 | ext_debug("create %d intermediate indices\n", k); | 967 | ext_debug("create %d intermediate indices\n", k); |
933 | /* insert new index into current index block */ | 968 | /* insert new index into current index block */ |
@@ -964,8 +999,14 @@ static int ext4_ext_split(handle_t *handle, struct inode *inode, | |||
964 | 999 | ||
965 | ext_debug("cur 0x%p, last 0x%p\n", path[i].p_idx, | 1000 | ext_debug("cur 0x%p, last 0x%p\n", path[i].p_idx, |
966 | EXT_MAX_INDEX(path[i].p_hdr)); | 1001 | EXT_MAX_INDEX(path[i].p_hdr)); |
967 | BUG_ON(EXT_MAX_INDEX(path[i].p_hdr) != | 1002 | if (unlikely(EXT_MAX_INDEX(path[i].p_hdr) != |
968 | EXT_LAST_INDEX(path[i].p_hdr)); | 1003 | EXT_LAST_INDEX(path[i].p_hdr))) { |
1004 | EXT4_ERROR_INODE(inode, | ||
1005 | "EXT_MAX_INDEX != EXT_LAST_INDEX ee_block %d!", | ||
1006 | le32_to_cpu(path[i].p_ext->ee_block)); | ||
1007 | err = -EIO; | ||
1008 | goto cleanup; | ||
1009 | } | ||
969 | while (path[i].p_idx <= EXT_MAX_INDEX(path[i].p_hdr)) { | 1010 | while (path[i].p_idx <= EXT_MAX_INDEX(path[i].p_hdr)) { |
970 | ext_debug("%d: move %d:%llu in new index %llu\n", i, | 1011 | ext_debug("%d: move %d:%llu in new index %llu\n", i, |
971 | le32_to_cpu(path[i].p_idx->ei_block), | 1012 | le32_to_cpu(path[i].p_idx->ei_block), |
@@ -1203,7 +1244,10 @@ ext4_ext_search_left(struct inode *inode, struct ext4_ext_path *path, | |||
1203 | struct ext4_extent *ex; | 1244 | struct ext4_extent *ex; |
1204 | int depth, ee_len; | 1245 | int depth, ee_len; |
1205 | 1246 | ||
1206 | BUG_ON(path == NULL); | 1247 | if (unlikely(path == NULL)) { |
1248 | EXT4_ERROR_INODE(inode, "path == NULL *logical %d!", *logical); | ||
1249 | return -EIO; | ||
1250 | } | ||
1207 | depth = path->p_depth; | 1251 | depth = path->p_depth; |
1208 | *phys = 0; | 1252 | *phys = 0; |
1209 | 1253 | ||
@@ -1217,15 +1261,33 @@ ext4_ext_search_left(struct inode *inode, struct ext4_ext_path *path, | |||
1217 | ex = path[depth].p_ext; | 1261 | ex = path[depth].p_ext; |
1218 | ee_len = ext4_ext_get_actual_len(ex); | 1262 | ee_len = ext4_ext_get_actual_len(ex); |
1219 | if (*logical < le32_to_cpu(ex->ee_block)) { | 1263 | if (*logical < le32_to_cpu(ex->ee_block)) { |
1220 | BUG_ON(EXT_FIRST_EXTENT(path[depth].p_hdr) != ex); | 1264 | if (unlikely(EXT_FIRST_EXTENT(path[depth].p_hdr) != ex)) { |
1265 | EXT4_ERROR_INODE(inode, | ||
1266 | "EXT_FIRST_EXTENT != ex *logical %d ee_block %d!", | ||
1267 | *logical, le32_to_cpu(ex->ee_block)); | ||
1268 | return -EIO; | ||
1269 | } | ||
1221 | while (--depth >= 0) { | 1270 | while (--depth >= 0) { |
1222 | ix = path[depth].p_idx; | 1271 | ix = path[depth].p_idx; |
1223 | BUG_ON(ix != EXT_FIRST_INDEX(path[depth].p_hdr)); | 1272 | if (unlikely(ix != EXT_FIRST_INDEX(path[depth].p_hdr))) { |
1273 | EXT4_ERROR_INODE(inode, | ||
1274 | "ix (%d) != EXT_FIRST_INDEX (%d) (depth %d)!", | ||
1275 | ix != NULL ? ix->ei_block : 0, | ||
1276 | EXT_FIRST_INDEX(path[depth].p_hdr) != NULL ? | ||
1277 | EXT_FIRST_INDEX(path[depth].p_hdr)->ei_block : 0, | ||
1278 | depth); | ||
1279 | return -EIO; | ||
1280 | } | ||
1224 | } | 1281 | } |
1225 | return 0; | 1282 | return 0; |
1226 | } | 1283 | } |
1227 | 1284 | ||
1228 | BUG_ON(*logical < (le32_to_cpu(ex->ee_block) + ee_len)); | 1285 | if (unlikely(*logical < (le32_to_cpu(ex->ee_block) + ee_len))) { |
1286 | EXT4_ERROR_INODE(inode, | ||
1287 | "logical %d < ee_block %d + ee_len %d!", | ||
1288 | *logical, le32_to_cpu(ex->ee_block), ee_len); | ||
1289 | return -EIO; | ||
1290 | } | ||
1229 | 1291 | ||
1230 | *logical = le32_to_cpu(ex->ee_block) + ee_len - 1; | 1292 | *logical = le32_to_cpu(ex->ee_block) + ee_len - 1; |
1231 | *phys = ext_pblock(ex) + ee_len - 1; | 1293 | *phys = ext_pblock(ex) + ee_len - 1; |
@@ -1251,7 +1313,10 @@ ext4_ext_search_right(struct inode *inode, struct ext4_ext_path *path, | |||
1251 | int depth; /* Note, NOT eh_depth; depth from top of tree */ | 1313 | int depth; /* Note, NOT eh_depth; depth from top of tree */ |
1252 | int ee_len; | 1314 | int ee_len; |
1253 | 1315 | ||
1254 | BUG_ON(path == NULL); | 1316 | if (unlikely(path == NULL)) { |
1317 | EXT4_ERROR_INODE(inode, "path == NULL *logical %d!", *logical); | ||
1318 | return -EIO; | ||
1319 | } | ||
1255 | depth = path->p_depth; | 1320 | depth = path->p_depth; |
1256 | *phys = 0; | 1321 | *phys = 0; |
1257 | 1322 | ||
@@ -1265,17 +1330,32 @@ ext4_ext_search_right(struct inode *inode, struct ext4_ext_path *path, | |||
1265 | ex = path[depth].p_ext; | 1330 | ex = path[depth].p_ext; |
1266 | ee_len = ext4_ext_get_actual_len(ex); | 1331 | ee_len = ext4_ext_get_actual_len(ex); |
1267 | if (*logical < le32_to_cpu(ex->ee_block)) { | 1332 | if (*logical < le32_to_cpu(ex->ee_block)) { |
1268 | BUG_ON(EXT_FIRST_EXTENT(path[depth].p_hdr) != ex); | 1333 | if (unlikely(EXT_FIRST_EXTENT(path[depth].p_hdr) != ex)) { |
1334 | EXT4_ERROR_INODE(inode, | ||
1335 | "first_extent(path[%d].p_hdr) != ex", | ||
1336 | depth); | ||
1337 | return -EIO; | ||
1338 | } | ||
1269 | while (--depth >= 0) { | 1339 | while (--depth >= 0) { |
1270 | ix = path[depth].p_idx; | 1340 | ix = path[depth].p_idx; |
1271 | BUG_ON(ix != EXT_FIRST_INDEX(path[depth].p_hdr)); | 1341 | if (unlikely(ix != EXT_FIRST_INDEX(path[depth].p_hdr))) { |
1342 | EXT4_ERROR_INODE(inode, | ||
1343 | "ix != EXT_FIRST_INDEX *logical %d!", | ||
1344 | *logical); | ||
1345 | return -EIO; | ||
1346 | } | ||
1272 | } | 1347 | } |
1273 | *logical = le32_to_cpu(ex->ee_block); | 1348 | *logical = le32_to_cpu(ex->ee_block); |
1274 | *phys = ext_pblock(ex); | 1349 | *phys = ext_pblock(ex); |
1275 | return 0; | 1350 | return 0; |
1276 | } | 1351 | } |
1277 | 1352 | ||
1278 | BUG_ON(*logical < (le32_to_cpu(ex->ee_block) + ee_len)); | 1353 | if (unlikely(*logical < (le32_to_cpu(ex->ee_block) + ee_len))) { |
1354 | EXT4_ERROR_INODE(inode, | ||
1355 | "logical %d < ee_block %d + ee_len %d!", | ||
1356 | *logical, le32_to_cpu(ex->ee_block), ee_len); | ||
1357 | return -EIO; | ||
1358 | } | ||
1279 | 1359 | ||
1280 | if (ex != EXT_LAST_EXTENT(path[depth].p_hdr)) { | 1360 | if (ex != EXT_LAST_EXTENT(path[depth].p_hdr)) { |
1281 | /* next allocated block in this leaf */ | 1361 | /* next allocated block in this leaf */ |
@@ -1414,8 +1494,12 @@ static int ext4_ext_correct_indexes(handle_t *handle, struct inode *inode, | |||
1414 | 1494 | ||
1415 | eh = path[depth].p_hdr; | 1495 | eh = path[depth].p_hdr; |
1416 | ex = path[depth].p_ext; | 1496 | ex = path[depth].p_ext; |
1417 | BUG_ON(ex == NULL); | 1497 | |
1418 | BUG_ON(eh == NULL); | 1498 | if (unlikely(ex == NULL || eh == NULL)) { |
1499 | EXT4_ERROR_INODE(inode, | ||
1500 | "ex %p == NULL or eh %p == NULL", ex, eh); | ||
1501 | return -EIO; | ||
1502 | } | ||
1419 | 1503 | ||
1420 | if (depth == 0) { | 1504 | if (depth == 0) { |
1421 | /* there is no tree at all */ | 1505 | /* there is no tree at all */ |
@@ -1538,8 +1622,9 @@ int ext4_ext_try_to_merge(struct inode *inode, | |||
1538 | merge_done = 1; | 1622 | merge_done = 1; |
1539 | WARN_ON(eh->eh_entries == 0); | 1623 | WARN_ON(eh->eh_entries == 0); |
1540 | if (!eh->eh_entries) | 1624 | if (!eh->eh_entries) |
1541 | ext4_error(inode->i_sb, "ext4_ext_try_to_merge", | 1625 | ext4_error(inode->i_sb, |
1542 | "inode#%lu, eh->eh_entries = 0!", inode->i_ino); | 1626 | "inode#%lu, eh->eh_entries = 0!", |
1627 | inode->i_ino); | ||
1543 | } | 1628 | } |
1544 | 1629 | ||
1545 | return merge_done; | 1630 | return merge_done; |
@@ -1612,13 +1697,19 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode, | |||
1612 | ext4_lblk_t next; | 1697 | ext4_lblk_t next; |
1613 | unsigned uninitialized = 0; | 1698 | unsigned uninitialized = 0; |
1614 | 1699 | ||
1615 | BUG_ON(ext4_ext_get_actual_len(newext) == 0); | 1700 | if (unlikely(ext4_ext_get_actual_len(newext) == 0)) { |
1701 | EXT4_ERROR_INODE(inode, "ext4_ext_get_actual_len(newext) == 0"); | ||
1702 | return -EIO; | ||
1703 | } | ||
1616 | depth = ext_depth(inode); | 1704 | depth = ext_depth(inode); |
1617 | ex = path[depth].p_ext; | 1705 | ex = path[depth].p_ext; |
1618 | BUG_ON(path[depth].p_hdr == NULL); | 1706 | if (unlikely(path[depth].p_hdr == NULL)) { |
1707 | EXT4_ERROR_INODE(inode, "path[%d].p_hdr == NULL", depth); | ||
1708 | return -EIO; | ||
1709 | } | ||
1619 | 1710 | ||
1620 | /* try to insert block into found extent and return */ | 1711 | /* try to insert block into found extent and return */ |
1621 | if (ex && (flag != EXT4_GET_BLOCKS_DIO_CREATE_EXT) | 1712 | if (ex && !(flag & EXT4_GET_BLOCKS_PRE_IO) |
1622 | && ext4_can_extents_be_merged(inode, ex, newext)) { | 1713 | && ext4_can_extents_be_merged(inode, ex, newext)) { |
1623 | ext_debug("append [%d]%d block to %d:[%d]%d (from %llu)\n", | 1714 | ext_debug("append [%d]%d block to %d:[%d]%d (from %llu)\n", |
1624 | ext4_ext_is_uninitialized(newext), | 1715 | ext4_ext_is_uninitialized(newext), |
@@ -1739,7 +1830,7 @@ has_space: | |||
1739 | 1830 | ||
1740 | merge: | 1831 | merge: |
1741 | /* try to merge extents to the right */ | 1832 | /* try to merge extents to the right */ |
1742 | if (flag != EXT4_GET_BLOCKS_DIO_CREATE_EXT) | 1833 | if (!(flag & EXT4_GET_BLOCKS_PRE_IO)) |
1743 | ext4_ext_try_to_merge(inode, path, nearex); | 1834 | ext4_ext_try_to_merge(inode, path, nearex); |
1744 | 1835 | ||
1745 | /* try to merge extents to the left */ | 1836 | /* try to merge extents to the left */ |
@@ -1787,7 +1878,11 @@ int ext4_ext_walk_space(struct inode *inode, ext4_lblk_t block, | |||
1787 | } | 1878 | } |
1788 | 1879 | ||
1789 | depth = ext_depth(inode); | 1880 | depth = ext_depth(inode); |
1790 | BUG_ON(path[depth].p_hdr == NULL); | 1881 | if (unlikely(path[depth].p_hdr == NULL)) { |
1882 | EXT4_ERROR_INODE(inode, "path[%d].p_hdr == NULL", depth); | ||
1883 | err = -EIO; | ||
1884 | break; | ||
1885 | } | ||
1791 | ex = path[depth].p_ext; | 1886 | ex = path[depth].p_ext; |
1792 | next = ext4_ext_next_allocated_block(path); | 1887 | next = ext4_ext_next_allocated_block(path); |
1793 | 1888 | ||
@@ -1838,7 +1933,11 @@ int ext4_ext_walk_space(struct inode *inode, ext4_lblk_t block, | |||
1838 | cbex.ec_type = EXT4_EXT_CACHE_EXTENT; | 1933 | cbex.ec_type = EXT4_EXT_CACHE_EXTENT; |
1839 | } | 1934 | } |
1840 | 1935 | ||
1841 | BUG_ON(cbex.ec_len == 0); | 1936 | if (unlikely(cbex.ec_len == 0)) { |
1937 | EXT4_ERROR_INODE(inode, "cbex.ec_len == 0"); | ||
1938 | err = -EIO; | ||
1939 | break; | ||
1940 | } | ||
1842 | err = func(inode, path, &cbex, ex, cbdata); | 1941 | err = func(inode, path, &cbex, ex, cbdata); |
1843 | ext4_ext_drop_refs(path); | 1942 | ext4_ext_drop_refs(path); |
1844 | 1943 | ||
@@ -1952,7 +2051,7 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block, | |||
1952 | 2051 | ||
1953 | BUG_ON(cex->ec_type != EXT4_EXT_CACHE_GAP && | 2052 | BUG_ON(cex->ec_type != EXT4_EXT_CACHE_GAP && |
1954 | cex->ec_type != EXT4_EXT_CACHE_EXTENT); | 2053 | cex->ec_type != EXT4_EXT_CACHE_EXTENT); |
1955 | if (block >= cex->ec_block && block < cex->ec_block + cex->ec_len) { | 2054 | if (in_range(block, cex->ec_block, cex->ec_len)) { |
1956 | ex->ee_block = cpu_to_le32(cex->ec_block); | 2055 | ex->ee_block = cpu_to_le32(cex->ec_block); |
1957 | ext4_ext_store_pblock(ex, cex->ec_start); | 2056 | ext4_ext_store_pblock(ex, cex->ec_start); |
1958 | ex->ee_len = cpu_to_le16(cex->ec_len); | 2057 | ex->ee_len = cpu_to_le16(cex->ec_len); |
@@ -1981,7 +2080,10 @@ static int ext4_ext_rm_idx(handle_t *handle, struct inode *inode, | |||
1981 | /* free index block */ | 2080 | /* free index block */ |
1982 | path--; | 2081 | path--; |
1983 | leaf = idx_pblock(path->p_idx); | 2082 | leaf = idx_pblock(path->p_idx); |
1984 | BUG_ON(path->p_hdr->eh_entries == 0); | 2083 | if (unlikely(path->p_hdr->eh_entries == 0)) { |
2084 | EXT4_ERROR_INODE(inode, "path->p_hdr->eh_entries == 0"); | ||
2085 | return -EIO; | ||
2086 | } | ||
1985 | err = ext4_ext_get_access(handle, inode, path); | 2087 | err = ext4_ext_get_access(handle, inode, path); |
1986 | if (err) | 2088 | if (err) |
1987 | return err; | 2089 | return err; |
@@ -2119,8 +2221,10 @@ ext4_ext_rm_leaf(handle_t *handle, struct inode *inode, | |||
2119 | if (!path[depth].p_hdr) | 2221 | if (!path[depth].p_hdr) |
2120 | path[depth].p_hdr = ext_block_hdr(path[depth].p_bh); | 2222 | path[depth].p_hdr = ext_block_hdr(path[depth].p_bh); |
2121 | eh = path[depth].p_hdr; | 2223 | eh = path[depth].p_hdr; |
2122 | BUG_ON(eh == NULL); | 2224 | if (unlikely(path[depth].p_hdr == NULL)) { |
2123 | 2225 | EXT4_ERROR_INODE(inode, "path[%d].p_hdr == NULL", depth); | |
2226 | return -EIO; | ||
2227 | } | ||
2124 | /* find where to start removing */ | 2228 | /* find where to start removing */ |
2125 | ex = EXT_LAST_EXTENT(eh); | 2229 | ex = EXT_LAST_EXTENT(eh); |
2126 | 2230 | ||
@@ -2983,7 +3087,7 @@ fix_extent_len: | |||
2983 | ext4_ext_dirty(handle, inode, path + depth); | 3087 | ext4_ext_dirty(handle, inode, path + depth); |
2984 | return err; | 3088 | return err; |
2985 | } | 3089 | } |
2986 | static int ext4_convert_unwritten_extents_dio(handle_t *handle, | 3090 | static int ext4_convert_unwritten_extents_endio(handle_t *handle, |
2987 | struct inode *inode, | 3091 | struct inode *inode, |
2988 | struct ext4_ext_path *path) | 3092 | struct ext4_ext_path *path) |
2989 | { | 3093 | { |
@@ -3063,8 +3167,8 @@ ext4_ext_handle_uninitialized_extents(handle_t *handle, struct inode *inode, | |||
3063 | flags, allocated); | 3167 | flags, allocated); |
3064 | ext4_ext_show_leaf(inode, path); | 3168 | ext4_ext_show_leaf(inode, path); |
3065 | 3169 | ||
3066 | /* DIO get_block() before submit the IO, split the extent */ | 3170 | /* get_block() before submit the IO, split the extent */ |
3067 | if (flags == EXT4_GET_BLOCKS_DIO_CREATE_EXT) { | 3171 | if ((flags & EXT4_GET_BLOCKS_PRE_IO)) { |
3068 | ret = ext4_split_unwritten_extents(handle, | 3172 | ret = ext4_split_unwritten_extents(handle, |
3069 | inode, path, iblock, | 3173 | inode, path, iblock, |
3070 | max_blocks, flags); | 3174 | max_blocks, flags); |
@@ -3074,14 +3178,16 @@ ext4_ext_handle_uninitialized_extents(handle_t *handle, struct inode *inode, | |||
3074 | * completed | 3178 | * completed |
3075 | */ | 3179 | */ |
3076 | if (io) | 3180 | if (io) |
3077 | io->flag = DIO_AIO_UNWRITTEN; | 3181 | io->flag = EXT4_IO_UNWRITTEN; |
3078 | else | 3182 | else |
3079 | EXT4_I(inode)->i_state |= EXT4_STATE_DIO_UNWRITTEN; | 3183 | ext4_set_inode_state(inode, EXT4_STATE_DIO_UNWRITTEN); |
3184 | if (ext4_should_dioread_nolock(inode)) | ||
3185 | set_buffer_uninit(bh_result); | ||
3080 | goto out; | 3186 | goto out; |
3081 | } | 3187 | } |
3082 | /* async DIO end_io complete, convert the filled extent to written */ | 3188 | /* IO end_io complete, convert the filled extent to written */ |
3083 | if (flags == EXT4_GET_BLOCKS_DIO_CONVERT_EXT) { | 3189 | if ((flags & EXT4_GET_BLOCKS_CONVERT)) { |
3084 | ret = ext4_convert_unwritten_extents_dio(handle, inode, | 3190 | ret = ext4_convert_unwritten_extents_endio(handle, inode, |
3085 | path); | 3191 | path); |
3086 | if (ret >= 0) | 3192 | if (ret >= 0) |
3087 | ext4_update_inode_fsync_trans(handle, inode, 1); | 3193 | ext4_update_inode_fsync_trans(handle, inode, 1); |
@@ -3185,7 +3291,7 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode, | |||
3185 | { | 3291 | { |
3186 | struct ext4_ext_path *path = NULL; | 3292 | struct ext4_ext_path *path = NULL; |
3187 | struct ext4_extent_header *eh; | 3293 | struct ext4_extent_header *eh; |
3188 | struct ext4_extent newex, *ex; | 3294 | struct ext4_extent newex, *ex, *last_ex; |
3189 | ext4_fsblk_t newblock; | 3295 | ext4_fsblk_t newblock; |
3190 | int err = 0, depth, ret, cache_type; | 3296 | int err = 0, depth, ret, cache_type; |
3191 | unsigned int allocated = 0; | 3297 | unsigned int allocated = 0; |
@@ -3237,10 +3343,10 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode, | |||
3237 | * this situation is possible, though, _during_ tree modification; | 3343 | * this situation is possible, though, _during_ tree modification; |
3238 | * this is why assert can't be put in ext4_ext_find_extent() | 3344 | * this is why assert can't be put in ext4_ext_find_extent() |
3239 | */ | 3345 | */ |
3240 | if (path[depth].p_ext == NULL && depth != 0) { | 3346 | if (unlikely(path[depth].p_ext == NULL && depth != 0)) { |
3241 | ext4_error(inode->i_sb, __func__, "bad extent address " | 3347 | EXT4_ERROR_INODE(inode, "bad extent address " |
3242 | "inode: %lu, iblock: %d, depth: %d", | 3348 | "iblock: %d, depth: %d pblock %lld", |
3243 | inode->i_ino, iblock, depth); | 3349 | iblock, depth, path[depth].p_block); |
3244 | err = -EIO; | 3350 | err = -EIO; |
3245 | goto out2; | 3351 | goto out2; |
3246 | } | 3352 | } |
@@ -3258,7 +3364,7 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode, | |||
3258 | */ | 3364 | */ |
3259 | ee_len = ext4_ext_get_actual_len(ex); | 3365 | ee_len = ext4_ext_get_actual_len(ex); |
3260 | /* if found extent covers block, simply return it */ | 3366 | /* if found extent covers block, simply return it */ |
3261 | if (iblock >= ee_block && iblock < ee_block + ee_len) { | 3367 | if (in_range(iblock, ee_block, ee_len)) { |
3262 | newblock = iblock - ee_block + ee_start; | 3368 | newblock = iblock - ee_block + ee_start; |
3263 | /* number of remaining blocks in the extent */ | 3369 | /* number of remaining blocks in the extent */ |
3264 | allocated = ee_len - (iblock - ee_block); | 3370 | allocated = ee_len - (iblock - ee_block); |
@@ -3350,21 +3456,35 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode, | |||
3350 | if (flags & EXT4_GET_BLOCKS_UNINIT_EXT){ | 3456 | if (flags & EXT4_GET_BLOCKS_UNINIT_EXT){ |
3351 | ext4_ext_mark_uninitialized(&newex); | 3457 | ext4_ext_mark_uninitialized(&newex); |
3352 | /* | 3458 | /* |
3353 | * io_end structure was created for every async | 3459 | * io_end structure was created for every IO write to an |
3354 | * direct IO write to the middle of the file. | 3460 | * uninitialized extent. To avoid unecessary conversion, |
3355 | * To avoid unecessary convertion for every aio dio rewrite | 3461 | * here we flag the IO that really needs the conversion. |
3356 | * to the mid of file, here we flag the IO that is really | ||
3357 | * need the convertion. | ||
3358 | * For non asycn direct IO case, flag the inode state | 3462 | * For non asycn direct IO case, flag the inode state |
3359 | * that we need to perform convertion when IO is done. | 3463 | * that we need to perform convertion when IO is done. |
3360 | */ | 3464 | */ |
3361 | if (flags == EXT4_GET_BLOCKS_DIO_CREATE_EXT) { | 3465 | if ((flags & EXT4_GET_BLOCKS_PRE_IO)) { |
3362 | if (io) | 3466 | if (io) |
3363 | io->flag = DIO_AIO_UNWRITTEN; | 3467 | io->flag = EXT4_IO_UNWRITTEN; |
3364 | else | 3468 | else |
3365 | EXT4_I(inode)->i_state |= | 3469 | ext4_set_inode_state(inode, |
3366 | EXT4_STATE_DIO_UNWRITTEN;; | 3470 | EXT4_STATE_DIO_UNWRITTEN); |
3471 | } | ||
3472 | if (ext4_should_dioread_nolock(inode)) | ||
3473 | set_buffer_uninit(bh_result); | ||
3474 | } | ||
3475 | |||
3476 | if (unlikely(EXT4_I(inode)->i_flags & EXT4_EOFBLOCKS_FL)) { | ||
3477 | if (unlikely(!eh->eh_entries)) { | ||
3478 | EXT4_ERROR_INODE(inode, | ||
3479 | "eh->eh_entries == 0 ee_block %d", | ||
3480 | ex->ee_block); | ||
3481 | err = -EIO; | ||
3482 | goto out2; | ||
3367 | } | 3483 | } |
3484 | last_ex = EXT_LAST_EXTENT(eh); | ||
3485 | if (iblock + ar.len > le32_to_cpu(last_ex->ee_block) | ||
3486 | + ext4_ext_get_actual_len(last_ex)) | ||
3487 | EXT4_I(inode)->i_flags &= ~EXT4_EOFBLOCKS_FL; | ||
3368 | } | 3488 | } |
3369 | err = ext4_ext_insert_extent(handle, inode, path, &newex, flags); | 3489 | err = ext4_ext_insert_extent(handle, inode, path, &newex, flags); |
3370 | if (err) { | 3490 | if (err) { |
@@ -3499,6 +3619,13 @@ static void ext4_falloc_update_inode(struct inode *inode, | |||
3499 | i_size_write(inode, new_size); | 3619 | i_size_write(inode, new_size); |
3500 | if (new_size > EXT4_I(inode)->i_disksize) | 3620 | if (new_size > EXT4_I(inode)->i_disksize) |
3501 | ext4_update_i_disksize(inode, new_size); | 3621 | ext4_update_i_disksize(inode, new_size); |
3622 | } else { | ||
3623 | /* | ||
3624 | * Mark that we allocate beyond EOF so the subsequent truncate | ||
3625 | * can proceed even if the new size is the same as i_size. | ||
3626 | */ | ||
3627 | if (new_size > i_size_read(inode)) | ||
3628 | EXT4_I(inode)->i_flags |= EXT4_EOFBLOCKS_FL; | ||
3502 | } | 3629 | } |
3503 | 3630 | ||
3504 | } | 3631 | } |
@@ -3603,7 +3730,7 @@ retry: | |||
3603 | * Returns 0 on success. | 3730 | * Returns 0 on success. |
3604 | */ | 3731 | */ |
3605 | int ext4_convert_unwritten_extents(struct inode *inode, loff_t offset, | 3732 | int ext4_convert_unwritten_extents(struct inode *inode, loff_t offset, |
3606 | loff_t len) | 3733 | ssize_t len) |
3607 | { | 3734 | { |
3608 | handle_t *handle; | 3735 | handle_t *handle; |
3609 | ext4_lblk_t block; | 3736 | ext4_lblk_t block; |
@@ -3635,7 +3762,7 @@ int ext4_convert_unwritten_extents(struct inode *inode, loff_t offset, | |||
3635 | map_bh.b_state = 0; | 3762 | map_bh.b_state = 0; |
3636 | ret = ext4_get_blocks(handle, inode, block, | 3763 | ret = ext4_get_blocks(handle, inode, block, |
3637 | max_blocks, &map_bh, | 3764 | max_blocks, &map_bh, |
3638 | EXT4_GET_BLOCKS_DIO_CONVERT_EXT); | 3765 | EXT4_GET_BLOCKS_IO_CONVERT_EXT); |
3639 | if (ret <= 0) { | 3766 | if (ret <= 0) { |
3640 | WARN_ON(ret <= 0); | 3767 | WARN_ON(ret <= 0); |
3641 | printk(KERN_ERR "%s: ext4_ext_get_blocks " | 3768 | printk(KERN_ERR "%s: ext4_ext_get_blocks " |
@@ -3739,7 +3866,7 @@ static int ext4_xattr_fiemap(struct inode *inode, | |||
3739 | int error = 0; | 3866 | int error = 0; |
3740 | 3867 | ||
3741 | /* in-inode? */ | 3868 | /* in-inode? */ |
3742 | if (EXT4_I(inode)->i_state & EXT4_STATE_XATTR) { | 3869 | if (ext4_test_inode_state(inode, EXT4_STATE_XATTR)) { |
3743 | struct ext4_iloc iloc; | 3870 | struct ext4_iloc iloc; |
3744 | int offset; /* offset of xattr in inode */ | 3871 | int offset; /* offset of xattr in inode */ |
3745 | 3872 | ||
@@ -3767,7 +3894,6 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, | |||
3767 | __u64 start, __u64 len) | 3894 | __u64 start, __u64 len) |
3768 | { | 3895 | { |
3769 | ext4_lblk_t start_blk; | 3896 | ext4_lblk_t start_blk; |
3770 | ext4_lblk_t len_blks; | ||
3771 | int error = 0; | 3897 | int error = 0; |
3772 | 3898 | ||
3773 | /* fallback to generic here if not in extents fmt */ | 3899 | /* fallback to generic here if not in extents fmt */ |
@@ -3781,8 +3907,14 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, | |||
3781 | if (fieinfo->fi_flags & FIEMAP_FLAG_XATTR) { | 3907 | if (fieinfo->fi_flags & FIEMAP_FLAG_XATTR) { |
3782 | error = ext4_xattr_fiemap(inode, fieinfo); | 3908 | error = ext4_xattr_fiemap(inode, fieinfo); |
3783 | } else { | 3909 | } else { |
3910 | ext4_lblk_t len_blks; | ||
3911 | __u64 last_blk; | ||
3912 | |||
3784 | start_blk = start >> inode->i_sb->s_blocksize_bits; | 3913 | start_blk = start >> inode->i_sb->s_blocksize_bits; |
3785 | len_blks = len >> inode->i_sb->s_blocksize_bits; | 3914 | last_blk = (start + len - 1) >> inode->i_sb->s_blocksize_bits; |
3915 | if (last_blk >= EXT_MAX_BLOCK) | ||
3916 | last_blk = EXT_MAX_BLOCK-1; | ||
3917 | len_blks = ((ext4_lblk_t) last_blk) - start_blk + 1; | ||
3786 | 3918 | ||
3787 | /* | 3919 | /* |
3788 | * Walk the extent tree gathering extent information. | 3920 | * Walk the extent tree gathering extent information. |
diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 9630583cef28..d0776e410f34 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c | |||
@@ -23,6 +23,7 @@ | |||
23 | #include <linux/jbd2.h> | 23 | #include <linux/jbd2.h> |
24 | #include <linux/mount.h> | 24 | #include <linux/mount.h> |
25 | #include <linux/path.h> | 25 | #include <linux/path.h> |
26 | #include <linux/quotaops.h> | ||
26 | #include "ext4.h" | 27 | #include "ext4.h" |
27 | #include "ext4_jbd2.h" | 28 | #include "ext4_jbd2.h" |
28 | #include "xattr.h" | 29 | #include "xattr.h" |
@@ -35,9 +36,9 @@ | |||
35 | */ | 36 | */ |
36 | static int ext4_release_file(struct inode *inode, struct file *filp) | 37 | static int ext4_release_file(struct inode *inode, struct file *filp) |
37 | { | 38 | { |
38 | if (EXT4_I(inode)->i_state & EXT4_STATE_DA_ALLOC_CLOSE) { | 39 | if (ext4_test_inode_state(inode, EXT4_STATE_DA_ALLOC_CLOSE)) { |
39 | ext4_alloc_da_blocks(inode); | 40 | ext4_alloc_da_blocks(inode); |
40 | EXT4_I(inode)->i_state &= ~EXT4_STATE_DA_ALLOC_CLOSE; | 41 | ext4_clear_inode_state(inode, EXT4_STATE_DA_ALLOC_CLOSE); |
41 | } | 42 | } |
42 | /* if we are the last writer on the inode, drop the block reservation */ | 43 | /* if we are the last writer on the inode, drop the block reservation */ |
43 | if ((filp->f_mode & FMODE_WRITE) && | 44 | if ((filp->f_mode & FMODE_WRITE) && |
@@ -116,18 +117,16 @@ static int ext4_file_open(struct inode * inode, struct file * filp) | |||
116 | * devices or filesystem images. | 117 | * devices or filesystem images. |
117 | */ | 118 | */ |
118 | memset(buf, 0, sizeof(buf)); | 119 | memset(buf, 0, sizeof(buf)); |
119 | path.mnt = mnt->mnt_parent; | 120 | path.mnt = mnt; |
120 | path.dentry = mnt->mnt_mountpoint; | 121 | path.dentry = mnt->mnt_root; |
121 | path_get(&path); | ||
122 | cp = d_path(&path, buf, sizeof(buf)); | 122 | cp = d_path(&path, buf, sizeof(buf)); |
123 | path_put(&path); | ||
124 | if (!IS_ERR(cp)) { | 123 | if (!IS_ERR(cp)) { |
125 | memcpy(sbi->s_es->s_last_mounted, cp, | 124 | memcpy(sbi->s_es->s_last_mounted, cp, |
126 | sizeof(sbi->s_es->s_last_mounted)); | 125 | sizeof(sbi->s_es->s_last_mounted)); |
127 | sb->s_dirt = 1; | 126 | sb->s_dirt = 1; |
128 | } | 127 | } |
129 | } | 128 | } |
130 | return generic_file_open(inode, filp); | 129 | return dquot_file_open(inode, filp); |
131 | } | 130 | } |
132 | 131 | ||
133 | const struct file_operations ext4_file_operations = { | 132 | const struct file_operations ext4_file_operations = { |
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index 98bd140aad01..0d0c3239c1cd 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c | |||
@@ -63,7 +63,7 @@ int ext4_sync_file(struct file *file, struct dentry *dentry, int datasync) | |||
63 | if (inode->i_sb->s_flags & MS_RDONLY) | 63 | if (inode->i_sb->s_flags & MS_RDONLY) |
64 | return 0; | 64 | return 0; |
65 | 65 | ||
66 | ret = flush_aio_dio_completed_IO(inode); | 66 | ret = flush_completed_IO(inode); |
67 | if (ret < 0) | 67 | if (ret < 0) |
68 | return ret; | 68 | return ret; |
69 | 69 | ||
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index f3624ead4f6c..361c0b9962a8 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c | |||
@@ -76,8 +76,7 @@ unsigned ext4_init_inode_bitmap(struct super_block *sb, struct buffer_head *bh, | |||
76 | /* If checksum is bad mark all blocks and inodes use to prevent | 76 | /* If checksum is bad mark all blocks and inodes use to prevent |
77 | * allocation, essentially implementing a per-group read-only flag. */ | 77 | * allocation, essentially implementing a per-group read-only flag. */ |
78 | if (!ext4_group_desc_csum_verify(sbi, block_group, gdp)) { | 78 | if (!ext4_group_desc_csum_verify(sbi, block_group, gdp)) { |
79 | ext4_error(sb, __func__, "Checksum bad for group %u", | 79 | ext4_error(sb, "Checksum bad for group %u", block_group); |
80 | block_group); | ||
81 | ext4_free_blks_set(sb, gdp, 0); | 80 | ext4_free_blks_set(sb, gdp, 0); |
82 | ext4_free_inodes_set(sb, gdp, 0); | 81 | ext4_free_inodes_set(sb, gdp, 0); |
83 | ext4_itable_unused_set(sb, gdp, 0); | 82 | ext4_itable_unused_set(sb, gdp, 0); |
@@ -111,8 +110,7 @@ ext4_read_inode_bitmap(struct super_block *sb, ext4_group_t block_group) | |||
111 | bitmap_blk = ext4_inode_bitmap(sb, desc); | 110 | bitmap_blk = ext4_inode_bitmap(sb, desc); |
112 | bh = sb_getblk(sb, bitmap_blk); | 111 | bh = sb_getblk(sb, bitmap_blk); |
113 | if (unlikely(!bh)) { | 112 | if (unlikely(!bh)) { |
114 | ext4_error(sb, __func__, | 113 | ext4_error(sb, "Cannot read inode bitmap - " |
115 | "Cannot read inode bitmap - " | ||
116 | "block_group = %u, inode_bitmap = %llu", | 114 | "block_group = %u, inode_bitmap = %llu", |
117 | block_group, bitmap_blk); | 115 | block_group, bitmap_blk); |
118 | return NULL; | 116 | return NULL; |
@@ -153,8 +151,7 @@ ext4_read_inode_bitmap(struct super_block *sb, ext4_group_t block_group) | |||
153 | set_bitmap_uptodate(bh); | 151 | set_bitmap_uptodate(bh); |
154 | if (bh_submit_read(bh) < 0) { | 152 | if (bh_submit_read(bh) < 0) { |
155 | put_bh(bh); | 153 | put_bh(bh); |
156 | ext4_error(sb, __func__, | 154 | ext4_error(sb, "Cannot read inode bitmap - " |
157 | "Cannot read inode bitmap - " | ||
158 | "block_group = %u, inode_bitmap = %llu", | 155 | "block_group = %u, inode_bitmap = %llu", |
159 | block_group, bitmap_blk); | 156 | block_group, bitmap_blk); |
160 | return NULL; | 157 | return NULL; |
@@ -217,10 +214,10 @@ void ext4_free_inode(handle_t *handle, struct inode *inode) | |||
217 | * Note: we must free any quota before locking the superblock, | 214 | * Note: we must free any quota before locking the superblock, |
218 | * as writing the quota to disk may need the lock as well. | 215 | * as writing the quota to disk may need the lock as well. |
219 | */ | 216 | */ |
220 | vfs_dq_init(inode); | 217 | dquot_initialize(inode); |
221 | ext4_xattr_delete_inode(handle, inode); | 218 | ext4_xattr_delete_inode(handle, inode); |
222 | vfs_dq_free_inode(inode); | 219 | dquot_free_inode(inode); |
223 | vfs_dq_drop(inode); | 220 | dquot_drop(inode); |
224 | 221 | ||
225 | is_directory = S_ISDIR(inode->i_mode); | 222 | is_directory = S_ISDIR(inode->i_mode); |
226 | 223 | ||
@@ -229,8 +226,7 @@ void ext4_free_inode(handle_t *handle, struct inode *inode) | |||
229 | 226 | ||
230 | es = EXT4_SB(sb)->s_es; | 227 | es = EXT4_SB(sb)->s_es; |
231 | if (ino < EXT4_FIRST_INO(sb) || ino > le32_to_cpu(es->s_inodes_count)) { | 228 | if (ino < EXT4_FIRST_INO(sb) || ino > le32_to_cpu(es->s_inodes_count)) { |
232 | ext4_error(sb, "ext4_free_inode", | 229 | ext4_error(sb, "reserved or nonexistent inode %lu", ino); |
233 | "reserved or nonexistent inode %lu", ino); | ||
234 | goto error_return; | 230 | goto error_return; |
235 | } | 231 | } |
236 | block_group = (ino - 1) / EXT4_INODES_PER_GROUP(sb); | 232 | block_group = (ino - 1) / EXT4_INODES_PER_GROUP(sb); |
@@ -248,8 +244,7 @@ void ext4_free_inode(handle_t *handle, struct inode *inode) | |||
248 | cleared = ext4_clear_bit_atomic(ext4_group_lock_ptr(sb, block_group), | 244 | cleared = ext4_clear_bit_atomic(ext4_group_lock_ptr(sb, block_group), |
249 | bit, bitmap_bh->b_data); | 245 | bit, bitmap_bh->b_data); |
250 | if (!cleared) | 246 | if (!cleared) |
251 | ext4_error(sb, "ext4_free_inode", | 247 | ext4_error(sb, "bit already cleared for inode %lu", ino); |
252 | "bit already cleared for inode %lu", ino); | ||
253 | else { | 248 | else { |
254 | gdp = ext4_get_group_desc(sb, block_group, &bh2); | 249 | gdp = ext4_get_group_desc(sb, block_group, &bh2); |
255 | 250 | ||
@@ -736,8 +731,7 @@ static int ext4_claim_inode(struct super_block *sb, | |||
736 | if ((group == 0 && ino < EXT4_FIRST_INO(sb)) || | 731 | if ((group == 0 && ino < EXT4_FIRST_INO(sb)) || |
737 | ino > EXT4_INODES_PER_GROUP(sb)) { | 732 | ino > EXT4_INODES_PER_GROUP(sb)) { |
738 | ext4_unlock_group(sb, group); | 733 | ext4_unlock_group(sb, group); |
739 | ext4_error(sb, __func__, | 734 | ext4_error(sb, "reserved inode or inode > inodes count - " |
740 | "reserved inode or inode > inodes count - " | ||
741 | "block_group = %u, inode=%lu", group, | 735 | "block_group = %u, inode=%lu", group, |
742 | ino + group * EXT4_INODES_PER_GROUP(sb)); | 736 | ino + group * EXT4_INODES_PER_GROUP(sb)); |
743 | return 1; | 737 | return 1; |
@@ -904,7 +898,7 @@ repeat_in_this_group: | |||
904 | BUFFER_TRACE(inode_bitmap_bh, | 898 | BUFFER_TRACE(inode_bitmap_bh, |
905 | "call ext4_handle_dirty_metadata"); | 899 | "call ext4_handle_dirty_metadata"); |
906 | err = ext4_handle_dirty_metadata(handle, | 900 | err = ext4_handle_dirty_metadata(handle, |
907 | inode, | 901 | NULL, |
908 | inode_bitmap_bh); | 902 | inode_bitmap_bh); |
909 | if (err) | 903 | if (err) |
910 | goto fail; | 904 | goto fail; |
@@ -1029,15 +1023,16 @@ got: | |||
1029 | inode->i_generation = sbi->s_next_generation++; | 1023 | inode->i_generation = sbi->s_next_generation++; |
1030 | spin_unlock(&sbi->s_next_gen_lock); | 1024 | spin_unlock(&sbi->s_next_gen_lock); |
1031 | 1025 | ||
1032 | ei->i_state = EXT4_STATE_NEW; | 1026 | ei->i_state_flags = 0; |
1027 | ext4_set_inode_state(inode, EXT4_STATE_NEW); | ||
1033 | 1028 | ||
1034 | ei->i_extra_isize = EXT4_SB(sb)->s_want_extra_isize; | 1029 | ei->i_extra_isize = EXT4_SB(sb)->s_want_extra_isize; |
1035 | 1030 | ||
1036 | ret = inode; | 1031 | ret = inode; |
1037 | if (vfs_dq_alloc_inode(inode)) { | 1032 | dquot_initialize(inode); |
1038 | err = -EDQUOT; | 1033 | err = dquot_alloc_inode(inode); |
1034 | if (err) | ||
1039 | goto fail_drop; | 1035 | goto fail_drop; |
1040 | } | ||
1041 | 1036 | ||
1042 | err = ext4_init_acl(handle, inode, dir); | 1037 | err = ext4_init_acl(handle, inode, dir); |
1043 | if (err) | 1038 | if (err) |
@@ -1074,10 +1069,10 @@ really_out: | |||
1074 | return ret; | 1069 | return ret; |
1075 | 1070 | ||
1076 | fail_free_drop: | 1071 | fail_free_drop: |
1077 | vfs_dq_free_inode(inode); | 1072 | dquot_free_inode(inode); |
1078 | 1073 | ||
1079 | fail_drop: | 1074 | fail_drop: |
1080 | vfs_dq_drop(inode); | 1075 | dquot_drop(inode); |
1081 | inode->i_flags |= S_NOQUOTA; | 1076 | inode->i_flags |= S_NOQUOTA; |
1082 | inode->i_nlink = 0; | 1077 | inode->i_nlink = 0; |
1083 | unlock_new_inode(inode); | 1078 | unlock_new_inode(inode); |
@@ -1098,8 +1093,7 @@ struct inode *ext4_orphan_get(struct super_block *sb, unsigned long ino) | |||
1098 | 1093 | ||
1099 | /* Error cases - e2fsck has already cleaned up for us */ | 1094 | /* Error cases - e2fsck has already cleaned up for us */ |
1100 | if (ino > max_ino) { | 1095 | if (ino > max_ino) { |
1101 | ext4_warning(sb, __func__, | 1096 | ext4_warning(sb, "bad orphan ino %lu! e2fsck was run?", ino); |
1102 | "bad orphan ino %lu! e2fsck was run?", ino); | ||
1103 | goto error; | 1097 | goto error; |
1104 | } | 1098 | } |
1105 | 1099 | ||
@@ -1107,8 +1101,7 @@ struct inode *ext4_orphan_get(struct super_block *sb, unsigned long ino) | |||
1107 | bit = (ino - 1) % EXT4_INODES_PER_GROUP(sb); | 1101 | bit = (ino - 1) % EXT4_INODES_PER_GROUP(sb); |
1108 | bitmap_bh = ext4_read_inode_bitmap(sb, block_group); | 1102 | bitmap_bh = ext4_read_inode_bitmap(sb, block_group); |
1109 | if (!bitmap_bh) { | 1103 | if (!bitmap_bh) { |
1110 | ext4_warning(sb, __func__, | 1104 | ext4_warning(sb, "inode bitmap error for orphan %lu", ino); |
1111 | "inode bitmap error for orphan %lu", ino); | ||
1112 | goto error; | 1105 | goto error; |
1113 | } | 1106 | } |
1114 | 1107 | ||
@@ -1140,8 +1133,7 @@ iget_failed: | |||
1140 | err = PTR_ERR(inode); | 1133 | err = PTR_ERR(inode); |
1141 | inode = NULL; | 1134 | inode = NULL; |
1142 | bad_orphan: | 1135 | bad_orphan: |
1143 | ext4_warning(sb, __func__, | 1136 | ext4_warning(sb, "bad orphan inode %lu! e2fsck was run?", ino); |
1144 | "bad orphan inode %lu! e2fsck was run?", ino); | ||
1145 | printk(KERN_NOTICE "ext4_test_bit(bit=%d, block=%llu) = %d\n", | 1137 | printk(KERN_NOTICE "ext4_test_bit(bit=%d, block=%llu) = %d\n", |
1146 | bit, (unsigned long long)bitmap_bh->b_blocknr, | 1138 | bit, (unsigned long long)bitmap_bh->b_blocknr, |
1147 | ext4_test_bit(bit, bitmap_bh->b_data)); | 1139 | ext4_test_bit(bit, bitmap_bh->b_data)); |
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index e11952404e02..986120f30066 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
@@ -38,6 +38,7 @@ | |||
38 | #include <linux/uio.h> | 38 | #include <linux/uio.h> |
39 | #include <linux/bio.h> | 39 | #include <linux/bio.h> |
40 | #include <linux/workqueue.h> | 40 | #include <linux/workqueue.h> |
41 | #include <linux/kernel.h> | ||
41 | 42 | ||
42 | #include "ext4_jbd2.h" | 43 | #include "ext4_jbd2.h" |
43 | #include "xattr.h" | 44 | #include "xattr.h" |
@@ -170,6 +171,9 @@ void ext4_delete_inode(struct inode *inode) | |||
170 | handle_t *handle; | 171 | handle_t *handle; |
171 | int err; | 172 | int err; |
172 | 173 | ||
174 | if (!is_bad_inode(inode)) | ||
175 | dquot_initialize(inode); | ||
176 | |||
173 | if (ext4_should_order_data(inode)) | 177 | if (ext4_should_order_data(inode)) |
174 | ext4_begin_ordered_truncate(inode, 0); | 178 | ext4_begin_ordered_truncate(inode, 0); |
175 | truncate_inode_pages(&inode->i_data, 0); | 179 | truncate_inode_pages(&inode->i_data, 0); |
@@ -194,7 +198,7 @@ void ext4_delete_inode(struct inode *inode) | |||
194 | inode->i_size = 0; | 198 | inode->i_size = 0; |
195 | err = ext4_mark_inode_dirty(handle, inode); | 199 | err = ext4_mark_inode_dirty(handle, inode); |
196 | if (err) { | 200 | if (err) { |
197 | ext4_warning(inode->i_sb, __func__, | 201 | ext4_warning(inode->i_sb, |
198 | "couldn't mark inode dirty (err %d)", err); | 202 | "couldn't mark inode dirty (err %d)", err); |
199 | goto stop_handle; | 203 | goto stop_handle; |
200 | } | 204 | } |
@@ -212,7 +216,7 @@ void ext4_delete_inode(struct inode *inode) | |||
212 | if (err > 0) | 216 | if (err > 0) |
213 | err = ext4_journal_restart(handle, 3); | 217 | err = ext4_journal_restart(handle, 3); |
214 | if (err != 0) { | 218 | if (err != 0) { |
215 | ext4_warning(inode->i_sb, __func__, | 219 | ext4_warning(inode->i_sb, |
216 | "couldn't extend journal (err %d)", err); | 220 | "couldn't extend journal (err %d)", err); |
217 | stop_handle: | 221 | stop_handle: |
218 | ext4_journal_stop(handle); | 222 | ext4_journal_stop(handle); |
@@ -323,8 +327,7 @@ static int ext4_block_to_path(struct inode *inode, | |||
323 | offsets[n++] = i_block & (ptrs - 1); | 327 | offsets[n++] = i_block & (ptrs - 1); |
324 | final = ptrs; | 328 | final = ptrs; |
325 | } else { | 329 | } else { |
326 | ext4_warning(inode->i_sb, "ext4_block_to_path", | 330 | ext4_warning(inode->i_sb, "block %lu > max in inode %lu", |
327 | "block %lu > max in inode %lu", | ||
328 | i_block + direct_blocks + | 331 | i_block + direct_blocks + |
329 | indirect_blocks + double_blocks, inode->i_ino); | 332 | indirect_blocks + double_blocks, inode->i_ino); |
330 | } | 333 | } |
@@ -344,7 +347,7 @@ static int __ext4_check_blockref(const char *function, struct inode *inode, | |||
344 | if (blk && | 347 | if (blk && |
345 | unlikely(!ext4_data_block_valid(EXT4_SB(inode->i_sb), | 348 | unlikely(!ext4_data_block_valid(EXT4_SB(inode->i_sb), |
346 | blk, 1))) { | 349 | blk, 1))) { |
347 | ext4_error(inode->i_sb, function, | 350 | __ext4_error(inode->i_sb, function, |
348 | "invalid block reference %u " | 351 | "invalid block reference %u " |
349 | "in inode #%lu", blk, inode->i_ino); | 352 | "in inode #%lu", blk, inode->i_ino); |
350 | return -EIO; | 353 | return -EIO; |
@@ -607,7 +610,14 @@ static int ext4_alloc_blocks(handle_t *handle, struct inode *inode, | |||
607 | if (*err) | 610 | if (*err) |
608 | goto failed_out; | 611 | goto failed_out; |
609 | 612 | ||
610 | BUG_ON(current_block + count > EXT4_MAX_BLOCK_FILE_PHYS); | 613 | if (unlikely(current_block + count > EXT4_MAX_BLOCK_FILE_PHYS)) { |
614 | EXT4_ERROR_INODE(inode, | ||
615 | "current_block %llu + count %lu > %d!", | ||
616 | current_block, count, | ||
617 | EXT4_MAX_BLOCK_FILE_PHYS); | ||
618 | *err = -EIO; | ||
619 | goto failed_out; | ||
620 | } | ||
611 | 621 | ||
612 | target -= count; | 622 | target -= count; |
613 | /* allocate blocks for indirect blocks */ | 623 | /* allocate blocks for indirect blocks */ |
@@ -643,7 +653,14 @@ static int ext4_alloc_blocks(handle_t *handle, struct inode *inode, | |||
643 | ar.flags = EXT4_MB_HINT_DATA; | 653 | ar.flags = EXT4_MB_HINT_DATA; |
644 | 654 | ||
645 | current_block = ext4_mb_new_blocks(handle, &ar, err); | 655 | current_block = ext4_mb_new_blocks(handle, &ar, err); |
646 | BUG_ON(current_block + ar.len > EXT4_MAX_BLOCK_FILE_PHYS); | 656 | if (unlikely(current_block + ar.len > EXT4_MAX_BLOCK_FILE_PHYS)) { |
657 | EXT4_ERROR_INODE(inode, | ||
658 | "current_block %llu + ar.len %d > %d!", | ||
659 | current_block, ar.len, | ||
660 | EXT4_MAX_BLOCK_FILE_PHYS); | ||
661 | *err = -EIO; | ||
662 | goto failed_out; | ||
663 | } | ||
647 | 664 | ||
648 | if (*err && (target == blks)) { | 665 | if (*err && (target == blks)) { |
649 | /* | 666 | /* |
@@ -1061,6 +1078,7 @@ void ext4_da_update_reserve_space(struct inode *inode, | |||
1061 | int mdb_free = 0, allocated_meta_blocks = 0; | 1078 | int mdb_free = 0, allocated_meta_blocks = 0; |
1062 | 1079 | ||
1063 | spin_lock(&ei->i_block_reservation_lock); | 1080 | spin_lock(&ei->i_block_reservation_lock); |
1081 | trace_ext4_da_update_reserve_space(inode, used); | ||
1064 | if (unlikely(used > ei->i_reserved_data_blocks)) { | 1082 | if (unlikely(used > ei->i_reserved_data_blocks)) { |
1065 | ext4_msg(inode->i_sb, KERN_NOTICE, "%s: ino %lu, used %d " | 1083 | ext4_msg(inode->i_sb, KERN_NOTICE, "%s: ino %lu, used %d " |
1066 | "with only %d reserved data blocks\n", | 1084 | "with only %d reserved data blocks\n", |
@@ -1093,9 +1111,9 @@ void ext4_da_update_reserve_space(struct inode *inode, | |||
1093 | 1111 | ||
1094 | /* Update quota subsystem */ | 1112 | /* Update quota subsystem */ |
1095 | if (quota_claim) { | 1113 | if (quota_claim) { |
1096 | vfs_dq_claim_block(inode, used); | 1114 | dquot_claim_block(inode, used); |
1097 | if (mdb_free) | 1115 | if (mdb_free) |
1098 | vfs_dq_release_reservation_block(inode, mdb_free); | 1116 | dquot_release_reservation_block(inode, mdb_free); |
1099 | } else { | 1117 | } else { |
1100 | /* | 1118 | /* |
1101 | * We did fallocate with an offset that is already delayed | 1119 | * We did fallocate with an offset that is already delayed |
@@ -1106,8 +1124,8 @@ void ext4_da_update_reserve_space(struct inode *inode, | |||
1106 | * that | 1124 | * that |
1107 | */ | 1125 | */ |
1108 | if (allocated_meta_blocks) | 1126 | if (allocated_meta_blocks) |
1109 | vfs_dq_claim_block(inode, allocated_meta_blocks); | 1127 | dquot_claim_block(inode, allocated_meta_blocks); |
1110 | vfs_dq_release_reservation_block(inode, mdb_free + used); | 1128 | dquot_release_reservation_block(inode, mdb_free + used); |
1111 | } | 1129 | } |
1112 | 1130 | ||
1113 | /* | 1131 | /* |
@@ -1124,7 +1142,7 @@ static int check_block_validity(struct inode *inode, const char *msg, | |||
1124 | sector_t logical, sector_t phys, int len) | 1142 | sector_t logical, sector_t phys, int len) |
1125 | { | 1143 | { |
1126 | if (!ext4_data_block_valid(EXT4_SB(inode->i_sb), phys, len)) { | 1144 | if (!ext4_data_block_valid(EXT4_SB(inode->i_sb), phys, len)) { |
1127 | ext4_error(inode->i_sb, msg, | 1145 | __ext4_error(inode->i_sb, msg, |
1128 | "inode #%lu logical block %llu mapped to %llu " | 1146 | "inode #%lu logical block %llu mapped to %llu " |
1129 | "(size %d)", inode->i_ino, | 1147 | "(size %d)", inode->i_ino, |
1130 | (unsigned long long) logical, | 1148 | (unsigned long long) logical, |
@@ -1306,7 +1324,7 @@ int ext4_get_blocks(handle_t *handle, struct inode *inode, sector_t block, | |||
1306 | * i_data's format changing. Force the migrate | 1324 | * i_data's format changing. Force the migrate |
1307 | * to fail by clearing migrate flags | 1325 | * to fail by clearing migrate flags |
1308 | */ | 1326 | */ |
1309 | EXT4_I(inode)->i_state &= ~EXT4_STATE_EXT_MIGRATE; | 1327 | ext4_clear_inode_state(inode, EXT4_STATE_EXT_MIGRATE); |
1310 | } | 1328 | } |
1311 | 1329 | ||
1312 | /* | 1330 | /* |
@@ -1534,6 +1552,8 @@ static void ext4_truncate_failed_write(struct inode *inode) | |||
1534 | ext4_truncate(inode); | 1552 | ext4_truncate(inode); |
1535 | } | 1553 | } |
1536 | 1554 | ||
1555 | static int ext4_get_block_write(struct inode *inode, sector_t iblock, | ||
1556 | struct buffer_head *bh_result, int create); | ||
1537 | static int ext4_write_begin(struct file *file, struct address_space *mapping, | 1557 | static int ext4_write_begin(struct file *file, struct address_space *mapping, |
1538 | loff_t pos, unsigned len, unsigned flags, | 1558 | loff_t pos, unsigned len, unsigned flags, |
1539 | struct page **pagep, void **fsdata) | 1559 | struct page **pagep, void **fsdata) |
@@ -1575,8 +1595,12 @@ retry: | |||
1575 | } | 1595 | } |
1576 | *pagep = page; | 1596 | *pagep = page; |
1577 | 1597 | ||
1578 | ret = block_write_begin(file, mapping, pos, len, flags, pagep, fsdata, | 1598 | if (ext4_should_dioread_nolock(inode)) |
1579 | ext4_get_block); | 1599 | ret = block_write_begin(file, mapping, pos, len, flags, pagep, |
1600 | fsdata, ext4_get_block_write); | ||
1601 | else | ||
1602 | ret = block_write_begin(file, mapping, pos, len, flags, pagep, | ||
1603 | fsdata, ext4_get_block); | ||
1580 | 1604 | ||
1581 | if (!ret && ext4_should_journal_data(inode)) { | 1605 | if (!ret && ext4_should_journal_data(inode)) { |
1582 | ret = walk_page_buffers(handle, page_buffers(page), | 1606 | ret = walk_page_buffers(handle, page_buffers(page), |
@@ -1793,7 +1817,7 @@ static int ext4_journalled_write_end(struct file *file, | |||
1793 | new_i_size = pos + copied; | 1817 | new_i_size = pos + copied; |
1794 | if (new_i_size > inode->i_size) | 1818 | if (new_i_size > inode->i_size) |
1795 | i_size_write(inode, pos+copied); | 1819 | i_size_write(inode, pos+copied); |
1796 | EXT4_I(inode)->i_state |= EXT4_STATE_JDATA; | 1820 | ext4_set_inode_state(inode, EXT4_STATE_JDATA); |
1797 | if (new_i_size > EXT4_I(inode)->i_disksize) { | 1821 | if (new_i_size > EXT4_I(inode)->i_disksize) { |
1798 | ext4_update_i_disksize(inode, new_i_size); | 1822 | ext4_update_i_disksize(inode, new_i_size); |
1799 | ret2 = ext4_mark_inode_dirty(handle, inode); | 1823 | ret2 = ext4_mark_inode_dirty(handle, inode); |
@@ -1836,6 +1860,7 @@ static int ext4_da_reserve_space(struct inode *inode, sector_t lblock) | |||
1836 | struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb); | 1860 | struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb); |
1837 | struct ext4_inode_info *ei = EXT4_I(inode); | 1861 | struct ext4_inode_info *ei = EXT4_I(inode); |
1838 | unsigned long md_needed, md_reserved; | 1862 | unsigned long md_needed, md_reserved; |
1863 | int ret; | ||
1839 | 1864 | ||
1840 | /* | 1865 | /* |
1841 | * recalculate the amount of metadata blocks to reserve | 1866 | * recalculate the amount of metadata blocks to reserve |
@@ -1846,6 +1871,7 @@ repeat: | |||
1846 | spin_lock(&ei->i_block_reservation_lock); | 1871 | spin_lock(&ei->i_block_reservation_lock); |
1847 | md_reserved = ei->i_reserved_meta_blocks; | 1872 | md_reserved = ei->i_reserved_meta_blocks; |
1848 | md_needed = ext4_calc_metadata_amount(inode, lblock); | 1873 | md_needed = ext4_calc_metadata_amount(inode, lblock); |
1874 | trace_ext4_da_reserve_space(inode, md_needed); | ||
1849 | spin_unlock(&ei->i_block_reservation_lock); | 1875 | spin_unlock(&ei->i_block_reservation_lock); |
1850 | 1876 | ||
1851 | /* | 1877 | /* |
@@ -1853,11 +1879,12 @@ repeat: | |||
1853 | * later. Real quota accounting is done at pages writeout | 1879 | * later. Real quota accounting is done at pages writeout |
1854 | * time. | 1880 | * time. |
1855 | */ | 1881 | */ |
1856 | if (vfs_dq_reserve_block(inode, md_needed + 1)) | 1882 | ret = dquot_reserve_block(inode, md_needed + 1); |
1857 | return -EDQUOT; | 1883 | if (ret) |
1884 | return ret; | ||
1858 | 1885 | ||
1859 | if (ext4_claim_free_blocks(sbi, md_needed + 1)) { | 1886 | if (ext4_claim_free_blocks(sbi, md_needed + 1)) { |
1860 | vfs_dq_release_reservation_block(inode, md_needed + 1); | 1887 | dquot_release_reservation_block(inode, md_needed + 1); |
1861 | if (ext4_should_retry_alloc(inode->i_sb, &retries)) { | 1888 | if (ext4_should_retry_alloc(inode->i_sb, &retries)) { |
1862 | yield(); | 1889 | yield(); |
1863 | goto repeat; | 1890 | goto repeat; |
@@ -1914,7 +1941,7 @@ static void ext4_da_release_space(struct inode *inode, int to_free) | |||
1914 | 1941 | ||
1915 | spin_unlock(&EXT4_I(inode)->i_block_reservation_lock); | 1942 | spin_unlock(&EXT4_I(inode)->i_block_reservation_lock); |
1916 | 1943 | ||
1917 | vfs_dq_release_reservation_block(inode, to_free); | 1944 | dquot_release_reservation_block(inode, to_free); |
1918 | } | 1945 | } |
1919 | 1946 | ||
1920 | static void ext4_da_page_release_reservation(struct page *page, | 1947 | static void ext4_da_page_release_reservation(struct page *page, |
@@ -2091,6 +2118,8 @@ static void mpage_put_bnr_to_bhs(struct mpage_da_data *mpd, sector_t logical, | |||
2091 | } else if (buffer_mapped(bh)) | 2118 | } else if (buffer_mapped(bh)) |
2092 | BUG_ON(bh->b_blocknr != pblock); | 2119 | BUG_ON(bh->b_blocknr != pblock); |
2093 | 2120 | ||
2121 | if (buffer_uninit(exbh)) | ||
2122 | set_buffer_uninit(bh); | ||
2094 | cur_logical++; | 2123 | cur_logical++; |
2095 | pblock++; | 2124 | pblock++; |
2096 | } while ((bh = bh->b_this_page) != head); | 2125 | } while ((bh = bh->b_this_page) != head); |
@@ -2133,17 +2162,16 @@ static void ext4_da_block_invalidatepages(struct mpage_da_data *mpd, | |||
2133 | break; | 2162 | break; |
2134 | for (i = 0; i < nr_pages; i++) { | 2163 | for (i = 0; i < nr_pages; i++) { |
2135 | struct page *page = pvec.pages[i]; | 2164 | struct page *page = pvec.pages[i]; |
2136 | index = page->index; | 2165 | if (page->index > end) |
2137 | if (index > end) | ||
2138 | break; | 2166 | break; |
2139 | index++; | ||
2140 | |||
2141 | BUG_ON(!PageLocked(page)); | 2167 | BUG_ON(!PageLocked(page)); |
2142 | BUG_ON(PageWriteback(page)); | 2168 | BUG_ON(PageWriteback(page)); |
2143 | block_invalidatepage(page, 0); | 2169 | block_invalidatepage(page, 0); |
2144 | ClearPageUptodate(page); | 2170 | ClearPageUptodate(page); |
2145 | unlock_page(page); | 2171 | unlock_page(page); |
2146 | } | 2172 | } |
2173 | index = pvec.pages[nr_pages - 1]->index + 1; | ||
2174 | pagevec_release(&pvec); | ||
2147 | } | 2175 | } |
2148 | return; | 2176 | return; |
2149 | } | 2177 | } |
@@ -2220,6 +2248,8 @@ static int mpage_da_map_blocks(struct mpage_da_data *mpd) | |||
2220 | */ | 2248 | */ |
2221 | new.b_state = 0; | 2249 | new.b_state = 0; |
2222 | get_blocks_flags = EXT4_GET_BLOCKS_CREATE; | 2250 | get_blocks_flags = EXT4_GET_BLOCKS_CREATE; |
2251 | if (ext4_should_dioread_nolock(mpd->inode)) | ||
2252 | get_blocks_flags |= EXT4_GET_BLOCKS_IO_CREATE_EXT; | ||
2223 | if (mpd->b_state & (1 << BH_Delay)) | 2253 | if (mpd->b_state & (1 << BH_Delay)) |
2224 | get_blocks_flags |= EXT4_GET_BLOCKS_DELALLOC_RESERVE; | 2254 | get_blocks_flags |= EXT4_GET_BLOCKS_DELALLOC_RESERVE; |
2225 | 2255 | ||
@@ -2630,11 +2660,14 @@ static int __ext4_journalled_writepage(struct page *page, | |||
2630 | ret = err; | 2660 | ret = err; |
2631 | 2661 | ||
2632 | walk_page_buffers(handle, page_bufs, 0, len, NULL, bput_one); | 2662 | walk_page_buffers(handle, page_bufs, 0, len, NULL, bput_one); |
2633 | EXT4_I(inode)->i_state |= EXT4_STATE_JDATA; | 2663 | ext4_set_inode_state(inode, EXT4_STATE_JDATA); |
2634 | out: | 2664 | out: |
2635 | return ret; | 2665 | return ret; |
2636 | } | 2666 | } |
2637 | 2667 | ||
2668 | static int ext4_set_bh_endio(struct buffer_head *bh, struct inode *inode); | ||
2669 | static void ext4_end_io_buffer_write(struct buffer_head *bh, int uptodate); | ||
2670 | |||
2638 | /* | 2671 | /* |
2639 | * Note that we don't need to start a transaction unless we're journaling data | 2672 | * Note that we don't need to start a transaction unless we're journaling data |
2640 | * because we should have holes filled from ext4_page_mkwrite(). We even don't | 2673 | * because we should have holes filled from ext4_page_mkwrite(). We even don't |
@@ -2682,7 +2715,7 @@ static int ext4_writepage(struct page *page, | |||
2682 | int ret = 0; | 2715 | int ret = 0; |
2683 | loff_t size; | 2716 | loff_t size; |
2684 | unsigned int len; | 2717 | unsigned int len; |
2685 | struct buffer_head *page_bufs; | 2718 | struct buffer_head *page_bufs = NULL; |
2686 | struct inode *inode = page->mapping->host; | 2719 | struct inode *inode = page->mapping->host; |
2687 | 2720 | ||
2688 | trace_ext4_writepage(inode, page); | 2721 | trace_ext4_writepage(inode, page); |
@@ -2758,7 +2791,11 @@ static int ext4_writepage(struct page *page, | |||
2758 | 2791 | ||
2759 | if (test_opt(inode->i_sb, NOBH) && ext4_should_writeback_data(inode)) | 2792 | if (test_opt(inode->i_sb, NOBH) && ext4_should_writeback_data(inode)) |
2760 | ret = nobh_writepage(page, noalloc_get_block_write, wbc); | 2793 | ret = nobh_writepage(page, noalloc_get_block_write, wbc); |
2761 | else | 2794 | else if (page_bufs && buffer_uninit(page_bufs)) { |
2795 | ext4_set_bh_endio(page_bufs, inode); | ||
2796 | ret = block_write_full_page_endio(page, noalloc_get_block_write, | ||
2797 | wbc, ext4_end_io_buffer_write); | ||
2798 | } else | ||
2762 | ret = block_write_full_page(page, noalloc_get_block_write, | 2799 | ret = block_write_full_page(page, noalloc_get_block_write, |
2763 | wbc); | 2800 | wbc); |
2764 | 2801 | ||
@@ -3301,7 +3338,8 @@ static sector_t ext4_bmap(struct address_space *mapping, sector_t block) | |||
3301 | filemap_write_and_wait(mapping); | 3338 | filemap_write_and_wait(mapping); |
3302 | } | 3339 | } |
3303 | 3340 | ||
3304 | if (EXT4_JOURNAL(inode) && EXT4_I(inode)->i_state & EXT4_STATE_JDATA) { | 3341 | if (EXT4_JOURNAL(inode) && |
3342 | ext4_test_inode_state(inode, EXT4_STATE_JDATA)) { | ||
3305 | /* | 3343 | /* |
3306 | * This is a REALLY heavyweight approach, but the use of | 3344 | * This is a REALLY heavyweight approach, but the use of |
3307 | * bmap on dirty files is expected to be extremely rare: | 3345 | * bmap on dirty files is expected to be extremely rare: |
@@ -3320,7 +3358,7 @@ static sector_t ext4_bmap(struct address_space *mapping, sector_t block) | |||
3320 | * everything they get. | 3358 | * everything they get. |
3321 | */ | 3359 | */ |
3322 | 3360 | ||
3323 | EXT4_I(inode)->i_state &= ~EXT4_STATE_JDATA; | 3361 | ext4_clear_inode_state(inode, EXT4_STATE_JDATA); |
3324 | journal = EXT4_JOURNAL(inode); | 3362 | journal = EXT4_JOURNAL(inode); |
3325 | jbd2_journal_lock_updates(journal); | 3363 | jbd2_journal_lock_updates(journal); |
3326 | err = jbd2_journal_flush(journal); | 3364 | err = jbd2_journal_flush(journal); |
@@ -3345,11 +3383,45 @@ ext4_readpages(struct file *file, struct address_space *mapping, | |||
3345 | return mpage_readpages(mapping, pages, nr_pages, ext4_get_block); | 3383 | return mpage_readpages(mapping, pages, nr_pages, ext4_get_block); |
3346 | } | 3384 | } |
3347 | 3385 | ||
3386 | static void ext4_free_io_end(ext4_io_end_t *io) | ||
3387 | { | ||
3388 | BUG_ON(!io); | ||
3389 | if (io->page) | ||
3390 | put_page(io->page); | ||
3391 | iput(io->inode); | ||
3392 | kfree(io); | ||
3393 | } | ||
3394 | |||
3395 | static void ext4_invalidatepage_free_endio(struct page *page, unsigned long offset) | ||
3396 | { | ||
3397 | struct buffer_head *head, *bh; | ||
3398 | unsigned int curr_off = 0; | ||
3399 | |||
3400 | if (!page_has_buffers(page)) | ||
3401 | return; | ||
3402 | head = bh = page_buffers(page); | ||
3403 | do { | ||
3404 | if (offset <= curr_off && test_clear_buffer_uninit(bh) | ||
3405 | && bh->b_private) { | ||
3406 | ext4_free_io_end(bh->b_private); | ||
3407 | bh->b_private = NULL; | ||
3408 | bh->b_end_io = NULL; | ||
3409 | } | ||
3410 | curr_off = curr_off + bh->b_size; | ||
3411 | bh = bh->b_this_page; | ||
3412 | } while (bh != head); | ||
3413 | } | ||
3414 | |||
3348 | static void ext4_invalidatepage(struct page *page, unsigned long offset) | 3415 | static void ext4_invalidatepage(struct page *page, unsigned long offset) |
3349 | { | 3416 | { |
3350 | journal_t *journal = EXT4_JOURNAL(page->mapping->host); | 3417 | journal_t *journal = EXT4_JOURNAL(page->mapping->host); |
3351 | 3418 | ||
3352 | /* | 3419 | /* |
3420 | * free any io_end structure allocated for buffers to be discarded | ||
3421 | */ | ||
3422 | if (ext4_should_dioread_nolock(page->mapping->host)) | ||
3423 | ext4_invalidatepage_free_endio(page, offset); | ||
3424 | /* | ||
3353 | * If it's a full truncate we just forget about the pending dirtying | 3425 | * If it's a full truncate we just forget about the pending dirtying |
3354 | */ | 3426 | */ |
3355 | if (offset == 0) | 3427 | if (offset == 0) |
@@ -3420,7 +3492,14 @@ static ssize_t ext4_ind_direct_IO(int rw, struct kiocb *iocb, | |||
3420 | } | 3492 | } |
3421 | 3493 | ||
3422 | retry: | 3494 | retry: |
3423 | ret = blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev, iov, | 3495 | if (rw == READ && ext4_should_dioread_nolock(inode)) |
3496 | ret = blockdev_direct_IO_no_locking(rw, iocb, inode, | ||
3497 | inode->i_sb->s_bdev, iov, | ||
3498 | offset, nr_segs, | ||
3499 | ext4_get_block, NULL); | ||
3500 | else | ||
3501 | ret = blockdev_direct_IO(rw, iocb, inode, | ||
3502 | inode->i_sb->s_bdev, iov, | ||
3424 | offset, nr_segs, | 3503 | offset, nr_segs, |
3425 | ext4_get_block, NULL); | 3504 | ext4_get_block, NULL); |
3426 | if (ret == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries)) | 3505 | if (ret == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries)) |
@@ -3436,6 +3515,9 @@ retry: | |||
3436 | * but cannot extend i_size. Bail out and pretend | 3515 | * but cannot extend i_size. Bail out and pretend |
3437 | * the write failed... */ | 3516 | * the write failed... */ |
3438 | ret = PTR_ERR(handle); | 3517 | ret = PTR_ERR(handle); |
3518 | if (inode->i_nlink) | ||
3519 | ext4_orphan_del(NULL, inode); | ||
3520 | |||
3439 | goto out; | 3521 | goto out; |
3440 | } | 3522 | } |
3441 | if (inode->i_nlink) | 3523 | if (inode->i_nlink) |
@@ -3463,75 +3545,63 @@ out: | |||
3463 | return ret; | 3545 | return ret; |
3464 | } | 3546 | } |
3465 | 3547 | ||
3466 | static int ext4_get_block_dio_write(struct inode *inode, sector_t iblock, | 3548 | static int ext4_get_block_write(struct inode *inode, sector_t iblock, |
3467 | struct buffer_head *bh_result, int create) | 3549 | struct buffer_head *bh_result, int create) |
3468 | { | 3550 | { |
3469 | handle_t *handle = NULL; | 3551 | handle_t *handle = ext4_journal_current_handle(); |
3470 | int ret = 0; | 3552 | int ret = 0; |
3471 | unsigned max_blocks = bh_result->b_size >> inode->i_blkbits; | 3553 | unsigned max_blocks = bh_result->b_size >> inode->i_blkbits; |
3472 | int dio_credits; | 3554 | int dio_credits; |
3555 | int started = 0; | ||
3473 | 3556 | ||
3474 | ext4_debug("ext4_get_block_dio_write: inode %lu, create flag %d\n", | 3557 | ext4_debug("ext4_get_block_write: inode %lu, create flag %d\n", |
3475 | inode->i_ino, create); | 3558 | inode->i_ino, create); |
3476 | /* | 3559 | /* |
3477 | * DIO VFS code passes create = 0 flag for write to | 3560 | * ext4_get_block in prepare for a DIO write or buffer write. |
3478 | * the middle of file. It does this to avoid block | 3561 | * We allocate an uinitialized extent if blocks haven't been allocated. |
3479 | * allocation for holes, to prevent expose stale data | 3562 | * The extent will be converted to initialized after IO complete. |
3480 | * out when there is parallel buffered read (which does | ||
3481 | * not hold the i_mutex lock) while direct IO write has | ||
3482 | * not completed. DIO request on holes finally falls back | ||
3483 | * to buffered IO for this reason. | ||
3484 | * | ||
3485 | * For ext4 extent based file, since we support fallocate, | ||
3486 | * new allocated extent as uninitialized, for holes, we | ||
3487 | * could fallocate blocks for holes, thus parallel | ||
3488 | * buffered IO read will zero out the page when read on | ||
3489 | * a hole while parallel DIO write to the hole has not completed. | ||
3490 | * | ||
3491 | * when we come here, we know it's a direct IO write to | ||
3492 | * to the middle of file (<i_size) | ||
3493 | * so it's safe to override the create flag from VFS. | ||
3494 | */ | 3563 | */ |
3495 | create = EXT4_GET_BLOCKS_DIO_CREATE_EXT; | 3564 | create = EXT4_GET_BLOCKS_IO_CREATE_EXT; |
3496 | 3565 | ||
3497 | if (max_blocks > DIO_MAX_BLOCKS) | 3566 | if (!handle) { |
3498 | max_blocks = DIO_MAX_BLOCKS; | 3567 | if (max_blocks > DIO_MAX_BLOCKS) |
3499 | dio_credits = ext4_chunk_trans_blocks(inode, max_blocks); | 3568 | max_blocks = DIO_MAX_BLOCKS; |
3500 | handle = ext4_journal_start(inode, dio_credits); | 3569 | dio_credits = ext4_chunk_trans_blocks(inode, max_blocks); |
3501 | if (IS_ERR(handle)) { | 3570 | handle = ext4_journal_start(inode, dio_credits); |
3502 | ret = PTR_ERR(handle); | 3571 | if (IS_ERR(handle)) { |
3503 | goto out; | 3572 | ret = PTR_ERR(handle); |
3573 | goto out; | ||
3574 | } | ||
3575 | started = 1; | ||
3504 | } | 3576 | } |
3577 | |||
3505 | ret = ext4_get_blocks(handle, inode, iblock, max_blocks, bh_result, | 3578 | ret = ext4_get_blocks(handle, inode, iblock, max_blocks, bh_result, |
3506 | create); | 3579 | create); |
3507 | if (ret > 0) { | 3580 | if (ret > 0) { |
3508 | bh_result->b_size = (ret << inode->i_blkbits); | 3581 | bh_result->b_size = (ret << inode->i_blkbits); |
3509 | ret = 0; | 3582 | ret = 0; |
3510 | } | 3583 | } |
3511 | ext4_journal_stop(handle); | 3584 | if (started) |
3585 | ext4_journal_stop(handle); | ||
3512 | out: | 3586 | out: |
3513 | return ret; | 3587 | return ret; |
3514 | } | 3588 | } |
3515 | 3589 | ||
3516 | static void ext4_free_io_end(ext4_io_end_t *io) | 3590 | static void dump_completed_IO(struct inode * inode) |
3517 | { | ||
3518 | BUG_ON(!io); | ||
3519 | iput(io->inode); | ||
3520 | kfree(io); | ||
3521 | } | ||
3522 | static void dump_aio_dio_list(struct inode * inode) | ||
3523 | { | 3591 | { |
3524 | #ifdef EXT4_DEBUG | 3592 | #ifdef EXT4_DEBUG |
3525 | struct list_head *cur, *before, *after; | 3593 | struct list_head *cur, *before, *after; |
3526 | ext4_io_end_t *io, *io0, *io1; | 3594 | ext4_io_end_t *io, *io0, *io1; |
3595 | unsigned long flags; | ||
3527 | 3596 | ||
3528 | if (list_empty(&EXT4_I(inode)->i_aio_dio_complete_list)){ | 3597 | if (list_empty(&EXT4_I(inode)->i_completed_io_list)){ |
3529 | ext4_debug("inode %lu aio dio list is empty\n", inode->i_ino); | 3598 | ext4_debug("inode %lu completed_io list is empty\n", inode->i_ino); |
3530 | return; | 3599 | return; |
3531 | } | 3600 | } |
3532 | 3601 | ||
3533 | ext4_debug("Dump inode %lu aio_dio_completed_IO list \n", inode->i_ino); | 3602 | ext4_debug("Dump inode %lu completed_io list \n", inode->i_ino); |
3534 | list_for_each_entry(io, &EXT4_I(inode)->i_aio_dio_complete_list, list){ | 3603 | spin_lock_irqsave(&EXT4_I(inode)->i_completed_io_lock, flags); |
3604 | list_for_each_entry(io, &EXT4_I(inode)->i_completed_io_list, list){ | ||
3535 | cur = &io->list; | 3605 | cur = &io->list; |
3536 | before = cur->prev; | 3606 | before = cur->prev; |
3537 | io0 = container_of(before, ext4_io_end_t, list); | 3607 | io0 = container_of(before, ext4_io_end_t, list); |
@@ -3541,32 +3611,31 @@ static void dump_aio_dio_list(struct inode * inode) | |||
3541 | ext4_debug("io 0x%p from inode %lu,prev 0x%p,next 0x%p\n", | 3611 | ext4_debug("io 0x%p from inode %lu,prev 0x%p,next 0x%p\n", |
3542 | io, inode->i_ino, io0, io1); | 3612 | io, inode->i_ino, io0, io1); |
3543 | } | 3613 | } |
3614 | spin_unlock_irqrestore(&EXT4_I(inode)->i_completed_io_lock, flags); | ||
3544 | #endif | 3615 | #endif |
3545 | } | 3616 | } |
3546 | 3617 | ||
3547 | /* | 3618 | /* |
3548 | * check a range of space and convert unwritten extents to written. | 3619 | * check a range of space and convert unwritten extents to written. |
3549 | */ | 3620 | */ |
3550 | static int ext4_end_aio_dio_nolock(ext4_io_end_t *io) | 3621 | static int ext4_end_io_nolock(ext4_io_end_t *io) |
3551 | { | 3622 | { |
3552 | struct inode *inode = io->inode; | 3623 | struct inode *inode = io->inode; |
3553 | loff_t offset = io->offset; | 3624 | loff_t offset = io->offset; |
3554 | size_t size = io->size; | 3625 | ssize_t size = io->size; |
3555 | int ret = 0; | 3626 | int ret = 0; |
3556 | 3627 | ||
3557 | ext4_debug("end_aio_dio_onlock: io 0x%p from inode %lu,list->next 0x%p," | 3628 | ext4_debug("ext4_end_io_nolock: io 0x%p from inode %lu,list->next 0x%p," |
3558 | "list->prev 0x%p\n", | 3629 | "list->prev 0x%p\n", |
3559 | io, inode->i_ino, io->list.next, io->list.prev); | 3630 | io, inode->i_ino, io->list.next, io->list.prev); |
3560 | 3631 | ||
3561 | if (list_empty(&io->list)) | 3632 | if (list_empty(&io->list)) |
3562 | return ret; | 3633 | return ret; |
3563 | 3634 | ||
3564 | if (io->flag != DIO_AIO_UNWRITTEN) | 3635 | if (io->flag != EXT4_IO_UNWRITTEN) |
3565 | return ret; | 3636 | return ret; |
3566 | 3637 | ||
3567 | if (offset + size <= i_size_read(inode)) | 3638 | ret = ext4_convert_unwritten_extents(inode, offset, size); |
3568 | ret = ext4_convert_unwritten_extents(inode, offset, size); | ||
3569 | |||
3570 | if (ret < 0) { | 3639 | if (ret < 0) { |
3571 | printk(KERN_EMERG "%s: failed to convert unwritten" | 3640 | printk(KERN_EMERG "%s: failed to convert unwritten" |
3572 | "extents to written extents, error is %d" | 3641 | "extents to written extents, error is %d" |
@@ -3579,50 +3648,64 @@ static int ext4_end_aio_dio_nolock(ext4_io_end_t *io) | |||
3579 | io->flag = 0; | 3648 | io->flag = 0; |
3580 | return ret; | 3649 | return ret; |
3581 | } | 3650 | } |
3651 | |||
3582 | /* | 3652 | /* |
3583 | * work on completed aio dio IO, to convert unwritten extents to extents | 3653 | * work on completed aio dio IO, to convert unwritten extents to extents |
3584 | */ | 3654 | */ |
3585 | static void ext4_end_aio_dio_work(struct work_struct *work) | 3655 | static void ext4_end_io_work(struct work_struct *work) |
3586 | { | 3656 | { |
3587 | ext4_io_end_t *io = container_of(work, ext4_io_end_t, work); | 3657 | ext4_io_end_t *io = container_of(work, ext4_io_end_t, work); |
3588 | struct inode *inode = io->inode; | 3658 | struct inode *inode = io->inode; |
3589 | int ret = 0; | 3659 | struct ext4_inode_info *ei = EXT4_I(inode); |
3660 | unsigned long flags; | ||
3661 | int ret; | ||
3590 | 3662 | ||
3591 | mutex_lock(&inode->i_mutex); | 3663 | mutex_lock(&inode->i_mutex); |
3592 | ret = ext4_end_aio_dio_nolock(io); | 3664 | ret = ext4_end_io_nolock(io); |
3593 | if (ret >= 0) { | 3665 | if (ret < 0) { |
3594 | if (!list_empty(&io->list)) | 3666 | mutex_unlock(&inode->i_mutex); |
3595 | list_del_init(&io->list); | 3667 | return; |
3596 | ext4_free_io_end(io); | ||
3597 | } | 3668 | } |
3669 | |||
3670 | spin_lock_irqsave(&ei->i_completed_io_lock, flags); | ||
3671 | if (!list_empty(&io->list)) | ||
3672 | list_del_init(&io->list); | ||
3673 | spin_unlock_irqrestore(&ei->i_completed_io_lock, flags); | ||
3598 | mutex_unlock(&inode->i_mutex); | 3674 | mutex_unlock(&inode->i_mutex); |
3675 | ext4_free_io_end(io); | ||
3599 | } | 3676 | } |
3677 | |||
3600 | /* | 3678 | /* |
3601 | * This function is called from ext4_sync_file(). | 3679 | * This function is called from ext4_sync_file(). |
3602 | * | 3680 | * |
3603 | * When AIO DIO IO is completed, the work to convert unwritten | 3681 | * When IO is completed, the work to convert unwritten extents to |
3604 | * extents to written is queued on workqueue but may not get immediately | 3682 | * written is queued on workqueue but may not get immediately |
3605 | * scheduled. When fsync is called, we need to ensure the | 3683 | * scheduled. When fsync is called, we need to ensure the |
3606 | * conversion is complete before fsync returns. | 3684 | * conversion is complete before fsync returns. |
3607 | * The inode keeps track of a list of completed AIO from DIO path | 3685 | * The inode keeps track of a list of pending/completed IO that |
3608 | * that might needs to do the conversion. This function walks through | 3686 | * might needs to do the conversion. This function walks through |
3609 | * the list and convert the related unwritten extents to written. | 3687 | * the list and convert the related unwritten extents for completed IO |
3688 | * to written. | ||
3689 | * The function return the number of pending IOs on success. | ||
3610 | */ | 3690 | */ |
3611 | int flush_aio_dio_completed_IO(struct inode *inode) | 3691 | int flush_completed_IO(struct inode *inode) |
3612 | { | 3692 | { |
3613 | ext4_io_end_t *io; | 3693 | ext4_io_end_t *io; |
3694 | struct ext4_inode_info *ei = EXT4_I(inode); | ||
3695 | unsigned long flags; | ||
3614 | int ret = 0; | 3696 | int ret = 0; |
3615 | int ret2 = 0; | 3697 | int ret2 = 0; |
3616 | 3698 | ||
3617 | if (list_empty(&EXT4_I(inode)->i_aio_dio_complete_list)) | 3699 | if (list_empty(&ei->i_completed_io_list)) |
3618 | return ret; | 3700 | return ret; |
3619 | 3701 | ||
3620 | dump_aio_dio_list(inode); | 3702 | dump_completed_IO(inode); |
3621 | while (!list_empty(&EXT4_I(inode)->i_aio_dio_complete_list)){ | 3703 | spin_lock_irqsave(&ei->i_completed_io_lock, flags); |
3622 | io = list_entry(EXT4_I(inode)->i_aio_dio_complete_list.next, | 3704 | while (!list_empty(&ei->i_completed_io_list)){ |
3705 | io = list_entry(ei->i_completed_io_list.next, | ||
3623 | ext4_io_end_t, list); | 3706 | ext4_io_end_t, list); |
3624 | /* | 3707 | /* |
3625 | * Calling ext4_end_aio_dio_nolock() to convert completed | 3708 | * Calling ext4_end_io_nolock() to convert completed |
3626 | * IO to written. | 3709 | * IO to written. |
3627 | * | 3710 | * |
3628 | * When ext4_sync_file() is called, run_queue() may already | 3711 | * When ext4_sync_file() is called, run_queue() may already |
@@ -3635,20 +3718,23 @@ int flush_aio_dio_completed_IO(struct inode *inode) | |||
3635 | * avoid double converting from both fsync and background work | 3718 | * avoid double converting from both fsync and background work |
3636 | * queue work. | 3719 | * queue work. |
3637 | */ | 3720 | */ |
3638 | ret = ext4_end_aio_dio_nolock(io); | 3721 | spin_unlock_irqrestore(&ei->i_completed_io_lock, flags); |
3722 | ret = ext4_end_io_nolock(io); | ||
3723 | spin_lock_irqsave(&ei->i_completed_io_lock, flags); | ||
3639 | if (ret < 0) | 3724 | if (ret < 0) |
3640 | ret2 = ret; | 3725 | ret2 = ret; |
3641 | else | 3726 | else |
3642 | list_del_init(&io->list); | 3727 | list_del_init(&io->list); |
3643 | } | 3728 | } |
3729 | spin_unlock_irqrestore(&ei->i_completed_io_lock, flags); | ||
3644 | return (ret2 < 0) ? ret2 : 0; | 3730 | return (ret2 < 0) ? ret2 : 0; |
3645 | } | 3731 | } |
3646 | 3732 | ||
3647 | static ext4_io_end_t *ext4_init_io_end (struct inode *inode) | 3733 | static ext4_io_end_t *ext4_init_io_end (struct inode *inode, gfp_t flags) |
3648 | { | 3734 | { |
3649 | ext4_io_end_t *io = NULL; | 3735 | ext4_io_end_t *io = NULL; |
3650 | 3736 | ||
3651 | io = kmalloc(sizeof(*io), GFP_NOFS); | 3737 | io = kmalloc(sizeof(*io), flags); |
3652 | 3738 | ||
3653 | if (io) { | 3739 | if (io) { |
3654 | igrab(inode); | 3740 | igrab(inode); |
@@ -3656,8 +3742,8 @@ static ext4_io_end_t *ext4_init_io_end (struct inode *inode) | |||
3656 | io->flag = 0; | 3742 | io->flag = 0; |
3657 | io->offset = 0; | 3743 | io->offset = 0; |
3658 | io->size = 0; | 3744 | io->size = 0; |
3659 | io->error = 0; | 3745 | io->page = NULL; |
3660 | INIT_WORK(&io->work, ext4_end_aio_dio_work); | 3746 | INIT_WORK(&io->work, ext4_end_io_work); |
3661 | INIT_LIST_HEAD(&io->list); | 3747 | INIT_LIST_HEAD(&io->list); |
3662 | } | 3748 | } |
3663 | 3749 | ||
@@ -3669,6 +3755,8 @@ static void ext4_end_io_dio(struct kiocb *iocb, loff_t offset, | |||
3669 | { | 3755 | { |
3670 | ext4_io_end_t *io_end = iocb->private; | 3756 | ext4_io_end_t *io_end = iocb->private; |
3671 | struct workqueue_struct *wq; | 3757 | struct workqueue_struct *wq; |
3758 | unsigned long flags; | ||
3759 | struct ext4_inode_info *ei; | ||
3672 | 3760 | ||
3673 | /* if not async direct IO or dio with 0 bytes write, just return */ | 3761 | /* if not async direct IO or dio with 0 bytes write, just return */ |
3674 | if (!io_end || !size) | 3762 | if (!io_end || !size) |
@@ -3680,7 +3768,7 @@ static void ext4_end_io_dio(struct kiocb *iocb, loff_t offset, | |||
3680 | size); | 3768 | size); |
3681 | 3769 | ||
3682 | /* if not aio dio with unwritten extents, just free io and return */ | 3770 | /* if not aio dio with unwritten extents, just free io and return */ |
3683 | if (io_end->flag != DIO_AIO_UNWRITTEN){ | 3771 | if (io_end->flag != EXT4_IO_UNWRITTEN){ |
3684 | ext4_free_io_end(io_end); | 3772 | ext4_free_io_end(io_end); |
3685 | iocb->private = NULL; | 3773 | iocb->private = NULL; |
3686 | return; | 3774 | return; |
@@ -3688,16 +3776,85 @@ static void ext4_end_io_dio(struct kiocb *iocb, loff_t offset, | |||
3688 | 3776 | ||
3689 | io_end->offset = offset; | 3777 | io_end->offset = offset; |
3690 | io_end->size = size; | 3778 | io_end->size = size; |
3779 | io_end->flag = EXT4_IO_UNWRITTEN; | ||
3691 | wq = EXT4_SB(io_end->inode->i_sb)->dio_unwritten_wq; | 3780 | wq = EXT4_SB(io_end->inode->i_sb)->dio_unwritten_wq; |
3692 | 3781 | ||
3693 | /* queue the work to convert unwritten extents to written */ | 3782 | /* queue the work to convert unwritten extents to written */ |
3694 | queue_work(wq, &io_end->work); | 3783 | queue_work(wq, &io_end->work); |
3695 | 3784 | ||
3696 | /* Add the io_end to per-inode completed aio dio list*/ | 3785 | /* Add the io_end to per-inode completed aio dio list*/ |
3697 | list_add_tail(&io_end->list, | 3786 | ei = EXT4_I(io_end->inode); |
3698 | &EXT4_I(io_end->inode)->i_aio_dio_complete_list); | 3787 | spin_lock_irqsave(&ei->i_completed_io_lock, flags); |
3788 | list_add_tail(&io_end->list, &ei->i_completed_io_list); | ||
3789 | spin_unlock_irqrestore(&ei->i_completed_io_lock, flags); | ||
3699 | iocb->private = NULL; | 3790 | iocb->private = NULL; |
3700 | } | 3791 | } |
3792 | |||
3793 | static void ext4_end_io_buffer_write(struct buffer_head *bh, int uptodate) | ||
3794 | { | ||
3795 | ext4_io_end_t *io_end = bh->b_private; | ||
3796 | struct workqueue_struct *wq; | ||
3797 | struct inode *inode; | ||
3798 | unsigned long flags; | ||
3799 | |||
3800 | if (!test_clear_buffer_uninit(bh) || !io_end) | ||
3801 | goto out; | ||
3802 | |||
3803 | if (!(io_end->inode->i_sb->s_flags & MS_ACTIVE)) { | ||
3804 | printk("sb umounted, discard end_io request for inode %lu\n", | ||
3805 | io_end->inode->i_ino); | ||
3806 | ext4_free_io_end(io_end); | ||
3807 | goto out; | ||
3808 | } | ||
3809 | |||
3810 | io_end->flag = EXT4_IO_UNWRITTEN; | ||
3811 | inode = io_end->inode; | ||
3812 | |||
3813 | /* Add the io_end to per-inode completed io list*/ | ||
3814 | spin_lock_irqsave(&EXT4_I(inode)->i_completed_io_lock, flags); | ||
3815 | list_add_tail(&io_end->list, &EXT4_I(inode)->i_completed_io_list); | ||
3816 | spin_unlock_irqrestore(&EXT4_I(inode)->i_completed_io_lock, flags); | ||
3817 | |||
3818 | wq = EXT4_SB(inode->i_sb)->dio_unwritten_wq; | ||
3819 | /* queue the work to convert unwritten extents to written */ | ||
3820 | queue_work(wq, &io_end->work); | ||
3821 | out: | ||
3822 | bh->b_private = NULL; | ||
3823 | bh->b_end_io = NULL; | ||
3824 | clear_buffer_uninit(bh); | ||
3825 | end_buffer_async_write(bh, uptodate); | ||
3826 | } | ||
3827 | |||
3828 | static int ext4_set_bh_endio(struct buffer_head *bh, struct inode *inode) | ||
3829 | { | ||
3830 | ext4_io_end_t *io_end; | ||
3831 | struct page *page = bh->b_page; | ||
3832 | loff_t offset = (sector_t)page->index << PAGE_CACHE_SHIFT; | ||
3833 | size_t size = bh->b_size; | ||
3834 | |||
3835 | retry: | ||
3836 | io_end = ext4_init_io_end(inode, GFP_ATOMIC); | ||
3837 | if (!io_end) { | ||
3838 | if (printk_ratelimit()) | ||
3839 | printk(KERN_WARNING "%s: allocation fail\n", __func__); | ||
3840 | schedule(); | ||
3841 | goto retry; | ||
3842 | } | ||
3843 | io_end->offset = offset; | ||
3844 | io_end->size = size; | ||
3845 | /* | ||
3846 | * We need to hold a reference to the page to make sure it | ||
3847 | * doesn't get evicted before ext4_end_io_work() has a chance | ||
3848 | * to convert the extent from written to unwritten. | ||
3849 | */ | ||
3850 | io_end->page = page; | ||
3851 | get_page(io_end->page); | ||
3852 | |||
3853 | bh->b_private = io_end; | ||
3854 | bh->b_end_io = ext4_end_io_buffer_write; | ||
3855 | return 0; | ||
3856 | } | ||
3857 | |||
3701 | /* | 3858 | /* |
3702 | * For ext4 extent files, ext4 will do direct-io write to holes, | 3859 | * For ext4 extent files, ext4 will do direct-io write to holes, |
3703 | * preallocated extents, and those write extend the file, no need to | 3860 | * preallocated extents, and those write extend the file, no need to |
@@ -3751,7 +3908,7 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb, | |||
3751 | iocb->private = NULL; | 3908 | iocb->private = NULL; |
3752 | EXT4_I(inode)->cur_aio_dio = NULL; | 3909 | EXT4_I(inode)->cur_aio_dio = NULL; |
3753 | if (!is_sync_kiocb(iocb)) { | 3910 | if (!is_sync_kiocb(iocb)) { |
3754 | iocb->private = ext4_init_io_end(inode); | 3911 | iocb->private = ext4_init_io_end(inode, GFP_NOFS); |
3755 | if (!iocb->private) | 3912 | if (!iocb->private) |
3756 | return -ENOMEM; | 3913 | return -ENOMEM; |
3757 | /* | 3914 | /* |
@@ -3767,7 +3924,7 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb, | |||
3767 | ret = blockdev_direct_IO(rw, iocb, inode, | 3924 | ret = blockdev_direct_IO(rw, iocb, inode, |
3768 | inode->i_sb->s_bdev, iov, | 3925 | inode->i_sb->s_bdev, iov, |
3769 | offset, nr_segs, | 3926 | offset, nr_segs, |
3770 | ext4_get_block_dio_write, | 3927 | ext4_get_block_write, |
3771 | ext4_end_io_dio); | 3928 | ext4_end_io_dio); |
3772 | if (iocb->private) | 3929 | if (iocb->private) |
3773 | EXT4_I(inode)->cur_aio_dio = NULL; | 3930 | EXT4_I(inode)->cur_aio_dio = NULL; |
@@ -3788,8 +3945,8 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb, | |||
3788 | if (ret != -EIOCBQUEUED && ret <= 0 && iocb->private) { | 3945 | if (ret != -EIOCBQUEUED && ret <= 0 && iocb->private) { |
3789 | ext4_free_io_end(iocb->private); | 3946 | ext4_free_io_end(iocb->private); |
3790 | iocb->private = NULL; | 3947 | iocb->private = NULL; |
3791 | } else if (ret > 0 && (EXT4_I(inode)->i_state & | 3948 | } else if (ret > 0 && ext4_test_inode_state(inode, |
3792 | EXT4_STATE_DIO_UNWRITTEN)) { | 3949 | EXT4_STATE_DIO_UNWRITTEN)) { |
3793 | int err; | 3950 | int err; |
3794 | /* | 3951 | /* |
3795 | * for non AIO case, since the IO is already | 3952 | * for non AIO case, since the IO is already |
@@ -3799,7 +3956,7 @@ static ssize_t ext4_ext_direct_IO(int rw, struct kiocb *iocb, | |||
3799 | offset, ret); | 3956 | offset, ret); |
3800 | if (err < 0) | 3957 | if (err < 0) |
3801 | ret = err; | 3958 | ret = err; |
3802 | EXT4_I(inode)->i_state &= ~EXT4_STATE_DIO_UNWRITTEN; | 3959 | ext4_clear_inode_state(inode, EXT4_STATE_DIO_UNWRITTEN); |
3803 | } | 3960 | } |
3804 | return ret; | 3961 | return ret; |
3805 | } | 3962 | } |
@@ -4130,18 +4287,27 @@ no_top: | |||
4130 | * We release `count' blocks on disk, but (last - first) may be greater | 4287 | * We release `count' blocks on disk, but (last - first) may be greater |
4131 | * than `count' because there can be holes in there. | 4288 | * than `count' because there can be holes in there. |
4132 | */ | 4289 | */ |
4133 | static void ext4_clear_blocks(handle_t *handle, struct inode *inode, | 4290 | static int ext4_clear_blocks(handle_t *handle, struct inode *inode, |
4134 | struct buffer_head *bh, | 4291 | struct buffer_head *bh, |
4135 | ext4_fsblk_t block_to_free, | 4292 | ext4_fsblk_t block_to_free, |
4136 | unsigned long count, __le32 *first, | 4293 | unsigned long count, __le32 *first, |
4137 | __le32 *last) | 4294 | __le32 *last) |
4138 | { | 4295 | { |
4139 | __le32 *p; | 4296 | __le32 *p; |
4140 | int flags = EXT4_FREE_BLOCKS_FORGET; | 4297 | int flags = EXT4_FREE_BLOCKS_FORGET | EXT4_FREE_BLOCKS_VALIDATED; |
4141 | 4298 | ||
4142 | if (S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode)) | 4299 | if (S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode)) |
4143 | flags |= EXT4_FREE_BLOCKS_METADATA; | 4300 | flags |= EXT4_FREE_BLOCKS_METADATA; |
4144 | 4301 | ||
4302 | if (!ext4_data_block_valid(EXT4_SB(inode->i_sb), block_to_free, | ||
4303 | count)) { | ||
4304 | ext4_error(inode->i_sb, "inode #%lu: " | ||
4305 | "attempt to clear blocks %llu len %lu, invalid", | ||
4306 | inode->i_ino, (unsigned long long) block_to_free, | ||
4307 | count); | ||
4308 | return 1; | ||
4309 | } | ||
4310 | |||
4145 | if (try_to_extend_transaction(handle, inode)) { | 4311 | if (try_to_extend_transaction(handle, inode)) { |
4146 | if (bh) { | 4312 | if (bh) { |
4147 | BUFFER_TRACE(bh, "call ext4_handle_dirty_metadata"); | 4313 | BUFFER_TRACE(bh, "call ext4_handle_dirty_metadata"); |
@@ -4160,6 +4326,7 @@ static void ext4_clear_blocks(handle_t *handle, struct inode *inode, | |||
4160 | *p = 0; | 4326 | *p = 0; |
4161 | 4327 | ||
4162 | ext4_free_blocks(handle, inode, 0, block_to_free, count, flags); | 4328 | ext4_free_blocks(handle, inode, 0, block_to_free, count, flags); |
4329 | return 0; | ||
4163 | } | 4330 | } |
4164 | 4331 | ||
4165 | /** | 4332 | /** |
@@ -4215,9 +4382,10 @@ static void ext4_free_data(handle_t *handle, struct inode *inode, | |||
4215 | } else if (nr == block_to_free + count) { | 4382 | } else if (nr == block_to_free + count) { |
4216 | count++; | 4383 | count++; |
4217 | } else { | 4384 | } else { |
4218 | ext4_clear_blocks(handle, inode, this_bh, | 4385 | if (ext4_clear_blocks(handle, inode, this_bh, |
4219 | block_to_free, | 4386 | block_to_free, count, |
4220 | count, block_to_free_p, p); | 4387 | block_to_free_p, p)) |
4388 | break; | ||
4221 | block_to_free = nr; | 4389 | block_to_free = nr; |
4222 | block_to_free_p = p; | 4390 | block_to_free_p = p; |
4223 | count = 1; | 4391 | count = 1; |
@@ -4241,7 +4409,7 @@ static void ext4_free_data(handle_t *handle, struct inode *inode, | |||
4241 | if ((EXT4_JOURNAL(inode) == NULL) || bh2jh(this_bh)) | 4409 | if ((EXT4_JOURNAL(inode) == NULL) || bh2jh(this_bh)) |
4242 | ext4_handle_dirty_metadata(handle, inode, this_bh); | 4410 | ext4_handle_dirty_metadata(handle, inode, this_bh); |
4243 | else | 4411 | else |
4244 | ext4_error(inode->i_sb, __func__, | 4412 | ext4_error(inode->i_sb, |
4245 | "circular indirect block detected, " | 4413 | "circular indirect block detected, " |
4246 | "inode=%lu, block=%llu", | 4414 | "inode=%lu, block=%llu", |
4247 | inode->i_ino, | 4415 | inode->i_ino, |
@@ -4281,6 +4449,16 @@ static void ext4_free_branches(handle_t *handle, struct inode *inode, | |||
4281 | if (!nr) | 4449 | if (!nr) |
4282 | continue; /* A hole */ | 4450 | continue; /* A hole */ |
4283 | 4451 | ||
4452 | if (!ext4_data_block_valid(EXT4_SB(inode->i_sb), | ||
4453 | nr, 1)) { | ||
4454 | ext4_error(inode->i_sb, | ||
4455 | "indirect mapped block in inode " | ||
4456 | "#%lu invalid (level %d, blk #%lu)", | ||
4457 | inode->i_ino, depth, | ||
4458 | (unsigned long) nr); | ||
4459 | break; | ||
4460 | } | ||
4461 | |||
4284 | /* Go read the buffer for the next level down */ | 4462 | /* Go read the buffer for the next level down */ |
4285 | bh = sb_bread(inode->i_sb, nr); | 4463 | bh = sb_bread(inode->i_sb, nr); |
4286 | 4464 | ||
@@ -4289,7 +4467,7 @@ static void ext4_free_branches(handle_t *handle, struct inode *inode, | |||
4289 | * (should be rare). | 4467 | * (should be rare). |
4290 | */ | 4468 | */ |
4291 | if (!bh) { | 4469 | if (!bh) { |
4292 | ext4_error(inode->i_sb, "ext4_free_branches", | 4470 | ext4_error(inode->i_sb, |
4293 | "Read failure, inode=%lu, block=%llu", | 4471 | "Read failure, inode=%lu, block=%llu", |
4294 | inode->i_ino, nr); | 4472 | inode->i_ino, nr); |
4295 | continue; | 4473 | continue; |
@@ -4433,8 +4611,10 @@ void ext4_truncate(struct inode *inode) | |||
4433 | if (!ext4_can_truncate(inode)) | 4611 | if (!ext4_can_truncate(inode)) |
4434 | return; | 4612 | return; |
4435 | 4613 | ||
4614 | EXT4_I(inode)->i_flags &= ~EXT4_EOFBLOCKS_FL; | ||
4615 | |||
4436 | if (inode->i_size == 0 && !test_opt(inode->i_sb, NO_AUTO_DA_ALLOC)) | 4616 | if (inode->i_size == 0 && !test_opt(inode->i_sb, NO_AUTO_DA_ALLOC)) |
4437 | ei->i_state |= EXT4_STATE_DA_ALLOC_CLOSE; | 4617 | ext4_set_inode_state(inode, EXT4_STATE_DA_ALLOC_CLOSE); |
4438 | 4618 | ||
4439 | if (EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) { | 4619 | if (EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) { |
4440 | ext4_ext_truncate(inode); | 4620 | ext4_ext_truncate(inode); |
@@ -4604,9 +4784,8 @@ static int __ext4_get_inode_loc(struct inode *inode, | |||
4604 | 4784 | ||
4605 | bh = sb_getblk(sb, block); | 4785 | bh = sb_getblk(sb, block); |
4606 | if (!bh) { | 4786 | if (!bh) { |
4607 | ext4_error(sb, "ext4_get_inode_loc", "unable to read " | 4787 | ext4_error(sb, "unable to read inode block - " |
4608 | "inode block - inode=%lu, block=%llu", | 4788 | "inode=%lu, block=%llu", inode->i_ino, block); |
4609 | inode->i_ino, block); | ||
4610 | return -EIO; | 4789 | return -EIO; |
4611 | } | 4790 | } |
4612 | if (!buffer_uptodate(bh)) { | 4791 | if (!buffer_uptodate(bh)) { |
@@ -4704,9 +4883,8 @@ make_io: | |||
4704 | submit_bh(READ_META, bh); | 4883 | submit_bh(READ_META, bh); |
4705 | wait_on_buffer(bh); | 4884 | wait_on_buffer(bh); |
4706 | if (!buffer_uptodate(bh)) { | 4885 | if (!buffer_uptodate(bh)) { |
4707 | ext4_error(sb, __func__, | 4886 | ext4_error(sb, "unable to read inode block - inode=%lu," |
4708 | "unable to read inode block - inode=%lu, " | 4887 | " block=%llu", inode->i_ino, block); |
4709 | "block=%llu", inode->i_ino, block); | ||
4710 | brelse(bh); | 4888 | brelse(bh); |
4711 | return -EIO; | 4889 | return -EIO; |
4712 | } | 4890 | } |
@@ -4720,7 +4898,7 @@ int ext4_get_inode_loc(struct inode *inode, struct ext4_iloc *iloc) | |||
4720 | { | 4898 | { |
4721 | /* We have all inode data except xattrs in memory here. */ | 4899 | /* We have all inode data except xattrs in memory here. */ |
4722 | return __ext4_get_inode_loc(inode, iloc, | 4900 | return __ext4_get_inode_loc(inode, iloc, |
4723 | !(EXT4_I(inode)->i_state & EXT4_STATE_XATTR)); | 4901 | !ext4_test_inode_state(inode, EXT4_STATE_XATTR)); |
4724 | } | 4902 | } |
4725 | 4903 | ||
4726 | void ext4_set_inode_flags(struct inode *inode) | 4904 | void ext4_set_inode_flags(struct inode *inode) |
@@ -4814,7 +4992,7 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
4814 | } | 4992 | } |
4815 | inode->i_nlink = le16_to_cpu(raw_inode->i_links_count); | 4993 | inode->i_nlink = le16_to_cpu(raw_inode->i_links_count); |
4816 | 4994 | ||
4817 | ei->i_state = 0; | 4995 | ei->i_state_flags = 0; |
4818 | ei->i_dir_start_lookup = 0; | 4996 | ei->i_dir_start_lookup = 0; |
4819 | ei->i_dtime = le32_to_cpu(raw_inode->i_dtime); | 4997 | ei->i_dtime = le32_to_cpu(raw_inode->i_dtime); |
4820 | /* We now have enough fields to check if the inode was active or not. | 4998 | /* We now have enough fields to check if the inode was active or not. |
@@ -4897,7 +5075,7 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
4897 | EXT4_GOOD_OLD_INODE_SIZE + | 5075 | EXT4_GOOD_OLD_INODE_SIZE + |
4898 | ei->i_extra_isize; | 5076 | ei->i_extra_isize; |
4899 | if (*magic == cpu_to_le32(EXT4_XATTR_MAGIC)) | 5077 | if (*magic == cpu_to_le32(EXT4_XATTR_MAGIC)) |
4900 | ei->i_state |= EXT4_STATE_XATTR; | 5078 | ext4_set_inode_state(inode, EXT4_STATE_XATTR); |
4901 | } | 5079 | } |
4902 | } else | 5080 | } else |
4903 | ei->i_extra_isize = 0; | 5081 | ei->i_extra_isize = 0; |
@@ -4917,8 +5095,7 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
4917 | ret = 0; | 5095 | ret = 0; |
4918 | if (ei->i_file_acl && | 5096 | if (ei->i_file_acl && |
4919 | !ext4_data_block_valid(EXT4_SB(sb), ei->i_file_acl, 1)) { | 5097 | !ext4_data_block_valid(EXT4_SB(sb), ei->i_file_acl, 1)) { |
4920 | ext4_error(sb, __func__, | 5098 | ext4_error(sb, "bad extended attribute block %llu inode #%lu", |
4921 | "bad extended attribute block %llu in inode #%lu", | ||
4922 | ei->i_file_acl, inode->i_ino); | 5099 | ei->i_file_acl, inode->i_ino); |
4923 | ret = -EIO; | 5100 | ret = -EIO; |
4924 | goto bad_inode; | 5101 | goto bad_inode; |
@@ -4964,8 +5141,7 @@ struct inode *ext4_iget(struct super_block *sb, unsigned long ino) | |||
4964 | new_decode_dev(le32_to_cpu(raw_inode->i_block[1]))); | 5141 | new_decode_dev(le32_to_cpu(raw_inode->i_block[1]))); |
4965 | } else { | 5142 | } else { |
4966 | ret = -EIO; | 5143 | ret = -EIO; |
4967 | ext4_error(inode->i_sb, __func__, | 5144 | ext4_error(inode->i_sb, "bogus i_mode (%o) for inode=%lu", |
4968 | "bogus i_mode (%o) for inode=%lu", | ||
4969 | inode->i_mode, inode->i_ino); | 5145 | inode->i_mode, inode->i_ino); |
4970 | goto bad_inode; | 5146 | goto bad_inode; |
4971 | } | 5147 | } |
@@ -5037,7 +5213,7 @@ static int ext4_do_update_inode(handle_t *handle, | |||
5037 | 5213 | ||
5038 | /* For fields not not tracking in the in-memory inode, | 5214 | /* For fields not not tracking in the in-memory inode, |
5039 | * initialise them to zero for new inodes. */ | 5215 | * initialise them to zero for new inodes. */ |
5040 | if (ei->i_state & EXT4_STATE_NEW) | 5216 | if (ext4_test_inode_state(inode, EXT4_STATE_NEW)) |
5041 | memset(raw_inode, 0, EXT4_SB(inode->i_sb)->s_inode_size); | 5217 | memset(raw_inode, 0, EXT4_SB(inode->i_sb)->s_inode_size); |
5042 | 5218 | ||
5043 | ext4_get_inode_flags(ei); | 5219 | ext4_get_inode_flags(ei); |
@@ -5101,7 +5277,7 @@ static int ext4_do_update_inode(handle_t *handle, | |||
5101 | EXT4_FEATURE_RO_COMPAT_LARGE_FILE); | 5277 | EXT4_FEATURE_RO_COMPAT_LARGE_FILE); |
5102 | sb->s_dirt = 1; | 5278 | sb->s_dirt = 1; |
5103 | ext4_handle_sync(handle); | 5279 | ext4_handle_sync(handle); |
5104 | err = ext4_handle_dirty_metadata(handle, inode, | 5280 | err = ext4_handle_dirty_metadata(handle, NULL, |
5105 | EXT4_SB(sb)->s_sbh); | 5281 | EXT4_SB(sb)->s_sbh); |
5106 | } | 5282 | } |
5107 | } | 5283 | } |
@@ -5130,10 +5306,10 @@ static int ext4_do_update_inode(handle_t *handle, | |||
5130 | } | 5306 | } |
5131 | 5307 | ||
5132 | BUFFER_TRACE(bh, "call ext4_handle_dirty_metadata"); | 5308 | BUFFER_TRACE(bh, "call ext4_handle_dirty_metadata"); |
5133 | rc = ext4_handle_dirty_metadata(handle, inode, bh); | 5309 | rc = ext4_handle_dirty_metadata(handle, NULL, bh); |
5134 | if (!err) | 5310 | if (!err) |
5135 | err = rc; | 5311 | err = rc; |
5136 | ei->i_state &= ~EXT4_STATE_NEW; | 5312 | ext4_clear_inode_state(inode, EXT4_STATE_NEW); |
5137 | 5313 | ||
5138 | ext4_update_inode_fsync_trans(handle, inode, 0); | 5314 | ext4_update_inode_fsync_trans(handle, inode, 0); |
5139 | out_brelse: | 5315 | out_brelse: |
@@ -5177,7 +5353,7 @@ out_brelse: | |||
5177 | * `stuff()' is running, and the new i_size will be lost. Plus the inode | 5353 | * `stuff()' is running, and the new i_size will be lost. Plus the inode |
5178 | * will no longer be on the superblock's dirty inode list. | 5354 | * will no longer be on the superblock's dirty inode list. |
5179 | */ | 5355 | */ |
5180 | int ext4_write_inode(struct inode *inode, int wait) | 5356 | int ext4_write_inode(struct inode *inode, struct writeback_control *wbc) |
5181 | { | 5357 | { |
5182 | int err; | 5358 | int err; |
5183 | 5359 | ||
@@ -5191,7 +5367,7 @@ int ext4_write_inode(struct inode *inode, int wait) | |||
5191 | return -EIO; | 5367 | return -EIO; |
5192 | } | 5368 | } |
5193 | 5369 | ||
5194 | if (!wait) | 5370 | if (wbc->sync_mode != WB_SYNC_ALL) |
5195 | return 0; | 5371 | return 0; |
5196 | 5372 | ||
5197 | err = ext4_force_commit(inode->i_sb); | 5373 | err = ext4_force_commit(inode->i_sb); |
@@ -5201,13 +5377,11 @@ int ext4_write_inode(struct inode *inode, int wait) | |||
5201 | err = ext4_get_inode_loc(inode, &iloc); | 5377 | err = ext4_get_inode_loc(inode, &iloc); |
5202 | if (err) | 5378 | if (err) |
5203 | return err; | 5379 | return err; |
5204 | if (wait) | 5380 | if (wbc->sync_mode == WB_SYNC_ALL) |
5205 | sync_dirty_buffer(iloc.bh); | 5381 | sync_dirty_buffer(iloc.bh); |
5206 | if (buffer_req(iloc.bh) && !buffer_uptodate(iloc.bh)) { | 5382 | if (buffer_req(iloc.bh) && !buffer_uptodate(iloc.bh)) { |
5207 | ext4_error(inode->i_sb, __func__, | 5383 | ext4_error(inode->i_sb, "IO error syncing inode, " |
5208 | "IO error syncing inode, " | 5384 | "inode=%lu, block=%llu", inode->i_ino, |
5209 | "inode=%lu, block=%llu", | ||
5210 | inode->i_ino, | ||
5211 | (unsigned long long)iloc.bh->b_blocknr); | 5385 | (unsigned long long)iloc.bh->b_blocknr); |
5212 | err = -EIO; | 5386 | err = -EIO; |
5213 | } | 5387 | } |
@@ -5249,6 +5423,8 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr) | |||
5249 | if (error) | 5423 | if (error) |
5250 | return error; | 5424 | return error; |
5251 | 5425 | ||
5426 | if (ia_valid & ATTR_SIZE) | ||
5427 | dquot_initialize(inode); | ||
5252 | if ((ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid) || | 5428 | if ((ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid) || |
5253 | (ia_valid & ATTR_GID && attr->ia_gid != inode->i_gid)) { | 5429 | (ia_valid & ATTR_GID && attr->ia_gid != inode->i_gid)) { |
5254 | handle_t *handle; | 5430 | handle_t *handle; |
@@ -5261,7 +5437,7 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr) | |||
5261 | error = PTR_ERR(handle); | 5437 | error = PTR_ERR(handle); |
5262 | goto err_out; | 5438 | goto err_out; |
5263 | } | 5439 | } |
5264 | error = vfs_dq_transfer(inode, attr) ? -EDQUOT : 0; | 5440 | error = dquot_transfer(inode, attr); |
5265 | if (error) { | 5441 | if (error) { |
5266 | ext4_journal_stop(handle); | 5442 | ext4_journal_stop(handle); |
5267 | return error; | 5443 | return error; |
@@ -5288,7 +5464,9 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr) | |||
5288 | } | 5464 | } |
5289 | 5465 | ||
5290 | if (S_ISREG(inode->i_mode) && | 5466 | if (S_ISREG(inode->i_mode) && |
5291 | attr->ia_valid & ATTR_SIZE && attr->ia_size < inode->i_size) { | 5467 | attr->ia_valid & ATTR_SIZE && |
5468 | (attr->ia_size < inode->i_size || | ||
5469 | (EXT4_I(inode)->i_flags & EXT4_EOFBLOCKS_FL))) { | ||
5292 | handle_t *handle; | 5470 | handle_t *handle; |
5293 | 5471 | ||
5294 | handle = ext4_journal_start(inode, 3); | 5472 | handle = ext4_journal_start(inode, 3); |
@@ -5319,6 +5497,9 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr) | |||
5319 | goto err_out; | 5497 | goto err_out; |
5320 | } | 5498 | } |
5321 | } | 5499 | } |
5500 | /* ext4_truncate will clear the flag */ | ||
5501 | if ((EXT4_I(inode)->i_flags & EXT4_EOFBLOCKS_FL)) | ||
5502 | ext4_truncate(inode); | ||
5322 | } | 5503 | } |
5323 | 5504 | ||
5324 | rc = inode_setattr(inode, attr); | 5505 | rc = inode_setattr(inode, attr); |
@@ -5557,8 +5738,8 @@ static int ext4_expand_extra_isize(struct inode *inode, | |||
5557 | entry = IFIRST(header); | 5738 | entry = IFIRST(header); |
5558 | 5739 | ||
5559 | /* No extended attributes present */ | 5740 | /* No extended attributes present */ |
5560 | if (!(EXT4_I(inode)->i_state & EXT4_STATE_XATTR) || | 5741 | if (!ext4_test_inode_state(inode, EXT4_STATE_XATTR) || |
5561 | header->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC)) { | 5742 | header->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC)) { |
5562 | memset((void *)raw_inode + EXT4_GOOD_OLD_INODE_SIZE, 0, | 5743 | memset((void *)raw_inode + EXT4_GOOD_OLD_INODE_SIZE, 0, |
5563 | new_extra_isize); | 5744 | new_extra_isize); |
5564 | EXT4_I(inode)->i_extra_isize = new_extra_isize; | 5745 | EXT4_I(inode)->i_extra_isize = new_extra_isize; |
@@ -5602,7 +5783,7 @@ int ext4_mark_inode_dirty(handle_t *handle, struct inode *inode) | |||
5602 | err = ext4_reserve_inode_write(handle, inode, &iloc); | 5783 | err = ext4_reserve_inode_write(handle, inode, &iloc); |
5603 | if (ext4_handle_valid(handle) && | 5784 | if (ext4_handle_valid(handle) && |
5604 | EXT4_I(inode)->i_extra_isize < sbi->s_want_extra_isize && | 5785 | EXT4_I(inode)->i_extra_isize < sbi->s_want_extra_isize && |
5605 | !(EXT4_I(inode)->i_state & EXT4_STATE_NO_EXPAND)) { | 5786 | !ext4_test_inode_state(inode, EXT4_STATE_NO_EXPAND)) { |
5606 | /* | 5787 | /* |
5607 | * We need extra buffer credits since we may write into EA block | 5788 | * We need extra buffer credits since we may write into EA block |
5608 | * with this same handle. If journal_extend fails, then it will | 5789 | * with this same handle. If journal_extend fails, then it will |
@@ -5616,10 +5797,11 @@ int ext4_mark_inode_dirty(handle_t *handle, struct inode *inode) | |||
5616 | sbi->s_want_extra_isize, | 5797 | sbi->s_want_extra_isize, |
5617 | iloc, handle); | 5798 | iloc, handle); |
5618 | if (ret) { | 5799 | if (ret) { |
5619 | EXT4_I(inode)->i_state |= EXT4_STATE_NO_EXPAND; | 5800 | ext4_set_inode_state(inode, |
5801 | EXT4_STATE_NO_EXPAND); | ||
5620 | if (mnt_count != | 5802 | if (mnt_count != |
5621 | le16_to_cpu(sbi->s_es->s_mnt_count)) { | 5803 | le16_to_cpu(sbi->s_es->s_mnt_count)) { |
5622 | ext4_warning(inode->i_sb, __func__, | 5804 | ext4_warning(inode->i_sb, |
5623 | "Unable to expand inode %lu. Delete" | 5805 | "Unable to expand inode %lu. Delete" |
5624 | " some EAs or run e2fsck.", | 5806 | " some EAs or run e2fsck.", |
5625 | inode->i_ino); | 5807 | inode->i_ino); |
@@ -5641,7 +5823,7 @@ int ext4_mark_inode_dirty(handle_t *handle, struct inode *inode) | |||
5641 | * i_size has been changed by generic_commit_write() and we thus need | 5823 | * i_size has been changed by generic_commit_write() and we thus need |
5642 | * to include the updated inode in the current transaction. | 5824 | * to include the updated inode in the current transaction. |
5643 | * | 5825 | * |
5644 | * Also, vfs_dq_alloc_block() will always dirty the inode when blocks | 5826 | * Also, dquot_alloc_block() will always dirty the inode when blocks |
5645 | * are allocated to the file. | 5827 | * are allocated to the file. |
5646 | * | 5828 | * |
5647 | * If the inode is marked synchronous, we don't honour that here - doing | 5829 | * If the inode is marked synchronous, we don't honour that here - doing |
@@ -5683,7 +5865,7 @@ static int ext4_pin_inode(handle_t *handle, struct inode *inode) | |||
5683 | err = jbd2_journal_get_write_access(handle, iloc.bh); | 5865 | err = jbd2_journal_get_write_access(handle, iloc.bh); |
5684 | if (!err) | 5866 | if (!err) |
5685 | err = ext4_handle_dirty_metadata(handle, | 5867 | err = ext4_handle_dirty_metadata(handle, |
5686 | inode, | 5868 | NULL, |
5687 | iloc.bh); | 5869 | iloc.bh); |
5688 | brelse(iloc.bh); | 5870 | brelse(iloc.bh); |
5689 | } | 5871 | } |
diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index b63d193126db..016d0249294f 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c | |||
@@ -92,6 +92,15 @@ long ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) | |||
92 | flags &= ~EXT4_EXTENTS_FL; | 92 | flags &= ~EXT4_EXTENTS_FL; |
93 | } | 93 | } |
94 | 94 | ||
95 | if (flags & EXT4_EOFBLOCKS_FL) { | ||
96 | /* we don't support adding EOFBLOCKS flag */ | ||
97 | if (!(oldflags & EXT4_EOFBLOCKS_FL)) { | ||
98 | err = -EOPNOTSUPP; | ||
99 | goto flags_out; | ||
100 | } | ||
101 | } else if (oldflags & EXT4_EOFBLOCKS_FL) | ||
102 | ext4_truncate(inode); | ||
103 | |||
95 | handle = ext4_journal_start(inode, 1); | 104 | handle = ext4_journal_start(inode, 1); |
96 | if (IS_ERR(handle)) { | 105 | if (IS_ERR(handle)) { |
97 | err = PTR_ERR(handle); | 106 | err = PTR_ERR(handle); |
@@ -249,7 +258,8 @@ setversion_out: | |||
249 | if (me.moved_len > 0) | 258 | if (me.moved_len > 0) |
250 | file_remove_suid(donor_filp); | 259 | file_remove_suid(donor_filp); |
251 | 260 | ||
252 | if (copy_to_user((struct move_extent *)arg, &me, sizeof(me))) | 261 | if (copy_to_user((struct move_extent __user *)arg, |
262 | &me, sizeof(me))) | ||
253 | err = -EFAULT; | 263 | err = -EFAULT; |
254 | mext_out: | 264 | mext_out: |
255 | fput(donor_filp); | 265 | fput(donor_filp); |
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index d34afad3e137..506713a2ebd8 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c | |||
@@ -441,10 +441,9 @@ static void mb_free_blocks_double(struct inode *inode, struct ext4_buddy *e4b, | |||
441 | for (i = 0; i < count; i++) { | 441 | for (i = 0; i < count; i++) { |
442 | if (!mb_test_bit(first + i, e4b->bd_info->bb_bitmap)) { | 442 | if (!mb_test_bit(first + i, e4b->bd_info->bb_bitmap)) { |
443 | ext4_fsblk_t blocknr; | 443 | ext4_fsblk_t blocknr; |
444 | blocknr = e4b->bd_group * EXT4_BLOCKS_PER_GROUP(sb); | 444 | |
445 | blocknr = ext4_group_first_block_no(sb, e4b->bd_group); | ||
445 | blocknr += first + i; | 446 | blocknr += first + i; |
446 | blocknr += | ||
447 | le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block); | ||
448 | ext4_grp_locked_error(sb, e4b->bd_group, | 447 | ext4_grp_locked_error(sb, e4b->bd_group, |
449 | __func__, "double-free of inode" | 448 | __func__, "double-free of inode" |
450 | " %lu's block %llu(bit %u in group %u)", | 449 | " %lu's block %llu(bit %u in group %u)", |
@@ -1255,10 +1254,9 @@ static void mb_free_blocks(struct inode *inode, struct ext4_buddy *e4b, | |||
1255 | 1254 | ||
1256 | if (!mb_test_bit(block, EXT4_MB_BITMAP(e4b))) { | 1255 | if (!mb_test_bit(block, EXT4_MB_BITMAP(e4b))) { |
1257 | ext4_fsblk_t blocknr; | 1256 | ext4_fsblk_t blocknr; |
1258 | blocknr = e4b->bd_group * EXT4_BLOCKS_PER_GROUP(sb); | 1257 | |
1258 | blocknr = ext4_group_first_block_no(sb, e4b->bd_group); | ||
1259 | blocknr += block; | 1259 | blocknr += block; |
1260 | blocknr += | ||
1261 | le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block); | ||
1262 | ext4_grp_locked_error(sb, e4b->bd_group, | 1260 | ext4_grp_locked_error(sb, e4b->bd_group, |
1263 | __func__, "double-free of inode" | 1261 | __func__, "double-free of inode" |
1264 | " %lu's block %llu(bit %u in group %u)", | 1262 | " %lu's block %llu(bit %u in group %u)", |
@@ -1631,7 +1629,6 @@ int ext4_mb_find_by_goal(struct ext4_allocation_context *ac, | |||
1631 | int max; | 1629 | int max; |
1632 | int err; | 1630 | int err; |
1633 | struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb); | 1631 | struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb); |
1634 | struct ext4_super_block *es = sbi->s_es; | ||
1635 | struct ext4_free_extent ex; | 1632 | struct ext4_free_extent ex; |
1636 | 1633 | ||
1637 | if (!(ac->ac_flags & EXT4_MB_HINT_TRY_GOAL)) | 1634 | if (!(ac->ac_flags & EXT4_MB_HINT_TRY_GOAL)) |
@@ -1648,8 +1645,8 @@ int ext4_mb_find_by_goal(struct ext4_allocation_context *ac, | |||
1648 | if (max >= ac->ac_g_ex.fe_len && ac->ac_g_ex.fe_len == sbi->s_stripe) { | 1645 | if (max >= ac->ac_g_ex.fe_len && ac->ac_g_ex.fe_len == sbi->s_stripe) { |
1649 | ext4_fsblk_t start; | 1646 | ext4_fsblk_t start; |
1650 | 1647 | ||
1651 | start = (e4b->bd_group * EXT4_BLOCKS_PER_GROUP(ac->ac_sb)) + | 1648 | start = ext4_group_first_block_no(ac->ac_sb, e4b->bd_group) + |
1652 | ex.fe_start + le32_to_cpu(es->s_first_data_block); | 1649 | ex.fe_start; |
1653 | /* use do_div to get remainder (would be 64-bit modulo) */ | 1650 | /* use do_div to get remainder (would be 64-bit modulo) */ |
1654 | if (do_div(start, sbi->s_stripe) == 0) { | 1651 | if (do_div(start, sbi->s_stripe) == 0) { |
1655 | ac->ac_found++; | 1652 | ac->ac_found++; |
@@ -1803,8 +1800,8 @@ void ext4_mb_scan_aligned(struct ext4_allocation_context *ac, | |||
1803 | BUG_ON(sbi->s_stripe == 0); | 1800 | BUG_ON(sbi->s_stripe == 0); |
1804 | 1801 | ||
1805 | /* find first stripe-aligned block in group */ | 1802 | /* find first stripe-aligned block in group */ |
1806 | first_group_block = e4b->bd_group * EXT4_BLOCKS_PER_GROUP(sb) | 1803 | first_group_block = ext4_group_first_block_no(sb, e4b->bd_group); |
1807 | + le32_to_cpu(sbi->s_es->s_first_data_block); | 1804 | |
1808 | a = first_group_block + sbi->s_stripe - 1; | 1805 | a = first_group_block + sbi->s_stripe - 1; |
1809 | do_div(a, sbi->s_stripe); | 1806 | do_div(a, sbi->s_stripe); |
1810 | i = (a * sbi->s_stripe) - first_group_block; | 1807 | i = (a * sbi->s_stripe) - first_group_block; |
@@ -2256,7 +2253,7 @@ int ext4_mb_add_groupinfo(struct super_block *sb, ext4_group_t group, | |||
2256 | 2253 | ||
2257 | INIT_LIST_HEAD(&meta_group_info[i]->bb_prealloc_list); | 2254 | INIT_LIST_HEAD(&meta_group_info[i]->bb_prealloc_list); |
2258 | init_rwsem(&meta_group_info[i]->alloc_sem); | 2255 | init_rwsem(&meta_group_info[i]->alloc_sem); |
2259 | meta_group_info[i]->bb_free_root.rb_node = NULL; | 2256 | meta_group_info[i]->bb_free_root = RB_ROOT; |
2260 | 2257 | ||
2261 | #ifdef DOUBLE_CHECK | 2258 | #ifdef DOUBLE_CHECK |
2262 | { | 2259 | { |
@@ -2560,12 +2557,9 @@ static void release_blocks_on_commit(journal_t *journal, transaction_t *txn) | |||
2560 | ext4_unlock_group(sb, entry->group); | 2557 | ext4_unlock_group(sb, entry->group); |
2561 | if (test_opt(sb, DISCARD)) { | 2558 | if (test_opt(sb, DISCARD)) { |
2562 | ext4_fsblk_t discard_block; | 2559 | ext4_fsblk_t discard_block; |
2563 | struct ext4_super_block *es = EXT4_SB(sb)->s_es; | ||
2564 | 2560 | ||
2565 | discard_block = (ext4_fsblk_t)entry->group * | 2561 | discard_block = entry->start_blk + |
2566 | EXT4_BLOCKS_PER_GROUP(sb) | 2562 | ext4_group_first_block_no(sb, entry->group); |
2567 | + entry->start_blk | ||
2568 | + le32_to_cpu(es->s_first_data_block); | ||
2569 | trace_ext4_discard_blocks(sb, | 2563 | trace_ext4_discard_blocks(sb, |
2570 | (unsigned long long)discard_block, | 2564 | (unsigned long long)discard_block, |
2571 | entry->count); | 2565 | entry->count); |
@@ -2703,14 +2697,11 @@ ext4_mb_mark_diskspace_used(struct ext4_allocation_context *ac, | |||
2703 | if (err) | 2697 | if (err) |
2704 | goto out_err; | 2698 | goto out_err; |
2705 | 2699 | ||
2706 | block = ac->ac_b_ex.fe_group * EXT4_BLOCKS_PER_GROUP(sb) | 2700 | block = ext4_grp_offs_to_block(sb, &ac->ac_b_ex); |
2707 | + ac->ac_b_ex.fe_start | ||
2708 | + le32_to_cpu(es->s_first_data_block); | ||
2709 | 2701 | ||
2710 | len = ac->ac_b_ex.fe_len; | 2702 | len = ac->ac_b_ex.fe_len; |
2711 | if (!ext4_data_block_valid(sbi, block, len)) { | 2703 | if (!ext4_data_block_valid(sbi, block, len)) { |
2712 | ext4_error(sb, __func__, | 2704 | ext4_error(sb, "Allocating blocks %llu-%llu which overlap " |
2713 | "Allocating blocks %llu-%llu which overlap " | ||
2714 | "fs metadata\n", block, block+len); | 2705 | "fs metadata\n", block, block+len); |
2715 | /* File system mounted not to panic on error | 2706 | /* File system mounted not to panic on error |
2716 | * Fix the bitmap and repeat the block allocation | 2707 | * Fix the bitmap and repeat the block allocation |
@@ -3161,9 +3152,7 @@ ext4_mb_use_preallocated(struct ext4_allocation_context *ac) | |||
3161 | /* The max size of hash table is PREALLOC_TB_SIZE */ | 3152 | /* The max size of hash table is PREALLOC_TB_SIZE */ |
3162 | order = PREALLOC_TB_SIZE - 1; | 3153 | order = PREALLOC_TB_SIZE - 1; |
3163 | 3154 | ||
3164 | goal_block = ac->ac_g_ex.fe_group * EXT4_BLOCKS_PER_GROUP(ac->ac_sb) + | 3155 | goal_block = ext4_grp_offs_to_block(ac->ac_sb, &ac->ac_g_ex); |
3165 | ac->ac_g_ex.fe_start + | ||
3166 | le32_to_cpu(EXT4_SB(ac->ac_sb)->s_es->s_first_data_block); | ||
3167 | /* | 3156 | /* |
3168 | * search for the prealloc space that is having | 3157 | * search for the prealloc space that is having |
3169 | * minimal distance from the goal block. | 3158 | * minimal distance from the goal block. |
@@ -3526,8 +3515,7 @@ ext4_mb_release_inode_pa(struct ext4_buddy *e4b, struct buffer_head *bitmap_bh, | |||
3526 | if (bit >= end) | 3515 | if (bit >= end) |
3527 | break; | 3516 | break; |
3528 | next = mb_find_next_bit(bitmap_bh->b_data, end, bit); | 3517 | next = mb_find_next_bit(bitmap_bh->b_data, end, bit); |
3529 | start = group * EXT4_BLOCKS_PER_GROUP(sb) + bit + | 3518 | start = ext4_group_first_block_no(sb, group) + bit; |
3530 | le32_to_cpu(sbi->s_es->s_first_data_block); | ||
3531 | mb_debug(1, " free preallocated %u/%u in group %u\n", | 3519 | mb_debug(1, " free preallocated %u/%u in group %u\n", |
3532 | (unsigned) start, (unsigned) next - bit, | 3520 | (unsigned) start, (unsigned) next - bit, |
3533 | (unsigned) group); | 3521 | (unsigned) group); |
@@ -3623,15 +3611,13 @@ ext4_mb_discard_group_preallocations(struct super_block *sb, | |||
3623 | 3611 | ||
3624 | bitmap_bh = ext4_read_block_bitmap(sb, group); | 3612 | bitmap_bh = ext4_read_block_bitmap(sb, group); |
3625 | if (bitmap_bh == NULL) { | 3613 | if (bitmap_bh == NULL) { |
3626 | ext4_error(sb, __func__, "Error in reading block " | 3614 | ext4_error(sb, "Error reading block bitmap for %u", group); |
3627 | "bitmap for %u", group); | ||
3628 | return 0; | 3615 | return 0; |
3629 | } | 3616 | } |
3630 | 3617 | ||
3631 | err = ext4_mb_load_buddy(sb, group, &e4b); | 3618 | err = ext4_mb_load_buddy(sb, group, &e4b); |
3632 | if (err) { | 3619 | if (err) { |
3633 | ext4_error(sb, __func__, "Error in loading buddy " | 3620 | ext4_error(sb, "Error loading buddy information for %u", group); |
3634 | "information for %u", group); | ||
3635 | put_bh(bitmap_bh); | 3621 | put_bh(bitmap_bh); |
3636 | return 0; | 3622 | return 0; |
3637 | } | 3623 | } |
@@ -3804,15 +3790,15 @@ repeat: | |||
3804 | 3790 | ||
3805 | err = ext4_mb_load_buddy(sb, group, &e4b); | 3791 | err = ext4_mb_load_buddy(sb, group, &e4b); |
3806 | if (err) { | 3792 | if (err) { |
3807 | ext4_error(sb, __func__, "Error in loading buddy " | 3793 | ext4_error(sb, "Error loading buddy information for %u", |
3808 | "information for %u", group); | 3794 | group); |
3809 | continue; | 3795 | continue; |
3810 | } | 3796 | } |
3811 | 3797 | ||
3812 | bitmap_bh = ext4_read_block_bitmap(sb, group); | 3798 | bitmap_bh = ext4_read_block_bitmap(sb, group); |
3813 | if (bitmap_bh == NULL) { | 3799 | if (bitmap_bh == NULL) { |
3814 | ext4_error(sb, __func__, "Error in reading block " | 3800 | ext4_error(sb, "Error reading block bitmap for %u", |
3815 | "bitmap for %u", group); | 3801 | group); |
3816 | ext4_mb_release_desc(&e4b); | 3802 | ext4_mb_release_desc(&e4b); |
3817 | continue; | 3803 | continue; |
3818 | } | 3804 | } |
@@ -3938,7 +3924,7 @@ static void ext4_mb_group_or_file(struct ext4_allocation_context *ac) | |||
3938 | 3924 | ||
3939 | /* don't use group allocation for large files */ | 3925 | /* don't use group allocation for large files */ |
3940 | size = max(size, isize); | 3926 | size = max(size, isize); |
3941 | if (size >= sbi->s_mb_stream_request) { | 3927 | if (size > sbi->s_mb_stream_request) { |
3942 | ac->ac_flags |= EXT4_MB_STREAM_ALLOC; | 3928 | ac->ac_flags |= EXT4_MB_STREAM_ALLOC; |
3943 | return; | 3929 | return; |
3944 | } | 3930 | } |
@@ -4077,8 +4063,8 @@ ext4_mb_discard_lg_preallocations(struct super_block *sb, | |||
4077 | 4063 | ||
4078 | ext4_get_group_no_and_offset(sb, pa->pa_pstart, &group, NULL); | 4064 | ext4_get_group_no_and_offset(sb, pa->pa_pstart, &group, NULL); |
4079 | if (ext4_mb_load_buddy(sb, group, &e4b)) { | 4065 | if (ext4_mb_load_buddy(sb, group, &e4b)) { |
4080 | ext4_error(sb, __func__, "Error in loading buddy " | 4066 | ext4_error(sb, "Error loading buddy information for %u", |
4081 | "information for %u", group); | 4067 | group); |
4082 | continue; | 4068 | continue; |
4083 | } | 4069 | } |
4084 | ext4_lock_group(sb, group); | 4070 | ext4_lock_group(sb, group); |
@@ -4254,7 +4240,7 @@ ext4_fsblk_t ext4_mb_new_blocks(handle_t *handle, | |||
4254 | return 0; | 4240 | return 0; |
4255 | } | 4241 | } |
4256 | reserv_blks = ar->len; | 4242 | reserv_blks = ar->len; |
4257 | while (ar->len && vfs_dq_alloc_block(ar->inode, ar->len)) { | 4243 | while (ar->len && dquot_alloc_block(ar->inode, ar->len)) { |
4258 | ar->flags |= EXT4_MB_HINT_NOPREALLOC; | 4244 | ar->flags |= EXT4_MB_HINT_NOPREALLOC; |
4259 | ar->len--; | 4245 | ar->len--; |
4260 | } | 4246 | } |
@@ -4331,7 +4317,7 @@ out2: | |||
4331 | kmem_cache_free(ext4_ac_cachep, ac); | 4317 | kmem_cache_free(ext4_ac_cachep, ac); |
4332 | out1: | 4318 | out1: |
4333 | if (inquota && ar->len < inquota) | 4319 | if (inquota && ar->len < inquota) |
4334 | vfs_dq_free_block(ar->inode, inquota - ar->len); | 4320 | dquot_free_block(ar->inode, inquota - ar->len); |
4335 | out3: | 4321 | out3: |
4336 | if (!ar->len) { | 4322 | if (!ar->len) { |
4337 | if (!EXT4_I(ar->inode)->i_delalloc_reserved_flag) | 4323 | if (!EXT4_I(ar->inode)->i_delalloc_reserved_flag) |
@@ -4476,10 +4462,10 @@ void ext4_free_blocks(handle_t *handle, struct inode *inode, | |||
4476 | 4462 | ||
4477 | sbi = EXT4_SB(sb); | 4463 | sbi = EXT4_SB(sb); |
4478 | es = EXT4_SB(sb)->s_es; | 4464 | es = EXT4_SB(sb)->s_es; |
4479 | if (!ext4_data_block_valid(sbi, block, count)) { | 4465 | if (!(flags & EXT4_FREE_BLOCKS_VALIDATED) && |
4480 | ext4_error(sb, __func__, | 4466 | !ext4_data_block_valid(sbi, block, count)) { |
4481 | "Freeing blocks not in datazone - " | 4467 | ext4_error(sb, "Freeing blocks not in datazone - " |
4482 | "block = %llu, count = %lu", block, count); | 4468 | "block = %llu, count = %lu", block, count); |
4483 | goto error_return; | 4469 | goto error_return; |
4484 | } | 4470 | } |
4485 | 4471 | ||
@@ -4547,8 +4533,7 @@ do_more: | |||
4547 | in_range(block + count - 1, ext4_inode_table(sb, gdp), | 4533 | in_range(block + count - 1, ext4_inode_table(sb, gdp), |
4548 | EXT4_SB(sb)->s_itb_per_group)) { | 4534 | EXT4_SB(sb)->s_itb_per_group)) { |
4549 | 4535 | ||
4550 | ext4_error(sb, __func__, | 4536 | ext4_error(sb, "Freeing blocks in system zone - " |
4551 | "Freeing blocks in system zone - " | ||
4552 | "Block = %llu, count = %lu", block, count); | 4537 | "Block = %llu, count = %lu", block, count); |
4553 | /* err = 0. ext4_std_error should be a no op */ | 4538 | /* err = 0. ext4_std_error should be a no op */ |
4554 | goto error_return; | 4539 | goto error_return; |
@@ -4646,7 +4631,7 @@ do_more: | |||
4646 | sb->s_dirt = 1; | 4631 | sb->s_dirt = 1; |
4647 | error_return: | 4632 | error_return: |
4648 | if (freed) | 4633 | if (freed) |
4649 | vfs_dq_free_block(inode, freed); | 4634 | dquot_free_block(inode, freed); |
4650 | brelse(bitmap_bh); | 4635 | brelse(bitmap_bh); |
4651 | ext4_std_error(sb, err); | 4636 | ext4_std_error(sb, err); |
4652 | if (ac) | 4637 | if (ac) |
diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h index 436521cae456..b619322c76f0 100644 --- a/fs/ext4/mballoc.h +++ b/fs/ext4/mballoc.h | |||
@@ -220,16 +220,9 @@ struct ext4_buddy { | |||
220 | #define EXT4_MB_BITMAP(e4b) ((e4b)->bd_bitmap) | 220 | #define EXT4_MB_BITMAP(e4b) ((e4b)->bd_bitmap) |
221 | #define EXT4_MB_BUDDY(e4b) ((e4b)->bd_buddy) | 221 | #define EXT4_MB_BUDDY(e4b) ((e4b)->bd_buddy) |
222 | 222 | ||
223 | #define in_range(b, first, len) ((b) >= (first) && (b) <= (first) + (len) - 1) | ||
224 | |||
225 | static inline ext4_fsblk_t ext4_grp_offs_to_block(struct super_block *sb, | 223 | static inline ext4_fsblk_t ext4_grp_offs_to_block(struct super_block *sb, |
226 | struct ext4_free_extent *fex) | 224 | struct ext4_free_extent *fex) |
227 | { | 225 | { |
228 | ext4_fsblk_t block; | 226 | return ext4_group_first_block_no(sb, fex->fe_group) + fex->fe_start; |
229 | |||
230 | block = (ext4_fsblk_t) fex->fe_group * EXT4_BLOCKS_PER_GROUP(sb) | ||
231 | + fex->fe_start | ||
232 | + le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block); | ||
233 | return block; | ||
234 | } | 227 | } |
235 | #endif | 228 | #endif |
diff --git a/fs/ext4/migrate.c b/fs/ext4/migrate.c index 81415814b00b..8b87bd0eac95 100644 --- a/fs/ext4/migrate.c +++ b/fs/ext4/migrate.c | |||
@@ -365,12 +365,12 @@ static int ext4_ext_swap_inode_data(handle_t *handle, struct inode *inode, | |||
365 | * happened after we started the migrate. We need to | 365 | * happened after we started the migrate. We need to |
366 | * fail the migrate | 366 | * fail the migrate |
367 | */ | 367 | */ |
368 | if (!(EXT4_I(inode)->i_state & EXT4_STATE_EXT_MIGRATE)) { | 368 | if (!ext4_test_inode_state(inode, EXT4_STATE_EXT_MIGRATE)) { |
369 | retval = -EAGAIN; | 369 | retval = -EAGAIN; |
370 | up_write(&EXT4_I(inode)->i_data_sem); | 370 | up_write(&EXT4_I(inode)->i_data_sem); |
371 | goto err_out; | 371 | goto err_out; |
372 | } else | 372 | } else |
373 | EXT4_I(inode)->i_state &= ~EXT4_STATE_EXT_MIGRATE; | 373 | ext4_clear_inode_state(inode, EXT4_STATE_EXT_MIGRATE); |
374 | /* | 374 | /* |
375 | * We have the extent map build with the tmp inode. | 375 | * We have the extent map build with the tmp inode. |
376 | * Now copy the i_data across | 376 | * Now copy the i_data across |
@@ -503,14 +503,10 @@ int ext4_ext_migrate(struct inode *inode) | |||
503 | } | 503 | } |
504 | i_size_write(tmp_inode, i_size_read(inode)); | 504 | i_size_write(tmp_inode, i_size_read(inode)); |
505 | /* | 505 | /* |
506 | * We don't want the inode to be reclaimed | 506 | * Set the i_nlink to zero so it will be deleted later |
507 | * if we got interrupted in between. We have | 507 | * when we drop inode reference. |
508 | * this tmp inode carrying reference to the | ||
509 | * data blocks of the original file. We set | ||
510 | * the i_nlink to zero at the last stage after | ||
511 | * switching the original file to extent format | ||
512 | */ | 508 | */ |
513 | tmp_inode->i_nlink = 1; | 509 | tmp_inode->i_nlink = 0; |
514 | 510 | ||
515 | ext4_ext_tree_init(handle, tmp_inode); | 511 | ext4_ext_tree_init(handle, tmp_inode); |
516 | ext4_orphan_add(handle, tmp_inode); | 512 | ext4_orphan_add(handle, tmp_inode); |
@@ -533,10 +529,20 @@ int ext4_ext_migrate(struct inode *inode) | |||
533 | * allocation. | 529 | * allocation. |
534 | */ | 530 | */ |
535 | down_read((&EXT4_I(inode)->i_data_sem)); | 531 | down_read((&EXT4_I(inode)->i_data_sem)); |
536 | EXT4_I(inode)->i_state |= EXT4_STATE_EXT_MIGRATE; | 532 | ext4_set_inode_state(inode, EXT4_STATE_EXT_MIGRATE); |
537 | up_read((&EXT4_I(inode)->i_data_sem)); | 533 | up_read((&EXT4_I(inode)->i_data_sem)); |
538 | 534 | ||
539 | handle = ext4_journal_start(inode, 1); | 535 | handle = ext4_journal_start(inode, 1); |
536 | if (IS_ERR(handle)) { | ||
537 | /* | ||
538 | * It is impossible to update on-disk structures without | ||
539 | * a handle, so just rollback in-core changes and live other | ||
540 | * work to orphan_list_cleanup() | ||
541 | */ | ||
542 | ext4_orphan_del(NULL, tmp_inode); | ||
543 | retval = PTR_ERR(handle); | ||
544 | goto out; | ||
545 | } | ||
540 | 546 | ||
541 | ei = EXT4_I(inode); | 547 | ei = EXT4_I(inode); |
542 | i_data = ei->i_data; | 548 | i_data = ei->i_data; |
@@ -618,15 +624,8 @@ err_out: | |||
618 | 624 | ||
619 | /* Reset the extent details */ | 625 | /* Reset the extent details */ |
620 | ext4_ext_tree_init(handle, tmp_inode); | 626 | ext4_ext_tree_init(handle, tmp_inode); |
621 | |||
622 | /* | ||
623 | * Set the i_nlink to zero so that | ||
624 | * generic_drop_inode really deletes the | ||
625 | * inode | ||
626 | */ | ||
627 | tmp_inode->i_nlink = 0; | ||
628 | |||
629 | ext4_journal_stop(handle); | 627 | ext4_journal_stop(handle); |
628 | out: | ||
630 | unlock_new_inode(tmp_inode); | 629 | unlock_new_inode(tmp_inode); |
631 | iput(tmp_inode); | 630 | iput(tmp_inode); |
632 | 631 | ||
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index 82c415be87a4..aa5fe28d180f 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c | |||
@@ -152,12 +152,12 @@ mext_check_null_inode(struct inode *inode1, struct inode *inode2, | |||
152 | int ret = 0; | 152 | int ret = 0; |
153 | 153 | ||
154 | if (inode1 == NULL) { | 154 | if (inode1 == NULL) { |
155 | ext4_error(inode2->i_sb, function, | 155 | __ext4_error(inode2->i_sb, function, |
156 | "Both inodes should not be NULL: " | 156 | "Both inodes should not be NULL: " |
157 | "inode1 NULL inode2 %lu", inode2->i_ino); | 157 | "inode1 NULL inode2 %lu", inode2->i_ino); |
158 | ret = -EIO; | 158 | ret = -EIO; |
159 | } else if (inode2 == NULL) { | 159 | } else if (inode2 == NULL) { |
160 | ext4_error(inode1->i_sb, function, | 160 | __ext4_error(inode1->i_sb, function, |
161 | "Both inodes should not be NULL: " | 161 | "Both inodes should not be NULL: " |
162 | "inode1 %lu inode2 NULL", inode1->i_ino); | 162 | "inode1 %lu inode2 NULL", inode1->i_ino); |
163 | ret = -EIO; | 163 | ret = -EIO; |
@@ -252,6 +252,7 @@ mext_insert_across_blocks(handle_t *handle, struct inode *orig_inode, | |||
252 | } | 252 | } |
253 | 253 | ||
254 | o_start->ee_len = start_ext->ee_len; | 254 | o_start->ee_len = start_ext->ee_len; |
255 | eblock = le32_to_cpu(start_ext->ee_block); | ||
255 | new_flag = 1; | 256 | new_flag = 1; |
256 | 257 | ||
257 | } else if (start_ext->ee_len && new_ext->ee_len && | 258 | } else if (start_ext->ee_len && new_ext->ee_len && |
@@ -262,6 +263,7 @@ mext_insert_across_blocks(handle_t *handle, struct inode *orig_inode, | |||
262 | * orig |------------------------------| | 263 | * orig |------------------------------| |
263 | */ | 264 | */ |
264 | o_start->ee_len = start_ext->ee_len; | 265 | o_start->ee_len = start_ext->ee_len; |
266 | eblock = le32_to_cpu(start_ext->ee_block); | ||
265 | new_flag = 1; | 267 | new_flag = 1; |
266 | 268 | ||
267 | } else if (!start_ext->ee_len && new_ext->ee_len && | 269 | } else if (!start_ext->ee_len && new_ext->ee_len && |
@@ -475,7 +477,6 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode, | |||
475 | struct ext4_extent *oext, *o_start, *o_end, *prev_ext; | 477 | struct ext4_extent *oext, *o_start, *o_end, *prev_ext; |
476 | struct ext4_extent new_ext, start_ext, end_ext; | 478 | struct ext4_extent new_ext, start_ext, end_ext; |
477 | ext4_lblk_t new_ext_end; | 479 | ext4_lblk_t new_ext_end; |
478 | ext4_fsblk_t new_phys_end; | ||
479 | int oext_alen, new_ext_alen, end_ext_alen; | 480 | int oext_alen, new_ext_alen, end_ext_alen; |
480 | int depth = ext_depth(orig_inode); | 481 | int depth = ext_depth(orig_inode); |
481 | int ret; | 482 | int ret; |
@@ -489,7 +490,6 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode, | |||
489 | new_ext.ee_len = dext->ee_len; | 490 | new_ext.ee_len = dext->ee_len; |
490 | new_ext_alen = ext4_ext_get_actual_len(&new_ext); | 491 | new_ext_alen = ext4_ext_get_actual_len(&new_ext); |
491 | new_ext_end = le32_to_cpu(new_ext.ee_block) + new_ext_alen - 1; | 492 | new_ext_end = le32_to_cpu(new_ext.ee_block) + new_ext_alen - 1; |
492 | new_phys_end = ext_pblock(&new_ext) + new_ext_alen - 1; | ||
493 | 493 | ||
494 | /* | 494 | /* |
495 | * Case: original extent is first | 495 | * Case: original extent is first |
@@ -502,6 +502,7 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode, | |||
502 | le32_to_cpu(oext->ee_block) + oext_alen) { | 502 | le32_to_cpu(oext->ee_block) + oext_alen) { |
503 | start_ext.ee_len = cpu_to_le16(le32_to_cpu(new_ext.ee_block) - | 503 | start_ext.ee_len = cpu_to_le16(le32_to_cpu(new_ext.ee_block) - |
504 | le32_to_cpu(oext->ee_block)); | 504 | le32_to_cpu(oext->ee_block)); |
505 | start_ext.ee_block = oext->ee_block; | ||
505 | copy_extent_status(oext, &start_ext); | 506 | copy_extent_status(oext, &start_ext); |
506 | } else if (oext > EXT_FIRST_EXTENT(orig_path[depth].p_hdr)) { | 507 | } else if (oext > EXT_FIRST_EXTENT(orig_path[depth].p_hdr)) { |
507 | prev_ext = oext - 1; | 508 | prev_ext = oext - 1; |
@@ -515,6 +516,7 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode, | |||
515 | start_ext.ee_len = cpu_to_le16( | 516 | start_ext.ee_len = cpu_to_le16( |
516 | ext4_ext_get_actual_len(prev_ext) + | 517 | ext4_ext_get_actual_len(prev_ext) + |
517 | new_ext_alen); | 518 | new_ext_alen); |
519 | start_ext.ee_block = oext->ee_block; | ||
518 | copy_extent_status(prev_ext, &start_ext); | 520 | copy_extent_status(prev_ext, &start_ext); |
519 | new_ext.ee_len = 0; | 521 | new_ext.ee_len = 0; |
520 | } | 522 | } |
@@ -526,7 +528,7 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode, | |||
526 | * new_ext |-------| | 528 | * new_ext |-------| |
527 | */ | 529 | */ |
528 | if (le32_to_cpu(oext->ee_block) + oext_alen - 1 < new_ext_end) { | 530 | if (le32_to_cpu(oext->ee_block) + oext_alen - 1 < new_ext_end) { |
529 | ext4_error(orig_inode->i_sb, __func__, | 531 | ext4_error(orig_inode->i_sb, |
530 | "new_ext_end(%u) should be less than or equal to " | 532 | "new_ext_end(%u) should be less than or equal to " |
531 | "oext->ee_block(%u) + oext_alen(%d) - 1", | 533 | "oext->ee_block(%u) + oext_alen(%d) - 1", |
532 | new_ext_end, le32_to_cpu(oext->ee_block), | 534 | new_ext_end, le32_to_cpu(oext->ee_block), |
@@ -689,12 +691,12 @@ mext_replace_branches(handle_t *handle, struct inode *orig_inode, | |||
689 | while (1) { | 691 | while (1) { |
690 | /* The extent for donor must be found. */ | 692 | /* The extent for donor must be found. */ |
691 | if (!dext) { | 693 | if (!dext) { |
692 | ext4_error(donor_inode->i_sb, __func__, | 694 | ext4_error(donor_inode->i_sb, |
693 | "The extent for donor must be found"); | 695 | "The extent for donor must be found"); |
694 | *err = -EIO; | 696 | *err = -EIO; |
695 | goto out; | 697 | goto out; |
696 | } else if (donor_off != le32_to_cpu(tmp_dext.ee_block)) { | 698 | } else if (donor_off != le32_to_cpu(tmp_dext.ee_block)) { |
697 | ext4_error(donor_inode->i_sb, __func__, | 699 | ext4_error(donor_inode->i_sb, |
698 | "Donor offset(%u) and the first block of donor " | 700 | "Donor offset(%u) and the first block of donor " |
699 | "extent(%u) should be equal", | 701 | "extent(%u) should be equal", |
700 | donor_off, | 702 | donor_off, |
@@ -928,7 +930,7 @@ out2: | |||
928 | } | 930 | } |
929 | 931 | ||
930 | /** | 932 | /** |
931 | * mext_check_argumants - Check whether move extent can be done | 933 | * mext_check_arguments - Check whether move extent can be done |
932 | * | 934 | * |
933 | * @orig_inode: original inode | 935 | * @orig_inode: original inode |
934 | * @donor_inode: donor inode | 936 | * @donor_inode: donor inode |
@@ -949,14 +951,6 @@ mext_check_arguments(struct inode *orig_inode, | |||
949 | unsigned int blkbits = orig_inode->i_blkbits; | 951 | unsigned int blkbits = orig_inode->i_blkbits; |
950 | unsigned int blocksize = 1 << blkbits; | 952 | unsigned int blocksize = 1 << blkbits; |
951 | 953 | ||
952 | /* Regular file check */ | ||
953 | if (!S_ISREG(orig_inode->i_mode) || !S_ISREG(donor_inode->i_mode)) { | ||
954 | ext4_debug("ext4 move extent: The argument files should be " | ||
955 | "regular file [ino:orig %lu, donor %lu]\n", | ||
956 | orig_inode->i_ino, donor_inode->i_ino); | ||
957 | return -EINVAL; | ||
958 | } | ||
959 | |||
960 | if (donor_inode->i_mode & (S_ISUID|S_ISGID)) { | 954 | if (donor_inode->i_mode & (S_ISUID|S_ISGID)) { |
961 | ext4_debug("ext4 move extent: suid or sgid is set" | 955 | ext4_debug("ext4 move extent: suid or sgid is set" |
962 | " to donor file [ino:orig %lu, donor %lu]\n", | 956 | " to donor file [ino:orig %lu, donor %lu]\n", |
@@ -1204,6 +1198,14 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, | |||
1204 | return -EINVAL; | 1198 | return -EINVAL; |
1205 | } | 1199 | } |
1206 | 1200 | ||
1201 | /* Regular file check */ | ||
1202 | if (!S_ISREG(orig_inode->i_mode) || !S_ISREG(donor_inode->i_mode)) { | ||
1203 | ext4_debug("ext4 move extent: The argument files should be " | ||
1204 | "regular file [ino:orig %lu, donor %lu]\n", | ||
1205 | orig_inode->i_ino, donor_inode->i_ino); | ||
1206 | return -EINVAL; | ||
1207 | } | ||
1208 | |||
1207 | /* Protect orig and donor inodes against a truncate */ | 1209 | /* Protect orig and donor inodes against a truncate */ |
1208 | ret1 = mext_inode_double_lock(orig_inode, donor_inode); | 1210 | ret1 = mext_inode_double_lock(orig_inode, donor_inode); |
1209 | if (ret1 < 0) | 1211 | if (ret1 < 0) |
@@ -1351,7 +1353,7 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, | |||
1351 | if (ret1 < 0) | 1353 | if (ret1 < 0) |
1352 | break; | 1354 | break; |
1353 | if (*moved_len > len) { | 1355 | if (*moved_len > len) { |
1354 | ext4_error(orig_inode->i_sb, __func__, | 1356 | ext4_error(orig_inode->i_sb, |
1355 | "We replaced blocks too much! " | 1357 | "We replaced blocks too much! " |
1356 | "sum of replaced: %llu requested: %llu", | 1358 | "sum of replaced: %llu requested: %llu", |
1357 | *moved_len, len); | 1359 | *moved_len, len); |
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 17a17e10dd60..0c070fabd108 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c | |||
@@ -383,8 +383,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir, | |||
383 | if (root->info.hash_version != DX_HASH_TEA && | 383 | if (root->info.hash_version != DX_HASH_TEA && |
384 | root->info.hash_version != DX_HASH_HALF_MD4 && | 384 | root->info.hash_version != DX_HASH_HALF_MD4 && |
385 | root->info.hash_version != DX_HASH_LEGACY) { | 385 | root->info.hash_version != DX_HASH_LEGACY) { |
386 | ext4_warning(dir->i_sb, __func__, | 386 | ext4_warning(dir->i_sb, "Unrecognised inode hash code %d", |
387 | "Unrecognised inode hash code %d", | ||
388 | root->info.hash_version); | 387 | root->info.hash_version); |
389 | brelse(bh); | 388 | brelse(bh); |
390 | *err = ERR_BAD_DX_DIR; | 389 | *err = ERR_BAD_DX_DIR; |
@@ -399,8 +398,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir, | |||
399 | hash = hinfo->hash; | 398 | hash = hinfo->hash; |
400 | 399 | ||
401 | if (root->info.unused_flags & 1) { | 400 | if (root->info.unused_flags & 1) { |
402 | ext4_warning(dir->i_sb, __func__, | 401 | ext4_warning(dir->i_sb, "Unimplemented inode hash flags: %#06x", |
403 | "Unimplemented inode hash flags: %#06x", | ||
404 | root->info.unused_flags); | 402 | root->info.unused_flags); |
405 | brelse(bh); | 403 | brelse(bh); |
406 | *err = ERR_BAD_DX_DIR; | 404 | *err = ERR_BAD_DX_DIR; |
@@ -408,8 +406,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir, | |||
408 | } | 406 | } |
409 | 407 | ||
410 | if ((indirect = root->info.indirect_levels) > 1) { | 408 | if ((indirect = root->info.indirect_levels) > 1) { |
411 | ext4_warning(dir->i_sb, __func__, | 409 | ext4_warning(dir->i_sb, "Unimplemented inode hash depth: %#06x", |
412 | "Unimplemented inode hash depth: %#06x", | ||
413 | root->info.indirect_levels); | 410 | root->info.indirect_levels); |
414 | brelse(bh); | 411 | brelse(bh); |
415 | *err = ERR_BAD_DX_DIR; | 412 | *err = ERR_BAD_DX_DIR; |
@@ -421,8 +418,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir, | |||
421 | 418 | ||
422 | if (dx_get_limit(entries) != dx_root_limit(dir, | 419 | if (dx_get_limit(entries) != dx_root_limit(dir, |
423 | root->info.info_length)) { | 420 | root->info.info_length)) { |
424 | ext4_warning(dir->i_sb, __func__, | 421 | ext4_warning(dir->i_sb, "dx entry: limit != root limit"); |
425 | "dx entry: limit != root limit"); | ||
426 | brelse(bh); | 422 | brelse(bh); |
427 | *err = ERR_BAD_DX_DIR; | 423 | *err = ERR_BAD_DX_DIR; |
428 | goto fail; | 424 | goto fail; |
@@ -433,7 +429,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir, | |||
433 | { | 429 | { |
434 | count = dx_get_count(entries); | 430 | count = dx_get_count(entries); |
435 | if (!count || count > dx_get_limit(entries)) { | 431 | if (!count || count > dx_get_limit(entries)) { |
436 | ext4_warning(dir->i_sb, __func__, | 432 | ext4_warning(dir->i_sb, |
437 | "dx entry: no count or count > limit"); | 433 | "dx entry: no count or count > limit"); |
438 | brelse(bh); | 434 | brelse(bh); |
439 | *err = ERR_BAD_DX_DIR; | 435 | *err = ERR_BAD_DX_DIR; |
@@ -478,7 +474,7 @@ dx_probe(const struct qstr *d_name, struct inode *dir, | |||
478 | goto fail2; | 474 | goto fail2; |
479 | at = entries = ((struct dx_node *) bh->b_data)->entries; | 475 | at = entries = ((struct dx_node *) bh->b_data)->entries; |
480 | if (dx_get_limit(entries) != dx_node_limit (dir)) { | 476 | if (dx_get_limit(entries) != dx_node_limit (dir)) { |
481 | ext4_warning(dir->i_sb, __func__, | 477 | ext4_warning(dir->i_sb, |
482 | "dx entry: limit != node limit"); | 478 | "dx entry: limit != node limit"); |
483 | brelse(bh); | 479 | brelse(bh); |
484 | *err = ERR_BAD_DX_DIR; | 480 | *err = ERR_BAD_DX_DIR; |
@@ -494,7 +490,7 @@ fail2: | |||
494 | } | 490 | } |
495 | fail: | 491 | fail: |
496 | if (*err == ERR_BAD_DX_DIR) | 492 | if (*err == ERR_BAD_DX_DIR) |
497 | ext4_warning(dir->i_sb, __func__, | 493 | ext4_warning(dir->i_sb, |
498 | "Corrupt dir inode %ld, running e2fsck is " | 494 | "Corrupt dir inode %ld, running e2fsck is " |
499 | "recommended.", dir->i_ino); | 495 | "recommended.", dir->i_ino); |
500 | return NULL; | 496 | return NULL; |
@@ -947,9 +943,8 @@ restart: | |||
947 | wait_on_buffer(bh); | 943 | wait_on_buffer(bh); |
948 | if (!buffer_uptodate(bh)) { | 944 | if (!buffer_uptodate(bh)) { |
949 | /* read error, skip block & hope for the best */ | 945 | /* read error, skip block & hope for the best */ |
950 | ext4_error(sb, __func__, "reading directory #%lu " | 946 | ext4_error(sb, "reading directory #%lu offset %lu", |
951 | "offset %lu", dir->i_ino, | 947 | dir->i_ino, (unsigned long)block); |
952 | (unsigned long)block); | ||
953 | brelse(bh); | 948 | brelse(bh); |
954 | goto next; | 949 | goto next; |
955 | } | 950 | } |
@@ -1041,7 +1036,7 @@ static struct buffer_head * ext4_dx_find_entry(struct inode *dir, const struct q | |||
1041 | retval = ext4_htree_next_block(dir, hash, frame, | 1036 | retval = ext4_htree_next_block(dir, hash, frame, |
1042 | frames, NULL); | 1037 | frames, NULL); |
1043 | if (retval < 0) { | 1038 | if (retval < 0) { |
1044 | ext4_warning(sb, __func__, | 1039 | ext4_warning(sb, |
1045 | "error reading index page in directory #%lu", | 1040 | "error reading index page in directory #%lu", |
1046 | dir->i_ino); | 1041 | dir->i_ino); |
1047 | *err = retval; | 1042 | *err = retval; |
@@ -1071,14 +1066,13 @@ static struct dentry *ext4_lookup(struct inode *dir, struct dentry *dentry, stru | |||
1071 | __u32 ino = le32_to_cpu(de->inode); | 1066 | __u32 ino = le32_to_cpu(de->inode); |
1072 | brelse(bh); | 1067 | brelse(bh); |
1073 | if (!ext4_valid_inum(dir->i_sb, ino)) { | 1068 | if (!ext4_valid_inum(dir->i_sb, ino)) { |
1074 | ext4_error(dir->i_sb, "ext4_lookup", | 1069 | ext4_error(dir->i_sb, "bad inode number: %u", ino); |
1075 | "bad inode number: %u", ino); | ||
1076 | return ERR_PTR(-EIO); | 1070 | return ERR_PTR(-EIO); |
1077 | } | 1071 | } |
1078 | inode = ext4_iget(dir->i_sb, ino); | 1072 | inode = ext4_iget(dir->i_sb, ino); |
1079 | if (unlikely(IS_ERR(inode))) { | 1073 | if (unlikely(IS_ERR(inode))) { |
1080 | if (PTR_ERR(inode) == -ESTALE) { | 1074 | if (PTR_ERR(inode) == -ESTALE) { |
1081 | ext4_error(dir->i_sb, __func__, | 1075 | ext4_error(dir->i_sb, |
1082 | "deleted inode referenced: %u", | 1076 | "deleted inode referenced: %u", |
1083 | ino); | 1077 | ino); |
1084 | return ERR_PTR(-EIO); | 1078 | return ERR_PTR(-EIO); |
@@ -1110,7 +1104,7 @@ struct dentry *ext4_get_parent(struct dentry *child) | |||
1110 | brelse(bh); | 1104 | brelse(bh); |
1111 | 1105 | ||
1112 | if (!ext4_valid_inum(child->d_inode->i_sb, ino)) { | 1106 | if (!ext4_valid_inum(child->d_inode->i_sb, ino)) { |
1113 | ext4_error(child->d_inode->i_sb, "ext4_get_parent", | 1107 | ext4_error(child->d_inode->i_sb, |
1114 | "bad inode number: %u", ino); | 1108 | "bad inode number: %u", ino); |
1115 | return ERR_PTR(-EIO); | 1109 | return ERR_PTR(-EIO); |
1116 | } | 1110 | } |
@@ -1410,7 +1404,7 @@ static int make_indexed_dir(handle_t *handle, struct dentry *dentry, | |||
1410 | de = (struct ext4_dir_entry_2 *)((char *)fde + | 1404 | de = (struct ext4_dir_entry_2 *)((char *)fde + |
1411 | ext4_rec_len_from_disk(fde->rec_len, blocksize)); | 1405 | ext4_rec_len_from_disk(fde->rec_len, blocksize)); |
1412 | if ((char *) de >= (((char *) root) + blocksize)) { | 1406 | if ((char *) de >= (((char *) root) + blocksize)) { |
1413 | ext4_error(dir->i_sb, __func__, | 1407 | ext4_error(dir->i_sb, |
1414 | "invalid rec_len for '..' in inode %lu", | 1408 | "invalid rec_len for '..' in inode %lu", |
1415 | dir->i_ino); | 1409 | dir->i_ino); |
1416 | brelse(bh); | 1410 | brelse(bh); |
@@ -1575,8 +1569,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct dentry *dentry, | |||
1575 | 1569 | ||
1576 | if (levels && (dx_get_count(frames->entries) == | 1570 | if (levels && (dx_get_count(frames->entries) == |
1577 | dx_get_limit(frames->entries))) { | 1571 | dx_get_limit(frames->entries))) { |
1578 | ext4_warning(sb, __func__, | 1572 | ext4_warning(sb, "Directory index full!"); |
1579 | "Directory index full!"); | ||
1580 | err = -ENOSPC; | 1573 | err = -ENOSPC; |
1581 | goto cleanup; | 1574 | goto cleanup; |
1582 | } | 1575 | } |
@@ -1766,6 +1759,8 @@ static int ext4_create(struct inode *dir, struct dentry *dentry, int mode, | |||
1766 | struct inode *inode; | 1759 | struct inode *inode; |
1767 | int err, retries = 0; | 1760 | int err, retries = 0; |
1768 | 1761 | ||
1762 | dquot_initialize(dir); | ||
1763 | |||
1769 | retry: | 1764 | retry: |
1770 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + | 1765 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + |
1771 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 3 + | 1766 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 3 + |
@@ -1800,6 +1795,8 @@ static int ext4_mknod(struct inode *dir, struct dentry *dentry, | |||
1800 | if (!new_valid_dev(rdev)) | 1795 | if (!new_valid_dev(rdev)) |
1801 | return -EINVAL; | 1796 | return -EINVAL; |
1802 | 1797 | ||
1798 | dquot_initialize(dir); | ||
1799 | |||
1803 | retry: | 1800 | retry: |
1804 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + | 1801 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + |
1805 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 3 + | 1802 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 3 + |
@@ -1837,6 +1834,8 @@ static int ext4_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
1837 | if (EXT4_DIR_LINK_MAX(dir)) | 1834 | if (EXT4_DIR_LINK_MAX(dir)) |
1838 | return -EMLINK; | 1835 | return -EMLINK; |
1839 | 1836 | ||
1837 | dquot_initialize(dir); | ||
1838 | |||
1840 | retry: | 1839 | retry: |
1841 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + | 1840 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + |
1842 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 3 + | 1841 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 3 + |
@@ -1916,11 +1915,11 @@ static int empty_dir(struct inode *inode) | |||
1916 | if (inode->i_size < EXT4_DIR_REC_LEN(1) + EXT4_DIR_REC_LEN(2) || | 1915 | if (inode->i_size < EXT4_DIR_REC_LEN(1) + EXT4_DIR_REC_LEN(2) || |
1917 | !(bh = ext4_bread(NULL, inode, 0, 0, &err))) { | 1916 | !(bh = ext4_bread(NULL, inode, 0, 0, &err))) { |
1918 | if (err) | 1917 | if (err) |
1919 | ext4_error(inode->i_sb, __func__, | 1918 | ext4_error(inode->i_sb, |
1920 | "error %d reading directory #%lu offset 0", | 1919 | "error %d reading directory #%lu offset 0", |
1921 | err, inode->i_ino); | 1920 | err, inode->i_ino); |
1922 | else | 1921 | else |
1923 | ext4_warning(inode->i_sb, __func__, | 1922 | ext4_warning(inode->i_sb, |
1924 | "bad directory (dir #%lu) - no data block", | 1923 | "bad directory (dir #%lu) - no data block", |
1925 | inode->i_ino); | 1924 | inode->i_ino); |
1926 | return 1; | 1925 | return 1; |
@@ -1931,7 +1930,7 @@ static int empty_dir(struct inode *inode) | |||
1931 | !le32_to_cpu(de1->inode) || | 1930 | !le32_to_cpu(de1->inode) || |
1932 | strcmp(".", de->name) || | 1931 | strcmp(".", de->name) || |
1933 | strcmp("..", de1->name)) { | 1932 | strcmp("..", de1->name)) { |
1934 | ext4_warning(inode->i_sb, "empty_dir", | 1933 | ext4_warning(inode->i_sb, |
1935 | "bad directory (dir #%lu) - no `.' or `..'", | 1934 | "bad directory (dir #%lu) - no `.' or `..'", |
1936 | inode->i_ino); | 1935 | inode->i_ino); |
1937 | brelse(bh); | 1936 | brelse(bh); |
@@ -1949,7 +1948,7 @@ static int empty_dir(struct inode *inode) | |||
1949 | offset >> EXT4_BLOCK_SIZE_BITS(sb), 0, &err); | 1948 | offset >> EXT4_BLOCK_SIZE_BITS(sb), 0, &err); |
1950 | if (!bh) { | 1949 | if (!bh) { |
1951 | if (err) | 1950 | if (err) |
1952 | ext4_error(sb, __func__, | 1951 | ext4_error(sb, |
1953 | "error %d reading directory" | 1952 | "error %d reading directory" |
1954 | " #%lu offset %u", | 1953 | " #%lu offset %u", |
1955 | err, inode->i_ino, offset); | 1954 | err, inode->i_ino, offset); |
@@ -2020,11 +2019,18 @@ int ext4_orphan_add(handle_t *handle, struct inode *inode) | |||
2020 | err = ext4_reserve_inode_write(handle, inode, &iloc); | 2019 | err = ext4_reserve_inode_write(handle, inode, &iloc); |
2021 | if (err) | 2020 | if (err) |
2022 | goto out_unlock; | 2021 | goto out_unlock; |
2022 | /* | ||
2023 | * Due to previous errors inode may be already a part of on-disk | ||
2024 | * orphan list. If so skip on-disk list modification. | ||
2025 | */ | ||
2026 | if (NEXT_ORPHAN(inode) && NEXT_ORPHAN(inode) <= | ||
2027 | (le32_to_cpu(EXT4_SB(sb)->s_es->s_inodes_count))) | ||
2028 | goto mem_insert; | ||
2023 | 2029 | ||
2024 | /* Insert this inode at the head of the on-disk orphan list... */ | 2030 | /* Insert this inode at the head of the on-disk orphan list... */ |
2025 | NEXT_ORPHAN(inode) = le32_to_cpu(EXT4_SB(sb)->s_es->s_last_orphan); | 2031 | NEXT_ORPHAN(inode) = le32_to_cpu(EXT4_SB(sb)->s_es->s_last_orphan); |
2026 | EXT4_SB(sb)->s_es->s_last_orphan = cpu_to_le32(inode->i_ino); | 2032 | EXT4_SB(sb)->s_es->s_last_orphan = cpu_to_le32(inode->i_ino); |
2027 | err = ext4_handle_dirty_metadata(handle, inode, EXT4_SB(sb)->s_sbh); | 2033 | err = ext4_handle_dirty_metadata(handle, NULL, EXT4_SB(sb)->s_sbh); |
2028 | rc = ext4_mark_iloc_dirty(handle, inode, &iloc); | 2034 | rc = ext4_mark_iloc_dirty(handle, inode, &iloc); |
2029 | if (!err) | 2035 | if (!err) |
2030 | err = rc; | 2036 | err = rc; |
@@ -2037,6 +2043,7 @@ int ext4_orphan_add(handle_t *handle, struct inode *inode) | |||
2037 | * | 2043 | * |
2038 | * This is safe: on error we're going to ignore the orphan list | 2044 | * This is safe: on error we're going to ignore the orphan list |
2039 | * anyway on the next recovery. */ | 2045 | * anyway on the next recovery. */ |
2046 | mem_insert: | ||
2040 | if (!err) | 2047 | if (!err) |
2041 | list_add(&EXT4_I(inode)->i_orphan, &EXT4_SB(sb)->s_orphan); | 2048 | list_add(&EXT4_I(inode)->i_orphan, &EXT4_SB(sb)->s_orphan); |
2042 | 2049 | ||
@@ -2096,7 +2103,7 @@ int ext4_orphan_del(handle_t *handle, struct inode *inode) | |||
2096 | if (err) | 2103 | if (err) |
2097 | goto out_brelse; | 2104 | goto out_brelse; |
2098 | sbi->s_es->s_last_orphan = cpu_to_le32(ino_next); | 2105 | sbi->s_es->s_last_orphan = cpu_to_le32(ino_next); |
2099 | err = ext4_handle_dirty_metadata(handle, inode, sbi->s_sbh); | 2106 | err = ext4_handle_dirty_metadata(handle, NULL, sbi->s_sbh); |
2100 | } else { | 2107 | } else { |
2101 | struct ext4_iloc iloc2; | 2108 | struct ext4_iloc iloc2; |
2102 | struct inode *i_prev = | 2109 | struct inode *i_prev = |
@@ -2136,7 +2143,9 @@ static int ext4_rmdir(struct inode *dir, struct dentry *dentry) | |||
2136 | 2143 | ||
2137 | /* Initialize quotas before so that eventual writes go in | 2144 | /* Initialize quotas before so that eventual writes go in |
2138 | * separate transaction */ | 2145 | * separate transaction */ |
2139 | vfs_dq_init(dentry->d_inode); | 2146 | dquot_initialize(dir); |
2147 | dquot_initialize(dentry->d_inode); | ||
2148 | |||
2140 | handle = ext4_journal_start(dir, EXT4_DELETE_TRANS_BLOCKS(dir->i_sb)); | 2149 | handle = ext4_journal_start(dir, EXT4_DELETE_TRANS_BLOCKS(dir->i_sb)); |
2141 | if (IS_ERR(handle)) | 2150 | if (IS_ERR(handle)) |
2142 | return PTR_ERR(handle); | 2151 | return PTR_ERR(handle); |
@@ -2163,7 +2172,7 @@ static int ext4_rmdir(struct inode *dir, struct dentry *dentry) | |||
2163 | if (retval) | 2172 | if (retval) |
2164 | goto end_rmdir; | 2173 | goto end_rmdir; |
2165 | if (!EXT4_DIR_LINK_EMPTY(inode)) | 2174 | if (!EXT4_DIR_LINK_EMPTY(inode)) |
2166 | ext4_warning(inode->i_sb, "ext4_rmdir", | 2175 | ext4_warning(inode->i_sb, |
2167 | "empty directory has too many links (%d)", | 2176 | "empty directory has too many links (%d)", |
2168 | inode->i_nlink); | 2177 | inode->i_nlink); |
2169 | inode->i_version++; | 2178 | inode->i_version++; |
@@ -2195,7 +2204,9 @@ static int ext4_unlink(struct inode *dir, struct dentry *dentry) | |||
2195 | 2204 | ||
2196 | /* Initialize quotas before so that eventual writes go | 2205 | /* Initialize quotas before so that eventual writes go |
2197 | * in separate transaction */ | 2206 | * in separate transaction */ |
2198 | vfs_dq_init(dentry->d_inode); | 2207 | dquot_initialize(dir); |
2208 | dquot_initialize(dentry->d_inode); | ||
2209 | |||
2199 | handle = ext4_journal_start(dir, EXT4_DELETE_TRANS_BLOCKS(dir->i_sb)); | 2210 | handle = ext4_journal_start(dir, EXT4_DELETE_TRANS_BLOCKS(dir->i_sb)); |
2200 | if (IS_ERR(handle)) | 2211 | if (IS_ERR(handle)) |
2201 | return PTR_ERR(handle); | 2212 | return PTR_ERR(handle); |
@@ -2215,7 +2226,7 @@ static int ext4_unlink(struct inode *dir, struct dentry *dentry) | |||
2215 | goto end_unlink; | 2226 | goto end_unlink; |
2216 | 2227 | ||
2217 | if (!inode->i_nlink) { | 2228 | if (!inode->i_nlink) { |
2218 | ext4_warning(inode->i_sb, "ext4_unlink", | 2229 | ext4_warning(inode->i_sb, |
2219 | "Deleting nonexistent file (%lu), %d", | 2230 | "Deleting nonexistent file (%lu), %d", |
2220 | inode->i_ino, inode->i_nlink); | 2231 | inode->i_ino, inode->i_nlink); |
2221 | inode->i_nlink = 1; | 2232 | inode->i_nlink = 1; |
@@ -2250,6 +2261,8 @@ static int ext4_symlink(struct inode *dir, | |||
2250 | if (l > dir->i_sb->s_blocksize) | 2261 | if (l > dir->i_sb->s_blocksize) |
2251 | return -ENAMETOOLONG; | 2262 | return -ENAMETOOLONG; |
2252 | 2263 | ||
2264 | dquot_initialize(dir); | ||
2265 | |||
2253 | retry: | 2266 | retry: |
2254 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + | 2267 | handle = ext4_journal_start(dir, EXT4_DATA_TRANS_BLOCKS(dir->i_sb) + |
2255 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 5 + | 2268 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 5 + |
@@ -2308,6 +2321,8 @@ static int ext4_link(struct dentry *old_dentry, | |||
2308 | if (inode->i_nlink >= EXT4_LINK_MAX) | 2321 | if (inode->i_nlink >= EXT4_LINK_MAX) |
2309 | return -EMLINK; | 2322 | return -EMLINK; |
2310 | 2323 | ||
2324 | dquot_initialize(dir); | ||
2325 | |||
2311 | /* | 2326 | /* |
2312 | * Return -ENOENT if we've raced with unlink and i_nlink is 0. Doing | 2327 | * Return -ENOENT if we've raced with unlink and i_nlink is 0. Doing |
2313 | * otherwise has the potential to corrupt the orphan inode list. | 2328 | * otherwise has the potential to corrupt the orphan inode list. |
@@ -2358,12 +2373,15 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
2358 | struct ext4_dir_entry_2 *old_de, *new_de; | 2373 | struct ext4_dir_entry_2 *old_de, *new_de; |
2359 | int retval, force_da_alloc = 0; | 2374 | int retval, force_da_alloc = 0; |
2360 | 2375 | ||
2376 | dquot_initialize(old_dir); | ||
2377 | dquot_initialize(new_dir); | ||
2378 | |||
2361 | old_bh = new_bh = dir_bh = NULL; | 2379 | old_bh = new_bh = dir_bh = NULL; |
2362 | 2380 | ||
2363 | /* Initialize quotas before so that eventual writes go | 2381 | /* Initialize quotas before so that eventual writes go |
2364 | * in separate transaction */ | 2382 | * in separate transaction */ |
2365 | if (new_dentry->d_inode) | 2383 | if (new_dentry->d_inode) |
2366 | vfs_dq_init(new_dentry->d_inode); | 2384 | dquot_initialize(new_dentry->d_inode); |
2367 | handle = ext4_journal_start(old_dir, 2 * | 2385 | handle = ext4_journal_start(old_dir, 2 * |
2368 | EXT4_DATA_TRANS_BLOCKS(old_dir->i_sb) + | 2386 | EXT4_DATA_TRANS_BLOCKS(old_dir->i_sb) + |
2369 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 2); | 2387 | EXT4_INDEX_EXTRA_TRANS_BLOCKS + 2); |
@@ -2462,7 +2480,7 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
2462 | } | 2480 | } |
2463 | } | 2481 | } |
2464 | if (retval) { | 2482 | if (retval) { |
2465 | ext4_warning(old_dir->i_sb, "ext4_rename", | 2483 | ext4_warning(old_dir->i_sb, |
2466 | "Deleting old file (%lu), %d, error=%d", | 2484 | "Deleting old file (%lu), %d, error=%d", |
2467 | old_dir->i_ino, old_dir->i_nlink, retval); | 2485 | old_dir->i_ino, old_dir->i_nlink, retval); |
2468 | } | 2486 | } |
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 3b2c5541d8a6..5692c48754a0 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c | |||
@@ -48,65 +48,54 @@ static int verify_group_input(struct super_block *sb, | |||
48 | 48 | ||
49 | ext4_get_group_no_and_offset(sb, start, NULL, &offset); | 49 | ext4_get_group_no_and_offset(sb, start, NULL, &offset); |
50 | if (group != sbi->s_groups_count) | 50 | if (group != sbi->s_groups_count) |
51 | ext4_warning(sb, __func__, | 51 | ext4_warning(sb, "Cannot add at group %u (only %u groups)", |
52 | "Cannot add at group %u (only %u groups)", | ||
53 | input->group, sbi->s_groups_count); | 52 | input->group, sbi->s_groups_count); |
54 | else if (offset != 0) | 53 | else if (offset != 0) |
55 | ext4_warning(sb, __func__, "Last group not full"); | 54 | ext4_warning(sb, "Last group not full"); |
56 | else if (input->reserved_blocks > input->blocks_count / 5) | 55 | else if (input->reserved_blocks > input->blocks_count / 5) |
57 | ext4_warning(sb, __func__, "Reserved blocks too high (%u)", | 56 | ext4_warning(sb, "Reserved blocks too high (%u)", |
58 | input->reserved_blocks); | 57 | input->reserved_blocks); |
59 | else if (free_blocks_count < 0) | 58 | else if (free_blocks_count < 0) |
60 | ext4_warning(sb, __func__, "Bad blocks count %u", | 59 | ext4_warning(sb, "Bad blocks count %u", |
61 | input->blocks_count); | 60 | input->blocks_count); |
62 | else if (!(bh = sb_bread(sb, end - 1))) | 61 | else if (!(bh = sb_bread(sb, end - 1))) |
63 | ext4_warning(sb, __func__, | 62 | ext4_warning(sb, "Cannot read last block (%llu)", |
64 | "Cannot read last block (%llu)", | ||
65 | end - 1); | 63 | end - 1); |
66 | else if (outside(input->block_bitmap, start, end)) | 64 | else if (outside(input->block_bitmap, start, end)) |
67 | ext4_warning(sb, __func__, | 65 | ext4_warning(sb, "Block bitmap not in group (block %llu)", |
68 | "Block bitmap not in group (block %llu)", | ||
69 | (unsigned long long)input->block_bitmap); | 66 | (unsigned long long)input->block_bitmap); |
70 | else if (outside(input->inode_bitmap, start, end)) | 67 | else if (outside(input->inode_bitmap, start, end)) |
71 | ext4_warning(sb, __func__, | 68 | ext4_warning(sb, "Inode bitmap not in group (block %llu)", |
72 | "Inode bitmap not in group (block %llu)", | ||
73 | (unsigned long long)input->inode_bitmap); | 69 | (unsigned long long)input->inode_bitmap); |
74 | else if (outside(input->inode_table, start, end) || | 70 | else if (outside(input->inode_table, start, end) || |
75 | outside(itend - 1, start, end)) | 71 | outside(itend - 1, start, end)) |
76 | ext4_warning(sb, __func__, | 72 | ext4_warning(sb, "Inode table not in group (blocks %llu-%llu)", |
77 | "Inode table not in group (blocks %llu-%llu)", | ||
78 | (unsigned long long)input->inode_table, itend - 1); | 73 | (unsigned long long)input->inode_table, itend - 1); |
79 | else if (input->inode_bitmap == input->block_bitmap) | 74 | else if (input->inode_bitmap == input->block_bitmap) |
80 | ext4_warning(sb, __func__, | 75 | ext4_warning(sb, "Block bitmap same as inode bitmap (%llu)", |
81 | "Block bitmap same as inode bitmap (%llu)", | ||
82 | (unsigned long long)input->block_bitmap); | 76 | (unsigned long long)input->block_bitmap); |
83 | else if (inside(input->block_bitmap, input->inode_table, itend)) | 77 | else if (inside(input->block_bitmap, input->inode_table, itend)) |
84 | ext4_warning(sb, __func__, | 78 | ext4_warning(sb, "Block bitmap (%llu) in inode table " |
85 | "Block bitmap (%llu) in inode table (%llu-%llu)", | 79 | "(%llu-%llu)", |
86 | (unsigned long long)input->block_bitmap, | 80 | (unsigned long long)input->block_bitmap, |
87 | (unsigned long long)input->inode_table, itend - 1); | 81 | (unsigned long long)input->inode_table, itend - 1); |
88 | else if (inside(input->inode_bitmap, input->inode_table, itend)) | 82 | else if (inside(input->inode_bitmap, input->inode_table, itend)) |
89 | ext4_warning(sb, __func__, | 83 | ext4_warning(sb, "Inode bitmap (%llu) in inode table " |
90 | "Inode bitmap (%llu) in inode table (%llu-%llu)", | 84 | "(%llu-%llu)", |
91 | (unsigned long long)input->inode_bitmap, | 85 | (unsigned long long)input->inode_bitmap, |
92 | (unsigned long long)input->inode_table, itend - 1); | 86 | (unsigned long long)input->inode_table, itend - 1); |
93 | else if (inside(input->block_bitmap, start, metaend)) | 87 | else if (inside(input->block_bitmap, start, metaend)) |
94 | ext4_warning(sb, __func__, | 88 | ext4_warning(sb, "Block bitmap (%llu) in GDT table (%llu-%llu)", |
95 | "Block bitmap (%llu) in GDT table" | ||
96 | " (%llu-%llu)", | ||
97 | (unsigned long long)input->block_bitmap, | 89 | (unsigned long long)input->block_bitmap, |
98 | start, metaend - 1); | 90 | start, metaend - 1); |
99 | else if (inside(input->inode_bitmap, start, metaend)) | 91 | else if (inside(input->inode_bitmap, start, metaend)) |
100 | ext4_warning(sb, __func__, | 92 | ext4_warning(sb, "Inode bitmap (%llu) in GDT table (%llu-%llu)", |
101 | "Inode bitmap (%llu) in GDT table" | ||
102 | " (%llu-%llu)", | ||
103 | (unsigned long long)input->inode_bitmap, | 93 | (unsigned long long)input->inode_bitmap, |
104 | start, metaend - 1); | 94 | start, metaend - 1); |
105 | else if (inside(input->inode_table, start, metaend) || | 95 | else if (inside(input->inode_table, start, metaend) || |
106 | inside(itend - 1, start, metaend)) | 96 | inside(itend - 1, start, metaend)) |
107 | ext4_warning(sb, __func__, | 97 | ext4_warning(sb, "Inode table (%llu-%llu) overlaps GDT table " |
108 | "Inode table (%llu-%llu) overlaps" | 98 | "(%llu-%llu)", |
109 | "GDT table (%llu-%llu)", | ||
110 | (unsigned long long)input->inode_table, | 99 | (unsigned long long)input->inode_table, |
111 | itend - 1, start, metaend - 1); | 100 | itend - 1, start, metaend - 1); |
112 | else | 101 | else |
@@ -364,8 +353,7 @@ static int verify_reserved_gdb(struct super_block *sb, | |||
364 | while ((grp = ext4_list_backups(sb, &three, &five, &seven)) < end) { | 353 | while ((grp = ext4_list_backups(sb, &three, &five, &seven)) < end) { |
365 | if (le32_to_cpu(*p++) != | 354 | if (le32_to_cpu(*p++) != |
366 | grp * EXT4_BLOCKS_PER_GROUP(sb) + blk){ | 355 | grp * EXT4_BLOCKS_PER_GROUP(sb) + blk){ |
367 | ext4_warning(sb, __func__, | 356 | ext4_warning(sb, "reserved GDT %llu" |
368 | "reserved GDT %llu" | ||
369 | " missing grp %d (%llu)", | 357 | " missing grp %d (%llu)", |
370 | blk, grp, | 358 | blk, grp, |
371 | grp * | 359 | grp * |
@@ -420,8 +408,7 @@ static int add_new_gdb(handle_t *handle, struct inode *inode, | |||
420 | */ | 408 | */ |
421 | if (EXT4_SB(sb)->s_sbh->b_blocknr != | 409 | if (EXT4_SB(sb)->s_sbh->b_blocknr != |
422 | le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block)) { | 410 | le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block)) { |
423 | ext4_warning(sb, __func__, | 411 | ext4_warning(sb, "won't resize using backup superblock at %llu", |
424 | "won't resize using backup superblock at %llu", | ||
425 | (unsigned long long)EXT4_SB(sb)->s_sbh->b_blocknr); | 412 | (unsigned long long)EXT4_SB(sb)->s_sbh->b_blocknr); |
426 | return -EPERM; | 413 | return -EPERM; |
427 | } | 414 | } |
@@ -444,8 +431,7 @@ static int add_new_gdb(handle_t *handle, struct inode *inode, | |||
444 | 431 | ||
445 | data = (__le32 *)dind->b_data; | 432 | data = (__le32 *)dind->b_data; |
446 | if (le32_to_cpu(data[gdb_num % EXT4_ADDR_PER_BLOCK(sb)]) != gdblock) { | 433 | if (le32_to_cpu(data[gdb_num % EXT4_ADDR_PER_BLOCK(sb)]) != gdblock) { |
447 | ext4_warning(sb, __func__, | 434 | ext4_warning(sb, "new group %u GDT block %llu not reserved", |
448 | "new group %u GDT block %llu not reserved", | ||
449 | input->group, gdblock); | 435 | input->group, gdblock); |
450 | err = -EINVAL; | 436 | err = -EINVAL; |
451 | goto exit_dind; | 437 | goto exit_dind; |
@@ -468,7 +454,7 @@ static int add_new_gdb(handle_t *handle, struct inode *inode, | |||
468 | GFP_NOFS); | 454 | GFP_NOFS); |
469 | if (!n_group_desc) { | 455 | if (!n_group_desc) { |
470 | err = -ENOMEM; | 456 | err = -ENOMEM; |
471 | ext4_warning(sb, __func__, | 457 | ext4_warning(sb, |
472 | "not enough memory for %lu groups", gdb_num + 1); | 458 | "not enough memory for %lu groups", gdb_num + 1); |
473 | goto exit_inode; | 459 | goto exit_inode; |
474 | } | 460 | } |
@@ -567,8 +553,7 @@ static int reserve_backup_gdb(handle_t *handle, struct inode *inode, | |||
567 | /* Get each reserved primary GDT block and verify it holds backups */ | 553 | /* Get each reserved primary GDT block and verify it holds backups */ |
568 | for (res = 0; res < reserved_gdb; res++, blk++) { | 554 | for (res = 0; res < reserved_gdb; res++, blk++) { |
569 | if (le32_to_cpu(*data) != blk) { | 555 | if (le32_to_cpu(*data) != blk) { |
570 | ext4_warning(sb, __func__, | 556 | ext4_warning(sb, "reserved block %llu" |
571 | "reserved block %llu" | ||
572 | " not at offset %ld", | 557 | " not at offset %ld", |
573 | blk, | 558 | blk, |
574 | (long)(data - (__le32 *)dind->b_data)); | 559 | (long)(data - (__le32 *)dind->b_data)); |
@@ -713,8 +698,7 @@ static void update_backups(struct super_block *sb, | |||
713 | */ | 698 | */ |
714 | exit_err: | 699 | exit_err: |
715 | if (err) { | 700 | if (err) { |
716 | ext4_warning(sb, __func__, | 701 | ext4_warning(sb, "can't update backup for group %u (err %d), " |
717 | "can't update backup for group %u (err %d), " | ||
718 | "forcing fsck on next reboot", group, err); | 702 | "forcing fsck on next reboot", group, err); |
719 | sbi->s_mount_state &= ~EXT4_VALID_FS; | 703 | sbi->s_mount_state &= ~EXT4_VALID_FS; |
720 | sbi->s_es->s_state &= cpu_to_le16(~EXT4_VALID_FS); | 704 | sbi->s_es->s_state &= cpu_to_le16(~EXT4_VALID_FS); |
@@ -753,20 +737,19 @@ int ext4_group_add(struct super_block *sb, struct ext4_new_group_data *input) | |||
753 | 737 | ||
754 | if (gdb_off == 0 && !EXT4_HAS_RO_COMPAT_FEATURE(sb, | 738 | if (gdb_off == 0 && !EXT4_HAS_RO_COMPAT_FEATURE(sb, |
755 | EXT4_FEATURE_RO_COMPAT_SPARSE_SUPER)) { | 739 | EXT4_FEATURE_RO_COMPAT_SPARSE_SUPER)) { |
756 | ext4_warning(sb, __func__, | 740 | ext4_warning(sb, "Can't resize non-sparse filesystem further"); |
757 | "Can't resize non-sparse filesystem further"); | ||
758 | return -EPERM; | 741 | return -EPERM; |
759 | } | 742 | } |
760 | 743 | ||
761 | if (ext4_blocks_count(es) + input->blocks_count < | 744 | if (ext4_blocks_count(es) + input->blocks_count < |
762 | ext4_blocks_count(es)) { | 745 | ext4_blocks_count(es)) { |
763 | ext4_warning(sb, __func__, "blocks_count overflow"); | 746 | ext4_warning(sb, "blocks_count overflow"); |
764 | return -EINVAL; | 747 | return -EINVAL; |
765 | } | 748 | } |
766 | 749 | ||
767 | if (le32_to_cpu(es->s_inodes_count) + EXT4_INODES_PER_GROUP(sb) < | 750 | if (le32_to_cpu(es->s_inodes_count) + EXT4_INODES_PER_GROUP(sb) < |
768 | le32_to_cpu(es->s_inodes_count)) { | 751 | le32_to_cpu(es->s_inodes_count)) { |
769 | ext4_warning(sb, __func__, "inodes_count overflow"); | 752 | ext4_warning(sb, "inodes_count overflow"); |
770 | return -EINVAL; | 753 | return -EINVAL; |
771 | } | 754 | } |
772 | 755 | ||
@@ -774,14 +757,13 @@ int ext4_group_add(struct super_block *sb, struct ext4_new_group_data *input) | |||
774 | if (!EXT4_HAS_COMPAT_FEATURE(sb, | 757 | if (!EXT4_HAS_COMPAT_FEATURE(sb, |
775 | EXT4_FEATURE_COMPAT_RESIZE_INODE) | 758 | EXT4_FEATURE_COMPAT_RESIZE_INODE) |
776 | || !le16_to_cpu(es->s_reserved_gdt_blocks)) { | 759 | || !le16_to_cpu(es->s_reserved_gdt_blocks)) { |
777 | ext4_warning(sb, __func__, | 760 | ext4_warning(sb, |
778 | "No reserved GDT blocks, can't resize"); | 761 | "No reserved GDT blocks, can't resize"); |
779 | return -EPERM; | 762 | return -EPERM; |
780 | } | 763 | } |
781 | inode = ext4_iget(sb, EXT4_RESIZE_INO); | 764 | inode = ext4_iget(sb, EXT4_RESIZE_INO); |
782 | if (IS_ERR(inode)) { | 765 | if (IS_ERR(inode)) { |
783 | ext4_warning(sb, __func__, | 766 | ext4_warning(sb, "Error opening resize inode"); |
784 | "Error opening resize inode"); | ||
785 | return PTR_ERR(inode); | 767 | return PTR_ERR(inode); |
786 | } | 768 | } |
787 | } | 769 | } |
@@ -810,8 +792,7 @@ int ext4_group_add(struct super_block *sb, struct ext4_new_group_data *input) | |||
810 | 792 | ||
811 | mutex_lock(&sbi->s_resize_lock); | 793 | mutex_lock(&sbi->s_resize_lock); |
812 | if (input->group != sbi->s_groups_count) { | 794 | if (input->group != sbi->s_groups_count) { |
813 | ext4_warning(sb, __func__, | 795 | ext4_warning(sb, "multiple resizers run on filesystem!"); |
814 | "multiple resizers run on filesystem!"); | ||
815 | err = -EBUSY; | 796 | err = -EBUSY; |
816 | goto exit_journal; | 797 | goto exit_journal; |
817 | } | 798 | } |
@@ -997,13 +978,12 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es, | |||
997 | " too large to resize to %llu blocks safely\n", | 978 | " too large to resize to %llu blocks safely\n", |
998 | sb->s_id, n_blocks_count); | 979 | sb->s_id, n_blocks_count); |
999 | if (sizeof(sector_t) < 8) | 980 | if (sizeof(sector_t) < 8) |
1000 | ext4_warning(sb, __func__, "CONFIG_LBDAF not enabled"); | 981 | ext4_warning(sb, "CONFIG_LBDAF not enabled"); |
1001 | return -EINVAL; | 982 | return -EINVAL; |
1002 | } | 983 | } |
1003 | 984 | ||
1004 | if (n_blocks_count < o_blocks_count) { | 985 | if (n_blocks_count < o_blocks_count) { |
1005 | ext4_warning(sb, __func__, | 986 | ext4_warning(sb, "can't shrink FS - resize aborted"); |
1006 | "can't shrink FS - resize aborted"); | ||
1007 | return -EBUSY; | 987 | return -EBUSY; |
1008 | } | 988 | } |
1009 | 989 | ||
@@ -1011,15 +991,14 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es, | |||
1011 | ext4_get_group_no_and_offset(sb, o_blocks_count, &group, &last); | 991 | ext4_get_group_no_and_offset(sb, o_blocks_count, &group, &last); |
1012 | 992 | ||
1013 | if (last == 0) { | 993 | if (last == 0) { |
1014 | ext4_warning(sb, __func__, | 994 | ext4_warning(sb, "need to use ext2online to resize further"); |
1015 | "need to use ext2online to resize further"); | ||
1016 | return -EPERM; | 995 | return -EPERM; |
1017 | } | 996 | } |
1018 | 997 | ||
1019 | add = EXT4_BLOCKS_PER_GROUP(sb) - last; | 998 | add = EXT4_BLOCKS_PER_GROUP(sb) - last; |
1020 | 999 | ||
1021 | if (o_blocks_count + add < o_blocks_count) { | 1000 | if (o_blocks_count + add < o_blocks_count) { |
1022 | ext4_warning(sb, __func__, "blocks_count overflow"); | 1001 | ext4_warning(sb, "blocks_count overflow"); |
1023 | return -EINVAL; | 1002 | return -EINVAL; |
1024 | } | 1003 | } |
1025 | 1004 | ||
@@ -1027,16 +1006,13 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es, | |||
1027 | add = n_blocks_count - o_blocks_count; | 1006 | add = n_blocks_count - o_blocks_count; |
1028 | 1007 | ||
1029 | if (o_blocks_count + add < n_blocks_count) | 1008 | if (o_blocks_count + add < n_blocks_count) |
1030 | ext4_warning(sb, __func__, | 1009 | ext4_warning(sb, "will only finish group (%llu blocks, %u new)", |
1031 | "will only finish group (%llu" | ||
1032 | " blocks, %u new)", | ||
1033 | o_blocks_count + add, add); | 1010 | o_blocks_count + add, add); |
1034 | 1011 | ||
1035 | /* See if the device is actually as big as what was requested */ | 1012 | /* See if the device is actually as big as what was requested */ |
1036 | bh = sb_bread(sb, o_blocks_count + add - 1); | 1013 | bh = sb_bread(sb, o_blocks_count + add - 1); |
1037 | if (!bh) { | 1014 | if (!bh) { |
1038 | ext4_warning(sb, __func__, | 1015 | ext4_warning(sb, "can't read last block, resize aborted"); |
1039 | "can't read last block, resize aborted"); | ||
1040 | return -ENOSPC; | 1016 | return -ENOSPC; |
1041 | } | 1017 | } |
1042 | brelse(bh); | 1018 | brelse(bh); |
@@ -1047,14 +1023,13 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es, | |||
1047 | handle = ext4_journal_start_sb(sb, 3); | 1023 | handle = ext4_journal_start_sb(sb, 3); |
1048 | if (IS_ERR(handle)) { | 1024 | if (IS_ERR(handle)) { |
1049 | err = PTR_ERR(handle); | 1025 | err = PTR_ERR(handle); |
1050 | ext4_warning(sb, __func__, "error %d on journal start", err); | 1026 | ext4_warning(sb, "error %d on journal start", err); |
1051 | goto exit_put; | 1027 | goto exit_put; |
1052 | } | 1028 | } |
1053 | 1029 | ||
1054 | mutex_lock(&EXT4_SB(sb)->s_resize_lock); | 1030 | mutex_lock(&EXT4_SB(sb)->s_resize_lock); |
1055 | if (o_blocks_count != ext4_blocks_count(es)) { | 1031 | if (o_blocks_count != ext4_blocks_count(es)) { |
1056 | ext4_warning(sb, __func__, | 1032 | ext4_warning(sb, "multiple resizers run on filesystem!"); |
1057 | "multiple resizers run on filesystem!"); | ||
1058 | mutex_unlock(&EXT4_SB(sb)->s_resize_lock); | 1033 | mutex_unlock(&EXT4_SB(sb)->s_resize_lock); |
1059 | ext4_journal_stop(handle); | 1034 | ext4_journal_stop(handle); |
1060 | err = -EBUSY; | 1035 | err = -EBUSY; |
@@ -1063,8 +1038,7 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es, | |||
1063 | 1038 | ||
1064 | if ((err = ext4_journal_get_write_access(handle, | 1039 | if ((err = ext4_journal_get_write_access(handle, |
1065 | EXT4_SB(sb)->s_sbh))) { | 1040 | EXT4_SB(sb)->s_sbh))) { |
1066 | ext4_warning(sb, __func__, | 1041 | ext4_warning(sb, "error %d on journal write access", err); |
1067 | "error %d on journal write access", err); | ||
1068 | mutex_unlock(&EXT4_SB(sb)->s_resize_lock); | 1042 | mutex_unlock(&EXT4_SB(sb)->s_resize_lock); |
1069 | ext4_journal_stop(handle); | 1043 | ext4_journal_stop(handle); |
1070 | goto exit_put; | 1044 | goto exit_put; |
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 735c20d5fd56..ce84a6ed4a48 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c | |||
@@ -333,7 +333,7 @@ static void ext4_handle_error(struct super_block *sb) | |||
333 | sb->s_id); | 333 | sb->s_id); |
334 | } | 334 | } |
335 | 335 | ||
336 | void ext4_error(struct super_block *sb, const char *function, | 336 | void __ext4_error(struct super_block *sb, const char *function, |
337 | const char *fmt, ...) | 337 | const char *fmt, ...) |
338 | { | 338 | { |
339 | va_list args; | 339 | va_list args; |
@@ -347,6 +347,42 @@ void ext4_error(struct super_block *sb, const char *function, | |||
347 | ext4_handle_error(sb); | 347 | ext4_handle_error(sb); |
348 | } | 348 | } |
349 | 349 | ||
350 | void ext4_error_inode(const char *function, struct inode *inode, | ||
351 | const char *fmt, ...) | ||
352 | { | ||
353 | va_list args; | ||
354 | |||
355 | va_start(args, fmt); | ||
356 | printk(KERN_CRIT "EXT4-fs error (device %s): %s: inode #%lu: (comm %s) ", | ||
357 | inode->i_sb->s_id, function, inode->i_ino, current->comm); | ||
358 | vprintk(fmt, args); | ||
359 | printk("\n"); | ||
360 | va_end(args); | ||
361 | |||
362 | ext4_handle_error(inode->i_sb); | ||
363 | } | ||
364 | |||
365 | void ext4_error_file(const char *function, struct file *file, | ||
366 | const char *fmt, ...) | ||
367 | { | ||
368 | va_list args; | ||
369 | struct inode *inode = file->f_dentry->d_inode; | ||
370 | char pathname[80], *path; | ||
371 | |||
372 | va_start(args, fmt); | ||
373 | path = d_path(&(file->f_path), pathname, sizeof(pathname)); | ||
374 | if (!path) | ||
375 | path = "(unknown)"; | ||
376 | printk(KERN_CRIT | ||
377 | "EXT4-fs error (device %s): %s: inode #%lu (comm %s path %s): ", | ||
378 | inode->i_sb->s_id, function, inode->i_ino, current->comm, path); | ||
379 | vprintk(fmt, args); | ||
380 | printk("\n"); | ||
381 | va_end(args); | ||
382 | |||
383 | ext4_handle_error(inode->i_sb); | ||
384 | } | ||
385 | |||
350 | static const char *ext4_decode_error(struct super_block *sb, int errno, | 386 | static const char *ext4_decode_error(struct super_block *sb, int errno, |
351 | char nbuf[16]) | 387 | char nbuf[16]) |
352 | { | 388 | { |
@@ -450,7 +486,7 @@ void ext4_msg (struct super_block * sb, const char *prefix, | |||
450 | va_end(args); | 486 | va_end(args); |
451 | } | 487 | } |
452 | 488 | ||
453 | void ext4_warning(struct super_block *sb, const char *function, | 489 | void __ext4_warning(struct super_block *sb, const char *function, |
454 | const char *fmt, ...) | 490 | const char *fmt, ...) |
455 | { | 491 | { |
456 | va_list args; | 492 | va_list args; |
@@ -507,7 +543,7 @@ void ext4_update_dynamic_rev(struct super_block *sb) | |||
507 | if (le32_to_cpu(es->s_rev_level) > EXT4_GOOD_OLD_REV) | 543 | if (le32_to_cpu(es->s_rev_level) > EXT4_GOOD_OLD_REV) |
508 | return; | 544 | return; |
509 | 545 | ||
510 | ext4_warning(sb, __func__, | 546 | ext4_warning(sb, |
511 | "updating to rev %d because of new feature flag, " | 547 | "updating to rev %d because of new feature flag, " |
512 | "running e2fsck is recommended", | 548 | "running e2fsck is recommended", |
513 | EXT4_DYNAMIC_REV); | 549 | EXT4_DYNAMIC_REV); |
@@ -708,7 +744,8 @@ static struct inode *ext4_alloc_inode(struct super_block *sb) | |||
708 | #ifdef CONFIG_QUOTA | 744 | #ifdef CONFIG_QUOTA |
709 | ei->i_reserved_quota = 0; | 745 | ei->i_reserved_quota = 0; |
710 | #endif | 746 | #endif |
711 | INIT_LIST_HEAD(&ei->i_aio_dio_complete_list); | 747 | INIT_LIST_HEAD(&ei->i_completed_io_list); |
748 | spin_lock_init(&ei->i_completed_io_lock); | ||
712 | ei->cur_aio_dio = NULL; | 749 | ei->cur_aio_dio = NULL; |
713 | ei->i_sync_tid = 0; | 750 | ei->i_sync_tid = 0; |
714 | ei->i_datasync_tid = 0; | 751 | ei->i_datasync_tid = 0; |
@@ -761,6 +798,7 @@ static void destroy_inodecache(void) | |||
761 | 798 | ||
762 | static void ext4_clear_inode(struct inode *inode) | 799 | static void ext4_clear_inode(struct inode *inode) |
763 | { | 800 | { |
801 | dquot_drop(inode); | ||
764 | ext4_discard_preallocations(inode); | 802 | ext4_discard_preallocations(inode); |
765 | if (EXT4_JOURNAL(inode)) | 803 | if (EXT4_JOURNAL(inode)) |
766 | jbd2_journal_release_jbd_inode(EXT4_SB(inode->i_sb)->s_journal, | 804 | jbd2_journal_release_jbd_inode(EXT4_SB(inode->i_sb)->s_journal, |
@@ -796,10 +834,10 @@ static inline void ext4_show_quota_options(struct seq_file *seq, | |||
796 | if (sbi->s_qf_names[GRPQUOTA]) | 834 | if (sbi->s_qf_names[GRPQUOTA]) |
797 | seq_printf(seq, ",grpjquota=%s", sbi->s_qf_names[GRPQUOTA]); | 835 | seq_printf(seq, ",grpjquota=%s", sbi->s_qf_names[GRPQUOTA]); |
798 | 836 | ||
799 | if (sbi->s_mount_opt & EXT4_MOUNT_USRQUOTA) | 837 | if (test_opt(sb, USRQUOTA)) |
800 | seq_puts(seq, ",usrquota"); | 838 | seq_puts(seq, ",usrquota"); |
801 | 839 | ||
802 | if (sbi->s_mount_opt & EXT4_MOUNT_GRPQUOTA) | 840 | if (test_opt(sb, GRPQUOTA)) |
803 | seq_puts(seq, ",grpquota"); | 841 | seq_puts(seq, ",grpquota"); |
804 | #endif | 842 | #endif |
805 | } | 843 | } |
@@ -926,6 +964,9 @@ static int ext4_show_options(struct seq_file *seq, struct vfsmount *vfs) | |||
926 | if (test_opt(sb, NOLOAD)) | 964 | if (test_opt(sb, NOLOAD)) |
927 | seq_puts(seq, ",norecovery"); | 965 | seq_puts(seq, ",norecovery"); |
928 | 966 | ||
967 | if (test_opt(sb, DIOREAD_NOLOCK)) | ||
968 | seq_puts(seq, ",dioread_nolock"); | ||
969 | |||
929 | ext4_show_quota_options(seq, sb); | 970 | ext4_show_quota_options(seq, sb); |
930 | 971 | ||
931 | return 0; | 972 | return 0; |
@@ -1012,19 +1053,9 @@ static ssize_t ext4_quota_write(struct super_block *sb, int type, | |||
1012 | const char *data, size_t len, loff_t off); | 1053 | const char *data, size_t len, loff_t off); |
1013 | 1054 | ||
1014 | static const struct dquot_operations ext4_quota_operations = { | 1055 | static const struct dquot_operations ext4_quota_operations = { |
1015 | .initialize = dquot_initialize, | ||
1016 | .drop = dquot_drop, | ||
1017 | .alloc_space = dquot_alloc_space, | ||
1018 | .reserve_space = dquot_reserve_space, | ||
1019 | .claim_space = dquot_claim_space, | ||
1020 | .release_rsv = dquot_release_reserved_space, | ||
1021 | #ifdef CONFIG_QUOTA | 1056 | #ifdef CONFIG_QUOTA |
1022 | .get_reserved_space = ext4_get_reserved_space, | 1057 | .get_reserved_space = ext4_get_reserved_space, |
1023 | #endif | 1058 | #endif |
1024 | .alloc_inode = dquot_alloc_inode, | ||
1025 | .free_space = dquot_free_space, | ||
1026 | .free_inode = dquot_free_inode, | ||
1027 | .transfer = dquot_transfer, | ||
1028 | .write_dquot = ext4_write_dquot, | 1059 | .write_dquot = ext4_write_dquot, |
1029 | .acquire_dquot = ext4_acquire_dquot, | 1060 | .acquire_dquot = ext4_acquire_dquot, |
1030 | .release_dquot = ext4_release_dquot, | 1061 | .release_dquot = ext4_release_dquot, |
@@ -1109,6 +1140,7 @@ enum { | |||
1109 | Opt_stripe, Opt_delalloc, Opt_nodelalloc, | 1140 | Opt_stripe, Opt_delalloc, Opt_nodelalloc, |
1110 | Opt_block_validity, Opt_noblock_validity, | 1141 | Opt_block_validity, Opt_noblock_validity, |
1111 | Opt_inode_readahead_blks, Opt_journal_ioprio, | 1142 | Opt_inode_readahead_blks, Opt_journal_ioprio, |
1143 | Opt_dioread_nolock, Opt_dioread_lock, | ||
1112 | Opt_discard, Opt_nodiscard, | 1144 | Opt_discard, Opt_nodiscard, |
1113 | }; | 1145 | }; |
1114 | 1146 | ||
@@ -1176,6 +1208,8 @@ static const match_table_t tokens = { | |||
1176 | {Opt_auto_da_alloc, "auto_da_alloc=%u"}, | 1208 | {Opt_auto_da_alloc, "auto_da_alloc=%u"}, |
1177 | {Opt_auto_da_alloc, "auto_da_alloc"}, | 1209 | {Opt_auto_da_alloc, "auto_da_alloc"}, |
1178 | {Opt_noauto_da_alloc, "noauto_da_alloc"}, | 1210 | {Opt_noauto_da_alloc, "noauto_da_alloc"}, |
1211 | {Opt_dioread_nolock, "dioread_nolock"}, | ||
1212 | {Opt_dioread_lock, "dioread_lock"}, | ||
1179 | {Opt_discard, "discard"}, | 1213 | {Opt_discard, "discard"}, |
1180 | {Opt_nodiscard, "nodiscard"}, | 1214 | {Opt_nodiscard, "nodiscard"}, |
1181 | {Opt_err, NULL}, | 1215 | {Opt_err, NULL}, |
@@ -1205,6 +1239,66 @@ static ext4_fsblk_t get_sb_block(void **data) | |||
1205 | } | 1239 | } |
1206 | 1240 | ||
1207 | #define DEFAULT_JOURNAL_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, 3)) | 1241 | #define DEFAULT_JOURNAL_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, 3)) |
1242 | static char deprecated_msg[] = "Mount option \"%s\" will be removed by %s\n" | ||
1243 | "Contact linux-ext4@vger.kernel.org if you think we should keep it.\n"; | ||
1244 | |||
1245 | #ifdef CONFIG_QUOTA | ||
1246 | static int set_qf_name(struct super_block *sb, int qtype, substring_t *args) | ||
1247 | { | ||
1248 | struct ext4_sb_info *sbi = EXT4_SB(sb); | ||
1249 | char *qname; | ||
1250 | |||
1251 | if (sb_any_quota_loaded(sb) && | ||
1252 | !sbi->s_qf_names[qtype]) { | ||
1253 | ext4_msg(sb, KERN_ERR, | ||
1254 | "Cannot change journaled " | ||
1255 | "quota options when quota turned on"); | ||
1256 | return 0; | ||
1257 | } | ||
1258 | qname = match_strdup(args); | ||
1259 | if (!qname) { | ||
1260 | ext4_msg(sb, KERN_ERR, | ||
1261 | "Not enough memory for storing quotafile name"); | ||
1262 | return 0; | ||
1263 | } | ||
1264 | if (sbi->s_qf_names[qtype] && | ||
1265 | strcmp(sbi->s_qf_names[qtype], qname)) { | ||
1266 | ext4_msg(sb, KERN_ERR, | ||
1267 | "%s quota file already specified", QTYPE2NAME(qtype)); | ||
1268 | kfree(qname); | ||
1269 | return 0; | ||
1270 | } | ||
1271 | sbi->s_qf_names[qtype] = qname; | ||
1272 | if (strchr(sbi->s_qf_names[qtype], '/')) { | ||
1273 | ext4_msg(sb, KERN_ERR, | ||
1274 | "quotafile must be on filesystem root"); | ||
1275 | kfree(sbi->s_qf_names[qtype]); | ||
1276 | sbi->s_qf_names[qtype] = NULL; | ||
1277 | return 0; | ||
1278 | } | ||
1279 | set_opt(sbi->s_mount_opt, QUOTA); | ||
1280 | return 1; | ||
1281 | } | ||
1282 | |||
1283 | static int clear_qf_name(struct super_block *sb, int qtype) | ||
1284 | { | ||
1285 | |||
1286 | struct ext4_sb_info *sbi = EXT4_SB(sb); | ||
1287 | |||
1288 | if (sb_any_quota_loaded(sb) && | ||
1289 | sbi->s_qf_names[qtype]) { | ||
1290 | ext4_msg(sb, KERN_ERR, "Cannot change journaled quota options" | ||
1291 | " when quota turned on"); | ||
1292 | return 0; | ||
1293 | } | ||
1294 | /* | ||
1295 | * The space will be released later when all options are confirmed | ||
1296 | * to be correct | ||
1297 | */ | ||
1298 | sbi->s_qf_names[qtype] = NULL; | ||
1299 | return 1; | ||
1300 | } | ||
1301 | #endif | ||
1208 | 1302 | ||
1209 | static int parse_options(char *options, struct super_block *sb, | 1303 | static int parse_options(char *options, struct super_block *sb, |
1210 | unsigned long *journal_devnum, | 1304 | unsigned long *journal_devnum, |
@@ -1217,8 +1311,7 @@ static int parse_options(char *options, struct super_block *sb, | |||
1217 | int data_opt = 0; | 1311 | int data_opt = 0; |
1218 | int option; | 1312 | int option; |
1219 | #ifdef CONFIG_QUOTA | 1313 | #ifdef CONFIG_QUOTA |
1220 | int qtype, qfmt; | 1314 | int qfmt; |
1221 | char *qname; | ||
1222 | #endif | 1315 | #endif |
1223 | 1316 | ||
1224 | if (!options) | 1317 | if (!options) |
@@ -1229,19 +1322,31 @@ static int parse_options(char *options, struct super_block *sb, | |||
1229 | if (!*p) | 1322 | if (!*p) |
1230 | continue; | 1323 | continue; |
1231 | 1324 | ||
1325 | /* | ||
1326 | * Initialize args struct so we know whether arg was | ||
1327 | * found; some options take optional arguments. | ||
1328 | */ | ||
1329 | args[0].to = args[0].from = 0; | ||
1232 | token = match_token(p, tokens, args); | 1330 | token = match_token(p, tokens, args); |
1233 | switch (token) { | 1331 | switch (token) { |
1234 | case Opt_bsd_df: | 1332 | case Opt_bsd_df: |
1333 | ext4_msg(sb, KERN_WARNING, deprecated_msg, p, "2.6.38"); | ||
1235 | clear_opt(sbi->s_mount_opt, MINIX_DF); | 1334 | clear_opt(sbi->s_mount_opt, MINIX_DF); |
1236 | break; | 1335 | break; |
1237 | case Opt_minix_df: | 1336 | case Opt_minix_df: |
1337 | ext4_msg(sb, KERN_WARNING, deprecated_msg, p, "2.6.38"); | ||
1238 | set_opt(sbi->s_mount_opt, MINIX_DF); | 1338 | set_opt(sbi->s_mount_opt, MINIX_DF); |
1339 | |||
1239 | break; | 1340 | break; |
1240 | case Opt_grpid: | 1341 | case Opt_grpid: |
1342 | ext4_msg(sb, KERN_WARNING, deprecated_msg, p, "2.6.38"); | ||
1241 | set_opt(sbi->s_mount_opt, GRPID); | 1343 | set_opt(sbi->s_mount_opt, GRPID); |
1344 | |||
1242 | break; | 1345 | break; |
1243 | case Opt_nogrpid: | 1346 | case Opt_nogrpid: |
1347 | ext4_msg(sb, KERN_WARNING, deprecated_msg, p, "2.6.38"); | ||
1244 | clear_opt(sbi->s_mount_opt, GRPID); | 1348 | clear_opt(sbi->s_mount_opt, GRPID); |
1349 | |||
1245 | break; | 1350 | break; |
1246 | case Opt_resuid: | 1351 | case Opt_resuid: |
1247 | if (match_int(&args[0], &option)) | 1352 | if (match_int(&args[0], &option)) |
@@ -1378,14 +1483,13 @@ static int parse_options(char *options, struct super_block *sb, | |||
1378 | data_opt = EXT4_MOUNT_WRITEBACK_DATA; | 1483 | data_opt = EXT4_MOUNT_WRITEBACK_DATA; |
1379 | datacheck: | 1484 | datacheck: |
1380 | if (is_remount) { | 1485 | if (is_remount) { |
1381 | if ((sbi->s_mount_opt & EXT4_MOUNT_DATA_FLAGS) | 1486 | if (test_opt(sb, DATA_FLAGS) != data_opt) { |
1382 | != data_opt) { | ||
1383 | ext4_msg(sb, KERN_ERR, | 1487 | ext4_msg(sb, KERN_ERR, |
1384 | "Cannot change data mode on remount"); | 1488 | "Cannot change data mode on remount"); |
1385 | return 0; | 1489 | return 0; |
1386 | } | 1490 | } |
1387 | } else { | 1491 | } else { |
1388 | sbi->s_mount_opt &= ~EXT4_MOUNT_DATA_FLAGS; | 1492 | clear_opt(sbi->s_mount_opt, DATA_FLAGS); |
1389 | sbi->s_mount_opt |= data_opt; | 1493 | sbi->s_mount_opt |= data_opt; |
1390 | } | 1494 | } |
1391 | break; | 1495 | break; |
@@ -1397,63 +1501,22 @@ static int parse_options(char *options, struct super_block *sb, | |||
1397 | break; | 1501 | break; |
1398 | #ifdef CONFIG_QUOTA | 1502 | #ifdef CONFIG_QUOTA |
1399 | case Opt_usrjquota: | 1503 | case Opt_usrjquota: |
1400 | qtype = USRQUOTA; | 1504 | if (!set_qf_name(sb, USRQUOTA, &args[0])) |
1401 | goto set_qf_name; | ||
1402 | case Opt_grpjquota: | ||
1403 | qtype = GRPQUOTA; | ||
1404 | set_qf_name: | ||
1405 | if (sb_any_quota_loaded(sb) && | ||
1406 | !sbi->s_qf_names[qtype]) { | ||
1407 | ext4_msg(sb, KERN_ERR, | ||
1408 | "Cannot change journaled " | ||
1409 | "quota options when quota turned on"); | ||
1410 | return 0; | 1505 | return 0; |
1411 | } | 1506 | break; |
1412 | qname = match_strdup(&args[0]); | 1507 | case Opt_grpjquota: |
1413 | if (!qname) { | 1508 | if (!set_qf_name(sb, GRPQUOTA, &args[0])) |
1414 | ext4_msg(sb, KERN_ERR, | ||
1415 | "Not enough memory for " | ||
1416 | "storing quotafile name"); | ||
1417 | return 0; | ||
1418 | } | ||
1419 | if (sbi->s_qf_names[qtype] && | ||
1420 | strcmp(sbi->s_qf_names[qtype], qname)) { | ||
1421 | ext4_msg(sb, KERN_ERR, | ||
1422 | "%s quota file already " | ||
1423 | "specified", QTYPE2NAME(qtype)); | ||
1424 | kfree(qname); | ||
1425 | return 0; | ||
1426 | } | ||
1427 | sbi->s_qf_names[qtype] = qname; | ||
1428 | if (strchr(sbi->s_qf_names[qtype], '/')) { | ||
1429 | ext4_msg(sb, KERN_ERR, | ||
1430 | "quotafile must be on " | ||
1431 | "filesystem root"); | ||
1432 | kfree(sbi->s_qf_names[qtype]); | ||
1433 | sbi->s_qf_names[qtype] = NULL; | ||
1434 | return 0; | 1509 | return 0; |
1435 | } | ||
1436 | set_opt(sbi->s_mount_opt, QUOTA); | ||
1437 | break; | 1510 | break; |
1438 | case Opt_offusrjquota: | 1511 | case Opt_offusrjquota: |
1439 | qtype = USRQUOTA; | 1512 | if (!clear_qf_name(sb, USRQUOTA)) |
1440 | goto clear_qf_name; | 1513 | return 0; |
1514 | break; | ||
1441 | case Opt_offgrpjquota: | 1515 | case Opt_offgrpjquota: |
1442 | qtype = GRPQUOTA; | 1516 | if (!clear_qf_name(sb, GRPQUOTA)) |
1443 | clear_qf_name: | ||
1444 | if (sb_any_quota_loaded(sb) && | ||
1445 | sbi->s_qf_names[qtype]) { | ||
1446 | ext4_msg(sb, KERN_ERR, "Cannot change " | ||
1447 | "journaled quota options when " | ||
1448 | "quota turned on"); | ||
1449 | return 0; | 1517 | return 0; |
1450 | } | ||
1451 | /* | ||
1452 | * The space will be released later when all options | ||
1453 | * are confirmed to be correct | ||
1454 | */ | ||
1455 | sbi->s_qf_names[qtype] = NULL; | ||
1456 | break; | 1518 | break; |
1519 | |||
1457 | case Opt_jqfmt_vfsold: | 1520 | case Opt_jqfmt_vfsold: |
1458 | qfmt = QFMT_VFS_OLD; | 1521 | qfmt = QFMT_VFS_OLD; |
1459 | goto set_qf_format; | 1522 | goto set_qf_format; |
@@ -1518,10 +1581,11 @@ set_qf_format: | |||
1518 | clear_opt(sbi->s_mount_opt, BARRIER); | 1581 | clear_opt(sbi->s_mount_opt, BARRIER); |
1519 | break; | 1582 | break; |
1520 | case Opt_barrier: | 1583 | case Opt_barrier: |
1521 | if (match_int(&args[0], &option)) { | 1584 | if (args[0].from) { |
1522 | set_opt(sbi->s_mount_opt, BARRIER); | 1585 | if (match_int(&args[0], &option)) |
1523 | break; | 1586 | return 0; |
1524 | } | 1587 | } else |
1588 | option = 1; /* No argument, default to 1 */ | ||
1525 | if (option) | 1589 | if (option) |
1526 | set_opt(sbi->s_mount_opt, BARRIER); | 1590 | set_opt(sbi->s_mount_opt, BARRIER); |
1527 | else | 1591 | else |
@@ -1594,10 +1658,11 @@ set_qf_format: | |||
1594 | set_opt(sbi->s_mount_opt,NO_AUTO_DA_ALLOC); | 1658 | set_opt(sbi->s_mount_opt,NO_AUTO_DA_ALLOC); |
1595 | break; | 1659 | break; |
1596 | case Opt_auto_da_alloc: | 1660 | case Opt_auto_da_alloc: |
1597 | if (match_int(&args[0], &option)) { | 1661 | if (args[0].from) { |
1598 | clear_opt(sbi->s_mount_opt, NO_AUTO_DA_ALLOC); | 1662 | if (match_int(&args[0], &option)) |
1599 | break; | 1663 | return 0; |
1600 | } | 1664 | } else |
1665 | option = 1; /* No argument, default to 1 */ | ||
1601 | if (option) | 1666 | if (option) |
1602 | clear_opt(sbi->s_mount_opt, NO_AUTO_DA_ALLOC); | 1667 | clear_opt(sbi->s_mount_opt, NO_AUTO_DA_ALLOC); |
1603 | else | 1668 | else |
@@ -1609,6 +1674,12 @@ set_qf_format: | |||
1609 | case Opt_nodiscard: | 1674 | case Opt_nodiscard: |
1610 | clear_opt(sbi->s_mount_opt, DISCARD); | 1675 | clear_opt(sbi->s_mount_opt, DISCARD); |
1611 | break; | 1676 | break; |
1677 | case Opt_dioread_nolock: | ||
1678 | set_opt(sbi->s_mount_opt, DIOREAD_NOLOCK); | ||
1679 | break; | ||
1680 | case Opt_dioread_lock: | ||
1681 | clear_opt(sbi->s_mount_opt, DIOREAD_NOLOCK); | ||
1682 | break; | ||
1612 | default: | 1683 | default: |
1613 | ext4_msg(sb, KERN_ERR, | 1684 | ext4_msg(sb, KERN_ERR, |
1614 | "Unrecognized mount option \"%s\" " | 1685 | "Unrecognized mount option \"%s\" " |
@@ -1618,18 +1689,13 @@ set_qf_format: | |||
1618 | } | 1689 | } |
1619 | #ifdef CONFIG_QUOTA | 1690 | #ifdef CONFIG_QUOTA |
1620 | if (sbi->s_qf_names[USRQUOTA] || sbi->s_qf_names[GRPQUOTA]) { | 1691 | if (sbi->s_qf_names[USRQUOTA] || sbi->s_qf_names[GRPQUOTA]) { |
1621 | if ((sbi->s_mount_opt & EXT4_MOUNT_USRQUOTA) && | 1692 | if (test_opt(sb, USRQUOTA) && sbi->s_qf_names[USRQUOTA]) |
1622 | sbi->s_qf_names[USRQUOTA]) | ||
1623 | clear_opt(sbi->s_mount_opt, USRQUOTA); | 1693 | clear_opt(sbi->s_mount_opt, USRQUOTA); |
1624 | 1694 | ||
1625 | if ((sbi->s_mount_opt & EXT4_MOUNT_GRPQUOTA) && | 1695 | if (test_opt(sb, GRPQUOTA) && sbi->s_qf_names[GRPQUOTA]) |
1626 | sbi->s_qf_names[GRPQUOTA]) | ||
1627 | clear_opt(sbi->s_mount_opt, GRPQUOTA); | 1696 | clear_opt(sbi->s_mount_opt, GRPQUOTA); |
1628 | 1697 | ||
1629 | if ((sbi->s_qf_names[USRQUOTA] && | 1698 | if (test_opt(sb, GRPQUOTA) || test_opt(sb, USRQUOTA)) { |
1630 | (sbi->s_mount_opt & EXT4_MOUNT_GRPQUOTA)) || | ||
1631 | (sbi->s_qf_names[GRPQUOTA] && | ||
1632 | (sbi->s_mount_opt & EXT4_MOUNT_USRQUOTA))) { | ||
1633 | ext4_msg(sb, KERN_ERR, "old and new quota " | 1699 | ext4_msg(sb, KERN_ERR, "old and new quota " |
1634 | "format mixing"); | 1700 | "format mixing"); |
1635 | return 0; | 1701 | return 0; |
@@ -1939,7 +2005,7 @@ static void ext4_orphan_cleanup(struct super_block *sb, | |||
1939 | } | 2005 | } |
1940 | 2006 | ||
1941 | list_add(&EXT4_I(inode)->i_orphan, &EXT4_SB(sb)->s_orphan); | 2007 | list_add(&EXT4_I(inode)->i_orphan, &EXT4_SB(sb)->s_orphan); |
1942 | vfs_dq_init(inode); | 2008 | dquot_initialize(inode); |
1943 | if (inode->i_nlink) { | 2009 | if (inode->i_nlink) { |
1944 | ext4_msg(sb, KERN_DEBUG, | 2010 | ext4_msg(sb, KERN_DEBUG, |
1945 | "%s: truncating inode %lu to %lld bytes", | 2011 | "%s: truncating inode %lu to %lld bytes", |
@@ -2292,7 +2358,7 @@ static void ext4_sb_release(struct kobject *kobj) | |||
2292 | } | 2358 | } |
2293 | 2359 | ||
2294 | 2360 | ||
2295 | static struct sysfs_ops ext4_attr_ops = { | 2361 | static const struct sysfs_ops ext4_attr_ops = { |
2296 | .show = ext4_attr_show, | 2362 | .show = ext4_attr_show, |
2297 | .store = ext4_attr_store, | 2363 | .store = ext4_attr_store, |
2298 | }; | 2364 | }; |
@@ -2432,8 +2498,11 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2432 | def_mount_opts = le32_to_cpu(es->s_default_mount_opts); | 2498 | def_mount_opts = le32_to_cpu(es->s_default_mount_opts); |
2433 | if (def_mount_opts & EXT4_DEFM_DEBUG) | 2499 | if (def_mount_opts & EXT4_DEFM_DEBUG) |
2434 | set_opt(sbi->s_mount_opt, DEBUG); | 2500 | set_opt(sbi->s_mount_opt, DEBUG); |
2435 | if (def_mount_opts & EXT4_DEFM_BSDGROUPS) | 2501 | if (def_mount_opts & EXT4_DEFM_BSDGROUPS) { |
2502 | ext4_msg(sb, KERN_WARNING, deprecated_msg, "bsdgroups", | ||
2503 | "2.6.38"); | ||
2436 | set_opt(sbi->s_mount_opt, GRPID); | 2504 | set_opt(sbi->s_mount_opt, GRPID); |
2505 | } | ||
2437 | if (def_mount_opts & EXT4_DEFM_UID16) | 2506 | if (def_mount_opts & EXT4_DEFM_UID16) |
2438 | set_opt(sbi->s_mount_opt, NO_UID32); | 2507 | set_opt(sbi->s_mount_opt, NO_UID32); |
2439 | #ifdef CONFIG_EXT4_FS_XATTR | 2508 | #ifdef CONFIG_EXT4_FS_XATTR |
@@ -2445,11 +2514,11 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2445 | set_opt(sbi->s_mount_opt, POSIX_ACL); | 2514 | set_opt(sbi->s_mount_opt, POSIX_ACL); |
2446 | #endif | 2515 | #endif |
2447 | if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_DATA) | 2516 | if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_DATA) |
2448 | sbi->s_mount_opt |= EXT4_MOUNT_JOURNAL_DATA; | 2517 | set_opt(sbi->s_mount_opt, JOURNAL_DATA); |
2449 | else if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_ORDERED) | 2518 | else if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_ORDERED) |
2450 | sbi->s_mount_opt |= EXT4_MOUNT_ORDERED_DATA; | 2519 | set_opt(sbi->s_mount_opt, ORDERED_DATA); |
2451 | else if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_WBACK) | 2520 | else if ((def_mount_opts & EXT4_DEFM_JMODE) == EXT4_DEFM_JMODE_WBACK) |
2452 | sbi->s_mount_opt |= EXT4_MOUNT_WRITEBACK_DATA; | 2521 | set_opt(sbi->s_mount_opt, WRITEBACK_DATA); |
2453 | 2522 | ||
2454 | if (le16_to_cpu(sbi->s_es->s_errors) == EXT4_ERRORS_PANIC) | 2523 | if (le16_to_cpu(sbi->s_es->s_errors) == EXT4_ERRORS_PANIC) |
2455 | set_opt(sbi->s_mount_opt, ERRORS_PANIC); | 2524 | set_opt(sbi->s_mount_opt, ERRORS_PANIC); |
@@ -2477,7 +2546,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2477 | goto failed_mount; | 2546 | goto failed_mount; |
2478 | 2547 | ||
2479 | sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | | 2548 | sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | |
2480 | ((sbi->s_mount_opt & EXT4_MOUNT_POSIX_ACL) ? MS_POSIXACL : 0); | 2549 | (test_opt(sb, POSIX_ACL) ? MS_POSIXACL : 0); |
2481 | 2550 | ||
2482 | if (le32_to_cpu(es->s_rev_level) == EXT4_GOOD_OLD_REV && | 2551 | if (le32_to_cpu(es->s_rev_level) == EXT4_GOOD_OLD_REV && |
2483 | (EXT4_HAS_COMPAT_FEATURE(sb, ~0U) || | 2552 | (EXT4_HAS_COMPAT_FEATURE(sb, ~0U) || |
@@ -2766,7 +2835,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2766 | EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER)) { | 2835 | EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER)) { |
2767 | ext4_msg(sb, KERN_ERR, "required journal recovery " | 2836 | ext4_msg(sb, KERN_ERR, "required journal recovery " |
2768 | "suppressed and not mounted read-only"); | 2837 | "suppressed and not mounted read-only"); |
2769 | goto failed_mount4; | 2838 | goto failed_mount_wq; |
2770 | } else { | 2839 | } else { |
2771 | clear_opt(sbi->s_mount_opt, DATA_FLAGS); | 2840 | clear_opt(sbi->s_mount_opt, DATA_FLAGS); |
2772 | set_opt(sbi->s_mount_opt, WRITEBACK_DATA); | 2841 | set_opt(sbi->s_mount_opt, WRITEBACK_DATA); |
@@ -2779,7 +2848,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2779 | !jbd2_journal_set_features(EXT4_SB(sb)->s_journal, 0, 0, | 2848 | !jbd2_journal_set_features(EXT4_SB(sb)->s_journal, 0, 0, |
2780 | JBD2_FEATURE_INCOMPAT_64BIT)) { | 2849 | JBD2_FEATURE_INCOMPAT_64BIT)) { |
2781 | ext4_msg(sb, KERN_ERR, "Failed to set 64-bit journal feature"); | 2850 | ext4_msg(sb, KERN_ERR, "Failed to set 64-bit journal feature"); |
2782 | goto failed_mount4; | 2851 | goto failed_mount_wq; |
2783 | } | 2852 | } |
2784 | 2853 | ||
2785 | if (test_opt(sb, JOURNAL_ASYNC_COMMIT)) { | 2854 | if (test_opt(sb, JOURNAL_ASYNC_COMMIT)) { |
@@ -2818,7 +2887,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2818 | (sbi->s_journal, 0, 0, JBD2_FEATURE_INCOMPAT_REVOKE)) { | 2887 | (sbi->s_journal, 0, 0, JBD2_FEATURE_INCOMPAT_REVOKE)) { |
2819 | ext4_msg(sb, KERN_ERR, "Journal does not support " | 2888 | ext4_msg(sb, KERN_ERR, "Journal does not support " |
2820 | "requested data journaling mode"); | 2889 | "requested data journaling mode"); |
2821 | goto failed_mount4; | 2890 | goto failed_mount_wq; |
2822 | } | 2891 | } |
2823 | default: | 2892 | default: |
2824 | break; | 2893 | break; |
@@ -2826,13 +2895,17 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) | |||
2826 | set_task_ioprio(sbi->s_journal->j_task, journal_ioprio); | 2895 | set_task_ioprio(sbi->s_journal->j_task, journal_ioprio); |
2827 | 2896 | ||
2828 | no_journal: | 2897 | no_journal: |
2829 | |||
2830 | if (test_opt(sb, NOBH)) { | 2898 | if (test_opt(sb, NOBH)) { |
2831 | if (!(test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_WRITEBACK_DATA)) { | 2899 | if (!(test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_WRITEBACK_DATA)) { |
2832 | ext4_msg(sb, KERN_WARNING, "Ignoring nobh option - " | 2900 | ext4_msg(sb, KERN_WARNING, "Ignoring nobh option - " |
2833 | "its supported only with writeback mode"); | 2901 | "its supported only with writeback mode"); |
2834 | clear_opt(sbi->s_mount_opt, NOBH); | 2902 | clear_opt(sbi->s_mount_opt, NOBH); |
2835 | } | 2903 | } |
2904 | if (test_opt(sb, DIOREAD_NOLOCK)) { | ||
2905 | ext4_msg(sb, KERN_WARNING, "dioread_nolock option is " | ||
2906 | "not supported with nobh mode"); | ||
2907 | goto failed_mount_wq; | ||
2908 | } | ||
2836 | } | 2909 | } |
2837 | EXT4_SB(sb)->dio_unwritten_wq = create_workqueue("ext4-dio-unwritten"); | 2910 | EXT4_SB(sb)->dio_unwritten_wq = create_workqueue("ext4-dio-unwritten"); |
2838 | if (!EXT4_SB(sb)->dio_unwritten_wq) { | 2911 | if (!EXT4_SB(sb)->dio_unwritten_wq) { |
@@ -2897,6 +2970,18 @@ no_journal: | |||
2897 | "requested data journaling mode"); | 2970 | "requested data journaling mode"); |
2898 | clear_opt(sbi->s_mount_opt, DELALLOC); | 2971 | clear_opt(sbi->s_mount_opt, DELALLOC); |
2899 | } | 2972 | } |
2973 | if (test_opt(sb, DIOREAD_NOLOCK)) { | ||
2974 | if (test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA) { | ||
2975 | ext4_msg(sb, KERN_WARNING, "Ignoring dioread_nolock " | ||
2976 | "option - requested data journaling mode"); | ||
2977 | clear_opt(sbi->s_mount_opt, DIOREAD_NOLOCK); | ||
2978 | } | ||
2979 | if (sb->s_blocksize < PAGE_SIZE) { | ||
2980 | ext4_msg(sb, KERN_WARNING, "Ignoring dioread_nolock " | ||
2981 | "option - block size is too small"); | ||
2982 | clear_opt(sbi->s_mount_opt, DIOREAD_NOLOCK); | ||
2983 | } | ||
2984 | } | ||
2900 | 2985 | ||
2901 | err = ext4_setup_system_zone(sb); | 2986 | err = ext4_setup_system_zone(sb); |
2902 | if (err) { | 2987 | if (err) { |
@@ -3360,10 +3445,9 @@ static void ext4_clear_journal_err(struct super_block *sb, | |||
3360 | char nbuf[16]; | 3445 | char nbuf[16]; |
3361 | 3446 | ||
3362 | errstr = ext4_decode_error(sb, j_errno, nbuf); | 3447 | errstr = ext4_decode_error(sb, j_errno, nbuf); |
3363 | ext4_warning(sb, __func__, "Filesystem error recorded " | 3448 | ext4_warning(sb, "Filesystem error recorded " |
3364 | "from previous mount: %s", errstr); | 3449 | "from previous mount: %s", errstr); |
3365 | ext4_warning(sb, __func__, "Marking fs in need of " | 3450 | ext4_warning(sb, "Marking fs in need of filesystem check."); |
3366 | "filesystem check."); | ||
3367 | 3451 | ||
3368 | EXT4_SB(sb)->s_mount_state |= EXT4_ERROR_FS; | 3452 | EXT4_SB(sb)->s_mount_state |= EXT4_ERROR_FS; |
3369 | es->s_state |= cpu_to_le16(EXT4_ERROR_FS); | 3453 | es->s_state |= cpu_to_le16(EXT4_ERROR_FS); |
@@ -3514,7 +3598,7 @@ static int ext4_remount(struct super_block *sb, int *flags, char *data) | |||
3514 | ext4_abort(sb, __func__, "Abort forced by user"); | 3598 | ext4_abort(sb, __func__, "Abort forced by user"); |
3515 | 3599 | ||
3516 | sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | | 3600 | sb->s_flags = (sb->s_flags & ~MS_POSIXACL) | |
3517 | ((sbi->s_mount_opt & EXT4_MOUNT_POSIX_ACL) ? MS_POSIXACL : 0); | 3601 | (test_opt(sb, POSIX_ACL) ? MS_POSIXACL : 0); |
3518 | 3602 | ||
3519 | es = sbi->s_es; | 3603 | es = sbi->s_es; |
3520 | 3604 | ||
@@ -3708,7 +3792,7 @@ static int ext4_statfs(struct dentry *dentry, struct kstatfs *buf) | |||
3708 | * Process 1 Process 2 | 3792 | * Process 1 Process 2 |
3709 | * ext4_create() quota_sync() | 3793 | * ext4_create() quota_sync() |
3710 | * jbd2_journal_start() write_dquot() | 3794 | * jbd2_journal_start() write_dquot() |
3711 | * vfs_dq_init() down(dqio_mutex) | 3795 | * dquot_initialize() down(dqio_mutex) |
3712 | * down(dqio_mutex) jbd2_journal_start() | 3796 | * down(dqio_mutex) jbd2_journal_start() |
3713 | * | 3797 | * |
3714 | */ | 3798 | */ |
@@ -3917,9 +4001,7 @@ static ssize_t ext4_quota_write(struct super_block *sb, int type, | |||
3917 | ext4_lblk_t blk = off >> EXT4_BLOCK_SIZE_BITS(sb); | 4001 | ext4_lblk_t blk = off >> EXT4_BLOCK_SIZE_BITS(sb); |
3918 | int err = 0; | 4002 | int err = 0; |
3919 | int offset = off & (sb->s_blocksize - 1); | 4003 | int offset = off & (sb->s_blocksize - 1); |
3920 | int tocopy; | ||
3921 | int journal_quota = EXT4_SB(sb)->s_qf_names[type] != NULL; | 4004 | int journal_quota = EXT4_SB(sb)->s_qf_names[type] != NULL; |
3922 | size_t towrite = len; | ||
3923 | struct buffer_head *bh; | 4005 | struct buffer_head *bh; |
3924 | handle_t *handle = journal_current_handle(); | 4006 | handle_t *handle = journal_current_handle(); |
3925 | 4007 | ||
@@ -3929,52 +4011,53 @@ static ssize_t ext4_quota_write(struct super_block *sb, int type, | |||
3929 | (unsigned long long)off, (unsigned long long)len); | 4011 | (unsigned long long)off, (unsigned long long)len); |
3930 | return -EIO; | 4012 | return -EIO; |
3931 | } | 4013 | } |
4014 | /* | ||
4015 | * Since we account only one data block in transaction credits, | ||
4016 | * then it is impossible to cross a block boundary. | ||
4017 | */ | ||
4018 | if (sb->s_blocksize - offset < len) { | ||
4019 | ext4_msg(sb, KERN_WARNING, "Quota write (off=%llu, len=%llu)" | ||
4020 | " cancelled because not block aligned", | ||
4021 | (unsigned long long)off, (unsigned long long)len); | ||
4022 | return -EIO; | ||
4023 | } | ||
4024 | |||
3932 | mutex_lock_nested(&inode->i_mutex, I_MUTEX_QUOTA); | 4025 | mutex_lock_nested(&inode->i_mutex, I_MUTEX_QUOTA); |
3933 | while (towrite > 0) { | 4026 | bh = ext4_bread(handle, inode, blk, 1, &err); |
3934 | tocopy = sb->s_blocksize - offset < towrite ? | 4027 | if (!bh) |
3935 | sb->s_blocksize - offset : towrite; | 4028 | goto out; |
3936 | bh = ext4_bread(handle, inode, blk, 1, &err); | 4029 | if (journal_quota) { |
3937 | if (!bh) | 4030 | err = ext4_journal_get_write_access(handle, bh); |
4031 | if (err) { | ||
4032 | brelse(bh); | ||
3938 | goto out; | 4033 | goto out; |
3939 | if (journal_quota) { | ||
3940 | err = ext4_journal_get_write_access(handle, bh); | ||
3941 | if (err) { | ||
3942 | brelse(bh); | ||
3943 | goto out; | ||
3944 | } | ||
3945 | } | 4034 | } |
3946 | lock_buffer(bh); | ||
3947 | memcpy(bh->b_data+offset, data, tocopy); | ||
3948 | flush_dcache_page(bh->b_page); | ||
3949 | unlock_buffer(bh); | ||
3950 | if (journal_quota) | ||
3951 | err = ext4_handle_dirty_metadata(handle, NULL, bh); | ||
3952 | else { | ||
3953 | /* Always do at least ordered writes for quotas */ | ||
3954 | err = ext4_jbd2_file_inode(handle, inode); | ||
3955 | mark_buffer_dirty(bh); | ||
3956 | } | ||
3957 | brelse(bh); | ||
3958 | if (err) | ||
3959 | goto out; | ||
3960 | offset = 0; | ||
3961 | towrite -= tocopy; | ||
3962 | data += tocopy; | ||
3963 | blk++; | ||
3964 | } | 4035 | } |
4036 | lock_buffer(bh); | ||
4037 | memcpy(bh->b_data+offset, data, len); | ||
4038 | flush_dcache_page(bh->b_page); | ||
4039 | unlock_buffer(bh); | ||
4040 | if (journal_quota) | ||
4041 | err = ext4_handle_dirty_metadata(handle, NULL, bh); | ||
4042 | else { | ||
4043 | /* Always do at least ordered writes for quotas */ | ||
4044 | err = ext4_jbd2_file_inode(handle, inode); | ||
4045 | mark_buffer_dirty(bh); | ||
4046 | } | ||
4047 | brelse(bh); | ||
3965 | out: | 4048 | out: |
3966 | if (len == towrite) { | 4049 | if (err) { |
3967 | mutex_unlock(&inode->i_mutex); | 4050 | mutex_unlock(&inode->i_mutex); |
3968 | return err; | 4051 | return err; |
3969 | } | 4052 | } |
3970 | if (inode->i_size < off+len-towrite) { | 4053 | if (inode->i_size < off + len) { |
3971 | i_size_write(inode, off+len-towrite); | 4054 | i_size_write(inode, off + len); |
3972 | EXT4_I(inode)->i_disksize = inode->i_size; | 4055 | EXT4_I(inode)->i_disksize = inode->i_size; |
3973 | } | 4056 | } |
3974 | inode->i_mtime = inode->i_ctime = CURRENT_TIME; | 4057 | inode->i_mtime = inode->i_ctime = CURRENT_TIME; |
3975 | ext4_mark_inode_dirty(handle, inode); | 4058 | ext4_mark_inode_dirty(handle, inode); |
3976 | mutex_unlock(&inode->i_mutex); | 4059 | mutex_unlock(&inode->i_mutex); |
3977 | return len - towrite; | 4060 | return len; |
3978 | } | 4061 | } |
3979 | 4062 | ||
3980 | #endif | 4063 | #endif |
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index f3a2f7ed45aa..b4c5aa8489d8 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c | |||
@@ -227,7 +227,8 @@ ext4_xattr_block_get(struct inode *inode, int name_index, const char *name, | |||
227 | ea_bdebug(bh, "b_count=%d, refcount=%d", | 227 | ea_bdebug(bh, "b_count=%d, refcount=%d", |
228 | atomic_read(&(bh->b_count)), le32_to_cpu(BHDR(bh)->h_refcount)); | 228 | atomic_read(&(bh->b_count)), le32_to_cpu(BHDR(bh)->h_refcount)); |
229 | if (ext4_xattr_check_block(bh)) { | 229 | if (ext4_xattr_check_block(bh)) { |
230 | bad_block: ext4_error(inode->i_sb, __func__, | 230 | bad_block: |
231 | ext4_error(inode->i_sb, | ||
231 | "inode %lu: bad block %llu", inode->i_ino, | 232 | "inode %lu: bad block %llu", inode->i_ino, |
232 | EXT4_I(inode)->i_file_acl); | 233 | EXT4_I(inode)->i_file_acl); |
233 | error = -EIO; | 234 | error = -EIO; |
@@ -267,7 +268,7 @@ ext4_xattr_ibody_get(struct inode *inode, int name_index, const char *name, | |||
267 | void *end; | 268 | void *end; |
268 | int error; | 269 | int error; |
269 | 270 | ||
270 | if (!(EXT4_I(inode)->i_state & EXT4_STATE_XATTR)) | 271 | if (!ext4_test_inode_state(inode, EXT4_STATE_XATTR)) |
271 | return -ENODATA; | 272 | return -ENODATA; |
272 | error = ext4_get_inode_loc(inode, &iloc); | 273 | error = ext4_get_inode_loc(inode, &iloc); |
273 | if (error) | 274 | if (error) |
@@ -371,7 +372,7 @@ ext4_xattr_block_list(struct dentry *dentry, char *buffer, size_t buffer_size) | |||
371 | ea_bdebug(bh, "b_count=%d, refcount=%d", | 372 | ea_bdebug(bh, "b_count=%d, refcount=%d", |
372 | atomic_read(&(bh->b_count)), le32_to_cpu(BHDR(bh)->h_refcount)); | 373 | atomic_read(&(bh->b_count)), le32_to_cpu(BHDR(bh)->h_refcount)); |
373 | if (ext4_xattr_check_block(bh)) { | 374 | if (ext4_xattr_check_block(bh)) { |
374 | ext4_error(inode->i_sb, __func__, | 375 | ext4_error(inode->i_sb, |
375 | "inode %lu: bad block %llu", inode->i_ino, | 376 | "inode %lu: bad block %llu", inode->i_ino, |
376 | EXT4_I(inode)->i_file_acl); | 377 | EXT4_I(inode)->i_file_acl); |
377 | error = -EIO; | 378 | error = -EIO; |
@@ -396,7 +397,7 @@ ext4_xattr_ibody_list(struct dentry *dentry, char *buffer, size_t buffer_size) | |||
396 | void *end; | 397 | void *end; |
397 | int error; | 398 | int error; |
398 | 399 | ||
399 | if (!(EXT4_I(inode)->i_state & EXT4_STATE_XATTR)) | 400 | if (!ext4_test_inode_state(inode, EXT4_STATE_XATTR)) |
400 | return 0; | 401 | return 0; |
401 | error = ext4_get_inode_loc(inode, &iloc); | 402 | error = ext4_get_inode_loc(inode, &iloc); |
402 | if (error) | 403 | if (error) |
@@ -494,7 +495,7 @@ ext4_xattr_release_block(handle_t *handle, struct inode *inode, | |||
494 | error = ext4_handle_dirty_metadata(handle, inode, bh); | 495 | error = ext4_handle_dirty_metadata(handle, inode, bh); |
495 | if (IS_SYNC(inode)) | 496 | if (IS_SYNC(inode)) |
496 | ext4_handle_sync(handle); | 497 | ext4_handle_sync(handle); |
497 | vfs_dq_free_block(inode, 1); | 498 | dquot_free_block(inode, 1); |
498 | ea_bdebug(bh, "refcount now=%d; releasing", | 499 | ea_bdebug(bh, "refcount now=%d; releasing", |
499 | le32_to_cpu(BHDR(bh)->h_refcount)); | 500 | le32_to_cpu(BHDR(bh)->h_refcount)); |
500 | if (ce) | 501 | if (ce) |
@@ -665,9 +666,8 @@ ext4_xattr_block_find(struct inode *inode, struct ext4_xattr_info *i, | |||
665 | atomic_read(&(bs->bh->b_count)), | 666 | atomic_read(&(bs->bh->b_count)), |
666 | le32_to_cpu(BHDR(bs->bh)->h_refcount)); | 667 | le32_to_cpu(BHDR(bs->bh)->h_refcount)); |
667 | if (ext4_xattr_check_block(bs->bh)) { | 668 | if (ext4_xattr_check_block(bs->bh)) { |
668 | ext4_error(sb, __func__, | 669 | ext4_error(sb, "inode %lu: bad block %llu", |
669 | "inode %lu: bad block %llu", inode->i_ino, | 670 | inode->i_ino, EXT4_I(inode)->i_file_acl); |
670 | EXT4_I(inode)->i_file_acl); | ||
671 | error = -EIO; | 671 | error = -EIO; |
672 | goto cleanup; | 672 | goto cleanup; |
673 | } | 673 | } |
@@ -787,8 +787,8 @@ inserted: | |||
787 | else { | 787 | else { |
788 | /* The old block is released after updating | 788 | /* The old block is released after updating |
789 | the inode. */ | 789 | the inode. */ |
790 | error = -EDQUOT; | 790 | error = dquot_alloc_block(inode, 1); |
791 | if (vfs_dq_alloc_block(inode, 1)) | 791 | if (error) |
792 | goto cleanup; | 792 | goto cleanup; |
793 | error = ext4_journal_get_write_access(handle, | 793 | error = ext4_journal_get_write_access(handle, |
794 | new_bh); | 794 | new_bh); |
@@ -876,13 +876,12 @@ cleanup: | |||
876 | return error; | 876 | return error; |
877 | 877 | ||
878 | cleanup_dquot: | 878 | cleanup_dquot: |
879 | vfs_dq_free_block(inode, 1); | 879 | dquot_free_block(inode, 1); |
880 | goto cleanup; | 880 | goto cleanup; |
881 | 881 | ||
882 | bad_block: | 882 | bad_block: |
883 | ext4_error(inode->i_sb, __func__, | 883 | ext4_error(inode->i_sb, "inode %lu: bad block %llu", |
884 | "inode %lu: bad block %llu", inode->i_ino, | 884 | inode->i_ino, EXT4_I(inode)->i_file_acl); |
885 | EXT4_I(inode)->i_file_acl); | ||
886 | goto cleanup; | 885 | goto cleanup; |
887 | 886 | ||
888 | #undef header | 887 | #undef header |
@@ -908,7 +907,7 @@ ext4_xattr_ibody_find(struct inode *inode, struct ext4_xattr_info *i, | |||
908 | is->s.base = is->s.first = IFIRST(header); | 907 | is->s.base = is->s.first = IFIRST(header); |
909 | is->s.here = is->s.first; | 908 | is->s.here = is->s.first; |
910 | is->s.end = (void *)raw_inode + EXT4_SB(inode->i_sb)->s_inode_size; | 909 | is->s.end = (void *)raw_inode + EXT4_SB(inode->i_sb)->s_inode_size; |
911 | if (EXT4_I(inode)->i_state & EXT4_STATE_XATTR) { | 910 | if (ext4_test_inode_state(inode, EXT4_STATE_XATTR)) { |
912 | error = ext4_xattr_check_names(IFIRST(header), is->s.end); | 911 | error = ext4_xattr_check_names(IFIRST(header), is->s.end); |
913 | if (error) | 912 | if (error) |
914 | return error; | 913 | return error; |
@@ -940,10 +939,10 @@ ext4_xattr_ibody_set(handle_t *handle, struct inode *inode, | |||
940 | header = IHDR(inode, ext4_raw_inode(&is->iloc)); | 939 | header = IHDR(inode, ext4_raw_inode(&is->iloc)); |
941 | if (!IS_LAST_ENTRY(s->first)) { | 940 | if (!IS_LAST_ENTRY(s->first)) { |
942 | header->h_magic = cpu_to_le32(EXT4_XATTR_MAGIC); | 941 | header->h_magic = cpu_to_le32(EXT4_XATTR_MAGIC); |
943 | EXT4_I(inode)->i_state |= EXT4_STATE_XATTR; | 942 | ext4_set_inode_state(inode, EXT4_STATE_XATTR); |
944 | } else { | 943 | } else { |
945 | header->h_magic = cpu_to_le32(0); | 944 | header->h_magic = cpu_to_le32(0); |
946 | EXT4_I(inode)->i_state &= ~EXT4_STATE_XATTR; | 945 | ext4_clear_inode_state(inode, EXT4_STATE_XATTR); |
947 | } | 946 | } |
948 | return 0; | 947 | return 0; |
949 | } | 948 | } |
@@ -986,8 +985,8 @@ ext4_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index, | |||
986 | if (strlen(name) > 255) | 985 | if (strlen(name) > 255) |
987 | return -ERANGE; | 986 | return -ERANGE; |
988 | down_write(&EXT4_I(inode)->xattr_sem); | 987 | down_write(&EXT4_I(inode)->xattr_sem); |
989 | no_expand = EXT4_I(inode)->i_state & EXT4_STATE_NO_EXPAND; | 988 | no_expand = ext4_test_inode_state(inode, EXT4_STATE_NO_EXPAND); |
990 | EXT4_I(inode)->i_state |= EXT4_STATE_NO_EXPAND; | 989 | ext4_set_inode_state(inode, EXT4_STATE_NO_EXPAND); |
991 | 990 | ||
992 | error = ext4_get_inode_loc(inode, &is.iloc); | 991 | error = ext4_get_inode_loc(inode, &is.iloc); |
993 | if (error) | 992 | if (error) |
@@ -997,10 +996,10 @@ ext4_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index, | |||
997 | if (error) | 996 | if (error) |
998 | goto cleanup; | 997 | goto cleanup; |
999 | 998 | ||
1000 | if (EXT4_I(inode)->i_state & EXT4_STATE_NEW) { | 999 | if (ext4_test_inode_state(inode, EXT4_STATE_NEW)) { |
1001 | struct ext4_inode *raw_inode = ext4_raw_inode(&is.iloc); | 1000 | struct ext4_inode *raw_inode = ext4_raw_inode(&is.iloc); |
1002 | memset(raw_inode, 0, EXT4_SB(inode->i_sb)->s_inode_size); | 1001 | memset(raw_inode, 0, EXT4_SB(inode->i_sb)->s_inode_size); |
1003 | EXT4_I(inode)->i_state &= ~EXT4_STATE_NEW; | 1002 | ext4_clear_inode_state(inode, EXT4_STATE_NEW); |
1004 | } | 1003 | } |
1005 | 1004 | ||
1006 | error = ext4_xattr_ibody_find(inode, &i, &is); | 1005 | error = ext4_xattr_ibody_find(inode, &i, &is); |
@@ -1052,7 +1051,7 @@ ext4_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index, | |||
1052 | ext4_xattr_update_super_block(handle, inode->i_sb); | 1051 | ext4_xattr_update_super_block(handle, inode->i_sb); |
1053 | inode->i_ctime = ext4_current_time(inode); | 1052 | inode->i_ctime = ext4_current_time(inode); |
1054 | if (!value) | 1053 | if (!value) |
1055 | EXT4_I(inode)->i_state &= ~EXT4_STATE_NO_EXPAND; | 1054 | ext4_clear_inode_state(inode, EXT4_STATE_NO_EXPAND); |
1056 | error = ext4_mark_iloc_dirty(handle, inode, &is.iloc); | 1055 | error = ext4_mark_iloc_dirty(handle, inode, &is.iloc); |
1057 | /* | 1056 | /* |
1058 | * The bh is consumed by ext4_mark_iloc_dirty, even with | 1057 | * The bh is consumed by ext4_mark_iloc_dirty, even with |
@@ -1067,7 +1066,7 @@ cleanup: | |||
1067 | brelse(is.iloc.bh); | 1066 | brelse(is.iloc.bh); |
1068 | brelse(bs.bh); | 1067 | brelse(bs.bh); |
1069 | if (no_expand == 0) | 1068 | if (no_expand == 0) |
1070 | EXT4_I(inode)->i_state &= ~EXT4_STATE_NO_EXPAND; | 1069 | ext4_clear_inode_state(inode, EXT4_STATE_NO_EXPAND); |
1071 | up_write(&EXT4_I(inode)->xattr_sem); | 1070 | up_write(&EXT4_I(inode)->xattr_sem); |
1072 | return error; | 1071 | return error; |
1073 | } | 1072 | } |
@@ -1195,9 +1194,8 @@ retry: | |||
1195 | if (!bh) | 1194 | if (!bh) |
1196 | goto cleanup; | 1195 | goto cleanup; |
1197 | if (ext4_xattr_check_block(bh)) { | 1196 | if (ext4_xattr_check_block(bh)) { |
1198 | ext4_error(inode->i_sb, __func__, | 1197 | ext4_error(inode->i_sb, "inode %lu: bad block %llu", |
1199 | "inode %lu: bad block %llu", inode->i_ino, | 1198 | inode->i_ino, EXT4_I(inode)->i_file_acl); |
1200 | EXT4_I(inode)->i_file_acl); | ||
1201 | error = -EIO; | 1199 | error = -EIO; |
1202 | goto cleanup; | 1200 | goto cleanup; |
1203 | } | 1201 | } |
@@ -1302,6 +1300,8 @@ retry: | |||
1302 | 1300 | ||
1303 | /* Remove the chosen entry from the inode */ | 1301 | /* Remove the chosen entry from the inode */ |
1304 | error = ext4_xattr_ibody_set(handle, inode, &i, is); | 1302 | error = ext4_xattr_ibody_set(handle, inode, &i, is); |
1303 | if (error) | ||
1304 | goto cleanup; | ||
1305 | 1305 | ||
1306 | entry = IFIRST(header); | 1306 | entry = IFIRST(header); |
1307 | if (entry_size + EXT4_XATTR_SIZE(size) >= new_extra_isize) | 1307 | if (entry_size + EXT4_XATTR_SIZE(size) >= new_extra_isize) |
@@ -1372,16 +1372,14 @@ ext4_xattr_delete_inode(handle_t *handle, struct inode *inode) | |||
1372 | goto cleanup; | 1372 | goto cleanup; |
1373 | bh = sb_bread(inode->i_sb, EXT4_I(inode)->i_file_acl); | 1373 | bh = sb_bread(inode->i_sb, EXT4_I(inode)->i_file_acl); |
1374 | if (!bh) { | 1374 | if (!bh) { |
1375 | ext4_error(inode->i_sb, __func__, | 1375 | ext4_error(inode->i_sb, "inode %lu: block %llu read error", |
1376 | "inode %lu: block %llu read error", inode->i_ino, | 1376 | inode->i_ino, EXT4_I(inode)->i_file_acl); |
1377 | EXT4_I(inode)->i_file_acl); | ||
1378 | goto cleanup; | 1377 | goto cleanup; |
1379 | } | 1378 | } |
1380 | if (BHDR(bh)->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC) || | 1379 | if (BHDR(bh)->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC) || |
1381 | BHDR(bh)->h_blocks != cpu_to_le32(1)) { | 1380 | BHDR(bh)->h_blocks != cpu_to_le32(1)) { |
1382 | ext4_error(inode->i_sb, __func__, | 1381 | ext4_error(inode->i_sb, "inode %lu: bad block %llu", |
1383 | "inode %lu: bad block %llu", inode->i_ino, | 1382 | inode->i_ino, EXT4_I(inode)->i_file_acl); |
1384 | EXT4_I(inode)->i_file_acl); | ||
1385 | goto cleanup; | 1383 | goto cleanup; |
1386 | } | 1384 | } |
1387 | ext4_xattr_release_block(handle, inode, bh); | 1385 | ext4_xattr_release_block(handle, inode, bh); |
@@ -1506,7 +1504,7 @@ again: | |||
1506 | } | 1504 | } |
1507 | bh = sb_bread(inode->i_sb, ce->e_block); | 1505 | bh = sb_bread(inode->i_sb, ce->e_block); |
1508 | if (!bh) { | 1506 | if (!bh) { |
1509 | ext4_error(inode->i_sb, __func__, | 1507 | ext4_error(inode->i_sb, |
1510 | "inode %lu: block %lu read error", | 1508 | "inode %lu: block %lu read error", |
1511 | inode->i_ino, (unsigned long) ce->e_block); | 1509 | inode->i_ino, (unsigned long) ce->e_block); |
1512 | } else if (le32_to_cpu(BHDR(bh)->h_refcount) >= | 1510 | } else if (le32_to_cpu(BHDR(bh)->h_refcount) >= |
diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 14da530b05ca..fbeecdc194dc 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c | |||
@@ -577,7 +577,7 @@ static inline loff_t fat_i_pos_read(struct msdos_sb_info *sbi, | |||
577 | return i_pos; | 577 | return i_pos; |
578 | } | 578 | } |
579 | 579 | ||
580 | static int fat_write_inode(struct inode *inode, int wait) | 580 | static int __fat_write_inode(struct inode *inode, int wait) |
581 | { | 581 | { |
582 | struct super_block *sb = inode->i_sb; | 582 | struct super_block *sb = inode->i_sb; |
583 | struct msdos_sb_info *sbi = MSDOS_SB(sb); | 583 | struct msdos_sb_info *sbi = MSDOS_SB(sb); |
@@ -634,9 +634,14 @@ retry: | |||
634 | return err; | 634 | return err; |
635 | } | 635 | } |
636 | 636 | ||
637 | static int fat_write_inode(struct inode *inode, struct writeback_control *wbc) | ||
638 | { | ||
639 | return __fat_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL); | ||
640 | } | ||
641 | |||
637 | int fat_sync_inode(struct inode *inode) | 642 | int fat_sync_inode(struct inode *inode) |
638 | { | 643 | { |
639 | return fat_write_inode(inode, 1); | 644 | return __fat_write_inode(inode, 1); |
640 | } | 645 | } |
641 | 646 | ||
642 | EXPORT_SYMBOL_GPL(fat_sync_inode); | 647 | EXPORT_SYMBOL_GPL(fat_sync_inode); |
diff --git a/fs/fcntl.c b/fs/fcntl.c index 97e01dc0d95f..452d02f9075e 100644 --- a/fs/fcntl.c +++ b/fs/fcntl.c | |||
@@ -344,7 +344,7 @@ static long do_fcntl(int fd, unsigned int cmd, unsigned long arg, | |||
344 | switch (cmd) { | 344 | switch (cmd) { |
345 | case F_DUPFD: | 345 | case F_DUPFD: |
346 | case F_DUPFD_CLOEXEC: | 346 | case F_DUPFD_CLOEXEC: |
347 | if (arg >= current->signal->rlim[RLIMIT_NOFILE].rlim_cur) | 347 | if (arg >= rlimit(RLIMIT_NOFILE)) |
348 | break; | 348 | break; |
349 | err = alloc_fd(arg, cmd == F_DUPFD_CLOEXEC ? O_CLOEXEC : 0); | 349 | err = alloc_fd(arg, cmd == F_DUPFD_CLOEXEC ? O_CLOEXEC : 0); |
350 | if (err >= 0) { | 350 | if (err >= 0) { |
@@ -257,7 +257,7 @@ int expand_files(struct files_struct *files, int nr) | |||
257 | * N.B. For clone tasks sharing a files structure, this test | 257 | * N.B. For clone tasks sharing a files structure, this test |
258 | * will limit the total number of files that can be opened. | 258 | * will limit the total number of files that can be opened. |
259 | */ | 259 | */ |
260 | if (nr >= current->signal->rlim[RLIMIT_NOFILE].rlim_cur) | 260 | if (nr >= rlimit(RLIMIT_NOFILE)) |
261 | return -EMFILE; | 261 | return -EMFILE; |
262 | 262 | ||
263 | /* Do we need to expand? */ | 263 | /* Do we need to expand? */ |
@@ -478,7 +478,7 @@ repeat: | |||
478 | error = fd; | 478 | error = fd; |
479 | #if 1 | 479 | #if 1 |
480 | /* Sanity check */ | 480 | /* Sanity check */ |
481 | if (rcu_dereference(fdt->fd[fd]) != NULL) { | 481 | if (rcu_dereference_raw(fdt->fd[fd]) != NULL) { |
482 | printk(KERN_WARNING "alloc_fd: slot %d not NULL!\n", fd); | 482 | printk(KERN_WARNING "alloc_fd: slot %d not NULL!\n", fd); |
483 | rcu_assign_pointer(fdt->fd[fd], NULL); | 483 | rcu_assign_pointer(fdt->fd[fd], NULL); |
484 | } | 484 | } |
diff --git a/fs/file_table.c b/fs/file_table.c index b98404b54383..32d12b78bac8 100644 --- a/fs/file_table.c +++ b/fs/file_table.c | |||
@@ -393,7 +393,9 @@ retry: | |||
393 | continue; | 393 | continue; |
394 | if (!(f->f_mode & FMODE_WRITE)) | 394 | if (!(f->f_mode & FMODE_WRITE)) |
395 | continue; | 395 | continue; |
396 | spin_lock(&f->f_lock); | ||
396 | f->f_mode &= ~FMODE_WRITE; | 397 | f->f_mode &= ~FMODE_WRITE; |
398 | spin_unlock(&f->f_lock); | ||
397 | if (file_check_writeable(f) != 0) | 399 | if (file_check_writeable(f) != 0) |
398 | continue; | 400 | continue; |
399 | file_release_write(f); | 401 | file_release_write(f); |
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 1a7c42c64ff4..76fc4d594acb 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c | |||
@@ -381,10 +381,10 @@ static void queue_io(struct bdi_writeback *wb, unsigned long *older_than_this) | |||
381 | move_expired_inodes(&wb->b_dirty, &wb->b_io, older_than_this); | 381 | move_expired_inodes(&wb->b_dirty, &wb->b_io, older_than_this); |
382 | } | 382 | } |
383 | 383 | ||
384 | static int write_inode(struct inode *inode, int sync) | 384 | static int write_inode(struct inode *inode, struct writeback_control *wbc) |
385 | { | 385 | { |
386 | if (inode->i_sb->s_op->write_inode && !is_bad_inode(inode)) | 386 | if (inode->i_sb->s_op->write_inode && !is_bad_inode(inode)) |
387 | return inode->i_sb->s_op->write_inode(inode, sync); | 387 | return inode->i_sb->s_op->write_inode(inode, wbc); |
388 | return 0; | 388 | return 0; |
389 | } | 389 | } |
390 | 390 | ||
@@ -421,7 +421,6 @@ static int | |||
421 | writeback_single_inode(struct inode *inode, struct writeback_control *wbc) | 421 | writeback_single_inode(struct inode *inode, struct writeback_control *wbc) |
422 | { | 422 | { |
423 | struct address_space *mapping = inode->i_mapping; | 423 | struct address_space *mapping = inode->i_mapping; |
424 | int wait = wbc->sync_mode == WB_SYNC_ALL; | ||
425 | unsigned dirty; | 424 | unsigned dirty; |
426 | int ret; | 425 | int ret; |
427 | 426 | ||
@@ -439,7 +438,7 @@ writeback_single_inode(struct inode *inode, struct writeback_control *wbc) | |||
439 | * We'll have another go at writing back this inode when we | 438 | * We'll have another go at writing back this inode when we |
440 | * completed a full scan of b_io. | 439 | * completed a full scan of b_io. |
441 | */ | 440 | */ |
442 | if (!wait) { | 441 | if (wbc->sync_mode != WB_SYNC_ALL) { |
443 | requeue_io(inode); | 442 | requeue_io(inode); |
444 | return 0; | 443 | return 0; |
445 | } | 444 | } |
@@ -461,15 +460,20 @@ writeback_single_inode(struct inode *inode, struct writeback_control *wbc) | |||
461 | 460 | ||
462 | ret = do_writepages(mapping, wbc); | 461 | ret = do_writepages(mapping, wbc); |
463 | 462 | ||
464 | /* Don't write the inode if only I_DIRTY_PAGES was set */ | 463 | /* |
465 | if (dirty & (I_DIRTY_SYNC | I_DIRTY_DATASYNC)) { | 464 | * Make sure to wait on the data before writing out the metadata. |
466 | int err = write_inode(inode, wait); | 465 | * This is important for filesystems that modify metadata on data |
466 | * I/O completion. | ||
467 | */ | ||
468 | if (wbc->sync_mode == WB_SYNC_ALL) { | ||
469 | int err = filemap_fdatawait(mapping); | ||
467 | if (ret == 0) | 470 | if (ret == 0) |
468 | ret = err; | 471 | ret = err; |
469 | } | 472 | } |
470 | 473 | ||
471 | if (wait) { | 474 | /* Don't write the inode if only I_DIRTY_PAGES was set */ |
472 | int err = filemap_fdatawait(mapping); | 475 | if (dirty & (I_DIRTY_SYNC | I_DIRTY_DATASYNC)) { |
476 | int err = write_inode(inode, wbc); | ||
473 | if (ret == 0) | 477 | if (ret == 0) |
474 | ret = err; | 478 | ret = err; |
475 | } | 479 | } |
diff --git a/fs/fscache/Kconfig b/fs/fscache/Kconfig index 864dac20a242..cc94bb9563f2 100644 --- a/fs/fscache/Kconfig +++ b/fs/fscache/Kconfig | |||
@@ -1,7 +1,6 @@ | |||
1 | 1 | ||
2 | config FSCACHE | 2 | config FSCACHE |
3 | tristate "General filesystem local caching manager" | 3 | tristate "General filesystem local caching manager" |
4 | depends on EXPERIMENTAL | ||
5 | select SLOW_WORK | 4 | select SLOW_WORK |
6 | help | 5 | help |
7 | This option enables a generic filesystem caching manager that can be | 6 | This option enables a generic filesystem caching manager that can be |
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 51d9e33d634f..eb7e9423691f 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c | |||
@@ -865,13 +865,10 @@ static int fuse_notify_inval_inode(struct fuse_conn *fc, unsigned int size, | |||
865 | 865 | ||
866 | down_read(&fc->killsb); | 866 | down_read(&fc->killsb); |
867 | err = -ENOENT; | 867 | err = -ENOENT; |
868 | if (!fc->sb) | 868 | if (fc->sb) { |
869 | goto err_unlock; | 869 | err = fuse_reverse_inval_inode(fc->sb, outarg.ino, |
870 | 870 | outarg.off, outarg.len); | |
871 | err = fuse_reverse_inval_inode(fc->sb, outarg.ino, | 871 | } |
872 | outarg.off, outarg.len); | ||
873 | |||
874 | err_unlock: | ||
875 | up_read(&fc->killsb); | 872 | up_read(&fc->killsb); |
876 | return err; | 873 | return err; |
877 | 874 | ||
@@ -884,10 +881,15 @@ static int fuse_notify_inval_entry(struct fuse_conn *fc, unsigned int size, | |||
884 | struct fuse_copy_state *cs) | 881 | struct fuse_copy_state *cs) |
885 | { | 882 | { |
886 | struct fuse_notify_inval_entry_out outarg; | 883 | struct fuse_notify_inval_entry_out outarg; |
887 | int err = -EINVAL; | 884 | int err = -ENOMEM; |
888 | char buf[FUSE_NAME_MAX+1]; | 885 | char *buf; |
889 | struct qstr name; | 886 | struct qstr name; |
890 | 887 | ||
888 | buf = kzalloc(FUSE_NAME_MAX + 1, GFP_KERNEL); | ||
889 | if (!buf) | ||
890 | goto err; | ||
891 | |||
892 | err = -EINVAL; | ||
891 | if (size < sizeof(outarg)) | 893 | if (size < sizeof(outarg)) |
892 | goto err; | 894 | goto err; |
893 | 895 | ||
@@ -910,16 +912,14 @@ static int fuse_notify_inval_entry(struct fuse_conn *fc, unsigned int size, | |||
910 | 912 | ||
911 | down_read(&fc->killsb); | 913 | down_read(&fc->killsb); |
912 | err = -ENOENT; | 914 | err = -ENOENT; |
913 | if (!fc->sb) | 915 | if (fc->sb) |
914 | goto err_unlock; | 916 | err = fuse_reverse_inval_entry(fc->sb, outarg.parent, &name); |
915 | |||
916 | err = fuse_reverse_inval_entry(fc->sb, outarg.parent, &name); | ||
917 | |||
918 | err_unlock: | ||
919 | up_read(&fc->killsb); | 917 | up_read(&fc->killsb); |
918 | kfree(buf); | ||
920 | return err; | 919 | return err; |
921 | 920 | ||
922 | err: | 921 | err: |
922 | kfree(buf); | ||
923 | fuse_copy_finish(cs); | 923 | fuse_copy_finish(cs); |
924 | return err; | 924 | return err; |
925 | } | 925 | } |
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index 7b8da9415267..0c1d0b82dcf1 100644 --- a/fs/gfs2/aops.c +++ b/fs/gfs2/aops.c | |||
@@ -1061,8 +1061,8 @@ out: | |||
1061 | 1061 | ||
1062 | int gfs2_releasepage(struct page *page, gfp_t gfp_mask) | 1062 | int gfs2_releasepage(struct page *page, gfp_t gfp_mask) |
1063 | { | 1063 | { |
1064 | struct inode *aspace = page->mapping->host; | 1064 | struct address_space *mapping = page->mapping; |
1065 | struct gfs2_sbd *sdp = aspace->i_sb->s_fs_info; | 1065 | struct gfs2_sbd *sdp = gfs2_mapping2sbd(mapping); |
1066 | struct buffer_head *bh, *head; | 1066 | struct buffer_head *bh, *head; |
1067 | struct gfs2_bufdata *bd; | 1067 | struct gfs2_bufdata *bd; |
1068 | 1068 | ||
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index f42663325931..454d4b4eb36b 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c | |||
@@ -19,7 +19,6 @@ | |||
19 | #include <linux/list.h> | 19 | #include <linux/list.h> |
20 | #include <linux/wait.h> | 20 | #include <linux/wait.h> |
21 | #include <linux/module.h> | 21 | #include <linux/module.h> |
22 | #include <linux/rwsem.h> | ||
23 | #include <asm/uaccess.h> | 22 | #include <asm/uaccess.h> |
24 | #include <linux/seq_file.h> | 23 | #include <linux/seq_file.h> |
25 | #include <linux/debugfs.h> | 24 | #include <linux/debugfs.h> |
@@ -60,7 +59,6 @@ static int __dump_glock(struct seq_file *seq, const struct gfs2_glock *gl); | |||
60 | #define GLOCK_BUG_ON(gl,x) do { if (unlikely(x)) { __dump_glock(NULL, gl); BUG(); } } while(0) | 59 | #define GLOCK_BUG_ON(gl,x) do { if (unlikely(x)) { __dump_glock(NULL, gl); BUG(); } } while(0) |
61 | static void do_xmote(struct gfs2_glock *gl, struct gfs2_holder *gh, unsigned int target); | 60 | static void do_xmote(struct gfs2_glock *gl, struct gfs2_holder *gh, unsigned int target); |
62 | 61 | ||
63 | static DECLARE_RWSEM(gfs2_umount_flush_sem); | ||
64 | static struct dentry *gfs2_root; | 62 | static struct dentry *gfs2_root; |
65 | static struct workqueue_struct *glock_workqueue; | 63 | static struct workqueue_struct *glock_workqueue; |
66 | struct workqueue_struct *gfs2_delete_workqueue; | 64 | struct workqueue_struct *gfs2_delete_workqueue; |
@@ -154,12 +152,14 @@ static unsigned int gl_hash(const struct gfs2_sbd *sdp, | |||
154 | static void glock_free(struct gfs2_glock *gl) | 152 | static void glock_free(struct gfs2_glock *gl) |
155 | { | 153 | { |
156 | struct gfs2_sbd *sdp = gl->gl_sbd; | 154 | struct gfs2_sbd *sdp = gl->gl_sbd; |
157 | struct inode *aspace = gl->gl_aspace; | 155 | struct address_space *mapping = gfs2_glock2aspace(gl); |
156 | struct kmem_cache *cachep = gfs2_glock_cachep; | ||
158 | 157 | ||
159 | if (aspace) | 158 | GLOCK_BUG_ON(gl, mapping && mapping->nrpages); |
160 | gfs2_aspace_put(aspace); | ||
161 | trace_gfs2_glock_put(gl); | 159 | trace_gfs2_glock_put(gl); |
162 | sdp->sd_lockstruct.ls_ops->lm_put_lock(gfs2_glock_cachep, gl); | 160 | if (mapping) |
161 | cachep = gfs2_glock_aspace_cachep; | ||
162 | sdp->sd_lockstruct.ls_ops->lm_put_lock(cachep, gl); | ||
163 | } | 163 | } |
164 | 164 | ||
165 | /** | 165 | /** |
@@ -712,7 +712,6 @@ static void glock_work_func(struct work_struct *work) | |||
712 | finish_xmote(gl, gl->gl_reply); | 712 | finish_xmote(gl, gl->gl_reply); |
713 | drop_ref = 1; | 713 | drop_ref = 1; |
714 | } | 714 | } |
715 | down_read(&gfs2_umount_flush_sem); | ||
716 | spin_lock(&gl->gl_spin); | 715 | spin_lock(&gl->gl_spin); |
717 | if (test_and_clear_bit(GLF_PENDING_DEMOTE, &gl->gl_flags) && | 716 | if (test_and_clear_bit(GLF_PENDING_DEMOTE, &gl->gl_flags) && |
718 | gl->gl_state != LM_ST_UNLOCKED && | 717 | gl->gl_state != LM_ST_UNLOCKED && |
@@ -725,7 +724,6 @@ static void glock_work_func(struct work_struct *work) | |||
725 | } | 724 | } |
726 | run_queue(gl, 0); | 725 | run_queue(gl, 0); |
727 | spin_unlock(&gl->gl_spin); | 726 | spin_unlock(&gl->gl_spin); |
728 | up_read(&gfs2_umount_flush_sem); | ||
729 | if (!delay || | 727 | if (!delay || |
730 | queue_delayed_work(glock_workqueue, &gl->gl_work, delay) == 0) | 728 | queue_delayed_work(glock_workqueue, &gl->gl_work, delay) == 0) |
731 | gfs2_glock_put(gl); | 729 | gfs2_glock_put(gl); |
@@ -750,10 +748,11 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, | |||
750 | const struct gfs2_glock_operations *glops, int create, | 748 | const struct gfs2_glock_operations *glops, int create, |
751 | struct gfs2_glock **glp) | 749 | struct gfs2_glock **glp) |
752 | { | 750 | { |
751 | struct super_block *s = sdp->sd_vfs; | ||
753 | struct lm_lockname name = { .ln_number = number, .ln_type = glops->go_type }; | 752 | struct lm_lockname name = { .ln_number = number, .ln_type = glops->go_type }; |
754 | struct gfs2_glock *gl, *tmp; | 753 | struct gfs2_glock *gl, *tmp; |
755 | unsigned int hash = gl_hash(sdp, &name); | 754 | unsigned int hash = gl_hash(sdp, &name); |
756 | int error; | 755 | struct address_space *mapping; |
757 | 756 | ||
758 | read_lock(gl_lock_addr(hash)); | 757 | read_lock(gl_lock_addr(hash)); |
759 | gl = search_bucket(hash, sdp, &name); | 758 | gl = search_bucket(hash, sdp, &name); |
@@ -765,7 +764,10 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, | |||
765 | if (!create) | 764 | if (!create) |
766 | return -ENOENT; | 765 | return -ENOENT; |
767 | 766 | ||
768 | gl = kmem_cache_alloc(gfs2_glock_cachep, GFP_KERNEL); | 767 | if (glops->go_flags & GLOF_ASPACE) |
768 | gl = kmem_cache_alloc(gfs2_glock_aspace_cachep, GFP_KERNEL); | ||
769 | else | ||
770 | gl = kmem_cache_alloc(gfs2_glock_cachep, GFP_KERNEL); | ||
769 | if (!gl) | 771 | if (!gl) |
770 | return -ENOMEM; | 772 | return -ENOMEM; |
771 | 773 | ||
@@ -784,18 +786,18 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, | |||
784 | gl->gl_tchange = jiffies; | 786 | gl->gl_tchange = jiffies; |
785 | gl->gl_object = NULL; | 787 | gl->gl_object = NULL; |
786 | gl->gl_sbd = sdp; | 788 | gl->gl_sbd = sdp; |
787 | gl->gl_aspace = NULL; | ||
788 | INIT_DELAYED_WORK(&gl->gl_work, glock_work_func); | 789 | INIT_DELAYED_WORK(&gl->gl_work, glock_work_func); |
789 | INIT_WORK(&gl->gl_delete, delete_work_func); | 790 | INIT_WORK(&gl->gl_delete, delete_work_func); |
790 | 791 | ||
791 | /* If this glock protects actual on-disk data or metadata blocks, | 792 | mapping = gfs2_glock2aspace(gl); |
792 | create a VFS inode to manage the pages/buffers holding them. */ | 793 | if (mapping) { |
793 | if (glops == &gfs2_inode_glops || glops == &gfs2_rgrp_glops) { | 794 | mapping->a_ops = &gfs2_meta_aops; |
794 | gl->gl_aspace = gfs2_aspace_get(sdp); | 795 | mapping->host = s->s_bdev->bd_inode; |
795 | if (!gl->gl_aspace) { | 796 | mapping->flags = 0; |
796 | error = -ENOMEM; | 797 | mapping_set_gfp_mask(mapping, GFP_NOFS); |
797 | goto fail; | 798 | mapping->assoc_mapping = NULL; |
798 | } | 799 | mapping->backing_dev_info = s->s_bdi; |
800 | mapping->writeback_index = 0; | ||
799 | } | 801 | } |
800 | 802 | ||
801 | write_lock(gl_lock_addr(hash)); | 803 | write_lock(gl_lock_addr(hash)); |
@@ -812,10 +814,6 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, | |||
812 | *glp = gl; | 814 | *glp = gl; |
813 | 815 | ||
814 | return 0; | 816 | return 0; |
815 | |||
816 | fail: | ||
817 | kmem_cache_free(gfs2_glock_cachep, gl); | ||
818 | return error; | ||
819 | } | 817 | } |
820 | 818 | ||
821 | /** | 819 | /** |
@@ -1510,35 +1508,10 @@ void gfs2_glock_thaw(struct gfs2_sbd *sdp) | |||
1510 | 1508 | ||
1511 | void gfs2_gl_hash_clear(struct gfs2_sbd *sdp) | 1509 | void gfs2_gl_hash_clear(struct gfs2_sbd *sdp) |
1512 | { | 1510 | { |
1513 | unsigned long t; | ||
1514 | unsigned int x; | 1511 | unsigned int x; |
1515 | int cont; | ||
1516 | 1512 | ||
1517 | t = jiffies; | 1513 | for (x = 0; x < GFS2_GL_HASH_SIZE; x++) |
1518 | 1514 | examine_bucket(clear_glock, sdp, x); | |
1519 | for (;;) { | ||
1520 | cont = 0; | ||
1521 | for (x = 0; x < GFS2_GL_HASH_SIZE; x++) { | ||
1522 | if (examine_bucket(clear_glock, sdp, x)) | ||
1523 | cont = 1; | ||
1524 | } | ||
1525 | |||
1526 | if (!cont) | ||
1527 | break; | ||
1528 | |||
1529 | if (time_after_eq(jiffies, | ||
1530 | t + gfs2_tune_get(sdp, gt_stall_secs) * HZ)) { | ||
1531 | fs_warn(sdp, "Unmount seems to be stalled. " | ||
1532 | "Dumping lock state...\n"); | ||
1533 | gfs2_dump_lockstate(sdp); | ||
1534 | t = jiffies; | ||
1535 | } | ||
1536 | |||
1537 | down_write(&gfs2_umount_flush_sem); | ||
1538 | invalidate_inodes(sdp->sd_vfs); | ||
1539 | up_write(&gfs2_umount_flush_sem); | ||
1540 | msleep(10); | ||
1541 | } | ||
1542 | flush_workqueue(glock_workqueue); | 1515 | flush_workqueue(glock_workqueue); |
1543 | wait_event(sdp->sd_glock_wait, atomic_read(&sdp->sd_glock_disposal) == 0); | 1516 | wait_event(sdp->sd_glock_wait, atomic_read(&sdp->sd_glock_disposal) == 0); |
1544 | gfs2_dump_lockstate(sdp); | 1517 | gfs2_dump_lockstate(sdp); |
@@ -1685,7 +1658,7 @@ static int __dump_glock(struct seq_file *seq, const struct gfs2_glock *gl) | |||
1685 | dtime *= 1000000/HZ; /* demote time in uSec */ | 1658 | dtime *= 1000000/HZ; /* demote time in uSec */ |
1686 | if (!test_bit(GLF_DEMOTE, &gl->gl_flags)) | 1659 | if (!test_bit(GLF_DEMOTE, &gl->gl_flags)) |
1687 | dtime = 0; | 1660 | dtime = 0; |
1688 | gfs2_print_dbg(seq, "G: s:%s n:%u/%llu f:%s t:%s d:%s/%llu a:%d r:%d\n", | 1661 | gfs2_print_dbg(seq, "G: s:%s n:%u/%llx f:%s t:%s d:%s/%llu a:%d r:%d\n", |
1689 | state2str(gl->gl_state), | 1662 | state2str(gl->gl_state), |
1690 | gl->gl_name.ln_type, | 1663 | gl->gl_name.ln_type, |
1691 | (unsigned long long)gl->gl_name.ln_number, | 1664 | (unsigned long long)gl->gl_name.ln_number, |
diff --git a/fs/gfs2/glock.h b/fs/gfs2/glock.h index c0262faf4725..2bda1911b156 100644 --- a/fs/gfs2/glock.h +++ b/fs/gfs2/glock.h | |||
@@ -180,6 +180,13 @@ static inline int gfs2_glock_is_held_shrd(struct gfs2_glock *gl) | |||
180 | return gl->gl_state == LM_ST_SHARED; | 180 | return gl->gl_state == LM_ST_SHARED; |
181 | } | 181 | } |
182 | 182 | ||
183 | static inline struct address_space *gfs2_glock2aspace(struct gfs2_glock *gl) | ||
184 | { | ||
185 | if (gl->gl_ops->go_flags & GLOF_ASPACE) | ||
186 | return (struct address_space *)(gl + 1); | ||
187 | return NULL; | ||
188 | } | ||
189 | |||
183 | int gfs2_glock_get(struct gfs2_sbd *sdp, | 190 | int gfs2_glock_get(struct gfs2_sbd *sdp, |
184 | u64 number, const struct gfs2_glock_operations *glops, | 191 | u64 number, const struct gfs2_glock_operations *glops, |
185 | int create, struct gfs2_glock **glp); | 192 | int create, struct gfs2_glock **glp); |
diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index 78554acc0605..38e3749d476c 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2/glops.c | |||
@@ -87,7 +87,7 @@ static void gfs2_ail_empty_gl(struct gfs2_glock *gl) | |||
87 | 87 | ||
88 | static void rgrp_go_sync(struct gfs2_glock *gl) | 88 | static void rgrp_go_sync(struct gfs2_glock *gl) |
89 | { | 89 | { |
90 | struct address_space *metamapping = gl->gl_aspace->i_mapping; | 90 | struct address_space *metamapping = gfs2_glock2aspace(gl); |
91 | int error; | 91 | int error; |
92 | 92 | ||
93 | if (!test_and_clear_bit(GLF_DIRTY, &gl->gl_flags)) | 93 | if (!test_and_clear_bit(GLF_DIRTY, &gl->gl_flags)) |
@@ -113,7 +113,7 @@ static void rgrp_go_sync(struct gfs2_glock *gl) | |||
113 | 113 | ||
114 | static void rgrp_go_inval(struct gfs2_glock *gl, int flags) | 114 | static void rgrp_go_inval(struct gfs2_glock *gl, int flags) |
115 | { | 115 | { |
116 | struct address_space *mapping = gl->gl_aspace->i_mapping; | 116 | struct address_space *mapping = gfs2_glock2aspace(gl); |
117 | 117 | ||
118 | BUG_ON(!(flags & DIO_METADATA)); | 118 | BUG_ON(!(flags & DIO_METADATA)); |
119 | gfs2_assert_withdraw(gl->gl_sbd, !atomic_read(&gl->gl_ail_count)); | 119 | gfs2_assert_withdraw(gl->gl_sbd, !atomic_read(&gl->gl_ail_count)); |
@@ -134,7 +134,7 @@ static void rgrp_go_inval(struct gfs2_glock *gl, int flags) | |||
134 | static void inode_go_sync(struct gfs2_glock *gl) | 134 | static void inode_go_sync(struct gfs2_glock *gl) |
135 | { | 135 | { |
136 | struct gfs2_inode *ip = gl->gl_object; | 136 | struct gfs2_inode *ip = gl->gl_object; |
137 | struct address_space *metamapping = gl->gl_aspace->i_mapping; | 137 | struct address_space *metamapping = gfs2_glock2aspace(gl); |
138 | int error; | 138 | int error; |
139 | 139 | ||
140 | if (ip && !S_ISREG(ip->i_inode.i_mode)) | 140 | if (ip && !S_ISREG(ip->i_inode.i_mode)) |
@@ -183,7 +183,7 @@ static void inode_go_inval(struct gfs2_glock *gl, int flags) | |||
183 | gfs2_assert_withdraw(gl->gl_sbd, !atomic_read(&gl->gl_ail_count)); | 183 | gfs2_assert_withdraw(gl->gl_sbd, !atomic_read(&gl->gl_ail_count)); |
184 | 184 | ||
185 | if (flags & DIO_METADATA) { | 185 | if (flags & DIO_METADATA) { |
186 | struct address_space *mapping = gl->gl_aspace->i_mapping; | 186 | struct address_space *mapping = gfs2_glock2aspace(gl); |
187 | truncate_inode_pages(mapping, 0); | 187 | truncate_inode_pages(mapping, 0); |
188 | if (ip) { | 188 | if (ip) { |
189 | set_bit(GIF_INVALID, &ip->i_flags); | 189 | set_bit(GIF_INVALID, &ip->i_flags); |
@@ -282,7 +282,8 @@ static int inode_go_dump(struct seq_file *seq, const struct gfs2_glock *gl) | |||
282 | 282 | ||
283 | static int rgrp_go_demote_ok(const struct gfs2_glock *gl) | 283 | static int rgrp_go_demote_ok(const struct gfs2_glock *gl) |
284 | { | 284 | { |
285 | return !gl->gl_aspace->i_mapping->nrpages; | 285 | const struct address_space *mapping = (const struct address_space *)(gl + 1); |
286 | return !mapping->nrpages; | ||
286 | } | 287 | } |
287 | 288 | ||
288 | /** | 289 | /** |
@@ -387,8 +388,7 @@ static void iopen_go_callback(struct gfs2_glock *gl) | |||
387 | struct gfs2_inode *ip = (struct gfs2_inode *)gl->gl_object; | 388 | struct gfs2_inode *ip = (struct gfs2_inode *)gl->gl_object; |
388 | 389 | ||
389 | if (gl->gl_demote_state == LM_ST_UNLOCKED && | 390 | if (gl->gl_demote_state == LM_ST_UNLOCKED && |
390 | gl->gl_state == LM_ST_SHARED && | 391 | gl->gl_state == LM_ST_SHARED && ip) { |
391 | ip && test_bit(GIF_USER, &ip->i_flags)) { | ||
392 | gfs2_glock_hold(gl); | 392 | gfs2_glock_hold(gl); |
393 | if (queue_work(gfs2_delete_workqueue, &gl->gl_delete) == 0) | 393 | if (queue_work(gfs2_delete_workqueue, &gl->gl_delete) == 0) |
394 | gfs2_glock_put_nolock(gl); | 394 | gfs2_glock_put_nolock(gl); |
@@ -407,6 +407,7 @@ const struct gfs2_glock_operations gfs2_inode_glops = { | |||
407 | .go_dump = inode_go_dump, | 407 | .go_dump = inode_go_dump, |
408 | .go_type = LM_TYPE_INODE, | 408 | .go_type = LM_TYPE_INODE, |
409 | .go_min_hold_time = HZ / 5, | 409 | .go_min_hold_time = HZ / 5, |
410 | .go_flags = GLOF_ASPACE, | ||
410 | }; | 411 | }; |
411 | 412 | ||
412 | const struct gfs2_glock_operations gfs2_rgrp_glops = { | 413 | const struct gfs2_glock_operations gfs2_rgrp_glops = { |
@@ -418,6 +419,7 @@ const struct gfs2_glock_operations gfs2_rgrp_glops = { | |||
418 | .go_dump = gfs2_rgrp_dump, | 419 | .go_dump = gfs2_rgrp_dump, |
419 | .go_type = LM_TYPE_RGRP, | 420 | .go_type = LM_TYPE_RGRP, |
420 | .go_min_hold_time = HZ / 5, | 421 | .go_min_hold_time = HZ / 5, |
422 | .go_flags = GLOF_ASPACE, | ||
421 | }; | 423 | }; |
422 | 424 | ||
423 | const struct gfs2_glock_operations gfs2_trans_glops = { | 425 | const struct gfs2_glock_operations gfs2_trans_glops = { |
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h index bc0ad158e6b4..b8025e51cabf 100644 --- a/fs/gfs2/incore.h +++ b/fs/gfs2/incore.h | |||
@@ -162,6 +162,8 @@ struct gfs2_glock_operations { | |||
162 | void (*go_callback) (struct gfs2_glock *gl); | 162 | void (*go_callback) (struct gfs2_glock *gl); |
163 | const int go_type; | 163 | const int go_type; |
164 | const unsigned long go_min_hold_time; | 164 | const unsigned long go_min_hold_time; |
165 | const unsigned long go_flags; | ||
166 | #define GLOF_ASPACE 1 | ||
165 | }; | 167 | }; |
166 | 168 | ||
167 | enum { | 169 | enum { |
@@ -225,7 +227,6 @@ struct gfs2_glock { | |||
225 | 227 | ||
226 | struct gfs2_sbd *gl_sbd; | 228 | struct gfs2_sbd *gl_sbd; |
227 | 229 | ||
228 | struct inode *gl_aspace; | ||
229 | struct list_head gl_ail_list; | 230 | struct list_head gl_ail_list; |
230 | atomic_t gl_ail_count; | 231 | atomic_t gl_ail_count; |
231 | struct delayed_work gl_work; | 232 | struct delayed_work gl_work; |
@@ -258,7 +259,6 @@ enum { | |||
258 | GIF_INVALID = 0, | 259 | GIF_INVALID = 0, |
259 | GIF_QD_LOCKED = 1, | 260 | GIF_QD_LOCKED = 1, |
260 | GIF_SW_PAGED = 3, | 261 | GIF_SW_PAGED = 3, |
261 | GIF_USER = 4, /* user inode, not metadata addr space */ | ||
262 | }; | 262 | }; |
263 | 263 | ||
264 | 264 | ||
@@ -451,7 +451,6 @@ struct gfs2_tune { | |||
451 | unsigned int gt_quota_quantum; /* Secs between syncs to quota file */ | 451 | unsigned int gt_quota_quantum; /* Secs between syncs to quota file */ |
452 | unsigned int gt_new_files_jdata; | 452 | unsigned int gt_new_files_jdata; |
453 | unsigned int gt_max_readahead; /* Max bytes to read-ahead from disk */ | 453 | unsigned int gt_max_readahead; /* Max bytes to read-ahead from disk */ |
454 | unsigned int gt_stall_secs; /* Detects trouble! */ | ||
455 | unsigned int gt_complain_secs; | 454 | unsigned int gt_complain_secs; |
456 | unsigned int gt_statfs_quantum; | 455 | unsigned int gt_statfs_quantum; |
457 | unsigned int gt_statfs_slow; | 456 | unsigned int gt_statfs_slow; |
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 6e220f4eee7d..b1bf2694fb2b 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c | |||
@@ -45,7 +45,7 @@ static int iget_test(struct inode *inode, void *opaque) | |||
45 | struct gfs2_inode *ip = GFS2_I(inode); | 45 | struct gfs2_inode *ip = GFS2_I(inode); |
46 | u64 *no_addr = opaque; | 46 | u64 *no_addr = opaque; |
47 | 47 | ||
48 | if (ip->i_no_addr == *no_addr && test_bit(GIF_USER, &ip->i_flags)) | 48 | if (ip->i_no_addr == *no_addr) |
49 | return 1; | 49 | return 1; |
50 | 50 | ||
51 | return 0; | 51 | return 0; |
@@ -58,7 +58,6 @@ static int iget_set(struct inode *inode, void *opaque) | |||
58 | 58 | ||
59 | inode->i_ino = (unsigned long)*no_addr; | 59 | inode->i_ino = (unsigned long)*no_addr; |
60 | ip->i_no_addr = *no_addr; | 60 | ip->i_no_addr = *no_addr; |
61 | set_bit(GIF_USER, &ip->i_flags); | ||
62 | return 0; | 61 | return 0; |
63 | } | 62 | } |
64 | 63 | ||
@@ -84,7 +83,7 @@ static int iget_skip_test(struct inode *inode, void *opaque) | |||
84 | struct gfs2_inode *ip = GFS2_I(inode); | 83 | struct gfs2_inode *ip = GFS2_I(inode); |
85 | struct gfs2_skip_data *data = opaque; | 84 | struct gfs2_skip_data *data = opaque; |
86 | 85 | ||
87 | if (ip->i_no_addr == data->no_addr && test_bit(GIF_USER, &ip->i_flags)){ | 86 | if (ip->i_no_addr == data->no_addr) { |
88 | if (inode->i_state & (I_FREEING|I_CLEAR|I_WILL_FREE)){ | 87 | if (inode->i_state & (I_FREEING|I_CLEAR|I_WILL_FREE)){ |
89 | data->skipped = 1; | 88 | data->skipped = 1; |
90 | return 0; | 89 | return 0; |
@@ -103,7 +102,6 @@ static int iget_skip_set(struct inode *inode, void *opaque) | |||
103 | return 1; | 102 | return 1; |
104 | inode->i_ino = (unsigned long)(data->no_addr); | 103 | inode->i_ino = (unsigned long)(data->no_addr); |
105 | ip->i_no_addr = data->no_addr; | 104 | ip->i_no_addr = data->no_addr; |
106 | set_bit(GIF_USER, &ip->i_flags); | ||
107 | return 0; | 105 | return 0; |
108 | } | 106 | } |
109 | 107 | ||
diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c index 0e5e0e7022e5..569b46240f61 100644 --- a/fs/gfs2/lock_dlm.c +++ b/fs/gfs2/lock_dlm.c | |||
@@ -30,7 +30,10 @@ static void gdlm_ast(void *arg) | |||
30 | 30 | ||
31 | switch (gl->gl_lksb.sb_status) { | 31 | switch (gl->gl_lksb.sb_status) { |
32 | case -DLM_EUNLOCK: /* Unlocked, so glock can be freed */ | 32 | case -DLM_EUNLOCK: /* Unlocked, so glock can be freed */ |
33 | kmem_cache_free(gfs2_glock_cachep, gl); | 33 | if (gl->gl_ops->go_flags & GLOF_ASPACE) |
34 | kmem_cache_free(gfs2_glock_aspace_cachep, gl); | ||
35 | else | ||
36 | kmem_cache_free(gfs2_glock_cachep, gl); | ||
34 | if (atomic_dec_and_test(&sdp->sd_glock_disposal)) | 37 | if (atomic_dec_and_test(&sdp->sd_glock_disposal)) |
35 | wake_up(&sdp->sd_glock_wait); | 38 | wake_up(&sdp->sd_glock_wait); |
36 | return; | 39 | return; |
diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c index de97632ba32f..adc260fbea90 100644 --- a/fs/gfs2/lops.c +++ b/fs/gfs2/lops.c | |||
@@ -528,9 +528,9 @@ static void databuf_lo_add(struct gfs2_sbd *sdp, struct gfs2_log_element *le) | |||
528 | gfs2_pin(sdp, bd->bd_bh); | 528 | gfs2_pin(sdp, bd->bd_bh); |
529 | tr->tr_num_databuf_new++; | 529 | tr->tr_num_databuf_new++; |
530 | sdp->sd_log_num_databuf++; | 530 | sdp->sd_log_num_databuf++; |
531 | list_add(&le->le_list, &sdp->sd_log_le_databuf); | 531 | list_add_tail(&le->le_list, &sdp->sd_log_le_databuf); |
532 | } else { | 532 | } else { |
533 | list_add(&le->le_list, &sdp->sd_log_le_ordered); | 533 | list_add_tail(&le->le_list, &sdp->sd_log_le_ordered); |
534 | } | 534 | } |
535 | out: | 535 | out: |
536 | gfs2_log_unlock(sdp); | 536 | gfs2_log_unlock(sdp); |
diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c index 5b31f7741a8f..a88fadc704bb 100644 --- a/fs/gfs2/main.c +++ b/fs/gfs2/main.c | |||
@@ -52,6 +52,22 @@ static void gfs2_init_glock_once(void *foo) | |||
52 | atomic_set(&gl->gl_ail_count, 0); | 52 | atomic_set(&gl->gl_ail_count, 0); |
53 | } | 53 | } |
54 | 54 | ||
55 | static void gfs2_init_gl_aspace_once(void *foo) | ||
56 | { | ||
57 | struct gfs2_glock *gl = foo; | ||
58 | struct address_space *mapping = (struct address_space *)(gl + 1); | ||
59 | |||
60 | gfs2_init_glock_once(gl); | ||
61 | memset(mapping, 0, sizeof(*mapping)); | ||
62 | INIT_RADIX_TREE(&mapping->page_tree, GFP_ATOMIC); | ||
63 | spin_lock_init(&mapping->tree_lock); | ||
64 | spin_lock_init(&mapping->i_mmap_lock); | ||
65 | INIT_LIST_HEAD(&mapping->private_list); | ||
66 | spin_lock_init(&mapping->private_lock); | ||
67 | INIT_RAW_PRIO_TREE_ROOT(&mapping->i_mmap); | ||
68 | INIT_LIST_HEAD(&mapping->i_mmap_nonlinear); | ||
69 | } | ||
70 | |||
55 | /** | 71 | /** |
56 | * init_gfs2_fs - Register GFS2 as a filesystem | 72 | * init_gfs2_fs - Register GFS2 as a filesystem |
57 | * | 73 | * |
@@ -78,6 +94,14 @@ static int __init init_gfs2_fs(void) | |||
78 | if (!gfs2_glock_cachep) | 94 | if (!gfs2_glock_cachep) |
79 | goto fail; | 95 | goto fail; |
80 | 96 | ||
97 | gfs2_glock_aspace_cachep = kmem_cache_create("gfs2_glock (aspace)", | ||
98 | sizeof(struct gfs2_glock) + | ||
99 | sizeof(struct address_space), | ||
100 | 0, 0, gfs2_init_gl_aspace_once); | ||
101 | |||
102 | if (!gfs2_glock_aspace_cachep) | ||
103 | goto fail; | ||
104 | |||
81 | gfs2_inode_cachep = kmem_cache_create("gfs2_inode", | 105 | gfs2_inode_cachep = kmem_cache_create("gfs2_inode", |
82 | sizeof(struct gfs2_inode), | 106 | sizeof(struct gfs2_inode), |
83 | 0, SLAB_RECLAIM_ACCOUNT| | 107 | 0, SLAB_RECLAIM_ACCOUNT| |
@@ -144,6 +168,9 @@ fail: | |||
144 | if (gfs2_inode_cachep) | 168 | if (gfs2_inode_cachep) |
145 | kmem_cache_destroy(gfs2_inode_cachep); | 169 | kmem_cache_destroy(gfs2_inode_cachep); |
146 | 170 | ||
171 | if (gfs2_glock_aspace_cachep) | ||
172 | kmem_cache_destroy(gfs2_glock_aspace_cachep); | ||
173 | |||
147 | if (gfs2_glock_cachep) | 174 | if (gfs2_glock_cachep) |
148 | kmem_cache_destroy(gfs2_glock_cachep); | 175 | kmem_cache_destroy(gfs2_glock_cachep); |
149 | 176 | ||
@@ -169,6 +196,7 @@ static void __exit exit_gfs2_fs(void) | |||
169 | kmem_cache_destroy(gfs2_rgrpd_cachep); | 196 | kmem_cache_destroy(gfs2_rgrpd_cachep); |
170 | kmem_cache_destroy(gfs2_bufdata_cachep); | 197 | kmem_cache_destroy(gfs2_bufdata_cachep); |
171 | kmem_cache_destroy(gfs2_inode_cachep); | 198 | kmem_cache_destroy(gfs2_inode_cachep); |
199 | kmem_cache_destroy(gfs2_glock_aspace_cachep); | ||
172 | kmem_cache_destroy(gfs2_glock_cachep); | 200 | kmem_cache_destroy(gfs2_glock_cachep); |
173 | 201 | ||
174 | gfs2_sys_uninit(); | 202 | gfs2_sys_uninit(); |
diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c index 6f68a5f18eb8..0bb12c80937a 100644 --- a/fs/gfs2/meta_io.c +++ b/fs/gfs2/meta_io.c | |||
@@ -93,49 +93,13 @@ static int gfs2_aspace_writepage(struct page *page, struct writeback_control *wb | |||
93 | return err; | 93 | return err; |
94 | } | 94 | } |
95 | 95 | ||
96 | static const struct address_space_operations aspace_aops = { | 96 | const struct address_space_operations gfs2_meta_aops = { |
97 | .writepage = gfs2_aspace_writepage, | 97 | .writepage = gfs2_aspace_writepage, |
98 | .releasepage = gfs2_releasepage, | 98 | .releasepage = gfs2_releasepage, |
99 | .sync_page = block_sync_page, | 99 | .sync_page = block_sync_page, |
100 | }; | 100 | }; |
101 | 101 | ||
102 | /** | 102 | /** |
103 | * gfs2_aspace_get - Create and initialize a struct inode structure | ||
104 | * @sdp: the filesystem the aspace is in | ||
105 | * | ||
106 | * Right now a struct inode is just a struct inode. Maybe Linux | ||
107 | * will supply a more lightweight address space construct (that works) | ||
108 | * in the future. | ||
109 | * | ||
110 | * Make sure pages/buffers in this aspace aren't in high memory. | ||
111 | * | ||
112 | * Returns: the aspace | ||
113 | */ | ||
114 | |||
115 | struct inode *gfs2_aspace_get(struct gfs2_sbd *sdp) | ||
116 | { | ||
117 | struct inode *aspace; | ||
118 | struct gfs2_inode *ip; | ||
119 | |||
120 | aspace = new_inode(sdp->sd_vfs); | ||
121 | if (aspace) { | ||
122 | mapping_set_gfp_mask(aspace->i_mapping, GFP_NOFS); | ||
123 | aspace->i_mapping->a_ops = &aspace_aops; | ||
124 | aspace->i_size = MAX_LFS_FILESIZE; | ||
125 | ip = GFS2_I(aspace); | ||
126 | clear_bit(GIF_USER, &ip->i_flags); | ||
127 | insert_inode_hash(aspace); | ||
128 | } | ||
129 | return aspace; | ||
130 | } | ||
131 | |||
132 | void gfs2_aspace_put(struct inode *aspace) | ||
133 | { | ||
134 | remove_inode_hash(aspace); | ||
135 | iput(aspace); | ||
136 | } | ||
137 | |||
138 | /** | ||
139 | * gfs2_meta_sync - Sync all buffers associated with a glock | 103 | * gfs2_meta_sync - Sync all buffers associated with a glock |
140 | * @gl: The glock | 104 | * @gl: The glock |
141 | * | 105 | * |
@@ -143,7 +107,7 @@ void gfs2_aspace_put(struct inode *aspace) | |||
143 | 107 | ||
144 | void gfs2_meta_sync(struct gfs2_glock *gl) | 108 | void gfs2_meta_sync(struct gfs2_glock *gl) |
145 | { | 109 | { |
146 | struct address_space *mapping = gl->gl_aspace->i_mapping; | 110 | struct address_space *mapping = gfs2_glock2aspace(gl); |
147 | int error; | 111 | int error; |
148 | 112 | ||
149 | filemap_fdatawrite(mapping); | 113 | filemap_fdatawrite(mapping); |
@@ -164,7 +128,7 @@ void gfs2_meta_sync(struct gfs2_glock *gl) | |||
164 | 128 | ||
165 | struct buffer_head *gfs2_getbuf(struct gfs2_glock *gl, u64 blkno, int create) | 129 | struct buffer_head *gfs2_getbuf(struct gfs2_glock *gl, u64 blkno, int create) |
166 | { | 130 | { |
167 | struct address_space *mapping = gl->gl_aspace->i_mapping; | 131 | struct address_space *mapping = gfs2_glock2aspace(gl); |
168 | struct gfs2_sbd *sdp = gl->gl_sbd; | 132 | struct gfs2_sbd *sdp = gl->gl_sbd; |
169 | struct page *page; | 133 | struct page *page; |
170 | struct buffer_head *bh; | 134 | struct buffer_head *bh; |
@@ -344,8 +308,10 @@ void gfs2_attach_bufdata(struct gfs2_glock *gl, struct buffer_head *bh, | |||
344 | 308 | ||
345 | void gfs2_remove_from_journal(struct buffer_head *bh, struct gfs2_trans *tr, int meta) | 309 | void gfs2_remove_from_journal(struct buffer_head *bh, struct gfs2_trans *tr, int meta) |
346 | { | 310 | { |
347 | struct gfs2_sbd *sdp = GFS2_SB(bh->b_page->mapping->host); | 311 | struct address_space *mapping = bh->b_page->mapping; |
312 | struct gfs2_sbd *sdp = gfs2_mapping2sbd(mapping); | ||
348 | struct gfs2_bufdata *bd = bh->b_private; | 313 | struct gfs2_bufdata *bd = bh->b_private; |
314 | |||
349 | if (test_clear_buffer_pinned(bh)) { | 315 | if (test_clear_buffer_pinned(bh)) { |
350 | list_del_init(&bd->bd_le.le_list); | 316 | list_del_init(&bd->bd_le.le_list); |
351 | if (meta) { | 317 | if (meta) { |
diff --git a/fs/gfs2/meta_io.h b/fs/gfs2/meta_io.h index de270c2f9b63..6a1d9ba16411 100644 --- a/fs/gfs2/meta_io.h +++ b/fs/gfs2/meta_io.h | |||
@@ -37,8 +37,16 @@ static inline void gfs2_buffer_copy_tail(struct buffer_head *to_bh, | |||
37 | 0, from_head - to_head); | 37 | 0, from_head - to_head); |
38 | } | 38 | } |
39 | 39 | ||
40 | struct inode *gfs2_aspace_get(struct gfs2_sbd *sdp); | 40 | extern const struct address_space_operations gfs2_meta_aops; |
41 | void gfs2_aspace_put(struct inode *aspace); | 41 | |
42 | static inline struct gfs2_sbd *gfs2_mapping2sbd(struct address_space *mapping) | ||
43 | { | ||
44 | struct inode *inode = mapping->host; | ||
45 | if (mapping->a_ops == &gfs2_meta_aops) | ||
46 | return (((struct gfs2_glock *)mapping) - 1)->gl_sbd; | ||
47 | else | ||
48 | return inode->i_sb->s_fs_info; | ||
49 | } | ||
42 | 50 | ||
43 | void gfs2_meta_sync(struct gfs2_glock *gl); | 51 | void gfs2_meta_sync(struct gfs2_glock *gl); |
44 | 52 | ||
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index a86ed6381566..a054b526dc08 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c | |||
@@ -65,7 +65,6 @@ static void gfs2_tune_init(struct gfs2_tune *gt) | |||
65 | gt->gt_quota_scale_den = 1; | 65 | gt->gt_quota_scale_den = 1; |
66 | gt->gt_new_files_jdata = 0; | 66 | gt->gt_new_files_jdata = 0; |
67 | gt->gt_max_readahead = 1 << 18; | 67 | gt->gt_max_readahead = 1 << 18; |
68 | gt->gt_stall_secs = 600; | ||
69 | gt->gt_complain_secs = 10; | 68 | gt->gt_complain_secs = 10; |
70 | } | 69 | } |
71 | 70 | ||
@@ -1241,10 +1240,9 @@ fail_sb: | |||
1241 | fail_locking: | 1240 | fail_locking: |
1242 | init_locking(sdp, &mount_gh, UNDO); | 1241 | init_locking(sdp, &mount_gh, UNDO); |
1243 | fail_lm: | 1242 | fail_lm: |
1243 | invalidate_inodes(sb); | ||
1244 | gfs2_gl_hash_clear(sdp); | 1244 | gfs2_gl_hash_clear(sdp); |
1245 | gfs2_lm_unmount(sdp); | 1245 | gfs2_lm_unmount(sdp); |
1246 | while (invalidate_inodes(sb)) | ||
1247 | yield(); | ||
1248 | fail_sys: | 1246 | fail_sys: |
1249 | gfs2_sys_fs_del(sdp); | 1247 | gfs2_sys_fs_del(sdp); |
1250 | fail: | 1248 | fail: |
diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c index 84350e1be66d..4e64352d49de 100644 --- a/fs/gfs2/ops_inode.c +++ b/fs/gfs2/ops_inode.c | |||
@@ -976,122 +976,62 @@ out: | |||
976 | } | 976 | } |
977 | 977 | ||
978 | /** | 978 | /** |
979 | * gfs2_readlinki - return the contents of a symlink | 979 | * gfs2_follow_link - Follow a symbolic link |
980 | * @ip: the symlink's inode | 980 | * @dentry: The dentry of the link |
981 | * @buf: a pointer to the buffer to be filled | 981 | * @nd: Data that we pass to vfs_follow_link() |
982 | * @len: a pointer to the length of @buf | ||
983 | * | 982 | * |
984 | * If @buf is too small, a piece of memory is kmalloc()ed and needs | 983 | * This can handle symlinks of any size. |
985 | * to be freed by the caller. | ||
986 | * | 984 | * |
987 | * Returns: errno | 985 | * Returns: 0 on success or error code |
988 | */ | 986 | */ |
989 | 987 | ||
990 | static int gfs2_readlinki(struct gfs2_inode *ip, char **buf, unsigned int *len) | 988 | static void *gfs2_follow_link(struct dentry *dentry, struct nameidata *nd) |
991 | { | 989 | { |
990 | struct gfs2_inode *ip = GFS2_I(dentry->d_inode); | ||
992 | struct gfs2_holder i_gh; | 991 | struct gfs2_holder i_gh; |
993 | struct buffer_head *dibh; | 992 | struct buffer_head *dibh; |
994 | unsigned int x; | 993 | unsigned int x; |
994 | char *buf; | ||
995 | int error; | 995 | int error; |
996 | 996 | ||
997 | gfs2_holder_init(ip->i_gl, LM_ST_SHARED, 0, &i_gh); | 997 | gfs2_holder_init(ip->i_gl, LM_ST_SHARED, 0, &i_gh); |
998 | error = gfs2_glock_nq(&i_gh); | 998 | error = gfs2_glock_nq(&i_gh); |
999 | if (error) { | 999 | if (error) { |
1000 | gfs2_holder_uninit(&i_gh); | 1000 | gfs2_holder_uninit(&i_gh); |
1001 | return error; | 1001 | nd_set_link(nd, ERR_PTR(error)); |
1002 | return NULL; | ||
1002 | } | 1003 | } |
1003 | 1004 | ||
1004 | if (!ip->i_disksize) { | 1005 | if (!ip->i_disksize) { |
1005 | gfs2_consist_inode(ip); | 1006 | gfs2_consist_inode(ip); |
1006 | error = -EIO; | 1007 | buf = ERR_PTR(-EIO); |
1007 | goto out; | 1008 | goto out; |
1008 | } | 1009 | } |
1009 | 1010 | ||
1010 | error = gfs2_meta_inode_buffer(ip, &dibh); | 1011 | error = gfs2_meta_inode_buffer(ip, &dibh); |
1011 | if (error) | 1012 | if (error) { |
1013 | buf = ERR_PTR(error); | ||
1012 | goto out; | 1014 | goto out; |
1013 | |||
1014 | x = ip->i_disksize + 1; | ||
1015 | if (x > *len) { | ||
1016 | *buf = kmalloc(x, GFP_NOFS); | ||
1017 | if (!*buf) { | ||
1018 | error = -ENOMEM; | ||
1019 | goto out_brelse; | ||
1020 | } | ||
1021 | } | 1015 | } |
1022 | 1016 | ||
1023 | memcpy(*buf, dibh->b_data + sizeof(struct gfs2_dinode), x); | 1017 | x = ip->i_disksize + 1; |
1024 | *len = x; | 1018 | buf = kmalloc(x, GFP_NOFS); |
1025 | 1019 | if (!buf) | |
1026 | out_brelse: | 1020 | buf = ERR_PTR(-ENOMEM); |
1021 | else | ||
1022 | memcpy(buf, dibh->b_data + sizeof(struct gfs2_dinode), x); | ||
1027 | brelse(dibh); | 1023 | brelse(dibh); |
1028 | out: | 1024 | out: |
1029 | gfs2_glock_dq_uninit(&i_gh); | 1025 | gfs2_glock_dq_uninit(&i_gh); |
1030 | return error; | 1026 | nd_set_link(nd, buf); |
1031 | } | 1027 | return NULL; |
1032 | |||
1033 | /** | ||
1034 | * gfs2_readlink - Read the value of a symlink | ||
1035 | * @dentry: the symlink | ||
1036 | * @buf: the buffer to read the symlink data into | ||
1037 | * @size: the size of the buffer | ||
1038 | * | ||
1039 | * Returns: errno | ||
1040 | */ | ||
1041 | |||
1042 | static int gfs2_readlink(struct dentry *dentry, char __user *user_buf, | ||
1043 | int user_size) | ||
1044 | { | ||
1045 | struct gfs2_inode *ip = GFS2_I(dentry->d_inode); | ||
1046 | char array[GFS2_FAST_NAME_SIZE], *buf = array; | ||
1047 | unsigned int len = GFS2_FAST_NAME_SIZE; | ||
1048 | int error; | ||
1049 | |||
1050 | error = gfs2_readlinki(ip, &buf, &len); | ||
1051 | if (error) | ||
1052 | return error; | ||
1053 | |||
1054 | if (user_size > len - 1) | ||
1055 | user_size = len - 1; | ||
1056 | |||
1057 | if (copy_to_user(user_buf, buf, user_size)) | ||
1058 | error = -EFAULT; | ||
1059 | else | ||
1060 | error = user_size; | ||
1061 | |||
1062 | if (buf != array) | ||
1063 | kfree(buf); | ||
1064 | |||
1065 | return error; | ||
1066 | } | 1028 | } |
1067 | 1029 | ||
1068 | /** | 1030 | static void gfs2_put_link(struct dentry *dentry, struct nameidata *nd, void *p) |
1069 | * gfs2_follow_link - Follow a symbolic link | ||
1070 | * @dentry: The dentry of the link | ||
1071 | * @nd: Data that we pass to vfs_follow_link() | ||
1072 | * | ||
1073 | * This can handle symlinks of any size. It is optimised for symlinks | ||
1074 | * under GFS2_FAST_NAME_SIZE. | ||
1075 | * | ||
1076 | * Returns: 0 on success or error code | ||
1077 | */ | ||
1078 | |||
1079 | static void *gfs2_follow_link(struct dentry *dentry, struct nameidata *nd) | ||
1080 | { | 1031 | { |
1081 | struct gfs2_inode *ip = GFS2_I(dentry->d_inode); | 1032 | char *s = nd_get_link(nd); |
1082 | char array[GFS2_FAST_NAME_SIZE], *buf = array; | 1033 | if (!IS_ERR(s)) |
1083 | unsigned int len = GFS2_FAST_NAME_SIZE; | 1034 | kfree(s); |
1084 | int error; | ||
1085 | |||
1086 | error = gfs2_readlinki(ip, &buf, &len); | ||
1087 | if (!error) { | ||
1088 | error = vfs_follow_link(nd, buf); | ||
1089 | if (buf != array) | ||
1090 | kfree(buf); | ||
1091 | } else | ||
1092 | path_put(&nd->path); | ||
1093 | |||
1094 | return ERR_PTR(error); | ||
1095 | } | 1035 | } |
1096 | 1036 | ||
1097 | /** | 1037 | /** |
@@ -1426,8 +1366,9 @@ const struct inode_operations gfs2_dir_iops = { | |||
1426 | }; | 1366 | }; |
1427 | 1367 | ||
1428 | const struct inode_operations gfs2_symlink_iops = { | 1368 | const struct inode_operations gfs2_symlink_iops = { |
1429 | .readlink = gfs2_readlink, | 1369 | .readlink = generic_readlink, |
1430 | .follow_link = gfs2_follow_link, | 1370 | .follow_link = gfs2_follow_link, |
1371 | .put_link = gfs2_put_link, | ||
1431 | .permission = gfs2_permission, | 1372 | .permission = gfs2_permission, |
1432 | .setattr = gfs2_setattr, | 1373 | .setattr = gfs2_setattr, |
1433 | .getattr = gfs2_getattr, | 1374 | .getattr = gfs2_getattr, |
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index e3bf6eab8750..6dbcbad6ab17 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c | |||
@@ -1083,7 +1083,7 @@ void gfs2_quota_change(struct gfs2_inode *ip, s64 change, | |||
1083 | } | 1083 | } |
1084 | } | 1084 | } |
1085 | 1085 | ||
1086 | int gfs2_quota_sync(struct super_block *sb, int type) | 1086 | int gfs2_quota_sync(struct super_block *sb, int type, int wait) |
1087 | { | 1087 | { |
1088 | struct gfs2_sbd *sdp = sb->s_fs_info; | 1088 | struct gfs2_sbd *sdp = sb->s_fs_info; |
1089 | struct gfs2_quota_data **qda; | 1089 | struct gfs2_quota_data **qda; |
@@ -1127,6 +1127,11 @@ int gfs2_quota_sync(struct super_block *sb, int type) | |||
1127 | return error; | 1127 | return error; |
1128 | } | 1128 | } |
1129 | 1129 | ||
1130 | static int gfs2_quota_sync_timeo(struct super_block *sb, int type) | ||
1131 | { | ||
1132 | return gfs2_quota_sync(sb, type, 0); | ||
1133 | } | ||
1134 | |||
1130 | int gfs2_quota_refresh(struct gfs2_sbd *sdp, int user, u32 id) | 1135 | int gfs2_quota_refresh(struct gfs2_sbd *sdp, int user, u32 id) |
1131 | { | 1136 | { |
1132 | struct gfs2_quota_data *qd; | 1137 | struct gfs2_quota_data *qd; |
@@ -1382,7 +1387,7 @@ int gfs2_quotad(void *data) | |||
1382 | &tune->gt_statfs_quantum); | 1387 | &tune->gt_statfs_quantum); |
1383 | 1388 | ||
1384 | /* Update quota file */ | 1389 | /* Update quota file */ |
1385 | quotad_check_timeo(sdp, "sync", gfs2_quota_sync, t, | 1390 | quotad_check_timeo(sdp, "sync", gfs2_quota_sync_timeo, t, |
1386 | "ad_timeo, &tune->gt_quota_quantum); | 1391 | "ad_timeo, &tune->gt_quota_quantum); |
1387 | 1392 | ||
1388 | /* Check for & recover partially truncated inodes */ | 1393 | /* Check for & recover partially truncated inodes */ |
diff --git a/fs/gfs2/quota.h b/fs/gfs2/quota.h index e271fa07ad02..195f60c8bd14 100644 --- a/fs/gfs2/quota.h +++ b/fs/gfs2/quota.h | |||
@@ -25,7 +25,7 @@ extern int gfs2_quota_check(struct gfs2_inode *ip, u32 uid, u32 gid); | |||
25 | extern void gfs2_quota_change(struct gfs2_inode *ip, s64 change, | 25 | extern void gfs2_quota_change(struct gfs2_inode *ip, s64 change, |
26 | u32 uid, u32 gid); | 26 | u32 uid, u32 gid); |
27 | 27 | ||
28 | extern int gfs2_quota_sync(struct super_block *sb, int type); | 28 | extern int gfs2_quota_sync(struct super_block *sb, int type, int wait); |
29 | extern int gfs2_quota_refresh(struct gfs2_sbd *sdp, int user, u32 id); | 29 | extern int gfs2_quota_refresh(struct gfs2_sbd *sdp, int user, u32 id); |
30 | 30 | ||
31 | extern int gfs2_quota_init(struct gfs2_sbd *sdp); | 31 | extern int gfs2_quota_init(struct gfs2_sbd *sdp); |
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index b9dd3da22c0a..50aac606b990 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c | |||
@@ -22,6 +22,7 @@ | |||
22 | #include <linux/crc32.h> | 22 | #include <linux/crc32.h> |
23 | #include <linux/time.h> | 23 | #include <linux/time.h> |
24 | #include <linux/wait.h> | 24 | #include <linux/wait.h> |
25 | #include <linux/writeback.h> | ||
25 | 26 | ||
26 | #include "gfs2.h" | 27 | #include "gfs2.h" |
27 | #include "incore.h" | 28 | #include "incore.h" |
@@ -711,7 +712,7 @@ void gfs2_unfreeze_fs(struct gfs2_sbd *sdp) | |||
711 | * Returns: errno | 712 | * Returns: errno |
712 | */ | 713 | */ |
713 | 714 | ||
714 | static int gfs2_write_inode(struct inode *inode, int sync) | 715 | static int gfs2_write_inode(struct inode *inode, struct writeback_control *wbc) |
715 | { | 716 | { |
716 | struct gfs2_inode *ip = GFS2_I(inode); | 717 | struct gfs2_inode *ip = GFS2_I(inode); |
717 | struct gfs2_sbd *sdp = GFS2_SB(inode); | 718 | struct gfs2_sbd *sdp = GFS2_SB(inode); |
@@ -722,8 +723,7 @@ static int gfs2_write_inode(struct inode *inode, int sync) | |||
722 | int ret = 0; | 723 | int ret = 0; |
723 | 724 | ||
724 | /* Check this is a "normal" inode, etc */ | 725 | /* Check this is a "normal" inode, etc */ |
725 | if (!test_bit(GIF_USER, &ip->i_flags) || | 726 | if (current->flags & PF_MEMALLOC) |
726 | (current->flags & PF_MEMALLOC)) | ||
727 | return 0; | 727 | return 0; |
728 | ret = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, &gh); | 728 | ret = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, &gh); |
729 | if (ret) | 729 | if (ret) |
@@ -746,7 +746,7 @@ static int gfs2_write_inode(struct inode *inode, int sync) | |||
746 | do_unlock: | 746 | do_unlock: |
747 | gfs2_glock_dq_uninit(&gh); | 747 | gfs2_glock_dq_uninit(&gh); |
748 | do_flush: | 748 | do_flush: |
749 | if (sync != 0) | 749 | if (wbc->sync_mode == WB_SYNC_ALL) |
750 | gfs2_log_flush(GFS2_SB(inode), ip->i_gl); | 750 | gfs2_log_flush(GFS2_SB(inode), ip->i_gl); |
751 | return ret; | 751 | return ret; |
752 | } | 752 | } |
@@ -764,7 +764,7 @@ static int gfs2_make_fs_ro(struct gfs2_sbd *sdp) | |||
764 | int error; | 764 | int error; |
765 | 765 | ||
766 | flush_workqueue(gfs2_delete_workqueue); | 766 | flush_workqueue(gfs2_delete_workqueue); |
767 | gfs2_quota_sync(sdp->sd_vfs, 0); | 767 | gfs2_quota_sync(sdp->sd_vfs, 0, 1); |
768 | gfs2_statfs_sync(sdp->sd_vfs, 0); | 768 | gfs2_statfs_sync(sdp->sd_vfs, 0); |
769 | 769 | ||
770 | error = gfs2_glock_nq_init(sdp->sd_trans_gl, LM_ST_SHARED, GL_NOCACHE, | 770 | error = gfs2_glock_nq_init(sdp->sd_trans_gl, LM_ST_SHARED, GL_NOCACHE, |
@@ -860,6 +860,7 @@ restart: | |||
860 | gfs2_clear_rgrpd(sdp); | 860 | gfs2_clear_rgrpd(sdp); |
861 | gfs2_jindex_free(sdp); | 861 | gfs2_jindex_free(sdp); |
862 | /* Take apart glock structures and buffer lists */ | 862 | /* Take apart glock structures and buffer lists */ |
863 | invalidate_inodes(sdp->sd_vfs); | ||
863 | gfs2_gl_hash_clear(sdp); | 864 | gfs2_gl_hash_clear(sdp); |
864 | /* Unmount the locking protocol */ | 865 | /* Unmount the locking protocol */ |
865 | gfs2_lm_unmount(sdp); | 866 | gfs2_lm_unmount(sdp); |
@@ -1194,7 +1195,7 @@ static void gfs2_drop_inode(struct inode *inode) | |||
1194 | { | 1195 | { |
1195 | struct gfs2_inode *ip = GFS2_I(inode); | 1196 | struct gfs2_inode *ip = GFS2_I(inode); |
1196 | 1197 | ||
1197 | if (test_bit(GIF_USER, &ip->i_flags) && inode->i_nlink) { | 1198 | if (inode->i_nlink) { |
1198 | struct gfs2_glock *gl = ip->i_iopen_gh.gh_gl; | 1199 | struct gfs2_glock *gl = ip->i_iopen_gh.gh_gl; |
1199 | if (gl && test_bit(GLF_DEMOTE, &gl->gl_flags)) | 1200 | if (gl && test_bit(GLF_DEMOTE, &gl->gl_flags)) |
1200 | clear_nlink(inode); | 1201 | clear_nlink(inode); |
@@ -1212,18 +1213,12 @@ static void gfs2_clear_inode(struct inode *inode) | |||
1212 | { | 1213 | { |
1213 | struct gfs2_inode *ip = GFS2_I(inode); | 1214 | struct gfs2_inode *ip = GFS2_I(inode); |
1214 | 1215 | ||
1215 | /* This tells us its a "real" inode and not one which only | 1216 | ip->i_gl->gl_object = NULL; |
1216 | * serves to contain an address space (see rgrp.c, meta_io.c) | 1217 | gfs2_glock_put(ip->i_gl); |
1217 | * which therefore doesn't have its own glocks. | 1218 | ip->i_gl = NULL; |
1218 | */ | 1219 | if (ip->i_iopen_gh.gh_gl) { |
1219 | if (test_bit(GIF_USER, &ip->i_flags)) { | 1220 | ip->i_iopen_gh.gh_gl->gl_object = NULL; |
1220 | ip->i_gl->gl_object = NULL; | 1221 | gfs2_glock_dq_uninit(&ip->i_iopen_gh); |
1221 | gfs2_glock_put(ip->i_gl); | ||
1222 | ip->i_gl = NULL; | ||
1223 | if (ip->i_iopen_gh.gh_gl) { | ||
1224 | ip->i_iopen_gh.gh_gl->gl_object = NULL; | ||
1225 | gfs2_glock_dq_uninit(&ip->i_iopen_gh); | ||
1226 | } | ||
1227 | } | 1222 | } |
1228 | } | 1223 | } |
1229 | 1224 | ||
@@ -1358,9 +1353,6 @@ static void gfs2_delete_inode(struct inode *inode) | |||
1358 | struct gfs2_holder gh; | 1353 | struct gfs2_holder gh; |
1359 | int error; | 1354 | int error; |
1360 | 1355 | ||
1361 | if (!test_bit(GIF_USER, &ip->i_flags)) | ||
1362 | goto out; | ||
1363 | |||
1364 | error = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, &gh); | 1356 | error = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, &gh); |
1365 | if (unlikely(error)) { | 1357 | if (unlikely(error)) { |
1366 | gfs2_glock_dq_uninit(&ip->i_iopen_gh); | 1358 | gfs2_glock_dq_uninit(&ip->i_iopen_gh); |
diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c index 0dc34621f6a6..419042f7f0b6 100644 --- a/fs/gfs2/sys.c +++ b/fs/gfs2/sys.c | |||
@@ -49,7 +49,7 @@ static ssize_t gfs2_attr_store(struct kobject *kobj, struct attribute *attr, | |||
49 | return a->store ? a->store(sdp, buf, len) : len; | 49 | return a->store ? a->store(sdp, buf, len) : len; |
50 | } | 50 | } |
51 | 51 | ||
52 | static struct sysfs_ops gfs2_attr_ops = { | 52 | static const struct sysfs_ops gfs2_attr_ops = { |
53 | .show = gfs2_attr_show, | 53 | .show = gfs2_attr_show, |
54 | .store = gfs2_attr_store, | 54 | .store = gfs2_attr_store, |
55 | }; | 55 | }; |
@@ -167,7 +167,7 @@ static ssize_t quota_sync_store(struct gfs2_sbd *sdp, const char *buf, | |||
167 | if (simple_strtol(buf, NULL, 0) != 1) | 167 | if (simple_strtol(buf, NULL, 0) != 1) |
168 | return -EINVAL; | 168 | return -EINVAL; |
169 | 169 | ||
170 | gfs2_quota_sync(sdp->sd_vfs, 0); | 170 | gfs2_quota_sync(sdp->sd_vfs, 0, 1); |
171 | return len; | 171 | return len; |
172 | } | 172 | } |
173 | 173 | ||
@@ -478,7 +478,6 @@ TUNE_ATTR(complain_secs, 0); | |||
478 | TUNE_ATTR(statfs_slow, 0); | 478 | TUNE_ATTR(statfs_slow, 0); |
479 | TUNE_ATTR(new_files_jdata, 0); | 479 | TUNE_ATTR(new_files_jdata, 0); |
480 | TUNE_ATTR(quota_simul_sync, 1); | 480 | TUNE_ATTR(quota_simul_sync, 1); |
481 | TUNE_ATTR(stall_secs, 1); | ||
482 | TUNE_ATTR(statfs_quantum, 1); | 481 | TUNE_ATTR(statfs_quantum, 1); |
483 | TUNE_ATTR_3(quota_scale, quota_scale_show, quota_scale_store); | 482 | TUNE_ATTR_3(quota_scale, quota_scale_show, quota_scale_store); |
484 | 483 | ||
@@ -491,7 +490,6 @@ static struct attribute *tune_attrs[] = { | |||
491 | &tune_attr_complain_secs.attr, | 490 | &tune_attr_complain_secs.attr, |
492 | &tune_attr_statfs_slow.attr, | 491 | &tune_attr_statfs_slow.attr, |
493 | &tune_attr_quota_simul_sync.attr, | 492 | &tune_attr_quota_simul_sync.attr, |
494 | &tune_attr_stall_secs.attr, | ||
495 | &tune_attr_statfs_quantum.attr, | 493 | &tune_attr_statfs_quantum.attr, |
496 | &tune_attr_quota_scale.attr, | 494 | &tune_attr_quota_scale.attr, |
497 | &tune_attr_new_files_jdata.attr, | 495 | &tune_attr_new_files_jdata.attr, |
@@ -576,7 +574,7 @@ static int gfs2_uevent(struct kset *kset, struct kobject *kobj, | |||
576 | return 0; | 574 | return 0; |
577 | } | 575 | } |
578 | 576 | ||
579 | static struct kset_uevent_ops gfs2_uevent_ops = { | 577 | static const struct kset_uevent_ops gfs2_uevent_ops = { |
580 | .uevent = gfs2_uevent, | 578 | .uevent = gfs2_uevent, |
581 | }; | 579 | }; |
582 | 580 | ||
diff --git a/fs/gfs2/util.c b/fs/gfs2/util.c index f6a7efa34eb9..226f2bfbf16a 100644 --- a/fs/gfs2/util.c +++ b/fs/gfs2/util.c | |||
@@ -21,6 +21,7 @@ | |||
21 | #include "util.h" | 21 | #include "util.h" |
22 | 22 | ||
23 | struct kmem_cache *gfs2_glock_cachep __read_mostly; | 23 | struct kmem_cache *gfs2_glock_cachep __read_mostly; |
24 | struct kmem_cache *gfs2_glock_aspace_cachep __read_mostly; | ||
24 | struct kmem_cache *gfs2_inode_cachep __read_mostly; | 25 | struct kmem_cache *gfs2_inode_cachep __read_mostly; |
25 | struct kmem_cache *gfs2_bufdata_cachep __read_mostly; | 26 | struct kmem_cache *gfs2_bufdata_cachep __read_mostly; |
26 | struct kmem_cache *gfs2_rgrpd_cachep __read_mostly; | 27 | struct kmem_cache *gfs2_rgrpd_cachep __read_mostly; |
diff --git a/fs/gfs2/util.h b/fs/gfs2/util.h index 33e96b0ce9ab..b432e04600de 100644 --- a/fs/gfs2/util.h +++ b/fs/gfs2/util.h | |||
@@ -145,6 +145,7 @@ gfs2_io_error_bh_i((sdp), (bh), __func__, __FILE__, __LINE__); | |||
145 | 145 | ||
146 | 146 | ||
147 | extern struct kmem_cache *gfs2_glock_cachep; | 147 | extern struct kmem_cache *gfs2_glock_cachep; |
148 | extern struct kmem_cache *gfs2_glock_aspace_cachep; | ||
148 | extern struct kmem_cache *gfs2_inode_cachep; | 149 | extern struct kmem_cache *gfs2_inode_cachep; |
149 | extern struct kmem_cache *gfs2_bufdata_cachep; | 150 | extern struct kmem_cache *gfs2_bufdata_cachep; |
150 | extern struct kmem_cache *gfs2_rgrpd_cachep; | 151 | extern struct kmem_cache *gfs2_rgrpd_cachep; |
diff --git a/fs/hfs/hfs_fs.h b/fs/hfs/hfs_fs.h index 052387e11671..fe35e3b626c4 100644 --- a/fs/hfs/hfs_fs.h +++ b/fs/hfs/hfs_fs.h | |||
@@ -188,7 +188,7 @@ extern const struct address_space_operations hfs_btree_aops; | |||
188 | 188 | ||
189 | extern struct inode *hfs_new_inode(struct inode *, struct qstr *, int); | 189 | extern struct inode *hfs_new_inode(struct inode *, struct qstr *, int); |
190 | extern void hfs_inode_write_fork(struct inode *, struct hfs_extent *, __be32 *, __be32 *); | 190 | extern void hfs_inode_write_fork(struct inode *, struct hfs_extent *, __be32 *, __be32 *); |
191 | extern int hfs_write_inode(struct inode *, int); | 191 | extern int hfs_write_inode(struct inode *, struct writeback_control *); |
192 | extern int hfs_inode_setattr(struct dentry *, struct iattr *); | 192 | extern int hfs_inode_setattr(struct dentry *, struct iattr *); |
193 | extern void hfs_inode_read_fork(struct inode *inode, struct hfs_extent *ext, | 193 | extern void hfs_inode_read_fork(struct inode *inode, struct hfs_extent *ext, |
194 | __be32 log_size, __be32 phys_size, u32 clump_size); | 194 | __be32 log_size, __be32 phys_size, u32 clump_size); |
diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c index a1cbff2b4d99..14f5cb1b9fdc 100644 --- a/fs/hfs/inode.c +++ b/fs/hfs/inode.c | |||
@@ -381,7 +381,7 @@ void hfs_inode_write_fork(struct inode *inode, struct hfs_extent *ext, | |||
381 | HFS_SB(inode->i_sb)->alloc_blksz); | 381 | HFS_SB(inode->i_sb)->alloc_blksz); |
382 | } | 382 | } |
383 | 383 | ||
384 | int hfs_write_inode(struct inode *inode, int unused) | 384 | int hfs_write_inode(struct inode *inode, struct writeback_control *wbc) |
385 | { | 385 | { |
386 | struct inode *main_inode = inode; | 386 | struct inode *main_inode = inode; |
387 | struct hfs_find_data fd; | 387 | struct hfs_find_data fd; |
diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c index 43022f3d5148..74b473a8ef92 100644 --- a/fs/hfsplus/super.c +++ b/fs/hfsplus/super.c | |||
@@ -87,7 +87,8 @@ bad_inode: | |||
87 | return ERR_PTR(err); | 87 | return ERR_PTR(err); |
88 | } | 88 | } |
89 | 89 | ||
90 | static int hfsplus_write_inode(struct inode *inode, int unused) | 90 | static int hfsplus_write_inode(struct inode *inode, |
91 | struct writeback_control *wbc) | ||
91 | { | 92 | { |
92 | struct hfsplus_vh *vhdr; | 93 | struct hfsplus_vh *vhdr; |
93 | int ret = 0; | 94 | int ret = 0; |
diff --git a/fs/hpfs/anode.c b/fs/hpfs/anode.c index 1aa88c4e0964..6a2f04bf3df0 100644 --- a/fs/hpfs/anode.c +++ b/fs/hpfs/anode.c | |||
@@ -353,7 +353,7 @@ int hpfs_ea_read(struct super_block *s, secno a, int ano, unsigned pos, | |||
353 | } | 353 | } |
354 | 354 | ||
355 | int hpfs_ea_write(struct super_block *s, secno a, int ano, unsigned pos, | 355 | int hpfs_ea_write(struct super_block *s, secno a, int ano, unsigned pos, |
356 | unsigned len, char *buf) | 356 | unsigned len, const char *buf) |
357 | { | 357 | { |
358 | struct buffer_head *bh; | 358 | struct buffer_head *bh; |
359 | char *data; | 359 | char *data; |
diff --git a/fs/hpfs/dentry.c b/fs/hpfs/dentry.c index 940d6d150bee..67d9d36b3d5f 100644 --- a/fs/hpfs/dentry.c +++ b/fs/hpfs/dentry.c | |||
@@ -20,8 +20,8 @@ static int hpfs_hash_dentry(struct dentry *dentry, struct qstr *qstr) | |||
20 | 20 | ||
21 | if (l == 1) if (qstr->name[0]=='.') goto x; | 21 | if (l == 1) if (qstr->name[0]=='.') goto x; |
22 | if (l == 2) if (qstr->name[0]=='.' || qstr->name[1]=='.') goto x; | 22 | if (l == 2) if (qstr->name[0]=='.' || qstr->name[1]=='.') goto x; |
23 | hpfs_adjust_length((char *)qstr->name, &l); | 23 | hpfs_adjust_length(qstr->name, &l); |
24 | /*if (hpfs_chk_name((char *)qstr->name,&l))*/ | 24 | /*if (hpfs_chk_name(qstr->name,&l))*/ |
25 | /*return -ENAMETOOLONG;*/ | 25 | /*return -ENAMETOOLONG;*/ |
26 | /*return -ENOENT;*/ | 26 | /*return -ENOENT;*/ |
27 | x: | 27 | x: |
@@ -38,14 +38,16 @@ static int hpfs_compare_dentry(struct dentry *dentry, struct qstr *a, struct qst | |||
38 | { | 38 | { |
39 | unsigned al=a->len; | 39 | unsigned al=a->len; |
40 | unsigned bl=b->len; | 40 | unsigned bl=b->len; |
41 | hpfs_adjust_length((char *)a->name, &al); | 41 | hpfs_adjust_length(a->name, &al); |
42 | /*hpfs_adjust_length((char *)b->name, &bl);*/ | 42 | /*hpfs_adjust_length(b->name, &bl);*/ |
43 | /* 'a' is the qstr of an already existing dentry, so the name | 43 | /* 'a' is the qstr of an already existing dentry, so the name |
44 | * must be valid. 'b' must be validated first. | 44 | * must be valid. 'b' must be validated first. |
45 | */ | 45 | */ |
46 | 46 | ||
47 | if (hpfs_chk_name((char *)b->name, &bl)) return 1; | 47 | if (hpfs_chk_name(b->name, &bl)) |
48 | if (hpfs_compare_names(dentry->d_sb, (char *)a->name, al, (char *)b->name, bl, 0)) return 1; | 48 | return 1; |
49 | if (hpfs_compare_names(dentry->d_sb, a->name, al, b->name, bl, 0)) | ||
50 | return 1; | ||
49 | return 0; | 51 | return 0; |
50 | } | 52 | } |
51 | 53 | ||
diff --git a/fs/hpfs/dir.c b/fs/hpfs/dir.c index 8865c94f55f6..26e3964a4b8c 100644 --- a/fs/hpfs/dir.c +++ b/fs/hpfs/dir.c | |||
@@ -59,7 +59,7 @@ static int hpfs_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
59 | struct hpfs_dirent *de; | 59 | struct hpfs_dirent *de; |
60 | int lc; | 60 | int lc; |
61 | long old_pos; | 61 | long old_pos; |
62 | char *tempname; | 62 | unsigned char *tempname; |
63 | int c1, c2 = 0; | 63 | int c1, c2 = 0; |
64 | int ret = 0; | 64 | int ret = 0; |
65 | 65 | ||
@@ -158,11 +158,11 @@ static int hpfs_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
158 | tempname = hpfs_translate_name(inode->i_sb, de->name, de->namelen, lc, de->not_8x3); | 158 | tempname = hpfs_translate_name(inode->i_sb, de->name, de->namelen, lc, de->not_8x3); |
159 | if (filldir(dirent, tempname, de->namelen, old_pos, de->fnode, DT_UNKNOWN) < 0) { | 159 | if (filldir(dirent, tempname, de->namelen, old_pos, de->fnode, DT_UNKNOWN) < 0) { |
160 | filp->f_pos = old_pos; | 160 | filp->f_pos = old_pos; |
161 | if (tempname != (char *)de->name) kfree(tempname); | 161 | if (tempname != de->name) kfree(tempname); |
162 | hpfs_brelse4(&qbh); | 162 | hpfs_brelse4(&qbh); |
163 | goto out; | 163 | goto out; |
164 | } | 164 | } |
165 | if (tempname != (char *)de->name) kfree(tempname); | 165 | if (tempname != de->name) kfree(tempname); |
166 | hpfs_brelse4(&qbh); | 166 | hpfs_brelse4(&qbh); |
167 | } | 167 | } |
168 | out: | 168 | out: |
@@ -187,7 +187,7 @@ out: | |||
187 | 187 | ||
188 | struct dentry *hpfs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | 188 | struct dentry *hpfs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) |
189 | { | 189 | { |
190 | const char *name = dentry->d_name.name; | 190 | const unsigned char *name = dentry->d_name.name; |
191 | unsigned len = dentry->d_name.len; | 191 | unsigned len = dentry->d_name.len; |
192 | struct quad_buffer_head qbh; | 192 | struct quad_buffer_head qbh; |
193 | struct hpfs_dirent *de; | 193 | struct hpfs_dirent *de; |
@@ -197,7 +197,7 @@ struct dentry *hpfs_lookup(struct inode *dir, struct dentry *dentry, struct name | |||
197 | struct hpfs_inode_info *hpfs_result; | 197 | struct hpfs_inode_info *hpfs_result; |
198 | 198 | ||
199 | lock_kernel(); | 199 | lock_kernel(); |
200 | if ((err = hpfs_chk_name((char *)name, &len))) { | 200 | if ((err = hpfs_chk_name(name, &len))) { |
201 | if (err == -ENAMETOOLONG) { | 201 | if (err == -ENAMETOOLONG) { |
202 | unlock_kernel(); | 202 | unlock_kernel(); |
203 | return ERR_PTR(-ENAMETOOLONG); | 203 | return ERR_PTR(-ENAMETOOLONG); |
@@ -209,7 +209,7 @@ struct dentry *hpfs_lookup(struct inode *dir, struct dentry *dentry, struct name | |||
209 | * '.' and '..' will never be passed here. | 209 | * '.' and '..' will never be passed here. |
210 | */ | 210 | */ |
211 | 211 | ||
212 | de = map_dirent(dir, hpfs_i(dir)->i_dno, (char *) name, len, NULL, &qbh); | 212 | de = map_dirent(dir, hpfs_i(dir)->i_dno, name, len, NULL, &qbh); |
213 | 213 | ||
214 | /* | 214 | /* |
215 | * This is not really a bailout, just means file not found. | 215 | * This is not really a bailout, just means file not found. |
@@ -250,7 +250,7 @@ struct dentry *hpfs_lookup(struct inode *dir, struct dentry *dentry, struct name | |||
250 | hpfs_result = hpfs_i(result); | 250 | hpfs_result = hpfs_i(result); |
251 | if (!de->directory) hpfs_result->i_parent_dir = dir->i_ino; | 251 | if (!de->directory) hpfs_result->i_parent_dir = dir->i_ino; |
252 | 252 | ||
253 | hpfs_decide_conv(result, (char *)name, len); | 253 | hpfs_decide_conv(result, name, len); |
254 | 254 | ||
255 | if (de->has_acl || de->has_xtd_perm) if (!(dir->i_sb->s_flags & MS_RDONLY)) { | 255 | if (de->has_acl || de->has_xtd_perm) if (!(dir->i_sb->s_flags & MS_RDONLY)) { |
256 | hpfs_error(result->i_sb, "ACLs or XPERM found. This is probably HPFS386. This driver doesn't support it now. Send me some info on these structures"); | 256 | hpfs_error(result->i_sb, "ACLs or XPERM found. This is probably HPFS386. This driver doesn't support it now. Send me some info on these structures"); |
diff --git a/fs/hpfs/dnode.c b/fs/hpfs/dnode.c index fe83c2b7d2d8..9b2ffadfc8c4 100644 --- a/fs/hpfs/dnode.c +++ b/fs/hpfs/dnode.c | |||
@@ -158,7 +158,8 @@ static void set_last_pointer(struct super_block *s, struct dnode *d, dnode_secno | |||
158 | 158 | ||
159 | /* Add an entry to dnode and don't care if it grows over 2048 bytes */ | 159 | /* Add an entry to dnode and don't care if it grows over 2048 bytes */ |
160 | 160 | ||
161 | struct hpfs_dirent *hpfs_add_de(struct super_block *s, struct dnode *d, unsigned char *name, | 161 | struct hpfs_dirent *hpfs_add_de(struct super_block *s, struct dnode *d, |
162 | const unsigned char *name, | ||
162 | unsigned namelen, secno down_ptr) | 163 | unsigned namelen, secno down_ptr) |
163 | { | 164 | { |
164 | struct hpfs_dirent *de; | 165 | struct hpfs_dirent *de; |
@@ -223,7 +224,7 @@ static void fix_up_ptrs(struct super_block *s, struct dnode *d) | |||
223 | /* Add an entry to dnode and do dnode splitting if required */ | 224 | /* Add an entry to dnode and do dnode splitting if required */ |
224 | 225 | ||
225 | static int hpfs_add_to_dnode(struct inode *i, dnode_secno dno, | 226 | static int hpfs_add_to_dnode(struct inode *i, dnode_secno dno, |
226 | unsigned char *name, unsigned namelen, | 227 | const unsigned char *name, unsigned namelen, |
227 | struct hpfs_dirent *new_de, dnode_secno down_ptr) | 228 | struct hpfs_dirent *new_de, dnode_secno down_ptr) |
228 | { | 229 | { |
229 | struct quad_buffer_head qbh, qbh1, qbh2; | 230 | struct quad_buffer_head qbh, qbh1, qbh2; |
@@ -231,7 +232,7 @@ static int hpfs_add_to_dnode(struct inode *i, dnode_secno dno, | |||
231 | dnode_secno adno, rdno; | 232 | dnode_secno adno, rdno; |
232 | struct hpfs_dirent *de; | 233 | struct hpfs_dirent *de; |
233 | struct hpfs_dirent nde; | 234 | struct hpfs_dirent nde; |
234 | char *nname; | 235 | unsigned char *nname; |
235 | int h; | 236 | int h; |
236 | int pos; | 237 | int pos; |
237 | struct buffer_head *bh; | 238 | struct buffer_head *bh; |
@@ -305,7 +306,9 @@ static int hpfs_add_to_dnode(struct inode *i, dnode_secno dno, | |||
305 | pos++; | 306 | pos++; |
306 | } | 307 | } |
307 | copy_de(new_de = &nde, de); | 308 | copy_de(new_de = &nde, de); |
308 | memcpy(name = nname, de->name, namelen = de->namelen); | 309 | memcpy(nname, de->name, de->namelen); |
310 | name = nname; | ||
311 | namelen = de->namelen; | ||
309 | for_all_poss(i, hpfs_pos_subst, ((loff_t)dno << 4) | pos, 4); | 312 | for_all_poss(i, hpfs_pos_subst, ((loff_t)dno << 4) | pos, 4); |
310 | down_ptr = adno; | 313 | down_ptr = adno; |
311 | set_last_pointer(i->i_sb, ad, de->down ? de_down_pointer(de) : 0); | 314 | set_last_pointer(i->i_sb, ad, de->down ? de_down_pointer(de) : 0); |
@@ -368,7 +371,8 @@ static int hpfs_add_to_dnode(struct inode *i, dnode_secno dno, | |||
368 | * I hope, now it's finally bug-free. | 371 | * I hope, now it's finally bug-free. |
369 | */ | 372 | */ |
370 | 373 | ||
371 | int hpfs_add_dirent(struct inode *i, unsigned char *name, unsigned namelen, | 374 | int hpfs_add_dirent(struct inode *i, |
375 | const unsigned char *name, unsigned namelen, | ||
372 | struct hpfs_dirent *new_de, int cdepth) | 376 | struct hpfs_dirent *new_de, int cdepth) |
373 | { | 377 | { |
374 | struct hpfs_inode_info *hpfs_inode = hpfs_i(i); | 378 | struct hpfs_inode_info *hpfs_inode = hpfs_i(i); |
@@ -897,7 +901,8 @@ struct hpfs_dirent *map_pos_dirent(struct inode *inode, loff_t *posp, | |||
897 | 901 | ||
898 | /* Find a dirent in tree */ | 902 | /* Find a dirent in tree */ |
899 | 903 | ||
900 | struct hpfs_dirent *map_dirent(struct inode *inode, dnode_secno dno, char *name, unsigned len, | 904 | struct hpfs_dirent *map_dirent(struct inode *inode, dnode_secno dno, |
905 | const unsigned char *name, unsigned len, | ||
901 | dnode_secno *dd, struct quad_buffer_head *qbh) | 906 | dnode_secno *dd, struct quad_buffer_head *qbh) |
902 | { | 907 | { |
903 | struct dnode *dnode; | 908 | struct dnode *dnode; |
@@ -988,8 +993,8 @@ void hpfs_remove_dtree(struct super_block *s, dnode_secno dno) | |||
988 | struct hpfs_dirent *map_fnode_dirent(struct super_block *s, fnode_secno fno, | 993 | struct hpfs_dirent *map_fnode_dirent(struct super_block *s, fnode_secno fno, |
989 | struct fnode *f, struct quad_buffer_head *qbh) | 994 | struct fnode *f, struct quad_buffer_head *qbh) |
990 | { | 995 | { |
991 | char *name1; | 996 | unsigned char *name1; |
992 | char *name2; | 997 | unsigned char *name2; |
993 | int name1len, name2len; | 998 | int name1len, name2len; |
994 | struct dnode *d; | 999 | struct dnode *d; |
995 | dnode_secno dno, downd; | 1000 | dnode_secno dno, downd; |
diff --git a/fs/hpfs/ea.c b/fs/hpfs/ea.c index 547a8384571f..45e53d972b42 100644 --- a/fs/hpfs/ea.c +++ b/fs/hpfs/ea.c | |||
@@ -62,8 +62,8 @@ static char *get_indirect_ea(struct super_block *s, int ano, secno a, int size) | |||
62 | return ret; | 62 | return ret; |
63 | } | 63 | } |
64 | 64 | ||
65 | static void set_indirect_ea(struct super_block *s, int ano, secno a, char *data, | 65 | static void set_indirect_ea(struct super_block *s, int ano, secno a, |
66 | int size) | 66 | const char *data, int size) |
67 | { | 67 | { |
68 | hpfs_ea_write(s, a, ano, 0, size, data); | 68 | hpfs_ea_write(s, a, ano, 0, size, data); |
69 | } | 69 | } |
@@ -186,7 +186,8 @@ char *hpfs_get_ea(struct super_block *s, struct fnode *fnode, char *key, int *si | |||
186 | * This driver can't change sizes of eas ('cause I just don't need it). | 186 | * This driver can't change sizes of eas ('cause I just don't need it). |
187 | */ | 187 | */ |
188 | 188 | ||
189 | void hpfs_set_ea(struct inode *inode, struct fnode *fnode, char *key, char *data, int size) | 189 | void hpfs_set_ea(struct inode *inode, struct fnode *fnode, const char *key, |
190 | const char *data, int size) | ||
190 | { | 191 | { |
191 | fnode_secno fno = inode->i_ino; | 192 | fnode_secno fno = inode->i_ino; |
192 | struct super_block *s = inode->i_sb; | 193 | struct super_block *s = inode->i_sb; |
diff --git a/fs/hpfs/hpfs_fn.h b/fs/hpfs/hpfs_fn.h index 701ca54c0867..97bf738cd5d6 100644 --- a/fs/hpfs/hpfs_fn.h +++ b/fs/hpfs/hpfs_fn.h | |||
@@ -215,7 +215,7 @@ secno hpfs_bplus_lookup(struct super_block *, struct inode *, struct bplus_heade | |||
215 | secno hpfs_add_sector_to_btree(struct super_block *, secno, int, unsigned); | 215 | secno hpfs_add_sector_to_btree(struct super_block *, secno, int, unsigned); |
216 | void hpfs_remove_btree(struct super_block *, struct bplus_header *); | 216 | void hpfs_remove_btree(struct super_block *, struct bplus_header *); |
217 | int hpfs_ea_read(struct super_block *, secno, int, unsigned, unsigned, char *); | 217 | int hpfs_ea_read(struct super_block *, secno, int, unsigned, unsigned, char *); |
218 | int hpfs_ea_write(struct super_block *, secno, int, unsigned, unsigned, char *); | 218 | int hpfs_ea_write(struct super_block *, secno, int, unsigned, unsigned, const char *); |
219 | void hpfs_ea_remove(struct super_block *, secno, int, unsigned); | 219 | void hpfs_ea_remove(struct super_block *, secno, int, unsigned); |
220 | void hpfs_truncate_btree(struct super_block *, secno, int, unsigned); | 220 | void hpfs_truncate_btree(struct super_block *, secno, int, unsigned); |
221 | void hpfs_remove_fnode(struct super_block *, fnode_secno fno); | 221 | void hpfs_remove_fnode(struct super_block *, fnode_secno fno); |
@@ -244,13 +244,17 @@ extern const struct file_operations hpfs_dir_ops; | |||
244 | 244 | ||
245 | void hpfs_add_pos(struct inode *, loff_t *); | 245 | void hpfs_add_pos(struct inode *, loff_t *); |
246 | void hpfs_del_pos(struct inode *, loff_t *); | 246 | void hpfs_del_pos(struct inode *, loff_t *); |
247 | struct hpfs_dirent *hpfs_add_de(struct super_block *, struct dnode *, unsigned char *, unsigned, secno); | 247 | struct hpfs_dirent *hpfs_add_de(struct super_block *, struct dnode *, |
248 | int hpfs_add_dirent(struct inode *, unsigned char *, unsigned, struct hpfs_dirent *, int); | 248 | const unsigned char *, unsigned, secno); |
249 | int hpfs_add_dirent(struct inode *, const unsigned char *, unsigned, | ||
250 | struct hpfs_dirent *, int); | ||
249 | int hpfs_remove_dirent(struct inode *, dnode_secno, struct hpfs_dirent *, struct quad_buffer_head *, int); | 251 | int hpfs_remove_dirent(struct inode *, dnode_secno, struct hpfs_dirent *, struct quad_buffer_head *, int); |
250 | void hpfs_count_dnodes(struct super_block *, dnode_secno, int *, int *, int *); | 252 | void hpfs_count_dnodes(struct super_block *, dnode_secno, int *, int *, int *); |
251 | dnode_secno hpfs_de_as_down_as_possible(struct super_block *, dnode_secno dno); | 253 | dnode_secno hpfs_de_as_down_as_possible(struct super_block *, dnode_secno dno); |
252 | struct hpfs_dirent *map_pos_dirent(struct inode *, loff_t *, struct quad_buffer_head *); | 254 | struct hpfs_dirent *map_pos_dirent(struct inode *, loff_t *, struct quad_buffer_head *); |
253 | struct hpfs_dirent *map_dirent(struct inode *, dnode_secno, char *, unsigned, dnode_secno *, struct quad_buffer_head *); | 255 | struct hpfs_dirent *map_dirent(struct inode *, dnode_secno, |
256 | const unsigned char *, unsigned, dnode_secno *, | ||
257 | struct quad_buffer_head *); | ||
254 | void hpfs_remove_dtree(struct super_block *, dnode_secno); | 258 | void hpfs_remove_dtree(struct super_block *, dnode_secno); |
255 | struct hpfs_dirent *map_fnode_dirent(struct super_block *, fnode_secno, struct fnode *, struct quad_buffer_head *); | 259 | struct hpfs_dirent *map_fnode_dirent(struct super_block *, fnode_secno, struct fnode *, struct quad_buffer_head *); |
256 | 260 | ||
@@ -259,7 +263,8 @@ struct hpfs_dirent *map_fnode_dirent(struct super_block *, fnode_secno, struct f | |||
259 | void hpfs_ea_ext_remove(struct super_block *, secno, int, unsigned); | 263 | void hpfs_ea_ext_remove(struct super_block *, secno, int, unsigned); |
260 | int hpfs_read_ea(struct super_block *, struct fnode *, char *, char *, int); | 264 | int hpfs_read_ea(struct super_block *, struct fnode *, char *, char *, int); |
261 | char *hpfs_get_ea(struct super_block *, struct fnode *, char *, int *); | 265 | char *hpfs_get_ea(struct super_block *, struct fnode *, char *, int *); |
262 | void hpfs_set_ea(struct inode *, struct fnode *, char *, char *, int); | 266 | void hpfs_set_ea(struct inode *, struct fnode *, const char *, |
267 | const char *, int); | ||
263 | 268 | ||
264 | /* file.c */ | 269 | /* file.c */ |
265 | 270 | ||
@@ -282,7 +287,7 @@ void hpfs_delete_inode(struct inode *); | |||
282 | 287 | ||
283 | unsigned *hpfs_map_dnode_bitmap(struct super_block *, struct quad_buffer_head *); | 288 | unsigned *hpfs_map_dnode_bitmap(struct super_block *, struct quad_buffer_head *); |
284 | unsigned *hpfs_map_bitmap(struct super_block *, unsigned, struct quad_buffer_head *, char *); | 289 | unsigned *hpfs_map_bitmap(struct super_block *, unsigned, struct quad_buffer_head *, char *); |
285 | char *hpfs_load_code_page(struct super_block *, secno); | 290 | unsigned char *hpfs_load_code_page(struct super_block *, secno); |
286 | secno *hpfs_load_bitmap_directory(struct super_block *, secno bmp); | 291 | secno *hpfs_load_bitmap_directory(struct super_block *, secno bmp); |
287 | struct fnode *hpfs_map_fnode(struct super_block *s, ino_t, struct buffer_head **); | 292 | struct fnode *hpfs_map_fnode(struct super_block *s, ino_t, struct buffer_head **); |
288 | struct anode *hpfs_map_anode(struct super_block *s, anode_secno, struct buffer_head **); | 293 | struct anode *hpfs_map_anode(struct super_block *s, anode_secno, struct buffer_head **); |
@@ -292,12 +297,13 @@ dnode_secno hpfs_fnode_dno(struct super_block *s, ino_t ino); | |||
292 | /* name.c */ | 297 | /* name.c */ |
293 | 298 | ||
294 | unsigned char hpfs_upcase(unsigned char *, unsigned char); | 299 | unsigned char hpfs_upcase(unsigned char *, unsigned char); |
295 | int hpfs_chk_name(unsigned char *, unsigned *); | 300 | int hpfs_chk_name(const unsigned char *, unsigned *); |
296 | char *hpfs_translate_name(struct super_block *, unsigned char *, unsigned, int, int); | 301 | unsigned char *hpfs_translate_name(struct super_block *, unsigned char *, unsigned, int, int); |
297 | int hpfs_compare_names(struct super_block *, unsigned char *, unsigned, unsigned char *, unsigned, int); | 302 | int hpfs_compare_names(struct super_block *, const unsigned char *, unsigned, |
298 | int hpfs_is_name_long(unsigned char *, unsigned); | 303 | const unsigned char *, unsigned, int); |
299 | void hpfs_adjust_length(unsigned char *, unsigned *); | 304 | int hpfs_is_name_long(const unsigned char *, unsigned); |
300 | void hpfs_decide_conv(struct inode *, unsigned char *, unsigned); | 305 | void hpfs_adjust_length(const unsigned char *, unsigned *); |
306 | void hpfs_decide_conv(struct inode *, const unsigned char *, unsigned); | ||
301 | 307 | ||
302 | /* namei.c */ | 308 | /* namei.c */ |
303 | 309 | ||
diff --git a/fs/hpfs/inode.c b/fs/hpfs/inode.c index fe703ae46bc7..ff90affb94e1 100644 --- a/fs/hpfs/inode.c +++ b/fs/hpfs/inode.c | |||
@@ -46,7 +46,7 @@ void hpfs_read_inode(struct inode *i) | |||
46 | struct fnode *fnode; | 46 | struct fnode *fnode; |
47 | struct super_block *sb = i->i_sb; | 47 | struct super_block *sb = i->i_sb; |
48 | struct hpfs_inode_info *hpfs_inode = hpfs_i(i); | 48 | struct hpfs_inode_info *hpfs_inode = hpfs_i(i); |
49 | unsigned char *ea; | 49 | void *ea; |
50 | int ea_size; | 50 | int ea_size; |
51 | 51 | ||
52 | if (!(fnode = hpfs_map_fnode(sb, i->i_ino, &bh))) { | 52 | if (!(fnode = hpfs_map_fnode(sb, i->i_ino, &bh))) { |
@@ -112,7 +112,7 @@ void hpfs_read_inode(struct inode *i) | |||
112 | } | 112 | } |
113 | } | 113 | } |
114 | if (fnode->dirflag) { | 114 | if (fnode->dirflag) { |
115 | unsigned n_dnodes, n_subdirs; | 115 | int n_dnodes, n_subdirs; |
116 | i->i_mode |= S_IFDIR; | 116 | i->i_mode |= S_IFDIR; |
117 | i->i_op = &hpfs_dir_iops; | 117 | i->i_op = &hpfs_dir_iops; |
118 | i->i_fop = &hpfs_dir_ops; | 118 | i->i_fop = &hpfs_dir_ops; |
diff --git a/fs/hpfs/map.c b/fs/hpfs/map.c index c4724589b2eb..840d033ecee8 100644 --- a/fs/hpfs/map.c +++ b/fs/hpfs/map.c | |||
@@ -35,7 +35,7 @@ unsigned int *hpfs_map_bitmap(struct super_block *s, unsigned bmp_block, | |||
35 | * lowercasing table | 35 | * lowercasing table |
36 | */ | 36 | */ |
37 | 37 | ||
38 | char *hpfs_load_code_page(struct super_block *s, secno cps) | 38 | unsigned char *hpfs_load_code_page(struct super_block *s, secno cps) |
39 | { | 39 | { |
40 | struct buffer_head *bh; | 40 | struct buffer_head *bh; |
41 | secno cpds; | 41 | secno cpds; |
@@ -71,7 +71,7 @@ char *hpfs_load_code_page(struct super_block *s, secno cps) | |||
71 | brelse(bh); | 71 | brelse(bh); |
72 | return NULL; | 72 | return NULL; |
73 | } | 73 | } |
74 | ptr = (char *)cpd + cpd->offs[cpi] + 6; | 74 | ptr = (unsigned char *)cpd + cpd->offs[cpi] + 6; |
75 | if (!(cp_table = kmalloc(256, GFP_KERNEL))) { | 75 | if (!(cp_table = kmalloc(256, GFP_KERNEL))) { |
76 | printk("HPFS: out of memory for code page table\n"); | 76 | printk("HPFS: out of memory for code page table\n"); |
77 | brelse(bh); | 77 | brelse(bh); |
@@ -217,7 +217,7 @@ struct dnode *hpfs_map_dnode(struct super_block *s, unsigned secno, | |||
217 | if ((dnode = hpfs_map_4sectors(s, secno, qbh, DNODE_RD_AHEAD))) | 217 | if ((dnode = hpfs_map_4sectors(s, secno, qbh, DNODE_RD_AHEAD))) |
218 | if (hpfs_sb(s)->sb_chk) { | 218 | if (hpfs_sb(s)->sb_chk) { |
219 | unsigned p, pp = 0; | 219 | unsigned p, pp = 0; |
220 | unsigned char *d = (char *)dnode; | 220 | unsigned char *d = (unsigned char *)dnode; |
221 | int b = 0; | 221 | int b = 0; |
222 | if (dnode->magic != DNODE_MAGIC) { | 222 | if (dnode->magic != DNODE_MAGIC) { |
223 | hpfs_error(s, "bad magic on dnode %08x", secno); | 223 | hpfs_error(s, "bad magic on dnode %08x", secno); |
diff --git a/fs/hpfs/name.c b/fs/hpfs/name.c index 1f4a964384eb..f24736d7a439 100644 --- a/fs/hpfs/name.c +++ b/fs/hpfs/name.c | |||
@@ -8,16 +8,16 @@ | |||
8 | 8 | ||
9 | #include "hpfs_fn.h" | 9 | #include "hpfs_fn.h" |
10 | 10 | ||
11 | static char *text_postfix[]={ | 11 | static const char *text_postfix[]={ |
12 | ".ASM", ".BAS", ".BAT", ".C", ".CC", ".CFG", ".CMD", ".CON", ".CPP", ".DEF", | 12 | ".ASM", ".BAS", ".BAT", ".C", ".CC", ".CFG", ".CMD", ".CON", ".CPP", ".DEF", |
13 | ".DOC", ".DPR", ".ERX", ".H", ".HPP", ".HTM", ".HTML", ".JAVA", ".LOG", ".PAS", | 13 | ".DOC", ".DPR", ".ERX", ".H", ".HPP", ".HTM", ".HTML", ".JAVA", ".LOG", ".PAS", |
14 | ".RC", ".TEX", ".TXT", ".Y", ""}; | 14 | ".RC", ".TEX", ".TXT", ".Y", ""}; |
15 | 15 | ||
16 | static char *text_prefix[]={ | 16 | static const char *text_prefix[]={ |
17 | "AUTOEXEC.", "CHANGES", "COPYING", "CONFIG.", "CREDITS", "FAQ", "FILE_ID.DIZ", | 17 | "AUTOEXEC.", "CHANGES", "COPYING", "CONFIG.", "CREDITS", "FAQ", "FILE_ID.DIZ", |
18 | "MAKEFILE", "READ.ME", "README", "TERMCAP", ""}; | 18 | "MAKEFILE", "READ.ME", "README", "TERMCAP", ""}; |
19 | 19 | ||
20 | void hpfs_decide_conv(struct inode *inode, unsigned char *name, unsigned len) | 20 | void hpfs_decide_conv(struct inode *inode, const unsigned char *name, unsigned len) |
21 | { | 21 | { |
22 | struct hpfs_inode_info *hpfs_inode = hpfs_i(inode); | 22 | struct hpfs_inode_info *hpfs_inode = hpfs_i(inode); |
23 | int i; | 23 | int i; |
@@ -71,7 +71,7 @@ static inline unsigned char locase(unsigned char *dir, unsigned char a) | |||
71 | return dir[a]; | 71 | return dir[a]; |
72 | } | 72 | } |
73 | 73 | ||
74 | int hpfs_chk_name(unsigned char *name, unsigned *len) | 74 | int hpfs_chk_name(const unsigned char *name, unsigned *len) |
75 | { | 75 | { |
76 | int i; | 76 | int i; |
77 | if (*len > 254) return -ENAMETOOLONG; | 77 | if (*len > 254) return -ENAMETOOLONG; |
@@ -83,10 +83,10 @@ int hpfs_chk_name(unsigned char *name, unsigned *len) | |||
83 | return 0; | 83 | return 0; |
84 | } | 84 | } |
85 | 85 | ||
86 | char *hpfs_translate_name(struct super_block *s, unsigned char *from, | 86 | unsigned char *hpfs_translate_name(struct super_block *s, unsigned char *from, |
87 | unsigned len, int lc, int lng) | 87 | unsigned len, int lc, int lng) |
88 | { | 88 | { |
89 | char *to; | 89 | unsigned char *to; |
90 | int i; | 90 | int i; |
91 | if (hpfs_sb(s)->sb_chk >= 2) if (hpfs_is_name_long(from, len) != lng) { | 91 | if (hpfs_sb(s)->sb_chk >= 2) if (hpfs_is_name_long(from, len) != lng) { |
92 | printk("HPFS: Long name flag mismatch - name "); | 92 | printk("HPFS: Long name flag mismatch - name "); |
@@ -103,8 +103,9 @@ char *hpfs_translate_name(struct super_block *s, unsigned char *from, | |||
103 | return to; | 103 | return to; |
104 | } | 104 | } |
105 | 105 | ||
106 | int hpfs_compare_names(struct super_block *s, unsigned char *n1, unsigned l1, | 106 | int hpfs_compare_names(struct super_block *s, |
107 | unsigned char *n2, unsigned l2, int last) | 107 | const unsigned char *n1, unsigned l1, |
108 | const unsigned char *n2, unsigned l2, int last) | ||
108 | { | 109 | { |
109 | unsigned l = l1 < l2 ? l1 : l2; | 110 | unsigned l = l1 < l2 ? l1 : l2; |
110 | unsigned i; | 111 | unsigned i; |
@@ -120,7 +121,7 @@ int hpfs_compare_names(struct super_block *s, unsigned char *n1, unsigned l1, | |||
120 | return 0; | 121 | return 0; |
121 | } | 122 | } |
122 | 123 | ||
123 | int hpfs_is_name_long(unsigned char *name, unsigned len) | 124 | int hpfs_is_name_long(const unsigned char *name, unsigned len) |
124 | { | 125 | { |
125 | int i,j; | 126 | int i,j; |
126 | for (i = 0; i < len && name[i] != '.'; i++) | 127 | for (i = 0; i < len && name[i] != '.'; i++) |
@@ -134,7 +135,7 @@ int hpfs_is_name_long(unsigned char *name, unsigned len) | |||
134 | 135 | ||
135 | /* OS/2 clears dots and spaces at the end of file name, so we have to */ | 136 | /* OS/2 clears dots and spaces at the end of file name, so we have to */ |
136 | 137 | ||
137 | void hpfs_adjust_length(unsigned char *name, unsigned *len) | 138 | void hpfs_adjust_length(const unsigned char *name, unsigned *len) |
138 | { | 139 | { |
139 | if (!*len) return; | 140 | if (!*len) return; |
140 | if (*len == 1 && name[0] == '.') return; | 141 | if (*len == 1 && name[0] == '.') return; |
diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c index 82b9c4ba9ed0..11c2b4080f65 100644 --- a/fs/hpfs/namei.c +++ b/fs/hpfs/namei.c | |||
@@ -11,7 +11,7 @@ | |||
11 | 11 | ||
12 | static int hpfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | 12 | static int hpfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) |
13 | { | 13 | { |
14 | const char *name = dentry->d_name.name; | 14 | const unsigned char *name = dentry->d_name.name; |
15 | unsigned len = dentry->d_name.len; | 15 | unsigned len = dentry->d_name.len; |
16 | struct quad_buffer_head qbh0; | 16 | struct quad_buffer_head qbh0; |
17 | struct buffer_head *bh; | 17 | struct buffer_head *bh; |
@@ -24,7 +24,7 @@ static int hpfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
24 | int r; | 24 | int r; |
25 | struct hpfs_dirent dee; | 25 | struct hpfs_dirent dee; |
26 | int err; | 26 | int err; |
27 | if ((err = hpfs_chk_name((char *)name, &len))) return err==-ENOENT ? -EINVAL : err; | 27 | if ((err = hpfs_chk_name(name, &len))) return err==-ENOENT ? -EINVAL : err; |
28 | lock_kernel(); | 28 | lock_kernel(); |
29 | err = -ENOSPC; | 29 | err = -ENOSPC; |
30 | fnode = hpfs_alloc_fnode(dir->i_sb, hpfs_i(dir)->i_dno, &fno, &bh); | 30 | fnode = hpfs_alloc_fnode(dir->i_sb, hpfs_i(dir)->i_dno, &fno, &bh); |
@@ -62,7 +62,7 @@ static int hpfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
62 | result->i_mode &= ~0222; | 62 | result->i_mode &= ~0222; |
63 | 63 | ||
64 | mutex_lock(&hpfs_i(dir)->i_mutex); | 64 | mutex_lock(&hpfs_i(dir)->i_mutex); |
65 | r = hpfs_add_dirent(dir, (char *)name, len, &dee, 0); | 65 | r = hpfs_add_dirent(dir, name, len, &dee, 0); |
66 | if (r == 1) | 66 | if (r == 1) |
67 | goto bail3; | 67 | goto bail3; |
68 | if (r == -1) { | 68 | if (r == -1) { |
@@ -121,7 +121,7 @@ bail: | |||
121 | 121 | ||
122 | static int hpfs_create(struct inode *dir, struct dentry *dentry, int mode, struct nameidata *nd) | 122 | static int hpfs_create(struct inode *dir, struct dentry *dentry, int mode, struct nameidata *nd) |
123 | { | 123 | { |
124 | const char *name = dentry->d_name.name; | 124 | const unsigned char *name = dentry->d_name.name; |
125 | unsigned len = dentry->d_name.len; | 125 | unsigned len = dentry->d_name.len; |
126 | struct inode *result = NULL; | 126 | struct inode *result = NULL; |
127 | struct buffer_head *bh; | 127 | struct buffer_head *bh; |
@@ -130,7 +130,7 @@ static int hpfs_create(struct inode *dir, struct dentry *dentry, int mode, struc | |||
130 | int r; | 130 | int r; |
131 | struct hpfs_dirent dee; | 131 | struct hpfs_dirent dee; |
132 | int err; | 132 | int err; |
133 | if ((err = hpfs_chk_name((char *)name, &len))) | 133 | if ((err = hpfs_chk_name(name, &len))) |
134 | return err==-ENOENT ? -EINVAL : err; | 134 | return err==-ENOENT ? -EINVAL : err; |
135 | lock_kernel(); | 135 | lock_kernel(); |
136 | err = -ENOSPC; | 136 | err = -ENOSPC; |
@@ -155,7 +155,7 @@ static int hpfs_create(struct inode *dir, struct dentry *dentry, int mode, struc | |||
155 | result->i_op = &hpfs_file_iops; | 155 | result->i_op = &hpfs_file_iops; |
156 | result->i_fop = &hpfs_file_ops; | 156 | result->i_fop = &hpfs_file_ops; |
157 | result->i_nlink = 1; | 157 | result->i_nlink = 1; |
158 | hpfs_decide_conv(result, (char *)name, len); | 158 | hpfs_decide_conv(result, name, len); |
159 | hpfs_i(result)->i_parent_dir = dir->i_ino; | 159 | hpfs_i(result)->i_parent_dir = dir->i_ino; |
160 | result->i_ctime.tv_sec = result->i_mtime.tv_sec = result->i_atime.tv_sec = local_to_gmt(dir->i_sb, dee.creation_date); | 160 | result->i_ctime.tv_sec = result->i_mtime.tv_sec = result->i_atime.tv_sec = local_to_gmt(dir->i_sb, dee.creation_date); |
161 | result->i_ctime.tv_nsec = 0; | 161 | result->i_ctime.tv_nsec = 0; |
@@ -170,7 +170,7 @@ static int hpfs_create(struct inode *dir, struct dentry *dentry, int mode, struc | |||
170 | hpfs_i(result)->mmu_private = 0; | 170 | hpfs_i(result)->mmu_private = 0; |
171 | 171 | ||
172 | mutex_lock(&hpfs_i(dir)->i_mutex); | 172 | mutex_lock(&hpfs_i(dir)->i_mutex); |
173 | r = hpfs_add_dirent(dir, (char *)name, len, &dee, 0); | 173 | r = hpfs_add_dirent(dir, name, len, &dee, 0); |
174 | if (r == 1) | 174 | if (r == 1) |
175 | goto bail2; | 175 | goto bail2; |
176 | if (r == -1) { | 176 | if (r == -1) { |
@@ -211,7 +211,7 @@ bail: | |||
211 | 211 | ||
212 | static int hpfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t rdev) | 212 | static int hpfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t rdev) |
213 | { | 213 | { |
214 | const char *name = dentry->d_name.name; | 214 | const unsigned char *name = dentry->d_name.name; |
215 | unsigned len = dentry->d_name.len; | 215 | unsigned len = dentry->d_name.len; |
216 | struct buffer_head *bh; | 216 | struct buffer_head *bh; |
217 | struct fnode *fnode; | 217 | struct fnode *fnode; |
@@ -220,7 +220,7 @@ static int hpfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t | |||
220 | struct hpfs_dirent dee; | 220 | struct hpfs_dirent dee; |
221 | struct inode *result = NULL; | 221 | struct inode *result = NULL; |
222 | int err; | 222 | int err; |
223 | if ((err = hpfs_chk_name((char *)name, &len))) return err==-ENOENT ? -EINVAL : err; | 223 | if ((err = hpfs_chk_name(name, &len))) return err==-ENOENT ? -EINVAL : err; |
224 | if (hpfs_sb(dir->i_sb)->sb_eas < 2) return -EPERM; | 224 | if (hpfs_sb(dir->i_sb)->sb_eas < 2) return -EPERM; |
225 | if (!new_valid_dev(rdev)) | 225 | if (!new_valid_dev(rdev)) |
226 | return -EINVAL; | 226 | return -EINVAL; |
@@ -256,7 +256,7 @@ static int hpfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t | |||
256 | init_special_inode(result, mode, rdev); | 256 | init_special_inode(result, mode, rdev); |
257 | 257 | ||
258 | mutex_lock(&hpfs_i(dir)->i_mutex); | 258 | mutex_lock(&hpfs_i(dir)->i_mutex); |
259 | r = hpfs_add_dirent(dir, (char *)name, len, &dee, 0); | 259 | r = hpfs_add_dirent(dir, name, len, &dee, 0); |
260 | if (r == 1) | 260 | if (r == 1) |
261 | goto bail2; | 261 | goto bail2; |
262 | if (r == -1) { | 262 | if (r == -1) { |
@@ -289,7 +289,7 @@ bail: | |||
289 | 289 | ||
290 | static int hpfs_symlink(struct inode *dir, struct dentry *dentry, const char *symlink) | 290 | static int hpfs_symlink(struct inode *dir, struct dentry *dentry, const char *symlink) |
291 | { | 291 | { |
292 | const char *name = dentry->d_name.name; | 292 | const unsigned char *name = dentry->d_name.name; |
293 | unsigned len = dentry->d_name.len; | 293 | unsigned len = dentry->d_name.len; |
294 | struct buffer_head *bh; | 294 | struct buffer_head *bh; |
295 | struct fnode *fnode; | 295 | struct fnode *fnode; |
@@ -298,7 +298,7 @@ static int hpfs_symlink(struct inode *dir, struct dentry *dentry, const char *sy | |||
298 | struct hpfs_dirent dee; | 298 | struct hpfs_dirent dee; |
299 | struct inode *result; | 299 | struct inode *result; |
300 | int err; | 300 | int err; |
301 | if ((err = hpfs_chk_name((char *)name, &len))) return err==-ENOENT ? -EINVAL : err; | 301 | if ((err = hpfs_chk_name(name, &len))) return err==-ENOENT ? -EINVAL : err; |
302 | lock_kernel(); | 302 | lock_kernel(); |
303 | if (hpfs_sb(dir->i_sb)->sb_eas < 2) { | 303 | if (hpfs_sb(dir->i_sb)->sb_eas < 2) { |
304 | unlock_kernel(); | 304 | unlock_kernel(); |
@@ -335,7 +335,7 @@ static int hpfs_symlink(struct inode *dir, struct dentry *dentry, const char *sy | |||
335 | result->i_data.a_ops = &hpfs_symlink_aops; | 335 | result->i_data.a_ops = &hpfs_symlink_aops; |
336 | 336 | ||
337 | mutex_lock(&hpfs_i(dir)->i_mutex); | 337 | mutex_lock(&hpfs_i(dir)->i_mutex); |
338 | r = hpfs_add_dirent(dir, (char *)name, len, &dee, 0); | 338 | r = hpfs_add_dirent(dir, name, len, &dee, 0); |
339 | if (r == 1) | 339 | if (r == 1) |
340 | goto bail2; | 340 | goto bail2; |
341 | if (r == -1) { | 341 | if (r == -1) { |
@@ -345,7 +345,7 @@ static int hpfs_symlink(struct inode *dir, struct dentry *dentry, const char *sy | |||
345 | fnode->len = len; | 345 | fnode->len = len; |
346 | memcpy(fnode->name, name, len > 15 ? 15 : len); | 346 | memcpy(fnode->name, name, len > 15 ? 15 : len); |
347 | fnode->up = dir->i_ino; | 347 | fnode->up = dir->i_ino; |
348 | hpfs_set_ea(result, fnode, "SYMLINK", (char *)symlink, strlen(symlink)); | 348 | hpfs_set_ea(result, fnode, "SYMLINK", symlink, strlen(symlink)); |
349 | mark_buffer_dirty(bh); | 349 | mark_buffer_dirty(bh); |
350 | brelse(bh); | 350 | brelse(bh); |
351 | 351 | ||
@@ -369,7 +369,7 @@ bail: | |||
369 | 369 | ||
370 | static int hpfs_unlink(struct inode *dir, struct dentry *dentry) | 370 | static int hpfs_unlink(struct inode *dir, struct dentry *dentry) |
371 | { | 371 | { |
372 | const char *name = dentry->d_name.name; | 372 | const unsigned char *name = dentry->d_name.name; |
373 | unsigned len = dentry->d_name.len; | 373 | unsigned len = dentry->d_name.len; |
374 | struct quad_buffer_head qbh; | 374 | struct quad_buffer_head qbh; |
375 | struct hpfs_dirent *de; | 375 | struct hpfs_dirent *de; |
@@ -381,12 +381,12 @@ static int hpfs_unlink(struct inode *dir, struct dentry *dentry) | |||
381 | int err; | 381 | int err; |
382 | 382 | ||
383 | lock_kernel(); | 383 | lock_kernel(); |
384 | hpfs_adjust_length((char *)name, &len); | 384 | hpfs_adjust_length(name, &len); |
385 | again: | 385 | again: |
386 | mutex_lock(&hpfs_i(inode)->i_parent_mutex); | 386 | mutex_lock(&hpfs_i(inode)->i_parent_mutex); |
387 | mutex_lock(&hpfs_i(dir)->i_mutex); | 387 | mutex_lock(&hpfs_i(dir)->i_mutex); |
388 | err = -ENOENT; | 388 | err = -ENOENT; |
389 | de = map_dirent(dir, hpfs_i(dir)->i_dno, (char *)name, len, &dno, &qbh); | 389 | de = map_dirent(dir, hpfs_i(dir)->i_dno, name, len, &dno, &qbh); |
390 | if (!de) | 390 | if (!de) |
391 | goto out; | 391 | goto out; |
392 | 392 | ||
@@ -413,22 +413,25 @@ again: | |||
413 | 413 | ||
414 | mutex_unlock(&hpfs_i(dir)->i_mutex); | 414 | mutex_unlock(&hpfs_i(dir)->i_mutex); |
415 | mutex_unlock(&hpfs_i(inode)->i_parent_mutex); | 415 | mutex_unlock(&hpfs_i(inode)->i_parent_mutex); |
416 | d_drop(dentry); | 416 | dentry_unhash(dentry); |
417 | spin_lock(&dentry->d_lock); | 417 | if (!d_unhashed(dentry)) { |
418 | if (atomic_read(&dentry->d_count) > 1 || | 418 | dput(dentry); |
419 | generic_permission(inode, MAY_WRITE, NULL) || | 419 | unlock_kernel(); |
420 | return -ENOSPC; | ||
421 | } | ||
422 | if (generic_permission(inode, MAY_WRITE, NULL) || | ||
420 | !S_ISREG(inode->i_mode) || | 423 | !S_ISREG(inode->i_mode) || |
421 | get_write_access(inode)) { | 424 | get_write_access(inode)) { |
422 | spin_unlock(&dentry->d_lock); | ||
423 | d_rehash(dentry); | 425 | d_rehash(dentry); |
426 | dput(dentry); | ||
424 | } else { | 427 | } else { |
425 | struct iattr newattrs; | 428 | struct iattr newattrs; |
426 | spin_unlock(&dentry->d_lock); | ||
427 | /*printk("HPFS: truncating file before delete.\n");*/ | 429 | /*printk("HPFS: truncating file before delete.\n");*/ |
428 | newattrs.ia_size = 0; | 430 | newattrs.ia_size = 0; |
429 | newattrs.ia_valid = ATTR_SIZE | ATTR_CTIME; | 431 | newattrs.ia_valid = ATTR_SIZE | ATTR_CTIME; |
430 | err = notify_change(dentry, &newattrs); | 432 | err = notify_change(dentry, &newattrs); |
431 | put_write_access(inode); | 433 | put_write_access(inode); |
434 | dput(dentry); | ||
432 | if (!err) | 435 | if (!err) |
433 | goto again; | 436 | goto again; |
434 | } | 437 | } |
@@ -451,7 +454,7 @@ out: | |||
451 | 454 | ||
452 | static int hpfs_rmdir(struct inode *dir, struct dentry *dentry) | 455 | static int hpfs_rmdir(struct inode *dir, struct dentry *dentry) |
453 | { | 456 | { |
454 | const char *name = dentry->d_name.name; | 457 | const unsigned char *name = dentry->d_name.name; |
455 | unsigned len = dentry->d_name.len; | 458 | unsigned len = dentry->d_name.len; |
456 | struct quad_buffer_head qbh; | 459 | struct quad_buffer_head qbh; |
457 | struct hpfs_dirent *de; | 460 | struct hpfs_dirent *de; |
@@ -462,12 +465,12 @@ static int hpfs_rmdir(struct inode *dir, struct dentry *dentry) | |||
462 | int err; | 465 | int err; |
463 | int r; | 466 | int r; |
464 | 467 | ||
465 | hpfs_adjust_length((char *)name, &len); | 468 | hpfs_adjust_length(name, &len); |
466 | lock_kernel(); | 469 | lock_kernel(); |
467 | mutex_lock(&hpfs_i(inode)->i_parent_mutex); | 470 | mutex_lock(&hpfs_i(inode)->i_parent_mutex); |
468 | mutex_lock(&hpfs_i(dir)->i_mutex); | 471 | mutex_lock(&hpfs_i(dir)->i_mutex); |
469 | err = -ENOENT; | 472 | err = -ENOENT; |
470 | de = map_dirent(dir, hpfs_i(dir)->i_dno, (char *)name, len, &dno, &qbh); | 473 | de = map_dirent(dir, hpfs_i(dir)->i_dno, name, len, &dno, &qbh); |
471 | if (!de) | 474 | if (!de) |
472 | goto out; | 475 | goto out; |
473 | 476 | ||
@@ -546,10 +549,10 @@ const struct address_space_operations hpfs_symlink_aops = { | |||
546 | static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, | 549 | static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, |
547 | struct inode *new_dir, struct dentry *new_dentry) | 550 | struct inode *new_dir, struct dentry *new_dentry) |
548 | { | 551 | { |
549 | char *old_name = (char *)old_dentry->d_name.name; | 552 | const unsigned char *old_name = old_dentry->d_name.name; |
550 | int old_len = old_dentry->d_name.len; | 553 | unsigned old_len = old_dentry->d_name.len; |
551 | char *new_name = (char *)new_dentry->d_name.name; | 554 | const unsigned char *new_name = new_dentry->d_name.name; |
552 | int new_len = new_dentry->d_name.len; | 555 | unsigned new_len = new_dentry->d_name.len; |
553 | struct inode *i = old_dentry->d_inode; | 556 | struct inode *i = old_dentry->d_inode; |
554 | struct inode *new_inode = new_dentry->d_inode; | 557 | struct inode *new_inode = new_dentry->d_inode; |
555 | struct quad_buffer_head qbh, qbh1; | 558 | struct quad_buffer_head qbh, qbh1; |
@@ -560,9 +563,9 @@ static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
560 | struct buffer_head *bh; | 563 | struct buffer_head *bh; |
561 | struct fnode *fnode; | 564 | struct fnode *fnode; |
562 | int err; | 565 | int err; |
563 | if ((err = hpfs_chk_name((char *)new_name, &new_len))) return err; | 566 | if ((err = hpfs_chk_name(new_name, &new_len))) return err; |
564 | err = 0; | 567 | err = 0; |
565 | hpfs_adjust_length((char *)old_name, &old_len); | 568 | hpfs_adjust_length(old_name, &old_len); |
566 | 569 | ||
567 | lock_kernel(); | 570 | lock_kernel(); |
568 | /* order doesn't matter, due to VFS exclusion */ | 571 | /* order doesn't matter, due to VFS exclusion */ |
@@ -579,7 +582,7 @@ static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
579 | goto end1; | 582 | goto end1; |
580 | } | 583 | } |
581 | 584 | ||
582 | if (!(dep = map_dirent(old_dir, hpfs_i(old_dir)->i_dno, (char *)old_name, old_len, &dno, &qbh))) { | 585 | if (!(dep = map_dirent(old_dir, hpfs_i(old_dir)->i_dno, old_name, old_len, &dno, &qbh))) { |
583 | hpfs_error(i->i_sb, "lookup succeeded but map dirent failed"); | 586 | hpfs_error(i->i_sb, "lookup succeeded but map dirent failed"); |
584 | err = -ENOENT; | 587 | err = -ENOENT; |
585 | goto end1; | 588 | goto end1; |
@@ -590,7 +593,7 @@ static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
590 | if (new_inode) { | 593 | if (new_inode) { |
591 | int r; | 594 | int r; |
592 | if ((r = hpfs_remove_dirent(old_dir, dno, dep, &qbh, 1)) != 2) { | 595 | if ((r = hpfs_remove_dirent(old_dir, dno, dep, &qbh, 1)) != 2) { |
593 | if ((nde = map_dirent(new_dir, hpfs_i(new_dir)->i_dno, (char *)new_name, new_len, NULL, &qbh1))) { | 596 | if ((nde = map_dirent(new_dir, hpfs_i(new_dir)->i_dno, new_name, new_len, NULL, &qbh1))) { |
594 | clear_nlink(new_inode); | 597 | clear_nlink(new_inode); |
595 | copy_de(nde, &de); | 598 | copy_de(nde, &de); |
596 | memcpy(nde->name, new_name, new_len); | 599 | memcpy(nde->name, new_name, new_len); |
@@ -618,7 +621,7 @@ static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
618 | } | 621 | } |
619 | 622 | ||
620 | if (new_dir == old_dir) | 623 | if (new_dir == old_dir) |
621 | if (!(dep = map_dirent(old_dir, hpfs_i(old_dir)->i_dno, (char *)old_name, old_len, &dno, &qbh))) { | 624 | if (!(dep = map_dirent(old_dir, hpfs_i(old_dir)->i_dno, old_name, old_len, &dno, &qbh))) { |
622 | hpfs_unlock_creation(i->i_sb); | 625 | hpfs_unlock_creation(i->i_sb); |
623 | hpfs_error(i->i_sb, "lookup succeeded but map dirent failed at #2"); | 626 | hpfs_error(i->i_sb, "lookup succeeded but map dirent failed at #2"); |
624 | err = -ENOENT; | 627 | err = -ENOENT; |
@@ -648,7 +651,7 @@ static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
648 | brelse(bh); | 651 | brelse(bh); |
649 | } | 652 | } |
650 | hpfs_i(i)->i_conv = hpfs_sb(i->i_sb)->sb_conv; | 653 | hpfs_i(i)->i_conv = hpfs_sb(i->i_sb)->sb_conv; |
651 | hpfs_decide_conv(i, (char *)new_name, new_len); | 654 | hpfs_decide_conv(i, new_name, new_len); |
652 | end1: | 655 | end1: |
653 | if (old_dir != new_dir) | 656 | if (old_dir != new_dir) |
654 | mutex_unlock(&hpfs_i(new_dir)->i_mutex); | 657 | mutex_unlock(&hpfs_i(new_dir)->i_mutex); |
diff --git a/fs/hppfs/hppfs.c b/fs/hppfs/hppfs.c index 7239efc690d8..2e4dfa8593da 100644 --- a/fs/hppfs/hppfs.c +++ b/fs/hppfs/hppfs.c | |||
@@ -718,7 +718,7 @@ static int hppfs_fill_super(struct super_block *sb, void *d, int silent) | |||
718 | struct vfsmount *proc_mnt; | 718 | struct vfsmount *proc_mnt; |
719 | int err = -ENOENT; | 719 | int err = -ENOENT; |
720 | 720 | ||
721 | proc_mnt = do_kern_mount("proc", 0, "proc", NULL); | 721 | proc_mnt = mntget(current->nsproxy->pid_ns->proc_mnt); |
722 | if (IS_ERR(proc_mnt)) | 722 | if (IS_ERR(proc_mnt)) |
723 | goto out; | 723 | goto out; |
724 | 724 | ||
diff --git a/fs/inode.c b/fs/inode.c index 03dfeb2e3928..407bf392e20a 100644 --- a/fs/inode.c +++ b/fs/inode.c | |||
@@ -8,7 +8,6 @@ | |||
8 | #include <linux/mm.h> | 8 | #include <linux/mm.h> |
9 | #include <linux/dcache.h> | 9 | #include <linux/dcache.h> |
10 | #include <linux/init.h> | 10 | #include <linux/init.h> |
11 | #include <linux/quotaops.h> | ||
12 | #include <linux/slab.h> | 11 | #include <linux/slab.h> |
13 | #include <linux/writeback.h> | 12 | #include <linux/writeback.h> |
14 | #include <linux/module.h> | 13 | #include <linux/module.h> |
@@ -314,7 +313,6 @@ void clear_inode(struct inode *inode) | |||
314 | BUG_ON(!(inode->i_state & I_FREEING)); | 313 | BUG_ON(!(inode->i_state & I_FREEING)); |
315 | BUG_ON(inode->i_state & I_CLEAR); | 314 | BUG_ON(inode->i_state & I_CLEAR); |
316 | inode_sync_wait(inode); | 315 | inode_sync_wait(inode); |
317 | vfs_dq_drop(inode); | ||
318 | if (inode->i_sb->s_op->clear_inode) | 316 | if (inode->i_sb->s_op->clear_inode) |
319 | inode->i_sb->s_op->clear_inode(inode); | 317 | inode->i_sb->s_op->clear_inode(inode); |
320 | if (S_ISBLK(inode->i_mode) && inode->i_bdev) | 318 | if (S_ISBLK(inode->i_mode) && inode->i_bdev) |
@@ -1211,8 +1209,6 @@ void generic_delete_inode(struct inode *inode) | |||
1211 | 1209 | ||
1212 | if (op->delete_inode) { | 1210 | if (op->delete_inode) { |
1213 | void (*delete)(struct inode *) = op->delete_inode; | 1211 | void (*delete)(struct inode *) = op->delete_inode; |
1214 | if (!is_bad_inode(inode)) | ||
1215 | vfs_dq_init(inode); | ||
1216 | /* Filesystems implementing their own | 1212 | /* Filesystems implementing their own |
1217 | * s_op->delete_inode are required to call | 1213 | * s_op->delete_inode are required to call |
1218 | * truncate_inode_pages and clear_inode() | 1214 | * truncate_inode_pages and clear_inode() |
diff --git a/fs/internal.h b/fs/internal.h index e96a1667d749..8a03a5447bdf 100644 --- a/fs/internal.h +++ b/fs/internal.h | |||
@@ -70,6 +70,8 @@ extern struct vfsmount *copy_tree(struct vfsmount *, struct dentry *, int); | |||
70 | 70 | ||
71 | extern void __init mnt_init(void); | 71 | extern void __init mnt_init(void); |
72 | 72 | ||
73 | extern spinlock_t vfsmount_lock; | ||
74 | |||
73 | /* | 75 | /* |
74 | * fs_struct.c | 76 | * fs_struct.c |
75 | */ | 77 | */ |
diff --git a/fs/jbd/commit.c b/fs/jbd/commit.c index 4bd882548c45..2c90e3ef625f 100644 --- a/fs/jbd/commit.c +++ b/fs/jbd/commit.c | |||
@@ -862,12 +862,12 @@ restart_loop: | |||
862 | /* A buffer which has been freed while still being | 862 | /* A buffer which has been freed while still being |
863 | * journaled by a previous transaction may end up still | 863 | * journaled by a previous transaction may end up still |
864 | * being dirty here, but we want to avoid writing back | 864 | * being dirty here, but we want to avoid writing back |
865 | * that buffer in the future now that the last use has | 865 | * that buffer in the future after the "add to orphan" |
866 | * been committed. That's not only a performance gain, | 866 | * operation been committed, That's not only a performance |
867 | * it also stops aliasing problems if the buffer is left | 867 | * gain, it also stops aliasing problems if the buffer is |
868 | * behind for writeback and gets reallocated for another | 868 | * left behind for writeback and gets reallocated for another |
869 | * use in a different page. */ | 869 | * use in a different page. */ |
870 | if (buffer_freed(bh)) { | 870 | if (buffer_freed(bh) && !jh->b_next_transaction) { |
871 | clear_buffer_freed(bh); | 871 | clear_buffer_freed(bh); |
872 | clear_buffer_jbddirty(bh); | 872 | clear_buffer_jbddirty(bh); |
873 | } | 873 | } |
diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c index 006f9ad838a2..99e9fea11077 100644 --- a/fs/jbd/transaction.c +++ b/fs/jbd/transaction.c | |||
@@ -1864,6 +1864,21 @@ static int journal_unmap_buffer(journal_t *journal, struct buffer_head *bh) | |||
1864 | if (!jh) | 1864 | if (!jh) |
1865 | goto zap_buffer_no_jh; | 1865 | goto zap_buffer_no_jh; |
1866 | 1866 | ||
1867 | /* | ||
1868 | * We cannot remove the buffer from checkpoint lists until the | ||
1869 | * transaction adding inode to orphan list (let's call it T) | ||
1870 | * is committed. Otherwise if the transaction changing the | ||
1871 | * buffer would be cleaned from the journal before T is | ||
1872 | * committed, a crash will cause that the correct contents of | ||
1873 | * the buffer will be lost. On the other hand we have to | ||
1874 | * clear the buffer dirty bit at latest at the moment when the | ||
1875 | * transaction marking the buffer as freed in the filesystem | ||
1876 | * structures is committed because from that moment on the | ||
1877 | * buffer can be reallocated and used by a different page. | ||
1878 | * Since the block hasn't been freed yet but the inode has | ||
1879 | * already been added to orphan list, it is safe for us to add | ||
1880 | * the buffer to BJ_Forget list of the newest transaction. | ||
1881 | */ | ||
1867 | transaction = jh->b_transaction; | 1882 | transaction = jh->b_transaction; |
1868 | if (transaction == NULL) { | 1883 | if (transaction == NULL) { |
1869 | /* First case: not on any transaction. If it | 1884 | /* First case: not on any transaction. If it |
@@ -1929,16 +1944,15 @@ static int journal_unmap_buffer(journal_t *journal, struct buffer_head *bh) | |||
1929 | goto zap_buffer; | 1944 | goto zap_buffer; |
1930 | } | 1945 | } |
1931 | /* | 1946 | /* |
1932 | * If it is committing, we simply cannot touch it. We | 1947 | * The buffer is committing, we simply cannot touch |
1933 | * can remove it's next_transaction pointer from the | 1948 | * it. So we just set j_next_transaction to the |
1934 | * running transaction if that is set, but nothing | 1949 | * running transaction (if there is one) and mark |
1935 | * else. */ | 1950 | * buffer as freed so that commit code knows it should |
1951 | * clear dirty bits when it is done with the buffer. | ||
1952 | */ | ||
1936 | set_buffer_freed(bh); | 1953 | set_buffer_freed(bh); |
1937 | if (jh->b_next_transaction) { | 1954 | if (journal->j_running_transaction && buffer_jbddirty(bh)) |
1938 | J_ASSERT(jh->b_next_transaction == | 1955 | jh->b_next_transaction = journal->j_running_transaction; |
1939 | journal->j_running_transaction); | ||
1940 | jh->b_next_transaction = NULL; | ||
1941 | } | ||
1942 | journal_put_journal_head(jh); | 1956 | journal_put_journal_head(jh); |
1943 | spin_unlock(&journal->j_list_lock); | 1957 | spin_unlock(&journal->j_list_lock); |
1944 | jbd_unlock_bh_state(bh); | 1958 | jbd_unlock_bh_state(bh); |
@@ -2120,7 +2134,7 @@ void journal_file_buffer(struct journal_head *jh, | |||
2120 | */ | 2134 | */ |
2121 | void __journal_refile_buffer(struct journal_head *jh) | 2135 | void __journal_refile_buffer(struct journal_head *jh) |
2122 | { | 2136 | { |
2123 | int was_dirty; | 2137 | int was_dirty, jlist; |
2124 | struct buffer_head *bh = jh2bh(jh); | 2138 | struct buffer_head *bh = jh2bh(jh); |
2125 | 2139 | ||
2126 | J_ASSERT_JH(jh, jbd_is_locked_bh_state(bh)); | 2140 | J_ASSERT_JH(jh, jbd_is_locked_bh_state(bh)); |
@@ -2142,8 +2156,13 @@ void __journal_refile_buffer(struct journal_head *jh) | |||
2142 | __journal_temp_unlink_buffer(jh); | 2156 | __journal_temp_unlink_buffer(jh); |
2143 | jh->b_transaction = jh->b_next_transaction; | 2157 | jh->b_transaction = jh->b_next_transaction; |
2144 | jh->b_next_transaction = NULL; | 2158 | jh->b_next_transaction = NULL; |
2145 | __journal_file_buffer(jh, jh->b_transaction, | 2159 | if (buffer_freed(bh)) |
2146 | jh->b_modified ? BJ_Metadata : BJ_Reserved); | 2160 | jlist = BJ_Forget; |
2161 | else if (jh->b_modified) | ||
2162 | jlist = BJ_Metadata; | ||
2163 | else | ||
2164 | jlist = BJ_Reserved; | ||
2165 | __journal_file_buffer(jh, jh->b_transaction, jlist); | ||
2147 | J_ASSERT_JH(jh, jh->b_transaction->t_state == T_RUNNING); | 2166 | J_ASSERT_JH(jh, jh->b_transaction->t_state == T_RUNNING); |
2148 | 2167 | ||
2149 | if (was_dirty) | 2168 | if (was_dirty) |
diff --git a/fs/jbd2/checkpoint.c b/fs/jbd2/checkpoint.c index 886849370950..30beb11ef928 100644 --- a/fs/jbd2/checkpoint.c +++ b/fs/jbd2/checkpoint.c | |||
@@ -507,6 +507,7 @@ int jbd2_cleanup_journal_tail(journal_t *journal) | |||
507 | if (blocknr < journal->j_tail) | 507 | if (blocknr < journal->j_tail) |
508 | freed = freed + journal->j_last - journal->j_first; | 508 | freed = freed + journal->j_last - journal->j_first; |
509 | 509 | ||
510 | trace_jbd2_cleanup_journal_tail(journal, first_tid, blocknr, freed); | ||
510 | jbd_debug(1, | 511 | jbd_debug(1, |
511 | "Cleaning journal tail from %d to %d (offset %lu), " | 512 | "Cleaning journal tail from %d to %d (offset %lu), " |
512 | "freeing %lu\n", | 513 | "freeing %lu\n", |
diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c index 1bc74b6f26d2..671da7fb7ffd 100644 --- a/fs/jbd2/commit.c +++ b/fs/jbd2/commit.c | |||
@@ -883,8 +883,7 @@ restart_loop: | |||
883 | spin_unlock(&journal->j_list_lock); | 883 | spin_unlock(&journal->j_list_lock); |
884 | bh = jh2bh(jh); | 884 | bh = jh2bh(jh); |
885 | jbd_lock_bh_state(bh); | 885 | jbd_lock_bh_state(bh); |
886 | J_ASSERT_JH(jh, jh->b_transaction == commit_transaction || | 886 | J_ASSERT_JH(jh, jh->b_transaction == commit_transaction); |
887 | jh->b_transaction == journal->j_running_transaction); | ||
888 | 887 | ||
889 | /* | 888 | /* |
890 | * If there is undo-protected committed data against | 889 | * If there is undo-protected committed data against |
@@ -930,12 +929,12 @@ restart_loop: | |||
930 | /* A buffer which has been freed while still being | 929 | /* A buffer which has been freed while still being |
931 | * journaled by a previous transaction may end up still | 930 | * journaled by a previous transaction may end up still |
932 | * being dirty here, but we want to avoid writing back | 931 | * being dirty here, but we want to avoid writing back |
933 | * that buffer in the future now that the last use has | 932 | * that buffer in the future after the "add to orphan" |
934 | * been committed. That's not only a performance gain, | 933 | * operation been committed, That's not only a performance |
935 | * it also stops aliasing problems if the buffer is left | 934 | * gain, it also stops aliasing problems if the buffer is |
936 | * behind for writeback and gets reallocated for another | 935 | * left behind for writeback and gets reallocated for another |
937 | * use in a different page. */ | 936 | * use in a different page. */ |
938 | if (buffer_freed(bh)) { | 937 | if (buffer_freed(bh) && !jh->b_next_transaction) { |
939 | clear_buffer_freed(bh); | 938 | clear_buffer_freed(bh); |
940 | clear_buffer_jbddirty(bh); | 939 | clear_buffer_jbddirty(bh); |
941 | } | 940 | } |
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index ac0d027595d0..c03d4dce4d76 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c | |||
@@ -39,6 +39,8 @@ | |||
39 | #include <linux/seq_file.h> | 39 | #include <linux/seq_file.h> |
40 | #include <linux/math64.h> | 40 | #include <linux/math64.h> |
41 | #include <linux/hash.h> | 41 | #include <linux/hash.h> |
42 | #include <linux/log2.h> | ||
43 | #include <linux/vmalloc.h> | ||
42 | 44 | ||
43 | #define CREATE_TRACE_POINTS | 45 | #define CREATE_TRACE_POINTS |
44 | #include <trace/events/jbd2.h> | 46 | #include <trace/events/jbd2.h> |
@@ -93,6 +95,7 @@ EXPORT_SYMBOL(jbd2_journal_begin_ordered_truncate); | |||
93 | 95 | ||
94 | static int journal_convert_superblock_v1(journal_t *, journal_superblock_t *); | 96 | static int journal_convert_superblock_v1(journal_t *, journal_superblock_t *); |
95 | static void __journal_abort_soft (journal_t *journal, int errno); | 97 | static void __journal_abort_soft (journal_t *journal, int errno); |
98 | static int jbd2_journal_create_slab(size_t slab_size); | ||
96 | 99 | ||
97 | /* | 100 | /* |
98 | * Helper function used to manage commit timeouts | 101 | * Helper function used to manage commit timeouts |
@@ -1248,6 +1251,13 @@ int jbd2_journal_load(journal_t *journal) | |||
1248 | } | 1251 | } |
1249 | } | 1252 | } |
1250 | 1253 | ||
1254 | /* | ||
1255 | * Create a slab for this blocksize | ||
1256 | */ | ||
1257 | err = jbd2_journal_create_slab(be32_to_cpu(sb->s_blocksize)); | ||
1258 | if (err) | ||
1259 | return err; | ||
1260 | |||
1251 | /* Let the recovery code check whether it needs to recover any | 1261 | /* Let the recovery code check whether it needs to recover any |
1252 | * data from the journal. */ | 1262 | * data from the journal. */ |
1253 | if (jbd2_journal_recover(journal)) | 1263 | if (jbd2_journal_recover(journal)) |
@@ -1807,6 +1817,127 @@ size_t journal_tag_bytes(journal_t *journal) | |||
1807 | } | 1817 | } |
1808 | 1818 | ||
1809 | /* | 1819 | /* |
1820 | * JBD memory management | ||
1821 | * | ||
1822 | * These functions are used to allocate block-sized chunks of memory | ||
1823 | * used for making copies of buffer_head data. Very often it will be | ||
1824 | * page-sized chunks of data, but sometimes it will be in | ||
1825 | * sub-page-size chunks. (For example, 16k pages on Power systems | ||
1826 | * with a 4k block file system.) For blocks smaller than a page, we | ||
1827 | * use a SLAB allocator. There are slab caches for each block size, | ||
1828 | * which are allocated at mount time, if necessary, and we only free | ||
1829 | * (all of) the slab caches when/if the jbd2 module is unloaded. For | ||
1830 | * this reason we don't need to a mutex to protect access to | ||
1831 | * jbd2_slab[] allocating or releasing memory; only in | ||
1832 | * jbd2_journal_create_slab(). | ||
1833 | */ | ||
1834 | #define JBD2_MAX_SLABS 8 | ||
1835 | static struct kmem_cache *jbd2_slab[JBD2_MAX_SLABS]; | ||
1836 | static DECLARE_MUTEX(jbd2_slab_create_sem); | ||
1837 | |||
1838 | static const char *jbd2_slab_names[JBD2_MAX_SLABS] = { | ||
1839 | "jbd2_1k", "jbd2_2k", "jbd2_4k", "jbd2_8k", | ||
1840 | "jbd2_16k", "jbd2_32k", "jbd2_64k", "jbd2_128k" | ||
1841 | }; | ||
1842 | |||
1843 | |||
1844 | static void jbd2_journal_destroy_slabs(void) | ||
1845 | { | ||
1846 | int i; | ||
1847 | |||
1848 | for (i = 0; i < JBD2_MAX_SLABS; i++) { | ||
1849 | if (jbd2_slab[i]) | ||
1850 | kmem_cache_destroy(jbd2_slab[i]); | ||
1851 | jbd2_slab[i] = NULL; | ||
1852 | } | ||
1853 | } | ||
1854 | |||
1855 | static int jbd2_journal_create_slab(size_t size) | ||
1856 | { | ||
1857 | int i = order_base_2(size) - 10; | ||
1858 | size_t slab_size; | ||
1859 | |||
1860 | if (size == PAGE_SIZE) | ||
1861 | return 0; | ||
1862 | |||
1863 | if (i >= JBD2_MAX_SLABS) | ||
1864 | return -EINVAL; | ||
1865 | |||
1866 | if (unlikely(i < 0)) | ||
1867 | i = 0; | ||
1868 | down(&jbd2_slab_create_sem); | ||
1869 | if (jbd2_slab[i]) { | ||
1870 | up(&jbd2_slab_create_sem); | ||
1871 | return 0; /* Already created */ | ||
1872 | } | ||
1873 | |||
1874 | slab_size = 1 << (i+10); | ||
1875 | jbd2_slab[i] = kmem_cache_create(jbd2_slab_names[i], slab_size, | ||
1876 | slab_size, 0, NULL); | ||
1877 | up(&jbd2_slab_create_sem); | ||
1878 | if (!jbd2_slab[i]) { | ||
1879 | printk(KERN_EMERG "JBD2: no memory for jbd2_slab cache\n"); | ||
1880 | return -ENOMEM; | ||
1881 | } | ||
1882 | return 0; | ||
1883 | } | ||
1884 | |||
1885 | static struct kmem_cache *get_slab(size_t size) | ||
1886 | { | ||
1887 | int i = order_base_2(size) - 10; | ||
1888 | |||
1889 | BUG_ON(i >= JBD2_MAX_SLABS); | ||
1890 | if (unlikely(i < 0)) | ||
1891 | i = 0; | ||
1892 | BUG_ON(jbd2_slab[i] == 0); | ||
1893 | return jbd2_slab[i]; | ||
1894 | } | ||
1895 | |||
1896 | void *jbd2_alloc(size_t size, gfp_t flags) | ||
1897 | { | ||
1898 | void *ptr; | ||
1899 | |||
1900 | BUG_ON(size & (size-1)); /* Must be a power of 2 */ | ||
1901 | |||
1902 | flags |= __GFP_REPEAT; | ||
1903 | if (size == PAGE_SIZE) | ||
1904 | ptr = (void *)__get_free_pages(flags, 0); | ||
1905 | else if (size > PAGE_SIZE) { | ||
1906 | int order = get_order(size); | ||
1907 | |||
1908 | if (order < 3) | ||
1909 | ptr = (void *)__get_free_pages(flags, order); | ||
1910 | else | ||
1911 | ptr = vmalloc(size); | ||
1912 | } else | ||
1913 | ptr = kmem_cache_alloc(get_slab(size), flags); | ||
1914 | |||
1915 | /* Check alignment; SLUB has gotten this wrong in the past, | ||
1916 | * and this can lead to user data corruption! */ | ||
1917 | BUG_ON(((unsigned long) ptr) & (size-1)); | ||
1918 | |||
1919 | return ptr; | ||
1920 | } | ||
1921 | |||
1922 | void jbd2_free(void *ptr, size_t size) | ||
1923 | { | ||
1924 | if (size == PAGE_SIZE) { | ||
1925 | free_pages((unsigned long)ptr, 0); | ||
1926 | return; | ||
1927 | } | ||
1928 | if (size > PAGE_SIZE) { | ||
1929 | int order = get_order(size); | ||
1930 | |||
1931 | if (order < 3) | ||
1932 | free_pages((unsigned long)ptr, order); | ||
1933 | else | ||
1934 | vfree(ptr); | ||
1935 | return; | ||
1936 | } | ||
1937 | kmem_cache_free(get_slab(size), ptr); | ||
1938 | }; | ||
1939 | |||
1940 | /* | ||
1810 | * Journal_head storage management | 1941 | * Journal_head storage management |
1811 | */ | 1942 | */ |
1812 | static struct kmem_cache *jbd2_journal_head_cache; | 1943 | static struct kmem_cache *jbd2_journal_head_cache; |
@@ -2204,6 +2335,7 @@ static void jbd2_journal_destroy_caches(void) | |||
2204 | jbd2_journal_destroy_revoke_caches(); | 2335 | jbd2_journal_destroy_revoke_caches(); |
2205 | jbd2_journal_destroy_jbd2_journal_head_cache(); | 2336 | jbd2_journal_destroy_jbd2_journal_head_cache(); |
2206 | jbd2_journal_destroy_handle_cache(); | 2337 | jbd2_journal_destroy_handle_cache(); |
2338 | jbd2_journal_destroy_slabs(); | ||
2207 | } | 2339 | } |
2208 | 2340 | ||
2209 | static int __init journal_init(void) | 2341 | static int __init journal_init(void) |
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c index a0512700542f..bfc70f57900f 100644 --- a/fs/jbd2/transaction.c +++ b/fs/jbd2/transaction.c | |||
@@ -1727,6 +1727,21 @@ static int journal_unmap_buffer(journal_t *journal, struct buffer_head *bh) | |||
1727 | if (!jh) | 1727 | if (!jh) |
1728 | goto zap_buffer_no_jh; | 1728 | goto zap_buffer_no_jh; |
1729 | 1729 | ||
1730 | /* | ||
1731 | * We cannot remove the buffer from checkpoint lists until the | ||
1732 | * transaction adding inode to orphan list (let's call it T) | ||
1733 | * is committed. Otherwise if the transaction changing the | ||
1734 | * buffer would be cleaned from the journal before T is | ||
1735 | * committed, a crash will cause that the correct contents of | ||
1736 | * the buffer will be lost. On the other hand we have to | ||
1737 | * clear the buffer dirty bit at latest at the moment when the | ||
1738 | * transaction marking the buffer as freed in the filesystem | ||
1739 | * structures is committed because from that moment on the | ||
1740 | * buffer can be reallocated and used by a different page. | ||
1741 | * Since the block hasn't been freed yet but the inode has | ||
1742 | * already been added to orphan list, it is safe for us to add | ||
1743 | * the buffer to BJ_Forget list of the newest transaction. | ||
1744 | */ | ||
1730 | transaction = jh->b_transaction; | 1745 | transaction = jh->b_transaction; |
1731 | if (transaction == NULL) { | 1746 | if (transaction == NULL) { |
1732 | /* First case: not on any transaction. If it | 1747 | /* First case: not on any transaction. If it |
@@ -1783,16 +1798,15 @@ static int journal_unmap_buffer(journal_t *journal, struct buffer_head *bh) | |||
1783 | } else if (transaction == journal->j_committing_transaction) { | 1798 | } else if (transaction == journal->j_committing_transaction) { |
1784 | JBUFFER_TRACE(jh, "on committing transaction"); | 1799 | JBUFFER_TRACE(jh, "on committing transaction"); |
1785 | /* | 1800 | /* |
1786 | * If it is committing, we simply cannot touch it. We | 1801 | * The buffer is committing, we simply cannot touch |
1787 | * can remove it's next_transaction pointer from the | 1802 | * it. So we just set j_next_transaction to the |
1788 | * running transaction if that is set, but nothing | 1803 | * running transaction (if there is one) and mark |
1789 | * else. */ | 1804 | * buffer as freed so that commit code knows it should |
1805 | * clear dirty bits when it is done with the buffer. | ||
1806 | */ | ||
1790 | set_buffer_freed(bh); | 1807 | set_buffer_freed(bh); |
1791 | if (jh->b_next_transaction) { | 1808 | if (journal->j_running_transaction && buffer_jbddirty(bh)) |
1792 | J_ASSERT(jh->b_next_transaction == | 1809 | jh->b_next_transaction = journal->j_running_transaction; |
1793 | journal->j_running_transaction); | ||
1794 | jh->b_next_transaction = NULL; | ||
1795 | } | ||
1796 | jbd2_journal_put_journal_head(jh); | 1810 | jbd2_journal_put_journal_head(jh); |
1797 | spin_unlock(&journal->j_list_lock); | 1811 | spin_unlock(&journal->j_list_lock); |
1798 | jbd_unlock_bh_state(bh); | 1812 | jbd_unlock_bh_state(bh); |
@@ -1969,7 +1983,7 @@ void jbd2_journal_file_buffer(struct journal_head *jh, | |||
1969 | */ | 1983 | */ |
1970 | void __jbd2_journal_refile_buffer(struct journal_head *jh) | 1984 | void __jbd2_journal_refile_buffer(struct journal_head *jh) |
1971 | { | 1985 | { |
1972 | int was_dirty; | 1986 | int was_dirty, jlist; |
1973 | struct buffer_head *bh = jh2bh(jh); | 1987 | struct buffer_head *bh = jh2bh(jh); |
1974 | 1988 | ||
1975 | J_ASSERT_JH(jh, jbd_is_locked_bh_state(bh)); | 1989 | J_ASSERT_JH(jh, jbd_is_locked_bh_state(bh)); |
@@ -1991,8 +2005,13 @@ void __jbd2_journal_refile_buffer(struct journal_head *jh) | |||
1991 | __jbd2_journal_temp_unlink_buffer(jh); | 2005 | __jbd2_journal_temp_unlink_buffer(jh); |
1992 | jh->b_transaction = jh->b_next_transaction; | 2006 | jh->b_transaction = jh->b_next_transaction; |
1993 | jh->b_next_transaction = NULL; | 2007 | jh->b_next_transaction = NULL; |
1994 | __jbd2_journal_file_buffer(jh, jh->b_transaction, | 2008 | if (buffer_freed(bh)) |
1995 | jh->b_modified ? BJ_Metadata : BJ_Reserved); | 2009 | jlist = BJ_Forget; |
2010 | else if (jh->b_modified) | ||
2011 | jlist = BJ_Metadata; | ||
2012 | else | ||
2013 | jlist = BJ_Reserved; | ||
2014 | __jbd2_journal_file_buffer(jh, jh->b_transaction, jlist); | ||
1996 | J_ASSERT_JH(jh, jh->b_transaction->t_state == T_RUNNING); | 2015 | J_ASSERT_JH(jh, jh->b_transaction->t_state == T_RUNNING); |
1997 | 2016 | ||
1998 | if (was_dirty) | 2017 | if (was_dirty) |
diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c index d66477c34306..213169780b6c 100644 --- a/fs/jfs/acl.c +++ b/fs/jfs/acl.c | |||
@@ -20,7 +20,6 @@ | |||
20 | 20 | ||
21 | #include <linux/sched.h> | 21 | #include <linux/sched.h> |
22 | #include <linux/fs.h> | 22 | #include <linux/fs.h> |
23 | #include <linux/quotaops.h> | ||
24 | #include <linux/posix_acl_xattr.h> | 23 | #include <linux/posix_acl_xattr.h> |
25 | #include "jfs_incore.h" | 24 | #include "jfs_incore.h" |
26 | #include "jfs_txnmgr.h" | 25 | #include "jfs_txnmgr.h" |
@@ -174,7 +173,7 @@ cleanup: | |||
174 | return rc; | 173 | return rc; |
175 | } | 174 | } |
176 | 175 | ||
177 | static int jfs_acl_chmod(struct inode *inode) | 176 | int jfs_acl_chmod(struct inode *inode) |
178 | { | 177 | { |
179 | struct posix_acl *acl, *clone; | 178 | struct posix_acl *acl, *clone; |
180 | int rc; | 179 | int rc; |
@@ -205,26 +204,3 @@ static int jfs_acl_chmod(struct inode *inode) | |||
205 | posix_acl_release(clone); | 204 | posix_acl_release(clone); |
206 | return rc; | 205 | return rc; |
207 | } | 206 | } |
208 | |||
209 | int jfs_setattr(struct dentry *dentry, struct iattr *iattr) | ||
210 | { | ||
211 | struct inode *inode = dentry->d_inode; | ||
212 | int rc; | ||
213 | |||
214 | rc = inode_change_ok(inode, iattr); | ||
215 | if (rc) | ||
216 | return rc; | ||
217 | |||
218 | if ((iattr->ia_valid & ATTR_UID && iattr->ia_uid != inode->i_uid) || | ||
219 | (iattr->ia_valid & ATTR_GID && iattr->ia_gid != inode->i_gid)) { | ||
220 | if (vfs_dq_transfer(inode, iattr)) | ||
221 | return -EDQUOT; | ||
222 | } | ||
223 | |||
224 | rc = inode_setattr(inode, iattr); | ||
225 | |||
226 | if (!rc && (iattr->ia_valid & ATTR_MODE)) | ||
227 | rc = jfs_acl_chmod(inode); | ||
228 | |||
229 | return rc; | ||
230 | } | ||
diff --git a/fs/jfs/file.c b/fs/jfs/file.c index 2b70fa78e4a7..14ba982b3f24 100644 --- a/fs/jfs/file.c +++ b/fs/jfs/file.c | |||
@@ -18,6 +18,7 @@ | |||
18 | */ | 18 | */ |
19 | 19 | ||
20 | #include <linux/fs.h> | 20 | #include <linux/fs.h> |
21 | #include <linux/quotaops.h> | ||
21 | #include "jfs_incore.h" | 22 | #include "jfs_incore.h" |
22 | #include "jfs_inode.h" | 23 | #include "jfs_inode.h" |
23 | #include "jfs_dmap.h" | 24 | #include "jfs_dmap.h" |
@@ -47,7 +48,7 @@ static int jfs_open(struct inode *inode, struct file *file) | |||
47 | { | 48 | { |
48 | int rc; | 49 | int rc; |
49 | 50 | ||
50 | if ((rc = generic_file_open(inode, file))) | 51 | if ((rc = dquot_file_open(inode, file))) |
51 | return rc; | 52 | return rc; |
52 | 53 | ||
53 | /* | 54 | /* |
@@ -88,14 +89,40 @@ static int jfs_release(struct inode *inode, struct file *file) | |||
88 | return 0; | 89 | return 0; |
89 | } | 90 | } |
90 | 91 | ||
92 | int jfs_setattr(struct dentry *dentry, struct iattr *iattr) | ||
93 | { | ||
94 | struct inode *inode = dentry->d_inode; | ||
95 | int rc; | ||
96 | |||
97 | rc = inode_change_ok(inode, iattr); | ||
98 | if (rc) | ||
99 | return rc; | ||
100 | |||
101 | if (iattr->ia_valid & ATTR_SIZE) | ||
102 | dquot_initialize(inode); | ||
103 | if ((iattr->ia_valid & ATTR_UID && iattr->ia_uid != inode->i_uid) || | ||
104 | (iattr->ia_valid & ATTR_GID && iattr->ia_gid != inode->i_gid)) { | ||
105 | rc = dquot_transfer(inode, iattr); | ||
106 | if (rc) | ||
107 | return rc; | ||
108 | } | ||
109 | |||
110 | rc = inode_setattr(inode, iattr); | ||
111 | |||
112 | if (!rc && (iattr->ia_valid & ATTR_MODE)) | ||
113 | rc = jfs_acl_chmod(inode); | ||
114 | |||
115 | return rc; | ||
116 | } | ||
117 | |||
91 | const struct inode_operations jfs_file_inode_operations = { | 118 | const struct inode_operations jfs_file_inode_operations = { |
92 | .truncate = jfs_truncate, | 119 | .truncate = jfs_truncate, |
93 | .setxattr = jfs_setxattr, | 120 | .setxattr = jfs_setxattr, |
94 | .getxattr = jfs_getxattr, | 121 | .getxattr = jfs_getxattr, |
95 | .listxattr = jfs_listxattr, | 122 | .listxattr = jfs_listxattr, |
96 | .removexattr = jfs_removexattr, | 123 | .removexattr = jfs_removexattr, |
97 | #ifdef CONFIG_JFS_POSIX_ACL | ||
98 | .setattr = jfs_setattr, | 124 | .setattr = jfs_setattr, |
125 | #ifdef CONFIG_JFS_POSIX_ACL | ||
99 | .check_acl = jfs_check_acl, | 126 | .check_acl = jfs_check_acl, |
100 | #endif | 127 | #endif |
101 | }; | 128 | }; |
diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c index b2ae190a77ba..9dd126276c9f 100644 --- a/fs/jfs/inode.c +++ b/fs/jfs/inode.c | |||
@@ -22,6 +22,7 @@ | |||
22 | #include <linux/buffer_head.h> | 22 | #include <linux/buffer_head.h> |
23 | #include <linux/pagemap.h> | 23 | #include <linux/pagemap.h> |
24 | #include <linux/quotaops.h> | 24 | #include <linux/quotaops.h> |
25 | #include <linux/writeback.h> | ||
25 | #include "jfs_incore.h" | 26 | #include "jfs_incore.h" |
26 | #include "jfs_inode.h" | 27 | #include "jfs_inode.h" |
27 | #include "jfs_filsys.h" | 28 | #include "jfs_filsys.h" |
@@ -120,8 +121,10 @@ int jfs_commit_inode(struct inode *inode, int wait) | |||
120 | return rc; | 121 | return rc; |
121 | } | 122 | } |
122 | 123 | ||
123 | int jfs_write_inode(struct inode *inode, int wait) | 124 | int jfs_write_inode(struct inode *inode, struct writeback_control *wbc) |
124 | { | 125 | { |
126 | int wait = wbc->sync_mode == WB_SYNC_ALL; | ||
127 | |||
125 | if (test_cflag(COMMIT_Nolink, inode)) | 128 | if (test_cflag(COMMIT_Nolink, inode)) |
126 | return 0; | 129 | return 0; |
127 | /* | 130 | /* |
@@ -146,6 +149,9 @@ void jfs_delete_inode(struct inode *inode) | |||
146 | { | 149 | { |
147 | jfs_info("In jfs_delete_inode, inode = 0x%p", inode); | 150 | jfs_info("In jfs_delete_inode, inode = 0x%p", inode); |
148 | 151 | ||
152 | if (!is_bad_inode(inode)) | ||
153 | dquot_initialize(inode); | ||
154 | |||
149 | if (!is_bad_inode(inode) && | 155 | if (!is_bad_inode(inode) && |
150 | (JFS_IP(inode)->fileset == FILESYSTEM_I)) { | 156 | (JFS_IP(inode)->fileset == FILESYSTEM_I)) { |
151 | truncate_inode_pages(&inode->i_data, 0); | 157 | truncate_inode_pages(&inode->i_data, 0); |
@@ -158,9 +164,9 @@ void jfs_delete_inode(struct inode *inode) | |||
158 | /* | 164 | /* |
159 | * Free the inode from the quota allocation. | 165 | * Free the inode from the quota allocation. |
160 | */ | 166 | */ |
161 | vfs_dq_init(inode); | 167 | dquot_initialize(inode); |
162 | vfs_dq_free_inode(inode); | 168 | dquot_free_inode(inode); |
163 | vfs_dq_drop(inode); | 169 | dquot_drop(inode); |
164 | } | 170 | } |
165 | 171 | ||
166 | clear_inode(inode); | 172 | clear_inode(inode); |
diff --git a/fs/jfs/jfs_acl.h b/fs/jfs/jfs_acl.h index b07bd417ef85..54e07559878d 100644 --- a/fs/jfs/jfs_acl.h +++ b/fs/jfs/jfs_acl.h | |||
@@ -22,7 +22,7 @@ | |||
22 | 22 | ||
23 | int jfs_check_acl(struct inode *, int); | 23 | int jfs_check_acl(struct inode *, int); |
24 | int jfs_init_acl(tid_t, struct inode *, struct inode *); | 24 | int jfs_init_acl(tid_t, struct inode *, struct inode *); |
25 | int jfs_setattr(struct dentry *, struct iattr *); | 25 | int jfs_acl_chmod(struct inode *inode); |
26 | 26 | ||
27 | #else | 27 | #else |
28 | 28 | ||
@@ -32,5 +32,10 @@ static inline int jfs_init_acl(tid_t tid, struct inode *inode, | |||
32 | return 0; | 32 | return 0; |
33 | } | 33 | } |
34 | 34 | ||
35 | static inline int jfs_acl_chmod(struct inode *inode) | ||
36 | { | ||
37 | return 0; | ||
38 | } | ||
39 | |||
35 | #endif | 40 | #endif |
36 | #endif /* _H_JFS_ACL */ | 41 | #endif /* _H_JFS_ACL */ |
diff --git a/fs/jfs/jfs_dtree.c b/fs/jfs/jfs_dtree.c index 925871e9887b..0e4623be70ce 100644 --- a/fs/jfs/jfs_dtree.c +++ b/fs/jfs/jfs_dtree.c | |||
@@ -381,10 +381,10 @@ static u32 add_index(tid_t tid, struct inode *ip, s64 bn, int slot) | |||
381 | * It's time to move the inline table to an external | 381 | * It's time to move the inline table to an external |
382 | * page and begin to build the xtree | 382 | * page and begin to build the xtree |
383 | */ | 383 | */ |
384 | if (vfs_dq_alloc_block(ip, sbi->nbperpage)) | 384 | if (dquot_alloc_block(ip, sbi->nbperpage)) |
385 | goto clean_up; | 385 | goto clean_up; |
386 | if (dbAlloc(ip, 0, sbi->nbperpage, &xaddr)) { | 386 | if (dbAlloc(ip, 0, sbi->nbperpage, &xaddr)) { |
387 | vfs_dq_free_block(ip, sbi->nbperpage); | 387 | dquot_free_block(ip, sbi->nbperpage); |
388 | goto clean_up; | 388 | goto clean_up; |
389 | } | 389 | } |
390 | 390 | ||
@@ -408,7 +408,7 @@ static u32 add_index(tid_t tid, struct inode *ip, s64 bn, int slot) | |||
408 | memcpy(&jfs_ip->i_dirtable, temp_table, | 408 | memcpy(&jfs_ip->i_dirtable, temp_table, |
409 | sizeof (temp_table)); | 409 | sizeof (temp_table)); |
410 | dbFree(ip, xaddr, sbi->nbperpage); | 410 | dbFree(ip, xaddr, sbi->nbperpage); |
411 | vfs_dq_free_block(ip, sbi->nbperpage); | 411 | dquot_free_block(ip, sbi->nbperpage); |
412 | goto clean_up; | 412 | goto clean_up; |
413 | } | 413 | } |
414 | ip->i_size = PSIZE; | 414 | ip->i_size = PSIZE; |
@@ -1027,10 +1027,9 @@ static int dtSplitUp(tid_t tid, | |||
1027 | n = xlen; | 1027 | n = xlen; |
1028 | 1028 | ||
1029 | /* Allocate blocks to quota. */ | 1029 | /* Allocate blocks to quota. */ |
1030 | if (vfs_dq_alloc_block(ip, n)) { | 1030 | rc = dquot_alloc_block(ip, n); |
1031 | rc = -EDQUOT; | 1031 | if (rc) |
1032 | goto extendOut; | 1032 | goto extendOut; |
1033 | } | ||
1034 | quota_allocation += n; | 1033 | quota_allocation += n; |
1035 | 1034 | ||
1036 | if ((rc = dbReAlloc(sbi->ipbmap, xaddr, (s64) xlen, | 1035 | if ((rc = dbReAlloc(sbi->ipbmap, xaddr, (s64) xlen, |
@@ -1308,7 +1307,7 @@ static int dtSplitUp(tid_t tid, | |||
1308 | 1307 | ||
1309 | /* Rollback quota allocation */ | 1308 | /* Rollback quota allocation */ |
1310 | if (rc && quota_allocation) | 1309 | if (rc && quota_allocation) |
1311 | vfs_dq_free_block(ip, quota_allocation); | 1310 | dquot_free_block(ip, quota_allocation); |
1312 | 1311 | ||
1313 | dtSplitUp_Exit: | 1312 | dtSplitUp_Exit: |
1314 | 1313 | ||
@@ -1369,9 +1368,10 @@ static int dtSplitPage(tid_t tid, struct inode *ip, struct dtsplit * split, | |||
1369 | return -EIO; | 1368 | return -EIO; |
1370 | 1369 | ||
1371 | /* Allocate blocks to quota. */ | 1370 | /* Allocate blocks to quota. */ |
1372 | if (vfs_dq_alloc_block(ip, lengthPXD(pxd))) { | 1371 | rc = dquot_alloc_block(ip, lengthPXD(pxd)); |
1372 | if (rc) { | ||
1373 | release_metapage(rmp); | 1373 | release_metapage(rmp); |
1374 | return -EDQUOT; | 1374 | return rc; |
1375 | } | 1375 | } |
1376 | 1376 | ||
1377 | jfs_info("dtSplitPage: ip:0x%p smp:0x%p rmp:0x%p", ip, smp, rmp); | 1377 | jfs_info("dtSplitPage: ip:0x%p smp:0x%p rmp:0x%p", ip, smp, rmp); |
@@ -1892,6 +1892,7 @@ static int dtSplitRoot(tid_t tid, | |||
1892 | struct dt_lock *dtlck; | 1892 | struct dt_lock *dtlck; |
1893 | struct tlock *tlck; | 1893 | struct tlock *tlck; |
1894 | struct lv *lv; | 1894 | struct lv *lv; |
1895 | int rc; | ||
1895 | 1896 | ||
1896 | /* get split root page */ | 1897 | /* get split root page */ |
1897 | smp = split->mp; | 1898 | smp = split->mp; |
@@ -1916,9 +1917,10 @@ static int dtSplitRoot(tid_t tid, | |||
1916 | rp = rmp->data; | 1917 | rp = rmp->data; |
1917 | 1918 | ||
1918 | /* Allocate blocks to quota. */ | 1919 | /* Allocate blocks to quota. */ |
1919 | if (vfs_dq_alloc_block(ip, lengthPXD(pxd))) { | 1920 | rc = dquot_alloc_block(ip, lengthPXD(pxd)); |
1921 | if (rc) { | ||
1920 | release_metapage(rmp); | 1922 | release_metapage(rmp); |
1921 | return -EDQUOT; | 1923 | return rc; |
1922 | } | 1924 | } |
1923 | 1925 | ||
1924 | BT_MARK_DIRTY(rmp, ip); | 1926 | BT_MARK_DIRTY(rmp, ip); |
@@ -2287,7 +2289,7 @@ static int dtDeleteUp(tid_t tid, struct inode *ip, | |||
2287 | xlen = lengthPXD(&fp->header.self); | 2289 | xlen = lengthPXD(&fp->header.self); |
2288 | 2290 | ||
2289 | /* Free quota allocation. */ | 2291 | /* Free quota allocation. */ |
2290 | vfs_dq_free_block(ip, xlen); | 2292 | dquot_free_block(ip, xlen); |
2291 | 2293 | ||
2292 | /* free/invalidate its buffer page */ | 2294 | /* free/invalidate its buffer page */ |
2293 | discard_metapage(fmp); | 2295 | discard_metapage(fmp); |
@@ -2363,7 +2365,7 @@ static int dtDeleteUp(tid_t tid, struct inode *ip, | |||
2363 | xlen = lengthPXD(&p->header.self); | 2365 | xlen = lengthPXD(&p->header.self); |
2364 | 2366 | ||
2365 | /* Free quota allocation */ | 2367 | /* Free quota allocation */ |
2366 | vfs_dq_free_block(ip, xlen); | 2368 | dquot_free_block(ip, xlen); |
2367 | 2369 | ||
2368 | /* free/invalidate its buffer page */ | 2370 | /* free/invalidate its buffer page */ |
2369 | discard_metapage(mp); | 2371 | discard_metapage(mp); |
diff --git a/fs/jfs/jfs_extent.c b/fs/jfs/jfs_extent.c index 41d6045dbeb0..5d3bbd10f8db 100644 --- a/fs/jfs/jfs_extent.c +++ b/fs/jfs/jfs_extent.c | |||
@@ -141,10 +141,11 @@ extAlloc(struct inode *ip, s64 xlen, s64 pno, xad_t * xp, bool abnr) | |||
141 | } | 141 | } |
142 | 142 | ||
143 | /* Allocate blocks to quota. */ | 143 | /* Allocate blocks to quota. */ |
144 | if (vfs_dq_alloc_block(ip, nxlen)) { | 144 | rc = dquot_alloc_block(ip, nxlen); |
145 | if (rc) { | ||
145 | dbFree(ip, nxaddr, (s64) nxlen); | 146 | dbFree(ip, nxaddr, (s64) nxlen); |
146 | mutex_unlock(&JFS_IP(ip)->commit_mutex); | 147 | mutex_unlock(&JFS_IP(ip)->commit_mutex); |
147 | return -EDQUOT; | 148 | return rc; |
148 | } | 149 | } |
149 | 150 | ||
150 | /* determine the value of the extent flag */ | 151 | /* determine the value of the extent flag */ |
@@ -164,7 +165,7 @@ extAlloc(struct inode *ip, s64 xlen, s64 pno, xad_t * xp, bool abnr) | |||
164 | */ | 165 | */ |
165 | if (rc) { | 166 | if (rc) { |
166 | dbFree(ip, nxaddr, nxlen); | 167 | dbFree(ip, nxaddr, nxlen); |
167 | vfs_dq_free_block(ip, nxlen); | 168 | dquot_free_block(ip, nxlen); |
168 | mutex_unlock(&JFS_IP(ip)->commit_mutex); | 169 | mutex_unlock(&JFS_IP(ip)->commit_mutex); |
169 | return (rc); | 170 | return (rc); |
170 | } | 171 | } |
@@ -256,10 +257,11 @@ int extRealloc(struct inode *ip, s64 nxlen, xad_t * xp, bool abnr) | |||
256 | goto exit; | 257 | goto exit; |
257 | 258 | ||
258 | /* Allocat blocks to quota. */ | 259 | /* Allocat blocks to quota. */ |
259 | if (vfs_dq_alloc_block(ip, nxlen)) { | 260 | rc = dquot_alloc_block(ip, nxlen); |
261 | if (rc) { | ||
260 | dbFree(ip, nxaddr, (s64) nxlen); | 262 | dbFree(ip, nxaddr, (s64) nxlen); |
261 | mutex_unlock(&JFS_IP(ip)->commit_mutex); | 263 | mutex_unlock(&JFS_IP(ip)->commit_mutex); |
262 | return -EDQUOT; | 264 | return rc; |
263 | } | 265 | } |
264 | 266 | ||
265 | delta = nxlen - xlen; | 267 | delta = nxlen - xlen; |
@@ -297,7 +299,7 @@ int extRealloc(struct inode *ip, s64 nxlen, xad_t * xp, bool abnr) | |||
297 | /* extend the extent */ | 299 | /* extend the extent */ |
298 | if ((rc = xtExtend(0, ip, xoff + xlen, (int) nextend, 0))) { | 300 | if ((rc = xtExtend(0, ip, xoff + xlen, (int) nextend, 0))) { |
299 | dbFree(ip, xaddr + xlen, delta); | 301 | dbFree(ip, xaddr + xlen, delta); |
300 | vfs_dq_free_block(ip, nxlen); | 302 | dquot_free_block(ip, nxlen); |
301 | goto exit; | 303 | goto exit; |
302 | } | 304 | } |
303 | } else { | 305 | } else { |
@@ -308,7 +310,7 @@ int extRealloc(struct inode *ip, s64 nxlen, xad_t * xp, bool abnr) | |||
308 | */ | 310 | */ |
309 | if ((rc = xtTailgate(0, ip, xoff, (int) ntail, nxaddr, 0))) { | 311 | if ((rc = xtTailgate(0, ip, xoff, (int) ntail, nxaddr, 0))) { |
310 | dbFree(ip, nxaddr, nxlen); | 312 | dbFree(ip, nxaddr, nxlen); |
311 | vfs_dq_free_block(ip, nxlen); | 313 | dquot_free_block(ip, nxlen); |
312 | goto exit; | 314 | goto exit; |
313 | } | 315 | } |
314 | } | 316 | } |
diff --git a/fs/jfs/jfs_inode.c b/fs/jfs/jfs_inode.c index dc0e02159ac9..829921b67765 100644 --- a/fs/jfs/jfs_inode.c +++ b/fs/jfs/jfs_inode.c | |||
@@ -116,10 +116,10 @@ struct inode *ialloc(struct inode *parent, umode_t mode) | |||
116 | /* | 116 | /* |
117 | * Allocate inode to quota. | 117 | * Allocate inode to quota. |
118 | */ | 118 | */ |
119 | if (vfs_dq_alloc_inode(inode)) { | 119 | dquot_initialize(inode); |
120 | rc = -EDQUOT; | 120 | rc = dquot_alloc_inode(inode); |
121 | if (rc) | ||
121 | goto fail_drop; | 122 | goto fail_drop; |
122 | } | ||
123 | 123 | ||
124 | inode->i_mode = mode; | 124 | inode->i_mode = mode; |
125 | /* inherit flags from parent */ | 125 | /* inherit flags from parent */ |
@@ -162,7 +162,7 @@ struct inode *ialloc(struct inode *parent, umode_t mode) | |||
162 | return inode; | 162 | return inode; |
163 | 163 | ||
164 | fail_drop: | 164 | fail_drop: |
165 | vfs_dq_drop(inode); | 165 | dquot_drop(inode); |
166 | inode->i_flags |= S_NOQUOTA; | 166 | inode->i_flags |= S_NOQUOTA; |
167 | fail_unlock: | 167 | fail_unlock: |
168 | inode->i_nlink = 0; | 168 | inode->i_nlink = 0; |
diff --git a/fs/jfs/jfs_inode.h b/fs/jfs/jfs_inode.h index 1eff7db34d63..79e2c79661df 100644 --- a/fs/jfs/jfs_inode.h +++ b/fs/jfs/jfs_inode.h | |||
@@ -26,7 +26,7 @@ extern long jfs_ioctl(struct file *, unsigned int, unsigned long); | |||
26 | extern long jfs_compat_ioctl(struct file *, unsigned int, unsigned long); | 26 | extern long jfs_compat_ioctl(struct file *, unsigned int, unsigned long); |
27 | extern struct inode *jfs_iget(struct super_block *, unsigned long); | 27 | extern struct inode *jfs_iget(struct super_block *, unsigned long); |
28 | extern int jfs_commit_inode(struct inode *, int); | 28 | extern int jfs_commit_inode(struct inode *, int); |
29 | extern int jfs_write_inode(struct inode*, int); | 29 | extern int jfs_write_inode(struct inode *, struct writeback_control *); |
30 | extern void jfs_delete_inode(struct inode *); | 30 | extern void jfs_delete_inode(struct inode *); |
31 | extern void jfs_dirty_inode(struct inode *); | 31 | extern void jfs_dirty_inode(struct inode *); |
32 | extern void jfs_truncate(struct inode *); | 32 | extern void jfs_truncate(struct inode *); |
@@ -40,6 +40,7 @@ extern struct dentry *jfs_fh_to_parent(struct super_block *sb, struct fid *fid, | |||
40 | int fh_len, int fh_type); | 40 | int fh_len, int fh_type); |
41 | extern void jfs_set_inode_flags(struct inode *); | 41 | extern void jfs_set_inode_flags(struct inode *); |
42 | extern int jfs_get_block(struct inode *, sector_t, struct buffer_head *, int); | 42 | extern int jfs_get_block(struct inode *, sector_t, struct buffer_head *, int); |
43 | extern int jfs_setattr(struct dentry *, struct iattr *); | ||
43 | 44 | ||
44 | extern const struct address_space_operations jfs_aops; | 45 | extern const struct address_space_operations jfs_aops; |
45 | extern const struct inode_operations jfs_dir_inode_operations; | 46 | extern const struct inode_operations jfs_dir_inode_operations; |
diff --git a/fs/jfs/jfs_xtree.c b/fs/jfs/jfs_xtree.c index d654a6458648..6c50871e6220 100644 --- a/fs/jfs/jfs_xtree.c +++ b/fs/jfs/jfs_xtree.c | |||
@@ -585,10 +585,10 @@ int xtInsert(tid_t tid, /* transaction id */ | |||
585 | hint = addressXAD(xad) + lengthXAD(xad) - 1; | 585 | hint = addressXAD(xad) + lengthXAD(xad) - 1; |
586 | } else | 586 | } else |
587 | hint = 0; | 587 | hint = 0; |
588 | if ((rc = vfs_dq_alloc_block(ip, xlen))) | 588 | if ((rc = dquot_alloc_block(ip, xlen))) |
589 | goto out; | 589 | goto out; |
590 | if ((rc = dbAlloc(ip, hint, (s64) xlen, &xaddr))) { | 590 | if ((rc = dbAlloc(ip, hint, (s64) xlen, &xaddr))) { |
591 | vfs_dq_free_block(ip, xlen); | 591 | dquot_free_block(ip, xlen); |
592 | goto out; | 592 | goto out; |
593 | } | 593 | } |
594 | } | 594 | } |
@@ -617,7 +617,7 @@ int xtInsert(tid_t tid, /* transaction id */ | |||
617 | /* undo data extent allocation */ | 617 | /* undo data extent allocation */ |
618 | if (*xaddrp == 0) { | 618 | if (*xaddrp == 0) { |
619 | dbFree(ip, xaddr, (s64) xlen); | 619 | dbFree(ip, xaddr, (s64) xlen); |
620 | vfs_dq_free_block(ip, xlen); | 620 | dquot_free_block(ip, xlen); |
621 | } | 621 | } |
622 | return rc; | 622 | return rc; |
623 | } | 623 | } |
@@ -985,10 +985,9 @@ xtSplitPage(tid_t tid, struct inode *ip, | |||
985 | rbn = addressPXD(pxd); | 985 | rbn = addressPXD(pxd); |
986 | 986 | ||
987 | /* Allocate blocks to quota. */ | 987 | /* Allocate blocks to quota. */ |
988 | if (vfs_dq_alloc_block(ip, lengthPXD(pxd))) { | 988 | rc = dquot_alloc_block(ip, lengthPXD(pxd)); |
989 | rc = -EDQUOT; | 989 | if (rc) |
990 | goto clean_up; | 990 | goto clean_up; |
991 | } | ||
992 | 991 | ||
993 | quota_allocation += lengthPXD(pxd); | 992 | quota_allocation += lengthPXD(pxd); |
994 | 993 | ||
@@ -1195,7 +1194,7 @@ xtSplitPage(tid_t tid, struct inode *ip, | |||
1195 | 1194 | ||
1196 | /* Rollback quota allocation. */ | 1195 | /* Rollback quota allocation. */ |
1197 | if (quota_allocation) | 1196 | if (quota_allocation) |
1198 | vfs_dq_free_block(ip, quota_allocation); | 1197 | dquot_free_block(ip, quota_allocation); |
1199 | 1198 | ||
1200 | return (rc); | 1199 | return (rc); |
1201 | } | 1200 | } |
@@ -1235,6 +1234,7 @@ xtSplitRoot(tid_t tid, | |||
1235 | struct pxdlist *pxdlist; | 1234 | struct pxdlist *pxdlist; |
1236 | struct tlock *tlck; | 1235 | struct tlock *tlck; |
1237 | struct xtlock *xtlck; | 1236 | struct xtlock *xtlck; |
1237 | int rc; | ||
1238 | 1238 | ||
1239 | sp = &JFS_IP(ip)->i_xtroot; | 1239 | sp = &JFS_IP(ip)->i_xtroot; |
1240 | 1240 | ||
@@ -1252,9 +1252,10 @@ xtSplitRoot(tid_t tid, | |||
1252 | return -EIO; | 1252 | return -EIO; |
1253 | 1253 | ||
1254 | /* Allocate blocks to quota. */ | 1254 | /* Allocate blocks to quota. */ |
1255 | if (vfs_dq_alloc_block(ip, lengthPXD(pxd))) { | 1255 | rc = dquot_alloc_block(ip, lengthPXD(pxd)); |
1256 | if (rc) { | ||
1256 | release_metapage(rmp); | 1257 | release_metapage(rmp); |
1257 | return -EDQUOT; | 1258 | return rc; |
1258 | } | 1259 | } |
1259 | 1260 | ||
1260 | jfs_info("xtSplitRoot: ip:0x%p rmp:0x%p", ip, rmp); | 1261 | jfs_info("xtSplitRoot: ip:0x%p rmp:0x%p", ip, rmp); |
@@ -3680,7 +3681,7 @@ s64 xtTruncate(tid_t tid, struct inode *ip, s64 newsize, int flag) | |||
3680 | ip->i_size = newsize; | 3681 | ip->i_size = newsize; |
3681 | 3682 | ||
3682 | /* update quota allocation to reflect freed blocks */ | 3683 | /* update quota allocation to reflect freed blocks */ |
3683 | vfs_dq_free_block(ip, nfreed); | 3684 | dquot_free_block(ip, nfreed); |
3684 | 3685 | ||
3685 | /* | 3686 | /* |
3686 | * free tlock of invalidated pages | 3687 | * free tlock of invalidated pages |
diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c index c79a4270f083..4a3e9f39c21d 100644 --- a/fs/jfs/namei.c +++ b/fs/jfs/namei.c | |||
@@ -85,6 +85,8 @@ static int jfs_create(struct inode *dip, struct dentry *dentry, int mode, | |||
85 | 85 | ||
86 | jfs_info("jfs_create: dip:0x%p name:%s", dip, dentry->d_name.name); | 86 | jfs_info("jfs_create: dip:0x%p name:%s", dip, dentry->d_name.name); |
87 | 87 | ||
88 | dquot_initialize(dip); | ||
89 | |||
88 | /* | 90 | /* |
89 | * search parent directory for entry/freespace | 91 | * search parent directory for entry/freespace |
90 | * (dtSearch() returns parent directory page pinned) | 92 | * (dtSearch() returns parent directory page pinned) |
@@ -215,6 +217,8 @@ static int jfs_mkdir(struct inode *dip, struct dentry *dentry, int mode) | |||
215 | 217 | ||
216 | jfs_info("jfs_mkdir: dip:0x%p name:%s", dip, dentry->d_name.name); | 218 | jfs_info("jfs_mkdir: dip:0x%p name:%s", dip, dentry->d_name.name); |
217 | 219 | ||
220 | dquot_initialize(dip); | ||
221 | |||
218 | /* link count overflow on parent directory ? */ | 222 | /* link count overflow on parent directory ? */ |
219 | if (dip->i_nlink == JFS_LINK_MAX) { | 223 | if (dip->i_nlink == JFS_LINK_MAX) { |
220 | rc = -EMLINK; | 224 | rc = -EMLINK; |
@@ -356,7 +360,8 @@ static int jfs_rmdir(struct inode *dip, struct dentry *dentry) | |||
356 | jfs_info("jfs_rmdir: dip:0x%p name:%s", dip, dentry->d_name.name); | 360 | jfs_info("jfs_rmdir: dip:0x%p name:%s", dip, dentry->d_name.name); |
357 | 361 | ||
358 | /* Init inode for quota operations. */ | 362 | /* Init inode for quota operations. */ |
359 | vfs_dq_init(ip); | 363 | dquot_initialize(dip); |
364 | dquot_initialize(ip); | ||
360 | 365 | ||
361 | /* directory must be empty to be removed */ | 366 | /* directory must be empty to be removed */ |
362 | if (!dtEmpty(ip)) { | 367 | if (!dtEmpty(ip)) { |
@@ -483,7 +488,8 @@ static int jfs_unlink(struct inode *dip, struct dentry *dentry) | |||
483 | jfs_info("jfs_unlink: dip:0x%p name:%s", dip, dentry->d_name.name); | 488 | jfs_info("jfs_unlink: dip:0x%p name:%s", dip, dentry->d_name.name); |
484 | 489 | ||
485 | /* Init inode for quota operations. */ | 490 | /* Init inode for quota operations. */ |
486 | vfs_dq_init(ip); | 491 | dquot_initialize(dip); |
492 | dquot_initialize(ip); | ||
487 | 493 | ||
488 | if ((rc = get_UCSname(&dname, dentry))) | 494 | if ((rc = get_UCSname(&dname, dentry))) |
489 | goto out; | 495 | goto out; |
@@ -805,6 +811,8 @@ static int jfs_link(struct dentry *old_dentry, | |||
805 | if (ip->i_nlink == 0) | 811 | if (ip->i_nlink == 0) |
806 | return -ENOENT; | 812 | return -ENOENT; |
807 | 813 | ||
814 | dquot_initialize(dir); | ||
815 | |||
808 | tid = txBegin(ip->i_sb, 0); | 816 | tid = txBegin(ip->i_sb, 0); |
809 | 817 | ||
810 | mutex_lock_nested(&JFS_IP(dir)->commit_mutex, COMMIT_MUTEX_PARENT); | 818 | mutex_lock_nested(&JFS_IP(dir)->commit_mutex, COMMIT_MUTEX_PARENT); |
@@ -896,6 +904,8 @@ static int jfs_symlink(struct inode *dip, struct dentry *dentry, | |||
896 | 904 | ||
897 | jfs_info("jfs_symlink: dip:0x%p name:%s", dip, name); | 905 | jfs_info("jfs_symlink: dip:0x%p name:%s", dip, name); |
898 | 906 | ||
907 | dquot_initialize(dip); | ||
908 | |||
899 | ssize = strlen(name) + 1; | 909 | ssize = strlen(name) + 1; |
900 | 910 | ||
901 | /* | 911 | /* |
@@ -1087,6 +1097,9 @@ static int jfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
1087 | jfs_info("jfs_rename: %s %s", old_dentry->d_name.name, | 1097 | jfs_info("jfs_rename: %s %s", old_dentry->d_name.name, |
1088 | new_dentry->d_name.name); | 1098 | new_dentry->d_name.name); |
1089 | 1099 | ||
1100 | dquot_initialize(old_dir); | ||
1101 | dquot_initialize(new_dir); | ||
1102 | |||
1090 | old_ip = old_dentry->d_inode; | 1103 | old_ip = old_dentry->d_inode; |
1091 | new_ip = new_dentry->d_inode; | 1104 | new_ip = new_dentry->d_inode; |
1092 | 1105 | ||
@@ -1136,7 +1149,7 @@ static int jfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
1136 | } else if (new_ip) { | 1149 | } else if (new_ip) { |
1137 | IWRITE_LOCK(new_ip, RDWRLOCK_NORMAL); | 1150 | IWRITE_LOCK(new_ip, RDWRLOCK_NORMAL); |
1138 | /* Init inode for quota operations. */ | 1151 | /* Init inode for quota operations. */ |
1139 | vfs_dq_init(new_ip); | 1152 | dquot_initialize(new_ip); |
1140 | } | 1153 | } |
1141 | 1154 | ||
1142 | /* | 1155 | /* |
@@ -1360,6 +1373,8 @@ static int jfs_mknod(struct inode *dir, struct dentry *dentry, | |||
1360 | 1373 | ||
1361 | jfs_info("jfs_mknod: %s", dentry->d_name.name); | 1374 | jfs_info("jfs_mknod: %s", dentry->d_name.name); |
1362 | 1375 | ||
1376 | dquot_initialize(dir); | ||
1377 | |||
1363 | if ((rc = get_UCSname(&dname, dentry))) | 1378 | if ((rc = get_UCSname(&dname, dentry))) |
1364 | goto out; | 1379 | goto out; |
1365 | 1380 | ||
@@ -1541,8 +1556,8 @@ const struct inode_operations jfs_dir_inode_operations = { | |||
1541 | .getxattr = jfs_getxattr, | 1556 | .getxattr = jfs_getxattr, |
1542 | .listxattr = jfs_listxattr, | 1557 | .listxattr = jfs_listxattr, |
1543 | .removexattr = jfs_removexattr, | 1558 | .removexattr = jfs_removexattr, |
1544 | #ifdef CONFIG_JFS_POSIX_ACL | ||
1545 | .setattr = jfs_setattr, | 1559 | .setattr = jfs_setattr, |
1560 | #ifdef CONFIG_JFS_POSIX_ACL | ||
1546 | .check_acl = jfs_check_acl, | 1561 | .check_acl = jfs_check_acl, |
1547 | #endif | 1562 | #endif |
1548 | }; | 1563 | }; |
diff --git a/fs/jfs/super.c b/fs/jfs/super.c index d929a822a74e..266699deb1c6 100644 --- a/fs/jfs/super.c +++ b/fs/jfs/super.c | |||
@@ -131,6 +131,11 @@ static void jfs_destroy_inode(struct inode *inode) | |||
131 | kmem_cache_free(jfs_inode_cachep, ji); | 131 | kmem_cache_free(jfs_inode_cachep, ji); |
132 | } | 132 | } |
133 | 133 | ||
134 | static void jfs_clear_inode(struct inode *inode) | ||
135 | { | ||
136 | dquot_drop(inode); | ||
137 | } | ||
138 | |||
134 | static int jfs_statfs(struct dentry *dentry, struct kstatfs *buf) | 139 | static int jfs_statfs(struct dentry *dentry, struct kstatfs *buf) |
135 | { | 140 | { |
136 | struct jfs_sb_info *sbi = JFS_SBI(dentry->d_sb); | 141 | struct jfs_sb_info *sbi = JFS_SBI(dentry->d_sb); |
@@ -745,6 +750,7 @@ static const struct super_operations jfs_super_operations = { | |||
745 | .dirty_inode = jfs_dirty_inode, | 750 | .dirty_inode = jfs_dirty_inode, |
746 | .write_inode = jfs_write_inode, | 751 | .write_inode = jfs_write_inode, |
747 | .delete_inode = jfs_delete_inode, | 752 | .delete_inode = jfs_delete_inode, |
753 | .clear_inode = jfs_clear_inode, | ||
748 | .put_super = jfs_put_super, | 754 | .put_super = jfs_put_super, |
749 | .sync_fs = jfs_sync_fs, | 755 | .sync_fs = jfs_sync_fs, |
750 | .freeze_fs = jfs_freeze, | 756 | .freeze_fs = jfs_freeze, |
diff --git a/fs/jfs/xattr.c b/fs/jfs/xattr.c index fad364548bc9..1f594ab21895 100644 --- a/fs/jfs/xattr.c +++ b/fs/jfs/xattr.c | |||
@@ -260,14 +260,14 @@ static int ea_write(struct inode *ip, struct jfs_ea_list *ealist, int size, | |||
260 | nblocks = (size + (sb->s_blocksize - 1)) >> sb->s_blocksize_bits; | 260 | nblocks = (size + (sb->s_blocksize - 1)) >> sb->s_blocksize_bits; |
261 | 261 | ||
262 | /* Allocate new blocks to quota. */ | 262 | /* Allocate new blocks to quota. */ |
263 | if (vfs_dq_alloc_block(ip, nblocks)) { | 263 | rc = dquot_alloc_block(ip, nblocks); |
264 | return -EDQUOT; | 264 | if (rc) |
265 | } | 265 | return rc; |
266 | 266 | ||
267 | rc = dbAlloc(ip, INOHINT(ip), nblocks, &blkno); | 267 | rc = dbAlloc(ip, INOHINT(ip), nblocks, &blkno); |
268 | if (rc) { | 268 | if (rc) { |
269 | /*Rollback quota allocation. */ | 269 | /*Rollback quota allocation. */ |
270 | vfs_dq_free_block(ip, nblocks); | 270 | dquot_free_block(ip, nblocks); |
271 | return rc; | 271 | return rc; |
272 | } | 272 | } |
273 | 273 | ||
@@ -332,7 +332,7 @@ static int ea_write(struct inode *ip, struct jfs_ea_list *ealist, int size, | |||
332 | 332 | ||
333 | failed: | 333 | failed: |
334 | /* Rollback quota allocation. */ | 334 | /* Rollback quota allocation. */ |
335 | vfs_dq_free_block(ip, nblocks); | 335 | dquot_free_block(ip, nblocks); |
336 | 336 | ||
337 | dbFree(ip, blkno, nblocks); | 337 | dbFree(ip, blkno, nblocks); |
338 | return rc; | 338 | return rc; |
@@ -538,7 +538,8 @@ static int ea_get(struct inode *inode, struct ea_buffer *ea_buf, int min_size) | |||
538 | 538 | ||
539 | if (blocks_needed > current_blocks) { | 539 | if (blocks_needed > current_blocks) { |
540 | /* Allocate new blocks to quota. */ | 540 | /* Allocate new blocks to quota. */ |
541 | if (vfs_dq_alloc_block(inode, blocks_needed)) | 541 | rc = dquot_alloc_block(inode, blocks_needed); |
542 | if (rc) | ||
542 | return -EDQUOT; | 543 | return -EDQUOT; |
543 | 544 | ||
544 | quota_allocation = blocks_needed; | 545 | quota_allocation = blocks_needed; |
@@ -602,7 +603,7 @@ static int ea_get(struct inode *inode, struct ea_buffer *ea_buf, int min_size) | |||
602 | clean_up: | 603 | clean_up: |
603 | /* Rollback quota allocation */ | 604 | /* Rollback quota allocation */ |
604 | if (quota_allocation) | 605 | if (quota_allocation) |
605 | vfs_dq_free_block(inode, quota_allocation); | 606 | dquot_free_block(inode, quota_allocation); |
606 | 607 | ||
607 | return (rc); | 608 | return (rc); |
608 | } | 609 | } |
@@ -677,7 +678,7 @@ static int ea_put(tid_t tid, struct inode *inode, struct ea_buffer *ea_buf, | |||
677 | 678 | ||
678 | /* If old blocks exist, they must be removed from quota allocation. */ | 679 | /* If old blocks exist, they must be removed from quota allocation. */ |
679 | if (old_blocks) | 680 | if (old_blocks) |
680 | vfs_dq_free_block(inode, old_blocks); | 681 | dquot_free_block(inode, old_blocks); |
681 | 682 | ||
682 | inode->i_ctime = CURRENT_TIME; | 683 | inode->i_ctime = CURRENT_TIME; |
683 | 684 | ||
diff --git a/fs/libfs.c b/fs/libfs.c index 6e8d17e1dc4c..9e50bcf55857 100644 --- a/fs/libfs.c +++ b/fs/libfs.c | |||
@@ -338,28 +338,14 @@ int simple_readpage(struct file *file, struct page *page) | |||
338 | return 0; | 338 | return 0; |
339 | } | 339 | } |
340 | 340 | ||
341 | int simple_prepare_write(struct file *file, struct page *page, | ||
342 | unsigned from, unsigned to) | ||
343 | { | ||
344 | if (!PageUptodate(page)) { | ||
345 | if (to - from != PAGE_CACHE_SIZE) | ||
346 | zero_user_segments(page, | ||
347 | 0, from, | ||
348 | to, PAGE_CACHE_SIZE); | ||
349 | } | ||
350 | return 0; | ||
351 | } | ||
352 | |||
353 | int simple_write_begin(struct file *file, struct address_space *mapping, | 341 | int simple_write_begin(struct file *file, struct address_space *mapping, |
354 | loff_t pos, unsigned len, unsigned flags, | 342 | loff_t pos, unsigned len, unsigned flags, |
355 | struct page **pagep, void **fsdata) | 343 | struct page **pagep, void **fsdata) |
356 | { | 344 | { |
357 | struct page *page; | 345 | struct page *page; |
358 | pgoff_t index; | 346 | pgoff_t index; |
359 | unsigned from; | ||
360 | 347 | ||
361 | index = pos >> PAGE_CACHE_SHIFT; | 348 | index = pos >> PAGE_CACHE_SHIFT; |
362 | from = pos & (PAGE_CACHE_SIZE - 1); | ||
363 | 349 | ||
364 | page = grab_cache_page_write_begin(mapping, index, flags); | 350 | page = grab_cache_page_write_begin(mapping, index, flags); |
365 | if (!page) | 351 | if (!page) |
@@ -367,43 +353,59 @@ int simple_write_begin(struct file *file, struct address_space *mapping, | |||
367 | 353 | ||
368 | *pagep = page; | 354 | *pagep = page; |
369 | 355 | ||
370 | return simple_prepare_write(file, page, from, from+len); | 356 | if (!PageUptodate(page) && (len != PAGE_CACHE_SIZE)) { |
371 | } | 357 | unsigned from = pos & (PAGE_CACHE_SIZE - 1); |
372 | |||
373 | static int simple_commit_write(struct file *file, struct page *page, | ||
374 | unsigned from, unsigned to) | ||
375 | { | ||
376 | struct inode *inode = page->mapping->host; | ||
377 | loff_t pos = ((loff_t)page->index << PAGE_CACHE_SHIFT) + to; | ||
378 | 358 | ||
379 | if (!PageUptodate(page)) | 359 | zero_user_segments(page, 0, from, from + len, PAGE_CACHE_SIZE); |
380 | SetPageUptodate(page); | 360 | } |
381 | /* | ||
382 | * No need to use i_size_read() here, the i_size | ||
383 | * cannot change under us because we hold the i_mutex. | ||
384 | */ | ||
385 | if (pos > inode->i_size) | ||
386 | i_size_write(inode, pos); | ||
387 | set_page_dirty(page); | ||
388 | return 0; | 361 | return 0; |
389 | } | 362 | } |
390 | 363 | ||
364 | /** | ||
365 | * simple_write_end - .write_end helper for non-block-device FSes | ||
366 | * @available: See .write_end of address_space_operations | ||
367 | * @file: " | ||
368 | * @mapping: " | ||
369 | * @pos: " | ||
370 | * @len: " | ||
371 | * @copied: " | ||
372 | * @page: " | ||
373 | * @fsdata: " | ||
374 | * | ||
375 | * simple_write_end does the minimum needed for updating a page after writing is | ||
376 | * done. It has the same API signature as the .write_end of | ||
377 | * address_space_operations vector. So it can just be set onto .write_end for | ||
378 | * FSes that don't need any other processing. i_mutex is assumed to be held. | ||
379 | * Block based filesystems should use generic_write_end(). | ||
380 | * NOTE: Even though i_size might get updated by this function, mark_inode_dirty | ||
381 | * is not called, so a filesystem that actually does store data in .write_inode | ||
382 | * should extend on what's done here with a call to mark_inode_dirty() in the | ||
383 | * case that i_size has changed. | ||
384 | */ | ||
391 | int simple_write_end(struct file *file, struct address_space *mapping, | 385 | int simple_write_end(struct file *file, struct address_space *mapping, |
392 | loff_t pos, unsigned len, unsigned copied, | 386 | loff_t pos, unsigned len, unsigned copied, |
393 | struct page *page, void *fsdata) | 387 | struct page *page, void *fsdata) |
394 | { | 388 | { |
395 | unsigned from = pos & (PAGE_CACHE_SIZE - 1); | 389 | struct inode *inode = page->mapping->host; |
390 | loff_t last_pos = pos + copied; | ||
396 | 391 | ||
397 | /* zero the stale part of the page if we did a short copy */ | 392 | /* zero the stale part of the page if we did a short copy */ |
398 | if (copied < len) { | 393 | if (copied < len) { |
399 | void *kaddr = kmap_atomic(page, KM_USER0); | 394 | unsigned from = pos & (PAGE_CACHE_SIZE - 1); |
400 | memset(kaddr + from + copied, 0, len - copied); | 395 | |
401 | flush_dcache_page(page); | 396 | zero_user(page, from + copied, len - copied); |
402 | kunmap_atomic(kaddr, KM_USER0); | ||
403 | } | 397 | } |
404 | 398 | ||
405 | simple_commit_write(file, page, from, from+copied); | 399 | if (!PageUptodate(page)) |
400 | SetPageUptodate(page); | ||
401 | /* | ||
402 | * No need to use i_size_read() here, the i_size | ||
403 | * cannot change under us because we hold the i_mutex. | ||
404 | */ | ||
405 | if (last_pos > inode->i_size) | ||
406 | i_size_write(inode, last_pos); | ||
406 | 407 | ||
408 | set_page_dirty(page); | ||
407 | unlock_page(page); | 409 | unlock_page(page); |
408 | page_cache_release(page); | 410 | page_cache_release(page); |
409 | 411 | ||
@@ -853,7 +855,6 @@ EXPORT_SYMBOL(simple_getattr); | |||
853 | EXPORT_SYMBOL(simple_link); | 855 | EXPORT_SYMBOL(simple_link); |
854 | EXPORT_SYMBOL(simple_lookup); | 856 | EXPORT_SYMBOL(simple_lookup); |
855 | EXPORT_SYMBOL(simple_pin_fs); | 857 | EXPORT_SYMBOL(simple_pin_fs); |
856 | EXPORT_UNUSED_SYMBOL(simple_prepare_write); | ||
857 | EXPORT_SYMBOL(simple_readpage); | 858 | EXPORT_SYMBOL(simple_readpage); |
858 | EXPORT_SYMBOL(simple_release_fs); | 859 | EXPORT_SYMBOL(simple_release_fs); |
859 | EXPORT_SYMBOL(simple_rename); | 860 | EXPORT_SYMBOL(simple_rename); |
diff --git a/fs/locks.c b/fs/locks.c index a8794f233bc9..ae9ded026b7c 100644 --- a/fs/locks.c +++ b/fs/locks.c | |||
@@ -1182,8 +1182,9 @@ int __break_lease(struct inode *inode, unsigned int mode) | |||
1182 | struct file_lock *fl; | 1182 | struct file_lock *fl; |
1183 | unsigned long break_time; | 1183 | unsigned long break_time; |
1184 | int i_have_this_lease = 0; | 1184 | int i_have_this_lease = 0; |
1185 | int want_write = (mode & O_ACCMODE) != O_RDONLY; | ||
1185 | 1186 | ||
1186 | new_fl = lease_alloc(NULL, mode & FMODE_WRITE ? F_WRLCK : F_RDLCK); | 1187 | new_fl = lease_alloc(NULL, want_write ? F_WRLCK : F_RDLCK); |
1187 | 1188 | ||
1188 | lock_kernel(); | 1189 | lock_kernel(); |
1189 | 1190 | ||
@@ -1197,7 +1198,7 @@ int __break_lease(struct inode *inode, unsigned int mode) | |||
1197 | if (fl->fl_owner == current->files) | 1198 | if (fl->fl_owner == current->files) |
1198 | i_have_this_lease = 1; | 1199 | i_have_this_lease = 1; |
1199 | 1200 | ||
1200 | if (mode & FMODE_WRITE) { | 1201 | if (want_write) { |
1201 | /* If we want write access, we have to revoke any lease. */ | 1202 | /* If we want write access, we have to revoke any lease. */ |
1202 | future = F_UNLCK | F_INPROGRESS; | 1203 | future = F_UNLCK | F_INPROGRESS; |
1203 | } else if (flock->fl_type & F_INPROGRESS) { | 1204 | } else if (flock->fl_type & F_INPROGRESS) { |
diff --git a/fs/logfs/Kconfig b/fs/logfs/Kconfig new file mode 100644 index 000000000000..daf9a9b32dd3 --- /dev/null +++ b/fs/logfs/Kconfig | |||
@@ -0,0 +1,17 @@ | |||
1 | config LOGFS | ||
2 | tristate "LogFS file system (EXPERIMENTAL)" | ||
3 | depends on (MTD || BLOCK) && EXPERIMENTAL | ||
4 | select ZLIB_INFLATE | ||
5 | select ZLIB_DEFLATE | ||
6 | select CRC32 | ||
7 | select BTREE | ||
8 | help | ||
9 | Flash filesystem aimed to scale efficiently to large devices. | ||
10 | In comparison to JFFS2 it offers significantly faster mount | ||
11 | times and potentially less RAM usage, although the latter has | ||
12 | not been measured yet. | ||
13 | |||
14 | In its current state it is still very experimental and should | ||
15 | not be used for other than testing purposes. | ||
16 | |||
17 | If unsure, say N. | ||
diff --git a/fs/logfs/Makefile b/fs/logfs/Makefile new file mode 100644 index 000000000000..4820027787ee --- /dev/null +++ b/fs/logfs/Makefile | |||
@@ -0,0 +1,13 @@ | |||
1 | obj-$(CONFIG_LOGFS) += logfs.o | ||
2 | |||
3 | logfs-y += compr.o | ||
4 | logfs-y += dir.o | ||
5 | logfs-y += file.o | ||
6 | logfs-y += gc.o | ||
7 | logfs-y += inode.o | ||
8 | logfs-y += journal.o | ||
9 | logfs-y += readwrite.o | ||
10 | logfs-y += segment.o | ||
11 | logfs-y += super.o | ||
12 | logfs-$(CONFIG_BLOCK) += dev_bdev.o | ||
13 | logfs-$(CONFIG_MTD) += dev_mtd.o | ||
diff --git a/fs/logfs/compr.c b/fs/logfs/compr.c new file mode 100644 index 000000000000..44bbfd249abc --- /dev/null +++ b/fs/logfs/compr.c | |||
@@ -0,0 +1,95 @@ | |||
1 | /* | ||
2 | * fs/logfs/compr.c - compression routines | ||
3 | * | ||
4 | * As should be obvious for Linux kernel code, license is GPLv2 | ||
5 | * | ||
6 | * Copyright (c) 2005-2008 Joern Engel <joern@logfs.org> | ||
7 | */ | ||
8 | #include "logfs.h" | ||
9 | #include <linux/vmalloc.h> | ||
10 | #include <linux/zlib.h> | ||
11 | |||
12 | #define COMPR_LEVEL 3 | ||
13 | |||
14 | static DEFINE_MUTEX(compr_mutex); | ||
15 | static struct z_stream_s stream; | ||
16 | |||
17 | int logfs_compress(void *in, void *out, size_t inlen, size_t outlen) | ||
18 | { | ||
19 | int err, ret; | ||
20 | |||
21 | ret = -EIO; | ||
22 | mutex_lock(&compr_mutex); | ||
23 | err = zlib_deflateInit(&stream, COMPR_LEVEL); | ||
24 | if (err != Z_OK) | ||
25 | goto error; | ||
26 | |||
27 | stream.next_in = in; | ||
28 | stream.avail_in = inlen; | ||
29 | stream.total_in = 0; | ||
30 | stream.next_out = out; | ||
31 | stream.avail_out = outlen; | ||
32 | stream.total_out = 0; | ||
33 | |||
34 | err = zlib_deflate(&stream, Z_FINISH); | ||
35 | if (err != Z_STREAM_END) | ||
36 | goto error; | ||
37 | |||
38 | err = zlib_deflateEnd(&stream); | ||
39 | if (err != Z_OK) | ||
40 | goto error; | ||
41 | |||
42 | if (stream.total_out >= stream.total_in) | ||
43 | goto error; | ||
44 | |||
45 | ret = stream.total_out; | ||
46 | error: | ||
47 | mutex_unlock(&compr_mutex); | ||
48 | return ret; | ||
49 | } | ||
50 | |||
51 | int logfs_uncompress(void *in, void *out, size_t inlen, size_t outlen) | ||
52 | { | ||
53 | int err, ret; | ||
54 | |||
55 | ret = -EIO; | ||
56 | mutex_lock(&compr_mutex); | ||
57 | err = zlib_inflateInit(&stream); | ||
58 | if (err != Z_OK) | ||
59 | goto error; | ||
60 | |||
61 | stream.next_in = in; | ||
62 | stream.avail_in = inlen; | ||
63 | stream.total_in = 0; | ||
64 | stream.next_out = out; | ||
65 | stream.avail_out = outlen; | ||
66 | stream.total_out = 0; | ||
67 | |||
68 | err = zlib_inflate(&stream, Z_FINISH); | ||
69 | if (err != Z_STREAM_END) | ||
70 | goto error; | ||
71 | |||
72 | err = zlib_inflateEnd(&stream); | ||
73 | if (err != Z_OK) | ||
74 | goto error; | ||
75 | |||
76 | ret = 0; | ||
77 | error: | ||
78 | mutex_unlock(&compr_mutex); | ||
79 | return ret; | ||
80 | } | ||
81 | |||
82 | int __init logfs_compr_init(void) | ||
83 | { | ||
84 | size_t size = max(zlib_deflate_workspacesize(), | ||
85 | zlib_inflate_workspacesize()); | ||
86 | stream.workspace = vmalloc(size); | ||
87 | if (!stream.workspace) | ||
88 | return -ENOMEM; | ||
89 | return 0; | ||
90 | } | ||
91 | |||
92 | void logfs_compr_exit(void) | ||
93 | { | ||
94 | vfree(stream.workspace); | ||
95 | } | ||
diff --git a/fs/logfs/dev_bdev.c b/fs/logfs/dev_bdev.c new file mode 100644 index 000000000000..9718c22f186d --- /dev/null +++ b/fs/logfs/dev_bdev.c | |||
@@ -0,0 +1,327 @@ | |||
1 | /* | ||
2 | * fs/logfs/dev_bdev.c - Device access methods for block devices | ||
3 | * | ||
4 | * As should be obvious for Linux kernel code, license is GPLv2 | ||
5 | * | ||
6 | * Copyright (c) 2005-2008 Joern Engel <joern@logfs.org> | ||
7 | */ | ||
8 | #include "logfs.h" | ||
9 | #include <linux/bio.h> | ||
10 | #include <linux/blkdev.h> | ||
11 | #include <linux/buffer_head.h> | ||
12 | |||
13 | #define PAGE_OFS(ofs) ((ofs) & (PAGE_SIZE-1)) | ||
14 | |||
15 | static void request_complete(struct bio *bio, int err) | ||
16 | { | ||
17 | complete((struct completion *)bio->bi_private); | ||
18 | } | ||
19 | |||
20 | static int sync_request(struct page *page, struct block_device *bdev, int rw) | ||
21 | { | ||
22 | struct bio bio; | ||
23 | struct bio_vec bio_vec; | ||
24 | struct completion complete; | ||
25 | |||
26 | bio_init(&bio); | ||
27 | bio.bi_io_vec = &bio_vec; | ||
28 | bio_vec.bv_page = page; | ||
29 | bio_vec.bv_len = PAGE_SIZE; | ||
30 | bio_vec.bv_offset = 0; | ||
31 | bio.bi_vcnt = 1; | ||
32 | bio.bi_idx = 0; | ||
33 | bio.bi_size = PAGE_SIZE; | ||
34 | bio.bi_bdev = bdev; | ||
35 | bio.bi_sector = page->index * (PAGE_SIZE >> 9); | ||
36 | init_completion(&complete); | ||
37 | bio.bi_private = &complete; | ||
38 | bio.bi_end_io = request_complete; | ||
39 | |||
40 | submit_bio(rw, &bio); | ||
41 | generic_unplug_device(bdev_get_queue(bdev)); | ||
42 | wait_for_completion(&complete); | ||
43 | return test_bit(BIO_UPTODATE, &bio.bi_flags) ? 0 : -EIO; | ||
44 | } | ||
45 | |||
46 | static int bdev_readpage(void *_sb, struct page *page) | ||
47 | { | ||
48 | struct super_block *sb = _sb; | ||
49 | struct block_device *bdev = logfs_super(sb)->s_bdev; | ||
50 | int err; | ||
51 | |||
52 | err = sync_request(page, bdev, READ); | ||
53 | if (err) { | ||
54 | ClearPageUptodate(page); | ||
55 | SetPageError(page); | ||
56 | } else { | ||
57 | SetPageUptodate(page); | ||
58 | ClearPageError(page); | ||
59 | } | ||
60 | unlock_page(page); | ||
61 | return err; | ||
62 | } | ||
63 | |||
64 | static DECLARE_WAIT_QUEUE_HEAD(wq); | ||
65 | |||
66 | static void writeseg_end_io(struct bio *bio, int err) | ||
67 | { | ||
68 | const int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); | ||
69 | struct bio_vec *bvec = bio->bi_io_vec + bio->bi_vcnt - 1; | ||
70 | struct super_block *sb = bio->bi_private; | ||
71 | struct logfs_super *super = logfs_super(sb); | ||
72 | struct page *page; | ||
73 | |||
74 | BUG_ON(!uptodate); /* FIXME: Retry io or write elsewhere */ | ||
75 | BUG_ON(err); | ||
76 | BUG_ON(bio->bi_vcnt == 0); | ||
77 | do { | ||
78 | page = bvec->bv_page; | ||
79 | if (--bvec >= bio->bi_io_vec) | ||
80 | prefetchw(&bvec->bv_page->flags); | ||
81 | |||
82 | end_page_writeback(page); | ||
83 | } while (bvec >= bio->bi_io_vec); | ||
84 | bio_put(bio); | ||
85 | if (atomic_dec_and_test(&super->s_pending_writes)) | ||
86 | wake_up(&wq); | ||
87 | } | ||
88 | |||
89 | static int __bdev_writeseg(struct super_block *sb, u64 ofs, pgoff_t index, | ||
90 | size_t nr_pages) | ||
91 | { | ||
92 | struct logfs_super *super = logfs_super(sb); | ||
93 | struct address_space *mapping = super->s_mapping_inode->i_mapping; | ||
94 | struct bio *bio; | ||
95 | struct page *page; | ||
96 | struct request_queue *q = bdev_get_queue(sb->s_bdev); | ||
97 | unsigned int max_pages = queue_max_hw_sectors(q) >> (PAGE_SHIFT - 9); | ||
98 | int i; | ||
99 | |||
100 | bio = bio_alloc(GFP_NOFS, max_pages); | ||
101 | BUG_ON(!bio); /* FIXME: handle this */ | ||
102 | |||
103 | for (i = 0; i < nr_pages; i++) { | ||
104 | if (i >= max_pages) { | ||
105 | /* Block layer cannot split bios :( */ | ||
106 | bio->bi_vcnt = i; | ||
107 | bio->bi_idx = 0; | ||
108 | bio->bi_size = i * PAGE_SIZE; | ||
109 | bio->bi_bdev = super->s_bdev; | ||
110 | bio->bi_sector = ofs >> 9; | ||
111 | bio->bi_private = sb; | ||
112 | bio->bi_end_io = writeseg_end_io; | ||
113 | atomic_inc(&super->s_pending_writes); | ||
114 | submit_bio(WRITE, bio); | ||
115 | |||
116 | ofs += i * PAGE_SIZE; | ||
117 | index += i; | ||
118 | nr_pages -= i; | ||
119 | i = 0; | ||
120 | |||
121 | bio = bio_alloc(GFP_NOFS, max_pages); | ||
122 | BUG_ON(!bio); | ||
123 | } | ||
124 | page = find_lock_page(mapping, index + i); | ||
125 | BUG_ON(!page); | ||
126 | bio->bi_io_vec[i].bv_page = page; | ||
127 | bio->bi_io_vec[i].bv_len = PAGE_SIZE; | ||
128 | bio->bi_io_vec[i].bv_offset = 0; | ||
129 | |||
130 | BUG_ON(PageWriteback(page)); | ||
131 | set_page_writeback(page); | ||
132 | unlock_page(page); | ||
133 | } | ||
134 | bio->bi_vcnt = nr_pages; | ||
135 | bio->bi_idx = 0; | ||
136 | bio->bi_size = nr_pages * PAGE_SIZE; | ||
137 | bio->bi_bdev = super->s_bdev; | ||
138 | bio->bi_sector = ofs >> 9; | ||
139 | bio->bi_private = sb; | ||
140 | bio->bi_end_io = writeseg_end_io; | ||
141 | atomic_inc(&super->s_pending_writes); | ||
142 | submit_bio(WRITE, bio); | ||
143 | return 0; | ||
144 | } | ||
145 | |||
146 | static void bdev_writeseg(struct super_block *sb, u64 ofs, size_t len) | ||
147 | { | ||
148 | struct logfs_super *super = logfs_super(sb); | ||
149 | int head; | ||
150 | |||
151 | BUG_ON(super->s_flags & LOGFS_SB_FLAG_RO); | ||
152 | |||
153 | if (len == 0) { | ||
154 | /* This can happen when the object fit perfectly into a | ||
155 | * segment, the segment gets written per sync and subsequently | ||
156 | * closed. | ||
157 | */ | ||
158 | return; | ||
159 | } | ||
160 | head = ofs & (PAGE_SIZE - 1); | ||
161 | if (head) { | ||
162 | ofs -= head; | ||
163 | len += head; | ||
164 | } | ||
165 | len = PAGE_ALIGN(len); | ||
166 | __bdev_writeseg(sb, ofs, ofs >> PAGE_SHIFT, len >> PAGE_SHIFT); | ||
167 | generic_unplug_device(bdev_get_queue(logfs_super(sb)->s_bdev)); | ||
168 | } | ||
169 | |||
170 | |||
171 | static void erase_end_io(struct bio *bio, int err) | ||
172 | { | ||
173 | const int uptodate = test_bit(BIO_UPTODATE, &bio->bi_flags); | ||
174 | struct super_block *sb = bio->bi_private; | ||
175 | struct logfs_super *super = logfs_super(sb); | ||
176 | |||
177 | BUG_ON(!uptodate); /* FIXME: Retry io or write elsewhere */ | ||
178 | BUG_ON(err); | ||
179 | BUG_ON(bio->bi_vcnt == 0); | ||
180 | bio_put(bio); | ||
181 | if (atomic_dec_and_test(&super->s_pending_writes)) | ||
182 | wake_up(&wq); | ||
183 | } | ||
184 | |||
185 | static int do_erase(struct super_block *sb, u64 ofs, pgoff_t index, | ||
186 | size_t nr_pages) | ||
187 | { | ||
188 | struct logfs_super *super = logfs_super(sb); | ||
189 | struct bio *bio; | ||
190 | struct request_queue *q = bdev_get_queue(sb->s_bdev); | ||
191 | unsigned int max_pages = queue_max_hw_sectors(q) >> (PAGE_SHIFT - 9); | ||
192 | int i; | ||
193 | |||
194 | bio = bio_alloc(GFP_NOFS, max_pages); | ||
195 | BUG_ON(!bio); /* FIXME: handle this */ | ||
196 | |||
197 | for (i = 0; i < nr_pages; i++) { | ||
198 | if (i >= max_pages) { | ||
199 | /* Block layer cannot split bios :( */ | ||
200 | bio->bi_vcnt = i; | ||
201 | bio->bi_idx = 0; | ||
202 | bio->bi_size = i * PAGE_SIZE; | ||
203 | bio->bi_bdev = super->s_bdev; | ||
204 | bio->bi_sector = ofs >> 9; | ||
205 | bio->bi_private = sb; | ||
206 | bio->bi_end_io = erase_end_io; | ||
207 | atomic_inc(&super->s_pending_writes); | ||
208 | submit_bio(WRITE, bio); | ||
209 | |||
210 | ofs += i * PAGE_SIZE; | ||
211 | index += i; | ||
212 | nr_pages -= i; | ||
213 | i = 0; | ||
214 | |||
215 | bio = bio_alloc(GFP_NOFS, max_pages); | ||
216 | BUG_ON(!bio); | ||
217 | } | ||
218 | bio->bi_io_vec[i].bv_page = super->s_erase_page; | ||
219 | bio->bi_io_vec[i].bv_len = PAGE_SIZE; | ||
220 | bio->bi_io_vec[i].bv_offset = 0; | ||
221 | } | ||
222 | bio->bi_vcnt = nr_pages; | ||
223 | bio->bi_idx = 0; | ||
224 | bio->bi_size = nr_pages * PAGE_SIZE; | ||
225 | bio->bi_bdev = super->s_bdev; | ||
226 | bio->bi_sector = ofs >> 9; | ||
227 | bio->bi_private = sb; | ||
228 | bio->bi_end_io = erase_end_io; | ||
229 | atomic_inc(&super->s_pending_writes); | ||
230 | submit_bio(WRITE, bio); | ||
231 | return 0; | ||
232 | } | ||
233 | |||
234 | static int bdev_erase(struct super_block *sb, loff_t to, size_t len, | ||
235 | int ensure_write) | ||
236 | { | ||
237 | struct logfs_super *super = logfs_super(sb); | ||
238 | |||
239 | BUG_ON(to & (PAGE_SIZE - 1)); | ||
240 | BUG_ON(len & (PAGE_SIZE - 1)); | ||
241 | |||
242 | if (super->s_flags & LOGFS_SB_FLAG_RO) | ||
243 | return -EROFS; | ||
244 | |||
245 | if (ensure_write) { | ||
246 | /* | ||
247 | * Object store doesn't care whether erases happen or not. | ||
248 | * But for the journal they are required. Otherwise a scan | ||
249 | * can find an old commit entry and assume it is the current | ||
250 | * one, travelling back in time. | ||
251 | */ | ||
252 | do_erase(sb, to, to >> PAGE_SHIFT, len >> PAGE_SHIFT); | ||
253 | } | ||
254 | |||
255 | return 0; | ||
256 | } | ||
257 | |||
258 | static void bdev_sync(struct super_block *sb) | ||
259 | { | ||
260 | struct logfs_super *super = logfs_super(sb); | ||
261 | |||
262 | wait_event(wq, atomic_read(&super->s_pending_writes) == 0); | ||
263 | } | ||
264 | |||
265 | static struct page *bdev_find_first_sb(struct super_block *sb, u64 *ofs) | ||
266 | { | ||
267 | struct logfs_super *super = logfs_super(sb); | ||
268 | struct address_space *mapping = super->s_mapping_inode->i_mapping; | ||
269 | filler_t *filler = bdev_readpage; | ||
270 | |||
271 | *ofs = 0; | ||
272 | return read_cache_page(mapping, 0, filler, sb); | ||
273 | } | ||
274 | |||
275 | static struct page *bdev_find_last_sb(struct super_block *sb, u64 *ofs) | ||
276 | { | ||
277 | struct logfs_super *super = logfs_super(sb); | ||
278 | struct address_space *mapping = super->s_mapping_inode->i_mapping; | ||
279 | filler_t *filler = bdev_readpage; | ||
280 | u64 pos = (super->s_bdev->bd_inode->i_size & ~0xfffULL) - 0x1000; | ||
281 | pgoff_t index = pos >> PAGE_SHIFT; | ||
282 | |||
283 | *ofs = pos; | ||
284 | return read_cache_page(mapping, index, filler, sb); | ||
285 | } | ||
286 | |||
287 | static int bdev_write_sb(struct super_block *sb, struct page *page) | ||
288 | { | ||
289 | struct block_device *bdev = logfs_super(sb)->s_bdev; | ||
290 | |||
291 | /* Nothing special to do for block devices. */ | ||
292 | return sync_request(page, bdev, WRITE); | ||
293 | } | ||
294 | |||
295 | static void bdev_put_device(struct super_block *sb) | ||
296 | { | ||
297 | close_bdev_exclusive(logfs_super(sb)->s_bdev, FMODE_READ|FMODE_WRITE); | ||
298 | } | ||
299 | |||
300 | static const struct logfs_device_ops bd_devops = { | ||
301 | .find_first_sb = bdev_find_first_sb, | ||
302 | .find_last_sb = bdev_find_last_sb, | ||
303 | .write_sb = bdev_write_sb, | ||
304 | .readpage = bdev_readpage, | ||
305 | .writeseg = bdev_writeseg, | ||
306 | .erase = bdev_erase, | ||
307 | .sync = bdev_sync, | ||
308 | .put_device = bdev_put_device, | ||
309 | }; | ||
310 | |||
311 | int logfs_get_sb_bdev(struct file_system_type *type, int flags, | ||
312 | const char *devname, struct vfsmount *mnt) | ||
313 | { | ||
314 | struct block_device *bdev; | ||
315 | |||
316 | bdev = open_bdev_exclusive(devname, FMODE_READ|FMODE_WRITE, type); | ||
317 | if (IS_ERR(bdev)) | ||
318 | return PTR_ERR(bdev); | ||
319 | |||
320 | if (MAJOR(bdev->bd_dev) == MTD_BLOCK_MAJOR) { | ||
321 | int mtdnr = MINOR(bdev->bd_dev); | ||
322 | close_bdev_exclusive(bdev, FMODE_READ|FMODE_WRITE); | ||
323 | return logfs_get_sb_mtd(type, flags, mtdnr, mnt); | ||
324 | } | ||
325 | |||
326 | return logfs_get_sb_device(type, flags, NULL, bdev, &bd_devops, mnt); | ||
327 | } | ||
diff --git a/fs/logfs/dev_mtd.c b/fs/logfs/dev_mtd.c new file mode 100644 index 000000000000..cafb6ef2e05b --- /dev/null +++ b/fs/logfs/dev_mtd.c | |||
@@ -0,0 +1,254 @@ | |||
1 | /* | ||
2 | * fs/logfs/dev_mtd.c - Device access methods for MTD | ||
3 | * | ||
4 | * As should be obvious for Linux kernel code, license is GPLv2 | ||
5 | * | ||
6 | * Copyright (c) 2005-2008 Joern Engel <joern@logfs.org> | ||
7 | */ | ||
8 | #include "logfs.h" | ||
9 | #include <linux/completion.h> | ||
10 | #include <linux/mount.h> | ||
11 | #include <linux/sched.h> | ||
12 | |||
13 | #define PAGE_OFS(ofs) ((ofs) & (PAGE_SIZE-1)) | ||
14 | |||
15 | static int mtd_read(struct super_block *sb, loff_t ofs, size_t len, void *buf) | ||
16 | { | ||
17 | struct mtd_info *mtd = logfs_super(sb)->s_mtd; | ||
18 | size_t retlen; | ||
19 | int ret; | ||
20 | |||
21 | ret = mtd->read(mtd, ofs, len, &retlen, buf); | ||
22 | BUG_ON(ret == -EINVAL); | ||
23 | if (ret) | ||
24 | return ret; | ||
25 | |||
26 | /* Not sure if we should loop instead. */ | ||
27 | if (retlen != len) | ||
28 | return -EIO; | ||
29 | |||
30 | return 0; | ||
31 | } | ||
32 | |||
33 | static int mtd_write(struct super_block *sb, loff_t ofs, size_t len, void *buf) | ||
34 | { | ||
35 | struct logfs_super *super = logfs_super(sb); | ||
36 | struct mtd_info *mtd = super->s_mtd; | ||
37 | size_t retlen; | ||
38 | loff_t page_start, page_end; | ||
39 | int ret; | ||
40 | |||
41 | if (super->s_flags & LOGFS_SB_FLAG_RO) | ||
42 | return -EROFS; | ||
43 | |||
44 | BUG_ON((ofs >= mtd->size) || (len > mtd->size - ofs)); | ||
45 | BUG_ON(ofs != (ofs >> super->s_writeshift) << super->s_writeshift); | ||
46 | BUG_ON(len > PAGE_CACHE_SIZE); | ||
47 | page_start = ofs & PAGE_CACHE_MASK; | ||
48 | page_end = PAGE_CACHE_ALIGN(ofs + len) - 1; | ||
49 | ret = mtd->write(mtd, ofs, len, &retlen, buf); | ||
50 | if (ret || (retlen != len)) | ||
51 | return -EIO; | ||
52 | |||
53 | return 0; | ||
54 | } | ||
55 | |||
56 | /* | ||
57 | * For as long as I can remember (since about 2001) mtd->erase has been an | ||
58 | * asynchronous interface lacking the first driver to actually use the | ||
59 | * asynchronous properties. So just to prevent the first implementor of such | ||
60 | * a thing from breaking logfs in 2350, we do the usual pointless dance to | ||
61 | * declare a completion variable and wait for completion before returning | ||
62 | * from mtd_erase(). What an excercise in futility! | ||
63 | */ | ||
64 | static void logfs_erase_callback(struct erase_info *ei) | ||
65 | { | ||
66 | complete((struct completion *)ei->priv); | ||
67 | } | ||
68 | |||
69 | static int mtd_erase_mapping(struct super_block *sb, loff_t ofs, size_t len) | ||
70 | { | ||
71 | struct logfs_super *super = logfs_super(sb); | ||
72 | struct address_space *mapping = super->s_mapping_inode->i_mapping; | ||
73 | struct page *page; | ||
74 | pgoff_t index = ofs >> PAGE_SHIFT; | ||
75 | |||
76 | for (index = ofs >> PAGE_SHIFT; index < (ofs + len) >> PAGE_SHIFT; index++) { | ||
77 | page = find_get_page(mapping, index); | ||
78 | if (!page) | ||
79 | continue; | ||
80 | memset(page_address(page), 0xFF, PAGE_SIZE); | ||
81 | page_cache_release(page); | ||
82 | } | ||
83 | return 0; | ||
84 | } | ||
85 | |||
86 | static int mtd_erase(struct super_block *sb, loff_t ofs, size_t len, | ||
87 | int ensure_write) | ||
88 | { | ||
89 | struct mtd_info *mtd = logfs_super(sb)->s_mtd; | ||
90 | struct erase_info ei; | ||
91 | DECLARE_COMPLETION_ONSTACK(complete); | ||
92 | int ret; | ||
93 | |||
94 | BUG_ON(len % mtd->erasesize); | ||
95 | if (logfs_super(sb)->s_flags & LOGFS_SB_FLAG_RO) | ||
96 | return -EROFS; | ||
97 | |||
98 | memset(&ei, 0, sizeof(ei)); | ||
99 | ei.mtd = mtd; | ||
100 | ei.addr = ofs; | ||
101 | ei.len = len; | ||
102 | ei.callback = logfs_erase_callback; | ||
103 | ei.priv = (long)&complete; | ||
104 | ret = mtd->erase(mtd, &ei); | ||
105 | if (ret) | ||
106 | return -EIO; | ||
107 | |||
108 | wait_for_completion(&complete); | ||
109 | if (ei.state != MTD_ERASE_DONE) | ||
110 | return -EIO; | ||
111 | return mtd_erase_mapping(sb, ofs, len); | ||
112 | } | ||
113 | |||
114 | static void mtd_sync(struct super_block *sb) | ||
115 | { | ||
116 | struct mtd_info *mtd = logfs_super(sb)->s_mtd; | ||
117 | |||
118 | if (mtd->sync) | ||
119 | mtd->sync(mtd); | ||
120 | } | ||
121 | |||
122 | static int mtd_readpage(void *_sb, struct page *page) | ||
123 | { | ||
124 | struct super_block *sb = _sb; | ||
125 | int err; | ||
126 | |||
127 | err = mtd_read(sb, page->index << PAGE_SHIFT, PAGE_SIZE, | ||
128 | page_address(page)); | ||
129 | if (err == -EUCLEAN) { | ||
130 | err = 0; | ||
131 | /* FIXME: force GC this segment */ | ||
132 | } | ||
133 | if (err) { | ||
134 | ClearPageUptodate(page); | ||
135 | SetPageError(page); | ||
136 | } else { | ||
137 | SetPageUptodate(page); | ||
138 | ClearPageError(page); | ||
139 | } | ||
140 | unlock_page(page); | ||
141 | return err; | ||
142 | } | ||
143 | |||
144 | static struct page *mtd_find_first_sb(struct super_block *sb, u64 *ofs) | ||
145 | { | ||
146 | struct logfs_super *super = logfs_super(sb); | ||
147 | struct address_space *mapping = super->s_mapping_inode->i_mapping; | ||
148 | filler_t *filler = mtd_readpage; | ||
149 | struct mtd_info *mtd = super->s_mtd; | ||
150 | |||
151 | if (!mtd->block_isbad) | ||
152 | return NULL; | ||
153 | |||
154 | *ofs = 0; | ||
155 | while (mtd->block_isbad(mtd, *ofs)) { | ||
156 | *ofs += mtd->erasesize; | ||
157 | if (*ofs >= mtd->size) | ||
158 | return NULL; | ||
159 | } | ||
160 | BUG_ON(*ofs & ~PAGE_MASK); | ||
161 | return read_cache_page(mapping, *ofs >> PAGE_SHIFT, filler, sb); | ||
162 | } | ||
163 | |||
164 | static struct page *mtd_find_last_sb(struct super_block *sb, u64 *ofs) | ||
165 | { | ||
166 | struct logfs_super *super = logfs_super(sb); | ||
167 | struct address_space *mapping = super->s_mapping_inode->i_mapping; | ||
168 | filler_t *filler = mtd_readpage; | ||
169 | struct mtd_info *mtd = super->s_mtd; | ||
170 | |||
171 | if (!mtd->block_isbad) | ||
172 | return NULL; | ||
173 | |||
174 | *ofs = mtd->size - mtd->erasesize; | ||
175 | while (mtd->block_isbad(mtd, *ofs)) { | ||
176 | *ofs -= mtd->erasesize; | ||
177 | if (*ofs <= 0) | ||
178 | return NULL; | ||
179 | } | ||
180 | *ofs = *ofs + mtd->erasesize - 0x1000; | ||
181 | BUG_ON(*ofs & ~PAGE_MASK); | ||
182 | return read_cache_page(mapping, *ofs >> PAGE_SHIFT, filler, sb); | ||
183 | } | ||
184 | |||
185 | static int __mtd_writeseg(struct super_block *sb, u64 ofs, pgoff_t index, | ||
186 | size_t nr_pages) | ||
187 | { | ||
188 | struct logfs_super *super = logfs_super(sb); | ||
189 | struct address_space *mapping = super->s_mapping_inode->i_mapping; | ||
190 | struct page *page; | ||
191 | int i, err; | ||
192 | |||
193 | for (i = 0; i < nr_pages; i++) { | ||
194 | page = find_lock_page(mapping, index + i); | ||
195 | BUG_ON(!page); | ||
196 | |||
197 | err = mtd_write(sb, page->index << PAGE_SHIFT, PAGE_SIZE, | ||
198 | page_address(page)); | ||
199 | unlock_page(page); | ||
200 | page_cache_release(page); | ||
201 | if (err) | ||
202 | return err; | ||
203 | } | ||
204 | return 0; | ||
205 | } | ||
206 | |||
207 | static void mtd_writeseg(struct super_block *sb, u64 ofs, size_t len) | ||
208 | { | ||
209 | struct logfs_super *super = logfs_super(sb); | ||
210 | int head; | ||
211 | |||
212 | if (super->s_flags & LOGFS_SB_FLAG_RO) | ||
213 | return; | ||
214 | |||
215 | if (len == 0) { | ||
216 | /* This can happen when the object fit perfectly into a | ||
217 | * segment, the segment gets written per sync and subsequently | ||
218 | * closed. | ||
219 | */ | ||
220 | return; | ||
221 | } | ||
222 | head = ofs & (PAGE_SIZE - 1); | ||
223 | if (head) { | ||
224 | ofs -= head; | ||
225 | len += head; | ||
226 | } | ||
227 | len = PAGE_ALIGN(len); | ||
228 | __mtd_writeseg(sb, ofs, ofs >> PAGE_SHIFT, len >> PAGE_SHIFT); | ||
229 | } | ||
230 | |||
231 | static void mtd_put_device(struct super_block *sb) | ||
232 | { | ||
233 | put_mtd_device(logfs_super(sb)->s_mtd); | ||
234 | } | ||
235 | |||
236 | static const struct logfs_device_ops mtd_devops = { | ||
237 | .find_first_sb = mtd_find_first_sb, | ||
238 | .find_last_sb = mtd_find_last_sb, | ||
239 | .readpage = mtd_readpage, | ||
240 | .writeseg = mtd_writeseg, | ||
241 | .erase = mtd_erase, | ||
242 | .sync = mtd_sync, | ||
243 | .put_device = mtd_put_device, | ||
244 | }; | ||
245 | |||
246 | int logfs_get_sb_mtd(struct file_system_type *type, int flags, | ||
247 | int mtdnr, struct vfsmount *mnt) | ||
248 | { | ||
249 | struct mtd_info *mtd; | ||
250 | const struct logfs_device_ops *devops = &mtd_devops; | ||
251 | |||
252 | mtd = get_mtd_device(NULL, mtdnr); | ||
253 | return logfs_get_sb_device(type, flags, mtd, NULL, devops, mnt); | ||
254 | } | ||
diff --git a/fs/logfs/dir.c b/fs/logfs/dir.c new file mode 100644 index 000000000000..56a8bfbb0120 --- /dev/null +++ b/fs/logfs/dir.c | |||
@@ -0,0 +1,827 @@ | |||
1 | /* | ||
2 | * fs/logfs/dir.c - directory-related code | ||
3 | * | ||
4 | * As should be obvious for Linux kernel code, license is GPLv2 | ||
5 | * | ||
6 | * Copyright (c) 2005-2008 Joern Engel <joern@logfs.org> | ||
7 | */ | ||
8 | #include "logfs.h" | ||
9 | |||
10 | |||
11 | /* | ||
12 | * Atomic dir operations | ||
13 | * | ||
14 | * Directory operations are by default not atomic. Dentries and Inodes are | ||
15 | * created/removed/altered in seperate operations. Therefore we need to do | ||
16 | * a small amount of journaling. | ||
17 | * | ||
18 | * Create, link, mkdir, mknod and symlink all share the same function to do | ||
19 | * the work: __logfs_create. This function works in two atomic steps: | ||
20 | * 1. allocate inode (remember in journal) | ||
21 | * 2. allocate dentry (clear journal) | ||
22 | * | ||
23 | * As we can only get interrupted between the two, when the inode we just | ||
24 | * created is simply stored in the anchor. On next mount, if we were | ||
25 | * interrupted, we delete the inode. From a users point of view the | ||
26 | * operation never happened. | ||
27 | * | ||
28 | * Unlink and rmdir also share the same function: unlink. Again, this | ||
29 | * function works in two atomic steps | ||
30 | * 1. remove dentry (remember inode in journal) | ||
31 | * 2. unlink inode (clear journal) | ||
32 | * | ||
33 | * And again, on the next mount, if we were interrupted, we delete the inode. | ||
34 | * From a users point of view the operation succeeded. | ||
35 | * | ||
36 | * Rename is the real pain to deal with, harder than all the other methods | ||
37 | * combined. Depending on the circumstances we can run into three cases. | ||
38 | * A "target rename" where the target dentry already existed, a "local | ||
39 | * rename" where both parent directories are identical or a "cross-directory | ||
40 | * rename" in the remaining case. | ||
41 | * | ||
42 | * Local rename is atomic, as the old dentry is simply rewritten with a new | ||
43 | * name. | ||
44 | * | ||
45 | * Cross-directory rename works in two steps, similar to __logfs_create and | ||
46 | * logfs_unlink: | ||
47 | * 1. Write new dentry (remember old dentry in journal) | ||
48 | * 2. Remove old dentry (clear journal) | ||
49 | * | ||
50 | * Here we remember a dentry instead of an inode. On next mount, if we were | ||
51 | * interrupted, we delete the dentry. From a users point of view, the | ||
52 | * operation succeeded. | ||
53 | * | ||
54 | * Target rename works in three atomic steps: | ||
55 | * 1. Attach old inode to new dentry (remember old dentry and new inode) | ||
56 | * 2. Remove old dentry (still remember the new inode) | ||
57 | * 3. Remove victim inode | ||
58 | * | ||
59 | * Here we remember both an inode an a dentry. If we get interrupted | ||
60 | * between steps 1 and 2, we delete both the dentry and the inode. If | ||
61 | * we get interrupted between steps 2 and 3, we delete just the inode. | ||
62 | * In either case, the remaining objects are deleted on next mount. From | ||
63 | * a users point of view, the operation succeeded. | ||
64 | */ | ||
65 | |||
66 | static int write_dir(struct inode *dir, struct logfs_disk_dentry *dd, | ||
67 | loff_t pos) | ||
68 | { | ||
69 | return logfs_inode_write(dir, dd, sizeof(*dd), pos, WF_LOCK, NULL); | ||
70 | } | ||
71 | |||
72 | static int write_inode(struct inode *inode) | ||
73 | { | ||
74 | return __logfs_write_inode(inode, WF_LOCK); | ||
75 | } | ||
76 | |||
77 | static s64 dir_seek_data(struct inode *inode, s64 pos) | ||
78 | { | ||
79 | s64 new_pos = logfs_seek_data(inode, pos); | ||
80 | |||
81 | return max(pos, new_pos - 1); | ||
82 | } | ||
83 | |||
84 | static int beyond_eof(struct inode *inode, loff_t bix) | ||
85 | { | ||
86 | loff_t pos = bix << inode->i_sb->s_blocksize_bits; | ||
87 | return pos >= i_size_read(inode); | ||
88 | } | ||
89 | |||
90 | /* | ||
91 | * Prime value was chosen to be roughly 256 + 26. r5 hash uses 11, | ||
92 | * so short names (len <= 9) don't even occupy the complete 32bit name | ||
93 | * space. A prime >256 ensures short names quickly spread the 32bit | ||
94 | * name space. Add about 26 for the estimated amount of information | ||
95 | * of each character and pick a prime nearby, preferrably a bit-sparse | ||
96 | * one. | ||
97 | */ | ||
98 | static u32 hash_32(const char *s, int len, u32 seed) | ||
99 | { | ||
100 | u32 hash = seed; | ||
101 | int i; | ||
102 | |||
103 | for (i = 0; i < len; i++) | ||
104 | hash = hash * 293 + s[i]; | ||
105 | return hash; | ||
106 | } | ||
107 | |||
108 | /* | ||
109 | * We have to satisfy several conflicting requirements here. Small | ||
110 | * directories should stay fairly compact and not require too many | ||
111 | * indirect blocks. The number of possible locations for a given hash | ||
112 | * should be small to make lookup() fast. And we should try hard not | ||
113 | * to overflow the 32bit name space or nfs and 32bit host systems will | ||
114 | * be unhappy. | ||
115 | * | ||
116 | * So we use the following scheme. First we reduce the hash to 0..15 | ||
117 | * and try a direct block. If that is occupied we reduce the hash to | ||
118 | * 16..255 and try an indirect block. Same for 2x and 3x indirect | ||
119 | * blocks. Lastly we reduce the hash to 0x800_0000 .. 0xffff_ffff, | ||
120 | * but use buckets containing eight entries instead of a single one. | ||
121 | * | ||
122 | * Using 16 entries should allow for a reasonable amount of hash | ||
123 | * collisions, so the 32bit name space can be packed fairly tight | ||
124 | * before overflowing. Oh and currently we don't overflow but return | ||
125 | * and error. | ||
126 | * | ||
127 | * How likely are collisions? Doing the appropriate math is beyond me | ||
128 | * and the Bronstein textbook. But running a test program to brute | ||
129 | * force collisions for a couple of days showed that on average the | ||
130 | * first collision occurs after 598M entries, with 290M being the | ||
131 | * smallest result. Obviously 21 entries could already cause a | ||
132 | * collision if all entries are carefully chosen. | ||
133 | */ | ||
134 | static pgoff_t hash_index(u32 hash, int round) | ||
135 | { | ||
136 | u32 i0_blocks = I0_BLOCKS; | ||
137 | u32 i1_blocks = I1_BLOCKS; | ||
138 | u32 i2_blocks = I2_BLOCKS; | ||
139 | u32 i3_blocks = I3_BLOCKS; | ||
140 | |||
141 | switch (round) { | ||
142 | case 0: | ||
143 | return hash % i0_blocks; | ||
144 | case 1: | ||
145 | return i0_blocks + hash % (i1_blocks - i0_blocks); | ||
146 | case 2: | ||
147 | return i1_blocks + hash % (i2_blocks - i1_blocks); | ||
148 | case 3: | ||
149 | return i2_blocks + hash % (i3_blocks - i2_blocks); | ||
150 | case 4 ... 19: | ||
151 | return i3_blocks + 16 * (hash % (((1<<31) - i3_blocks) / 16)) | ||
152 | + round - 4; | ||
153 | } | ||
154 | BUG(); | ||
155 | } | ||
156 | |||
157 | static struct page *logfs_get_dd_page(struct inode *dir, struct dentry *dentry) | ||
158 | { | ||
159 | struct qstr *name = &dentry->d_name; | ||
160 | struct page *page; | ||
161 | struct logfs_disk_dentry *dd; | ||
162 | u32 hash = hash_32(name->name, name->len, 0); | ||
163 | pgoff_t index; | ||
164 | int round; | ||
165 | |||
166 | if (name->len > LOGFS_MAX_NAMELEN) | ||
167 | return ERR_PTR(-ENAMETOOLONG); | ||
168 | |||
169 | for (round = 0; round < 20; round++) { | ||
170 | index = hash_index(hash, round); | ||
171 | |||
172 | if (beyond_eof(dir, index)) | ||
173 | return NULL; | ||
174 | if (!logfs_exist_block(dir, index)) | ||
175 | continue; | ||
176 | page = read_cache_page(dir->i_mapping, index, | ||
177 | (filler_t *)logfs_readpage, NULL); | ||
178 | if (IS_ERR(page)) | ||
179 | return page; | ||
180 | dd = kmap_atomic(page, KM_USER0); | ||
181 | BUG_ON(dd->namelen == 0); | ||
182 | |||
183 | if (name->len != be16_to_cpu(dd->namelen) || | ||
184 | memcmp(name->name, dd->name, name->len)) { | ||
185 | kunmap_atomic(dd, KM_USER0); | ||
186 | page_cache_release(page); | ||
187 | continue; | ||
188 | } | ||
189 | |||
190 | kunmap_atomic(dd, KM_USER0); | ||
191 | return page; | ||
192 | } | ||
193 | return NULL; | ||
194 | } | ||
195 | |||
196 | static int logfs_remove_inode(struct inode *inode) | ||
197 | { | ||
198 | int ret; | ||
199 | |||
200 | inode->i_nlink--; | ||
201 | ret = write_inode(inode); | ||
202 | LOGFS_BUG_ON(ret, inode->i_sb); | ||
203 | return ret; | ||
204 | } | ||
205 | |||
206 | static void abort_transaction(struct inode *inode, struct logfs_transaction *ta) | ||
207 | { | ||
208 | if (logfs_inode(inode)->li_block) | ||
209 | logfs_inode(inode)->li_block->ta = NULL; | ||
210 | kfree(ta); | ||
211 | } | ||
212 | |||
213 | static int logfs_unlink(struct inode *dir, struct dentry *dentry) | ||
214 | { | ||
215 | struct logfs_super *super = logfs_super(dir->i_sb); | ||
216 | struct inode *inode = dentry->d_inode; | ||
217 | struct logfs_transaction *ta; | ||
218 | struct page *page; | ||
219 | pgoff_t index; | ||
220 | int ret; | ||
221 | |||
222 | ta = kzalloc(sizeof(*ta), GFP_KERNEL); | ||
223 | if (!ta) | ||
224 | return -ENOMEM; | ||
225 | |||
226 | ta->state = UNLINK_1; | ||
227 | ta->ino = inode->i_ino; | ||
228 | |||
229 | inode->i_ctime = dir->i_ctime = dir->i_mtime = CURRENT_TIME; | ||
230 | |||
231 | page = logfs_get_dd_page(dir, dentry); | ||
232 | if (!page) { | ||
233 | kfree(ta); | ||
234 | return -ENOENT; | ||
235 | } | ||
236 | if (IS_ERR(page)) { | ||
237 | kfree(ta); | ||
238 | return PTR_ERR(page); | ||
239 | } | ||
240 | index = page->index; | ||
241 | page_cache_release(page); | ||
242 | |||
243 | mutex_lock(&super->s_dirop_mutex); | ||
244 | logfs_add_transaction(dir, ta); | ||
245 | |||
246 | ret = logfs_delete(dir, index, NULL); | ||
247 | if (!ret) | ||
248 | ret = write_inode(dir); | ||
249 | |||
250 | if (ret) { | ||
251 | abort_transaction(dir, ta); | ||
252 | printk(KERN_ERR"LOGFS: unable to delete inode\n"); | ||
253 | goto out; | ||
254 | } | ||
255 | |||
256 | ta->state = UNLINK_2; | ||
257 | logfs_add_transaction(inode, ta); | ||
258 | ret = logfs_remove_inode(inode); | ||
259 | out: | ||
260 | mutex_unlock(&super->s_dirop_mutex); | ||
261 | return ret; | ||
262 | } | ||
263 | |||
264 | static inline int logfs_empty_dir(struct inode *dir) | ||
265 | { | ||
266 | u64 data; | ||
267 | |||
268 | data = logfs_seek_data(dir, 0) << dir->i_sb->s_blocksize_bits; | ||
269 | return data >= i_size_read(dir); | ||
270 | } | ||
271 | |||
272 | static int logfs_rmdir(struct inode *dir, struct dentry *dentry) | ||
273 | { | ||
274 | struct inode *inode = dentry->d_inode; | ||
275 | |||
276 | if (!logfs_empty_dir(inode)) | ||
277 | return -ENOTEMPTY; | ||
278 | |||
279 | return logfs_unlink(dir, dentry); | ||
280 | } | ||
281 | |||
282 | /* FIXME: readdir currently has it's own dir_walk code. I don't see a good | ||
283 | * way to combine the two copies */ | ||
284 | #define IMPLICIT_NODES 2 | ||
285 | static int __logfs_readdir(struct file *file, void *buf, filldir_t filldir) | ||
286 | { | ||
287 | struct inode *dir = file->f_dentry->d_inode; | ||
288 | loff_t pos = file->f_pos - IMPLICIT_NODES; | ||
289 | struct page *page; | ||
290 | struct logfs_disk_dentry *dd; | ||
291 | int full; | ||
292 | |||
293 | BUG_ON(pos < 0); | ||
294 | for (;; pos++) { | ||
295 | if (beyond_eof(dir, pos)) | ||
296 | break; | ||
297 | if (!logfs_exist_block(dir, pos)) { | ||
298 | /* deleted dentry */ | ||
299 | pos = dir_seek_data(dir, pos); | ||
300 | continue; | ||
301 | } | ||
302 | page = read_cache_page(dir->i_mapping, pos, | ||
303 | (filler_t *)logfs_readpage, NULL); | ||
304 | if (IS_ERR(page)) | ||
305 | return PTR_ERR(page); | ||
306 | dd = kmap_atomic(page, KM_USER0); | ||
307 | BUG_ON(dd->namelen == 0); | ||
308 | |||
309 | full = filldir(buf, (char *)dd->name, be16_to_cpu(dd->namelen), | ||
310 | pos, be64_to_cpu(dd->ino), dd->type); | ||
311 | kunmap_atomic(dd, KM_USER0); | ||
312 | page_cache_release(page); | ||
313 | if (full) | ||
314 | break; | ||
315 | } | ||
316 | |||
317 | file->f_pos = pos + IMPLICIT_NODES; | ||
318 | return 0; | ||
319 | } | ||
320 | |||
321 | static int logfs_readdir(struct file *file, void *buf, filldir_t filldir) | ||
322 | { | ||
323 | struct inode *inode = file->f_dentry->d_inode; | ||
324 | ino_t pino = parent_ino(file->f_dentry); | ||
325 | int err; | ||
326 | |||
327 | if (file->f_pos < 0) | ||
328 | return -EINVAL; | ||
329 | |||
330 | if (file->f_pos == 0) { | ||
331 | if (filldir(buf, ".", 1, 1, inode->i_ino, DT_DIR) < 0) | ||
332 | return 0; | ||
333 | file->f_pos++; | ||
334 | } | ||
335 | if (file->f_pos == 1) { | ||
336 | if (filldir(buf, "..", 2, 2, pino, DT_DIR) < 0) | ||
337 | return 0; | ||
338 | file->f_pos++; | ||
339 | } | ||
340 | |||
341 | err = __logfs_readdir(file, buf, filldir); | ||
342 | return err; | ||
343 | } | ||
344 | |||
345 | static void logfs_set_name(struct logfs_disk_dentry *dd, struct qstr *name) | ||
346 | { | ||
347 | dd->namelen = cpu_to_be16(name->len); | ||
348 | memcpy(dd->name, name->name, name->len); | ||
349 | } | ||
350 | |||
351 | static struct dentry *logfs_lookup(struct inode *dir, struct dentry *dentry, | ||
352 | struct nameidata *nd) | ||
353 | { | ||
354 | struct page *page; | ||
355 | struct logfs_disk_dentry *dd; | ||
356 | pgoff_t index; | ||
357 | u64 ino = 0; | ||
358 | struct inode *inode; | ||
359 | |||
360 | page = logfs_get_dd_page(dir, dentry); | ||
361 | if (IS_ERR(page)) | ||
362 | return ERR_CAST(page); | ||
363 | if (!page) { | ||
364 | d_add(dentry, NULL); | ||
365 | return NULL; | ||
366 | } | ||
367 | index = page->index; | ||
368 | dd = kmap_atomic(page, KM_USER0); | ||
369 | ino = be64_to_cpu(dd->ino); | ||
370 | kunmap_atomic(dd, KM_USER0); | ||
371 | page_cache_release(page); | ||
372 | |||
373 | inode = logfs_iget(dir->i_sb, ino); | ||
374 | if (IS_ERR(inode)) { | ||
375 | printk(KERN_ERR"LogFS: Cannot read inode #%llx for dentry (%lx, %lx)n", | ||
376 | ino, dir->i_ino, index); | ||
377 | return ERR_CAST(inode); | ||
378 | } | ||
379 | return d_splice_alias(inode, dentry); | ||
380 | } | ||
381 | |||
382 | static void grow_dir(struct inode *dir, loff_t index) | ||
383 | { | ||
384 | index = (index + 1) << dir->i_sb->s_blocksize_bits; | ||
385 | if (i_size_read(dir) < index) | ||
386 | i_size_write(dir, index); | ||
387 | } | ||
388 | |||
389 | static int logfs_write_dir(struct inode *dir, struct dentry *dentry, | ||
390 | struct inode *inode) | ||
391 | { | ||
392 | struct page *page; | ||
393 | struct logfs_disk_dentry *dd; | ||
394 | u32 hash = hash_32(dentry->d_name.name, dentry->d_name.len, 0); | ||
395 | pgoff_t index; | ||
396 | int round, err; | ||
397 | |||
398 | for (round = 0; round < 20; round++) { | ||
399 | index = hash_index(hash, round); | ||
400 | |||
401 | if (logfs_exist_block(dir, index)) | ||
402 | continue; | ||
403 | page = find_or_create_page(dir->i_mapping, index, GFP_KERNEL); | ||
404 | if (!page) | ||
405 | return -ENOMEM; | ||
406 | |||
407 | dd = kmap_atomic(page, KM_USER0); | ||
408 | memset(dd, 0, sizeof(*dd)); | ||
409 | dd->ino = cpu_to_be64(inode->i_ino); | ||
410 | dd->type = logfs_type(inode); | ||
411 | logfs_set_name(dd, &dentry->d_name); | ||
412 | kunmap_atomic(dd, KM_USER0); | ||
413 | |||
414 | err = logfs_write_buf(dir, page, WF_LOCK); | ||
415 | unlock_page(page); | ||
416 | page_cache_release(page); | ||
417 | if (!err) | ||
418 | grow_dir(dir, index); | ||
419 | return err; | ||
420 | } | ||
421 | /* FIXME: Is there a better return value? In most cases neither | ||
422 | * the filesystem nor the directory are full. But we have had | ||
423 | * too many collisions for this particular hash and no fallback. | ||
424 | */ | ||
425 | return -ENOSPC; | ||
426 | } | ||
427 | |||
428 | static int __logfs_create(struct inode *dir, struct dentry *dentry, | ||
429 | struct inode *inode, const char *dest, long destlen) | ||
430 | { | ||
431 | struct logfs_super *super = logfs_super(dir->i_sb); | ||
432 | struct logfs_inode *li = logfs_inode(inode); | ||
433 | struct logfs_transaction *ta; | ||
434 | int ret; | ||
435 | |||
436 | ta = kzalloc(sizeof(*ta), GFP_KERNEL); | ||
437 | if (!ta) | ||
438 | return -ENOMEM; | ||
439 | |||
440 | ta->state = CREATE_1; | ||
441 | ta->ino = inode->i_ino; | ||
442 | mutex_lock(&super->s_dirop_mutex); | ||
443 | logfs_add_transaction(inode, ta); | ||
444 | |||
445 | if (dest) { | ||
446 | /* symlink */ | ||
447 | ret = logfs_inode_write(inode, dest, destlen, 0, WF_LOCK, NULL); | ||
448 | if (!ret) | ||
449 | ret = write_inode(inode); | ||
450 | } else { | ||
451 | /* creat/mkdir/mknod */ | ||
452 | ret = write_inode(inode); | ||
453 | } | ||
454 | if (ret) { | ||
455 | abort_transaction(inode, ta); | ||
456 | li->li_flags |= LOGFS_IF_STILLBORN; | ||
457 | /* FIXME: truncate symlink */ | ||
458 | inode->i_nlink--; | ||
459 | iput(inode); | ||
460 | goto out; | ||
461 | } | ||
462 | |||
463 | ta->state = CREATE_2; | ||
464 | logfs_add_transaction(dir, ta); | ||
465 | ret = logfs_write_dir(dir, dentry, inode); | ||
466 | /* sync directory */ | ||
467 | if (!ret) | ||
468 | ret = write_inode(dir); | ||
469 | |||
470 | if (ret) { | ||
471 | logfs_del_transaction(dir, ta); | ||
472 | ta->state = CREATE_2; | ||
473 | logfs_add_transaction(inode, ta); | ||
474 | logfs_remove_inode(inode); | ||
475 | iput(inode); | ||
476 | goto out; | ||
477 | } | ||
478 | d_instantiate(dentry, inode); | ||
479 | out: | ||
480 | mutex_unlock(&super->s_dirop_mutex); | ||
481 | return ret; | ||
482 | } | ||
483 | |||
484 | static int logfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | ||
485 | { | ||
486 | struct inode *inode; | ||
487 | |||
488 | /* | ||
489 | * FIXME: why do we have to fill in S_IFDIR, while the mode is | ||
490 | * correct for mknod, creat, etc.? Smells like the vfs *should* | ||
491 | * do it for us but for some reason fails to do so. | ||
492 | */ | ||
493 | inode = logfs_new_inode(dir, S_IFDIR | mode); | ||
494 | if (IS_ERR(inode)) | ||
495 | return PTR_ERR(inode); | ||
496 | |||
497 | inode->i_op = &logfs_dir_iops; | ||
498 | inode->i_fop = &logfs_dir_fops; | ||
499 | |||
500 | return __logfs_create(dir, dentry, inode, NULL, 0); | ||
501 | } | ||
502 | |||
503 | static int logfs_create(struct inode *dir, struct dentry *dentry, int mode, | ||
504 | struct nameidata *nd) | ||
505 | { | ||
506 | struct inode *inode; | ||
507 | |||
508 | inode = logfs_new_inode(dir, mode); | ||
509 | if (IS_ERR(inode)) | ||
510 | return PTR_ERR(inode); | ||
511 | |||
512 | inode->i_op = &logfs_reg_iops; | ||
513 | inode->i_fop = &logfs_reg_fops; | ||
514 | inode->i_mapping->a_ops = &logfs_reg_aops; | ||
515 | |||
516 | return __logfs_create(dir, dentry, inode, NULL, 0); | ||
517 | } | ||
518 | |||
519 | static int logfs_mknod(struct inode *dir, struct dentry *dentry, int mode, | ||
520 | dev_t rdev) | ||
521 | { | ||
522 | struct inode *inode; | ||
523 | |||
524 | if (dentry->d_name.len > LOGFS_MAX_NAMELEN) | ||
525 | return -ENAMETOOLONG; | ||
526 | |||
527 | inode = logfs_new_inode(dir, mode); | ||
528 | if (IS_ERR(inode)) | ||
529 | return PTR_ERR(inode); | ||
530 | |||
531 | init_special_inode(inode, mode, rdev); | ||
532 | |||
533 | return __logfs_create(dir, dentry, inode, NULL, 0); | ||
534 | } | ||
535 | |||
536 | static int logfs_symlink(struct inode *dir, struct dentry *dentry, | ||
537 | const char *target) | ||
538 | { | ||
539 | struct inode *inode; | ||
540 | size_t destlen = strlen(target) + 1; | ||
541 | |||
542 | if (destlen > dir->i_sb->s_blocksize) | ||
543 | return -ENAMETOOLONG; | ||
544 | |||
545 | inode = logfs_new_inode(dir, S_IFLNK | 0777); | ||
546 | if (IS_ERR(inode)) | ||
547 | return PTR_ERR(inode); | ||
548 | |||
549 | inode->i_op = &logfs_symlink_iops; | ||
550 | inode->i_mapping->a_ops = &logfs_reg_aops; | ||
551 | |||
552 | return __logfs_create(dir, dentry, inode, target, destlen); | ||
553 | } | ||
554 | |||
555 | static int logfs_permission(struct inode *inode, int mask) | ||
556 | { | ||
557 | return generic_permission(inode, mask, NULL); | ||
558 | } | ||
559 | |||
560 | static int logfs_link(struct dentry *old_dentry, struct inode *dir, | ||
561 | struct dentry *dentry) | ||
562 | { | ||
563 | struct inode *inode = old_dentry->d_inode; | ||
564 | |||
565 | if (inode->i_nlink >= LOGFS_LINK_MAX) | ||
566 | return -EMLINK; | ||
567 | |||
568 | inode->i_ctime = dir->i_ctime = dir->i_mtime = CURRENT_TIME; | ||
569 | atomic_inc(&inode->i_count); | ||
570 | inode->i_nlink++; | ||
571 | mark_inode_dirty_sync(inode); | ||
572 | |||
573 | return __logfs_create(dir, dentry, inode, NULL, 0); | ||
574 | } | ||
575 | |||
576 | static int logfs_get_dd(struct inode *dir, struct dentry *dentry, | ||
577 | struct logfs_disk_dentry *dd, loff_t *pos) | ||
578 | { | ||
579 | struct page *page; | ||
580 | void *map; | ||
581 | |||
582 | page = logfs_get_dd_page(dir, dentry); | ||
583 | if (IS_ERR(page)) | ||
584 | return PTR_ERR(page); | ||
585 | *pos = page->index; | ||
586 | map = kmap_atomic(page, KM_USER0); | ||
587 | memcpy(dd, map, sizeof(*dd)); | ||
588 | kunmap_atomic(map, KM_USER0); | ||
589 | page_cache_release(page); | ||
590 | return 0; | ||
591 | } | ||
592 | |||
593 | static int logfs_delete_dd(struct inode *dir, loff_t pos) | ||
594 | { | ||
595 | /* | ||
596 | * Getting called with pos somewhere beyond eof is either a goofup | ||
597 | * within this file or means someone maliciously edited the | ||
598 | * (crc-protected) journal. | ||
599 | */ | ||
600 | BUG_ON(beyond_eof(dir, pos)); | ||
601 | dir->i_ctime = dir->i_mtime = CURRENT_TIME; | ||
602 | log_dir(" Delete dentry (%lx, %llx)\n", dir->i_ino, pos); | ||
603 | return logfs_delete(dir, pos, NULL); | ||
604 | } | ||
605 | |||
606 | /* | ||
607 | * Cross-directory rename, target does not exist. Just a little nasty. | ||
608 | * Create a new dentry in the target dir, then remove the old dentry, | ||
609 | * all the while taking care to remember our operation in the journal. | ||
610 | */ | ||
611 | static int logfs_rename_cross(struct inode *old_dir, struct dentry *old_dentry, | ||
612 | struct inode *new_dir, struct dentry *new_dentry) | ||
613 | { | ||
614 | struct logfs_super *super = logfs_super(old_dir->i_sb); | ||
615 | struct logfs_disk_dentry dd; | ||
616 | struct logfs_transaction *ta; | ||
617 | loff_t pos; | ||
618 | int err; | ||
619 | |||
620 | /* 1. locate source dd */ | ||
621 | err = logfs_get_dd(old_dir, old_dentry, &dd, &pos); | ||
622 | if (err) | ||
623 | return err; | ||
624 | |||
625 | ta = kzalloc(sizeof(*ta), GFP_KERNEL); | ||
626 | if (!ta) | ||
627 | return -ENOMEM; | ||
628 | |||
629 | ta->state = CROSS_RENAME_1; | ||
630 | ta->dir = old_dir->i_ino; | ||
631 | ta->pos = pos; | ||
632 | |||
633 | /* 2. write target dd */ | ||
634 | mutex_lock(&super->s_dirop_mutex); | ||
635 | logfs_add_transaction(new_dir, ta); | ||
636 | err = logfs_write_dir(new_dir, new_dentry, old_dentry->d_inode); | ||
637 | if (!err) | ||
638 | err = write_inode(new_dir); | ||
639 | |||
640 | if (err) { | ||
641 | super->s_rename_dir = 0; | ||
642 | super->s_rename_pos = 0; | ||
643 | abort_transaction(new_dir, ta); | ||
644 | goto out; | ||
645 | } | ||
646 | |||
647 | /* 3. remove source dd */ | ||
648 | ta->state = CROSS_RENAME_2; | ||
649 | logfs_add_transaction(old_dir, ta); | ||
650 | err = logfs_delete_dd(old_dir, pos); | ||
651 | if (!err) | ||
652 | err = write_inode(old_dir); | ||
653 | LOGFS_BUG_ON(err, old_dir->i_sb); | ||
654 | out: | ||
655 | mutex_unlock(&super->s_dirop_mutex); | ||
656 | return err; | ||
657 | } | ||
658 | |||
659 | static int logfs_replace_inode(struct inode *dir, struct dentry *dentry, | ||
660 | struct logfs_disk_dentry *dd, struct inode *inode) | ||
661 | { | ||
662 | loff_t pos; | ||
663 | int err; | ||
664 | |||
665 | err = logfs_get_dd(dir, dentry, dd, &pos); | ||
666 | if (err) | ||
667 | return err; | ||
668 | dd->ino = cpu_to_be64(inode->i_ino); | ||
669 | dd->type = logfs_type(inode); | ||
670 | |||
671 | err = write_dir(dir, dd, pos); | ||
672 | if (err) | ||
673 | return err; | ||
674 | log_dir("Replace dentry (%lx, %llx) %s -> %llx\n", dir->i_ino, pos, | ||
675 | dd->name, be64_to_cpu(dd->ino)); | ||
676 | return write_inode(dir); | ||
677 | } | ||
678 | |||
679 | /* Target dentry exists - the worst case. We need to attach the source | ||
680 | * inode to the target dentry, then remove the orphaned target inode and | ||
681 | * source dentry. | ||
682 | */ | ||
683 | static int logfs_rename_target(struct inode *old_dir, struct dentry *old_dentry, | ||
684 | struct inode *new_dir, struct dentry *new_dentry) | ||
685 | { | ||
686 | struct logfs_super *super = logfs_super(old_dir->i_sb); | ||
687 | struct inode *old_inode = old_dentry->d_inode; | ||
688 | struct inode *new_inode = new_dentry->d_inode; | ||
689 | int isdir = S_ISDIR(old_inode->i_mode); | ||
690 | struct logfs_disk_dentry dd; | ||
691 | struct logfs_transaction *ta; | ||
692 | loff_t pos; | ||
693 | int err; | ||
694 | |||
695 | BUG_ON(isdir != S_ISDIR(new_inode->i_mode)); | ||
696 | if (isdir) { | ||
697 | if (!logfs_empty_dir(new_inode)) | ||
698 | return -ENOTEMPTY; | ||
699 | } | ||
700 | |||
701 | /* 1. locate source dd */ | ||
702 | err = logfs_get_dd(old_dir, old_dentry, &dd, &pos); | ||
703 | if (err) | ||
704 | return err; | ||
705 | |||
706 | ta = kzalloc(sizeof(*ta), GFP_KERNEL); | ||
707 | if (!ta) | ||
708 | return -ENOMEM; | ||
709 | |||
710 | ta->state = TARGET_RENAME_1; | ||
711 | ta->dir = old_dir->i_ino; | ||
712 | ta->pos = pos; | ||
713 | ta->ino = new_inode->i_ino; | ||
714 | |||
715 | /* 2. attach source inode to target dd */ | ||
716 | mutex_lock(&super->s_dirop_mutex); | ||
717 | logfs_add_transaction(new_dir, ta); | ||
718 | err = logfs_replace_inode(new_dir, new_dentry, &dd, old_inode); | ||
719 | if (err) { | ||
720 | super->s_rename_dir = 0; | ||
721 | super->s_rename_pos = 0; | ||
722 | super->s_victim_ino = 0; | ||
723 | abort_transaction(new_dir, ta); | ||
724 | goto out; | ||
725 | } | ||
726 | |||
727 | /* 3. remove source dd */ | ||
728 | ta->state = TARGET_RENAME_2; | ||
729 | logfs_add_transaction(old_dir, ta); | ||
730 | err = logfs_delete_dd(old_dir, pos); | ||
731 | if (!err) | ||
732 | err = write_inode(old_dir); | ||
733 | LOGFS_BUG_ON(err, old_dir->i_sb); | ||
734 | |||
735 | /* 4. remove target inode */ | ||
736 | ta->state = TARGET_RENAME_3; | ||
737 | logfs_add_transaction(new_inode, ta); | ||
738 | err = logfs_remove_inode(new_inode); | ||
739 | |||
740 | out: | ||
741 | mutex_unlock(&super->s_dirop_mutex); | ||
742 | return err; | ||
743 | } | ||
744 | |||
745 | static int logfs_rename(struct inode *old_dir, struct dentry *old_dentry, | ||
746 | struct inode *new_dir, struct dentry *new_dentry) | ||
747 | { | ||
748 | if (new_dentry->d_inode) | ||
749 | return logfs_rename_target(old_dir, old_dentry, | ||
750 | new_dir, new_dentry); | ||
751 | return logfs_rename_cross(old_dir, old_dentry, new_dir, new_dentry); | ||
752 | } | ||
753 | |||
754 | /* No locking done here, as this is called before .get_sb() returns. */ | ||
755 | int logfs_replay_journal(struct super_block *sb) | ||
756 | { | ||
757 | struct logfs_super *super = logfs_super(sb); | ||
758 | struct inode *inode; | ||
759 | u64 ino, pos; | ||
760 | int err; | ||
761 | |||
762 | if (super->s_victim_ino) { | ||
763 | /* delete victim inode */ | ||
764 | ino = super->s_victim_ino; | ||
765 | printk(KERN_INFO"LogFS: delete unmapped inode #%llx\n", ino); | ||
766 | inode = logfs_iget(sb, ino); | ||
767 | if (IS_ERR(inode)) | ||
768 | goto fail; | ||
769 | |||
770 | LOGFS_BUG_ON(i_size_read(inode) > 0, sb); | ||
771 | super->s_victim_ino = 0; | ||
772 | err = logfs_remove_inode(inode); | ||
773 | iput(inode); | ||
774 | if (err) { | ||
775 | super->s_victim_ino = ino; | ||
776 | goto fail; | ||
777 | } | ||
778 | } | ||
779 | if (super->s_rename_dir) { | ||
780 | /* delete old dd from rename */ | ||
781 | ino = super->s_rename_dir; | ||
782 | pos = super->s_rename_pos; | ||
783 | printk(KERN_INFO"LogFS: delete unbacked dentry (%llx, %llx)\n", | ||
784 | ino, pos); | ||
785 | inode = logfs_iget(sb, ino); | ||
786 | if (IS_ERR(inode)) | ||
787 | goto fail; | ||
788 | |||
789 | super->s_rename_dir = 0; | ||
790 | super->s_rename_pos = 0; | ||
791 | err = logfs_delete_dd(inode, pos); | ||
792 | iput(inode); | ||
793 | if (err) { | ||
794 | super->s_rename_dir = ino; | ||
795 | super->s_rename_pos = pos; | ||
796 | goto fail; | ||
797 | } | ||
798 | } | ||
799 | return 0; | ||
800 | fail: | ||
801 | LOGFS_BUG(sb); | ||
802 | return -EIO; | ||
803 | } | ||
804 | |||
805 | const struct inode_operations logfs_symlink_iops = { | ||
806 | .readlink = generic_readlink, | ||
807 | .follow_link = page_follow_link_light, | ||
808 | }; | ||
809 | |||
810 | const struct inode_operations logfs_dir_iops = { | ||
811 | .create = logfs_create, | ||
812 | .link = logfs_link, | ||
813 | .lookup = logfs_lookup, | ||
814 | .mkdir = logfs_mkdir, | ||
815 | .mknod = logfs_mknod, | ||
816 | .rename = logfs_rename, | ||
817 | .rmdir = logfs_rmdir, | ||
818 | .permission = logfs_permission, | ||
819 | .symlink = logfs_symlink, | ||
820 | .unlink = logfs_unlink, | ||
821 | }; | ||
822 | const struct file_operations logfs_dir_fops = { | ||
823 | .fsync = logfs_fsync, | ||
824 | .ioctl = logfs_ioctl, | ||
825 | .readdir = logfs_readdir, | ||
826 | .read = generic_read_dir, | ||
827 | }; | ||
diff --git a/fs/logfs/file.c b/fs/logfs/file.c new file mode 100644 index 000000000000..370f367a933e --- /dev/null +++ b/fs/logfs/file.c | |||
@@ -0,0 +1,263 @@ | |||
1 | /* | ||
2 | * fs/logfs/file.c - prepare_write, commit_write and friends | ||
3 | * | ||
4 | * As should be obvious for Linux kernel code, license is GPLv2 | ||
5 | * | ||
6 | * Copyright (c) 2005-2008 Joern Engel <joern@logfs.org> | ||
7 | */ | ||
8 | #include "logfs.h" | ||
9 | #include <linux/sched.h> | ||
10 | #include <linux/writeback.h> | ||
11 | |||
12 | static int logfs_write_begin(struct file *file, struct address_space *mapping, | ||
13 | loff_t pos, unsigned len, unsigned flags, | ||
14 | struct page **pagep, void **fsdata) | ||
15 | { | ||
16 | struct inode *inode = mapping->host; | ||
17 | struct page *page; | ||
18 | pgoff_t index = pos >> PAGE_CACHE_SHIFT; | ||
19 | |||
20 | page = grab_cache_page_write_begin(mapping, index, flags); | ||
21 | if (!page) | ||
22 | return -ENOMEM; | ||
23 | *pagep = page; | ||
24 | |||
25 | if ((len == PAGE_CACHE_SIZE) || PageUptodate(page)) | ||
26 | return 0; | ||
27 | if ((pos & PAGE_CACHE_MASK) >= i_size_read(inode)) { | ||
28 | unsigned start = pos & (PAGE_CACHE_SIZE - 1); | ||
29 | unsigned end = start + len; | ||
30 | |||
31 | /* Reading beyond i_size is simple: memset to zero */ | ||
32 | zero_user_segments(page, 0, start, end, PAGE_CACHE_SIZE); | ||
33 | return 0; | ||
34 | } | ||
35 | return logfs_readpage_nolock(page); | ||
36 | } | ||
37 | |||
38 | static int logfs_write_end(struct file *file, struct address_space *mapping, | ||
39 | loff_t pos, unsigned len, unsigned copied, struct page *page, | ||
40 | void *fsdata) | ||
41 | { | ||
42 | struct inode *inode = mapping->host; | ||
43 | pgoff_t index = page->index; | ||
44 | unsigned start = pos & (PAGE_CACHE_SIZE - 1); | ||
45 | unsigned end = start + copied; | ||
46 | int ret = 0; | ||
47 | |||
48 | BUG_ON(PAGE_CACHE_SIZE != inode->i_sb->s_blocksize); | ||
49 | BUG_ON(page->index > I3_BLOCKS); | ||
50 | |||
51 | if (copied < len) { | ||
52 | /* | ||
53 | * Short write of a non-initialized paged. Just tell userspace | ||
54 | * to retry the entire page. | ||
55 | */ | ||
56 | if (!PageUptodate(page)) { | ||
57 | copied = 0; | ||
58 | goto out; | ||
59 | } | ||
60 | } | ||
61 | if (copied == 0) | ||
62 | goto out; /* FIXME: do we need to update inode? */ | ||
63 | |||
64 | if (i_size_read(inode) < (index << PAGE_CACHE_SHIFT) + end) { | ||
65 | i_size_write(inode, (index << PAGE_CACHE_SHIFT) + end); | ||
66 | mark_inode_dirty_sync(inode); | ||
67 | } | ||
68 | |||
69 | SetPageUptodate(page); | ||
70 | if (!PageDirty(page)) { | ||
71 | if (!get_page_reserve(inode, page)) | ||
72 | __set_page_dirty_nobuffers(page); | ||
73 | else | ||
74 | ret = logfs_write_buf(inode, page, WF_LOCK); | ||
75 | } | ||
76 | out: | ||
77 | unlock_page(page); | ||
78 | page_cache_release(page); | ||
79 | return ret ? ret : copied; | ||
80 | } | ||
81 | |||
82 | int logfs_readpage(struct file *file, struct page *page) | ||
83 | { | ||
84 | int ret; | ||
85 | |||
86 | ret = logfs_readpage_nolock(page); | ||
87 | unlock_page(page); | ||
88 | return ret; | ||
89 | } | ||
90 | |||
91 | /* Clear the page's dirty flag in the radix tree. */ | ||
92 | /* TODO: mucking with PageWriteback is silly. Add a generic function to clear | ||
93 | * the dirty bit from the radix tree for filesystems that don't have to wait | ||
94 | * for page writeback to finish (i.e. any compressing filesystem). | ||
95 | */ | ||
96 | static void clear_radix_tree_dirty(struct page *page) | ||
97 | { | ||
98 | BUG_ON(PagePrivate(page) || page->private); | ||
99 | set_page_writeback(page); | ||
100 | end_page_writeback(page); | ||
101 | } | ||
102 | |||
103 | static int __logfs_writepage(struct page *page) | ||
104 | { | ||
105 | struct inode *inode = page->mapping->host; | ||
106 | int err; | ||
107 | |||
108 | err = logfs_write_buf(inode, page, WF_LOCK); | ||
109 | if (err) | ||
110 | set_page_dirty(page); | ||
111 | else | ||
112 | clear_radix_tree_dirty(page); | ||
113 | unlock_page(page); | ||
114 | return err; | ||
115 | } | ||
116 | |||
117 | static int logfs_writepage(struct page *page, struct writeback_control *wbc) | ||
118 | { | ||
119 | struct inode *inode = page->mapping->host; | ||
120 | loff_t i_size = i_size_read(inode); | ||
121 | pgoff_t end_index = i_size >> PAGE_CACHE_SHIFT; | ||
122 | unsigned offset; | ||
123 | u64 bix; | ||
124 | level_t level; | ||
125 | |||
126 | log_file("logfs_writepage(%lx, %lx, %p)\n", inode->i_ino, page->index, | ||
127 | page); | ||
128 | |||
129 | logfs_unpack_index(page->index, &bix, &level); | ||
130 | |||
131 | /* Indirect blocks are never truncated */ | ||
132 | if (level != 0) | ||
133 | return __logfs_writepage(page); | ||
134 | |||
135 | /* | ||
136 | * TODO: everything below is a near-verbatim copy of nobh_writepage(). | ||
137 | * The relevant bits should be factored out after logfs is merged. | ||
138 | */ | ||
139 | |||
140 | /* Is the page fully inside i_size? */ | ||
141 | if (bix < end_index) | ||
142 | return __logfs_writepage(page); | ||
143 | |||
144 | /* Is the page fully outside i_size? (truncate in progress) */ | ||
145 | offset = i_size & (PAGE_CACHE_SIZE-1); | ||
146 | if (bix > end_index || offset == 0) { | ||
147 | unlock_page(page); | ||
148 | return 0; /* don't care */ | ||
149 | } | ||
150 | |||
151 | /* | ||
152 | * The page straddles i_size. It must be zeroed out on each and every | ||
153 | * writepage invokation because it may be mmapped. "A file is mapped | ||
154 | * in multiples of the page size. For a file that is not a multiple of | ||
155 | * the page size, the remaining memory is zeroed when mapped, and | ||
156 | * writes to that region are not written out to the file." | ||
157 | */ | ||
158 | zero_user_segment(page, offset, PAGE_CACHE_SIZE); | ||
159 | return __logfs_writepage(page); | ||
160 | } | ||
161 | |||
162 | static void logfs_invalidatepage(struct page *page, unsigned long offset) | ||
163 | { | ||
164 | move_page_to_btree(page); | ||
165 | BUG_ON(PagePrivate(page) || page->private); | ||
166 | } | ||
167 | |||
168 | static int logfs_releasepage(struct page *page, gfp_t only_xfs_uses_this) | ||
169 | { | ||
170 | return 0; /* None of these are easy to release */ | ||
171 | } | ||
172 | |||
173 | |||
174 | int logfs_ioctl(struct inode *inode, struct file *file, unsigned int cmd, | ||
175 | unsigned long arg) | ||
176 | { | ||
177 | struct logfs_inode *li = logfs_inode(inode); | ||
178 | unsigned int oldflags, flags; | ||
179 | int err; | ||
180 | |||
181 | switch (cmd) { | ||
182 | case FS_IOC_GETFLAGS: | ||
183 | flags = li->li_flags & LOGFS_FL_USER_VISIBLE; | ||
184 | return put_user(flags, (int __user *)arg); | ||
185 | case FS_IOC_SETFLAGS: | ||
186 | if (IS_RDONLY(inode)) | ||
187 | return -EROFS; | ||
188 | |||
189 | if (!is_owner_or_cap(inode)) | ||
190 | return -EACCES; | ||
191 | |||
192 | err = get_user(flags, (int __user *)arg); | ||
193 | if (err) | ||
194 | return err; | ||
195 | |||
196 | mutex_lock(&inode->i_mutex); | ||
197 | oldflags = li->li_flags; | ||
198 | flags &= LOGFS_FL_USER_MODIFIABLE; | ||
199 | flags |= oldflags & ~LOGFS_FL_USER_MODIFIABLE; | ||
200 | li->li_flags = flags; | ||
201 | mutex_unlock(&inode->i_mutex); | ||
202 | |||
203 | inode->i_ctime = CURRENT_TIME; | ||
204 | mark_inode_dirty_sync(inode); | ||
205 | return 0; | ||
206 | |||
207 | default: | ||
208 | return -ENOTTY; | ||
209 | } | ||
210 | } | ||
211 | |||
212 | int logfs_fsync(struct file *file, struct dentry *dentry, int datasync) | ||
213 | { | ||
214 | struct super_block *sb = dentry->d_inode->i_sb; | ||
215 | struct logfs_super *super = logfs_super(sb); | ||
216 | |||
217 | /* FIXME: write anchor */ | ||
218 | super->s_devops->sync(sb); | ||
219 | return 0; | ||
220 | } | ||
221 | |||
222 | static int logfs_setattr(struct dentry *dentry, struct iattr *attr) | ||
223 | { | ||
224 | struct inode *inode = dentry->d_inode; | ||
225 | int err = 0; | ||
226 | |||
227 | if (attr->ia_valid & ATTR_SIZE) | ||
228 | err = logfs_truncate(inode, attr->ia_size); | ||
229 | attr->ia_valid &= ~ATTR_SIZE; | ||
230 | |||
231 | if (!err) | ||
232 | err = inode_change_ok(inode, attr); | ||
233 | if (!err) | ||
234 | err = inode_setattr(inode, attr); | ||
235 | return err; | ||
236 | } | ||
237 | |||
238 | const struct inode_operations logfs_reg_iops = { | ||
239 | .setattr = logfs_setattr, | ||
240 | }; | ||
241 | |||
242 | const struct file_operations logfs_reg_fops = { | ||
243 | .aio_read = generic_file_aio_read, | ||
244 | .aio_write = generic_file_aio_write, | ||
245 | .fsync = logfs_fsync, | ||
246 | .ioctl = logfs_ioctl, | ||
247 | .llseek = generic_file_llseek, | ||
248 | .mmap = generic_file_readonly_mmap, | ||
249 | .open = generic_file_open, | ||
250 | .read = do_sync_read, | ||
251 | .write = do_sync_write, | ||
252 | }; | ||
253 | |||
254 | const struct address_space_operations logfs_reg_aops = { | ||
255 | .invalidatepage = logfs_invalidatepage, | ||
256 | .readpage = logfs_readpage, | ||
257 | .releasepage = logfs_releasepage, | ||
258 | .set_page_dirty = __set_page_dirty_nobuffers, | ||
259 | .writepage = logfs_writepage, | ||
260 | .writepages = generic_writepages, | ||
261 | .write_begin = logfs_write_begin, | ||
262 | .write_end = logfs_write_end, | ||
263 | }; | ||
diff --git a/fs/logfs/gc.c b/fs/logfs/gc.c new file mode 100644 index 000000000000..92949f95a901 --- /dev/null +++ b/fs/logfs/gc.c | |||
@@ -0,0 +1,730 @@ | |||
1 | /* | ||
2 | * fs/logfs/gc.c - garbage collection code | ||
3 | * | ||
4 | * As should be obvious for Linux kernel code, license is GPLv2 | ||
5 | * | ||
6 | * Copyright (c) 2005-2008 Joern Engel <joern@logfs.org> | ||
7 | */ | ||
8 | #include "logfs.h" | ||
9 | #include <linux/sched.h> | ||
10 | |||
11 | /* | ||
12 | * Wear leveling needs to kick in when the difference between low erase | ||
13 | * counts and high erase counts gets too big. A good value for "too big" | ||
14 | * may be somewhat below 10% of maximum erase count for the device. | ||
15 | * Why not 397, to pick a nice round number with no specific meaning? :) | ||
16 | * | ||
17 | * WL_RATELIMIT is the minimum time between two wear level events. A huge | ||
18 | * number of segments may fulfil the requirements for wear leveling at the | ||
19 | * same time. If that happens we don't want to cause a latency from hell, | ||
20 | * but just gently pick one segment every so often and minimize overhead. | ||
21 | */ | ||
22 | #define WL_DELTA 397 | ||
23 | #define WL_RATELIMIT 100 | ||
24 | #define MAX_OBJ_ALIASES 2600 | ||
25 | #define SCAN_RATIO 512 /* number of scanned segments per gc'd segment */ | ||
26 | #define LIST_SIZE 64 /* base size of candidate lists */ | ||
27 | #define SCAN_ROUNDS 128 /* maximum number of complete medium scans */ | ||
28 | #define SCAN_ROUNDS_HIGH 4 /* maximum number of higher-level scans */ | ||
29 | |||
30 | static int no_free_segments(struct super_block *sb) | ||
31 | { | ||
32 | struct logfs_super *super = logfs_super(sb); | ||
33 | |||
34 | return super->s_free_list.count; | ||
35 | } | ||
36 | |||
37 | /* journal has distance -1, top-most ifile layer distance 0 */ | ||
38 | static u8 root_distance(struct super_block *sb, gc_level_t __gc_level) | ||
39 | { | ||
40 | struct logfs_super *super = logfs_super(sb); | ||
41 | u8 gc_level = (__force u8)__gc_level; | ||
42 | |||
43 | switch (gc_level) { | ||
44 | case 0: /* fall through */ | ||
45 | case 1: /* fall through */ | ||
46 | case 2: /* fall through */ | ||
47 | case 3: | ||
48 | /* file data or indirect blocks */ | ||
49 | return super->s_ifile_levels + super->s_iblock_levels - gc_level; | ||
50 | case 6: /* fall through */ | ||
51 | case 7: /* fall through */ | ||
52 | case 8: /* fall through */ | ||
53 | case 9: | ||
54 | /* inode file data or indirect blocks */ | ||
55 | return super->s_ifile_levels - (gc_level - 6); | ||
56 | default: | ||
57 | printk(KERN_ERR"LOGFS: segment of unknown level %x found\n", | ||
58 | gc_level); | ||
59 | WARN_ON(1); | ||
60 | return super->s_ifile_levels + super->s_iblock_levels; | ||
61 | } | ||
62 | } | ||
63 | |||
64 | static int segment_is_reserved(struct super_block *sb, u32 segno) | ||
65 | { | ||
66 | struct logfs_super *super = logfs_super(sb); | ||
67 | struct logfs_area *area; | ||
68 | void *reserved; | ||
69 | int i; | ||
70 | |||
71 | /* Some segments are reserved. Just pretend they were all valid */ | ||
72 | reserved = btree_lookup32(&super->s_reserved_segments, segno); | ||
73 | if (reserved) | ||
74 | return 1; | ||
75 | |||
76 | /* Currently open segments */ | ||
77 | for_each_area(i) { | ||
78 | area = super->s_area[i]; | ||
79 | if (area->a_is_open && area->a_segno == segno) | ||
80 | return 1; | ||
81 | } | ||
82 | |||
83 | return 0; | ||
84 | } | ||
85 | |||
86 | static void logfs_mark_segment_bad(struct super_block *sb, u32 segno) | ||
87 | { | ||
88 | BUG(); | ||
89 | } | ||
90 | |||
91 | /* | ||
92 | * Returns the bytes consumed by valid objects in this segment. Object headers | ||
93 | * are counted, the segment header is not. | ||
94 | */ | ||
95 | static u32 logfs_valid_bytes(struct super_block *sb, u32 segno, u32 *ec, | ||
96 | gc_level_t *gc_level) | ||
97 | { | ||
98 | struct logfs_segment_entry se; | ||
99 | u32 ec_level; | ||
100 | |||
101 | logfs_get_segment_entry(sb, segno, &se); | ||
102 | if (se.ec_level == cpu_to_be32(BADSEG) || | ||
103 | se.valid == cpu_to_be32(RESERVED)) | ||
104 | return RESERVED; | ||
105 | |||
106 | ec_level = be32_to_cpu(se.ec_level); | ||
107 | *ec = ec_level >> 4; | ||
108 | *gc_level = GC_LEVEL(ec_level & 0xf); | ||
109 | return be32_to_cpu(se.valid); | ||
110 | } | ||
111 | |||
112 | static void logfs_cleanse_block(struct super_block *sb, u64 ofs, u64 ino, | ||
113 | u64 bix, gc_level_t gc_level) | ||
114 | { | ||
115 | struct inode *inode; | ||
116 | int err, cookie; | ||
117 | |||
118 | inode = logfs_safe_iget(sb, ino, &cookie); | ||
119 | err = logfs_rewrite_block(inode, bix, ofs, gc_level, 0); | ||
120 | BUG_ON(err); | ||
121 | logfs_safe_iput(inode, cookie); | ||
122 | } | ||
123 | |||
124 | static u32 logfs_gc_segment(struct super_block *sb, u32 segno, u8 dist) | ||
125 | { | ||
126 | struct logfs_super *super = logfs_super(sb); | ||
127 | struct logfs_segment_header sh; | ||
128 | struct logfs_object_header oh; | ||
129 | u64 ofs, ino, bix; | ||
130 | u32 seg_ofs, logical_segno, cleaned = 0; | ||
131 | int err, len, valid; | ||
132 | gc_level_t gc_level; | ||
133 | |||
134 | LOGFS_BUG_ON(segment_is_reserved(sb, segno), sb); | ||
135 | |||
136 | btree_insert32(&super->s_reserved_segments, segno, (void *)1, GFP_NOFS); | ||
137 | err = wbuf_read(sb, dev_ofs(sb, segno, 0), sizeof(sh), &sh); | ||
138 | BUG_ON(err); | ||
139 | gc_level = GC_LEVEL(sh.level); | ||
140 | logical_segno = be32_to_cpu(sh.segno); | ||
141 | if (sh.crc != logfs_crc32(&sh, sizeof(sh), 4)) { | ||
142 | logfs_mark_segment_bad(sb, segno); | ||
143 | cleaned = -1; | ||
144 | goto out; | ||
145 | } | ||
146 | |||
147 | for (seg_ofs = LOGFS_SEGMENT_HEADERSIZE; | ||
148 | seg_ofs + sizeof(oh) < super->s_segsize; ) { | ||
149 | ofs = dev_ofs(sb, logical_segno, seg_ofs); | ||
150 | err = wbuf_read(sb, dev_ofs(sb, segno, seg_ofs), sizeof(oh), | ||
151 | &oh); | ||
152 | BUG_ON(err); | ||
153 | |||
154 | if (!memchr_inv(&oh, 0xff, sizeof(oh))) | ||
155 | break; | ||
156 | |||
157 | if (oh.crc != logfs_crc32(&oh, sizeof(oh) - 4, 4)) { | ||
158 | logfs_mark_segment_bad(sb, segno); | ||
159 | cleaned = super->s_segsize - 1; | ||
160 | goto out; | ||
161 | } | ||
162 | |||
163 | ino = be64_to_cpu(oh.ino); | ||
164 | bix = be64_to_cpu(oh.bix); | ||
165 | len = sizeof(oh) + be16_to_cpu(oh.len); | ||
166 | valid = logfs_is_valid_block(sb, ofs, ino, bix, gc_level); | ||
167 | if (valid == 1) { | ||
168 | logfs_cleanse_block(sb, ofs, ino, bix, gc_level); | ||
169 | cleaned += len; | ||
170 | } else if (valid == 2) { | ||
171 | /* Will be invalid upon journal commit */ | ||
172 | cleaned += len; | ||
173 | } | ||
174 | seg_ofs += len; | ||
175 | } | ||
176 | out: | ||
177 | btree_remove32(&super->s_reserved_segments, segno); | ||
178 | return cleaned; | ||
179 | } | ||
180 | |||
181 | static struct gc_candidate *add_list(struct gc_candidate *cand, | ||
182 | struct candidate_list *list) | ||
183 | { | ||
184 | struct rb_node **p = &list->rb_tree.rb_node; | ||
185 | struct rb_node *parent = NULL; | ||
186 | struct gc_candidate *cur; | ||
187 | int comp; | ||
188 | |||
189 | cand->list = list; | ||
190 | while (*p) { | ||
191 | parent = *p; | ||
192 | cur = rb_entry(parent, struct gc_candidate, rb_node); | ||
193 | |||
194 | if (list->sort_by_ec) | ||
195 | comp = cand->erase_count < cur->erase_count; | ||
196 | else | ||
197 | comp = cand->valid < cur->valid; | ||
198 | |||
199 | if (comp) | ||
200 | p = &parent->rb_left; | ||
201 | else | ||
202 | p = &parent->rb_right; | ||
203 | } | ||
204 | rb_link_node(&cand->rb_node, parent, p); | ||
205 | rb_insert_color(&cand->rb_node, &list->rb_tree); | ||
206 | |||
207 | if (list->count <= list->maxcount) { | ||
208 | list->count++; | ||
209 | return NULL; | ||
210 | } | ||
211 | cand = rb_entry(rb_last(&list->rb_tree), struct gc_candidate, rb_node); | ||
212 | rb_erase(&cand->rb_node, &list->rb_tree); | ||
213 | cand->list = NULL; | ||
214 | return cand; | ||
215 | } | ||
216 | |||
217 | static void remove_from_list(struct gc_candidate *cand) | ||
218 | { | ||
219 | struct candidate_list *list = cand->list; | ||
220 | |||
221 | rb_erase(&cand->rb_node, &list->rb_tree); | ||
222 | list->count--; | ||
223 | } | ||
224 | |||
225 | static void free_candidate(struct super_block *sb, struct gc_candidate *cand) | ||
226 | { | ||
227 | struct logfs_super *super = logfs_super(sb); | ||
228 | |||
229 | btree_remove32(&super->s_cand_tree, cand->segno); | ||
230 | kfree(cand); | ||
231 | } | ||
232 | |||
233 | u32 get_best_cand(struct super_block *sb, struct candidate_list *list, u32 *ec) | ||
234 | { | ||
235 | struct gc_candidate *cand; | ||
236 | u32 segno; | ||
237 | |||
238 | BUG_ON(list->count == 0); | ||
239 | |||
240 | cand = rb_entry(rb_first(&list->rb_tree), struct gc_candidate, rb_node); | ||
241 | remove_from_list(cand); | ||
242 | segno = cand->segno; | ||
243 | if (ec) | ||
244 | *ec = cand->erase_count; | ||
245 | free_candidate(sb, cand); | ||
246 | return segno; | ||
247 | } | ||
248 | |||
249 | /* | ||
250 | * We have several lists to manage segments with. The reserve_list is used to | ||
251 | * deal with bad blocks. We try to keep the best (lowest ec) segments on this | ||
252 | * list. | ||
253 | * The free_list contains free segments for normal usage. It usually gets the | ||
254 | * second pick after the reserve_list. But when the free_list is running short | ||
255 | * it is more important to keep the free_list full than to keep a reserve. | ||
256 | * | ||
257 | * Segments that are not free are put onto a per-level low_list. If we have | ||
258 | * to run garbage collection, we pick a candidate from there. All segments on | ||
259 | * those lists should have at least some free space so GC will make progress. | ||
260 | * | ||
261 | * And last we have the ec_list, which is used to pick segments for wear | ||
262 | * leveling. | ||
263 | * | ||
264 | * If all appropriate lists are full, we simply free the candidate and forget | ||
265 | * about that segment for a while. We have better candidates for each purpose. | ||
266 | */ | ||
267 | static void __add_candidate(struct super_block *sb, struct gc_candidate *cand) | ||
268 | { | ||
269 | struct logfs_super *super = logfs_super(sb); | ||
270 | u32 full = super->s_segsize - LOGFS_SEGMENT_RESERVE; | ||
271 | |||
272 | if (cand->valid == 0) { | ||
273 | /* 100% free segments */ | ||
274 | log_gc_noisy("add reserve segment %x (ec %x) at %llx\n", | ||
275 | cand->segno, cand->erase_count, | ||
276 | dev_ofs(sb, cand->segno, 0)); | ||
277 | cand = add_list(cand, &super->s_reserve_list); | ||
278 | if (cand) { | ||
279 | log_gc_noisy("add free segment %x (ec %x) at %llx\n", | ||
280 | cand->segno, cand->erase_count, | ||
281 | dev_ofs(sb, cand->segno, 0)); | ||
282 | cand = add_list(cand, &super->s_free_list); | ||
283 | } | ||
284 | } else { | ||
285 | /* good candidates for Garbage Collection */ | ||
286 | if (cand->valid < full) | ||
287 | cand = add_list(cand, &super->s_low_list[cand->dist]); | ||
288 | /* good candidates for wear leveling, | ||
289 | * segments that were recently written get ignored */ | ||
290 | if (cand) | ||
291 | cand = add_list(cand, &super->s_ec_list); | ||
292 | } | ||
293 | if (cand) | ||
294 | free_candidate(sb, cand); | ||
295 | } | ||
296 | |||
297 | static int add_candidate(struct super_block *sb, u32 segno, u32 valid, u32 ec, | ||
298 | u8 dist) | ||
299 | { | ||
300 | struct logfs_super *super = logfs_super(sb); | ||
301 | struct gc_candidate *cand; | ||
302 | |||
303 | cand = kmalloc(sizeof(*cand), GFP_NOFS); | ||
304 | if (!cand) | ||
305 | return -ENOMEM; | ||
306 | |||
307 | cand->segno = segno; | ||
308 | cand->valid = valid; | ||
309 | cand->erase_count = ec; | ||
310 | cand->dist = dist; | ||
311 | |||
312 | btree_insert32(&super->s_cand_tree, segno, cand, GFP_NOFS); | ||
313 | __add_candidate(sb, cand); | ||
314 | return 0; | ||
315 | } | ||
316 | |||
317 | static void remove_segment_from_lists(struct super_block *sb, u32 segno) | ||
318 | { | ||
319 | struct logfs_super *super = logfs_super(sb); | ||
320 | struct gc_candidate *cand; | ||
321 | |||
322 | cand = btree_lookup32(&super->s_cand_tree, segno); | ||
323 | if (cand) { | ||
324 | remove_from_list(cand); | ||
325 | free_candidate(sb, cand); | ||
326 | } | ||
327 | } | ||
328 | |||
329 | static void scan_segment(struct super_block *sb, u32 segno) | ||
330 | { | ||
331 | u32 valid, ec = 0; | ||
332 | gc_level_t gc_level = 0; | ||
333 | u8 dist; | ||
334 | |||
335 | if (segment_is_reserved(sb, segno)) | ||
336 | return; | ||
337 | |||
338 | remove_segment_from_lists(sb, segno); | ||
339 | valid = logfs_valid_bytes(sb, segno, &ec, &gc_level); | ||
340 | if (valid == RESERVED) | ||
341 | return; | ||
342 | |||
343 | dist = root_distance(sb, gc_level); | ||
344 | add_candidate(sb, segno, valid, ec, dist); | ||
345 | } | ||
346 | |||
347 | static struct gc_candidate *first_in_list(struct candidate_list *list) | ||
348 | { | ||
349 | if (list->count == 0) | ||
350 | return NULL; | ||
351 | return rb_entry(rb_first(&list->rb_tree), struct gc_candidate, rb_node); | ||
352 | } | ||
353 | |||
354 | /* | ||
355 | * Find the best segment for garbage collection. Main criterion is | ||
356 | * the segment requiring the least effort to clean. Secondary | ||
357 | * criterion is to GC on the lowest level available. | ||
358 | * | ||
359 | * So we search the least effort segment on the lowest level first, | ||
360 | * then move up and pick another segment iff is requires significantly | ||
361 | * less effort. Hence the LOGFS_MAX_OBJECTSIZE in the comparison. | ||
362 | */ | ||
363 | static struct gc_candidate *get_candidate(struct super_block *sb) | ||
364 | { | ||
365 | struct logfs_super *super = logfs_super(sb); | ||
366 | int i, max_dist; | ||
367 | struct gc_candidate *cand = NULL, *this; | ||
368 | |||
369 | max_dist = min(no_free_segments(sb), LOGFS_NO_AREAS); | ||
370 | |||
371 | for (i = max_dist; i >= 0; i--) { | ||
372 | this = first_in_list(&super->s_low_list[i]); | ||
373 | if (!this) | ||
374 | continue; | ||
375 | if (!cand) | ||
376 | cand = this; | ||
377 | if (this->valid + LOGFS_MAX_OBJECTSIZE <= cand->valid) | ||
378 | cand = this; | ||
379 | } | ||
380 | return cand; | ||
381 | } | ||
382 | |||
383 | static int __logfs_gc_once(struct super_block *sb, struct gc_candidate *cand) | ||
384 | { | ||
385 | struct logfs_super *super = logfs_super(sb); | ||
386 | gc_level_t gc_level; | ||
387 | u32 cleaned, valid, segno, ec; | ||
388 | u8 dist; | ||
389 | |||
390 | if (!cand) { | ||
391 | log_gc("GC attempted, but no candidate found\n"); | ||
392 | return 0; | ||
393 | } | ||
394 | |||
395 | segno = cand->segno; | ||
396 | dist = cand->dist; | ||
397 | valid = logfs_valid_bytes(sb, segno, &ec, &gc_level); | ||
398 | free_candidate(sb, cand); | ||
399 | log_gc("GC segment #%02x at %llx, %x required, %x free, %x valid, %llx free\n", | ||
400 | segno, (u64)segno << super->s_segshift, | ||
401 | dist, no_free_segments(sb), valid, | ||
402 | super->s_free_bytes); | ||
403 | cleaned = logfs_gc_segment(sb, segno, dist); | ||
404 | log_gc("GC segment #%02x complete - now %x valid\n", segno, | ||
405 | valid - cleaned); | ||
406 | BUG_ON(cleaned != valid); | ||
407 | return 1; | ||
408 | } | ||
409 | |||
410 | static int logfs_gc_once(struct super_block *sb) | ||
411 | { | ||
412 | struct gc_candidate *cand; | ||
413 | |||
414 | cand = get_candidate(sb); | ||
415 | if (cand) | ||
416 | remove_from_list(cand); | ||
417 | return __logfs_gc_once(sb, cand); | ||
418 | } | ||
419 | |||
420 | /* returns 1 if a wrap occurs, 0 otherwise */ | ||
421 | static int logfs_scan_some(struct super_block *sb) | ||
422 | { | ||
423 | struct logfs_super *super = logfs_super(sb); | ||
424 | u32 segno; | ||
425 | int i, ret = 0; | ||
426 | |||
427 | segno = super->s_sweeper; | ||
428 | for (i = SCAN_RATIO; i > 0; i--) { | ||
429 | segno++; | ||
430 | if (segno >= super->s_no_segs) { | ||
431 | segno = 0; | ||
432 | ret = 1; | ||
433 | /* Break out of the loop. We want to read a single | ||
434 | * block from the segment size on next invocation if | ||
435 | * SCAN_RATIO is set to match block size | ||
436 | */ | ||
437 | break; | ||
438 | } | ||
439 | |||
440 | scan_segment(sb, segno); | ||
441 | } | ||
442 | super->s_sweeper = segno; | ||
443 | return ret; | ||
444 | } | ||
445 | |||
446 | /* | ||
447 | * In principle, this function should loop forever, looking for GC candidates | ||
448 | * and moving data. LogFS is designed in such a way that this loop is | ||
449 | * guaranteed to terminate. | ||
450 | * | ||
451 | * Limiting the loop to some iterations serves purely to catch cases when | ||
452 | * these guarantees have failed. An actual endless loop is an obvious bug | ||
453 | * and should be reported as such. | ||
454 | */ | ||
455 | static void __logfs_gc_pass(struct super_block *sb, int target) | ||
456 | { | ||
457 | struct logfs_super *super = logfs_super(sb); | ||
458 | struct logfs_block *block; | ||
459 | int round, progress, last_progress = 0; | ||
460 | |||
461 | if (no_free_segments(sb) >= target && | ||
462 | super->s_no_object_aliases < MAX_OBJ_ALIASES) | ||
463 | return; | ||
464 | |||
465 | log_gc("__logfs_gc_pass(%x)\n", target); | ||
466 | for (round = 0; round < SCAN_ROUNDS; ) { | ||
467 | if (no_free_segments(sb) >= target) | ||
468 | goto write_alias; | ||
469 | |||
470 | /* Sync in-memory state with on-medium state in case they | ||
471 | * diverged */ | ||
472 | logfs_write_anchor(sb); | ||
473 | round += logfs_scan_some(sb); | ||
474 | if (no_free_segments(sb) >= target) | ||
475 | goto write_alias; | ||
476 | progress = logfs_gc_once(sb); | ||
477 | if (progress) | ||
478 | last_progress = round; | ||
479 | else if (round - last_progress > 2) | ||
480 | break; | ||
481 | continue; | ||
482 | |||
483 | /* | ||
484 | * The goto logic is nasty, I just don't know a better way to | ||
485 | * code it. GC is supposed to ensure two things: | ||
486 | * 1. Enough free segments are available. | ||
487 | * 2. The number of aliases is bounded. | ||
488 | * When 1. is achieved, we take a look at 2. and write back | ||
489 | * some alias-containing blocks, if necessary. However, after | ||
490 | * each such write we need to go back to 1., as writes can | ||
491 | * consume free segments. | ||
492 | */ | ||
493 | write_alias: | ||
494 | if (super->s_no_object_aliases < MAX_OBJ_ALIASES) | ||
495 | return; | ||
496 | if (list_empty(&super->s_object_alias)) { | ||
497 | /* All aliases are still in btree */ | ||
498 | return; | ||
499 | } | ||
500 | log_gc("Write back one alias\n"); | ||
501 | block = list_entry(super->s_object_alias.next, | ||
502 | struct logfs_block, alias_list); | ||
503 | block->ops->write_block(block); | ||
504 | /* | ||
505 | * To round off the nasty goto logic, we reset round here. It | ||
506 | * is a safety-net for GC not making any progress and limited | ||
507 | * to something reasonably small. If incremented it for every | ||
508 | * single alias, the loop could terminate rather quickly. | ||
509 | */ | ||
510 | round = 0; | ||
511 | } | ||
512 | LOGFS_BUG(sb); | ||
513 | } | ||
514 | |||
515 | static int wl_ratelimit(struct super_block *sb, u64 *next_event) | ||
516 | { | ||
517 | struct logfs_super *super = logfs_super(sb); | ||
518 | |||
519 | if (*next_event < super->s_gec) { | ||
520 | *next_event = super->s_gec + WL_RATELIMIT; | ||
521 | return 0; | ||
522 | } | ||
523 | return 1; | ||
524 | } | ||
525 | |||
526 | static void logfs_wl_pass(struct super_block *sb) | ||
527 | { | ||
528 | struct logfs_super *super = logfs_super(sb); | ||
529 | struct gc_candidate *wl_cand, *free_cand; | ||
530 | |||
531 | if (wl_ratelimit(sb, &super->s_wl_gec_ostore)) | ||
532 | return; | ||
533 | |||
534 | wl_cand = first_in_list(&super->s_ec_list); | ||
535 | if (!wl_cand) | ||
536 | return; | ||
537 | free_cand = first_in_list(&super->s_free_list); | ||
538 | if (!free_cand) | ||
539 | return; | ||
540 | |||
541 | if (wl_cand->erase_count < free_cand->erase_count + WL_DELTA) { | ||
542 | remove_from_list(wl_cand); | ||
543 | __logfs_gc_once(sb, wl_cand); | ||
544 | } | ||
545 | } | ||
546 | |||
547 | /* | ||
548 | * The journal needs wear leveling as well. But moving the journal is an | ||
549 | * expensive operation so we try to avoid it as much as possible. And if we | ||
550 | * have to do it, we move the whole journal, not individual segments. | ||
551 | * | ||
552 | * Ratelimiting is not strictly necessary here, it mainly serves to avoid the | ||
553 | * calculations. First we check whether moving the journal would be a | ||
554 | * significant improvement. That means that a) the current journal segments | ||
555 | * have more wear than the future journal segments and b) the current journal | ||
556 | * segments have more wear than normal ostore segments. | ||
557 | * Rationale for b) is that we don't have to move the journal if it is aging | ||
558 | * less than the ostore, even if the reserve segments age even less (they are | ||
559 | * excluded from wear leveling, after all). | ||
560 | * Next we check that the superblocks have less wear than the journal. Since | ||
561 | * moving the journal requires writing the superblocks, we have to protect the | ||
562 | * superblocks even more than the journal. | ||
563 | * | ||
564 | * Also we double the acceptable wear difference, compared to ostore wear | ||
565 | * leveling. Journal data is read and rewritten rapidly, comparatively. So | ||
566 | * soft errors have much less time to accumulate and we allow the journal to | ||
567 | * be a bit worse than the ostore. | ||
568 | */ | ||
569 | static void logfs_journal_wl_pass(struct super_block *sb) | ||
570 | { | ||
571 | struct logfs_super *super = logfs_super(sb); | ||
572 | struct gc_candidate *cand; | ||
573 | u32 min_journal_ec = -1, max_reserve_ec = 0; | ||
574 | int i; | ||
575 | |||
576 | if (wl_ratelimit(sb, &super->s_wl_gec_journal)) | ||
577 | return; | ||
578 | |||
579 | if (super->s_reserve_list.count < super->s_no_journal_segs) { | ||
580 | /* Reserve is not full enough to move complete journal */ | ||
581 | return; | ||
582 | } | ||
583 | |||
584 | journal_for_each(i) | ||
585 | if (super->s_journal_seg[i]) | ||
586 | min_journal_ec = min(min_journal_ec, | ||
587 | super->s_journal_ec[i]); | ||
588 | cand = rb_entry(rb_first(&super->s_free_list.rb_tree), | ||
589 | struct gc_candidate, rb_node); | ||
590 | max_reserve_ec = cand->erase_count; | ||
591 | for (i = 0; i < 2; i++) { | ||
592 | struct logfs_segment_entry se; | ||
593 | u32 segno = seg_no(sb, super->s_sb_ofs[i]); | ||
594 | u32 ec; | ||
595 | |||
596 | logfs_get_segment_entry(sb, segno, &se); | ||
597 | ec = be32_to_cpu(se.ec_level) >> 4; | ||
598 | max_reserve_ec = max(max_reserve_ec, ec); | ||
599 | } | ||
600 | |||
601 | if (min_journal_ec > max_reserve_ec + 2 * WL_DELTA) { | ||
602 | do_logfs_journal_wl_pass(sb); | ||
603 | } | ||
604 | } | ||
605 | |||
606 | void logfs_gc_pass(struct super_block *sb) | ||
607 | { | ||
608 | struct logfs_super *super = logfs_super(sb); | ||
609 | |||
610 | //BUG_ON(mutex_trylock(&logfs_super(sb)->s_w_mutex)); | ||
611 | /* Write journal before free space is getting saturated with dirty | ||
612 | * objects. | ||
613 | */ | ||
614 | if (super->s_dirty_used_bytes + super->s_dirty_free_bytes | ||
615 | + LOGFS_MAX_OBJECTSIZE >= super->s_free_bytes) | ||
616 | logfs_write_anchor(sb); | ||
617 | __logfs_gc_pass(sb, super->s_total_levels); | ||
618 | logfs_wl_pass(sb); | ||
619 | logfs_journal_wl_pass(sb); | ||
620 | } | ||
621 | |||
622 | static int check_area(struct super_block *sb, int i) | ||
623 | { | ||
624 | struct logfs_super *super = logfs_super(sb); | ||
625 | struct logfs_area *area = super->s_area[i]; | ||
626 | struct logfs_object_header oh; | ||
627 | u32 segno = area->a_segno; | ||
628 | u32 ofs = area->a_used_bytes; | ||
629 | __be32 crc; | ||
630 | int err; | ||
631 | |||
632 | if (!area->a_is_open) | ||
633 | return 0; | ||
634 | |||
635 | for (ofs = area->a_used_bytes; | ||
636 | ofs <= super->s_segsize - sizeof(oh); | ||
637 | ofs += (u32)be16_to_cpu(oh.len) + sizeof(oh)) { | ||
638 | err = wbuf_read(sb, dev_ofs(sb, segno, ofs), sizeof(oh), &oh); | ||
639 | if (err) | ||
640 | return err; | ||
641 | |||
642 | if (!memchr_inv(&oh, 0xff, sizeof(oh))) | ||
643 | break; | ||
644 | |||
645 | crc = logfs_crc32(&oh, sizeof(oh) - 4, 4); | ||
646 | if (crc != oh.crc) { | ||
647 | printk(KERN_INFO "interrupted header at %llx\n", | ||
648 | dev_ofs(sb, segno, ofs)); | ||
649 | return 0; | ||
650 | } | ||
651 | } | ||
652 | if (ofs != area->a_used_bytes) { | ||
653 | printk(KERN_INFO "%x bytes unaccounted data found at %llx\n", | ||
654 | ofs - area->a_used_bytes, | ||
655 | dev_ofs(sb, segno, area->a_used_bytes)); | ||
656 | area->a_used_bytes = ofs; | ||
657 | } | ||
658 | return 0; | ||
659 | } | ||
660 | |||
661 | int logfs_check_areas(struct super_block *sb) | ||
662 | { | ||
663 | int i, err; | ||
664 | |||
665 | for_each_area(i) { | ||
666 | err = check_area(sb, i); | ||
667 | if (err) | ||
668 | return err; | ||
669 | } | ||
670 | return 0; | ||
671 | } | ||
672 | |||
673 | static void logfs_init_candlist(struct candidate_list *list, int maxcount, | ||
674 | int sort_by_ec) | ||
675 | { | ||
676 | list->count = 0; | ||
677 | list->maxcount = maxcount; | ||
678 | list->sort_by_ec = sort_by_ec; | ||
679 | list->rb_tree = RB_ROOT; | ||
680 | } | ||
681 | |||
682 | int logfs_init_gc(struct super_block *sb) | ||
683 | { | ||
684 | struct logfs_super *super = logfs_super(sb); | ||
685 | int i; | ||
686 | |||
687 | btree_init_mempool32(&super->s_cand_tree, super->s_btree_pool); | ||
688 | logfs_init_candlist(&super->s_free_list, LIST_SIZE + SCAN_RATIO, 1); | ||
689 | logfs_init_candlist(&super->s_reserve_list, | ||
690 | super->s_bad_seg_reserve, 1); | ||
691 | for_each_area(i) | ||
692 | logfs_init_candlist(&super->s_low_list[i], LIST_SIZE, 0); | ||
693 | logfs_init_candlist(&super->s_ec_list, LIST_SIZE, 1); | ||
694 | return 0; | ||
695 | } | ||
696 | |||
697 | static void logfs_cleanup_list(struct super_block *sb, | ||
698 | struct candidate_list *list) | ||
699 | { | ||
700 | struct gc_candidate *cand; | ||
701 | |||
702 | while (list->count) { | ||
703 | cand = rb_entry(list->rb_tree.rb_node, struct gc_candidate, | ||
704 | rb_node); | ||
705 | remove_from_list(cand); | ||
706 | free_candidate(sb, cand); | ||
707 | } | ||
708 | BUG_ON(list->rb_tree.rb_node); | ||
709 | } | ||
710 | |||
711 | void logfs_cleanup_gc(struct super_block *sb) | ||
712 | { | ||
713 | struct logfs_super *super = logfs_super(sb); | ||
714 | int i; | ||
715 | |||
716 | if (!super->s_free_list.count) | ||
717 | return; | ||
718 | |||
719 | /* | ||
720 | * FIXME: The btree may still contain a single empty node. So we | ||
721 | * call the grim visitor to clean up that mess. Btree code should | ||
722 | * do it for us, really. | ||
723 | */ | ||
724 | btree_grim_visitor32(&super->s_cand_tree, 0, NULL); | ||
725 | logfs_cleanup_list(sb, &super->s_free_list); | ||
726 | logfs_cleanup_list(sb, &super->s_reserve_list); | ||
727 | for_each_area(i) | ||
728 | logfs_cleanup_list(sb, &super->s_low_list[i]); | ||
729 | logfs_cleanup_list(sb, &super->s_ec_list); | ||
730 | } | ||
diff --git a/fs/logfs/inode.c b/fs/logfs/inode.c new file mode 100644 index 000000000000..33ec1aeaeec4 --- /dev/null +++ b/fs/logfs/inode.c | |||
@@ -0,0 +1,417 @@ | |||
1 | /* | ||
2 | * fs/logfs/inode.c - inode handling code | ||
3 | * | ||
4 | * As should be obvious for Linux kernel code, license is GPLv2 | ||
5 | * | ||
6 | * Copyright (c) 2005-2008 Joern Engel <joern@logfs.org> | ||
7 | */ | ||
8 | #include "logfs.h" | ||
9 | #include <linux/writeback.h> | ||
10 | #include <linux/backing-dev.h> | ||
11 | |||
12 | /* | ||
13 | * How soon to reuse old inode numbers? LogFS doesn't store deleted inodes | ||
14 | * on the medium. It therefore also lacks a method to store the previous | ||
15 | * generation number for deleted inodes. Instead a single generation number | ||
16 | * is stored which will be used for new inodes. Being just a 32bit counter, | ||
17 | * this can obvious wrap relatively quickly. So we only reuse inodes if we | ||
18 | * know that a fair number of inodes can be created before we have to increment | ||
19 | * the generation again - effectively adding some bits to the counter. | ||
20 | * But being too aggressive here means we keep a very large and very sparse | ||
21 | * inode file, wasting space on indirect blocks. | ||
22 | * So what is a good value? Beats me. 64k seems moderately bad on both | ||
23 | * fronts, so let's use that for now... | ||
24 | * | ||
25 | * NFS sucks, as everyone already knows. | ||
26 | */ | ||
27 | #define INOS_PER_WRAP (0x10000) | ||
28 | |||
29 | /* | ||
30 | * Logfs' requirement to read inodes for garbage collection makes life a bit | ||
31 | * harder. GC may have to read inodes that are in I_FREEING state, when they | ||
32 | * are being written out - and waiting for GC to make progress, naturally. | ||
33 | * | ||
34 | * So we cannot just call iget() or some variant of it, but first have to check | ||
35 | * wether the inode in question might be in I_FREEING state. Therefore we | ||
36 | * maintain our own per-sb list of "almost deleted" inodes and check against | ||
37 | * that list first. Normally this should be at most 1-2 entries long. | ||
38 | * | ||
39 | * Also, inodes have logfs-specific reference counting on top of what the vfs | ||
40 | * does. When .destroy_inode is called, normally the reference count will drop | ||
41 | * to zero and the inode gets deleted. But if GC accessed the inode, its | ||
42 | * refcount will remain nonzero and final deletion will have to wait. | ||
43 | * | ||
44 | * As a result we have two sets of functions to get/put inodes: | ||
45 | * logfs_safe_iget/logfs_safe_iput - safe to call from GC context | ||
46 | * logfs_iget/iput - normal version | ||
47 | */ | ||
48 | static struct kmem_cache *logfs_inode_cache; | ||
49 | |||
50 | static DEFINE_SPINLOCK(logfs_inode_lock); | ||
51 | |||
52 | static void logfs_inode_setops(struct inode *inode) | ||
53 | { | ||
54 | switch (inode->i_mode & S_IFMT) { | ||
55 | case S_IFDIR: | ||
56 | inode->i_op = &logfs_dir_iops; | ||
57 | inode->i_fop = &logfs_dir_fops; | ||
58 | inode->i_mapping->a_ops = &logfs_reg_aops; | ||
59 | break; | ||
60 | case S_IFREG: | ||
61 | inode->i_op = &logfs_reg_iops; | ||
62 | inode->i_fop = &logfs_reg_fops; | ||
63 | inode->i_mapping->a_ops = &logfs_reg_aops; | ||
64 | break; | ||
65 | case S_IFLNK: | ||
66 | inode->i_op = &logfs_symlink_iops; | ||
67 | inode->i_mapping->a_ops = &logfs_reg_aops; | ||
68 | break; | ||
69 | case S_IFSOCK: /* fall through */ | ||
70 | case S_IFBLK: /* fall through */ | ||
71 | case S_IFCHR: /* fall through */ | ||
72 | case S_IFIFO: | ||
73 | init_special_inode(inode, inode->i_mode, inode->i_rdev); | ||
74 | break; | ||
75 | default: | ||
76 | BUG(); | ||
77 | } | ||
78 | } | ||
79 | |||
80 | static struct inode *__logfs_iget(struct super_block *sb, ino_t ino) | ||
81 | { | ||
82 | struct inode *inode = iget_locked(sb, ino); | ||
83 | int err; | ||
84 | |||
85 | if (!inode) | ||
86 | return ERR_PTR(-ENOMEM); | ||
87 | if (!(inode->i_state & I_NEW)) | ||
88 | return inode; | ||
89 | |||
90 | err = logfs_read_inode(inode); | ||
91 | if (err || inode->i_nlink == 0) { | ||
92 | /* inode->i_nlink == 0 can be true when called from | ||
93 | * block validator */ | ||
94 | /* set i_nlink to 0 to prevent caching */ | ||
95 | inode->i_nlink = 0; | ||
96 | logfs_inode(inode)->li_flags |= LOGFS_IF_ZOMBIE; | ||
97 | iget_failed(inode); | ||
98 | if (!err) | ||
99 | err = -ENOENT; | ||
100 | return ERR_PTR(err); | ||
101 | } | ||
102 | |||
103 | logfs_inode_setops(inode); | ||
104 | unlock_new_inode(inode); | ||
105 | return inode; | ||
106 | } | ||
107 | |||
108 | struct inode *logfs_iget(struct super_block *sb, ino_t ino) | ||
109 | { | ||
110 | BUG_ON(ino == LOGFS_INO_MASTER); | ||
111 | BUG_ON(ino == LOGFS_INO_SEGFILE); | ||
112 | return __logfs_iget(sb, ino); | ||
113 | } | ||
114 | |||
115 | /* | ||
116 | * is_cached is set to 1 if we hand out a cached inode, 0 otherwise. | ||
117 | * this allows logfs_iput to do the right thing later | ||
118 | */ | ||
119 | struct inode *logfs_safe_iget(struct super_block *sb, ino_t ino, int *is_cached) | ||
120 | { | ||
121 | struct logfs_super *super = logfs_super(sb); | ||
122 | struct logfs_inode *li; | ||
123 | |||
124 | if (ino == LOGFS_INO_MASTER) | ||
125 | return super->s_master_inode; | ||
126 | if (ino == LOGFS_INO_SEGFILE) | ||
127 | return super->s_segfile_inode; | ||
128 | |||
129 | spin_lock(&logfs_inode_lock); | ||
130 | list_for_each_entry(li, &super->s_freeing_list, li_freeing_list) | ||
131 | if (li->vfs_inode.i_ino == ino) { | ||
132 | li->li_refcount++; | ||
133 | spin_unlock(&logfs_inode_lock); | ||
134 | *is_cached = 1; | ||
135 | return &li->vfs_inode; | ||
136 | } | ||
137 | spin_unlock(&logfs_inode_lock); | ||
138 | |||
139 | *is_cached = 0; | ||
140 | return __logfs_iget(sb, ino); | ||
141 | } | ||
142 | |||
143 | static void __logfs_destroy_inode(struct inode *inode) | ||
144 | { | ||
145 | struct logfs_inode *li = logfs_inode(inode); | ||
146 | |||
147 | BUG_ON(li->li_block); | ||
148 | list_del(&li->li_freeing_list); | ||
149 | kmem_cache_free(logfs_inode_cache, li); | ||
150 | } | ||
151 | |||
152 | static void logfs_destroy_inode(struct inode *inode) | ||
153 | { | ||
154 | struct logfs_inode *li = logfs_inode(inode); | ||
155 | |||
156 | BUG_ON(list_empty(&li->li_freeing_list)); | ||
157 | spin_lock(&logfs_inode_lock); | ||
158 | li->li_refcount--; | ||
159 | if (li->li_refcount == 0) | ||
160 | __logfs_destroy_inode(inode); | ||
161 | spin_unlock(&logfs_inode_lock); | ||
162 | } | ||
163 | |||
164 | void logfs_safe_iput(struct inode *inode, int is_cached) | ||
165 | { | ||
166 | if (inode->i_ino == LOGFS_INO_MASTER) | ||
167 | return; | ||
168 | if (inode->i_ino == LOGFS_INO_SEGFILE) | ||
169 | return; | ||
170 | |||
171 | if (is_cached) { | ||
172 | logfs_destroy_inode(inode); | ||
173 | return; | ||
174 | } | ||
175 | |||
176 | iput(inode); | ||
177 | } | ||
178 | |||
179 | static void logfs_init_inode(struct super_block *sb, struct inode *inode) | ||
180 | { | ||
181 | struct logfs_inode *li = logfs_inode(inode); | ||
182 | int i; | ||
183 | |||
184 | li->li_flags = 0; | ||
185 | li->li_height = 0; | ||
186 | li->li_used_bytes = 0; | ||
187 | li->li_block = NULL; | ||
188 | inode->i_uid = 0; | ||
189 | inode->i_gid = 0; | ||
190 | inode->i_size = 0; | ||
191 | inode->i_blocks = 0; | ||
192 | inode->i_ctime = CURRENT_TIME; | ||
193 | inode->i_mtime = CURRENT_TIME; | ||
194 | inode->i_nlink = 1; | ||
195 | INIT_LIST_HEAD(&li->li_freeing_list); | ||
196 | |||
197 | for (i = 0; i < LOGFS_EMBEDDED_FIELDS; i++) | ||
198 | li->li_data[i] = 0; | ||
199 | |||
200 | return; | ||
201 | } | ||
202 | |||
203 | static struct inode *logfs_alloc_inode(struct super_block *sb) | ||
204 | { | ||
205 | struct logfs_inode *li; | ||
206 | |||
207 | li = kmem_cache_alloc(logfs_inode_cache, GFP_NOFS); | ||
208 | if (!li) | ||
209 | return NULL; | ||
210 | logfs_init_inode(sb, &li->vfs_inode); | ||
211 | return &li->vfs_inode; | ||
212 | } | ||
213 | |||
214 | /* | ||
215 | * In logfs inodes are written to an inode file. The inode file, like any | ||
216 | * other file, is managed with a inode. The inode file's inode, aka master | ||
217 | * inode, requires special handling in several respects. First, it cannot be | ||
218 | * written to the inode file, so it is stored in the journal instead. | ||
219 | * | ||
220 | * Secondly, this inode cannot be written back and destroyed before all other | ||
221 | * inodes have been written. The ordering is important. Linux' VFS is happily | ||
222 | * unaware of the ordering constraint and would ordinarily destroy the master | ||
223 | * inode at umount time while other inodes are still in use and dirty. Not | ||
224 | * good. | ||
225 | * | ||
226 | * So logfs makes sure the master inode is not written until all other inodes | ||
227 | * have been destroyed. Sadly, this method has another side-effect. The VFS | ||
228 | * will notice one remaining inode and print a frightening warning message. | ||
229 | * Worse, it is impossible to judge whether such a warning was caused by the | ||
230 | * master inode or any other inodes have leaked as well. | ||
231 | * | ||
232 | * Our attempt of solving this is with logfs_new_meta_inode() below. Its | ||
233 | * purpose is to create a new inode that will not trigger the warning if such | ||
234 | * an inode is still in use. An ugly hack, no doubt. Suggections for | ||
235 | * improvement are welcome. | ||
236 | */ | ||
237 | struct inode *logfs_new_meta_inode(struct super_block *sb, u64 ino) | ||
238 | { | ||
239 | struct inode *inode; | ||
240 | |||
241 | inode = logfs_alloc_inode(sb); | ||
242 | if (!inode) | ||
243 | return ERR_PTR(-ENOMEM); | ||
244 | |||
245 | inode->i_mode = S_IFREG; | ||
246 | inode->i_ino = ino; | ||
247 | inode->i_sb = sb; | ||
248 | |||
249 | /* This is a blatant copy of alloc_inode code. We'd need alloc_inode | ||
250 | * to be nonstatic, alas. */ | ||
251 | { | ||
252 | struct address_space * const mapping = &inode->i_data; | ||
253 | |||
254 | mapping->a_ops = &logfs_reg_aops; | ||
255 | mapping->host = inode; | ||
256 | mapping->flags = 0; | ||
257 | mapping_set_gfp_mask(mapping, GFP_NOFS); | ||
258 | mapping->assoc_mapping = NULL; | ||
259 | mapping->backing_dev_info = &default_backing_dev_info; | ||
260 | inode->i_mapping = mapping; | ||
261 | inode->i_nlink = 1; | ||
262 | } | ||
263 | |||
264 | return inode; | ||
265 | } | ||
266 | |||
267 | struct inode *logfs_read_meta_inode(struct super_block *sb, u64 ino) | ||
268 | { | ||
269 | struct inode *inode; | ||
270 | int err; | ||
271 | |||
272 | inode = logfs_new_meta_inode(sb, ino); | ||
273 | if (IS_ERR(inode)) | ||
274 | return inode; | ||
275 | |||
276 | err = logfs_read_inode(inode); | ||
277 | if (err) { | ||
278 | destroy_meta_inode(inode); | ||
279 | return ERR_PTR(err); | ||
280 | } | ||
281 | logfs_inode_setops(inode); | ||
282 | return inode; | ||
283 | } | ||
284 | |||
285 | static int logfs_write_inode(struct inode *inode, struct writeback_control *wbc) | ||
286 | { | ||
287 | int ret; | ||
288 | long flags = WF_LOCK; | ||
289 | |||
290 | /* Can only happen if creat() failed. Safe to skip. */ | ||
291 | if (logfs_inode(inode)->li_flags & LOGFS_IF_STILLBORN) | ||
292 | return 0; | ||
293 | |||
294 | ret = __logfs_write_inode(inode, flags); | ||
295 | LOGFS_BUG_ON(ret, inode->i_sb); | ||
296 | return ret; | ||
297 | } | ||
298 | |||
299 | void destroy_meta_inode(struct inode *inode) | ||
300 | { | ||
301 | if (inode) { | ||
302 | if (inode->i_data.nrpages) | ||
303 | truncate_inode_pages(&inode->i_data, 0); | ||
304 | logfs_clear_inode(inode); | ||
305 | kmem_cache_free(logfs_inode_cache, logfs_inode(inode)); | ||
306 | } | ||
307 | } | ||
308 | |||
309 | /* called with inode_lock held */ | ||
310 | static void logfs_drop_inode(struct inode *inode) | ||
311 | { | ||
312 | struct logfs_super *super = logfs_super(inode->i_sb); | ||
313 | struct logfs_inode *li = logfs_inode(inode); | ||
314 | |||
315 | spin_lock(&logfs_inode_lock); | ||
316 | list_move(&li->li_freeing_list, &super->s_freeing_list); | ||
317 | spin_unlock(&logfs_inode_lock); | ||
318 | generic_drop_inode(inode); | ||
319 | } | ||
320 | |||
321 | static void logfs_set_ino_generation(struct super_block *sb, | ||
322 | struct inode *inode) | ||
323 | { | ||
324 | struct logfs_super *super = logfs_super(sb); | ||
325 | u64 ino; | ||
326 | |||
327 | mutex_lock(&super->s_journal_mutex); | ||
328 | ino = logfs_seek_hole(super->s_master_inode, super->s_last_ino); | ||
329 | super->s_last_ino = ino; | ||
330 | super->s_inos_till_wrap--; | ||
331 | if (super->s_inos_till_wrap < 0) { | ||
332 | super->s_last_ino = LOGFS_RESERVED_INOS; | ||
333 | super->s_generation++; | ||
334 | super->s_inos_till_wrap = INOS_PER_WRAP; | ||
335 | } | ||
336 | inode->i_ino = ino; | ||
337 | inode->i_generation = super->s_generation; | ||
338 | mutex_unlock(&super->s_journal_mutex); | ||
339 | } | ||
340 | |||
341 | struct inode *logfs_new_inode(struct inode *dir, int mode) | ||
342 | { | ||
343 | struct super_block *sb = dir->i_sb; | ||
344 | struct inode *inode; | ||
345 | |||
346 | inode = new_inode(sb); | ||
347 | if (!inode) | ||
348 | return ERR_PTR(-ENOMEM); | ||
349 | |||
350 | logfs_init_inode(sb, inode); | ||
351 | |||
352 | /* inherit parent flags */ | ||
353 | logfs_inode(inode)->li_flags |= | ||
354 | logfs_inode(dir)->li_flags & LOGFS_FL_INHERITED; | ||
355 | |||
356 | inode->i_mode = mode; | ||
357 | logfs_set_ino_generation(sb, inode); | ||
358 | |||
359 | inode->i_uid = current_fsuid(); | ||
360 | inode->i_gid = current_fsgid(); | ||
361 | if (dir->i_mode & S_ISGID) { | ||
362 | inode->i_gid = dir->i_gid; | ||
363 | if (S_ISDIR(mode)) | ||
364 | inode->i_mode |= S_ISGID; | ||
365 | } | ||
366 | |||
367 | logfs_inode_setops(inode); | ||
368 | insert_inode_hash(inode); | ||
369 | |||
370 | return inode; | ||
371 | } | ||
372 | |||
373 | static void logfs_init_once(void *_li) | ||
374 | { | ||
375 | struct logfs_inode *li = _li; | ||
376 | int i; | ||
377 | |||
378 | li->li_flags = 0; | ||
379 | li->li_used_bytes = 0; | ||
380 | li->li_refcount = 1; | ||
381 | for (i = 0; i < LOGFS_EMBEDDED_FIELDS; i++) | ||
382 | li->li_data[i] = 0; | ||
383 | inode_init_once(&li->vfs_inode); | ||
384 | } | ||
385 | |||
386 | static int logfs_sync_fs(struct super_block *sb, int wait) | ||
387 | { | ||
388 | /* FIXME: write anchor */ | ||
389 | logfs_super(sb)->s_devops->sync(sb); | ||
390 | return 0; | ||
391 | } | ||
392 | |||
393 | const struct super_operations logfs_super_operations = { | ||
394 | .alloc_inode = logfs_alloc_inode, | ||
395 | .clear_inode = logfs_clear_inode, | ||
396 | .delete_inode = logfs_delete_inode, | ||
397 | .destroy_inode = logfs_destroy_inode, | ||
398 | .drop_inode = logfs_drop_inode, | ||
399 | .write_inode = logfs_write_inode, | ||
400 | .statfs = logfs_statfs, | ||
401 | .sync_fs = logfs_sync_fs, | ||
402 | }; | ||
403 | |||
404 | int logfs_init_inode_cache(void) | ||
405 | { | ||
406 | logfs_inode_cache = kmem_cache_create("logfs_inode_cache", | ||
407 | sizeof(struct logfs_inode), 0, SLAB_RECLAIM_ACCOUNT, | ||
408 | logfs_init_once); | ||
409 | if (!logfs_inode_cache) | ||
410 | return -ENOMEM; | ||
411 | return 0; | ||
412 | } | ||
413 | |||
414 | void logfs_destroy_inode_cache(void) | ||
415 | { | ||
416 | kmem_cache_destroy(logfs_inode_cache); | ||
417 | } | ||
diff --git a/fs/logfs/journal.c b/fs/logfs/journal.c new file mode 100644 index 000000000000..6ad30a4c9052 --- /dev/null +++ b/fs/logfs/journal.c | |||
@@ -0,0 +1,883 @@ | |||
1 | /* | ||
2 | * fs/logfs/journal.c - journal handling code | ||
3 | * | ||
4 | * As should be obvious for Linux kernel code, license is GPLv2 | ||
5 | * | ||
6 | * Copyright (c) 2005-2008 Joern Engel <joern@logfs.org> | ||
7 | */ | ||
8 | #include "logfs.h" | ||
9 | |||
10 | static void logfs_calc_free(struct super_block *sb) | ||
11 | { | ||
12 | struct logfs_super *super = logfs_super(sb); | ||
13 | u64 reserve, no_segs = super->s_no_segs; | ||
14 | s64 free; | ||
15 | int i; | ||
16 | |||
17 | /* superblock segments */ | ||
18 | no_segs -= 2; | ||
19 | super->s_no_journal_segs = 0; | ||
20 | /* journal */ | ||
21 | journal_for_each(i) | ||
22 | if (super->s_journal_seg[i]) { | ||
23 | no_segs--; | ||
24 | super->s_no_journal_segs++; | ||
25 | } | ||
26 | |||
27 | /* open segments plus one extra per level for GC */ | ||
28 | no_segs -= 2 * super->s_total_levels; | ||
29 | |||
30 | free = no_segs * (super->s_segsize - LOGFS_SEGMENT_RESERVE); | ||
31 | free -= super->s_used_bytes; | ||
32 | /* just a bit extra */ | ||
33 | free -= super->s_total_levels * 4096; | ||
34 | |||
35 | /* Bad blocks are 'paid' for with speed reserve - the filesystem | ||
36 | * simply gets slower as bad blocks accumulate. Until the bad blocks | ||
37 | * exceed the speed reserve - then the filesystem gets smaller. | ||
38 | */ | ||
39 | reserve = super->s_bad_segments + super->s_bad_seg_reserve; | ||
40 | reserve *= super->s_segsize - LOGFS_SEGMENT_RESERVE; | ||
41 | reserve = max(reserve, super->s_speed_reserve); | ||
42 | free -= reserve; | ||
43 | if (free < 0) | ||
44 | free = 0; | ||
45 | |||
46 | super->s_free_bytes = free; | ||
47 | } | ||
48 | |||
49 | static void reserve_sb_and_journal(struct super_block *sb) | ||
50 | { | ||
51 | struct logfs_super *super = logfs_super(sb); | ||
52 | struct btree_head32 *head = &super->s_reserved_segments; | ||
53 | int i, err; | ||
54 | |||
55 | err = btree_insert32(head, seg_no(sb, super->s_sb_ofs[0]), (void *)1, | ||
56 | GFP_KERNEL); | ||
57 | BUG_ON(err); | ||
58 | |||
59 | err = btree_insert32(head, seg_no(sb, super->s_sb_ofs[1]), (void *)1, | ||
60 | GFP_KERNEL); | ||
61 | BUG_ON(err); | ||
62 | |||
63 | journal_for_each(i) { | ||
64 | if (!super->s_journal_seg[i]) | ||
65 | continue; | ||
66 | err = btree_insert32(head, super->s_journal_seg[i], (void *)1, | ||
67 | GFP_KERNEL); | ||
68 | BUG_ON(err); | ||
69 | } | ||
70 | } | ||
71 | |||
72 | static void read_dynsb(struct super_block *sb, | ||
73 | struct logfs_je_dynsb *dynsb) | ||
74 | { | ||
75 | struct logfs_super *super = logfs_super(sb); | ||
76 | |||
77 | super->s_gec = be64_to_cpu(dynsb->ds_gec); | ||
78 | super->s_sweeper = be64_to_cpu(dynsb->ds_sweeper); | ||
79 | super->s_victim_ino = be64_to_cpu(dynsb->ds_victim_ino); | ||
80 | super->s_rename_dir = be64_to_cpu(dynsb->ds_rename_dir); | ||
81 | super->s_rename_pos = be64_to_cpu(dynsb->ds_rename_pos); | ||
82 | super->s_used_bytes = be64_to_cpu(dynsb->ds_used_bytes); | ||
83 | super->s_generation = be32_to_cpu(dynsb->ds_generation); | ||
84 | } | ||
85 | |||
86 | static void read_anchor(struct super_block *sb, | ||
87 | struct logfs_je_anchor *da) | ||
88 | { | ||
89 | struct logfs_super *super = logfs_super(sb); | ||
90 | struct inode *inode = super->s_master_inode; | ||
91 | struct logfs_inode *li = logfs_inode(inode); | ||
92 | int i; | ||
93 | |||
94 | super->s_last_ino = be64_to_cpu(da->da_last_ino); | ||
95 | li->li_flags = 0; | ||
96 | li->li_height = da->da_height; | ||
97 | i_size_write(inode, be64_to_cpu(da->da_size)); | ||
98 | li->li_used_bytes = be64_to_cpu(da->da_used_bytes); | ||
99 | |||
100 | for (i = 0; i < LOGFS_EMBEDDED_FIELDS; i++) | ||
101 | li->li_data[i] = be64_to_cpu(da->da_data[i]); | ||
102 | } | ||
103 | |||
104 | static void read_erasecount(struct super_block *sb, | ||
105 | struct logfs_je_journal_ec *ec) | ||
106 | { | ||
107 | struct logfs_super *super = logfs_super(sb); | ||
108 | int i; | ||
109 | |||
110 | journal_for_each(i) | ||
111 | super->s_journal_ec[i] = be32_to_cpu(ec->ec[i]); | ||
112 | } | ||
113 | |||
114 | static int read_area(struct super_block *sb, struct logfs_je_area *a) | ||
115 | { | ||
116 | struct logfs_super *super = logfs_super(sb); | ||
117 | struct logfs_area *area = super->s_area[a->gc_level]; | ||
118 | u64 ofs; | ||
119 | u32 writemask = ~(super->s_writesize - 1); | ||
120 | |||
121 | if (a->gc_level >= LOGFS_NO_AREAS) | ||
122 | return -EIO; | ||
123 | if (a->vim != VIM_DEFAULT) | ||
124 | return -EIO; /* TODO: close area and continue */ | ||
125 | |||
126 | area->a_used_bytes = be32_to_cpu(a->used_bytes); | ||
127 | area->a_written_bytes = area->a_used_bytes & writemask; | ||
128 | area->a_segno = be32_to_cpu(a->segno); | ||
129 | if (area->a_segno) | ||
130 | area->a_is_open = 1; | ||
131 | |||
132 | ofs = dev_ofs(sb, area->a_segno, area->a_written_bytes); | ||
133 | if (super->s_writesize > 1) | ||
134 | logfs_buf_recover(area, ofs, a + 1, super->s_writesize); | ||
135 | else | ||
136 | logfs_buf_recover(area, ofs, NULL, 0); | ||
137 | return 0; | ||
138 | } | ||
139 | |||
140 | static void *unpack(void *from, void *to) | ||
141 | { | ||
142 | struct logfs_journal_header *jh = from; | ||
143 | void *data = from + sizeof(struct logfs_journal_header); | ||
144 | int err; | ||
145 | size_t inlen, outlen; | ||
146 | |||
147 | inlen = be16_to_cpu(jh->h_len); | ||
148 | outlen = be16_to_cpu(jh->h_datalen); | ||
149 | |||
150 | if (jh->h_compr == COMPR_NONE) | ||
151 | memcpy(to, data, inlen); | ||
152 | else { | ||
153 | err = logfs_uncompress(data, to, inlen, outlen); | ||
154 | BUG_ON(err); | ||
155 | } | ||
156 | return to; | ||
157 | } | ||
158 | |||
159 | static int __read_je_header(struct super_block *sb, u64 ofs, | ||
160 | struct logfs_journal_header *jh) | ||
161 | { | ||
162 | struct logfs_super *super = logfs_super(sb); | ||
163 | size_t bufsize = max_t(size_t, sb->s_blocksize, super->s_writesize) | ||
164 | + MAX_JOURNAL_HEADER; | ||
165 | u16 type, len, datalen; | ||
166 | int err; | ||
167 | |||
168 | /* read header only */ | ||
169 | err = wbuf_read(sb, ofs, sizeof(*jh), jh); | ||
170 | if (err) | ||
171 | return err; | ||
172 | type = be16_to_cpu(jh->h_type); | ||
173 | len = be16_to_cpu(jh->h_len); | ||
174 | datalen = be16_to_cpu(jh->h_datalen); | ||
175 | if (len > sb->s_blocksize) | ||
176 | return -EIO; | ||
177 | if ((type < JE_FIRST) || (type > JE_LAST)) | ||
178 | return -EIO; | ||
179 | if (datalen > bufsize) | ||
180 | return -EIO; | ||
181 | return 0; | ||
182 | } | ||
183 | |||
184 | static int __read_je_payload(struct super_block *sb, u64 ofs, | ||
185 | struct logfs_journal_header *jh) | ||
186 | { | ||
187 | u16 len; | ||
188 | int err; | ||
189 | |||
190 | len = be16_to_cpu(jh->h_len); | ||
191 | err = wbuf_read(sb, ofs + sizeof(*jh), len, jh + 1); | ||
192 | if (err) | ||
193 | return err; | ||
194 | if (jh->h_crc != logfs_crc32(jh, len + sizeof(*jh), 4)) { | ||
195 | /* Old code was confused. It forgot about the header length | ||
196 | * and stopped calculating the crc 16 bytes before the end | ||
197 | * of data - ick! | ||
198 | * FIXME: Remove this hack once the old code is fixed. | ||
199 | */ | ||
200 | if (jh->h_crc == logfs_crc32(jh, len, 4)) | ||
201 | WARN_ON_ONCE(1); | ||
202 | else | ||
203 | return -EIO; | ||
204 | } | ||
205 | return 0; | ||
206 | } | ||
207 | |||
208 | /* | ||
209 | * jh needs to be large enough to hold the complete entry, not just the header | ||
210 | */ | ||
211 | static int __read_je(struct super_block *sb, u64 ofs, | ||
212 | struct logfs_journal_header *jh) | ||
213 | { | ||
214 | int err; | ||
215 | |||
216 | err = __read_je_header(sb, ofs, jh); | ||
217 | if (err) | ||
218 | return err; | ||
219 | return __read_je_payload(sb, ofs, jh); | ||
220 | } | ||
221 | |||
222 | static int read_je(struct super_block *sb, u64 ofs) | ||
223 | { | ||
224 | struct logfs_super *super = logfs_super(sb); | ||
225 | struct logfs_journal_header *jh = super->s_compressed_je; | ||
226 | void *scratch = super->s_je; | ||
227 | u16 type, datalen; | ||
228 | int err; | ||
229 | |||
230 | err = __read_je(sb, ofs, jh); | ||
231 | if (err) | ||
232 | return err; | ||
233 | type = be16_to_cpu(jh->h_type); | ||
234 | datalen = be16_to_cpu(jh->h_datalen); | ||
235 | |||
236 | switch (type) { | ||
237 | case JE_DYNSB: | ||
238 | read_dynsb(sb, unpack(jh, scratch)); | ||
239 | break; | ||
240 | case JE_ANCHOR: | ||
241 | read_anchor(sb, unpack(jh, scratch)); | ||
242 | break; | ||
243 | case JE_ERASECOUNT: | ||
244 | read_erasecount(sb, unpack(jh, scratch)); | ||
245 | break; | ||
246 | case JE_AREA: | ||
247 | read_area(sb, unpack(jh, scratch)); | ||
248 | break; | ||
249 | case JE_OBJ_ALIAS: | ||
250 | err = logfs_load_object_aliases(sb, unpack(jh, scratch), | ||
251 | datalen); | ||
252 | break; | ||
253 | default: | ||
254 | WARN_ON_ONCE(1); | ||
255 | return -EIO; | ||
256 | } | ||
257 | return err; | ||
258 | } | ||
259 | |||
260 | static int logfs_read_segment(struct super_block *sb, u32 segno) | ||
261 | { | ||
262 | struct logfs_super *super = logfs_super(sb); | ||
263 | struct logfs_journal_header *jh = super->s_compressed_je; | ||
264 | u64 ofs, seg_ofs = dev_ofs(sb, segno, 0); | ||
265 | u32 h_ofs, last_ofs = 0; | ||
266 | u16 len, datalen, last_len = 0; | ||
267 | int i, err; | ||
268 | |||
269 | /* search for most recent commit */ | ||
270 | for (h_ofs = 0; h_ofs < super->s_segsize; h_ofs += sizeof(*jh)) { | ||
271 | ofs = seg_ofs + h_ofs; | ||
272 | err = __read_je_header(sb, ofs, jh); | ||
273 | if (err) | ||
274 | continue; | ||
275 | if (jh->h_type != cpu_to_be16(JE_COMMIT)) | ||
276 | continue; | ||
277 | err = __read_je_payload(sb, ofs, jh); | ||
278 | if (err) | ||
279 | continue; | ||
280 | len = be16_to_cpu(jh->h_len); | ||
281 | datalen = be16_to_cpu(jh->h_datalen); | ||
282 | if ((datalen > sizeof(super->s_je_array)) || | ||
283 | (datalen % sizeof(__be64))) | ||
284 | continue; | ||
285 | last_ofs = h_ofs; | ||
286 | last_len = datalen; | ||
287 | h_ofs += ALIGN(len, sizeof(*jh)) - sizeof(*jh); | ||
288 | } | ||
289 | /* read commit */ | ||
290 | if (last_ofs == 0) | ||
291 | return -ENOENT; | ||
292 | ofs = seg_ofs + last_ofs; | ||
293 | log_journal("Read commit from %llx\n", ofs); | ||
294 | err = __read_je(sb, ofs, jh); | ||
295 | BUG_ON(err); /* We should have caught it in the scan loop already */ | ||
296 | if (err) | ||
297 | return err; | ||
298 | /* uncompress */ | ||
299 | unpack(jh, super->s_je_array); | ||
300 | super->s_no_je = last_len / sizeof(__be64); | ||
301 | /* iterate over array */ | ||
302 | for (i = 0; i < super->s_no_je; i++) { | ||
303 | err = read_je(sb, be64_to_cpu(super->s_je_array[i])); | ||
304 | if (err) | ||
305 | return err; | ||
306 | } | ||
307 | super->s_journal_area->a_segno = segno; | ||
308 | return 0; | ||
309 | } | ||
310 | |||
311 | static u64 read_gec(struct super_block *sb, u32 segno) | ||
312 | { | ||
313 | struct logfs_segment_header sh; | ||
314 | __be32 crc; | ||
315 | int err; | ||
316 | |||
317 | if (!segno) | ||
318 | return 0; | ||
319 | err = wbuf_read(sb, dev_ofs(sb, segno, 0), sizeof(sh), &sh); | ||
320 | if (err) | ||
321 | return 0; | ||
322 | crc = logfs_crc32(&sh, sizeof(sh), 4); | ||
323 | if (crc != sh.crc) { | ||
324 | WARN_ON(sh.gec != cpu_to_be64(0xffffffffffffffffull)); | ||
325 | /* Most likely it was just erased */ | ||
326 | return 0; | ||
327 | } | ||
328 | return be64_to_cpu(sh.gec); | ||
329 | } | ||
330 | |||
331 | static int logfs_read_journal(struct super_block *sb) | ||
332 | { | ||
333 | struct logfs_super *super = logfs_super(sb); | ||
334 | u64 gec[LOGFS_JOURNAL_SEGS], max; | ||
335 | u32 segno; | ||
336 | int i, max_i; | ||
337 | |||
338 | max = 0; | ||
339 | max_i = -1; | ||
340 | journal_for_each(i) { | ||
341 | segno = super->s_journal_seg[i]; | ||
342 | gec[i] = read_gec(sb, super->s_journal_seg[i]); | ||
343 | if (gec[i] > max) { | ||
344 | max = gec[i]; | ||
345 | max_i = i; | ||
346 | } | ||
347 | } | ||
348 | if (max_i == -1) | ||
349 | return -EIO; | ||
350 | /* FIXME: Try older segments in case of error */ | ||
351 | return logfs_read_segment(sb, super->s_journal_seg[max_i]); | ||
352 | } | ||
353 | |||
354 | /* | ||
355 | * First search the current segment (outer loop), then pick the next segment | ||
356 | * in the array, skipping any zero entries (inner loop). | ||
357 | */ | ||
358 | static void journal_get_free_segment(struct logfs_area *area) | ||
359 | { | ||
360 | struct logfs_super *super = logfs_super(area->a_sb); | ||
361 | int i; | ||
362 | |||
363 | journal_for_each(i) { | ||
364 | if (area->a_segno != super->s_journal_seg[i]) | ||
365 | continue; | ||
366 | |||
367 | do { | ||
368 | i++; | ||
369 | if (i == LOGFS_JOURNAL_SEGS) | ||
370 | i = 0; | ||
371 | } while (!super->s_journal_seg[i]); | ||
372 | |||
373 | area->a_segno = super->s_journal_seg[i]; | ||
374 | area->a_erase_count = ++(super->s_journal_ec[i]); | ||
375 | log_journal("Journal now at %x (ec %x)\n", area->a_segno, | ||
376 | area->a_erase_count); | ||
377 | return; | ||
378 | } | ||
379 | BUG(); | ||
380 | } | ||
381 | |||
382 | static void journal_get_erase_count(struct logfs_area *area) | ||
383 | { | ||
384 | /* erase count is stored globally and incremented in | ||
385 | * journal_get_free_segment() - nothing to do here */ | ||
386 | } | ||
387 | |||
388 | static int journal_erase_segment(struct logfs_area *area) | ||
389 | { | ||
390 | struct super_block *sb = area->a_sb; | ||
391 | struct logfs_segment_header sh; | ||
392 | u64 ofs; | ||
393 | int err; | ||
394 | |||
395 | err = logfs_erase_segment(sb, area->a_segno, 1); | ||
396 | if (err) | ||
397 | return err; | ||
398 | |||
399 | sh.pad = 0; | ||
400 | sh.type = SEG_JOURNAL; | ||
401 | sh.level = 0; | ||
402 | sh.segno = cpu_to_be32(area->a_segno); | ||
403 | sh.ec = cpu_to_be32(area->a_erase_count); | ||
404 | sh.gec = cpu_to_be64(logfs_super(sb)->s_gec); | ||
405 | sh.crc = logfs_crc32(&sh, sizeof(sh), 4); | ||
406 | |||
407 | /* This causes a bug in segment.c. Not yet. */ | ||
408 | //logfs_set_segment_erased(sb, area->a_segno, area->a_erase_count, 0); | ||
409 | |||
410 | ofs = dev_ofs(sb, area->a_segno, 0); | ||
411 | area->a_used_bytes = ALIGN(sizeof(sh), 16); | ||
412 | logfs_buf_write(area, ofs, &sh, sizeof(sh)); | ||
413 | return 0; | ||
414 | } | ||
415 | |||
416 | static size_t __logfs_write_header(struct logfs_super *super, | ||
417 | struct logfs_journal_header *jh, size_t len, size_t datalen, | ||
418 | u16 type, u8 compr) | ||
419 | { | ||
420 | jh->h_len = cpu_to_be16(len); | ||
421 | jh->h_type = cpu_to_be16(type); | ||
422 | jh->h_datalen = cpu_to_be16(datalen); | ||
423 | jh->h_compr = compr; | ||
424 | jh->h_pad[0] = 'H'; | ||
425 | jh->h_pad[1] = 'E'; | ||
426 | jh->h_pad[2] = 'A'; | ||
427 | jh->h_pad[3] = 'D'; | ||
428 | jh->h_pad[4] = 'R'; | ||
429 | jh->h_crc = logfs_crc32(jh, len + sizeof(*jh), 4); | ||
430 | return ALIGN(len, 16) + sizeof(*jh); | ||
431 | } | ||
432 | |||
433 | static size_t logfs_write_header(struct logfs_super *super, | ||
434 | struct logfs_journal_header *jh, size_t datalen, u16 type) | ||
435 | { | ||
436 | size_t len = datalen; | ||
437 | |||
438 | return __logfs_write_header(super, jh, len, datalen, type, COMPR_NONE); | ||
439 | } | ||
440 | |||
441 | static inline size_t logfs_journal_erasecount_size(struct logfs_super *super) | ||
442 | { | ||
443 | return LOGFS_JOURNAL_SEGS * sizeof(__be32); | ||
444 | } | ||
445 | |||
446 | static void *logfs_write_erasecount(struct super_block *sb, void *_ec, | ||
447 | u16 *type, size_t *len) | ||
448 | { | ||
449 | struct logfs_super *super = logfs_super(sb); | ||
450 | struct logfs_je_journal_ec *ec = _ec; | ||
451 | int i; | ||
452 | |||
453 | journal_for_each(i) | ||
454 | ec->ec[i] = cpu_to_be32(super->s_journal_ec[i]); | ||
455 | *type = JE_ERASECOUNT; | ||
456 | *len = logfs_journal_erasecount_size(super); | ||
457 | return ec; | ||
458 | } | ||
459 | |||
460 | static void account_shadow(void *_shadow, unsigned long _sb, u64 ignore, | ||
461 | size_t ignore2) | ||
462 | { | ||
463 | struct logfs_shadow *shadow = _shadow; | ||
464 | struct super_block *sb = (void *)_sb; | ||
465 | struct logfs_super *super = logfs_super(sb); | ||
466 | |||
467 | /* consume new space */ | ||
468 | super->s_free_bytes -= shadow->new_len; | ||
469 | super->s_used_bytes += shadow->new_len; | ||
470 | super->s_dirty_used_bytes -= shadow->new_len; | ||
471 | |||
472 | /* free up old space */ | ||
473 | super->s_free_bytes += shadow->old_len; | ||
474 | super->s_used_bytes -= shadow->old_len; | ||
475 | super->s_dirty_free_bytes -= shadow->old_len; | ||
476 | |||
477 | logfs_set_segment_used(sb, shadow->old_ofs, -shadow->old_len); | ||
478 | logfs_set_segment_used(sb, shadow->new_ofs, shadow->new_len); | ||
479 | |||
480 | log_journal("account_shadow(%llx, %llx, %x) %llx->%llx %x->%x\n", | ||
481 | shadow->ino, shadow->bix, shadow->gc_level, | ||
482 | shadow->old_ofs, shadow->new_ofs, | ||
483 | shadow->old_len, shadow->new_len); | ||
484 | mempool_free(shadow, super->s_shadow_pool); | ||
485 | } | ||
486 | |||
487 | static void account_shadows(struct super_block *sb) | ||
488 | { | ||
489 | struct logfs_super *super = logfs_super(sb); | ||
490 | struct inode *inode = super->s_master_inode; | ||
491 | struct logfs_inode *li = logfs_inode(inode); | ||
492 | struct shadow_tree *tree = &super->s_shadow_tree; | ||
493 | |||
494 | btree_grim_visitor64(&tree->new, (unsigned long)sb, account_shadow); | ||
495 | btree_grim_visitor64(&tree->old, (unsigned long)sb, account_shadow); | ||
496 | |||
497 | if (li->li_block) { | ||
498 | /* | ||
499 | * We never actually use the structure, when attached to the | ||
500 | * master inode. But it is easier to always free it here than | ||
501 | * to have checks in several places elsewhere when allocating | ||
502 | * it. | ||
503 | */ | ||
504 | li->li_block->ops->free_block(sb, li->li_block); | ||
505 | } | ||
506 | BUG_ON((s64)li->li_used_bytes < 0); | ||
507 | } | ||
508 | |||
509 | static void *__logfs_write_anchor(struct super_block *sb, void *_da, | ||
510 | u16 *type, size_t *len) | ||
511 | { | ||
512 | struct logfs_super *super = logfs_super(sb); | ||
513 | struct logfs_je_anchor *da = _da; | ||
514 | struct inode *inode = super->s_master_inode; | ||
515 | struct logfs_inode *li = logfs_inode(inode); | ||
516 | int i; | ||
517 | |||
518 | da->da_height = li->li_height; | ||
519 | da->da_last_ino = cpu_to_be64(super->s_last_ino); | ||
520 | da->da_size = cpu_to_be64(i_size_read(inode)); | ||
521 | da->da_used_bytes = cpu_to_be64(li->li_used_bytes); | ||
522 | for (i = 0; i < LOGFS_EMBEDDED_FIELDS; i++) | ||
523 | da->da_data[i] = cpu_to_be64(li->li_data[i]); | ||
524 | *type = JE_ANCHOR; | ||
525 | *len = sizeof(*da); | ||
526 | return da; | ||
527 | } | ||
528 | |||
529 | static void *logfs_write_dynsb(struct super_block *sb, void *_dynsb, | ||
530 | u16 *type, size_t *len) | ||
531 | { | ||
532 | struct logfs_super *super = logfs_super(sb); | ||
533 | struct logfs_je_dynsb *dynsb = _dynsb; | ||
534 | |||
535 | dynsb->ds_gec = cpu_to_be64(super->s_gec); | ||
536 | dynsb->ds_sweeper = cpu_to_be64(super->s_sweeper); | ||
537 | dynsb->ds_victim_ino = cpu_to_be64(super->s_victim_ino); | ||
538 | dynsb->ds_rename_dir = cpu_to_be64(super->s_rename_dir); | ||
539 | dynsb->ds_rename_pos = cpu_to_be64(super->s_rename_pos); | ||
540 | dynsb->ds_used_bytes = cpu_to_be64(super->s_used_bytes); | ||
541 | dynsb->ds_generation = cpu_to_be32(super->s_generation); | ||
542 | *type = JE_DYNSB; | ||
543 | *len = sizeof(*dynsb); | ||
544 | return dynsb; | ||
545 | } | ||
546 | |||
547 | static void write_wbuf(struct super_block *sb, struct logfs_area *area, | ||
548 | void *wbuf) | ||
549 | { | ||
550 | struct logfs_super *super = logfs_super(sb); | ||
551 | struct address_space *mapping = super->s_mapping_inode->i_mapping; | ||
552 | u64 ofs; | ||
553 | pgoff_t index; | ||
554 | int page_ofs; | ||
555 | struct page *page; | ||
556 | |||
557 | ofs = dev_ofs(sb, area->a_segno, | ||
558 | area->a_used_bytes & ~(super->s_writesize - 1)); | ||
559 | index = ofs >> PAGE_SHIFT; | ||
560 | page_ofs = ofs & (PAGE_SIZE - 1); | ||
561 | |||
562 | page = find_lock_page(mapping, index); | ||
563 | BUG_ON(!page); | ||
564 | memcpy(wbuf, page_address(page) + page_ofs, super->s_writesize); | ||
565 | unlock_page(page); | ||
566 | } | ||
567 | |||
568 | static void *logfs_write_area(struct super_block *sb, void *_a, | ||
569 | u16 *type, size_t *len) | ||
570 | { | ||
571 | struct logfs_super *super = logfs_super(sb); | ||
572 | struct logfs_area *area = super->s_area[super->s_sum_index]; | ||
573 | struct logfs_je_area *a = _a; | ||
574 | |||
575 | a->vim = VIM_DEFAULT; | ||
576 | a->gc_level = super->s_sum_index; | ||
577 | a->used_bytes = cpu_to_be32(area->a_used_bytes); | ||
578 | a->segno = cpu_to_be32(area->a_segno); | ||
579 | if (super->s_writesize > 1) | ||
580 | write_wbuf(sb, area, a + 1); | ||
581 | |||
582 | *type = JE_AREA; | ||
583 | *len = sizeof(*a) + super->s_writesize; | ||
584 | return a; | ||
585 | } | ||
586 | |||
587 | static void *logfs_write_commit(struct super_block *sb, void *h, | ||
588 | u16 *type, size_t *len) | ||
589 | { | ||
590 | struct logfs_super *super = logfs_super(sb); | ||
591 | |||
592 | *type = JE_COMMIT; | ||
593 | *len = super->s_no_je * sizeof(__be64); | ||
594 | return super->s_je_array; | ||
595 | } | ||
596 | |||
597 | static size_t __logfs_write_je(struct super_block *sb, void *buf, u16 type, | ||
598 | size_t len) | ||
599 | { | ||
600 | struct logfs_super *super = logfs_super(sb); | ||
601 | void *header = super->s_compressed_je; | ||
602 | void *data = header + sizeof(struct logfs_journal_header); | ||
603 | ssize_t compr_len, pad_len; | ||
604 | u8 compr = COMPR_ZLIB; | ||
605 | |||
606 | if (len == 0) | ||
607 | return logfs_write_header(super, header, 0, type); | ||
608 | |||
609 | compr_len = logfs_compress(buf, data, len, sb->s_blocksize); | ||
610 | if (compr_len < 0 || type == JE_ANCHOR) { | ||
611 | BUG_ON(len > sb->s_blocksize); | ||
612 | memcpy(data, buf, len); | ||
613 | compr_len = len; | ||
614 | compr = COMPR_NONE; | ||
615 | } | ||
616 | |||
617 | pad_len = ALIGN(compr_len, 16); | ||
618 | memset(data + compr_len, 0, pad_len - compr_len); | ||
619 | |||
620 | return __logfs_write_header(super, header, compr_len, len, type, compr); | ||
621 | } | ||
622 | |||
623 | static s64 logfs_get_free_bytes(struct logfs_area *area, size_t *bytes, | ||
624 | int must_pad) | ||
625 | { | ||
626 | u32 writesize = logfs_super(area->a_sb)->s_writesize; | ||
627 | s32 ofs; | ||
628 | int ret; | ||
629 | |||
630 | ret = logfs_open_area(area, *bytes); | ||
631 | if (ret) | ||
632 | return -EAGAIN; | ||
633 | |||
634 | ofs = area->a_used_bytes; | ||
635 | area->a_used_bytes += *bytes; | ||
636 | |||
637 | if (must_pad) { | ||
638 | area->a_used_bytes = ALIGN(area->a_used_bytes, writesize); | ||
639 | *bytes = area->a_used_bytes - ofs; | ||
640 | } | ||
641 | |||
642 | return dev_ofs(area->a_sb, area->a_segno, ofs); | ||
643 | } | ||
644 | |||
645 | static int logfs_write_je_buf(struct super_block *sb, void *buf, u16 type, | ||
646 | size_t buf_len) | ||
647 | { | ||
648 | struct logfs_super *super = logfs_super(sb); | ||
649 | struct logfs_area *area = super->s_journal_area; | ||
650 | struct logfs_journal_header *jh = super->s_compressed_je; | ||
651 | size_t len; | ||
652 | int must_pad = 0; | ||
653 | s64 ofs; | ||
654 | |||
655 | len = __logfs_write_je(sb, buf, type, buf_len); | ||
656 | if (jh->h_type == cpu_to_be16(JE_COMMIT)) | ||
657 | must_pad = 1; | ||
658 | |||
659 | ofs = logfs_get_free_bytes(area, &len, must_pad); | ||
660 | if (ofs < 0) | ||
661 | return ofs; | ||
662 | logfs_buf_write(area, ofs, super->s_compressed_je, len); | ||
663 | super->s_je_array[super->s_no_je++] = cpu_to_be64(ofs); | ||
664 | return 0; | ||
665 | } | ||
666 | |||
667 | static int logfs_write_je(struct super_block *sb, | ||
668 | void* (*write)(struct super_block *sb, void *scratch, | ||
669 | u16 *type, size_t *len)) | ||
670 | { | ||
671 | void *buf; | ||
672 | size_t len; | ||
673 | u16 type; | ||
674 | |||
675 | buf = write(sb, logfs_super(sb)->s_je, &type, &len); | ||
676 | return logfs_write_je_buf(sb, buf, type, len); | ||
677 | } | ||
678 | |||
679 | int write_alias_journal(struct super_block *sb, u64 ino, u64 bix, | ||
680 | level_t level, int child_no, __be64 val) | ||
681 | { | ||
682 | struct logfs_super *super = logfs_super(sb); | ||
683 | struct logfs_obj_alias *oa = super->s_je; | ||
684 | int err = 0, fill = super->s_je_fill; | ||
685 | |||
686 | log_aliases("logfs_write_obj_aliases #%x(%llx, %llx, %x, %x) %llx\n", | ||
687 | fill, ino, bix, level, child_no, be64_to_cpu(val)); | ||
688 | oa[fill].ino = cpu_to_be64(ino); | ||
689 | oa[fill].bix = cpu_to_be64(bix); | ||
690 | oa[fill].val = val; | ||
691 | oa[fill].level = (__force u8)level; | ||
692 | oa[fill].child_no = cpu_to_be16(child_no); | ||
693 | fill++; | ||
694 | if (fill >= sb->s_blocksize / sizeof(*oa)) { | ||
695 | err = logfs_write_je_buf(sb, oa, JE_OBJ_ALIAS, sb->s_blocksize); | ||
696 | fill = 0; | ||
697 | } | ||
698 | |||
699 | super->s_je_fill = fill; | ||
700 | return err; | ||
701 | } | ||
702 | |||
703 | static int logfs_write_obj_aliases(struct super_block *sb) | ||
704 | { | ||
705 | struct logfs_super *super = logfs_super(sb); | ||
706 | int err; | ||
707 | |||
708 | log_journal("logfs_write_obj_aliases: %d aliases to write\n", | ||
709 | super->s_no_object_aliases); | ||
710 | super->s_je_fill = 0; | ||
711 | err = logfs_write_obj_aliases_pagecache(sb); | ||
712 | if (err) | ||
713 | return err; | ||
714 | |||
715 | if (super->s_je_fill) | ||
716 | err = logfs_write_je_buf(sb, super->s_je, JE_OBJ_ALIAS, | ||
717 | super->s_je_fill | ||
718 | * sizeof(struct logfs_obj_alias)); | ||
719 | return err; | ||
720 | } | ||
721 | |||
722 | /* | ||
723 | * Write all journal entries. The goto logic ensures that all journal entries | ||
724 | * are written whenever a new segment is used. It is ugly and potentially a | ||
725 | * bit wasteful, but robustness is more important. With this we can *always* | ||
726 | * erase all journal segments except the one containing the most recent commit. | ||
727 | */ | ||
728 | void logfs_write_anchor(struct super_block *sb) | ||
729 | { | ||
730 | struct logfs_super *super = logfs_super(sb); | ||
731 | struct logfs_area *area = super->s_journal_area; | ||
732 | int i, err; | ||
733 | |||
734 | if (!(super->s_flags & LOGFS_SB_FLAG_DIRTY)) | ||
735 | return; | ||
736 | super->s_flags &= ~LOGFS_SB_FLAG_DIRTY; | ||
737 | |||
738 | BUG_ON(super->s_flags & LOGFS_SB_FLAG_SHUTDOWN); | ||
739 | mutex_lock(&super->s_journal_mutex); | ||
740 | |||
741 | /* Do this first or suffer corruption */ | ||
742 | logfs_sync_segments(sb); | ||
743 | account_shadows(sb); | ||
744 | |||
745 | again: | ||
746 | super->s_no_je = 0; | ||
747 | for_each_area(i) { | ||
748 | if (!super->s_area[i]->a_is_open) | ||
749 | continue; | ||
750 | super->s_sum_index = i; | ||
751 | err = logfs_write_je(sb, logfs_write_area); | ||
752 | if (err) | ||
753 | goto again; | ||
754 | } | ||
755 | err = logfs_write_obj_aliases(sb); | ||
756 | if (err) | ||
757 | goto again; | ||
758 | err = logfs_write_je(sb, logfs_write_erasecount); | ||
759 | if (err) | ||
760 | goto again; | ||
761 | err = logfs_write_je(sb, __logfs_write_anchor); | ||
762 | if (err) | ||
763 | goto again; | ||
764 | err = logfs_write_je(sb, logfs_write_dynsb); | ||
765 | if (err) | ||
766 | goto again; | ||
767 | /* | ||
768 | * Order is imperative. First we sync all writes, including the | ||
769 | * non-committed journal writes. Then we write the final commit and | ||
770 | * sync the current journal segment. | ||
771 | * There is a theoretical bug here. Syncing the journal segment will | ||
772 | * write a number of journal entries and the final commit. All these | ||
773 | * are written in a single operation. If the device layer writes the | ||
774 | * data back-to-front, the commit will precede the other journal | ||
775 | * entries, leaving a race window. | ||
776 | * Two fixes are possible. Preferred is to fix the device layer to | ||
777 | * ensure writes happen front-to-back. Alternatively we can insert | ||
778 | * another logfs_sync_area() super->s_devops->sync() combo before | ||
779 | * writing the commit. | ||
780 | */ | ||
781 | /* | ||
782 | * On another subject, super->s_devops->sync is usually not necessary. | ||
783 | * Unless called from sys_sync or friends, a barrier would suffice. | ||
784 | */ | ||
785 | super->s_devops->sync(sb); | ||
786 | err = logfs_write_je(sb, logfs_write_commit); | ||
787 | if (err) | ||
788 | goto again; | ||
789 | log_journal("Write commit to %llx\n", | ||
790 | be64_to_cpu(super->s_je_array[super->s_no_je - 1])); | ||
791 | logfs_sync_area(area); | ||
792 | BUG_ON(area->a_used_bytes != area->a_written_bytes); | ||
793 | super->s_devops->sync(sb); | ||
794 | |||
795 | mutex_unlock(&super->s_journal_mutex); | ||
796 | return; | ||
797 | } | ||
798 | |||
799 | void do_logfs_journal_wl_pass(struct super_block *sb) | ||
800 | { | ||
801 | struct logfs_super *super = logfs_super(sb); | ||
802 | struct logfs_area *area = super->s_journal_area; | ||
803 | u32 segno, ec; | ||
804 | int i, err; | ||
805 | |||
806 | log_journal("Journal requires wear-leveling.\n"); | ||
807 | /* Drop old segments */ | ||
808 | journal_for_each(i) | ||
809 | if (super->s_journal_seg[i]) { | ||
810 | logfs_set_segment_unreserved(sb, | ||
811 | super->s_journal_seg[i], | ||
812 | super->s_journal_ec[i]); | ||
813 | super->s_journal_seg[i] = 0; | ||
814 | super->s_journal_ec[i] = 0; | ||
815 | } | ||
816 | /* Get new segments */ | ||
817 | for (i = 0; i < super->s_no_journal_segs; i++) { | ||
818 | segno = get_best_cand(sb, &super->s_reserve_list, &ec); | ||
819 | super->s_journal_seg[i] = segno; | ||
820 | super->s_journal_ec[i] = ec; | ||
821 | logfs_set_segment_reserved(sb, segno); | ||
822 | } | ||
823 | /* Manually move journal_area */ | ||
824 | area->a_segno = super->s_journal_seg[0]; | ||
825 | area->a_is_open = 0; | ||
826 | area->a_used_bytes = 0; | ||
827 | /* Write journal */ | ||
828 | logfs_write_anchor(sb); | ||
829 | /* Write superblocks */ | ||
830 | err = logfs_write_sb(sb); | ||
831 | BUG_ON(err); | ||
832 | } | ||
833 | |||
834 | static const struct logfs_area_ops journal_area_ops = { | ||
835 | .get_free_segment = journal_get_free_segment, | ||
836 | .get_erase_count = journal_get_erase_count, | ||
837 | .erase_segment = journal_erase_segment, | ||
838 | }; | ||
839 | |||
840 | int logfs_init_journal(struct super_block *sb) | ||
841 | { | ||
842 | struct logfs_super *super = logfs_super(sb); | ||
843 | size_t bufsize = max_t(size_t, sb->s_blocksize, super->s_writesize) | ||
844 | + MAX_JOURNAL_HEADER; | ||
845 | int ret = -ENOMEM; | ||
846 | |||
847 | mutex_init(&super->s_journal_mutex); | ||
848 | btree_init_mempool32(&super->s_reserved_segments, super->s_btree_pool); | ||
849 | |||
850 | super->s_je = kzalloc(bufsize, GFP_KERNEL); | ||
851 | if (!super->s_je) | ||
852 | return ret; | ||
853 | |||
854 | super->s_compressed_je = kzalloc(bufsize, GFP_KERNEL); | ||
855 | if (!super->s_compressed_je) | ||
856 | return ret; | ||
857 | |||
858 | super->s_master_inode = logfs_new_meta_inode(sb, LOGFS_INO_MASTER); | ||
859 | if (IS_ERR(super->s_master_inode)) | ||
860 | return PTR_ERR(super->s_master_inode); | ||
861 | |||
862 | ret = logfs_read_journal(sb); | ||
863 | if (ret) | ||
864 | return -EIO; | ||
865 | |||
866 | reserve_sb_and_journal(sb); | ||
867 | logfs_calc_free(sb); | ||
868 | |||
869 | super->s_journal_area->a_ops = &journal_area_ops; | ||
870 | return 0; | ||
871 | } | ||
872 | |||
873 | void logfs_cleanup_journal(struct super_block *sb) | ||
874 | { | ||
875 | struct logfs_super *super = logfs_super(sb); | ||
876 | |||
877 | btree_grim_visitor32(&super->s_reserved_segments, 0, NULL); | ||
878 | destroy_meta_inode(super->s_master_inode); | ||
879 | super->s_master_inode = NULL; | ||
880 | |||
881 | kfree(super->s_compressed_je); | ||
882 | kfree(super->s_je); | ||
883 | } | ||
diff --git a/fs/logfs/logfs.h b/fs/logfs/logfs.h new file mode 100644 index 000000000000..129779431373 --- /dev/null +++ b/fs/logfs/logfs.h | |||
@@ -0,0 +1,724 @@ | |||
1 | /* | ||
2 | * fs/logfs/logfs.h | ||
3 | * | ||
4 | * As should be obvious for Linux kernel code, license is GPLv2 | ||
5 | * | ||
6 | * Copyright (c) 2005-2008 Joern Engel <joern@logfs.org> | ||
7 | * | ||
8 | * Private header for logfs. | ||
9 | */ | ||
10 | #ifndef FS_LOGFS_LOGFS_H | ||
11 | #define FS_LOGFS_LOGFS_H | ||
12 | |||
13 | #undef __CHECK_ENDIAN__ | ||
14 | #define __CHECK_ENDIAN__ | ||
15 | |||
16 | #include <linux/btree.h> | ||
17 | #include <linux/crc32.h> | ||
18 | #include <linux/fs.h> | ||
19 | #include <linux/kernel.h> | ||
20 | #include <linux/mempool.h> | ||
21 | #include <linux/pagemap.h> | ||
22 | #include <linux/mtd/mtd.h> | ||
23 | #include "logfs_abi.h" | ||
24 | |||
25 | #define LOGFS_DEBUG_SUPER (0x0001) | ||
26 | #define LOGFS_DEBUG_SEGMENT (0x0002) | ||
27 | #define LOGFS_DEBUG_JOURNAL (0x0004) | ||
28 | #define LOGFS_DEBUG_DIR (0x0008) | ||
29 | #define LOGFS_DEBUG_FILE (0x0010) | ||
30 | #define LOGFS_DEBUG_INODE (0x0020) | ||
31 | #define LOGFS_DEBUG_READWRITE (0x0040) | ||
32 | #define LOGFS_DEBUG_GC (0x0080) | ||
33 | #define LOGFS_DEBUG_GC_NOISY (0x0100) | ||
34 | #define LOGFS_DEBUG_ALIASES (0x0200) | ||
35 | #define LOGFS_DEBUG_BLOCKMOVE (0x0400) | ||
36 | #define LOGFS_DEBUG_ALL (0xffffffff) | ||
37 | |||
38 | #define LOGFS_DEBUG (0x01) | ||
39 | /* | ||
40 | * To enable specific log messages, simply define LOGFS_DEBUG to match any | ||
41 | * or all of the above. | ||
42 | */ | ||
43 | #ifndef LOGFS_DEBUG | ||
44 | #define LOGFS_DEBUG (0) | ||
45 | #endif | ||
46 | |||
47 | #define log_cond(cond, fmt, arg...) do { \ | ||
48 | if (cond) \ | ||
49 | printk(KERN_DEBUG fmt, ##arg); \ | ||
50 | } while (0) | ||
51 | |||
52 | #define log_super(fmt, arg...) \ | ||
53 | log_cond(LOGFS_DEBUG & LOGFS_DEBUG_SUPER, fmt, ##arg) | ||
54 | #define log_segment(fmt, arg...) \ | ||
55 | log_cond(LOGFS_DEBUG & LOGFS_DEBUG_SEGMENT, fmt, ##arg) | ||
56 | #define log_journal(fmt, arg...) \ | ||
57 | log_cond(LOGFS_DEBUG & LOGFS_DEBUG_JOURNAL, fmt, ##arg) | ||
58 | #define log_dir(fmt, arg...) \ | ||
59 | log_cond(LOGFS_DEBUG & LOGFS_DEBUG_DIR, fmt, ##arg) | ||
60 | #define log_file(fmt, arg...) \ | ||
61 | log_cond(LOGFS_DEBUG & LOGFS_DEBUG_FILE, fmt, ##arg) | ||
62 | #define log_inode(fmt, arg...) \ | ||
63 | log_cond(LOGFS_DEBUG & LOGFS_DEBUG_INODE, fmt, ##arg) | ||
64 | #define log_readwrite(fmt, arg...) \ | ||
65 | log_cond(LOGFS_DEBUG & LOGFS_DEBUG_READWRITE, fmt, ##arg) | ||
66 | #define log_gc(fmt, arg...) \ | ||
67 | log_cond(LOGFS_DEBUG & LOGFS_DEBUG_GC, fmt, ##arg) | ||
68 | #define log_gc_noisy(fmt, arg...) \ | ||
69 | log_cond(LOGFS_DEBUG & LOGFS_DEBUG_GC_NOISY, fmt, ##arg) | ||
70 | #define log_aliases(fmt, arg...) \ | ||
71 | log_cond(LOGFS_DEBUG & LOGFS_DEBUG_ALIASES, fmt, ##arg) | ||
72 | #define log_blockmove(fmt, arg...) \ | ||
73 | log_cond(LOGFS_DEBUG & LOGFS_DEBUG_BLOCKMOVE, fmt, ##arg) | ||
74 | |||
75 | #define PG_pre_locked PG_owner_priv_1 | ||
76 | #define PagePreLocked(page) test_bit(PG_pre_locked, &(page)->flags) | ||
77 | #define SetPagePreLocked(page) set_bit(PG_pre_locked, &(page)->flags) | ||
78 | #define ClearPagePreLocked(page) clear_bit(PG_pre_locked, &(page)->flags) | ||
79 | |||
80 | /* FIXME: This should really be somewhere in the 64bit area. */ | ||
81 | #define LOGFS_LINK_MAX (1<<30) | ||
82 | |||
83 | /* Read-only filesystem */ | ||
84 | #define LOGFS_SB_FLAG_RO 0x0001 | ||
85 | #define LOGFS_SB_FLAG_DIRTY 0x0002 | ||
86 | #define LOGFS_SB_FLAG_OBJ_ALIAS 0x0004 | ||
87 | #define LOGFS_SB_FLAG_SHUTDOWN 0x0008 | ||
88 | |||
89 | /* Write Control Flags */ | ||
90 | #define WF_LOCK 0x01 /* take write lock */ | ||
91 | #define WF_WRITE 0x02 /* write block */ | ||
92 | #define WF_DELETE 0x04 /* delete old block */ | ||
93 | |||
94 | typedef u8 __bitwise level_t; | ||
95 | typedef u8 __bitwise gc_level_t; | ||
96 | |||
97 | #define LEVEL(level) ((__force level_t)(level)) | ||
98 | #define GC_LEVEL(gc_level) ((__force gc_level_t)(gc_level)) | ||
99 | |||
100 | #define SUBLEVEL(level) ( (void)((level) == LEVEL(1)), \ | ||
101 | (__force level_t)((__force u8)(level) - 1) ) | ||
102 | |||
103 | /** | ||
104 | * struct logfs_area - area management information | ||
105 | * | ||
106 | * @a_sb: the superblock this area belongs to | ||
107 | * @a_is_open: 1 if the area is currently open, else 0 | ||
108 | * @a_segno: segment number of area | ||
109 | * @a_written_bytes: number of bytes already written back | ||
110 | * @a_used_bytes: number of used bytes | ||
111 | * @a_ops: area operations (either journal or ostore) | ||
112 | * @a_erase_count: erase count | ||
113 | * @a_level: GC level | ||
114 | */ | ||
115 | struct logfs_area { /* a segment open for writing */ | ||
116 | struct super_block *a_sb; | ||
117 | int a_is_open; | ||
118 | u32 a_segno; | ||
119 | u32 a_written_bytes; | ||
120 | u32 a_used_bytes; | ||
121 | const struct logfs_area_ops *a_ops; | ||
122 | u32 a_erase_count; | ||
123 | gc_level_t a_level; | ||
124 | }; | ||
125 | |||
126 | /** | ||
127 | * struct logfs_area_ops - area operations | ||
128 | * | ||
129 | * @get_free_segment: fill area->ofs with the offset of a free segment | ||
130 | * @get_erase_count: fill area->erase_count (needs area->ofs) | ||
131 | * @erase_segment: erase and setup segment | ||
132 | */ | ||
133 | struct logfs_area_ops { | ||
134 | void (*get_free_segment)(struct logfs_area *area); | ||
135 | void (*get_erase_count)(struct logfs_area *area); | ||
136 | int (*erase_segment)(struct logfs_area *area); | ||
137 | }; | ||
138 | |||
139 | /** | ||
140 | * struct logfs_device_ops - device access operations | ||
141 | * | ||
142 | * @readpage: read one page (mm page) | ||
143 | * @writeseg: write one segment. may be a partial segment | ||
144 | * @erase: erase one segment | ||
145 | * @read: read from the device | ||
146 | * @erase: erase part of the device | ||
147 | */ | ||
148 | struct logfs_device_ops { | ||
149 | struct page *(*find_first_sb)(struct super_block *sb, u64 *ofs); | ||
150 | struct page *(*find_last_sb)(struct super_block *sb, u64 *ofs); | ||
151 | int (*write_sb)(struct super_block *sb, struct page *page); | ||
152 | int (*readpage)(void *_sb, struct page *page); | ||
153 | void (*writeseg)(struct super_block *sb, u64 ofs, size_t len); | ||
154 | int (*erase)(struct super_block *sb, loff_t ofs, size_t len, | ||
155 | int ensure_write); | ||
156 | void (*sync)(struct super_block *sb); | ||
157 | void (*put_device)(struct super_block *sb); | ||
158 | }; | ||
159 | |||
160 | /** | ||
161 | * struct candidate_list - list of similar candidates | ||
162 | */ | ||
163 | struct candidate_list { | ||
164 | struct rb_root rb_tree; | ||
165 | int count; | ||
166 | int maxcount; | ||
167 | int sort_by_ec; | ||
168 | }; | ||
169 | |||
170 | /** | ||
171 | * struct gc_candidate - "candidate" segment to be garbage collected next | ||
172 | * | ||
173 | * @list: list (either free of low) | ||
174 | * @segno: segment number | ||
175 | * @valid: number of valid bytes | ||
176 | * @erase_count: erase count of segment | ||
177 | * @dist: distance from tree root | ||
178 | * | ||
179 | * Candidates can be on two lists. The free list contains electees rather | ||
180 | * than candidates - segments that no longer contain any valid data. The | ||
181 | * low list contains candidates to be picked for GC. It should be kept | ||
182 | * short. It is not required to always pick a perfect candidate. In the | ||
183 | * worst case GC will have to move more data than absolutely necessary. | ||
184 | */ | ||
185 | struct gc_candidate { | ||
186 | struct rb_node rb_node; | ||
187 | struct candidate_list *list; | ||
188 | u32 segno; | ||
189 | u32 valid; | ||
190 | u32 erase_count; | ||
191 | u8 dist; | ||
192 | }; | ||
193 | |||
194 | /** | ||
195 | * struct logfs_journal_entry - temporary structure used during journal scan | ||
196 | * | ||
197 | * @used: | ||
198 | * @version: normalized version | ||
199 | * @len: length | ||
200 | * @offset: offset | ||
201 | */ | ||
202 | struct logfs_journal_entry { | ||
203 | int used; | ||
204 | s16 version; | ||
205 | u16 len; | ||
206 | u16 datalen; | ||
207 | u64 offset; | ||
208 | }; | ||
209 | |||
210 | enum transaction_state { | ||
211 | CREATE_1 = 1, | ||
212 | CREATE_2, | ||
213 | UNLINK_1, | ||
214 | UNLINK_2, | ||
215 | CROSS_RENAME_1, | ||
216 | CROSS_RENAME_2, | ||
217 | TARGET_RENAME_1, | ||
218 | TARGET_RENAME_2, | ||
219 | TARGET_RENAME_3 | ||
220 | }; | ||
221 | |||
222 | /** | ||
223 | * struct logfs_transaction - essential fields to support atomic dirops | ||
224 | * | ||
225 | * @ino: target inode | ||
226 | * @dir: inode of directory containing dentry | ||
227 | * @pos: pos of dentry in directory | ||
228 | */ | ||
229 | struct logfs_transaction { | ||
230 | enum transaction_state state; | ||
231 | u64 ino; | ||
232 | u64 dir; | ||
233 | u64 pos; | ||
234 | }; | ||
235 | |||
236 | /** | ||
237 | * struct logfs_shadow - old block in the shadow of a not-yet-committed new one | ||
238 | * @old_ofs: offset of old block on medium | ||
239 | * @new_ofs: offset of new block on medium | ||
240 | * @ino: inode number | ||
241 | * @bix: block index | ||
242 | * @old_len: size of old block, including header | ||
243 | * @new_len: size of new block, including header | ||
244 | * @level: block level | ||
245 | */ | ||
246 | struct logfs_shadow { | ||
247 | u64 old_ofs; | ||
248 | u64 new_ofs; | ||
249 | u64 ino; | ||
250 | u64 bix; | ||
251 | int old_len; | ||
252 | int new_len; | ||
253 | gc_level_t gc_level; | ||
254 | }; | ||
255 | |||
256 | /** | ||
257 | * struct shadow_tree | ||
258 | * @new: shadows where old_ofs==0, indexed by new_ofs | ||
259 | * @old: shadows where old_ofs!=0, indexed by old_ofs | ||
260 | */ | ||
261 | struct shadow_tree { | ||
262 | struct btree_head64 new; | ||
263 | struct btree_head64 old; | ||
264 | }; | ||
265 | |||
266 | struct object_alias_item { | ||
267 | struct list_head list; | ||
268 | __be64 val; | ||
269 | int child_no; | ||
270 | }; | ||
271 | |||
272 | /** | ||
273 | * struct logfs_block - contains any block state | ||
274 | * @type: indirect block or inode | ||
275 | * @full: number of fully populated children | ||
276 | * @partial: number of partially populated children | ||
277 | * | ||
278 | * Most blocks are directly represented by page cache pages. But when a block | ||
279 | * becomes dirty, is part of a transaction, contains aliases or is otherwise | ||
280 | * special, a struct logfs_block is allocated to track the additional state. | ||
281 | * Inodes are very similar to indirect blocks, so they can also get one of | ||
282 | * these structures added when appropriate. | ||
283 | */ | ||
284 | #define BLOCK_INDIRECT 1 /* Indirect block */ | ||
285 | #define BLOCK_INODE 2 /* Inode */ | ||
286 | struct logfs_block_ops; | ||
287 | struct logfs_block { | ||
288 | struct list_head alias_list; | ||
289 | struct list_head item_list; | ||
290 | struct super_block *sb; | ||
291 | u64 ino; | ||
292 | u64 bix; | ||
293 | level_t level; | ||
294 | struct page *page; | ||
295 | struct inode *inode; | ||
296 | struct logfs_transaction *ta; | ||
297 | unsigned long alias_map[LOGFS_BLOCK_FACTOR / BITS_PER_LONG]; | ||
298 | struct logfs_block_ops *ops; | ||
299 | int full; | ||
300 | int partial; | ||
301 | int reserved_bytes; | ||
302 | }; | ||
303 | |||
304 | typedef int write_alias_t(struct super_block *sb, u64 ino, u64 bix, | ||
305 | level_t level, int child_no, __be64 val); | ||
306 | struct logfs_block_ops { | ||
307 | void (*write_block)(struct logfs_block *block); | ||
308 | gc_level_t (*block_level)(struct logfs_block *block); | ||
309 | void (*free_block)(struct super_block *sb, struct logfs_block*block); | ||
310 | int (*write_alias)(struct super_block *sb, | ||
311 | struct logfs_block *block, | ||
312 | write_alias_t *write_one_alias); | ||
313 | }; | ||
314 | |||
315 | struct logfs_super { | ||
316 | struct mtd_info *s_mtd; /* underlying device */ | ||
317 | struct block_device *s_bdev; /* underlying device */ | ||
318 | const struct logfs_device_ops *s_devops;/* device access */ | ||
319 | struct inode *s_master_inode; /* inode file */ | ||
320 | struct inode *s_segfile_inode; /* segment file */ | ||
321 | struct inode *s_mapping_inode; /* device mapping */ | ||
322 | atomic_t s_pending_writes; /* outstanting bios */ | ||
323 | long s_flags; | ||
324 | mempool_t *s_btree_pool; /* for btree nodes */ | ||
325 | mempool_t *s_alias_pool; /* aliases in segment.c */ | ||
326 | u64 s_feature_incompat; | ||
327 | u64 s_feature_ro_compat; | ||
328 | u64 s_feature_compat; | ||
329 | u64 s_feature_flags; | ||
330 | u64 s_sb_ofs[2]; | ||
331 | struct page *s_erase_page; /* for dev_bdev.c */ | ||
332 | /* alias.c fields */ | ||
333 | struct btree_head32 s_segment_alias; /* remapped segments */ | ||
334 | int s_no_object_aliases; | ||
335 | struct list_head s_object_alias; /* remapped objects */ | ||
336 | struct btree_head128 s_object_alias_tree; /* remapped objects */ | ||
337 | struct mutex s_object_alias_mutex; | ||
338 | /* dir.c fields */ | ||
339 | struct mutex s_dirop_mutex; /* for creat/unlink/rename */ | ||
340 | u64 s_victim_ino; /* used for atomic dir-ops */ | ||
341 | u64 s_rename_dir; /* source directory ino */ | ||
342 | u64 s_rename_pos; /* position of source dd */ | ||
343 | /* gc.c fields */ | ||
344 | long s_segsize; /* size of a segment */ | ||
345 | int s_segshift; /* log2 of segment size */ | ||
346 | long s_segmask; /* 1 << s_segshift - 1 */ | ||
347 | long s_no_segs; /* segments on device */ | ||
348 | long s_no_journal_segs; /* segments used for journal */ | ||
349 | long s_no_blocks; /* blocks per segment */ | ||
350 | long s_writesize; /* minimum write size */ | ||
351 | int s_writeshift; /* log2 of write size */ | ||
352 | u64 s_size; /* filesystem size */ | ||
353 | struct logfs_area *s_area[LOGFS_NO_AREAS]; /* open segment array */ | ||
354 | u64 s_gec; /* global erase count */ | ||
355 | u64 s_wl_gec_ostore; /* time of last wl event */ | ||
356 | u64 s_wl_gec_journal; /* time of last wl event */ | ||
357 | u64 s_sweeper; /* current sweeper pos */ | ||
358 | u8 s_ifile_levels; /* max level of ifile */ | ||
359 | u8 s_iblock_levels; /* max level of regular files */ | ||
360 | u8 s_data_levels; /* # of segments to leaf block*/ | ||
361 | u8 s_total_levels; /* sum of above three */ | ||
362 | struct btree_head32 s_cand_tree; /* all candidates */ | ||
363 | struct candidate_list s_free_list; /* 100% free segments */ | ||
364 | struct candidate_list s_reserve_list; /* Bad segment reserve */ | ||
365 | struct candidate_list s_low_list[LOGFS_NO_AREAS];/* good candidates */ | ||
366 | struct candidate_list s_ec_list; /* wear level candidates */ | ||
367 | struct btree_head32 s_reserved_segments;/* sb, journal, bad, etc. */ | ||
368 | /* inode.c fields */ | ||
369 | u64 s_last_ino; /* highest ino used */ | ||
370 | long s_inos_till_wrap; | ||
371 | u32 s_generation; /* i_generation for new files */ | ||
372 | struct list_head s_freeing_list; /* inodes being freed */ | ||
373 | /* journal.c fields */ | ||
374 | struct mutex s_journal_mutex; | ||
375 | void *s_je; /* journal entry to compress */ | ||
376 | void *s_compressed_je; /* block to write to journal */ | ||
377 | u32 s_journal_seg[LOGFS_JOURNAL_SEGS]; /* journal segments */ | ||
378 | u32 s_journal_ec[LOGFS_JOURNAL_SEGS]; /* journal erasecounts */ | ||
379 | u64 s_last_version; | ||
380 | struct logfs_area *s_journal_area; /* open journal segment */ | ||
381 | __be64 s_je_array[64]; | ||
382 | int s_no_je; | ||
383 | |||
384 | int s_sum_index; /* for the 12 summaries */ | ||
385 | struct shadow_tree s_shadow_tree; | ||
386 | int s_je_fill; /* index of current je */ | ||
387 | /* readwrite.c fields */ | ||
388 | struct mutex s_write_mutex; | ||
389 | int s_lock_count; | ||
390 | mempool_t *s_block_pool; /* struct logfs_block pool */ | ||
391 | mempool_t *s_shadow_pool; /* struct logfs_shadow pool */ | ||
392 | /* | ||
393 | * Space accounting: | ||
394 | * - s_used_bytes specifies space used to store valid data objects. | ||
395 | * - s_dirty_used_bytes is space used to store non-committed data | ||
396 | * objects. Those objects have already been written themselves, | ||
397 | * but they don't become valid until all indirect blocks up to the | ||
398 | * journal have been written as well. | ||
399 | * - s_dirty_free_bytes is space used to store the old copy of a | ||
400 | * replaced object, as long as the replacement is non-committed. | ||
401 | * In other words, it is the amount of space freed when all dirty | ||
402 | * blocks are written back. | ||
403 | * - s_free_bytes is the amount of free space available for any | ||
404 | * purpose. | ||
405 | * - s_root_reserve is the amount of free space available only to | ||
406 | * the root user. Non-privileged users can no longer write once | ||
407 | * this watermark has been reached. | ||
408 | * - s_speed_reserve is space which remains unused to speed up | ||
409 | * garbage collection performance. | ||
410 | * - s_dirty_pages is the space reserved for currently dirty pages. | ||
411 | * It is a pessimistic estimate, so some/most will get freed on | ||
412 | * page writeback. | ||
413 | * | ||
414 | * s_used_bytes + s_free_bytes + s_speed_reserve = total usable size | ||
415 | */ | ||
416 | u64 s_free_bytes; | ||
417 | u64 s_used_bytes; | ||
418 | u64 s_dirty_free_bytes; | ||
419 | u64 s_dirty_used_bytes; | ||
420 | u64 s_root_reserve; | ||
421 | u64 s_speed_reserve; | ||
422 | u64 s_dirty_pages; | ||
423 | /* Bad block handling: | ||
424 | * - s_bad_seg_reserve is a number of segments usually kept | ||
425 | * free. When encountering bad blocks, the affected segment's data | ||
426 | * is _temporarily_ moved to a reserved segment. | ||
427 | * - s_bad_segments is the number of known bad segments. | ||
428 | */ | ||
429 | u32 s_bad_seg_reserve; | ||
430 | u32 s_bad_segments; | ||
431 | }; | ||
432 | |||
433 | /** | ||
434 | * struct logfs_inode - in-memory inode | ||
435 | * | ||
436 | * @vfs_inode: struct inode | ||
437 | * @li_data: data pointers | ||
438 | * @li_used_bytes: number of used bytes | ||
439 | * @li_freeing_list: used to track inodes currently being freed | ||
440 | * @li_flags: inode flags | ||
441 | * @li_refcount: number of internal (GC-induced) references | ||
442 | */ | ||
443 | struct logfs_inode { | ||
444 | struct inode vfs_inode; | ||
445 | u64 li_data[LOGFS_EMBEDDED_FIELDS]; | ||
446 | u64 li_used_bytes; | ||
447 | struct list_head li_freeing_list; | ||
448 | struct logfs_block *li_block; | ||
449 | u32 li_flags; | ||
450 | u8 li_height; | ||
451 | int li_refcount; | ||
452 | }; | ||
453 | |||
454 | #define journal_for_each(__i) for (__i = 0; __i < LOGFS_JOURNAL_SEGS; __i++) | ||
455 | #define for_each_area(__i) for (__i = 0; __i < LOGFS_NO_AREAS; __i++) | ||
456 | #define for_each_area_down(__i) for (__i = LOGFS_NO_AREAS - 1; __i >= 0; __i--) | ||
457 | |||
458 | /* compr.c */ | ||
459 | int logfs_compress(void *in, void *out, size_t inlen, size_t outlen); | ||
460 | int logfs_uncompress(void *in, void *out, size_t inlen, size_t outlen); | ||
461 | int __init logfs_compr_init(void); | ||
462 | void logfs_compr_exit(void); | ||
463 | |||
464 | /* dev_bdev.c */ | ||
465 | #ifdef CONFIG_BLOCK | ||
466 | int logfs_get_sb_bdev(struct file_system_type *type, int flags, | ||
467 | const char *devname, struct vfsmount *mnt); | ||
468 | #else | ||
469 | static inline int logfs_get_sb_bdev(struct file_system_type *type, int flags, | ||
470 | const char *devname, struct vfsmount *mnt) | ||
471 | { | ||
472 | return -ENODEV; | ||
473 | } | ||
474 | #endif | ||
475 | |||
476 | /* dev_mtd.c */ | ||
477 | #ifdef CONFIG_MTD | ||
478 | int logfs_get_sb_mtd(struct file_system_type *type, int flags, | ||
479 | int mtdnr, struct vfsmount *mnt); | ||
480 | #else | ||
481 | static inline int logfs_get_sb_mtd(struct file_system_type *type, int flags, | ||
482 | int mtdnr, struct vfsmount *mnt) | ||
483 | { | ||
484 | return -ENODEV; | ||
485 | } | ||
486 | #endif | ||
487 | |||
488 | /* dir.c */ | ||
489 | extern const struct inode_operations logfs_symlink_iops; | ||
490 | extern const struct inode_operations logfs_dir_iops; | ||
491 | extern const struct file_operations logfs_dir_fops; | ||
492 | int logfs_replay_journal(struct super_block *sb); | ||
493 | |||
494 | /* file.c */ | ||
495 | extern const struct inode_operations logfs_reg_iops; | ||
496 | extern const struct file_operations logfs_reg_fops; | ||
497 | extern const struct address_space_operations logfs_reg_aops; | ||
498 | int logfs_readpage(struct file *file, struct page *page); | ||
499 | int logfs_ioctl(struct inode *inode, struct file *file, unsigned int cmd, | ||
500 | unsigned long arg); | ||
501 | int logfs_fsync(struct file *file, struct dentry *dentry, int datasync); | ||
502 | |||
503 | /* gc.c */ | ||
504 | u32 get_best_cand(struct super_block *sb, struct candidate_list *list, u32 *ec); | ||
505 | void logfs_gc_pass(struct super_block *sb); | ||
506 | int logfs_check_areas(struct super_block *sb); | ||
507 | int logfs_init_gc(struct super_block *sb); | ||
508 | void logfs_cleanup_gc(struct super_block *sb); | ||
509 | |||
510 | /* inode.c */ | ||
511 | extern const struct super_operations logfs_super_operations; | ||
512 | struct inode *logfs_iget(struct super_block *sb, ino_t ino); | ||
513 | struct inode *logfs_safe_iget(struct super_block *sb, ino_t ino, int *cookie); | ||
514 | void logfs_safe_iput(struct inode *inode, int cookie); | ||
515 | struct inode *logfs_new_inode(struct inode *dir, int mode); | ||
516 | struct inode *logfs_new_meta_inode(struct super_block *sb, u64 ino); | ||
517 | struct inode *logfs_read_meta_inode(struct super_block *sb, u64 ino); | ||
518 | int logfs_init_inode_cache(void); | ||
519 | void logfs_destroy_inode_cache(void); | ||
520 | void destroy_meta_inode(struct inode *inode); | ||
521 | void logfs_set_blocks(struct inode *inode, u64 no); | ||
522 | /* these logically belong into inode.c but actually reside in readwrite.c */ | ||
523 | int logfs_read_inode(struct inode *inode); | ||
524 | int __logfs_write_inode(struct inode *inode, long flags); | ||
525 | void logfs_delete_inode(struct inode *inode); | ||
526 | void logfs_clear_inode(struct inode *inode); | ||
527 | |||
528 | /* journal.c */ | ||
529 | void logfs_write_anchor(struct super_block *sb); | ||
530 | int logfs_init_journal(struct super_block *sb); | ||
531 | void logfs_cleanup_journal(struct super_block *sb); | ||
532 | int write_alias_journal(struct super_block *sb, u64 ino, u64 bix, | ||
533 | level_t level, int child_no, __be64 val); | ||
534 | void do_logfs_journal_wl_pass(struct super_block *sb); | ||
535 | |||
536 | /* readwrite.c */ | ||
537 | pgoff_t logfs_pack_index(u64 bix, level_t level); | ||
538 | void logfs_unpack_index(pgoff_t index, u64 *bix, level_t *level); | ||
539 | int logfs_inode_write(struct inode *inode, const void *buf, size_t count, | ||
540 | loff_t bix, long flags, struct shadow_tree *shadow_tree); | ||
541 | int logfs_readpage_nolock(struct page *page); | ||
542 | int logfs_write_buf(struct inode *inode, struct page *page, long flags); | ||
543 | int logfs_delete(struct inode *inode, pgoff_t index, | ||
544 | struct shadow_tree *shadow_tree); | ||
545 | int logfs_rewrite_block(struct inode *inode, u64 bix, u64 ofs, | ||
546 | gc_level_t gc_level, long flags); | ||
547 | int logfs_is_valid_block(struct super_block *sb, u64 ofs, u64 ino, u64 bix, | ||
548 | gc_level_t gc_level); | ||
549 | int logfs_truncate(struct inode *inode, u64 size); | ||
550 | u64 logfs_seek_hole(struct inode *inode, u64 bix); | ||
551 | u64 logfs_seek_data(struct inode *inode, u64 bix); | ||
552 | int logfs_open_segfile(struct super_block *sb); | ||
553 | int logfs_init_rw(struct super_block *sb); | ||
554 | void logfs_cleanup_rw(struct super_block *sb); | ||
555 | void logfs_add_transaction(struct inode *inode, struct logfs_transaction *ta); | ||
556 | void logfs_del_transaction(struct inode *inode, struct logfs_transaction *ta); | ||
557 | void logfs_write_block(struct logfs_block *block, long flags); | ||
558 | int logfs_write_obj_aliases_pagecache(struct super_block *sb); | ||
559 | void logfs_get_segment_entry(struct super_block *sb, u32 segno, | ||
560 | struct logfs_segment_entry *se); | ||
561 | void logfs_set_segment_used(struct super_block *sb, u64 ofs, int increment); | ||
562 | void logfs_set_segment_erased(struct super_block *sb, u32 segno, u32 ec, | ||
563 | gc_level_t gc_level); | ||
564 | void logfs_set_segment_reserved(struct super_block *sb, u32 segno); | ||
565 | void logfs_set_segment_unreserved(struct super_block *sb, u32 segno, u32 ec); | ||
566 | struct logfs_block *__alloc_block(struct super_block *sb, | ||
567 | u64 ino, u64 bix, level_t level); | ||
568 | void __free_block(struct super_block *sb, struct logfs_block *block); | ||
569 | void btree_write_block(struct logfs_block *block); | ||
570 | void initialize_block_counters(struct page *page, struct logfs_block *block, | ||
571 | __be64 *array, int page_is_empty); | ||
572 | int logfs_exist_block(struct inode *inode, u64 bix); | ||
573 | int get_page_reserve(struct inode *inode, struct page *page); | ||
574 | extern struct logfs_block_ops indirect_block_ops; | ||
575 | |||
576 | /* segment.c */ | ||
577 | int logfs_erase_segment(struct super_block *sb, u32 ofs, int ensure_erase); | ||
578 | int wbuf_read(struct super_block *sb, u64 ofs, size_t len, void *buf); | ||
579 | int logfs_segment_read(struct inode *inode, struct page *page, u64 ofs, u64 bix, | ||
580 | level_t level); | ||
581 | int logfs_segment_write(struct inode *inode, struct page *page, | ||
582 | struct logfs_shadow *shadow); | ||
583 | int logfs_segment_delete(struct inode *inode, struct logfs_shadow *shadow); | ||
584 | int logfs_load_object_aliases(struct super_block *sb, | ||
585 | struct logfs_obj_alias *oa, int count); | ||
586 | void move_page_to_btree(struct page *page); | ||
587 | int logfs_init_mapping(struct super_block *sb); | ||
588 | void logfs_sync_area(struct logfs_area *area); | ||
589 | void logfs_sync_segments(struct super_block *sb); | ||
590 | |||
591 | /* area handling */ | ||
592 | int logfs_init_areas(struct super_block *sb); | ||
593 | void logfs_cleanup_areas(struct super_block *sb); | ||
594 | int logfs_open_area(struct logfs_area *area, size_t bytes); | ||
595 | void __logfs_buf_write(struct logfs_area *area, u64 ofs, void *buf, size_t len, | ||
596 | int use_filler); | ||
597 | |||
598 | static inline void logfs_buf_write(struct logfs_area *area, u64 ofs, | ||
599 | void *buf, size_t len) | ||
600 | { | ||
601 | __logfs_buf_write(area, ofs, buf, len, 0); | ||
602 | } | ||
603 | |||
604 | static inline void logfs_buf_recover(struct logfs_area *area, u64 ofs, | ||
605 | void *buf, size_t len) | ||
606 | { | ||
607 | __logfs_buf_write(area, ofs, buf, len, 1); | ||
608 | } | ||
609 | |||
610 | /* super.c */ | ||
611 | struct page *emergency_read_begin(struct address_space *mapping, pgoff_t index); | ||
612 | void emergency_read_end(struct page *page); | ||
613 | void logfs_crash_dump(struct super_block *sb); | ||
614 | void *memchr_inv(const void *s, int c, size_t n); | ||
615 | int logfs_statfs(struct dentry *dentry, struct kstatfs *stats); | ||
616 | int logfs_get_sb_device(struct file_system_type *type, int flags, | ||
617 | struct mtd_info *mtd, struct block_device *bdev, | ||
618 | const struct logfs_device_ops *devops, struct vfsmount *mnt); | ||
619 | int logfs_check_ds(struct logfs_disk_super *ds); | ||
620 | int logfs_write_sb(struct super_block *sb); | ||
621 | |||
622 | static inline struct logfs_super *logfs_super(struct super_block *sb) | ||
623 | { | ||
624 | return sb->s_fs_info; | ||
625 | } | ||
626 | |||
627 | static inline struct logfs_inode *logfs_inode(struct inode *inode) | ||
628 | { | ||
629 | return container_of(inode, struct logfs_inode, vfs_inode); | ||
630 | } | ||
631 | |||
632 | static inline void logfs_set_ro(struct super_block *sb) | ||
633 | { | ||
634 | logfs_super(sb)->s_flags |= LOGFS_SB_FLAG_RO; | ||
635 | } | ||
636 | |||
637 | #define LOGFS_BUG(sb) do { \ | ||
638 | struct super_block *__sb = sb; \ | ||
639 | logfs_crash_dump(__sb); \ | ||
640 | logfs_super(__sb)->s_flags |= LOGFS_SB_FLAG_RO; \ | ||
641 | BUG(); \ | ||
642 | } while (0) | ||
643 | |||
644 | #define LOGFS_BUG_ON(condition, sb) \ | ||
645 | do { if (unlikely(condition)) LOGFS_BUG((sb)); } while (0) | ||
646 | |||
647 | static inline __be32 logfs_crc32(void *data, size_t len, size_t skip) | ||
648 | { | ||
649 | return cpu_to_be32(crc32(~0, data+skip, len-skip)); | ||
650 | } | ||
651 | |||
652 | static inline u8 logfs_type(struct inode *inode) | ||
653 | { | ||
654 | return (inode->i_mode >> 12) & 15; | ||
655 | } | ||
656 | |||
657 | static inline pgoff_t logfs_index(struct super_block *sb, u64 pos) | ||
658 | { | ||
659 | return pos >> sb->s_blocksize_bits; | ||
660 | } | ||
661 | |||
662 | static inline u64 dev_ofs(struct super_block *sb, u32 segno, u32 ofs) | ||
663 | { | ||
664 | return ((u64)segno << logfs_super(sb)->s_segshift) + ofs; | ||
665 | } | ||
666 | |||
667 | static inline u32 seg_no(struct super_block *sb, u64 ofs) | ||
668 | { | ||
669 | return ofs >> logfs_super(sb)->s_segshift; | ||
670 | } | ||
671 | |||
672 | static inline u32 seg_ofs(struct super_block *sb, u64 ofs) | ||
673 | { | ||
674 | return ofs & logfs_super(sb)->s_segmask; | ||
675 | } | ||
676 | |||
677 | static inline u64 seg_align(struct super_block *sb, u64 ofs) | ||
678 | { | ||
679 | return ofs & ~logfs_super(sb)->s_segmask; | ||
680 | } | ||
681 | |||
682 | static inline struct logfs_block *logfs_block(struct page *page) | ||
683 | { | ||
684 | return (void *)page->private; | ||
685 | } | ||
686 | |||
687 | static inline level_t shrink_level(gc_level_t __level) | ||
688 | { | ||
689 | u8 level = (__force u8)__level; | ||
690 | |||
691 | if (level >= LOGFS_MAX_LEVELS) | ||
692 | level -= LOGFS_MAX_LEVELS; | ||
693 | return (__force level_t)level; | ||
694 | } | ||
695 | |||
696 | static inline gc_level_t expand_level(u64 ino, level_t __level) | ||
697 | { | ||
698 | u8 level = (__force u8)__level; | ||
699 | |||
700 | if (ino == LOGFS_INO_MASTER) { | ||
701 | /* ifile has seperate areas */ | ||
702 | level += LOGFS_MAX_LEVELS; | ||
703 | } | ||
704 | return (__force gc_level_t)level; | ||
705 | } | ||
706 | |||
707 | static inline int logfs_block_shift(struct super_block *sb, level_t level) | ||
708 | { | ||
709 | level = shrink_level((__force gc_level_t)level); | ||
710 | return (__force int)level * (sb->s_blocksize_bits - 3); | ||
711 | } | ||
712 | |||
713 | static inline u64 logfs_block_mask(struct super_block *sb, level_t level) | ||
714 | { | ||
715 | return ~0ull << logfs_block_shift(sb, level); | ||
716 | } | ||
717 | |||
718 | static inline struct logfs_area *get_area(struct super_block *sb, | ||
719 | gc_level_t gc_level) | ||
720 | { | ||
721 | return logfs_super(sb)->s_area[(__force u8)gc_level]; | ||
722 | } | ||
723 | |||
724 | #endif | ||
diff --git a/fs/logfs/logfs_abi.h b/fs/logfs/logfs_abi.h new file mode 100644 index 000000000000..f674725663fe --- /dev/null +++ b/fs/logfs/logfs_abi.h | |||
@@ -0,0 +1,629 @@ | |||
1 | /* | ||
2 | * fs/logfs/logfs_abi.h | ||
3 | * | ||
4 | * As should be obvious for Linux kernel code, license is GPLv2 | ||
5 | * | ||
6 | * Copyright (c) 2005-2008 Joern Engel <joern@logfs.org> | ||
7 | * | ||
8 | * Public header for logfs. | ||
9 | */ | ||
10 | #ifndef FS_LOGFS_LOGFS_ABI_H | ||
11 | #define FS_LOGFS_LOGFS_ABI_H | ||
12 | |||
13 | /* For out-of-kernel compiles */ | ||
14 | #ifndef BUILD_BUG_ON | ||
15 | #define BUILD_BUG_ON(condition) /**/ | ||
16 | #endif | ||
17 | |||
18 | #define SIZE_CHECK(type, size) \ | ||
19 | static inline void check_##type(void) \ | ||
20 | { \ | ||
21 | BUILD_BUG_ON(sizeof(struct type) != (size)); \ | ||
22 | } | ||
23 | |||
24 | /* | ||
25 | * Throughout the logfs code, we're constantly dealing with blocks at | ||
26 | * various positions or offsets. To remove confusion, we stricly | ||
27 | * distinguish between a "position" - the logical position within a | ||
28 | * file and an "offset" - the physical location within the device. | ||
29 | * | ||
30 | * Any usage of the term offset for a logical location or position for | ||
31 | * a physical one is a bug and should get fixed. | ||
32 | */ | ||
33 | |||
34 | /* | ||
35 | * Block are allocated in one of several segments depending on their | ||
36 | * level. The following levels are used: | ||
37 | * 0 - regular data block | ||
38 | * 1 - i1 indirect blocks | ||
39 | * 2 - i2 indirect blocks | ||
40 | * 3 - i3 indirect blocks | ||
41 | * 4 - i4 indirect blocks | ||
42 | * 5 - i5 indirect blocks | ||
43 | * 6 - ifile data blocks | ||
44 | * 7 - ifile i1 indirect blocks | ||
45 | * 8 - ifile i2 indirect blocks | ||
46 | * 9 - ifile i3 indirect blocks | ||
47 | * 10 - ifile i4 indirect blocks | ||
48 | * 11 - ifile i5 indirect blocks | ||
49 | * Potential levels to be used in the future: | ||
50 | * 12 - gc recycled blocks, long-lived data | ||
51 | * 13 - replacement blocks, short-lived data | ||
52 | * | ||
53 | * Levels 1-11 are necessary for robust gc operations and help seperate | ||
54 | * short-lived metadata from longer-lived file data. In the future, | ||
55 | * file data should get seperated into several segments based on simple | ||
56 | * heuristics. Old data recycled during gc operation is expected to be | ||
57 | * long-lived. New data is of uncertain life expectancy. New data | ||
58 | * used to replace older blocks in existing files is expected to be | ||
59 | * short-lived. | ||
60 | */ | ||
61 | |||
62 | |||
63 | /* Magic numbers. 64bit for superblock, 32bit for statfs f_type */ | ||
64 | #define LOGFS_MAGIC 0x7a3a8e5cb9d5bf67ull | ||
65 | #define LOGFS_MAGIC_U32 0xc97e8168u | ||
66 | |||
67 | /* | ||
68 | * Various blocksize related macros. Blocksize is currently fixed at 4KiB. | ||
69 | * Sooner or later that should become configurable and the macros replaced | ||
70 | * by something superblock-dependent. Pointers in indirect blocks are and | ||
71 | * will remain 64bit. | ||
72 | * | ||
73 | * LOGFS_BLOCKSIZE - self-explaining | ||
74 | * LOGFS_BLOCK_FACTOR - number of pointers per indirect block | ||
75 | * LOGFS_BLOCK_BITS - log2 of LOGFS_BLOCK_FACTOR, used for shifts | ||
76 | */ | ||
77 | #define LOGFS_BLOCKSIZE (4096ull) | ||
78 | #define LOGFS_BLOCK_FACTOR (LOGFS_BLOCKSIZE / sizeof(u64)) | ||
79 | #define LOGFS_BLOCK_BITS (9) | ||
80 | |||
81 | /* | ||
82 | * Number of blocks at various levels of indirection. There are 16 direct | ||
83 | * block pointers plus a single indirect pointer. | ||
84 | */ | ||
85 | #define I0_BLOCKS (16) | ||
86 | #define I1_BLOCKS LOGFS_BLOCK_FACTOR | ||
87 | #define I2_BLOCKS (LOGFS_BLOCK_FACTOR * I1_BLOCKS) | ||
88 | #define I3_BLOCKS (LOGFS_BLOCK_FACTOR * I2_BLOCKS) | ||
89 | #define I4_BLOCKS (LOGFS_BLOCK_FACTOR * I3_BLOCKS) | ||
90 | #define I5_BLOCKS (LOGFS_BLOCK_FACTOR * I4_BLOCKS) | ||
91 | |||
92 | #define INDIRECT_INDEX I0_BLOCKS | ||
93 | #define LOGFS_EMBEDDED_FIELDS (I0_BLOCKS + 1) | ||
94 | |||
95 | /* | ||
96 | * Sizes at which files require another level of indirection. Files smaller | ||
97 | * than LOGFS_EMBEDDED_SIZE can be completely stored in the inode itself, | ||
98 | * similar like ext2 fast symlinks. | ||
99 | * | ||
100 | * Data at a position smaller than LOGFS_I0_SIZE is accessed through the | ||
101 | * direct pointers, else through the 1x indirect pointer and so forth. | ||
102 | */ | ||
103 | #define LOGFS_EMBEDDED_SIZE (LOGFS_EMBEDDED_FIELDS * sizeof(u64)) | ||
104 | #define LOGFS_I0_SIZE (I0_BLOCKS * LOGFS_BLOCKSIZE) | ||
105 | #define LOGFS_I1_SIZE (I1_BLOCKS * LOGFS_BLOCKSIZE) | ||
106 | #define LOGFS_I2_SIZE (I2_BLOCKS * LOGFS_BLOCKSIZE) | ||
107 | #define LOGFS_I3_SIZE (I3_BLOCKS * LOGFS_BLOCKSIZE) | ||
108 | #define LOGFS_I4_SIZE (I4_BLOCKS * LOGFS_BLOCKSIZE) | ||
109 | #define LOGFS_I5_SIZE (I5_BLOCKS * LOGFS_BLOCKSIZE) | ||
110 | |||
111 | /* | ||
112 | * Each indirect block pointer must have this flag set, if all block pointers | ||
113 | * behind it are set, i.e. there is no hole hidden in the shadow of this | ||
114 | * indirect block pointer. | ||
115 | */ | ||
116 | #define LOGFS_FULLY_POPULATED (1ULL << 63) | ||
117 | #define pure_ofs(ofs) (ofs & ~LOGFS_FULLY_POPULATED) | ||
118 | |||
119 | /* | ||
120 | * LogFS needs to seperate data into levels. Each level is defined as the | ||
121 | * maximal possible distance from the master inode (inode of the inode file). | ||
122 | * Data blocks reside on level 0, 1x indirect block on level 1, etc. | ||
123 | * Inodes reside on level 6, indirect blocks for the inode file on levels 7-11. | ||
124 | * This effort is necessary to guarantee garbage collection to always make | ||
125 | * progress. | ||
126 | * | ||
127 | * LOGFS_MAX_INDIRECT is the maximal indirection through indirect blocks, | ||
128 | * LOGFS_MAX_LEVELS is one more for the actual data level of a file. It is | ||
129 | * the maximal number of levels for one file. | ||
130 | * LOGFS_NO_AREAS is twice that, as the inode file and regular files are | ||
131 | * effectively stacked on top of each other. | ||
132 | */ | ||
133 | #define LOGFS_MAX_INDIRECT (5) | ||
134 | #define LOGFS_MAX_LEVELS (LOGFS_MAX_INDIRECT + 1) | ||
135 | #define LOGFS_NO_AREAS (2 * LOGFS_MAX_LEVELS) | ||
136 | |||
137 | /* Maximum size of filenames */ | ||
138 | #define LOGFS_MAX_NAMELEN (255) | ||
139 | |||
140 | /* Number of segments in the primary journal. */ | ||
141 | #define LOGFS_JOURNAL_SEGS (16) | ||
142 | |||
143 | /* Maximum number of free/erased/etc. segments in journal entries */ | ||
144 | #define MAX_CACHED_SEGS (64) | ||
145 | |||
146 | |||
147 | /* | ||
148 | * LOGFS_OBJECT_HEADERSIZE is the size of a single header in the object store, | ||
149 | * LOGFS_MAX_OBJECTSIZE the size of the largest possible object, including | ||
150 | * its header, | ||
151 | * LOGFS_SEGMENT_RESERVE is the amount of space reserved for each segment for | ||
152 | * its segment header and the padded space at the end when no further objects | ||
153 | * fit. | ||
154 | */ | ||
155 | #define LOGFS_OBJECT_HEADERSIZE (0x1c) | ||
156 | #define LOGFS_SEGMENT_HEADERSIZE (0x18) | ||
157 | #define LOGFS_MAX_OBJECTSIZE (LOGFS_OBJECT_HEADERSIZE + LOGFS_BLOCKSIZE) | ||
158 | #define LOGFS_SEGMENT_RESERVE \ | ||
159 | (LOGFS_SEGMENT_HEADERSIZE + LOGFS_MAX_OBJECTSIZE - 1) | ||
160 | |||
161 | /* | ||
162 | * Segment types: | ||
163 | * SEG_SUPER - Data or indirect block | ||
164 | * SEG_JOURNAL - Inode | ||
165 | * SEG_OSTORE - Dentry | ||
166 | */ | ||
167 | enum { | ||
168 | SEG_SUPER = 0x01, | ||
169 | SEG_JOURNAL = 0x02, | ||
170 | SEG_OSTORE = 0x03, | ||
171 | }; | ||
172 | |||
173 | /** | ||
174 | * struct logfs_segment_header - per-segment header in the ostore | ||
175 | * | ||
176 | * @crc: crc32 of header (there is no data) | ||
177 | * @pad: unused, must be 0 | ||
178 | * @type: segment type, see above | ||
179 | * @level: GC level for all objects in this segment | ||
180 | * @segno: segment number | ||
181 | * @ec: erase count for this segment | ||
182 | * @gec: global erase count at time of writing | ||
183 | */ | ||
184 | struct logfs_segment_header { | ||
185 | __be32 crc; | ||
186 | __be16 pad; | ||
187 | __u8 type; | ||
188 | __u8 level; | ||
189 | __be32 segno; | ||
190 | __be32 ec; | ||
191 | __be64 gec; | ||
192 | }; | ||
193 | |||
194 | SIZE_CHECK(logfs_segment_header, LOGFS_SEGMENT_HEADERSIZE); | ||
195 | |||
196 | #define LOGFS_FEATURES_INCOMPAT (0ull) | ||
197 | #define LOGFS_FEATURES_RO_COMPAT (0ull) | ||
198 | #define LOGFS_FEATURES_COMPAT (0ull) | ||
199 | |||
200 | /** | ||
201 | * struct logfs_disk_super - on-medium superblock | ||
202 | * | ||
203 | * @ds_magic: magic number, must equal LOGFS_MAGIC | ||
204 | * @ds_crc: crc32 of structure starting with the next field | ||
205 | * @ds_ifile_levels: maximum number of levels for ifile | ||
206 | * @ds_iblock_levels: maximum number of levels for regular files | ||
207 | * @ds_data_levels: number of seperate levels for data | ||
208 | * @pad0: reserved, must be 0 | ||
209 | * @ds_feature_incompat: incompatible filesystem features | ||
210 | * @ds_feature_ro_compat: read-only compatible filesystem features | ||
211 | * @ds_feature_compat: compatible filesystem features | ||
212 | * @ds_flags: flags | ||
213 | * @ds_segment_shift: log2 of segment size | ||
214 | * @ds_block_shift: log2 of block size | ||
215 | * @ds_write_shift: log2 of write size | ||
216 | * @pad1: reserved, must be 0 | ||
217 | * @ds_journal_seg: segments used by primary journal | ||
218 | * @ds_root_reserve: bytes reserved for the superuser | ||
219 | * @ds_speed_reserve: bytes reserved to speed up GC | ||
220 | * @ds_bad_seg_reserve: number of segments reserved to handle bad blocks | ||
221 | * @pad2: reserved, must be 0 | ||
222 | * @pad3: reserved, must be 0 | ||
223 | * | ||
224 | * Contains only read-only fields. Read-write fields like the amount of used | ||
225 | * space is tracked in the dynamic superblock, which is stored in the journal. | ||
226 | */ | ||
227 | struct logfs_disk_super { | ||
228 | struct logfs_segment_header ds_sh; | ||
229 | __be64 ds_magic; | ||
230 | |||
231 | __be32 ds_crc; | ||
232 | __u8 ds_ifile_levels; | ||
233 | __u8 ds_iblock_levels; | ||
234 | __u8 ds_data_levels; | ||
235 | __u8 ds_segment_shift; | ||
236 | __u8 ds_block_shift; | ||
237 | __u8 ds_write_shift; | ||
238 | __u8 pad0[6]; | ||
239 | |||
240 | __be64 ds_filesystem_size; | ||
241 | __be32 ds_segment_size; | ||
242 | __be32 ds_bad_seg_reserve; | ||
243 | |||
244 | __be64 ds_feature_incompat; | ||
245 | __be64 ds_feature_ro_compat; | ||
246 | |||
247 | __be64 ds_feature_compat; | ||
248 | __be64 ds_feature_flags; | ||
249 | |||
250 | __be64 ds_root_reserve; | ||
251 | __be64 ds_speed_reserve; | ||
252 | |||
253 | __be32 ds_journal_seg[LOGFS_JOURNAL_SEGS]; | ||
254 | |||
255 | __be64 ds_super_ofs[2]; | ||
256 | __be64 pad3[8]; | ||
257 | }; | ||
258 | |||
259 | SIZE_CHECK(logfs_disk_super, 256); | ||
260 | |||
261 | /* | ||
262 | * Object types: | ||
263 | * OBJ_BLOCK - Data or indirect block | ||
264 | * OBJ_INODE - Inode | ||
265 | * OBJ_DENTRY - Dentry | ||
266 | */ | ||
267 | enum { | ||
268 | OBJ_BLOCK = 0x04, | ||
269 | OBJ_INODE = 0x05, | ||
270 | OBJ_DENTRY = 0x06, | ||
271 | }; | ||
272 | |||
273 | /** | ||
274 | * struct logfs_object_header - per-object header in the ostore | ||
275 | * | ||
276 | * @crc: crc32 of header, excluding data_crc | ||
277 | * @len: length of data | ||
278 | * @type: object type, see above | ||
279 | * @compr: compression type | ||
280 | * @ino: inode number | ||
281 | * @bix: block index | ||
282 | * @data_crc: crc32 of payload | ||
283 | */ | ||
284 | struct logfs_object_header { | ||
285 | __be32 crc; | ||
286 | __be16 len; | ||
287 | __u8 type; | ||
288 | __u8 compr; | ||
289 | __be64 ino; | ||
290 | __be64 bix; | ||
291 | __be32 data_crc; | ||
292 | } __attribute__((packed)); | ||
293 | |||
294 | SIZE_CHECK(logfs_object_header, LOGFS_OBJECT_HEADERSIZE); | ||
295 | |||
296 | /* | ||
297 | * Reserved inode numbers: | ||
298 | * LOGFS_INO_MASTER - master inode (for inode file) | ||
299 | * LOGFS_INO_ROOT - root directory | ||
300 | * LOGFS_INO_SEGFILE - per-segment used bytes and erase count | ||
301 | */ | ||
302 | enum { | ||
303 | LOGFS_INO_MAPPING = 0x00, | ||
304 | LOGFS_INO_MASTER = 0x01, | ||
305 | LOGFS_INO_ROOT = 0x02, | ||
306 | LOGFS_INO_SEGFILE = 0x03, | ||
307 | LOGFS_RESERVED_INOS = 0x10, | ||
308 | }; | ||
309 | |||
310 | /* | ||
311 | * Inode flags. High bits should never be written to the medium. They are | ||
312 | * reserved for in-memory usage. | ||
313 | * Low bits should either remain in sync with the corresponding FS_*_FL or | ||
314 | * reuse slots that obviously don't make sense for logfs. | ||
315 | * | ||
316 | * LOGFS_IF_DIRTY Inode must be written back | ||
317 | * LOGFS_IF_ZOMBIE Inode has been deleted | ||
318 | * LOGFS_IF_STILLBORN -ENOSPC happened when creating inode | ||
319 | */ | ||
320 | #define LOGFS_IF_COMPRESSED 0x00000004 /* == FS_COMPR_FL */ | ||
321 | #define LOGFS_IF_DIRTY 0x20000000 | ||
322 | #define LOGFS_IF_ZOMBIE 0x40000000 | ||
323 | #define LOGFS_IF_STILLBORN 0x80000000 | ||
324 | |||
325 | /* Flags available to chattr */ | ||
326 | #define LOGFS_FL_USER_VISIBLE (LOGFS_IF_COMPRESSED) | ||
327 | #define LOGFS_FL_USER_MODIFIABLE (LOGFS_IF_COMPRESSED) | ||
328 | /* Flags inherited from parent directory on file/directory creation */ | ||
329 | #define LOGFS_FL_INHERITED (LOGFS_IF_COMPRESSED) | ||
330 | |||
331 | /** | ||
332 | * struct logfs_disk_inode - on-medium inode | ||
333 | * | ||
334 | * @di_mode: file mode | ||
335 | * @di_pad: reserved, must be 0 | ||
336 | * @di_flags: inode flags, see above | ||
337 | * @di_uid: user id | ||
338 | * @di_gid: group id | ||
339 | * @di_ctime: change time | ||
340 | * @di_mtime: modify time | ||
341 | * @di_refcount: reference count (aka nlink or link count) | ||
342 | * @di_generation: inode generation, for nfs | ||
343 | * @di_used_bytes: number of bytes used | ||
344 | * @di_size: file size | ||
345 | * @di_data: data pointers | ||
346 | */ | ||
347 | struct logfs_disk_inode { | ||
348 | __be16 di_mode; | ||
349 | __u8 di_height; | ||
350 | __u8 di_pad; | ||
351 | __be32 di_flags; | ||
352 | __be32 di_uid; | ||
353 | __be32 di_gid; | ||
354 | |||
355 | __be64 di_ctime; | ||
356 | __be64 di_mtime; | ||
357 | |||
358 | __be64 di_atime; | ||
359 | __be32 di_refcount; | ||
360 | __be32 di_generation; | ||
361 | |||
362 | __be64 di_used_bytes; | ||
363 | __be64 di_size; | ||
364 | |||
365 | __be64 di_data[LOGFS_EMBEDDED_FIELDS]; | ||
366 | }; | ||
367 | |||
368 | SIZE_CHECK(logfs_disk_inode, 200); | ||
369 | |||
370 | #define INODE_POINTER_OFS \ | ||
371 | (offsetof(struct logfs_disk_inode, di_data) / sizeof(__be64)) | ||
372 | #define INODE_USED_OFS \ | ||
373 | (offsetof(struct logfs_disk_inode, di_used_bytes) / sizeof(__be64)) | ||
374 | #define INODE_SIZE_OFS \ | ||
375 | (offsetof(struct logfs_disk_inode, di_size) / sizeof(__be64)) | ||
376 | #define INODE_HEIGHT_OFS (0) | ||
377 | |||
378 | /** | ||
379 | * struct logfs_disk_dentry - on-medium dentry structure | ||
380 | * | ||
381 | * @ino: inode number | ||
382 | * @namelen: length of file name | ||
383 | * @type: file type, identical to bits 12..15 of mode | ||
384 | * @name: file name | ||
385 | */ | ||
386 | /* FIXME: add 6 bytes of padding to remove the __packed */ | ||
387 | struct logfs_disk_dentry { | ||
388 | __be64 ino; | ||
389 | __be16 namelen; | ||
390 | __u8 type; | ||
391 | __u8 name[LOGFS_MAX_NAMELEN]; | ||
392 | } __attribute__((packed)); | ||
393 | |||
394 | SIZE_CHECK(logfs_disk_dentry, 266); | ||
395 | |||
396 | #define RESERVED 0xffffffff | ||
397 | #define BADSEG 0xffffffff | ||
398 | /** | ||
399 | * struct logfs_segment_entry - segment file entry | ||
400 | * | ||
401 | * @ec_level: erase count and level | ||
402 | * @valid: number of valid bytes | ||
403 | * | ||
404 | * Segment file contains one entry for every segment. ec_level contains the | ||
405 | * erasecount in the upper 28 bits and the level in the lower 4 bits. An | ||
406 | * ec_level of BADSEG (-1) identifies bad segments. valid contains the number | ||
407 | * of valid bytes or RESERVED (-1 again) if the segment is used for either the | ||
408 | * superblock or the journal, or when the segment is bad. | ||
409 | */ | ||
410 | struct logfs_segment_entry { | ||
411 | __be32 ec_level; | ||
412 | __be32 valid; | ||
413 | }; | ||
414 | |||
415 | SIZE_CHECK(logfs_segment_entry, 8); | ||
416 | |||
417 | /** | ||
418 | * struct logfs_journal_header - header for journal entries (JEs) | ||
419 | * | ||
420 | * @h_crc: crc32 of journal entry | ||
421 | * @h_len: length of compressed journal entry, | ||
422 | * not including header | ||
423 | * @h_datalen: length of uncompressed data | ||
424 | * @h_type: JE type | ||
425 | * @h_compr: compression type | ||
426 | * @h_pad: reserved | ||
427 | */ | ||
428 | struct logfs_journal_header { | ||
429 | __be32 h_crc; | ||
430 | __be16 h_len; | ||
431 | __be16 h_datalen; | ||
432 | __be16 h_type; | ||
433 | __u8 h_compr; | ||
434 | __u8 h_pad[5]; | ||
435 | }; | ||
436 | |||
437 | SIZE_CHECK(logfs_journal_header, 16); | ||
438 | |||
439 | /* | ||
440 | * Life expectency of data. | ||
441 | * VIM_DEFAULT - default vim | ||
442 | * VIM_SEGFILE - for segment file only - very short-living | ||
443 | * VIM_GC - GC'd data - likely long-living | ||
444 | */ | ||
445 | enum logfs_vim { | ||
446 | VIM_DEFAULT = 0, | ||
447 | VIM_SEGFILE = 1, | ||
448 | }; | ||
449 | |||
450 | /** | ||
451 | * struct logfs_je_area - wbuf header | ||
452 | * | ||
453 | * @segno: segment number of area | ||
454 | * @used_bytes: number of bytes already used | ||
455 | * @gc_level: GC level | ||
456 | * @vim: life expectancy of data | ||
457 | * | ||
458 | * "Areas" are segments currently being used for writing. There is at least | ||
459 | * one area per GC level. Several may be used to seperate long-living from | ||
460 | * short-living data. If an area with unknown vim is encountered, it can | ||
461 | * simply be closed. | ||
462 | * The write buffer immediately follow this header. | ||
463 | */ | ||
464 | struct logfs_je_area { | ||
465 | __be32 segno; | ||
466 | __be32 used_bytes; | ||
467 | __u8 gc_level; | ||
468 | __u8 vim; | ||
469 | } __attribute__((packed)); | ||
470 | |||
471 | SIZE_CHECK(logfs_je_area, 10); | ||
472 | |||
473 | #define MAX_JOURNAL_HEADER \ | ||
474 | (sizeof(struct logfs_journal_header) + sizeof(struct logfs_je_area)) | ||
475 | |||
476 | /** | ||
477 | * struct logfs_je_dynsb - dynamic superblock | ||
478 | * | ||
479 | * @ds_gec: global erase count | ||
480 | * @ds_sweeper: current position of GC "sweeper" | ||
481 | * @ds_rename_dir: source directory ino (see dir.c documentation) | ||
482 | * @ds_rename_pos: position of source dd (see dir.c documentation) | ||
483 | * @ds_victim_ino: victims of incomplete dir operation (see dir.c) | ||
484 | * @ds_victim_ino: parent inode of victim (see dir.c) | ||
485 | * @ds_used_bytes: number of used bytes | ||
486 | */ | ||
487 | struct logfs_je_dynsb { | ||
488 | __be64 ds_gec; | ||
489 | __be64 ds_sweeper; | ||
490 | |||
491 | __be64 ds_rename_dir; | ||
492 | __be64 ds_rename_pos; | ||
493 | |||
494 | __be64 ds_victim_ino; | ||
495 | __be64 ds_victim_parent; /* XXX */ | ||
496 | |||
497 | __be64 ds_used_bytes; | ||
498 | __be32 ds_generation; | ||
499 | __be32 pad; | ||
500 | }; | ||
501 | |||
502 | SIZE_CHECK(logfs_je_dynsb, 64); | ||
503 | |||
504 | /** | ||
505 | * struct logfs_je_anchor - anchor of filesystem tree, aka master inode | ||
506 | * | ||
507 | * @da_size: size of inode file | ||
508 | * @da_last_ino: last created inode | ||
509 | * @da_used_bytes: number of bytes used | ||
510 | * @da_data: data pointers | ||
511 | */ | ||
512 | struct logfs_je_anchor { | ||
513 | __be64 da_size; | ||
514 | __be64 da_last_ino; | ||
515 | |||
516 | __be64 da_used_bytes; | ||
517 | u8 da_height; | ||
518 | u8 pad[7]; | ||
519 | |||
520 | __be64 da_data[LOGFS_EMBEDDED_FIELDS]; | ||
521 | }; | ||
522 | |||
523 | SIZE_CHECK(logfs_je_anchor, 168); | ||
524 | |||
525 | /** | ||
526 | * struct logfs_je_spillout - spillout entry (from 1st to 2nd journal) | ||
527 | * | ||
528 | * @so_segment: segments used for 2nd journal | ||
529 | * | ||
530 | * Length of the array is given by h_len field in the header. | ||
531 | */ | ||
532 | struct logfs_je_spillout { | ||
533 | __be64 so_segment[0]; | ||
534 | }; | ||
535 | |||
536 | SIZE_CHECK(logfs_je_spillout, 0); | ||
537 | |||
538 | /** | ||
539 | * struct logfs_je_journal_ec - erase counts for all journal segments | ||
540 | * | ||
541 | * @ec: erase count | ||
542 | * | ||
543 | * Length of the array is given by h_len field in the header. | ||
544 | */ | ||
545 | struct logfs_je_journal_ec { | ||
546 | __be32 ec[0]; | ||
547 | }; | ||
548 | |||
549 | SIZE_CHECK(logfs_je_journal_ec, 0); | ||
550 | |||
551 | /** | ||
552 | * struct logfs_je_free_segments - list of free segmetns with erase count | ||
553 | */ | ||
554 | struct logfs_je_free_segments { | ||
555 | __be32 segno; | ||
556 | __be32 ec; | ||
557 | }; | ||
558 | |||
559 | SIZE_CHECK(logfs_je_free_segments, 8); | ||
560 | |||
561 | /** | ||
562 | * struct logfs_seg_alias - list of segment aliases | ||
563 | */ | ||
564 | struct logfs_seg_alias { | ||
565 | __be32 old_segno; | ||
566 | __be32 new_segno; | ||
567 | }; | ||
568 | |||
569 | SIZE_CHECK(logfs_seg_alias, 8); | ||
570 | |||
571 | /** | ||
572 | * struct logfs_obj_alias - list of object aliases | ||
573 | */ | ||
574 | struct logfs_obj_alias { | ||
575 | __be64 ino; | ||
576 | __be64 bix; | ||
577 | __be64 val; | ||
578 | u8 level; | ||
579 | u8 pad[5]; | ||
580 | __be16 child_no; | ||
581 | }; | ||
582 | |||
583 | SIZE_CHECK(logfs_obj_alias, 32); | ||
584 | |||
585 | /** | ||
586 | * Compression types. | ||
587 | * | ||
588 | * COMPR_NONE - uncompressed | ||
589 | * COMPR_ZLIB - compressed with zlib | ||
590 | */ | ||
591 | enum { | ||
592 | COMPR_NONE = 0, | ||
593 | COMPR_ZLIB = 1, | ||
594 | }; | ||
595 | |||
596 | /* | ||
597 | * Journal entries come in groups of 16. First group contains unique | ||
598 | * entries, next groups contain one entry per level | ||
599 | * | ||
600 | * JE_FIRST - smallest possible journal entry number | ||
601 | * | ||
602 | * JEG_BASE - base group, containing unique entries | ||
603 | * JE_COMMIT - commit entry, validates all previous entries | ||
604 | * JE_DYNSB - dynamic superblock, anything that ought to be in the | ||
605 | * superblock but cannot because it is read-write data | ||
606 | * JE_ANCHOR - anchor aka master inode aka inode file's inode | ||
607 | * JE_ERASECOUNT erasecounts for all journal segments | ||
608 | * JE_SPILLOUT - unused | ||
609 | * JE_SEG_ALIAS - aliases segments | ||
610 | * JE_AREA - area description | ||
611 | * | ||
612 | * JE_LAST - largest possible journal entry number | ||
613 | */ | ||
614 | enum { | ||
615 | JE_FIRST = 0x01, | ||
616 | |||
617 | JEG_BASE = 0x00, | ||
618 | JE_COMMIT = 0x02, | ||
619 | JE_DYNSB = 0x03, | ||
620 | JE_ANCHOR = 0x04, | ||
621 | JE_ERASECOUNT = 0x05, | ||
622 | JE_SPILLOUT = 0x06, | ||
623 | JE_OBJ_ALIAS = 0x0d, | ||
624 | JE_AREA = 0x0e, | ||
625 | |||
626 | JE_LAST = 0x0e, | ||
627 | }; | ||
628 | |||
629 | #endif | ||
diff --git a/fs/logfs/readwrite.c b/fs/logfs/readwrite.c new file mode 100644 index 000000000000..7a23b3e7c0a7 --- /dev/null +++ b/fs/logfs/readwrite.c | |||
@@ -0,0 +1,2246 @@ | |||
1 | /* | ||
2 | * fs/logfs/readwrite.c | ||
3 | * | ||
4 | * As should be obvious for Linux kernel code, license is GPLv2 | ||
5 | * | ||
6 | * Copyright (c) 2005-2008 Joern Engel <joern@logfs.org> | ||
7 | * | ||
8 | * | ||
9 | * Actually contains five sets of very similar functions: | ||
10 | * read read blocks from a file | ||
11 | * seek_hole find next hole | ||
12 | * seek_data find next data block | ||
13 | * valid check whether a block still belongs to a file | ||
14 | * write write blocks to a file | ||
15 | * delete delete a block (for directories and ifile) | ||
16 | * rewrite move existing blocks of a file to a new location (gc helper) | ||
17 | * truncate truncate a file | ||
18 | */ | ||
19 | #include "logfs.h" | ||
20 | #include <linux/sched.h> | ||
21 | |||
22 | static u64 adjust_bix(u64 bix, level_t level) | ||
23 | { | ||
24 | switch (level) { | ||
25 | case 0: | ||
26 | return bix; | ||
27 | case LEVEL(1): | ||
28 | return max_t(u64, bix, I0_BLOCKS); | ||
29 | case LEVEL(2): | ||
30 | return max_t(u64, bix, I1_BLOCKS); | ||
31 | case LEVEL(3): | ||
32 | return max_t(u64, bix, I2_BLOCKS); | ||
33 | case LEVEL(4): | ||
34 | return max_t(u64, bix, I3_BLOCKS); | ||
35 | case LEVEL(5): | ||
36 | return max_t(u64, bix, I4_BLOCKS); | ||
37 | default: | ||
38 | WARN_ON(1); | ||
39 | return bix; | ||
40 | } | ||
41 | } | ||
42 | |||
43 | static inline u64 maxbix(u8 height) | ||
44 | { | ||
45 | return 1ULL << (LOGFS_BLOCK_BITS * height); | ||
46 | } | ||
47 | |||
48 | /** | ||
49 | * The inode address space is cut in two halves. Lower half belongs to data | ||
50 | * pages, upper half to indirect blocks. If the high bit (INDIRECT_BIT) is | ||
51 | * set, the actual block index (bix) and level can be derived from the page | ||
52 | * index. | ||
53 | * | ||
54 | * The lowest three bits of the block index are set to 0 after packing and | ||
55 | * unpacking. Since the lowest n bits (9 for 4KiB blocksize) are ignored | ||
56 | * anyway this is harmless. | ||
57 | */ | ||
58 | #define ARCH_SHIFT (BITS_PER_LONG - 32) | ||
59 | #define INDIRECT_BIT (0x80000000UL << ARCH_SHIFT) | ||
60 | #define LEVEL_SHIFT (28 + ARCH_SHIFT) | ||
61 | static inline pgoff_t first_indirect_block(void) | ||
62 | { | ||
63 | return INDIRECT_BIT | (1ULL << LEVEL_SHIFT); | ||
64 | } | ||
65 | |||
66 | pgoff_t logfs_pack_index(u64 bix, level_t level) | ||
67 | { | ||
68 | pgoff_t index; | ||
69 | |||
70 | BUG_ON(bix >= INDIRECT_BIT); | ||
71 | if (level == 0) | ||
72 | return bix; | ||
73 | |||
74 | index = INDIRECT_BIT; | ||
75 | index |= (__force long)level << LEVEL_SHIFT; | ||
76 | index |= bix >> ((__force u8)level * LOGFS_BLOCK_BITS); | ||
77 | return index; | ||
78 | } | ||
79 | |||
80 | void logfs_unpack_index(pgoff_t index, u64 *bix, level_t *level) | ||
81 | { | ||
82 | u8 __level; | ||
83 | |||
84 | if (!(index & INDIRECT_BIT)) { | ||
85 | *bix = index; | ||
86 | *level = 0; | ||
87 | return; | ||
88 | } | ||
89 | |||
90 | __level = (index & ~INDIRECT_BIT) >> LEVEL_SHIFT; | ||
91 | *level = LEVEL(__level); | ||
92 | *bix = (index << (__level * LOGFS_BLOCK_BITS)) & ~INDIRECT_BIT; | ||
93 | *bix = adjust_bix(*bix, *level); | ||
94 | return; | ||
95 | } | ||
96 | #undef ARCH_SHIFT | ||
97 | #undef INDIRECT_BIT | ||
98 | #undef LEVEL_SHIFT | ||
99 | |||
100 | /* | ||
101 | * Time is stored as nanoseconds since the epoch. | ||
102 | */ | ||
103 | static struct timespec be64_to_timespec(__be64 betime) | ||
104 | { | ||
105 | return ns_to_timespec(be64_to_cpu(betime)); | ||
106 | } | ||
107 | |||
108 | static __be64 timespec_to_be64(struct timespec tsp) | ||
109 | { | ||
110 | return cpu_to_be64((u64)tsp.tv_sec * NSEC_PER_SEC + tsp.tv_nsec); | ||
111 | } | ||
112 | |||
113 | static void logfs_disk_to_inode(struct logfs_disk_inode *di, struct inode*inode) | ||
114 | { | ||
115 | struct logfs_inode *li = logfs_inode(inode); | ||
116 | int i; | ||
117 | |||
118 | inode->i_mode = be16_to_cpu(di->di_mode); | ||
119 | li->li_height = di->di_height; | ||
120 | li->li_flags = be32_to_cpu(di->di_flags); | ||
121 | inode->i_uid = be32_to_cpu(di->di_uid); | ||
122 | inode->i_gid = be32_to_cpu(di->di_gid); | ||
123 | inode->i_size = be64_to_cpu(di->di_size); | ||
124 | logfs_set_blocks(inode, be64_to_cpu(di->di_used_bytes)); | ||
125 | inode->i_atime = be64_to_timespec(di->di_atime); | ||
126 | inode->i_ctime = be64_to_timespec(di->di_ctime); | ||
127 | inode->i_mtime = be64_to_timespec(di->di_mtime); | ||
128 | inode->i_nlink = be32_to_cpu(di->di_refcount); | ||
129 | inode->i_generation = be32_to_cpu(di->di_generation); | ||
130 | |||
131 | switch (inode->i_mode & S_IFMT) { | ||
132 | case S_IFSOCK: /* fall through */ | ||
133 | case S_IFBLK: /* fall through */ | ||
134 | case S_IFCHR: /* fall through */ | ||
135 | case S_IFIFO: | ||
136 | inode->i_rdev = be64_to_cpu(di->di_data[0]); | ||
137 | break; | ||
138 | case S_IFDIR: /* fall through */ | ||
139 | case S_IFREG: /* fall through */ | ||
140 | case S_IFLNK: | ||
141 | for (i = 0; i < LOGFS_EMBEDDED_FIELDS; i++) | ||
142 | li->li_data[i] = be64_to_cpu(di->di_data[i]); | ||
143 | break; | ||
144 | default: | ||
145 | BUG(); | ||
146 | } | ||
147 | } | ||
148 | |||
149 | static void logfs_inode_to_disk(struct inode *inode, struct logfs_disk_inode*di) | ||
150 | { | ||
151 | struct logfs_inode *li = logfs_inode(inode); | ||
152 | int i; | ||
153 | |||
154 | di->di_mode = cpu_to_be16(inode->i_mode); | ||
155 | di->di_height = li->li_height; | ||
156 | di->di_pad = 0; | ||
157 | di->di_flags = cpu_to_be32(li->li_flags); | ||
158 | di->di_uid = cpu_to_be32(inode->i_uid); | ||
159 | di->di_gid = cpu_to_be32(inode->i_gid); | ||
160 | di->di_size = cpu_to_be64(i_size_read(inode)); | ||
161 | di->di_used_bytes = cpu_to_be64(li->li_used_bytes); | ||
162 | di->di_atime = timespec_to_be64(inode->i_atime); | ||
163 | di->di_ctime = timespec_to_be64(inode->i_ctime); | ||
164 | di->di_mtime = timespec_to_be64(inode->i_mtime); | ||
165 | di->di_refcount = cpu_to_be32(inode->i_nlink); | ||
166 | di->di_generation = cpu_to_be32(inode->i_generation); | ||
167 | |||
168 | switch (inode->i_mode & S_IFMT) { | ||
169 | case S_IFSOCK: /* fall through */ | ||
170 | case S_IFBLK: /* fall through */ | ||
171 | case S_IFCHR: /* fall through */ | ||
172 | case S_IFIFO: | ||
173 | di->di_data[0] = cpu_to_be64(inode->i_rdev); | ||
174 | break; | ||
175 | case S_IFDIR: /* fall through */ | ||
176 | case S_IFREG: /* fall through */ | ||
177 | case S_IFLNK: | ||
178 | for (i = 0; i < LOGFS_EMBEDDED_FIELDS; i++) | ||
179 | di->di_data[i] = cpu_to_be64(li->li_data[i]); | ||
180 | break; | ||
181 | default: | ||
182 | BUG(); | ||
183 | } | ||
184 | } | ||
185 | |||
186 | static void __logfs_set_blocks(struct inode *inode) | ||
187 | { | ||
188 | struct super_block *sb = inode->i_sb; | ||
189 | struct logfs_inode *li = logfs_inode(inode); | ||
190 | |||
191 | inode->i_blocks = ULONG_MAX; | ||
192 | if (li->li_used_bytes >> sb->s_blocksize_bits < ULONG_MAX) | ||
193 | inode->i_blocks = ALIGN(li->li_used_bytes, 512) >> 9; | ||
194 | } | ||
195 | |||
196 | void logfs_set_blocks(struct inode *inode, u64 bytes) | ||
197 | { | ||
198 | struct logfs_inode *li = logfs_inode(inode); | ||
199 | |||
200 | li->li_used_bytes = bytes; | ||
201 | __logfs_set_blocks(inode); | ||
202 | } | ||
203 | |||
204 | static void prelock_page(struct super_block *sb, struct page *page, int lock) | ||
205 | { | ||
206 | struct logfs_super *super = logfs_super(sb); | ||
207 | |||
208 | BUG_ON(!PageLocked(page)); | ||
209 | if (lock) { | ||
210 | BUG_ON(PagePreLocked(page)); | ||
211 | SetPagePreLocked(page); | ||
212 | } else { | ||
213 | /* We are in GC path. */ | ||
214 | if (PagePreLocked(page)) | ||
215 | super->s_lock_count++; | ||
216 | else | ||
217 | SetPagePreLocked(page); | ||
218 | } | ||
219 | } | ||
220 | |||
221 | static void preunlock_page(struct super_block *sb, struct page *page, int lock) | ||
222 | { | ||
223 | struct logfs_super *super = logfs_super(sb); | ||
224 | |||
225 | BUG_ON(!PageLocked(page)); | ||
226 | if (lock) | ||
227 | ClearPagePreLocked(page); | ||
228 | else { | ||
229 | /* We are in GC path. */ | ||
230 | BUG_ON(!PagePreLocked(page)); | ||
231 | if (super->s_lock_count) | ||
232 | super->s_lock_count--; | ||
233 | else | ||
234 | ClearPagePreLocked(page); | ||
235 | } | ||
236 | } | ||
237 | |||
238 | /* | ||
239 | * Logfs is prone to an AB-BA deadlock where one task tries to acquire | ||
240 | * s_write_mutex with a locked page and GC tries to get that page while holding | ||
241 | * s_write_mutex. | ||
242 | * To solve this issue logfs will ignore the page lock iff the page in question | ||
243 | * is waiting for s_write_mutex. We annotate this fact by setting PG_pre_locked | ||
244 | * in addition to PG_locked. | ||
245 | */ | ||
246 | static void logfs_get_wblocks(struct super_block *sb, struct page *page, | ||
247 | int lock) | ||
248 | { | ||
249 | struct logfs_super *super = logfs_super(sb); | ||
250 | |||
251 | if (page) | ||
252 | prelock_page(sb, page, lock); | ||
253 | |||
254 | if (lock) { | ||
255 | mutex_lock(&super->s_write_mutex); | ||
256 | logfs_gc_pass(sb); | ||
257 | /* FIXME: We also have to check for shadowed space | ||
258 | * and mempool fill grade */ | ||
259 | } | ||
260 | } | ||
261 | |||
262 | static void logfs_put_wblocks(struct super_block *sb, struct page *page, | ||
263 | int lock) | ||
264 | { | ||
265 | struct logfs_super *super = logfs_super(sb); | ||
266 | |||
267 | if (page) | ||
268 | preunlock_page(sb, page, lock); | ||
269 | /* Order matters - we must clear PG_pre_locked before releasing | ||
270 | * s_write_mutex or we could race against another task. */ | ||
271 | if (lock) | ||
272 | mutex_unlock(&super->s_write_mutex); | ||
273 | } | ||
274 | |||
275 | static struct page *logfs_get_read_page(struct inode *inode, u64 bix, | ||
276 | level_t level) | ||
277 | { | ||
278 | return find_or_create_page(inode->i_mapping, | ||
279 | logfs_pack_index(bix, level), GFP_NOFS); | ||
280 | } | ||
281 | |||
282 | static void logfs_put_read_page(struct page *page) | ||
283 | { | ||
284 | unlock_page(page); | ||
285 | page_cache_release(page); | ||
286 | } | ||
287 | |||
288 | static void logfs_lock_write_page(struct page *page) | ||
289 | { | ||
290 | int loop = 0; | ||
291 | |||
292 | while (unlikely(!trylock_page(page))) { | ||
293 | if (loop++ > 0x1000) { | ||
294 | /* Has been observed once so far... */ | ||
295 | printk(KERN_ERR "stack at %p\n", &loop); | ||
296 | BUG(); | ||
297 | } | ||
298 | if (PagePreLocked(page)) { | ||
299 | /* Holder of page lock is waiting for us, it | ||
300 | * is safe to use this page. */ | ||
301 | break; | ||
302 | } | ||
303 | /* Some other process has this page locked and has | ||
304 | * nothing to do with us. Wait for it to finish. | ||
305 | */ | ||
306 | schedule(); | ||
307 | } | ||
308 | BUG_ON(!PageLocked(page)); | ||
309 | } | ||
310 | |||
311 | static struct page *logfs_get_write_page(struct inode *inode, u64 bix, | ||
312 | level_t level) | ||
313 | { | ||
314 | struct address_space *mapping = inode->i_mapping; | ||
315 | pgoff_t index = logfs_pack_index(bix, level); | ||
316 | struct page *page; | ||
317 | int err; | ||
318 | |||
319 | repeat: | ||
320 | page = find_get_page(mapping, index); | ||
321 | if (!page) { | ||
322 | page = __page_cache_alloc(GFP_NOFS); | ||
323 | if (!page) | ||
324 | return NULL; | ||
325 | err = add_to_page_cache_lru(page, mapping, index, GFP_NOFS); | ||
326 | if (unlikely(err)) { | ||
327 | page_cache_release(page); | ||
328 | if (err == -EEXIST) | ||
329 | goto repeat; | ||
330 | return NULL; | ||
331 | } | ||
332 | } else logfs_lock_write_page(page); | ||
333 | BUG_ON(!PageLocked(page)); | ||
334 | return page; | ||
335 | } | ||
336 | |||
337 | static void logfs_unlock_write_page(struct page *page) | ||
338 | { | ||
339 | if (!PagePreLocked(page)) | ||
340 | unlock_page(page); | ||
341 | } | ||
342 | |||
343 | static void logfs_put_write_page(struct page *page) | ||
344 | { | ||
345 | logfs_unlock_write_page(page); | ||
346 | page_cache_release(page); | ||
347 | } | ||
348 | |||
349 | static struct page *logfs_get_page(struct inode *inode, u64 bix, level_t level, | ||
350 | int rw) | ||
351 | { | ||
352 | if (rw == READ) | ||
353 | return logfs_get_read_page(inode, bix, level); | ||
354 | else | ||
355 | return logfs_get_write_page(inode, bix, level); | ||
356 | } | ||
357 | |||
358 | static void logfs_put_page(struct page *page, int rw) | ||
359 | { | ||
360 | if (rw == READ) | ||
361 | logfs_put_read_page(page); | ||
362 | else | ||
363 | logfs_put_write_page(page); | ||
364 | } | ||
365 | |||
366 | static unsigned long __get_bits(u64 val, int skip, int no) | ||
367 | { | ||
368 | u64 ret = val; | ||
369 | |||
370 | ret >>= skip * no; | ||
371 | ret <<= 64 - no; | ||
372 | ret >>= 64 - no; | ||
373 | return ret; | ||
374 | } | ||
375 | |||
376 | static unsigned long get_bits(u64 val, level_t skip) | ||
377 | { | ||
378 | return __get_bits(val, (__force int)skip, LOGFS_BLOCK_BITS); | ||
379 | } | ||
380 | |||
381 | static inline void init_shadow_tree(struct super_block *sb, | ||
382 | struct shadow_tree *tree) | ||
383 | { | ||
384 | struct logfs_super *super = logfs_super(sb); | ||
385 | |||
386 | btree_init_mempool64(&tree->new, super->s_btree_pool); | ||
387 | btree_init_mempool64(&tree->old, super->s_btree_pool); | ||
388 | } | ||
389 | |||
390 | static void indirect_write_block(struct logfs_block *block) | ||
391 | { | ||
392 | struct page *page; | ||
393 | struct inode *inode; | ||
394 | int ret; | ||
395 | |||
396 | page = block->page; | ||
397 | inode = page->mapping->host; | ||
398 | logfs_lock_write_page(page); | ||
399 | ret = logfs_write_buf(inode, page, 0); | ||
400 | logfs_unlock_write_page(page); | ||
401 | /* | ||
402 | * This needs some rework. Unless you want your filesystem to run | ||
403 | * completely synchronously (you don't), the filesystem will always | ||
404 | * report writes as 'successful' before the actual work has been | ||
405 | * done. The actual work gets done here and this is where any errors | ||
406 | * will show up. And there isn't much we can do about it, really. | ||
407 | * | ||
408 | * Some attempts to fix the errors (move from bad blocks, retry io,...) | ||
409 | * have already been done, so anything left should be either a broken | ||
410 | * device or a bug somewhere in logfs itself. Being relatively new, | ||
411 | * the odds currently favor a bug, so for now the line below isn't | ||
412 | * entirely tasteles. | ||
413 | */ | ||
414 | BUG_ON(ret); | ||
415 | } | ||
416 | |||
417 | static void inode_write_block(struct logfs_block *block) | ||
418 | { | ||
419 | struct inode *inode; | ||
420 | int ret; | ||
421 | |||
422 | inode = block->inode; | ||
423 | if (inode->i_ino == LOGFS_INO_MASTER) | ||
424 | logfs_write_anchor(inode->i_sb); | ||
425 | else { | ||
426 | ret = __logfs_write_inode(inode, 0); | ||
427 | /* see indirect_write_block comment */ | ||
428 | BUG_ON(ret); | ||
429 | } | ||
430 | } | ||
431 | |||
432 | static gc_level_t inode_block_level(struct logfs_block *block) | ||
433 | { | ||
434 | BUG_ON(block->inode->i_ino == LOGFS_INO_MASTER); | ||
435 | return GC_LEVEL(LOGFS_MAX_LEVELS); | ||
436 | } | ||
437 | |||
438 | static gc_level_t indirect_block_level(struct logfs_block *block) | ||
439 | { | ||
440 | struct page *page; | ||
441 | struct inode *inode; | ||
442 | u64 bix; | ||
443 | level_t level; | ||
444 | |||
445 | page = block->page; | ||
446 | inode = page->mapping->host; | ||
447 | logfs_unpack_index(page->index, &bix, &level); | ||
448 | return expand_level(inode->i_ino, level); | ||
449 | } | ||
450 | |||
451 | /* | ||
452 | * This silences a false, yet annoying gcc warning. I hate it when my editor | ||
453 | * jumps into bitops.h each time I recompile this file. | ||
454 | * TODO: Complain to gcc folks about this and upgrade compiler. | ||
455 | */ | ||
456 | static unsigned long fnb(const unsigned long *addr, | ||
457 | unsigned long size, unsigned long offset) | ||
458 | { | ||
459 | return find_next_bit(addr, size, offset); | ||
460 | } | ||
461 | |||
462 | static __be64 inode_val0(struct inode *inode) | ||
463 | { | ||
464 | struct logfs_inode *li = logfs_inode(inode); | ||
465 | u64 val; | ||
466 | |||
467 | /* | ||
468 | * Explicit shifting generates good code, but must match the format | ||
469 | * of the structure. Add some paranoia just in case. | ||
470 | */ | ||
471 | BUILD_BUG_ON(offsetof(struct logfs_disk_inode, di_mode) != 0); | ||
472 | BUILD_BUG_ON(offsetof(struct logfs_disk_inode, di_height) != 2); | ||
473 | BUILD_BUG_ON(offsetof(struct logfs_disk_inode, di_flags) != 4); | ||
474 | |||
475 | val = (u64)inode->i_mode << 48 | | ||
476 | (u64)li->li_height << 40 | | ||
477 | (u64)li->li_flags; | ||
478 | return cpu_to_be64(val); | ||
479 | } | ||
480 | |||
481 | static int inode_write_alias(struct super_block *sb, | ||
482 | struct logfs_block *block, write_alias_t *write_one_alias) | ||
483 | { | ||
484 | struct inode *inode = block->inode; | ||
485 | struct logfs_inode *li = logfs_inode(inode); | ||
486 | unsigned long pos; | ||
487 | u64 ino , bix; | ||
488 | __be64 val; | ||
489 | level_t level; | ||
490 | int err; | ||
491 | |||
492 | for (pos = 0; ; pos++) { | ||
493 | pos = fnb(block->alias_map, LOGFS_BLOCK_FACTOR, pos); | ||
494 | if (pos >= LOGFS_EMBEDDED_FIELDS + INODE_POINTER_OFS) | ||
495 | return 0; | ||
496 | |||
497 | switch (pos) { | ||
498 | case INODE_HEIGHT_OFS: | ||
499 | val = inode_val0(inode); | ||
500 | break; | ||
501 | case INODE_USED_OFS: | ||
502 | val = cpu_to_be64(li->li_used_bytes);; | ||
503 | break; | ||
504 | case INODE_SIZE_OFS: | ||
505 | val = cpu_to_be64(i_size_read(inode)); | ||
506 | break; | ||
507 | case INODE_POINTER_OFS ... INODE_POINTER_OFS + LOGFS_EMBEDDED_FIELDS - 1: | ||
508 | val = cpu_to_be64(li->li_data[pos - INODE_POINTER_OFS]); | ||
509 | break; | ||
510 | default: | ||
511 | BUG(); | ||
512 | } | ||
513 | |||
514 | ino = LOGFS_INO_MASTER; | ||
515 | bix = inode->i_ino; | ||
516 | level = LEVEL(0); | ||
517 | err = write_one_alias(sb, ino, bix, level, pos, val); | ||
518 | if (err) | ||
519 | return err; | ||
520 | } | ||
521 | } | ||
522 | |||
523 | static int indirect_write_alias(struct super_block *sb, | ||
524 | struct logfs_block *block, write_alias_t *write_one_alias) | ||
525 | { | ||
526 | unsigned long pos; | ||
527 | struct page *page = block->page; | ||
528 | u64 ino , bix; | ||
529 | __be64 *child, val; | ||
530 | level_t level; | ||
531 | int err; | ||
532 | |||
533 | for (pos = 0; ; pos++) { | ||
534 | pos = fnb(block->alias_map, LOGFS_BLOCK_FACTOR, pos); | ||
535 | if (pos >= LOGFS_BLOCK_FACTOR) | ||
536 | return 0; | ||
537 | |||
538 | ino = page->mapping->host->i_ino; | ||
539 | logfs_unpack_index(page->index, &bix, &level); | ||
540 | child = kmap_atomic(page, KM_USER0); | ||
541 | val = child[pos]; | ||
542 | kunmap_atomic(child, KM_USER0); | ||
543 | err = write_one_alias(sb, ino, bix, level, pos, val); | ||
544 | if (err) | ||
545 | return err; | ||
546 | } | ||
547 | } | ||
548 | |||
549 | int logfs_write_obj_aliases_pagecache(struct super_block *sb) | ||
550 | { | ||
551 | struct logfs_super *super = logfs_super(sb); | ||
552 | struct logfs_block *block; | ||
553 | int err; | ||
554 | |||
555 | list_for_each_entry(block, &super->s_object_alias, alias_list) { | ||
556 | err = block->ops->write_alias(sb, block, write_alias_journal); | ||
557 | if (err) | ||
558 | return err; | ||
559 | } | ||
560 | return 0; | ||
561 | } | ||
562 | |||
563 | void __free_block(struct super_block *sb, struct logfs_block *block) | ||
564 | { | ||
565 | BUG_ON(!list_empty(&block->item_list)); | ||
566 | list_del(&block->alias_list); | ||
567 | mempool_free(block, logfs_super(sb)->s_block_pool); | ||
568 | } | ||
569 | |||
570 | static void inode_free_block(struct super_block *sb, struct logfs_block *block) | ||
571 | { | ||
572 | struct inode *inode = block->inode; | ||
573 | |||
574 | logfs_inode(inode)->li_block = NULL; | ||
575 | __free_block(sb, block); | ||
576 | } | ||
577 | |||
578 | static void indirect_free_block(struct super_block *sb, | ||
579 | struct logfs_block *block) | ||
580 | { | ||
581 | ClearPagePrivate(block->page); | ||
582 | block->page->private = 0; | ||
583 | __free_block(sb, block); | ||
584 | } | ||
585 | |||
586 | |||
587 | static struct logfs_block_ops inode_block_ops = { | ||
588 | .write_block = inode_write_block, | ||
589 | .block_level = inode_block_level, | ||
590 | .free_block = inode_free_block, | ||
591 | .write_alias = inode_write_alias, | ||
592 | }; | ||
593 | |||
594 | struct logfs_block_ops indirect_block_ops = { | ||
595 | .write_block = indirect_write_block, | ||
596 | .block_level = indirect_block_level, | ||
597 | .free_block = indirect_free_block, | ||
598 | .write_alias = indirect_write_alias, | ||
599 | }; | ||
600 | |||
601 | struct logfs_block *__alloc_block(struct super_block *sb, | ||
602 | u64 ino, u64 bix, level_t level) | ||
603 | { | ||
604 | struct logfs_super *super = logfs_super(sb); | ||
605 | struct logfs_block *block; | ||
606 | |||
607 | block = mempool_alloc(super->s_block_pool, GFP_NOFS); | ||
608 | memset(block, 0, sizeof(*block)); | ||
609 | INIT_LIST_HEAD(&block->alias_list); | ||
610 | INIT_LIST_HEAD(&block->item_list); | ||
611 | block->sb = sb; | ||
612 | block->ino = ino; | ||
613 | block->bix = bix; | ||
614 | block->level = level; | ||
615 | return block; | ||
616 | } | ||
617 | |||
618 | static void alloc_inode_block(struct inode *inode) | ||
619 | { | ||
620 | struct logfs_inode *li = logfs_inode(inode); | ||
621 | struct logfs_block *block; | ||
622 | |||
623 | if (li->li_block) | ||
624 | return; | ||
625 | |||
626 | block = __alloc_block(inode->i_sb, LOGFS_INO_MASTER, inode->i_ino, 0); | ||
627 | block->inode = inode; | ||
628 | li->li_block = block; | ||
629 | block->ops = &inode_block_ops; | ||
630 | } | ||
631 | |||
632 | void initialize_block_counters(struct page *page, struct logfs_block *block, | ||
633 | __be64 *array, int page_is_empty) | ||
634 | { | ||
635 | u64 ptr; | ||
636 | int i, start; | ||
637 | |||
638 | block->partial = 0; | ||
639 | block->full = 0; | ||
640 | start = 0; | ||
641 | if (page->index < first_indirect_block()) { | ||
642 | /* Counters are pointless on level 0 */ | ||
643 | return; | ||
644 | } | ||
645 | if (page->index == first_indirect_block()) { | ||
646 | /* Skip unused pointers */ | ||
647 | start = I0_BLOCKS; | ||
648 | block->full = I0_BLOCKS; | ||
649 | } | ||
650 | if (!page_is_empty) { | ||
651 | for (i = start; i < LOGFS_BLOCK_FACTOR; i++) { | ||
652 | ptr = be64_to_cpu(array[i]); | ||
653 | if (ptr) | ||
654 | block->partial++; | ||
655 | if (ptr & LOGFS_FULLY_POPULATED) | ||
656 | block->full++; | ||
657 | } | ||
658 | } | ||
659 | } | ||
660 | |||
661 | static void alloc_data_block(struct inode *inode, struct page *page) | ||
662 | { | ||
663 | struct logfs_block *block; | ||
664 | u64 bix; | ||
665 | level_t level; | ||
666 | |||
667 | if (PagePrivate(page)) | ||
668 | return; | ||
669 | |||
670 | logfs_unpack_index(page->index, &bix, &level); | ||
671 | block = __alloc_block(inode->i_sb, inode->i_ino, bix, level); | ||
672 | block->page = page; | ||
673 | SetPagePrivate(page); | ||
674 | page->private = (unsigned long)block; | ||
675 | block->ops = &indirect_block_ops; | ||
676 | } | ||
677 | |||
678 | static void alloc_indirect_block(struct inode *inode, struct page *page, | ||
679 | int page_is_empty) | ||
680 | { | ||
681 | struct logfs_block *block; | ||
682 | __be64 *array; | ||
683 | |||
684 | if (PagePrivate(page)) | ||
685 | return; | ||
686 | |||
687 | alloc_data_block(inode, page); | ||
688 | |||
689 | block = logfs_block(page); | ||
690 | array = kmap_atomic(page, KM_USER0); | ||
691 | initialize_block_counters(page, block, array, page_is_empty); | ||
692 | kunmap_atomic(array, KM_USER0); | ||
693 | } | ||
694 | |||
695 | static void block_set_pointer(struct page *page, int index, u64 ptr) | ||
696 | { | ||
697 | struct logfs_block *block = logfs_block(page); | ||
698 | __be64 *array; | ||
699 | u64 oldptr; | ||
700 | |||
701 | BUG_ON(!block); | ||
702 | array = kmap_atomic(page, KM_USER0); | ||
703 | oldptr = be64_to_cpu(array[index]); | ||
704 | array[index] = cpu_to_be64(ptr); | ||
705 | kunmap_atomic(array, KM_USER0); | ||
706 | SetPageUptodate(page); | ||
707 | |||
708 | block->full += !!(ptr & LOGFS_FULLY_POPULATED) | ||
709 | - !!(oldptr & LOGFS_FULLY_POPULATED); | ||
710 | block->partial += !!ptr - !!oldptr; | ||
711 | } | ||
712 | |||
713 | static u64 block_get_pointer(struct page *page, int index) | ||
714 | { | ||
715 | __be64 *block; | ||
716 | u64 ptr; | ||
717 | |||
718 | block = kmap_atomic(page, KM_USER0); | ||
719 | ptr = be64_to_cpu(block[index]); | ||
720 | kunmap_atomic(block, KM_USER0); | ||
721 | return ptr; | ||
722 | } | ||
723 | |||
724 | static int logfs_read_empty(struct page *page) | ||
725 | { | ||
726 | zero_user_segment(page, 0, PAGE_CACHE_SIZE); | ||
727 | return 0; | ||
728 | } | ||
729 | |||
730 | static int logfs_read_direct(struct inode *inode, struct page *page) | ||
731 | { | ||
732 | struct logfs_inode *li = logfs_inode(inode); | ||
733 | pgoff_t index = page->index; | ||
734 | u64 block; | ||
735 | |||
736 | block = li->li_data[index]; | ||
737 | if (!block) | ||
738 | return logfs_read_empty(page); | ||
739 | |||
740 | return logfs_segment_read(inode, page, block, index, 0); | ||
741 | } | ||
742 | |||
743 | static int logfs_read_loop(struct inode *inode, struct page *page, | ||
744 | int rw_context) | ||
745 | { | ||
746 | struct logfs_inode *li = logfs_inode(inode); | ||
747 | u64 bix, bofs = li->li_data[INDIRECT_INDEX]; | ||
748 | level_t level, target_level; | ||
749 | int ret; | ||
750 | struct page *ipage; | ||
751 | |||
752 | logfs_unpack_index(page->index, &bix, &target_level); | ||
753 | if (!bofs) | ||
754 | return logfs_read_empty(page); | ||
755 | |||
756 | if (bix >= maxbix(li->li_height)) | ||
757 | return logfs_read_empty(page); | ||
758 | |||
759 | for (level = LEVEL(li->li_height); | ||
760 | (__force u8)level > (__force u8)target_level; | ||
761 | level = SUBLEVEL(level)){ | ||
762 | ipage = logfs_get_page(inode, bix, level, rw_context); | ||
763 | if (!ipage) | ||
764 | return -ENOMEM; | ||
765 | |||
766 | ret = logfs_segment_read(inode, ipage, bofs, bix, level); | ||
767 | if (ret) { | ||
768 | logfs_put_read_page(ipage); | ||
769 | return ret; | ||
770 | } | ||
771 | |||
772 | bofs = block_get_pointer(ipage, get_bits(bix, SUBLEVEL(level))); | ||
773 | logfs_put_page(ipage, rw_context); | ||
774 | if (!bofs) | ||
775 | return logfs_read_empty(page); | ||
776 | } | ||
777 | |||
778 | return logfs_segment_read(inode, page, bofs, bix, 0); | ||
779 | } | ||
780 | |||
781 | static int logfs_read_block(struct inode *inode, struct page *page, | ||
782 | int rw_context) | ||
783 | { | ||
784 | pgoff_t index = page->index; | ||
785 | |||
786 | if (index < I0_BLOCKS) | ||
787 | return logfs_read_direct(inode, page); | ||
788 | return logfs_read_loop(inode, page, rw_context); | ||
789 | } | ||
790 | |||
791 | static int logfs_exist_loop(struct inode *inode, u64 bix) | ||
792 | { | ||
793 | struct logfs_inode *li = logfs_inode(inode); | ||
794 | u64 bofs = li->li_data[INDIRECT_INDEX]; | ||
795 | level_t level; | ||
796 | int ret; | ||
797 | struct page *ipage; | ||
798 | |||
799 | if (!bofs) | ||
800 | return 0; | ||
801 | if (bix >= maxbix(li->li_height)) | ||
802 | return 0; | ||
803 | |||
804 | for (level = LEVEL(li->li_height); level != 0; level = SUBLEVEL(level)) { | ||
805 | ipage = logfs_get_read_page(inode, bix, level); | ||
806 | if (!ipage) | ||
807 | return -ENOMEM; | ||
808 | |||
809 | ret = logfs_segment_read(inode, ipage, bofs, bix, level); | ||
810 | if (ret) { | ||
811 | logfs_put_read_page(ipage); | ||
812 | return ret; | ||
813 | } | ||
814 | |||
815 | bofs = block_get_pointer(ipage, get_bits(bix, SUBLEVEL(level))); | ||
816 | logfs_put_read_page(ipage); | ||
817 | if (!bofs) | ||
818 | return 0; | ||
819 | } | ||
820 | |||
821 | return 1; | ||
822 | } | ||
823 | |||
824 | int logfs_exist_block(struct inode *inode, u64 bix) | ||
825 | { | ||
826 | struct logfs_inode *li = logfs_inode(inode); | ||
827 | |||
828 | if (bix < I0_BLOCKS) | ||
829 | return !!li->li_data[bix]; | ||
830 | return logfs_exist_loop(inode, bix); | ||
831 | } | ||
832 | |||
833 | static u64 seek_holedata_direct(struct inode *inode, u64 bix, int data) | ||
834 | { | ||
835 | struct logfs_inode *li = logfs_inode(inode); | ||
836 | |||
837 | for (; bix < I0_BLOCKS; bix++) | ||
838 | if (data ^ (li->li_data[bix] == 0)) | ||
839 | return bix; | ||
840 | return I0_BLOCKS; | ||
841 | } | ||
842 | |||
843 | static u64 seek_holedata_loop(struct inode *inode, u64 bix, int data) | ||
844 | { | ||
845 | struct logfs_inode *li = logfs_inode(inode); | ||
846 | __be64 *rblock; | ||
847 | u64 increment, bofs = li->li_data[INDIRECT_INDEX]; | ||
848 | level_t level; | ||
849 | int ret, slot; | ||
850 | struct page *page; | ||
851 | |||
852 | BUG_ON(!bofs); | ||
853 | |||
854 | for (level = LEVEL(li->li_height); level != 0; level = SUBLEVEL(level)) { | ||
855 | increment = 1 << (LOGFS_BLOCK_BITS * ((__force u8)level-1)); | ||
856 | page = logfs_get_read_page(inode, bix, level); | ||
857 | if (!page) | ||
858 | return bix; | ||
859 | |||
860 | ret = logfs_segment_read(inode, page, bofs, bix, level); | ||
861 | if (ret) { | ||
862 | logfs_put_read_page(page); | ||
863 | return bix; | ||
864 | } | ||
865 | |||
866 | slot = get_bits(bix, SUBLEVEL(level)); | ||
867 | rblock = kmap_atomic(page, KM_USER0); | ||
868 | while (slot < LOGFS_BLOCK_FACTOR) { | ||
869 | if (data && (rblock[slot] != 0)) | ||
870 | break; | ||
871 | if (!data && !(be64_to_cpu(rblock[slot]) & LOGFS_FULLY_POPULATED)) | ||
872 | break; | ||
873 | slot++; | ||
874 | bix += increment; | ||
875 | bix &= ~(increment - 1); | ||
876 | } | ||
877 | if (slot >= LOGFS_BLOCK_FACTOR) { | ||
878 | kunmap_atomic(rblock, KM_USER0); | ||
879 | logfs_put_read_page(page); | ||
880 | return bix; | ||
881 | } | ||
882 | bofs = be64_to_cpu(rblock[slot]); | ||
883 | kunmap_atomic(rblock, KM_USER0); | ||
884 | logfs_put_read_page(page); | ||
885 | if (!bofs) { | ||
886 | BUG_ON(data); | ||
887 | return bix; | ||
888 | } | ||
889 | } | ||
890 | return bix; | ||
891 | } | ||
892 | |||
893 | /** | ||
894 | * logfs_seek_hole - find next hole starting at a given block index | ||
895 | * @inode: inode to search in | ||
896 | * @bix: block index to start searching | ||
897 | * | ||
898 | * Returns next hole. If the file doesn't contain any further holes, the | ||
899 | * block address next to eof is returned instead. | ||
900 | */ | ||
901 | u64 logfs_seek_hole(struct inode *inode, u64 bix) | ||
902 | { | ||
903 | struct logfs_inode *li = logfs_inode(inode); | ||
904 | |||
905 | if (bix < I0_BLOCKS) { | ||
906 | bix = seek_holedata_direct(inode, bix, 0); | ||
907 | if (bix < I0_BLOCKS) | ||
908 | return bix; | ||
909 | } | ||
910 | |||
911 | if (!li->li_data[INDIRECT_INDEX]) | ||
912 | return bix; | ||
913 | else if (li->li_data[INDIRECT_INDEX] & LOGFS_FULLY_POPULATED) | ||
914 | bix = maxbix(li->li_height); | ||
915 | else { | ||
916 | bix = seek_holedata_loop(inode, bix, 0); | ||
917 | if (bix < maxbix(li->li_height)) | ||
918 | return bix; | ||
919 | /* Should not happen anymore. But if some port writes semi- | ||
920 | * corrupt images (as this one used to) we might run into it. | ||
921 | */ | ||
922 | WARN_ON_ONCE(bix == maxbix(li->li_height)); | ||
923 | } | ||
924 | |||
925 | return bix; | ||
926 | } | ||
927 | |||
928 | static u64 __logfs_seek_data(struct inode *inode, u64 bix) | ||
929 | { | ||
930 | struct logfs_inode *li = logfs_inode(inode); | ||
931 | |||
932 | if (bix < I0_BLOCKS) { | ||
933 | bix = seek_holedata_direct(inode, bix, 1); | ||
934 | if (bix < I0_BLOCKS) | ||
935 | return bix; | ||
936 | } | ||
937 | |||
938 | if (bix < maxbix(li->li_height)) { | ||
939 | if (!li->li_data[INDIRECT_INDEX]) | ||
940 | bix = maxbix(li->li_height); | ||
941 | else | ||
942 | return seek_holedata_loop(inode, bix, 1); | ||
943 | } | ||
944 | |||
945 | return bix; | ||
946 | } | ||
947 | |||
948 | /** | ||
949 | * logfs_seek_data - find next data block after a given block index | ||
950 | * @inode: inode to search in | ||
951 | * @bix: block index to start searching | ||
952 | * | ||
953 | * Returns next data block. If the file doesn't contain any further data | ||
954 | * blocks, the last block in the file is returned instead. | ||
955 | */ | ||
956 | u64 logfs_seek_data(struct inode *inode, u64 bix) | ||
957 | { | ||
958 | struct super_block *sb = inode->i_sb; | ||
959 | u64 ret, end; | ||
960 | |||
961 | ret = __logfs_seek_data(inode, bix); | ||
962 | end = i_size_read(inode) >> sb->s_blocksize_bits; | ||
963 | if (ret >= end) | ||
964 | ret = max(bix, end); | ||
965 | return ret; | ||
966 | } | ||
967 | |||
968 | static int logfs_is_valid_direct(struct logfs_inode *li, u64 bix, u64 ofs) | ||
969 | { | ||
970 | return pure_ofs(li->li_data[bix]) == ofs; | ||
971 | } | ||
972 | |||
973 | static int __logfs_is_valid_loop(struct inode *inode, u64 bix, | ||
974 | u64 ofs, u64 bofs) | ||
975 | { | ||
976 | struct logfs_inode *li = logfs_inode(inode); | ||
977 | level_t level; | ||
978 | int ret; | ||
979 | struct page *page; | ||
980 | |||
981 | for (level = LEVEL(li->li_height); level != 0; level = SUBLEVEL(level)){ | ||
982 | page = logfs_get_write_page(inode, bix, level); | ||
983 | BUG_ON(!page); | ||
984 | |||
985 | ret = logfs_segment_read(inode, page, bofs, bix, level); | ||
986 | if (ret) { | ||
987 | logfs_put_write_page(page); | ||
988 | return 0; | ||
989 | } | ||
990 | |||
991 | bofs = block_get_pointer(page, get_bits(bix, SUBLEVEL(level))); | ||
992 | logfs_put_write_page(page); | ||
993 | if (!bofs) | ||
994 | return 0; | ||
995 | |||
996 | if (pure_ofs(bofs) == ofs) | ||
997 | return 1; | ||
998 | } | ||
999 | return 0; | ||
1000 | } | ||
1001 | |||
1002 | static int logfs_is_valid_loop(struct inode *inode, u64 bix, u64 ofs) | ||
1003 | { | ||
1004 | struct logfs_inode *li = logfs_inode(inode); | ||
1005 | u64 bofs = li->li_data[INDIRECT_INDEX]; | ||
1006 | |||
1007 | if (!bofs) | ||
1008 | return 0; | ||
1009 | |||
1010 | if (bix >= maxbix(li->li_height)) | ||
1011 | return 0; | ||
1012 | |||
1013 | if (pure_ofs(bofs) == ofs) | ||
1014 | return 1; | ||
1015 | |||
1016 | return __logfs_is_valid_loop(inode, bix, ofs, bofs); | ||
1017 | } | ||
1018 | |||
1019 | static int __logfs_is_valid_block(struct inode *inode, u64 bix, u64 ofs) | ||
1020 | { | ||
1021 | struct logfs_inode *li = logfs_inode(inode); | ||
1022 | |||
1023 | if ((inode->i_nlink == 0) && atomic_read(&inode->i_count) == 1) | ||
1024 | return 0; | ||
1025 | |||
1026 | if (bix < I0_BLOCKS) | ||
1027 | return logfs_is_valid_direct(li, bix, ofs); | ||
1028 | return logfs_is_valid_loop(inode, bix, ofs); | ||
1029 | } | ||
1030 | |||
1031 | /** | ||
1032 | * logfs_is_valid_block - check whether this block is still valid | ||
1033 | * | ||
1034 | * @sb - superblock | ||
1035 | * @ofs - block physical offset | ||
1036 | * @ino - block inode number | ||
1037 | * @bix - block index | ||
1038 | * @level - block level | ||
1039 | * | ||
1040 | * Returns 0 if the block is invalid, 1 if it is valid and 2 if it will | ||
1041 | * become invalid once the journal is written. | ||
1042 | */ | ||
1043 | int logfs_is_valid_block(struct super_block *sb, u64 ofs, u64 ino, u64 bix, | ||
1044 | gc_level_t gc_level) | ||
1045 | { | ||
1046 | struct logfs_super *super = logfs_super(sb); | ||
1047 | struct inode *inode; | ||
1048 | int ret, cookie; | ||
1049 | |||
1050 | /* Umount closes a segment with free blocks remaining. Those | ||
1051 | * blocks are by definition invalid. */ | ||
1052 | if (ino == -1) | ||
1053 | return 0; | ||
1054 | |||
1055 | LOGFS_BUG_ON((u64)(u_long)ino != ino, sb); | ||
1056 | |||
1057 | inode = logfs_safe_iget(sb, ino, &cookie); | ||
1058 | if (IS_ERR(inode)) | ||
1059 | goto invalid; | ||
1060 | |||
1061 | ret = __logfs_is_valid_block(inode, bix, ofs); | ||
1062 | logfs_safe_iput(inode, cookie); | ||
1063 | if (ret) | ||
1064 | return ret; | ||
1065 | |||
1066 | invalid: | ||
1067 | /* Block is nominally invalid, but may still sit in the shadow tree, | ||
1068 | * waiting for a journal commit. | ||
1069 | */ | ||
1070 | if (btree_lookup64(&super->s_shadow_tree.old, ofs)) | ||
1071 | return 2; | ||
1072 | return 0; | ||
1073 | } | ||
1074 | |||
1075 | int logfs_readpage_nolock(struct page *page) | ||
1076 | { | ||
1077 | struct inode *inode = page->mapping->host; | ||
1078 | int ret = -EIO; | ||
1079 | |||
1080 | ret = logfs_read_block(inode, page, READ); | ||
1081 | |||
1082 | if (ret) { | ||
1083 | ClearPageUptodate(page); | ||
1084 | SetPageError(page); | ||
1085 | } else { | ||
1086 | SetPageUptodate(page); | ||
1087 | ClearPageError(page); | ||
1088 | } | ||
1089 | flush_dcache_page(page); | ||
1090 | |||
1091 | return ret; | ||
1092 | } | ||
1093 | |||
1094 | static int logfs_reserve_bytes(struct inode *inode, int bytes) | ||
1095 | { | ||
1096 | struct logfs_super *super = logfs_super(inode->i_sb); | ||
1097 | u64 available = super->s_free_bytes + super->s_dirty_free_bytes | ||
1098 | - super->s_dirty_used_bytes - super->s_dirty_pages; | ||
1099 | |||
1100 | if (!bytes) | ||
1101 | return 0; | ||
1102 | |||
1103 | if (available < bytes) | ||
1104 | return -ENOSPC; | ||
1105 | |||
1106 | if (available < bytes + super->s_root_reserve && | ||
1107 | !capable(CAP_SYS_RESOURCE)) | ||
1108 | return -ENOSPC; | ||
1109 | |||
1110 | return 0; | ||
1111 | } | ||
1112 | |||
1113 | int get_page_reserve(struct inode *inode, struct page *page) | ||
1114 | { | ||
1115 | struct logfs_super *super = logfs_super(inode->i_sb); | ||
1116 | int ret; | ||
1117 | |||
1118 | if (logfs_block(page) && logfs_block(page)->reserved_bytes) | ||
1119 | return 0; | ||
1120 | |||
1121 | logfs_get_wblocks(inode->i_sb, page, WF_LOCK); | ||
1122 | ret = logfs_reserve_bytes(inode, 6 * LOGFS_MAX_OBJECTSIZE); | ||
1123 | if (!ret) { | ||
1124 | alloc_data_block(inode, page); | ||
1125 | logfs_block(page)->reserved_bytes += 6 * LOGFS_MAX_OBJECTSIZE; | ||
1126 | super->s_dirty_pages += 6 * LOGFS_MAX_OBJECTSIZE; | ||
1127 | } | ||
1128 | logfs_put_wblocks(inode->i_sb, page, WF_LOCK); | ||
1129 | return ret; | ||
1130 | } | ||
1131 | |||
1132 | /* | ||
1133 | * We are protected by write lock. Push victims up to superblock level | ||
1134 | * and release transaction when appropriate. | ||
1135 | */ | ||
1136 | /* FIXME: This is currently called from the wrong spots. */ | ||
1137 | static void logfs_handle_transaction(struct inode *inode, | ||
1138 | struct logfs_transaction *ta) | ||
1139 | { | ||
1140 | struct logfs_super *super = logfs_super(inode->i_sb); | ||
1141 | |||
1142 | if (!ta) | ||
1143 | return; | ||
1144 | logfs_inode(inode)->li_block->ta = NULL; | ||
1145 | |||
1146 | if (inode->i_ino != LOGFS_INO_MASTER) { | ||
1147 | BUG(); /* FIXME: Yes, this needs more thought */ | ||
1148 | /* just remember the transaction until inode is written */ | ||
1149 | //BUG_ON(logfs_inode(inode)->li_transaction); | ||
1150 | //logfs_inode(inode)->li_transaction = ta; | ||
1151 | return; | ||
1152 | } | ||
1153 | |||
1154 | switch (ta->state) { | ||
1155 | case CREATE_1: /* fall through */ | ||
1156 | case UNLINK_1: | ||
1157 | BUG_ON(super->s_victim_ino); | ||
1158 | super->s_victim_ino = ta->ino; | ||
1159 | break; | ||
1160 | case CREATE_2: /* fall through */ | ||
1161 | case UNLINK_2: | ||
1162 | BUG_ON(super->s_victim_ino != ta->ino); | ||
1163 | super->s_victim_ino = 0; | ||
1164 | /* transaction ends here - free it */ | ||
1165 | kfree(ta); | ||
1166 | break; | ||
1167 | case CROSS_RENAME_1: | ||
1168 | BUG_ON(super->s_rename_dir); | ||
1169 | BUG_ON(super->s_rename_pos); | ||
1170 | super->s_rename_dir = ta->dir; | ||
1171 | super->s_rename_pos = ta->pos; | ||
1172 | break; | ||
1173 | case CROSS_RENAME_2: | ||
1174 | BUG_ON(super->s_rename_dir != ta->dir); | ||
1175 | BUG_ON(super->s_rename_pos != ta->pos); | ||
1176 | super->s_rename_dir = 0; | ||
1177 | super->s_rename_pos = 0; | ||
1178 | kfree(ta); | ||
1179 | break; | ||
1180 | case TARGET_RENAME_1: | ||
1181 | BUG_ON(super->s_rename_dir); | ||
1182 | BUG_ON(super->s_rename_pos); | ||
1183 | BUG_ON(super->s_victim_ino); | ||
1184 | super->s_rename_dir = ta->dir; | ||
1185 | super->s_rename_pos = ta->pos; | ||
1186 | super->s_victim_ino = ta->ino; | ||
1187 | break; | ||
1188 | case TARGET_RENAME_2: | ||
1189 | BUG_ON(super->s_rename_dir != ta->dir); | ||
1190 | BUG_ON(super->s_rename_pos != ta->pos); | ||
1191 | BUG_ON(super->s_victim_ino != ta->ino); | ||
1192 | super->s_rename_dir = 0; | ||
1193 | super->s_rename_pos = 0; | ||
1194 | break; | ||
1195 | case TARGET_RENAME_3: | ||
1196 | BUG_ON(super->s_rename_dir); | ||
1197 | BUG_ON(super->s_rename_pos); | ||
1198 | BUG_ON(super->s_victim_ino != ta->ino); | ||
1199 | super->s_victim_ino = 0; | ||
1200 | kfree(ta); | ||
1201 | break; | ||
1202 | default: | ||
1203 | BUG(); | ||
1204 | } | ||
1205 | } | ||
1206 | |||
1207 | /* | ||
1208 | * Not strictly a reservation, but rather a check that we still have enough | ||
1209 | * space to satisfy the write. | ||
1210 | */ | ||
1211 | static int logfs_reserve_blocks(struct inode *inode, int blocks) | ||
1212 | { | ||
1213 | return logfs_reserve_bytes(inode, blocks * LOGFS_MAX_OBJECTSIZE); | ||
1214 | } | ||
1215 | |||
1216 | struct write_control { | ||
1217 | u64 ofs; | ||
1218 | long flags; | ||
1219 | }; | ||
1220 | |||
1221 | static struct logfs_shadow *alloc_shadow(struct inode *inode, u64 bix, | ||
1222 | level_t level, u64 old_ofs) | ||
1223 | { | ||
1224 | struct logfs_super *super = logfs_super(inode->i_sb); | ||
1225 | struct logfs_shadow *shadow; | ||
1226 | |||
1227 | shadow = mempool_alloc(super->s_shadow_pool, GFP_NOFS); | ||
1228 | memset(shadow, 0, sizeof(*shadow)); | ||
1229 | shadow->ino = inode->i_ino; | ||
1230 | shadow->bix = bix; | ||
1231 | shadow->gc_level = expand_level(inode->i_ino, level); | ||
1232 | shadow->old_ofs = old_ofs & ~LOGFS_FULLY_POPULATED; | ||
1233 | return shadow; | ||
1234 | } | ||
1235 | |||
1236 | static void free_shadow(struct inode *inode, struct logfs_shadow *shadow) | ||
1237 | { | ||
1238 | struct logfs_super *super = logfs_super(inode->i_sb); | ||
1239 | |||
1240 | mempool_free(shadow, super->s_shadow_pool); | ||
1241 | } | ||
1242 | |||
1243 | /** | ||
1244 | * fill_shadow_tree - Propagate shadow tree changes due to a write | ||
1245 | * @inode: Inode owning the page | ||
1246 | * @page: Struct page that was written | ||
1247 | * @shadow: Shadow for the current write | ||
1248 | * | ||
1249 | * Writes in logfs can result in two semi-valid objects. The old object | ||
1250 | * is still valid as long as it can be reached by following pointers on | ||
1251 | * the medium. Only when writes propagate all the way up to the journal | ||
1252 | * has the new object safely replaced the old one. | ||
1253 | * | ||
1254 | * To handle this problem, a struct logfs_shadow is used to represent | ||
1255 | * every single write. It is attached to the indirect block, which is | ||
1256 | * marked dirty. When the indirect block is written, its shadows are | ||
1257 | * handed up to the next indirect block (or inode). Untimately they | ||
1258 | * will reach the master inode and be freed upon journal commit. | ||
1259 | * | ||
1260 | * This function handles a single step in the propagation. It adds the | ||
1261 | * shadow for the current write to the tree, along with any shadows in | ||
1262 | * the page's tree, in case it was an indirect block. If a page is | ||
1263 | * written, the inode parameter is left NULL, if an inode is written, | ||
1264 | * the page parameter is left NULL. | ||
1265 | */ | ||
1266 | static void fill_shadow_tree(struct inode *inode, struct page *page, | ||
1267 | struct logfs_shadow *shadow) | ||
1268 | { | ||
1269 | struct logfs_super *super = logfs_super(inode->i_sb); | ||
1270 | struct logfs_block *block = logfs_block(page); | ||
1271 | struct shadow_tree *tree = &super->s_shadow_tree; | ||
1272 | |||
1273 | if (PagePrivate(page)) { | ||
1274 | if (block->alias_map) | ||
1275 | super->s_no_object_aliases -= bitmap_weight( | ||
1276 | block->alias_map, LOGFS_BLOCK_FACTOR); | ||
1277 | logfs_handle_transaction(inode, block->ta); | ||
1278 | block->ops->free_block(inode->i_sb, block); | ||
1279 | } | ||
1280 | if (shadow) { | ||
1281 | if (shadow->old_ofs) | ||
1282 | btree_insert64(&tree->old, shadow->old_ofs, shadow, | ||
1283 | GFP_NOFS); | ||
1284 | else | ||
1285 | btree_insert64(&tree->new, shadow->new_ofs, shadow, | ||
1286 | GFP_NOFS); | ||
1287 | |||
1288 | super->s_dirty_used_bytes += shadow->new_len; | ||
1289 | super->s_dirty_free_bytes += shadow->old_len; | ||
1290 | } | ||
1291 | } | ||
1292 | |||
1293 | static void logfs_set_alias(struct super_block *sb, struct logfs_block *block, | ||
1294 | long child_no) | ||
1295 | { | ||
1296 | struct logfs_super *super = logfs_super(sb); | ||
1297 | |||
1298 | if (block->inode && block->inode->i_ino == LOGFS_INO_MASTER) { | ||
1299 | /* Aliases in the master inode are pointless. */ | ||
1300 | return; | ||
1301 | } | ||
1302 | |||
1303 | if (!test_bit(child_no, block->alias_map)) { | ||
1304 | set_bit(child_no, block->alias_map); | ||
1305 | super->s_no_object_aliases++; | ||
1306 | } | ||
1307 | list_move_tail(&block->alias_list, &super->s_object_alias); | ||
1308 | } | ||
1309 | |||
1310 | /* | ||
1311 | * Object aliases can and often do change the size and occupied space of a | ||
1312 | * file. So not only do we have to change the pointers, we also have to | ||
1313 | * change inode->i_size and li->li_used_bytes. Which is done by setting | ||
1314 | * another two object aliases for the inode itself. | ||
1315 | */ | ||
1316 | static void set_iused(struct inode *inode, struct logfs_shadow *shadow) | ||
1317 | { | ||
1318 | struct logfs_inode *li = logfs_inode(inode); | ||
1319 | |||
1320 | if (shadow->new_len == shadow->old_len) | ||
1321 | return; | ||
1322 | |||
1323 | alloc_inode_block(inode); | ||
1324 | li->li_used_bytes += shadow->new_len - shadow->old_len; | ||
1325 | __logfs_set_blocks(inode); | ||
1326 | logfs_set_alias(inode->i_sb, li->li_block, INODE_USED_OFS); | ||
1327 | logfs_set_alias(inode->i_sb, li->li_block, INODE_SIZE_OFS); | ||
1328 | } | ||
1329 | |||
1330 | static int logfs_write_i0(struct inode *inode, struct page *page, | ||
1331 | struct write_control *wc) | ||
1332 | { | ||
1333 | struct logfs_shadow *shadow; | ||
1334 | u64 bix; | ||
1335 | level_t level; | ||
1336 | int full, err = 0; | ||
1337 | |||
1338 | logfs_unpack_index(page->index, &bix, &level); | ||
1339 | if (wc->ofs == 0) | ||
1340 | if (logfs_reserve_blocks(inode, 1)) | ||
1341 | return -ENOSPC; | ||
1342 | |||
1343 | shadow = alloc_shadow(inode, bix, level, wc->ofs); | ||
1344 | if (wc->flags & WF_WRITE) | ||
1345 | err = logfs_segment_write(inode, page, shadow); | ||
1346 | if (wc->flags & WF_DELETE) | ||
1347 | logfs_segment_delete(inode, shadow); | ||
1348 | if (err) { | ||
1349 | free_shadow(inode, shadow); | ||
1350 | return err; | ||
1351 | } | ||
1352 | |||
1353 | set_iused(inode, shadow); | ||
1354 | full = 1; | ||
1355 | if (level != 0) { | ||
1356 | alloc_indirect_block(inode, page, 0); | ||
1357 | full = logfs_block(page)->full == LOGFS_BLOCK_FACTOR; | ||
1358 | } | ||
1359 | fill_shadow_tree(inode, page, shadow); | ||
1360 | wc->ofs = shadow->new_ofs; | ||
1361 | if (wc->ofs && full) | ||
1362 | wc->ofs |= LOGFS_FULLY_POPULATED; | ||
1363 | return 0; | ||
1364 | } | ||
1365 | |||
1366 | static int logfs_write_direct(struct inode *inode, struct page *page, | ||
1367 | long flags) | ||
1368 | { | ||
1369 | struct logfs_inode *li = logfs_inode(inode); | ||
1370 | struct write_control wc = { | ||
1371 | .ofs = li->li_data[page->index], | ||
1372 | .flags = flags, | ||
1373 | }; | ||
1374 | int err; | ||
1375 | |||
1376 | alloc_inode_block(inode); | ||
1377 | |||
1378 | err = logfs_write_i0(inode, page, &wc); | ||
1379 | if (err) | ||
1380 | return err; | ||
1381 | |||
1382 | li->li_data[page->index] = wc.ofs; | ||
1383 | logfs_set_alias(inode->i_sb, li->li_block, | ||
1384 | page->index + INODE_POINTER_OFS); | ||
1385 | return 0; | ||
1386 | } | ||
1387 | |||
1388 | static int ptr_change(u64 ofs, struct page *page) | ||
1389 | { | ||
1390 | struct logfs_block *block = logfs_block(page); | ||
1391 | int empty0, empty1, full0, full1; | ||
1392 | |||
1393 | empty0 = ofs == 0; | ||
1394 | empty1 = block->partial == 0; | ||
1395 | if (empty0 != empty1) | ||
1396 | return 1; | ||
1397 | |||
1398 | /* The !! is necessary to shrink result to int */ | ||
1399 | full0 = !!(ofs & LOGFS_FULLY_POPULATED); | ||
1400 | full1 = block->full == LOGFS_BLOCK_FACTOR; | ||
1401 | if (full0 != full1) | ||
1402 | return 1; | ||
1403 | return 0; | ||
1404 | } | ||
1405 | |||
1406 | static int __logfs_write_rec(struct inode *inode, struct page *page, | ||
1407 | struct write_control *this_wc, | ||
1408 | pgoff_t bix, level_t target_level, level_t level) | ||
1409 | { | ||
1410 | int ret, page_empty = 0; | ||
1411 | int child_no = get_bits(bix, SUBLEVEL(level)); | ||
1412 | struct page *ipage; | ||
1413 | struct write_control child_wc = { | ||
1414 | .flags = this_wc->flags, | ||
1415 | }; | ||
1416 | |||
1417 | ipage = logfs_get_write_page(inode, bix, level); | ||
1418 | if (!ipage) | ||
1419 | return -ENOMEM; | ||
1420 | |||
1421 | if (this_wc->ofs) { | ||
1422 | ret = logfs_segment_read(inode, ipage, this_wc->ofs, bix, level); | ||
1423 | if (ret) | ||
1424 | goto out; | ||
1425 | } else if (!PageUptodate(ipage)) { | ||
1426 | page_empty = 1; | ||
1427 | logfs_read_empty(ipage); | ||
1428 | } | ||
1429 | |||
1430 | child_wc.ofs = block_get_pointer(ipage, child_no); | ||
1431 | |||
1432 | if ((__force u8)level-1 > (__force u8)target_level) | ||
1433 | ret = __logfs_write_rec(inode, page, &child_wc, bix, | ||
1434 | target_level, SUBLEVEL(level)); | ||
1435 | else | ||
1436 | ret = logfs_write_i0(inode, page, &child_wc); | ||
1437 | |||
1438 | if (ret) | ||
1439 | goto out; | ||
1440 | |||
1441 | alloc_indirect_block(inode, ipage, page_empty); | ||
1442 | block_set_pointer(ipage, child_no, child_wc.ofs); | ||
1443 | /* FIXME: first condition seems superfluous */ | ||
1444 | if (child_wc.ofs || logfs_block(ipage)->partial) | ||
1445 | this_wc->flags |= WF_WRITE; | ||
1446 | /* the condition on this_wc->ofs ensures that we won't consume extra | ||
1447 | * space for indirect blocks in the future, which we cannot reserve */ | ||
1448 | if (!this_wc->ofs || ptr_change(this_wc->ofs, ipage)) | ||
1449 | ret = logfs_write_i0(inode, ipage, this_wc); | ||
1450 | else | ||
1451 | logfs_set_alias(inode->i_sb, logfs_block(ipage), child_no); | ||
1452 | out: | ||
1453 | logfs_put_write_page(ipage); | ||
1454 | return ret; | ||
1455 | } | ||
1456 | |||
1457 | static int logfs_write_rec(struct inode *inode, struct page *page, | ||
1458 | pgoff_t bix, level_t target_level, long flags) | ||
1459 | { | ||
1460 | struct logfs_inode *li = logfs_inode(inode); | ||
1461 | struct write_control wc = { | ||
1462 | .ofs = li->li_data[INDIRECT_INDEX], | ||
1463 | .flags = flags, | ||
1464 | }; | ||
1465 | int ret; | ||
1466 | |||
1467 | alloc_inode_block(inode); | ||
1468 | |||
1469 | if (li->li_height > (__force u8)target_level) | ||
1470 | ret = __logfs_write_rec(inode, page, &wc, bix, target_level, | ||
1471 | LEVEL(li->li_height)); | ||
1472 | else | ||
1473 | ret = logfs_write_i0(inode, page, &wc); | ||
1474 | if (ret) | ||
1475 | return ret; | ||
1476 | |||
1477 | if (li->li_data[INDIRECT_INDEX] != wc.ofs) { | ||
1478 | li->li_data[INDIRECT_INDEX] = wc.ofs; | ||
1479 | logfs_set_alias(inode->i_sb, li->li_block, | ||
1480 | INDIRECT_INDEX + INODE_POINTER_OFS); | ||
1481 | } | ||
1482 | return ret; | ||
1483 | } | ||
1484 | |||
1485 | void logfs_add_transaction(struct inode *inode, struct logfs_transaction *ta) | ||
1486 | { | ||
1487 | alloc_inode_block(inode); | ||
1488 | logfs_inode(inode)->li_block->ta = ta; | ||
1489 | } | ||
1490 | |||
1491 | void logfs_del_transaction(struct inode *inode, struct logfs_transaction *ta) | ||
1492 | { | ||
1493 | struct logfs_block *block = logfs_inode(inode)->li_block; | ||
1494 | |||
1495 | if (block && block->ta) | ||
1496 | block->ta = NULL; | ||
1497 | } | ||
1498 | |||
1499 | static int grow_inode(struct inode *inode, u64 bix, level_t level) | ||
1500 | { | ||
1501 | struct logfs_inode *li = logfs_inode(inode); | ||
1502 | u8 height = (__force u8)level; | ||
1503 | struct page *page; | ||
1504 | struct write_control wc = { | ||
1505 | .flags = WF_WRITE, | ||
1506 | }; | ||
1507 | int err; | ||
1508 | |||
1509 | BUG_ON(height > 5 || li->li_height > 5); | ||
1510 | while (height > li->li_height || bix >= maxbix(li->li_height)) { | ||
1511 | page = logfs_get_write_page(inode, I0_BLOCKS + 1, | ||
1512 | LEVEL(li->li_height + 1)); | ||
1513 | if (!page) | ||
1514 | return -ENOMEM; | ||
1515 | logfs_read_empty(page); | ||
1516 | alloc_indirect_block(inode, page, 1); | ||
1517 | block_set_pointer(page, 0, li->li_data[INDIRECT_INDEX]); | ||
1518 | err = logfs_write_i0(inode, page, &wc); | ||
1519 | logfs_put_write_page(page); | ||
1520 | if (err) | ||
1521 | return err; | ||
1522 | li->li_data[INDIRECT_INDEX] = wc.ofs; | ||
1523 | wc.ofs = 0; | ||
1524 | li->li_height++; | ||
1525 | logfs_set_alias(inode->i_sb, li->li_block, INODE_HEIGHT_OFS); | ||
1526 | } | ||
1527 | return 0; | ||
1528 | } | ||
1529 | |||
1530 | static int __logfs_write_buf(struct inode *inode, struct page *page, long flags) | ||
1531 | { | ||
1532 | struct logfs_super *super = logfs_super(inode->i_sb); | ||
1533 | pgoff_t index = page->index; | ||
1534 | u64 bix; | ||
1535 | level_t level; | ||
1536 | int err; | ||
1537 | |||
1538 | flags |= WF_WRITE | WF_DELETE; | ||
1539 | inode->i_ctime = inode->i_mtime = CURRENT_TIME; | ||
1540 | |||
1541 | logfs_unpack_index(index, &bix, &level); | ||
1542 | if (logfs_block(page) && logfs_block(page)->reserved_bytes) | ||
1543 | super->s_dirty_pages -= logfs_block(page)->reserved_bytes; | ||
1544 | |||
1545 | if (index < I0_BLOCKS) | ||
1546 | return logfs_write_direct(inode, page, flags); | ||
1547 | |||
1548 | bix = adjust_bix(bix, level); | ||
1549 | err = grow_inode(inode, bix, level); | ||
1550 | if (err) | ||
1551 | return err; | ||
1552 | return logfs_write_rec(inode, page, bix, level, flags); | ||
1553 | } | ||
1554 | |||
1555 | int logfs_write_buf(struct inode *inode, struct page *page, long flags) | ||
1556 | { | ||
1557 | struct super_block *sb = inode->i_sb; | ||
1558 | int ret; | ||
1559 | |||
1560 | logfs_get_wblocks(sb, page, flags & WF_LOCK); | ||
1561 | ret = __logfs_write_buf(inode, page, flags); | ||
1562 | logfs_put_wblocks(sb, page, flags & WF_LOCK); | ||
1563 | return ret; | ||
1564 | } | ||
1565 | |||
1566 | static int __logfs_delete(struct inode *inode, struct page *page) | ||
1567 | { | ||
1568 | long flags = WF_DELETE; | ||
1569 | |||
1570 | inode->i_ctime = inode->i_mtime = CURRENT_TIME; | ||
1571 | |||
1572 | if (page->index < I0_BLOCKS) | ||
1573 | return logfs_write_direct(inode, page, flags); | ||
1574 | return logfs_write_rec(inode, page, page->index, 0, flags); | ||
1575 | } | ||
1576 | |||
1577 | int logfs_delete(struct inode *inode, pgoff_t index, | ||
1578 | struct shadow_tree *shadow_tree) | ||
1579 | { | ||
1580 | struct super_block *sb = inode->i_sb; | ||
1581 | struct page *page; | ||
1582 | int ret; | ||
1583 | |||
1584 | page = logfs_get_read_page(inode, index, 0); | ||
1585 | if (!page) | ||
1586 | return -ENOMEM; | ||
1587 | |||
1588 | logfs_get_wblocks(sb, page, 1); | ||
1589 | ret = __logfs_delete(inode, page); | ||
1590 | logfs_put_wblocks(sb, page, 1); | ||
1591 | |||
1592 | logfs_put_read_page(page); | ||
1593 | |||
1594 | return ret; | ||
1595 | } | ||
1596 | |||
1597 | /* Rewrite cannot mark the inode dirty but has to write it immediatly. */ | ||
1598 | int logfs_rewrite_block(struct inode *inode, u64 bix, u64 ofs, | ||
1599 | gc_level_t gc_level, long flags) | ||
1600 | { | ||
1601 | level_t level = shrink_level(gc_level); | ||
1602 | struct page *page; | ||
1603 | int err; | ||
1604 | |||
1605 | page = logfs_get_write_page(inode, bix, level); | ||
1606 | if (!page) | ||
1607 | return -ENOMEM; | ||
1608 | |||
1609 | err = logfs_segment_read(inode, page, ofs, bix, level); | ||
1610 | if (!err) { | ||
1611 | if (level != 0) | ||
1612 | alloc_indirect_block(inode, page, 0); | ||
1613 | err = logfs_write_buf(inode, page, flags); | ||
1614 | } | ||
1615 | logfs_put_write_page(page); | ||
1616 | return err; | ||
1617 | } | ||
1618 | |||
1619 | static int truncate_data_block(struct inode *inode, struct page *page, | ||
1620 | u64 ofs, struct logfs_shadow *shadow, u64 size) | ||
1621 | { | ||
1622 | loff_t pageofs = page->index << inode->i_sb->s_blocksize_bits; | ||
1623 | u64 bix; | ||
1624 | level_t level; | ||
1625 | int err; | ||
1626 | |||
1627 | /* Does truncation happen within this page? */ | ||
1628 | if (size <= pageofs || size - pageofs >= PAGE_SIZE) | ||
1629 | return 0; | ||
1630 | |||
1631 | logfs_unpack_index(page->index, &bix, &level); | ||
1632 | BUG_ON(level != 0); | ||
1633 | |||
1634 | err = logfs_segment_read(inode, page, ofs, bix, level); | ||
1635 | if (err) | ||
1636 | return err; | ||
1637 | |||
1638 | zero_user_segment(page, size - pageofs, PAGE_CACHE_SIZE); | ||
1639 | return logfs_segment_write(inode, page, shadow); | ||
1640 | } | ||
1641 | |||
1642 | static int logfs_truncate_i0(struct inode *inode, struct page *page, | ||
1643 | struct write_control *wc, u64 size) | ||
1644 | { | ||
1645 | struct logfs_shadow *shadow; | ||
1646 | u64 bix; | ||
1647 | level_t level; | ||
1648 | int err = 0; | ||
1649 | |||
1650 | logfs_unpack_index(page->index, &bix, &level); | ||
1651 | BUG_ON(level != 0); | ||
1652 | shadow = alloc_shadow(inode, bix, level, wc->ofs); | ||
1653 | |||
1654 | err = truncate_data_block(inode, page, wc->ofs, shadow, size); | ||
1655 | if (err) { | ||
1656 | free_shadow(inode, shadow); | ||
1657 | return err; | ||
1658 | } | ||
1659 | |||
1660 | logfs_segment_delete(inode, shadow); | ||
1661 | set_iused(inode, shadow); | ||
1662 | fill_shadow_tree(inode, page, shadow); | ||
1663 | wc->ofs = shadow->new_ofs; | ||
1664 | return 0; | ||
1665 | } | ||
1666 | |||
1667 | static int logfs_truncate_direct(struct inode *inode, u64 size) | ||
1668 | { | ||
1669 | struct logfs_inode *li = logfs_inode(inode); | ||
1670 | struct write_control wc; | ||
1671 | struct page *page; | ||
1672 | int e; | ||
1673 | int err; | ||
1674 | |||
1675 | alloc_inode_block(inode); | ||
1676 | |||
1677 | for (e = I0_BLOCKS - 1; e >= 0; e--) { | ||
1678 | if (size > (e+1) * LOGFS_BLOCKSIZE) | ||
1679 | break; | ||
1680 | |||
1681 | wc.ofs = li->li_data[e]; | ||
1682 | if (!wc.ofs) | ||
1683 | continue; | ||
1684 | |||
1685 | page = logfs_get_write_page(inode, e, 0); | ||
1686 | if (!page) | ||
1687 | return -ENOMEM; | ||
1688 | err = logfs_segment_read(inode, page, wc.ofs, e, 0); | ||
1689 | if (err) { | ||
1690 | logfs_put_write_page(page); | ||
1691 | return err; | ||
1692 | } | ||
1693 | err = logfs_truncate_i0(inode, page, &wc, size); | ||
1694 | logfs_put_write_page(page); | ||
1695 | if (err) | ||
1696 | return err; | ||
1697 | |||
1698 | li->li_data[e] = wc.ofs; | ||
1699 | } | ||
1700 | return 0; | ||
1701 | } | ||
1702 | |||
1703 | /* FIXME: these need to become per-sb once we support different blocksizes */ | ||
1704 | static u64 __logfs_step[] = { | ||
1705 | 1, | ||
1706 | I1_BLOCKS, | ||
1707 | I2_BLOCKS, | ||
1708 | I3_BLOCKS, | ||
1709 | }; | ||
1710 | |||
1711 | static u64 __logfs_start_index[] = { | ||
1712 | I0_BLOCKS, | ||
1713 | I1_BLOCKS, | ||
1714 | I2_BLOCKS, | ||
1715 | I3_BLOCKS | ||
1716 | }; | ||
1717 | |||
1718 | static inline u64 logfs_step(level_t level) | ||
1719 | { | ||
1720 | return __logfs_step[(__force u8)level]; | ||
1721 | } | ||
1722 | |||
1723 | static inline u64 logfs_factor(u8 level) | ||
1724 | { | ||
1725 | return __logfs_step[level] * LOGFS_BLOCKSIZE; | ||
1726 | } | ||
1727 | |||
1728 | static inline u64 logfs_start_index(level_t level) | ||
1729 | { | ||
1730 | return __logfs_start_index[(__force u8)level]; | ||
1731 | } | ||
1732 | |||
1733 | static void logfs_unpack_raw_index(pgoff_t index, u64 *bix, level_t *level) | ||
1734 | { | ||
1735 | logfs_unpack_index(index, bix, level); | ||
1736 | if (*bix <= logfs_start_index(SUBLEVEL(*level))) | ||
1737 | *bix = 0; | ||
1738 | } | ||
1739 | |||
1740 | static int __logfs_truncate_rec(struct inode *inode, struct page *ipage, | ||
1741 | struct write_control *this_wc, u64 size) | ||
1742 | { | ||
1743 | int truncate_happened = 0; | ||
1744 | int e, err = 0; | ||
1745 | u64 bix, child_bix, next_bix; | ||
1746 | level_t level; | ||
1747 | struct page *page; | ||
1748 | struct write_control child_wc = { /* FIXME: flags */ }; | ||
1749 | |||
1750 | logfs_unpack_raw_index(ipage->index, &bix, &level); | ||
1751 | err = logfs_segment_read(inode, ipage, this_wc->ofs, bix, level); | ||
1752 | if (err) | ||
1753 | return err; | ||
1754 | |||
1755 | for (e = LOGFS_BLOCK_FACTOR - 1; e >= 0; e--) { | ||
1756 | child_bix = bix + e * logfs_step(SUBLEVEL(level)); | ||
1757 | next_bix = child_bix + logfs_step(SUBLEVEL(level)); | ||
1758 | if (size > next_bix * LOGFS_BLOCKSIZE) | ||
1759 | break; | ||
1760 | |||
1761 | child_wc.ofs = pure_ofs(block_get_pointer(ipage, e)); | ||
1762 | if (!child_wc.ofs) | ||
1763 | continue; | ||
1764 | |||
1765 | page = logfs_get_write_page(inode, child_bix, SUBLEVEL(level)); | ||
1766 | if (!page) | ||
1767 | return -ENOMEM; | ||
1768 | |||
1769 | if ((__force u8)level > 1) | ||
1770 | err = __logfs_truncate_rec(inode, page, &child_wc, size); | ||
1771 | else | ||
1772 | err = logfs_truncate_i0(inode, page, &child_wc, size); | ||
1773 | logfs_put_write_page(page); | ||
1774 | if (err) | ||
1775 | return err; | ||
1776 | |||
1777 | truncate_happened = 1; | ||
1778 | alloc_indirect_block(inode, ipage, 0); | ||
1779 | block_set_pointer(ipage, e, child_wc.ofs); | ||
1780 | } | ||
1781 | |||
1782 | if (!truncate_happened) { | ||
1783 | printk("ineffectual truncate (%lx, %lx, %llx)\n", inode->i_ino, ipage->index, size); | ||
1784 | return 0; | ||
1785 | } | ||
1786 | |||
1787 | this_wc->flags = WF_DELETE; | ||
1788 | if (logfs_block(ipage)->partial) | ||
1789 | this_wc->flags |= WF_WRITE; | ||
1790 | |||
1791 | return logfs_write_i0(inode, ipage, this_wc); | ||
1792 | } | ||
1793 | |||
1794 | static int logfs_truncate_rec(struct inode *inode, u64 size) | ||
1795 | { | ||
1796 | struct logfs_inode *li = logfs_inode(inode); | ||
1797 | struct write_control wc = { | ||
1798 | .ofs = li->li_data[INDIRECT_INDEX], | ||
1799 | }; | ||
1800 | struct page *page; | ||
1801 | int err; | ||
1802 | |||
1803 | alloc_inode_block(inode); | ||
1804 | |||
1805 | if (!wc.ofs) | ||
1806 | return 0; | ||
1807 | |||
1808 | page = logfs_get_write_page(inode, 0, LEVEL(li->li_height)); | ||
1809 | if (!page) | ||
1810 | return -ENOMEM; | ||
1811 | |||
1812 | err = __logfs_truncate_rec(inode, page, &wc, size); | ||
1813 | logfs_put_write_page(page); | ||
1814 | if (err) | ||
1815 | return err; | ||
1816 | |||
1817 | if (li->li_data[INDIRECT_INDEX] != wc.ofs) | ||
1818 | li->li_data[INDIRECT_INDEX] = wc.ofs; | ||
1819 | return 0; | ||
1820 | } | ||
1821 | |||
1822 | static int __logfs_truncate(struct inode *inode, u64 size) | ||
1823 | { | ||
1824 | int ret; | ||
1825 | |||
1826 | if (size >= logfs_factor(logfs_inode(inode)->li_height)) | ||
1827 | return 0; | ||
1828 | |||
1829 | ret = logfs_truncate_rec(inode, size); | ||
1830 | if (ret) | ||
1831 | return ret; | ||
1832 | |||
1833 | return logfs_truncate_direct(inode, size); | ||
1834 | } | ||
1835 | |||
1836 | int logfs_truncate(struct inode *inode, u64 size) | ||
1837 | { | ||
1838 | struct super_block *sb = inode->i_sb; | ||
1839 | int err; | ||
1840 | |||
1841 | logfs_get_wblocks(sb, NULL, 1); | ||
1842 | err = __logfs_truncate(inode, size); | ||
1843 | if (!err) | ||
1844 | err = __logfs_write_inode(inode, 0); | ||
1845 | logfs_put_wblocks(sb, NULL, 1); | ||
1846 | |||
1847 | if (!err) | ||
1848 | err = vmtruncate(inode, size); | ||
1849 | |||
1850 | /* I don't trust error recovery yet. */ | ||
1851 | WARN_ON(err); | ||
1852 | return err; | ||
1853 | } | ||
1854 | |||
1855 | static void move_page_to_inode(struct inode *inode, struct page *page) | ||
1856 | { | ||
1857 | struct logfs_inode *li = logfs_inode(inode); | ||
1858 | struct logfs_block *block = logfs_block(page); | ||
1859 | |||
1860 | if (!block) | ||
1861 | return; | ||
1862 | |||
1863 | log_blockmove("move_page_to_inode(%llx, %llx, %x)\n", | ||
1864 | block->ino, block->bix, block->level); | ||
1865 | BUG_ON(li->li_block); | ||
1866 | block->ops = &inode_block_ops; | ||
1867 | block->inode = inode; | ||
1868 | li->li_block = block; | ||
1869 | |||
1870 | block->page = NULL; | ||
1871 | page->private = 0; | ||
1872 | ClearPagePrivate(page); | ||
1873 | } | ||
1874 | |||
1875 | static void move_inode_to_page(struct page *page, struct inode *inode) | ||
1876 | { | ||
1877 | struct logfs_inode *li = logfs_inode(inode); | ||
1878 | struct logfs_block *block = li->li_block; | ||
1879 | |||
1880 | if (!block) | ||
1881 | return; | ||
1882 | |||
1883 | log_blockmove("move_inode_to_page(%llx, %llx, %x)\n", | ||
1884 | block->ino, block->bix, block->level); | ||
1885 | BUG_ON(PagePrivate(page)); | ||
1886 | block->ops = &indirect_block_ops; | ||
1887 | block->page = page; | ||
1888 | page->private = (unsigned long)block; | ||
1889 | SetPagePrivate(page); | ||
1890 | |||
1891 | block->inode = NULL; | ||
1892 | li->li_block = NULL; | ||
1893 | } | ||
1894 | |||
1895 | int logfs_read_inode(struct inode *inode) | ||
1896 | { | ||
1897 | struct super_block *sb = inode->i_sb; | ||
1898 | struct logfs_super *super = logfs_super(sb); | ||
1899 | struct inode *master_inode = super->s_master_inode; | ||
1900 | struct page *page; | ||
1901 | struct logfs_disk_inode *di; | ||
1902 | u64 ino = inode->i_ino; | ||
1903 | |||
1904 | if (ino << sb->s_blocksize_bits > i_size_read(master_inode)) | ||
1905 | return -ENODATA; | ||
1906 | if (!logfs_exist_block(master_inode, ino)) | ||
1907 | return -ENODATA; | ||
1908 | |||
1909 | page = read_cache_page(master_inode->i_mapping, ino, | ||
1910 | (filler_t *)logfs_readpage, NULL); | ||
1911 | if (IS_ERR(page)) | ||
1912 | return PTR_ERR(page); | ||
1913 | |||
1914 | di = kmap_atomic(page, KM_USER0); | ||
1915 | logfs_disk_to_inode(di, inode); | ||
1916 | kunmap_atomic(di, KM_USER0); | ||
1917 | move_page_to_inode(inode, page); | ||
1918 | page_cache_release(page); | ||
1919 | return 0; | ||
1920 | } | ||
1921 | |||
1922 | /* Caller must logfs_put_write_page(page); */ | ||
1923 | static struct page *inode_to_page(struct inode *inode) | ||
1924 | { | ||
1925 | struct inode *master_inode = logfs_super(inode->i_sb)->s_master_inode; | ||
1926 | struct logfs_disk_inode *di; | ||
1927 | struct page *page; | ||
1928 | |||
1929 | BUG_ON(inode->i_ino == LOGFS_INO_MASTER); | ||
1930 | |||
1931 | page = logfs_get_write_page(master_inode, inode->i_ino, 0); | ||
1932 | if (!page) | ||
1933 | return NULL; | ||
1934 | |||
1935 | di = kmap_atomic(page, KM_USER0); | ||
1936 | logfs_inode_to_disk(inode, di); | ||
1937 | kunmap_atomic(di, KM_USER0); | ||
1938 | move_inode_to_page(page, inode); | ||
1939 | return page; | ||
1940 | } | ||
1941 | |||
1942 | /* Cheaper version of write_inode. All changes are concealed in | ||
1943 | * aliases, which are moved back. No write to the medium happens. | ||
1944 | */ | ||
1945 | void logfs_clear_inode(struct inode *inode) | ||
1946 | { | ||
1947 | struct super_block *sb = inode->i_sb; | ||
1948 | struct logfs_inode *li = logfs_inode(inode); | ||
1949 | struct logfs_block *block = li->li_block; | ||
1950 | struct page *page; | ||
1951 | |||
1952 | /* Only deleted files may be dirty at this point */ | ||
1953 | BUG_ON(inode->i_state & I_DIRTY && inode->i_nlink); | ||
1954 | if (!block) | ||
1955 | return; | ||
1956 | if ((logfs_super(sb)->s_flags & LOGFS_SB_FLAG_SHUTDOWN)) { | ||
1957 | block->ops->free_block(inode->i_sb, block); | ||
1958 | return; | ||
1959 | } | ||
1960 | |||
1961 | BUG_ON(inode->i_ino < LOGFS_RESERVED_INOS); | ||
1962 | page = inode_to_page(inode); | ||
1963 | BUG_ON(!page); /* FIXME: Use emergency page */ | ||
1964 | logfs_put_write_page(page); | ||
1965 | } | ||
1966 | |||
1967 | static int do_write_inode(struct inode *inode) | ||
1968 | { | ||
1969 | struct super_block *sb = inode->i_sb; | ||
1970 | struct inode *master_inode = logfs_super(sb)->s_master_inode; | ||
1971 | loff_t size = (inode->i_ino + 1) << inode->i_sb->s_blocksize_bits; | ||
1972 | struct page *page; | ||
1973 | int err; | ||
1974 | |||
1975 | BUG_ON(inode->i_ino == LOGFS_INO_MASTER); | ||
1976 | /* FIXME: lock inode */ | ||
1977 | |||
1978 | if (i_size_read(master_inode) < size) | ||
1979 | i_size_write(master_inode, size); | ||
1980 | |||
1981 | /* TODO: Tell vfs this inode is clean now */ | ||
1982 | |||
1983 | page = inode_to_page(inode); | ||
1984 | if (!page) | ||
1985 | return -ENOMEM; | ||
1986 | |||
1987 | /* FIXME: transaction is part of logfs_block now. Is that enough? */ | ||
1988 | err = logfs_write_buf(master_inode, page, 0); | ||
1989 | logfs_put_write_page(page); | ||
1990 | return err; | ||
1991 | } | ||
1992 | |||
1993 | static void logfs_mod_segment_entry(struct super_block *sb, u32 segno, | ||
1994 | int write, | ||
1995 | void (*change_se)(struct logfs_segment_entry *, long), | ||
1996 | long arg) | ||
1997 | { | ||
1998 | struct logfs_super *super = logfs_super(sb); | ||
1999 | struct inode *inode; | ||
2000 | struct page *page; | ||
2001 | struct logfs_segment_entry *se; | ||
2002 | pgoff_t page_no; | ||
2003 | int child_no; | ||
2004 | |||
2005 | page_no = segno >> (sb->s_blocksize_bits - 3); | ||
2006 | child_no = segno & ((sb->s_blocksize >> 3) - 1); | ||
2007 | |||
2008 | inode = super->s_segfile_inode; | ||
2009 | page = logfs_get_write_page(inode, page_no, 0); | ||
2010 | BUG_ON(!page); /* FIXME: We need some reserve page for this case */ | ||
2011 | if (!PageUptodate(page)) | ||
2012 | logfs_read_block(inode, page, WRITE); | ||
2013 | |||
2014 | if (write) | ||
2015 | alloc_indirect_block(inode, page, 0); | ||
2016 | se = kmap_atomic(page, KM_USER0); | ||
2017 | change_se(se + child_no, arg); | ||
2018 | if (write) { | ||
2019 | logfs_set_alias(sb, logfs_block(page), child_no); | ||
2020 | BUG_ON((int)be32_to_cpu(se[child_no].valid) > super->s_segsize); | ||
2021 | } | ||
2022 | kunmap_atomic(se, KM_USER0); | ||
2023 | |||
2024 | logfs_put_write_page(page); | ||
2025 | } | ||
2026 | |||
2027 | static void __get_segment_entry(struct logfs_segment_entry *se, long _target) | ||
2028 | { | ||
2029 | struct logfs_segment_entry *target = (void *)_target; | ||
2030 | |||
2031 | *target = *se; | ||
2032 | } | ||
2033 | |||
2034 | void logfs_get_segment_entry(struct super_block *sb, u32 segno, | ||
2035 | struct logfs_segment_entry *se) | ||
2036 | { | ||
2037 | logfs_mod_segment_entry(sb, segno, 0, __get_segment_entry, (long)se); | ||
2038 | } | ||
2039 | |||
2040 | static void __set_segment_used(struct logfs_segment_entry *se, long increment) | ||
2041 | { | ||
2042 | u32 valid; | ||
2043 | |||
2044 | valid = be32_to_cpu(se->valid); | ||
2045 | valid += increment; | ||
2046 | se->valid = cpu_to_be32(valid); | ||
2047 | } | ||
2048 | |||
2049 | void logfs_set_segment_used(struct super_block *sb, u64 ofs, int increment) | ||
2050 | { | ||
2051 | struct logfs_super *super = logfs_super(sb); | ||
2052 | u32 segno = ofs >> super->s_segshift; | ||
2053 | |||
2054 | if (!increment) | ||
2055 | return; | ||
2056 | |||
2057 | logfs_mod_segment_entry(sb, segno, 1, __set_segment_used, increment); | ||
2058 | } | ||
2059 | |||
2060 | static void __set_segment_erased(struct logfs_segment_entry *se, long ec_level) | ||
2061 | { | ||
2062 | se->ec_level = cpu_to_be32(ec_level); | ||
2063 | } | ||
2064 | |||
2065 | void logfs_set_segment_erased(struct super_block *sb, u32 segno, u32 ec, | ||
2066 | gc_level_t gc_level) | ||
2067 | { | ||
2068 | u32 ec_level = ec << 4 | (__force u8)gc_level; | ||
2069 | |||
2070 | logfs_mod_segment_entry(sb, segno, 1, __set_segment_erased, ec_level); | ||
2071 | } | ||
2072 | |||
2073 | static void __set_segment_reserved(struct logfs_segment_entry *se, long ignore) | ||
2074 | { | ||
2075 | se->valid = cpu_to_be32(RESERVED); | ||
2076 | } | ||
2077 | |||
2078 | void logfs_set_segment_reserved(struct super_block *sb, u32 segno) | ||
2079 | { | ||
2080 | logfs_mod_segment_entry(sb, segno, 1, __set_segment_reserved, 0); | ||
2081 | } | ||
2082 | |||
2083 | static void __set_segment_unreserved(struct logfs_segment_entry *se, | ||
2084 | long ec_level) | ||
2085 | { | ||
2086 | se->valid = 0; | ||
2087 | se->ec_level = cpu_to_be32(ec_level); | ||
2088 | } | ||
2089 | |||
2090 | void logfs_set_segment_unreserved(struct super_block *sb, u32 segno, u32 ec) | ||
2091 | { | ||
2092 | u32 ec_level = ec << 4; | ||
2093 | |||
2094 | logfs_mod_segment_entry(sb, segno, 1, __set_segment_unreserved, | ||
2095 | ec_level); | ||
2096 | } | ||
2097 | |||
2098 | int __logfs_write_inode(struct inode *inode, long flags) | ||
2099 | { | ||
2100 | struct super_block *sb = inode->i_sb; | ||
2101 | int ret; | ||
2102 | |||
2103 | logfs_get_wblocks(sb, NULL, flags & WF_LOCK); | ||
2104 | ret = do_write_inode(inode); | ||
2105 | logfs_put_wblocks(sb, NULL, flags & WF_LOCK); | ||
2106 | return ret; | ||
2107 | } | ||
2108 | |||
2109 | static int do_delete_inode(struct inode *inode) | ||
2110 | { | ||
2111 | struct super_block *sb = inode->i_sb; | ||
2112 | struct inode *master_inode = logfs_super(sb)->s_master_inode; | ||
2113 | struct page *page; | ||
2114 | int ret; | ||
2115 | |||
2116 | page = logfs_get_write_page(master_inode, inode->i_ino, 0); | ||
2117 | if (!page) | ||
2118 | return -ENOMEM; | ||
2119 | |||
2120 | move_inode_to_page(page, inode); | ||
2121 | |||
2122 | logfs_get_wblocks(sb, page, 1); | ||
2123 | ret = __logfs_delete(master_inode, page); | ||
2124 | logfs_put_wblocks(sb, page, 1); | ||
2125 | |||
2126 | logfs_put_write_page(page); | ||
2127 | return ret; | ||
2128 | } | ||
2129 | |||
2130 | /* | ||
2131 | * ZOMBIE inodes have already been deleted before and should remain dead, | ||
2132 | * if it weren't for valid checking. No need to kill them again here. | ||
2133 | */ | ||
2134 | void logfs_delete_inode(struct inode *inode) | ||
2135 | { | ||
2136 | struct logfs_inode *li = logfs_inode(inode); | ||
2137 | |||
2138 | if (!(li->li_flags & LOGFS_IF_ZOMBIE)) { | ||
2139 | li->li_flags |= LOGFS_IF_ZOMBIE; | ||
2140 | if (i_size_read(inode) > 0) | ||
2141 | logfs_truncate(inode, 0); | ||
2142 | do_delete_inode(inode); | ||
2143 | } | ||
2144 | truncate_inode_pages(&inode->i_data, 0); | ||
2145 | clear_inode(inode); | ||
2146 | } | ||
2147 | |||
2148 | void btree_write_block(struct logfs_block *block) | ||
2149 | { | ||
2150 | struct inode *inode; | ||
2151 | struct page *page; | ||
2152 | int err, cookie; | ||
2153 | |||
2154 | inode = logfs_safe_iget(block->sb, block->ino, &cookie); | ||
2155 | page = logfs_get_write_page(inode, block->bix, block->level); | ||
2156 | |||
2157 | err = logfs_readpage_nolock(page); | ||
2158 | BUG_ON(err); | ||
2159 | BUG_ON(!PagePrivate(page)); | ||
2160 | BUG_ON(logfs_block(page) != block); | ||
2161 | err = __logfs_write_buf(inode, page, 0); | ||
2162 | BUG_ON(err); | ||
2163 | BUG_ON(PagePrivate(page) || page->private); | ||
2164 | |||
2165 | logfs_put_write_page(page); | ||
2166 | logfs_safe_iput(inode, cookie); | ||
2167 | } | ||
2168 | |||
2169 | /** | ||
2170 | * logfs_inode_write - write inode or dentry objects | ||
2171 | * | ||
2172 | * @inode: parent inode (ifile or directory) | ||
2173 | * @buf: object to write (inode or dentry) | ||
2174 | * @n: object size | ||
2175 | * @_pos: object number (file position in blocks/objects) | ||
2176 | * @flags: write flags | ||
2177 | * @lock: 0 if write lock is already taken, 1 otherwise | ||
2178 | * @shadow_tree: shadow below this inode | ||
2179 | * | ||
2180 | * FIXME: All caller of this put a 200-300 byte variable on the stack, | ||
2181 | * only to call here and do a memcpy from that stack variable. A good | ||
2182 | * example of wasted performance and stack space. | ||
2183 | */ | ||
2184 | int logfs_inode_write(struct inode *inode, const void *buf, size_t count, | ||
2185 | loff_t bix, long flags, struct shadow_tree *shadow_tree) | ||
2186 | { | ||
2187 | loff_t pos = bix << inode->i_sb->s_blocksize_bits; | ||
2188 | int err; | ||
2189 | struct page *page; | ||
2190 | void *pagebuf; | ||
2191 | |||
2192 | BUG_ON(pos & (LOGFS_BLOCKSIZE-1)); | ||
2193 | BUG_ON(count > LOGFS_BLOCKSIZE); | ||
2194 | page = logfs_get_write_page(inode, bix, 0); | ||
2195 | if (!page) | ||
2196 | return -ENOMEM; | ||
2197 | |||
2198 | pagebuf = kmap_atomic(page, KM_USER0); | ||
2199 | memcpy(pagebuf, buf, count); | ||
2200 | flush_dcache_page(page); | ||
2201 | kunmap_atomic(pagebuf, KM_USER0); | ||
2202 | |||
2203 | if (i_size_read(inode) < pos + LOGFS_BLOCKSIZE) | ||
2204 | i_size_write(inode, pos + LOGFS_BLOCKSIZE); | ||
2205 | |||
2206 | err = logfs_write_buf(inode, page, flags); | ||
2207 | logfs_put_write_page(page); | ||
2208 | return err; | ||
2209 | } | ||
2210 | |||
2211 | int logfs_open_segfile(struct super_block *sb) | ||
2212 | { | ||
2213 | struct logfs_super *super = logfs_super(sb); | ||
2214 | struct inode *inode; | ||
2215 | |||
2216 | inode = logfs_read_meta_inode(sb, LOGFS_INO_SEGFILE); | ||
2217 | if (IS_ERR(inode)) | ||
2218 | return PTR_ERR(inode); | ||
2219 | super->s_segfile_inode = inode; | ||
2220 | return 0; | ||
2221 | } | ||
2222 | |||
2223 | int logfs_init_rw(struct super_block *sb) | ||
2224 | { | ||
2225 | struct logfs_super *super = logfs_super(sb); | ||
2226 | int min_fill = 3 * super->s_no_blocks; | ||
2227 | |||
2228 | INIT_LIST_HEAD(&super->s_object_alias); | ||
2229 | mutex_init(&super->s_write_mutex); | ||
2230 | super->s_block_pool = mempool_create_kmalloc_pool(min_fill, | ||
2231 | sizeof(struct logfs_block)); | ||
2232 | super->s_shadow_pool = mempool_create_kmalloc_pool(min_fill, | ||
2233 | sizeof(struct logfs_shadow)); | ||
2234 | return 0; | ||
2235 | } | ||
2236 | |||
2237 | void logfs_cleanup_rw(struct super_block *sb) | ||
2238 | { | ||
2239 | struct logfs_super *super = logfs_super(sb); | ||
2240 | |||
2241 | destroy_meta_inode(super->s_segfile_inode); | ||
2242 | if (super->s_block_pool) | ||
2243 | mempool_destroy(super->s_block_pool); | ||
2244 | if (super->s_shadow_pool) | ||
2245 | mempool_destroy(super->s_shadow_pool); | ||
2246 | } | ||
diff --git a/fs/logfs/segment.c b/fs/logfs/segment.c new file mode 100644 index 000000000000..1a14f9910d55 --- /dev/null +++ b/fs/logfs/segment.c | |||
@@ -0,0 +1,927 @@ | |||
1 | /* | ||
2 | * fs/logfs/segment.c - Handling the Object Store | ||
3 | * | ||
4 | * As should be obvious for Linux kernel code, license is GPLv2 | ||
5 | * | ||
6 | * Copyright (c) 2005-2008 Joern Engel <joern@logfs.org> | ||
7 | * | ||
8 | * Object store or ostore makes up the complete device with exception of | ||
9 | * the superblock and journal areas. Apart from its own metadata it stores | ||
10 | * three kinds of objects: inodes, dentries and blocks, both data and indirect. | ||
11 | */ | ||
12 | #include "logfs.h" | ||
13 | |||
14 | static int logfs_mark_segment_bad(struct super_block *sb, u32 segno) | ||
15 | { | ||
16 | struct logfs_super *super = logfs_super(sb); | ||
17 | struct btree_head32 *head = &super->s_reserved_segments; | ||
18 | int err; | ||
19 | |||
20 | err = btree_insert32(head, segno, (void *)1, GFP_NOFS); | ||
21 | if (err) | ||
22 | return err; | ||
23 | logfs_super(sb)->s_bad_segments++; | ||
24 | /* FIXME: write to journal */ | ||
25 | return 0; | ||
26 | } | ||
27 | |||
28 | int logfs_erase_segment(struct super_block *sb, u32 segno, int ensure_erase) | ||
29 | { | ||
30 | struct logfs_super *super = logfs_super(sb); | ||
31 | |||
32 | super->s_gec++; | ||
33 | |||
34 | return super->s_devops->erase(sb, (u64)segno << super->s_segshift, | ||
35 | super->s_segsize, ensure_erase); | ||
36 | } | ||
37 | |||
38 | static s64 logfs_get_free_bytes(struct logfs_area *area, size_t bytes) | ||
39 | { | ||
40 | s32 ofs; | ||
41 | |||
42 | logfs_open_area(area, bytes); | ||
43 | |||
44 | ofs = area->a_used_bytes; | ||
45 | area->a_used_bytes += bytes; | ||
46 | BUG_ON(area->a_used_bytes >= logfs_super(area->a_sb)->s_segsize); | ||
47 | |||
48 | return dev_ofs(area->a_sb, area->a_segno, ofs); | ||
49 | } | ||
50 | |||
51 | static struct page *get_mapping_page(struct super_block *sb, pgoff_t index, | ||
52 | int use_filler) | ||
53 | { | ||
54 | struct logfs_super *super = logfs_super(sb); | ||
55 | struct address_space *mapping = super->s_mapping_inode->i_mapping; | ||
56 | filler_t *filler = super->s_devops->readpage; | ||
57 | struct page *page; | ||
58 | |||
59 | BUG_ON(mapping_gfp_mask(mapping) & __GFP_FS); | ||
60 | if (use_filler) | ||
61 | page = read_cache_page(mapping, index, filler, sb); | ||
62 | else { | ||
63 | page = find_or_create_page(mapping, index, GFP_NOFS); | ||
64 | unlock_page(page); | ||
65 | } | ||
66 | return page; | ||
67 | } | ||
68 | |||
69 | void __logfs_buf_write(struct logfs_area *area, u64 ofs, void *buf, size_t len, | ||
70 | int use_filler) | ||
71 | { | ||
72 | pgoff_t index = ofs >> PAGE_SHIFT; | ||
73 | struct page *page; | ||
74 | long offset = ofs & (PAGE_SIZE-1); | ||
75 | long copylen; | ||
76 | |||
77 | /* Only logfs_wbuf_recover may use len==0 */ | ||
78 | BUG_ON(!len && !use_filler); | ||
79 | do { | ||
80 | copylen = min((ulong)len, PAGE_SIZE - offset); | ||
81 | |||
82 | page = get_mapping_page(area->a_sb, index, use_filler); | ||
83 | SetPageUptodate(page); | ||
84 | BUG_ON(!page); /* FIXME: reserve a pool */ | ||
85 | memcpy(page_address(page) + offset, buf, copylen); | ||
86 | SetPagePrivate(page); | ||
87 | page_cache_release(page); | ||
88 | |||
89 | buf += copylen; | ||
90 | len -= copylen; | ||
91 | offset = 0; | ||
92 | index++; | ||
93 | } while (len); | ||
94 | } | ||
95 | |||
96 | /* | ||
97 | * bdev_writeseg will write full pages. Memset the tail to prevent data leaks. | ||
98 | */ | ||
99 | static void pad_wbuf(struct logfs_area *area, int final) | ||
100 | { | ||
101 | struct super_block *sb = area->a_sb; | ||
102 | struct logfs_super *super = logfs_super(sb); | ||
103 | struct page *page; | ||
104 | u64 ofs = dev_ofs(sb, area->a_segno, area->a_used_bytes); | ||
105 | pgoff_t index = ofs >> PAGE_SHIFT; | ||
106 | long offset = ofs & (PAGE_SIZE-1); | ||
107 | u32 len = PAGE_SIZE - offset; | ||
108 | |||
109 | if (len == PAGE_SIZE) { | ||
110 | /* The math in this function can surely use some love */ | ||
111 | len = 0; | ||
112 | } | ||
113 | if (len) { | ||
114 | BUG_ON(area->a_used_bytes >= super->s_segsize); | ||
115 | |||
116 | page = get_mapping_page(area->a_sb, index, 0); | ||
117 | BUG_ON(!page); /* FIXME: reserve a pool */ | ||
118 | memset(page_address(page) + offset, 0xff, len); | ||
119 | SetPagePrivate(page); | ||
120 | page_cache_release(page); | ||
121 | } | ||
122 | |||
123 | if (!final) | ||
124 | return; | ||
125 | |||
126 | area->a_used_bytes += len; | ||
127 | for ( ; area->a_used_bytes < super->s_segsize; | ||
128 | area->a_used_bytes += PAGE_SIZE) { | ||
129 | /* Memset another page */ | ||
130 | index++; | ||
131 | page = get_mapping_page(area->a_sb, index, 0); | ||
132 | BUG_ON(!page); /* FIXME: reserve a pool */ | ||
133 | memset(page_address(page), 0xff, PAGE_SIZE); | ||
134 | SetPagePrivate(page); | ||
135 | page_cache_release(page); | ||
136 | } | ||
137 | } | ||
138 | |||
139 | /* | ||
140 | * We have to be careful with the alias tree. Since lookup is done by bix, | ||
141 | * it needs to be normalized, so 14, 15, 16, etc. all match when dealing with | ||
142 | * indirect blocks. So always use it through accessor functions. | ||
143 | */ | ||
144 | static void *alias_tree_lookup(struct super_block *sb, u64 ino, u64 bix, | ||
145 | level_t level) | ||
146 | { | ||
147 | struct btree_head128 *head = &logfs_super(sb)->s_object_alias_tree; | ||
148 | pgoff_t index = logfs_pack_index(bix, level); | ||
149 | |||
150 | return btree_lookup128(head, ino, index); | ||
151 | } | ||
152 | |||
153 | static int alias_tree_insert(struct super_block *sb, u64 ino, u64 bix, | ||
154 | level_t level, void *val) | ||
155 | { | ||
156 | struct btree_head128 *head = &logfs_super(sb)->s_object_alias_tree; | ||
157 | pgoff_t index = logfs_pack_index(bix, level); | ||
158 | |||
159 | return btree_insert128(head, ino, index, val, GFP_NOFS); | ||
160 | } | ||
161 | |||
162 | static int btree_write_alias(struct super_block *sb, struct logfs_block *block, | ||
163 | write_alias_t *write_one_alias) | ||
164 | { | ||
165 | struct object_alias_item *item; | ||
166 | int err; | ||
167 | |||
168 | list_for_each_entry(item, &block->item_list, list) { | ||
169 | err = write_alias_journal(sb, block->ino, block->bix, | ||
170 | block->level, item->child_no, item->val); | ||
171 | if (err) | ||
172 | return err; | ||
173 | } | ||
174 | return 0; | ||
175 | } | ||
176 | |||
177 | static gc_level_t btree_block_level(struct logfs_block *block) | ||
178 | { | ||
179 | return expand_level(block->ino, block->level); | ||
180 | } | ||
181 | |||
182 | static struct logfs_block_ops btree_block_ops = { | ||
183 | .write_block = btree_write_block, | ||
184 | .block_level = btree_block_level, | ||
185 | .free_block = __free_block, | ||
186 | .write_alias = btree_write_alias, | ||
187 | }; | ||
188 | |||
189 | int logfs_load_object_aliases(struct super_block *sb, | ||
190 | struct logfs_obj_alias *oa, int count) | ||
191 | { | ||
192 | struct logfs_super *super = logfs_super(sb); | ||
193 | struct logfs_block *block; | ||
194 | struct object_alias_item *item; | ||
195 | u64 ino, bix; | ||
196 | level_t level; | ||
197 | int i, err; | ||
198 | |||
199 | super->s_flags |= LOGFS_SB_FLAG_OBJ_ALIAS; | ||
200 | count /= sizeof(*oa); | ||
201 | for (i = 0; i < count; i++) { | ||
202 | item = mempool_alloc(super->s_alias_pool, GFP_NOFS); | ||
203 | if (!item) | ||
204 | return -ENOMEM; | ||
205 | memset(item, 0, sizeof(*item)); | ||
206 | |||
207 | super->s_no_object_aliases++; | ||
208 | item->val = oa[i].val; | ||
209 | item->child_no = be16_to_cpu(oa[i].child_no); | ||
210 | |||
211 | ino = be64_to_cpu(oa[i].ino); | ||
212 | bix = be64_to_cpu(oa[i].bix); | ||
213 | level = LEVEL(oa[i].level); | ||
214 | |||
215 | log_aliases("logfs_load_object_aliases(%llx, %llx, %x, %x) %llx\n", | ||
216 | ino, bix, level, item->child_no, | ||
217 | be64_to_cpu(item->val)); | ||
218 | block = alias_tree_lookup(sb, ino, bix, level); | ||
219 | if (!block) { | ||
220 | block = __alloc_block(sb, ino, bix, level); | ||
221 | block->ops = &btree_block_ops; | ||
222 | err = alias_tree_insert(sb, ino, bix, level, block); | ||
223 | BUG_ON(err); /* mempool empty */ | ||
224 | } | ||
225 | if (test_and_set_bit(item->child_no, block->alias_map)) { | ||
226 | printk(KERN_ERR"LogFS: Alias collision detected\n"); | ||
227 | return -EIO; | ||
228 | } | ||
229 | list_move_tail(&block->alias_list, &super->s_object_alias); | ||
230 | list_add(&item->list, &block->item_list); | ||
231 | } | ||
232 | return 0; | ||
233 | } | ||
234 | |||
235 | static void kill_alias(void *_block, unsigned long ignore0, | ||
236 | u64 ignore1, u64 ignore2, size_t ignore3) | ||
237 | { | ||
238 | struct logfs_block *block = _block; | ||
239 | struct super_block *sb = block->sb; | ||
240 | struct logfs_super *super = logfs_super(sb); | ||
241 | struct object_alias_item *item; | ||
242 | |||
243 | while (!list_empty(&block->item_list)) { | ||
244 | item = list_entry(block->item_list.next, typeof(*item), list); | ||
245 | list_del(&item->list); | ||
246 | mempool_free(item, super->s_alias_pool); | ||
247 | } | ||
248 | block->ops->free_block(sb, block); | ||
249 | } | ||
250 | |||
251 | static int obj_type(struct inode *inode, level_t level) | ||
252 | { | ||
253 | if (level == 0) { | ||
254 | if (S_ISDIR(inode->i_mode)) | ||
255 | return OBJ_DENTRY; | ||
256 | if (inode->i_ino == LOGFS_INO_MASTER) | ||
257 | return OBJ_INODE; | ||
258 | } | ||
259 | return OBJ_BLOCK; | ||
260 | } | ||
261 | |||
262 | static int obj_len(struct super_block *sb, int obj_type) | ||
263 | { | ||
264 | switch (obj_type) { | ||
265 | case OBJ_DENTRY: | ||
266 | return sizeof(struct logfs_disk_dentry); | ||
267 | case OBJ_INODE: | ||
268 | return sizeof(struct logfs_disk_inode); | ||
269 | case OBJ_BLOCK: | ||
270 | return sb->s_blocksize; | ||
271 | default: | ||
272 | BUG(); | ||
273 | } | ||
274 | } | ||
275 | |||
276 | static int __logfs_segment_write(struct inode *inode, void *buf, | ||
277 | struct logfs_shadow *shadow, int type, int len, int compr) | ||
278 | { | ||
279 | struct logfs_area *area; | ||
280 | struct super_block *sb = inode->i_sb; | ||
281 | s64 ofs; | ||
282 | struct logfs_object_header h; | ||
283 | int acc_len; | ||
284 | |||
285 | if (shadow->gc_level == 0) | ||
286 | acc_len = len; | ||
287 | else | ||
288 | acc_len = obj_len(sb, type); | ||
289 | |||
290 | area = get_area(sb, shadow->gc_level); | ||
291 | ofs = logfs_get_free_bytes(area, len + LOGFS_OBJECT_HEADERSIZE); | ||
292 | LOGFS_BUG_ON(ofs <= 0, sb); | ||
293 | /* | ||
294 | * Order is important. logfs_get_free_bytes(), by modifying the | ||
295 | * segment file, may modify the content of the very page we're about | ||
296 | * to write now. Which is fine, as long as the calculated crc and | ||
297 | * written data still match. So do the modifications _before_ | ||
298 | * calculating the crc. | ||
299 | */ | ||
300 | |||
301 | h.len = cpu_to_be16(len); | ||
302 | h.type = type; | ||
303 | h.compr = compr; | ||
304 | h.ino = cpu_to_be64(inode->i_ino); | ||
305 | h.bix = cpu_to_be64(shadow->bix); | ||
306 | h.crc = logfs_crc32(&h, sizeof(h) - 4, 4); | ||
307 | h.data_crc = logfs_crc32(buf, len, 0); | ||
308 | |||
309 | logfs_buf_write(area, ofs, &h, sizeof(h)); | ||
310 | logfs_buf_write(area, ofs + LOGFS_OBJECT_HEADERSIZE, buf, len); | ||
311 | |||
312 | shadow->new_ofs = ofs; | ||
313 | shadow->new_len = acc_len + LOGFS_OBJECT_HEADERSIZE; | ||
314 | |||
315 | return 0; | ||
316 | } | ||
317 | |||
318 | static s64 logfs_segment_write_compress(struct inode *inode, void *buf, | ||
319 | struct logfs_shadow *shadow, int type, int len) | ||
320 | { | ||
321 | struct super_block *sb = inode->i_sb; | ||
322 | void *compressor_buf = logfs_super(sb)->s_compressed_je; | ||
323 | ssize_t compr_len; | ||
324 | int ret; | ||
325 | |||
326 | mutex_lock(&logfs_super(sb)->s_journal_mutex); | ||
327 | compr_len = logfs_compress(buf, compressor_buf, len, len); | ||
328 | |||
329 | if (compr_len >= 0) { | ||
330 | ret = __logfs_segment_write(inode, compressor_buf, shadow, | ||
331 | type, compr_len, COMPR_ZLIB); | ||
332 | } else { | ||
333 | ret = __logfs_segment_write(inode, buf, shadow, type, len, | ||
334 | COMPR_NONE); | ||
335 | } | ||
336 | mutex_unlock(&logfs_super(sb)->s_journal_mutex); | ||
337 | return ret; | ||
338 | } | ||
339 | |||
340 | /** | ||
341 | * logfs_segment_write - write data block to object store | ||
342 | * @inode: inode containing data | ||
343 | * | ||
344 | * Returns an errno or zero. | ||
345 | */ | ||
346 | int logfs_segment_write(struct inode *inode, struct page *page, | ||
347 | struct logfs_shadow *shadow) | ||
348 | { | ||
349 | struct super_block *sb = inode->i_sb; | ||
350 | struct logfs_super *super = logfs_super(sb); | ||
351 | int do_compress, type, len; | ||
352 | int ret; | ||
353 | void *buf; | ||
354 | |||
355 | super->s_flags |= LOGFS_SB_FLAG_DIRTY; | ||
356 | BUG_ON(super->s_flags & LOGFS_SB_FLAG_SHUTDOWN); | ||
357 | do_compress = logfs_inode(inode)->li_flags & LOGFS_IF_COMPRESSED; | ||
358 | if (shadow->gc_level != 0) { | ||
359 | /* temporarily disable compression for indirect blocks */ | ||
360 | do_compress = 0; | ||
361 | } | ||
362 | |||
363 | type = obj_type(inode, shrink_level(shadow->gc_level)); | ||
364 | len = obj_len(sb, type); | ||
365 | buf = kmap(page); | ||
366 | if (do_compress) | ||
367 | ret = logfs_segment_write_compress(inode, buf, shadow, type, | ||
368 | len); | ||
369 | else | ||
370 | ret = __logfs_segment_write(inode, buf, shadow, type, len, | ||
371 | COMPR_NONE); | ||
372 | kunmap(page); | ||
373 | |||
374 | log_segment("logfs_segment_write(%llx, %llx, %x) %llx->%llx %x->%x\n", | ||
375 | shadow->ino, shadow->bix, shadow->gc_level, | ||
376 | shadow->old_ofs, shadow->new_ofs, | ||
377 | shadow->old_len, shadow->new_len); | ||
378 | /* this BUG_ON did catch a locking bug. useful */ | ||
379 | BUG_ON(!(shadow->new_ofs & (super->s_segsize - 1))); | ||
380 | return ret; | ||
381 | } | ||
382 | |||
383 | int wbuf_read(struct super_block *sb, u64 ofs, size_t len, void *buf) | ||
384 | { | ||
385 | pgoff_t index = ofs >> PAGE_SHIFT; | ||
386 | struct page *page; | ||
387 | long offset = ofs & (PAGE_SIZE-1); | ||
388 | long copylen; | ||
389 | |||
390 | while (len) { | ||
391 | copylen = min((ulong)len, PAGE_SIZE - offset); | ||
392 | |||
393 | page = get_mapping_page(sb, index, 1); | ||
394 | if (IS_ERR(page)) | ||
395 | return PTR_ERR(page); | ||
396 | memcpy(buf, page_address(page) + offset, copylen); | ||
397 | page_cache_release(page); | ||
398 | |||
399 | buf += copylen; | ||
400 | len -= copylen; | ||
401 | offset = 0; | ||
402 | index++; | ||
403 | } | ||
404 | return 0; | ||
405 | } | ||
406 | |||
407 | /* | ||
408 | * The "position" of indirect blocks is ambiguous. It can be the position | ||
409 | * of any data block somewhere behind this indirect block. So we need to | ||
410 | * normalize the positions through logfs_block_mask() before comparing. | ||
411 | */ | ||
412 | static int check_pos(struct super_block *sb, u64 pos1, u64 pos2, level_t level) | ||
413 | { | ||
414 | return (pos1 & logfs_block_mask(sb, level)) != | ||
415 | (pos2 & logfs_block_mask(sb, level)); | ||
416 | } | ||
417 | |||
418 | #if 0 | ||
419 | static int read_seg_header(struct super_block *sb, u64 ofs, | ||
420 | struct logfs_segment_header *sh) | ||
421 | { | ||
422 | __be32 crc; | ||
423 | int err; | ||
424 | |||
425 | err = wbuf_read(sb, ofs, sizeof(*sh), sh); | ||
426 | if (err) | ||
427 | return err; | ||
428 | crc = logfs_crc32(sh, sizeof(*sh), 4); | ||
429 | if (crc != sh->crc) { | ||
430 | printk(KERN_ERR"LOGFS: header crc error at %llx: expected %x, " | ||
431 | "got %x\n", ofs, be32_to_cpu(sh->crc), | ||
432 | be32_to_cpu(crc)); | ||
433 | return -EIO; | ||
434 | } | ||
435 | return 0; | ||
436 | } | ||
437 | #endif | ||
438 | |||
439 | static int read_obj_header(struct super_block *sb, u64 ofs, | ||
440 | struct logfs_object_header *oh) | ||
441 | { | ||
442 | __be32 crc; | ||
443 | int err; | ||
444 | |||
445 | err = wbuf_read(sb, ofs, sizeof(*oh), oh); | ||
446 | if (err) | ||
447 | return err; | ||
448 | crc = logfs_crc32(oh, sizeof(*oh) - 4, 4); | ||
449 | if (crc != oh->crc) { | ||
450 | printk(KERN_ERR"LOGFS: header crc error at %llx: expected %x, " | ||
451 | "got %x\n", ofs, be32_to_cpu(oh->crc), | ||
452 | be32_to_cpu(crc)); | ||
453 | return -EIO; | ||
454 | } | ||
455 | return 0; | ||
456 | } | ||
457 | |||
458 | static void move_btree_to_page(struct inode *inode, struct page *page, | ||
459 | __be64 *data) | ||
460 | { | ||
461 | struct super_block *sb = inode->i_sb; | ||
462 | struct logfs_super *super = logfs_super(sb); | ||
463 | struct btree_head128 *head = &super->s_object_alias_tree; | ||
464 | struct logfs_block *block; | ||
465 | struct object_alias_item *item, *next; | ||
466 | |||
467 | if (!(super->s_flags & LOGFS_SB_FLAG_OBJ_ALIAS)) | ||
468 | return; | ||
469 | |||
470 | block = btree_remove128(head, inode->i_ino, page->index); | ||
471 | if (!block) | ||
472 | return; | ||
473 | |||
474 | log_blockmove("move_btree_to_page(%llx, %llx, %x)\n", | ||
475 | block->ino, block->bix, block->level); | ||
476 | list_for_each_entry_safe(item, next, &block->item_list, list) { | ||
477 | data[item->child_no] = item->val; | ||
478 | list_del(&item->list); | ||
479 | mempool_free(item, super->s_alias_pool); | ||
480 | } | ||
481 | block->page = page; | ||
482 | SetPagePrivate(page); | ||
483 | page->private = (unsigned long)block; | ||
484 | block->ops = &indirect_block_ops; | ||
485 | initialize_block_counters(page, block, data, 0); | ||
486 | } | ||
487 | |||
488 | /* | ||
489 | * This silences a false, yet annoying gcc warning. I hate it when my editor | ||
490 | * jumps into bitops.h each time I recompile this file. | ||
491 | * TODO: Complain to gcc folks about this and upgrade compiler. | ||
492 | */ | ||
493 | static unsigned long fnb(const unsigned long *addr, | ||
494 | unsigned long size, unsigned long offset) | ||
495 | { | ||
496 | return find_next_bit(addr, size, offset); | ||
497 | } | ||
498 | |||
499 | void move_page_to_btree(struct page *page) | ||
500 | { | ||
501 | struct logfs_block *block = logfs_block(page); | ||
502 | struct super_block *sb = block->sb; | ||
503 | struct logfs_super *super = logfs_super(sb); | ||
504 | struct object_alias_item *item; | ||
505 | unsigned long pos; | ||
506 | __be64 *child; | ||
507 | int err; | ||
508 | |||
509 | if (super->s_flags & LOGFS_SB_FLAG_SHUTDOWN) { | ||
510 | block->ops->free_block(sb, block); | ||
511 | return; | ||
512 | } | ||
513 | log_blockmove("move_page_to_btree(%llx, %llx, %x)\n", | ||
514 | block->ino, block->bix, block->level); | ||
515 | super->s_flags |= LOGFS_SB_FLAG_OBJ_ALIAS; | ||
516 | |||
517 | for (pos = 0; ; pos++) { | ||
518 | pos = fnb(block->alias_map, LOGFS_BLOCK_FACTOR, pos); | ||
519 | if (pos >= LOGFS_BLOCK_FACTOR) | ||
520 | break; | ||
521 | |||
522 | item = mempool_alloc(super->s_alias_pool, GFP_NOFS); | ||
523 | BUG_ON(!item); /* mempool empty */ | ||
524 | memset(item, 0, sizeof(*item)); | ||
525 | |||
526 | child = kmap_atomic(page, KM_USER0); | ||
527 | item->val = child[pos]; | ||
528 | kunmap_atomic(child, KM_USER0); | ||
529 | item->child_no = pos; | ||
530 | list_add(&item->list, &block->item_list); | ||
531 | } | ||
532 | block->page = NULL; | ||
533 | ClearPagePrivate(page); | ||
534 | page->private = 0; | ||
535 | block->ops = &btree_block_ops; | ||
536 | err = alias_tree_insert(block->sb, block->ino, block->bix, block->level, | ||
537 | block); | ||
538 | BUG_ON(err); /* mempool empty */ | ||
539 | ClearPageUptodate(page); | ||
540 | } | ||
541 | |||
542 | static int __logfs_segment_read(struct inode *inode, void *buf, | ||
543 | u64 ofs, u64 bix, level_t level) | ||
544 | { | ||
545 | struct super_block *sb = inode->i_sb; | ||
546 | void *compressor_buf = logfs_super(sb)->s_compressed_je; | ||
547 | struct logfs_object_header oh; | ||
548 | __be32 crc; | ||
549 | u16 len; | ||
550 | int err, block_len; | ||
551 | |||
552 | block_len = obj_len(sb, obj_type(inode, level)); | ||
553 | err = read_obj_header(sb, ofs, &oh); | ||
554 | if (err) | ||
555 | goto out_err; | ||
556 | |||
557 | err = -EIO; | ||
558 | if (be64_to_cpu(oh.ino) != inode->i_ino | ||
559 | || check_pos(sb, be64_to_cpu(oh.bix), bix, level)) { | ||
560 | printk(KERN_ERR"LOGFS: (ino, bix) don't match at %llx: " | ||
561 | "expected (%lx, %llx), got (%llx, %llx)\n", | ||
562 | ofs, inode->i_ino, bix, | ||
563 | be64_to_cpu(oh.ino), be64_to_cpu(oh.bix)); | ||
564 | goto out_err; | ||
565 | } | ||
566 | |||
567 | len = be16_to_cpu(oh.len); | ||
568 | |||
569 | switch (oh.compr) { | ||
570 | case COMPR_NONE: | ||
571 | err = wbuf_read(sb, ofs + LOGFS_OBJECT_HEADERSIZE, len, buf); | ||
572 | if (err) | ||
573 | goto out_err; | ||
574 | crc = logfs_crc32(buf, len, 0); | ||
575 | if (crc != oh.data_crc) { | ||
576 | printk(KERN_ERR"LOGFS: uncompressed data crc error at " | ||
577 | "%llx: expected %x, got %x\n", ofs, | ||
578 | be32_to_cpu(oh.data_crc), | ||
579 | be32_to_cpu(crc)); | ||
580 | goto out_err; | ||
581 | } | ||
582 | break; | ||
583 | case COMPR_ZLIB: | ||
584 | mutex_lock(&logfs_super(sb)->s_journal_mutex); | ||
585 | err = wbuf_read(sb, ofs + LOGFS_OBJECT_HEADERSIZE, len, | ||
586 | compressor_buf); | ||
587 | if (err) { | ||
588 | mutex_unlock(&logfs_super(sb)->s_journal_mutex); | ||
589 | goto out_err; | ||
590 | } | ||
591 | crc = logfs_crc32(compressor_buf, len, 0); | ||
592 | if (crc != oh.data_crc) { | ||
593 | printk(KERN_ERR"LOGFS: compressed data crc error at " | ||
594 | "%llx: expected %x, got %x\n", ofs, | ||
595 | be32_to_cpu(oh.data_crc), | ||
596 | be32_to_cpu(crc)); | ||
597 | mutex_unlock(&logfs_super(sb)->s_journal_mutex); | ||
598 | goto out_err; | ||
599 | } | ||
600 | err = logfs_uncompress(compressor_buf, buf, len, block_len); | ||
601 | mutex_unlock(&logfs_super(sb)->s_journal_mutex); | ||
602 | if (err) { | ||
603 | printk(KERN_ERR"LOGFS: uncompress error at %llx\n", ofs); | ||
604 | goto out_err; | ||
605 | } | ||
606 | break; | ||
607 | default: | ||
608 | LOGFS_BUG(sb); | ||
609 | err = -EIO; | ||
610 | goto out_err; | ||
611 | } | ||
612 | return 0; | ||
613 | |||
614 | out_err: | ||
615 | logfs_set_ro(sb); | ||
616 | printk(KERN_ERR"LOGFS: device is read-only now\n"); | ||
617 | LOGFS_BUG(sb); | ||
618 | return err; | ||
619 | } | ||
620 | |||
621 | /** | ||
622 | * logfs_segment_read - read data block from object store | ||
623 | * @inode: inode containing data | ||
624 | * @buf: data buffer | ||
625 | * @ofs: physical data offset | ||
626 | * @bix: block index | ||
627 | * @level: block level | ||
628 | * | ||
629 | * Returns 0 on success or a negative errno. | ||
630 | */ | ||
631 | int logfs_segment_read(struct inode *inode, struct page *page, | ||
632 | u64 ofs, u64 bix, level_t level) | ||
633 | { | ||
634 | int err; | ||
635 | void *buf; | ||
636 | |||
637 | if (PageUptodate(page)) | ||
638 | return 0; | ||
639 | |||
640 | ofs &= ~LOGFS_FULLY_POPULATED; | ||
641 | |||
642 | buf = kmap(page); | ||
643 | err = __logfs_segment_read(inode, buf, ofs, bix, level); | ||
644 | if (!err) { | ||
645 | move_btree_to_page(inode, page, buf); | ||
646 | SetPageUptodate(page); | ||
647 | } | ||
648 | kunmap(page); | ||
649 | log_segment("logfs_segment_read(%lx, %llx, %x) %llx (%d)\n", | ||
650 | inode->i_ino, bix, level, ofs, err); | ||
651 | return err; | ||
652 | } | ||
653 | |||
654 | int logfs_segment_delete(struct inode *inode, struct logfs_shadow *shadow) | ||
655 | { | ||
656 | struct super_block *sb = inode->i_sb; | ||
657 | struct logfs_super *super = logfs_super(sb); | ||
658 | struct logfs_object_header h; | ||
659 | u16 len; | ||
660 | int err; | ||
661 | |||
662 | super->s_flags |= LOGFS_SB_FLAG_DIRTY; | ||
663 | BUG_ON(super->s_flags & LOGFS_SB_FLAG_SHUTDOWN); | ||
664 | BUG_ON(shadow->old_ofs & LOGFS_FULLY_POPULATED); | ||
665 | if (!shadow->old_ofs) | ||
666 | return 0; | ||
667 | |||
668 | log_segment("logfs_segment_delete(%llx, %llx, %x) %llx->%llx %x->%x\n", | ||
669 | shadow->ino, shadow->bix, shadow->gc_level, | ||
670 | shadow->old_ofs, shadow->new_ofs, | ||
671 | shadow->old_len, shadow->new_len); | ||
672 | err = read_obj_header(sb, shadow->old_ofs, &h); | ||
673 | LOGFS_BUG_ON(err, sb); | ||
674 | LOGFS_BUG_ON(be64_to_cpu(h.ino) != inode->i_ino, sb); | ||
675 | LOGFS_BUG_ON(check_pos(sb, shadow->bix, be64_to_cpu(h.bix), | ||
676 | shrink_level(shadow->gc_level)), sb); | ||
677 | |||
678 | if (shadow->gc_level == 0) | ||
679 | len = be16_to_cpu(h.len); | ||
680 | else | ||
681 | len = obj_len(sb, h.type); | ||
682 | shadow->old_len = len + sizeof(h); | ||
683 | return 0; | ||
684 | } | ||
685 | |||
686 | static void freeseg(struct super_block *sb, u32 segno) | ||
687 | { | ||
688 | struct logfs_super *super = logfs_super(sb); | ||
689 | struct address_space *mapping = super->s_mapping_inode->i_mapping; | ||
690 | struct page *page; | ||
691 | u64 ofs, start, end; | ||
692 | |||
693 | start = dev_ofs(sb, segno, 0); | ||
694 | end = dev_ofs(sb, segno + 1, 0); | ||
695 | for (ofs = start; ofs < end; ofs += PAGE_SIZE) { | ||
696 | page = find_get_page(mapping, ofs >> PAGE_SHIFT); | ||
697 | if (!page) | ||
698 | continue; | ||
699 | ClearPagePrivate(page); | ||
700 | page_cache_release(page); | ||
701 | } | ||
702 | } | ||
703 | |||
704 | int logfs_open_area(struct logfs_area *area, size_t bytes) | ||
705 | { | ||
706 | struct super_block *sb = area->a_sb; | ||
707 | struct logfs_super *super = logfs_super(sb); | ||
708 | int err, closed = 0; | ||
709 | |||
710 | if (area->a_is_open && area->a_used_bytes + bytes <= super->s_segsize) | ||
711 | return 0; | ||
712 | |||
713 | if (area->a_is_open) { | ||
714 | u64 ofs = dev_ofs(sb, area->a_segno, area->a_written_bytes); | ||
715 | u32 len = super->s_segsize - area->a_written_bytes; | ||
716 | |||
717 | log_gc("logfs_close_area(%x)\n", area->a_segno); | ||
718 | pad_wbuf(area, 1); | ||
719 | super->s_devops->writeseg(area->a_sb, ofs, len); | ||
720 | freeseg(sb, area->a_segno); | ||
721 | closed = 1; | ||
722 | } | ||
723 | |||
724 | area->a_used_bytes = 0; | ||
725 | area->a_written_bytes = 0; | ||
726 | again: | ||
727 | area->a_ops->get_free_segment(area); | ||
728 | area->a_ops->get_erase_count(area); | ||
729 | |||
730 | log_gc("logfs_open_area(%x, %x)\n", area->a_segno, area->a_level); | ||
731 | err = area->a_ops->erase_segment(area); | ||
732 | if (err) { | ||
733 | printk(KERN_WARNING "LogFS: Error erasing segment %x\n", | ||
734 | area->a_segno); | ||
735 | logfs_mark_segment_bad(sb, area->a_segno); | ||
736 | goto again; | ||
737 | } | ||
738 | area->a_is_open = 1; | ||
739 | return closed; | ||
740 | } | ||
741 | |||
742 | void logfs_sync_area(struct logfs_area *area) | ||
743 | { | ||
744 | struct super_block *sb = area->a_sb; | ||
745 | struct logfs_super *super = logfs_super(sb); | ||
746 | u64 ofs = dev_ofs(sb, area->a_segno, area->a_written_bytes); | ||
747 | u32 len = (area->a_used_bytes - area->a_written_bytes); | ||
748 | |||
749 | if (super->s_writesize) | ||
750 | len &= ~(super->s_writesize - 1); | ||
751 | if (len == 0) | ||
752 | return; | ||
753 | pad_wbuf(area, 0); | ||
754 | super->s_devops->writeseg(sb, ofs, len); | ||
755 | area->a_written_bytes += len; | ||
756 | } | ||
757 | |||
758 | void logfs_sync_segments(struct super_block *sb) | ||
759 | { | ||
760 | struct logfs_super *super = logfs_super(sb); | ||
761 | int i; | ||
762 | |||
763 | for_each_area(i) | ||
764 | logfs_sync_area(super->s_area[i]); | ||
765 | } | ||
766 | |||
767 | /* | ||
768 | * Pick a free segment to be used for this area. Effectively takes a | ||
769 | * candidate from the free list (not really a candidate anymore). | ||
770 | */ | ||
771 | static void ostore_get_free_segment(struct logfs_area *area) | ||
772 | { | ||
773 | struct super_block *sb = area->a_sb; | ||
774 | struct logfs_super *super = logfs_super(sb); | ||
775 | |||
776 | if (super->s_free_list.count == 0) { | ||
777 | printk(KERN_ERR"LOGFS: ran out of free segments\n"); | ||
778 | LOGFS_BUG(sb); | ||
779 | } | ||
780 | |||
781 | area->a_segno = get_best_cand(sb, &super->s_free_list, NULL); | ||
782 | } | ||
783 | |||
784 | static void ostore_get_erase_count(struct logfs_area *area) | ||
785 | { | ||
786 | struct logfs_segment_entry se; | ||
787 | u32 ec_level; | ||
788 | |||
789 | logfs_get_segment_entry(area->a_sb, area->a_segno, &se); | ||
790 | BUG_ON(se.ec_level == cpu_to_be32(BADSEG) || | ||
791 | se.valid == cpu_to_be32(RESERVED)); | ||
792 | |||
793 | ec_level = be32_to_cpu(se.ec_level); | ||
794 | area->a_erase_count = (ec_level >> 4) + 1; | ||
795 | } | ||
796 | |||
797 | static int ostore_erase_segment(struct logfs_area *area) | ||
798 | { | ||
799 | struct super_block *sb = area->a_sb; | ||
800 | struct logfs_segment_header sh; | ||
801 | u64 ofs; | ||
802 | int err; | ||
803 | |||
804 | err = logfs_erase_segment(sb, area->a_segno, 0); | ||
805 | if (err) | ||
806 | return err; | ||
807 | |||
808 | sh.pad = 0; | ||
809 | sh.type = SEG_OSTORE; | ||
810 | sh.level = (__force u8)area->a_level; | ||
811 | sh.segno = cpu_to_be32(area->a_segno); | ||
812 | sh.ec = cpu_to_be32(area->a_erase_count); | ||
813 | sh.gec = cpu_to_be64(logfs_super(sb)->s_gec); | ||
814 | sh.crc = logfs_crc32(&sh, sizeof(sh), 4); | ||
815 | |||
816 | logfs_set_segment_erased(sb, area->a_segno, area->a_erase_count, | ||
817 | area->a_level); | ||
818 | |||
819 | ofs = dev_ofs(sb, area->a_segno, 0); | ||
820 | area->a_used_bytes = sizeof(sh); | ||
821 | logfs_buf_write(area, ofs, &sh, sizeof(sh)); | ||
822 | return 0; | ||
823 | } | ||
824 | |||
825 | static const struct logfs_area_ops ostore_area_ops = { | ||
826 | .get_free_segment = ostore_get_free_segment, | ||
827 | .get_erase_count = ostore_get_erase_count, | ||
828 | .erase_segment = ostore_erase_segment, | ||
829 | }; | ||
830 | |||
831 | static void free_area(struct logfs_area *area) | ||
832 | { | ||
833 | if (area) | ||
834 | freeseg(area->a_sb, area->a_segno); | ||
835 | kfree(area); | ||
836 | } | ||
837 | |||
838 | static struct logfs_area *alloc_area(struct super_block *sb) | ||
839 | { | ||
840 | struct logfs_area *area; | ||
841 | |||
842 | area = kzalloc(sizeof(*area), GFP_KERNEL); | ||
843 | if (!area) | ||
844 | return NULL; | ||
845 | |||
846 | area->a_sb = sb; | ||
847 | return area; | ||
848 | } | ||
849 | |||
850 | static void map_invalidatepage(struct page *page, unsigned long l) | ||
851 | { | ||
852 | BUG(); | ||
853 | } | ||
854 | |||
855 | static int map_releasepage(struct page *page, gfp_t g) | ||
856 | { | ||
857 | /* Don't release these pages */ | ||
858 | return 0; | ||
859 | } | ||
860 | |||
861 | static const struct address_space_operations mapping_aops = { | ||
862 | .invalidatepage = map_invalidatepage, | ||
863 | .releasepage = map_releasepage, | ||
864 | .set_page_dirty = __set_page_dirty_nobuffers, | ||
865 | }; | ||
866 | |||
867 | int logfs_init_mapping(struct super_block *sb) | ||
868 | { | ||
869 | struct logfs_super *super = logfs_super(sb); | ||
870 | struct address_space *mapping; | ||
871 | struct inode *inode; | ||
872 | |||
873 | inode = logfs_new_meta_inode(sb, LOGFS_INO_MAPPING); | ||
874 | if (IS_ERR(inode)) | ||
875 | return PTR_ERR(inode); | ||
876 | super->s_mapping_inode = inode; | ||
877 | mapping = inode->i_mapping; | ||
878 | mapping->a_ops = &mapping_aops; | ||
879 | /* Would it be possible to use __GFP_HIGHMEM as well? */ | ||
880 | mapping_set_gfp_mask(mapping, GFP_NOFS); | ||
881 | return 0; | ||
882 | } | ||
883 | |||
884 | int logfs_init_areas(struct super_block *sb) | ||
885 | { | ||
886 | struct logfs_super *super = logfs_super(sb); | ||
887 | int i = -1; | ||
888 | |||
889 | super->s_alias_pool = mempool_create_kmalloc_pool(600, | ||
890 | sizeof(struct object_alias_item)); | ||
891 | if (!super->s_alias_pool) | ||
892 | return -ENOMEM; | ||
893 | |||
894 | super->s_journal_area = alloc_area(sb); | ||
895 | if (!super->s_journal_area) | ||
896 | goto err; | ||
897 | |||
898 | for_each_area(i) { | ||
899 | super->s_area[i] = alloc_area(sb); | ||
900 | if (!super->s_area[i]) | ||
901 | goto err; | ||
902 | super->s_area[i]->a_level = GC_LEVEL(i); | ||
903 | super->s_area[i]->a_ops = &ostore_area_ops; | ||
904 | } | ||
905 | btree_init_mempool128(&super->s_object_alias_tree, | ||
906 | super->s_btree_pool); | ||
907 | return 0; | ||
908 | |||
909 | err: | ||
910 | for (i--; i >= 0; i--) | ||
911 | free_area(super->s_area[i]); | ||
912 | free_area(super->s_journal_area); | ||
913 | mempool_destroy(super->s_alias_pool); | ||
914 | return -ENOMEM; | ||
915 | } | ||
916 | |||
917 | void logfs_cleanup_areas(struct super_block *sb) | ||
918 | { | ||
919 | struct logfs_super *super = logfs_super(sb); | ||
920 | int i; | ||
921 | |||
922 | btree_grim_visitor128(&super->s_object_alias_tree, 0, kill_alias); | ||
923 | for_each_area(i) | ||
924 | free_area(super->s_area[i]); | ||
925 | free_area(super->s_journal_area); | ||
926 | destroy_meta_inode(super->s_mapping_inode); | ||
927 | } | ||
diff --git a/fs/logfs/super.c b/fs/logfs/super.c new file mode 100644 index 000000000000..c66beab78dee --- /dev/null +++ b/fs/logfs/super.c | |||
@@ -0,0 +1,650 @@ | |||
1 | /* | ||
2 | * fs/logfs/super.c | ||
3 | * | ||
4 | * As should be obvious for Linux kernel code, license is GPLv2 | ||
5 | * | ||
6 | * Copyright (c) 2005-2008 Joern Engel <joern@logfs.org> | ||
7 | * | ||
8 | * Generally contains mount/umount code and also serves as a dump area for | ||
9 | * any functions that don't fit elsewhere and neither justify a file of their | ||
10 | * own. | ||
11 | */ | ||
12 | #include "logfs.h" | ||
13 | #include <linux/bio.h> | ||
14 | #include <linux/mtd/mtd.h> | ||
15 | #include <linux/statfs.h> | ||
16 | #include <linux/buffer_head.h> | ||
17 | |||
18 | static DEFINE_MUTEX(emergency_mutex); | ||
19 | static struct page *emergency_page; | ||
20 | |||
21 | struct page *emergency_read_begin(struct address_space *mapping, pgoff_t index) | ||
22 | { | ||
23 | filler_t *filler = (filler_t *)mapping->a_ops->readpage; | ||
24 | struct page *page; | ||
25 | int err; | ||
26 | |||
27 | page = read_cache_page(mapping, index, filler, NULL); | ||
28 | if (page) | ||
29 | return page; | ||
30 | |||
31 | /* No more pages available, switch to emergency page */ | ||
32 | printk(KERN_INFO"Logfs: Using emergency page\n"); | ||
33 | mutex_lock(&emergency_mutex); | ||
34 | err = filler(NULL, emergency_page); | ||
35 | if (err) { | ||
36 | mutex_unlock(&emergency_mutex); | ||
37 | printk(KERN_EMERG"Logfs: Error reading emergency page\n"); | ||
38 | return ERR_PTR(err); | ||
39 | } | ||
40 | return emergency_page; | ||
41 | } | ||
42 | |||
43 | void emergency_read_end(struct page *page) | ||
44 | { | ||
45 | if (page == emergency_page) | ||
46 | mutex_unlock(&emergency_mutex); | ||
47 | else | ||
48 | page_cache_release(page); | ||
49 | } | ||
50 | |||
51 | static void dump_segfile(struct super_block *sb) | ||
52 | { | ||
53 | struct logfs_super *super = logfs_super(sb); | ||
54 | struct logfs_segment_entry se; | ||
55 | u32 segno; | ||
56 | |||
57 | for (segno = 0; segno < super->s_no_segs; segno++) { | ||
58 | logfs_get_segment_entry(sb, segno, &se); | ||
59 | printk("%3x: %6x %8x", segno, be32_to_cpu(se.ec_level), | ||
60 | be32_to_cpu(se.valid)); | ||
61 | if (++segno < super->s_no_segs) { | ||
62 | logfs_get_segment_entry(sb, segno, &se); | ||
63 | printk(" %6x %8x", be32_to_cpu(se.ec_level), | ||
64 | be32_to_cpu(se.valid)); | ||
65 | } | ||
66 | if (++segno < super->s_no_segs) { | ||
67 | logfs_get_segment_entry(sb, segno, &se); | ||
68 | printk(" %6x %8x", be32_to_cpu(se.ec_level), | ||
69 | be32_to_cpu(se.valid)); | ||
70 | } | ||
71 | if (++segno < super->s_no_segs) { | ||
72 | logfs_get_segment_entry(sb, segno, &se); | ||
73 | printk(" %6x %8x", be32_to_cpu(se.ec_level), | ||
74 | be32_to_cpu(se.valid)); | ||
75 | } | ||
76 | printk("\n"); | ||
77 | } | ||
78 | } | ||
79 | |||
80 | /* | ||
81 | * logfs_crash_dump - dump debug information to device | ||
82 | * | ||
83 | * The LogFS superblock only occupies part of a segment. This function will | ||
84 | * write as much debug information as it can gather into the spare space. | ||
85 | */ | ||
86 | void logfs_crash_dump(struct super_block *sb) | ||
87 | { | ||
88 | dump_segfile(sb); | ||
89 | } | ||
90 | |||
91 | /* | ||
92 | * TODO: move to lib/string.c | ||
93 | */ | ||
94 | /** | ||
95 | * memchr_inv - Find a character in an area of memory. | ||
96 | * @s: The memory area | ||
97 | * @c: The byte to search for | ||
98 | * @n: The size of the area. | ||
99 | * | ||
100 | * returns the address of the first character other than @c, or %NULL | ||
101 | * if the whole buffer contains just @c. | ||
102 | */ | ||
103 | void *memchr_inv(const void *s, int c, size_t n) | ||
104 | { | ||
105 | const unsigned char *p = s; | ||
106 | while (n-- != 0) | ||
107 | if ((unsigned char)c != *p++) | ||
108 | return (void *)(p - 1); | ||
109 | |||
110 | return NULL; | ||
111 | } | ||
112 | |||
113 | /* | ||
114 | * FIXME: There should be a reserve for root, similar to ext2. | ||
115 | */ | ||
116 | int logfs_statfs(struct dentry *dentry, struct kstatfs *stats) | ||
117 | { | ||
118 | struct super_block *sb = dentry->d_sb; | ||
119 | struct logfs_super *super = logfs_super(sb); | ||
120 | |||
121 | stats->f_type = LOGFS_MAGIC_U32; | ||
122 | stats->f_bsize = sb->s_blocksize; | ||
123 | stats->f_blocks = super->s_size >> LOGFS_BLOCK_BITS >> 3; | ||
124 | stats->f_bfree = super->s_free_bytes >> sb->s_blocksize_bits; | ||
125 | stats->f_bavail = super->s_free_bytes >> sb->s_blocksize_bits; | ||
126 | stats->f_files = 0; | ||
127 | stats->f_ffree = 0; | ||
128 | stats->f_namelen = LOGFS_MAX_NAMELEN; | ||
129 | return 0; | ||
130 | } | ||
131 | |||
132 | static int logfs_sb_set(struct super_block *sb, void *_super) | ||
133 | { | ||
134 | struct logfs_super *super = _super; | ||
135 | |||
136 | sb->s_fs_info = super; | ||
137 | sb->s_mtd = super->s_mtd; | ||
138 | sb->s_bdev = super->s_bdev; | ||
139 | return 0; | ||
140 | } | ||
141 | |||
142 | static int logfs_sb_test(struct super_block *sb, void *_super) | ||
143 | { | ||
144 | struct logfs_super *super = _super; | ||
145 | struct mtd_info *mtd = super->s_mtd; | ||
146 | |||
147 | if (mtd && sb->s_mtd == mtd) | ||
148 | return 1; | ||
149 | if (super->s_bdev && sb->s_bdev == super->s_bdev) | ||
150 | return 1; | ||
151 | return 0; | ||
152 | } | ||
153 | |||
154 | static void set_segment_header(struct logfs_segment_header *sh, u8 type, | ||
155 | u8 level, u32 segno, u32 ec) | ||
156 | { | ||
157 | sh->pad = 0; | ||
158 | sh->type = type; | ||
159 | sh->level = level; | ||
160 | sh->segno = cpu_to_be32(segno); | ||
161 | sh->ec = cpu_to_be32(ec); | ||
162 | sh->gec = cpu_to_be64(segno); | ||
163 | sh->crc = logfs_crc32(sh, LOGFS_SEGMENT_HEADERSIZE, 4); | ||
164 | } | ||
165 | |||
166 | static void logfs_write_ds(struct super_block *sb, struct logfs_disk_super *ds, | ||
167 | u32 segno, u32 ec) | ||
168 | { | ||
169 | struct logfs_super *super = logfs_super(sb); | ||
170 | struct logfs_segment_header *sh = &ds->ds_sh; | ||
171 | int i; | ||
172 | |||
173 | memset(ds, 0, sizeof(*ds)); | ||
174 | set_segment_header(sh, SEG_SUPER, 0, segno, ec); | ||
175 | |||
176 | ds->ds_ifile_levels = super->s_ifile_levels; | ||
177 | ds->ds_iblock_levels = super->s_iblock_levels; | ||
178 | ds->ds_data_levels = super->s_data_levels; /* XXX: Remove */ | ||
179 | ds->ds_segment_shift = super->s_segshift; | ||
180 | ds->ds_block_shift = sb->s_blocksize_bits; | ||
181 | ds->ds_write_shift = super->s_writeshift; | ||
182 | ds->ds_filesystem_size = cpu_to_be64(super->s_size); | ||
183 | ds->ds_segment_size = cpu_to_be32(super->s_segsize); | ||
184 | ds->ds_bad_seg_reserve = cpu_to_be32(super->s_bad_seg_reserve); | ||
185 | ds->ds_feature_incompat = cpu_to_be64(super->s_feature_incompat); | ||
186 | ds->ds_feature_ro_compat= cpu_to_be64(super->s_feature_ro_compat); | ||
187 | ds->ds_feature_compat = cpu_to_be64(super->s_feature_compat); | ||
188 | ds->ds_feature_flags = cpu_to_be64(super->s_feature_flags); | ||
189 | ds->ds_root_reserve = cpu_to_be64(super->s_root_reserve); | ||
190 | ds->ds_speed_reserve = cpu_to_be64(super->s_speed_reserve); | ||
191 | journal_for_each(i) | ||
192 | ds->ds_journal_seg[i] = cpu_to_be32(super->s_journal_seg[i]); | ||
193 | ds->ds_magic = cpu_to_be64(LOGFS_MAGIC); | ||
194 | ds->ds_crc = logfs_crc32(ds, sizeof(*ds), | ||
195 | LOGFS_SEGMENT_HEADERSIZE + 12); | ||
196 | } | ||
197 | |||
198 | static int write_one_sb(struct super_block *sb, | ||
199 | struct page *(*find_sb)(struct super_block *sb, u64 *ofs)) | ||
200 | { | ||
201 | struct logfs_super *super = logfs_super(sb); | ||
202 | struct logfs_disk_super *ds; | ||
203 | struct logfs_segment_entry se; | ||
204 | struct page *page; | ||
205 | u64 ofs; | ||
206 | u32 ec, segno; | ||
207 | int err; | ||
208 | |||
209 | page = find_sb(sb, &ofs); | ||
210 | if (!page) | ||
211 | return -EIO; | ||
212 | ds = page_address(page); | ||
213 | segno = seg_no(sb, ofs); | ||
214 | logfs_get_segment_entry(sb, segno, &se); | ||
215 | ec = be32_to_cpu(se.ec_level) >> 4; | ||
216 | ec++; | ||
217 | logfs_set_segment_erased(sb, segno, ec, 0); | ||
218 | logfs_write_ds(sb, ds, segno, ec); | ||
219 | err = super->s_devops->write_sb(sb, page); | ||
220 | page_cache_release(page); | ||
221 | return err; | ||
222 | } | ||
223 | |||
224 | int logfs_write_sb(struct super_block *sb) | ||
225 | { | ||
226 | struct logfs_super *super = logfs_super(sb); | ||
227 | int err; | ||
228 | |||
229 | /* First superblock */ | ||
230 | err = write_one_sb(sb, super->s_devops->find_first_sb); | ||
231 | if (err) | ||
232 | return err; | ||
233 | |||
234 | /* Last superblock */ | ||
235 | err = write_one_sb(sb, super->s_devops->find_last_sb); | ||
236 | if (err) | ||
237 | return err; | ||
238 | return 0; | ||
239 | } | ||
240 | |||
241 | static int ds_cmp(const void *ds0, const void *ds1) | ||
242 | { | ||
243 | size_t len = sizeof(struct logfs_disk_super); | ||
244 | |||
245 | /* We know the segment headers differ, so ignore them */ | ||
246 | len -= LOGFS_SEGMENT_HEADERSIZE; | ||
247 | ds0 += LOGFS_SEGMENT_HEADERSIZE; | ||
248 | ds1 += LOGFS_SEGMENT_HEADERSIZE; | ||
249 | return memcmp(ds0, ds1, len); | ||
250 | } | ||
251 | |||
252 | static int logfs_recover_sb(struct super_block *sb) | ||
253 | { | ||
254 | struct logfs_super *super = logfs_super(sb); | ||
255 | struct logfs_disk_super _ds0, *ds0 = &_ds0; | ||
256 | struct logfs_disk_super _ds1, *ds1 = &_ds1; | ||
257 | int err, valid0, valid1; | ||
258 | |||
259 | /* read first superblock */ | ||
260 | err = wbuf_read(sb, super->s_sb_ofs[0], sizeof(*ds0), ds0); | ||
261 | if (err) | ||
262 | return err; | ||
263 | /* read last superblock */ | ||
264 | err = wbuf_read(sb, super->s_sb_ofs[1], sizeof(*ds1), ds1); | ||
265 | if (err) | ||
266 | return err; | ||
267 | valid0 = logfs_check_ds(ds0) == 0; | ||
268 | valid1 = logfs_check_ds(ds1) == 0; | ||
269 | |||
270 | if (!valid0 && valid1) { | ||
271 | printk(KERN_INFO"First superblock is invalid - fixing.\n"); | ||
272 | return write_one_sb(sb, super->s_devops->find_first_sb); | ||
273 | } | ||
274 | if (valid0 && !valid1) { | ||
275 | printk(KERN_INFO"Last superblock is invalid - fixing.\n"); | ||
276 | return write_one_sb(sb, super->s_devops->find_last_sb); | ||
277 | } | ||
278 | if (valid0 && valid1 && ds_cmp(ds0, ds1)) { | ||
279 | printk(KERN_INFO"Superblocks don't match - fixing.\n"); | ||
280 | return write_one_sb(sb, super->s_devops->find_last_sb); | ||
281 | } | ||
282 | /* If neither is valid now, something's wrong. Didn't we properly | ||
283 | * check them before?!? */ | ||
284 | BUG_ON(!valid0 && !valid1); | ||
285 | return 0; | ||
286 | } | ||
287 | |||
288 | static int logfs_make_writeable(struct super_block *sb) | ||
289 | { | ||
290 | int err; | ||
291 | |||
292 | /* Repair any broken superblock copies */ | ||
293 | err = logfs_recover_sb(sb); | ||
294 | if (err) | ||
295 | return err; | ||
296 | |||
297 | /* Check areas for trailing unaccounted data */ | ||
298 | err = logfs_check_areas(sb); | ||
299 | if (err) | ||
300 | return err; | ||
301 | |||
302 | err = logfs_open_segfile(sb); | ||
303 | if (err) | ||
304 | return err; | ||
305 | |||
306 | /* Do one GC pass before any data gets dirtied */ | ||
307 | logfs_gc_pass(sb); | ||
308 | |||
309 | /* after all initializations are done, replay the journal | ||
310 | * for rw-mounts, if necessary */ | ||
311 | err = logfs_replay_journal(sb); | ||
312 | if (err) | ||
313 | return err; | ||
314 | |||
315 | return 0; | ||
316 | } | ||
317 | |||
318 | static int logfs_get_sb_final(struct super_block *sb, struct vfsmount *mnt) | ||
319 | { | ||
320 | struct logfs_super *super = logfs_super(sb); | ||
321 | struct inode *rootdir; | ||
322 | int err; | ||
323 | |||
324 | /* root dir */ | ||
325 | rootdir = logfs_iget(sb, LOGFS_INO_ROOT); | ||
326 | if (IS_ERR(rootdir)) | ||
327 | goto fail; | ||
328 | |||
329 | sb->s_root = d_alloc_root(rootdir); | ||
330 | if (!sb->s_root) | ||
331 | goto fail; | ||
332 | |||
333 | super->s_erase_page = alloc_pages(GFP_KERNEL, 0); | ||
334 | if (!super->s_erase_page) | ||
335 | goto fail2; | ||
336 | memset(page_address(super->s_erase_page), 0xFF, PAGE_SIZE); | ||
337 | |||
338 | /* FIXME: check for read-only mounts */ | ||
339 | err = logfs_make_writeable(sb); | ||
340 | if (err) | ||
341 | goto fail3; | ||
342 | |||
343 | log_super("LogFS: Finished mounting\n"); | ||
344 | simple_set_mnt(mnt, sb); | ||
345 | return 0; | ||
346 | |||
347 | fail3: | ||
348 | __free_page(super->s_erase_page); | ||
349 | fail2: | ||
350 | iput(rootdir); | ||
351 | fail: | ||
352 | iput(logfs_super(sb)->s_master_inode); | ||
353 | return -EIO; | ||
354 | } | ||
355 | |||
356 | int logfs_check_ds(struct logfs_disk_super *ds) | ||
357 | { | ||
358 | struct logfs_segment_header *sh = &ds->ds_sh; | ||
359 | |||
360 | if (ds->ds_magic != cpu_to_be64(LOGFS_MAGIC)) | ||
361 | return -EINVAL; | ||
362 | if (sh->crc != logfs_crc32(sh, LOGFS_SEGMENT_HEADERSIZE, 4)) | ||
363 | return -EINVAL; | ||
364 | if (ds->ds_crc != logfs_crc32(ds, sizeof(*ds), | ||
365 | LOGFS_SEGMENT_HEADERSIZE + 12)) | ||
366 | return -EINVAL; | ||
367 | return 0; | ||
368 | } | ||
369 | |||
370 | static struct page *find_super_block(struct super_block *sb) | ||
371 | { | ||
372 | struct logfs_super *super = logfs_super(sb); | ||
373 | struct page *first, *last; | ||
374 | |||
375 | first = super->s_devops->find_first_sb(sb, &super->s_sb_ofs[0]); | ||
376 | if (!first || IS_ERR(first)) | ||
377 | return NULL; | ||
378 | last = super->s_devops->find_last_sb(sb, &super->s_sb_ofs[1]); | ||
379 | if (!last || IS_ERR(first)) { | ||
380 | page_cache_release(first); | ||
381 | return NULL; | ||
382 | } | ||
383 | |||
384 | if (!logfs_check_ds(page_address(first))) { | ||
385 | page_cache_release(last); | ||
386 | return first; | ||
387 | } | ||
388 | |||
389 | /* First one didn't work, try the second superblock */ | ||
390 | if (!logfs_check_ds(page_address(last))) { | ||
391 | page_cache_release(first); | ||
392 | return last; | ||
393 | } | ||
394 | |||
395 | /* Neither worked, sorry folks */ | ||
396 | page_cache_release(first); | ||
397 | page_cache_release(last); | ||
398 | return NULL; | ||
399 | } | ||
400 | |||
401 | static int __logfs_read_sb(struct super_block *sb) | ||
402 | { | ||
403 | struct logfs_super *super = logfs_super(sb); | ||
404 | struct page *page; | ||
405 | struct logfs_disk_super *ds; | ||
406 | int i; | ||
407 | |||
408 | page = find_super_block(sb); | ||
409 | if (!page) | ||
410 | return -EIO; | ||
411 | |||
412 | ds = page_address(page); | ||
413 | super->s_size = be64_to_cpu(ds->ds_filesystem_size); | ||
414 | super->s_root_reserve = be64_to_cpu(ds->ds_root_reserve); | ||
415 | super->s_speed_reserve = be64_to_cpu(ds->ds_speed_reserve); | ||
416 | super->s_bad_seg_reserve = be32_to_cpu(ds->ds_bad_seg_reserve); | ||
417 | super->s_segsize = 1 << ds->ds_segment_shift; | ||
418 | super->s_segmask = (1 << ds->ds_segment_shift) - 1; | ||
419 | super->s_segshift = ds->ds_segment_shift; | ||
420 | sb->s_blocksize = 1 << ds->ds_block_shift; | ||
421 | sb->s_blocksize_bits = ds->ds_block_shift; | ||
422 | super->s_writesize = 1 << ds->ds_write_shift; | ||
423 | super->s_writeshift = ds->ds_write_shift; | ||
424 | super->s_no_segs = super->s_size >> super->s_segshift; | ||
425 | super->s_no_blocks = super->s_segsize >> sb->s_blocksize_bits; | ||
426 | super->s_feature_incompat = be64_to_cpu(ds->ds_feature_incompat); | ||
427 | super->s_feature_ro_compat = be64_to_cpu(ds->ds_feature_ro_compat); | ||
428 | super->s_feature_compat = be64_to_cpu(ds->ds_feature_compat); | ||
429 | super->s_feature_flags = be64_to_cpu(ds->ds_feature_flags); | ||
430 | |||
431 | journal_for_each(i) | ||
432 | super->s_journal_seg[i] = be32_to_cpu(ds->ds_journal_seg[i]); | ||
433 | |||
434 | super->s_ifile_levels = ds->ds_ifile_levels; | ||
435 | super->s_iblock_levels = ds->ds_iblock_levels; | ||
436 | super->s_data_levels = ds->ds_data_levels; | ||
437 | super->s_total_levels = super->s_ifile_levels + super->s_iblock_levels | ||
438 | + super->s_data_levels; | ||
439 | page_cache_release(page); | ||
440 | return 0; | ||
441 | } | ||
442 | |||
443 | static int logfs_read_sb(struct super_block *sb, int read_only) | ||
444 | { | ||
445 | struct logfs_super *super = logfs_super(sb); | ||
446 | int ret; | ||
447 | |||
448 | super->s_btree_pool = mempool_create(32, btree_alloc, btree_free, NULL); | ||
449 | if (!super->s_btree_pool) | ||
450 | return -ENOMEM; | ||
451 | |||
452 | btree_init_mempool64(&super->s_shadow_tree.new, super->s_btree_pool); | ||
453 | btree_init_mempool64(&super->s_shadow_tree.old, super->s_btree_pool); | ||
454 | |||
455 | ret = logfs_init_mapping(sb); | ||
456 | if (ret) | ||
457 | return ret; | ||
458 | |||
459 | ret = __logfs_read_sb(sb); | ||
460 | if (ret) | ||
461 | return ret; | ||
462 | |||
463 | if (super->s_feature_incompat & ~LOGFS_FEATURES_INCOMPAT) | ||
464 | return -EIO; | ||
465 | if ((super->s_feature_ro_compat & ~LOGFS_FEATURES_RO_COMPAT) && | ||
466 | !read_only) | ||
467 | return -EIO; | ||
468 | |||
469 | mutex_init(&super->s_dirop_mutex); | ||
470 | mutex_init(&super->s_object_alias_mutex); | ||
471 | INIT_LIST_HEAD(&super->s_freeing_list); | ||
472 | |||
473 | ret = logfs_init_rw(sb); | ||
474 | if (ret) | ||
475 | return ret; | ||
476 | |||
477 | ret = logfs_init_areas(sb); | ||
478 | if (ret) | ||
479 | return ret; | ||
480 | |||
481 | ret = logfs_init_gc(sb); | ||
482 | if (ret) | ||
483 | return ret; | ||
484 | |||
485 | ret = logfs_init_journal(sb); | ||
486 | if (ret) | ||
487 | return ret; | ||
488 | |||
489 | return 0; | ||
490 | } | ||
491 | |||
492 | static void logfs_kill_sb(struct super_block *sb) | ||
493 | { | ||
494 | struct logfs_super *super = logfs_super(sb); | ||
495 | |||
496 | log_super("LogFS: Start unmounting\n"); | ||
497 | /* Alias entries slow down mount, so evict as many as possible */ | ||
498 | sync_filesystem(sb); | ||
499 | logfs_write_anchor(sb); | ||
500 | |||
501 | /* | ||
502 | * From this point on alias entries are simply dropped - and any | ||
503 | * writes to the object store are considered bugs. | ||
504 | */ | ||
505 | super->s_flags |= LOGFS_SB_FLAG_SHUTDOWN; | ||
506 | log_super("LogFS: Now in shutdown\n"); | ||
507 | generic_shutdown_super(sb); | ||
508 | |||
509 | BUG_ON(super->s_dirty_used_bytes || super->s_dirty_free_bytes); | ||
510 | |||
511 | logfs_cleanup_gc(sb); | ||
512 | logfs_cleanup_journal(sb); | ||
513 | logfs_cleanup_areas(sb); | ||
514 | logfs_cleanup_rw(sb); | ||
515 | if (super->s_erase_page) | ||
516 | __free_page(super->s_erase_page); | ||
517 | super->s_devops->put_device(sb); | ||
518 | mempool_destroy(super->s_btree_pool); | ||
519 | mempool_destroy(super->s_alias_pool); | ||
520 | kfree(super); | ||
521 | log_super("LogFS: Finished unmounting\n"); | ||
522 | } | ||
523 | |||
524 | int logfs_get_sb_device(struct file_system_type *type, int flags, | ||
525 | struct mtd_info *mtd, struct block_device *bdev, | ||
526 | const struct logfs_device_ops *devops, struct vfsmount *mnt) | ||
527 | { | ||
528 | struct logfs_super *super; | ||
529 | struct super_block *sb; | ||
530 | int err = -ENOMEM; | ||
531 | static int mount_count; | ||
532 | |||
533 | log_super("LogFS: Start mount %x\n", mount_count++); | ||
534 | super = kzalloc(sizeof(*super), GFP_KERNEL); | ||
535 | if (!super) | ||
536 | goto err0; | ||
537 | |||
538 | super->s_mtd = mtd; | ||
539 | super->s_bdev = bdev; | ||
540 | err = -EINVAL; | ||
541 | sb = sget(type, logfs_sb_test, logfs_sb_set, super); | ||
542 | if (IS_ERR(sb)) | ||
543 | goto err0; | ||
544 | |||
545 | if (sb->s_root) { | ||
546 | /* Device is already in use */ | ||
547 | err = 0; | ||
548 | simple_set_mnt(mnt, sb); | ||
549 | goto err0; | ||
550 | } | ||
551 | |||
552 | super->s_devops = devops; | ||
553 | |||
554 | /* | ||
555 | * sb->s_maxbytes is limited to 8TB. On 32bit systems, the page cache | ||
556 | * only covers 16TB and the upper 8TB are used for indirect blocks. | ||
557 | * On 64bit system we could bump up the limit, but that would make | ||
558 | * the filesystem incompatible with 32bit systems. | ||
559 | */ | ||
560 | sb->s_maxbytes = (1ull << 43) - 1; | ||
561 | sb->s_op = &logfs_super_operations; | ||
562 | sb->s_flags = flags | MS_NOATIME; | ||
563 | |||
564 | err = logfs_read_sb(sb, sb->s_flags & MS_RDONLY); | ||
565 | if (err) | ||
566 | goto err1; | ||
567 | |||
568 | sb->s_flags |= MS_ACTIVE; | ||
569 | err = logfs_get_sb_final(sb, mnt); | ||
570 | if (err) | ||
571 | goto err1; | ||
572 | return 0; | ||
573 | |||
574 | err1: | ||
575 | up_write(&sb->s_umount); | ||
576 | deactivate_super(sb); | ||
577 | return err; | ||
578 | err0: | ||
579 | kfree(super); | ||
580 | //devops->put_device(sb); | ||
581 | return err; | ||
582 | } | ||
583 | |||
584 | static int logfs_get_sb(struct file_system_type *type, int flags, | ||
585 | const char *devname, void *data, struct vfsmount *mnt) | ||
586 | { | ||
587 | ulong mtdnr; | ||
588 | |||
589 | if (!devname) | ||
590 | return logfs_get_sb_bdev(type, flags, devname, mnt); | ||
591 | if (strncmp(devname, "mtd", 3)) | ||
592 | return logfs_get_sb_bdev(type, flags, devname, mnt); | ||
593 | |||
594 | { | ||
595 | char *garbage; | ||
596 | mtdnr = simple_strtoul(devname+3, &garbage, 0); | ||
597 | if (*garbage) | ||
598 | return -EINVAL; | ||
599 | } | ||
600 | |||
601 | return logfs_get_sb_mtd(type, flags, mtdnr, mnt); | ||
602 | } | ||
603 | |||
604 | static struct file_system_type logfs_fs_type = { | ||
605 | .owner = THIS_MODULE, | ||
606 | .name = "logfs", | ||
607 | .get_sb = logfs_get_sb, | ||
608 | .kill_sb = logfs_kill_sb, | ||
609 | .fs_flags = FS_REQUIRES_DEV, | ||
610 | |||
611 | }; | ||
612 | |||
613 | static int __init logfs_init(void) | ||
614 | { | ||
615 | int ret; | ||
616 | |||
617 | emergency_page = alloc_pages(GFP_KERNEL, 0); | ||
618 | if (!emergency_page) | ||
619 | return -ENOMEM; | ||
620 | |||
621 | ret = logfs_compr_init(); | ||
622 | if (ret) | ||
623 | goto out1; | ||
624 | |||
625 | ret = logfs_init_inode_cache(); | ||
626 | if (ret) | ||
627 | goto out2; | ||
628 | |||
629 | return register_filesystem(&logfs_fs_type); | ||
630 | out2: | ||
631 | logfs_compr_exit(); | ||
632 | out1: | ||
633 | __free_pages(emergency_page, 0); | ||
634 | return ret; | ||
635 | } | ||
636 | |||
637 | static void __exit logfs_exit(void) | ||
638 | { | ||
639 | unregister_filesystem(&logfs_fs_type); | ||
640 | logfs_destroy_inode_cache(); | ||
641 | logfs_compr_exit(); | ||
642 | __free_pages(emergency_page, 0); | ||
643 | } | ||
644 | |||
645 | module_init(logfs_init); | ||
646 | module_exit(logfs_exit); | ||
647 | |||
648 | MODULE_LICENSE("GPL v2"); | ||
649 | MODULE_AUTHOR("Joern Engel <joern@logfs.org>"); | ||
650 | MODULE_DESCRIPTION("scalable flash filesystem"); | ||
diff --git a/fs/minix/inode.c b/fs/minix/inode.c index 74ea82d72164..756f8c93780c 100644 --- a/fs/minix/inode.c +++ b/fs/minix/inode.c | |||
@@ -17,8 +17,10 @@ | |||
17 | #include <linux/init.h> | 17 | #include <linux/init.h> |
18 | #include <linux/highuid.h> | 18 | #include <linux/highuid.h> |
19 | #include <linux/vfs.h> | 19 | #include <linux/vfs.h> |
20 | #include <linux/writeback.h> | ||
20 | 21 | ||
21 | static int minix_write_inode(struct inode * inode, int wait); | 22 | static int minix_write_inode(struct inode *inode, |
23 | struct writeback_control *wbc); | ||
22 | static int minix_statfs(struct dentry *dentry, struct kstatfs *buf); | 24 | static int minix_statfs(struct dentry *dentry, struct kstatfs *buf); |
23 | static int minix_remount (struct super_block * sb, int * flags, char * data); | 25 | static int minix_remount (struct super_block * sb, int * flags, char * data); |
24 | 26 | ||
@@ -552,7 +554,7 @@ static struct buffer_head * V2_minix_update_inode(struct inode * inode) | |||
552 | return bh; | 554 | return bh; |
553 | } | 555 | } |
554 | 556 | ||
555 | static int minix_write_inode(struct inode *inode, int wait) | 557 | static int minix_write_inode(struct inode *inode, struct writeback_control *wbc) |
556 | { | 558 | { |
557 | int err = 0; | 559 | int err = 0; |
558 | struct buffer_head *bh; | 560 | struct buffer_head *bh; |
@@ -563,7 +565,7 @@ static int minix_write_inode(struct inode *inode, int wait) | |||
563 | bh = V2_minix_update_inode(inode); | 565 | bh = V2_minix_update_inode(inode); |
564 | if (!bh) | 566 | if (!bh) |
565 | return -EIO; | 567 | return -EIO; |
566 | if (wait && buffer_dirty(bh)) { | 568 | if (wbc->sync_mode == WB_SYNC_ALL && buffer_dirty(bh)) { |
567 | sync_dirty_buffer(bh); | 569 | sync_dirty_buffer(bh); |
568 | if (buffer_req(bh) && !buffer_uptodate(bh)) { | 570 | if (buffer_req(bh) && !buffer_uptodate(bh)) { |
569 | printk("IO error syncing minix inode [%s:%08lx]\n", | 571 | printk("IO error syncing minix inode [%s:%08lx]\n", |
diff --git a/fs/namei.c b/fs/namei.c index a4855af776a8..48e60a187325 100644 --- a/fs/namei.c +++ b/fs/namei.c | |||
@@ -19,7 +19,6 @@ | |||
19 | #include <linux/slab.h> | 19 | #include <linux/slab.h> |
20 | #include <linux/fs.h> | 20 | #include <linux/fs.h> |
21 | #include <linux/namei.h> | 21 | #include <linux/namei.h> |
22 | #include <linux/quotaops.h> | ||
23 | #include <linux/pagemap.h> | 22 | #include <linux/pagemap.h> |
24 | #include <linux/fsnotify.h> | 23 | #include <linux/fsnotify.h> |
25 | #include <linux/personality.h> | 24 | #include <linux/personality.h> |
@@ -498,8 +497,6 @@ static int link_path_walk(const char *, struct nameidata *); | |||
498 | 497 | ||
499 | static __always_inline int __vfs_follow_link(struct nameidata *nd, const char *link) | 498 | static __always_inline int __vfs_follow_link(struct nameidata *nd, const char *link) |
500 | { | 499 | { |
501 | int res = 0; | ||
502 | char *name; | ||
503 | if (IS_ERR(link)) | 500 | if (IS_ERR(link)) |
504 | goto fail; | 501 | goto fail; |
505 | 502 | ||
@@ -510,22 +507,7 @@ static __always_inline int __vfs_follow_link(struct nameidata *nd, const char *l | |||
510 | path_get(&nd->root); | 507 | path_get(&nd->root); |
511 | } | 508 | } |
512 | 509 | ||
513 | res = link_path_walk(link, nd); | 510 | return link_path_walk(link, nd); |
514 | if (nd->depth || res || nd->last_type!=LAST_NORM) | ||
515 | return res; | ||
516 | /* | ||
517 | * If it is an iterative symlinks resolution in open_namei() we | ||
518 | * have to copy the last component. And all that crap because of | ||
519 | * bloody create() on broken symlinks. Furrfu... | ||
520 | */ | ||
521 | name = __getname(); | ||
522 | if (unlikely(!name)) { | ||
523 | path_put(&nd->path); | ||
524 | return -ENOMEM; | ||
525 | } | ||
526 | strcpy(name, nd->last.name); | ||
527 | nd->last.name = name; | ||
528 | return 0; | ||
529 | fail: | 511 | fail: |
530 | path_put(&nd->path); | 512 | path_put(&nd->path); |
531 | return PTR_ERR(link); | 513 | return PTR_ERR(link); |
@@ -547,10 +529,10 @@ static inline void path_to_nameidata(struct path *path, struct nameidata *nd) | |||
547 | nd->path.dentry = path->dentry; | 529 | nd->path.dentry = path->dentry; |
548 | } | 530 | } |
549 | 531 | ||
550 | static __always_inline int __do_follow_link(struct path *path, struct nameidata *nd) | 532 | static __always_inline int |
533 | __do_follow_link(struct path *path, struct nameidata *nd, void **p) | ||
551 | { | 534 | { |
552 | int error; | 535 | int error; |
553 | void *cookie; | ||
554 | struct dentry *dentry = path->dentry; | 536 | struct dentry *dentry = path->dentry; |
555 | 537 | ||
556 | touch_atime(path->mnt, dentry); | 538 | touch_atime(path->mnt, dentry); |
@@ -562,9 +544,9 @@ static __always_inline int __do_follow_link(struct path *path, struct nameidata | |||
562 | } | 544 | } |
563 | mntget(path->mnt); | 545 | mntget(path->mnt); |
564 | nd->last_type = LAST_BIND; | 546 | nd->last_type = LAST_BIND; |
565 | cookie = dentry->d_inode->i_op->follow_link(dentry, nd); | 547 | *p = dentry->d_inode->i_op->follow_link(dentry, nd); |
566 | error = PTR_ERR(cookie); | 548 | error = PTR_ERR(*p); |
567 | if (!IS_ERR(cookie)) { | 549 | if (!IS_ERR(*p)) { |
568 | char *s = nd_get_link(nd); | 550 | char *s = nd_get_link(nd); |
569 | error = 0; | 551 | error = 0; |
570 | if (s) | 552 | if (s) |
@@ -574,8 +556,6 @@ static __always_inline int __do_follow_link(struct path *path, struct nameidata | |||
574 | if (error) | 556 | if (error) |
575 | path_put(&nd->path); | 557 | path_put(&nd->path); |
576 | } | 558 | } |
577 | if (dentry->d_inode->i_op->put_link) | ||
578 | dentry->d_inode->i_op->put_link(dentry, nd, cookie); | ||
579 | } | 559 | } |
580 | return error; | 560 | return error; |
581 | } | 561 | } |
@@ -589,6 +569,7 @@ static __always_inline int __do_follow_link(struct path *path, struct nameidata | |||
589 | */ | 569 | */ |
590 | static inline int do_follow_link(struct path *path, struct nameidata *nd) | 570 | static inline int do_follow_link(struct path *path, struct nameidata *nd) |
591 | { | 571 | { |
572 | void *cookie; | ||
592 | int err = -ELOOP; | 573 | int err = -ELOOP; |
593 | if (current->link_count >= MAX_NESTED_LINKS) | 574 | if (current->link_count >= MAX_NESTED_LINKS) |
594 | goto loop; | 575 | goto loop; |
@@ -602,7 +583,9 @@ static inline int do_follow_link(struct path *path, struct nameidata *nd) | |||
602 | current->link_count++; | 583 | current->link_count++; |
603 | current->total_link_count++; | 584 | current->total_link_count++; |
604 | nd->depth++; | 585 | nd->depth++; |
605 | err = __do_follow_link(path, nd); | 586 | err = __do_follow_link(path, nd, &cookie); |
587 | if (!IS_ERR(cookie) && path->dentry->d_inode->i_op->put_link) | ||
588 | path->dentry->d_inode->i_op->put_link(path->dentry, nd, cookie); | ||
606 | path_put(path); | 589 | path_put(path); |
607 | current->link_count--; | 590 | current->link_count--; |
608 | nd->depth--; | 591 | nd->depth--; |
@@ -689,33 +672,20 @@ static __always_inline void follow_dotdot(struct nameidata *nd) | |||
689 | set_root(nd); | 672 | set_root(nd); |
690 | 673 | ||
691 | while(1) { | 674 | while(1) { |
692 | struct vfsmount *parent; | ||
693 | struct dentry *old = nd->path.dentry; | 675 | struct dentry *old = nd->path.dentry; |
694 | 676 | ||
695 | if (nd->path.dentry == nd->root.dentry && | 677 | if (nd->path.dentry == nd->root.dentry && |
696 | nd->path.mnt == nd->root.mnt) { | 678 | nd->path.mnt == nd->root.mnt) { |
697 | break; | 679 | break; |
698 | } | 680 | } |
699 | spin_lock(&dcache_lock); | ||
700 | if (nd->path.dentry != nd->path.mnt->mnt_root) { | 681 | if (nd->path.dentry != nd->path.mnt->mnt_root) { |
701 | nd->path.dentry = dget(nd->path.dentry->d_parent); | 682 | /* rare case of legitimate dget_parent()... */ |
702 | spin_unlock(&dcache_lock); | 683 | nd->path.dentry = dget_parent(nd->path.dentry); |
703 | dput(old); | 684 | dput(old); |
704 | break; | 685 | break; |
705 | } | 686 | } |
706 | spin_unlock(&dcache_lock); | 687 | if (!follow_up(&nd->path)) |
707 | spin_lock(&vfsmount_lock); | ||
708 | parent = nd->path.mnt->mnt_parent; | ||
709 | if (parent == nd->path.mnt) { | ||
710 | spin_unlock(&vfsmount_lock); | ||
711 | break; | 688 | break; |
712 | } | ||
713 | mntget(parent); | ||
714 | nd->path.dentry = dget(nd->path.mnt->mnt_mountpoint); | ||
715 | spin_unlock(&vfsmount_lock); | ||
716 | dput(old); | ||
717 | mntput(nd->path.mnt); | ||
718 | nd->path.mnt = parent; | ||
719 | } | 689 | } |
720 | follow_mount(&nd->path); | 690 | follow_mount(&nd->path); |
721 | } | 691 | } |
@@ -1347,7 +1317,7 @@ static int may_delete(struct inode *dir,struct dentry *victim,int isdir) | |||
1347 | return -ENOENT; | 1317 | return -ENOENT; |
1348 | 1318 | ||
1349 | BUG_ON(victim->d_parent->d_inode != dir); | 1319 | BUG_ON(victim->d_parent->d_inode != dir); |
1350 | audit_inode_child(victim->d_name.name, victim, dir); | 1320 | audit_inode_child(victim, dir); |
1351 | 1321 | ||
1352 | error = inode_permission(dir, MAY_WRITE | MAY_EXEC); | 1322 | error = inode_permission(dir, MAY_WRITE | MAY_EXEC); |
1353 | if (error) | 1323 | if (error) |
@@ -1388,22 +1358,6 @@ static inline int may_create(struct inode *dir, struct dentry *child) | |||
1388 | return inode_permission(dir, MAY_WRITE | MAY_EXEC); | 1358 | return inode_permission(dir, MAY_WRITE | MAY_EXEC); |
1389 | } | 1359 | } |
1390 | 1360 | ||
1391 | /* | ||
1392 | * O_DIRECTORY translates into forcing a directory lookup. | ||
1393 | */ | ||
1394 | static inline int lookup_flags(unsigned int f) | ||
1395 | { | ||
1396 | unsigned long retval = LOOKUP_FOLLOW; | ||
1397 | |||
1398 | if (f & O_NOFOLLOW) | ||
1399 | retval &= ~LOOKUP_FOLLOW; | ||
1400 | |||
1401 | if (f & O_DIRECTORY) | ||
1402 | retval |= LOOKUP_DIRECTORY; | ||
1403 | |||
1404 | return retval; | ||
1405 | } | ||
1406 | |||
1407 | /* | 1361 | /* |
1408 | * p1 and p2 should be directories on the same fs. | 1362 | * p1 and p2 should be directories on the same fs. |
1409 | */ | 1363 | */ |
@@ -1461,7 +1415,6 @@ int vfs_create(struct inode *dir, struct dentry *dentry, int mode, | |||
1461 | error = security_inode_create(dir, dentry, mode); | 1415 | error = security_inode_create(dir, dentry, mode); |
1462 | if (error) | 1416 | if (error) |
1463 | return error; | 1417 | return error; |
1464 | vfs_dq_init(dir); | ||
1465 | error = dir->i_op->create(dir, dentry, mode, nd); | 1418 | error = dir->i_op->create(dir, dentry, mode, nd); |
1466 | if (!error) | 1419 | if (!error) |
1467 | fsnotify_create(dir, dentry); | 1420 | fsnotify_create(dir, dentry); |
@@ -1503,7 +1456,7 @@ int may_open(struct path *path, int acc_mode, int flag) | |||
1503 | * An append-only file must be opened in append mode for writing. | 1456 | * An append-only file must be opened in append mode for writing. |
1504 | */ | 1457 | */ |
1505 | if (IS_APPEND(inode)) { | 1458 | if (IS_APPEND(inode)) { |
1506 | if ((flag & FMODE_WRITE) && !(flag & O_APPEND)) | 1459 | if ((flag & O_ACCMODE) != O_RDONLY && !(flag & O_APPEND)) |
1507 | return -EPERM; | 1460 | return -EPERM; |
1508 | if (flag & O_TRUNC) | 1461 | if (flag & O_TRUNC) |
1509 | return -EPERM; | 1462 | return -EPERM; |
@@ -1547,7 +1500,7 @@ static int handle_truncate(struct path *path) | |||
1547 | * what get passed to sys_open(). | 1500 | * what get passed to sys_open(). |
1548 | */ | 1501 | */ |
1549 | static int __open_namei_create(struct nameidata *nd, struct path *path, | 1502 | static int __open_namei_create(struct nameidata *nd, struct path *path, |
1550 | int flag, int mode) | 1503 | int open_flag, int mode) |
1551 | { | 1504 | { |
1552 | int error; | 1505 | int error; |
1553 | struct dentry *dir = nd->path.dentry; | 1506 | struct dentry *dir = nd->path.dentry; |
@@ -1565,7 +1518,7 @@ out_unlock: | |||
1565 | if (error) | 1518 | if (error) |
1566 | return error; | 1519 | return error; |
1567 | /* Don't check for write permission, don't truncate */ | 1520 | /* Don't check for write permission, don't truncate */ |
1568 | return may_open(&nd->path, 0, flag & ~O_TRUNC); | 1521 | return may_open(&nd->path, 0, open_flag & ~O_TRUNC); |
1569 | } | 1522 | } |
1570 | 1523 | ||
1571 | /* | 1524 | /* |
@@ -1603,129 +1556,132 @@ static int open_will_truncate(int flag, struct inode *inode) | |||
1603 | return (flag & O_TRUNC); | 1556 | return (flag & O_TRUNC); |
1604 | } | 1557 | } |
1605 | 1558 | ||
1606 | /* | 1559 | static struct file *finish_open(struct nameidata *nd, |
1607 | * Note that the low bits of the passed in "open_flag" | 1560 | int open_flag, int acc_mode) |
1608 | * are not the same as in the local variable "flag". See | ||
1609 | * open_to_namei_flags() for more details. | ||
1610 | */ | ||
1611 | struct file *do_filp_open(int dfd, const char *pathname, | ||
1612 | int open_flag, int mode, int acc_mode) | ||
1613 | { | 1561 | { |
1614 | struct file *filp; | 1562 | struct file *filp; |
1615 | struct nameidata nd; | ||
1616 | int error; | ||
1617 | struct path path; | ||
1618 | struct dentry *dir; | ||
1619 | int count = 0; | ||
1620 | int will_truncate; | 1563 | int will_truncate; |
1621 | int flag = open_to_namei_flags(open_flag); | 1564 | int error; |
1622 | int force_reval = 0; | ||
1623 | 1565 | ||
1566 | will_truncate = open_will_truncate(open_flag, nd->path.dentry->d_inode); | ||
1567 | if (will_truncate) { | ||
1568 | error = mnt_want_write(nd->path.mnt); | ||
1569 | if (error) | ||
1570 | goto exit; | ||
1571 | } | ||
1572 | error = may_open(&nd->path, acc_mode, open_flag); | ||
1573 | if (error) { | ||
1574 | if (will_truncate) | ||
1575 | mnt_drop_write(nd->path.mnt); | ||
1576 | goto exit; | ||
1577 | } | ||
1578 | filp = nameidata_to_filp(nd); | ||
1579 | if (!IS_ERR(filp)) { | ||
1580 | error = ima_file_check(filp, acc_mode); | ||
1581 | if (error) { | ||
1582 | fput(filp); | ||
1583 | filp = ERR_PTR(error); | ||
1584 | } | ||
1585 | } | ||
1586 | if (!IS_ERR(filp)) { | ||
1587 | if (will_truncate) { | ||
1588 | error = handle_truncate(&nd->path); | ||
1589 | if (error) { | ||
1590 | fput(filp); | ||
1591 | filp = ERR_PTR(error); | ||
1592 | } | ||
1593 | } | ||
1594 | } | ||
1624 | /* | 1595 | /* |
1625 | * O_SYNC is implemented as __O_SYNC|O_DSYNC. As many places only | 1596 | * It is now safe to drop the mnt write |
1626 | * check for O_DSYNC if the need any syncing at all we enforce it's | 1597 | * because the filp has had a write taken |
1627 | * always set instead of having to deal with possibly weird behaviour | 1598 | * on its behalf. |
1628 | * for malicious applications setting only __O_SYNC. | ||
1629 | */ | 1599 | */ |
1630 | if (open_flag & __O_SYNC) | 1600 | if (will_truncate) |
1631 | open_flag |= O_DSYNC; | 1601 | mnt_drop_write(nd->path.mnt); |
1632 | 1602 | return filp; | |
1633 | if (!acc_mode) | ||
1634 | acc_mode = MAY_OPEN | ACC_MODE(open_flag); | ||
1635 | 1603 | ||
1636 | /* O_TRUNC implies we need access checks for write permissions */ | 1604 | exit: |
1637 | if (flag & O_TRUNC) | 1605 | if (!IS_ERR(nd->intent.open.file)) |
1638 | acc_mode |= MAY_WRITE; | 1606 | release_open_intent(nd); |
1607 | path_put(&nd->path); | ||
1608 | return ERR_PTR(error); | ||
1609 | } | ||
1639 | 1610 | ||
1640 | /* Allow the LSM permission hook to distinguish append | 1611 | static struct file *do_last(struct nameidata *nd, struct path *path, |
1641 | access from general write access. */ | 1612 | int open_flag, int acc_mode, |
1642 | if (flag & O_APPEND) | 1613 | int mode, const char *pathname, |
1643 | acc_mode |= MAY_APPEND; | 1614 | int *want_dir) |
1615 | { | ||
1616 | struct dentry *dir = nd->path.dentry; | ||
1617 | struct file *filp; | ||
1618 | int error = -EISDIR; | ||
1644 | 1619 | ||
1645 | /* | 1620 | switch (nd->last_type) { |
1646 | * The simplest case - just a plain lookup. | 1621 | case LAST_DOTDOT: |
1647 | */ | 1622 | follow_dotdot(nd); |
1648 | if (!(flag & O_CREAT)) { | 1623 | dir = nd->path.dentry; |
1649 | filp = get_empty_filp(); | 1624 | if (nd->path.mnt->mnt_sb->s_type->fs_flags & FS_REVAL_DOT) { |
1650 | 1625 | if (!dir->d_op->d_revalidate(dir, nd)) { | |
1651 | if (filp == NULL) | 1626 | error = -ESTALE; |
1652 | return ERR_PTR(-ENFILE); | 1627 | goto exit; |
1653 | nd.intent.open.file = filp; | ||
1654 | filp->f_flags = open_flag; | ||
1655 | nd.intent.open.flags = flag; | ||
1656 | nd.intent.open.create_mode = 0; | ||
1657 | error = do_path_lookup(dfd, pathname, | ||
1658 | lookup_flags(flag)|LOOKUP_OPEN, &nd); | ||
1659 | if (IS_ERR(nd.intent.open.file)) { | ||
1660 | if (error == 0) { | ||
1661 | error = PTR_ERR(nd.intent.open.file); | ||
1662 | path_put(&nd.path); | ||
1663 | } | 1628 | } |
1664 | } else if (error) | 1629 | } |
1665 | release_open_intent(&nd); | 1630 | /* fallthrough */ |
1666 | if (error) | 1631 | case LAST_DOT: |
1667 | return ERR_PTR(error); | 1632 | case LAST_ROOT: |
1633 | if (open_flag & O_CREAT) | ||
1634 | goto exit; | ||
1635 | /* fallthrough */ | ||
1636 | case LAST_BIND: | ||
1637 | audit_inode(pathname, dir); | ||
1668 | goto ok; | 1638 | goto ok; |
1669 | } | 1639 | } |
1670 | 1640 | ||
1671 | /* | 1641 | /* trailing slashes? */ |
1672 | * Create - we need to know the parent. | 1642 | if (nd->last.name[nd->last.len]) { |
1673 | */ | 1643 | if (open_flag & O_CREAT) |
1674 | reval: | 1644 | goto exit; |
1675 | error = path_init(dfd, pathname, LOOKUP_PARENT, &nd); | 1645 | *want_dir = 1; |
1676 | if (error) | ||
1677 | return ERR_PTR(error); | ||
1678 | if (force_reval) | ||
1679 | nd.flags |= LOOKUP_REVAL; | ||
1680 | error = path_walk(pathname, &nd); | ||
1681 | if (error) { | ||
1682 | if (nd.root.mnt) | ||
1683 | path_put(&nd.root); | ||
1684 | return ERR_PTR(error); | ||
1685 | } | 1646 | } |
1686 | if (unlikely(!audit_dummy_context())) | ||
1687 | audit_inode(pathname, nd.path.dentry); | ||
1688 | 1647 | ||
1689 | /* | 1648 | /* just plain open? */ |
1690 | * We have the parent and last component. First of all, check | 1649 | if (!(open_flag & O_CREAT)) { |
1691 | * that we are not asked to creat(2) an obvious directory - that | 1650 | error = do_lookup(nd, &nd->last, path); |
1692 | * will not do. | 1651 | if (error) |
1693 | */ | 1652 | goto exit; |
1694 | error = -EISDIR; | 1653 | error = -ENOENT; |
1695 | if (nd.last_type != LAST_NORM || nd.last.name[nd.last.len]) | 1654 | if (!path->dentry->d_inode) |
1696 | goto exit_parent; | 1655 | goto exit_dput; |
1656 | if (path->dentry->d_inode->i_op->follow_link) | ||
1657 | return NULL; | ||
1658 | error = -ENOTDIR; | ||
1659 | if (*want_dir && !path->dentry->d_inode->i_op->lookup) | ||
1660 | goto exit_dput; | ||
1661 | path_to_nameidata(path, nd); | ||
1662 | audit_inode(pathname, nd->path.dentry); | ||
1663 | goto ok; | ||
1664 | } | ||
1697 | 1665 | ||
1698 | error = -ENFILE; | 1666 | /* OK, it's O_CREAT */ |
1699 | filp = get_empty_filp(); | ||
1700 | if (filp == NULL) | ||
1701 | goto exit_parent; | ||
1702 | nd.intent.open.file = filp; | ||
1703 | filp->f_flags = open_flag; | ||
1704 | nd.intent.open.flags = flag; | ||
1705 | nd.intent.open.create_mode = mode; | ||
1706 | dir = nd.path.dentry; | ||
1707 | nd.flags &= ~LOOKUP_PARENT; | ||
1708 | nd.flags |= LOOKUP_CREATE | LOOKUP_OPEN; | ||
1709 | if (flag & O_EXCL) | ||
1710 | nd.flags |= LOOKUP_EXCL; | ||
1711 | mutex_lock(&dir->d_inode->i_mutex); | 1667 | mutex_lock(&dir->d_inode->i_mutex); |
1712 | path.dentry = lookup_hash(&nd); | ||
1713 | path.mnt = nd.path.mnt; | ||
1714 | 1668 | ||
1715 | do_last: | 1669 | path->dentry = lookup_hash(nd); |
1716 | error = PTR_ERR(path.dentry); | 1670 | path->mnt = nd->path.mnt; |
1717 | if (IS_ERR(path.dentry)) { | 1671 | |
1672 | error = PTR_ERR(path->dentry); | ||
1673 | if (IS_ERR(path->dentry)) { | ||
1718 | mutex_unlock(&dir->d_inode->i_mutex); | 1674 | mutex_unlock(&dir->d_inode->i_mutex); |
1719 | goto exit; | 1675 | goto exit; |
1720 | } | 1676 | } |
1721 | 1677 | ||
1722 | if (IS_ERR(nd.intent.open.file)) { | 1678 | if (IS_ERR(nd->intent.open.file)) { |
1723 | error = PTR_ERR(nd.intent.open.file); | 1679 | error = PTR_ERR(nd->intent.open.file); |
1724 | goto exit_mutex_unlock; | 1680 | goto exit_mutex_unlock; |
1725 | } | 1681 | } |
1726 | 1682 | ||
1727 | /* Negative dentry, just create the file */ | 1683 | /* Negative dentry, just create the file */ |
1728 | if (!path.dentry->d_inode) { | 1684 | if (!path->dentry->d_inode) { |
1729 | /* | 1685 | /* |
1730 | * This write is needed to ensure that a | 1686 | * This write is needed to ensure that a |
1731 | * ro->rw transition does not occur between | 1687 | * ro->rw transition does not occur between |
@@ -1733,18 +1689,16 @@ do_last: | |||
1733 | * a permanent write count is taken through | 1689 | * a permanent write count is taken through |
1734 | * the 'struct file' in nameidata_to_filp(). | 1690 | * the 'struct file' in nameidata_to_filp(). |
1735 | */ | 1691 | */ |
1736 | error = mnt_want_write(nd.path.mnt); | 1692 | error = mnt_want_write(nd->path.mnt); |
1737 | if (error) | 1693 | if (error) |
1738 | goto exit_mutex_unlock; | 1694 | goto exit_mutex_unlock; |
1739 | error = __open_namei_create(&nd, &path, flag, mode); | 1695 | error = __open_namei_create(nd, path, open_flag, mode); |
1740 | if (error) { | 1696 | if (error) { |
1741 | mnt_drop_write(nd.path.mnt); | 1697 | mnt_drop_write(nd->path.mnt); |
1742 | goto exit; | 1698 | goto exit; |
1743 | } | 1699 | } |
1744 | filp = nameidata_to_filp(&nd); | 1700 | filp = nameidata_to_filp(nd); |
1745 | mnt_drop_write(nd.path.mnt); | 1701 | mnt_drop_write(nd->path.mnt); |
1746 | if (nd.root.mnt) | ||
1747 | path_put(&nd.root); | ||
1748 | if (!IS_ERR(filp)) { | 1702 | if (!IS_ERR(filp)) { |
1749 | error = ima_file_check(filp, acc_mode); | 1703 | error = ima_file_check(filp, acc_mode); |
1750 | if (error) { | 1704 | if (error) { |
@@ -1759,150 +1713,181 @@ do_last: | |||
1759 | * It already exists. | 1713 | * It already exists. |
1760 | */ | 1714 | */ |
1761 | mutex_unlock(&dir->d_inode->i_mutex); | 1715 | mutex_unlock(&dir->d_inode->i_mutex); |
1762 | audit_inode(pathname, path.dentry); | 1716 | audit_inode(pathname, path->dentry); |
1763 | 1717 | ||
1764 | error = -EEXIST; | 1718 | error = -EEXIST; |
1765 | if (flag & O_EXCL) | 1719 | if (open_flag & O_EXCL) |
1766 | goto exit_dput; | 1720 | goto exit_dput; |
1767 | 1721 | ||
1768 | if (__follow_mount(&path)) { | 1722 | if (__follow_mount(path)) { |
1769 | error = -ELOOP; | 1723 | error = -ELOOP; |
1770 | if (flag & O_NOFOLLOW) | 1724 | if (open_flag & O_NOFOLLOW) |
1771 | goto exit_dput; | 1725 | goto exit_dput; |
1772 | } | 1726 | } |
1773 | 1727 | ||
1774 | error = -ENOENT; | 1728 | error = -ENOENT; |
1775 | if (!path.dentry->d_inode) | 1729 | if (!path->dentry->d_inode) |
1776 | goto exit_dput; | 1730 | goto exit_dput; |
1777 | if (path.dentry->d_inode->i_op->follow_link) | ||
1778 | goto do_link; | ||
1779 | 1731 | ||
1780 | path_to_nameidata(&path, &nd); | 1732 | if (path->dentry->d_inode->i_op->follow_link) |
1733 | return NULL; | ||
1734 | |||
1735 | path_to_nameidata(path, nd); | ||
1781 | error = -EISDIR; | 1736 | error = -EISDIR; |
1782 | if (S_ISDIR(path.dentry->d_inode->i_mode)) | 1737 | if (S_ISDIR(path->dentry->d_inode->i_mode)) |
1783 | goto exit; | 1738 | goto exit; |
1784 | ok: | 1739 | ok: |
1740 | filp = finish_open(nd, open_flag, acc_mode); | ||
1741 | return filp; | ||
1742 | |||
1743 | exit_mutex_unlock: | ||
1744 | mutex_unlock(&dir->d_inode->i_mutex); | ||
1745 | exit_dput: | ||
1746 | path_put_conditional(path, nd); | ||
1747 | exit: | ||
1748 | if (!IS_ERR(nd->intent.open.file)) | ||
1749 | release_open_intent(nd); | ||
1750 | path_put(&nd->path); | ||
1751 | return ERR_PTR(error); | ||
1752 | } | ||
1753 | |||
1754 | /* | ||
1755 | * Note that the low bits of the passed in "open_flag" | ||
1756 | * are not the same as in the local variable "flag". See | ||
1757 | * open_to_namei_flags() for more details. | ||
1758 | */ | ||
1759 | struct file *do_filp_open(int dfd, const char *pathname, | ||
1760 | int open_flag, int mode, int acc_mode) | ||
1761 | { | ||
1762 | struct file *filp; | ||
1763 | struct nameidata nd; | ||
1764 | int error; | ||
1765 | struct path path; | ||
1766 | int count = 0; | ||
1767 | int flag = open_to_namei_flags(open_flag); | ||
1768 | int force_reval = 0; | ||
1769 | int want_dir = open_flag & O_DIRECTORY; | ||
1770 | |||
1771 | if (!(open_flag & O_CREAT)) | ||
1772 | mode = 0; | ||
1773 | |||
1785 | /* | 1774 | /* |
1786 | * Consider: | 1775 | * O_SYNC is implemented as __O_SYNC|O_DSYNC. As many places only |
1787 | * 1. may_open() truncates a file | 1776 | * check for O_DSYNC if the need any syncing at all we enforce it's |
1788 | * 2. a rw->ro mount transition occurs | 1777 | * always set instead of having to deal with possibly weird behaviour |
1789 | * 3. nameidata_to_filp() fails due to | 1778 | * for malicious applications setting only __O_SYNC. |
1790 | * the ro mount. | ||
1791 | * That would be inconsistent, and should | ||
1792 | * be avoided. Taking this mnt write here | ||
1793 | * ensures that (2) can not occur. | ||
1794 | */ | 1779 | */ |
1795 | will_truncate = open_will_truncate(flag, nd.path.dentry->d_inode); | 1780 | if (open_flag & __O_SYNC) |
1796 | if (will_truncate) { | 1781 | open_flag |= O_DSYNC; |
1797 | error = mnt_want_write(nd.path.mnt); | 1782 | |
1798 | if (error) | 1783 | if (!acc_mode) |
1799 | goto exit; | 1784 | acc_mode = MAY_OPEN | ACC_MODE(open_flag); |
1800 | } | 1785 | |
1801 | error = may_open(&nd.path, acc_mode, flag); | 1786 | /* O_TRUNC implies we need access checks for write permissions */ |
1787 | if (open_flag & O_TRUNC) | ||
1788 | acc_mode |= MAY_WRITE; | ||
1789 | |||
1790 | /* Allow the LSM permission hook to distinguish append | ||
1791 | access from general write access. */ | ||
1792 | if (open_flag & O_APPEND) | ||
1793 | acc_mode |= MAY_APPEND; | ||
1794 | |||
1795 | /* find the parent */ | ||
1796 | reval: | ||
1797 | error = path_init(dfd, pathname, LOOKUP_PARENT, &nd); | ||
1798 | if (error) | ||
1799 | return ERR_PTR(error); | ||
1800 | if (force_reval) | ||
1801 | nd.flags |= LOOKUP_REVAL; | ||
1802 | |||
1803 | current->total_link_count = 0; | ||
1804 | error = link_path_walk(pathname, &nd); | ||
1802 | if (error) { | 1805 | if (error) { |
1803 | if (will_truncate) | 1806 | filp = ERR_PTR(error); |
1804 | mnt_drop_write(nd.path.mnt); | 1807 | goto out; |
1805 | goto exit; | ||
1806 | } | ||
1807 | filp = nameidata_to_filp(&nd); | ||
1808 | if (!IS_ERR(filp)) { | ||
1809 | error = ima_file_check(filp, acc_mode); | ||
1810 | if (error) { | ||
1811 | fput(filp); | ||
1812 | filp = ERR_PTR(error); | ||
1813 | } | ||
1814 | } | 1808 | } |
1815 | if (!IS_ERR(filp)) { | 1809 | if (unlikely(!audit_dummy_context()) && (open_flag & O_CREAT)) |
1816 | if (acc_mode & MAY_WRITE) | 1810 | audit_inode(pathname, nd.path.dentry); |
1817 | vfs_dq_init(nd.path.dentry->d_inode); | ||
1818 | 1811 | ||
1819 | if (will_truncate) { | ||
1820 | error = handle_truncate(&nd.path); | ||
1821 | if (error) { | ||
1822 | fput(filp); | ||
1823 | filp = ERR_PTR(error); | ||
1824 | } | ||
1825 | } | ||
1826 | } | ||
1827 | /* | 1812 | /* |
1828 | * It is now safe to drop the mnt write | 1813 | * We have the parent and last component. |
1829 | * because the filp has had a write taken | ||
1830 | * on its behalf. | ||
1831 | */ | 1814 | */ |
1832 | if (will_truncate) | 1815 | |
1833 | mnt_drop_write(nd.path.mnt); | 1816 | error = -ENFILE; |
1817 | filp = get_empty_filp(); | ||
1818 | if (filp == NULL) | ||
1819 | goto exit_parent; | ||
1820 | nd.intent.open.file = filp; | ||
1821 | filp->f_flags = open_flag; | ||
1822 | nd.intent.open.flags = flag; | ||
1823 | nd.intent.open.create_mode = mode; | ||
1824 | nd.flags &= ~LOOKUP_PARENT; | ||
1825 | nd.flags |= LOOKUP_OPEN; | ||
1826 | if (open_flag & O_CREAT) { | ||
1827 | nd.flags |= LOOKUP_CREATE; | ||
1828 | if (open_flag & O_EXCL) | ||
1829 | nd.flags |= LOOKUP_EXCL; | ||
1830 | } | ||
1831 | filp = do_last(&nd, &path, open_flag, acc_mode, mode, pathname, &want_dir); | ||
1832 | while (unlikely(!filp)) { /* trailing symlink */ | ||
1833 | struct path holder; | ||
1834 | struct inode *inode = path.dentry->d_inode; | ||
1835 | void *cookie; | ||
1836 | error = -ELOOP; | ||
1837 | /* S_ISDIR part is a temporary automount kludge */ | ||
1838 | if ((open_flag & O_NOFOLLOW) && !S_ISDIR(inode->i_mode)) | ||
1839 | goto exit_dput; | ||
1840 | if (count++ == 32) | ||
1841 | goto exit_dput; | ||
1842 | /* | ||
1843 | * This is subtle. Instead of calling do_follow_link() we do | ||
1844 | * the thing by hands. The reason is that this way we have zero | ||
1845 | * link_count and path_walk() (called from ->follow_link) | ||
1846 | * honoring LOOKUP_PARENT. After that we have the parent and | ||
1847 | * last component, i.e. we are in the same situation as after | ||
1848 | * the first path_walk(). Well, almost - if the last component | ||
1849 | * is normal we get its copy stored in nd->last.name and we will | ||
1850 | * have to putname() it when we are done. Procfs-like symlinks | ||
1851 | * just set LAST_BIND. | ||
1852 | */ | ||
1853 | nd.flags |= LOOKUP_PARENT; | ||
1854 | error = security_inode_follow_link(path.dentry, &nd); | ||
1855 | if (error) | ||
1856 | goto exit_dput; | ||
1857 | error = __do_follow_link(&path, &nd, &cookie); | ||
1858 | if (unlikely(error)) { | ||
1859 | /* nd.path had been dropped */ | ||
1860 | if (!IS_ERR(cookie) && inode->i_op->put_link) | ||
1861 | inode->i_op->put_link(path.dentry, &nd, cookie); | ||
1862 | path_put(&path); | ||
1863 | release_open_intent(&nd); | ||
1864 | filp = ERR_PTR(error); | ||
1865 | goto out; | ||
1866 | } | ||
1867 | holder = path; | ||
1868 | nd.flags &= ~LOOKUP_PARENT; | ||
1869 | filp = do_last(&nd, &path, open_flag, acc_mode, mode, pathname, &want_dir); | ||
1870 | if (inode->i_op->put_link) | ||
1871 | inode->i_op->put_link(holder.dentry, &nd, cookie); | ||
1872 | path_put(&holder); | ||
1873 | } | ||
1874 | out: | ||
1834 | if (nd.root.mnt) | 1875 | if (nd.root.mnt) |
1835 | path_put(&nd.root); | 1876 | path_put(&nd.root); |
1877 | if (filp == ERR_PTR(-ESTALE) && !force_reval) { | ||
1878 | force_reval = 1; | ||
1879 | goto reval; | ||
1880 | } | ||
1836 | return filp; | 1881 | return filp; |
1837 | 1882 | ||
1838 | exit_mutex_unlock: | ||
1839 | mutex_unlock(&dir->d_inode->i_mutex); | ||
1840 | exit_dput: | 1883 | exit_dput: |
1841 | path_put_conditional(&path, &nd); | 1884 | path_put_conditional(&path, &nd); |
1842 | exit: | ||
1843 | if (!IS_ERR(nd.intent.open.file)) | 1885 | if (!IS_ERR(nd.intent.open.file)) |
1844 | release_open_intent(&nd); | 1886 | release_open_intent(&nd); |
1845 | exit_parent: | 1887 | exit_parent: |
1846 | if (nd.root.mnt) | ||
1847 | path_put(&nd.root); | ||
1848 | path_put(&nd.path); | 1888 | path_put(&nd.path); |
1849 | return ERR_PTR(error); | 1889 | filp = ERR_PTR(error); |
1850 | 1890 | goto out; | |
1851 | do_link: | ||
1852 | error = -ELOOP; | ||
1853 | if (flag & O_NOFOLLOW) | ||
1854 | goto exit_dput; | ||
1855 | /* | ||
1856 | * This is subtle. Instead of calling do_follow_link() we do the | ||
1857 | * thing by hands. The reason is that this way we have zero link_count | ||
1858 | * and path_walk() (called from ->follow_link) honoring LOOKUP_PARENT. | ||
1859 | * After that we have the parent and last component, i.e. | ||
1860 | * we are in the same situation as after the first path_walk(). | ||
1861 | * Well, almost - if the last component is normal we get its copy | ||
1862 | * stored in nd->last.name and we will have to putname() it when we | ||
1863 | * are done. Procfs-like symlinks just set LAST_BIND. | ||
1864 | */ | ||
1865 | nd.flags |= LOOKUP_PARENT; | ||
1866 | error = security_inode_follow_link(path.dentry, &nd); | ||
1867 | if (error) | ||
1868 | goto exit_dput; | ||
1869 | error = __do_follow_link(&path, &nd); | ||
1870 | path_put(&path); | ||
1871 | if (error) { | ||
1872 | /* Does someone understand code flow here? Or it is only | ||
1873 | * me so stupid? Anathema to whoever designed this non-sense | ||
1874 | * with "intent.open". | ||
1875 | */ | ||
1876 | release_open_intent(&nd); | ||
1877 | if (nd.root.mnt) | ||
1878 | path_put(&nd.root); | ||
1879 | if (error == -ESTALE && !force_reval) { | ||
1880 | force_reval = 1; | ||
1881 | goto reval; | ||
1882 | } | ||
1883 | return ERR_PTR(error); | ||
1884 | } | ||
1885 | nd.flags &= ~LOOKUP_PARENT; | ||
1886 | if (nd.last_type == LAST_BIND) | ||
1887 | goto ok; | ||
1888 | error = -EISDIR; | ||
1889 | if (nd.last_type != LAST_NORM) | ||
1890 | goto exit; | ||
1891 | if (nd.last.name[nd.last.len]) { | ||
1892 | __putname(nd.last.name); | ||
1893 | goto exit; | ||
1894 | } | ||
1895 | error = -ELOOP; | ||
1896 | if (count++==32) { | ||
1897 | __putname(nd.last.name); | ||
1898 | goto exit; | ||
1899 | } | ||
1900 | dir = nd.path.dentry; | ||
1901 | mutex_lock(&dir->d_inode->i_mutex); | ||
1902 | path.dentry = lookup_hash(&nd); | ||
1903 | path.mnt = nd.path.mnt; | ||
1904 | __putname(nd.last.name); | ||
1905 | goto do_last; | ||
1906 | } | 1891 | } |
1907 | 1892 | ||
1908 | /** | 1893 | /** |
@@ -1996,7 +1981,6 @@ int vfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t dev) | |||
1996 | if (error) | 1981 | if (error) |
1997 | return error; | 1982 | return error; |
1998 | 1983 | ||
1999 | vfs_dq_init(dir); | ||
2000 | error = dir->i_op->mknod(dir, dentry, mode, dev); | 1984 | error = dir->i_op->mknod(dir, dentry, mode, dev); |
2001 | if (!error) | 1985 | if (!error) |
2002 | fsnotify_create(dir, dentry); | 1986 | fsnotify_create(dir, dentry); |
@@ -2095,7 +2079,6 @@ int vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
2095 | if (error) | 2079 | if (error) |
2096 | return error; | 2080 | return error; |
2097 | 2081 | ||
2098 | vfs_dq_init(dir); | ||
2099 | error = dir->i_op->mkdir(dir, dentry, mode); | 2082 | error = dir->i_op->mkdir(dir, dentry, mode); |
2100 | if (!error) | 2083 | if (!error) |
2101 | fsnotify_mkdir(dir, dentry); | 2084 | fsnotify_mkdir(dir, dentry); |
@@ -2181,8 +2164,6 @@ int vfs_rmdir(struct inode *dir, struct dentry *dentry) | |||
2181 | if (!dir->i_op->rmdir) | 2164 | if (!dir->i_op->rmdir) |
2182 | return -EPERM; | 2165 | return -EPERM; |
2183 | 2166 | ||
2184 | vfs_dq_init(dir); | ||
2185 | |||
2186 | mutex_lock(&dentry->d_inode->i_mutex); | 2167 | mutex_lock(&dentry->d_inode->i_mutex); |
2187 | dentry_unhash(dentry); | 2168 | dentry_unhash(dentry); |
2188 | if (d_mountpoint(dentry)) | 2169 | if (d_mountpoint(dentry)) |
@@ -2268,15 +2249,16 @@ int vfs_unlink(struct inode *dir, struct dentry *dentry) | |||
2268 | if (!dir->i_op->unlink) | 2249 | if (!dir->i_op->unlink) |
2269 | return -EPERM; | 2250 | return -EPERM; |
2270 | 2251 | ||
2271 | vfs_dq_init(dir); | ||
2272 | |||
2273 | mutex_lock(&dentry->d_inode->i_mutex); | 2252 | mutex_lock(&dentry->d_inode->i_mutex); |
2274 | if (d_mountpoint(dentry)) | 2253 | if (d_mountpoint(dentry)) |
2275 | error = -EBUSY; | 2254 | error = -EBUSY; |
2276 | else { | 2255 | else { |
2277 | error = security_inode_unlink(dir, dentry); | 2256 | error = security_inode_unlink(dir, dentry); |
2278 | if (!error) | 2257 | if (!error) { |
2279 | error = dir->i_op->unlink(dir, dentry); | 2258 | error = dir->i_op->unlink(dir, dentry); |
2259 | if (!error) | ||
2260 | dentry->d_inode->i_flags |= S_DEAD; | ||
2261 | } | ||
2280 | } | 2262 | } |
2281 | mutex_unlock(&dentry->d_inode->i_mutex); | 2263 | mutex_unlock(&dentry->d_inode->i_mutex); |
2282 | 2264 | ||
@@ -2379,7 +2361,6 @@ int vfs_symlink(struct inode *dir, struct dentry *dentry, const char *oldname) | |||
2379 | if (error) | 2361 | if (error) |
2380 | return error; | 2362 | return error; |
2381 | 2363 | ||
2382 | vfs_dq_init(dir); | ||
2383 | error = dir->i_op->symlink(dir, dentry, oldname); | 2364 | error = dir->i_op->symlink(dir, dentry, oldname); |
2384 | if (!error) | 2365 | if (!error) |
2385 | fsnotify_create(dir, dentry); | 2366 | fsnotify_create(dir, dentry); |
@@ -2463,7 +2444,6 @@ int vfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_de | |||
2463 | return error; | 2444 | return error; |
2464 | 2445 | ||
2465 | mutex_lock(&inode->i_mutex); | 2446 | mutex_lock(&inode->i_mutex); |
2466 | vfs_dq_init(dir); | ||
2467 | error = dir->i_op->link(old_dentry, dir, new_dentry); | 2447 | error = dir->i_op->link(old_dentry, dir, new_dentry); |
2468 | mutex_unlock(&inode->i_mutex); | 2448 | mutex_unlock(&inode->i_mutex); |
2469 | if (!error) | 2449 | if (!error) |
@@ -2629,6 +2609,8 @@ static int vfs_rename_other(struct inode *old_dir, struct dentry *old_dentry, | |||
2629 | else | 2609 | else |
2630 | error = old_dir->i_op->rename(old_dir, old_dentry, new_dir, new_dentry); | 2610 | error = old_dir->i_op->rename(old_dir, old_dentry, new_dir, new_dentry); |
2631 | if (!error) { | 2611 | if (!error) { |
2612 | if (target) | ||
2613 | target->i_flags |= S_DEAD; | ||
2632 | if (!(old_dir->i_sb->s_type->fs_flags & FS_RENAME_DOES_D_MOVE)) | 2614 | if (!(old_dir->i_sb->s_type->fs_flags & FS_RENAME_DOES_D_MOVE)) |
2633 | d_move(old_dentry, new_dentry); | 2615 | d_move(old_dentry, new_dentry); |
2634 | } | 2616 | } |
@@ -2662,20 +2644,15 @@ int vfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
2662 | if (!old_dir->i_op->rename) | 2644 | if (!old_dir->i_op->rename) |
2663 | return -EPERM; | 2645 | return -EPERM; |
2664 | 2646 | ||
2665 | vfs_dq_init(old_dir); | ||
2666 | vfs_dq_init(new_dir); | ||
2667 | |||
2668 | old_name = fsnotify_oldname_init(old_dentry->d_name.name); | 2647 | old_name = fsnotify_oldname_init(old_dentry->d_name.name); |
2669 | 2648 | ||
2670 | if (is_dir) | 2649 | if (is_dir) |
2671 | error = vfs_rename_dir(old_dir,old_dentry,new_dir,new_dentry); | 2650 | error = vfs_rename_dir(old_dir,old_dentry,new_dir,new_dentry); |
2672 | else | 2651 | else |
2673 | error = vfs_rename_other(old_dir,old_dentry,new_dir,new_dentry); | 2652 | error = vfs_rename_other(old_dir,old_dentry,new_dir,new_dentry); |
2674 | if (!error) { | 2653 | if (!error) |
2675 | const char *new_name = old_dentry->d_name.name; | 2654 | fsnotify_move(old_dir, new_dir, old_name, is_dir, |
2676 | fsnotify_move(old_dir, new_dir, old_name, new_name, is_dir, | ||
2677 | new_dentry->d_inode, old_dentry); | 2655 | new_dentry->d_inode, old_dentry); |
2678 | } | ||
2679 | fsnotify_oldname_free(old_name); | 2656 | fsnotify_oldname_free(old_name); |
2680 | 2657 | ||
2681 | return error; | 2658 | return error; |
diff --git a/fs/namespace.c b/fs/namespace.c index c768f733c8d6..8174c8ab5c70 100644 --- a/fs/namespace.c +++ b/fs/namespace.c | |||
@@ -573,7 +573,7 @@ static struct vfsmount *clone_mnt(struct vfsmount *old, struct dentry *root, | |||
573 | mnt->mnt_master = old; | 573 | mnt->mnt_master = old; |
574 | CLEAR_MNT_SHARED(mnt); | 574 | CLEAR_MNT_SHARED(mnt); |
575 | } else if (!(flag & CL_PRIVATE)) { | 575 | } else if (!(flag & CL_PRIVATE)) { |
576 | if ((flag & CL_PROPAGATION) || IS_MNT_SHARED(old)) | 576 | if ((flag & CL_MAKE_SHARED) || IS_MNT_SHARED(old)) |
577 | list_add(&mnt->mnt_share, &old->mnt_share); | 577 | list_add(&mnt->mnt_share, &old->mnt_share); |
578 | if (IS_MNT_SLAVE(old)) | 578 | if (IS_MNT_SLAVE(old)) |
579 | list_add(&mnt->mnt_slave, &old->mnt_slave); | 579 | list_add(&mnt->mnt_slave, &old->mnt_slave); |
@@ -737,6 +737,21 @@ static void m_stop(struct seq_file *m, void *v) | |||
737 | up_read(&namespace_sem); | 737 | up_read(&namespace_sem); |
738 | } | 738 | } |
739 | 739 | ||
740 | int mnt_had_events(struct proc_mounts *p) | ||
741 | { | ||
742 | struct mnt_namespace *ns = p->ns; | ||
743 | int res = 0; | ||
744 | |||
745 | spin_lock(&vfsmount_lock); | ||
746 | if (p->event != ns->event) { | ||
747 | p->event = ns->event; | ||
748 | res = 1; | ||
749 | } | ||
750 | spin_unlock(&vfsmount_lock); | ||
751 | |||
752 | return res; | ||
753 | } | ||
754 | |||
740 | struct proc_fs_info { | 755 | struct proc_fs_info { |
741 | int flag; | 756 | int flag; |
742 | const char *str; | 757 | const char *str; |
@@ -1121,8 +1136,15 @@ SYSCALL_DEFINE2(umount, char __user *, name, int, flags) | |||
1121 | { | 1136 | { |
1122 | struct path path; | 1137 | struct path path; |
1123 | int retval; | 1138 | int retval; |
1139 | int lookup_flags = 0; | ||
1124 | 1140 | ||
1125 | retval = user_path(name, &path); | 1141 | if (flags & ~(MNT_FORCE | MNT_DETACH | MNT_EXPIRE | UMOUNT_NOFOLLOW)) |
1142 | return -EINVAL; | ||
1143 | |||
1144 | if (!(flags & UMOUNT_NOFOLLOW)) | ||
1145 | lookup_flags |= LOOKUP_FOLLOW; | ||
1146 | |||
1147 | retval = user_path_at(AT_FDCWD, name, lookup_flags, &path); | ||
1126 | if (retval) | 1148 | if (retval) |
1127 | goto out; | 1149 | goto out; |
1128 | retval = -EINVAL; | 1150 | retval = -EINVAL; |
@@ -1246,6 +1268,21 @@ void drop_collected_mounts(struct vfsmount *mnt) | |||
1246 | release_mounts(&umount_list); | 1268 | release_mounts(&umount_list); |
1247 | } | 1269 | } |
1248 | 1270 | ||
1271 | int iterate_mounts(int (*f)(struct vfsmount *, void *), void *arg, | ||
1272 | struct vfsmount *root) | ||
1273 | { | ||
1274 | struct vfsmount *mnt; | ||
1275 | int res = f(root, arg); | ||
1276 | if (res) | ||
1277 | return res; | ||
1278 | list_for_each_entry(mnt, &root->mnt_list, mnt_list) { | ||
1279 | res = f(mnt, arg); | ||
1280 | if (res) | ||
1281 | return res; | ||
1282 | } | ||
1283 | return 0; | ||
1284 | } | ||
1285 | |||
1249 | static void cleanup_group_ids(struct vfsmount *mnt, struct vfsmount *end) | 1286 | static void cleanup_group_ids(struct vfsmount *mnt, struct vfsmount *end) |
1250 | { | 1287 | { |
1251 | struct vfsmount *p; | 1288 | struct vfsmount *p; |
@@ -1538,7 +1575,7 @@ static int do_remount(struct path *path, int flags, int mnt_flags, | |||
1538 | err = do_remount_sb(sb, flags, data, 0); | 1575 | err = do_remount_sb(sb, flags, data, 0); |
1539 | if (!err) { | 1576 | if (!err) { |
1540 | spin_lock(&vfsmount_lock); | 1577 | spin_lock(&vfsmount_lock); |
1541 | mnt_flags |= path->mnt->mnt_flags & MNT_PNODE_MASK; | 1578 | mnt_flags |= path->mnt->mnt_flags & MNT_PROPAGATION_MASK; |
1542 | path->mnt->mnt_flags = mnt_flags; | 1579 | path->mnt->mnt_flags = mnt_flags; |
1543 | spin_unlock(&vfsmount_lock); | 1580 | spin_unlock(&vfsmount_lock); |
1544 | } | 1581 | } |
@@ -1671,7 +1708,7 @@ int do_add_mount(struct vfsmount *newmnt, struct path *path, | |||
1671 | { | 1708 | { |
1672 | int err; | 1709 | int err; |
1673 | 1710 | ||
1674 | mnt_flags &= ~(MNT_SHARED | MNT_WRITE_HOLD); | 1711 | mnt_flags &= ~(MNT_SHARED | MNT_WRITE_HOLD | MNT_INTERNAL); |
1675 | 1712 | ||
1676 | down_write(&namespace_sem); | 1713 | down_write(&namespace_sem); |
1677 | /* Something was mounted here while we slept */ | 1714 | /* Something was mounted here while we slept */ |
@@ -2314,17 +2351,13 @@ void __init mnt_init(void) | |||
2314 | 2351 | ||
2315 | void put_mnt_ns(struct mnt_namespace *ns) | 2352 | void put_mnt_ns(struct mnt_namespace *ns) |
2316 | { | 2353 | { |
2317 | struct vfsmount *root; | ||
2318 | LIST_HEAD(umount_list); | 2354 | LIST_HEAD(umount_list); |
2319 | 2355 | ||
2320 | if (!atomic_dec_and_lock(&ns->count, &vfsmount_lock)) | 2356 | if (!atomic_dec_and_test(&ns->count)) |
2321 | return; | 2357 | return; |
2322 | root = ns->root; | ||
2323 | ns->root = NULL; | ||
2324 | spin_unlock(&vfsmount_lock); | ||
2325 | down_write(&namespace_sem); | 2358 | down_write(&namespace_sem); |
2326 | spin_lock(&vfsmount_lock); | 2359 | spin_lock(&vfsmount_lock); |
2327 | umount_tree(root, 0, &umount_list); | 2360 | umount_tree(ns->root, 0, &umount_list); |
2328 | spin_unlock(&vfsmount_lock); | 2361 | spin_unlock(&vfsmount_lock); |
2329 | up_write(&namespace_sem); | 2362 | up_write(&namespace_sem); |
2330 | release_mounts(&umount_list); | 2363 | release_mounts(&umount_list); |
diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig index 59e5673b4597..a43d07e7b924 100644 --- a/fs/nfs/Kconfig +++ b/fs/nfs/Kconfig | |||
@@ -95,8 +95,7 @@ config ROOT_NFS | |||
95 | Most people say N here. | 95 | Most people say N here. |
96 | 96 | ||
97 | config NFS_FSCACHE | 97 | config NFS_FSCACHE |
98 | bool "Provide NFS client caching support (EXPERIMENTAL)" | 98 | bool "Provide NFS client caching support" |
99 | depends on EXPERIMENTAL | ||
100 | depends on NFS_FS=m && FSCACHE || NFS_FS=y && FSCACHE=y | 99 | depends on NFS_FS=m && FSCACHE || NFS_FS=y && FSCACHE=y |
101 | help | 100 | help |
102 | Say Y here if you want NFS data to be cached locally on disc through | 101 | Say Y here if you want NFS data to be cached locally on disc through |
diff --git a/fs/nfs/callback.h b/fs/nfs/callback.h index d4036be0b589..85a7cfd1b8dd 100644 --- a/fs/nfs/callback.h +++ b/fs/nfs/callback.h | |||
@@ -119,6 +119,14 @@ struct cb_recallanyargs { | |||
119 | }; | 119 | }; |
120 | 120 | ||
121 | extern unsigned nfs4_callback_recallany(struct cb_recallanyargs *args, void *dummy); | 121 | extern unsigned nfs4_callback_recallany(struct cb_recallanyargs *args, void *dummy); |
122 | |||
123 | struct cb_recallslotargs { | ||
124 | struct sockaddr *crsa_addr; | ||
125 | uint32_t crsa_target_max_slots; | ||
126 | }; | ||
127 | extern unsigned nfs4_callback_recallslot(struct cb_recallslotargs *args, | ||
128 | void *dummy); | ||
129 | |||
122 | #endif /* CONFIG_NFS_V4_1 */ | 130 | #endif /* CONFIG_NFS_V4_1 */ |
123 | 131 | ||
124 | extern __be32 nfs4_callback_getattr(struct cb_getattrargs *args, struct cb_getattrres *res); | 132 | extern __be32 nfs4_callback_getattr(struct cb_getattrargs *args, struct cb_getattrres *res); |
diff --git a/fs/nfs/callback_proc.c b/fs/nfs/callback_proc.c index defa9b4c470e..84761b5bb8e2 100644 --- a/fs/nfs/callback_proc.c +++ b/fs/nfs/callback_proc.c | |||
@@ -143,44 +143,49 @@ int nfs41_validate_delegation_stateid(struct nfs_delegation *delegation, const n | |||
143 | * Return success if the sequenceID is one more than what we last saw on | 143 | * Return success if the sequenceID is one more than what we last saw on |
144 | * this slot, accounting for wraparound. Increments the slot's sequence. | 144 | * this slot, accounting for wraparound. Increments the slot's sequence. |
145 | * | 145 | * |
146 | * We don't yet implement a duplicate request cache, so at this time | 146 | * We don't yet implement a duplicate request cache, instead we set the |
147 | * we will log replays, and process them as if we had not seen them before, | 147 | * back channel ca_maxresponsesize_cached to zero. This is OK for now |
148 | * but we don't bump the sequence in the slot. Not too worried about it, | ||
149 | * since we only currently implement idempotent callbacks anyway. | 148 | * since we only currently implement idempotent callbacks anyway. |
150 | * | 149 | * |
151 | * We have a single slot backchannel at this time, so we don't bother | 150 | * We have a single slot backchannel at this time, so we don't bother |
152 | * checking the used_slots bit array on the table. The lower layer guarantees | 151 | * checking the used_slots bit array on the table. The lower layer guarantees |
153 | * a single outstanding callback request at a time. | 152 | * a single outstanding callback request at a time. |
154 | */ | 153 | */ |
155 | static int | 154 | static __be32 |
156 | validate_seqid(struct nfs4_slot_table *tbl, u32 slotid, u32 seqid) | 155 | validate_seqid(struct nfs4_slot_table *tbl, struct cb_sequenceargs * args) |
157 | { | 156 | { |
158 | struct nfs4_slot *slot; | 157 | struct nfs4_slot *slot; |
159 | 158 | ||
160 | dprintk("%s enter. slotid %d seqid %d\n", | 159 | dprintk("%s enter. slotid %d seqid %d\n", |
161 | __func__, slotid, seqid); | 160 | __func__, args->csa_slotid, args->csa_sequenceid); |
162 | 161 | ||
163 | if (slotid > NFS41_BC_MAX_CALLBACKS) | 162 | if (args->csa_slotid > NFS41_BC_MAX_CALLBACKS) |
164 | return htonl(NFS4ERR_BADSLOT); | 163 | return htonl(NFS4ERR_BADSLOT); |
165 | 164 | ||
166 | slot = tbl->slots + slotid; | 165 | slot = tbl->slots + args->csa_slotid; |
167 | dprintk("%s slot table seqid: %d\n", __func__, slot->seq_nr); | 166 | dprintk("%s slot table seqid: %d\n", __func__, slot->seq_nr); |
168 | 167 | ||
169 | /* Normal */ | 168 | /* Normal */ |
170 | if (likely(seqid == slot->seq_nr + 1)) { | 169 | if (likely(args->csa_sequenceid == slot->seq_nr + 1)) { |
171 | slot->seq_nr++; | 170 | slot->seq_nr++; |
172 | return htonl(NFS4_OK); | 171 | return htonl(NFS4_OK); |
173 | } | 172 | } |
174 | 173 | ||
175 | /* Replay */ | 174 | /* Replay */ |
176 | if (seqid == slot->seq_nr) { | 175 | if (args->csa_sequenceid == slot->seq_nr) { |
177 | dprintk("%s seqid %d is a replay - no DRC available\n", | 176 | dprintk("%s seqid %d is a replay\n", |
178 | __func__, seqid); | 177 | __func__, args->csa_sequenceid); |
179 | return htonl(NFS4_OK); | 178 | /* Signal process_op to set this error on next op */ |
179 | if (args->csa_cachethis == 0) | ||
180 | return htonl(NFS4ERR_RETRY_UNCACHED_REP); | ||
181 | |||
182 | /* The ca_maxresponsesize_cached is 0 with no DRC */ | ||
183 | else if (args->csa_cachethis == 1) | ||
184 | return htonl(NFS4ERR_REP_TOO_BIG_TO_CACHE); | ||
180 | } | 185 | } |
181 | 186 | ||
182 | /* Wraparound */ | 187 | /* Wraparound */ |
183 | if (seqid == 1 && (slot->seq_nr + 1) == 0) { | 188 | if (args->csa_sequenceid == 1 && (slot->seq_nr + 1) == 0) { |
184 | slot->seq_nr = 1; | 189 | slot->seq_nr = 1; |
185 | return htonl(NFS4_OK); | 190 | return htonl(NFS4_OK); |
186 | } | 191 | } |
@@ -225,27 +230,87 @@ validate_seqid(struct nfs4_slot_table *tbl, u32 slotid, u32 seqid) | |||
225 | return NULL; | 230 | return NULL; |
226 | } | 231 | } |
227 | 232 | ||
228 | /* FIXME: referring calls should be processed */ | 233 | /* |
229 | unsigned nfs4_callback_sequence(struct cb_sequenceargs *args, | 234 | * For each referring call triple, check the session's slot table for |
235 | * a match. If the slot is in use and the sequence numbers match, the | ||
236 | * client is still waiting for a response to the original request. | ||
237 | */ | ||
238 | static bool referring_call_exists(struct nfs_client *clp, | ||
239 | uint32_t nrclists, | ||
240 | struct referring_call_list *rclists) | ||
241 | { | ||
242 | bool status = 0; | ||
243 | int i, j; | ||
244 | struct nfs4_session *session; | ||
245 | struct nfs4_slot_table *tbl; | ||
246 | struct referring_call_list *rclist; | ||
247 | struct referring_call *ref; | ||
248 | |||
249 | /* | ||
250 | * XXX When client trunking is implemented, this becomes | ||
251 | * a session lookup from within the loop | ||
252 | */ | ||
253 | session = clp->cl_session; | ||
254 | tbl = &session->fc_slot_table; | ||
255 | |||
256 | for (i = 0; i < nrclists; i++) { | ||
257 | rclist = &rclists[i]; | ||
258 | if (memcmp(session->sess_id.data, | ||
259 | rclist->rcl_sessionid.data, | ||
260 | NFS4_MAX_SESSIONID_LEN) != 0) | ||
261 | continue; | ||
262 | |||
263 | for (j = 0; j < rclist->rcl_nrefcalls; j++) { | ||
264 | ref = &rclist->rcl_refcalls[j]; | ||
265 | |||
266 | dprintk("%s: sessionid %x:%x:%x:%x sequenceid %u " | ||
267 | "slotid %u\n", __func__, | ||
268 | ((u32 *)&rclist->rcl_sessionid.data)[0], | ||
269 | ((u32 *)&rclist->rcl_sessionid.data)[1], | ||
270 | ((u32 *)&rclist->rcl_sessionid.data)[2], | ||
271 | ((u32 *)&rclist->rcl_sessionid.data)[3], | ||
272 | ref->rc_sequenceid, ref->rc_slotid); | ||
273 | |||
274 | spin_lock(&tbl->slot_tbl_lock); | ||
275 | status = (test_bit(ref->rc_slotid, tbl->used_slots) && | ||
276 | tbl->slots[ref->rc_slotid].seq_nr == | ||
277 | ref->rc_sequenceid); | ||
278 | spin_unlock(&tbl->slot_tbl_lock); | ||
279 | if (status) | ||
280 | goto out; | ||
281 | } | ||
282 | } | ||
283 | |||
284 | out: | ||
285 | return status; | ||
286 | } | ||
287 | |||
288 | __be32 nfs4_callback_sequence(struct cb_sequenceargs *args, | ||
230 | struct cb_sequenceres *res) | 289 | struct cb_sequenceres *res) |
231 | { | 290 | { |
232 | struct nfs_client *clp; | 291 | struct nfs_client *clp; |
233 | int i, status; | 292 | int i; |
234 | 293 | __be32 status; | |
235 | for (i = 0; i < args->csa_nrclists; i++) | ||
236 | kfree(args->csa_rclists[i].rcl_refcalls); | ||
237 | kfree(args->csa_rclists); | ||
238 | 294 | ||
239 | status = htonl(NFS4ERR_BADSESSION); | 295 | status = htonl(NFS4ERR_BADSESSION); |
240 | clp = find_client_with_session(args->csa_addr, 4, &args->csa_sessionid); | 296 | clp = find_client_with_session(args->csa_addr, 4, &args->csa_sessionid); |
241 | if (clp == NULL) | 297 | if (clp == NULL) |
242 | goto out; | 298 | goto out; |
243 | 299 | ||
244 | status = validate_seqid(&clp->cl_session->bc_slot_table, | 300 | status = validate_seqid(&clp->cl_session->bc_slot_table, args); |
245 | args->csa_slotid, args->csa_sequenceid); | ||
246 | if (status) | 301 | if (status) |
247 | goto out_putclient; | 302 | goto out_putclient; |
248 | 303 | ||
304 | /* | ||
305 | * Check for pending referring calls. If a match is found, a | ||
306 | * related callback was received before the response to the original | ||
307 | * call. | ||
308 | */ | ||
309 | if (referring_call_exists(clp, args->csa_nrclists, args->csa_rclists)) { | ||
310 | status = htonl(NFS4ERR_DELAY); | ||
311 | goto out_putclient; | ||
312 | } | ||
313 | |||
249 | memcpy(&res->csr_sessionid, &args->csa_sessionid, | 314 | memcpy(&res->csr_sessionid, &args->csa_sessionid, |
250 | sizeof(res->csr_sessionid)); | 315 | sizeof(res->csr_sessionid)); |
251 | res->csr_sequenceid = args->csa_sequenceid; | 316 | res->csr_sequenceid = args->csa_sequenceid; |
@@ -256,15 +321,23 @@ unsigned nfs4_callback_sequence(struct cb_sequenceargs *args, | |||
256 | out_putclient: | 321 | out_putclient: |
257 | nfs_put_client(clp); | 322 | nfs_put_client(clp); |
258 | out: | 323 | out: |
259 | dprintk("%s: exit with status = %d\n", __func__, ntohl(status)); | 324 | for (i = 0; i < args->csa_nrclists; i++) |
260 | res->csr_status = status; | 325 | kfree(args->csa_rclists[i].rcl_refcalls); |
261 | return res->csr_status; | 326 | kfree(args->csa_rclists); |
327 | |||
328 | if (status == htonl(NFS4ERR_RETRY_UNCACHED_REP)) | ||
329 | res->csr_status = 0; | ||
330 | else | ||
331 | res->csr_status = status; | ||
332 | dprintk("%s: exit with status = %d res->csr_status %d\n", __func__, | ||
333 | ntohl(status), ntohl(res->csr_status)); | ||
334 | return status; | ||
262 | } | 335 | } |
263 | 336 | ||
264 | unsigned nfs4_callback_recallany(struct cb_recallanyargs *args, void *dummy) | 337 | __be32 nfs4_callback_recallany(struct cb_recallanyargs *args, void *dummy) |
265 | { | 338 | { |
266 | struct nfs_client *clp; | 339 | struct nfs_client *clp; |
267 | int status; | 340 | __be32 status; |
268 | fmode_t flags = 0; | 341 | fmode_t flags = 0; |
269 | 342 | ||
270 | status = htonl(NFS4ERR_OP_NOT_IN_SESSION); | 343 | status = htonl(NFS4ERR_OP_NOT_IN_SESSION); |
@@ -289,4 +362,40 @@ out: | |||
289 | dprintk("%s: exit with status = %d\n", __func__, ntohl(status)); | 362 | dprintk("%s: exit with status = %d\n", __func__, ntohl(status)); |
290 | return status; | 363 | return status; |
291 | } | 364 | } |
365 | |||
366 | /* Reduce the fore channel's max_slots to the target value */ | ||
367 | __be32 nfs4_callback_recallslot(struct cb_recallslotargs *args, void *dummy) | ||
368 | { | ||
369 | struct nfs_client *clp; | ||
370 | struct nfs4_slot_table *fc_tbl; | ||
371 | __be32 status; | ||
372 | |||
373 | status = htonl(NFS4ERR_OP_NOT_IN_SESSION); | ||
374 | clp = nfs_find_client(args->crsa_addr, 4); | ||
375 | if (clp == NULL) | ||
376 | goto out; | ||
377 | |||
378 | dprintk("NFS: CB_RECALL_SLOT request from %s target max slots %d\n", | ||
379 | rpc_peeraddr2str(clp->cl_rpcclient, RPC_DISPLAY_ADDR), | ||
380 | args->crsa_target_max_slots); | ||
381 | |||
382 | fc_tbl = &clp->cl_session->fc_slot_table; | ||
383 | |||
384 | status = htonl(NFS4ERR_BAD_HIGH_SLOT); | ||
385 | if (args->crsa_target_max_slots > fc_tbl->max_slots || | ||
386 | args->crsa_target_max_slots < 1) | ||
387 | goto out_putclient; | ||
388 | |||
389 | status = htonl(NFS4_OK); | ||
390 | if (args->crsa_target_max_slots == fc_tbl->max_slots) | ||
391 | goto out_putclient; | ||
392 | |||
393 | fc_tbl->target_max_slots = args->crsa_target_max_slots; | ||
394 | nfs41_handle_recall_slot(clp); | ||
395 | out_putclient: | ||
396 | nfs_put_client(clp); /* balance nfs_find_client */ | ||
397 | out: | ||
398 | dprintk("%s: exit with status = %d\n", __func__, ntohl(status)); | ||
399 | return status; | ||
400 | } | ||
292 | #endif /* CONFIG_NFS_V4_1 */ | 401 | #endif /* CONFIG_NFS_V4_1 */ |
diff --git a/fs/nfs/callback_xdr.c b/fs/nfs/callback_xdr.c index 8e1a2511c8be..db30c0b398b5 100644 --- a/fs/nfs/callback_xdr.c +++ b/fs/nfs/callback_xdr.c | |||
@@ -24,10 +24,14 @@ | |||
24 | #define CB_OP_SEQUENCE_RES_MAXSZ (CB_OP_HDR_RES_MAXSZ + \ | 24 | #define CB_OP_SEQUENCE_RES_MAXSZ (CB_OP_HDR_RES_MAXSZ + \ |
25 | 4 + 1 + 3) | 25 | 4 + 1 + 3) |
26 | #define CB_OP_RECALLANY_RES_MAXSZ (CB_OP_HDR_RES_MAXSZ) | 26 | #define CB_OP_RECALLANY_RES_MAXSZ (CB_OP_HDR_RES_MAXSZ) |
27 | #define CB_OP_RECALLSLOT_RES_MAXSZ (CB_OP_HDR_RES_MAXSZ) | ||
27 | #endif /* CONFIG_NFS_V4_1 */ | 28 | #endif /* CONFIG_NFS_V4_1 */ |
28 | 29 | ||
29 | #define NFSDBG_FACILITY NFSDBG_CALLBACK | 30 | #define NFSDBG_FACILITY NFSDBG_CALLBACK |
30 | 31 | ||
32 | /* Internal error code */ | ||
33 | #define NFS4ERR_RESOURCE_HDR 11050 | ||
34 | |||
31 | typedef __be32 (*callback_process_op_t)(void *, void *); | 35 | typedef __be32 (*callback_process_op_t)(void *, void *); |
32 | typedef __be32 (*callback_decode_arg_t)(struct svc_rqst *, struct xdr_stream *, void *); | 36 | typedef __be32 (*callback_decode_arg_t)(struct svc_rqst *, struct xdr_stream *, void *); |
33 | typedef __be32 (*callback_encode_res_t)(struct svc_rqst *, struct xdr_stream *, void *); | 37 | typedef __be32 (*callback_encode_res_t)(struct svc_rqst *, struct xdr_stream *, void *); |
@@ -173,7 +177,7 @@ static __be32 decode_op_hdr(struct xdr_stream *xdr, unsigned int *op) | |||
173 | __be32 *p; | 177 | __be32 *p; |
174 | p = read_buf(xdr, 4); | 178 | p = read_buf(xdr, 4); |
175 | if (unlikely(p == NULL)) | 179 | if (unlikely(p == NULL)) |
176 | return htonl(NFS4ERR_RESOURCE); | 180 | return htonl(NFS4ERR_RESOURCE_HDR); |
177 | *op = ntohl(*p); | 181 | *op = ntohl(*p); |
178 | return 0; | 182 | return 0; |
179 | } | 183 | } |
@@ -215,10 +219,10 @@ out: | |||
215 | 219 | ||
216 | #if defined(CONFIG_NFS_V4_1) | 220 | #if defined(CONFIG_NFS_V4_1) |
217 | 221 | ||
218 | static unsigned decode_sessionid(struct xdr_stream *xdr, | 222 | static __be32 decode_sessionid(struct xdr_stream *xdr, |
219 | struct nfs4_sessionid *sid) | 223 | struct nfs4_sessionid *sid) |
220 | { | 224 | { |
221 | uint32_t *p; | 225 | __be32 *p; |
222 | int len = NFS4_MAX_SESSIONID_LEN; | 226 | int len = NFS4_MAX_SESSIONID_LEN; |
223 | 227 | ||
224 | p = read_buf(xdr, len); | 228 | p = read_buf(xdr, len); |
@@ -229,12 +233,12 @@ static unsigned decode_sessionid(struct xdr_stream *xdr, | |||
229 | return 0; | 233 | return 0; |
230 | } | 234 | } |
231 | 235 | ||
232 | static unsigned decode_rc_list(struct xdr_stream *xdr, | 236 | static __be32 decode_rc_list(struct xdr_stream *xdr, |
233 | struct referring_call_list *rc_list) | 237 | struct referring_call_list *rc_list) |
234 | { | 238 | { |
235 | uint32_t *p; | 239 | __be32 *p; |
236 | int i; | 240 | int i; |
237 | unsigned status; | 241 | __be32 status; |
238 | 242 | ||
239 | status = decode_sessionid(xdr, &rc_list->rcl_sessionid); | 243 | status = decode_sessionid(xdr, &rc_list->rcl_sessionid); |
240 | if (status) | 244 | if (status) |
@@ -267,13 +271,13 @@ out: | |||
267 | return status; | 271 | return status; |
268 | } | 272 | } |
269 | 273 | ||
270 | static unsigned decode_cb_sequence_args(struct svc_rqst *rqstp, | 274 | static __be32 decode_cb_sequence_args(struct svc_rqst *rqstp, |
271 | struct xdr_stream *xdr, | 275 | struct xdr_stream *xdr, |
272 | struct cb_sequenceargs *args) | 276 | struct cb_sequenceargs *args) |
273 | { | 277 | { |
274 | uint32_t *p; | 278 | __be32 *p; |
275 | int i; | 279 | int i; |
276 | unsigned status; | 280 | __be32 status; |
277 | 281 | ||
278 | status = decode_sessionid(xdr, &args->csa_sessionid); | 282 | status = decode_sessionid(xdr, &args->csa_sessionid); |
279 | if (status) | 283 | if (status) |
@@ -327,11 +331,11 @@ out_free: | |||
327 | goto out; | 331 | goto out; |
328 | } | 332 | } |
329 | 333 | ||
330 | static unsigned decode_recallany_args(struct svc_rqst *rqstp, | 334 | static __be32 decode_recallany_args(struct svc_rqst *rqstp, |
331 | struct xdr_stream *xdr, | 335 | struct xdr_stream *xdr, |
332 | struct cb_recallanyargs *args) | 336 | struct cb_recallanyargs *args) |
333 | { | 337 | { |
334 | uint32_t *p; | 338 | __be32 *p; |
335 | 339 | ||
336 | args->craa_addr = svc_addr(rqstp); | 340 | args->craa_addr = svc_addr(rqstp); |
337 | p = read_buf(xdr, 4); | 341 | p = read_buf(xdr, 4); |
@@ -346,6 +350,20 @@ static unsigned decode_recallany_args(struct svc_rqst *rqstp, | |||
346 | return 0; | 350 | return 0; |
347 | } | 351 | } |
348 | 352 | ||
353 | static __be32 decode_recallslot_args(struct svc_rqst *rqstp, | ||
354 | struct xdr_stream *xdr, | ||
355 | struct cb_recallslotargs *args) | ||
356 | { | ||
357 | __be32 *p; | ||
358 | |||
359 | args->crsa_addr = svc_addr(rqstp); | ||
360 | p = read_buf(xdr, 4); | ||
361 | if (unlikely(p == NULL)) | ||
362 | return htonl(NFS4ERR_BADXDR); | ||
363 | args->crsa_target_max_slots = ntohl(*p++); | ||
364 | return 0; | ||
365 | } | ||
366 | |||
349 | #endif /* CONFIG_NFS_V4_1 */ | 367 | #endif /* CONFIG_NFS_V4_1 */ |
350 | 368 | ||
351 | static __be32 encode_string(struct xdr_stream *xdr, unsigned int len, const char *str) | 369 | static __be32 encode_string(struct xdr_stream *xdr, unsigned int len, const char *str) |
@@ -465,7 +483,7 @@ static __be32 encode_op_hdr(struct xdr_stream *xdr, uint32_t op, __be32 res) | |||
465 | 483 | ||
466 | p = xdr_reserve_space(xdr, 8); | 484 | p = xdr_reserve_space(xdr, 8); |
467 | if (unlikely(p == NULL)) | 485 | if (unlikely(p == NULL)) |
468 | return htonl(NFS4ERR_RESOURCE); | 486 | return htonl(NFS4ERR_RESOURCE_HDR); |
469 | *p++ = htonl(op); | 487 | *p++ = htonl(op); |
470 | *p = res; | 488 | *p = res; |
471 | return 0; | 489 | return 0; |
@@ -499,10 +517,10 @@ out: | |||
499 | 517 | ||
500 | #if defined(CONFIG_NFS_V4_1) | 518 | #if defined(CONFIG_NFS_V4_1) |
501 | 519 | ||
502 | static unsigned encode_sessionid(struct xdr_stream *xdr, | 520 | static __be32 encode_sessionid(struct xdr_stream *xdr, |
503 | const struct nfs4_sessionid *sid) | 521 | const struct nfs4_sessionid *sid) |
504 | { | 522 | { |
505 | uint32_t *p; | 523 | __be32 *p; |
506 | int len = NFS4_MAX_SESSIONID_LEN; | 524 | int len = NFS4_MAX_SESSIONID_LEN; |
507 | 525 | ||
508 | p = xdr_reserve_space(xdr, len); | 526 | p = xdr_reserve_space(xdr, len); |
@@ -513,11 +531,11 @@ static unsigned encode_sessionid(struct xdr_stream *xdr, | |||
513 | return 0; | 531 | return 0; |
514 | } | 532 | } |
515 | 533 | ||
516 | static unsigned encode_cb_sequence_res(struct svc_rqst *rqstp, | 534 | static __be32 encode_cb_sequence_res(struct svc_rqst *rqstp, |
517 | struct xdr_stream *xdr, | 535 | struct xdr_stream *xdr, |
518 | const struct cb_sequenceres *res) | 536 | const struct cb_sequenceres *res) |
519 | { | 537 | { |
520 | uint32_t *p; | 538 | __be32 *p; |
521 | unsigned status = res->csr_status; | 539 | unsigned status = res->csr_status; |
522 | 540 | ||
523 | if (unlikely(status != 0)) | 541 | if (unlikely(status != 0)) |
@@ -554,6 +572,7 @@ preprocess_nfs41_op(int nop, unsigned int op_nr, struct callback_op **op) | |||
554 | case OP_CB_RECALL: | 572 | case OP_CB_RECALL: |
555 | case OP_CB_SEQUENCE: | 573 | case OP_CB_SEQUENCE: |
556 | case OP_CB_RECALL_ANY: | 574 | case OP_CB_RECALL_ANY: |
575 | case OP_CB_RECALL_SLOT: | ||
557 | *op = &callback_ops[op_nr]; | 576 | *op = &callback_ops[op_nr]; |
558 | break; | 577 | break; |
559 | 578 | ||
@@ -562,7 +581,6 @@ preprocess_nfs41_op(int nop, unsigned int op_nr, struct callback_op **op) | |||
562 | case OP_CB_NOTIFY: | 581 | case OP_CB_NOTIFY: |
563 | case OP_CB_PUSH_DELEG: | 582 | case OP_CB_PUSH_DELEG: |
564 | case OP_CB_RECALLABLE_OBJ_AVAIL: | 583 | case OP_CB_RECALLABLE_OBJ_AVAIL: |
565 | case OP_CB_RECALL_SLOT: | ||
566 | case OP_CB_WANTS_CANCELLED: | 584 | case OP_CB_WANTS_CANCELLED: |
567 | case OP_CB_NOTIFY_LOCK: | 585 | case OP_CB_NOTIFY_LOCK: |
568 | return htonl(NFS4ERR_NOTSUPP); | 586 | return htonl(NFS4ERR_NOTSUPP); |
@@ -602,20 +620,18 @@ preprocess_nfs4_op(unsigned int op_nr, struct callback_op **op) | |||
602 | static __be32 process_op(uint32_t minorversion, int nop, | 620 | static __be32 process_op(uint32_t minorversion, int nop, |
603 | struct svc_rqst *rqstp, | 621 | struct svc_rqst *rqstp, |
604 | struct xdr_stream *xdr_in, void *argp, | 622 | struct xdr_stream *xdr_in, void *argp, |
605 | struct xdr_stream *xdr_out, void *resp) | 623 | struct xdr_stream *xdr_out, void *resp, int* drc_status) |
606 | { | 624 | { |
607 | struct callback_op *op = &callback_ops[0]; | 625 | struct callback_op *op = &callback_ops[0]; |
608 | unsigned int op_nr = OP_CB_ILLEGAL; | 626 | unsigned int op_nr; |
609 | __be32 status; | 627 | __be32 status; |
610 | long maxlen; | 628 | long maxlen; |
611 | __be32 res; | 629 | __be32 res; |
612 | 630 | ||
613 | dprintk("%s: start\n", __func__); | 631 | dprintk("%s: start\n", __func__); |
614 | status = decode_op_hdr(xdr_in, &op_nr); | 632 | status = decode_op_hdr(xdr_in, &op_nr); |
615 | if (unlikely(status)) { | 633 | if (unlikely(status)) |
616 | status = htonl(NFS4ERR_OP_ILLEGAL); | 634 | return status; |
617 | goto out; | ||
618 | } | ||
619 | 635 | ||
620 | dprintk("%s: minorversion=%d nop=%d op_nr=%u\n", | 636 | dprintk("%s: minorversion=%d nop=%d op_nr=%u\n", |
621 | __func__, minorversion, nop, op_nr); | 637 | __func__, minorversion, nop, op_nr); |
@@ -624,19 +640,32 @@ static __be32 process_op(uint32_t minorversion, int nop, | |||
624 | preprocess_nfs4_op(op_nr, &op); | 640 | preprocess_nfs4_op(op_nr, &op); |
625 | if (status == htonl(NFS4ERR_OP_ILLEGAL)) | 641 | if (status == htonl(NFS4ERR_OP_ILLEGAL)) |
626 | op_nr = OP_CB_ILLEGAL; | 642 | op_nr = OP_CB_ILLEGAL; |
627 | out: | 643 | if (status) |
644 | goto encode_hdr; | ||
645 | |||
646 | if (*drc_status) { | ||
647 | status = *drc_status; | ||
648 | goto encode_hdr; | ||
649 | } | ||
650 | |||
628 | maxlen = xdr_out->end - xdr_out->p; | 651 | maxlen = xdr_out->end - xdr_out->p; |
629 | if (maxlen > 0 && maxlen < PAGE_SIZE) { | 652 | if (maxlen > 0 && maxlen < PAGE_SIZE) { |
630 | if (likely(status == 0 && op->decode_args != NULL)) | 653 | status = op->decode_args(rqstp, xdr_in, argp); |
631 | status = op->decode_args(rqstp, xdr_in, argp); | 654 | if (likely(status == 0)) |
632 | if (likely(status == 0 && op->process_op != NULL)) | ||
633 | status = op->process_op(argp, resp); | 655 | status = op->process_op(argp, resp); |
634 | } else | 656 | } else |
635 | status = htonl(NFS4ERR_RESOURCE); | 657 | status = htonl(NFS4ERR_RESOURCE); |
636 | 658 | ||
659 | /* Only set by OP_CB_SEQUENCE processing */ | ||
660 | if (status == htonl(NFS4ERR_RETRY_UNCACHED_REP)) { | ||
661 | *drc_status = status; | ||
662 | status = 0; | ||
663 | } | ||
664 | |||
665 | encode_hdr: | ||
637 | res = encode_op_hdr(xdr_out, op_nr, status); | 666 | res = encode_op_hdr(xdr_out, op_nr, status); |
638 | if (status == 0) | 667 | if (unlikely(res)) |
639 | status = res; | 668 | return res; |
640 | if (op->encode_res != NULL && status == 0) | 669 | if (op->encode_res != NULL && status == 0) |
641 | status = op->encode_res(rqstp, xdr_out, resp); | 670 | status = op->encode_res(rqstp, xdr_out, resp); |
642 | dprintk("%s: done, status = %d\n", __func__, ntohl(status)); | 671 | dprintk("%s: done, status = %d\n", __func__, ntohl(status)); |
@@ -652,7 +681,7 @@ static __be32 nfs4_callback_compound(struct svc_rqst *rqstp, void *argp, void *r | |||
652 | struct cb_compound_hdr_res hdr_res = { NULL }; | 681 | struct cb_compound_hdr_res hdr_res = { NULL }; |
653 | struct xdr_stream xdr_in, xdr_out; | 682 | struct xdr_stream xdr_in, xdr_out; |
654 | __be32 *p; | 683 | __be32 *p; |
655 | __be32 status; | 684 | __be32 status, drc_status = 0; |
656 | unsigned int nops = 0; | 685 | unsigned int nops = 0; |
657 | 686 | ||
658 | dprintk("%s: start\n", __func__); | 687 | dprintk("%s: start\n", __func__); |
@@ -672,11 +701,18 @@ static __be32 nfs4_callback_compound(struct svc_rqst *rqstp, void *argp, void *r | |||
672 | return rpc_system_err; | 701 | return rpc_system_err; |
673 | 702 | ||
674 | while (status == 0 && nops != hdr_arg.nops) { | 703 | while (status == 0 && nops != hdr_arg.nops) { |
675 | status = process_op(hdr_arg.minorversion, nops, | 704 | status = process_op(hdr_arg.minorversion, nops, rqstp, |
676 | rqstp, &xdr_in, argp, &xdr_out, resp); | 705 | &xdr_in, argp, &xdr_out, resp, &drc_status); |
677 | nops++; | 706 | nops++; |
678 | } | 707 | } |
679 | 708 | ||
709 | /* Buffer overflow in decode_ops_hdr or encode_ops_hdr. Return | ||
710 | * resource error in cb_compound status without returning op */ | ||
711 | if (unlikely(status == htonl(NFS4ERR_RESOURCE_HDR))) { | ||
712 | status = htonl(NFS4ERR_RESOURCE); | ||
713 | nops--; | ||
714 | } | ||
715 | |||
680 | *hdr_res.status = status; | 716 | *hdr_res.status = status; |
681 | *hdr_res.nops = htonl(nops); | 717 | *hdr_res.nops = htonl(nops); |
682 | dprintk("%s: done, status = %u\n", __func__, ntohl(status)); | 718 | dprintk("%s: done, status = %u\n", __func__, ntohl(status)); |
@@ -713,6 +749,11 @@ static struct callback_op callback_ops[] = { | |||
713 | .decode_args = (callback_decode_arg_t)decode_recallany_args, | 749 | .decode_args = (callback_decode_arg_t)decode_recallany_args, |
714 | .res_maxsize = CB_OP_RECALLANY_RES_MAXSZ, | 750 | .res_maxsize = CB_OP_RECALLANY_RES_MAXSZ, |
715 | }, | 751 | }, |
752 | [OP_CB_RECALL_SLOT] = { | ||
753 | .process_op = (callback_process_op_t)nfs4_callback_recallslot, | ||
754 | .decode_args = (callback_decode_arg_t)decode_recallslot_args, | ||
755 | .res_maxsize = CB_OP_RECALLSLOT_RES_MAXSZ, | ||
756 | }, | ||
716 | #endif /* CONFIG_NFS_V4_1 */ | 757 | #endif /* CONFIG_NFS_V4_1 */ |
717 | }; | 758 | }; |
718 | 759 | ||
diff --git a/fs/nfs/client.c b/fs/nfs/client.c index ee77713ce68b..2274f1737336 100644 --- a/fs/nfs/client.c +++ b/fs/nfs/client.c | |||
@@ -164,30 +164,7 @@ error_0: | |||
164 | return ERR_PTR(err); | 164 | return ERR_PTR(err); |
165 | } | 165 | } |
166 | 166 | ||
167 | static void nfs4_shutdown_client(struct nfs_client *clp) | ||
168 | { | ||
169 | #ifdef CONFIG_NFS_V4 | ||
170 | if (__test_and_clear_bit(NFS_CS_RENEWD, &clp->cl_res_state)) | ||
171 | nfs4_kill_renewd(clp); | ||
172 | BUG_ON(!RB_EMPTY_ROOT(&clp->cl_state_owners)); | ||
173 | if (__test_and_clear_bit(NFS_CS_IDMAP, &clp->cl_res_state)) | ||
174 | nfs_idmap_delete(clp); | ||
175 | |||
176 | rpc_destroy_wait_queue(&clp->cl_rpcwaitq); | ||
177 | #endif | ||
178 | } | ||
179 | |||
180 | /* | ||
181 | * Destroy the NFS4 callback service | ||
182 | */ | ||
183 | static void nfs4_destroy_callback(struct nfs_client *clp) | ||
184 | { | ||
185 | #ifdef CONFIG_NFS_V4 | 167 | #ifdef CONFIG_NFS_V4 |
186 | if (__test_and_clear_bit(NFS_CS_CALLBACK, &clp->cl_res_state)) | ||
187 | nfs_callback_down(clp->cl_minorversion); | ||
188 | #endif /* CONFIG_NFS_V4 */ | ||
189 | } | ||
190 | |||
191 | /* | 168 | /* |
192 | * Clears/puts all minor version specific parts from an nfs_client struct | 169 | * Clears/puts all minor version specific parts from an nfs_client struct |
193 | * reverting it to minorversion 0. | 170 | * reverting it to minorversion 0. |
@@ -202,9 +179,33 @@ static void nfs4_clear_client_minor_version(struct nfs_client *clp) | |||
202 | 179 | ||
203 | clp->cl_call_sync = _nfs4_call_sync; | 180 | clp->cl_call_sync = _nfs4_call_sync; |
204 | #endif /* CONFIG_NFS_V4_1 */ | 181 | #endif /* CONFIG_NFS_V4_1 */ |
182 | } | ||
205 | 183 | ||
184 | /* | ||
185 | * Destroy the NFS4 callback service | ||
186 | */ | ||
187 | static void nfs4_destroy_callback(struct nfs_client *clp) | ||
188 | { | ||
189 | if (__test_and_clear_bit(NFS_CS_CALLBACK, &clp->cl_res_state)) | ||
190 | nfs_callback_down(clp->cl_minorversion); | ||
191 | } | ||
192 | |||
193 | static void nfs4_shutdown_client(struct nfs_client *clp) | ||
194 | { | ||
195 | if (__test_and_clear_bit(NFS_CS_RENEWD, &clp->cl_res_state)) | ||
196 | nfs4_kill_renewd(clp); | ||
197 | nfs4_clear_client_minor_version(clp); | ||
206 | nfs4_destroy_callback(clp); | 198 | nfs4_destroy_callback(clp); |
199 | if (__test_and_clear_bit(NFS_CS_IDMAP, &clp->cl_res_state)) | ||
200 | nfs_idmap_delete(clp); | ||
201 | |||
202 | rpc_destroy_wait_queue(&clp->cl_rpcwaitq); | ||
207 | } | 203 | } |
204 | #else | ||
205 | static void nfs4_shutdown_client(struct nfs_client *clp) | ||
206 | { | ||
207 | } | ||
208 | #endif /* CONFIG_NFS_V4 */ | ||
208 | 209 | ||
209 | /* | 210 | /* |
210 | * Destroy a shared client record | 211 | * Destroy a shared client record |
@@ -213,7 +214,6 @@ static void nfs_free_client(struct nfs_client *clp) | |||
213 | { | 214 | { |
214 | dprintk("--> nfs_free_client(%u)\n", clp->rpc_ops->version); | 215 | dprintk("--> nfs_free_client(%u)\n", clp->rpc_ops->version); |
215 | 216 | ||
216 | nfs4_clear_client_minor_version(clp); | ||
217 | nfs4_shutdown_client(clp); | 217 | nfs4_shutdown_client(clp); |
218 | 218 | ||
219 | nfs_fscache_release_client_cookie(clp); | 219 | nfs_fscache_release_client_cookie(clp); |
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 3c7f03b669fb..a1f6b4438fb1 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c | |||
@@ -560,7 +560,7 @@ static int nfs_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
560 | desc->entry = &my_entry; | 560 | desc->entry = &my_entry; |
561 | 561 | ||
562 | nfs_block_sillyrename(dentry); | 562 | nfs_block_sillyrename(dentry); |
563 | res = nfs_revalidate_mapping_nolock(inode, filp->f_mapping); | 563 | res = nfs_revalidate_mapping(inode, filp->f_mapping); |
564 | if (res < 0) | 564 | if (res < 0) |
565 | goto out; | 565 | goto out; |
566 | 566 | ||
diff --git a/fs/nfs/dns_resolve.c b/fs/nfs/dns_resolve.c index 95e1ca765d47..3f0cd4dfddaf 100644 --- a/fs/nfs/dns_resolve.c +++ b/fs/nfs/dns_resolve.c | |||
@@ -36,6 +36,19 @@ struct nfs_dns_ent { | |||
36 | }; | 36 | }; |
37 | 37 | ||
38 | 38 | ||
39 | static void nfs_dns_ent_update(struct cache_head *cnew, | ||
40 | struct cache_head *ckey) | ||
41 | { | ||
42 | struct nfs_dns_ent *new; | ||
43 | struct nfs_dns_ent *key; | ||
44 | |||
45 | new = container_of(cnew, struct nfs_dns_ent, h); | ||
46 | key = container_of(ckey, struct nfs_dns_ent, h); | ||
47 | |||
48 | memcpy(&new->addr, &key->addr, key->addrlen); | ||
49 | new->addrlen = key->addrlen; | ||
50 | } | ||
51 | |||
39 | static void nfs_dns_ent_init(struct cache_head *cnew, | 52 | static void nfs_dns_ent_init(struct cache_head *cnew, |
40 | struct cache_head *ckey) | 53 | struct cache_head *ckey) |
41 | { | 54 | { |
@@ -49,8 +62,7 @@ static void nfs_dns_ent_init(struct cache_head *cnew, | |||
49 | new->hostname = kstrndup(key->hostname, key->namelen, GFP_KERNEL); | 62 | new->hostname = kstrndup(key->hostname, key->namelen, GFP_KERNEL); |
50 | if (new->hostname) { | 63 | if (new->hostname) { |
51 | new->namelen = key->namelen; | 64 | new->namelen = key->namelen; |
52 | memcpy(&new->addr, &key->addr, key->addrlen); | 65 | nfs_dns_ent_update(cnew, ckey); |
53 | new->addrlen = key->addrlen; | ||
54 | } else { | 66 | } else { |
55 | new->namelen = 0; | 67 | new->namelen = 0; |
56 | new->addrlen = 0; | 68 | new->addrlen = 0; |
@@ -234,7 +246,7 @@ static struct cache_detail nfs_dns_resolve = { | |||
234 | .cache_show = nfs_dns_show, | 246 | .cache_show = nfs_dns_show, |
235 | .match = nfs_dns_match, | 247 | .match = nfs_dns_match, |
236 | .init = nfs_dns_ent_init, | 248 | .init = nfs_dns_ent_init, |
237 | .update = nfs_dns_ent_init, | 249 | .update = nfs_dns_ent_update, |
238 | .alloc = nfs_dns_ent_alloc, | 250 | .alloc = nfs_dns_ent_alloc, |
239 | }; | 251 | }; |
240 | 252 | ||
diff --git a/fs/nfs/file.c b/fs/nfs/file.c index 63f2071d6445..ae8d02294e46 100644 --- a/fs/nfs/file.c +++ b/fs/nfs/file.c | |||
@@ -123,11 +123,11 @@ nfs_file_open(struct inode *inode, struct file *filp) | |||
123 | filp->f_path.dentry->d_parent->d_name.name, | 123 | filp->f_path.dentry->d_parent->d_name.name, |
124 | filp->f_path.dentry->d_name.name); | 124 | filp->f_path.dentry->d_name.name); |
125 | 125 | ||
126 | nfs_inc_stats(inode, NFSIOS_VFSOPEN); | ||
126 | res = nfs_check_flags(filp->f_flags); | 127 | res = nfs_check_flags(filp->f_flags); |
127 | if (res) | 128 | if (res) |
128 | return res; | 129 | return res; |
129 | 130 | ||
130 | nfs_inc_stats(inode, NFSIOS_VFSOPEN); | ||
131 | res = nfs_open(inode, filp); | 131 | res = nfs_open(inode, filp); |
132 | return res; | 132 | return res; |
133 | } | 133 | } |
@@ -237,9 +237,9 @@ nfs_file_flush(struct file *file, fl_owner_t id) | |||
237 | dentry->d_parent->d_name.name, | 237 | dentry->d_parent->d_name.name, |
238 | dentry->d_name.name); | 238 | dentry->d_name.name); |
239 | 239 | ||
240 | nfs_inc_stats(inode, NFSIOS_VFSFLUSH); | ||
240 | if ((file->f_mode & FMODE_WRITE) == 0) | 241 | if ((file->f_mode & FMODE_WRITE) == 0) |
241 | return 0; | 242 | return 0; |
242 | nfs_inc_stats(inode, NFSIOS_VFSFLUSH); | ||
243 | 243 | ||
244 | /* Flush writes to the server and return any errors */ | 244 | /* Flush writes to the server and return any errors */ |
245 | return nfs_do_fsync(ctx, inode); | 245 | return nfs_do_fsync(ctx, inode); |
@@ -262,9 +262,11 @@ nfs_file_read(struct kiocb *iocb, const struct iovec *iov, | |||
262 | (unsigned long) count, (unsigned long) pos); | 262 | (unsigned long) count, (unsigned long) pos); |
263 | 263 | ||
264 | result = nfs_revalidate_mapping(inode, iocb->ki_filp->f_mapping); | 264 | result = nfs_revalidate_mapping(inode, iocb->ki_filp->f_mapping); |
265 | nfs_add_stats(inode, NFSIOS_NORMALREADBYTES, count); | 265 | if (!result) { |
266 | if (!result) | ||
267 | result = generic_file_aio_read(iocb, iov, nr_segs, pos); | 266 | result = generic_file_aio_read(iocb, iov, nr_segs, pos); |
267 | if (result > 0) | ||
268 | nfs_add_stats(inode, NFSIOS_NORMALREADBYTES, result); | ||
269 | } | ||
268 | return result; | 270 | return result; |
269 | } | 271 | } |
270 | 272 | ||
@@ -282,8 +284,11 @@ nfs_file_splice_read(struct file *filp, loff_t *ppos, | |||
282 | (unsigned long) count, (unsigned long long) *ppos); | 284 | (unsigned long) count, (unsigned long long) *ppos); |
283 | 285 | ||
284 | res = nfs_revalidate_mapping(inode, filp->f_mapping); | 286 | res = nfs_revalidate_mapping(inode, filp->f_mapping); |
285 | if (!res) | 287 | if (!res) { |
286 | res = generic_file_splice_read(filp, ppos, pipe, count, flags); | 288 | res = generic_file_splice_read(filp, ppos, pipe, count, flags); |
289 | if (res > 0) | ||
290 | nfs_add_stats(inode, NFSIOS_NORMALREADBYTES, res); | ||
291 | } | ||
287 | return res; | 292 | return res; |
288 | } | 293 | } |
289 | 294 | ||
@@ -596,6 +601,7 @@ static ssize_t nfs_file_write(struct kiocb *iocb, const struct iovec *iov, | |||
596 | { | 601 | { |
597 | struct dentry * dentry = iocb->ki_filp->f_path.dentry; | 602 | struct dentry * dentry = iocb->ki_filp->f_path.dentry; |
598 | struct inode * inode = dentry->d_inode; | 603 | struct inode * inode = dentry->d_inode; |
604 | unsigned long written = 0; | ||
599 | ssize_t result; | 605 | ssize_t result; |
600 | size_t count = iov_length(iov, nr_segs); | 606 | size_t count = iov_length(iov, nr_segs); |
601 | 607 | ||
@@ -622,14 +628,18 @@ static ssize_t nfs_file_write(struct kiocb *iocb, const struct iovec *iov, | |||
622 | if (!count) | 628 | if (!count) |
623 | goto out; | 629 | goto out; |
624 | 630 | ||
625 | nfs_add_stats(inode, NFSIOS_NORMALWRITTENBYTES, count); | ||
626 | result = generic_file_aio_write(iocb, iov, nr_segs, pos); | 631 | result = generic_file_aio_write(iocb, iov, nr_segs, pos); |
632 | if (result > 0) | ||
633 | written = result; | ||
634 | |||
627 | /* Return error values for O_DSYNC and IS_SYNC() */ | 635 | /* Return error values for O_DSYNC and IS_SYNC() */ |
628 | if (result >= 0 && nfs_need_sync_write(iocb->ki_filp, inode)) { | 636 | if (result >= 0 && nfs_need_sync_write(iocb->ki_filp, inode)) { |
629 | int err = nfs_do_fsync(nfs_file_open_context(iocb->ki_filp), inode); | 637 | int err = nfs_do_fsync(nfs_file_open_context(iocb->ki_filp), inode); |
630 | if (err < 0) | 638 | if (err < 0) |
631 | result = err; | 639 | result = err; |
632 | } | 640 | } |
641 | if (result > 0) | ||
642 | nfs_add_stats(inode, NFSIOS_NORMALWRITTENBYTES, written); | ||
633 | out: | 643 | out: |
634 | return result; | 644 | return result; |
635 | 645 | ||
@@ -644,6 +654,7 @@ static ssize_t nfs_file_splice_write(struct pipe_inode_info *pipe, | |||
644 | { | 654 | { |
645 | struct dentry *dentry = filp->f_path.dentry; | 655 | struct dentry *dentry = filp->f_path.dentry; |
646 | struct inode *inode = dentry->d_inode; | 656 | struct inode *inode = dentry->d_inode; |
657 | unsigned long written = 0; | ||
647 | ssize_t ret; | 658 | ssize_t ret; |
648 | 659 | ||
649 | dprintk("NFS splice_write(%s/%s, %lu@%llu)\n", | 660 | dprintk("NFS splice_write(%s/%s, %lu@%llu)\n", |
@@ -654,14 +665,17 @@ static ssize_t nfs_file_splice_write(struct pipe_inode_info *pipe, | |||
654 | * The combination of splice and an O_APPEND destination is disallowed. | 665 | * The combination of splice and an O_APPEND destination is disallowed. |
655 | */ | 666 | */ |
656 | 667 | ||
657 | nfs_add_stats(inode, NFSIOS_NORMALWRITTENBYTES, count); | ||
658 | |||
659 | ret = generic_file_splice_write(pipe, filp, ppos, count, flags); | 668 | ret = generic_file_splice_write(pipe, filp, ppos, count, flags); |
669 | if (ret > 0) | ||
670 | written = ret; | ||
671 | |||
660 | if (ret >= 0 && nfs_need_sync_write(filp, inode)) { | 672 | if (ret >= 0 && nfs_need_sync_write(filp, inode)) { |
661 | int err = nfs_do_fsync(nfs_file_open_context(filp), inode); | 673 | int err = nfs_do_fsync(nfs_file_open_context(filp), inode); |
662 | if (err < 0) | 674 | if (err < 0) |
663 | ret = err; | 675 | ret = err; |
664 | } | 676 | } |
677 | if (ret > 0) | ||
678 | nfs_add_stats(inode, NFSIOS_NORMALWRITTENBYTES, written); | ||
665 | return ret; | 679 | return ret; |
666 | } | 680 | } |
667 | 681 | ||
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index f141bde7756a..657201acda84 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c | |||
@@ -97,22 +97,6 @@ u64 nfs_compat_user_ino64(u64 fileid) | |||
97 | return ino; | 97 | return ino; |
98 | } | 98 | } |
99 | 99 | ||
100 | int nfs_write_inode(struct inode *inode, int sync) | ||
101 | { | ||
102 | int ret; | ||
103 | |||
104 | if (sync) { | ||
105 | ret = filemap_fdatawait(inode->i_mapping); | ||
106 | if (ret == 0) | ||
107 | ret = nfs_commit_inode(inode, FLUSH_SYNC); | ||
108 | } else | ||
109 | ret = nfs_commit_inode(inode, 0); | ||
110 | if (ret >= 0) | ||
111 | return 0; | ||
112 | __mark_inode_dirty(inode, I_DIRTY_DATASYNC); | ||
113 | return ret; | ||
114 | } | ||
115 | |||
116 | void nfs_clear_inode(struct inode *inode) | 100 | void nfs_clear_inode(struct inode *inode) |
117 | { | 101 | { |
118 | /* | 102 | /* |
@@ -130,16 +114,12 @@ void nfs_clear_inode(struct inode *inode) | |||
130 | */ | 114 | */ |
131 | int nfs_sync_mapping(struct address_space *mapping) | 115 | int nfs_sync_mapping(struct address_space *mapping) |
132 | { | 116 | { |
133 | int ret; | 117 | int ret = 0; |
134 | 118 | ||
135 | if (mapping->nrpages == 0) | 119 | if (mapping->nrpages != 0) { |
136 | return 0; | 120 | unmap_mapping_range(mapping, 0, 0, 0); |
137 | unmap_mapping_range(mapping, 0, 0, 0); | 121 | ret = nfs_wb_all(mapping->host); |
138 | ret = filemap_write_and_wait(mapping); | 122 | } |
139 | if (ret != 0) | ||
140 | goto out; | ||
141 | ret = nfs_wb_all(mapping->host); | ||
142 | out: | ||
143 | return ret; | 123 | return ret; |
144 | } | 124 | } |
145 | 125 | ||
@@ -511,17 +491,11 @@ int nfs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat) | |||
511 | int need_atime = NFS_I(inode)->cache_validity & NFS_INO_INVALID_ATIME; | 491 | int need_atime = NFS_I(inode)->cache_validity & NFS_INO_INVALID_ATIME; |
512 | int err; | 492 | int err; |
513 | 493 | ||
514 | /* | 494 | /* Flush out writes to the server in order to update c/mtime. */ |
515 | * Flush out writes to the server in order to update c/mtime. | ||
516 | * | ||
517 | * Hold the i_mutex to suspend application writes temporarily; | ||
518 | * this prevents long-running writing applications from blocking | ||
519 | * nfs_wb_nocommit. | ||
520 | */ | ||
521 | if (S_ISREG(inode->i_mode)) { | 495 | if (S_ISREG(inode->i_mode)) { |
522 | mutex_lock(&inode->i_mutex); | 496 | err = filemap_write_and_wait(inode->i_mapping); |
523 | nfs_wb_nocommit(inode); | 497 | if (err) |
524 | mutex_unlock(&inode->i_mutex); | 498 | goto out; |
525 | } | 499 | } |
526 | 500 | ||
527 | /* | 501 | /* |
@@ -545,6 +519,7 @@ int nfs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat) | |||
545 | generic_fillattr(inode, stat); | 519 | generic_fillattr(inode, stat); |
546 | stat->ino = nfs_compat_user_ino64(NFS_FILEID(inode)); | 520 | stat->ino = nfs_compat_user_ino64(NFS_FILEID(inode)); |
547 | } | 521 | } |
522 | out: | ||
548 | return err; | 523 | return err; |
549 | } | 524 | } |
550 | 525 | ||
@@ -574,14 +549,14 @@ void nfs_close_context(struct nfs_open_context *ctx, int is_sync) | |||
574 | nfs_revalidate_inode(server, inode); | 549 | nfs_revalidate_inode(server, inode); |
575 | } | 550 | } |
576 | 551 | ||
577 | static struct nfs_open_context *alloc_nfs_open_context(struct vfsmount *mnt, struct dentry *dentry, struct rpc_cred *cred) | 552 | static struct nfs_open_context *alloc_nfs_open_context(struct path *path, struct rpc_cred *cred) |
578 | { | 553 | { |
579 | struct nfs_open_context *ctx; | 554 | struct nfs_open_context *ctx; |
580 | 555 | ||
581 | ctx = kmalloc(sizeof(*ctx), GFP_KERNEL); | 556 | ctx = kmalloc(sizeof(*ctx), GFP_KERNEL); |
582 | if (ctx != NULL) { | 557 | if (ctx != NULL) { |
583 | ctx->path.dentry = dget(dentry); | 558 | ctx->path = *path; |
584 | ctx->path.mnt = mntget(mnt); | 559 | path_get(&ctx->path); |
585 | ctx->cred = get_rpccred(cred); | 560 | ctx->cred = get_rpccred(cred); |
586 | ctx->state = NULL; | 561 | ctx->state = NULL; |
587 | ctx->lockowner = current->files; | 562 | ctx->lockowner = current->files; |
@@ -620,11 +595,6 @@ void put_nfs_open_context(struct nfs_open_context *ctx) | |||
620 | __put_nfs_open_context(ctx, 0); | 595 | __put_nfs_open_context(ctx, 0); |
621 | } | 596 | } |
622 | 597 | ||
623 | static void put_nfs_open_context_sync(struct nfs_open_context *ctx) | ||
624 | { | ||
625 | __put_nfs_open_context(ctx, 1); | ||
626 | } | ||
627 | |||
628 | /* | 598 | /* |
629 | * Ensure that mmap has a recent RPC credential for use when writing out | 599 | * Ensure that mmap has a recent RPC credential for use when writing out |
630 | * shared pages | 600 | * shared pages |
@@ -671,7 +641,7 @@ static void nfs_file_clear_open_context(struct file *filp) | |||
671 | spin_lock(&inode->i_lock); | 641 | spin_lock(&inode->i_lock); |
672 | list_move_tail(&ctx->list, &NFS_I(inode)->open_files); | 642 | list_move_tail(&ctx->list, &NFS_I(inode)->open_files); |
673 | spin_unlock(&inode->i_lock); | 643 | spin_unlock(&inode->i_lock); |
674 | put_nfs_open_context_sync(ctx); | 644 | __put_nfs_open_context(ctx, filp->f_flags & O_DIRECT ? 0 : 1); |
675 | } | 645 | } |
676 | } | 646 | } |
677 | 647 | ||
@@ -686,7 +656,7 @@ int nfs_open(struct inode *inode, struct file *filp) | |||
686 | cred = rpc_lookup_cred(); | 656 | cred = rpc_lookup_cred(); |
687 | if (IS_ERR(cred)) | 657 | if (IS_ERR(cred)) |
688 | return PTR_ERR(cred); | 658 | return PTR_ERR(cred); |
689 | ctx = alloc_nfs_open_context(filp->f_path.mnt, filp->f_path.dentry, cred); | 659 | ctx = alloc_nfs_open_context(&filp->f_path, cred); |
690 | put_rpccred(cred); | 660 | put_rpccred(cred); |
691 | if (ctx == NULL) | 661 | if (ctx == NULL) |
692 | return -ENOMEM; | 662 | return -ENOMEM; |
@@ -779,7 +749,7 @@ int nfs_revalidate_inode(struct nfs_server *server, struct inode *inode) | |||
779 | return __nfs_revalidate_inode(server, inode); | 749 | return __nfs_revalidate_inode(server, inode); |
780 | } | 750 | } |
781 | 751 | ||
782 | static int nfs_invalidate_mapping_nolock(struct inode *inode, struct address_space *mapping) | 752 | static int nfs_invalidate_mapping(struct inode *inode, struct address_space *mapping) |
783 | { | 753 | { |
784 | struct nfs_inode *nfsi = NFS_I(inode); | 754 | struct nfs_inode *nfsi = NFS_I(inode); |
785 | 755 | ||
@@ -800,49 +770,10 @@ static int nfs_invalidate_mapping_nolock(struct inode *inode, struct address_spa | |||
800 | return 0; | 770 | return 0; |
801 | } | 771 | } |
802 | 772 | ||
803 | static int nfs_invalidate_mapping(struct inode *inode, struct address_space *mapping) | ||
804 | { | ||
805 | int ret = 0; | ||
806 | |||
807 | mutex_lock(&inode->i_mutex); | ||
808 | if (NFS_I(inode)->cache_validity & NFS_INO_INVALID_DATA) { | ||
809 | ret = nfs_sync_mapping(mapping); | ||
810 | if (ret == 0) | ||
811 | ret = nfs_invalidate_mapping_nolock(inode, mapping); | ||
812 | } | ||
813 | mutex_unlock(&inode->i_mutex); | ||
814 | return ret; | ||
815 | } | ||
816 | |||
817 | /** | ||
818 | * nfs_revalidate_mapping_nolock - Revalidate the pagecache | ||
819 | * @inode - pointer to host inode | ||
820 | * @mapping - pointer to mapping | ||
821 | */ | ||
822 | int nfs_revalidate_mapping_nolock(struct inode *inode, struct address_space *mapping) | ||
823 | { | ||
824 | struct nfs_inode *nfsi = NFS_I(inode); | ||
825 | int ret = 0; | ||
826 | |||
827 | if ((nfsi->cache_validity & NFS_INO_REVAL_PAGECACHE) | ||
828 | || nfs_attribute_timeout(inode) || NFS_STALE(inode)) { | ||
829 | ret = __nfs_revalidate_inode(NFS_SERVER(inode), inode); | ||
830 | if (ret < 0) | ||
831 | goto out; | ||
832 | } | ||
833 | if (nfsi->cache_validity & NFS_INO_INVALID_DATA) | ||
834 | ret = nfs_invalidate_mapping_nolock(inode, mapping); | ||
835 | out: | ||
836 | return ret; | ||
837 | } | ||
838 | |||
839 | /** | 773 | /** |
840 | * nfs_revalidate_mapping - Revalidate the pagecache | 774 | * nfs_revalidate_mapping - Revalidate the pagecache |
841 | * @inode - pointer to host inode | 775 | * @inode - pointer to host inode |
842 | * @mapping - pointer to mapping | 776 | * @mapping - pointer to mapping |
843 | * | ||
844 | * This version of the function will take the inode->i_mutex and attempt to | ||
845 | * flush out all dirty data if it needs to invalidate the page cache. | ||
846 | */ | 777 | */ |
847 | int nfs_revalidate_mapping(struct inode *inode, struct address_space *mapping) | 778 | int nfs_revalidate_mapping(struct inode *inode, struct address_space *mapping) |
848 | { | 779 | { |
@@ -1420,6 +1351,7 @@ static void init_once(void *foo) | |||
1420 | INIT_LIST_HEAD(&nfsi->access_cache_inode_lru); | 1351 | INIT_LIST_HEAD(&nfsi->access_cache_inode_lru); |
1421 | INIT_RADIX_TREE(&nfsi->nfs_page_tree, GFP_ATOMIC); | 1352 | INIT_RADIX_TREE(&nfsi->nfs_page_tree, GFP_ATOMIC); |
1422 | nfsi->npages = 0; | 1353 | nfsi->npages = 0; |
1354 | nfsi->ncommit = 0; | ||
1423 | atomic_set(&nfsi->silly_count, 1); | 1355 | atomic_set(&nfsi->silly_count, 1); |
1424 | INIT_HLIST_HEAD(&nfsi->silly_list); | 1356 | INIT_HLIST_HEAD(&nfsi->silly_list); |
1425 | init_waitqueue_head(&nfsi->waitqueue); | 1357 | init_waitqueue_head(&nfsi->waitqueue); |
diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h index 29e464d23b32..11f82f03c5de 100644 --- a/fs/nfs/internal.h +++ b/fs/nfs/internal.h | |||
@@ -211,7 +211,7 @@ extern int nfs_access_cache_shrinker(int nr_to_scan, gfp_t gfp_mask); | |||
211 | extern struct workqueue_struct *nfsiod_workqueue; | 211 | extern struct workqueue_struct *nfsiod_workqueue; |
212 | extern struct inode *nfs_alloc_inode(struct super_block *sb); | 212 | extern struct inode *nfs_alloc_inode(struct super_block *sb); |
213 | extern void nfs_destroy_inode(struct inode *); | 213 | extern void nfs_destroy_inode(struct inode *); |
214 | extern int nfs_write_inode(struct inode *,int); | 214 | extern int nfs_write_inode(struct inode *, struct writeback_control *); |
215 | extern void nfs_clear_inode(struct inode *); | 215 | extern void nfs_clear_inode(struct inode *); |
216 | #ifdef CONFIG_NFS_V4 | 216 | #ifdef CONFIG_NFS_V4 |
217 | extern void nfs4_clear_inode(struct inode *); | 217 | extern void nfs4_clear_inode(struct inode *); |
diff --git a/fs/nfs/iostat.h b/fs/nfs/iostat.h index 46d779abafd3..1d8d5c813b01 100644 --- a/fs/nfs/iostat.h +++ b/fs/nfs/iostat.h | |||
@@ -57,12 +57,12 @@ static inline void nfs_add_fscache_stats(struct inode *inode, | |||
57 | } | 57 | } |
58 | #endif | 58 | #endif |
59 | 59 | ||
60 | static inline struct nfs_iostats *nfs_alloc_iostats(void) | 60 | static inline struct nfs_iostats __percpu *nfs_alloc_iostats(void) |
61 | { | 61 | { |
62 | return alloc_percpu(struct nfs_iostats); | 62 | return alloc_percpu(struct nfs_iostats); |
63 | } | 63 | } |
64 | 64 | ||
65 | static inline void nfs_free_iostats(struct nfs_iostats *stats) | 65 | static inline void nfs_free_iostats(struct nfs_iostats __percpu *stats) |
66 | { | 66 | { |
67 | if (stats != NULL) | 67 | if (stats != NULL) |
68 | free_percpu(stats); | 68 | free_percpu(stats); |
diff --git a/fs/nfs/nfs3proc.c b/fs/nfs/nfs3proc.c index 3f8881d1a050..24992f0a29f2 100644 --- a/fs/nfs/nfs3proc.c +++ b/fs/nfs/nfs3proc.c | |||
@@ -22,14 +22,14 @@ | |||
22 | 22 | ||
23 | #define NFSDBG_FACILITY NFSDBG_PROC | 23 | #define NFSDBG_FACILITY NFSDBG_PROC |
24 | 24 | ||
25 | /* A wrapper to handle the EJUKEBOX error message */ | 25 | /* A wrapper to handle the EJUKEBOX and EKEYEXPIRED error messages */ |
26 | static int | 26 | static int |
27 | nfs3_rpc_wrapper(struct rpc_clnt *clnt, struct rpc_message *msg, int flags) | 27 | nfs3_rpc_wrapper(struct rpc_clnt *clnt, struct rpc_message *msg, int flags) |
28 | { | 28 | { |
29 | int res; | 29 | int res; |
30 | do { | 30 | do { |
31 | res = rpc_call_sync(clnt, msg, flags); | 31 | res = rpc_call_sync(clnt, msg, flags); |
32 | if (res != -EJUKEBOX) | 32 | if (res != -EJUKEBOX && res != -EKEYEXPIRED) |
33 | break; | 33 | break; |
34 | schedule_timeout_killable(NFS_JUKEBOX_RETRY_TIME); | 34 | schedule_timeout_killable(NFS_JUKEBOX_RETRY_TIME); |
35 | res = -ERESTARTSYS; | 35 | res = -ERESTARTSYS; |
@@ -42,9 +42,10 @@ nfs3_rpc_wrapper(struct rpc_clnt *clnt, struct rpc_message *msg, int flags) | |||
42 | static int | 42 | static int |
43 | nfs3_async_handle_jukebox(struct rpc_task *task, struct inode *inode) | 43 | nfs3_async_handle_jukebox(struct rpc_task *task, struct inode *inode) |
44 | { | 44 | { |
45 | if (task->tk_status != -EJUKEBOX) | 45 | if (task->tk_status != -EJUKEBOX && task->tk_status != -EKEYEXPIRED) |
46 | return 0; | 46 | return 0; |
47 | nfs_inc_stats(inode, NFSIOS_DELAY); | 47 | if (task->tk_status == -EJUKEBOX) |
48 | nfs_inc_stats(inode, NFSIOS_DELAY); | ||
48 | task->tk_status = 0; | 49 | task->tk_status = 0; |
49 | rpc_restart_call(task); | 50 | rpc_restart_call(task); |
50 | rpc_delay(task, NFS_JUKEBOX_RETRY_TIME); | 51 | rpc_delay(task, NFS_JUKEBOX_RETRY_TIME); |
diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h index 0c6fda33d66e..a187200a7aac 100644 --- a/fs/nfs/nfs4_fs.h +++ b/fs/nfs/nfs4_fs.h | |||
@@ -46,6 +46,7 @@ enum nfs4_client_state { | |||
46 | NFS4CLNT_DELEGRETURN, | 46 | NFS4CLNT_DELEGRETURN, |
47 | NFS4CLNT_SESSION_RESET, | 47 | NFS4CLNT_SESSION_RESET, |
48 | NFS4CLNT_SESSION_DRAINING, | 48 | NFS4CLNT_SESSION_DRAINING, |
49 | NFS4CLNT_RECALL_SLOT, | ||
49 | }; | 50 | }; |
50 | 51 | ||
51 | /* | 52 | /* |
@@ -280,6 +281,7 @@ extern void nfs4_schedule_state_manager(struct nfs_client *); | |||
280 | extern int nfs4_state_mark_reclaim_nograce(struct nfs_client *clp, struct nfs4_state *state); | 281 | extern int nfs4_state_mark_reclaim_nograce(struct nfs_client *clp, struct nfs4_state *state); |
281 | extern int nfs4_state_mark_reclaim_reboot(struct nfs_client *clp, struct nfs4_state *state); | 282 | extern int nfs4_state_mark_reclaim_reboot(struct nfs_client *clp, struct nfs4_state *state); |
282 | extern void nfs41_handle_sequence_flag_errors(struct nfs_client *clp, u32 flags); | 283 | extern void nfs41_handle_sequence_flag_errors(struct nfs_client *clp, u32 flags); |
284 | extern void nfs41_handle_recall_slot(struct nfs_client *clp); | ||
283 | extern void nfs4_put_lock_state(struct nfs4_lock_state *lsp); | 285 | extern void nfs4_put_lock_state(struct nfs4_lock_state *lsp); |
284 | extern int nfs4_set_lock_state(struct nfs4_state *state, struct file_lock *fl); | 286 | extern int nfs4_set_lock_state(struct nfs4_state *state, struct file_lock *fl); |
285 | extern void nfs4_copy_stateid(nfs4_stateid *, struct nfs4_state *, fl_owner_t); | 287 | extern void nfs4_copy_stateid(nfs4_stateid *, struct nfs4_state *, fl_owner_t); |
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 375f0fae2c6a..eda74c42d552 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c | |||
@@ -281,6 +281,7 @@ static int nfs4_handle_exception(const struct nfs_server *server, int errorcode, | |||
281 | } | 281 | } |
282 | case -NFS4ERR_GRACE: | 282 | case -NFS4ERR_GRACE: |
283 | case -NFS4ERR_DELAY: | 283 | case -NFS4ERR_DELAY: |
284 | case -EKEYEXPIRED: | ||
284 | ret = nfs4_delay(server->client, &exception->timeout); | 285 | ret = nfs4_delay(server->client, &exception->timeout); |
285 | if (ret != 0) | 286 | if (ret != 0) |
286 | break; | 287 | break; |
@@ -418,7 +419,8 @@ static void nfs41_sequence_done(struct nfs_client *clp, | |||
418 | clp->cl_last_renewal = timestamp; | 419 | clp->cl_last_renewal = timestamp; |
419 | spin_unlock(&clp->cl_lock); | 420 | spin_unlock(&clp->cl_lock); |
420 | /* Check sequence flags */ | 421 | /* Check sequence flags */ |
421 | nfs41_handle_sequence_flag_errors(clp, res->sr_status_flags); | 422 | if (atomic_read(&clp->cl_count) > 1) |
423 | nfs41_handle_sequence_flag_errors(clp, res->sr_status_flags); | ||
422 | } | 424 | } |
423 | out: | 425 | out: |
424 | /* The session may be reset by one of the error handlers. */ | 426 | /* The session may be reset by one of the error handlers. */ |
@@ -724,8 +726,8 @@ static struct nfs4_opendata *nfs4_opendata_alloc(struct path *path, | |||
724 | p->o_arg.seqid = nfs_alloc_seqid(&sp->so_seqid); | 726 | p->o_arg.seqid = nfs_alloc_seqid(&sp->so_seqid); |
725 | if (p->o_arg.seqid == NULL) | 727 | if (p->o_arg.seqid == NULL) |
726 | goto err_free; | 728 | goto err_free; |
727 | p->path.mnt = mntget(path->mnt); | 729 | path_get(path); |
728 | p->path.dentry = dget(path->dentry); | 730 | p->path = *path; |
729 | p->dir = parent; | 731 | p->dir = parent; |
730 | p->owner = sp; | 732 | p->owner = sp; |
731 | atomic_inc(&sp->so_count); | 733 | atomic_inc(&sp->so_count); |
@@ -1163,7 +1165,7 @@ static int nfs4_do_open_reclaim(struct nfs_open_context *ctx, struct nfs4_state | |||
1163 | int err; | 1165 | int err; |
1164 | do { | 1166 | do { |
1165 | err = _nfs4_do_open_reclaim(ctx, state); | 1167 | err = _nfs4_do_open_reclaim(ctx, state); |
1166 | if (err != -NFS4ERR_DELAY) | 1168 | if (err != -NFS4ERR_DELAY && err != -EKEYEXPIRED) |
1167 | break; | 1169 | break; |
1168 | nfs4_handle_exception(server, err, &exception); | 1170 | nfs4_handle_exception(server, err, &exception); |
1169 | } while (exception.retry); | 1171 | } while (exception.retry); |
@@ -1582,6 +1584,7 @@ static int nfs4_do_open_expired(struct nfs_open_context *ctx, struct nfs4_state | |||
1582 | goto out; | 1584 | goto out; |
1583 | case -NFS4ERR_GRACE: | 1585 | case -NFS4ERR_GRACE: |
1584 | case -NFS4ERR_DELAY: | 1586 | case -NFS4ERR_DELAY: |
1587 | case -EKEYEXPIRED: | ||
1585 | nfs4_handle_exception(server, err, &exception); | 1588 | nfs4_handle_exception(server, err, &exception); |
1586 | err = 0; | 1589 | err = 0; |
1587 | } | 1590 | } |
@@ -1944,8 +1947,8 @@ int nfs4_do_close(struct path *path, struct nfs4_state *state, int wait) | |||
1944 | calldata->res.seqid = calldata->arg.seqid; | 1947 | calldata->res.seqid = calldata->arg.seqid; |
1945 | calldata->res.server = server; | 1948 | calldata->res.server = server; |
1946 | calldata->res.seq_res.sr_slotid = NFS4_MAX_SLOT_TABLE; | 1949 | calldata->res.seq_res.sr_slotid = NFS4_MAX_SLOT_TABLE; |
1947 | calldata->path.mnt = mntget(path->mnt); | 1950 | path_get(path); |
1948 | calldata->path.dentry = dget(path->dentry); | 1951 | calldata->path = *path; |
1949 | 1952 | ||
1950 | msg.rpc_argp = &calldata->arg, | 1953 | msg.rpc_argp = &calldata->arg, |
1951 | msg.rpc_resp = &calldata->res, | 1954 | msg.rpc_resp = &calldata->res, |
@@ -3145,10 +3148,19 @@ static void nfs4_proc_commit_setup(struct nfs_write_data *data, struct rpc_messa | |||
3145 | * nfs4_proc_async_renew(): This is not one of the nfs_rpc_ops; it is a special | 3148 | * nfs4_proc_async_renew(): This is not one of the nfs_rpc_ops; it is a special |
3146 | * standalone procedure for queueing an asynchronous RENEW. | 3149 | * standalone procedure for queueing an asynchronous RENEW. |
3147 | */ | 3150 | */ |
3151 | static void nfs4_renew_release(void *data) | ||
3152 | { | ||
3153 | struct nfs_client *clp = data; | ||
3154 | |||
3155 | if (atomic_read(&clp->cl_count) > 1) | ||
3156 | nfs4_schedule_state_renewal(clp); | ||
3157 | nfs_put_client(clp); | ||
3158 | } | ||
3159 | |||
3148 | static void nfs4_renew_done(struct rpc_task *task, void *data) | 3160 | static void nfs4_renew_done(struct rpc_task *task, void *data) |
3149 | { | 3161 | { |
3150 | struct nfs_client *clp = (struct nfs_client *)task->tk_msg.rpc_argp; | 3162 | struct nfs_client *clp = data; |
3151 | unsigned long timestamp = (unsigned long)data; | 3163 | unsigned long timestamp = task->tk_start; |
3152 | 3164 | ||
3153 | if (task->tk_status < 0) { | 3165 | if (task->tk_status < 0) { |
3154 | /* Unless we're shutting down, schedule state recovery! */ | 3166 | /* Unless we're shutting down, schedule state recovery! */ |
@@ -3164,6 +3176,7 @@ static void nfs4_renew_done(struct rpc_task *task, void *data) | |||
3164 | 3176 | ||
3165 | static const struct rpc_call_ops nfs4_renew_ops = { | 3177 | static const struct rpc_call_ops nfs4_renew_ops = { |
3166 | .rpc_call_done = nfs4_renew_done, | 3178 | .rpc_call_done = nfs4_renew_done, |
3179 | .rpc_release = nfs4_renew_release, | ||
3167 | }; | 3180 | }; |
3168 | 3181 | ||
3169 | int nfs4_proc_async_renew(struct nfs_client *clp, struct rpc_cred *cred) | 3182 | int nfs4_proc_async_renew(struct nfs_client *clp, struct rpc_cred *cred) |
@@ -3174,8 +3187,10 @@ int nfs4_proc_async_renew(struct nfs_client *clp, struct rpc_cred *cred) | |||
3174 | .rpc_cred = cred, | 3187 | .rpc_cred = cred, |
3175 | }; | 3188 | }; |
3176 | 3189 | ||
3190 | if (!atomic_inc_not_zero(&clp->cl_count)) | ||
3191 | return -EIO; | ||
3177 | return rpc_call_async(clp->cl_rpcclient, &msg, RPC_TASK_SOFT, | 3192 | return rpc_call_async(clp->cl_rpcclient, &msg, RPC_TASK_SOFT, |
3178 | &nfs4_renew_ops, (void *)jiffies); | 3193 | &nfs4_renew_ops, clp); |
3179 | } | 3194 | } |
3180 | 3195 | ||
3181 | int nfs4_proc_renew(struct nfs_client *clp, struct rpc_cred *cred) | 3196 | int nfs4_proc_renew(struct nfs_client *clp, struct rpc_cred *cred) |
@@ -3452,6 +3467,7 @@ _nfs4_async_handle_error(struct rpc_task *task, const struct nfs_server *server, | |||
3452 | if (server) | 3467 | if (server) |
3453 | nfs_inc_server_stats(server, NFSIOS_DELAY); | 3468 | nfs_inc_server_stats(server, NFSIOS_DELAY); |
3454 | case -NFS4ERR_GRACE: | 3469 | case -NFS4ERR_GRACE: |
3470 | case -EKEYEXPIRED: | ||
3455 | rpc_delay(task, NFS4_POLL_RETRY_MAX); | 3471 | rpc_delay(task, NFS4_POLL_RETRY_MAX); |
3456 | task->tk_status = 0; | 3472 | task->tk_status = 0; |
3457 | return -EAGAIN; | 3473 | return -EAGAIN; |
@@ -3564,6 +3580,7 @@ int nfs4_proc_setclientid_confirm(struct nfs_client *clp, struct rpc_cred *cred) | |||
3564 | case -NFS4ERR_RESOURCE: | 3580 | case -NFS4ERR_RESOURCE: |
3565 | /* The IBM lawyers misread another document! */ | 3581 | /* The IBM lawyers misread another document! */ |
3566 | case -NFS4ERR_DELAY: | 3582 | case -NFS4ERR_DELAY: |
3583 | case -EKEYEXPIRED: | ||
3567 | err = nfs4_delay(clp->cl_rpcclient, &timeout); | 3584 | err = nfs4_delay(clp->cl_rpcclient, &timeout); |
3568 | } | 3585 | } |
3569 | } while (err == 0); | 3586 | } while (err == 0); |
@@ -4179,7 +4196,7 @@ static int nfs4_lock_reclaim(struct nfs4_state *state, struct file_lock *request | |||
4179 | if (test_bit(NFS_DELEGATED_STATE, &state->flags) != 0) | 4196 | if (test_bit(NFS_DELEGATED_STATE, &state->flags) != 0) |
4180 | return 0; | 4197 | return 0; |
4181 | err = _nfs4_do_setlk(state, F_SETLK, request, NFS_LOCK_RECLAIM); | 4198 | err = _nfs4_do_setlk(state, F_SETLK, request, NFS_LOCK_RECLAIM); |
4182 | if (err != -NFS4ERR_DELAY) | 4199 | if (err != -NFS4ERR_DELAY && err != -EKEYEXPIRED) |
4183 | break; | 4200 | break; |
4184 | nfs4_handle_exception(server, err, &exception); | 4201 | nfs4_handle_exception(server, err, &exception); |
4185 | } while (exception.retry); | 4202 | } while (exception.retry); |
@@ -4204,6 +4221,7 @@ static int nfs4_lock_expired(struct nfs4_state *state, struct file_lock *request | |||
4204 | goto out; | 4221 | goto out; |
4205 | case -NFS4ERR_GRACE: | 4222 | case -NFS4ERR_GRACE: |
4206 | case -NFS4ERR_DELAY: | 4223 | case -NFS4ERR_DELAY: |
4224 | case -EKEYEXPIRED: | ||
4207 | nfs4_handle_exception(server, err, &exception); | 4225 | nfs4_handle_exception(server, err, &exception); |
4208 | err = 0; | 4226 | err = 0; |
4209 | } | 4227 | } |
@@ -4355,6 +4373,7 @@ int nfs4_lock_delegation_recall(struct nfs4_state *state, struct file_lock *fl) | |||
4355 | err = 0; | 4373 | err = 0; |
4356 | goto out; | 4374 | goto out; |
4357 | case -NFS4ERR_DELAY: | 4375 | case -NFS4ERR_DELAY: |
4376 | case -EKEYEXPIRED: | ||
4358 | break; | 4377 | break; |
4359 | } | 4378 | } |
4360 | err = nfs4_handle_exception(server, err, &exception); | 4379 | err = nfs4_handle_exception(server, err, &exception); |
@@ -4500,7 +4519,7 @@ int nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred) | |||
4500 | 4519 | ||
4501 | status = rpc_call_sync(clp->cl_rpcclient, &msg, 0); | 4520 | status = rpc_call_sync(clp->cl_rpcclient, &msg, 0); |
4502 | 4521 | ||
4503 | if (status != NFS4ERR_CLID_INUSE) | 4522 | if (status != -NFS4ERR_CLID_INUSE) |
4504 | break; | 4523 | break; |
4505 | 4524 | ||
4506 | if (signalled()) | 4525 | if (signalled()) |
@@ -4554,6 +4573,7 @@ static void nfs4_get_lease_time_done(struct rpc_task *task, void *calldata) | |||
4554 | switch (task->tk_status) { | 4573 | switch (task->tk_status) { |
4555 | case -NFS4ERR_DELAY: | 4574 | case -NFS4ERR_DELAY: |
4556 | case -NFS4ERR_GRACE: | 4575 | case -NFS4ERR_GRACE: |
4576 | case -EKEYEXPIRED: | ||
4557 | dprintk("%s Retry: tk_status %d\n", __func__, task->tk_status); | 4577 | dprintk("%s Retry: tk_status %d\n", __func__, task->tk_status); |
4558 | rpc_delay(task, NFS4_POLL_RETRY_MIN); | 4578 | rpc_delay(task, NFS4_POLL_RETRY_MIN); |
4559 | task->tk_status = 0; | 4579 | task->tk_status = 0; |
@@ -4611,26 +4631,32 @@ int nfs4_proc_get_lease_time(struct nfs_client *clp, struct nfs_fsinfo *fsinfo) | |||
4611 | /* | 4631 | /* |
4612 | * Reset a slot table | 4632 | * Reset a slot table |
4613 | */ | 4633 | */ |
4614 | static int nfs4_reset_slot_table(struct nfs4_slot_table *tbl, int max_slots, | 4634 | static int nfs4_reset_slot_table(struct nfs4_slot_table *tbl, u32 max_reqs, |
4615 | int old_max_slots, int ivalue) | 4635 | int ivalue) |
4616 | { | 4636 | { |
4637 | struct nfs4_slot *new = NULL; | ||
4617 | int i; | 4638 | int i; |
4618 | int ret = 0; | 4639 | int ret = 0; |
4619 | 4640 | ||
4620 | dprintk("--> %s: max_reqs=%u, tbl %p\n", __func__, max_slots, tbl); | 4641 | dprintk("--> %s: max_reqs=%u, tbl->max_slots %d\n", __func__, |
4642 | max_reqs, tbl->max_slots); | ||
4621 | 4643 | ||
4622 | /* | 4644 | /* Does the newly negotiated max_reqs match the existing slot table? */ |
4623 | * Until we have dynamic slot table adjustment, insist | 4645 | if (max_reqs != tbl->max_slots) { |
4624 | * upon the same slot table size | 4646 | ret = -ENOMEM; |
4625 | */ | 4647 | new = kmalloc(max_reqs * sizeof(struct nfs4_slot), |
4626 | if (max_slots != old_max_slots) { | 4648 | GFP_KERNEL); |
4627 | dprintk("%s reset slot table does't match old\n", | 4649 | if (!new) |
4628 | __func__); | 4650 | goto out; |
4629 | ret = -EINVAL; /*XXX NFS4ERR_REQ_TOO_BIG ? */ | 4651 | ret = 0; |
4630 | goto out; | 4652 | kfree(tbl->slots); |
4631 | } | 4653 | } |
4632 | spin_lock(&tbl->slot_tbl_lock); | 4654 | spin_lock(&tbl->slot_tbl_lock); |
4633 | for (i = 0; i < max_slots; ++i) | 4655 | if (new) { |
4656 | tbl->slots = new; | ||
4657 | tbl->max_slots = max_reqs; | ||
4658 | } | ||
4659 | for (i = 0; i < tbl->max_slots; ++i) | ||
4634 | tbl->slots[i].seq_nr = ivalue; | 4660 | tbl->slots[i].seq_nr = ivalue; |
4635 | spin_unlock(&tbl->slot_tbl_lock); | 4661 | spin_unlock(&tbl->slot_tbl_lock); |
4636 | dprintk("%s: tbl=%p slots=%p max_slots=%d\n", __func__, | 4662 | dprintk("%s: tbl=%p slots=%p max_slots=%d\n", __func__, |
@@ -4648,16 +4674,12 @@ static int nfs4_reset_slot_tables(struct nfs4_session *session) | |||
4648 | int status; | 4674 | int status; |
4649 | 4675 | ||
4650 | status = nfs4_reset_slot_table(&session->fc_slot_table, | 4676 | status = nfs4_reset_slot_table(&session->fc_slot_table, |
4651 | session->fc_attrs.max_reqs, | 4677 | session->fc_attrs.max_reqs, 1); |
4652 | session->fc_slot_table.max_slots, | ||
4653 | 1); | ||
4654 | if (status) | 4678 | if (status) |
4655 | return status; | 4679 | return status; |
4656 | 4680 | ||
4657 | status = nfs4_reset_slot_table(&session->bc_slot_table, | 4681 | status = nfs4_reset_slot_table(&session->bc_slot_table, |
4658 | session->bc_attrs.max_reqs, | 4682 | session->bc_attrs.max_reqs, 0); |
4659 | session->bc_slot_table.max_slots, | ||
4660 | 0); | ||
4661 | return status; | 4683 | return status; |
4662 | } | 4684 | } |
4663 | 4685 | ||
@@ -4798,16 +4820,14 @@ static void nfs4_init_channel_attrs(struct nfs41_create_session_args *args) | |||
4798 | args->fc_attrs.headerpadsz = 0; | 4820 | args->fc_attrs.headerpadsz = 0; |
4799 | args->fc_attrs.max_rqst_sz = mxrqst_sz; | 4821 | args->fc_attrs.max_rqst_sz = mxrqst_sz; |
4800 | args->fc_attrs.max_resp_sz = mxresp_sz; | 4822 | args->fc_attrs.max_resp_sz = mxresp_sz; |
4801 | args->fc_attrs.max_resp_sz_cached = mxresp_sz; | ||
4802 | args->fc_attrs.max_ops = NFS4_MAX_OPS; | 4823 | args->fc_attrs.max_ops = NFS4_MAX_OPS; |
4803 | args->fc_attrs.max_reqs = session->clp->cl_rpcclient->cl_xprt->max_reqs; | 4824 | args->fc_attrs.max_reqs = session->clp->cl_rpcclient->cl_xprt->max_reqs; |
4804 | 4825 | ||
4805 | dprintk("%s: Fore Channel : max_rqst_sz=%u max_resp_sz=%u " | 4826 | dprintk("%s: Fore Channel : max_rqst_sz=%u max_resp_sz=%u " |
4806 | "max_resp_sz_cached=%u max_ops=%u max_reqs=%u\n", | 4827 | "max_ops=%u max_reqs=%u\n", |
4807 | __func__, | 4828 | __func__, |
4808 | args->fc_attrs.max_rqst_sz, args->fc_attrs.max_resp_sz, | 4829 | args->fc_attrs.max_rqst_sz, args->fc_attrs.max_resp_sz, |
4809 | args->fc_attrs.max_resp_sz_cached, args->fc_attrs.max_ops, | 4830 | args->fc_attrs.max_ops, args->fc_attrs.max_reqs); |
4810 | args->fc_attrs.max_reqs); | ||
4811 | 4831 | ||
4812 | /* Back channel attributes */ | 4832 | /* Back channel attributes */ |
4813 | args->bc_attrs.headerpadsz = 0; | 4833 | args->bc_attrs.headerpadsz = 0; |
@@ -5016,7 +5036,16 @@ static int nfs4_proc_sequence(struct nfs_client *clp, struct rpc_cred *cred) | |||
5016 | &res, args.sa_cache_this, 1); | 5036 | &res, args.sa_cache_this, 1); |
5017 | } | 5037 | } |
5018 | 5038 | ||
5019 | void nfs41_sequence_call_done(struct rpc_task *task, void *data) | 5039 | static void nfs41_sequence_release(void *data) |
5040 | { | ||
5041 | struct nfs_client *clp = (struct nfs_client *)data; | ||
5042 | |||
5043 | if (atomic_read(&clp->cl_count) > 1) | ||
5044 | nfs4_schedule_state_renewal(clp); | ||
5045 | nfs_put_client(clp); | ||
5046 | } | ||
5047 | |||
5048 | static void nfs41_sequence_call_done(struct rpc_task *task, void *data) | ||
5020 | { | 5049 | { |
5021 | struct nfs_client *clp = (struct nfs_client *)data; | 5050 | struct nfs_client *clp = (struct nfs_client *)data; |
5022 | 5051 | ||
@@ -5024,6 +5053,8 @@ void nfs41_sequence_call_done(struct rpc_task *task, void *data) | |||
5024 | 5053 | ||
5025 | if (task->tk_status < 0) { | 5054 | if (task->tk_status < 0) { |
5026 | dprintk("%s ERROR %d\n", __func__, task->tk_status); | 5055 | dprintk("%s ERROR %d\n", __func__, task->tk_status); |
5056 | if (atomic_read(&clp->cl_count) == 1) | ||
5057 | goto out; | ||
5027 | 5058 | ||
5028 | if (_nfs4_async_handle_error(task, NULL, clp, NULL) | 5059 | if (_nfs4_async_handle_error(task, NULL, clp, NULL) |
5029 | == -EAGAIN) { | 5060 | == -EAGAIN) { |
@@ -5032,7 +5063,7 @@ void nfs41_sequence_call_done(struct rpc_task *task, void *data) | |||
5032 | } | 5063 | } |
5033 | } | 5064 | } |
5034 | dprintk("%s rpc_cred %p\n", __func__, task->tk_msg.rpc_cred); | 5065 | dprintk("%s rpc_cred %p\n", __func__, task->tk_msg.rpc_cred); |
5035 | 5066 | out: | |
5036 | kfree(task->tk_msg.rpc_argp); | 5067 | kfree(task->tk_msg.rpc_argp); |
5037 | kfree(task->tk_msg.rpc_resp); | 5068 | kfree(task->tk_msg.rpc_resp); |
5038 | 5069 | ||
@@ -5057,6 +5088,7 @@ static void nfs41_sequence_prepare(struct rpc_task *task, void *data) | |||
5057 | static const struct rpc_call_ops nfs41_sequence_ops = { | 5088 | static const struct rpc_call_ops nfs41_sequence_ops = { |
5058 | .rpc_call_done = nfs41_sequence_call_done, | 5089 | .rpc_call_done = nfs41_sequence_call_done, |
5059 | .rpc_call_prepare = nfs41_sequence_prepare, | 5090 | .rpc_call_prepare = nfs41_sequence_prepare, |
5091 | .rpc_release = nfs41_sequence_release, | ||
5060 | }; | 5092 | }; |
5061 | 5093 | ||
5062 | static int nfs41_proc_async_sequence(struct nfs_client *clp, | 5094 | static int nfs41_proc_async_sequence(struct nfs_client *clp, |
@@ -5069,12 +5101,13 @@ static int nfs41_proc_async_sequence(struct nfs_client *clp, | |||
5069 | .rpc_cred = cred, | 5101 | .rpc_cred = cred, |
5070 | }; | 5102 | }; |
5071 | 5103 | ||
5104 | if (!atomic_inc_not_zero(&clp->cl_count)) | ||
5105 | return -EIO; | ||
5072 | args = kzalloc(sizeof(*args), GFP_KERNEL); | 5106 | args = kzalloc(sizeof(*args), GFP_KERNEL); |
5073 | if (!args) | ||
5074 | return -ENOMEM; | ||
5075 | res = kzalloc(sizeof(*res), GFP_KERNEL); | 5107 | res = kzalloc(sizeof(*res), GFP_KERNEL); |
5076 | if (!res) { | 5108 | if (!args || !res) { |
5077 | kfree(args); | 5109 | kfree(args); |
5110 | nfs_put_client(clp); | ||
5078 | return -ENOMEM; | 5111 | return -ENOMEM; |
5079 | } | 5112 | } |
5080 | res->sr_slotid = NFS4_MAX_SLOT_TABLE; | 5113 | res->sr_slotid = NFS4_MAX_SLOT_TABLE; |
diff --git a/fs/nfs/nfs4renewd.c b/fs/nfs/nfs4renewd.c index 0156c01c212c..d87f10327b72 100644 --- a/fs/nfs/nfs4renewd.c +++ b/fs/nfs/nfs4renewd.c | |||
@@ -36,11 +36,6 @@ | |||
36 | * as an rpc_task, not a real kernel thread, so it always runs in rpciod's | 36 | * as an rpc_task, not a real kernel thread, so it always runs in rpciod's |
37 | * context. There is one renewd per nfs_server. | 37 | * context. There is one renewd per nfs_server. |
38 | * | 38 | * |
39 | * TODO: If the send queue gets backlogged (e.g., if the server goes down), | ||
40 | * we will keep filling the queue with periodic RENEW requests. We need a | ||
41 | * mechanism for ensuring that if renewd successfully sends off a request, | ||
42 | * then it only wakes up when the request is finished. Maybe use the | ||
43 | * child task framework of the RPC layer? | ||
44 | */ | 39 | */ |
45 | 40 | ||
46 | #include <linux/mm.h> | 41 | #include <linux/mm.h> |
@@ -63,7 +58,7 @@ nfs4_renew_state(struct work_struct *work) | |||
63 | struct nfs_client *clp = | 58 | struct nfs_client *clp = |
64 | container_of(work, struct nfs_client, cl_renewd.work); | 59 | container_of(work, struct nfs_client, cl_renewd.work); |
65 | struct rpc_cred *cred; | 60 | struct rpc_cred *cred; |
66 | long lease, timeout; | 61 | long lease; |
67 | unsigned long last, now; | 62 | unsigned long last, now; |
68 | 63 | ||
69 | ops = nfs4_state_renewal_ops[clp->cl_minorversion]; | 64 | ops = nfs4_state_renewal_ops[clp->cl_minorversion]; |
@@ -75,7 +70,6 @@ nfs4_renew_state(struct work_struct *work) | |||
75 | lease = clp->cl_lease_time; | 70 | lease = clp->cl_lease_time; |
76 | last = clp->cl_last_renewal; | 71 | last = clp->cl_last_renewal; |
77 | now = jiffies; | 72 | now = jiffies; |
78 | timeout = (2 * lease) / 3 + (long)last - (long)now; | ||
79 | /* Are we close to a lease timeout? */ | 73 | /* Are we close to a lease timeout? */ |
80 | if (time_after(now, last + lease/3)) { | 74 | if (time_after(now, last + lease/3)) { |
81 | cred = ops->get_state_renewal_cred_locked(clp); | 75 | cred = ops->get_state_renewal_cred_locked(clp); |
@@ -90,19 +84,15 @@ nfs4_renew_state(struct work_struct *work) | |||
90 | /* Queue an asynchronous RENEW. */ | 84 | /* Queue an asynchronous RENEW. */ |
91 | ops->sched_state_renewal(clp, cred); | 85 | ops->sched_state_renewal(clp, cred); |
92 | put_rpccred(cred); | 86 | put_rpccred(cred); |
87 | goto out_exp; | ||
93 | } | 88 | } |
94 | timeout = (2 * lease) / 3; | 89 | } else { |
95 | spin_lock(&clp->cl_lock); | ||
96 | } else | ||
97 | dprintk("%s: failed to call renewd. Reason: lease not expired \n", | 90 | dprintk("%s: failed to call renewd. Reason: lease not expired \n", |
98 | __func__); | 91 | __func__); |
99 | if (timeout < 5 * HZ) /* safeguard */ | 92 | spin_unlock(&clp->cl_lock); |
100 | timeout = 5 * HZ; | 93 | } |
101 | dprintk("%s: requeueing work. Lease period = %ld\n", | 94 | nfs4_schedule_state_renewal(clp); |
102 | __func__, (timeout + HZ - 1) / HZ); | 95 | out_exp: |
103 | cancel_delayed_work(&clp->cl_renewd); | ||
104 | schedule_delayed_work(&clp->cl_renewd, timeout); | ||
105 | spin_unlock(&clp->cl_lock); | ||
106 | nfs_expire_unreferenced_delegations(clp); | 96 | nfs_expire_unreferenced_delegations(clp); |
107 | out: | 97 | out: |
108 | dprintk("%s: done\n", __func__); | 98 | dprintk("%s: done\n", __func__); |
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c index c1e2733f4fa4..6c5ed51f105e 100644 --- a/fs/nfs/nfs4state.c +++ b/fs/nfs/nfs4state.c | |||
@@ -1249,26 +1249,65 @@ static int nfs4_reclaim_lease(struct nfs_client *clp) | |||
1249 | } | 1249 | } |
1250 | 1250 | ||
1251 | #ifdef CONFIG_NFS_V4_1 | 1251 | #ifdef CONFIG_NFS_V4_1 |
1252 | void nfs41_handle_recall_slot(struct nfs_client *clp) | ||
1253 | { | ||
1254 | set_bit(NFS4CLNT_RECALL_SLOT, &clp->cl_state); | ||
1255 | nfs4_schedule_state_recovery(clp); | ||
1256 | } | ||
1257 | |||
1258 | static void nfs4_reset_all_state(struct nfs_client *clp) | ||
1259 | { | ||
1260 | if (test_and_set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state) == 0) { | ||
1261 | clp->cl_boot_time = CURRENT_TIME; | ||
1262 | nfs4_state_start_reclaim_nograce(clp); | ||
1263 | nfs4_schedule_state_recovery(clp); | ||
1264 | } | ||
1265 | } | ||
1266 | |||
1267 | static void nfs41_handle_server_reboot(struct nfs_client *clp) | ||
1268 | { | ||
1269 | if (test_and_set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state) == 0) { | ||
1270 | nfs4_state_start_reclaim_reboot(clp); | ||
1271 | nfs4_schedule_state_recovery(clp); | ||
1272 | } | ||
1273 | } | ||
1274 | |||
1275 | static void nfs41_handle_state_revoked(struct nfs_client *clp) | ||
1276 | { | ||
1277 | /* Temporary */ | ||
1278 | nfs4_reset_all_state(clp); | ||
1279 | } | ||
1280 | |||
1281 | static void nfs41_handle_recallable_state_revoked(struct nfs_client *clp) | ||
1282 | { | ||
1283 | /* This will need to handle layouts too */ | ||
1284 | nfs_expire_all_delegations(clp); | ||
1285 | } | ||
1286 | |||
1287 | static void nfs41_handle_cb_path_down(struct nfs_client *clp) | ||
1288 | { | ||
1289 | nfs_expire_all_delegations(clp); | ||
1290 | if (test_and_set_bit(NFS4CLNT_SESSION_RESET, &clp->cl_state) == 0) | ||
1291 | nfs4_schedule_state_recovery(clp); | ||
1292 | } | ||
1293 | |||
1252 | void nfs41_handle_sequence_flag_errors(struct nfs_client *clp, u32 flags) | 1294 | void nfs41_handle_sequence_flag_errors(struct nfs_client *clp, u32 flags) |
1253 | { | 1295 | { |
1254 | if (!flags) | 1296 | if (!flags) |
1255 | return; | 1297 | return; |
1256 | else if (flags & SEQ4_STATUS_RESTART_RECLAIM_NEEDED) { | 1298 | else if (flags & SEQ4_STATUS_RESTART_RECLAIM_NEEDED) |
1257 | set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state); | 1299 | nfs41_handle_server_reboot(clp); |
1258 | nfs4_state_start_reclaim_reboot(clp); | 1300 | else if (flags & (SEQ4_STATUS_EXPIRED_ALL_STATE_REVOKED | |
1259 | nfs4_schedule_state_recovery(clp); | ||
1260 | } else if (flags & (SEQ4_STATUS_EXPIRED_ALL_STATE_REVOKED | | ||
1261 | SEQ4_STATUS_EXPIRED_SOME_STATE_REVOKED | | 1301 | SEQ4_STATUS_EXPIRED_SOME_STATE_REVOKED | |
1262 | SEQ4_STATUS_ADMIN_STATE_REVOKED | | 1302 | SEQ4_STATUS_ADMIN_STATE_REVOKED | |
1263 | SEQ4_STATUS_RECALLABLE_STATE_REVOKED | | 1303 | SEQ4_STATUS_LEASE_MOVED)) |
1264 | SEQ4_STATUS_LEASE_MOVED)) { | 1304 | nfs41_handle_state_revoked(clp); |
1265 | set_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state); | 1305 | else if (flags & SEQ4_STATUS_RECALLABLE_STATE_REVOKED) |
1266 | nfs4_state_start_reclaim_nograce(clp); | 1306 | nfs41_handle_recallable_state_revoked(clp); |
1267 | nfs4_schedule_state_recovery(clp); | 1307 | else if (flags & (SEQ4_STATUS_CB_PATH_DOWN | |
1268 | } else if (flags & (SEQ4_STATUS_CB_PATH_DOWN | | ||
1269 | SEQ4_STATUS_BACKCHANNEL_FAULT | | 1308 | SEQ4_STATUS_BACKCHANNEL_FAULT | |
1270 | SEQ4_STATUS_CB_PATH_DOWN_SESSION)) | 1309 | SEQ4_STATUS_CB_PATH_DOWN_SESSION)) |
1271 | nfs_expire_all_delegations(clp); | 1310 | nfs41_handle_cb_path_down(clp); |
1272 | } | 1311 | } |
1273 | 1312 | ||
1274 | static int nfs4_reset_session(struct nfs_client *clp) | 1313 | static int nfs4_reset_session(struct nfs_client *clp) |
@@ -1285,23 +1324,52 @@ static int nfs4_reset_session(struct nfs_client *clp) | |||
1285 | 1324 | ||
1286 | memset(clp->cl_session->sess_id.data, 0, NFS4_MAX_SESSIONID_LEN); | 1325 | memset(clp->cl_session->sess_id.data, 0, NFS4_MAX_SESSIONID_LEN); |
1287 | status = nfs4_proc_create_session(clp); | 1326 | status = nfs4_proc_create_session(clp); |
1288 | if (status) | 1327 | if (status) { |
1289 | status = nfs4_recovery_handle_error(clp, status); | 1328 | status = nfs4_recovery_handle_error(clp, status); |
1329 | goto out; | ||
1330 | } | ||
1331 | /* create_session negotiated new slot table */ | ||
1332 | clear_bit(NFS4CLNT_RECALL_SLOT, &clp->cl_state); | ||
1290 | 1333 | ||
1291 | out: | 1334 | /* Let the state manager reestablish state */ |
1292 | /* | 1335 | if (!test_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state)) |
1293 | * Let the state manager reestablish state | ||
1294 | */ | ||
1295 | if (!test_bit(NFS4CLNT_LEASE_EXPIRED, &clp->cl_state) && | ||
1296 | status == 0) | ||
1297 | nfs41_setup_state_renewal(clp); | 1336 | nfs41_setup_state_renewal(clp); |
1298 | 1337 | out: | |
1299 | return status; | 1338 | return status; |
1300 | } | 1339 | } |
1301 | 1340 | ||
1341 | static int nfs4_recall_slot(struct nfs_client *clp) | ||
1342 | { | ||
1343 | struct nfs4_slot_table *fc_tbl = &clp->cl_session->fc_slot_table; | ||
1344 | struct nfs4_channel_attrs *fc_attrs = &clp->cl_session->fc_attrs; | ||
1345 | struct nfs4_slot *new, *old; | ||
1346 | int i; | ||
1347 | |||
1348 | nfs4_begin_drain_session(clp); | ||
1349 | new = kmalloc(fc_tbl->target_max_slots * sizeof(struct nfs4_slot), | ||
1350 | GFP_KERNEL); | ||
1351 | if (!new) | ||
1352 | return -ENOMEM; | ||
1353 | |||
1354 | spin_lock(&fc_tbl->slot_tbl_lock); | ||
1355 | for (i = 0; i < fc_tbl->target_max_slots; i++) | ||
1356 | new[i].seq_nr = fc_tbl->slots[i].seq_nr; | ||
1357 | old = fc_tbl->slots; | ||
1358 | fc_tbl->slots = new; | ||
1359 | fc_tbl->max_slots = fc_tbl->target_max_slots; | ||
1360 | fc_tbl->target_max_slots = 0; | ||
1361 | fc_attrs->max_reqs = fc_tbl->max_slots; | ||
1362 | spin_unlock(&fc_tbl->slot_tbl_lock); | ||
1363 | |||
1364 | kfree(old); | ||
1365 | nfs4_end_drain_session(clp); | ||
1366 | return 0; | ||
1367 | } | ||
1368 | |||
1302 | #else /* CONFIG_NFS_V4_1 */ | 1369 | #else /* CONFIG_NFS_V4_1 */ |
1303 | static int nfs4_reset_session(struct nfs_client *clp) { return 0; } | 1370 | static int nfs4_reset_session(struct nfs_client *clp) { return 0; } |
1304 | static int nfs4_end_drain_session(struct nfs_client *clp) { return 0; } | 1371 | static int nfs4_end_drain_session(struct nfs_client *clp) { return 0; } |
1372 | static int nfs4_recall_slot(struct nfs_client *clp) { return 0; } | ||
1305 | #endif /* CONFIG_NFS_V4_1 */ | 1373 | #endif /* CONFIG_NFS_V4_1 */ |
1306 | 1374 | ||
1307 | /* Set NFS4CLNT_LEASE_EXPIRED for all v4.0 errors and for recoverable errors | 1375 | /* Set NFS4CLNT_LEASE_EXPIRED for all v4.0 errors and for recoverable errors |
@@ -1314,6 +1382,7 @@ static void nfs4_set_lease_expired(struct nfs_client *clp, int status) | |||
1314 | case -NFS4ERR_DELAY: | 1382 | case -NFS4ERR_DELAY: |
1315 | case -NFS4ERR_CLID_INUSE: | 1383 | case -NFS4ERR_CLID_INUSE: |
1316 | case -EAGAIN: | 1384 | case -EAGAIN: |
1385 | case -EKEYEXPIRED: | ||
1317 | break; | 1386 | break; |
1318 | 1387 | ||
1319 | case -NFS4ERR_NOT_SAME: /* FixMe: implement recovery | 1388 | case -NFS4ERR_NOT_SAME: /* FixMe: implement recovery |
@@ -1397,6 +1466,15 @@ static void nfs4_state_manager(struct nfs_client *clp) | |||
1397 | nfs_client_return_marked_delegations(clp); | 1466 | nfs_client_return_marked_delegations(clp); |
1398 | continue; | 1467 | continue; |
1399 | } | 1468 | } |
1469 | /* Recall session slots */ | ||
1470 | if (test_and_clear_bit(NFS4CLNT_RECALL_SLOT, &clp->cl_state) | ||
1471 | && nfs4_has_session(clp)) { | ||
1472 | status = nfs4_recall_slot(clp); | ||
1473 | if (status < 0) | ||
1474 | goto out_error; | ||
1475 | continue; | ||
1476 | } | ||
1477 | |||
1400 | 1478 | ||
1401 | nfs4_clear_state_manager_bit(clp); | 1479 | nfs4_clear_state_manager_bit(clp); |
1402 | /* Did we race with an attempt to give us more work? */ | 1480 | /* Did we race with an attempt to give us more work? */ |
diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c index 5cd5184b56db..4d338be492cb 100644 --- a/fs/nfs/nfs4xdr.c +++ b/fs/nfs/nfs4xdr.c | |||
@@ -1578,6 +1578,14 @@ static void encode_create_session(struct xdr_stream *xdr, | |||
1578 | char machine_name[NFS4_MAX_MACHINE_NAME_LEN]; | 1578 | char machine_name[NFS4_MAX_MACHINE_NAME_LEN]; |
1579 | uint32_t len; | 1579 | uint32_t len; |
1580 | struct nfs_client *clp = args->client; | 1580 | struct nfs_client *clp = args->client; |
1581 | u32 max_resp_sz_cached; | ||
1582 | |||
1583 | /* | ||
1584 | * Assumes OPEN is the biggest non-idempotent compound. | ||
1585 | * 2 is the verifier. | ||
1586 | */ | ||
1587 | max_resp_sz_cached = (NFS4_dec_open_sz + RPC_REPHDRSIZE + | ||
1588 | RPC_MAX_AUTH_SIZE + 2) * XDR_UNIT; | ||
1581 | 1589 | ||
1582 | len = scnprintf(machine_name, sizeof(machine_name), "%s", | 1590 | len = scnprintf(machine_name, sizeof(machine_name), "%s", |
1583 | clp->cl_ipaddr); | 1591 | clp->cl_ipaddr); |
@@ -1592,7 +1600,7 @@ static void encode_create_session(struct xdr_stream *xdr, | |||
1592 | *p++ = cpu_to_be32(args->fc_attrs.headerpadsz); /* header padding size */ | 1600 | *p++ = cpu_to_be32(args->fc_attrs.headerpadsz); /* header padding size */ |
1593 | *p++ = cpu_to_be32(args->fc_attrs.max_rqst_sz); /* max req size */ | 1601 | *p++ = cpu_to_be32(args->fc_attrs.max_rqst_sz); /* max req size */ |
1594 | *p++ = cpu_to_be32(args->fc_attrs.max_resp_sz); /* max resp size */ | 1602 | *p++ = cpu_to_be32(args->fc_attrs.max_resp_sz); /* max resp size */ |
1595 | *p++ = cpu_to_be32(args->fc_attrs.max_resp_sz_cached); /* Max resp sz cached */ | 1603 | *p++ = cpu_to_be32(max_resp_sz_cached); /* Max resp sz cached */ |
1596 | *p++ = cpu_to_be32(args->fc_attrs.max_ops); /* max operations */ | 1604 | *p++ = cpu_to_be32(args->fc_attrs.max_ops); /* max operations */ |
1597 | *p++ = cpu_to_be32(args->fc_attrs.max_reqs); /* max requests */ | 1605 | *p++ = cpu_to_be32(args->fc_attrs.max_reqs); /* max requests */ |
1598 | *p++ = cpu_to_be32(0); /* rdmachannel_attrs */ | 1606 | *p++ = cpu_to_be32(0); /* rdmachannel_attrs */ |
diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c index ef583854d8d0..c752d944fe9e 100644 --- a/fs/nfs/proc.c +++ b/fs/nfs/proc.c | |||
@@ -47,6 +47,39 @@ | |||
47 | #define NFSDBG_FACILITY NFSDBG_PROC | 47 | #define NFSDBG_FACILITY NFSDBG_PROC |
48 | 48 | ||
49 | /* | 49 | /* |
50 | * wrapper to handle the -EKEYEXPIRED error message. This should generally | ||
51 | * only happen if using krb5 auth and a user's TGT expires. NFSv2 doesn't | ||
52 | * support the NFSERR_JUKEBOX error code, but we handle this situation in the | ||
53 | * same way that we handle that error with NFSv3. | ||
54 | */ | ||
55 | static int | ||
56 | nfs_rpc_wrapper(struct rpc_clnt *clnt, struct rpc_message *msg, int flags) | ||
57 | { | ||
58 | int res; | ||
59 | do { | ||
60 | res = rpc_call_sync(clnt, msg, flags); | ||
61 | if (res != -EKEYEXPIRED) | ||
62 | break; | ||
63 | schedule_timeout_killable(NFS_JUKEBOX_RETRY_TIME); | ||
64 | res = -ERESTARTSYS; | ||
65 | } while (!fatal_signal_pending(current)); | ||
66 | return res; | ||
67 | } | ||
68 | |||
69 | #define rpc_call_sync(clnt, msg, flags) nfs_rpc_wrapper(clnt, msg, flags) | ||
70 | |||
71 | static int | ||
72 | nfs_async_handle_expired_key(struct rpc_task *task) | ||
73 | { | ||
74 | if (task->tk_status != -EKEYEXPIRED) | ||
75 | return 0; | ||
76 | task->tk_status = 0; | ||
77 | rpc_restart_call(task); | ||
78 | rpc_delay(task, NFS_JUKEBOX_RETRY_TIME); | ||
79 | return 1; | ||
80 | } | ||
81 | |||
82 | /* | ||
50 | * Bare-bones access to getattr: this is for nfs_read_super. | 83 | * Bare-bones access to getattr: this is for nfs_read_super. |
51 | */ | 84 | */ |
52 | static int | 85 | static int |
@@ -307,6 +340,8 @@ nfs_proc_unlink_setup(struct rpc_message *msg, struct inode *dir) | |||
307 | 340 | ||
308 | static int nfs_proc_unlink_done(struct rpc_task *task, struct inode *dir) | 341 | static int nfs_proc_unlink_done(struct rpc_task *task, struct inode *dir) |
309 | { | 342 | { |
343 | if (nfs_async_handle_expired_key(task)) | ||
344 | return 0; | ||
310 | nfs_mark_for_revalidate(dir); | 345 | nfs_mark_for_revalidate(dir); |
311 | return 1; | 346 | return 1; |
312 | } | 347 | } |
@@ -560,6 +595,9 @@ nfs_proc_pathconf(struct nfs_server *server, struct nfs_fh *fhandle, | |||
560 | 595 | ||
561 | static int nfs_read_done(struct rpc_task *task, struct nfs_read_data *data) | 596 | static int nfs_read_done(struct rpc_task *task, struct nfs_read_data *data) |
562 | { | 597 | { |
598 | if (nfs_async_handle_expired_key(task)) | ||
599 | return -EAGAIN; | ||
600 | |||
563 | nfs_invalidate_atime(data->inode); | 601 | nfs_invalidate_atime(data->inode); |
564 | if (task->tk_status >= 0) { | 602 | if (task->tk_status >= 0) { |
565 | nfs_refresh_inode(data->inode, data->res.fattr); | 603 | nfs_refresh_inode(data->inode, data->res.fattr); |
@@ -579,6 +617,9 @@ static void nfs_proc_read_setup(struct nfs_read_data *data, struct rpc_message * | |||
579 | 617 | ||
580 | static int nfs_write_done(struct rpc_task *task, struct nfs_write_data *data) | 618 | static int nfs_write_done(struct rpc_task *task, struct nfs_write_data *data) |
581 | { | 619 | { |
620 | if (nfs_async_handle_expired_key(task)) | ||
621 | return -EAGAIN; | ||
622 | |||
582 | if (task->tk_status >= 0) | 623 | if (task->tk_status >= 0) |
583 | nfs_post_op_update_inode_force_wcc(data->inode, data->res.fattr); | 624 | nfs_post_op_update_inode_force_wcc(data->inode, data->res.fattr); |
584 | return 0; | 625 | return 0; |
diff --git a/fs/nfs/symlink.c b/fs/nfs/symlink.c index 412738dbfbc7..2ea9e5c27e55 100644 --- a/fs/nfs/symlink.c +++ b/fs/nfs/symlink.c | |||
@@ -50,7 +50,7 @@ static void *nfs_follow_link(struct dentry *dentry, struct nameidata *nd) | |||
50 | struct page *page; | 50 | struct page *page; |
51 | void *err; | 51 | void *err; |
52 | 52 | ||
53 | err = ERR_PTR(nfs_revalidate_mapping_nolock(inode, inode->i_mapping)); | 53 | err = ERR_PTR(nfs_revalidate_mapping(inode, inode->i_mapping)); |
54 | if (err) | 54 | if (err) |
55 | goto read_failed; | 55 | goto read_failed; |
56 | page = read_cache_page(&inode->i_data, 0, | 56 | page = read_cache_page(&inode->i_data, 0, |
diff --git a/fs/nfs/write.c b/fs/nfs/write.c index d63d964a0392..53ff70e23993 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c | |||
@@ -438,6 +438,7 @@ nfs_mark_request_commit(struct nfs_page *req) | |||
438 | radix_tree_tag_set(&nfsi->nfs_page_tree, | 438 | radix_tree_tag_set(&nfsi->nfs_page_tree, |
439 | req->wb_index, | 439 | req->wb_index, |
440 | NFS_PAGE_TAG_COMMIT); | 440 | NFS_PAGE_TAG_COMMIT); |
441 | nfsi->ncommit++; | ||
441 | spin_unlock(&inode->i_lock); | 442 | spin_unlock(&inode->i_lock); |
442 | inc_zone_page_state(req->wb_page, NR_UNSTABLE_NFS); | 443 | inc_zone_page_state(req->wb_page, NR_UNSTABLE_NFS); |
443 | inc_bdi_stat(req->wb_page->mapping->backing_dev_info, BDI_RECLAIMABLE); | 444 | inc_bdi_stat(req->wb_page->mapping->backing_dev_info, BDI_RECLAIMABLE); |
@@ -501,57 +502,6 @@ int nfs_reschedule_unstable_write(struct nfs_page *req) | |||
501 | } | 502 | } |
502 | #endif | 503 | #endif |
503 | 504 | ||
504 | /* | ||
505 | * Wait for a request to complete. | ||
506 | * | ||
507 | * Interruptible by fatal signals only. | ||
508 | */ | ||
509 | static int nfs_wait_on_requests_locked(struct inode *inode, pgoff_t idx_start, unsigned int npages) | ||
510 | { | ||
511 | struct nfs_inode *nfsi = NFS_I(inode); | ||
512 | struct nfs_page *req; | ||
513 | pgoff_t idx_end, next; | ||
514 | unsigned int res = 0; | ||
515 | int error; | ||
516 | |||
517 | if (npages == 0) | ||
518 | idx_end = ~0; | ||
519 | else | ||
520 | idx_end = idx_start + npages - 1; | ||
521 | |||
522 | next = idx_start; | ||
523 | while (radix_tree_gang_lookup_tag(&nfsi->nfs_page_tree, (void **)&req, next, 1, NFS_PAGE_TAG_LOCKED)) { | ||
524 | if (req->wb_index > idx_end) | ||
525 | break; | ||
526 | |||
527 | next = req->wb_index + 1; | ||
528 | BUG_ON(!NFS_WBACK_BUSY(req)); | ||
529 | |||
530 | kref_get(&req->wb_kref); | ||
531 | spin_unlock(&inode->i_lock); | ||
532 | error = nfs_wait_on_request(req); | ||
533 | nfs_release_request(req); | ||
534 | spin_lock(&inode->i_lock); | ||
535 | if (error < 0) | ||
536 | return error; | ||
537 | res++; | ||
538 | } | ||
539 | return res; | ||
540 | } | ||
541 | |||
542 | static void nfs_cancel_commit_list(struct list_head *head) | ||
543 | { | ||
544 | struct nfs_page *req; | ||
545 | |||
546 | while(!list_empty(head)) { | ||
547 | req = nfs_list_entry(head->next); | ||
548 | nfs_list_remove_request(req); | ||
549 | nfs_clear_request_commit(req); | ||
550 | nfs_inode_remove_request(req); | ||
551 | nfs_unlock_request(req); | ||
552 | } | ||
553 | } | ||
554 | |||
555 | #if defined(CONFIG_NFS_V3) || defined(CONFIG_NFS_V4) | 505 | #if defined(CONFIG_NFS_V3) || defined(CONFIG_NFS_V4) |
556 | static int | 506 | static int |
557 | nfs_need_commit(struct nfs_inode *nfsi) | 507 | nfs_need_commit(struct nfs_inode *nfsi) |
@@ -573,11 +523,17 @@ static int | |||
573 | nfs_scan_commit(struct inode *inode, struct list_head *dst, pgoff_t idx_start, unsigned int npages) | 523 | nfs_scan_commit(struct inode *inode, struct list_head *dst, pgoff_t idx_start, unsigned int npages) |
574 | { | 524 | { |
575 | struct nfs_inode *nfsi = NFS_I(inode); | 525 | struct nfs_inode *nfsi = NFS_I(inode); |
526 | int ret; | ||
576 | 527 | ||
577 | if (!nfs_need_commit(nfsi)) | 528 | if (!nfs_need_commit(nfsi)) |
578 | return 0; | 529 | return 0; |
579 | 530 | ||
580 | return nfs_scan_list(nfsi, dst, idx_start, npages, NFS_PAGE_TAG_COMMIT); | 531 | ret = nfs_scan_list(nfsi, dst, idx_start, npages, NFS_PAGE_TAG_COMMIT); |
532 | if (ret > 0) | ||
533 | nfsi->ncommit -= ret; | ||
534 | if (nfs_need_commit(NFS_I(inode))) | ||
535 | __mark_inode_dirty(inode, I_DIRTY_DATASYNC); | ||
536 | return ret; | ||
581 | } | 537 | } |
582 | #else | 538 | #else |
583 | static inline int nfs_need_commit(struct nfs_inode *nfsi) | 539 | static inline int nfs_need_commit(struct nfs_inode *nfsi) |
@@ -642,9 +598,10 @@ static struct nfs_page *nfs_try_to_update_request(struct inode *inode, | |||
642 | spin_lock(&inode->i_lock); | 598 | spin_lock(&inode->i_lock); |
643 | } | 599 | } |
644 | 600 | ||
645 | if (nfs_clear_request_commit(req)) | 601 | if (nfs_clear_request_commit(req) && |
646 | radix_tree_tag_clear(&NFS_I(inode)->nfs_page_tree, | 602 | radix_tree_tag_clear(&NFS_I(inode)->nfs_page_tree, |
647 | req->wb_index, NFS_PAGE_TAG_COMMIT); | 603 | req->wb_index, NFS_PAGE_TAG_COMMIT) != NULL) |
604 | NFS_I(inode)->ncommit--; | ||
648 | 605 | ||
649 | /* Okay, the request matches. Update the region */ | 606 | /* Okay, the request matches. Update the region */ |
650 | if (offset < req->wb_offset) { | 607 | if (offset < req->wb_offset) { |
@@ -1391,7 +1348,7 @@ static const struct rpc_call_ops nfs_commit_ops = { | |||
1391 | .rpc_release = nfs_commit_release, | 1348 | .rpc_release = nfs_commit_release, |
1392 | }; | 1349 | }; |
1393 | 1350 | ||
1394 | int nfs_commit_inode(struct inode *inode, int how) | 1351 | static int nfs_commit_inode(struct inode *inode, int how) |
1395 | { | 1352 | { |
1396 | LIST_HEAD(head); | 1353 | LIST_HEAD(head); |
1397 | int res; | 1354 | int res; |
@@ -1406,92 +1363,51 @@ int nfs_commit_inode(struct inode *inode, int how) | |||
1406 | } | 1363 | } |
1407 | return res; | 1364 | return res; |
1408 | } | 1365 | } |
1409 | #else | ||
1410 | static inline int nfs_commit_list(struct inode *inode, struct list_head *head, int how) | ||
1411 | { | ||
1412 | return 0; | ||
1413 | } | ||
1414 | #endif | ||
1415 | 1366 | ||
1416 | long nfs_sync_mapping_wait(struct address_space *mapping, struct writeback_control *wbc, int how) | 1367 | static int nfs_commit_unstable_pages(struct inode *inode, struct writeback_control *wbc) |
1417 | { | 1368 | { |
1418 | struct inode *inode = mapping->host; | 1369 | struct nfs_inode *nfsi = NFS_I(inode); |
1419 | pgoff_t idx_start, idx_end; | 1370 | int flags = FLUSH_SYNC; |
1420 | unsigned int npages = 0; | 1371 | int ret = 0; |
1421 | LIST_HEAD(head); | 1372 | |
1422 | int nocommit = how & FLUSH_NOCOMMIT; | 1373 | /* Don't commit yet if this is a non-blocking flush and there are |
1423 | long pages, ret; | 1374 | * lots of outstanding writes for this mapping. |
1424 | 1375 | */ | |
1425 | /* FIXME */ | 1376 | if (wbc->sync_mode == WB_SYNC_NONE && |
1426 | if (wbc->range_cyclic) | 1377 | nfsi->ncommit <= (nfsi->npages >> 1)) |
1427 | idx_start = 0; | 1378 | goto out_mark_dirty; |
1428 | else { | 1379 | |
1429 | idx_start = wbc->range_start >> PAGE_CACHE_SHIFT; | 1380 | if (wbc->nonblocking || wbc->for_background) |
1430 | idx_end = wbc->range_end >> PAGE_CACHE_SHIFT; | 1381 | flags = 0; |
1431 | if (idx_end > idx_start) { | 1382 | ret = nfs_commit_inode(inode, flags); |
1432 | pgoff_t l_npages = 1 + idx_end - idx_start; | 1383 | if (ret >= 0) { |
1433 | npages = l_npages; | 1384 | if (wbc->sync_mode == WB_SYNC_NONE) { |
1434 | if (sizeof(npages) != sizeof(l_npages) && | 1385 | if (ret < wbc->nr_to_write) |
1435 | (pgoff_t)npages != l_npages) | 1386 | wbc->nr_to_write -= ret; |
1436 | npages = 0; | 1387 | else |
1388 | wbc->nr_to_write = 0; | ||
1437 | } | 1389 | } |
1390 | return 0; | ||
1438 | } | 1391 | } |
1439 | how &= ~FLUSH_NOCOMMIT; | 1392 | out_mark_dirty: |
1440 | spin_lock(&inode->i_lock); | 1393 | __mark_inode_dirty(inode, I_DIRTY_DATASYNC); |
1441 | do { | ||
1442 | ret = nfs_wait_on_requests_locked(inode, idx_start, npages); | ||
1443 | if (ret != 0) | ||
1444 | continue; | ||
1445 | if (nocommit) | ||
1446 | break; | ||
1447 | pages = nfs_scan_commit(inode, &head, idx_start, npages); | ||
1448 | if (pages == 0) | ||
1449 | break; | ||
1450 | if (how & FLUSH_INVALIDATE) { | ||
1451 | spin_unlock(&inode->i_lock); | ||
1452 | nfs_cancel_commit_list(&head); | ||
1453 | ret = pages; | ||
1454 | spin_lock(&inode->i_lock); | ||
1455 | continue; | ||
1456 | } | ||
1457 | pages += nfs_scan_commit(inode, &head, 0, 0); | ||
1458 | spin_unlock(&inode->i_lock); | ||
1459 | ret = nfs_commit_list(inode, &head, how); | ||
1460 | spin_lock(&inode->i_lock); | ||
1461 | |||
1462 | } while (ret >= 0); | ||
1463 | spin_unlock(&inode->i_lock); | ||
1464 | return ret; | 1394 | return ret; |
1465 | } | 1395 | } |
1466 | 1396 | #else | |
1467 | static int __nfs_write_mapping(struct address_space *mapping, struct writeback_control *wbc, int how) | 1397 | static int nfs_commit_inode(struct inode *inode, int how) |
1468 | { | 1398 | { |
1469 | int ret; | ||
1470 | |||
1471 | ret = nfs_writepages(mapping, wbc); | ||
1472 | if (ret < 0) | ||
1473 | goto out; | ||
1474 | ret = nfs_sync_mapping_wait(mapping, wbc, how); | ||
1475 | if (ret < 0) | ||
1476 | goto out; | ||
1477 | return 0; | 1399 | return 0; |
1478 | out: | ||
1479 | __mark_inode_dirty(mapping->host, I_DIRTY_PAGES); | ||
1480 | return ret; | ||
1481 | } | 1400 | } |
1482 | 1401 | ||
1483 | /* Two pass sync: first using WB_SYNC_NONE, then WB_SYNC_ALL */ | 1402 | static int nfs_commit_unstable_pages(struct inode *inode, struct writeback_control *wbc) |
1484 | static int nfs_write_mapping(struct address_space *mapping, int how) | ||
1485 | { | 1403 | { |
1486 | struct writeback_control wbc = { | 1404 | return 0; |
1487 | .bdi = mapping->backing_dev_info, | 1405 | } |
1488 | .sync_mode = WB_SYNC_ALL, | 1406 | #endif |
1489 | .nr_to_write = LONG_MAX, | ||
1490 | .range_start = 0, | ||
1491 | .range_end = LLONG_MAX, | ||
1492 | }; | ||
1493 | 1407 | ||
1494 | return __nfs_write_mapping(mapping, &wbc, how); | 1408 | int nfs_write_inode(struct inode *inode, struct writeback_control *wbc) |
1409 | { | ||
1410 | return nfs_commit_unstable_pages(inode, wbc); | ||
1495 | } | 1411 | } |
1496 | 1412 | ||
1497 | /* | 1413 | /* |
@@ -1499,37 +1415,26 @@ static int nfs_write_mapping(struct address_space *mapping, int how) | |||
1499 | */ | 1415 | */ |
1500 | int nfs_wb_all(struct inode *inode) | 1416 | int nfs_wb_all(struct inode *inode) |
1501 | { | 1417 | { |
1502 | return nfs_write_mapping(inode->i_mapping, 0); | 1418 | struct writeback_control wbc = { |
1503 | } | 1419 | .sync_mode = WB_SYNC_ALL, |
1420 | .nr_to_write = LONG_MAX, | ||
1421 | .range_start = 0, | ||
1422 | .range_end = LLONG_MAX, | ||
1423 | }; | ||
1504 | 1424 | ||
1505 | int nfs_wb_nocommit(struct inode *inode) | 1425 | return sync_inode(inode, &wbc); |
1506 | { | ||
1507 | return nfs_write_mapping(inode->i_mapping, FLUSH_NOCOMMIT); | ||
1508 | } | 1426 | } |
1509 | 1427 | ||
1510 | int nfs_wb_page_cancel(struct inode *inode, struct page *page) | 1428 | int nfs_wb_page_cancel(struct inode *inode, struct page *page) |
1511 | { | 1429 | { |
1512 | struct nfs_page *req; | 1430 | struct nfs_page *req; |
1513 | loff_t range_start = page_offset(page); | ||
1514 | loff_t range_end = range_start + (loff_t)(PAGE_CACHE_SIZE - 1); | ||
1515 | struct writeback_control wbc = { | ||
1516 | .bdi = page->mapping->backing_dev_info, | ||
1517 | .sync_mode = WB_SYNC_ALL, | ||
1518 | .nr_to_write = LONG_MAX, | ||
1519 | .range_start = range_start, | ||
1520 | .range_end = range_end, | ||
1521 | }; | ||
1522 | int ret = 0; | 1431 | int ret = 0; |
1523 | 1432 | ||
1524 | BUG_ON(!PageLocked(page)); | 1433 | BUG_ON(!PageLocked(page)); |
1525 | for (;;) { | 1434 | for (;;) { |
1526 | req = nfs_page_find_request(page); | 1435 | req = nfs_page_find_request(page); |
1527 | if (req == NULL) | 1436 | if (req == NULL) |
1528 | goto out; | ||
1529 | if (test_bit(PG_CLEAN, &req->wb_flags)) { | ||
1530 | nfs_release_request(req); | ||
1531 | break; | 1437 | break; |
1532 | } | ||
1533 | if (nfs_lock_request_dontget(req)) { | 1438 | if (nfs_lock_request_dontget(req)) { |
1534 | nfs_inode_remove_request(req); | 1439 | nfs_inode_remove_request(req); |
1535 | /* | 1440 | /* |
@@ -1543,54 +1448,54 @@ int nfs_wb_page_cancel(struct inode *inode, struct page *page) | |||
1543 | ret = nfs_wait_on_request(req); | 1448 | ret = nfs_wait_on_request(req); |
1544 | nfs_release_request(req); | 1449 | nfs_release_request(req); |
1545 | if (ret < 0) | 1450 | if (ret < 0) |
1546 | goto out; | 1451 | break; |
1547 | } | 1452 | } |
1548 | if (!PagePrivate(page)) | ||
1549 | return 0; | ||
1550 | ret = nfs_sync_mapping_wait(page->mapping, &wbc, FLUSH_INVALIDATE); | ||
1551 | out: | ||
1552 | return ret; | 1453 | return ret; |
1553 | } | 1454 | } |
1554 | 1455 | ||
1555 | static int nfs_wb_page_priority(struct inode *inode, struct page *page, | 1456 | /* |
1556 | int how) | 1457 | * Write back all requests on one page - we do this before reading it. |
1458 | */ | ||
1459 | int nfs_wb_page(struct inode *inode, struct page *page) | ||
1557 | { | 1460 | { |
1558 | loff_t range_start = page_offset(page); | 1461 | loff_t range_start = page_offset(page); |
1559 | loff_t range_end = range_start + (loff_t)(PAGE_CACHE_SIZE - 1); | 1462 | loff_t range_end = range_start + (loff_t)(PAGE_CACHE_SIZE - 1); |
1560 | struct writeback_control wbc = { | 1463 | struct writeback_control wbc = { |
1561 | .bdi = page->mapping->backing_dev_info, | ||
1562 | .sync_mode = WB_SYNC_ALL, | 1464 | .sync_mode = WB_SYNC_ALL, |
1563 | .nr_to_write = LONG_MAX, | 1465 | .nr_to_write = 0, |
1564 | .range_start = range_start, | 1466 | .range_start = range_start, |
1565 | .range_end = range_end, | 1467 | .range_end = range_end, |
1566 | }; | 1468 | }; |
1469 | struct nfs_page *req; | ||
1470 | int need_commit; | ||
1567 | int ret; | 1471 | int ret; |
1568 | 1472 | ||
1569 | do { | 1473 | while(PagePrivate(page)) { |
1570 | if (clear_page_dirty_for_io(page)) { | 1474 | if (clear_page_dirty_for_io(page)) { |
1571 | ret = nfs_writepage_locked(page, &wbc); | 1475 | ret = nfs_writepage_locked(page, &wbc); |
1572 | if (ret < 0) | 1476 | if (ret < 0) |
1573 | goto out_error; | 1477 | goto out_error; |
1574 | } else if (!PagePrivate(page)) | 1478 | } |
1479 | req = nfs_find_and_lock_request(page); | ||
1480 | if (!req) | ||
1575 | break; | 1481 | break; |
1576 | ret = nfs_sync_mapping_wait(page->mapping, &wbc, how); | 1482 | if (IS_ERR(req)) { |
1577 | if (ret < 0) | 1483 | ret = PTR_ERR(req); |
1578 | goto out_error; | 1484 | goto out_error; |
1579 | } while (PagePrivate(page)); | 1485 | } |
1486 | need_commit = test_bit(PG_CLEAN, &req->wb_flags); | ||
1487 | nfs_clear_page_tag_locked(req); | ||
1488 | if (need_commit) { | ||
1489 | ret = nfs_commit_inode(inode, FLUSH_SYNC); | ||
1490 | if (ret < 0) | ||
1491 | goto out_error; | ||
1492 | } | ||
1493 | } | ||
1580 | return 0; | 1494 | return 0; |
1581 | out_error: | 1495 | out_error: |
1582 | __mark_inode_dirty(inode, I_DIRTY_PAGES); | ||
1583 | return ret; | 1496 | return ret; |
1584 | } | 1497 | } |
1585 | 1498 | ||
1586 | /* | ||
1587 | * Write back all requests on one page - we do this before reading it. | ||
1588 | */ | ||
1589 | int nfs_wb_page(struct inode *inode, struct page* page) | ||
1590 | { | ||
1591 | return nfs_wb_page_priority(inode, page, FLUSH_STABLE); | ||
1592 | } | ||
1593 | |||
1594 | #ifdef CONFIG_MIGRATION | 1499 | #ifdef CONFIG_MIGRATION |
1595 | int nfs_migrate_page(struct address_space *mapping, struct page *newpage, | 1500 | int nfs_migrate_page(struct address_space *mapping, struct page *newpage, |
1596 | struct page *page) | 1501 | struct page *page) |
diff --git a/fs/nfsctl.c b/fs/nfsctl.c index d3854d94b7cf..bf9cbd242ddd 100644 --- a/fs/nfsctl.c +++ b/fs/nfsctl.c | |||
@@ -36,10 +36,9 @@ static struct file *do_open(char *name, int flags) | |||
36 | return ERR_PTR(error); | 36 | return ERR_PTR(error); |
37 | 37 | ||
38 | if (flags == O_RDWR) | 38 | if (flags == O_RDWR) |
39 | error = may_open(&nd.path, MAY_READ|MAY_WRITE, | 39 | error = may_open(&nd.path, MAY_READ|MAY_WRITE, flags); |
40 | FMODE_READ|FMODE_WRITE); | ||
41 | else | 40 | else |
42 | error = may_open(&nd.path, MAY_WRITE, FMODE_WRITE); | 41 | error = may_open(&nd.path, MAY_WRITE, flags); |
43 | 42 | ||
44 | if (!error) | 43 | if (!error) |
45 | return dentry_open(nd.path.dentry, nd.path.mnt, flags, | 44 | return dentry_open(nd.path.dentry, nd.path.mnt, flags, |
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 6edfe23694e6..efef7f2442d5 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c | |||
@@ -1998,7 +1998,9 @@ nfs4_file_downgrade(struct file *filp, unsigned int share_access) | |||
1998 | { | 1998 | { |
1999 | if (share_access & NFS4_SHARE_ACCESS_WRITE) { | 1999 | if (share_access & NFS4_SHARE_ACCESS_WRITE) { |
2000 | drop_file_write_access(filp); | 2000 | drop_file_write_access(filp); |
2001 | spin_lock(&filp->f_lock); | ||
2001 | filp->f_mode = (filp->f_mode | FMODE_READ) & ~FMODE_WRITE; | 2002 | filp->f_mode = (filp->f_mode | FMODE_READ) & ~FMODE_WRITE; |
2003 | spin_unlock(&filp->f_lock); | ||
2002 | } | 2004 | } |
2003 | } | 2005 | } |
2004 | 2006 | ||
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c index f61bd736152b..fb27b1db007b 100644 --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c | |||
@@ -2121,9 +2121,15 @@ out_acl: | |||
2121 | * and this is the root of a cross-mounted filesystem. | 2121 | * and this is the root of a cross-mounted filesystem. |
2122 | */ | 2122 | */ |
2123 | if (ignore_crossmnt == 0 && | 2123 | if (ignore_crossmnt == 0 && |
2124 | exp->ex_path.mnt->mnt_root->d_inode == dentry->d_inode) { | 2124 | dentry == exp->ex_path.mnt->mnt_root) { |
2125 | err = vfs_getattr(exp->ex_path.mnt->mnt_parent, | 2125 | struct path path = exp->ex_path; |
2126 | exp->ex_path.mnt->mnt_mountpoint, &stat); | 2126 | path_get(&path); |
2127 | while (follow_up(&path)) { | ||
2128 | if (path.dentry != path.mnt->mnt_root) | ||
2129 | break; | ||
2130 | } | ||
2131 | err = vfs_getattr(path.mnt, path.dentry, &stat); | ||
2132 | path_put(&path); | ||
2127 | if (err) | 2133 | if (err) |
2128 | goto out_nfserr; | 2134 | goto out_nfserr; |
2129 | } | 2135 | } |
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 43bd776c4882..a11b0e8678ee 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c | |||
@@ -20,7 +20,6 @@ | |||
20 | #include <linux/fcntl.h> | 20 | #include <linux/fcntl.h> |
21 | #include <linux/namei.h> | 21 | #include <linux/namei.h> |
22 | #include <linux/delay.h> | 22 | #include <linux/delay.h> |
23 | #include <linux/quotaops.h> | ||
24 | #include <linux/fsnotify.h> | 23 | #include <linux/fsnotify.h> |
25 | #include <linux/posix_acl_xattr.h> | 24 | #include <linux/posix_acl_xattr.h> |
26 | #include <linux/xattr.h> | 25 | #include <linux/xattr.h> |
@@ -389,7 +388,7 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap, | |||
389 | * If we are changing the size of the file, then | 388 | * If we are changing the size of the file, then |
390 | * we need to break all leases. | 389 | * we need to break all leases. |
391 | */ | 390 | */ |
392 | host_err = break_lease(inode, FMODE_WRITE | O_NONBLOCK); | 391 | host_err = break_lease(inode, O_WRONLY | O_NONBLOCK); |
393 | if (host_err == -EWOULDBLOCK) | 392 | if (host_err == -EWOULDBLOCK) |
394 | host_err = -ETIMEDOUT; | 393 | host_err = -ETIMEDOUT; |
395 | if (host_err) /* ENOMEM or EWOULDBLOCK */ | 394 | if (host_err) /* ENOMEM or EWOULDBLOCK */ |
@@ -405,7 +404,6 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp, struct iattr *iap, | |||
405 | put_write_access(inode); | 404 | put_write_access(inode); |
406 | goto out_nfserr; | 405 | goto out_nfserr; |
407 | } | 406 | } |
408 | vfs_dq_init(inode); | ||
409 | } | 407 | } |
410 | 408 | ||
411 | /* sanitize the mode change */ | 409 | /* sanitize the mode change */ |
@@ -762,7 +760,7 @@ nfsd_open(struct svc_rqst *rqstp, struct svc_fh *fhp, int type, | |||
762 | * Check to see if there are any leases on this file. | 760 | * Check to see if there are any leases on this file. |
763 | * This may block while leases are broken. | 761 | * This may block while leases are broken. |
764 | */ | 762 | */ |
765 | host_err = break_lease(inode, O_NONBLOCK | ((access & NFSD_MAY_WRITE) ? FMODE_WRITE : 0)); | 763 | host_err = break_lease(inode, O_NONBLOCK | ((access & NFSD_MAY_WRITE) ? O_WRONLY : 0)); |
766 | if (host_err == -EWOULDBLOCK) | 764 | if (host_err == -EWOULDBLOCK) |
767 | host_err = -ETIMEDOUT; | 765 | host_err = -ETIMEDOUT; |
768 | if (host_err) /* NOMEM or WOULDBLOCK */ | 766 | if (host_err) /* NOMEM or WOULDBLOCK */ |
@@ -773,8 +771,6 @@ nfsd_open(struct svc_rqst *rqstp, struct svc_fh *fhp, int type, | |||
773 | flags = O_RDWR|O_LARGEFILE; | 771 | flags = O_RDWR|O_LARGEFILE; |
774 | else | 772 | else |
775 | flags = O_WRONLY|O_LARGEFILE; | 773 | flags = O_WRONLY|O_LARGEFILE; |
776 | |||
777 | vfs_dq_init(inode); | ||
778 | } | 774 | } |
779 | *filp = dentry_open(dget(dentry), mntget(fhp->fh_export->ex_path.mnt), | 775 | *filp = dentry_open(dget(dentry), mntget(fhp->fh_export->ex_path.mnt), |
780 | flags, current_cred()); | 776 | flags, current_cred()); |
diff --git a/fs/nilfs2/dat.c b/fs/nilfs2/dat.c index 187dd07ba86c..9d1e5de91afb 100644 --- a/fs/nilfs2/dat.c +++ b/fs/nilfs2/dat.c | |||
@@ -388,8 +388,7 @@ int nilfs_dat_translate(struct inode *dat, __u64 vblocknr, sector_t *blocknrp) | |||
388 | ret = -ENOENT; | 388 | ret = -ENOENT; |
389 | goto out; | 389 | goto out; |
390 | } | 390 | } |
391 | if (blocknrp != NULL) | 391 | *blocknrp = blocknr; |
392 | *blocknrp = blocknr; | ||
393 | 392 | ||
394 | out: | 393 | out: |
395 | kunmap_atomic(kaddr, KM_USER0); | 394 | kunmap_atomic(kaddr, KM_USER0); |
diff --git a/fs/nilfs2/dir.c b/fs/nilfs2/dir.c index 76d803e060a9..0092840492ee 100644 --- a/fs/nilfs2/dir.c +++ b/fs/nilfs2/dir.c | |||
@@ -224,7 +224,7 @@ fail: | |||
224 | * len <= NILFS_NAME_LEN and de != NULL are guaranteed by caller. | 224 | * len <= NILFS_NAME_LEN and de != NULL are guaranteed by caller. |
225 | */ | 225 | */ |
226 | static int | 226 | static int |
227 | nilfs_match(int len, const char * const name, struct nilfs_dir_entry *de) | 227 | nilfs_match(int len, const unsigned char *name, struct nilfs_dir_entry *de) |
228 | { | 228 | { |
229 | if (len != de->name_len) | 229 | if (len != de->name_len) |
230 | return 0; | 230 | return 0; |
@@ -349,11 +349,11 @@ done: | |||
349 | * Entry is guaranteed to be valid. | 349 | * Entry is guaranteed to be valid. |
350 | */ | 350 | */ |
351 | struct nilfs_dir_entry * | 351 | struct nilfs_dir_entry * |
352 | nilfs_find_entry(struct inode *dir, struct dentry *dentry, | 352 | nilfs_find_entry(struct inode *dir, const struct qstr *qstr, |
353 | struct page **res_page) | 353 | struct page **res_page) |
354 | { | 354 | { |
355 | const char *name = dentry->d_name.name; | 355 | const unsigned char *name = qstr->name; |
356 | int namelen = dentry->d_name.len; | 356 | int namelen = qstr->len; |
357 | unsigned reclen = NILFS_DIR_REC_LEN(namelen); | 357 | unsigned reclen = NILFS_DIR_REC_LEN(namelen); |
358 | unsigned long start, n; | 358 | unsigned long start, n; |
359 | unsigned long npages = dir_pages(dir); | 359 | unsigned long npages = dir_pages(dir); |
@@ -424,13 +424,13 @@ struct nilfs_dir_entry *nilfs_dotdot(struct inode *dir, struct page **p) | |||
424 | return de; | 424 | return de; |
425 | } | 425 | } |
426 | 426 | ||
427 | ino_t nilfs_inode_by_name(struct inode *dir, struct dentry *dentry) | 427 | ino_t nilfs_inode_by_name(struct inode *dir, const struct qstr *qstr) |
428 | { | 428 | { |
429 | ino_t res = 0; | 429 | ino_t res = 0; |
430 | struct nilfs_dir_entry *de; | 430 | struct nilfs_dir_entry *de; |
431 | struct page *page; | 431 | struct page *page; |
432 | 432 | ||
433 | de = nilfs_find_entry(dir, dentry, &page); | 433 | de = nilfs_find_entry(dir, qstr, &page); |
434 | if (de) { | 434 | if (de) { |
435 | res = le64_to_cpu(de->inode); | 435 | res = le64_to_cpu(de->inode); |
436 | kunmap(page); | 436 | kunmap(page); |
@@ -465,7 +465,7 @@ void nilfs_set_link(struct inode *dir, struct nilfs_dir_entry *de, | |||
465 | int nilfs_add_link(struct dentry *dentry, struct inode *inode) | 465 | int nilfs_add_link(struct dentry *dentry, struct inode *inode) |
466 | { | 466 | { |
467 | struct inode *dir = dentry->d_parent->d_inode; | 467 | struct inode *dir = dentry->d_parent->d_inode; |
468 | const char *name = dentry->d_name.name; | 468 | const unsigned char *name = dentry->d_name.name; |
469 | int namelen = dentry->d_name.len; | 469 | int namelen = dentry->d_name.len; |
470 | unsigned chunk_size = nilfs_chunk_size(dir); | 470 | unsigned chunk_size = nilfs_chunk_size(dir); |
471 | unsigned reclen = NILFS_DIR_REC_LEN(namelen); | 471 | unsigned reclen = NILFS_DIR_REC_LEN(namelen); |
diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c index d6b2b83de363..313d0a21da48 100644 --- a/fs/nilfs2/ioctl.c +++ b/fs/nilfs2/ioctl.c | |||
@@ -26,6 +26,7 @@ | |||
26 | #include <linux/capability.h> /* capable() */ | 26 | #include <linux/capability.h> /* capable() */ |
27 | #include <linux/uaccess.h> /* copy_from_user(), copy_to_user() */ | 27 | #include <linux/uaccess.h> /* copy_from_user(), copy_to_user() */ |
28 | #include <linux/vmalloc.h> | 28 | #include <linux/vmalloc.h> |
29 | #include <linux/mount.h> /* mnt_want_write(), mnt_drop_write() */ | ||
29 | #include <linux/nilfs2_fs.h> | 30 | #include <linux/nilfs2_fs.h> |
30 | #include "nilfs.h" | 31 | #include "nilfs.h" |
31 | #include "segment.h" | 32 | #include "segment.h" |
@@ -107,20 +108,28 @@ static int nilfs_ioctl_change_cpmode(struct inode *inode, struct file *filp, | |||
107 | 108 | ||
108 | if (!capable(CAP_SYS_ADMIN)) | 109 | if (!capable(CAP_SYS_ADMIN)) |
109 | return -EPERM; | 110 | return -EPERM; |
111 | |||
112 | ret = mnt_want_write(filp->f_path.mnt); | ||
113 | if (ret) | ||
114 | return ret; | ||
115 | |||
116 | ret = -EFAULT; | ||
110 | if (copy_from_user(&cpmode, argp, sizeof(cpmode))) | 117 | if (copy_from_user(&cpmode, argp, sizeof(cpmode))) |
111 | return -EFAULT; | 118 | goto out; |
112 | 119 | ||
113 | mutex_lock(&nilfs->ns_mount_mutex); | 120 | mutex_lock(&nilfs->ns_mount_mutex); |
121 | |||
114 | nilfs_transaction_begin(inode->i_sb, &ti, 0); | 122 | nilfs_transaction_begin(inode->i_sb, &ti, 0); |
115 | ret = nilfs_cpfile_change_cpmode( | 123 | ret = nilfs_cpfile_change_cpmode( |
116 | cpfile, cpmode.cm_cno, cpmode.cm_mode); | 124 | cpfile, cpmode.cm_cno, cpmode.cm_mode); |
117 | if (unlikely(ret < 0)) { | 125 | if (unlikely(ret < 0)) |
118 | nilfs_transaction_abort(inode->i_sb); | 126 | nilfs_transaction_abort(inode->i_sb); |
119 | mutex_unlock(&nilfs->ns_mount_mutex); | 127 | else |
120 | return ret; | 128 | nilfs_transaction_commit(inode->i_sb); /* never fails */ |
121 | } | 129 | |
122 | nilfs_transaction_commit(inode->i_sb); /* never fails */ | ||
123 | mutex_unlock(&nilfs->ns_mount_mutex); | 130 | mutex_unlock(&nilfs->ns_mount_mutex); |
131 | out: | ||
132 | mnt_drop_write(filp->f_path.mnt); | ||
124 | return ret; | 133 | return ret; |
125 | } | 134 | } |
126 | 135 | ||
@@ -135,16 +144,23 @@ nilfs_ioctl_delete_checkpoint(struct inode *inode, struct file *filp, | |||
135 | 144 | ||
136 | if (!capable(CAP_SYS_ADMIN)) | 145 | if (!capable(CAP_SYS_ADMIN)) |
137 | return -EPERM; | 146 | return -EPERM; |
147 | |||
148 | ret = mnt_want_write(filp->f_path.mnt); | ||
149 | if (ret) | ||
150 | return ret; | ||
151 | |||
152 | ret = -EFAULT; | ||
138 | if (copy_from_user(&cno, argp, sizeof(cno))) | 153 | if (copy_from_user(&cno, argp, sizeof(cno))) |
139 | return -EFAULT; | 154 | goto out; |
140 | 155 | ||
141 | nilfs_transaction_begin(inode->i_sb, &ti, 0); | 156 | nilfs_transaction_begin(inode->i_sb, &ti, 0); |
142 | ret = nilfs_cpfile_delete_checkpoint(cpfile, cno); | 157 | ret = nilfs_cpfile_delete_checkpoint(cpfile, cno); |
143 | if (unlikely(ret < 0)) { | 158 | if (unlikely(ret < 0)) |
144 | nilfs_transaction_abort(inode->i_sb); | 159 | nilfs_transaction_abort(inode->i_sb); |
145 | return ret; | 160 | else |
146 | } | 161 | nilfs_transaction_commit(inode->i_sb); /* never fails */ |
147 | nilfs_transaction_commit(inode->i_sb); /* never fails */ | 162 | out: |
163 | mnt_drop_write(filp->f_path.mnt); | ||
148 | return ret; | 164 | return ret; |
149 | } | 165 | } |
150 | 166 | ||
@@ -496,12 +512,19 @@ static int nilfs_ioctl_clean_segments(struct inode *inode, struct file *filp, | |||
496 | if (!capable(CAP_SYS_ADMIN)) | 512 | if (!capable(CAP_SYS_ADMIN)) |
497 | return -EPERM; | 513 | return -EPERM; |
498 | 514 | ||
515 | ret = mnt_want_write(filp->f_path.mnt); | ||
516 | if (ret) | ||
517 | return ret; | ||
518 | |||
519 | ret = -EFAULT; | ||
499 | if (copy_from_user(argv, argp, sizeof(argv))) | 520 | if (copy_from_user(argv, argp, sizeof(argv))) |
500 | return -EFAULT; | 521 | goto out; |
501 | 522 | ||
523 | ret = -EINVAL; | ||
502 | nsegs = argv[4].v_nmembs; | 524 | nsegs = argv[4].v_nmembs; |
503 | if (argv[4].v_size != argsz[4]) | 525 | if (argv[4].v_size != argsz[4]) |
504 | return -EINVAL; | 526 | goto out; |
527 | |||
505 | /* | 528 | /* |
506 | * argv[4] points to segment numbers this ioctl cleans. We | 529 | * argv[4] points to segment numbers this ioctl cleans. We |
507 | * use kmalloc() for its buffer because memory used for the | 530 | * use kmalloc() for its buffer because memory used for the |
@@ -509,9 +532,10 @@ static int nilfs_ioctl_clean_segments(struct inode *inode, struct file *filp, | |||
509 | */ | 532 | */ |
510 | kbufs[4] = memdup_user((void __user *)(unsigned long)argv[4].v_base, | 533 | kbufs[4] = memdup_user((void __user *)(unsigned long)argv[4].v_base, |
511 | nsegs * sizeof(__u64)); | 534 | nsegs * sizeof(__u64)); |
512 | if (IS_ERR(kbufs[4])) | 535 | if (IS_ERR(kbufs[4])) { |
513 | return PTR_ERR(kbufs[4]); | 536 | ret = PTR_ERR(kbufs[4]); |
514 | 537 | goto out; | |
538 | } | ||
515 | nilfs = NILFS_SB(inode->i_sb)->s_nilfs; | 539 | nilfs = NILFS_SB(inode->i_sb)->s_nilfs; |
516 | 540 | ||
517 | for (n = 0; n < 4; n++) { | 541 | for (n = 0; n < 4; n++) { |
@@ -563,10 +587,12 @@ static int nilfs_ioctl_clean_segments(struct inode *inode, struct file *filp, | |||
563 | nilfs_remove_all_gcinode(nilfs); | 587 | nilfs_remove_all_gcinode(nilfs); |
564 | clear_nilfs_gc_running(nilfs); | 588 | clear_nilfs_gc_running(nilfs); |
565 | 589 | ||
566 | out_free: | 590 | out_free: |
567 | while (--n >= 0) | 591 | while (--n >= 0) |
568 | vfree(kbufs[n]); | 592 | vfree(kbufs[n]); |
569 | kfree(kbufs[4]); | 593 | kfree(kbufs[4]); |
594 | out: | ||
595 | mnt_drop_write(filp->f_path.mnt); | ||
570 | return ret; | 596 | return ret; |
571 | } | 597 | } |
572 | 598 | ||
@@ -575,13 +601,17 @@ static int nilfs_ioctl_sync(struct inode *inode, struct file *filp, | |||
575 | { | 601 | { |
576 | __u64 cno; | 602 | __u64 cno; |
577 | int ret; | 603 | int ret; |
604 | struct the_nilfs *nilfs; | ||
578 | 605 | ||
579 | ret = nilfs_construct_segment(inode->i_sb); | 606 | ret = nilfs_construct_segment(inode->i_sb); |
580 | if (ret < 0) | 607 | if (ret < 0) |
581 | return ret; | 608 | return ret; |
582 | 609 | ||
583 | if (argp != NULL) { | 610 | if (argp != NULL) { |
584 | cno = NILFS_SB(inode->i_sb)->s_nilfs->ns_cno - 1; | 611 | nilfs = NILFS_SB(inode->i_sb)->s_nilfs; |
612 | down_read(&nilfs->ns_segctor_sem); | ||
613 | cno = nilfs->ns_cno - 1; | ||
614 | up_read(&nilfs->ns_segctor_sem); | ||
585 | if (copy_to_user(argp, &cno, sizeof(cno))) | 615 | if (copy_to_user(argp, &cno, sizeof(cno))) |
586 | return -EFAULT; | 616 | return -EFAULT; |
587 | } | 617 | } |
diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c index 07ba838ef089..ad6ed2cf19b4 100644 --- a/fs/nilfs2/namei.c +++ b/fs/nilfs2/namei.c | |||
@@ -67,7 +67,7 @@ nilfs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | |||
67 | if (dentry->d_name.len > NILFS_NAME_LEN) | 67 | if (dentry->d_name.len > NILFS_NAME_LEN) |
68 | return ERR_PTR(-ENAMETOOLONG); | 68 | return ERR_PTR(-ENAMETOOLONG); |
69 | 69 | ||
70 | ino = nilfs_inode_by_name(dir, dentry); | 70 | ino = nilfs_inode_by_name(dir, &dentry->d_name); |
71 | inode = NULL; | 71 | inode = NULL; |
72 | if (ino) { | 72 | if (ino) { |
73 | inode = nilfs_iget(dir->i_sb, ino); | 73 | inode = nilfs_iget(dir->i_sb, ino); |
@@ -81,10 +81,7 @@ struct dentry *nilfs_get_parent(struct dentry *child) | |||
81 | { | 81 | { |
82 | unsigned long ino; | 82 | unsigned long ino; |
83 | struct inode *inode; | 83 | struct inode *inode; |
84 | struct dentry dotdot; | 84 | struct qstr dotdot = {.name = "..", .len = 2}; |
85 | |||
86 | dotdot.d_name.name = ".."; | ||
87 | dotdot.d_name.len = 2; | ||
88 | 85 | ||
89 | ino = nilfs_inode_by_name(child->d_inode, &dotdot); | 86 | ino = nilfs_inode_by_name(child->d_inode, &dotdot); |
90 | if (!ino) | 87 | if (!ino) |
@@ -296,7 +293,7 @@ static int nilfs_do_unlink(struct inode *dir, struct dentry *dentry) | |||
296 | int err; | 293 | int err; |
297 | 294 | ||
298 | err = -ENOENT; | 295 | err = -ENOENT; |
299 | de = nilfs_find_entry(dir, dentry, &page); | 296 | de = nilfs_find_entry(dir, &dentry->d_name, &page); |
300 | if (!de) | 297 | if (!de) |
301 | goto out; | 298 | goto out; |
302 | 299 | ||
@@ -389,7 +386,7 @@ static int nilfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
389 | return err; | 386 | return err; |
390 | 387 | ||
391 | err = -ENOENT; | 388 | err = -ENOENT; |
392 | old_de = nilfs_find_entry(old_dir, old_dentry, &old_page); | 389 | old_de = nilfs_find_entry(old_dir, &old_dentry->d_name, &old_page); |
393 | if (!old_de) | 390 | if (!old_de) |
394 | goto out; | 391 | goto out; |
395 | 392 | ||
@@ -409,7 +406,7 @@ static int nilfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
409 | goto out_dir; | 406 | goto out_dir; |
410 | 407 | ||
411 | err = -ENOENT; | 408 | err = -ENOENT; |
412 | new_de = nilfs_find_entry(new_dir, new_dentry, &new_page); | 409 | new_de = nilfs_find_entry(new_dir, &new_dentry->d_name, &new_page); |
413 | if (!new_de) | 410 | if (!new_de) |
414 | goto out_dir; | 411 | goto out_dir; |
415 | inc_nlink(old_inode); | 412 | inc_nlink(old_inode); |
diff --git a/fs/nilfs2/nilfs.h b/fs/nilfs2/nilfs.h index 4da6f67e9a91..8723e5bfd071 100644 --- a/fs/nilfs2/nilfs.h +++ b/fs/nilfs2/nilfs.h | |||
@@ -217,10 +217,10 @@ static inline int nilfs_init_acl(struct inode *inode, struct inode *dir) | |||
217 | 217 | ||
218 | /* dir.c */ | 218 | /* dir.c */ |
219 | extern int nilfs_add_link(struct dentry *, struct inode *); | 219 | extern int nilfs_add_link(struct dentry *, struct inode *); |
220 | extern ino_t nilfs_inode_by_name(struct inode *, struct dentry *); | 220 | extern ino_t nilfs_inode_by_name(struct inode *, const struct qstr *); |
221 | extern int nilfs_make_empty(struct inode *, struct inode *); | 221 | extern int nilfs_make_empty(struct inode *, struct inode *); |
222 | extern struct nilfs_dir_entry * | 222 | extern struct nilfs_dir_entry * |
223 | nilfs_find_entry(struct inode *, struct dentry *, struct page **); | 223 | nilfs_find_entry(struct inode *, const struct qstr *, struct page **); |
224 | extern int nilfs_delete_entry(struct nilfs_dir_entry *, struct page *); | 224 | extern int nilfs_delete_entry(struct nilfs_dir_entry *, struct page *); |
225 | extern int nilfs_empty_dir(struct inode *); | 225 | extern int nilfs_empty_dir(struct inode *); |
226 | extern struct nilfs_dir_entry *nilfs_dotdot(struct inode *, struct page **); | 226 | extern struct nilfs_dir_entry *nilfs_dotdot(struct inode *, struct page **); |
diff --git a/fs/nilfs2/recovery.c b/fs/nilfs2/recovery.c index c9c96c7825dc..017bedc761a0 100644 --- a/fs/nilfs2/recovery.c +++ b/fs/nilfs2/recovery.c | |||
@@ -39,7 +39,6 @@ enum { | |||
39 | NILFS_SEG_FAIL_IO, | 39 | NILFS_SEG_FAIL_IO, |
40 | NILFS_SEG_FAIL_MAGIC, | 40 | NILFS_SEG_FAIL_MAGIC, |
41 | NILFS_SEG_FAIL_SEQ, | 41 | NILFS_SEG_FAIL_SEQ, |
42 | NILFS_SEG_FAIL_CHECKSUM_SEGSUM, | ||
43 | NILFS_SEG_FAIL_CHECKSUM_SUPER_ROOT, | 42 | NILFS_SEG_FAIL_CHECKSUM_SUPER_ROOT, |
44 | NILFS_SEG_FAIL_CHECKSUM_FULL, | 43 | NILFS_SEG_FAIL_CHECKSUM_FULL, |
45 | NILFS_SEG_FAIL_CONSISTENCY, | 44 | NILFS_SEG_FAIL_CONSISTENCY, |
@@ -71,10 +70,6 @@ static int nilfs_warn_segment_error(int err) | |||
71 | printk(KERN_WARNING | 70 | printk(KERN_WARNING |
72 | "NILFS warning: Sequence number mismatch\n"); | 71 | "NILFS warning: Sequence number mismatch\n"); |
73 | break; | 72 | break; |
74 | case NILFS_SEG_FAIL_CHECKSUM_SEGSUM: | ||
75 | printk(KERN_WARNING | ||
76 | "NILFS warning: Checksum error in segment summary\n"); | ||
77 | break; | ||
78 | case NILFS_SEG_FAIL_CHECKSUM_SUPER_ROOT: | 73 | case NILFS_SEG_FAIL_CHECKSUM_SUPER_ROOT: |
79 | printk(KERN_WARNING | 74 | printk(KERN_WARNING |
80 | "NILFS warning: Checksum error in super root\n"); | 75 | "NILFS warning: Checksum error in super root\n"); |
@@ -206,19 +201,15 @@ int nilfs_read_super_root_block(struct super_block *sb, sector_t sr_block, | |||
206 | * @pseg_start: start disk block number of partial segment | 201 | * @pseg_start: start disk block number of partial segment |
207 | * @seg_seq: sequence number requested | 202 | * @seg_seq: sequence number requested |
208 | * @ssi: pointer to nilfs_segsum_info struct to store information | 203 | * @ssi: pointer to nilfs_segsum_info struct to store information |
209 | * @full_check: full check flag | ||
210 | * (0: only checks segment summary CRC, 1: data CRC) | ||
211 | */ | 204 | */ |
212 | static int | 205 | static int |
213 | load_segment_summary(struct nilfs_sb_info *sbi, sector_t pseg_start, | 206 | load_segment_summary(struct nilfs_sb_info *sbi, sector_t pseg_start, |
214 | u64 seg_seq, struct nilfs_segsum_info *ssi, | 207 | u64 seg_seq, struct nilfs_segsum_info *ssi) |
215 | int full_check) | ||
216 | { | 208 | { |
217 | struct buffer_head *bh_sum; | 209 | struct buffer_head *bh_sum; |
218 | struct nilfs_segment_summary *sum; | 210 | struct nilfs_segment_summary *sum; |
219 | unsigned long offset, nblock; | 211 | unsigned long nblock; |
220 | u64 check_bytes; | 212 | u32 crc; |
221 | u32 crc, crc_sum; | ||
222 | int ret = NILFS_SEG_FAIL_IO; | 213 | int ret = NILFS_SEG_FAIL_IO; |
223 | 214 | ||
224 | bh_sum = sb_bread(sbi->s_super, pseg_start); | 215 | bh_sum = sb_bread(sbi->s_super, pseg_start); |
@@ -237,34 +228,24 @@ load_segment_summary(struct nilfs_sb_info *sbi, sector_t pseg_start, | |||
237 | ret = NILFS_SEG_FAIL_SEQ; | 228 | ret = NILFS_SEG_FAIL_SEQ; |
238 | goto failed; | 229 | goto failed; |
239 | } | 230 | } |
240 | if (full_check) { | ||
241 | offset = sizeof(sum->ss_datasum); | ||
242 | check_bytes = | ||
243 | ((u64)ssi->nblocks << sbi->s_super->s_blocksize_bits); | ||
244 | nblock = ssi->nblocks; | ||
245 | crc_sum = le32_to_cpu(sum->ss_datasum); | ||
246 | ret = NILFS_SEG_FAIL_CHECKSUM_FULL; | ||
247 | } else { /* only checks segment summary */ | ||
248 | offset = sizeof(sum->ss_datasum) + sizeof(sum->ss_sumsum); | ||
249 | check_bytes = ssi->sumbytes; | ||
250 | nblock = ssi->nsumblk; | ||
251 | crc_sum = le32_to_cpu(sum->ss_sumsum); | ||
252 | ret = NILFS_SEG_FAIL_CHECKSUM_SEGSUM; | ||
253 | } | ||
254 | 231 | ||
232 | nblock = ssi->nblocks; | ||
255 | if (unlikely(nblock == 0 || | 233 | if (unlikely(nblock == 0 || |
256 | nblock > sbi->s_nilfs->ns_blocks_per_segment)) { | 234 | nblock > sbi->s_nilfs->ns_blocks_per_segment)) { |
257 | /* This limits the number of blocks read in the CRC check */ | 235 | /* This limits the number of blocks read in the CRC check */ |
258 | ret = NILFS_SEG_FAIL_CONSISTENCY; | 236 | ret = NILFS_SEG_FAIL_CONSISTENCY; |
259 | goto failed; | 237 | goto failed; |
260 | } | 238 | } |
261 | if (calc_crc_cont(sbi, bh_sum, &crc, offset, check_bytes, | 239 | if (calc_crc_cont(sbi, bh_sum, &crc, sizeof(sum->ss_datasum), |
240 | ((u64)nblock << sbi->s_super->s_blocksize_bits), | ||
262 | pseg_start, nblock)) { | 241 | pseg_start, nblock)) { |
263 | ret = NILFS_SEG_FAIL_IO; | 242 | ret = NILFS_SEG_FAIL_IO; |
264 | goto failed; | 243 | goto failed; |
265 | } | 244 | } |
266 | if (crc == crc_sum) | 245 | if (crc == le32_to_cpu(sum->ss_datasum)) |
267 | ret = 0; | 246 | ret = 0; |
247 | else | ||
248 | ret = NILFS_SEG_FAIL_CHECKSUM_FULL; | ||
268 | failed: | 249 | failed: |
269 | brelse(bh_sum); | 250 | brelse(bh_sum); |
270 | out: | 251 | out: |
@@ -598,7 +579,7 @@ static int nilfs_do_roll_forward(struct the_nilfs *nilfs, | |||
598 | 579 | ||
599 | while (segnum != ri->ri_segnum || pseg_start <= ri->ri_pseg_start) { | 580 | while (segnum != ri->ri_segnum || pseg_start <= ri->ri_pseg_start) { |
600 | 581 | ||
601 | ret = load_segment_summary(sbi, pseg_start, seg_seq, &ssi, 1); | 582 | ret = load_segment_summary(sbi, pseg_start, seg_seq, &ssi); |
602 | if (ret) { | 583 | if (ret) { |
603 | if (ret == NILFS_SEG_FAIL_IO) { | 584 | if (ret == NILFS_SEG_FAIL_IO) { |
604 | err = -EIO; | 585 | err = -EIO; |
@@ -821,7 +802,7 @@ int nilfs_search_super_root(struct the_nilfs *nilfs, struct nilfs_sb_info *sbi, | |||
821 | 802 | ||
822 | for (;;) { | 803 | for (;;) { |
823 | /* Load segment summary */ | 804 | /* Load segment summary */ |
824 | ret = load_segment_summary(sbi, pseg_start, seg_seq, &ssi, 1); | 805 | ret = load_segment_summary(sbi, pseg_start, seg_seq, &ssi); |
825 | if (ret) { | 806 | if (ret) { |
826 | if (ret == NILFS_SEG_FAIL_IO) | 807 | if (ret == NILFS_SEG_FAIL_IO) |
827 | goto failed; | 808 | goto failed; |
diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c index 645c78656aa0..ab56fe44e377 100644 --- a/fs/nilfs2/segbuf.c +++ b/fs/nilfs2/segbuf.c | |||
@@ -40,6 +40,11 @@ struct nilfs_write_info { | |||
40 | }; | 40 | }; |
41 | 41 | ||
42 | 42 | ||
43 | static int nilfs_segbuf_write(struct nilfs_segment_buffer *segbuf, | ||
44 | struct the_nilfs *nilfs); | ||
45 | static int nilfs_segbuf_wait(struct nilfs_segment_buffer *segbuf); | ||
46 | |||
47 | |||
43 | static struct kmem_cache *nilfs_segbuf_cachep; | 48 | static struct kmem_cache *nilfs_segbuf_cachep; |
44 | 49 | ||
45 | static void nilfs_segbuf_init_once(void *obj) | 50 | static void nilfs_segbuf_init_once(void *obj) |
@@ -302,6 +307,19 @@ void nilfs_truncate_logs(struct list_head *logs, | |||
302 | } | 307 | } |
303 | } | 308 | } |
304 | 309 | ||
310 | int nilfs_write_logs(struct list_head *logs, struct the_nilfs *nilfs) | ||
311 | { | ||
312 | struct nilfs_segment_buffer *segbuf; | ||
313 | int ret = 0; | ||
314 | |||
315 | list_for_each_entry(segbuf, logs, sb_list) { | ||
316 | ret = nilfs_segbuf_write(segbuf, nilfs); | ||
317 | if (ret) | ||
318 | break; | ||
319 | } | ||
320 | return ret; | ||
321 | } | ||
322 | |||
305 | int nilfs_wait_on_logs(struct list_head *logs) | 323 | int nilfs_wait_on_logs(struct list_head *logs) |
306 | { | 324 | { |
307 | struct nilfs_segment_buffer *segbuf; | 325 | struct nilfs_segment_buffer *segbuf; |
diff --git a/fs/nilfs2/segbuf.h b/fs/nilfs2/segbuf.h index 6af1630fb401..94dfd3517bc0 100644 --- a/fs/nilfs2/segbuf.h +++ b/fs/nilfs2/segbuf.h | |||
@@ -166,13 +166,10 @@ nilfs_segbuf_add_file_buffer(struct nilfs_segment_buffer *segbuf, | |||
166 | segbuf->sb_sum.nfileblk++; | 166 | segbuf->sb_sum.nfileblk++; |
167 | } | 167 | } |
168 | 168 | ||
169 | int nilfs_segbuf_write(struct nilfs_segment_buffer *segbuf, | ||
170 | struct the_nilfs *nilfs); | ||
171 | int nilfs_segbuf_wait(struct nilfs_segment_buffer *segbuf); | ||
172 | |||
173 | void nilfs_clear_logs(struct list_head *logs); | 169 | void nilfs_clear_logs(struct list_head *logs); |
174 | void nilfs_truncate_logs(struct list_head *logs, | 170 | void nilfs_truncate_logs(struct list_head *logs, |
175 | struct nilfs_segment_buffer *last); | 171 | struct nilfs_segment_buffer *last); |
172 | int nilfs_write_logs(struct list_head *logs, struct the_nilfs *nilfs); | ||
176 | int nilfs_wait_on_logs(struct list_head *logs); | 173 | int nilfs_wait_on_logs(struct list_head *logs); |
177 | 174 | ||
178 | static inline void nilfs_destroy_logs(struct list_head *logs) | 175 | static inline void nilfs_destroy_logs(struct list_head *logs) |
diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index 105b508b47a8..ada2f1b947a3 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c | |||
@@ -1764,14 +1764,9 @@ static int nilfs_segctor_prepare_write(struct nilfs_sc_info *sci, | |||
1764 | static int nilfs_segctor_write(struct nilfs_sc_info *sci, | 1764 | static int nilfs_segctor_write(struct nilfs_sc_info *sci, |
1765 | struct the_nilfs *nilfs) | 1765 | struct the_nilfs *nilfs) |
1766 | { | 1766 | { |
1767 | struct nilfs_segment_buffer *segbuf; | 1767 | int ret; |
1768 | int ret = 0; | ||
1769 | 1768 | ||
1770 | list_for_each_entry(segbuf, &sci->sc_segbufs, sb_list) { | 1769 | ret = nilfs_write_logs(&sci->sc_segbufs, nilfs); |
1771 | ret = nilfs_segbuf_write(segbuf, nilfs); | ||
1772 | if (ret) | ||
1773 | break; | ||
1774 | } | ||
1775 | list_splice_tail_init(&sci->sc_segbufs, &sci->sc_write_logs); | 1770 | list_splice_tail_init(&sci->sc_segbufs, &sci->sc_write_logs); |
1776 | return ret; | 1771 | return ret; |
1777 | } | 1772 | } |
@@ -1937,8 +1932,7 @@ static void nilfs_segctor_complete_write(struct nilfs_sc_info *sci) | |||
1937 | { | 1932 | { |
1938 | struct nilfs_segment_buffer *segbuf; | 1933 | struct nilfs_segment_buffer *segbuf; |
1939 | struct page *bd_page = NULL, *fs_page = NULL; | 1934 | struct page *bd_page = NULL, *fs_page = NULL; |
1940 | struct nilfs_sb_info *sbi = sci->sc_sbi; | 1935 | struct the_nilfs *nilfs = sci->sc_sbi->s_nilfs; |
1941 | struct the_nilfs *nilfs = sbi->s_nilfs; | ||
1942 | int update_sr = (sci->sc_super_root != NULL); | 1936 | int update_sr = (sci->sc_super_root != NULL); |
1943 | 1937 | ||
1944 | list_for_each_entry(segbuf, &sci->sc_write_logs, sb_list) { | 1938 | list_for_each_entry(segbuf, &sci->sc_write_logs, sb_list) { |
@@ -2020,7 +2014,7 @@ static void nilfs_segctor_complete_write(struct nilfs_sc_info *sci) | |||
2020 | if (update_sr) { | 2014 | if (update_sr) { |
2021 | nilfs_set_last_segment(nilfs, segbuf->sb_pseg_start, | 2015 | nilfs_set_last_segment(nilfs, segbuf->sb_pseg_start, |
2022 | segbuf->sb_sum.seg_seq, nilfs->ns_cno++); | 2016 | segbuf->sb_sum.seg_seq, nilfs->ns_cno++); |
2023 | sbi->s_super->s_dirt = 1; | 2017 | set_nilfs_sb_dirty(nilfs); |
2024 | 2018 | ||
2025 | clear_bit(NILFS_SC_HAVE_DELTA, &sci->sc_flags); | 2019 | clear_bit(NILFS_SC_HAVE_DELTA, &sci->sc_flags); |
2026 | clear_bit(NILFS_SC_DIRTY, &sci->sc_flags); | 2020 | clear_bit(NILFS_SC_DIRTY, &sci->sc_flags); |
@@ -2425,43 +2419,43 @@ int nilfs_construct_dsync_segment(struct super_block *sb, struct inode *inode, | |||
2425 | return err; | 2419 | return err; |
2426 | } | 2420 | } |
2427 | 2421 | ||
2428 | struct nilfs_segctor_req { | ||
2429 | int mode; | ||
2430 | __u32 seq_accepted; | ||
2431 | int sc_err; /* construction failure */ | ||
2432 | int sb_err; /* super block writeback failure */ | ||
2433 | }; | ||
2434 | |||
2435 | #define FLUSH_FILE_BIT (0x1) /* data file only */ | 2422 | #define FLUSH_FILE_BIT (0x1) /* data file only */ |
2436 | #define FLUSH_DAT_BIT (1 << NILFS_DAT_INO) /* DAT only */ | 2423 | #define FLUSH_DAT_BIT (1 << NILFS_DAT_INO) /* DAT only */ |
2437 | 2424 | ||
2438 | static void nilfs_segctor_accept(struct nilfs_sc_info *sci, | 2425 | /** |
2439 | struct nilfs_segctor_req *req) | 2426 | * nilfs_segctor_accept - record accepted sequence count of log-write requests |
2427 | * @sci: segment constructor object | ||
2428 | */ | ||
2429 | static void nilfs_segctor_accept(struct nilfs_sc_info *sci) | ||
2440 | { | 2430 | { |
2441 | req->sc_err = req->sb_err = 0; | ||
2442 | spin_lock(&sci->sc_state_lock); | 2431 | spin_lock(&sci->sc_state_lock); |
2443 | req->seq_accepted = sci->sc_seq_request; | 2432 | sci->sc_seq_accepted = sci->sc_seq_request; |
2444 | spin_unlock(&sci->sc_state_lock); | 2433 | spin_unlock(&sci->sc_state_lock); |
2445 | 2434 | ||
2446 | if (sci->sc_timer) | 2435 | if (sci->sc_timer) |
2447 | del_timer_sync(sci->sc_timer); | 2436 | del_timer_sync(sci->sc_timer); |
2448 | } | 2437 | } |
2449 | 2438 | ||
2450 | static void nilfs_segctor_notify(struct nilfs_sc_info *sci, | 2439 | /** |
2451 | struct nilfs_segctor_req *req) | 2440 | * nilfs_segctor_notify - notify the result of request to caller threads |
2441 | * @sci: segment constructor object | ||
2442 | * @mode: mode of log forming | ||
2443 | * @err: error code to be notified | ||
2444 | */ | ||
2445 | static void nilfs_segctor_notify(struct nilfs_sc_info *sci, int mode, int err) | ||
2452 | { | 2446 | { |
2453 | /* Clear requests (even when the construction failed) */ | 2447 | /* Clear requests (even when the construction failed) */ |
2454 | spin_lock(&sci->sc_state_lock); | 2448 | spin_lock(&sci->sc_state_lock); |
2455 | 2449 | ||
2456 | if (req->mode == SC_LSEG_SR) { | 2450 | if (mode == SC_LSEG_SR) { |
2457 | sci->sc_state &= ~NILFS_SEGCTOR_COMMIT; | 2451 | sci->sc_state &= ~NILFS_SEGCTOR_COMMIT; |
2458 | sci->sc_seq_done = req->seq_accepted; | 2452 | sci->sc_seq_done = sci->sc_seq_accepted; |
2459 | nilfs_segctor_wakeup(sci, req->sc_err ? : req->sb_err); | 2453 | nilfs_segctor_wakeup(sci, err); |
2460 | sci->sc_flush_request = 0; | 2454 | sci->sc_flush_request = 0; |
2461 | } else { | 2455 | } else { |
2462 | if (req->mode == SC_FLUSH_FILE) | 2456 | if (mode == SC_FLUSH_FILE) |
2463 | sci->sc_flush_request &= ~FLUSH_FILE_BIT; | 2457 | sci->sc_flush_request &= ~FLUSH_FILE_BIT; |
2464 | else if (req->mode == SC_FLUSH_DAT) | 2458 | else if (mode == SC_FLUSH_DAT) |
2465 | sci->sc_flush_request &= ~FLUSH_DAT_BIT; | 2459 | sci->sc_flush_request &= ~FLUSH_DAT_BIT; |
2466 | 2460 | ||
2467 | /* re-enable timer if checkpoint creation was not done */ | 2461 | /* re-enable timer if checkpoint creation was not done */ |
@@ -2472,30 +2466,37 @@ static void nilfs_segctor_notify(struct nilfs_sc_info *sci, | |||
2472 | spin_unlock(&sci->sc_state_lock); | 2466 | spin_unlock(&sci->sc_state_lock); |
2473 | } | 2467 | } |
2474 | 2468 | ||
2475 | static int nilfs_segctor_construct(struct nilfs_sc_info *sci, | 2469 | /** |
2476 | struct nilfs_segctor_req *req) | 2470 | * nilfs_segctor_construct - form logs and write them to disk |
2471 | * @sci: segment constructor object | ||
2472 | * @mode: mode of log forming | ||
2473 | */ | ||
2474 | static int nilfs_segctor_construct(struct nilfs_sc_info *sci, int mode) | ||
2477 | { | 2475 | { |
2478 | struct nilfs_sb_info *sbi = sci->sc_sbi; | 2476 | struct nilfs_sb_info *sbi = sci->sc_sbi; |
2479 | struct the_nilfs *nilfs = sbi->s_nilfs; | 2477 | struct the_nilfs *nilfs = sbi->s_nilfs; |
2480 | int err = 0; | 2478 | int err = 0; |
2481 | 2479 | ||
2480 | nilfs_segctor_accept(sci); | ||
2481 | |||
2482 | if (nilfs_discontinued(nilfs)) | 2482 | if (nilfs_discontinued(nilfs)) |
2483 | req->mode = SC_LSEG_SR; | 2483 | mode = SC_LSEG_SR; |
2484 | if (!nilfs_segctor_confirm(sci)) { | 2484 | if (!nilfs_segctor_confirm(sci)) |
2485 | err = nilfs_segctor_do_construct(sci, req->mode); | 2485 | err = nilfs_segctor_do_construct(sci, mode); |
2486 | req->sc_err = err; | 2486 | |
2487 | } | ||
2488 | if (likely(!err)) { | 2487 | if (likely(!err)) { |
2489 | if (req->mode != SC_FLUSH_DAT) | 2488 | if (mode != SC_FLUSH_DAT) |
2490 | atomic_set(&nilfs->ns_ndirtyblks, 0); | 2489 | atomic_set(&nilfs->ns_ndirtyblks, 0); |
2491 | if (test_bit(NILFS_SC_SUPER_ROOT, &sci->sc_flags) && | 2490 | if (test_bit(NILFS_SC_SUPER_ROOT, &sci->sc_flags) && |
2492 | nilfs_discontinued(nilfs)) { | 2491 | nilfs_discontinued(nilfs)) { |
2493 | down_write(&nilfs->ns_sem); | 2492 | down_write(&nilfs->ns_sem); |
2494 | req->sb_err = nilfs_commit_super(sbi, | 2493 | err = nilfs_commit_super( |
2495 | nilfs_altsb_need_update(nilfs)); | 2494 | sbi, nilfs_altsb_need_update(nilfs)); |
2496 | up_write(&nilfs->ns_sem); | 2495 | up_write(&nilfs->ns_sem); |
2497 | } | 2496 | } |
2498 | } | 2497 | } |
2498 | |||
2499 | nilfs_segctor_notify(sci, mode, err); | ||
2499 | return err; | 2500 | return err; |
2500 | } | 2501 | } |
2501 | 2502 | ||
@@ -2526,7 +2527,6 @@ int nilfs_clean_segments(struct super_block *sb, struct nilfs_argv *argv, | |||
2526 | struct nilfs_sc_info *sci = NILFS_SC(sbi); | 2527 | struct nilfs_sc_info *sci = NILFS_SC(sbi); |
2527 | struct the_nilfs *nilfs = sbi->s_nilfs; | 2528 | struct the_nilfs *nilfs = sbi->s_nilfs; |
2528 | struct nilfs_transaction_info ti; | 2529 | struct nilfs_transaction_info ti; |
2529 | struct nilfs_segctor_req req = { .mode = SC_LSEG_SR }; | ||
2530 | int err; | 2530 | int err; |
2531 | 2531 | ||
2532 | if (unlikely(!sci)) | 2532 | if (unlikely(!sci)) |
@@ -2547,10 +2547,8 @@ int nilfs_clean_segments(struct super_block *sb, struct nilfs_argv *argv, | |||
2547 | list_splice_tail_init(&nilfs->ns_gc_inodes, &sci->sc_gc_inodes); | 2547 | list_splice_tail_init(&nilfs->ns_gc_inodes, &sci->sc_gc_inodes); |
2548 | 2548 | ||
2549 | for (;;) { | 2549 | for (;;) { |
2550 | nilfs_segctor_accept(sci, &req); | 2550 | err = nilfs_segctor_construct(sci, SC_LSEG_SR); |
2551 | err = nilfs_segctor_construct(sci, &req); | ||
2552 | nilfs_remove_written_gcinodes(nilfs, &sci->sc_gc_inodes); | 2551 | nilfs_remove_written_gcinodes(nilfs, &sci->sc_gc_inodes); |
2553 | nilfs_segctor_notify(sci, &req); | ||
2554 | 2552 | ||
2555 | if (likely(!err)) | 2553 | if (likely(!err)) |
2556 | break; | 2554 | break; |
@@ -2560,6 +2558,16 @@ int nilfs_clean_segments(struct super_block *sb, struct nilfs_argv *argv, | |||
2560 | set_current_state(TASK_INTERRUPTIBLE); | 2558 | set_current_state(TASK_INTERRUPTIBLE); |
2561 | schedule_timeout(sci->sc_interval); | 2559 | schedule_timeout(sci->sc_interval); |
2562 | } | 2560 | } |
2561 | if (nilfs_test_opt(sbi, DISCARD)) { | ||
2562 | int ret = nilfs_discard_segments(nilfs, sci->sc_freesegs, | ||
2563 | sci->sc_nfreesegs); | ||
2564 | if (ret) { | ||
2565 | printk(KERN_WARNING | ||
2566 | "NILFS warning: error %d on discard request, " | ||
2567 | "turning discards off for the device\n", ret); | ||
2568 | nilfs_clear_opt(sbi, DISCARD); | ||
2569 | } | ||
2570 | } | ||
2563 | 2571 | ||
2564 | out_unlock: | 2572 | out_unlock: |
2565 | sci->sc_freesegs = NULL; | 2573 | sci->sc_freesegs = NULL; |
@@ -2573,13 +2581,9 @@ static void nilfs_segctor_thread_construct(struct nilfs_sc_info *sci, int mode) | |||
2573 | { | 2581 | { |
2574 | struct nilfs_sb_info *sbi = sci->sc_sbi; | 2582 | struct nilfs_sb_info *sbi = sci->sc_sbi; |
2575 | struct nilfs_transaction_info ti; | 2583 | struct nilfs_transaction_info ti; |
2576 | struct nilfs_segctor_req req = { .mode = mode }; | ||
2577 | 2584 | ||
2578 | nilfs_transaction_lock(sbi, &ti, 0); | 2585 | nilfs_transaction_lock(sbi, &ti, 0); |
2579 | 2586 | nilfs_segctor_construct(sci, mode); | |
2580 | nilfs_segctor_accept(sci, &req); | ||
2581 | nilfs_segctor_construct(sci, &req); | ||
2582 | nilfs_segctor_notify(sci, &req); | ||
2583 | 2587 | ||
2584 | /* | 2588 | /* |
2585 | * Unclosed segment should be retried. We do this using sc_timer. | 2589 | * Unclosed segment should be retried. We do this using sc_timer. |
@@ -2635,6 +2639,7 @@ static int nilfs_segctor_flush_mode(struct nilfs_sc_info *sci) | |||
2635 | static int nilfs_segctor_thread(void *arg) | 2639 | static int nilfs_segctor_thread(void *arg) |
2636 | { | 2640 | { |
2637 | struct nilfs_sc_info *sci = (struct nilfs_sc_info *)arg; | 2641 | struct nilfs_sc_info *sci = (struct nilfs_sc_info *)arg; |
2642 | struct the_nilfs *nilfs = sci->sc_sbi->s_nilfs; | ||
2638 | struct timer_list timer; | 2643 | struct timer_list timer; |
2639 | int timeout = 0; | 2644 | int timeout = 0; |
2640 | 2645 | ||
@@ -2680,7 +2685,6 @@ static int nilfs_segctor_thread(void *arg) | |||
2680 | } else { | 2685 | } else { |
2681 | DEFINE_WAIT(wait); | 2686 | DEFINE_WAIT(wait); |
2682 | int should_sleep = 1; | 2687 | int should_sleep = 1; |
2683 | struct the_nilfs *nilfs; | ||
2684 | 2688 | ||
2685 | prepare_to_wait(&sci->sc_wait_daemon, &wait, | 2689 | prepare_to_wait(&sci->sc_wait_daemon, &wait, |
2686 | TASK_INTERRUPTIBLE); | 2690 | TASK_INTERRUPTIBLE); |
@@ -2701,8 +2705,8 @@ static int nilfs_segctor_thread(void *arg) | |||
2701 | finish_wait(&sci->sc_wait_daemon, &wait); | 2705 | finish_wait(&sci->sc_wait_daemon, &wait); |
2702 | timeout = ((sci->sc_state & NILFS_SEGCTOR_COMMIT) && | 2706 | timeout = ((sci->sc_state & NILFS_SEGCTOR_COMMIT) && |
2703 | time_after_eq(jiffies, sci->sc_timer->expires)); | 2707 | time_after_eq(jiffies, sci->sc_timer->expires)); |
2704 | nilfs = sci->sc_sbi->s_nilfs; | 2708 | |
2705 | if (sci->sc_super->s_dirt && nilfs_sb_need_update(nilfs)) | 2709 | if (nilfs_sb_dirty(nilfs) && nilfs_sb_need_update(nilfs)) |
2706 | set_nilfs_discontinued(nilfs); | 2710 | set_nilfs_discontinued(nilfs); |
2707 | } | 2711 | } |
2708 | goto loop; | 2712 | goto loop; |
@@ -2797,12 +2801,9 @@ static void nilfs_segctor_write_out(struct nilfs_sc_info *sci) | |||
2797 | do { | 2801 | do { |
2798 | struct nilfs_sb_info *sbi = sci->sc_sbi; | 2802 | struct nilfs_sb_info *sbi = sci->sc_sbi; |
2799 | struct nilfs_transaction_info ti; | 2803 | struct nilfs_transaction_info ti; |
2800 | struct nilfs_segctor_req req = { .mode = SC_LSEG_SR }; | ||
2801 | 2804 | ||
2802 | nilfs_transaction_lock(sbi, &ti, 0); | 2805 | nilfs_transaction_lock(sbi, &ti, 0); |
2803 | nilfs_segctor_accept(sci, &req); | 2806 | ret = nilfs_segctor_construct(sci, SC_LSEG_SR); |
2804 | ret = nilfs_segctor_construct(sci, &req); | ||
2805 | nilfs_segctor_notify(sci, &req); | ||
2806 | nilfs_transaction_unlock(sbi); | 2807 | nilfs_transaction_unlock(sbi); |
2807 | 2808 | ||
2808 | } while (ret && retrycount-- > 0); | 2809 | } while (ret && retrycount-- > 0); |
@@ -2865,8 +2866,15 @@ int nilfs_attach_segment_constructor(struct nilfs_sb_info *sbi) | |||
2865 | struct the_nilfs *nilfs = sbi->s_nilfs; | 2866 | struct the_nilfs *nilfs = sbi->s_nilfs; |
2866 | int err; | 2867 | int err; |
2867 | 2868 | ||
2868 | /* Each field of nilfs_segctor is cleared through the initialization | 2869 | if (NILFS_SC(sbi)) { |
2869 | of super-block info */ | 2870 | /* |
2871 | * This happens if the filesystem was remounted | ||
2872 | * read/write after nilfs_error degenerated it into a | ||
2873 | * read-only mount. | ||
2874 | */ | ||
2875 | nilfs_detach_segment_constructor(sbi); | ||
2876 | } | ||
2877 | |||
2870 | sbi->s_sc_info = nilfs_segctor_new(sbi); | 2878 | sbi->s_sc_info = nilfs_segctor_new(sbi); |
2871 | if (!sbi->s_sc_info) | 2879 | if (!sbi->s_sc_info) |
2872 | return -ENOMEM; | 2880 | return -ENOMEM; |
diff --git a/fs/nilfs2/segment.h b/fs/nilfs2/segment.h index 3d3ab2f9864c..3155e0c7f415 100644 --- a/fs/nilfs2/segment.h +++ b/fs/nilfs2/segment.h | |||
@@ -116,6 +116,7 @@ struct nilfs_segsum_pointer { | |||
116 | * @sc_wait_daemon: Daemon wait queue | 116 | * @sc_wait_daemon: Daemon wait queue |
117 | * @sc_wait_task: Start/end wait queue to control segctord task | 117 | * @sc_wait_task: Start/end wait queue to control segctord task |
118 | * @sc_seq_request: Request counter | 118 | * @sc_seq_request: Request counter |
119 | * @sc_seq_accept: Accepted request count | ||
119 | * @sc_seq_done: Completion counter | 120 | * @sc_seq_done: Completion counter |
120 | * @sc_sync: Request of explicit sync operation | 121 | * @sc_sync: Request of explicit sync operation |
121 | * @sc_interval: Timeout value of background construction | 122 | * @sc_interval: Timeout value of background construction |
@@ -169,6 +170,7 @@ struct nilfs_sc_info { | |||
169 | wait_queue_head_t sc_wait_task; | 170 | wait_queue_head_t sc_wait_task; |
170 | 171 | ||
171 | __u32 sc_seq_request; | 172 | __u32 sc_seq_request; |
173 | __u32 sc_seq_accepted; | ||
172 | __u32 sc_seq_done; | 174 | __u32 sc_seq_done; |
173 | 175 | ||
174 | int sc_sync; | 176 | int sc_sync; |
diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index 8173faee31e6..92579cc4c935 100644 --- a/fs/nilfs2/super.c +++ b/fs/nilfs2/super.c | |||
@@ -96,9 +96,6 @@ void nilfs_error(struct super_block *sb, const char *function, | |||
96 | if (!(sb->s_flags & MS_RDONLY)) { | 96 | if (!(sb->s_flags & MS_RDONLY)) { |
97 | struct the_nilfs *nilfs = sbi->s_nilfs; | 97 | struct the_nilfs *nilfs = sbi->s_nilfs; |
98 | 98 | ||
99 | if (!nilfs_test_opt(sbi, ERRORS_CONT)) | ||
100 | nilfs_detach_segment_constructor(sbi); | ||
101 | |||
102 | down_write(&nilfs->ns_sem); | 99 | down_write(&nilfs->ns_sem); |
103 | if (!(nilfs->ns_mount_state & NILFS_ERROR_FS)) { | 100 | if (!(nilfs->ns_mount_state & NILFS_ERROR_FS)) { |
104 | nilfs->ns_mount_state |= NILFS_ERROR_FS; | 101 | nilfs->ns_mount_state |= NILFS_ERROR_FS; |
@@ -301,7 +298,7 @@ int nilfs_commit_super(struct nilfs_sb_info *sbi, int dupsb) | |||
301 | memcpy(sbp[1], sbp[0], nilfs->ns_sbsize); | 298 | memcpy(sbp[1], sbp[0], nilfs->ns_sbsize); |
302 | nilfs->ns_sbwtime[1] = t; | 299 | nilfs->ns_sbwtime[1] = t; |
303 | } | 300 | } |
304 | sbi->s_super->s_dirt = 0; | 301 | clear_nilfs_sb_dirty(nilfs); |
305 | return nilfs_sync_super(sbi, dupsb); | 302 | return nilfs_sync_super(sbi, dupsb); |
306 | } | 303 | } |
307 | 304 | ||
@@ -345,7 +342,7 @@ static int nilfs_sync_fs(struct super_block *sb, int wait) | |||
345 | err = nilfs_construct_segment(sb); | 342 | err = nilfs_construct_segment(sb); |
346 | 343 | ||
347 | down_write(&nilfs->ns_sem); | 344 | down_write(&nilfs->ns_sem); |
348 | if (sb->s_dirt) | 345 | if (nilfs_sb_dirty(nilfs)) |
349 | nilfs_commit_super(sbi, 1); | 346 | nilfs_commit_super(sbi, 1); |
350 | up_write(&nilfs->ns_sem); | 347 | up_write(&nilfs->ns_sem); |
351 | 348 | ||
@@ -481,6 +478,8 @@ static int nilfs_show_options(struct seq_file *seq, struct vfsmount *vfs) | |||
481 | seq_printf(seq, ",order=strict"); | 478 | seq_printf(seq, ",order=strict"); |
482 | if (nilfs_test_opt(sbi, NORECOVERY)) | 479 | if (nilfs_test_opt(sbi, NORECOVERY)) |
483 | seq_printf(seq, ",norecovery"); | 480 | seq_printf(seq, ",norecovery"); |
481 | if (nilfs_test_opt(sbi, DISCARD)) | ||
482 | seq_printf(seq, ",discard"); | ||
484 | 483 | ||
485 | return 0; | 484 | return 0; |
486 | } | 485 | } |
@@ -550,7 +549,7 @@ static const struct export_operations nilfs_export_ops = { | |||
550 | enum { | 549 | enum { |
551 | Opt_err_cont, Opt_err_panic, Opt_err_ro, | 550 | Opt_err_cont, Opt_err_panic, Opt_err_ro, |
552 | Opt_nobarrier, Opt_snapshot, Opt_order, Opt_norecovery, | 551 | Opt_nobarrier, Opt_snapshot, Opt_order, Opt_norecovery, |
553 | Opt_err, | 552 | Opt_discard, Opt_err, |
554 | }; | 553 | }; |
555 | 554 | ||
556 | static match_table_t tokens = { | 555 | static match_table_t tokens = { |
@@ -561,6 +560,7 @@ static match_table_t tokens = { | |||
561 | {Opt_snapshot, "cp=%u"}, | 560 | {Opt_snapshot, "cp=%u"}, |
562 | {Opt_order, "order=%s"}, | 561 | {Opt_order, "order=%s"}, |
563 | {Opt_norecovery, "norecovery"}, | 562 | {Opt_norecovery, "norecovery"}, |
563 | {Opt_discard, "discard"}, | ||
564 | {Opt_err, NULL} | 564 | {Opt_err, NULL} |
565 | }; | 565 | }; |
566 | 566 | ||
@@ -614,6 +614,9 @@ static int parse_options(char *options, struct super_block *sb) | |||
614 | case Opt_norecovery: | 614 | case Opt_norecovery: |
615 | nilfs_set_opt(sbi, NORECOVERY); | 615 | nilfs_set_opt(sbi, NORECOVERY); |
616 | break; | 616 | break; |
617 | case Opt_discard: | ||
618 | nilfs_set_opt(sbi, DISCARD); | ||
619 | break; | ||
617 | default: | 620 | default: |
618 | printk(KERN_ERR | 621 | printk(KERN_ERR |
619 | "NILFS: Unrecognized mount option \"%s\"\n", p); | 622 | "NILFS: Unrecognized mount option \"%s\"\n", p); |
diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c index 6241e1722efc..92733d5651d2 100644 --- a/fs/nilfs2/the_nilfs.c +++ b/fs/nilfs2/the_nilfs.c | |||
@@ -646,6 +646,44 @@ int init_nilfs(struct the_nilfs *nilfs, struct nilfs_sb_info *sbi, char *data) | |||
646 | goto out; | 646 | goto out; |
647 | } | 647 | } |
648 | 648 | ||
649 | int nilfs_discard_segments(struct the_nilfs *nilfs, __u64 *segnump, | ||
650 | size_t nsegs) | ||
651 | { | ||
652 | sector_t seg_start, seg_end; | ||
653 | sector_t start = 0, nblocks = 0; | ||
654 | unsigned int sects_per_block; | ||
655 | __u64 *sn; | ||
656 | int ret = 0; | ||
657 | |||
658 | sects_per_block = (1 << nilfs->ns_blocksize_bits) / | ||
659 | bdev_logical_block_size(nilfs->ns_bdev); | ||
660 | for (sn = segnump; sn < segnump + nsegs; sn++) { | ||
661 | nilfs_get_segment_range(nilfs, *sn, &seg_start, &seg_end); | ||
662 | |||
663 | if (!nblocks) { | ||
664 | start = seg_start; | ||
665 | nblocks = seg_end - seg_start + 1; | ||
666 | } else if (start + nblocks == seg_start) { | ||
667 | nblocks += seg_end - seg_start + 1; | ||
668 | } else { | ||
669 | ret = blkdev_issue_discard(nilfs->ns_bdev, | ||
670 | start * sects_per_block, | ||
671 | nblocks * sects_per_block, | ||
672 | GFP_NOFS, | ||
673 | DISCARD_FL_BARRIER); | ||
674 | if (ret < 0) | ||
675 | return ret; | ||
676 | nblocks = 0; | ||
677 | } | ||
678 | } | ||
679 | if (nblocks) | ||
680 | ret = blkdev_issue_discard(nilfs->ns_bdev, | ||
681 | start * sects_per_block, | ||
682 | nblocks * sects_per_block, | ||
683 | GFP_NOFS, DISCARD_FL_BARRIER); | ||
684 | return ret; | ||
685 | } | ||
686 | |||
649 | int nilfs_count_free_blocks(struct the_nilfs *nilfs, sector_t *nblocks) | 687 | int nilfs_count_free_blocks(struct the_nilfs *nilfs, sector_t *nblocks) |
650 | { | 688 | { |
651 | struct inode *dat = nilfs_dat_inode(nilfs); | 689 | struct inode *dat = nilfs_dat_inode(nilfs); |
diff --git a/fs/nilfs2/the_nilfs.h b/fs/nilfs2/the_nilfs.h index 589786e33464..e9795f1724d7 100644 --- a/fs/nilfs2/the_nilfs.h +++ b/fs/nilfs2/the_nilfs.h | |||
@@ -38,6 +38,7 @@ enum { | |||
38 | the latest checkpoint was loaded */ | 38 | the latest checkpoint was loaded */ |
39 | THE_NILFS_DISCONTINUED, /* 'next' pointer chain has broken */ | 39 | THE_NILFS_DISCONTINUED, /* 'next' pointer chain has broken */ |
40 | THE_NILFS_GC_RUNNING, /* gc process is running */ | 40 | THE_NILFS_GC_RUNNING, /* gc process is running */ |
41 | THE_NILFS_SB_DIRTY, /* super block is dirty */ | ||
41 | }; | 42 | }; |
42 | 43 | ||
43 | /** | 44 | /** |
@@ -197,6 +198,7 @@ THE_NILFS_FNS(INIT, init) | |||
197 | THE_NILFS_FNS(LOADED, loaded) | 198 | THE_NILFS_FNS(LOADED, loaded) |
198 | THE_NILFS_FNS(DISCONTINUED, discontinued) | 199 | THE_NILFS_FNS(DISCONTINUED, discontinued) |
199 | THE_NILFS_FNS(GC_RUNNING, gc_running) | 200 | THE_NILFS_FNS(GC_RUNNING, gc_running) |
201 | THE_NILFS_FNS(SB_DIRTY, sb_dirty) | ||
200 | 202 | ||
201 | /* Minimum interval of periodical update of superblocks (in seconds) */ | 203 | /* Minimum interval of periodical update of superblocks (in seconds) */ |
202 | #define NILFS_SB_FREQ 10 | 204 | #define NILFS_SB_FREQ 10 |
@@ -221,6 +223,7 @@ struct the_nilfs *find_or_create_nilfs(struct block_device *); | |||
221 | void put_nilfs(struct the_nilfs *); | 223 | void put_nilfs(struct the_nilfs *); |
222 | int init_nilfs(struct the_nilfs *, struct nilfs_sb_info *, char *); | 224 | int init_nilfs(struct the_nilfs *, struct nilfs_sb_info *, char *); |
223 | int load_nilfs(struct the_nilfs *, struct nilfs_sb_info *); | 225 | int load_nilfs(struct the_nilfs *, struct nilfs_sb_info *); |
226 | int nilfs_discard_segments(struct the_nilfs *, __u64 *, size_t); | ||
224 | int nilfs_count_free_blocks(struct the_nilfs *, sector_t *); | 227 | int nilfs_count_free_blocks(struct the_nilfs *, sector_t *); |
225 | struct nilfs_sb_info *nilfs_find_sbinfo(struct the_nilfs *, int, __u64); | 228 | struct nilfs_sb_info *nilfs_find_sbinfo(struct the_nilfs *, int, __u64); |
226 | int nilfs_checkpoint_is_mounted(struct the_nilfs *, __u64, int); | 229 | int nilfs_checkpoint_is_mounted(struct the_nilfs *, __u64, int); |
diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c index a94e8bd8eb1f..472cdf29ef82 100644 --- a/fs/notify/inotify/inotify_user.c +++ b/fs/notify/inotify/inotify_user.c | |||
@@ -29,14 +29,12 @@ | |||
29 | #include <linux/init.h> /* module_init */ | 29 | #include <linux/init.h> /* module_init */ |
30 | #include <linux/inotify.h> | 30 | #include <linux/inotify.h> |
31 | #include <linux/kernel.h> /* roundup() */ | 31 | #include <linux/kernel.h> /* roundup() */ |
32 | #include <linux/magic.h> /* superblock magic number */ | ||
33 | #include <linux/mount.h> /* mntget */ | ||
34 | #include <linux/namei.h> /* LOOKUP_FOLLOW */ | 32 | #include <linux/namei.h> /* LOOKUP_FOLLOW */ |
35 | #include <linux/path.h> /* struct path */ | ||
36 | #include <linux/sched.h> /* struct user */ | 33 | #include <linux/sched.h> /* struct user */ |
37 | #include <linux/slab.h> /* struct kmem_cache */ | 34 | #include <linux/slab.h> /* struct kmem_cache */ |
38 | #include <linux/syscalls.h> | 35 | #include <linux/syscalls.h> |
39 | #include <linux/types.h> | 36 | #include <linux/types.h> |
37 | #include <linux/anon_inodes.h> | ||
40 | #include <linux/uaccess.h> | 38 | #include <linux/uaccess.h> |
41 | #include <linux/poll.h> | 39 | #include <linux/poll.h> |
42 | #include <linux/wait.h> | 40 | #include <linux/wait.h> |
@@ -45,8 +43,6 @@ | |||
45 | 43 | ||
46 | #include <asm/ioctls.h> | 44 | #include <asm/ioctls.h> |
47 | 45 | ||
48 | static struct vfsmount *inotify_mnt __read_mostly; | ||
49 | |||
50 | /* these are configurable via /proc/sys/fs/inotify/ */ | 46 | /* these are configurable via /proc/sys/fs/inotify/ */ |
51 | static int inotify_max_user_instances __read_mostly; | 47 | static int inotify_max_user_instances __read_mostly; |
52 | static int inotify_max_queued_events __read_mostly; | 48 | static int inotify_max_queued_events __read_mostly; |
@@ -645,9 +641,7 @@ SYSCALL_DEFINE1(inotify_init1, int, flags) | |||
645 | { | 641 | { |
646 | struct fsnotify_group *group; | 642 | struct fsnotify_group *group; |
647 | struct user_struct *user; | 643 | struct user_struct *user; |
648 | struct file *filp; | 644 | int ret; |
649 | struct path path; | ||
650 | int fd, ret; | ||
651 | 645 | ||
652 | /* Check the IN_* constants for consistency. */ | 646 | /* Check the IN_* constants for consistency. */ |
653 | BUILD_BUG_ON(IN_CLOEXEC != O_CLOEXEC); | 647 | BUILD_BUG_ON(IN_CLOEXEC != O_CLOEXEC); |
@@ -656,10 +650,6 @@ SYSCALL_DEFINE1(inotify_init1, int, flags) | |||
656 | if (flags & ~(IN_CLOEXEC | IN_NONBLOCK)) | 650 | if (flags & ~(IN_CLOEXEC | IN_NONBLOCK)) |
657 | return -EINVAL; | 651 | return -EINVAL; |
658 | 652 | ||
659 | fd = get_unused_fd_flags(flags & O_CLOEXEC); | ||
660 | if (fd < 0) | ||
661 | return fd; | ||
662 | |||
663 | user = get_current_user(); | 653 | user = get_current_user(); |
664 | if (unlikely(atomic_read(&user->inotify_devs) >= | 654 | if (unlikely(atomic_read(&user->inotify_devs) >= |
665 | inotify_max_user_instances)) { | 655 | inotify_max_user_instances)) { |
@@ -676,27 +666,14 @@ SYSCALL_DEFINE1(inotify_init1, int, flags) | |||
676 | 666 | ||
677 | atomic_inc(&user->inotify_devs); | 667 | atomic_inc(&user->inotify_devs); |
678 | 668 | ||
679 | path.mnt = inotify_mnt; | 669 | ret = anon_inode_getfd("inotify", &inotify_fops, group, |
680 | path.dentry = inotify_mnt->mnt_root; | 670 | O_RDONLY | flags); |
681 | path_get(&path); | 671 | if (ret >= 0) |
682 | filp = alloc_file(&path, FMODE_READ, &inotify_fops); | 672 | return ret; |
683 | if (!filp) | ||
684 | goto Enfile; | ||
685 | 673 | ||
686 | filp->f_flags = O_RDONLY | (flags & O_NONBLOCK); | ||
687 | filp->private_data = group; | ||
688 | |||
689 | fd_install(fd, filp); | ||
690 | |||
691 | return fd; | ||
692 | |||
693 | Enfile: | ||
694 | ret = -ENFILE; | ||
695 | path_put(&path); | ||
696 | atomic_dec(&user->inotify_devs); | 674 | atomic_dec(&user->inotify_devs); |
697 | out_free_uid: | 675 | out_free_uid: |
698 | free_uid(user); | 676 | free_uid(user); |
699 | put_unused_fd(fd); | ||
700 | return ret; | 677 | return ret; |
701 | } | 678 | } |
702 | 679 | ||
@@ -783,20 +760,6 @@ out: | |||
783 | return ret; | 760 | return ret; |
784 | } | 761 | } |
785 | 762 | ||
786 | static int | ||
787 | inotify_get_sb(struct file_system_type *fs_type, int flags, | ||
788 | const char *dev_name, void *data, struct vfsmount *mnt) | ||
789 | { | ||
790 | return get_sb_pseudo(fs_type, "inotify", NULL, | ||
791 | INOTIFYFS_SUPER_MAGIC, mnt); | ||
792 | } | ||
793 | |||
794 | static struct file_system_type inotify_fs_type = { | ||
795 | .name = "inotifyfs", | ||
796 | .get_sb = inotify_get_sb, | ||
797 | .kill_sb = kill_anon_super, | ||
798 | }; | ||
799 | |||
800 | /* | 763 | /* |
801 | * inotify_user_setup - Our initialization function. Note that we cannnot return | 764 | * inotify_user_setup - Our initialization function. Note that we cannnot return |
802 | * error because we have compiled-in VFS hooks. So an (unlikely) failure here | 765 | * error because we have compiled-in VFS hooks. So an (unlikely) failure here |
@@ -804,16 +767,6 @@ static struct file_system_type inotify_fs_type = { | |||
804 | */ | 767 | */ |
805 | static int __init inotify_user_setup(void) | 768 | static int __init inotify_user_setup(void) |
806 | { | 769 | { |
807 | int ret; | ||
808 | |||
809 | ret = register_filesystem(&inotify_fs_type); | ||
810 | if (unlikely(ret)) | ||
811 | panic("inotify: register_filesystem returned %d!\n", ret); | ||
812 | |||
813 | inotify_mnt = kern_mount(&inotify_fs_type); | ||
814 | if (IS_ERR(inotify_mnt)) | ||
815 | panic("inotify: kern_mount ret %ld!\n", PTR_ERR(inotify_mnt)); | ||
816 | |||
817 | inotify_inode_mark_cachep = KMEM_CACHE(inotify_inode_mark_entry, SLAB_PANIC); | 770 | inotify_inode_mark_cachep = KMEM_CACHE(inotify_inode_mark_entry, SLAB_PANIC); |
818 | event_priv_cachep = KMEM_CACHE(inotify_event_private_data, SLAB_PANIC); | 771 | event_priv_cachep = KMEM_CACHE(inotify_event_private_data, SLAB_PANIC); |
819 | 772 | ||
diff --git a/fs/ntfs/dir.c b/fs/ntfs/dir.c index 5a9e34475e37..9173e82a45d1 100644 --- a/fs/ntfs/dir.c +++ b/fs/ntfs/dir.c | |||
@@ -1545,7 +1545,7 @@ static int ntfs_dir_fsync(struct file *filp, struct dentry *dentry, | |||
1545 | write_inode_now(bmp_vi, !datasync); | 1545 | write_inode_now(bmp_vi, !datasync); |
1546 | iput(bmp_vi); | 1546 | iput(bmp_vi); |
1547 | } | 1547 | } |
1548 | ret = ntfs_write_inode(vi, 1); | 1548 | ret = __ntfs_write_inode(vi, 1); |
1549 | write_inode_now(vi, !datasync); | 1549 | write_inode_now(vi, !datasync); |
1550 | err = sync_blockdev(vi->i_sb->s_bdev); | 1550 | err = sync_blockdev(vi->i_sb->s_bdev); |
1551 | if (unlikely(err && !ret)) | 1551 | if (unlikely(err && !ret)) |
diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c index 43179ddd336f..b681c71d7069 100644 --- a/fs/ntfs/file.c +++ b/fs/ntfs/file.c | |||
@@ -2182,7 +2182,7 @@ static int ntfs_file_fsync(struct file *filp, struct dentry *dentry, | |||
2182 | ntfs_debug("Entering for inode 0x%lx.", vi->i_ino); | 2182 | ntfs_debug("Entering for inode 0x%lx.", vi->i_ino); |
2183 | BUG_ON(S_ISDIR(vi->i_mode)); | 2183 | BUG_ON(S_ISDIR(vi->i_mode)); |
2184 | if (!datasync || !NInoNonResident(NTFS_I(vi))) | 2184 | if (!datasync || !NInoNonResident(NTFS_I(vi))) |
2185 | ret = ntfs_write_inode(vi, 1); | 2185 | ret = __ntfs_write_inode(vi, 1); |
2186 | write_inode_now(vi, !datasync); | 2186 | write_inode_now(vi, !datasync); |
2187 | /* | 2187 | /* |
2188 | * NOTE: If we were to use mapping->private_list (see ext2 and | 2188 | * NOTE: If we were to use mapping->private_list (see ext2 and |
diff --git a/fs/ntfs/inode.c b/fs/ntfs/inode.c index dc2505abb6d7..4b57fb1eac2a 100644 --- a/fs/ntfs/inode.c +++ b/fs/ntfs/inode.c | |||
@@ -2957,7 +2957,7 @@ out: | |||
2957 | * | 2957 | * |
2958 | * Return 0 on success and -errno on error. | 2958 | * Return 0 on success and -errno on error. |
2959 | */ | 2959 | */ |
2960 | int ntfs_write_inode(struct inode *vi, int sync) | 2960 | int __ntfs_write_inode(struct inode *vi, int sync) |
2961 | { | 2961 | { |
2962 | sle64 nt; | 2962 | sle64 nt; |
2963 | ntfs_inode *ni = NTFS_I(vi); | 2963 | ntfs_inode *ni = NTFS_I(vi); |
diff --git a/fs/ntfs/inode.h b/fs/ntfs/inode.h index 117eaf8032a3..9a113544605d 100644 --- a/fs/ntfs/inode.h +++ b/fs/ntfs/inode.h | |||
@@ -307,12 +307,12 @@ extern void ntfs_truncate_vfs(struct inode *vi); | |||
307 | 307 | ||
308 | extern int ntfs_setattr(struct dentry *dentry, struct iattr *attr); | 308 | extern int ntfs_setattr(struct dentry *dentry, struct iattr *attr); |
309 | 309 | ||
310 | extern int ntfs_write_inode(struct inode *vi, int sync); | 310 | extern int __ntfs_write_inode(struct inode *vi, int sync); |
311 | 311 | ||
312 | static inline void ntfs_commit_inode(struct inode *vi) | 312 | static inline void ntfs_commit_inode(struct inode *vi) |
313 | { | 313 | { |
314 | if (!is_bad_inode(vi)) | 314 | if (!is_bad_inode(vi)) |
315 | ntfs_write_inode(vi, 1); | 315 | __ntfs_write_inode(vi, 1); |
316 | return; | 316 | return; |
317 | } | 317 | } |
318 | 318 | ||
diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c index 80b04770e8e9..1cf39dfaee7a 100644 --- a/fs/ntfs/super.c +++ b/fs/ntfs/super.c | |||
@@ -39,6 +39,7 @@ | |||
39 | #include "dir.h" | 39 | #include "dir.h" |
40 | #include "debug.h" | 40 | #include "debug.h" |
41 | #include "index.h" | 41 | #include "index.h" |
42 | #include "inode.h" | ||
42 | #include "aops.h" | 43 | #include "aops.h" |
43 | #include "layout.h" | 44 | #include "layout.h" |
44 | #include "malloc.h" | 45 | #include "malloc.h" |
@@ -2662,6 +2663,13 @@ static int ntfs_statfs(struct dentry *dentry, struct kstatfs *sfs) | |||
2662 | return 0; | 2663 | return 0; |
2663 | } | 2664 | } |
2664 | 2665 | ||
2666 | #ifdef NTFS_RW | ||
2667 | static int ntfs_write_inode(struct inode *vi, struct writeback_control *wbc) | ||
2668 | { | ||
2669 | return __ntfs_write_inode(vi, wbc->sync_mode == WB_SYNC_ALL); | ||
2670 | } | ||
2671 | #endif | ||
2672 | |||
2665 | /** | 2673 | /** |
2666 | * The complete super operations. | 2674 | * The complete super operations. |
2667 | */ | 2675 | */ |
diff --git a/fs/ocfs2/Makefile b/fs/ocfs2/Makefile index 600d2d2ade11..791c0886c060 100644 --- a/fs/ocfs2/Makefile +++ b/fs/ocfs2/Makefile | |||
@@ -46,6 +46,7 @@ ocfs2_stackglue-objs := stackglue.o | |||
46 | ocfs2_stack_o2cb-objs := stack_o2cb.o | 46 | ocfs2_stack_o2cb-objs := stack_o2cb.o |
47 | ocfs2_stack_user-objs := stack_user.o | 47 | ocfs2_stack_user-objs := stack_user.o |
48 | 48 | ||
49 | obj-$(CONFIG_OCFS2_FS) += dlmfs/ | ||
49 | # cluster/ is always needed when OCFS2_FS for masklog support | 50 | # cluster/ is always needed when OCFS2_FS for masklog support |
50 | obj-$(CONFIG_OCFS2_FS) += cluster/ | 51 | obj-$(CONFIG_OCFS2_FS) += cluster/ |
51 | obj-$(CONFIG_OCFS2_FS_O2CB) += dlm/ | 52 | obj-$(CONFIG_OCFS2_FS_O2CB) += dlm/ |
diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index d17bdc718f74..9f8bd913c51e 100644 --- a/fs/ocfs2/alloc.c +++ b/fs/ocfs2/alloc.c | |||
@@ -1050,7 +1050,8 @@ static int ocfs2_create_new_meta_bhs(handle_t *handle, | |||
1050 | strcpy(eb->h_signature, OCFS2_EXTENT_BLOCK_SIGNATURE); | 1050 | strcpy(eb->h_signature, OCFS2_EXTENT_BLOCK_SIGNATURE); |
1051 | eb->h_blkno = cpu_to_le64(first_blkno); | 1051 | eb->h_blkno = cpu_to_le64(first_blkno); |
1052 | eb->h_fs_generation = cpu_to_le32(osb->fs_generation); | 1052 | eb->h_fs_generation = cpu_to_le32(osb->fs_generation); |
1053 | eb->h_suballoc_slot = cpu_to_le16(osb->slot_num); | 1053 | eb->h_suballoc_slot = |
1054 | cpu_to_le16(meta_ac->ac_alloc_slot); | ||
1054 | eb->h_suballoc_bit = cpu_to_le16(suballoc_bit_start); | 1055 | eb->h_suballoc_bit = cpu_to_le16(suballoc_bit_start); |
1055 | eb->h_list.l_count = | 1056 | eb->h_list.l_count = |
1056 | cpu_to_le16(ocfs2_extent_recs_per_eb(osb->sb)); | 1057 | cpu_to_le16(ocfs2_extent_recs_per_eb(osb->sb)); |
@@ -5712,7 +5713,7 @@ int ocfs2_remove_btree_range(struct inode *inode, | |||
5712 | goto out; | 5713 | goto out; |
5713 | } | 5714 | } |
5714 | 5715 | ||
5715 | vfs_dq_free_space_nodirty(inode, | 5716 | dquot_free_space_nodirty(inode, |
5716 | ocfs2_clusters_to_bytes(inode->i_sb, len)); | 5717 | ocfs2_clusters_to_bytes(inode->i_sb, len)); |
5717 | 5718 | ||
5718 | ret = ocfs2_remove_extent(handle, et, cpos, len, meta_ac, dealloc); | 5719 | ret = ocfs2_remove_extent(handle, et, cpos, len, meta_ac, dealloc); |
@@ -6037,7 +6038,7 @@ static void ocfs2_truncate_log_worker(struct work_struct *work) | |||
6037 | if (status < 0) | 6038 | if (status < 0) |
6038 | mlog_errno(status); | 6039 | mlog_errno(status); |
6039 | else | 6040 | else |
6040 | ocfs2_init_inode_steal_slot(osb); | 6041 | ocfs2_init_steal_slots(osb); |
6041 | 6042 | ||
6042 | mlog_exit(status); | 6043 | mlog_exit(status); |
6043 | } | 6044 | } |
@@ -6935,7 +6936,7 @@ static int ocfs2_do_truncate(struct ocfs2_super *osb, | |||
6935 | goto bail; | 6936 | goto bail; |
6936 | } | 6937 | } |
6937 | 6938 | ||
6938 | vfs_dq_free_space_nodirty(inode, | 6939 | dquot_free_space_nodirty(inode, |
6939 | ocfs2_clusters_to_bytes(osb->sb, clusters_to_del)); | 6940 | ocfs2_clusters_to_bytes(osb->sb, clusters_to_del)); |
6940 | spin_lock(&OCFS2_I(inode)->ip_lock); | 6941 | spin_lock(&OCFS2_I(inode)->ip_lock); |
6941 | OCFS2_I(inode)->ip_clusters = le32_to_cpu(fe->i_clusters) - | 6942 | OCFS2_I(inode)->ip_clusters = le32_to_cpu(fe->i_clusters) - |
@@ -7300,11 +7301,10 @@ int ocfs2_convert_inline_data_to_extents(struct inode *inode, | |||
7300 | unsigned int page_end; | 7301 | unsigned int page_end; |
7301 | u64 phys; | 7302 | u64 phys; |
7302 | 7303 | ||
7303 | if (vfs_dq_alloc_space_nodirty(inode, | 7304 | ret = dquot_alloc_space_nodirty(inode, |
7304 | ocfs2_clusters_to_bytes(osb->sb, 1))) { | 7305 | ocfs2_clusters_to_bytes(osb->sb, 1)); |
7305 | ret = -EDQUOT; | 7306 | if (ret) |
7306 | goto out_commit; | 7307 | goto out_commit; |
7307 | } | ||
7308 | did_quota = 1; | 7308 | did_quota = 1; |
7309 | 7309 | ||
7310 | ret = ocfs2_claim_clusters(osb, handle, data_ac, 1, &bit_off, | 7310 | ret = ocfs2_claim_clusters(osb, handle, data_ac, 1, &bit_off, |
@@ -7380,7 +7380,7 @@ int ocfs2_convert_inline_data_to_extents(struct inode *inode, | |||
7380 | 7380 | ||
7381 | out_commit: | 7381 | out_commit: |
7382 | if (ret < 0 && did_quota) | 7382 | if (ret < 0 && did_quota) |
7383 | vfs_dq_free_space_nodirty(inode, | 7383 | dquot_free_space_nodirty(inode, |
7384 | ocfs2_clusters_to_bytes(osb->sb, 1)); | 7384 | ocfs2_clusters_to_bytes(osb->sb, 1)); |
7385 | 7385 | ||
7386 | ocfs2_commit_trans(osb, handle); | 7386 | ocfs2_commit_trans(osb, handle); |
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index 7e9df11260f4..21441ddb5506 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c | |||
@@ -577,8 +577,9 @@ static int ocfs2_direct_IO_get_blocks(struct inode *inode, sector_t iblock, | |||
577 | goto bail; | 577 | goto bail; |
578 | } | 578 | } |
579 | 579 | ||
580 | /* We should already CoW the refcounted extent. */ | 580 | /* We should already CoW the refcounted extent in case of create. */ |
581 | BUG_ON(ext_flags & OCFS2_EXT_REFCOUNTED); | 581 | BUG_ON(create && (ext_flags & OCFS2_EXT_REFCOUNTED)); |
582 | |||
582 | /* | 583 | /* |
583 | * get_more_blocks() expects us to describe a hole by clearing | 584 | * get_more_blocks() expects us to describe a hole by clearing |
584 | * the mapped bit on bh_result(). | 585 | * the mapped bit on bh_result(). |
@@ -1763,10 +1764,11 @@ int ocfs2_write_begin_nolock(struct address_space *mapping, | |||
1763 | 1764 | ||
1764 | wc->w_handle = handle; | 1765 | wc->w_handle = handle; |
1765 | 1766 | ||
1766 | if (clusters_to_alloc && vfs_dq_alloc_space_nodirty(inode, | 1767 | if (clusters_to_alloc) { |
1767 | ocfs2_clusters_to_bytes(osb->sb, clusters_to_alloc))) { | 1768 | ret = dquot_alloc_space_nodirty(inode, |
1768 | ret = -EDQUOT; | 1769 | ocfs2_clusters_to_bytes(osb->sb, clusters_to_alloc)); |
1769 | goto out_commit; | 1770 | if (ret) |
1771 | goto out_commit; | ||
1770 | } | 1772 | } |
1771 | /* | 1773 | /* |
1772 | * We don't want this to fail in ocfs2_write_end(), so do it | 1774 | * We don't want this to fail in ocfs2_write_end(), so do it |
@@ -1809,7 +1811,7 @@ success: | |||
1809 | return 0; | 1811 | return 0; |
1810 | out_quota: | 1812 | out_quota: |
1811 | if (clusters_to_alloc) | 1813 | if (clusters_to_alloc) |
1812 | vfs_dq_free_space(inode, | 1814 | dquot_free_space(inode, |
1813 | ocfs2_clusters_to_bytes(osb->sb, clusters_to_alloc)); | 1815 | ocfs2_clusters_to_bytes(osb->sb, clusters_to_alloc)); |
1814 | out_commit: | 1816 | out_commit: |
1815 | ocfs2_commit_trans(osb, handle); | 1817 | ocfs2_commit_trans(osb, handle); |
diff --git a/fs/ocfs2/cluster/masklog.c b/fs/ocfs2/cluster/masklog.c index 1cd2934de615..3bb928a2bf7d 100644 --- a/fs/ocfs2/cluster/masklog.c +++ b/fs/ocfs2/cluster/masklog.c | |||
@@ -112,6 +112,7 @@ static struct mlog_attribute mlog_attrs[MLOG_MAX_BITS] = { | |||
112 | define_mask(XATTR), | 112 | define_mask(XATTR), |
113 | define_mask(QUOTA), | 113 | define_mask(QUOTA), |
114 | define_mask(REFCOUNT), | 114 | define_mask(REFCOUNT), |
115 | define_mask(BASTS), | ||
115 | define_mask(ERROR), | 116 | define_mask(ERROR), |
116 | define_mask(NOTICE), | 117 | define_mask(NOTICE), |
117 | define_mask(KTHREAD), | 118 | define_mask(KTHREAD), |
@@ -135,7 +136,7 @@ static ssize_t mlog_store(struct kobject *obj, struct attribute *attr, | |||
135 | return mlog_mask_store(mlog_attr->mask, buf, count); | 136 | return mlog_mask_store(mlog_attr->mask, buf, count); |
136 | } | 137 | } |
137 | 138 | ||
138 | static struct sysfs_ops mlog_attr_ops = { | 139 | static const struct sysfs_ops mlog_attr_ops = { |
139 | .show = mlog_show, | 140 | .show = mlog_show, |
140 | .store = mlog_store, | 141 | .store = mlog_store, |
141 | }; | 142 | }; |
diff --git a/fs/ocfs2/cluster/masklog.h b/fs/ocfs2/cluster/masklog.h index 9b4d11726cf2..3dfddbec32f2 100644 --- a/fs/ocfs2/cluster/masklog.h +++ b/fs/ocfs2/cluster/masklog.h | |||
@@ -114,6 +114,7 @@ | |||
114 | #define ML_XATTR 0x0000000020000000ULL /* ocfs2 extended attributes */ | 114 | #define ML_XATTR 0x0000000020000000ULL /* ocfs2 extended attributes */ |
115 | #define ML_QUOTA 0x0000000040000000ULL /* ocfs2 quota operations */ | 115 | #define ML_QUOTA 0x0000000040000000ULL /* ocfs2 quota operations */ |
116 | #define ML_REFCOUNT 0x0000000080000000ULL /* refcount tree operations */ | 116 | #define ML_REFCOUNT 0x0000000080000000ULL /* refcount tree operations */ |
117 | #define ML_BASTS 0x0000001000000000ULL /* dlmglue asts and basts */ | ||
117 | /* bits that are infrequently given and frequently matched in the high word */ | 118 | /* bits that are infrequently given and frequently matched in the high word */ |
118 | #define ML_ERROR 0x0000000100000000ULL /* sent to KERN_ERR */ | 119 | #define ML_ERROR 0x0000000100000000ULL /* sent to KERN_ERR */ |
119 | #define ML_NOTICE 0x0000000200000000ULL /* setn to KERN_NOTICE */ | 120 | #define ML_NOTICE 0x0000000200000000ULL /* setn to KERN_NOTICE */ |
@@ -194,9 +195,9 @@ extern struct mlog_bits mlog_and_bits, mlog_not_bits; | |||
194 | * previous token if args expands to nothing. | 195 | * previous token if args expands to nothing. |
195 | */ | 196 | */ |
196 | #define __mlog_printk(level, fmt, args...) \ | 197 | #define __mlog_printk(level, fmt, args...) \ |
197 | printk(level "(%u,%lu):%s:%d " fmt, task_pid_nr(current), \ | 198 | printk(level "(%s,%u,%lu):%s:%d " fmt, current->comm, \ |
198 | __mlog_cpu_guess, __PRETTY_FUNCTION__, __LINE__ , \ | 199 | task_pid_nr(current), __mlog_cpu_guess, \ |
199 | ##args) | 200 | __PRETTY_FUNCTION__, __LINE__ , ##args) |
200 | 201 | ||
201 | #define mlog(mask, fmt, args...) do { \ | 202 | #define mlog(mask, fmt, args...) do { \ |
202 | u64 __m = MLOG_MASK_PREFIX | (mask); \ | 203 | u64 __m = MLOG_MASK_PREFIX | (mask); \ |
diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index 28c3ec238796..efd77d071c80 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c | |||
@@ -2439,7 +2439,7 @@ static int ocfs2_dx_dir_attach_index(struct ocfs2_super *osb, | |||
2439 | dx_root = (struct ocfs2_dx_root_block *)dx_root_bh->b_data; | 2439 | dx_root = (struct ocfs2_dx_root_block *)dx_root_bh->b_data; |
2440 | memset(dx_root, 0, osb->sb->s_blocksize); | 2440 | memset(dx_root, 0, osb->sb->s_blocksize); |
2441 | strcpy(dx_root->dr_signature, OCFS2_DX_ROOT_SIGNATURE); | 2441 | strcpy(dx_root->dr_signature, OCFS2_DX_ROOT_SIGNATURE); |
2442 | dx_root->dr_suballoc_slot = cpu_to_le16(osb->slot_num); | 2442 | dx_root->dr_suballoc_slot = cpu_to_le16(meta_ac->ac_alloc_slot); |
2443 | dx_root->dr_suballoc_bit = cpu_to_le16(dr_suballoc_bit); | 2443 | dx_root->dr_suballoc_bit = cpu_to_le16(dr_suballoc_bit); |
2444 | dx_root->dr_fs_generation = cpu_to_le32(osb->fs_generation); | 2444 | dx_root->dr_fs_generation = cpu_to_le32(osb->fs_generation); |
2445 | dx_root->dr_blkno = cpu_to_le64(dr_blkno); | 2445 | dx_root->dr_blkno = cpu_to_le64(dr_blkno); |
@@ -2964,12 +2964,10 @@ static int ocfs2_expand_inline_dir(struct inode *dir, struct buffer_head *di_bh, | |||
2964 | goto out; | 2964 | goto out; |
2965 | } | 2965 | } |
2966 | 2966 | ||
2967 | if (vfs_dq_alloc_space_nodirty(dir, | 2967 | ret = dquot_alloc_space_nodirty(dir, |
2968 | ocfs2_clusters_to_bytes(osb->sb, | 2968 | ocfs2_clusters_to_bytes(osb->sb, alloc + dx_alloc)); |
2969 | alloc + dx_alloc))) { | 2969 | if (ret) |
2970 | ret = -EDQUOT; | ||
2971 | goto out_commit; | 2970 | goto out_commit; |
2972 | } | ||
2973 | did_quota = 1; | 2971 | did_quota = 1; |
2974 | 2972 | ||
2975 | if (ocfs2_supports_indexed_dirs(osb) && !dx_inline) { | 2973 | if (ocfs2_supports_indexed_dirs(osb) && !dx_inline) { |
@@ -3178,7 +3176,7 @@ static int ocfs2_expand_inline_dir(struct inode *dir, struct buffer_head *di_bh, | |||
3178 | 3176 | ||
3179 | out_commit: | 3177 | out_commit: |
3180 | if (ret < 0 && did_quota) | 3178 | if (ret < 0 && did_quota) |
3181 | vfs_dq_free_space_nodirty(dir, bytes_allocated); | 3179 | dquot_free_space_nodirty(dir, bytes_allocated); |
3182 | 3180 | ||
3183 | ocfs2_commit_trans(osb, handle); | 3181 | ocfs2_commit_trans(osb, handle); |
3184 | 3182 | ||
@@ -3221,11 +3219,10 @@ static int ocfs2_do_extend_dir(struct super_block *sb, | |||
3221 | if (extend) { | 3219 | if (extend) { |
3222 | u32 offset = OCFS2_I(dir)->ip_clusters; | 3220 | u32 offset = OCFS2_I(dir)->ip_clusters; |
3223 | 3221 | ||
3224 | if (vfs_dq_alloc_space_nodirty(dir, | 3222 | status = dquot_alloc_space_nodirty(dir, |
3225 | ocfs2_clusters_to_bytes(sb, 1))) { | 3223 | ocfs2_clusters_to_bytes(sb, 1)); |
3226 | status = -EDQUOT; | 3224 | if (status) |
3227 | goto bail; | 3225 | goto bail; |
3228 | } | ||
3229 | did_quota = 1; | 3226 | did_quota = 1; |
3230 | 3227 | ||
3231 | status = ocfs2_add_inode_data(OCFS2_SB(sb), dir, &offset, | 3228 | status = ocfs2_add_inode_data(OCFS2_SB(sb), dir, &offset, |
@@ -3254,7 +3251,7 @@ static int ocfs2_do_extend_dir(struct super_block *sb, | |||
3254 | status = 0; | 3251 | status = 0; |
3255 | bail: | 3252 | bail: |
3256 | if (did_quota && status < 0) | 3253 | if (did_quota && status < 0) |
3257 | vfs_dq_free_space_nodirty(dir, ocfs2_clusters_to_bytes(sb, 1)); | 3254 | dquot_free_space_nodirty(dir, ocfs2_clusters_to_bytes(sb, 1)); |
3258 | mlog_exit(status); | 3255 | mlog_exit(status); |
3259 | return status; | 3256 | return status; |
3260 | } | 3257 | } |
@@ -3889,11 +3886,10 @@ static int ocfs2_dx_dir_rebalance(struct ocfs2_super *osb, struct inode *dir, | |||
3889 | goto out; | 3886 | goto out; |
3890 | } | 3887 | } |
3891 | 3888 | ||
3892 | if (vfs_dq_alloc_space_nodirty(dir, | 3889 | ret = dquot_alloc_space_nodirty(dir, |
3893 | ocfs2_clusters_to_bytes(dir->i_sb, 1))) { | 3890 | ocfs2_clusters_to_bytes(dir->i_sb, 1)); |
3894 | ret = -EDQUOT; | 3891 | if (ret) |
3895 | goto out_commit; | 3892 | goto out_commit; |
3896 | } | ||
3897 | did_quota = 1; | 3893 | did_quota = 1; |
3898 | 3894 | ||
3899 | ret = ocfs2_journal_access_dl(handle, INODE_CACHE(dir), dx_leaf_bh, | 3895 | ret = ocfs2_journal_access_dl(handle, INODE_CACHE(dir), dx_leaf_bh, |
@@ -3983,7 +3979,7 @@ static int ocfs2_dx_dir_rebalance(struct ocfs2_super *osb, struct inode *dir, | |||
3983 | 3979 | ||
3984 | out_commit: | 3980 | out_commit: |
3985 | if (ret < 0 && did_quota) | 3981 | if (ret < 0 && did_quota) |
3986 | vfs_dq_free_space_nodirty(dir, | 3982 | dquot_free_space_nodirty(dir, |
3987 | ocfs2_clusters_to_bytes(dir->i_sb, 1)); | 3983 | ocfs2_clusters_to_bytes(dir->i_sb, 1)); |
3988 | 3984 | ||
3989 | ocfs2_commit_trans(osb, handle); | 3985 | ocfs2_commit_trans(osb, handle); |
@@ -4165,11 +4161,10 @@ static int ocfs2_expand_inline_dx_root(struct inode *dir, | |||
4165 | goto out; | 4161 | goto out; |
4166 | } | 4162 | } |
4167 | 4163 | ||
4168 | if (vfs_dq_alloc_space_nodirty(dir, | 4164 | ret = dquot_alloc_space_nodirty(dir, |
4169 | ocfs2_clusters_to_bytes(osb->sb, 1))) { | 4165 | ocfs2_clusters_to_bytes(osb->sb, 1)); |
4170 | ret = -EDQUOT; | 4166 | if (ret) |
4171 | goto out_commit; | 4167 | goto out_commit; |
4172 | } | ||
4173 | did_quota = 1; | 4168 | did_quota = 1; |
4174 | 4169 | ||
4175 | /* | 4170 | /* |
@@ -4229,7 +4224,7 @@ static int ocfs2_expand_inline_dx_root(struct inode *dir, | |||
4229 | 4224 | ||
4230 | out_commit: | 4225 | out_commit: |
4231 | if (ret < 0 && did_quota) | 4226 | if (ret < 0 && did_quota) |
4232 | vfs_dq_free_space_nodirty(dir, | 4227 | dquot_free_space_nodirty(dir, |
4233 | ocfs2_clusters_to_bytes(dir->i_sb, 1)); | 4228 | ocfs2_clusters_to_bytes(dir->i_sb, 1)); |
4234 | 4229 | ||
4235 | ocfs2_commit_trans(osb, handle); | 4230 | ocfs2_commit_trans(osb, handle); |
diff --git a/fs/ocfs2/dlm/Makefile b/fs/ocfs2/dlm/Makefile index 190361375700..dcebf0d920fa 100644 --- a/fs/ocfs2/dlm/Makefile +++ b/fs/ocfs2/dlm/Makefile | |||
@@ -1,8 +1,7 @@ | |||
1 | EXTRA_CFLAGS += -Ifs/ocfs2 | 1 | EXTRA_CFLAGS += -Ifs/ocfs2 |
2 | 2 | ||
3 | obj-$(CONFIG_OCFS2_FS_O2CB) += ocfs2_dlm.o ocfs2_dlmfs.o | 3 | obj-$(CONFIG_OCFS2_FS_O2CB) += ocfs2_dlm.o |
4 | 4 | ||
5 | ocfs2_dlm-objs := dlmdomain.o dlmdebug.o dlmthread.o dlmrecovery.o \ | 5 | ocfs2_dlm-objs := dlmdomain.o dlmdebug.o dlmthread.o dlmrecovery.o \ |
6 | dlmmaster.o dlmast.o dlmconvert.o dlmlock.o dlmunlock.o dlmver.o | 6 | dlmmaster.o dlmast.o dlmconvert.o dlmlock.o dlmunlock.o dlmver.o |
7 | 7 | ||
8 | ocfs2_dlmfs-objs := userdlm.o dlmfs.o dlmfsver.o | ||
diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c index 344bcf90cbf4..b4f99de2caf3 100644 --- a/fs/ocfs2/dlm/dlmrecovery.c +++ b/fs/ocfs2/dlm/dlmrecovery.c | |||
@@ -310,7 +310,7 @@ static int dlm_recovery_thread(void *data) | |||
310 | mlog(0, "dlm thread running for %s...\n", dlm->name); | 310 | mlog(0, "dlm thread running for %s...\n", dlm->name); |
311 | 311 | ||
312 | while (!kthread_should_stop()) { | 312 | while (!kthread_should_stop()) { |
313 | if (dlm_joined(dlm)) { | 313 | if (dlm_domain_fully_joined(dlm)) { |
314 | status = dlm_do_recovery(dlm); | 314 | status = dlm_do_recovery(dlm); |
315 | if (status == -EAGAIN) { | 315 | if (status == -EAGAIN) { |
316 | /* do not sleep, recheck immediately. */ | 316 | /* do not sleep, recheck immediately. */ |
diff --git a/fs/ocfs2/dlmfs/Makefile b/fs/ocfs2/dlmfs/Makefile new file mode 100644 index 000000000000..df69b4856d0d --- /dev/null +++ b/fs/ocfs2/dlmfs/Makefile | |||
@@ -0,0 +1,5 @@ | |||
1 | EXTRA_CFLAGS += -Ifs/ocfs2 | ||
2 | |||
3 | obj-$(CONFIG_OCFS2_FS) += ocfs2_dlmfs.o | ||
4 | |||
5 | ocfs2_dlmfs-objs := userdlm.o dlmfs.o dlmfsver.o | ||
diff --git a/fs/ocfs2/dlm/dlmfs.c b/fs/ocfs2/dlmfs/dlmfs.c index 02bf17808bdc..1b0de157a08c 100644 --- a/fs/ocfs2/dlm/dlmfs.c +++ b/fs/ocfs2/dlmfs/dlmfs.c | |||
@@ -43,24 +43,17 @@ | |||
43 | #include <linux/init.h> | 43 | #include <linux/init.h> |
44 | #include <linux/string.h> | 44 | #include <linux/string.h> |
45 | #include <linux/backing-dev.h> | 45 | #include <linux/backing-dev.h> |
46 | #include <linux/poll.h> | ||
46 | 47 | ||
47 | #include <asm/uaccess.h> | 48 | #include <asm/uaccess.h> |
48 | 49 | ||
49 | 50 | #include "stackglue.h" | |
50 | #include "cluster/nodemanager.h" | ||
51 | #include "cluster/heartbeat.h" | ||
52 | #include "cluster/tcp.h" | ||
53 | |||
54 | #include "dlmapi.h" | ||
55 | |||
56 | #include "userdlm.h" | 51 | #include "userdlm.h" |
57 | |||
58 | #include "dlmfsver.h" | 52 | #include "dlmfsver.h" |
59 | 53 | ||
60 | #define MLOG_MASK_PREFIX ML_DLMFS | 54 | #define MLOG_MASK_PREFIX ML_DLMFS |
61 | #include "cluster/masklog.h" | 55 | #include "cluster/masklog.h" |
62 | 56 | ||
63 | #include "ocfs2_lockingver.h" | ||
64 | 57 | ||
65 | static const struct super_operations dlmfs_ops; | 58 | static const struct super_operations dlmfs_ops; |
66 | static const struct file_operations dlmfs_file_operations; | 59 | static const struct file_operations dlmfs_file_operations; |
@@ -71,15 +64,46 @@ static struct kmem_cache *dlmfs_inode_cache; | |||
71 | 64 | ||
72 | struct workqueue_struct *user_dlm_worker; | 65 | struct workqueue_struct *user_dlm_worker; |
73 | 66 | ||
67 | |||
68 | |||
74 | /* | 69 | /* |
75 | * This is the userdlmfs locking protocol version. | 70 | * These are the ABI capabilities of dlmfs. |
71 | * | ||
72 | * Over time, dlmfs has added some features that were not part of the | ||
73 | * initial ABI. Unfortunately, some of these features are not detectable | ||
74 | * via standard usage. For example, Linux's default poll always returns | ||
75 | * POLLIN, so there is no way for a caller of poll(2) to know when dlmfs | ||
76 | * added poll support. Instead, we provide this list of new capabilities. | ||
77 | * | ||
78 | * Capabilities is a read-only attribute. We do it as a module parameter | ||
79 | * so we can discover it whether dlmfs is built in, loaded, or even not | ||
80 | * loaded. | ||
76 | * | 81 | * |
77 | * See fs/ocfs2/dlmglue.c for more details on locking versions. | 82 | * The ABI features are local to this machine's dlmfs mount. This is |
83 | * distinct from the locking protocol, which is concerned with inter-node | ||
84 | * interaction. | ||
85 | * | ||
86 | * Capabilities: | ||
87 | * - bast : POLLIN against the file descriptor of a held lock | ||
88 | * signifies a bast fired on the lock. | ||
78 | */ | 89 | */ |
79 | static const struct dlm_protocol_version user_locking_protocol = { | 90 | #define DLMFS_CAPABILITIES "bast stackglue" |
80 | .pv_major = OCFS2_LOCKING_PROTOCOL_MAJOR, | 91 | extern int param_set_dlmfs_capabilities(const char *val, |
81 | .pv_minor = OCFS2_LOCKING_PROTOCOL_MINOR, | 92 | struct kernel_param *kp) |
82 | }; | 93 | { |
94 | printk(KERN_ERR "%s: readonly parameter\n", kp->name); | ||
95 | return -EINVAL; | ||
96 | } | ||
97 | static int param_get_dlmfs_capabilities(char *buffer, | ||
98 | struct kernel_param *kp) | ||
99 | { | ||
100 | return strlcpy(buffer, DLMFS_CAPABILITIES, | ||
101 | strlen(DLMFS_CAPABILITIES) + 1); | ||
102 | } | ||
103 | module_param_call(capabilities, param_set_dlmfs_capabilities, | ||
104 | param_get_dlmfs_capabilities, NULL, 0444); | ||
105 | MODULE_PARM_DESC(capabilities, DLMFS_CAPABILITIES); | ||
106 | |||
83 | 107 | ||
84 | /* | 108 | /* |
85 | * decodes a set of open flags into a valid lock level and a set of flags. | 109 | * decodes a set of open flags into a valid lock level and a set of flags. |
@@ -179,13 +203,46 @@ static int dlmfs_file_release(struct inode *inode, | |||
179 | return 0; | 203 | return 0; |
180 | } | 204 | } |
181 | 205 | ||
206 | /* | ||
207 | * We do ->setattr() just to override size changes. Our size is the size | ||
208 | * of the LVB and nothing else. | ||
209 | */ | ||
210 | static int dlmfs_file_setattr(struct dentry *dentry, struct iattr *attr) | ||
211 | { | ||
212 | int error; | ||
213 | struct inode *inode = dentry->d_inode; | ||
214 | |||
215 | attr->ia_valid &= ~ATTR_SIZE; | ||
216 | error = inode_change_ok(inode, attr); | ||
217 | if (!error) | ||
218 | error = inode_setattr(inode, attr); | ||
219 | |||
220 | return error; | ||
221 | } | ||
222 | |||
223 | static unsigned int dlmfs_file_poll(struct file *file, poll_table *wait) | ||
224 | { | ||
225 | int event = 0; | ||
226 | struct inode *inode = file->f_path.dentry->d_inode; | ||
227 | struct dlmfs_inode_private *ip = DLMFS_I(inode); | ||
228 | |||
229 | poll_wait(file, &ip->ip_lockres.l_event, wait); | ||
230 | |||
231 | spin_lock(&ip->ip_lockres.l_lock); | ||
232 | if (ip->ip_lockres.l_flags & USER_LOCK_BLOCKED) | ||
233 | event = POLLIN | POLLRDNORM; | ||
234 | spin_unlock(&ip->ip_lockres.l_lock); | ||
235 | |||
236 | return event; | ||
237 | } | ||
238 | |||
182 | static ssize_t dlmfs_file_read(struct file *filp, | 239 | static ssize_t dlmfs_file_read(struct file *filp, |
183 | char __user *buf, | 240 | char __user *buf, |
184 | size_t count, | 241 | size_t count, |
185 | loff_t *ppos) | 242 | loff_t *ppos) |
186 | { | 243 | { |
187 | int bytes_left; | 244 | int bytes_left; |
188 | ssize_t readlen; | 245 | ssize_t readlen, got; |
189 | char *lvb_buf; | 246 | char *lvb_buf; |
190 | struct inode *inode = filp->f_path.dentry->d_inode; | 247 | struct inode *inode = filp->f_path.dentry->d_inode; |
191 | 248 | ||
@@ -211,9 +268,13 @@ static ssize_t dlmfs_file_read(struct file *filp, | |||
211 | if (!lvb_buf) | 268 | if (!lvb_buf) |
212 | return -ENOMEM; | 269 | return -ENOMEM; |
213 | 270 | ||
214 | user_dlm_read_lvb(inode, lvb_buf, readlen); | 271 | got = user_dlm_read_lvb(inode, lvb_buf, readlen); |
215 | bytes_left = __copy_to_user(buf, lvb_buf, readlen); | 272 | if (got) { |
216 | readlen -= bytes_left; | 273 | BUG_ON(got != readlen); |
274 | bytes_left = __copy_to_user(buf, lvb_buf, readlen); | ||
275 | readlen -= bytes_left; | ||
276 | } else | ||
277 | readlen = 0; | ||
217 | 278 | ||
218 | kfree(lvb_buf); | 279 | kfree(lvb_buf); |
219 | 280 | ||
@@ -272,7 +333,7 @@ static void dlmfs_init_once(void *foo) | |||
272 | struct dlmfs_inode_private *ip = | 333 | struct dlmfs_inode_private *ip = |
273 | (struct dlmfs_inode_private *) foo; | 334 | (struct dlmfs_inode_private *) foo; |
274 | 335 | ||
275 | ip->ip_dlm = NULL; | 336 | ip->ip_conn = NULL; |
276 | ip->ip_parent = NULL; | 337 | ip->ip_parent = NULL; |
277 | 338 | ||
278 | inode_init_once(&ip->ip_vfs_inode); | 339 | inode_init_once(&ip->ip_vfs_inode); |
@@ -314,14 +375,14 @@ static void dlmfs_clear_inode(struct inode *inode) | |||
314 | goto clear_fields; | 375 | goto clear_fields; |
315 | } | 376 | } |
316 | 377 | ||
317 | mlog(0, "we're a directory, ip->ip_dlm = 0x%p\n", ip->ip_dlm); | 378 | mlog(0, "we're a directory, ip->ip_conn = 0x%p\n", ip->ip_conn); |
318 | /* we must be a directory. If required, lets unregister the | 379 | /* we must be a directory. If required, lets unregister the |
319 | * dlm context now. */ | 380 | * dlm context now. */ |
320 | if (ip->ip_dlm) | 381 | if (ip->ip_conn) |
321 | user_dlm_unregister_context(ip->ip_dlm); | 382 | user_dlm_unregister(ip->ip_conn); |
322 | clear_fields: | 383 | clear_fields: |
323 | ip->ip_parent = NULL; | 384 | ip->ip_parent = NULL; |
324 | ip->ip_dlm = NULL; | 385 | ip->ip_conn = NULL; |
325 | } | 386 | } |
326 | 387 | ||
327 | static struct backing_dev_info dlmfs_backing_dev_info = { | 388 | static struct backing_dev_info dlmfs_backing_dev_info = { |
@@ -371,7 +432,7 @@ static struct inode *dlmfs_get_inode(struct inode *parent, | |||
371 | inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; | 432 | inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; |
372 | 433 | ||
373 | ip = DLMFS_I(inode); | 434 | ip = DLMFS_I(inode); |
374 | ip->ip_dlm = DLMFS_I(parent)->ip_dlm; | 435 | ip->ip_conn = DLMFS_I(parent)->ip_conn; |
375 | 436 | ||
376 | switch (mode & S_IFMT) { | 437 | switch (mode & S_IFMT) { |
377 | default: | 438 | default: |
@@ -425,13 +486,12 @@ static int dlmfs_mkdir(struct inode * dir, | |||
425 | struct inode *inode = NULL; | 486 | struct inode *inode = NULL; |
426 | struct qstr *domain = &dentry->d_name; | 487 | struct qstr *domain = &dentry->d_name; |
427 | struct dlmfs_inode_private *ip; | 488 | struct dlmfs_inode_private *ip; |
428 | struct dlm_ctxt *dlm; | 489 | struct ocfs2_cluster_connection *conn; |
429 | struct dlm_protocol_version proto = user_locking_protocol; | ||
430 | 490 | ||
431 | mlog(0, "mkdir %.*s\n", domain->len, domain->name); | 491 | mlog(0, "mkdir %.*s\n", domain->len, domain->name); |
432 | 492 | ||
433 | /* verify that we have a proper domain */ | 493 | /* verify that we have a proper domain */ |
434 | if (domain->len >= O2NM_MAX_NAME_LEN) { | 494 | if (domain->len >= GROUP_NAME_MAX) { |
435 | status = -EINVAL; | 495 | status = -EINVAL; |
436 | mlog(ML_ERROR, "invalid domain name for directory.\n"); | 496 | mlog(ML_ERROR, "invalid domain name for directory.\n"); |
437 | goto bail; | 497 | goto bail; |
@@ -446,14 +506,14 @@ static int dlmfs_mkdir(struct inode * dir, | |||
446 | 506 | ||
447 | ip = DLMFS_I(inode); | 507 | ip = DLMFS_I(inode); |
448 | 508 | ||
449 | dlm = user_dlm_register_context(domain, &proto); | 509 | conn = user_dlm_register(domain); |
450 | if (IS_ERR(dlm)) { | 510 | if (IS_ERR(conn)) { |
451 | status = PTR_ERR(dlm); | 511 | status = PTR_ERR(conn); |
452 | mlog(ML_ERROR, "Error %d could not register domain \"%.*s\"\n", | 512 | mlog(ML_ERROR, "Error %d could not register domain \"%.*s\"\n", |
453 | status, domain->len, domain->name); | 513 | status, domain->len, domain->name); |
454 | goto bail; | 514 | goto bail; |
455 | } | 515 | } |
456 | ip->ip_dlm = dlm; | 516 | ip->ip_conn = conn; |
457 | 517 | ||
458 | inc_nlink(dir); | 518 | inc_nlink(dir); |
459 | d_instantiate(dentry, inode); | 519 | d_instantiate(dentry, inode); |
@@ -549,6 +609,7 @@ static int dlmfs_fill_super(struct super_block * sb, | |||
549 | static const struct file_operations dlmfs_file_operations = { | 609 | static const struct file_operations dlmfs_file_operations = { |
550 | .open = dlmfs_file_open, | 610 | .open = dlmfs_file_open, |
551 | .release = dlmfs_file_release, | 611 | .release = dlmfs_file_release, |
612 | .poll = dlmfs_file_poll, | ||
552 | .read = dlmfs_file_read, | 613 | .read = dlmfs_file_read, |
553 | .write = dlmfs_file_write, | 614 | .write = dlmfs_file_write, |
554 | }; | 615 | }; |
@@ -576,6 +637,7 @@ static const struct super_operations dlmfs_ops = { | |||
576 | 637 | ||
577 | static const struct inode_operations dlmfs_file_inode_operations = { | 638 | static const struct inode_operations dlmfs_file_inode_operations = { |
578 | .getattr = simple_getattr, | 639 | .getattr = simple_getattr, |
640 | .setattr = dlmfs_file_setattr, | ||
579 | }; | 641 | }; |
580 | 642 | ||
581 | static int dlmfs_get_sb(struct file_system_type *fs_type, | 643 | static int dlmfs_get_sb(struct file_system_type *fs_type, |
@@ -620,6 +682,7 @@ static int __init init_dlmfs_fs(void) | |||
620 | } | 682 | } |
621 | cleanup_worker = 1; | 683 | cleanup_worker = 1; |
622 | 684 | ||
685 | user_dlm_set_locking_protocol(); | ||
623 | status = register_filesystem(&dlmfs_fs_type); | 686 | status = register_filesystem(&dlmfs_fs_type); |
624 | bail: | 687 | bail: |
625 | if (status) { | 688 | if (status) { |
diff --git a/fs/ocfs2/dlm/dlmfsver.c b/fs/ocfs2/dlmfs/dlmfsver.c index a733b3321f83..a733b3321f83 100644 --- a/fs/ocfs2/dlm/dlmfsver.c +++ b/fs/ocfs2/dlmfs/dlmfsver.c | |||
diff --git a/fs/ocfs2/dlm/dlmfsver.h b/fs/ocfs2/dlmfs/dlmfsver.h index f35eadbed25c..f35eadbed25c 100644 --- a/fs/ocfs2/dlm/dlmfsver.h +++ b/fs/ocfs2/dlmfs/dlmfsver.h | |||
diff --git a/fs/ocfs2/dlm/userdlm.c b/fs/ocfs2/dlmfs/userdlm.c index 4cb1d3dae250..0499e3fb7bdb 100644 --- a/fs/ocfs2/dlm/userdlm.c +++ b/fs/ocfs2/dlmfs/userdlm.c | |||
@@ -34,18 +34,19 @@ | |||
34 | #include <linux/types.h> | 34 | #include <linux/types.h> |
35 | #include <linux/crc32.h> | 35 | #include <linux/crc32.h> |
36 | 36 | ||
37 | 37 | #include "ocfs2_lockingver.h" | |
38 | #include "cluster/nodemanager.h" | 38 | #include "stackglue.h" |
39 | #include "cluster/heartbeat.h" | ||
40 | #include "cluster/tcp.h" | ||
41 | |||
42 | #include "dlmapi.h" | ||
43 | |||
44 | #include "userdlm.h" | 39 | #include "userdlm.h" |
45 | 40 | ||
46 | #define MLOG_MASK_PREFIX ML_DLMFS | 41 | #define MLOG_MASK_PREFIX ML_DLMFS |
47 | #include "cluster/masklog.h" | 42 | #include "cluster/masklog.h" |
48 | 43 | ||
44 | |||
45 | static inline struct user_lock_res *user_lksb_to_lock_res(struct ocfs2_dlm_lksb *lksb) | ||
46 | { | ||
47 | return container_of(lksb, struct user_lock_res, l_lksb); | ||
48 | } | ||
49 | |||
49 | static inline int user_check_wait_flag(struct user_lock_res *lockres, | 50 | static inline int user_check_wait_flag(struct user_lock_res *lockres, |
50 | int flag) | 51 | int flag) |
51 | { | 52 | { |
@@ -73,15 +74,15 @@ static inline void user_wait_on_blocked_lock(struct user_lock_res *lockres) | |||
73 | } | 74 | } |
74 | 75 | ||
75 | /* I heart container_of... */ | 76 | /* I heart container_of... */ |
76 | static inline struct dlm_ctxt * | 77 | static inline struct ocfs2_cluster_connection * |
77 | dlm_ctxt_from_user_lockres(struct user_lock_res *lockres) | 78 | cluster_connection_from_user_lockres(struct user_lock_res *lockres) |
78 | { | 79 | { |
79 | struct dlmfs_inode_private *ip; | 80 | struct dlmfs_inode_private *ip; |
80 | 81 | ||
81 | ip = container_of(lockres, | 82 | ip = container_of(lockres, |
82 | struct dlmfs_inode_private, | 83 | struct dlmfs_inode_private, |
83 | ip_lockres); | 84 | ip_lockres); |
84 | return ip->ip_dlm; | 85 | return ip->ip_conn; |
85 | } | 86 | } |
86 | 87 | ||
87 | static struct inode * | 88 | static struct inode * |
@@ -103,9 +104,9 @@ static inline void user_recover_from_dlm_error(struct user_lock_res *lockres) | |||
103 | } | 104 | } |
104 | 105 | ||
105 | #define user_log_dlm_error(_func, _stat, _lockres) do { \ | 106 | #define user_log_dlm_error(_func, _stat, _lockres) do { \ |
106 | mlog(ML_ERROR, "Dlm error \"%s\" while calling %s on " \ | 107 | mlog(ML_ERROR, "Dlm error %d while calling %s on " \ |
107 | "resource %.*s: %s\n", dlm_errname(_stat), _func, \ | 108 | "resource %.*s\n", _stat, _func, \ |
108 | _lockres->l_namelen, _lockres->l_name, dlm_errmsg(_stat)); \ | 109 | _lockres->l_namelen, _lockres->l_name); \ |
109 | } while (0) | 110 | } while (0) |
110 | 111 | ||
111 | /* WARNING: This function lives in a world where the only three lock | 112 | /* WARNING: This function lives in a world where the only three lock |
@@ -113,34 +114,35 @@ static inline void user_recover_from_dlm_error(struct user_lock_res *lockres) | |||
113 | * lock types are added. */ | 114 | * lock types are added. */ |
114 | static inline int user_highest_compat_lock_level(int level) | 115 | static inline int user_highest_compat_lock_level(int level) |
115 | { | 116 | { |
116 | int new_level = LKM_EXMODE; | 117 | int new_level = DLM_LOCK_EX; |
117 | 118 | ||
118 | if (level == LKM_EXMODE) | 119 | if (level == DLM_LOCK_EX) |
119 | new_level = LKM_NLMODE; | 120 | new_level = DLM_LOCK_NL; |
120 | else if (level == LKM_PRMODE) | 121 | else if (level == DLM_LOCK_PR) |
121 | new_level = LKM_PRMODE; | 122 | new_level = DLM_LOCK_PR; |
122 | return new_level; | 123 | return new_level; |
123 | } | 124 | } |
124 | 125 | ||
125 | static void user_ast(void *opaque) | 126 | static void user_ast(struct ocfs2_dlm_lksb *lksb) |
126 | { | 127 | { |
127 | struct user_lock_res *lockres = opaque; | 128 | struct user_lock_res *lockres = user_lksb_to_lock_res(lksb); |
128 | struct dlm_lockstatus *lksb; | 129 | int status; |
129 | 130 | ||
130 | mlog(0, "AST fired for lockres %.*s\n", lockres->l_namelen, | 131 | mlog(ML_BASTS, "AST fired for lockres %.*s, level %d => %d\n", |
131 | lockres->l_name); | 132 | lockres->l_namelen, lockres->l_name, lockres->l_level, |
133 | lockres->l_requested); | ||
132 | 134 | ||
133 | spin_lock(&lockres->l_lock); | 135 | spin_lock(&lockres->l_lock); |
134 | 136 | ||
135 | lksb = &(lockres->l_lksb); | 137 | status = ocfs2_dlm_lock_status(&lockres->l_lksb); |
136 | if (lksb->status != DLM_NORMAL) { | 138 | if (status) { |
137 | mlog(ML_ERROR, "lksb status value of %u on lockres %.*s\n", | 139 | mlog(ML_ERROR, "lksb status value of %u on lockres %.*s\n", |
138 | lksb->status, lockres->l_namelen, lockres->l_name); | 140 | status, lockres->l_namelen, lockres->l_name); |
139 | spin_unlock(&lockres->l_lock); | 141 | spin_unlock(&lockres->l_lock); |
140 | return; | 142 | return; |
141 | } | 143 | } |
142 | 144 | ||
143 | mlog_bug_on_msg(lockres->l_requested == LKM_IVMODE, | 145 | mlog_bug_on_msg(lockres->l_requested == DLM_LOCK_IV, |
144 | "Lockres %.*s, requested ivmode. flags 0x%x\n", | 146 | "Lockres %.*s, requested ivmode. flags 0x%x\n", |
145 | lockres->l_namelen, lockres->l_name, lockres->l_flags); | 147 | lockres->l_namelen, lockres->l_name, lockres->l_flags); |
146 | 148 | ||
@@ -148,13 +150,13 @@ static void user_ast(void *opaque) | |||
148 | if (lockres->l_requested < lockres->l_level) { | 150 | if (lockres->l_requested < lockres->l_level) { |
149 | if (lockres->l_requested <= | 151 | if (lockres->l_requested <= |
150 | user_highest_compat_lock_level(lockres->l_blocking)) { | 152 | user_highest_compat_lock_level(lockres->l_blocking)) { |
151 | lockres->l_blocking = LKM_NLMODE; | 153 | lockres->l_blocking = DLM_LOCK_NL; |
152 | lockres->l_flags &= ~USER_LOCK_BLOCKED; | 154 | lockres->l_flags &= ~USER_LOCK_BLOCKED; |
153 | } | 155 | } |
154 | } | 156 | } |
155 | 157 | ||
156 | lockres->l_level = lockres->l_requested; | 158 | lockres->l_level = lockres->l_requested; |
157 | lockres->l_requested = LKM_IVMODE; | 159 | lockres->l_requested = DLM_LOCK_IV; |
158 | lockres->l_flags |= USER_LOCK_ATTACHED; | 160 | lockres->l_flags |= USER_LOCK_ATTACHED; |
159 | lockres->l_flags &= ~USER_LOCK_BUSY; | 161 | lockres->l_flags &= ~USER_LOCK_BUSY; |
160 | 162 | ||
@@ -193,11 +195,11 @@ static void __user_dlm_cond_queue_lockres(struct user_lock_res *lockres) | |||
193 | return; | 195 | return; |
194 | 196 | ||
195 | switch (lockres->l_blocking) { | 197 | switch (lockres->l_blocking) { |
196 | case LKM_EXMODE: | 198 | case DLM_LOCK_EX: |
197 | if (!lockres->l_ex_holders && !lockres->l_ro_holders) | 199 | if (!lockres->l_ex_holders && !lockres->l_ro_holders) |
198 | queue = 1; | 200 | queue = 1; |
199 | break; | 201 | break; |
200 | case LKM_PRMODE: | 202 | case DLM_LOCK_PR: |
201 | if (!lockres->l_ex_holders) | 203 | if (!lockres->l_ex_holders) |
202 | queue = 1; | 204 | queue = 1; |
203 | break; | 205 | break; |
@@ -209,12 +211,12 @@ static void __user_dlm_cond_queue_lockres(struct user_lock_res *lockres) | |||
209 | __user_dlm_queue_lockres(lockres); | 211 | __user_dlm_queue_lockres(lockres); |
210 | } | 212 | } |
211 | 213 | ||
212 | static void user_bast(void *opaque, int level) | 214 | static void user_bast(struct ocfs2_dlm_lksb *lksb, int level) |
213 | { | 215 | { |
214 | struct user_lock_res *lockres = opaque; | 216 | struct user_lock_res *lockres = user_lksb_to_lock_res(lksb); |
215 | 217 | ||
216 | mlog(0, "Blocking AST fired for lockres %.*s. Blocking level %d\n", | 218 | mlog(ML_BASTS, "BAST fired for lockres %.*s, blocking %d, level %d\n", |
217 | lockres->l_namelen, lockres->l_name, level); | 219 | lockres->l_namelen, lockres->l_name, level, lockres->l_level); |
218 | 220 | ||
219 | spin_lock(&lockres->l_lock); | 221 | spin_lock(&lockres->l_lock); |
220 | lockres->l_flags |= USER_LOCK_BLOCKED; | 222 | lockres->l_flags |= USER_LOCK_BLOCKED; |
@@ -227,15 +229,15 @@ static void user_bast(void *opaque, int level) | |||
227 | wake_up(&lockres->l_event); | 229 | wake_up(&lockres->l_event); |
228 | } | 230 | } |
229 | 231 | ||
230 | static void user_unlock_ast(void *opaque, enum dlm_status status) | 232 | static void user_unlock_ast(struct ocfs2_dlm_lksb *lksb, int status) |
231 | { | 233 | { |
232 | struct user_lock_res *lockres = opaque; | 234 | struct user_lock_res *lockres = user_lksb_to_lock_res(lksb); |
233 | 235 | ||
234 | mlog(0, "UNLOCK AST called on lock %.*s\n", lockres->l_namelen, | 236 | mlog(ML_BASTS, "UNLOCK AST fired for lockres %.*s, flags 0x%x\n", |
235 | lockres->l_name); | 237 | lockres->l_namelen, lockres->l_name, lockres->l_flags); |
236 | 238 | ||
237 | if (status != DLM_NORMAL && status != DLM_CANCELGRANT) | 239 | if (status) |
238 | mlog(ML_ERROR, "Dlm returns status %d\n", status); | 240 | mlog(ML_ERROR, "dlm returns status %d\n", status); |
239 | 241 | ||
240 | spin_lock(&lockres->l_lock); | 242 | spin_lock(&lockres->l_lock); |
241 | /* The teardown flag gets set early during the unlock process, | 243 | /* The teardown flag gets set early during the unlock process, |
@@ -243,7 +245,7 @@ static void user_unlock_ast(void *opaque, enum dlm_status status) | |||
243 | * for a concurrent cancel. */ | 245 | * for a concurrent cancel. */ |
244 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN | 246 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN |
245 | && !(lockres->l_flags & USER_LOCK_IN_CANCEL)) { | 247 | && !(lockres->l_flags & USER_LOCK_IN_CANCEL)) { |
246 | lockres->l_level = LKM_IVMODE; | 248 | lockres->l_level = DLM_LOCK_IV; |
247 | } else if (status == DLM_CANCELGRANT) { | 249 | } else if (status == DLM_CANCELGRANT) { |
248 | /* We tried to cancel a convert request, but it was | 250 | /* We tried to cancel a convert request, but it was |
249 | * already granted. Don't clear the busy flag - the | 251 | * already granted. Don't clear the busy flag - the |
@@ -254,7 +256,7 @@ static void user_unlock_ast(void *opaque, enum dlm_status status) | |||
254 | } else { | 256 | } else { |
255 | BUG_ON(!(lockres->l_flags & USER_LOCK_IN_CANCEL)); | 257 | BUG_ON(!(lockres->l_flags & USER_LOCK_IN_CANCEL)); |
256 | /* Cancel succeeded, we want to re-queue */ | 258 | /* Cancel succeeded, we want to re-queue */ |
257 | lockres->l_requested = LKM_IVMODE; /* cancel an | 259 | lockres->l_requested = DLM_LOCK_IV; /* cancel an |
258 | * upconvert | 260 | * upconvert |
259 | * request. */ | 261 | * request. */ |
260 | lockres->l_flags &= ~USER_LOCK_IN_CANCEL; | 262 | lockres->l_flags &= ~USER_LOCK_IN_CANCEL; |
@@ -271,6 +273,21 @@ out_noclear: | |||
271 | wake_up(&lockres->l_event); | 273 | wake_up(&lockres->l_event); |
272 | } | 274 | } |
273 | 275 | ||
276 | /* | ||
277 | * This is the userdlmfs locking protocol version. | ||
278 | * | ||
279 | * See fs/ocfs2/dlmglue.c for more details on locking versions. | ||
280 | */ | ||
281 | static struct ocfs2_locking_protocol user_dlm_lproto = { | ||
282 | .lp_max_version = { | ||
283 | .pv_major = OCFS2_LOCKING_PROTOCOL_MAJOR, | ||
284 | .pv_minor = OCFS2_LOCKING_PROTOCOL_MINOR, | ||
285 | }, | ||
286 | .lp_lock_ast = user_ast, | ||
287 | .lp_blocking_ast = user_bast, | ||
288 | .lp_unlock_ast = user_unlock_ast, | ||
289 | }; | ||
290 | |||
274 | static inline void user_dlm_drop_inode_ref(struct user_lock_res *lockres) | 291 | static inline void user_dlm_drop_inode_ref(struct user_lock_res *lockres) |
275 | { | 292 | { |
276 | struct inode *inode; | 293 | struct inode *inode; |
@@ -283,10 +300,10 @@ static void user_dlm_unblock_lock(struct work_struct *work) | |||
283 | int new_level, status; | 300 | int new_level, status; |
284 | struct user_lock_res *lockres = | 301 | struct user_lock_res *lockres = |
285 | container_of(work, struct user_lock_res, l_work); | 302 | container_of(work, struct user_lock_res, l_work); |
286 | struct dlm_ctxt *dlm = dlm_ctxt_from_user_lockres(lockres); | 303 | struct ocfs2_cluster_connection *conn = |
304 | cluster_connection_from_user_lockres(lockres); | ||
287 | 305 | ||
288 | mlog(0, "processing lockres %.*s\n", lockres->l_namelen, | 306 | mlog(0, "lockres %.*s\n", lockres->l_namelen, lockres->l_name); |
289 | lockres->l_name); | ||
290 | 307 | ||
291 | spin_lock(&lockres->l_lock); | 308 | spin_lock(&lockres->l_lock); |
292 | 309 | ||
@@ -304,17 +321,23 @@ static void user_dlm_unblock_lock(struct work_struct *work) | |||
304 | * flag, and finally we might get another bast which re-queues | 321 | * flag, and finally we might get another bast which re-queues |
305 | * us before our ast for the downconvert is called. */ | 322 | * us before our ast for the downconvert is called. */ |
306 | if (!(lockres->l_flags & USER_LOCK_BLOCKED)) { | 323 | if (!(lockres->l_flags & USER_LOCK_BLOCKED)) { |
324 | mlog(ML_BASTS, "lockres %.*s USER_LOCK_BLOCKED\n", | ||
325 | lockres->l_namelen, lockres->l_name); | ||
307 | spin_unlock(&lockres->l_lock); | 326 | spin_unlock(&lockres->l_lock); |
308 | goto drop_ref; | 327 | goto drop_ref; |
309 | } | 328 | } |
310 | 329 | ||
311 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN) { | 330 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN) { |
331 | mlog(ML_BASTS, "lockres %.*s USER_LOCK_IN_TEARDOWN\n", | ||
332 | lockres->l_namelen, lockres->l_name); | ||
312 | spin_unlock(&lockres->l_lock); | 333 | spin_unlock(&lockres->l_lock); |
313 | goto drop_ref; | 334 | goto drop_ref; |
314 | } | 335 | } |
315 | 336 | ||
316 | if (lockres->l_flags & USER_LOCK_BUSY) { | 337 | if (lockres->l_flags & USER_LOCK_BUSY) { |
317 | if (lockres->l_flags & USER_LOCK_IN_CANCEL) { | 338 | if (lockres->l_flags & USER_LOCK_IN_CANCEL) { |
339 | mlog(ML_BASTS, "lockres %.*s USER_LOCK_IN_CANCEL\n", | ||
340 | lockres->l_namelen, lockres->l_name); | ||
318 | spin_unlock(&lockres->l_lock); | 341 | spin_unlock(&lockres->l_lock); |
319 | goto drop_ref; | 342 | goto drop_ref; |
320 | } | 343 | } |
@@ -322,32 +345,31 @@ static void user_dlm_unblock_lock(struct work_struct *work) | |||
322 | lockres->l_flags |= USER_LOCK_IN_CANCEL; | 345 | lockres->l_flags |= USER_LOCK_IN_CANCEL; |
323 | spin_unlock(&lockres->l_lock); | 346 | spin_unlock(&lockres->l_lock); |
324 | 347 | ||
325 | status = dlmunlock(dlm, | 348 | status = ocfs2_dlm_unlock(conn, &lockres->l_lksb, |
326 | &lockres->l_lksb, | 349 | DLM_LKF_CANCEL); |
327 | LKM_CANCEL, | 350 | if (status) |
328 | user_unlock_ast, | 351 | user_log_dlm_error("ocfs2_dlm_unlock", status, lockres); |
329 | lockres); | ||
330 | if (status != DLM_NORMAL) | ||
331 | user_log_dlm_error("dlmunlock", status, lockres); | ||
332 | goto drop_ref; | 352 | goto drop_ref; |
333 | } | 353 | } |
334 | 354 | ||
335 | /* If there are still incompat holders, we can exit safely | 355 | /* If there are still incompat holders, we can exit safely |
336 | * without worrying about re-queueing this lock as that will | 356 | * without worrying about re-queueing this lock as that will |
337 | * happen on the last call to user_cluster_unlock. */ | 357 | * happen on the last call to user_cluster_unlock. */ |
338 | if ((lockres->l_blocking == LKM_EXMODE) | 358 | if ((lockres->l_blocking == DLM_LOCK_EX) |
339 | && (lockres->l_ex_holders || lockres->l_ro_holders)) { | 359 | && (lockres->l_ex_holders || lockres->l_ro_holders)) { |
340 | spin_unlock(&lockres->l_lock); | 360 | spin_unlock(&lockres->l_lock); |
341 | mlog(0, "can't downconvert for ex: ro = %u, ex = %u\n", | 361 | mlog(ML_BASTS, "lockres %.*s, EX/PR Holders %u,%u\n", |
342 | lockres->l_ro_holders, lockres->l_ex_holders); | 362 | lockres->l_namelen, lockres->l_name, |
363 | lockres->l_ex_holders, lockres->l_ro_holders); | ||
343 | goto drop_ref; | 364 | goto drop_ref; |
344 | } | 365 | } |
345 | 366 | ||
346 | if ((lockres->l_blocking == LKM_PRMODE) | 367 | if ((lockres->l_blocking == DLM_LOCK_PR) |
347 | && lockres->l_ex_holders) { | 368 | && lockres->l_ex_holders) { |
348 | spin_unlock(&lockres->l_lock); | 369 | spin_unlock(&lockres->l_lock); |
349 | mlog(0, "can't downconvert for pr: ex = %u\n", | 370 | mlog(ML_BASTS, "lockres %.*s, EX Holders %u\n", |
350 | lockres->l_ex_holders); | 371 | lockres->l_namelen, lockres->l_name, |
372 | lockres->l_ex_holders); | ||
351 | goto drop_ref; | 373 | goto drop_ref; |
352 | } | 374 | } |
353 | 375 | ||
@@ -355,22 +377,17 @@ static void user_dlm_unblock_lock(struct work_struct *work) | |||
355 | new_level = user_highest_compat_lock_level(lockres->l_blocking); | 377 | new_level = user_highest_compat_lock_level(lockres->l_blocking); |
356 | lockres->l_requested = new_level; | 378 | lockres->l_requested = new_level; |
357 | lockres->l_flags |= USER_LOCK_BUSY; | 379 | lockres->l_flags |= USER_LOCK_BUSY; |
358 | mlog(0, "Downconvert lock from %d to %d\n", | 380 | mlog(ML_BASTS, "lockres %.*s, downconvert %d => %d\n", |
359 | lockres->l_level, new_level); | 381 | lockres->l_namelen, lockres->l_name, lockres->l_level, new_level); |
360 | spin_unlock(&lockres->l_lock); | 382 | spin_unlock(&lockres->l_lock); |
361 | 383 | ||
362 | /* need lock downconvert request now... */ | 384 | /* need lock downconvert request now... */ |
363 | status = dlmlock(dlm, | 385 | status = ocfs2_dlm_lock(conn, new_level, &lockres->l_lksb, |
364 | new_level, | 386 | DLM_LKF_CONVERT|DLM_LKF_VALBLK, |
365 | &lockres->l_lksb, | 387 | lockres->l_name, |
366 | LKM_CONVERT|LKM_VALBLK, | 388 | lockres->l_namelen); |
367 | lockres->l_name, | 389 | if (status) { |
368 | lockres->l_namelen, | 390 | user_log_dlm_error("ocfs2_dlm_lock", status, lockres); |
369 | user_ast, | ||
370 | lockres, | ||
371 | user_bast); | ||
372 | if (status != DLM_NORMAL) { | ||
373 | user_log_dlm_error("dlmlock", status, lockres); | ||
374 | user_recover_from_dlm_error(lockres); | 391 | user_recover_from_dlm_error(lockres); |
375 | } | 392 | } |
376 | 393 | ||
@@ -382,10 +399,10 @@ static inline void user_dlm_inc_holders(struct user_lock_res *lockres, | |||
382 | int level) | 399 | int level) |
383 | { | 400 | { |
384 | switch(level) { | 401 | switch(level) { |
385 | case LKM_EXMODE: | 402 | case DLM_LOCK_EX: |
386 | lockres->l_ex_holders++; | 403 | lockres->l_ex_holders++; |
387 | break; | 404 | break; |
388 | case LKM_PRMODE: | 405 | case DLM_LOCK_PR: |
389 | lockres->l_ro_holders++; | 406 | lockres->l_ro_holders++; |
390 | break; | 407 | break; |
391 | default: | 408 | default: |
@@ -410,20 +427,19 @@ int user_dlm_cluster_lock(struct user_lock_res *lockres, | |||
410 | int lkm_flags) | 427 | int lkm_flags) |
411 | { | 428 | { |
412 | int status, local_flags; | 429 | int status, local_flags; |
413 | struct dlm_ctxt *dlm = dlm_ctxt_from_user_lockres(lockres); | 430 | struct ocfs2_cluster_connection *conn = |
431 | cluster_connection_from_user_lockres(lockres); | ||
414 | 432 | ||
415 | if (level != LKM_EXMODE && | 433 | if (level != DLM_LOCK_EX && |
416 | level != LKM_PRMODE) { | 434 | level != DLM_LOCK_PR) { |
417 | mlog(ML_ERROR, "lockres %.*s: invalid request!\n", | 435 | mlog(ML_ERROR, "lockres %.*s: invalid request!\n", |
418 | lockres->l_namelen, lockres->l_name); | 436 | lockres->l_namelen, lockres->l_name); |
419 | status = -EINVAL; | 437 | status = -EINVAL; |
420 | goto bail; | 438 | goto bail; |
421 | } | 439 | } |
422 | 440 | ||
423 | mlog(0, "lockres %.*s: asking for %s lock, passed flags = 0x%x\n", | 441 | mlog(ML_BASTS, "lockres %.*s, level %d, flags = 0x%x\n", |
424 | lockres->l_namelen, lockres->l_name, | 442 | lockres->l_namelen, lockres->l_name, level, lkm_flags); |
425 | (level == LKM_EXMODE) ? "LKM_EXMODE" : "LKM_PRMODE", | ||
426 | lkm_flags); | ||
427 | 443 | ||
428 | again: | 444 | again: |
429 | if (signal_pending(current)) { | 445 | if (signal_pending(current)) { |
@@ -457,35 +473,26 @@ again: | |||
457 | } | 473 | } |
458 | 474 | ||
459 | if (level > lockres->l_level) { | 475 | if (level > lockres->l_level) { |
460 | local_flags = lkm_flags | LKM_VALBLK; | 476 | local_flags = lkm_flags | DLM_LKF_VALBLK; |
461 | if (lockres->l_level != LKM_IVMODE) | 477 | if (lockres->l_level != DLM_LOCK_IV) |
462 | local_flags |= LKM_CONVERT; | 478 | local_flags |= DLM_LKF_CONVERT; |
463 | 479 | ||
464 | lockres->l_requested = level; | 480 | lockres->l_requested = level; |
465 | lockres->l_flags |= USER_LOCK_BUSY; | 481 | lockres->l_flags |= USER_LOCK_BUSY; |
466 | spin_unlock(&lockres->l_lock); | 482 | spin_unlock(&lockres->l_lock); |
467 | 483 | ||
468 | BUG_ON(level == LKM_IVMODE); | 484 | BUG_ON(level == DLM_LOCK_IV); |
469 | BUG_ON(level == LKM_NLMODE); | 485 | BUG_ON(level == DLM_LOCK_NL); |
470 | 486 | ||
471 | /* call dlm_lock to upgrade lock now */ | 487 | /* call dlm_lock to upgrade lock now */ |
472 | status = dlmlock(dlm, | 488 | status = ocfs2_dlm_lock(conn, level, &lockres->l_lksb, |
473 | level, | 489 | local_flags, lockres->l_name, |
474 | &lockres->l_lksb, | 490 | lockres->l_namelen); |
475 | local_flags, | 491 | if (status) { |
476 | lockres->l_name, | 492 | if ((lkm_flags & DLM_LKF_NOQUEUE) && |
477 | lockres->l_namelen, | 493 | (status != -EAGAIN)) |
478 | user_ast, | 494 | user_log_dlm_error("ocfs2_dlm_lock", |
479 | lockres, | 495 | status, lockres); |
480 | user_bast); | ||
481 | if (status != DLM_NORMAL) { | ||
482 | if ((lkm_flags & LKM_NOQUEUE) && | ||
483 | (status == DLM_NOTQUEUED)) | ||
484 | status = -EAGAIN; | ||
485 | else { | ||
486 | user_log_dlm_error("dlmlock", status, lockres); | ||
487 | status = -EINVAL; | ||
488 | } | ||
489 | user_recover_from_dlm_error(lockres); | 496 | user_recover_from_dlm_error(lockres); |
490 | goto bail; | 497 | goto bail; |
491 | } | 498 | } |
@@ -506,11 +513,11 @@ static inline void user_dlm_dec_holders(struct user_lock_res *lockres, | |||
506 | int level) | 513 | int level) |
507 | { | 514 | { |
508 | switch(level) { | 515 | switch(level) { |
509 | case LKM_EXMODE: | 516 | case DLM_LOCK_EX: |
510 | BUG_ON(!lockres->l_ex_holders); | 517 | BUG_ON(!lockres->l_ex_holders); |
511 | lockres->l_ex_holders--; | 518 | lockres->l_ex_holders--; |
512 | break; | 519 | break; |
513 | case LKM_PRMODE: | 520 | case DLM_LOCK_PR: |
514 | BUG_ON(!lockres->l_ro_holders); | 521 | BUG_ON(!lockres->l_ro_holders); |
515 | lockres->l_ro_holders--; | 522 | lockres->l_ro_holders--; |
516 | break; | 523 | break; |
@@ -522,8 +529,8 @@ static inline void user_dlm_dec_holders(struct user_lock_res *lockres, | |||
522 | void user_dlm_cluster_unlock(struct user_lock_res *lockres, | 529 | void user_dlm_cluster_unlock(struct user_lock_res *lockres, |
523 | int level) | 530 | int level) |
524 | { | 531 | { |
525 | if (level != LKM_EXMODE && | 532 | if (level != DLM_LOCK_EX && |
526 | level != LKM_PRMODE) { | 533 | level != DLM_LOCK_PR) { |
527 | mlog(ML_ERROR, "lockres %.*s: invalid request!\n", | 534 | mlog(ML_ERROR, "lockres %.*s: invalid request!\n", |
528 | lockres->l_namelen, lockres->l_name); | 535 | lockres->l_namelen, lockres->l_name); |
529 | return; | 536 | return; |
@@ -540,33 +547,40 @@ void user_dlm_write_lvb(struct inode *inode, | |||
540 | unsigned int len) | 547 | unsigned int len) |
541 | { | 548 | { |
542 | struct user_lock_res *lockres = &DLMFS_I(inode)->ip_lockres; | 549 | struct user_lock_res *lockres = &DLMFS_I(inode)->ip_lockres; |
543 | char *lvb = lockres->l_lksb.lvb; | 550 | char *lvb; |
544 | 551 | ||
545 | BUG_ON(len > DLM_LVB_LEN); | 552 | BUG_ON(len > DLM_LVB_LEN); |
546 | 553 | ||
547 | spin_lock(&lockres->l_lock); | 554 | spin_lock(&lockres->l_lock); |
548 | 555 | ||
549 | BUG_ON(lockres->l_level < LKM_EXMODE); | 556 | BUG_ON(lockres->l_level < DLM_LOCK_EX); |
557 | lvb = ocfs2_dlm_lvb(&lockres->l_lksb); | ||
550 | memcpy(lvb, val, len); | 558 | memcpy(lvb, val, len); |
551 | 559 | ||
552 | spin_unlock(&lockres->l_lock); | 560 | spin_unlock(&lockres->l_lock); |
553 | } | 561 | } |
554 | 562 | ||
555 | void user_dlm_read_lvb(struct inode *inode, | 563 | ssize_t user_dlm_read_lvb(struct inode *inode, |
556 | char *val, | 564 | char *val, |
557 | unsigned int len) | 565 | unsigned int len) |
558 | { | 566 | { |
559 | struct user_lock_res *lockres = &DLMFS_I(inode)->ip_lockres; | 567 | struct user_lock_res *lockres = &DLMFS_I(inode)->ip_lockres; |
560 | char *lvb = lockres->l_lksb.lvb; | 568 | char *lvb; |
569 | ssize_t ret = len; | ||
561 | 570 | ||
562 | BUG_ON(len > DLM_LVB_LEN); | 571 | BUG_ON(len > DLM_LVB_LEN); |
563 | 572 | ||
564 | spin_lock(&lockres->l_lock); | 573 | spin_lock(&lockres->l_lock); |
565 | 574 | ||
566 | BUG_ON(lockres->l_level < LKM_PRMODE); | 575 | BUG_ON(lockres->l_level < DLM_LOCK_PR); |
567 | memcpy(val, lvb, len); | 576 | if (ocfs2_dlm_lvb_valid(&lockres->l_lksb)) { |
577 | lvb = ocfs2_dlm_lvb(&lockres->l_lksb); | ||
578 | memcpy(val, lvb, len); | ||
579 | } else | ||
580 | ret = 0; | ||
568 | 581 | ||
569 | spin_unlock(&lockres->l_lock); | 582 | spin_unlock(&lockres->l_lock); |
583 | return ret; | ||
570 | } | 584 | } |
571 | 585 | ||
572 | void user_dlm_lock_res_init(struct user_lock_res *lockres, | 586 | void user_dlm_lock_res_init(struct user_lock_res *lockres, |
@@ -576,9 +590,9 @@ void user_dlm_lock_res_init(struct user_lock_res *lockres, | |||
576 | 590 | ||
577 | spin_lock_init(&lockres->l_lock); | 591 | spin_lock_init(&lockres->l_lock); |
578 | init_waitqueue_head(&lockres->l_event); | 592 | init_waitqueue_head(&lockres->l_event); |
579 | lockres->l_level = LKM_IVMODE; | 593 | lockres->l_level = DLM_LOCK_IV; |
580 | lockres->l_requested = LKM_IVMODE; | 594 | lockres->l_requested = DLM_LOCK_IV; |
581 | lockres->l_blocking = LKM_IVMODE; | 595 | lockres->l_blocking = DLM_LOCK_IV; |
582 | 596 | ||
583 | /* should have been checked before getting here. */ | 597 | /* should have been checked before getting here. */ |
584 | BUG_ON(dentry->d_name.len >= USER_DLM_LOCK_ID_MAX_LEN); | 598 | BUG_ON(dentry->d_name.len >= USER_DLM_LOCK_ID_MAX_LEN); |
@@ -592,9 +606,10 @@ void user_dlm_lock_res_init(struct user_lock_res *lockres, | |||
592 | int user_dlm_destroy_lock(struct user_lock_res *lockres) | 606 | int user_dlm_destroy_lock(struct user_lock_res *lockres) |
593 | { | 607 | { |
594 | int status = -EBUSY; | 608 | int status = -EBUSY; |
595 | struct dlm_ctxt *dlm = dlm_ctxt_from_user_lockres(lockres); | 609 | struct ocfs2_cluster_connection *conn = |
610 | cluster_connection_from_user_lockres(lockres); | ||
596 | 611 | ||
597 | mlog(0, "asked to destroy %.*s\n", lockres->l_namelen, lockres->l_name); | 612 | mlog(ML_BASTS, "lockres %.*s\n", lockres->l_namelen, lockres->l_name); |
598 | 613 | ||
599 | spin_lock(&lockres->l_lock); | 614 | spin_lock(&lockres->l_lock); |
600 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN) { | 615 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN) { |
@@ -627,14 +642,9 @@ int user_dlm_destroy_lock(struct user_lock_res *lockres) | |||
627 | lockres->l_flags |= USER_LOCK_BUSY; | 642 | lockres->l_flags |= USER_LOCK_BUSY; |
628 | spin_unlock(&lockres->l_lock); | 643 | spin_unlock(&lockres->l_lock); |
629 | 644 | ||
630 | status = dlmunlock(dlm, | 645 | status = ocfs2_dlm_unlock(conn, &lockres->l_lksb, DLM_LKF_VALBLK); |
631 | &lockres->l_lksb, | 646 | if (status) { |
632 | LKM_VALBLK, | 647 | user_log_dlm_error("ocfs2_dlm_unlock", status, lockres); |
633 | user_unlock_ast, | ||
634 | lockres); | ||
635 | if (status != DLM_NORMAL) { | ||
636 | user_log_dlm_error("dlmunlock", status, lockres); | ||
637 | status = -EINVAL; | ||
638 | goto bail; | 648 | goto bail; |
639 | } | 649 | } |
640 | 650 | ||
@@ -645,32 +655,34 @@ bail: | |||
645 | return status; | 655 | return status; |
646 | } | 656 | } |
647 | 657 | ||
648 | struct dlm_ctxt *user_dlm_register_context(struct qstr *name, | 658 | static void user_dlm_recovery_handler_noop(int node_num, |
649 | struct dlm_protocol_version *proto) | 659 | void *recovery_data) |
650 | { | 660 | { |
651 | struct dlm_ctxt *dlm; | 661 | /* We ignore recovery events */ |
652 | u32 dlm_key; | 662 | return; |
653 | char *domain; | 663 | } |
654 | |||
655 | domain = kmalloc(name->len + 1, GFP_NOFS); | ||
656 | if (!domain) { | ||
657 | mlog_errno(-ENOMEM); | ||
658 | return ERR_PTR(-ENOMEM); | ||
659 | } | ||
660 | 664 | ||
661 | dlm_key = crc32_le(0, name->name, name->len); | 665 | void user_dlm_set_locking_protocol(void) |
666 | { | ||
667 | ocfs2_stack_glue_set_max_proto_version(&user_dlm_lproto.lp_max_version); | ||
668 | } | ||
662 | 669 | ||
663 | snprintf(domain, name->len + 1, "%.*s", name->len, name->name); | 670 | struct ocfs2_cluster_connection *user_dlm_register(struct qstr *name) |
671 | { | ||
672 | int rc; | ||
673 | struct ocfs2_cluster_connection *conn; | ||
664 | 674 | ||
665 | dlm = dlm_register_domain(domain, dlm_key, proto); | 675 | rc = ocfs2_cluster_connect_agnostic(name->name, name->len, |
666 | if (IS_ERR(dlm)) | 676 | &user_dlm_lproto, |
667 | mlog_errno(PTR_ERR(dlm)); | 677 | user_dlm_recovery_handler_noop, |
678 | NULL, &conn); | ||
679 | if (rc) | ||
680 | mlog_errno(rc); | ||
668 | 681 | ||
669 | kfree(domain); | 682 | return rc ? ERR_PTR(rc) : conn; |
670 | return dlm; | ||
671 | } | 683 | } |
672 | 684 | ||
673 | void user_dlm_unregister_context(struct dlm_ctxt *dlm) | 685 | void user_dlm_unregister(struct ocfs2_cluster_connection *conn) |
674 | { | 686 | { |
675 | dlm_unregister_domain(dlm); | 687 | ocfs2_cluster_disconnect(conn, 0); |
676 | } | 688 | } |
diff --git a/fs/ocfs2/dlm/userdlm.h b/fs/ocfs2/dlmfs/userdlm.h index 0c3cc03c61fa..3b42d79531d7 100644 --- a/fs/ocfs2/dlm/userdlm.h +++ b/fs/ocfs2/dlmfs/userdlm.h | |||
@@ -57,7 +57,7 @@ struct user_lock_res { | |||
57 | int l_level; | 57 | int l_level; |
58 | unsigned int l_ro_holders; | 58 | unsigned int l_ro_holders; |
59 | unsigned int l_ex_holders; | 59 | unsigned int l_ex_holders; |
60 | struct dlm_lockstatus l_lksb; | 60 | struct ocfs2_dlm_lksb l_lksb; |
61 | 61 | ||
62 | int l_requested; | 62 | int l_requested; |
63 | int l_blocking; | 63 | int l_blocking; |
@@ -80,15 +80,15 @@ void user_dlm_cluster_unlock(struct user_lock_res *lockres, | |||
80 | void user_dlm_write_lvb(struct inode *inode, | 80 | void user_dlm_write_lvb(struct inode *inode, |
81 | const char *val, | 81 | const char *val, |
82 | unsigned int len); | 82 | unsigned int len); |
83 | void user_dlm_read_lvb(struct inode *inode, | 83 | ssize_t user_dlm_read_lvb(struct inode *inode, |
84 | char *val, | 84 | char *val, |
85 | unsigned int len); | 85 | unsigned int len); |
86 | struct dlm_ctxt *user_dlm_register_context(struct qstr *name, | 86 | struct ocfs2_cluster_connection *user_dlm_register(struct qstr *name); |
87 | struct dlm_protocol_version *proto); | 87 | void user_dlm_unregister(struct ocfs2_cluster_connection *conn); |
88 | void user_dlm_unregister_context(struct dlm_ctxt *dlm); | 88 | void user_dlm_set_locking_protocol(void); |
89 | 89 | ||
90 | struct dlmfs_inode_private { | 90 | struct dlmfs_inode_private { |
91 | struct dlm_ctxt *ip_dlm; | 91 | struct ocfs2_cluster_connection *ip_conn; |
92 | 92 | ||
93 | struct user_lock_res ip_lockres; /* unused for directories. */ | 93 | struct user_lock_res ip_lockres; /* unused for directories. */ |
94 | struct inode *ip_parent; | 94 | struct inode *ip_parent; |
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index e044019cb3b1..8298608d4165 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c | |||
@@ -297,6 +297,11 @@ static inline int ocfs2_is_inode_lock(struct ocfs2_lock_res *lockres) | |||
297 | lockres->l_type == OCFS2_LOCK_TYPE_OPEN; | 297 | lockres->l_type == OCFS2_LOCK_TYPE_OPEN; |
298 | } | 298 | } |
299 | 299 | ||
300 | static inline struct ocfs2_lock_res *ocfs2_lksb_to_lock_res(struct ocfs2_dlm_lksb *lksb) | ||
301 | { | ||
302 | return container_of(lksb, struct ocfs2_lock_res, l_lksb); | ||
303 | } | ||
304 | |||
300 | static inline struct inode *ocfs2_lock_res_inode(struct ocfs2_lock_res *lockres) | 305 | static inline struct inode *ocfs2_lock_res_inode(struct ocfs2_lock_res *lockres) |
301 | { | 306 | { |
302 | BUG_ON(!ocfs2_is_inode_lock(lockres)); | 307 | BUG_ON(!ocfs2_is_inode_lock(lockres)); |
@@ -927,6 +932,10 @@ static int ocfs2_generic_handle_bast(struct ocfs2_lock_res *lockres, | |||
927 | lockres->l_blocking = level; | 932 | lockres->l_blocking = level; |
928 | } | 933 | } |
929 | 934 | ||
935 | mlog(ML_BASTS, "lockres %s, block %d, level %d, l_block %d, dwn %d\n", | ||
936 | lockres->l_name, level, lockres->l_level, lockres->l_blocking, | ||
937 | needs_downconvert); | ||
938 | |||
930 | if (needs_downconvert) | 939 | if (needs_downconvert) |
931 | lockres_or_flags(lockres, OCFS2_LOCK_BLOCKED); | 940 | lockres_or_flags(lockres, OCFS2_LOCK_BLOCKED); |
932 | 941 | ||
@@ -1040,18 +1049,17 @@ static unsigned int lockres_set_pending(struct ocfs2_lock_res *lockres) | |||
1040 | return lockres->l_pending_gen; | 1049 | return lockres->l_pending_gen; |
1041 | } | 1050 | } |
1042 | 1051 | ||
1043 | 1052 | static void ocfs2_blocking_ast(struct ocfs2_dlm_lksb *lksb, int level) | |
1044 | static void ocfs2_blocking_ast(void *opaque, int level) | ||
1045 | { | 1053 | { |
1046 | struct ocfs2_lock_res *lockres = opaque; | 1054 | struct ocfs2_lock_res *lockres = ocfs2_lksb_to_lock_res(lksb); |
1047 | struct ocfs2_super *osb = ocfs2_get_lockres_osb(lockres); | 1055 | struct ocfs2_super *osb = ocfs2_get_lockres_osb(lockres); |
1048 | int needs_downconvert; | 1056 | int needs_downconvert; |
1049 | unsigned long flags; | 1057 | unsigned long flags; |
1050 | 1058 | ||
1051 | BUG_ON(level <= DLM_LOCK_NL); | 1059 | BUG_ON(level <= DLM_LOCK_NL); |
1052 | 1060 | ||
1053 | mlog(0, "BAST fired for lockres %s, blocking %d, level %d type %s\n", | 1061 | mlog(ML_BASTS, "BAST fired for lockres %s, blocking %d, level %d, " |
1054 | lockres->l_name, level, lockres->l_level, | 1062 | "type %s\n", lockres->l_name, level, lockres->l_level, |
1055 | ocfs2_lock_type_string(lockres->l_type)); | 1063 | ocfs2_lock_type_string(lockres->l_type)); |
1056 | 1064 | ||
1057 | /* | 1065 | /* |
@@ -1072,9 +1080,9 @@ static void ocfs2_blocking_ast(void *opaque, int level) | |||
1072 | ocfs2_wake_downconvert_thread(osb); | 1080 | ocfs2_wake_downconvert_thread(osb); |
1073 | } | 1081 | } |
1074 | 1082 | ||
1075 | static void ocfs2_locking_ast(void *opaque) | 1083 | static void ocfs2_locking_ast(struct ocfs2_dlm_lksb *lksb) |
1076 | { | 1084 | { |
1077 | struct ocfs2_lock_res *lockres = opaque; | 1085 | struct ocfs2_lock_res *lockres = ocfs2_lksb_to_lock_res(lksb); |
1078 | struct ocfs2_super *osb = ocfs2_get_lockres_osb(lockres); | 1086 | struct ocfs2_super *osb = ocfs2_get_lockres_osb(lockres); |
1079 | unsigned long flags; | 1087 | unsigned long flags; |
1080 | int status; | 1088 | int status; |
@@ -1095,6 +1103,10 @@ static void ocfs2_locking_ast(void *opaque) | |||
1095 | return; | 1103 | return; |
1096 | } | 1104 | } |
1097 | 1105 | ||
1106 | mlog(ML_BASTS, "AST fired for lockres %s, action %d, unlock %d, " | ||
1107 | "level %d => %d\n", lockres->l_name, lockres->l_action, | ||
1108 | lockres->l_unlock_action, lockres->l_level, lockres->l_requested); | ||
1109 | |||
1098 | switch(lockres->l_action) { | 1110 | switch(lockres->l_action) { |
1099 | case OCFS2_AST_ATTACH: | 1111 | case OCFS2_AST_ATTACH: |
1100 | ocfs2_generic_handle_attach_action(lockres); | 1112 | ocfs2_generic_handle_attach_action(lockres); |
@@ -1107,8 +1119,8 @@ static void ocfs2_locking_ast(void *opaque) | |||
1107 | ocfs2_generic_handle_downconvert_action(lockres); | 1119 | ocfs2_generic_handle_downconvert_action(lockres); |
1108 | break; | 1120 | break; |
1109 | default: | 1121 | default: |
1110 | mlog(ML_ERROR, "lockres %s: ast fired with invalid action: %u " | 1122 | mlog(ML_ERROR, "lockres %s: AST fired with invalid action: %u, " |
1111 | "lockres flags = 0x%lx, unlock action: %u\n", | 1123 | "flags 0x%lx, unlock: %u\n", |
1112 | lockres->l_name, lockres->l_action, lockres->l_flags, | 1124 | lockres->l_name, lockres->l_action, lockres->l_flags, |
1113 | lockres->l_unlock_action); | 1125 | lockres->l_unlock_action); |
1114 | BUG(); | 1126 | BUG(); |
@@ -1134,6 +1146,88 @@ out: | |||
1134 | spin_unlock_irqrestore(&lockres->l_lock, flags); | 1146 | spin_unlock_irqrestore(&lockres->l_lock, flags); |
1135 | } | 1147 | } |
1136 | 1148 | ||
1149 | static void ocfs2_unlock_ast(struct ocfs2_dlm_lksb *lksb, int error) | ||
1150 | { | ||
1151 | struct ocfs2_lock_res *lockres = ocfs2_lksb_to_lock_res(lksb); | ||
1152 | unsigned long flags; | ||
1153 | |||
1154 | mlog_entry_void(); | ||
1155 | |||
1156 | mlog(ML_BASTS, "UNLOCK AST fired for lockres %s, action = %d\n", | ||
1157 | lockres->l_name, lockres->l_unlock_action); | ||
1158 | |||
1159 | spin_lock_irqsave(&lockres->l_lock, flags); | ||
1160 | if (error) { | ||
1161 | mlog(ML_ERROR, "Dlm passes error %d for lock %s, " | ||
1162 | "unlock_action %d\n", error, lockres->l_name, | ||
1163 | lockres->l_unlock_action); | ||
1164 | spin_unlock_irqrestore(&lockres->l_lock, flags); | ||
1165 | mlog_exit_void(); | ||
1166 | return; | ||
1167 | } | ||
1168 | |||
1169 | switch(lockres->l_unlock_action) { | ||
1170 | case OCFS2_UNLOCK_CANCEL_CONVERT: | ||
1171 | mlog(0, "Cancel convert success for %s\n", lockres->l_name); | ||
1172 | lockres->l_action = OCFS2_AST_INVALID; | ||
1173 | /* Downconvert thread may have requeued this lock, we | ||
1174 | * need to wake it. */ | ||
1175 | if (lockres->l_flags & OCFS2_LOCK_BLOCKED) | ||
1176 | ocfs2_wake_downconvert_thread(ocfs2_get_lockres_osb(lockres)); | ||
1177 | break; | ||
1178 | case OCFS2_UNLOCK_DROP_LOCK: | ||
1179 | lockres->l_level = DLM_LOCK_IV; | ||
1180 | break; | ||
1181 | default: | ||
1182 | BUG(); | ||
1183 | } | ||
1184 | |||
1185 | lockres_clear_flags(lockres, OCFS2_LOCK_BUSY); | ||
1186 | lockres->l_unlock_action = OCFS2_UNLOCK_INVALID; | ||
1187 | wake_up(&lockres->l_event); | ||
1188 | spin_unlock_irqrestore(&lockres->l_lock, flags); | ||
1189 | |||
1190 | mlog_exit_void(); | ||
1191 | } | ||
1192 | |||
1193 | /* | ||
1194 | * This is the filesystem locking protocol. It provides the lock handling | ||
1195 | * hooks for the underlying DLM. It has a maximum version number. | ||
1196 | * The version number allows interoperability with systems running at | ||
1197 | * the same major number and an equal or smaller minor number. | ||
1198 | * | ||
1199 | * Whenever the filesystem does new things with locks (adds or removes a | ||
1200 | * lock, orders them differently, does different things underneath a lock), | ||
1201 | * the version must be changed. The protocol is negotiated when joining | ||
1202 | * the dlm domain. A node may join the domain if its major version is | ||
1203 | * identical to all other nodes and its minor version is greater than | ||
1204 | * or equal to all other nodes. When its minor version is greater than | ||
1205 | * the other nodes, it will run at the minor version specified by the | ||
1206 | * other nodes. | ||
1207 | * | ||
1208 | * If a locking change is made that will not be compatible with older | ||
1209 | * versions, the major number must be increased and the minor version set | ||
1210 | * to zero. If a change merely adds a behavior that can be disabled when | ||
1211 | * speaking to older versions, the minor version must be increased. If a | ||
1212 | * change adds a fully backwards compatible change (eg, LVB changes that | ||
1213 | * are just ignored by older versions), the version does not need to be | ||
1214 | * updated. | ||
1215 | */ | ||
1216 | static struct ocfs2_locking_protocol lproto = { | ||
1217 | .lp_max_version = { | ||
1218 | .pv_major = OCFS2_LOCKING_PROTOCOL_MAJOR, | ||
1219 | .pv_minor = OCFS2_LOCKING_PROTOCOL_MINOR, | ||
1220 | }, | ||
1221 | .lp_lock_ast = ocfs2_locking_ast, | ||
1222 | .lp_blocking_ast = ocfs2_blocking_ast, | ||
1223 | .lp_unlock_ast = ocfs2_unlock_ast, | ||
1224 | }; | ||
1225 | |||
1226 | void ocfs2_set_locking_protocol(void) | ||
1227 | { | ||
1228 | ocfs2_stack_glue_set_max_proto_version(&lproto.lp_max_version); | ||
1229 | } | ||
1230 | |||
1137 | static inline void ocfs2_recover_from_dlm_error(struct ocfs2_lock_res *lockres, | 1231 | static inline void ocfs2_recover_from_dlm_error(struct ocfs2_lock_res *lockres, |
1138 | int convert) | 1232 | int convert) |
1139 | { | 1233 | { |
@@ -1189,8 +1283,7 @@ static int ocfs2_lock_create(struct ocfs2_super *osb, | |||
1189 | &lockres->l_lksb, | 1283 | &lockres->l_lksb, |
1190 | dlm_flags, | 1284 | dlm_flags, |
1191 | lockres->l_name, | 1285 | lockres->l_name, |
1192 | OCFS2_LOCK_ID_MAX_LEN - 1, | 1286 | OCFS2_LOCK_ID_MAX_LEN - 1); |
1193 | lockres); | ||
1194 | lockres_clear_pending(lockres, gen, osb); | 1287 | lockres_clear_pending(lockres, gen, osb); |
1195 | if (ret) { | 1288 | if (ret) { |
1196 | ocfs2_log_dlm_error("ocfs2_dlm_lock", ret, lockres); | 1289 | ocfs2_log_dlm_error("ocfs2_dlm_lock", ret, lockres); |
@@ -1412,7 +1505,7 @@ again: | |||
1412 | BUG_ON(level == DLM_LOCK_IV); | 1505 | BUG_ON(level == DLM_LOCK_IV); |
1413 | BUG_ON(level == DLM_LOCK_NL); | 1506 | BUG_ON(level == DLM_LOCK_NL); |
1414 | 1507 | ||
1415 | mlog(0, "lock %s, convert from %d to level = %d\n", | 1508 | mlog(ML_BASTS, "lockres %s, convert from %d to %d\n", |
1416 | lockres->l_name, lockres->l_level, level); | 1509 | lockres->l_name, lockres->l_level, level); |
1417 | 1510 | ||
1418 | /* call dlm_lock to upgrade lock now */ | 1511 | /* call dlm_lock to upgrade lock now */ |
@@ -1421,8 +1514,7 @@ again: | |||
1421 | &lockres->l_lksb, | 1514 | &lockres->l_lksb, |
1422 | lkm_flags, | 1515 | lkm_flags, |
1423 | lockres->l_name, | 1516 | lockres->l_name, |
1424 | OCFS2_LOCK_ID_MAX_LEN - 1, | 1517 | OCFS2_LOCK_ID_MAX_LEN - 1); |
1425 | lockres); | ||
1426 | lockres_clear_pending(lockres, gen, osb); | 1518 | lockres_clear_pending(lockres, gen, osb); |
1427 | if (ret) { | 1519 | if (ret) { |
1428 | if (!(lkm_flags & DLM_LKF_NOQUEUE) || | 1520 | if (!(lkm_flags & DLM_LKF_NOQUEUE) || |
@@ -1859,8 +1951,7 @@ int ocfs2_file_lock(struct file *file, int ex, int trylock) | |||
1859 | spin_unlock_irqrestore(&lockres->l_lock, flags); | 1951 | spin_unlock_irqrestore(&lockres->l_lock, flags); |
1860 | 1952 | ||
1861 | ret = ocfs2_dlm_lock(osb->cconn, level, &lockres->l_lksb, lkm_flags, | 1953 | ret = ocfs2_dlm_lock(osb->cconn, level, &lockres->l_lksb, lkm_flags, |
1862 | lockres->l_name, OCFS2_LOCK_ID_MAX_LEN - 1, | 1954 | lockres->l_name, OCFS2_LOCK_ID_MAX_LEN - 1); |
1863 | lockres); | ||
1864 | if (ret) { | 1955 | if (ret) { |
1865 | if (!trylock || (ret != -EAGAIN)) { | 1956 | if (!trylock || (ret != -EAGAIN)) { |
1866 | ocfs2_log_dlm_error("ocfs2_dlm_lock", ret, lockres); | 1957 | ocfs2_log_dlm_error("ocfs2_dlm_lock", ret, lockres); |
@@ -2989,7 +3080,7 @@ int ocfs2_dlm_init(struct ocfs2_super *osb) | |||
2989 | status = ocfs2_cluster_connect(osb->osb_cluster_stack, | 3080 | status = ocfs2_cluster_connect(osb->osb_cluster_stack, |
2990 | osb->uuid_str, | 3081 | osb->uuid_str, |
2991 | strlen(osb->uuid_str), | 3082 | strlen(osb->uuid_str), |
2992 | ocfs2_do_node_down, osb, | 3083 | &lproto, ocfs2_do_node_down, osb, |
2993 | &conn); | 3084 | &conn); |
2994 | if (status) { | 3085 | if (status) { |
2995 | mlog_errno(status); | 3086 | mlog_errno(status); |
@@ -3056,50 +3147,6 @@ void ocfs2_dlm_shutdown(struct ocfs2_super *osb, | |||
3056 | mlog_exit_void(); | 3147 | mlog_exit_void(); |
3057 | } | 3148 | } |
3058 | 3149 | ||
3059 | static void ocfs2_unlock_ast(void *opaque, int error) | ||
3060 | { | ||
3061 | struct ocfs2_lock_res *lockres = opaque; | ||
3062 | unsigned long flags; | ||
3063 | |||
3064 | mlog_entry_void(); | ||
3065 | |||
3066 | mlog(0, "UNLOCK AST called on lock %s, action = %d\n", lockres->l_name, | ||
3067 | lockres->l_unlock_action); | ||
3068 | |||
3069 | spin_lock_irqsave(&lockres->l_lock, flags); | ||
3070 | if (error) { | ||
3071 | mlog(ML_ERROR, "Dlm passes error %d for lock %s, " | ||
3072 | "unlock_action %d\n", error, lockres->l_name, | ||
3073 | lockres->l_unlock_action); | ||
3074 | spin_unlock_irqrestore(&lockres->l_lock, flags); | ||
3075 | mlog_exit_void(); | ||
3076 | return; | ||
3077 | } | ||
3078 | |||
3079 | switch(lockres->l_unlock_action) { | ||
3080 | case OCFS2_UNLOCK_CANCEL_CONVERT: | ||
3081 | mlog(0, "Cancel convert success for %s\n", lockres->l_name); | ||
3082 | lockres->l_action = OCFS2_AST_INVALID; | ||
3083 | /* Downconvert thread may have requeued this lock, we | ||
3084 | * need to wake it. */ | ||
3085 | if (lockres->l_flags & OCFS2_LOCK_BLOCKED) | ||
3086 | ocfs2_wake_downconvert_thread(ocfs2_get_lockres_osb(lockres)); | ||
3087 | break; | ||
3088 | case OCFS2_UNLOCK_DROP_LOCK: | ||
3089 | lockres->l_level = DLM_LOCK_IV; | ||
3090 | break; | ||
3091 | default: | ||
3092 | BUG(); | ||
3093 | } | ||
3094 | |||
3095 | lockres_clear_flags(lockres, OCFS2_LOCK_BUSY); | ||
3096 | lockres->l_unlock_action = OCFS2_UNLOCK_INVALID; | ||
3097 | wake_up(&lockres->l_event); | ||
3098 | spin_unlock_irqrestore(&lockres->l_lock, flags); | ||
3099 | |||
3100 | mlog_exit_void(); | ||
3101 | } | ||
3102 | |||
3103 | static int ocfs2_drop_lock(struct ocfs2_super *osb, | 3150 | static int ocfs2_drop_lock(struct ocfs2_super *osb, |
3104 | struct ocfs2_lock_res *lockres) | 3151 | struct ocfs2_lock_res *lockres) |
3105 | { | 3152 | { |
@@ -3167,8 +3214,7 @@ static int ocfs2_drop_lock(struct ocfs2_super *osb, | |||
3167 | 3214 | ||
3168 | mlog(0, "lock %s\n", lockres->l_name); | 3215 | mlog(0, "lock %s\n", lockres->l_name); |
3169 | 3216 | ||
3170 | ret = ocfs2_dlm_unlock(osb->cconn, &lockres->l_lksb, lkm_flags, | 3217 | ret = ocfs2_dlm_unlock(osb->cconn, &lockres->l_lksb, lkm_flags); |
3171 | lockres); | ||
3172 | if (ret) { | 3218 | if (ret) { |
3173 | ocfs2_log_dlm_error("ocfs2_dlm_unlock", ret, lockres); | 3219 | ocfs2_log_dlm_error("ocfs2_dlm_unlock", ret, lockres); |
3174 | mlog(ML_ERROR, "lockres flags: %lu\n", lockres->l_flags); | 3220 | mlog(ML_ERROR, "lockres flags: %lu\n", lockres->l_flags); |
@@ -3276,13 +3322,20 @@ static unsigned int ocfs2_prepare_downconvert(struct ocfs2_lock_res *lockres, | |||
3276 | BUG_ON(lockres->l_blocking <= DLM_LOCK_NL); | 3322 | BUG_ON(lockres->l_blocking <= DLM_LOCK_NL); |
3277 | 3323 | ||
3278 | if (lockres->l_level <= new_level) { | 3324 | if (lockres->l_level <= new_level) { |
3279 | mlog(ML_ERROR, "lockres->l_level (%d) <= new_level (%d)\n", | 3325 | mlog(ML_ERROR, "lockres %s, lvl %d <= %d, blcklst %d, mask %d, " |
3280 | lockres->l_level, new_level); | 3326 | "type %d, flags 0x%lx, hold %d %d, act %d %d, req %d, " |
3327 | "block %d, pgen %d\n", lockres->l_name, lockres->l_level, | ||
3328 | new_level, list_empty(&lockres->l_blocked_list), | ||
3329 | list_empty(&lockres->l_mask_waiters), lockres->l_type, | ||
3330 | lockres->l_flags, lockres->l_ro_holders, | ||
3331 | lockres->l_ex_holders, lockres->l_action, | ||
3332 | lockres->l_unlock_action, lockres->l_requested, | ||
3333 | lockres->l_blocking, lockres->l_pending_gen); | ||
3281 | BUG(); | 3334 | BUG(); |
3282 | } | 3335 | } |
3283 | 3336 | ||
3284 | mlog(0, "lock %s, new_level = %d, l_blocking = %d\n", | 3337 | mlog(ML_BASTS, "lockres %s, level %d => %d, blocking %d\n", |
3285 | lockres->l_name, new_level, lockres->l_blocking); | 3338 | lockres->l_name, lockres->l_level, new_level, lockres->l_blocking); |
3286 | 3339 | ||
3287 | lockres->l_action = OCFS2_AST_DOWNCONVERT; | 3340 | lockres->l_action = OCFS2_AST_DOWNCONVERT; |
3288 | lockres->l_requested = new_level; | 3341 | lockres->l_requested = new_level; |
@@ -3301,6 +3354,9 @@ static int ocfs2_downconvert_lock(struct ocfs2_super *osb, | |||
3301 | 3354 | ||
3302 | mlog_entry_void(); | 3355 | mlog_entry_void(); |
3303 | 3356 | ||
3357 | mlog(ML_BASTS, "lockres %s, level %d => %d\n", lockres->l_name, | ||
3358 | lockres->l_level, new_level); | ||
3359 | |||
3304 | if (lvb) | 3360 | if (lvb) |
3305 | dlm_flags |= DLM_LKF_VALBLK; | 3361 | dlm_flags |= DLM_LKF_VALBLK; |
3306 | 3362 | ||
@@ -3309,8 +3365,7 @@ static int ocfs2_downconvert_lock(struct ocfs2_super *osb, | |||
3309 | &lockres->l_lksb, | 3365 | &lockres->l_lksb, |
3310 | dlm_flags, | 3366 | dlm_flags, |
3311 | lockres->l_name, | 3367 | lockres->l_name, |
3312 | OCFS2_LOCK_ID_MAX_LEN - 1, | 3368 | OCFS2_LOCK_ID_MAX_LEN - 1); |
3313 | lockres); | ||
3314 | lockres_clear_pending(lockres, generation, osb); | 3369 | lockres_clear_pending(lockres, generation, osb); |
3315 | if (ret) { | 3370 | if (ret) { |
3316 | ocfs2_log_dlm_error("ocfs2_dlm_lock", ret, lockres); | 3371 | ocfs2_log_dlm_error("ocfs2_dlm_lock", ret, lockres); |
@@ -3331,14 +3386,12 @@ static int ocfs2_prepare_cancel_convert(struct ocfs2_super *osb, | |||
3331 | assert_spin_locked(&lockres->l_lock); | 3386 | assert_spin_locked(&lockres->l_lock); |
3332 | 3387 | ||
3333 | mlog_entry_void(); | 3388 | mlog_entry_void(); |
3334 | mlog(0, "lock %s\n", lockres->l_name); | ||
3335 | 3389 | ||
3336 | if (lockres->l_unlock_action == OCFS2_UNLOCK_CANCEL_CONVERT) { | 3390 | if (lockres->l_unlock_action == OCFS2_UNLOCK_CANCEL_CONVERT) { |
3337 | /* If we're already trying to cancel a lock conversion | 3391 | /* If we're already trying to cancel a lock conversion |
3338 | * then just drop the spinlock and allow the caller to | 3392 | * then just drop the spinlock and allow the caller to |
3339 | * requeue this lock. */ | 3393 | * requeue this lock. */ |
3340 | 3394 | mlog(ML_BASTS, "lockres %s, skip convert\n", lockres->l_name); | |
3341 | mlog(0, "Lockres %s, skip convert\n", lockres->l_name); | ||
3342 | return 0; | 3395 | return 0; |
3343 | } | 3396 | } |
3344 | 3397 | ||
@@ -3353,6 +3406,8 @@ static int ocfs2_prepare_cancel_convert(struct ocfs2_super *osb, | |||
3353 | "lock %s, invalid flags: 0x%lx\n", | 3406 | "lock %s, invalid flags: 0x%lx\n", |
3354 | lockres->l_name, lockres->l_flags); | 3407 | lockres->l_name, lockres->l_flags); |
3355 | 3408 | ||
3409 | mlog(ML_BASTS, "lockres %s\n", lockres->l_name); | ||
3410 | |||
3356 | return 1; | 3411 | return 1; |
3357 | } | 3412 | } |
3358 | 3413 | ||
@@ -3362,16 +3417,15 @@ static int ocfs2_cancel_convert(struct ocfs2_super *osb, | |||
3362 | int ret; | 3417 | int ret; |
3363 | 3418 | ||
3364 | mlog_entry_void(); | 3419 | mlog_entry_void(); |
3365 | mlog(0, "lock %s\n", lockres->l_name); | ||
3366 | 3420 | ||
3367 | ret = ocfs2_dlm_unlock(osb->cconn, &lockres->l_lksb, | 3421 | ret = ocfs2_dlm_unlock(osb->cconn, &lockres->l_lksb, |
3368 | DLM_LKF_CANCEL, lockres); | 3422 | DLM_LKF_CANCEL); |
3369 | if (ret) { | 3423 | if (ret) { |
3370 | ocfs2_log_dlm_error("ocfs2_dlm_unlock", ret, lockres); | 3424 | ocfs2_log_dlm_error("ocfs2_dlm_unlock", ret, lockres); |
3371 | ocfs2_recover_from_dlm_error(lockres, 0); | 3425 | ocfs2_recover_from_dlm_error(lockres, 0); |
3372 | } | 3426 | } |
3373 | 3427 | ||
3374 | mlog(0, "lock %s return from ocfs2_dlm_unlock\n", lockres->l_name); | 3428 | mlog(ML_BASTS, "lockres %s\n", lockres->l_name); |
3375 | 3429 | ||
3376 | mlog_exit(ret); | 3430 | mlog_exit(ret); |
3377 | return ret; | 3431 | return ret; |
@@ -3428,8 +3482,11 @@ recheck: | |||
3428 | * at the same time they set OCFS2_DLM_BUSY. They must | 3482 | * at the same time they set OCFS2_DLM_BUSY. They must |
3429 | * clear OCFS2_DLM_PENDING after dlm_lock() returns. | 3483 | * clear OCFS2_DLM_PENDING after dlm_lock() returns. |
3430 | */ | 3484 | */ |
3431 | if (lockres->l_flags & OCFS2_LOCK_PENDING) | 3485 | if (lockres->l_flags & OCFS2_LOCK_PENDING) { |
3486 | mlog(ML_BASTS, "lockres %s, ReQ: Pending\n", | ||
3487 | lockres->l_name); | ||
3432 | goto leave_requeue; | 3488 | goto leave_requeue; |
3489 | } | ||
3433 | 3490 | ||
3434 | ctl->requeue = 1; | 3491 | ctl->requeue = 1; |
3435 | ret = ocfs2_prepare_cancel_convert(osb, lockres); | 3492 | ret = ocfs2_prepare_cancel_convert(osb, lockres); |
@@ -3461,6 +3518,7 @@ recheck: | |||
3461 | */ | 3518 | */ |
3462 | if (lockres->l_level == DLM_LOCK_NL) { | 3519 | if (lockres->l_level == DLM_LOCK_NL) { |
3463 | BUG_ON(lockres->l_ex_holders || lockres->l_ro_holders); | 3520 | BUG_ON(lockres->l_ex_holders || lockres->l_ro_holders); |
3521 | mlog(ML_BASTS, "lockres %s, Aborting dc\n", lockres->l_name); | ||
3464 | lockres->l_blocking = DLM_LOCK_NL; | 3522 | lockres->l_blocking = DLM_LOCK_NL; |
3465 | lockres_clear_flags(lockres, OCFS2_LOCK_BLOCKED); | 3523 | lockres_clear_flags(lockres, OCFS2_LOCK_BLOCKED); |
3466 | spin_unlock_irqrestore(&lockres->l_lock, flags); | 3524 | spin_unlock_irqrestore(&lockres->l_lock, flags); |
@@ -3470,28 +3528,41 @@ recheck: | |||
3470 | /* if we're blocking an exclusive and we have *any* holders, | 3528 | /* if we're blocking an exclusive and we have *any* holders, |
3471 | * then requeue. */ | 3529 | * then requeue. */ |
3472 | if ((lockres->l_blocking == DLM_LOCK_EX) | 3530 | if ((lockres->l_blocking == DLM_LOCK_EX) |
3473 | && (lockres->l_ex_holders || lockres->l_ro_holders)) | 3531 | && (lockres->l_ex_holders || lockres->l_ro_holders)) { |
3532 | mlog(ML_BASTS, "lockres %s, ReQ: EX/PR Holders %u,%u\n", | ||
3533 | lockres->l_name, lockres->l_ex_holders, | ||
3534 | lockres->l_ro_holders); | ||
3474 | goto leave_requeue; | 3535 | goto leave_requeue; |
3536 | } | ||
3475 | 3537 | ||
3476 | /* If it's a PR we're blocking, then only | 3538 | /* If it's a PR we're blocking, then only |
3477 | * requeue if we've got any EX holders */ | 3539 | * requeue if we've got any EX holders */ |
3478 | if (lockres->l_blocking == DLM_LOCK_PR && | 3540 | if (lockres->l_blocking == DLM_LOCK_PR && |
3479 | lockres->l_ex_holders) | 3541 | lockres->l_ex_holders) { |
3542 | mlog(ML_BASTS, "lockres %s, ReQ: EX Holders %u\n", | ||
3543 | lockres->l_name, lockres->l_ex_holders); | ||
3480 | goto leave_requeue; | 3544 | goto leave_requeue; |
3545 | } | ||
3481 | 3546 | ||
3482 | /* | 3547 | /* |
3483 | * Can we get a lock in this state if the holder counts are | 3548 | * Can we get a lock in this state if the holder counts are |
3484 | * zero? The meta data unblock code used to check this. | 3549 | * zero? The meta data unblock code used to check this. |
3485 | */ | 3550 | */ |
3486 | if ((lockres->l_ops->flags & LOCK_TYPE_REQUIRES_REFRESH) | 3551 | if ((lockres->l_ops->flags & LOCK_TYPE_REQUIRES_REFRESH) |
3487 | && (lockres->l_flags & OCFS2_LOCK_REFRESHING)) | 3552 | && (lockres->l_flags & OCFS2_LOCK_REFRESHING)) { |
3553 | mlog(ML_BASTS, "lockres %s, ReQ: Lock Refreshing\n", | ||
3554 | lockres->l_name); | ||
3488 | goto leave_requeue; | 3555 | goto leave_requeue; |
3556 | } | ||
3489 | 3557 | ||
3490 | new_level = ocfs2_highest_compat_lock_level(lockres->l_blocking); | 3558 | new_level = ocfs2_highest_compat_lock_level(lockres->l_blocking); |
3491 | 3559 | ||
3492 | if (lockres->l_ops->check_downconvert | 3560 | if (lockres->l_ops->check_downconvert |
3493 | && !lockres->l_ops->check_downconvert(lockres, new_level)) | 3561 | && !lockres->l_ops->check_downconvert(lockres, new_level)) { |
3562 | mlog(ML_BASTS, "lockres %s, ReQ: Checkpointing\n", | ||
3563 | lockres->l_name); | ||
3494 | goto leave_requeue; | 3564 | goto leave_requeue; |
3565 | } | ||
3495 | 3566 | ||
3496 | /* If we get here, then we know that there are no more | 3567 | /* If we get here, then we know that there are no more |
3497 | * incompatible holders (and anyone asking for an incompatible | 3568 | * incompatible holders (and anyone asking for an incompatible |
@@ -3509,13 +3580,19 @@ recheck: | |||
3509 | 3580 | ||
3510 | ctl->unblock_action = lockres->l_ops->downconvert_worker(lockres, blocking); | 3581 | ctl->unblock_action = lockres->l_ops->downconvert_worker(lockres, blocking); |
3511 | 3582 | ||
3512 | if (ctl->unblock_action == UNBLOCK_STOP_POST) | 3583 | if (ctl->unblock_action == UNBLOCK_STOP_POST) { |
3584 | mlog(ML_BASTS, "lockres %s, UNBLOCK_STOP_POST\n", | ||
3585 | lockres->l_name); | ||
3513 | goto leave; | 3586 | goto leave; |
3587 | } | ||
3514 | 3588 | ||
3515 | spin_lock_irqsave(&lockres->l_lock, flags); | 3589 | spin_lock_irqsave(&lockres->l_lock, flags); |
3516 | if ((blocking != lockres->l_blocking) || (level != lockres->l_level)) { | 3590 | if ((blocking != lockres->l_blocking) || (level != lockres->l_level)) { |
3517 | /* If this changed underneath us, then we can't drop | 3591 | /* If this changed underneath us, then we can't drop |
3518 | * it just yet. */ | 3592 | * it just yet. */ |
3593 | mlog(ML_BASTS, "lockres %s, block=%d:%d, level=%d:%d, " | ||
3594 | "Recheck\n", lockres->l_name, blocking, | ||
3595 | lockres->l_blocking, level, lockres->l_level); | ||
3519 | goto recheck; | 3596 | goto recheck; |
3520 | } | 3597 | } |
3521 | 3598 | ||
@@ -3910,45 +3987,6 @@ void ocfs2_refcount_unlock(struct ocfs2_refcount_tree *ref_tree, int ex) | |||
3910 | ocfs2_cluster_unlock(osb, lockres, level); | 3987 | ocfs2_cluster_unlock(osb, lockres, level); |
3911 | } | 3988 | } |
3912 | 3989 | ||
3913 | /* | ||
3914 | * This is the filesystem locking protocol. It provides the lock handling | ||
3915 | * hooks for the underlying DLM. It has a maximum version number. | ||
3916 | * The version number allows interoperability with systems running at | ||
3917 | * the same major number and an equal or smaller minor number. | ||
3918 | * | ||
3919 | * Whenever the filesystem does new things with locks (adds or removes a | ||
3920 | * lock, orders them differently, does different things underneath a lock), | ||
3921 | * the version must be changed. The protocol is negotiated when joining | ||
3922 | * the dlm domain. A node may join the domain if its major version is | ||
3923 | * identical to all other nodes and its minor version is greater than | ||
3924 | * or equal to all other nodes. When its minor version is greater than | ||
3925 | * the other nodes, it will run at the minor version specified by the | ||
3926 | * other nodes. | ||
3927 | * | ||
3928 | * If a locking change is made that will not be compatible with older | ||
3929 | * versions, the major number must be increased and the minor version set | ||
3930 | * to zero. If a change merely adds a behavior that can be disabled when | ||
3931 | * speaking to older versions, the minor version must be increased. If a | ||
3932 | * change adds a fully backwards compatible change (eg, LVB changes that | ||
3933 | * are just ignored by older versions), the version does not need to be | ||
3934 | * updated. | ||
3935 | */ | ||
3936 | static struct ocfs2_locking_protocol lproto = { | ||
3937 | .lp_max_version = { | ||
3938 | .pv_major = OCFS2_LOCKING_PROTOCOL_MAJOR, | ||
3939 | .pv_minor = OCFS2_LOCKING_PROTOCOL_MINOR, | ||
3940 | }, | ||
3941 | .lp_lock_ast = ocfs2_locking_ast, | ||
3942 | .lp_blocking_ast = ocfs2_blocking_ast, | ||
3943 | .lp_unlock_ast = ocfs2_unlock_ast, | ||
3944 | }; | ||
3945 | |||
3946 | void ocfs2_set_locking_protocol(void) | ||
3947 | { | ||
3948 | ocfs2_stack_glue_set_locking_protocol(&lproto); | ||
3949 | } | ||
3950 | |||
3951 | |||
3952 | static void ocfs2_process_blocked_lock(struct ocfs2_super *osb, | 3990 | static void ocfs2_process_blocked_lock(struct ocfs2_super *osb, |
3953 | struct ocfs2_lock_res *lockres) | 3991 | struct ocfs2_lock_res *lockres) |
3954 | { | 3992 | { |
@@ -3965,7 +4003,7 @@ static void ocfs2_process_blocked_lock(struct ocfs2_super *osb, | |||
3965 | BUG_ON(!lockres); | 4003 | BUG_ON(!lockres); |
3966 | BUG_ON(!lockres->l_ops); | 4004 | BUG_ON(!lockres->l_ops); |
3967 | 4005 | ||
3968 | mlog(0, "lockres %s blocked.\n", lockres->l_name); | 4006 | mlog(ML_BASTS, "lockres %s blocked\n", lockres->l_name); |
3969 | 4007 | ||
3970 | /* Detect whether a lock has been marked as going away while | 4008 | /* Detect whether a lock has been marked as going away while |
3971 | * the downconvert thread was processing other things. A lock can | 4009 | * the downconvert thread was processing other things. A lock can |
@@ -3988,7 +4026,7 @@ unqueue: | |||
3988 | } else | 4026 | } else |
3989 | ocfs2_schedule_blocked_lock(osb, lockres); | 4027 | ocfs2_schedule_blocked_lock(osb, lockres); |
3990 | 4028 | ||
3991 | mlog(0, "lockres %s, requeue = %s.\n", lockres->l_name, | 4029 | mlog(ML_BASTS, "lockres %s, requeue = %s.\n", lockres->l_name, |
3992 | ctl.requeue ? "yes" : "no"); | 4030 | ctl.requeue ? "yes" : "no"); |
3993 | spin_unlock_irqrestore(&lockres->l_lock, flags); | 4031 | spin_unlock_irqrestore(&lockres->l_lock, flags); |
3994 | 4032 | ||
@@ -4010,7 +4048,7 @@ static void ocfs2_schedule_blocked_lock(struct ocfs2_super *osb, | |||
4010 | /* Do not schedule a lock for downconvert when it's on | 4048 | /* Do not schedule a lock for downconvert when it's on |
4011 | * the way to destruction - any nodes wanting access | 4049 | * the way to destruction - any nodes wanting access |
4012 | * to the resource will get it soon. */ | 4050 | * to the resource will get it soon. */ |
4013 | mlog(0, "Lockres %s won't be scheduled: flags 0x%lx\n", | 4051 | mlog(ML_BASTS, "lockres %s won't be scheduled: flags 0x%lx\n", |
4014 | lockres->l_name, lockres->l_flags); | 4052 | lockres->l_name, lockres->l_flags); |
4015 | return; | 4053 | return; |
4016 | } | 4054 | } |
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index 558ce0312421..17947dc8341e 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c | |||
@@ -107,6 +107,9 @@ static int ocfs2_file_open(struct inode *inode, struct file *file) | |||
107 | mlog_entry("(0x%p, 0x%p, '%.*s')\n", inode, file, | 107 | mlog_entry("(0x%p, 0x%p, '%.*s')\n", inode, file, |
108 | file->f_path.dentry->d_name.len, file->f_path.dentry->d_name.name); | 108 | file->f_path.dentry->d_name.len, file->f_path.dentry->d_name.name); |
109 | 109 | ||
110 | if (file->f_mode & FMODE_WRITE) | ||
111 | dquot_initialize(inode); | ||
112 | |||
110 | spin_lock(&oi->ip_lock); | 113 | spin_lock(&oi->ip_lock); |
111 | 114 | ||
112 | /* Check that the inode hasn't been wiped from disk by another | 115 | /* Check that the inode hasn't been wiped from disk by another |
@@ -629,11 +632,10 @@ restart_all: | |||
629 | } | 632 | } |
630 | 633 | ||
631 | restarted_transaction: | 634 | restarted_transaction: |
632 | if (vfs_dq_alloc_space_nodirty(inode, ocfs2_clusters_to_bytes(osb->sb, | 635 | status = dquot_alloc_space_nodirty(inode, |
633 | clusters_to_add))) { | 636 | ocfs2_clusters_to_bytes(osb->sb, clusters_to_add)); |
634 | status = -EDQUOT; | 637 | if (status) |
635 | goto leave; | 638 | goto leave; |
636 | } | ||
637 | did_quota = 1; | 639 | did_quota = 1; |
638 | 640 | ||
639 | /* reserve a write to the file entry early on - that we if we | 641 | /* reserve a write to the file entry early on - that we if we |
@@ -674,7 +676,7 @@ restarted_transaction: | |||
674 | clusters_to_add -= (OCFS2_I(inode)->ip_clusters - prev_clusters); | 676 | clusters_to_add -= (OCFS2_I(inode)->ip_clusters - prev_clusters); |
675 | spin_unlock(&OCFS2_I(inode)->ip_lock); | 677 | spin_unlock(&OCFS2_I(inode)->ip_lock); |
676 | /* Release unused quota reservation */ | 678 | /* Release unused quota reservation */ |
677 | vfs_dq_free_space(inode, | 679 | dquot_free_space(inode, |
678 | ocfs2_clusters_to_bytes(osb->sb, clusters_to_add)); | 680 | ocfs2_clusters_to_bytes(osb->sb, clusters_to_add)); |
679 | did_quota = 0; | 681 | did_quota = 0; |
680 | 682 | ||
@@ -710,7 +712,7 @@ restarted_transaction: | |||
710 | 712 | ||
711 | leave: | 713 | leave: |
712 | if (status < 0 && did_quota) | 714 | if (status < 0 && did_quota) |
713 | vfs_dq_free_space(inode, | 715 | dquot_free_space(inode, |
714 | ocfs2_clusters_to_bytes(osb->sb, clusters_to_add)); | 716 | ocfs2_clusters_to_bytes(osb->sb, clusters_to_add)); |
715 | if (handle) { | 717 | if (handle) { |
716 | ocfs2_commit_trans(osb, handle); | 718 | ocfs2_commit_trans(osb, handle); |
@@ -978,6 +980,8 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr *attr) | |||
978 | 980 | ||
979 | size_change = S_ISREG(inode->i_mode) && attr->ia_valid & ATTR_SIZE; | 981 | size_change = S_ISREG(inode->i_mode) && attr->ia_valid & ATTR_SIZE; |
980 | if (size_change) { | 982 | if (size_change) { |
983 | dquot_initialize(inode); | ||
984 | |||
981 | status = ocfs2_rw_lock(inode, 1); | 985 | status = ocfs2_rw_lock(inode, 1); |
982 | if (status < 0) { | 986 | if (status < 0) { |
983 | mlog_errno(status); | 987 | mlog_errno(status); |
@@ -993,10 +997,9 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr *attr) | |||
993 | } | 997 | } |
994 | 998 | ||
995 | if (size_change && attr->ia_size != i_size_read(inode)) { | 999 | if (size_change && attr->ia_size != i_size_read(inode)) { |
996 | if (attr->ia_size > sb->s_maxbytes) { | 1000 | status = inode_newsize_ok(inode, attr->ia_size); |
997 | status = -EFBIG; | 1001 | if (status) |
998 | goto bail_unlock; | 1002 | goto bail_unlock; |
999 | } | ||
1000 | 1003 | ||
1001 | if (i_size_read(inode) > attr->ia_size) { | 1004 | if (i_size_read(inode) > attr->ia_size) { |
1002 | if (ocfs2_should_order_data(inode)) { | 1005 | if (ocfs2_should_order_data(inode)) { |
@@ -1021,7 +1024,7 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr *attr) | |||
1021 | /* | 1024 | /* |
1022 | * Gather pointers to quota structures so that allocation / | 1025 | * Gather pointers to quota structures so that allocation / |
1023 | * freeing of quota structures happens here and not inside | 1026 | * freeing of quota structures happens here and not inside |
1024 | * vfs_dq_transfer() where we have problems with lock ordering | 1027 | * dquot_transfer() where we have problems with lock ordering |
1025 | */ | 1028 | */ |
1026 | if (attr->ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid | 1029 | if (attr->ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid |
1027 | && OCFS2_HAS_RO_COMPAT_FEATURE(sb, | 1030 | && OCFS2_HAS_RO_COMPAT_FEATURE(sb, |
@@ -1054,7 +1057,7 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr *attr) | |||
1054 | mlog_errno(status); | 1057 | mlog_errno(status); |
1055 | goto bail_unlock; | 1058 | goto bail_unlock; |
1056 | } | 1059 | } |
1057 | status = vfs_dq_transfer(inode, attr) ? -EDQUOT : 0; | 1060 | status = dquot_transfer(inode, attr); |
1058 | if (status < 0) | 1061 | if (status < 0) |
1059 | goto bail_commit; | 1062 | goto bail_commit; |
1060 | } else { | 1063 | } else { |
@@ -1836,6 +1839,8 @@ static int ocfs2_prepare_inode_for_write(struct dentry *dentry, | |||
1836 | &meta_level); | 1839 | &meta_level); |
1837 | if (has_refcount) | 1840 | if (has_refcount) |
1838 | *has_refcount = 1; | 1841 | *has_refcount = 1; |
1842 | if (direct_io) | ||
1843 | *direct_io = 0; | ||
1839 | } | 1844 | } |
1840 | 1845 | ||
1841 | if (ret < 0) { | 1846 | if (ret < 0) { |
@@ -1859,10 +1864,6 @@ static int ocfs2_prepare_inode_for_write(struct dentry *dentry, | |||
1859 | break; | 1864 | break; |
1860 | } | 1865 | } |
1861 | 1866 | ||
1862 | if (has_refcount && *has_refcount == 1) { | ||
1863 | *direct_io = 0; | ||
1864 | break; | ||
1865 | } | ||
1866 | /* | 1867 | /* |
1867 | * Allowing concurrent direct writes means | 1868 | * Allowing concurrent direct writes means |
1868 | * i_size changes wouldn't be synchronized, so | 1869 | * i_size changes wouldn't be synchronized, so |
@@ -2043,7 +2044,7 @@ out_dio: | |||
2043 | * async dio is going to do it in the future or an end_io after an | 2044 | * async dio is going to do it in the future or an end_io after an |
2044 | * error has already done it. | 2045 | * error has already done it. |
2045 | */ | 2046 | */ |
2046 | if (ret == -EIOCBQUEUED || !ocfs2_iocb_is_rw_locked(iocb)) { | 2047 | if ((ret == -EIOCBQUEUED) || (!ocfs2_iocb_is_rw_locked(iocb))) { |
2047 | rw_level = -1; | 2048 | rw_level = -1; |
2048 | have_alloc_sem = 0; | 2049 | have_alloc_sem = 0; |
2049 | } | 2050 | } |
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index 88459bdd1ff3..278a223aae14 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c | |||
@@ -665,7 +665,7 @@ static int ocfs2_remove_inode(struct inode *inode, | |||
665 | } | 665 | } |
666 | 666 | ||
667 | ocfs2_remove_from_cache(INODE_CACHE(inode), di_bh); | 667 | ocfs2_remove_from_cache(INODE_CACHE(inode), di_bh); |
668 | vfs_dq_free_inode(inode); | 668 | dquot_free_inode(inode); |
669 | 669 | ||
670 | status = ocfs2_free_dinode(handle, inode_alloc_inode, | 670 | status = ocfs2_free_dinode(handle, inode_alloc_inode, |
671 | inode_alloc_bh, di); | 671 | inode_alloc_bh, di); |
@@ -971,6 +971,8 @@ void ocfs2_delete_inode(struct inode *inode) | |||
971 | goto bail; | 971 | goto bail; |
972 | } | 972 | } |
973 | 973 | ||
974 | dquot_initialize(inode); | ||
975 | |||
974 | if (!ocfs2_inode_is_valid_to_delete(inode)) { | 976 | if (!ocfs2_inode_is_valid_to_delete(inode)) { |
975 | /* It's probably not necessary to truncate_inode_pages | 977 | /* It's probably not necessary to truncate_inode_pages |
976 | * here but we do it for safety anyway (it will most | 978 | * here but we do it for safety anyway (it will most |
@@ -1087,6 +1089,8 @@ void ocfs2_clear_inode(struct inode *inode) | |||
1087 | mlog_bug_on_msg(OCFS2_SB(inode->i_sb) == NULL, | 1089 | mlog_bug_on_msg(OCFS2_SB(inode->i_sb) == NULL, |
1088 | "Inode=%lu\n", inode->i_ino); | 1090 | "Inode=%lu\n", inode->i_ino); |
1089 | 1091 | ||
1092 | dquot_drop(inode); | ||
1093 | |||
1090 | /* To preven remote deletes we hold open lock before, now it | 1094 | /* To preven remote deletes we hold open lock before, now it |
1091 | * is time to unlock PR and EX open locks. */ | 1095 | * is time to unlock PR and EX open locks. */ |
1092 | ocfs2_open_unlock(inode); | 1096 | ocfs2_open_unlock(inode); |
diff --git a/fs/ocfs2/ioctl.h b/fs/ocfs2/ioctl.h index cf9a5ee30fef..0cd5323bd3f0 100644 --- a/fs/ocfs2/ioctl.h +++ b/fs/ocfs2/ioctl.h | |||
@@ -7,10 +7,10 @@ | |||
7 | * | 7 | * |
8 | */ | 8 | */ |
9 | 9 | ||
10 | #ifndef OCFS2_IOCTL_H | 10 | #ifndef OCFS2_IOCTL_PROTO_H |
11 | #define OCFS2_IOCTL_H | 11 | #define OCFS2_IOCTL_PROTO_H |
12 | 12 | ||
13 | long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg); | 13 | long ocfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg); |
14 | long ocfs2_compat_ioctl(struct file *file, unsigned cmd, unsigned long arg); | 14 | long ocfs2_compat_ioctl(struct file *file, unsigned cmd, unsigned long arg); |
15 | 15 | ||
16 | #endif /* OCFS2_IOCTL_H */ | 16 | #endif /* OCFS2_IOCTL_PROTO_H */ |
diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c index ac10f83edb95..ca992d91f511 100644 --- a/fs/ocfs2/localalloc.c +++ b/fs/ocfs2/localalloc.c | |||
@@ -476,7 +476,7 @@ out_mutex: | |||
476 | 476 | ||
477 | out: | 477 | out: |
478 | if (!status) | 478 | if (!status) |
479 | ocfs2_init_inode_steal_slot(osb); | 479 | ocfs2_init_steal_slots(osb); |
480 | mlog_exit(status); | 480 | mlog_exit(status); |
481 | return status; | 481 | return status; |
482 | } | 482 | } |
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 50fb26a6a5f5..d9cd4e373a53 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c | |||
@@ -212,7 +212,7 @@ static struct inode *ocfs2_get_init_inode(struct inode *dir, int mode) | |||
212 | } else | 212 | } else |
213 | inode->i_gid = current_fsgid(); | 213 | inode->i_gid = current_fsgid(); |
214 | inode->i_mode = mode; | 214 | inode->i_mode = mode; |
215 | vfs_dq_init(inode); | 215 | dquot_initialize(inode); |
216 | return inode; | 216 | return inode; |
217 | } | 217 | } |
218 | 218 | ||
@@ -244,6 +244,8 @@ static int ocfs2_mknod(struct inode *dir, | |||
244 | (unsigned long)dev, dentry->d_name.len, | 244 | (unsigned long)dev, dentry->d_name.len, |
245 | dentry->d_name.name); | 245 | dentry->d_name.name); |
246 | 246 | ||
247 | dquot_initialize(dir); | ||
248 | |||
247 | /* get our super block */ | 249 | /* get our super block */ |
248 | osb = OCFS2_SB(dir->i_sb); | 250 | osb = OCFS2_SB(dir->i_sb); |
249 | 251 | ||
@@ -348,13 +350,9 @@ static int ocfs2_mknod(struct inode *dir, | |||
348 | goto leave; | 350 | goto leave; |
349 | } | 351 | } |
350 | 352 | ||
351 | /* We don't use standard VFS wrapper because we don't want vfs_dq_init | 353 | status = dquot_alloc_inode(inode); |
352 | * to be called. */ | 354 | if (status) |
353 | if (sb_any_quota_active(osb->sb) && | ||
354 | osb->sb->dq_op->alloc_inode(inode, 1) == NO_QUOTA) { | ||
355 | status = -EDQUOT; | ||
356 | goto leave; | 355 | goto leave; |
357 | } | ||
358 | did_quota_inode = 1; | 356 | did_quota_inode = 1; |
359 | 357 | ||
360 | mlog_entry("(0x%p, 0x%p, %d, %lu, '%.*s')\n", dir, dentry, | 358 | mlog_entry("(0x%p, 0x%p, %d, %lu, '%.*s')\n", dir, dentry, |
@@ -431,7 +429,7 @@ static int ocfs2_mknod(struct inode *dir, | |||
431 | status = 0; | 429 | status = 0; |
432 | leave: | 430 | leave: |
433 | if (status < 0 && did_quota_inode) | 431 | if (status < 0 && did_quota_inode) |
434 | vfs_dq_free_inode(inode); | 432 | dquot_free_inode(inode); |
435 | if (handle) | 433 | if (handle) |
436 | ocfs2_commit_trans(osb, handle); | 434 | ocfs2_commit_trans(osb, handle); |
437 | 435 | ||
@@ -636,6 +634,8 @@ static int ocfs2_link(struct dentry *old_dentry, | |||
636 | if (S_ISDIR(inode->i_mode)) | 634 | if (S_ISDIR(inode->i_mode)) |
637 | return -EPERM; | 635 | return -EPERM; |
638 | 636 | ||
637 | dquot_initialize(dir); | ||
638 | |||
639 | err = ocfs2_inode_lock_nested(dir, &parent_fe_bh, 1, OI_LS_PARENT); | 639 | err = ocfs2_inode_lock_nested(dir, &parent_fe_bh, 1, OI_LS_PARENT); |
640 | if (err < 0) { | 640 | if (err < 0) { |
641 | if (err != -ENOENT) | 641 | if (err != -ENOENT) |
@@ -791,6 +791,8 @@ static int ocfs2_unlink(struct inode *dir, | |||
791 | mlog_entry("(0x%p, 0x%p, '%.*s')\n", dir, dentry, | 791 | mlog_entry("(0x%p, 0x%p, '%.*s')\n", dir, dentry, |
792 | dentry->d_name.len, dentry->d_name.name); | 792 | dentry->d_name.len, dentry->d_name.name); |
793 | 793 | ||
794 | dquot_initialize(dir); | ||
795 | |||
794 | BUG_ON(dentry->d_parent->d_inode != dir); | 796 | BUG_ON(dentry->d_parent->d_inode != dir); |
795 | 797 | ||
796 | mlog(0, "ino = %llu\n", (unsigned long long)OCFS2_I(inode)->ip_blkno); | 798 | mlog(0, "ino = %llu\n", (unsigned long long)OCFS2_I(inode)->ip_blkno); |
@@ -1051,6 +1053,9 @@ static int ocfs2_rename(struct inode *old_dir, | |||
1051 | old_dentry->d_name.len, old_dentry->d_name.name, | 1053 | old_dentry->d_name.len, old_dentry->d_name.name, |
1052 | new_dentry->d_name.len, new_dentry->d_name.name); | 1054 | new_dentry->d_name.len, new_dentry->d_name.name); |
1053 | 1055 | ||
1056 | dquot_initialize(old_dir); | ||
1057 | dquot_initialize(new_dir); | ||
1058 | |||
1054 | osb = OCFS2_SB(old_dir->i_sb); | 1059 | osb = OCFS2_SB(old_dir->i_sb); |
1055 | 1060 | ||
1056 | if (new_inode) { | 1061 | if (new_inode) { |
@@ -1599,6 +1604,8 @@ static int ocfs2_symlink(struct inode *dir, | |||
1599 | mlog_entry("(0x%p, 0x%p, symname='%s' actual='%.*s')\n", dir, | 1604 | mlog_entry("(0x%p, 0x%p, symname='%s' actual='%.*s')\n", dir, |
1600 | dentry, symname, dentry->d_name.len, dentry->d_name.name); | 1605 | dentry, symname, dentry->d_name.len, dentry->d_name.name); |
1601 | 1606 | ||
1607 | dquot_initialize(dir); | ||
1608 | |||
1602 | sb = dir->i_sb; | 1609 | sb = dir->i_sb; |
1603 | osb = OCFS2_SB(sb); | 1610 | osb = OCFS2_SB(sb); |
1604 | 1611 | ||
@@ -1688,13 +1695,9 @@ static int ocfs2_symlink(struct inode *dir, | |||
1688 | goto bail; | 1695 | goto bail; |
1689 | } | 1696 | } |
1690 | 1697 | ||
1691 | /* We don't use standard VFS wrapper because we don't want vfs_dq_init | 1698 | status = dquot_alloc_inode(inode); |
1692 | * to be called. */ | 1699 | if (status) |
1693 | if (sb_any_quota_active(osb->sb) && | ||
1694 | osb->sb->dq_op->alloc_inode(inode, 1) == NO_QUOTA) { | ||
1695 | status = -EDQUOT; | ||
1696 | goto bail; | 1700 | goto bail; |
1697 | } | ||
1698 | did_quota_inode = 1; | 1701 | did_quota_inode = 1; |
1699 | 1702 | ||
1700 | mlog_entry("(0x%p, 0x%p, %d, '%.*s')\n", dir, dentry, | 1703 | mlog_entry("(0x%p, 0x%p, %d, '%.*s')\n", dir, dentry, |
@@ -1716,11 +1719,10 @@ static int ocfs2_symlink(struct inode *dir, | |||
1716 | u32 offset = 0; | 1719 | u32 offset = 0; |
1717 | 1720 | ||
1718 | inode->i_op = &ocfs2_symlink_inode_operations; | 1721 | inode->i_op = &ocfs2_symlink_inode_operations; |
1719 | if (vfs_dq_alloc_space_nodirty(inode, | 1722 | status = dquot_alloc_space_nodirty(inode, |
1720 | ocfs2_clusters_to_bytes(osb->sb, 1))) { | 1723 | ocfs2_clusters_to_bytes(osb->sb, 1)); |
1721 | status = -EDQUOT; | 1724 | if (status) |
1722 | goto bail; | 1725 | goto bail; |
1723 | } | ||
1724 | did_quota = 1; | 1726 | did_quota = 1; |
1725 | status = ocfs2_add_inode_data(osb, inode, &offset, 1, 0, | 1727 | status = ocfs2_add_inode_data(osb, inode, &offset, 1, 0, |
1726 | new_fe_bh, | 1728 | new_fe_bh, |
@@ -1788,10 +1790,10 @@ static int ocfs2_symlink(struct inode *dir, | |||
1788 | d_instantiate(dentry, inode); | 1790 | d_instantiate(dentry, inode); |
1789 | bail: | 1791 | bail: |
1790 | if (status < 0 && did_quota) | 1792 | if (status < 0 && did_quota) |
1791 | vfs_dq_free_space_nodirty(inode, | 1793 | dquot_free_space_nodirty(inode, |
1792 | ocfs2_clusters_to_bytes(osb->sb, 1)); | 1794 | ocfs2_clusters_to_bytes(osb->sb, 1)); |
1793 | if (status < 0 && did_quota_inode) | 1795 | if (status < 0 && did_quota_inode) |
1794 | vfs_dq_free_inode(inode); | 1796 | dquot_free_inode(inode); |
1795 | if (handle) | 1797 | if (handle) |
1796 | ocfs2_commit_trans(osb, handle); | 1798 | ocfs2_commit_trans(osb, handle); |
1797 | 1799 | ||
@@ -2099,13 +2101,9 @@ int ocfs2_create_inode_in_orphan(struct inode *dir, | |||
2099 | goto leave; | 2101 | goto leave; |
2100 | } | 2102 | } |
2101 | 2103 | ||
2102 | /* We don't use standard VFS wrapper because we don't want vfs_dq_init | 2104 | status = dquot_alloc_inode(inode); |
2103 | * to be called. */ | 2105 | if (status) |
2104 | if (sb_any_quota_active(osb->sb) && | ||
2105 | osb->sb->dq_op->alloc_inode(inode, 1) == NO_QUOTA) { | ||
2106 | status = -EDQUOT; | ||
2107 | goto leave; | 2106 | goto leave; |
2108 | } | ||
2109 | did_quota_inode = 1; | 2107 | did_quota_inode = 1; |
2110 | 2108 | ||
2111 | inode->i_nlink = 0; | 2109 | inode->i_nlink = 0; |
@@ -2140,7 +2138,7 @@ int ocfs2_create_inode_in_orphan(struct inode *dir, | |||
2140 | insert_inode_hash(inode); | 2138 | insert_inode_hash(inode); |
2141 | leave: | 2139 | leave: |
2142 | if (status < 0 && did_quota_inode) | 2140 | if (status < 0 && did_quota_inode) |
2143 | vfs_dq_free_inode(inode); | 2141 | dquot_free_inode(inode); |
2144 | if (handle) | 2142 | if (handle) |
2145 | ocfs2_commit_trans(osb, handle); | 2143 | ocfs2_commit_trans(osb, handle); |
2146 | 2144 | ||
diff --git a/fs/ocfs2/ocfs2.h b/fs/ocfs2/ocfs2.h index 740f448041e2..1238b491db90 100644 --- a/fs/ocfs2/ocfs2.h +++ b/fs/ocfs2/ocfs2.h | |||
@@ -42,6 +42,7 @@ | |||
42 | 42 | ||
43 | #include "ocfs2_fs.h" | 43 | #include "ocfs2_fs.h" |
44 | #include "ocfs2_lockid.h" | 44 | #include "ocfs2_lockid.h" |
45 | #include "ocfs2_ioctl.h" | ||
45 | 46 | ||
46 | /* For struct ocfs2_blockcheck_stats */ | 47 | /* For struct ocfs2_blockcheck_stats */ |
47 | #include "blockcheck.h" | 48 | #include "blockcheck.h" |
@@ -159,7 +160,7 @@ struct ocfs2_lock_res { | |||
159 | int l_level; | 160 | int l_level; |
160 | unsigned int l_ro_holders; | 161 | unsigned int l_ro_holders; |
161 | unsigned int l_ex_holders; | 162 | unsigned int l_ex_holders; |
162 | union ocfs2_dlm_lksb l_lksb; | 163 | struct ocfs2_dlm_lksb l_lksb; |
163 | 164 | ||
164 | /* used from AST/BAST funcs. */ | 165 | /* used from AST/BAST funcs. */ |
165 | enum ocfs2_ast_action l_action; | 166 | enum ocfs2_ast_action l_action; |
@@ -305,7 +306,9 @@ struct ocfs2_super | |||
305 | u32 s_next_generation; | 306 | u32 s_next_generation; |
306 | unsigned long osb_flags; | 307 | unsigned long osb_flags; |
307 | s16 s_inode_steal_slot; | 308 | s16 s_inode_steal_slot; |
309 | s16 s_meta_steal_slot; | ||
308 | atomic_t s_num_inodes_stolen; | 310 | atomic_t s_num_inodes_stolen; |
311 | atomic_t s_num_meta_stolen; | ||
309 | 312 | ||
310 | unsigned long s_mount_opt; | 313 | unsigned long s_mount_opt; |
311 | unsigned int s_atime_quantum; | 314 | unsigned int s_atime_quantum; |
@@ -760,33 +763,6 @@ static inline unsigned int ocfs2_megabytes_to_clusters(struct super_block *sb, | |||
760 | return megs << (20 - OCFS2_SB(sb)->s_clustersize_bits); | 763 | return megs << (20 - OCFS2_SB(sb)->s_clustersize_bits); |
761 | } | 764 | } |
762 | 765 | ||
763 | static inline void ocfs2_init_inode_steal_slot(struct ocfs2_super *osb) | ||
764 | { | ||
765 | spin_lock(&osb->osb_lock); | ||
766 | osb->s_inode_steal_slot = OCFS2_INVALID_SLOT; | ||
767 | spin_unlock(&osb->osb_lock); | ||
768 | atomic_set(&osb->s_num_inodes_stolen, 0); | ||
769 | } | ||
770 | |||
771 | static inline void ocfs2_set_inode_steal_slot(struct ocfs2_super *osb, | ||
772 | s16 slot) | ||
773 | { | ||
774 | spin_lock(&osb->osb_lock); | ||
775 | osb->s_inode_steal_slot = slot; | ||
776 | spin_unlock(&osb->osb_lock); | ||
777 | } | ||
778 | |||
779 | static inline s16 ocfs2_get_inode_steal_slot(struct ocfs2_super *osb) | ||
780 | { | ||
781 | s16 slot; | ||
782 | |||
783 | spin_lock(&osb->osb_lock); | ||
784 | slot = osb->s_inode_steal_slot; | ||
785 | spin_unlock(&osb->osb_lock); | ||
786 | |||
787 | return slot; | ||
788 | } | ||
789 | |||
790 | #define ocfs2_set_bit ext2_set_bit | 766 | #define ocfs2_set_bit ext2_set_bit |
791 | #define ocfs2_clear_bit ext2_clear_bit | 767 | #define ocfs2_clear_bit ext2_clear_bit |
792 | #define ocfs2_test_bit ext2_test_bit | 768 | #define ocfs2_test_bit ext2_test_bit |
diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h index 7638a38c32bc..bb37218a7978 100644 --- a/fs/ocfs2/ocfs2_fs.h +++ b/fs/ocfs2/ocfs2_fs.h | |||
@@ -254,63 +254,6 @@ | |||
254 | * refcount tree */ | 254 | * refcount tree */ |
255 | 255 | ||
256 | /* | 256 | /* |
257 | * ioctl commands | ||
258 | */ | ||
259 | #define OCFS2_IOC_GETFLAGS _IOR('f', 1, long) | ||
260 | #define OCFS2_IOC_SETFLAGS _IOW('f', 2, long) | ||
261 | #define OCFS2_IOC32_GETFLAGS _IOR('f', 1, int) | ||
262 | #define OCFS2_IOC32_SETFLAGS _IOW('f', 2, int) | ||
263 | |||
264 | /* | ||
265 | * Space reservation / allocation / free ioctls and argument structure | ||
266 | * are designed to be compatible with XFS. | ||
267 | * | ||
268 | * ALLOCSP* and FREESP* are not and will never be supported, but are | ||
269 | * included here for completeness. | ||
270 | */ | ||
271 | struct ocfs2_space_resv { | ||
272 | __s16 l_type; | ||
273 | __s16 l_whence; | ||
274 | __s64 l_start; | ||
275 | __s64 l_len; /* len == 0 means until end of file */ | ||
276 | __s32 l_sysid; | ||
277 | __u32 l_pid; | ||
278 | __s32 l_pad[4]; /* reserve area */ | ||
279 | }; | ||
280 | |||
281 | #define OCFS2_IOC_ALLOCSP _IOW ('X', 10, struct ocfs2_space_resv) | ||
282 | #define OCFS2_IOC_FREESP _IOW ('X', 11, struct ocfs2_space_resv) | ||
283 | #define OCFS2_IOC_RESVSP _IOW ('X', 40, struct ocfs2_space_resv) | ||
284 | #define OCFS2_IOC_UNRESVSP _IOW ('X', 41, struct ocfs2_space_resv) | ||
285 | #define OCFS2_IOC_ALLOCSP64 _IOW ('X', 36, struct ocfs2_space_resv) | ||
286 | #define OCFS2_IOC_FREESP64 _IOW ('X', 37, struct ocfs2_space_resv) | ||
287 | #define OCFS2_IOC_RESVSP64 _IOW ('X', 42, struct ocfs2_space_resv) | ||
288 | #define OCFS2_IOC_UNRESVSP64 _IOW ('X', 43, struct ocfs2_space_resv) | ||
289 | |||
290 | /* Used to pass group descriptor data when online resize is done */ | ||
291 | struct ocfs2_new_group_input { | ||
292 | __u64 group; /* Group descriptor's blkno. */ | ||
293 | __u32 clusters; /* Total number of clusters in this group */ | ||
294 | __u32 frees; /* Total free clusters in this group */ | ||
295 | __u16 chain; /* Chain for this group */ | ||
296 | __u16 reserved1; | ||
297 | __u32 reserved2; | ||
298 | }; | ||
299 | |||
300 | #define OCFS2_IOC_GROUP_EXTEND _IOW('o', 1, int) | ||
301 | #define OCFS2_IOC_GROUP_ADD _IOW('o', 2,struct ocfs2_new_group_input) | ||
302 | #define OCFS2_IOC_GROUP_ADD64 _IOW('o', 3,struct ocfs2_new_group_input) | ||
303 | |||
304 | /* Used to pass 2 file names to reflink. */ | ||
305 | struct reflink_arguments { | ||
306 | __u64 old_path; | ||
307 | __u64 new_path; | ||
308 | __u64 preserve; | ||
309 | }; | ||
310 | #define OCFS2_IOC_REFLINK _IOW('o', 4, struct reflink_arguments) | ||
311 | |||
312 | |||
313 | /* | ||
314 | * Journal Flags (ocfs2_dinode.id1.journal1.i_flags) | 257 | * Journal Flags (ocfs2_dinode.id1.journal1.i_flags) |
315 | */ | 258 | */ |
316 | #define OCFS2_JOURNAL_DIRTY_FL (0x00000001) /* Journal needs recovery */ | 259 | #define OCFS2_JOURNAL_DIRTY_FL (0x00000001) /* Journal needs recovery */ |
diff --git a/fs/ocfs2/ocfs2_ioctl.h b/fs/ocfs2/ocfs2_ioctl.h new file mode 100644 index 000000000000..2d3420af1a83 --- /dev/null +++ b/fs/ocfs2/ocfs2_ioctl.h | |||
@@ -0,0 +1,79 @@ | |||
1 | /* -*- mode: c; c-basic-offset: 8; -*- | ||
2 | * vim: noexpandtab sw=8 ts=8 sts=0: | ||
3 | * | ||
4 | * ocfs2_ioctl.h | ||
5 | * | ||
6 | * Defines OCFS2 ioctls. | ||
7 | * | ||
8 | * Copyright (C) 2010 Oracle. All rights reserved. | ||
9 | * | ||
10 | * This program is free software; you can redistribute it and/or | ||
11 | * modify it under the terms of the GNU General Public | ||
12 | * License, version 2, as published by the Free Software Foundation. | ||
13 | * | ||
14 | * This program is distributed in the hope that it will be useful, | ||
15 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
16 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
17 | * General Public License for more details. | ||
18 | */ | ||
19 | |||
20 | #ifndef OCFS2_IOCTL_H | ||
21 | #define OCFS2_IOCTL_H | ||
22 | |||
23 | /* | ||
24 | * ioctl commands | ||
25 | */ | ||
26 | #define OCFS2_IOC_GETFLAGS _IOR('f', 1, long) | ||
27 | #define OCFS2_IOC_SETFLAGS _IOW('f', 2, long) | ||
28 | #define OCFS2_IOC32_GETFLAGS _IOR('f', 1, int) | ||
29 | #define OCFS2_IOC32_SETFLAGS _IOW('f', 2, int) | ||
30 | |||
31 | /* | ||
32 | * Space reservation / allocation / free ioctls and argument structure | ||
33 | * are designed to be compatible with XFS. | ||
34 | * | ||
35 | * ALLOCSP* and FREESP* are not and will never be supported, but are | ||
36 | * included here for completeness. | ||
37 | */ | ||
38 | struct ocfs2_space_resv { | ||
39 | __s16 l_type; | ||
40 | __s16 l_whence; | ||
41 | __s64 l_start; | ||
42 | __s64 l_len; /* len == 0 means until end of file */ | ||
43 | __s32 l_sysid; | ||
44 | __u32 l_pid; | ||
45 | __s32 l_pad[4]; /* reserve area */ | ||
46 | }; | ||
47 | |||
48 | #define OCFS2_IOC_ALLOCSP _IOW ('X', 10, struct ocfs2_space_resv) | ||
49 | #define OCFS2_IOC_FREESP _IOW ('X', 11, struct ocfs2_space_resv) | ||
50 | #define OCFS2_IOC_RESVSP _IOW ('X', 40, struct ocfs2_space_resv) | ||
51 | #define OCFS2_IOC_UNRESVSP _IOW ('X', 41, struct ocfs2_space_resv) | ||
52 | #define OCFS2_IOC_ALLOCSP64 _IOW ('X', 36, struct ocfs2_space_resv) | ||
53 | #define OCFS2_IOC_FREESP64 _IOW ('X', 37, struct ocfs2_space_resv) | ||
54 | #define OCFS2_IOC_RESVSP64 _IOW ('X', 42, struct ocfs2_space_resv) | ||
55 | #define OCFS2_IOC_UNRESVSP64 _IOW ('X', 43, struct ocfs2_space_resv) | ||
56 | |||
57 | /* Used to pass group descriptor data when online resize is done */ | ||
58 | struct ocfs2_new_group_input { | ||
59 | __u64 group; /* Group descriptor's blkno. */ | ||
60 | __u32 clusters; /* Total number of clusters in this group */ | ||
61 | __u32 frees; /* Total free clusters in this group */ | ||
62 | __u16 chain; /* Chain for this group */ | ||
63 | __u16 reserved1; | ||
64 | __u32 reserved2; | ||
65 | }; | ||
66 | |||
67 | #define OCFS2_IOC_GROUP_EXTEND _IOW('o', 1, int) | ||
68 | #define OCFS2_IOC_GROUP_ADD _IOW('o', 2,struct ocfs2_new_group_input) | ||
69 | #define OCFS2_IOC_GROUP_ADD64 _IOW('o', 3,struct ocfs2_new_group_input) | ||
70 | |||
71 | /* Used to pass 2 file names to reflink. */ | ||
72 | struct reflink_arguments { | ||
73 | __u64 old_path; | ||
74 | __u64 new_path; | ||
75 | __u64 preserve; | ||
76 | }; | ||
77 | #define OCFS2_IOC_REFLINK _IOW('o', 4, struct reflink_arguments) | ||
78 | |||
79 | #endif /* OCFS2_IOCTL_H */ | ||
diff --git a/fs/ocfs2/ocfs2_lockingver.h b/fs/ocfs2/ocfs2_lockingver.h index 82d5eeac0fff..2e45c8d2ea7e 100644 --- a/fs/ocfs2/ocfs2_lockingver.h +++ b/fs/ocfs2/ocfs2_lockingver.h | |||
@@ -23,6 +23,8 @@ | |||
23 | /* | 23 | /* |
24 | * The protocol version for ocfs2 cluster locking. See dlmglue.c for | 24 | * The protocol version for ocfs2 cluster locking. See dlmglue.c for |
25 | * more details. | 25 | * more details. |
26 | * | ||
27 | * 1.0 - Initial locking version from ocfs2 1.4. | ||
26 | */ | 28 | */ |
27 | #define OCFS2_LOCKING_PROTOCOL_MAJOR 1 | 29 | #define OCFS2_LOCKING_PROTOCOL_MAJOR 1 |
28 | #define OCFS2_LOCKING_PROTOCOL_MINOR 0 | 30 | #define OCFS2_LOCKING_PROTOCOL_MINOR 0 |
diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c index b437dc0c4cad..355f41d1d520 100644 --- a/fs/ocfs2/quota_global.c +++ b/fs/ocfs2/quota_global.c | |||
@@ -851,13 +851,6 @@ static void ocfs2_destroy_dquot(struct dquot *dquot) | |||
851 | } | 851 | } |
852 | 852 | ||
853 | const struct dquot_operations ocfs2_quota_operations = { | 853 | const struct dquot_operations ocfs2_quota_operations = { |
854 | .initialize = dquot_initialize, | ||
855 | .drop = dquot_drop, | ||
856 | .alloc_space = dquot_alloc_space, | ||
857 | .alloc_inode = dquot_alloc_inode, | ||
858 | .free_space = dquot_free_space, | ||
859 | .free_inode = dquot_free_inode, | ||
860 | .transfer = dquot_transfer, | ||
861 | .write_dquot = ocfs2_write_dquot, | 854 | .write_dquot = ocfs2_write_dquot, |
862 | .acquire_dquot = ocfs2_acquire_dquot, | 855 | .acquire_dquot = ocfs2_acquire_dquot, |
863 | .release_dquot = ocfs2_release_dquot, | 856 | .release_dquot = ocfs2_release_dquot, |
diff --git a/fs/ocfs2/quota_local.c b/fs/ocfs2/quota_local.c index 21f9e71223ca..a6467f3d262e 100644 --- a/fs/ocfs2/quota_local.c +++ b/fs/ocfs2/quota_local.c | |||
@@ -457,7 +457,7 @@ static int ocfs2_recover_local_quota_file(struct inode *lqinode, | |||
457 | break; | 457 | break; |
458 | } | 458 | } |
459 | dchunk = (struct ocfs2_local_disk_chunk *)hbh->b_data; | 459 | dchunk = (struct ocfs2_local_disk_chunk *)hbh->b_data; |
460 | for_each_bit(bit, rchunk->rc_bitmap, ol_chunk_entries(sb)) { | 460 | for_each_set_bit(bit, rchunk->rc_bitmap, ol_chunk_entries(sb)) { |
461 | qbh = NULL; | 461 | qbh = NULL; |
462 | status = ocfs2_read_quota_block(lqinode, | 462 | status = ocfs2_read_quota_block(lqinode, |
463 | ol_dqblk_block(sb, chunk, bit), | 463 | ol_dqblk_block(sb, chunk, bit), |
diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c index 8ae65c9c020c..9e96921dffda 100644 --- a/fs/ocfs2/refcounttree.c +++ b/fs/ocfs2/refcounttree.c | |||
@@ -626,7 +626,7 @@ static int ocfs2_create_refcount_tree(struct inode *inode, | |||
626 | rb = (struct ocfs2_refcount_block *)new_bh->b_data; | 626 | rb = (struct ocfs2_refcount_block *)new_bh->b_data; |
627 | memset(rb, 0, inode->i_sb->s_blocksize); | 627 | memset(rb, 0, inode->i_sb->s_blocksize); |
628 | strcpy((void *)rb, OCFS2_REFCOUNT_BLOCK_SIGNATURE); | 628 | strcpy((void *)rb, OCFS2_REFCOUNT_BLOCK_SIGNATURE); |
629 | rb->rf_suballoc_slot = cpu_to_le16(osb->slot_num); | 629 | rb->rf_suballoc_slot = cpu_to_le16(meta_ac->ac_alloc_slot); |
630 | rb->rf_suballoc_bit = cpu_to_le16(suballoc_bit_start); | 630 | rb->rf_suballoc_bit = cpu_to_le16(suballoc_bit_start); |
631 | rb->rf_fs_generation = cpu_to_le32(osb->fs_generation); | 631 | rb->rf_fs_generation = cpu_to_le32(osb->fs_generation); |
632 | rb->rf_blkno = cpu_to_le64(first_blkno); | 632 | rb->rf_blkno = cpu_to_le64(first_blkno); |
@@ -1330,7 +1330,7 @@ static int ocfs2_expand_inline_ref_root(handle_t *handle, | |||
1330 | memcpy(new_bh->b_data, ref_root_bh->b_data, sb->s_blocksize); | 1330 | memcpy(new_bh->b_data, ref_root_bh->b_data, sb->s_blocksize); |
1331 | 1331 | ||
1332 | new_rb = (struct ocfs2_refcount_block *)new_bh->b_data; | 1332 | new_rb = (struct ocfs2_refcount_block *)new_bh->b_data; |
1333 | new_rb->rf_suballoc_slot = cpu_to_le16(OCFS2_SB(sb)->slot_num); | 1333 | new_rb->rf_suballoc_slot = cpu_to_le16(meta_ac->ac_alloc_slot); |
1334 | new_rb->rf_suballoc_bit = cpu_to_le16(suballoc_bit_start); | 1334 | new_rb->rf_suballoc_bit = cpu_to_le16(suballoc_bit_start); |
1335 | new_rb->rf_blkno = cpu_to_le64(blkno); | 1335 | new_rb->rf_blkno = cpu_to_le64(blkno); |
1336 | new_rb->rf_cpos = cpu_to_le32(0); | 1336 | new_rb->rf_cpos = cpu_to_le32(0); |
@@ -1576,7 +1576,7 @@ static int ocfs2_new_leaf_refcount_block(handle_t *handle, | |||
1576 | new_rb = (struct ocfs2_refcount_block *)new_bh->b_data; | 1576 | new_rb = (struct ocfs2_refcount_block *)new_bh->b_data; |
1577 | memset(new_rb, 0, sb->s_blocksize); | 1577 | memset(new_rb, 0, sb->s_blocksize); |
1578 | strcpy((void *)new_rb, OCFS2_REFCOUNT_BLOCK_SIGNATURE); | 1578 | strcpy((void *)new_rb, OCFS2_REFCOUNT_BLOCK_SIGNATURE); |
1579 | new_rb->rf_suballoc_slot = cpu_to_le16(OCFS2_SB(sb)->slot_num); | 1579 | new_rb->rf_suballoc_slot = cpu_to_le16(meta_ac->ac_alloc_slot); |
1580 | new_rb->rf_suballoc_bit = cpu_to_le16(suballoc_bit_start); | 1580 | new_rb->rf_suballoc_bit = cpu_to_le16(suballoc_bit_start); |
1581 | new_rb->rf_fs_generation = cpu_to_le32(OCFS2_SB(sb)->fs_generation); | 1581 | new_rb->rf_fs_generation = cpu_to_le32(OCFS2_SB(sb)->fs_generation); |
1582 | new_rb->rf_blkno = cpu_to_le64(blkno); | 1582 | new_rb->rf_blkno = cpu_to_le64(blkno); |
@@ -4390,7 +4390,7 @@ static int ocfs2_vfs_reflink(struct dentry *old_dentry, struct inode *dir, | |||
4390 | } | 4390 | } |
4391 | 4391 | ||
4392 | mutex_lock(&inode->i_mutex); | 4392 | mutex_lock(&inode->i_mutex); |
4393 | vfs_dq_init(dir); | 4393 | dquot_initialize(dir); |
4394 | error = ocfs2_reflink(old_dentry, dir, new_dentry, preserve); | 4394 | error = ocfs2_reflink(old_dentry, dir, new_dentry, preserve); |
4395 | mutex_unlock(&inode->i_mutex); | 4395 | mutex_unlock(&inode->i_mutex); |
4396 | if (!error) | 4396 | if (!error) |
diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c index 3038c92af493..7020e1253ffa 100644 --- a/fs/ocfs2/stack_o2cb.c +++ b/fs/ocfs2/stack_o2cb.c | |||
@@ -161,24 +161,23 @@ static int dlm_status_to_errno(enum dlm_status status) | |||
161 | 161 | ||
162 | static void o2dlm_lock_ast_wrapper(void *astarg) | 162 | static void o2dlm_lock_ast_wrapper(void *astarg) |
163 | { | 163 | { |
164 | BUG_ON(o2cb_stack.sp_proto == NULL); | 164 | struct ocfs2_dlm_lksb *lksb = astarg; |
165 | 165 | ||
166 | o2cb_stack.sp_proto->lp_lock_ast(astarg); | 166 | lksb->lksb_conn->cc_proto->lp_lock_ast(lksb); |
167 | } | 167 | } |
168 | 168 | ||
169 | static void o2dlm_blocking_ast_wrapper(void *astarg, int level) | 169 | static void o2dlm_blocking_ast_wrapper(void *astarg, int level) |
170 | { | 170 | { |
171 | BUG_ON(o2cb_stack.sp_proto == NULL); | 171 | struct ocfs2_dlm_lksb *lksb = astarg; |
172 | 172 | ||
173 | o2cb_stack.sp_proto->lp_blocking_ast(astarg, level); | 173 | lksb->lksb_conn->cc_proto->lp_blocking_ast(lksb, level); |
174 | } | 174 | } |
175 | 175 | ||
176 | static void o2dlm_unlock_ast_wrapper(void *astarg, enum dlm_status status) | 176 | static void o2dlm_unlock_ast_wrapper(void *astarg, enum dlm_status status) |
177 | { | 177 | { |
178 | struct ocfs2_dlm_lksb *lksb = astarg; | ||
178 | int error = dlm_status_to_errno(status); | 179 | int error = dlm_status_to_errno(status); |
179 | 180 | ||
180 | BUG_ON(o2cb_stack.sp_proto == NULL); | ||
181 | |||
182 | /* | 181 | /* |
183 | * In o2dlm, you can get both the lock_ast() for the lock being | 182 | * In o2dlm, you can get both the lock_ast() for the lock being |
184 | * granted and the unlock_ast() for the CANCEL failing. A | 183 | * granted and the unlock_ast() for the CANCEL failing. A |
@@ -193,16 +192,15 @@ static void o2dlm_unlock_ast_wrapper(void *astarg, enum dlm_status status) | |||
193 | if (status == DLM_CANCELGRANT) | 192 | if (status == DLM_CANCELGRANT) |
194 | return; | 193 | return; |
195 | 194 | ||
196 | o2cb_stack.sp_proto->lp_unlock_ast(astarg, error); | 195 | lksb->lksb_conn->cc_proto->lp_unlock_ast(lksb, error); |
197 | } | 196 | } |
198 | 197 | ||
199 | static int o2cb_dlm_lock(struct ocfs2_cluster_connection *conn, | 198 | static int o2cb_dlm_lock(struct ocfs2_cluster_connection *conn, |
200 | int mode, | 199 | int mode, |
201 | union ocfs2_dlm_lksb *lksb, | 200 | struct ocfs2_dlm_lksb *lksb, |
202 | u32 flags, | 201 | u32 flags, |
203 | void *name, | 202 | void *name, |
204 | unsigned int namelen, | 203 | unsigned int namelen) |
205 | void *astarg) | ||
206 | { | 204 | { |
207 | enum dlm_status status; | 205 | enum dlm_status status; |
208 | int o2dlm_mode = mode_to_o2dlm(mode); | 206 | int o2dlm_mode = mode_to_o2dlm(mode); |
@@ -211,28 +209,27 @@ static int o2cb_dlm_lock(struct ocfs2_cluster_connection *conn, | |||
211 | 209 | ||
212 | status = dlmlock(conn->cc_lockspace, o2dlm_mode, &lksb->lksb_o2dlm, | 210 | status = dlmlock(conn->cc_lockspace, o2dlm_mode, &lksb->lksb_o2dlm, |
213 | o2dlm_flags, name, namelen, | 211 | o2dlm_flags, name, namelen, |
214 | o2dlm_lock_ast_wrapper, astarg, | 212 | o2dlm_lock_ast_wrapper, lksb, |
215 | o2dlm_blocking_ast_wrapper); | 213 | o2dlm_blocking_ast_wrapper); |
216 | ret = dlm_status_to_errno(status); | 214 | ret = dlm_status_to_errno(status); |
217 | return ret; | 215 | return ret; |
218 | } | 216 | } |
219 | 217 | ||
220 | static int o2cb_dlm_unlock(struct ocfs2_cluster_connection *conn, | 218 | static int o2cb_dlm_unlock(struct ocfs2_cluster_connection *conn, |
221 | union ocfs2_dlm_lksb *lksb, | 219 | struct ocfs2_dlm_lksb *lksb, |
222 | u32 flags, | 220 | u32 flags) |
223 | void *astarg) | ||
224 | { | 221 | { |
225 | enum dlm_status status; | 222 | enum dlm_status status; |
226 | int o2dlm_flags = flags_to_o2dlm(flags); | 223 | int o2dlm_flags = flags_to_o2dlm(flags); |
227 | int ret; | 224 | int ret; |
228 | 225 | ||
229 | status = dlmunlock(conn->cc_lockspace, &lksb->lksb_o2dlm, | 226 | status = dlmunlock(conn->cc_lockspace, &lksb->lksb_o2dlm, |
230 | o2dlm_flags, o2dlm_unlock_ast_wrapper, astarg); | 227 | o2dlm_flags, o2dlm_unlock_ast_wrapper, lksb); |
231 | ret = dlm_status_to_errno(status); | 228 | ret = dlm_status_to_errno(status); |
232 | return ret; | 229 | return ret; |
233 | } | 230 | } |
234 | 231 | ||
235 | static int o2cb_dlm_lock_status(union ocfs2_dlm_lksb *lksb) | 232 | static int o2cb_dlm_lock_status(struct ocfs2_dlm_lksb *lksb) |
236 | { | 233 | { |
237 | return dlm_status_to_errno(lksb->lksb_o2dlm.status); | 234 | return dlm_status_to_errno(lksb->lksb_o2dlm.status); |
238 | } | 235 | } |
@@ -242,17 +239,17 @@ static int o2cb_dlm_lock_status(union ocfs2_dlm_lksb *lksb) | |||
242 | * contents, it will zero out the LVB. Thus the caller can always trust | 239 | * contents, it will zero out the LVB. Thus the caller can always trust |
243 | * the contents. | 240 | * the contents. |
244 | */ | 241 | */ |
245 | static int o2cb_dlm_lvb_valid(union ocfs2_dlm_lksb *lksb) | 242 | static int o2cb_dlm_lvb_valid(struct ocfs2_dlm_lksb *lksb) |
246 | { | 243 | { |
247 | return 1; | 244 | return 1; |
248 | } | 245 | } |
249 | 246 | ||
250 | static void *o2cb_dlm_lvb(union ocfs2_dlm_lksb *lksb) | 247 | static void *o2cb_dlm_lvb(struct ocfs2_dlm_lksb *lksb) |
251 | { | 248 | { |
252 | return (void *)(lksb->lksb_o2dlm.lvb); | 249 | return (void *)(lksb->lksb_o2dlm.lvb); |
253 | } | 250 | } |
254 | 251 | ||
255 | static void o2cb_dump_lksb(union ocfs2_dlm_lksb *lksb) | 252 | static void o2cb_dump_lksb(struct ocfs2_dlm_lksb *lksb) |
256 | { | 253 | { |
257 | dlm_print_one_lock(lksb->lksb_o2dlm.lockid); | 254 | dlm_print_one_lock(lksb->lksb_o2dlm.lockid); |
258 | } | 255 | } |
@@ -280,7 +277,7 @@ static int o2cb_cluster_connect(struct ocfs2_cluster_connection *conn) | |||
280 | struct dlm_protocol_version fs_version; | 277 | struct dlm_protocol_version fs_version; |
281 | 278 | ||
282 | BUG_ON(conn == NULL); | 279 | BUG_ON(conn == NULL); |
283 | BUG_ON(o2cb_stack.sp_proto == NULL); | 280 | BUG_ON(conn->cc_proto == NULL); |
284 | 281 | ||
285 | /* for now we only have one cluster/node, make sure we see it | 282 | /* for now we only have one cluster/node, make sure we see it |
286 | * in the heartbeat universe */ | 283 | * in the heartbeat universe */ |
diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2/stack_user.c index da78a2a334fd..5ae8812b2864 100644 --- a/fs/ocfs2/stack_user.c +++ b/fs/ocfs2/stack_user.c | |||
@@ -25,7 +25,6 @@ | |||
25 | #include <linux/reboot.h> | 25 | #include <linux/reboot.h> |
26 | #include <asm/uaccess.h> | 26 | #include <asm/uaccess.h> |
27 | 27 | ||
28 | #include "ocfs2.h" /* For struct ocfs2_lock_res */ | ||
29 | #include "stackglue.h" | 28 | #include "stackglue.h" |
30 | 29 | ||
31 | #include <linux/dlm_plock.h> | 30 | #include <linux/dlm_plock.h> |
@@ -63,8 +62,8 @@ | |||
63 | * negotiated by the client. The client negotiates based on the maximum | 62 | * negotiated by the client. The client negotiates based on the maximum |
64 | * version advertised in /sys/fs/ocfs2/max_locking_protocol. The major | 63 | * version advertised in /sys/fs/ocfs2/max_locking_protocol. The major |
65 | * number from the "SETV" message must match | 64 | * number from the "SETV" message must match |
66 | * ocfs2_user_plugin.sp_proto->lp_max_version.pv_major, and the minor number | 65 | * ocfs2_user_plugin.sp_max_proto.pv_major, and the minor number |
67 | * must be less than or equal to ...->lp_max_version.pv_minor. | 66 | * must be less than or equal to ...sp_max_version.pv_minor. |
68 | * | 67 | * |
69 | * Once this information has been set, mounts will be allowed. From this | 68 | * Once this information has been set, mounts will be allowed. From this |
70 | * point on, the "DOWN" message can be sent for node down notification. | 69 | * point on, the "DOWN" message can be sent for node down notification. |
@@ -401,7 +400,7 @@ static int ocfs2_control_do_setversion_msg(struct file *file, | |||
401 | char *ptr = NULL; | 400 | char *ptr = NULL; |
402 | struct ocfs2_control_private *p = file->private_data; | 401 | struct ocfs2_control_private *p = file->private_data; |
403 | struct ocfs2_protocol_version *max = | 402 | struct ocfs2_protocol_version *max = |
404 | &ocfs2_user_plugin.sp_proto->lp_max_version; | 403 | &ocfs2_user_plugin.sp_max_proto; |
405 | 404 | ||
406 | if (ocfs2_control_get_handshake_state(file) != | 405 | if (ocfs2_control_get_handshake_state(file) != |
407 | OCFS2_CONTROL_HANDSHAKE_PROTOCOL) | 406 | OCFS2_CONTROL_HANDSHAKE_PROTOCOL) |
@@ -664,18 +663,10 @@ static void ocfs2_control_exit(void) | |||
664 | -rc); | 663 | -rc); |
665 | } | 664 | } |
666 | 665 | ||
667 | static struct dlm_lksb *fsdlm_astarg_to_lksb(void *astarg) | ||
668 | { | ||
669 | struct ocfs2_lock_res *res = astarg; | ||
670 | return &res->l_lksb.lksb_fsdlm; | ||
671 | } | ||
672 | |||
673 | static void fsdlm_lock_ast_wrapper(void *astarg) | 666 | static void fsdlm_lock_ast_wrapper(void *astarg) |
674 | { | 667 | { |
675 | struct dlm_lksb *lksb = fsdlm_astarg_to_lksb(astarg); | 668 | struct ocfs2_dlm_lksb *lksb = astarg; |
676 | int status = lksb->sb_status; | 669 | int status = lksb->lksb_fsdlm.sb_status; |
677 | |||
678 | BUG_ON(ocfs2_user_plugin.sp_proto == NULL); | ||
679 | 670 | ||
680 | /* | 671 | /* |
681 | * For now we're punting on the issue of other non-standard errors | 672 | * For now we're punting on the issue of other non-standard errors |
@@ -688,25 +679,24 @@ static void fsdlm_lock_ast_wrapper(void *astarg) | |||
688 | */ | 679 | */ |
689 | 680 | ||
690 | if (status == -DLM_EUNLOCK || status == -DLM_ECANCEL) | 681 | if (status == -DLM_EUNLOCK || status == -DLM_ECANCEL) |
691 | ocfs2_user_plugin.sp_proto->lp_unlock_ast(astarg, 0); | 682 | lksb->lksb_conn->cc_proto->lp_unlock_ast(lksb, 0); |
692 | else | 683 | else |
693 | ocfs2_user_plugin.sp_proto->lp_lock_ast(astarg); | 684 | lksb->lksb_conn->cc_proto->lp_lock_ast(lksb); |
694 | } | 685 | } |
695 | 686 | ||
696 | static void fsdlm_blocking_ast_wrapper(void *astarg, int level) | 687 | static void fsdlm_blocking_ast_wrapper(void *astarg, int level) |
697 | { | 688 | { |
698 | BUG_ON(ocfs2_user_plugin.sp_proto == NULL); | 689 | struct ocfs2_dlm_lksb *lksb = astarg; |
699 | 690 | ||
700 | ocfs2_user_plugin.sp_proto->lp_blocking_ast(astarg, level); | 691 | lksb->lksb_conn->cc_proto->lp_blocking_ast(lksb, level); |
701 | } | 692 | } |
702 | 693 | ||
703 | static int user_dlm_lock(struct ocfs2_cluster_connection *conn, | 694 | static int user_dlm_lock(struct ocfs2_cluster_connection *conn, |
704 | int mode, | 695 | int mode, |
705 | union ocfs2_dlm_lksb *lksb, | 696 | struct ocfs2_dlm_lksb *lksb, |
706 | u32 flags, | 697 | u32 flags, |
707 | void *name, | 698 | void *name, |
708 | unsigned int namelen, | 699 | unsigned int namelen) |
709 | void *astarg) | ||
710 | { | 700 | { |
711 | int ret; | 701 | int ret; |
712 | 702 | ||
@@ -716,36 +706,35 @@ static int user_dlm_lock(struct ocfs2_cluster_connection *conn, | |||
716 | 706 | ||
717 | ret = dlm_lock(conn->cc_lockspace, mode, &lksb->lksb_fsdlm, | 707 | ret = dlm_lock(conn->cc_lockspace, mode, &lksb->lksb_fsdlm, |
718 | flags|DLM_LKF_NODLCKWT, name, namelen, 0, | 708 | flags|DLM_LKF_NODLCKWT, name, namelen, 0, |
719 | fsdlm_lock_ast_wrapper, astarg, | 709 | fsdlm_lock_ast_wrapper, lksb, |
720 | fsdlm_blocking_ast_wrapper); | 710 | fsdlm_blocking_ast_wrapper); |
721 | return ret; | 711 | return ret; |
722 | } | 712 | } |
723 | 713 | ||
724 | static int user_dlm_unlock(struct ocfs2_cluster_connection *conn, | 714 | static int user_dlm_unlock(struct ocfs2_cluster_connection *conn, |
725 | union ocfs2_dlm_lksb *lksb, | 715 | struct ocfs2_dlm_lksb *lksb, |
726 | u32 flags, | 716 | u32 flags) |
727 | void *astarg) | ||
728 | { | 717 | { |
729 | int ret; | 718 | int ret; |
730 | 719 | ||
731 | ret = dlm_unlock(conn->cc_lockspace, lksb->lksb_fsdlm.sb_lkid, | 720 | ret = dlm_unlock(conn->cc_lockspace, lksb->lksb_fsdlm.sb_lkid, |
732 | flags, &lksb->lksb_fsdlm, astarg); | 721 | flags, &lksb->lksb_fsdlm, lksb); |
733 | return ret; | 722 | return ret; |
734 | } | 723 | } |
735 | 724 | ||
736 | static int user_dlm_lock_status(union ocfs2_dlm_lksb *lksb) | 725 | static int user_dlm_lock_status(struct ocfs2_dlm_lksb *lksb) |
737 | { | 726 | { |
738 | return lksb->lksb_fsdlm.sb_status; | 727 | return lksb->lksb_fsdlm.sb_status; |
739 | } | 728 | } |
740 | 729 | ||
741 | static int user_dlm_lvb_valid(union ocfs2_dlm_lksb *lksb) | 730 | static int user_dlm_lvb_valid(struct ocfs2_dlm_lksb *lksb) |
742 | { | 731 | { |
743 | int invalid = lksb->lksb_fsdlm.sb_flags & DLM_SBF_VALNOTVALID; | 732 | int invalid = lksb->lksb_fsdlm.sb_flags & DLM_SBF_VALNOTVALID; |
744 | 733 | ||
745 | return !invalid; | 734 | return !invalid; |
746 | } | 735 | } |
747 | 736 | ||
748 | static void *user_dlm_lvb(union ocfs2_dlm_lksb *lksb) | 737 | static void *user_dlm_lvb(struct ocfs2_dlm_lksb *lksb) |
749 | { | 738 | { |
750 | if (!lksb->lksb_fsdlm.sb_lvbptr) | 739 | if (!lksb->lksb_fsdlm.sb_lvbptr) |
751 | lksb->lksb_fsdlm.sb_lvbptr = (char *)lksb + | 740 | lksb->lksb_fsdlm.sb_lvbptr = (char *)lksb + |
@@ -753,7 +742,7 @@ static void *user_dlm_lvb(union ocfs2_dlm_lksb *lksb) | |||
753 | return (void *)(lksb->lksb_fsdlm.sb_lvbptr); | 742 | return (void *)(lksb->lksb_fsdlm.sb_lvbptr); |
754 | } | 743 | } |
755 | 744 | ||
756 | static void user_dlm_dump_lksb(union ocfs2_dlm_lksb *lksb) | 745 | static void user_dlm_dump_lksb(struct ocfs2_dlm_lksb *lksb) |
757 | { | 746 | { |
758 | } | 747 | } |
759 | 748 | ||
diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c index f3df0baa9a48..39abf89697ed 100644 --- a/fs/ocfs2/stackglue.c +++ b/fs/ocfs2/stackglue.c | |||
@@ -36,7 +36,7 @@ | |||
36 | #define OCFS2_STACK_PLUGIN_USER "user" | 36 | #define OCFS2_STACK_PLUGIN_USER "user" |
37 | #define OCFS2_MAX_HB_CTL_PATH 256 | 37 | #define OCFS2_MAX_HB_CTL_PATH 256 |
38 | 38 | ||
39 | static struct ocfs2_locking_protocol *lproto; | 39 | static struct ocfs2_protocol_version locking_max_version; |
40 | static DEFINE_SPINLOCK(ocfs2_stack_lock); | 40 | static DEFINE_SPINLOCK(ocfs2_stack_lock); |
41 | static LIST_HEAD(ocfs2_stack_list); | 41 | static LIST_HEAD(ocfs2_stack_list); |
42 | static char cluster_stack_name[OCFS2_STACK_LABEL_LEN + 1]; | 42 | static char cluster_stack_name[OCFS2_STACK_LABEL_LEN + 1]; |
@@ -176,7 +176,7 @@ int ocfs2_stack_glue_register(struct ocfs2_stack_plugin *plugin) | |||
176 | spin_lock(&ocfs2_stack_lock); | 176 | spin_lock(&ocfs2_stack_lock); |
177 | if (!ocfs2_stack_lookup(plugin->sp_name)) { | 177 | if (!ocfs2_stack_lookup(plugin->sp_name)) { |
178 | plugin->sp_count = 0; | 178 | plugin->sp_count = 0; |
179 | plugin->sp_proto = lproto; | 179 | plugin->sp_max_proto = locking_max_version; |
180 | list_add(&plugin->sp_list, &ocfs2_stack_list); | 180 | list_add(&plugin->sp_list, &ocfs2_stack_list); |
181 | printk(KERN_INFO "ocfs2: Registered cluster interface %s\n", | 181 | printk(KERN_INFO "ocfs2: Registered cluster interface %s\n", |
182 | plugin->sp_name); | 182 | plugin->sp_name); |
@@ -213,77 +213,76 @@ void ocfs2_stack_glue_unregister(struct ocfs2_stack_plugin *plugin) | |||
213 | } | 213 | } |
214 | EXPORT_SYMBOL_GPL(ocfs2_stack_glue_unregister); | 214 | EXPORT_SYMBOL_GPL(ocfs2_stack_glue_unregister); |
215 | 215 | ||
216 | void ocfs2_stack_glue_set_locking_protocol(struct ocfs2_locking_protocol *proto) | 216 | void ocfs2_stack_glue_set_max_proto_version(struct ocfs2_protocol_version *max_proto) |
217 | { | 217 | { |
218 | struct ocfs2_stack_plugin *p; | 218 | struct ocfs2_stack_plugin *p; |
219 | 219 | ||
220 | BUG_ON(proto == NULL); | ||
221 | |||
222 | spin_lock(&ocfs2_stack_lock); | 220 | spin_lock(&ocfs2_stack_lock); |
223 | BUG_ON(active_stack != NULL); | 221 | if (memcmp(max_proto, &locking_max_version, |
222 | sizeof(struct ocfs2_protocol_version))) { | ||
223 | BUG_ON(locking_max_version.pv_major != 0); | ||
224 | 224 | ||
225 | lproto = proto; | 225 | locking_max_version = *max_proto; |
226 | list_for_each_entry(p, &ocfs2_stack_list, sp_list) { | 226 | list_for_each_entry(p, &ocfs2_stack_list, sp_list) { |
227 | p->sp_proto = lproto; | 227 | p->sp_max_proto = locking_max_version; |
228 | } | ||
228 | } | 229 | } |
229 | |||
230 | spin_unlock(&ocfs2_stack_lock); | 230 | spin_unlock(&ocfs2_stack_lock); |
231 | } | 231 | } |
232 | EXPORT_SYMBOL_GPL(ocfs2_stack_glue_set_locking_protocol); | 232 | EXPORT_SYMBOL_GPL(ocfs2_stack_glue_set_max_proto_version); |
233 | 233 | ||
234 | 234 | ||
235 | /* | 235 | /* |
236 | * The ocfs2_dlm_lock() and ocfs2_dlm_unlock() functions take | 236 | * The ocfs2_dlm_lock() and ocfs2_dlm_unlock() functions take no argument |
237 | * "struct ocfs2_lock_res *astarg" instead of "void *astarg" because the | 237 | * for the ast and bast functions. They will pass the lksb to the ast |
238 | * underlying stack plugins need to pilfer the lksb off of the lock_res. | 238 | * and bast. The caller can wrap the lksb with their own structure to |
239 | * If some other structure needs to be passed as an astarg, the plugins | 239 | * get more information. |
240 | * will need to be given a different avenue to the lksb. | ||
241 | */ | 240 | */ |
242 | int ocfs2_dlm_lock(struct ocfs2_cluster_connection *conn, | 241 | int ocfs2_dlm_lock(struct ocfs2_cluster_connection *conn, |
243 | int mode, | 242 | int mode, |
244 | union ocfs2_dlm_lksb *lksb, | 243 | struct ocfs2_dlm_lksb *lksb, |
245 | u32 flags, | 244 | u32 flags, |
246 | void *name, | 245 | void *name, |
247 | unsigned int namelen, | 246 | unsigned int namelen) |
248 | struct ocfs2_lock_res *astarg) | ||
249 | { | 247 | { |
250 | BUG_ON(lproto == NULL); | 248 | if (!lksb->lksb_conn) |
251 | 249 | lksb->lksb_conn = conn; | |
250 | else | ||
251 | BUG_ON(lksb->lksb_conn != conn); | ||
252 | return active_stack->sp_ops->dlm_lock(conn, mode, lksb, flags, | 252 | return active_stack->sp_ops->dlm_lock(conn, mode, lksb, flags, |
253 | name, namelen, astarg); | 253 | name, namelen); |
254 | } | 254 | } |
255 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lock); | 255 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lock); |
256 | 256 | ||
257 | int ocfs2_dlm_unlock(struct ocfs2_cluster_connection *conn, | 257 | int ocfs2_dlm_unlock(struct ocfs2_cluster_connection *conn, |
258 | union ocfs2_dlm_lksb *lksb, | 258 | struct ocfs2_dlm_lksb *lksb, |
259 | u32 flags, | 259 | u32 flags) |
260 | struct ocfs2_lock_res *astarg) | ||
261 | { | 260 | { |
262 | BUG_ON(lproto == NULL); | 261 | BUG_ON(lksb->lksb_conn == NULL); |
263 | 262 | ||
264 | return active_stack->sp_ops->dlm_unlock(conn, lksb, flags, astarg); | 263 | return active_stack->sp_ops->dlm_unlock(conn, lksb, flags); |
265 | } | 264 | } |
266 | EXPORT_SYMBOL_GPL(ocfs2_dlm_unlock); | 265 | EXPORT_SYMBOL_GPL(ocfs2_dlm_unlock); |
267 | 266 | ||
268 | int ocfs2_dlm_lock_status(union ocfs2_dlm_lksb *lksb) | 267 | int ocfs2_dlm_lock_status(struct ocfs2_dlm_lksb *lksb) |
269 | { | 268 | { |
270 | return active_stack->sp_ops->lock_status(lksb); | 269 | return active_stack->sp_ops->lock_status(lksb); |
271 | } | 270 | } |
272 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lock_status); | 271 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lock_status); |
273 | 272 | ||
274 | int ocfs2_dlm_lvb_valid(union ocfs2_dlm_lksb *lksb) | 273 | int ocfs2_dlm_lvb_valid(struct ocfs2_dlm_lksb *lksb) |
275 | { | 274 | { |
276 | return active_stack->sp_ops->lvb_valid(lksb); | 275 | return active_stack->sp_ops->lvb_valid(lksb); |
277 | } | 276 | } |
278 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lvb_valid); | 277 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lvb_valid); |
279 | 278 | ||
280 | void *ocfs2_dlm_lvb(union ocfs2_dlm_lksb *lksb) | 279 | void *ocfs2_dlm_lvb(struct ocfs2_dlm_lksb *lksb) |
281 | { | 280 | { |
282 | return active_stack->sp_ops->lock_lvb(lksb); | 281 | return active_stack->sp_ops->lock_lvb(lksb); |
283 | } | 282 | } |
284 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lvb); | 283 | EXPORT_SYMBOL_GPL(ocfs2_dlm_lvb); |
285 | 284 | ||
286 | void ocfs2_dlm_dump_lksb(union ocfs2_dlm_lksb *lksb) | 285 | void ocfs2_dlm_dump_lksb(struct ocfs2_dlm_lksb *lksb) |
287 | { | 286 | { |
288 | active_stack->sp_ops->dump_lksb(lksb); | 287 | active_stack->sp_ops->dump_lksb(lksb); |
289 | } | 288 | } |
@@ -312,6 +311,7 @@ EXPORT_SYMBOL_GPL(ocfs2_plock); | |||
312 | int ocfs2_cluster_connect(const char *stack_name, | 311 | int ocfs2_cluster_connect(const char *stack_name, |
313 | const char *group, | 312 | const char *group, |
314 | int grouplen, | 313 | int grouplen, |
314 | struct ocfs2_locking_protocol *lproto, | ||
315 | void (*recovery_handler)(int node_num, | 315 | void (*recovery_handler)(int node_num, |
316 | void *recovery_data), | 316 | void *recovery_data), |
317 | void *recovery_data, | 317 | void *recovery_data, |
@@ -329,6 +329,12 @@ int ocfs2_cluster_connect(const char *stack_name, | |||
329 | goto out; | 329 | goto out; |
330 | } | 330 | } |
331 | 331 | ||
332 | if (memcmp(&lproto->lp_max_version, &locking_max_version, | ||
333 | sizeof(struct ocfs2_protocol_version))) { | ||
334 | rc = -EINVAL; | ||
335 | goto out; | ||
336 | } | ||
337 | |||
332 | new_conn = kzalloc(sizeof(struct ocfs2_cluster_connection), | 338 | new_conn = kzalloc(sizeof(struct ocfs2_cluster_connection), |
333 | GFP_KERNEL); | 339 | GFP_KERNEL); |
334 | if (!new_conn) { | 340 | if (!new_conn) { |
@@ -341,6 +347,7 @@ int ocfs2_cluster_connect(const char *stack_name, | |||
341 | new_conn->cc_recovery_handler = recovery_handler; | 347 | new_conn->cc_recovery_handler = recovery_handler; |
342 | new_conn->cc_recovery_data = recovery_data; | 348 | new_conn->cc_recovery_data = recovery_data; |
343 | 349 | ||
350 | new_conn->cc_proto = lproto; | ||
344 | /* Start the new connection at our maximum compatibility level */ | 351 | /* Start the new connection at our maximum compatibility level */ |
345 | new_conn->cc_version = lproto->lp_max_version; | 352 | new_conn->cc_version = lproto->lp_max_version; |
346 | 353 | ||
@@ -366,6 +373,24 @@ out: | |||
366 | } | 373 | } |
367 | EXPORT_SYMBOL_GPL(ocfs2_cluster_connect); | 374 | EXPORT_SYMBOL_GPL(ocfs2_cluster_connect); |
368 | 375 | ||
376 | /* The caller will ensure all nodes have the same cluster stack */ | ||
377 | int ocfs2_cluster_connect_agnostic(const char *group, | ||
378 | int grouplen, | ||
379 | struct ocfs2_locking_protocol *lproto, | ||
380 | void (*recovery_handler)(int node_num, | ||
381 | void *recovery_data), | ||
382 | void *recovery_data, | ||
383 | struct ocfs2_cluster_connection **conn) | ||
384 | { | ||
385 | char *stack_name = NULL; | ||
386 | |||
387 | if (cluster_stack_name[0]) | ||
388 | stack_name = cluster_stack_name; | ||
389 | return ocfs2_cluster_connect(stack_name, group, grouplen, lproto, | ||
390 | recovery_handler, recovery_data, conn); | ||
391 | } | ||
392 | EXPORT_SYMBOL_GPL(ocfs2_cluster_connect_agnostic); | ||
393 | |||
369 | /* If hangup_pending is 0, the stack driver will be dropped */ | 394 | /* If hangup_pending is 0, the stack driver will be dropped */ |
370 | int ocfs2_cluster_disconnect(struct ocfs2_cluster_connection *conn, | 395 | int ocfs2_cluster_disconnect(struct ocfs2_cluster_connection *conn, |
371 | int hangup_pending) | 396 | int hangup_pending) |
@@ -453,10 +478,10 @@ static ssize_t ocfs2_max_locking_protocol_show(struct kobject *kobj, | |||
453 | ssize_t ret = 0; | 478 | ssize_t ret = 0; |
454 | 479 | ||
455 | spin_lock(&ocfs2_stack_lock); | 480 | spin_lock(&ocfs2_stack_lock); |
456 | if (lproto) | 481 | if (locking_max_version.pv_major) |
457 | ret = snprintf(buf, PAGE_SIZE, "%u.%u\n", | 482 | ret = snprintf(buf, PAGE_SIZE, "%u.%u\n", |
458 | lproto->lp_max_version.pv_major, | 483 | locking_max_version.pv_major, |
459 | lproto->lp_max_version.pv_minor); | 484 | locking_max_version.pv_minor); |
460 | spin_unlock(&ocfs2_stack_lock); | 485 | spin_unlock(&ocfs2_stack_lock); |
461 | 486 | ||
462 | return ret; | 487 | return ret; |
@@ -685,7 +710,10 @@ static int __init ocfs2_stack_glue_init(void) | |||
685 | 710 | ||
686 | static void __exit ocfs2_stack_glue_exit(void) | 711 | static void __exit ocfs2_stack_glue_exit(void) |
687 | { | 712 | { |
688 | lproto = NULL; | 713 | memset(&locking_max_version, 0, |
714 | sizeof(struct ocfs2_protocol_version)); | ||
715 | locking_max_version.pv_major = 0; | ||
716 | locking_max_version.pv_minor = 0; | ||
689 | ocfs2_sysfs_exit(); | 717 | ocfs2_sysfs_exit(); |
690 | if (ocfs2_table_header) | 718 | if (ocfs2_table_header) |
691 | unregister_sysctl_table(ocfs2_table_header); | 719 | unregister_sysctl_table(ocfs2_table_header); |
diff --git a/fs/ocfs2/stackglue.h b/fs/ocfs2/stackglue.h index 03a44d60eac9..8ce7398ae1d2 100644 --- a/fs/ocfs2/stackglue.h +++ b/fs/ocfs2/stackglue.h | |||
@@ -56,17 +56,6 @@ struct ocfs2_protocol_version { | |||
56 | }; | 56 | }; |
57 | 57 | ||
58 | /* | 58 | /* |
59 | * The ocfs2_locking_protocol defines the handlers called on ocfs2's behalf. | ||
60 | */ | ||
61 | struct ocfs2_locking_protocol { | ||
62 | struct ocfs2_protocol_version lp_max_version; | ||
63 | void (*lp_lock_ast)(void *astarg); | ||
64 | void (*lp_blocking_ast)(void *astarg, int level); | ||
65 | void (*lp_unlock_ast)(void *astarg, int error); | ||
66 | }; | ||
67 | |||
68 | |||
69 | /* | ||
70 | * The dlm_lockstatus struct includes lvb space, but the dlm_lksb struct only | 59 | * The dlm_lockstatus struct includes lvb space, but the dlm_lksb struct only |
71 | * has a pointer to separately allocated lvb space. This struct exists only to | 60 | * has a pointer to separately allocated lvb space. This struct exists only to |
72 | * include in the lksb union to make space for a combined dlm_lksb and lvb. | 61 | * include in the lksb union to make space for a combined dlm_lksb and lvb. |
@@ -81,12 +70,27 @@ struct fsdlm_lksb_plus_lvb { | |||
81 | * size of the union is known. Lock status structures are embedded in | 70 | * size of the union is known. Lock status structures are embedded in |
82 | * ocfs2 inodes. | 71 | * ocfs2 inodes. |
83 | */ | 72 | */ |
84 | union ocfs2_dlm_lksb { | 73 | struct ocfs2_cluster_connection; |
85 | struct dlm_lockstatus lksb_o2dlm; | 74 | struct ocfs2_dlm_lksb { |
86 | struct dlm_lksb lksb_fsdlm; | 75 | union { |
87 | struct fsdlm_lksb_plus_lvb padding; | 76 | struct dlm_lockstatus lksb_o2dlm; |
77 | struct dlm_lksb lksb_fsdlm; | ||
78 | struct fsdlm_lksb_plus_lvb padding; | ||
79 | }; | ||
80 | struct ocfs2_cluster_connection *lksb_conn; | ||
81 | }; | ||
82 | |||
83 | /* | ||
84 | * The ocfs2_locking_protocol defines the handlers called on ocfs2's behalf. | ||
85 | */ | ||
86 | struct ocfs2_locking_protocol { | ||
87 | struct ocfs2_protocol_version lp_max_version; | ||
88 | void (*lp_lock_ast)(struct ocfs2_dlm_lksb *lksb); | ||
89 | void (*lp_blocking_ast)(struct ocfs2_dlm_lksb *lksb, int level); | ||
90 | void (*lp_unlock_ast)(struct ocfs2_dlm_lksb *lksb, int error); | ||
88 | }; | 91 | }; |
89 | 92 | ||
93 | |||
90 | /* | 94 | /* |
91 | * A cluster connection. Mostly opaque to ocfs2, the connection holds | 95 | * A cluster connection. Mostly opaque to ocfs2, the connection holds |
92 | * state for the underlying stack. ocfs2 does use cc_version to determine | 96 | * state for the underlying stack. ocfs2 does use cc_version to determine |
@@ -96,6 +100,7 @@ struct ocfs2_cluster_connection { | |||
96 | char cc_name[GROUP_NAME_MAX]; | 100 | char cc_name[GROUP_NAME_MAX]; |
97 | int cc_namelen; | 101 | int cc_namelen; |
98 | struct ocfs2_protocol_version cc_version; | 102 | struct ocfs2_protocol_version cc_version; |
103 | struct ocfs2_locking_protocol *cc_proto; | ||
99 | void (*cc_recovery_handler)(int node_num, void *recovery_data); | 104 | void (*cc_recovery_handler)(int node_num, void *recovery_data); |
100 | void *cc_recovery_data; | 105 | void *cc_recovery_data; |
101 | void *cc_lockspace; | 106 | void *cc_lockspace; |
@@ -155,27 +160,29 @@ struct ocfs2_stack_operations { | |||
155 | * | 160 | * |
156 | * ast and bast functions are not part of the call because the | 161 | * ast and bast functions are not part of the call because the |
157 | * stack will likely want to wrap ast and bast calls before passing | 162 | * stack will likely want to wrap ast and bast calls before passing |
158 | * them to stack->sp_proto. | 163 | * them to stack->sp_proto. There is no astarg. The lksb will |
164 | * be passed back to the ast and bast functions. The caller can | ||
165 | * use this to find their object. | ||
159 | */ | 166 | */ |
160 | int (*dlm_lock)(struct ocfs2_cluster_connection *conn, | 167 | int (*dlm_lock)(struct ocfs2_cluster_connection *conn, |
161 | int mode, | 168 | int mode, |
162 | union ocfs2_dlm_lksb *lksb, | 169 | struct ocfs2_dlm_lksb *lksb, |
163 | u32 flags, | 170 | u32 flags, |
164 | void *name, | 171 | void *name, |
165 | unsigned int namelen, | 172 | unsigned int namelen); |
166 | void *astarg); | ||
167 | 173 | ||
168 | /* | 174 | /* |
169 | * Call the underlying dlm unlock function. The ->dlm_unlock() | 175 | * Call the underlying dlm unlock function. The ->dlm_unlock() |
170 | * function should convert the flags as appropriate. | 176 | * function should convert the flags as appropriate. |
171 | * | 177 | * |
172 | * The unlock ast is not passed, as the stack will want to wrap | 178 | * The unlock ast is not passed, as the stack will want to wrap |
173 | * it before calling stack->sp_proto->lp_unlock_ast(). | 179 | * it before calling stack->sp_proto->lp_unlock_ast(). There is |
180 | * no astarg. The lksb will be passed back to the unlock ast | ||
181 | * function. The caller can use this to find their object. | ||
174 | */ | 182 | */ |
175 | int (*dlm_unlock)(struct ocfs2_cluster_connection *conn, | 183 | int (*dlm_unlock)(struct ocfs2_cluster_connection *conn, |
176 | union ocfs2_dlm_lksb *lksb, | 184 | struct ocfs2_dlm_lksb *lksb, |
177 | u32 flags, | 185 | u32 flags); |
178 | void *astarg); | ||
179 | 186 | ||
180 | /* | 187 | /* |
181 | * Return the status of the current lock status block. The fs | 188 | * Return the status of the current lock status block. The fs |
@@ -183,17 +190,17 @@ struct ocfs2_stack_operations { | |||
183 | * callback pulls out the stack-specific lksb, converts the status | 190 | * callback pulls out the stack-specific lksb, converts the status |
184 | * to a proper errno, and returns it. | 191 | * to a proper errno, and returns it. |
185 | */ | 192 | */ |
186 | int (*lock_status)(union ocfs2_dlm_lksb *lksb); | 193 | int (*lock_status)(struct ocfs2_dlm_lksb *lksb); |
187 | 194 | ||
188 | /* | 195 | /* |
189 | * Return non-zero if the LVB is valid. | 196 | * Return non-zero if the LVB is valid. |
190 | */ | 197 | */ |
191 | int (*lvb_valid)(union ocfs2_dlm_lksb *lksb); | 198 | int (*lvb_valid)(struct ocfs2_dlm_lksb *lksb); |
192 | 199 | ||
193 | /* | 200 | /* |
194 | * Pull the lvb pointer off of the stack-specific lksb. | 201 | * Pull the lvb pointer off of the stack-specific lksb. |
195 | */ | 202 | */ |
196 | void *(*lock_lvb)(union ocfs2_dlm_lksb *lksb); | 203 | void *(*lock_lvb)(struct ocfs2_dlm_lksb *lksb); |
197 | 204 | ||
198 | /* | 205 | /* |
199 | * Cluster-aware posix locks | 206 | * Cluster-aware posix locks |
@@ -210,7 +217,7 @@ struct ocfs2_stack_operations { | |||
210 | * This is an optoinal debugging hook. If provided, the | 217 | * This is an optoinal debugging hook. If provided, the |
211 | * stack can dump debugging information about this lock. | 218 | * stack can dump debugging information about this lock. |
212 | */ | 219 | */ |
213 | void (*dump_lksb)(union ocfs2_dlm_lksb *lksb); | 220 | void (*dump_lksb)(struct ocfs2_dlm_lksb *lksb); |
214 | }; | 221 | }; |
215 | 222 | ||
216 | /* | 223 | /* |
@@ -226,7 +233,7 @@ struct ocfs2_stack_plugin { | |||
226 | /* These are managed by the stackglue code. */ | 233 | /* These are managed by the stackglue code. */ |
227 | struct list_head sp_list; | 234 | struct list_head sp_list; |
228 | unsigned int sp_count; | 235 | unsigned int sp_count; |
229 | struct ocfs2_locking_protocol *sp_proto; | 236 | struct ocfs2_protocol_version sp_max_proto; |
230 | }; | 237 | }; |
231 | 238 | ||
232 | 239 | ||
@@ -234,10 +241,22 @@ struct ocfs2_stack_plugin { | |||
234 | int ocfs2_cluster_connect(const char *stack_name, | 241 | int ocfs2_cluster_connect(const char *stack_name, |
235 | const char *group, | 242 | const char *group, |
236 | int grouplen, | 243 | int grouplen, |
244 | struct ocfs2_locking_protocol *lproto, | ||
237 | void (*recovery_handler)(int node_num, | 245 | void (*recovery_handler)(int node_num, |
238 | void *recovery_data), | 246 | void *recovery_data), |
239 | void *recovery_data, | 247 | void *recovery_data, |
240 | struct ocfs2_cluster_connection **conn); | 248 | struct ocfs2_cluster_connection **conn); |
249 | /* | ||
250 | * Used by callers that don't store their stack name. They must ensure | ||
251 | * all nodes have the same stack. | ||
252 | */ | ||
253 | int ocfs2_cluster_connect_agnostic(const char *group, | ||
254 | int grouplen, | ||
255 | struct ocfs2_locking_protocol *lproto, | ||
256 | void (*recovery_handler)(int node_num, | ||
257 | void *recovery_data), | ||
258 | void *recovery_data, | ||
259 | struct ocfs2_cluster_connection **conn); | ||
241 | int ocfs2_cluster_disconnect(struct ocfs2_cluster_connection *conn, | 260 | int ocfs2_cluster_disconnect(struct ocfs2_cluster_connection *conn, |
242 | int hangup_pending); | 261 | int hangup_pending); |
243 | void ocfs2_cluster_hangup(const char *group, int grouplen); | 262 | void ocfs2_cluster_hangup(const char *group, int grouplen); |
@@ -246,26 +265,24 @@ int ocfs2_cluster_this_node(unsigned int *node); | |||
246 | struct ocfs2_lock_res; | 265 | struct ocfs2_lock_res; |
247 | int ocfs2_dlm_lock(struct ocfs2_cluster_connection *conn, | 266 | int ocfs2_dlm_lock(struct ocfs2_cluster_connection *conn, |
248 | int mode, | 267 | int mode, |
249 | union ocfs2_dlm_lksb *lksb, | 268 | struct ocfs2_dlm_lksb *lksb, |
250 | u32 flags, | 269 | u32 flags, |
251 | void *name, | 270 | void *name, |
252 | unsigned int namelen, | 271 | unsigned int namelen); |
253 | struct ocfs2_lock_res *astarg); | ||
254 | int ocfs2_dlm_unlock(struct ocfs2_cluster_connection *conn, | 272 | int ocfs2_dlm_unlock(struct ocfs2_cluster_connection *conn, |
255 | union ocfs2_dlm_lksb *lksb, | 273 | struct ocfs2_dlm_lksb *lksb, |
256 | u32 flags, | 274 | u32 flags); |
257 | struct ocfs2_lock_res *astarg); | ||
258 | 275 | ||
259 | int ocfs2_dlm_lock_status(union ocfs2_dlm_lksb *lksb); | 276 | int ocfs2_dlm_lock_status(struct ocfs2_dlm_lksb *lksb); |
260 | int ocfs2_dlm_lvb_valid(union ocfs2_dlm_lksb *lksb); | 277 | int ocfs2_dlm_lvb_valid(struct ocfs2_dlm_lksb *lksb); |
261 | void *ocfs2_dlm_lvb(union ocfs2_dlm_lksb *lksb); | 278 | void *ocfs2_dlm_lvb(struct ocfs2_dlm_lksb *lksb); |
262 | void ocfs2_dlm_dump_lksb(union ocfs2_dlm_lksb *lksb); | 279 | void ocfs2_dlm_dump_lksb(struct ocfs2_dlm_lksb *lksb); |
263 | 280 | ||
264 | int ocfs2_stack_supports_plocks(void); | 281 | int ocfs2_stack_supports_plocks(void); |
265 | int ocfs2_plock(struct ocfs2_cluster_connection *conn, u64 ino, | 282 | int ocfs2_plock(struct ocfs2_cluster_connection *conn, u64 ino, |
266 | struct file *file, int cmd, struct file_lock *fl); | 283 | struct file *file, int cmd, struct file_lock *fl); |
267 | 284 | ||
268 | void ocfs2_stack_glue_set_locking_protocol(struct ocfs2_locking_protocol *proto); | 285 | void ocfs2_stack_glue_set_max_proto_version(struct ocfs2_protocol_version *max_proto); |
269 | 286 | ||
270 | 287 | ||
271 | /* Used by stack plugins */ | 288 | /* Used by stack plugins */ |
diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c index c30b644d9572..c3c60bc3e072 100644 --- a/fs/ocfs2/suballoc.c +++ b/fs/ocfs2/suballoc.c | |||
@@ -51,7 +51,7 @@ | |||
51 | #define ALLOC_NEW_GROUP 0x1 | 51 | #define ALLOC_NEW_GROUP 0x1 |
52 | #define ALLOC_GROUPS_FROM_GLOBAL 0x2 | 52 | #define ALLOC_GROUPS_FROM_GLOBAL 0x2 |
53 | 53 | ||
54 | #define OCFS2_MAX_INODES_TO_STEAL 1024 | 54 | #define OCFS2_MAX_TO_STEAL 1024 |
55 | 55 | ||
56 | static inline void ocfs2_debug_bg(struct ocfs2_group_desc *bg); | 56 | static inline void ocfs2_debug_bg(struct ocfs2_group_desc *bg); |
57 | static inline void ocfs2_debug_suballoc_inode(struct ocfs2_dinode *fe); | 57 | static inline void ocfs2_debug_suballoc_inode(struct ocfs2_dinode *fe); |
@@ -637,12 +637,113 @@ bail: | |||
637 | return status; | 637 | return status; |
638 | } | 638 | } |
639 | 639 | ||
640 | static void ocfs2_init_inode_steal_slot(struct ocfs2_super *osb) | ||
641 | { | ||
642 | spin_lock(&osb->osb_lock); | ||
643 | osb->s_inode_steal_slot = OCFS2_INVALID_SLOT; | ||
644 | spin_unlock(&osb->osb_lock); | ||
645 | atomic_set(&osb->s_num_inodes_stolen, 0); | ||
646 | } | ||
647 | |||
648 | static void ocfs2_init_meta_steal_slot(struct ocfs2_super *osb) | ||
649 | { | ||
650 | spin_lock(&osb->osb_lock); | ||
651 | osb->s_meta_steal_slot = OCFS2_INVALID_SLOT; | ||
652 | spin_unlock(&osb->osb_lock); | ||
653 | atomic_set(&osb->s_num_meta_stolen, 0); | ||
654 | } | ||
655 | |||
656 | void ocfs2_init_steal_slots(struct ocfs2_super *osb) | ||
657 | { | ||
658 | ocfs2_init_inode_steal_slot(osb); | ||
659 | ocfs2_init_meta_steal_slot(osb); | ||
660 | } | ||
661 | |||
662 | static void __ocfs2_set_steal_slot(struct ocfs2_super *osb, int slot, int type) | ||
663 | { | ||
664 | spin_lock(&osb->osb_lock); | ||
665 | if (type == INODE_ALLOC_SYSTEM_INODE) | ||
666 | osb->s_inode_steal_slot = slot; | ||
667 | else if (type == EXTENT_ALLOC_SYSTEM_INODE) | ||
668 | osb->s_meta_steal_slot = slot; | ||
669 | spin_unlock(&osb->osb_lock); | ||
670 | } | ||
671 | |||
672 | static int __ocfs2_get_steal_slot(struct ocfs2_super *osb, int type) | ||
673 | { | ||
674 | int slot = OCFS2_INVALID_SLOT; | ||
675 | |||
676 | spin_lock(&osb->osb_lock); | ||
677 | if (type == INODE_ALLOC_SYSTEM_INODE) | ||
678 | slot = osb->s_inode_steal_slot; | ||
679 | else if (type == EXTENT_ALLOC_SYSTEM_INODE) | ||
680 | slot = osb->s_meta_steal_slot; | ||
681 | spin_unlock(&osb->osb_lock); | ||
682 | |||
683 | return slot; | ||
684 | } | ||
685 | |||
686 | static int ocfs2_get_inode_steal_slot(struct ocfs2_super *osb) | ||
687 | { | ||
688 | return __ocfs2_get_steal_slot(osb, INODE_ALLOC_SYSTEM_INODE); | ||
689 | } | ||
690 | |||
691 | static int ocfs2_get_meta_steal_slot(struct ocfs2_super *osb) | ||
692 | { | ||
693 | return __ocfs2_get_steal_slot(osb, EXTENT_ALLOC_SYSTEM_INODE); | ||
694 | } | ||
695 | |||
696 | static int ocfs2_steal_resource(struct ocfs2_super *osb, | ||
697 | struct ocfs2_alloc_context *ac, | ||
698 | int type) | ||
699 | { | ||
700 | int i, status = -ENOSPC; | ||
701 | int slot = __ocfs2_get_steal_slot(osb, type); | ||
702 | |||
703 | /* Start to steal resource from the first slot after ours. */ | ||
704 | if (slot == OCFS2_INVALID_SLOT) | ||
705 | slot = osb->slot_num + 1; | ||
706 | |||
707 | for (i = 0; i < osb->max_slots; i++, slot++) { | ||
708 | if (slot == osb->max_slots) | ||
709 | slot = 0; | ||
710 | |||
711 | if (slot == osb->slot_num) | ||
712 | continue; | ||
713 | |||
714 | status = ocfs2_reserve_suballoc_bits(osb, ac, | ||
715 | type, | ||
716 | (u32)slot, NULL, | ||
717 | NOT_ALLOC_NEW_GROUP); | ||
718 | if (status >= 0) { | ||
719 | __ocfs2_set_steal_slot(osb, slot, type); | ||
720 | break; | ||
721 | } | ||
722 | |||
723 | ocfs2_free_ac_resource(ac); | ||
724 | } | ||
725 | |||
726 | return status; | ||
727 | } | ||
728 | |||
729 | static int ocfs2_steal_inode(struct ocfs2_super *osb, | ||
730 | struct ocfs2_alloc_context *ac) | ||
731 | { | ||
732 | return ocfs2_steal_resource(osb, ac, INODE_ALLOC_SYSTEM_INODE); | ||
733 | } | ||
734 | |||
735 | static int ocfs2_steal_meta(struct ocfs2_super *osb, | ||
736 | struct ocfs2_alloc_context *ac) | ||
737 | { | ||
738 | return ocfs2_steal_resource(osb, ac, EXTENT_ALLOC_SYSTEM_INODE); | ||
739 | } | ||
740 | |||
640 | int ocfs2_reserve_new_metadata_blocks(struct ocfs2_super *osb, | 741 | int ocfs2_reserve_new_metadata_blocks(struct ocfs2_super *osb, |
641 | int blocks, | 742 | int blocks, |
642 | struct ocfs2_alloc_context **ac) | 743 | struct ocfs2_alloc_context **ac) |
643 | { | 744 | { |
644 | int status; | 745 | int status; |
645 | u32 slot; | 746 | int slot = ocfs2_get_meta_steal_slot(osb); |
646 | 747 | ||
647 | *ac = kzalloc(sizeof(struct ocfs2_alloc_context), GFP_KERNEL); | 748 | *ac = kzalloc(sizeof(struct ocfs2_alloc_context), GFP_KERNEL); |
648 | if (!(*ac)) { | 749 | if (!(*ac)) { |
@@ -653,12 +754,34 @@ int ocfs2_reserve_new_metadata_blocks(struct ocfs2_super *osb, | |||
653 | 754 | ||
654 | (*ac)->ac_bits_wanted = blocks; | 755 | (*ac)->ac_bits_wanted = blocks; |
655 | (*ac)->ac_which = OCFS2_AC_USE_META; | 756 | (*ac)->ac_which = OCFS2_AC_USE_META; |
656 | slot = osb->slot_num; | ||
657 | (*ac)->ac_group_search = ocfs2_block_group_search; | 757 | (*ac)->ac_group_search = ocfs2_block_group_search; |
658 | 758 | ||
759 | if (slot != OCFS2_INVALID_SLOT && | ||
760 | atomic_read(&osb->s_num_meta_stolen) < OCFS2_MAX_TO_STEAL) | ||
761 | goto extent_steal; | ||
762 | |||
763 | atomic_set(&osb->s_num_meta_stolen, 0); | ||
659 | status = ocfs2_reserve_suballoc_bits(osb, (*ac), | 764 | status = ocfs2_reserve_suballoc_bits(osb, (*ac), |
660 | EXTENT_ALLOC_SYSTEM_INODE, | 765 | EXTENT_ALLOC_SYSTEM_INODE, |
661 | slot, NULL, ALLOC_NEW_GROUP); | 766 | (u32)osb->slot_num, NULL, |
767 | ALLOC_NEW_GROUP); | ||
768 | |||
769 | |||
770 | if (status >= 0) { | ||
771 | status = 0; | ||
772 | if (slot != OCFS2_INVALID_SLOT) | ||
773 | ocfs2_init_meta_steal_slot(osb); | ||
774 | goto bail; | ||
775 | } else if (status < 0 && status != -ENOSPC) { | ||
776 | mlog_errno(status); | ||
777 | goto bail; | ||
778 | } | ||
779 | |||
780 | ocfs2_free_ac_resource(*ac); | ||
781 | |||
782 | extent_steal: | ||
783 | status = ocfs2_steal_meta(osb, *ac); | ||
784 | atomic_inc(&osb->s_num_meta_stolen); | ||
662 | if (status < 0) { | 785 | if (status < 0) { |
663 | if (status != -ENOSPC) | 786 | if (status != -ENOSPC) |
664 | mlog_errno(status); | 787 | mlog_errno(status); |
@@ -685,43 +808,11 @@ int ocfs2_reserve_new_metadata(struct ocfs2_super *osb, | |||
685 | ac); | 808 | ac); |
686 | } | 809 | } |
687 | 810 | ||
688 | static int ocfs2_steal_inode_from_other_nodes(struct ocfs2_super *osb, | ||
689 | struct ocfs2_alloc_context *ac) | ||
690 | { | ||
691 | int i, status = -ENOSPC; | ||
692 | s16 slot = ocfs2_get_inode_steal_slot(osb); | ||
693 | |||
694 | /* Start to steal inodes from the first slot after ours. */ | ||
695 | if (slot == OCFS2_INVALID_SLOT) | ||
696 | slot = osb->slot_num + 1; | ||
697 | |||
698 | for (i = 0; i < osb->max_slots; i++, slot++) { | ||
699 | if (slot == osb->max_slots) | ||
700 | slot = 0; | ||
701 | |||
702 | if (slot == osb->slot_num) | ||
703 | continue; | ||
704 | |||
705 | status = ocfs2_reserve_suballoc_bits(osb, ac, | ||
706 | INODE_ALLOC_SYSTEM_INODE, | ||
707 | slot, NULL, | ||
708 | NOT_ALLOC_NEW_GROUP); | ||
709 | if (status >= 0) { | ||
710 | ocfs2_set_inode_steal_slot(osb, slot); | ||
711 | break; | ||
712 | } | ||
713 | |||
714 | ocfs2_free_ac_resource(ac); | ||
715 | } | ||
716 | |||
717 | return status; | ||
718 | } | ||
719 | |||
720 | int ocfs2_reserve_new_inode(struct ocfs2_super *osb, | 811 | int ocfs2_reserve_new_inode(struct ocfs2_super *osb, |
721 | struct ocfs2_alloc_context **ac) | 812 | struct ocfs2_alloc_context **ac) |
722 | { | 813 | { |
723 | int status; | 814 | int status; |
724 | s16 slot = ocfs2_get_inode_steal_slot(osb); | 815 | int slot = ocfs2_get_inode_steal_slot(osb); |
725 | u64 alloc_group; | 816 | u64 alloc_group; |
726 | 817 | ||
727 | *ac = kzalloc(sizeof(struct ocfs2_alloc_context), GFP_KERNEL); | 818 | *ac = kzalloc(sizeof(struct ocfs2_alloc_context), GFP_KERNEL); |
@@ -754,14 +845,14 @@ int ocfs2_reserve_new_inode(struct ocfs2_super *osb, | |||
754 | * need to check our slots to see whether there is some space for us. | 845 | * need to check our slots to see whether there is some space for us. |
755 | */ | 846 | */ |
756 | if (slot != OCFS2_INVALID_SLOT && | 847 | if (slot != OCFS2_INVALID_SLOT && |
757 | atomic_read(&osb->s_num_inodes_stolen) < OCFS2_MAX_INODES_TO_STEAL) | 848 | atomic_read(&osb->s_num_inodes_stolen) < OCFS2_MAX_TO_STEAL) |
758 | goto inode_steal; | 849 | goto inode_steal; |
759 | 850 | ||
760 | atomic_set(&osb->s_num_inodes_stolen, 0); | 851 | atomic_set(&osb->s_num_inodes_stolen, 0); |
761 | alloc_group = osb->osb_inode_alloc_group; | 852 | alloc_group = osb->osb_inode_alloc_group; |
762 | status = ocfs2_reserve_suballoc_bits(osb, *ac, | 853 | status = ocfs2_reserve_suballoc_bits(osb, *ac, |
763 | INODE_ALLOC_SYSTEM_INODE, | 854 | INODE_ALLOC_SYSTEM_INODE, |
764 | osb->slot_num, | 855 | (u32)osb->slot_num, |
765 | &alloc_group, | 856 | &alloc_group, |
766 | ALLOC_NEW_GROUP | | 857 | ALLOC_NEW_GROUP | |
767 | ALLOC_GROUPS_FROM_GLOBAL); | 858 | ALLOC_GROUPS_FROM_GLOBAL); |
@@ -789,7 +880,7 @@ int ocfs2_reserve_new_inode(struct ocfs2_super *osb, | |||
789 | ocfs2_free_ac_resource(*ac); | 880 | ocfs2_free_ac_resource(*ac); |
790 | 881 | ||
791 | inode_steal: | 882 | inode_steal: |
792 | status = ocfs2_steal_inode_from_other_nodes(osb, *ac); | 883 | status = ocfs2_steal_inode(osb, *ac); |
793 | atomic_inc(&osb->s_num_inodes_stolen); | 884 | atomic_inc(&osb->s_num_inodes_stolen); |
794 | if (status < 0) { | 885 | if (status < 0) { |
795 | if (status != -ENOSPC) | 886 | if (status != -ENOSPC) |
diff --git a/fs/ocfs2/suballoc.h b/fs/ocfs2/suballoc.h index 8c9a78a43164..fa60723c43e8 100644 --- a/fs/ocfs2/suballoc.h +++ b/fs/ocfs2/suballoc.h | |||
@@ -56,6 +56,7 @@ struct ocfs2_alloc_context { | |||
56 | is the same as ~0 - unlimited */ | 56 | is the same as ~0 - unlimited */ |
57 | }; | 57 | }; |
58 | 58 | ||
59 | void ocfs2_init_steal_slots(struct ocfs2_super *osb); | ||
59 | void ocfs2_free_alloc_context(struct ocfs2_alloc_context *ac); | 60 | void ocfs2_free_alloc_context(struct ocfs2_alloc_context *ac); |
60 | static inline int ocfs2_alloc_context_bits_left(struct ocfs2_alloc_context *ac) | 61 | static inline int ocfs2_alloc_context_bits_left(struct ocfs2_alloc_context *ac) |
61 | { | 62 | { |
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index 755cd49a5ef3..dee03197a494 100644 --- a/fs/ocfs2/super.c +++ b/fs/ocfs2/super.c | |||
@@ -69,6 +69,7 @@ | |||
69 | #include "xattr.h" | 69 | #include "xattr.h" |
70 | #include "quota.h" | 70 | #include "quota.h" |
71 | #include "refcounttree.h" | 71 | #include "refcounttree.h" |
72 | #include "suballoc.h" | ||
72 | 73 | ||
73 | #include "buffer_head_io.h" | 74 | #include "buffer_head_io.h" |
74 | 75 | ||
@@ -301,9 +302,12 @@ static int ocfs2_osb_dump(struct ocfs2_super *osb, char *buf, int len) | |||
301 | 302 | ||
302 | spin_lock(&osb->osb_lock); | 303 | spin_lock(&osb->osb_lock); |
303 | out += snprintf(buf + out, len - out, | 304 | out += snprintf(buf + out, len - out, |
304 | "%10s => Slot: %d NumStolen: %d\n", "Steal", | 305 | "%10s => InodeSlot: %d StolenInodes: %d, " |
306 | "MetaSlot: %d StolenMeta: %d\n", "Steal", | ||
305 | osb->s_inode_steal_slot, | 307 | osb->s_inode_steal_slot, |
306 | atomic_read(&osb->s_num_inodes_stolen)); | 308 | atomic_read(&osb->s_num_inodes_stolen), |
309 | osb->s_meta_steal_slot, | ||
310 | atomic_read(&osb->s_num_meta_stolen)); | ||
307 | spin_unlock(&osb->osb_lock); | 311 | spin_unlock(&osb->osb_lock); |
308 | 312 | ||
309 | out += snprintf(buf + out, len - out, "OrphanScan => "); | 313 | out += snprintf(buf + out, len - out, "OrphanScan => "); |
@@ -1997,7 +2001,7 @@ static int ocfs2_initialize_super(struct super_block *sb, | |||
1997 | osb->blocked_lock_count = 0; | 2001 | osb->blocked_lock_count = 0; |
1998 | spin_lock_init(&osb->osb_lock); | 2002 | spin_lock_init(&osb->osb_lock); |
1999 | spin_lock_init(&osb->osb_xattr_lock); | 2003 | spin_lock_init(&osb->osb_xattr_lock); |
2000 | ocfs2_init_inode_steal_slot(osb); | 2004 | ocfs2_init_steal_slots(osb); |
2001 | 2005 | ||
2002 | atomic_set(&osb->alloc_stats.moves, 0); | 2006 | atomic_set(&osb->alloc_stats.moves, 0); |
2003 | atomic_set(&osb->alloc_stats.local_data, 0); | 2007 | atomic_set(&osb->alloc_stats.local_data, 0); |
diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 8fc6fb071c6d..d1b0d386f6d1 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c | |||
@@ -116,10 +116,11 @@ static struct xattr_handler *ocfs2_xattr_handler_map[OCFS2_XATTR_MAX] = { | |||
116 | }; | 116 | }; |
117 | 117 | ||
118 | struct ocfs2_xattr_info { | 118 | struct ocfs2_xattr_info { |
119 | int name_index; | 119 | int xi_name_index; |
120 | const char *name; | 120 | const char *xi_name; |
121 | const void *value; | 121 | int xi_name_len; |
122 | size_t value_len; | 122 | const void *xi_value; |
123 | size_t xi_value_len; | ||
123 | }; | 124 | }; |
124 | 125 | ||
125 | struct ocfs2_xattr_search { | 126 | struct ocfs2_xattr_search { |
@@ -137,6 +138,115 @@ struct ocfs2_xattr_search { | |||
137 | int not_found; | 138 | int not_found; |
138 | }; | 139 | }; |
139 | 140 | ||
141 | /* Operations on struct ocfs2_xa_entry */ | ||
142 | struct ocfs2_xa_loc; | ||
143 | struct ocfs2_xa_loc_operations { | ||
144 | /* | ||
145 | * Journal functions | ||
146 | */ | ||
147 | int (*xlo_journal_access)(handle_t *handle, struct ocfs2_xa_loc *loc, | ||
148 | int type); | ||
149 | void (*xlo_journal_dirty)(handle_t *handle, struct ocfs2_xa_loc *loc); | ||
150 | |||
151 | /* | ||
152 | * Return a pointer to the appropriate buffer in loc->xl_storage | ||
153 | * at the given offset from loc->xl_header. | ||
154 | */ | ||
155 | void *(*xlo_offset_pointer)(struct ocfs2_xa_loc *loc, int offset); | ||
156 | |||
157 | /* Can we reuse the existing entry for the new value? */ | ||
158 | int (*xlo_can_reuse)(struct ocfs2_xa_loc *loc, | ||
159 | struct ocfs2_xattr_info *xi); | ||
160 | |||
161 | /* How much space is needed for the new value? */ | ||
162 | int (*xlo_check_space)(struct ocfs2_xa_loc *loc, | ||
163 | struct ocfs2_xattr_info *xi); | ||
164 | |||
165 | /* | ||
166 | * Return the offset of the first name+value pair. This is | ||
167 | * the start of our downward-filling free space. | ||
168 | */ | ||
169 | int (*xlo_get_free_start)(struct ocfs2_xa_loc *loc); | ||
170 | |||
171 | /* | ||
172 | * Remove the name+value at this location. Do whatever is | ||
173 | * appropriate with the remaining name+value pairs. | ||
174 | */ | ||
175 | void (*xlo_wipe_namevalue)(struct ocfs2_xa_loc *loc); | ||
176 | |||
177 | /* Fill xl_entry with a new entry */ | ||
178 | void (*xlo_add_entry)(struct ocfs2_xa_loc *loc, u32 name_hash); | ||
179 | |||
180 | /* Add name+value storage to an entry */ | ||
181 | void (*xlo_add_namevalue)(struct ocfs2_xa_loc *loc, int size); | ||
182 | |||
183 | /* | ||
184 | * Initialize the value buf's access and bh fields for this entry. | ||
185 | * ocfs2_xa_fill_value_buf() will handle the xv pointer. | ||
186 | */ | ||
187 | void (*xlo_fill_value_buf)(struct ocfs2_xa_loc *loc, | ||
188 | struct ocfs2_xattr_value_buf *vb); | ||
189 | }; | ||
190 | |||
191 | /* | ||
192 | * Describes an xattr entry location. This is a memory structure | ||
193 | * tracking the on-disk structure. | ||
194 | */ | ||
195 | struct ocfs2_xa_loc { | ||
196 | /* This xattr belongs to this inode */ | ||
197 | struct inode *xl_inode; | ||
198 | |||
199 | /* The ocfs2_xattr_header inside the on-disk storage. Not NULL. */ | ||
200 | struct ocfs2_xattr_header *xl_header; | ||
201 | |||
202 | /* Bytes from xl_header to the end of the storage */ | ||
203 | int xl_size; | ||
204 | |||
205 | /* | ||
206 | * The ocfs2_xattr_entry this location describes. If this is | ||
207 | * NULL, this location describes the on-disk structure where it | ||
208 | * would have been. | ||
209 | */ | ||
210 | struct ocfs2_xattr_entry *xl_entry; | ||
211 | |||
212 | /* | ||
213 | * Internal housekeeping | ||
214 | */ | ||
215 | |||
216 | /* Buffer(s) containing this entry */ | ||
217 | void *xl_storage; | ||
218 | |||
219 | /* Operations on the storage backing this location */ | ||
220 | const struct ocfs2_xa_loc_operations *xl_ops; | ||
221 | }; | ||
222 | |||
223 | /* | ||
224 | * Convenience functions to calculate how much space is needed for a | ||
225 | * given name+value pair | ||
226 | */ | ||
227 | static int namevalue_size(int name_len, uint64_t value_len) | ||
228 | { | ||
229 | if (value_len > OCFS2_XATTR_INLINE_SIZE) | ||
230 | return OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_ROOT_SIZE; | ||
231 | else | ||
232 | return OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_SIZE(value_len); | ||
233 | } | ||
234 | |||
235 | static int namevalue_size_xi(struct ocfs2_xattr_info *xi) | ||
236 | { | ||
237 | return namevalue_size(xi->xi_name_len, xi->xi_value_len); | ||
238 | } | ||
239 | |||
240 | static int namevalue_size_xe(struct ocfs2_xattr_entry *xe) | ||
241 | { | ||
242 | u64 value_len = le64_to_cpu(xe->xe_value_size); | ||
243 | |||
244 | BUG_ON((value_len > OCFS2_XATTR_INLINE_SIZE) && | ||
245 | ocfs2_xattr_is_local(xe)); | ||
246 | return namevalue_size(xe->xe_name_len, value_len); | ||
247 | } | ||
248 | |||
249 | |||
140 | static int ocfs2_xattr_bucket_get_name_value(struct super_block *sb, | 250 | static int ocfs2_xattr_bucket_get_name_value(struct super_block *sb, |
141 | struct ocfs2_xattr_header *xh, | 251 | struct ocfs2_xattr_header *xh, |
142 | int index, | 252 | int index, |
@@ -212,14 +322,6 @@ static inline u16 ocfs2_blocks_per_xattr_bucket(struct super_block *sb) | |||
212 | return OCFS2_XATTR_BUCKET_SIZE / (1 << sb->s_blocksize_bits); | 322 | return OCFS2_XATTR_BUCKET_SIZE / (1 << sb->s_blocksize_bits); |
213 | } | 323 | } |
214 | 324 | ||
215 | static inline u16 ocfs2_xattr_max_xe_in_bucket(struct super_block *sb) | ||
216 | { | ||
217 | u16 len = sb->s_blocksize - | ||
218 | offsetof(struct ocfs2_xattr_header, xh_entries); | ||
219 | |||
220 | return len / sizeof(struct ocfs2_xattr_entry); | ||
221 | } | ||
222 | |||
223 | #define bucket_blkno(_b) ((_b)->bu_bhs[0]->b_blocknr) | 325 | #define bucket_blkno(_b) ((_b)->bu_bhs[0]->b_blocknr) |
224 | #define bucket_block(_b, _n) ((_b)->bu_bhs[(_n)]->b_data) | 326 | #define bucket_block(_b, _n) ((_b)->bu_bhs[(_n)]->b_data) |
225 | #define bucket_xh(_b) ((struct ocfs2_xattr_header *)bucket_block((_b), 0)) | 327 | #define bucket_xh(_b) ((struct ocfs2_xattr_header *)bucket_block((_b), 0)) |
@@ -463,35 +565,22 @@ static u32 ocfs2_xattr_name_hash(struct inode *inode, | |||
463 | return hash; | 565 | return hash; |
464 | } | 566 | } |
465 | 567 | ||
466 | /* | 568 | static int ocfs2_xattr_entry_real_size(int name_len, size_t value_len) |
467 | * ocfs2_xattr_hash_entry() | ||
468 | * | ||
469 | * Compute the hash of an extended attribute. | ||
470 | */ | ||
471 | static void ocfs2_xattr_hash_entry(struct inode *inode, | ||
472 | struct ocfs2_xattr_header *header, | ||
473 | struct ocfs2_xattr_entry *entry) | ||
474 | { | 569 | { |
475 | u32 hash = 0; | 570 | return namevalue_size(name_len, value_len) + |
476 | char *name = (char *)header + le16_to_cpu(entry->xe_name_offset); | 571 | sizeof(struct ocfs2_xattr_entry); |
477 | |||
478 | hash = ocfs2_xattr_name_hash(inode, name, entry->xe_name_len); | ||
479 | entry->xe_name_hash = cpu_to_le32(hash); | ||
480 | |||
481 | return; | ||
482 | } | 572 | } |
483 | 573 | ||
484 | static int ocfs2_xattr_entry_real_size(int name_len, size_t value_len) | 574 | static int ocfs2_xi_entry_usage(struct ocfs2_xattr_info *xi) |
485 | { | 575 | { |
486 | int size = 0; | 576 | return namevalue_size_xi(xi) + |
487 | 577 | sizeof(struct ocfs2_xattr_entry); | |
488 | if (value_len <= OCFS2_XATTR_INLINE_SIZE) | 578 | } |
489 | size = OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_SIZE(value_len); | ||
490 | else | ||
491 | size = OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_ROOT_SIZE; | ||
492 | size += sizeof(struct ocfs2_xattr_entry); | ||
493 | 579 | ||
494 | return size; | 580 | static int ocfs2_xe_entry_usage(struct ocfs2_xattr_entry *xe) |
581 | { | ||
582 | return namevalue_size_xe(xe) + | ||
583 | sizeof(struct ocfs2_xattr_entry); | ||
495 | } | 584 | } |
496 | 585 | ||
497 | int ocfs2_calc_security_init(struct inode *dir, | 586 | int ocfs2_calc_security_init(struct inode *dir, |
@@ -1308,452 +1397,897 @@ out: | |||
1308 | return ret; | 1397 | return ret; |
1309 | } | 1398 | } |
1310 | 1399 | ||
1311 | static int ocfs2_xattr_cleanup(struct inode *inode, | 1400 | static int ocfs2_xa_check_space_helper(int needed_space, int free_start, |
1312 | handle_t *handle, | 1401 | int num_entries) |
1313 | struct ocfs2_xattr_info *xi, | ||
1314 | struct ocfs2_xattr_search *xs, | ||
1315 | struct ocfs2_xattr_value_buf *vb, | ||
1316 | size_t offs) | ||
1317 | { | 1402 | { |
1318 | int ret = 0; | 1403 | int free_space; |
1319 | size_t name_len = strlen(xi->name); | ||
1320 | void *val = xs->base + offs; | ||
1321 | size_t size = OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_ROOT_SIZE; | ||
1322 | 1404 | ||
1323 | ret = vb->vb_access(handle, INODE_CACHE(inode), vb->vb_bh, | 1405 | if (!needed_space) |
1324 | OCFS2_JOURNAL_ACCESS_WRITE); | 1406 | return 0; |
1325 | if (ret) { | ||
1326 | mlog_errno(ret); | ||
1327 | goto out; | ||
1328 | } | ||
1329 | /* Decrease xattr count */ | ||
1330 | le16_add_cpu(&xs->header->xh_count, -1); | ||
1331 | /* Remove the xattr entry and tree root which has already be set*/ | ||
1332 | memset((void *)xs->here, 0, sizeof(struct ocfs2_xattr_entry)); | ||
1333 | memset(val, 0, size); | ||
1334 | 1407 | ||
1335 | ret = ocfs2_journal_dirty(handle, vb->vb_bh); | 1408 | free_space = free_start - |
1336 | if (ret < 0) | 1409 | sizeof(struct ocfs2_xattr_header) - |
1337 | mlog_errno(ret); | 1410 | (num_entries * sizeof(struct ocfs2_xattr_entry)) - |
1338 | out: | 1411 | OCFS2_XATTR_HEADER_GAP; |
1339 | return ret; | 1412 | if (free_space < 0) |
1413 | return -EIO; | ||
1414 | if (free_space < needed_space) | ||
1415 | return -ENOSPC; | ||
1416 | |||
1417 | return 0; | ||
1340 | } | 1418 | } |
1341 | 1419 | ||
1342 | static int ocfs2_xattr_update_entry(struct inode *inode, | 1420 | static int ocfs2_xa_journal_access(handle_t *handle, struct ocfs2_xa_loc *loc, |
1343 | handle_t *handle, | 1421 | int type) |
1344 | struct ocfs2_xattr_info *xi, | ||
1345 | struct ocfs2_xattr_search *xs, | ||
1346 | struct ocfs2_xattr_value_buf *vb, | ||
1347 | size_t offs) | ||
1348 | { | 1422 | { |
1349 | int ret; | 1423 | return loc->xl_ops->xlo_journal_access(handle, loc, type); |
1424 | } | ||
1350 | 1425 | ||
1351 | ret = vb->vb_access(handle, INODE_CACHE(inode), vb->vb_bh, | 1426 | static void ocfs2_xa_journal_dirty(handle_t *handle, struct ocfs2_xa_loc *loc) |
1352 | OCFS2_JOURNAL_ACCESS_WRITE); | 1427 | { |
1353 | if (ret) { | 1428 | loc->xl_ops->xlo_journal_dirty(handle, loc); |
1354 | mlog_errno(ret); | 1429 | } |
1355 | goto out; | ||
1356 | } | ||
1357 | 1430 | ||
1358 | xs->here->xe_name_offset = cpu_to_le16(offs); | 1431 | /* Give a pointer into the storage for the given offset */ |
1359 | xs->here->xe_value_size = cpu_to_le64(xi->value_len); | 1432 | static void *ocfs2_xa_offset_pointer(struct ocfs2_xa_loc *loc, int offset) |
1360 | if (xi->value_len <= OCFS2_XATTR_INLINE_SIZE) | 1433 | { |
1361 | ocfs2_xattr_set_local(xs->here, 1); | 1434 | BUG_ON(offset >= loc->xl_size); |
1362 | else | 1435 | return loc->xl_ops->xlo_offset_pointer(loc, offset); |
1363 | ocfs2_xattr_set_local(xs->here, 0); | 1436 | } |
1364 | ocfs2_xattr_hash_entry(inode, xs->header, xs->here); | ||
1365 | 1437 | ||
1366 | ret = ocfs2_journal_dirty(handle, vb->vb_bh); | 1438 | /* |
1367 | if (ret < 0) | 1439 | * Wipe the name+value pair and allow the storage to reclaim it. This |
1368 | mlog_errno(ret); | 1440 | * must be followed by either removal of the entry or a call to |
1369 | out: | 1441 | * ocfs2_xa_add_namevalue(). |
1370 | return ret; | 1442 | */ |
1443 | static void ocfs2_xa_wipe_namevalue(struct ocfs2_xa_loc *loc) | ||
1444 | { | ||
1445 | loc->xl_ops->xlo_wipe_namevalue(loc); | ||
1371 | } | 1446 | } |
1372 | 1447 | ||
1373 | /* | 1448 | /* |
1374 | * ocfs2_xattr_set_value_outside() | 1449 | * Find lowest offset to a name+value pair. This is the start of our |
1375 | * | 1450 | * downward-growing free space. |
1376 | * Set large size value in B tree. | ||
1377 | */ | 1451 | */ |
1378 | static int ocfs2_xattr_set_value_outside(struct inode *inode, | 1452 | static int ocfs2_xa_get_free_start(struct ocfs2_xa_loc *loc) |
1379 | struct ocfs2_xattr_info *xi, | ||
1380 | struct ocfs2_xattr_search *xs, | ||
1381 | struct ocfs2_xattr_set_ctxt *ctxt, | ||
1382 | struct ocfs2_xattr_value_buf *vb, | ||
1383 | size_t offs) | ||
1384 | { | 1453 | { |
1385 | size_t name_len = strlen(xi->name); | 1454 | return loc->xl_ops->xlo_get_free_start(loc); |
1386 | void *val = xs->base + offs; | 1455 | } |
1387 | struct ocfs2_xattr_value_root *xv = NULL; | ||
1388 | size_t size = OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_ROOT_SIZE; | ||
1389 | int ret = 0; | ||
1390 | 1456 | ||
1391 | memset(val, 0, size); | 1457 | /* Can we reuse loc->xl_entry for xi? */ |
1392 | memcpy(val, xi->name, name_len); | 1458 | static int ocfs2_xa_can_reuse_entry(struct ocfs2_xa_loc *loc, |
1393 | xv = (struct ocfs2_xattr_value_root *) | 1459 | struct ocfs2_xattr_info *xi) |
1394 | (val + OCFS2_XATTR_SIZE(name_len)); | 1460 | { |
1395 | xv->xr_clusters = 0; | 1461 | return loc->xl_ops->xlo_can_reuse(loc, xi); |
1396 | xv->xr_last_eb_blk = 0; | 1462 | } |
1397 | xv->xr_list.l_tree_depth = 0; | 1463 | |
1398 | xv->xr_list.l_count = cpu_to_le16(1); | 1464 | /* How much free space is needed to set the new value */ |
1399 | xv->xr_list.l_next_free_rec = 0; | 1465 | static int ocfs2_xa_check_space(struct ocfs2_xa_loc *loc, |
1400 | vb->vb_xv = xv; | 1466 | struct ocfs2_xattr_info *xi) |
1401 | 1467 | { | |
1402 | ret = ocfs2_xattr_value_truncate(inode, vb, xi->value_len, ctxt); | 1468 | return loc->xl_ops->xlo_check_space(loc, xi); |
1403 | if (ret < 0) { | 1469 | } |
1404 | mlog_errno(ret); | 1470 | |
1405 | return ret; | 1471 | static void ocfs2_xa_add_entry(struct ocfs2_xa_loc *loc, u32 name_hash) |
1472 | { | ||
1473 | loc->xl_ops->xlo_add_entry(loc, name_hash); | ||
1474 | loc->xl_entry->xe_name_hash = cpu_to_le32(name_hash); | ||
1475 | /* | ||
1476 | * We can't leave the new entry's xe_name_offset at zero or | ||
1477 | * add_namevalue() will go nuts. We set it to the size of our | ||
1478 | * storage so that it can never be less than any other entry. | ||
1479 | */ | ||
1480 | loc->xl_entry->xe_name_offset = cpu_to_le16(loc->xl_size); | ||
1481 | } | ||
1482 | |||
1483 | static void ocfs2_xa_add_namevalue(struct ocfs2_xa_loc *loc, | ||
1484 | struct ocfs2_xattr_info *xi) | ||
1485 | { | ||
1486 | int size = namevalue_size_xi(xi); | ||
1487 | int nameval_offset; | ||
1488 | char *nameval_buf; | ||
1489 | |||
1490 | loc->xl_ops->xlo_add_namevalue(loc, size); | ||
1491 | loc->xl_entry->xe_value_size = cpu_to_le64(xi->xi_value_len); | ||
1492 | loc->xl_entry->xe_name_len = xi->xi_name_len; | ||
1493 | ocfs2_xattr_set_type(loc->xl_entry, xi->xi_name_index); | ||
1494 | ocfs2_xattr_set_local(loc->xl_entry, | ||
1495 | xi->xi_value_len <= OCFS2_XATTR_INLINE_SIZE); | ||
1496 | |||
1497 | nameval_offset = le16_to_cpu(loc->xl_entry->xe_name_offset); | ||
1498 | nameval_buf = ocfs2_xa_offset_pointer(loc, nameval_offset); | ||
1499 | memset(nameval_buf, 0, size); | ||
1500 | memcpy(nameval_buf, xi->xi_name, xi->xi_name_len); | ||
1501 | } | ||
1502 | |||
1503 | static void ocfs2_xa_fill_value_buf(struct ocfs2_xa_loc *loc, | ||
1504 | struct ocfs2_xattr_value_buf *vb) | ||
1505 | { | ||
1506 | int nameval_offset = le16_to_cpu(loc->xl_entry->xe_name_offset); | ||
1507 | int name_size = OCFS2_XATTR_SIZE(loc->xl_entry->xe_name_len); | ||
1508 | |||
1509 | /* Value bufs are for value trees */ | ||
1510 | BUG_ON(ocfs2_xattr_is_local(loc->xl_entry)); | ||
1511 | BUG_ON(namevalue_size_xe(loc->xl_entry) != | ||
1512 | (name_size + OCFS2_XATTR_ROOT_SIZE)); | ||
1513 | |||
1514 | loc->xl_ops->xlo_fill_value_buf(loc, vb); | ||
1515 | vb->vb_xv = | ||
1516 | (struct ocfs2_xattr_value_root *)ocfs2_xa_offset_pointer(loc, | ||
1517 | nameval_offset + | ||
1518 | name_size); | ||
1519 | } | ||
1520 | |||
1521 | static int ocfs2_xa_block_journal_access(handle_t *handle, | ||
1522 | struct ocfs2_xa_loc *loc, int type) | ||
1523 | { | ||
1524 | struct buffer_head *bh = loc->xl_storage; | ||
1525 | ocfs2_journal_access_func access; | ||
1526 | |||
1527 | if (loc->xl_size == (bh->b_size - | ||
1528 | offsetof(struct ocfs2_xattr_block, | ||
1529 | xb_attrs.xb_header))) | ||
1530 | access = ocfs2_journal_access_xb; | ||
1531 | else | ||
1532 | access = ocfs2_journal_access_di; | ||
1533 | return access(handle, INODE_CACHE(loc->xl_inode), bh, type); | ||
1534 | } | ||
1535 | |||
1536 | static void ocfs2_xa_block_journal_dirty(handle_t *handle, | ||
1537 | struct ocfs2_xa_loc *loc) | ||
1538 | { | ||
1539 | struct buffer_head *bh = loc->xl_storage; | ||
1540 | |||
1541 | ocfs2_journal_dirty(handle, bh); | ||
1542 | } | ||
1543 | |||
1544 | static void *ocfs2_xa_block_offset_pointer(struct ocfs2_xa_loc *loc, | ||
1545 | int offset) | ||
1546 | { | ||
1547 | return (char *)loc->xl_header + offset; | ||
1548 | } | ||
1549 | |||
1550 | static int ocfs2_xa_block_can_reuse(struct ocfs2_xa_loc *loc, | ||
1551 | struct ocfs2_xattr_info *xi) | ||
1552 | { | ||
1553 | /* | ||
1554 | * Block storage is strict. If the sizes aren't exact, we will | ||
1555 | * remove the old one and reinsert the new. | ||
1556 | */ | ||
1557 | return namevalue_size_xe(loc->xl_entry) == | ||
1558 | namevalue_size_xi(xi); | ||
1559 | } | ||
1560 | |||
1561 | static int ocfs2_xa_block_get_free_start(struct ocfs2_xa_loc *loc) | ||
1562 | { | ||
1563 | struct ocfs2_xattr_header *xh = loc->xl_header; | ||
1564 | int i, count = le16_to_cpu(xh->xh_count); | ||
1565 | int offset, free_start = loc->xl_size; | ||
1566 | |||
1567 | for (i = 0; i < count; i++) { | ||
1568 | offset = le16_to_cpu(xh->xh_entries[i].xe_name_offset); | ||
1569 | if (offset < free_start) | ||
1570 | free_start = offset; | ||
1406 | } | 1571 | } |
1407 | ret = ocfs2_xattr_update_entry(inode, ctxt->handle, xi, xs, vb, offs); | 1572 | |
1408 | if (ret < 0) { | 1573 | return free_start; |
1409 | mlog_errno(ret); | 1574 | } |
1410 | return ret; | 1575 | |
1576 | static int ocfs2_xa_block_check_space(struct ocfs2_xa_loc *loc, | ||
1577 | struct ocfs2_xattr_info *xi) | ||
1578 | { | ||
1579 | int count = le16_to_cpu(loc->xl_header->xh_count); | ||
1580 | int free_start = ocfs2_xa_get_free_start(loc); | ||
1581 | int needed_space = ocfs2_xi_entry_usage(xi); | ||
1582 | |||
1583 | /* | ||
1584 | * Block storage will reclaim the original entry before inserting | ||
1585 | * the new value, so we only need the difference. If the new | ||
1586 | * entry is smaller than the old one, we don't need anything. | ||
1587 | */ | ||
1588 | if (loc->xl_entry) { | ||
1589 | /* Don't need space if we're reusing! */ | ||
1590 | if (ocfs2_xa_can_reuse_entry(loc, xi)) | ||
1591 | needed_space = 0; | ||
1592 | else | ||
1593 | needed_space -= ocfs2_xe_entry_usage(loc->xl_entry); | ||
1411 | } | 1594 | } |
1412 | ret = __ocfs2_xattr_set_value_outside(inode, ctxt->handle, vb, | 1595 | if (needed_space < 0) |
1413 | xi->value, xi->value_len); | 1596 | needed_space = 0; |
1414 | if (ret < 0) | 1597 | return ocfs2_xa_check_space_helper(needed_space, free_start, count); |
1415 | mlog_errno(ret); | 1598 | } |
1416 | 1599 | ||
1417 | return ret; | 1600 | /* |
1601 | * Block storage for xattrs keeps the name+value pairs compacted. When | ||
1602 | * we remove one, we have to shift any that preceded it towards the end. | ||
1603 | */ | ||
1604 | static void ocfs2_xa_block_wipe_namevalue(struct ocfs2_xa_loc *loc) | ||
1605 | { | ||
1606 | int i, offset; | ||
1607 | int namevalue_offset, first_namevalue_offset, namevalue_size; | ||
1608 | struct ocfs2_xattr_entry *entry = loc->xl_entry; | ||
1609 | struct ocfs2_xattr_header *xh = loc->xl_header; | ||
1610 | int count = le16_to_cpu(xh->xh_count); | ||
1611 | |||
1612 | namevalue_offset = le16_to_cpu(entry->xe_name_offset); | ||
1613 | namevalue_size = namevalue_size_xe(entry); | ||
1614 | first_namevalue_offset = ocfs2_xa_get_free_start(loc); | ||
1615 | |||
1616 | /* Shift the name+value pairs */ | ||
1617 | memmove((char *)xh + first_namevalue_offset + namevalue_size, | ||
1618 | (char *)xh + first_namevalue_offset, | ||
1619 | namevalue_offset - first_namevalue_offset); | ||
1620 | memset((char *)xh + first_namevalue_offset, 0, namevalue_size); | ||
1621 | |||
1622 | /* Now tell xh->xh_entries about it */ | ||
1623 | for (i = 0; i < count; i++) { | ||
1624 | offset = le16_to_cpu(xh->xh_entries[i].xe_name_offset); | ||
1625 | if (offset < namevalue_offset) | ||
1626 | le16_add_cpu(&xh->xh_entries[i].xe_name_offset, | ||
1627 | namevalue_size); | ||
1628 | } | ||
1629 | |||
1630 | /* | ||
1631 | * Note that we don't update xh_free_start or xh_name_value_len | ||
1632 | * because they're not used in block-stored xattrs. | ||
1633 | */ | ||
1634 | } | ||
1635 | |||
1636 | static void ocfs2_xa_block_add_entry(struct ocfs2_xa_loc *loc, u32 name_hash) | ||
1637 | { | ||
1638 | int count = le16_to_cpu(loc->xl_header->xh_count); | ||
1639 | loc->xl_entry = &(loc->xl_header->xh_entries[count]); | ||
1640 | le16_add_cpu(&loc->xl_header->xh_count, 1); | ||
1641 | memset(loc->xl_entry, 0, sizeof(struct ocfs2_xattr_entry)); | ||
1642 | } | ||
1643 | |||
1644 | static void ocfs2_xa_block_add_namevalue(struct ocfs2_xa_loc *loc, int size) | ||
1645 | { | ||
1646 | int free_start = ocfs2_xa_get_free_start(loc); | ||
1647 | |||
1648 | loc->xl_entry->xe_name_offset = cpu_to_le16(free_start - size); | ||
1649 | } | ||
1650 | |||
1651 | static void ocfs2_xa_block_fill_value_buf(struct ocfs2_xa_loc *loc, | ||
1652 | struct ocfs2_xattr_value_buf *vb) | ||
1653 | { | ||
1654 | struct buffer_head *bh = loc->xl_storage; | ||
1655 | |||
1656 | if (loc->xl_size == (bh->b_size - | ||
1657 | offsetof(struct ocfs2_xattr_block, | ||
1658 | xb_attrs.xb_header))) | ||
1659 | vb->vb_access = ocfs2_journal_access_xb; | ||
1660 | else | ||
1661 | vb->vb_access = ocfs2_journal_access_di; | ||
1662 | vb->vb_bh = bh; | ||
1418 | } | 1663 | } |
1419 | 1664 | ||
1420 | /* | 1665 | /* |
1421 | * ocfs2_xattr_set_entry_local() | 1666 | * Operations for xattrs stored in blocks. This includes inline inode |
1422 | * | 1667 | * storage and unindexed ocfs2_xattr_blocks. |
1423 | * Set, replace or remove extended attribute in local. | ||
1424 | */ | 1668 | */ |
1425 | static void ocfs2_xattr_set_entry_local(struct inode *inode, | 1669 | static const struct ocfs2_xa_loc_operations ocfs2_xa_block_loc_ops = { |
1426 | struct ocfs2_xattr_info *xi, | 1670 | .xlo_journal_access = ocfs2_xa_block_journal_access, |
1427 | struct ocfs2_xattr_search *xs, | 1671 | .xlo_journal_dirty = ocfs2_xa_block_journal_dirty, |
1428 | struct ocfs2_xattr_entry *last, | 1672 | .xlo_offset_pointer = ocfs2_xa_block_offset_pointer, |
1429 | size_t min_offs) | 1673 | .xlo_check_space = ocfs2_xa_block_check_space, |
1674 | .xlo_can_reuse = ocfs2_xa_block_can_reuse, | ||
1675 | .xlo_get_free_start = ocfs2_xa_block_get_free_start, | ||
1676 | .xlo_wipe_namevalue = ocfs2_xa_block_wipe_namevalue, | ||
1677 | .xlo_add_entry = ocfs2_xa_block_add_entry, | ||
1678 | .xlo_add_namevalue = ocfs2_xa_block_add_namevalue, | ||
1679 | .xlo_fill_value_buf = ocfs2_xa_block_fill_value_buf, | ||
1680 | }; | ||
1681 | |||
1682 | static int ocfs2_xa_bucket_journal_access(handle_t *handle, | ||
1683 | struct ocfs2_xa_loc *loc, int type) | ||
1430 | { | 1684 | { |
1431 | size_t name_len = strlen(xi->name); | 1685 | struct ocfs2_xattr_bucket *bucket = loc->xl_storage; |
1432 | int i; | ||
1433 | 1686 | ||
1434 | if (xi->value && xs->not_found) { | 1687 | return ocfs2_xattr_bucket_journal_access(handle, bucket, type); |
1435 | /* Insert the new xattr entry. */ | 1688 | } |
1436 | le16_add_cpu(&xs->header->xh_count, 1); | 1689 | |
1437 | ocfs2_xattr_set_type(last, xi->name_index); | 1690 | static void ocfs2_xa_bucket_journal_dirty(handle_t *handle, |
1438 | ocfs2_xattr_set_local(last, 1); | 1691 | struct ocfs2_xa_loc *loc) |
1439 | last->xe_name_len = name_len; | 1692 | { |
1440 | } else { | 1693 | struct ocfs2_xattr_bucket *bucket = loc->xl_storage; |
1441 | void *first_val; | 1694 | |
1442 | void *val; | 1695 | ocfs2_xattr_bucket_journal_dirty(handle, bucket); |
1443 | size_t offs, size; | 1696 | } |
1444 | 1697 | ||
1445 | first_val = xs->base + min_offs; | 1698 | static void *ocfs2_xa_bucket_offset_pointer(struct ocfs2_xa_loc *loc, |
1446 | offs = le16_to_cpu(xs->here->xe_name_offset); | 1699 | int offset) |
1447 | val = xs->base + offs; | 1700 | { |
1448 | 1701 | struct ocfs2_xattr_bucket *bucket = loc->xl_storage; | |
1449 | if (le64_to_cpu(xs->here->xe_value_size) > | 1702 | int block, block_offset; |
1450 | OCFS2_XATTR_INLINE_SIZE) | 1703 | |
1451 | size = OCFS2_XATTR_SIZE(name_len) + | 1704 | /* The header is at the front of the bucket */ |
1452 | OCFS2_XATTR_ROOT_SIZE; | 1705 | block = offset >> loc->xl_inode->i_sb->s_blocksize_bits; |
1706 | block_offset = offset % loc->xl_inode->i_sb->s_blocksize; | ||
1707 | |||
1708 | return bucket_block(bucket, block) + block_offset; | ||
1709 | } | ||
1710 | |||
1711 | static int ocfs2_xa_bucket_can_reuse(struct ocfs2_xa_loc *loc, | ||
1712 | struct ocfs2_xattr_info *xi) | ||
1713 | { | ||
1714 | return namevalue_size_xe(loc->xl_entry) >= | ||
1715 | namevalue_size_xi(xi); | ||
1716 | } | ||
1717 | |||
1718 | static int ocfs2_xa_bucket_get_free_start(struct ocfs2_xa_loc *loc) | ||
1719 | { | ||
1720 | struct ocfs2_xattr_bucket *bucket = loc->xl_storage; | ||
1721 | return le16_to_cpu(bucket_xh(bucket)->xh_free_start); | ||
1722 | } | ||
1723 | |||
1724 | static int ocfs2_bucket_align_free_start(struct super_block *sb, | ||
1725 | int free_start, int size) | ||
1726 | { | ||
1727 | /* | ||
1728 | * We need to make sure that the name+value pair fits within | ||
1729 | * one block. | ||
1730 | */ | ||
1731 | if (((free_start - size) >> sb->s_blocksize_bits) != | ||
1732 | ((free_start - 1) >> sb->s_blocksize_bits)) | ||
1733 | free_start -= free_start % sb->s_blocksize; | ||
1734 | |||
1735 | return free_start; | ||
1736 | } | ||
1737 | |||
1738 | static int ocfs2_xa_bucket_check_space(struct ocfs2_xa_loc *loc, | ||
1739 | struct ocfs2_xattr_info *xi) | ||
1740 | { | ||
1741 | int rc; | ||
1742 | int count = le16_to_cpu(loc->xl_header->xh_count); | ||
1743 | int free_start = ocfs2_xa_get_free_start(loc); | ||
1744 | int needed_space = ocfs2_xi_entry_usage(xi); | ||
1745 | int size = namevalue_size_xi(xi); | ||
1746 | struct super_block *sb = loc->xl_inode->i_sb; | ||
1747 | |||
1748 | /* | ||
1749 | * Bucket storage does not reclaim name+value pairs it cannot | ||
1750 | * reuse. They live as holes until the bucket fills, and then | ||
1751 | * the bucket is defragmented. However, the bucket can reclaim | ||
1752 | * the ocfs2_xattr_entry. | ||
1753 | */ | ||
1754 | if (loc->xl_entry) { | ||
1755 | /* Don't need space if we're reusing! */ | ||
1756 | if (ocfs2_xa_can_reuse_entry(loc, xi)) | ||
1757 | needed_space = 0; | ||
1453 | else | 1758 | else |
1454 | size = OCFS2_XATTR_SIZE(name_len) + | 1759 | needed_space -= sizeof(struct ocfs2_xattr_entry); |
1455 | OCFS2_XATTR_SIZE(le64_to_cpu(xs->here->xe_value_size)); | 1760 | } |
1456 | 1761 | BUG_ON(needed_space < 0); | |
1457 | if (xi->value && size == OCFS2_XATTR_SIZE(name_len) + | ||
1458 | OCFS2_XATTR_SIZE(xi->value_len)) { | ||
1459 | /* The old and the new value have the | ||
1460 | same size. Just replace the value. */ | ||
1461 | ocfs2_xattr_set_local(xs->here, 1); | ||
1462 | xs->here->xe_value_size = cpu_to_le64(xi->value_len); | ||
1463 | /* Clear value bytes. */ | ||
1464 | memset(val + OCFS2_XATTR_SIZE(name_len), | ||
1465 | 0, | ||
1466 | OCFS2_XATTR_SIZE(xi->value_len)); | ||
1467 | memcpy(val + OCFS2_XATTR_SIZE(name_len), | ||
1468 | xi->value, | ||
1469 | xi->value_len); | ||
1470 | return; | ||
1471 | } | ||
1472 | /* Remove the old name+value. */ | ||
1473 | memmove(first_val + size, first_val, val - first_val); | ||
1474 | memset(first_val, 0, size); | ||
1475 | xs->here->xe_name_hash = 0; | ||
1476 | xs->here->xe_name_offset = 0; | ||
1477 | ocfs2_xattr_set_local(xs->here, 1); | ||
1478 | xs->here->xe_value_size = 0; | ||
1479 | |||
1480 | min_offs += size; | ||
1481 | |||
1482 | /* Adjust all value offsets. */ | ||
1483 | last = xs->header->xh_entries; | ||
1484 | for (i = 0 ; i < le16_to_cpu(xs->header->xh_count); i++) { | ||
1485 | size_t o = le16_to_cpu(last->xe_name_offset); | ||
1486 | |||
1487 | if (o < offs) | ||
1488 | last->xe_name_offset = cpu_to_le16(o + size); | ||
1489 | last += 1; | ||
1490 | } | ||
1491 | 1762 | ||
1492 | if (!xi->value) { | 1763 | if (free_start < size) { |
1493 | /* Remove the old entry. */ | 1764 | if (needed_space) |
1494 | last -= 1; | 1765 | return -ENOSPC; |
1495 | memmove(xs->here, xs->here + 1, | 1766 | } else { |
1496 | (void *)last - (void *)xs->here); | 1767 | /* |
1497 | memset(last, 0, sizeof(struct ocfs2_xattr_entry)); | 1768 | * First we check if it would fit in the first place. |
1498 | le16_add_cpu(&xs->header->xh_count, -1); | 1769 | * Below, we align the free start to a block. This may |
1499 | } | 1770 | * slide us below the minimum gap. By checking unaligned |
1771 | * first, we avoid that error. | ||
1772 | */ | ||
1773 | rc = ocfs2_xa_check_space_helper(needed_space, free_start, | ||
1774 | count); | ||
1775 | if (rc) | ||
1776 | return rc; | ||
1777 | free_start = ocfs2_bucket_align_free_start(sb, free_start, | ||
1778 | size); | ||
1500 | } | 1779 | } |
1501 | if (xi->value) { | 1780 | return ocfs2_xa_check_space_helper(needed_space, free_start, count); |
1502 | /* Insert the new name+value. */ | 1781 | } |
1503 | size_t size = OCFS2_XATTR_SIZE(name_len) + | 1782 | |
1504 | OCFS2_XATTR_SIZE(xi->value_len); | 1783 | static void ocfs2_xa_bucket_wipe_namevalue(struct ocfs2_xa_loc *loc) |
1505 | void *val = xs->base + min_offs - size; | 1784 | { |
1785 | le16_add_cpu(&loc->xl_header->xh_name_value_len, | ||
1786 | -namevalue_size_xe(loc->xl_entry)); | ||
1787 | } | ||
1506 | 1788 | ||
1507 | xs->here->xe_name_offset = cpu_to_le16(min_offs - size); | 1789 | static void ocfs2_xa_bucket_add_entry(struct ocfs2_xa_loc *loc, u32 name_hash) |
1508 | memset(val, 0, size); | 1790 | { |
1509 | memcpy(val, xi->name, name_len); | 1791 | struct ocfs2_xattr_header *xh = loc->xl_header; |
1510 | memcpy(val + OCFS2_XATTR_SIZE(name_len), | 1792 | int count = le16_to_cpu(xh->xh_count); |
1511 | xi->value, | 1793 | int low = 0, high = count - 1, tmp; |
1512 | xi->value_len); | 1794 | struct ocfs2_xattr_entry *tmp_xe; |
1513 | xs->here->xe_value_size = cpu_to_le64(xi->value_len); | 1795 | |
1514 | ocfs2_xattr_set_local(xs->here, 1); | 1796 | /* |
1515 | ocfs2_xattr_hash_entry(inode, xs->header, xs->here); | 1797 | * We keep buckets sorted by name_hash, so we need to find |
1798 | * our insert place. | ||
1799 | */ | ||
1800 | while (low <= high && count) { | ||
1801 | tmp = (low + high) / 2; | ||
1802 | tmp_xe = &xh->xh_entries[tmp]; | ||
1803 | |||
1804 | if (name_hash > le32_to_cpu(tmp_xe->xe_name_hash)) | ||
1805 | low = tmp + 1; | ||
1806 | else if (name_hash < le32_to_cpu(tmp_xe->xe_name_hash)) | ||
1807 | high = tmp - 1; | ||
1808 | else { | ||
1809 | low = tmp; | ||
1810 | break; | ||
1811 | } | ||
1516 | } | 1812 | } |
1517 | 1813 | ||
1518 | return; | 1814 | if (low != count) |
1815 | memmove(&xh->xh_entries[low + 1], | ||
1816 | &xh->xh_entries[low], | ||
1817 | ((count - low) * sizeof(struct ocfs2_xattr_entry))); | ||
1818 | |||
1819 | le16_add_cpu(&xh->xh_count, 1); | ||
1820 | loc->xl_entry = &xh->xh_entries[low]; | ||
1821 | memset(loc->xl_entry, 0, sizeof(struct ocfs2_xattr_entry)); | ||
1822 | } | ||
1823 | |||
1824 | static void ocfs2_xa_bucket_add_namevalue(struct ocfs2_xa_loc *loc, int size) | ||
1825 | { | ||
1826 | int free_start = ocfs2_xa_get_free_start(loc); | ||
1827 | struct ocfs2_xattr_header *xh = loc->xl_header; | ||
1828 | struct super_block *sb = loc->xl_inode->i_sb; | ||
1829 | int nameval_offset; | ||
1830 | |||
1831 | free_start = ocfs2_bucket_align_free_start(sb, free_start, size); | ||
1832 | nameval_offset = free_start - size; | ||
1833 | loc->xl_entry->xe_name_offset = cpu_to_le16(nameval_offset); | ||
1834 | xh->xh_free_start = cpu_to_le16(nameval_offset); | ||
1835 | le16_add_cpu(&xh->xh_name_value_len, size); | ||
1836 | |||
1837 | } | ||
1838 | |||
1839 | static void ocfs2_xa_bucket_fill_value_buf(struct ocfs2_xa_loc *loc, | ||
1840 | struct ocfs2_xattr_value_buf *vb) | ||
1841 | { | ||
1842 | struct ocfs2_xattr_bucket *bucket = loc->xl_storage; | ||
1843 | struct super_block *sb = loc->xl_inode->i_sb; | ||
1844 | int nameval_offset = le16_to_cpu(loc->xl_entry->xe_name_offset); | ||
1845 | int size = namevalue_size_xe(loc->xl_entry); | ||
1846 | int block_offset = nameval_offset >> sb->s_blocksize_bits; | ||
1847 | |||
1848 | /* Values are not allowed to straddle block boundaries */ | ||
1849 | BUG_ON(block_offset != | ||
1850 | ((nameval_offset + size - 1) >> sb->s_blocksize_bits)); | ||
1851 | /* We expect the bucket to be filled in */ | ||
1852 | BUG_ON(!bucket->bu_bhs[block_offset]); | ||
1853 | |||
1854 | vb->vb_access = ocfs2_journal_access; | ||
1855 | vb->vb_bh = bucket->bu_bhs[block_offset]; | ||
1856 | } | ||
1857 | |||
1858 | /* Operations for xattrs stored in buckets. */ | ||
1859 | static const struct ocfs2_xa_loc_operations ocfs2_xa_bucket_loc_ops = { | ||
1860 | .xlo_journal_access = ocfs2_xa_bucket_journal_access, | ||
1861 | .xlo_journal_dirty = ocfs2_xa_bucket_journal_dirty, | ||
1862 | .xlo_offset_pointer = ocfs2_xa_bucket_offset_pointer, | ||
1863 | .xlo_check_space = ocfs2_xa_bucket_check_space, | ||
1864 | .xlo_can_reuse = ocfs2_xa_bucket_can_reuse, | ||
1865 | .xlo_get_free_start = ocfs2_xa_bucket_get_free_start, | ||
1866 | .xlo_wipe_namevalue = ocfs2_xa_bucket_wipe_namevalue, | ||
1867 | .xlo_add_entry = ocfs2_xa_bucket_add_entry, | ||
1868 | .xlo_add_namevalue = ocfs2_xa_bucket_add_namevalue, | ||
1869 | .xlo_fill_value_buf = ocfs2_xa_bucket_fill_value_buf, | ||
1870 | }; | ||
1871 | |||
1872 | static unsigned int ocfs2_xa_value_clusters(struct ocfs2_xa_loc *loc) | ||
1873 | { | ||
1874 | struct ocfs2_xattr_value_buf vb; | ||
1875 | |||
1876 | if (ocfs2_xattr_is_local(loc->xl_entry)) | ||
1877 | return 0; | ||
1878 | |||
1879 | ocfs2_xa_fill_value_buf(loc, &vb); | ||
1880 | return le32_to_cpu(vb.vb_xv->xr_clusters); | ||
1881 | } | ||
1882 | |||
1883 | static int ocfs2_xa_value_truncate(struct ocfs2_xa_loc *loc, u64 bytes, | ||
1884 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
1885 | { | ||
1886 | int trunc_rc, access_rc; | ||
1887 | struct ocfs2_xattr_value_buf vb; | ||
1888 | |||
1889 | ocfs2_xa_fill_value_buf(loc, &vb); | ||
1890 | trunc_rc = ocfs2_xattr_value_truncate(loc->xl_inode, &vb, bytes, | ||
1891 | ctxt); | ||
1892 | |||
1893 | /* | ||
1894 | * The caller of ocfs2_xa_value_truncate() has already called | ||
1895 | * ocfs2_xa_journal_access on the loc. However, The truncate code | ||
1896 | * calls ocfs2_extend_trans(). This may commit the previous | ||
1897 | * transaction and open a new one. If this is a bucket, truncate | ||
1898 | * could leave only vb->vb_bh set up for journaling. Meanwhile, | ||
1899 | * the caller is expecting to dirty the entire bucket. So we must | ||
1900 | * reset the journal work. We do this even if truncate has failed, | ||
1901 | * as it could have failed after committing the extend. | ||
1902 | */ | ||
1903 | access_rc = ocfs2_xa_journal_access(ctxt->handle, loc, | ||
1904 | OCFS2_JOURNAL_ACCESS_WRITE); | ||
1905 | |||
1906 | /* Errors in truncate take precedence */ | ||
1907 | return trunc_rc ? trunc_rc : access_rc; | ||
1908 | } | ||
1909 | |||
1910 | static void ocfs2_xa_remove_entry(struct ocfs2_xa_loc *loc) | ||
1911 | { | ||
1912 | int index, count; | ||
1913 | struct ocfs2_xattr_header *xh = loc->xl_header; | ||
1914 | struct ocfs2_xattr_entry *entry = loc->xl_entry; | ||
1915 | |||
1916 | ocfs2_xa_wipe_namevalue(loc); | ||
1917 | loc->xl_entry = NULL; | ||
1918 | |||
1919 | le16_add_cpu(&xh->xh_count, -1); | ||
1920 | count = le16_to_cpu(xh->xh_count); | ||
1921 | |||
1922 | /* | ||
1923 | * Only zero out the entry if there are more remaining. This is | ||
1924 | * important for an empty bucket, as it keeps track of the | ||
1925 | * bucket's hash value. It doesn't hurt empty block storage. | ||
1926 | */ | ||
1927 | if (count) { | ||
1928 | index = ((char *)entry - (char *)&xh->xh_entries) / | ||
1929 | sizeof(struct ocfs2_xattr_entry); | ||
1930 | memmove(&xh->xh_entries[index], &xh->xh_entries[index + 1], | ||
1931 | (count - index) * sizeof(struct ocfs2_xattr_entry)); | ||
1932 | memset(&xh->xh_entries[count], 0, | ||
1933 | sizeof(struct ocfs2_xattr_entry)); | ||
1934 | } | ||
1519 | } | 1935 | } |
1520 | 1936 | ||
1521 | /* | 1937 | /* |
1522 | * ocfs2_xattr_set_entry() | 1938 | * If we have a problem adjusting the size of an external value during |
1939 | * ocfs2_xa_prepare_entry() or ocfs2_xa_remove(), we may have an xattr | ||
1940 | * in an intermediate state. For example, the value may be partially | ||
1941 | * truncated. | ||
1942 | * | ||
1943 | * If the value tree hasn't changed, the extend/truncate went nowhere. | ||
1944 | * We have nothing to do. The caller can treat it as a straight error. | ||
1523 | * | 1945 | * |
1524 | * Set extended attribute entry into inode or block. | 1946 | * If the value tree got partially truncated, we now have a corrupted |
1947 | * extended attribute. We're going to wipe its entry and leak the | ||
1948 | * clusters. Better to leak some storage than leave a corrupt entry. | ||
1525 | * | 1949 | * |
1526 | * If extended attribute value size > OCFS2_XATTR_INLINE_SIZE, | 1950 | * If the value tree grew, it obviously didn't grow enough for the |
1527 | * We first insert tree root(ocfs2_xattr_value_root) with set_entry_local(), | 1951 | * new entry. We're not going to try and reclaim those clusters either. |
1528 | * then set value in B tree with set_value_outside(). | 1952 | * If there was already an external value there (orig_clusters != 0), |
1953 | * the new clusters are attached safely and we can just leave the old | ||
1954 | * value in place. If there was no external value there, we remove | ||
1955 | * the entry. | ||
1956 | * | ||
1957 | * This way, the xattr block we store in the journal will be consistent. | ||
1958 | * If the size change broke because of the journal, no changes will hit | ||
1959 | * disk anyway. | ||
1529 | */ | 1960 | */ |
1530 | static int ocfs2_xattr_set_entry(struct inode *inode, | 1961 | static void ocfs2_xa_cleanup_value_truncate(struct ocfs2_xa_loc *loc, |
1531 | struct ocfs2_xattr_info *xi, | 1962 | const char *what, |
1532 | struct ocfs2_xattr_search *xs, | 1963 | unsigned int orig_clusters) |
1533 | struct ocfs2_xattr_set_ctxt *ctxt, | 1964 | { |
1534 | int flag) | 1965 | unsigned int new_clusters = ocfs2_xa_value_clusters(loc); |
1535 | { | 1966 | char *nameval_buf = ocfs2_xa_offset_pointer(loc, |
1536 | struct ocfs2_xattr_entry *last; | 1967 | le16_to_cpu(loc->xl_entry->xe_name_offset)); |
1537 | struct ocfs2_inode_info *oi = OCFS2_I(inode); | 1968 | |
1538 | struct ocfs2_dinode *di = (struct ocfs2_dinode *)xs->inode_bh->b_data; | 1969 | if (new_clusters < orig_clusters) { |
1539 | size_t min_offs = xs->end - xs->base, name_len = strlen(xi->name); | 1970 | mlog(ML_ERROR, |
1540 | size_t size_l = 0; | 1971 | "Partial truncate while %s xattr %.*s. Leaking " |
1541 | handle_t *handle = ctxt->handle; | 1972 | "%u clusters and removing the entry\n", |
1542 | int free, i, ret; | 1973 | what, loc->xl_entry->xe_name_len, nameval_buf, |
1543 | struct ocfs2_xattr_info xi_l = { | 1974 | orig_clusters - new_clusters); |
1544 | .name_index = xi->name_index, | 1975 | ocfs2_xa_remove_entry(loc); |
1545 | .name = xi->name, | 1976 | } else if (!orig_clusters) { |
1546 | .value = xi->value, | 1977 | mlog(ML_ERROR, |
1547 | .value_len = xi->value_len, | 1978 | "Unable to allocate an external value for xattr " |
1548 | }; | 1979 | "%.*s safely. Leaking %u clusters and removing the " |
1549 | struct ocfs2_xattr_value_buf vb = { | 1980 | "entry\n", |
1550 | .vb_bh = xs->xattr_bh, | 1981 | loc->xl_entry->xe_name_len, nameval_buf, |
1551 | .vb_access = ocfs2_journal_access_di, | 1982 | new_clusters - orig_clusters); |
1552 | }; | 1983 | ocfs2_xa_remove_entry(loc); |
1984 | } else if (new_clusters > orig_clusters) | ||
1985 | mlog(ML_ERROR, | ||
1986 | "Unable to grow xattr %.*s safely. %u new clusters " | ||
1987 | "have been added, but the value will not be " | ||
1988 | "modified\n", | ||
1989 | loc->xl_entry->xe_name_len, nameval_buf, | ||
1990 | new_clusters - orig_clusters); | ||
1991 | } | ||
1992 | |||
1993 | static int ocfs2_xa_remove(struct ocfs2_xa_loc *loc, | ||
1994 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
1995 | { | ||
1996 | int rc = 0; | ||
1997 | unsigned int orig_clusters; | ||
1998 | |||
1999 | if (!ocfs2_xattr_is_local(loc->xl_entry)) { | ||
2000 | orig_clusters = ocfs2_xa_value_clusters(loc); | ||
2001 | rc = ocfs2_xa_value_truncate(loc, 0, ctxt); | ||
2002 | if (rc) { | ||
2003 | mlog_errno(rc); | ||
2004 | /* | ||
2005 | * Since this is remove, we can return 0 if | ||
2006 | * ocfs2_xa_cleanup_value_truncate() is going to | ||
2007 | * wipe the entry anyway. So we check the | ||
2008 | * cluster count as well. | ||
2009 | */ | ||
2010 | if (orig_clusters != ocfs2_xa_value_clusters(loc)) | ||
2011 | rc = 0; | ||
2012 | ocfs2_xa_cleanup_value_truncate(loc, "removing", | ||
2013 | orig_clusters); | ||
2014 | if (rc) | ||
2015 | goto out; | ||
2016 | } | ||
2017 | } | ||
1553 | 2018 | ||
1554 | if (!(flag & OCFS2_INLINE_XATTR_FL)) { | 2019 | ocfs2_xa_remove_entry(loc); |
1555 | BUG_ON(xs->xattr_bh == xs->inode_bh); | ||
1556 | vb.vb_access = ocfs2_journal_access_xb; | ||
1557 | } else | ||
1558 | BUG_ON(xs->xattr_bh != xs->inode_bh); | ||
1559 | 2020 | ||
1560 | /* Compute min_offs, last and free space. */ | 2021 | out: |
1561 | last = xs->header->xh_entries; | 2022 | return rc; |
2023 | } | ||
1562 | 2024 | ||
1563 | for (i = 0 ; i < le16_to_cpu(xs->header->xh_count); i++) { | 2025 | static void ocfs2_xa_install_value_root(struct ocfs2_xa_loc *loc) |
1564 | size_t offs = le16_to_cpu(last->xe_name_offset); | 2026 | { |
1565 | if (offs < min_offs) | 2027 | int name_size = OCFS2_XATTR_SIZE(loc->xl_entry->xe_name_len); |
1566 | min_offs = offs; | 2028 | char *nameval_buf; |
1567 | last += 1; | ||
1568 | } | ||
1569 | 2029 | ||
1570 | free = min_offs - ((void *)last - xs->base) - OCFS2_XATTR_HEADER_GAP; | 2030 | nameval_buf = ocfs2_xa_offset_pointer(loc, |
1571 | if (free < 0) | 2031 | le16_to_cpu(loc->xl_entry->xe_name_offset)); |
1572 | return -EIO; | 2032 | memcpy(nameval_buf + name_size, &def_xv, OCFS2_XATTR_ROOT_SIZE); |
2033 | } | ||
1573 | 2034 | ||
1574 | if (!xs->not_found) { | 2035 | /* |
1575 | size_t size = 0; | 2036 | * Take an existing entry and make it ready for the new value. This |
1576 | if (ocfs2_xattr_is_local(xs->here)) | 2037 | * won't allocate space, but it may free space. It should be ready for |
1577 | size = OCFS2_XATTR_SIZE(name_len) + | 2038 | * ocfs2_xa_prepare_entry() to finish the work. |
1578 | OCFS2_XATTR_SIZE(le64_to_cpu(xs->here->xe_value_size)); | 2039 | */ |
1579 | else | 2040 | static int ocfs2_xa_reuse_entry(struct ocfs2_xa_loc *loc, |
1580 | size = OCFS2_XATTR_SIZE(name_len) + | 2041 | struct ocfs2_xattr_info *xi, |
1581 | OCFS2_XATTR_ROOT_SIZE; | 2042 | struct ocfs2_xattr_set_ctxt *ctxt) |
1582 | free += (size + sizeof(struct ocfs2_xattr_entry)); | 2043 | { |
1583 | } | 2044 | int rc = 0; |
1584 | /* Check free space in inode or block */ | 2045 | int name_size = OCFS2_XATTR_SIZE(xi->xi_name_len); |
1585 | if (xi->value && xi->value_len > OCFS2_XATTR_INLINE_SIZE) { | 2046 | unsigned int orig_clusters; |
1586 | if (free < sizeof(struct ocfs2_xattr_entry) + | 2047 | char *nameval_buf; |
1587 | OCFS2_XATTR_SIZE(name_len) + | 2048 | int xe_local = ocfs2_xattr_is_local(loc->xl_entry); |
1588 | OCFS2_XATTR_ROOT_SIZE) { | 2049 | int xi_local = xi->xi_value_len <= OCFS2_XATTR_INLINE_SIZE; |
1589 | ret = -ENOSPC; | 2050 | |
1590 | goto out; | 2051 | BUG_ON(OCFS2_XATTR_SIZE(loc->xl_entry->xe_name_len) != |
2052 | name_size); | ||
2053 | |||
2054 | nameval_buf = ocfs2_xa_offset_pointer(loc, | ||
2055 | le16_to_cpu(loc->xl_entry->xe_name_offset)); | ||
2056 | if (xe_local) { | ||
2057 | memset(nameval_buf + name_size, 0, | ||
2058 | namevalue_size_xe(loc->xl_entry) - name_size); | ||
2059 | if (!xi_local) | ||
2060 | ocfs2_xa_install_value_root(loc); | ||
2061 | } else { | ||
2062 | orig_clusters = ocfs2_xa_value_clusters(loc); | ||
2063 | if (xi_local) { | ||
2064 | rc = ocfs2_xa_value_truncate(loc, 0, ctxt); | ||
2065 | if (rc < 0) | ||
2066 | mlog_errno(rc); | ||
2067 | else | ||
2068 | memset(nameval_buf + name_size, 0, | ||
2069 | namevalue_size_xe(loc->xl_entry) - | ||
2070 | name_size); | ||
2071 | } else if (le64_to_cpu(loc->xl_entry->xe_value_size) > | ||
2072 | xi->xi_value_len) { | ||
2073 | rc = ocfs2_xa_value_truncate(loc, xi->xi_value_len, | ||
2074 | ctxt); | ||
2075 | if (rc < 0) | ||
2076 | mlog_errno(rc); | ||
1591 | } | 2077 | } |
1592 | size_l = OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_ROOT_SIZE; | 2078 | |
1593 | xi_l.value = (void *)&def_xv; | 2079 | if (rc) { |
1594 | xi_l.value_len = OCFS2_XATTR_ROOT_SIZE; | 2080 | ocfs2_xa_cleanup_value_truncate(loc, "reusing", |
1595 | } else if (xi->value) { | 2081 | orig_clusters); |
1596 | if (free < sizeof(struct ocfs2_xattr_entry) + | ||
1597 | OCFS2_XATTR_SIZE(name_len) + | ||
1598 | OCFS2_XATTR_SIZE(xi->value_len)) { | ||
1599 | ret = -ENOSPC; | ||
1600 | goto out; | 2082 | goto out; |
1601 | } | 2083 | } |
1602 | } | 2084 | } |
1603 | 2085 | ||
1604 | if (!xs->not_found) { | 2086 | loc->xl_entry->xe_value_size = cpu_to_le64(xi->xi_value_len); |
1605 | /* For existing extended attribute */ | 2087 | ocfs2_xattr_set_local(loc->xl_entry, xi_local); |
1606 | size_t size = OCFS2_XATTR_SIZE(name_len) + | ||
1607 | OCFS2_XATTR_SIZE(le64_to_cpu(xs->here->xe_value_size)); | ||
1608 | size_t offs = le16_to_cpu(xs->here->xe_name_offset); | ||
1609 | void *val = xs->base + offs; | ||
1610 | 2088 | ||
1611 | if (ocfs2_xattr_is_local(xs->here) && size == size_l) { | 2089 | out: |
1612 | /* Replace existing local xattr with tree root */ | 2090 | return rc; |
1613 | ret = ocfs2_xattr_set_value_outside(inode, xi, xs, | 2091 | } |
1614 | ctxt, &vb, offs); | ||
1615 | if (ret < 0) | ||
1616 | mlog_errno(ret); | ||
1617 | goto out; | ||
1618 | } else if (!ocfs2_xattr_is_local(xs->here)) { | ||
1619 | /* For existing xattr which has value outside */ | ||
1620 | vb.vb_xv = (struct ocfs2_xattr_value_root *) | ||
1621 | (val + OCFS2_XATTR_SIZE(name_len)); | ||
1622 | 2092 | ||
1623 | if (xi->value_len > OCFS2_XATTR_INLINE_SIZE) { | 2093 | /* |
1624 | /* | 2094 | * Prepares loc->xl_entry to receive the new xattr. This includes |
1625 | * If new value need set outside also, | 2095 | * properly setting up the name+value pair region. If loc->xl_entry |
1626 | * first truncate old value to new value, | 2096 | * already exists, it will take care of modifying it appropriately. |
1627 | * then set new value with set_value_outside(). | 2097 | * |
1628 | */ | 2098 | * Note that this modifies the data. You did journal_access already, |
1629 | ret = ocfs2_xattr_value_truncate(inode, | 2099 | * right? |
1630 | &vb, | 2100 | */ |
1631 | xi->value_len, | 2101 | static int ocfs2_xa_prepare_entry(struct ocfs2_xa_loc *loc, |
1632 | ctxt); | 2102 | struct ocfs2_xattr_info *xi, |
1633 | if (ret < 0) { | 2103 | u32 name_hash, |
1634 | mlog_errno(ret); | 2104 | struct ocfs2_xattr_set_ctxt *ctxt) |
1635 | goto out; | 2105 | { |
1636 | } | 2106 | int rc = 0; |
2107 | unsigned int orig_clusters; | ||
2108 | __le64 orig_value_size = 0; | ||
1637 | 2109 | ||
1638 | ret = ocfs2_xattr_update_entry(inode, | 2110 | rc = ocfs2_xa_check_space(loc, xi); |
1639 | handle, | 2111 | if (rc) |
1640 | xi, | 2112 | goto out; |
1641 | xs, | ||
1642 | &vb, | ||
1643 | offs); | ||
1644 | if (ret < 0) { | ||
1645 | mlog_errno(ret); | ||
1646 | goto out; | ||
1647 | } | ||
1648 | 2113 | ||
1649 | ret = __ocfs2_xattr_set_value_outside(inode, | 2114 | if (loc->xl_entry) { |
1650 | handle, | 2115 | if (ocfs2_xa_can_reuse_entry(loc, xi)) { |
1651 | &vb, | 2116 | orig_value_size = loc->xl_entry->xe_value_size; |
1652 | xi->value, | 2117 | rc = ocfs2_xa_reuse_entry(loc, xi, ctxt); |
1653 | xi->value_len); | 2118 | if (rc) |
1654 | if (ret < 0) | 2119 | goto out; |
1655 | mlog_errno(ret); | 2120 | goto alloc_value; |
2121 | } | ||
2122 | |||
2123 | if (!ocfs2_xattr_is_local(loc->xl_entry)) { | ||
2124 | orig_clusters = ocfs2_xa_value_clusters(loc); | ||
2125 | rc = ocfs2_xa_value_truncate(loc, 0, ctxt); | ||
2126 | if (rc) { | ||
2127 | mlog_errno(rc); | ||
2128 | ocfs2_xa_cleanup_value_truncate(loc, | ||
2129 | "overwriting", | ||
2130 | orig_clusters); | ||
1656 | goto out; | 2131 | goto out; |
1657 | } else { | ||
1658 | /* | ||
1659 | * If new value need set in local, | ||
1660 | * just trucate old value to zero. | ||
1661 | */ | ||
1662 | ret = ocfs2_xattr_value_truncate(inode, | ||
1663 | &vb, | ||
1664 | 0, | ||
1665 | ctxt); | ||
1666 | if (ret < 0) | ||
1667 | mlog_errno(ret); | ||
1668 | } | 2132 | } |
1669 | } | 2133 | } |
2134 | ocfs2_xa_wipe_namevalue(loc); | ||
2135 | } else | ||
2136 | ocfs2_xa_add_entry(loc, name_hash); | ||
2137 | |||
2138 | /* | ||
2139 | * If we get here, we have a blank entry. Fill it. We grow our | ||
2140 | * name+value pair back from the end. | ||
2141 | */ | ||
2142 | ocfs2_xa_add_namevalue(loc, xi); | ||
2143 | if (xi->xi_value_len > OCFS2_XATTR_INLINE_SIZE) | ||
2144 | ocfs2_xa_install_value_root(loc); | ||
2145 | |||
2146 | alloc_value: | ||
2147 | if (xi->xi_value_len > OCFS2_XATTR_INLINE_SIZE) { | ||
2148 | orig_clusters = ocfs2_xa_value_clusters(loc); | ||
2149 | rc = ocfs2_xa_value_truncate(loc, xi->xi_value_len, ctxt); | ||
2150 | if (rc < 0) { | ||
2151 | /* | ||
2152 | * If we tried to grow an existing external value, | ||
2153 | * ocfs2_xa_cleanuP-value_truncate() is going to | ||
2154 | * let it stand. We have to restore its original | ||
2155 | * value size. | ||
2156 | */ | ||
2157 | loc->xl_entry->xe_value_size = orig_value_size; | ||
2158 | ocfs2_xa_cleanup_value_truncate(loc, "growing", | ||
2159 | orig_clusters); | ||
2160 | mlog_errno(rc); | ||
2161 | } | ||
1670 | } | 2162 | } |
1671 | 2163 | ||
1672 | ret = ocfs2_journal_access_di(handle, INODE_CACHE(inode), xs->inode_bh, | 2164 | out: |
2165 | return rc; | ||
2166 | } | ||
2167 | |||
2168 | /* | ||
2169 | * Store the value portion of the name+value pair. This will skip | ||
2170 | * values that are stored externally. Their tree roots were set up | ||
2171 | * by ocfs2_xa_prepare_entry(). | ||
2172 | */ | ||
2173 | static int ocfs2_xa_store_value(struct ocfs2_xa_loc *loc, | ||
2174 | struct ocfs2_xattr_info *xi, | ||
2175 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
2176 | { | ||
2177 | int rc = 0; | ||
2178 | int nameval_offset = le16_to_cpu(loc->xl_entry->xe_name_offset); | ||
2179 | int name_size = OCFS2_XATTR_SIZE(xi->xi_name_len); | ||
2180 | char *nameval_buf; | ||
2181 | struct ocfs2_xattr_value_buf vb; | ||
2182 | |||
2183 | nameval_buf = ocfs2_xa_offset_pointer(loc, nameval_offset); | ||
2184 | if (xi->xi_value_len > OCFS2_XATTR_INLINE_SIZE) { | ||
2185 | ocfs2_xa_fill_value_buf(loc, &vb); | ||
2186 | rc = __ocfs2_xattr_set_value_outside(loc->xl_inode, | ||
2187 | ctxt->handle, &vb, | ||
2188 | xi->xi_value, | ||
2189 | xi->xi_value_len); | ||
2190 | } else | ||
2191 | memcpy(nameval_buf + name_size, xi->xi_value, xi->xi_value_len); | ||
2192 | |||
2193 | return rc; | ||
2194 | } | ||
2195 | |||
2196 | static int ocfs2_xa_set(struct ocfs2_xa_loc *loc, | ||
2197 | struct ocfs2_xattr_info *xi, | ||
2198 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
2199 | { | ||
2200 | int ret; | ||
2201 | u32 name_hash = ocfs2_xattr_name_hash(loc->xl_inode, xi->xi_name, | ||
2202 | xi->xi_name_len); | ||
2203 | |||
2204 | ret = ocfs2_xa_journal_access(ctxt->handle, loc, | ||
1673 | OCFS2_JOURNAL_ACCESS_WRITE); | 2205 | OCFS2_JOURNAL_ACCESS_WRITE); |
1674 | if (ret) { | 2206 | if (ret) { |
1675 | mlog_errno(ret); | 2207 | mlog_errno(ret); |
1676 | goto out; | 2208 | goto out; |
1677 | } | 2209 | } |
1678 | 2210 | ||
1679 | if (!(flag & OCFS2_INLINE_XATTR_FL)) { | ||
1680 | ret = vb.vb_access(handle, INODE_CACHE(inode), vb.vb_bh, | ||
1681 | OCFS2_JOURNAL_ACCESS_WRITE); | ||
1682 | if (ret) { | ||
1683 | mlog_errno(ret); | ||
1684 | goto out; | ||
1685 | } | ||
1686 | } | ||
1687 | |||
1688 | /* | 2211 | /* |
1689 | * Set value in local, include set tree root in local. | 2212 | * From here on out, everything is going to modify the buffer a |
1690 | * This is the first step for value size >INLINE_SIZE. | 2213 | * little. Errors are going to leave the xattr header in a |
2214 | * sane state. Thus, even with errors we dirty the sucker. | ||
1691 | */ | 2215 | */ |
1692 | ocfs2_xattr_set_entry_local(inode, &xi_l, xs, last, min_offs); | ||
1693 | 2216 | ||
1694 | if (!(flag & OCFS2_INLINE_XATTR_FL)) { | 2217 | /* Don't worry, we are never called with !xi_value and !xl_entry */ |
1695 | ret = ocfs2_journal_dirty(handle, xs->xattr_bh); | 2218 | if (!xi->xi_value) { |
1696 | if (ret < 0) { | 2219 | ret = ocfs2_xa_remove(loc, ctxt); |
1697 | mlog_errno(ret); | 2220 | goto out_dirty; |
1698 | goto out; | ||
1699 | } | ||
1700 | } | 2221 | } |
1701 | 2222 | ||
1702 | if (!(oi->ip_dyn_features & OCFS2_INLINE_XATTR_FL) && | 2223 | ret = ocfs2_xa_prepare_entry(loc, xi, name_hash, ctxt); |
1703 | (flag & OCFS2_INLINE_XATTR_FL)) { | 2224 | if (ret) { |
1704 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); | 2225 | if (ret != -ENOSPC) |
1705 | unsigned int xattrsize = osb->s_xattr_inline_size; | 2226 | mlog_errno(ret); |
1706 | 2227 | goto out_dirty; | |
1707 | /* | ||
1708 | * Adjust extent record count or inline data size | ||
1709 | * to reserve space for extended attribute. | ||
1710 | */ | ||
1711 | if (oi->ip_dyn_features & OCFS2_INLINE_DATA_FL) { | ||
1712 | struct ocfs2_inline_data *idata = &di->id2.i_data; | ||
1713 | le16_add_cpu(&idata->id_count, -xattrsize); | ||
1714 | } else if (!(ocfs2_inode_is_fast_symlink(inode))) { | ||
1715 | struct ocfs2_extent_list *el = &di->id2.i_list; | ||
1716 | le16_add_cpu(&el->l_count, -(xattrsize / | ||
1717 | sizeof(struct ocfs2_extent_rec))); | ||
1718 | } | ||
1719 | di->i_xattr_inline_size = cpu_to_le16(xattrsize); | ||
1720 | } | 2228 | } |
1721 | /* Update xattr flag */ | ||
1722 | spin_lock(&oi->ip_lock); | ||
1723 | oi->ip_dyn_features |= flag; | ||
1724 | di->i_dyn_features = cpu_to_le16(oi->ip_dyn_features); | ||
1725 | spin_unlock(&oi->ip_lock); | ||
1726 | 2229 | ||
1727 | ret = ocfs2_journal_dirty(handle, xs->inode_bh); | 2230 | ret = ocfs2_xa_store_value(loc, xi, ctxt); |
1728 | if (ret < 0) | 2231 | if (ret) |
1729 | mlog_errno(ret); | 2232 | mlog_errno(ret); |
1730 | 2233 | ||
1731 | if (!ret && xi->value_len > OCFS2_XATTR_INLINE_SIZE) { | 2234 | out_dirty: |
1732 | /* | 2235 | ocfs2_xa_journal_dirty(ctxt->handle, loc); |
1733 | * Set value outside in B tree. | ||
1734 | * This is the second step for value size > INLINE_SIZE. | ||
1735 | */ | ||
1736 | size_t offs = le16_to_cpu(xs->here->xe_name_offset); | ||
1737 | ret = ocfs2_xattr_set_value_outside(inode, xi, xs, ctxt, | ||
1738 | &vb, offs); | ||
1739 | if (ret < 0) { | ||
1740 | int ret2; | ||
1741 | 2236 | ||
1742 | mlog_errno(ret); | ||
1743 | /* | ||
1744 | * If set value outside failed, we have to clean | ||
1745 | * the junk tree root we have already set in local. | ||
1746 | */ | ||
1747 | ret2 = ocfs2_xattr_cleanup(inode, ctxt->handle, | ||
1748 | xi, xs, &vb, offs); | ||
1749 | if (ret2 < 0) | ||
1750 | mlog_errno(ret2); | ||
1751 | } | ||
1752 | } | ||
1753 | out: | 2237 | out: |
1754 | return ret; | 2238 | return ret; |
1755 | } | 2239 | } |
1756 | 2240 | ||
2241 | static void ocfs2_init_dinode_xa_loc(struct ocfs2_xa_loc *loc, | ||
2242 | struct inode *inode, | ||
2243 | struct buffer_head *bh, | ||
2244 | struct ocfs2_xattr_entry *entry) | ||
2245 | { | ||
2246 | struct ocfs2_dinode *di = (struct ocfs2_dinode *)bh->b_data; | ||
2247 | |||
2248 | BUG_ON(!(OCFS2_I(inode)->ip_dyn_features & OCFS2_INLINE_XATTR_FL)); | ||
2249 | |||
2250 | loc->xl_inode = inode; | ||
2251 | loc->xl_ops = &ocfs2_xa_block_loc_ops; | ||
2252 | loc->xl_storage = bh; | ||
2253 | loc->xl_entry = entry; | ||
2254 | loc->xl_size = le16_to_cpu(di->i_xattr_inline_size); | ||
2255 | loc->xl_header = | ||
2256 | (struct ocfs2_xattr_header *)(bh->b_data + bh->b_size - | ||
2257 | loc->xl_size); | ||
2258 | } | ||
2259 | |||
2260 | static void ocfs2_init_xattr_block_xa_loc(struct ocfs2_xa_loc *loc, | ||
2261 | struct inode *inode, | ||
2262 | struct buffer_head *bh, | ||
2263 | struct ocfs2_xattr_entry *entry) | ||
2264 | { | ||
2265 | struct ocfs2_xattr_block *xb = | ||
2266 | (struct ocfs2_xattr_block *)bh->b_data; | ||
2267 | |||
2268 | BUG_ON(le16_to_cpu(xb->xb_flags) & OCFS2_XATTR_INDEXED); | ||
2269 | |||
2270 | loc->xl_inode = inode; | ||
2271 | loc->xl_ops = &ocfs2_xa_block_loc_ops; | ||
2272 | loc->xl_storage = bh; | ||
2273 | loc->xl_header = &(xb->xb_attrs.xb_header); | ||
2274 | loc->xl_entry = entry; | ||
2275 | loc->xl_size = bh->b_size - offsetof(struct ocfs2_xattr_block, | ||
2276 | xb_attrs.xb_header); | ||
2277 | } | ||
2278 | |||
2279 | static void ocfs2_init_xattr_bucket_xa_loc(struct ocfs2_xa_loc *loc, | ||
2280 | struct ocfs2_xattr_bucket *bucket, | ||
2281 | struct ocfs2_xattr_entry *entry) | ||
2282 | { | ||
2283 | loc->xl_inode = bucket->bu_inode; | ||
2284 | loc->xl_ops = &ocfs2_xa_bucket_loc_ops; | ||
2285 | loc->xl_storage = bucket; | ||
2286 | loc->xl_header = bucket_xh(bucket); | ||
2287 | loc->xl_entry = entry; | ||
2288 | loc->xl_size = OCFS2_XATTR_BUCKET_SIZE; | ||
2289 | } | ||
2290 | |||
1757 | /* | 2291 | /* |
1758 | * In xattr remove, if it is stored outside and refcounted, we may have | 2292 | * In xattr remove, if it is stored outside and refcounted, we may have |
1759 | * the chance to split the refcount tree. So need the allocators. | 2293 | * the chance to split the refcount tree. So need the allocators. |
@@ -2149,6 +2683,55 @@ static int ocfs2_xattr_ibody_find(struct inode *inode, | |||
2149 | return 0; | 2683 | return 0; |
2150 | } | 2684 | } |
2151 | 2685 | ||
2686 | static int ocfs2_xattr_ibody_init(struct inode *inode, | ||
2687 | struct buffer_head *di_bh, | ||
2688 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
2689 | { | ||
2690 | int ret; | ||
2691 | struct ocfs2_inode_info *oi = OCFS2_I(inode); | ||
2692 | struct ocfs2_dinode *di = (struct ocfs2_dinode *)di_bh->b_data; | ||
2693 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); | ||
2694 | unsigned int xattrsize = osb->s_xattr_inline_size; | ||
2695 | |||
2696 | if (!ocfs2_xattr_has_space_inline(inode, di)) { | ||
2697 | ret = -ENOSPC; | ||
2698 | goto out; | ||
2699 | } | ||
2700 | |||
2701 | ret = ocfs2_journal_access_di(ctxt->handle, INODE_CACHE(inode), di_bh, | ||
2702 | OCFS2_JOURNAL_ACCESS_WRITE); | ||
2703 | if (ret) { | ||
2704 | mlog_errno(ret); | ||
2705 | goto out; | ||
2706 | } | ||
2707 | |||
2708 | /* | ||
2709 | * Adjust extent record count or inline data size | ||
2710 | * to reserve space for extended attribute. | ||
2711 | */ | ||
2712 | if (oi->ip_dyn_features & OCFS2_INLINE_DATA_FL) { | ||
2713 | struct ocfs2_inline_data *idata = &di->id2.i_data; | ||
2714 | le16_add_cpu(&idata->id_count, -xattrsize); | ||
2715 | } else if (!(ocfs2_inode_is_fast_symlink(inode))) { | ||
2716 | struct ocfs2_extent_list *el = &di->id2.i_list; | ||
2717 | le16_add_cpu(&el->l_count, -(xattrsize / | ||
2718 | sizeof(struct ocfs2_extent_rec))); | ||
2719 | } | ||
2720 | di->i_xattr_inline_size = cpu_to_le16(xattrsize); | ||
2721 | |||
2722 | spin_lock(&oi->ip_lock); | ||
2723 | oi->ip_dyn_features |= OCFS2_INLINE_XATTR_FL|OCFS2_HAS_XATTR_FL; | ||
2724 | di->i_dyn_features = cpu_to_le16(oi->ip_dyn_features); | ||
2725 | spin_unlock(&oi->ip_lock); | ||
2726 | |||
2727 | ret = ocfs2_journal_dirty(ctxt->handle, di_bh); | ||
2728 | if (ret < 0) | ||
2729 | mlog_errno(ret); | ||
2730 | |||
2731 | out: | ||
2732 | return ret; | ||
2733 | } | ||
2734 | |||
2152 | /* | 2735 | /* |
2153 | * ocfs2_xattr_ibody_set() | 2736 | * ocfs2_xattr_ibody_set() |
2154 | * | 2737 | * |
@@ -2160,9 +2743,10 @@ static int ocfs2_xattr_ibody_set(struct inode *inode, | |||
2160 | struct ocfs2_xattr_search *xs, | 2743 | struct ocfs2_xattr_search *xs, |
2161 | struct ocfs2_xattr_set_ctxt *ctxt) | 2744 | struct ocfs2_xattr_set_ctxt *ctxt) |
2162 | { | 2745 | { |
2746 | int ret; | ||
2163 | struct ocfs2_inode_info *oi = OCFS2_I(inode); | 2747 | struct ocfs2_inode_info *oi = OCFS2_I(inode); |
2164 | struct ocfs2_dinode *di = (struct ocfs2_dinode *)xs->inode_bh->b_data; | 2748 | struct ocfs2_dinode *di = (struct ocfs2_dinode *)xs->inode_bh->b_data; |
2165 | int ret; | 2749 | struct ocfs2_xa_loc loc; |
2166 | 2750 | ||
2167 | if (inode->i_sb->s_blocksize == OCFS2_MIN_BLOCKSIZE) | 2751 | if (inode->i_sb->s_blocksize == OCFS2_MIN_BLOCKSIZE) |
2168 | return -ENOSPC; | 2752 | return -ENOSPC; |
@@ -2175,8 +2759,25 @@ static int ocfs2_xattr_ibody_set(struct inode *inode, | |||
2175 | } | 2759 | } |
2176 | } | 2760 | } |
2177 | 2761 | ||
2178 | ret = ocfs2_xattr_set_entry(inode, xi, xs, ctxt, | 2762 | if (!(oi->ip_dyn_features & OCFS2_INLINE_XATTR_FL)) { |
2179 | (OCFS2_INLINE_XATTR_FL | OCFS2_HAS_XATTR_FL)); | 2763 | ret = ocfs2_xattr_ibody_init(inode, xs->inode_bh, ctxt); |
2764 | if (ret) { | ||
2765 | if (ret != -ENOSPC) | ||
2766 | mlog_errno(ret); | ||
2767 | goto out; | ||
2768 | } | ||
2769 | } | ||
2770 | |||
2771 | ocfs2_init_dinode_xa_loc(&loc, inode, xs->inode_bh, | ||
2772 | xs->not_found ? NULL : xs->here); | ||
2773 | ret = ocfs2_xa_set(&loc, xi, ctxt); | ||
2774 | if (ret) { | ||
2775 | if (ret != -ENOSPC) | ||
2776 | mlog_errno(ret); | ||
2777 | goto out; | ||
2778 | } | ||
2779 | xs->here = loc.xl_entry; | ||
2780 | |||
2180 | out: | 2781 | out: |
2181 | up_write(&oi->ip_alloc_sem); | 2782 | up_write(&oi->ip_alloc_sem); |
2182 | 2783 | ||
@@ -2236,12 +2837,11 @@ cleanup: | |||
2236 | return ret; | 2837 | return ret; |
2237 | } | 2838 | } |
2238 | 2839 | ||
2239 | static int ocfs2_create_xattr_block(handle_t *handle, | 2840 | static int ocfs2_create_xattr_block(struct inode *inode, |
2240 | struct inode *inode, | ||
2241 | struct buffer_head *inode_bh, | 2841 | struct buffer_head *inode_bh, |
2242 | struct ocfs2_alloc_context *meta_ac, | 2842 | struct ocfs2_xattr_set_ctxt *ctxt, |
2243 | struct buffer_head **ret_bh, | 2843 | int indexed, |
2244 | int indexed) | 2844 | struct buffer_head **ret_bh) |
2245 | { | 2845 | { |
2246 | int ret; | 2846 | int ret; |
2247 | u16 suballoc_bit_start; | 2847 | u16 suballoc_bit_start; |
@@ -2252,14 +2852,14 @@ static int ocfs2_create_xattr_block(handle_t *handle, | |||
2252 | struct buffer_head *new_bh = NULL; | 2852 | struct buffer_head *new_bh = NULL; |
2253 | struct ocfs2_xattr_block *xblk; | 2853 | struct ocfs2_xattr_block *xblk; |
2254 | 2854 | ||
2255 | ret = ocfs2_journal_access_di(handle, INODE_CACHE(inode), inode_bh, | 2855 | ret = ocfs2_journal_access_di(ctxt->handle, INODE_CACHE(inode), |
2256 | OCFS2_JOURNAL_ACCESS_CREATE); | 2856 | inode_bh, OCFS2_JOURNAL_ACCESS_CREATE); |
2257 | if (ret < 0) { | 2857 | if (ret < 0) { |
2258 | mlog_errno(ret); | 2858 | mlog_errno(ret); |
2259 | goto end; | 2859 | goto end; |
2260 | } | 2860 | } |
2261 | 2861 | ||
2262 | ret = ocfs2_claim_metadata(osb, handle, meta_ac, 1, | 2862 | ret = ocfs2_claim_metadata(osb, ctxt->handle, ctxt->meta_ac, 1, |
2263 | &suballoc_bit_start, &num_got, | 2863 | &suballoc_bit_start, &num_got, |
2264 | &first_blkno); | 2864 | &first_blkno); |
2265 | if (ret < 0) { | 2865 | if (ret < 0) { |
@@ -2270,7 +2870,7 @@ static int ocfs2_create_xattr_block(handle_t *handle, | |||
2270 | new_bh = sb_getblk(inode->i_sb, first_blkno); | 2870 | new_bh = sb_getblk(inode->i_sb, first_blkno); |
2271 | ocfs2_set_new_buffer_uptodate(INODE_CACHE(inode), new_bh); | 2871 | ocfs2_set_new_buffer_uptodate(INODE_CACHE(inode), new_bh); |
2272 | 2872 | ||
2273 | ret = ocfs2_journal_access_xb(handle, INODE_CACHE(inode), | 2873 | ret = ocfs2_journal_access_xb(ctxt->handle, INODE_CACHE(inode), |
2274 | new_bh, | 2874 | new_bh, |
2275 | OCFS2_JOURNAL_ACCESS_CREATE); | 2875 | OCFS2_JOURNAL_ACCESS_CREATE); |
2276 | if (ret < 0) { | 2876 | if (ret < 0) { |
@@ -2282,11 +2882,10 @@ static int ocfs2_create_xattr_block(handle_t *handle, | |||
2282 | xblk = (struct ocfs2_xattr_block *)new_bh->b_data; | 2882 | xblk = (struct ocfs2_xattr_block *)new_bh->b_data; |
2283 | memset(xblk, 0, inode->i_sb->s_blocksize); | 2883 | memset(xblk, 0, inode->i_sb->s_blocksize); |
2284 | strcpy((void *)xblk, OCFS2_XATTR_BLOCK_SIGNATURE); | 2884 | strcpy((void *)xblk, OCFS2_XATTR_BLOCK_SIGNATURE); |
2285 | xblk->xb_suballoc_slot = cpu_to_le16(osb->slot_num); | 2885 | xblk->xb_suballoc_slot = cpu_to_le16(ctxt->meta_ac->ac_alloc_slot); |
2286 | xblk->xb_suballoc_bit = cpu_to_le16(suballoc_bit_start); | 2886 | xblk->xb_suballoc_bit = cpu_to_le16(suballoc_bit_start); |
2287 | xblk->xb_fs_generation = cpu_to_le32(osb->fs_generation); | 2887 | xblk->xb_fs_generation = cpu_to_le32(osb->fs_generation); |
2288 | xblk->xb_blkno = cpu_to_le64(first_blkno); | 2888 | xblk->xb_blkno = cpu_to_le64(first_blkno); |
2289 | |||
2290 | if (indexed) { | 2889 | if (indexed) { |
2291 | struct ocfs2_xattr_tree_root *xr = &xblk->xb_attrs.xb_root; | 2890 | struct ocfs2_xattr_tree_root *xr = &xblk->xb_attrs.xb_root; |
2292 | xr->xt_clusters = cpu_to_le32(1); | 2891 | xr->xt_clusters = cpu_to_le32(1); |
@@ -2297,14 +2896,17 @@ static int ocfs2_create_xattr_block(handle_t *handle, | |||
2297 | xr->xt_list.l_next_free_rec = cpu_to_le16(1); | 2896 | xr->xt_list.l_next_free_rec = cpu_to_le16(1); |
2298 | xblk->xb_flags = cpu_to_le16(OCFS2_XATTR_INDEXED); | 2897 | xblk->xb_flags = cpu_to_le16(OCFS2_XATTR_INDEXED); |
2299 | } | 2898 | } |
2899 | ocfs2_journal_dirty(ctxt->handle, new_bh); | ||
2300 | 2900 | ||
2301 | ret = ocfs2_journal_dirty(handle, new_bh); | 2901 | /* Add it to the inode */ |
2302 | if (ret < 0) { | ||
2303 | mlog_errno(ret); | ||
2304 | goto end; | ||
2305 | } | ||
2306 | di->i_xattr_loc = cpu_to_le64(first_blkno); | 2902 | di->i_xattr_loc = cpu_to_le64(first_blkno); |
2307 | ocfs2_journal_dirty(handle, inode_bh); | 2903 | |
2904 | spin_lock(&OCFS2_I(inode)->ip_lock); | ||
2905 | OCFS2_I(inode)->ip_dyn_features |= OCFS2_HAS_XATTR_FL; | ||
2906 | di->i_dyn_features = cpu_to_le16(OCFS2_I(inode)->ip_dyn_features); | ||
2907 | spin_unlock(&OCFS2_I(inode)->ip_lock); | ||
2908 | |||
2909 | ocfs2_journal_dirty(ctxt->handle, inode_bh); | ||
2308 | 2910 | ||
2309 | *ret_bh = new_bh; | 2911 | *ret_bh = new_bh; |
2310 | new_bh = NULL; | 2912 | new_bh = NULL; |
@@ -2326,13 +2928,13 @@ static int ocfs2_xattr_block_set(struct inode *inode, | |||
2326 | struct ocfs2_xattr_set_ctxt *ctxt) | 2928 | struct ocfs2_xattr_set_ctxt *ctxt) |
2327 | { | 2929 | { |
2328 | struct buffer_head *new_bh = NULL; | 2930 | struct buffer_head *new_bh = NULL; |
2329 | handle_t *handle = ctxt->handle; | ||
2330 | struct ocfs2_xattr_block *xblk = NULL; | 2931 | struct ocfs2_xattr_block *xblk = NULL; |
2331 | int ret; | 2932 | int ret; |
2933 | struct ocfs2_xa_loc loc; | ||
2332 | 2934 | ||
2333 | if (!xs->xattr_bh) { | 2935 | if (!xs->xattr_bh) { |
2334 | ret = ocfs2_create_xattr_block(handle, inode, xs->inode_bh, | 2936 | ret = ocfs2_create_xattr_block(inode, xs->inode_bh, ctxt, |
2335 | ctxt->meta_ac, &new_bh, 0); | 2937 | 0, &new_bh); |
2336 | if (ret) { | 2938 | if (ret) { |
2337 | mlog_errno(ret); | 2939 | mlog_errno(ret); |
2338 | goto end; | 2940 | goto end; |
@@ -2348,21 +2950,25 @@ static int ocfs2_xattr_block_set(struct inode *inode, | |||
2348 | xblk = (struct ocfs2_xattr_block *)xs->xattr_bh->b_data; | 2950 | xblk = (struct ocfs2_xattr_block *)xs->xattr_bh->b_data; |
2349 | 2951 | ||
2350 | if (!(le16_to_cpu(xblk->xb_flags) & OCFS2_XATTR_INDEXED)) { | 2952 | if (!(le16_to_cpu(xblk->xb_flags) & OCFS2_XATTR_INDEXED)) { |
2351 | /* Set extended attribute into external block */ | 2953 | ocfs2_init_xattr_block_xa_loc(&loc, inode, xs->xattr_bh, |
2352 | ret = ocfs2_xattr_set_entry(inode, xi, xs, ctxt, | 2954 | xs->not_found ? NULL : xs->here); |
2353 | OCFS2_HAS_XATTR_FL); | ||
2354 | if (!ret || ret != -ENOSPC) | ||
2355 | goto end; | ||
2356 | 2955 | ||
2357 | ret = ocfs2_xattr_create_index_block(inode, xs, ctxt); | 2956 | ret = ocfs2_xa_set(&loc, xi, ctxt); |
2358 | if (ret) | 2957 | if (!ret) |
2958 | xs->here = loc.xl_entry; | ||
2959 | else if (ret != -ENOSPC) | ||
2359 | goto end; | 2960 | goto end; |
2961 | else { | ||
2962 | ret = ocfs2_xattr_create_index_block(inode, xs, ctxt); | ||
2963 | if (ret) | ||
2964 | goto end; | ||
2965 | } | ||
2360 | } | 2966 | } |
2361 | 2967 | ||
2362 | ret = ocfs2_xattr_set_entry_index_block(inode, xi, xs, ctxt); | 2968 | if (le16_to_cpu(xblk->xb_flags) & OCFS2_XATTR_INDEXED) |
2969 | ret = ocfs2_xattr_set_entry_index_block(inode, xi, xs, ctxt); | ||
2363 | 2970 | ||
2364 | end: | 2971 | end: |
2365 | |||
2366 | return ret; | 2972 | return ret; |
2367 | } | 2973 | } |
2368 | 2974 | ||
@@ -2371,7 +2977,6 @@ static int ocfs2_xattr_can_be_in_inode(struct inode *inode, | |||
2371 | struct ocfs2_xattr_info *xi, | 2977 | struct ocfs2_xattr_info *xi, |
2372 | struct ocfs2_xattr_search *xs) | 2978 | struct ocfs2_xattr_search *xs) |
2373 | { | 2979 | { |
2374 | u64 value_size; | ||
2375 | struct ocfs2_xattr_entry *last; | 2980 | struct ocfs2_xattr_entry *last; |
2376 | int free, i; | 2981 | int free, i; |
2377 | size_t min_offs = xs->end - xs->base; | 2982 | size_t min_offs = xs->end - xs->base; |
@@ -2394,13 +2999,7 @@ static int ocfs2_xattr_can_be_in_inode(struct inode *inode, | |||
2394 | 2999 | ||
2395 | BUG_ON(!xs->not_found); | 3000 | BUG_ON(!xs->not_found); |
2396 | 3001 | ||
2397 | if (xi->value_len > OCFS2_XATTR_INLINE_SIZE) | 3002 | if (free >= (sizeof(struct ocfs2_xattr_entry) + namevalue_size_xi(xi))) |
2398 | value_size = OCFS2_XATTR_ROOT_SIZE; | ||
2399 | else | ||
2400 | value_size = OCFS2_XATTR_SIZE(xi->value_len); | ||
2401 | |||
2402 | if (free >= sizeof(struct ocfs2_xattr_entry) + | ||
2403 | OCFS2_XATTR_SIZE(strlen(xi->name)) + value_size) | ||
2404 | return 1; | 3003 | return 1; |
2405 | 3004 | ||
2406 | return 0; | 3005 | return 0; |
@@ -2424,7 +3023,7 @@ static int ocfs2_calc_xattr_set_need(struct inode *inode, | |||
2424 | char *base = NULL; | 3023 | char *base = NULL; |
2425 | int name_offset, name_len = 0; | 3024 | int name_offset, name_len = 0; |
2426 | u32 new_clusters = ocfs2_clusters_for_bytes(inode->i_sb, | 3025 | u32 new_clusters = ocfs2_clusters_for_bytes(inode->i_sb, |
2427 | xi->value_len); | 3026 | xi->xi_value_len); |
2428 | u64 value_size; | 3027 | u64 value_size; |
2429 | 3028 | ||
2430 | /* | 3029 | /* |
@@ -2432,14 +3031,14 @@ static int ocfs2_calc_xattr_set_need(struct inode *inode, | |||
2432 | * No matter whether we replace an old one or add a new one, | 3031 | * No matter whether we replace an old one or add a new one, |
2433 | * we need this for writing. | 3032 | * we need this for writing. |
2434 | */ | 3033 | */ |
2435 | if (xi->value_len > OCFS2_XATTR_INLINE_SIZE) | 3034 | if (xi->xi_value_len > OCFS2_XATTR_INLINE_SIZE) |
2436 | credits += new_clusters * | 3035 | credits += new_clusters * |
2437 | ocfs2_clusters_to_blocks(inode->i_sb, 1); | 3036 | ocfs2_clusters_to_blocks(inode->i_sb, 1); |
2438 | 3037 | ||
2439 | if (xis->not_found && xbs->not_found) { | 3038 | if (xis->not_found && xbs->not_found) { |
2440 | credits += ocfs2_blocks_per_xattr_bucket(inode->i_sb); | 3039 | credits += ocfs2_blocks_per_xattr_bucket(inode->i_sb); |
2441 | 3040 | ||
2442 | if (xi->value_len > OCFS2_XATTR_INLINE_SIZE) { | 3041 | if (xi->xi_value_len > OCFS2_XATTR_INLINE_SIZE) { |
2443 | clusters_add += new_clusters; | 3042 | clusters_add += new_clusters; |
2444 | credits += ocfs2_calc_extend_credits(inode->i_sb, | 3043 | credits += ocfs2_calc_extend_credits(inode->i_sb, |
2445 | &def_xv.xv.xr_list, | 3044 | &def_xv.xv.xr_list, |
@@ -2484,7 +3083,7 @@ static int ocfs2_calc_xattr_set_need(struct inode *inode, | |||
2484 | * The credits for removing the value tree will be extended | 3083 | * The credits for removing the value tree will be extended |
2485 | * by ocfs2_remove_extent itself. | 3084 | * by ocfs2_remove_extent itself. |
2486 | */ | 3085 | */ |
2487 | if (!xi->value) { | 3086 | if (!xi->xi_value) { |
2488 | if (!ocfs2_xattr_is_local(xe)) | 3087 | if (!ocfs2_xattr_is_local(xe)) |
2489 | credits += ocfs2_remove_extent_credits(inode->i_sb); | 3088 | credits += ocfs2_remove_extent_credits(inode->i_sb); |
2490 | 3089 | ||
@@ -2514,7 +3113,7 @@ static int ocfs2_calc_xattr_set_need(struct inode *inode, | |||
2514 | } | 3113 | } |
2515 | } | 3114 | } |
2516 | 3115 | ||
2517 | if (xi->value_len > OCFS2_XATTR_INLINE_SIZE) { | 3116 | if (xi->xi_value_len > OCFS2_XATTR_INLINE_SIZE) { |
2518 | /* the new values will be stored outside. */ | 3117 | /* the new values will be stored outside. */ |
2519 | u32 old_clusters = 0; | 3118 | u32 old_clusters = 0; |
2520 | 3119 | ||
@@ -2547,9 +3146,10 @@ static int ocfs2_calc_xattr_set_need(struct inode *inode, | |||
2547 | * value, we don't need any allocation, otherwise we have | 3146 | * value, we don't need any allocation, otherwise we have |
2548 | * to guess metadata allocation. | 3147 | * to guess metadata allocation. |
2549 | */ | 3148 | */ |
2550 | if ((ocfs2_xattr_is_local(xe) && value_size >= xi->value_len) || | 3149 | if ((ocfs2_xattr_is_local(xe) && |
3150 | (value_size >= xi->xi_value_len)) || | ||
2551 | (!ocfs2_xattr_is_local(xe) && | 3151 | (!ocfs2_xattr_is_local(xe) && |
2552 | OCFS2_XATTR_ROOT_SIZE >= xi->value_len)) | 3152 | OCFS2_XATTR_ROOT_SIZE >= xi->xi_value_len)) |
2553 | goto out; | 3153 | goto out; |
2554 | } | 3154 | } |
2555 | 3155 | ||
@@ -2639,7 +3239,7 @@ static int ocfs2_init_xattr_set_ctxt(struct inode *inode, | |||
2639 | 3239 | ||
2640 | meta_add += extra_meta; | 3240 | meta_add += extra_meta; |
2641 | mlog(0, "Set xattr %s, reserve meta blocks = %d, clusters = %d, " | 3241 | mlog(0, "Set xattr %s, reserve meta blocks = %d, clusters = %d, " |
2642 | "credits = %d\n", xi->name, meta_add, clusters_add, *credits); | 3242 | "credits = %d\n", xi->xi_name, meta_add, clusters_add, *credits); |
2643 | 3243 | ||
2644 | if (meta_add) { | 3244 | if (meta_add) { |
2645 | ret = ocfs2_reserve_new_metadata_blocks(osb, meta_add, | 3245 | ret = ocfs2_reserve_new_metadata_blocks(osb, meta_add, |
@@ -2679,7 +3279,7 @@ static int __ocfs2_xattr_set_handle(struct inode *inode, | |||
2679 | { | 3279 | { |
2680 | int ret = 0, credits, old_found; | 3280 | int ret = 0, credits, old_found; |
2681 | 3281 | ||
2682 | if (!xi->value) { | 3282 | if (!xi->xi_value) { |
2683 | /* Remove existing extended attribute */ | 3283 | /* Remove existing extended attribute */ |
2684 | if (!xis->not_found) | 3284 | if (!xis->not_found) |
2685 | ret = ocfs2_xattr_ibody_set(inode, xi, xis, ctxt); | 3285 | ret = ocfs2_xattr_ibody_set(inode, xi, xis, ctxt); |
@@ -2693,8 +3293,8 @@ static int __ocfs2_xattr_set_handle(struct inode *inode, | |||
2693 | * If succeed and that extended attribute existing in | 3293 | * If succeed and that extended attribute existing in |
2694 | * external block, then we will remove it. | 3294 | * external block, then we will remove it. |
2695 | */ | 3295 | */ |
2696 | xi->value = NULL; | 3296 | xi->xi_value = NULL; |
2697 | xi->value_len = 0; | 3297 | xi->xi_value_len = 0; |
2698 | 3298 | ||
2699 | old_found = xis->not_found; | 3299 | old_found = xis->not_found; |
2700 | xis->not_found = -ENODATA; | 3300 | xis->not_found = -ENODATA; |
@@ -2722,8 +3322,8 @@ static int __ocfs2_xattr_set_handle(struct inode *inode, | |||
2722 | } else if (ret == -ENOSPC) { | 3322 | } else if (ret == -ENOSPC) { |
2723 | if (di->i_xattr_loc && !xbs->xattr_bh) { | 3323 | if (di->i_xattr_loc && !xbs->xattr_bh) { |
2724 | ret = ocfs2_xattr_block_find(inode, | 3324 | ret = ocfs2_xattr_block_find(inode, |
2725 | xi->name_index, | 3325 | xi->xi_name_index, |
2726 | xi->name, xbs); | 3326 | xi->xi_name, xbs); |
2727 | if (ret) | 3327 | if (ret) |
2728 | goto out; | 3328 | goto out; |
2729 | 3329 | ||
@@ -2762,8 +3362,8 @@ static int __ocfs2_xattr_set_handle(struct inode *inode, | |||
2762 | * If succeed and that extended attribute | 3362 | * If succeed and that extended attribute |
2763 | * existing in inode, we will remove it. | 3363 | * existing in inode, we will remove it. |
2764 | */ | 3364 | */ |
2765 | xi->value = NULL; | 3365 | xi->xi_value = NULL; |
2766 | xi->value_len = 0; | 3366 | xi->xi_value_len = 0; |
2767 | xbs->not_found = -ENODATA; | 3367 | xbs->not_found = -ENODATA; |
2768 | ret = ocfs2_calc_xattr_set_need(inode, | 3368 | ret = ocfs2_calc_xattr_set_need(inode, |
2769 | di, | 3369 | di, |
@@ -2829,10 +3429,11 @@ int ocfs2_xattr_set_handle(handle_t *handle, | |||
2829 | int ret; | 3429 | int ret; |
2830 | 3430 | ||
2831 | struct ocfs2_xattr_info xi = { | 3431 | struct ocfs2_xattr_info xi = { |
2832 | .name_index = name_index, | 3432 | .xi_name_index = name_index, |
2833 | .name = name, | 3433 | .xi_name = name, |
2834 | .value = value, | 3434 | .xi_name_len = strlen(name), |
2835 | .value_len = value_len, | 3435 | .xi_value = value, |
3436 | .xi_value_len = value_len, | ||
2836 | }; | 3437 | }; |
2837 | 3438 | ||
2838 | struct ocfs2_xattr_search xis = { | 3439 | struct ocfs2_xattr_search xis = { |
@@ -2912,10 +3513,11 @@ int ocfs2_xattr_set(struct inode *inode, | |||
2912 | struct ocfs2_refcount_tree *ref_tree = NULL; | 3513 | struct ocfs2_refcount_tree *ref_tree = NULL; |
2913 | 3514 | ||
2914 | struct ocfs2_xattr_info xi = { | 3515 | struct ocfs2_xattr_info xi = { |
2915 | .name_index = name_index, | 3516 | .xi_name_index = name_index, |
2916 | .name = name, | 3517 | .xi_name = name, |
2917 | .value = value, | 3518 | .xi_name_len = strlen(name), |
2918 | .value_len = value_len, | 3519 | .xi_value = value, |
3520 | .xi_value_len = value_len, | ||
2919 | }; | 3521 | }; |
2920 | 3522 | ||
2921 | struct ocfs2_xattr_search xis = { | 3523 | struct ocfs2_xattr_search xis = { |
@@ -3759,7 +4361,7 @@ static int ocfs2_defrag_xattr_bucket(struct inode *inode, | |||
3759 | struct ocfs2_xattr_bucket *bucket) | 4361 | struct ocfs2_xattr_bucket *bucket) |
3760 | { | 4362 | { |
3761 | int ret, i; | 4363 | int ret, i; |
3762 | size_t end, offset, len, value_len; | 4364 | size_t end, offset, len; |
3763 | struct ocfs2_xattr_header *xh; | 4365 | struct ocfs2_xattr_header *xh; |
3764 | char *entries, *buf, *bucket_buf = NULL; | 4366 | char *entries, *buf, *bucket_buf = NULL; |
3765 | u64 blkno = bucket_blkno(bucket); | 4367 | u64 blkno = bucket_blkno(bucket); |
@@ -3813,12 +4415,7 @@ static int ocfs2_defrag_xattr_bucket(struct inode *inode, | |||
3813 | end = OCFS2_XATTR_BUCKET_SIZE; | 4415 | end = OCFS2_XATTR_BUCKET_SIZE; |
3814 | for (i = 0; i < le16_to_cpu(xh->xh_count); i++, xe++) { | 4416 | for (i = 0; i < le16_to_cpu(xh->xh_count); i++, xe++) { |
3815 | offset = le16_to_cpu(xe->xe_name_offset); | 4417 | offset = le16_to_cpu(xe->xe_name_offset); |
3816 | if (ocfs2_xattr_is_local(xe)) | 4418 | len = namevalue_size_xe(xe); |
3817 | value_len = OCFS2_XATTR_SIZE( | ||
3818 | le64_to_cpu(xe->xe_value_size)); | ||
3819 | else | ||
3820 | value_len = OCFS2_XATTR_ROOT_SIZE; | ||
3821 | len = OCFS2_XATTR_SIZE(xe->xe_name_len) + value_len; | ||
3822 | 4419 | ||
3823 | /* | 4420 | /* |
3824 | * We must make sure that the name/value pair | 4421 | * We must make sure that the name/value pair |
@@ -4007,7 +4604,7 @@ static int ocfs2_divide_xattr_bucket(struct inode *inode, | |||
4007 | int new_bucket_head) | 4604 | int new_bucket_head) |
4008 | { | 4605 | { |
4009 | int ret, i; | 4606 | int ret, i; |
4010 | int count, start, len, name_value_len = 0, xe_len, name_offset = 0; | 4607 | int count, start, len, name_value_len = 0, name_offset = 0; |
4011 | struct ocfs2_xattr_bucket *s_bucket = NULL, *t_bucket = NULL; | 4608 | struct ocfs2_xattr_bucket *s_bucket = NULL, *t_bucket = NULL; |
4012 | struct ocfs2_xattr_header *xh; | 4609 | struct ocfs2_xattr_header *xh; |
4013 | struct ocfs2_xattr_entry *xe; | 4610 | struct ocfs2_xattr_entry *xe; |
@@ -4098,13 +4695,7 @@ static int ocfs2_divide_xattr_bucket(struct inode *inode, | |||
4098 | name_value_len = 0; | 4695 | name_value_len = 0; |
4099 | for (i = 0; i < start; i++) { | 4696 | for (i = 0; i < start; i++) { |
4100 | xe = &xh->xh_entries[i]; | 4697 | xe = &xh->xh_entries[i]; |
4101 | xe_len = OCFS2_XATTR_SIZE(xe->xe_name_len); | 4698 | name_value_len += namevalue_size_xe(xe); |
4102 | if (ocfs2_xattr_is_local(xe)) | ||
4103 | xe_len += | ||
4104 | OCFS2_XATTR_SIZE(le64_to_cpu(xe->xe_value_size)); | ||
4105 | else | ||
4106 | xe_len += OCFS2_XATTR_ROOT_SIZE; | ||
4107 | name_value_len += xe_len; | ||
4108 | if (le16_to_cpu(xe->xe_name_offset) < name_offset) | 4699 | if (le16_to_cpu(xe->xe_name_offset) < name_offset) |
4109 | name_offset = le16_to_cpu(xe->xe_name_offset); | 4700 | name_offset = le16_to_cpu(xe->xe_name_offset); |
4110 | } | 4701 | } |
@@ -4134,12 +4725,6 @@ static int ocfs2_divide_xattr_bucket(struct inode *inode, | |||
4134 | xh->xh_free_start = cpu_to_le16(OCFS2_XATTR_BUCKET_SIZE); | 4725 | xh->xh_free_start = cpu_to_le16(OCFS2_XATTR_BUCKET_SIZE); |
4135 | for (i = 0; i < le16_to_cpu(xh->xh_count); i++) { | 4726 | for (i = 0; i < le16_to_cpu(xh->xh_count); i++) { |
4136 | xe = &xh->xh_entries[i]; | 4727 | xe = &xh->xh_entries[i]; |
4137 | xe_len = OCFS2_XATTR_SIZE(xe->xe_name_len); | ||
4138 | if (ocfs2_xattr_is_local(xe)) | ||
4139 | xe_len += | ||
4140 | OCFS2_XATTR_SIZE(le64_to_cpu(xe->xe_value_size)); | ||
4141 | else | ||
4142 | xe_len += OCFS2_XATTR_ROOT_SIZE; | ||
4143 | if (le16_to_cpu(xe->xe_name_offset) < | 4728 | if (le16_to_cpu(xe->xe_name_offset) < |
4144 | le16_to_cpu(xh->xh_free_start)) | 4729 | le16_to_cpu(xh->xh_free_start)) |
4145 | xh->xh_free_start = xe->xe_name_offset; | 4730 | xh->xh_free_start = xe->xe_name_offset; |
@@ -4751,195 +5336,6 @@ static inline char *ocfs2_xattr_bucket_get_val(struct inode *inode, | |||
4751 | } | 5336 | } |
4752 | 5337 | ||
4753 | /* | 5338 | /* |
4754 | * Handle the normal xattr set, including replace, delete and new. | ||
4755 | * | ||
4756 | * Note: "local" indicates the real data's locality. So we can't | ||
4757 | * just its bucket locality by its length. | ||
4758 | */ | ||
4759 | static void ocfs2_xattr_set_entry_normal(struct inode *inode, | ||
4760 | struct ocfs2_xattr_info *xi, | ||
4761 | struct ocfs2_xattr_search *xs, | ||
4762 | u32 name_hash, | ||
4763 | int local) | ||
4764 | { | ||
4765 | struct ocfs2_xattr_entry *last, *xe; | ||
4766 | int name_len = strlen(xi->name); | ||
4767 | struct ocfs2_xattr_header *xh = xs->header; | ||
4768 | u16 count = le16_to_cpu(xh->xh_count), start; | ||
4769 | size_t blocksize = inode->i_sb->s_blocksize; | ||
4770 | char *val; | ||
4771 | size_t offs, size, new_size; | ||
4772 | |||
4773 | last = &xh->xh_entries[count]; | ||
4774 | if (!xs->not_found) { | ||
4775 | xe = xs->here; | ||
4776 | offs = le16_to_cpu(xe->xe_name_offset); | ||
4777 | if (ocfs2_xattr_is_local(xe)) | ||
4778 | size = OCFS2_XATTR_SIZE(name_len) + | ||
4779 | OCFS2_XATTR_SIZE(le64_to_cpu(xe->xe_value_size)); | ||
4780 | else | ||
4781 | size = OCFS2_XATTR_SIZE(name_len) + | ||
4782 | OCFS2_XATTR_SIZE(OCFS2_XATTR_ROOT_SIZE); | ||
4783 | |||
4784 | /* | ||
4785 | * If the new value will be stored outside, xi->value has been | ||
4786 | * initalized as an empty ocfs2_xattr_value_root, and the same | ||
4787 | * goes with xi->value_len, so we can set new_size safely here. | ||
4788 | * See ocfs2_xattr_set_in_bucket. | ||
4789 | */ | ||
4790 | new_size = OCFS2_XATTR_SIZE(name_len) + | ||
4791 | OCFS2_XATTR_SIZE(xi->value_len); | ||
4792 | |||
4793 | le16_add_cpu(&xh->xh_name_value_len, -size); | ||
4794 | if (xi->value) { | ||
4795 | if (new_size > size) | ||
4796 | goto set_new_name_value; | ||
4797 | |||
4798 | /* Now replace the old value with new one. */ | ||
4799 | if (local) | ||
4800 | xe->xe_value_size = cpu_to_le64(xi->value_len); | ||
4801 | else | ||
4802 | xe->xe_value_size = 0; | ||
4803 | |||
4804 | val = ocfs2_xattr_bucket_get_val(inode, | ||
4805 | xs->bucket, offs); | ||
4806 | memset(val + OCFS2_XATTR_SIZE(name_len), 0, | ||
4807 | size - OCFS2_XATTR_SIZE(name_len)); | ||
4808 | if (OCFS2_XATTR_SIZE(xi->value_len) > 0) | ||
4809 | memcpy(val + OCFS2_XATTR_SIZE(name_len), | ||
4810 | xi->value, xi->value_len); | ||
4811 | |||
4812 | le16_add_cpu(&xh->xh_name_value_len, new_size); | ||
4813 | ocfs2_xattr_set_local(xe, local); | ||
4814 | return; | ||
4815 | } else { | ||
4816 | /* | ||
4817 | * Remove the old entry if there is more than one. | ||
4818 | * We don't remove the last entry so that we can | ||
4819 | * use it to indicate the hash value of the empty | ||
4820 | * bucket. | ||
4821 | */ | ||
4822 | last -= 1; | ||
4823 | le16_add_cpu(&xh->xh_count, -1); | ||
4824 | if (xh->xh_count) { | ||
4825 | memmove(xe, xe + 1, | ||
4826 | (void *)last - (void *)xe); | ||
4827 | memset(last, 0, | ||
4828 | sizeof(struct ocfs2_xattr_entry)); | ||
4829 | } else | ||
4830 | xh->xh_free_start = | ||
4831 | cpu_to_le16(OCFS2_XATTR_BUCKET_SIZE); | ||
4832 | |||
4833 | return; | ||
4834 | } | ||
4835 | } else { | ||
4836 | /* find a new entry for insert. */ | ||
4837 | int low = 0, high = count - 1, tmp; | ||
4838 | struct ocfs2_xattr_entry *tmp_xe; | ||
4839 | |||
4840 | while (low <= high && count) { | ||
4841 | tmp = (low + high) / 2; | ||
4842 | tmp_xe = &xh->xh_entries[tmp]; | ||
4843 | |||
4844 | if (name_hash > le32_to_cpu(tmp_xe->xe_name_hash)) | ||
4845 | low = tmp + 1; | ||
4846 | else if (name_hash < | ||
4847 | le32_to_cpu(tmp_xe->xe_name_hash)) | ||
4848 | high = tmp - 1; | ||
4849 | else { | ||
4850 | low = tmp; | ||
4851 | break; | ||
4852 | } | ||
4853 | } | ||
4854 | |||
4855 | xe = &xh->xh_entries[low]; | ||
4856 | if (low != count) | ||
4857 | memmove(xe + 1, xe, (void *)last - (void *)xe); | ||
4858 | |||
4859 | le16_add_cpu(&xh->xh_count, 1); | ||
4860 | memset(xe, 0, sizeof(struct ocfs2_xattr_entry)); | ||
4861 | xe->xe_name_hash = cpu_to_le32(name_hash); | ||
4862 | xe->xe_name_len = name_len; | ||
4863 | ocfs2_xattr_set_type(xe, xi->name_index); | ||
4864 | } | ||
4865 | |||
4866 | set_new_name_value: | ||
4867 | /* Insert the new name+value. */ | ||
4868 | size = OCFS2_XATTR_SIZE(name_len) + OCFS2_XATTR_SIZE(xi->value_len); | ||
4869 | |||
4870 | /* | ||
4871 | * We must make sure that the name/value pair | ||
4872 | * exists in the same block. | ||
4873 | */ | ||
4874 | offs = le16_to_cpu(xh->xh_free_start); | ||
4875 | start = offs - size; | ||
4876 | |||
4877 | if (start >> inode->i_sb->s_blocksize_bits != | ||
4878 | (offs - 1) >> inode->i_sb->s_blocksize_bits) { | ||
4879 | offs = offs - offs % blocksize; | ||
4880 | xh->xh_free_start = cpu_to_le16(offs); | ||
4881 | } | ||
4882 | |||
4883 | val = ocfs2_xattr_bucket_get_val(inode, xs->bucket, offs - size); | ||
4884 | xe->xe_name_offset = cpu_to_le16(offs - size); | ||
4885 | |||
4886 | memset(val, 0, size); | ||
4887 | memcpy(val, xi->name, name_len); | ||
4888 | memcpy(val + OCFS2_XATTR_SIZE(name_len), xi->value, xi->value_len); | ||
4889 | |||
4890 | xe->xe_value_size = cpu_to_le64(xi->value_len); | ||
4891 | ocfs2_xattr_set_local(xe, local); | ||
4892 | xs->here = xe; | ||
4893 | le16_add_cpu(&xh->xh_free_start, -size); | ||
4894 | le16_add_cpu(&xh->xh_name_value_len, size); | ||
4895 | |||
4896 | return; | ||
4897 | } | ||
4898 | |||
4899 | /* | ||
4900 | * Set the xattr entry in the specified bucket. | ||
4901 | * The bucket is indicated by xs->bucket and it should have the enough | ||
4902 | * space for the xattr insertion. | ||
4903 | */ | ||
4904 | static int ocfs2_xattr_set_entry_in_bucket(struct inode *inode, | ||
4905 | handle_t *handle, | ||
4906 | struct ocfs2_xattr_info *xi, | ||
4907 | struct ocfs2_xattr_search *xs, | ||
4908 | u32 name_hash, | ||
4909 | int local) | ||
4910 | { | ||
4911 | int ret; | ||
4912 | u64 blkno; | ||
4913 | |||
4914 | mlog(0, "Set xattr entry len = %lu index = %d in bucket %llu\n", | ||
4915 | (unsigned long)xi->value_len, xi->name_index, | ||
4916 | (unsigned long long)bucket_blkno(xs->bucket)); | ||
4917 | |||
4918 | if (!xs->bucket->bu_bhs[1]) { | ||
4919 | blkno = bucket_blkno(xs->bucket); | ||
4920 | ocfs2_xattr_bucket_relse(xs->bucket); | ||
4921 | ret = ocfs2_read_xattr_bucket(xs->bucket, blkno); | ||
4922 | if (ret) { | ||
4923 | mlog_errno(ret); | ||
4924 | goto out; | ||
4925 | } | ||
4926 | } | ||
4927 | |||
4928 | ret = ocfs2_xattr_bucket_journal_access(handle, xs->bucket, | ||
4929 | OCFS2_JOURNAL_ACCESS_WRITE); | ||
4930 | if (ret < 0) { | ||
4931 | mlog_errno(ret); | ||
4932 | goto out; | ||
4933 | } | ||
4934 | |||
4935 | ocfs2_xattr_set_entry_normal(inode, xi, xs, name_hash, local); | ||
4936 | ocfs2_xattr_bucket_journal_dirty(handle, xs->bucket); | ||
4937 | |||
4938 | out: | ||
4939 | return ret; | ||
4940 | } | ||
4941 | |||
4942 | /* | ||
4943 | * Truncate the specified xe_off entry in xattr bucket. | 5339 | * Truncate the specified xe_off entry in xattr bucket. |
4944 | * bucket is indicated by header_bh and len is the new length. | 5340 | * bucket is indicated by header_bh and len is the new length. |
4945 | * Both the ocfs2_xattr_value_root and the entry will be updated here. | 5341 | * Both the ocfs2_xattr_value_root and the entry will be updated here. |
@@ -5009,66 +5405,6 @@ out: | |||
5009 | return ret; | 5405 | return ret; |
5010 | } | 5406 | } |
5011 | 5407 | ||
5012 | static int ocfs2_xattr_bucket_value_truncate_xs(struct inode *inode, | ||
5013 | struct ocfs2_xattr_search *xs, | ||
5014 | int len, | ||
5015 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
5016 | { | ||
5017 | int ret, offset; | ||
5018 | struct ocfs2_xattr_entry *xe = xs->here; | ||
5019 | struct ocfs2_xattr_header *xh = (struct ocfs2_xattr_header *)xs->base; | ||
5020 | |||
5021 | BUG_ON(!xs->bucket->bu_bhs[0] || !xe || ocfs2_xattr_is_local(xe)); | ||
5022 | |||
5023 | offset = xe - xh->xh_entries; | ||
5024 | ret = ocfs2_xattr_bucket_value_truncate(inode, xs->bucket, | ||
5025 | offset, len, ctxt); | ||
5026 | if (ret) | ||
5027 | mlog_errno(ret); | ||
5028 | |||
5029 | return ret; | ||
5030 | } | ||
5031 | |||
5032 | static int ocfs2_xattr_bucket_set_value_outside(struct inode *inode, | ||
5033 | handle_t *handle, | ||
5034 | struct ocfs2_xattr_search *xs, | ||
5035 | char *val, | ||
5036 | int value_len) | ||
5037 | { | ||
5038 | int ret, offset, block_off; | ||
5039 | struct ocfs2_xattr_value_root *xv; | ||
5040 | struct ocfs2_xattr_entry *xe = xs->here; | ||
5041 | struct ocfs2_xattr_header *xh = bucket_xh(xs->bucket); | ||
5042 | void *base; | ||
5043 | struct ocfs2_xattr_value_buf vb = { | ||
5044 | .vb_access = ocfs2_journal_access, | ||
5045 | }; | ||
5046 | |||
5047 | BUG_ON(!xs->base || !xe || ocfs2_xattr_is_local(xe)); | ||
5048 | |||
5049 | ret = ocfs2_xattr_bucket_get_name_value(inode->i_sb, xh, | ||
5050 | xe - xh->xh_entries, | ||
5051 | &block_off, | ||
5052 | &offset); | ||
5053 | if (ret) { | ||
5054 | mlog_errno(ret); | ||
5055 | goto out; | ||
5056 | } | ||
5057 | |||
5058 | base = bucket_block(xs->bucket, block_off); | ||
5059 | xv = (struct ocfs2_xattr_value_root *)(base + offset + | ||
5060 | OCFS2_XATTR_SIZE(xe->xe_name_len)); | ||
5061 | |||
5062 | vb.vb_xv = xv; | ||
5063 | vb.vb_bh = xs->bucket->bu_bhs[block_off]; | ||
5064 | ret = __ocfs2_xattr_set_value_outside(inode, handle, | ||
5065 | &vb, val, value_len); | ||
5066 | if (ret) | ||
5067 | mlog_errno(ret); | ||
5068 | out: | ||
5069 | return ret; | ||
5070 | } | ||
5071 | |||
5072 | static int ocfs2_rm_xattr_cluster(struct inode *inode, | 5408 | static int ocfs2_rm_xattr_cluster(struct inode *inode, |
5073 | struct buffer_head *root_bh, | 5409 | struct buffer_head *root_bh, |
5074 | u64 blkno, | 5410 | u64 blkno, |
@@ -5167,128 +5503,6 @@ out: | |||
5167 | return ret; | 5503 | return ret; |
5168 | } | 5504 | } |
5169 | 5505 | ||
5170 | static void ocfs2_xattr_bucket_remove_xs(struct inode *inode, | ||
5171 | handle_t *handle, | ||
5172 | struct ocfs2_xattr_search *xs) | ||
5173 | { | ||
5174 | struct ocfs2_xattr_header *xh = bucket_xh(xs->bucket); | ||
5175 | struct ocfs2_xattr_entry *last = &xh->xh_entries[ | ||
5176 | le16_to_cpu(xh->xh_count) - 1]; | ||
5177 | int ret = 0; | ||
5178 | |||
5179 | ret = ocfs2_xattr_bucket_journal_access(handle, xs->bucket, | ||
5180 | OCFS2_JOURNAL_ACCESS_WRITE); | ||
5181 | if (ret) { | ||
5182 | mlog_errno(ret); | ||
5183 | return; | ||
5184 | } | ||
5185 | |||
5186 | /* Remove the old entry. */ | ||
5187 | memmove(xs->here, xs->here + 1, | ||
5188 | (void *)last - (void *)xs->here); | ||
5189 | memset(last, 0, sizeof(struct ocfs2_xattr_entry)); | ||
5190 | le16_add_cpu(&xh->xh_count, -1); | ||
5191 | |||
5192 | ocfs2_xattr_bucket_journal_dirty(handle, xs->bucket); | ||
5193 | } | ||
5194 | |||
5195 | /* | ||
5196 | * Set the xattr name/value in the bucket specified in xs. | ||
5197 | * | ||
5198 | * As the new value in xi may be stored in the bucket or in an outside cluster, | ||
5199 | * we divide the whole process into 3 steps: | ||
5200 | * 1. insert name/value in the bucket(ocfs2_xattr_set_entry_in_bucket) | ||
5201 | * 2. truncate of the outside cluster(ocfs2_xattr_bucket_value_truncate_xs) | ||
5202 | * 3. Set the value to the outside cluster(ocfs2_xattr_bucket_set_value_outside) | ||
5203 | * 4. If the clusters for the new outside value can't be allocated, we need | ||
5204 | * to free the xattr we allocated in set. | ||
5205 | */ | ||
5206 | static int ocfs2_xattr_set_in_bucket(struct inode *inode, | ||
5207 | struct ocfs2_xattr_info *xi, | ||
5208 | struct ocfs2_xattr_search *xs, | ||
5209 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
5210 | { | ||
5211 | int ret, local = 1; | ||
5212 | size_t value_len; | ||
5213 | char *val = (char *)xi->value; | ||
5214 | struct ocfs2_xattr_entry *xe = xs->here; | ||
5215 | u32 name_hash = ocfs2_xattr_name_hash(inode, xi->name, | ||
5216 | strlen(xi->name)); | ||
5217 | |||
5218 | if (!xs->not_found && !ocfs2_xattr_is_local(xe)) { | ||
5219 | /* | ||
5220 | * We need to truncate the xattr storage first. | ||
5221 | * | ||
5222 | * If both the old and new value are stored to | ||
5223 | * outside block, we only need to truncate | ||
5224 | * the storage and then set the value outside. | ||
5225 | * | ||
5226 | * If the new value should be stored within block, | ||
5227 | * we should free all the outside block first and | ||
5228 | * the modification to the xattr block will be done | ||
5229 | * by following steps. | ||
5230 | */ | ||
5231 | if (xi->value_len > OCFS2_XATTR_INLINE_SIZE) | ||
5232 | value_len = xi->value_len; | ||
5233 | else | ||
5234 | value_len = 0; | ||
5235 | |||
5236 | ret = ocfs2_xattr_bucket_value_truncate_xs(inode, xs, | ||
5237 | value_len, | ||
5238 | ctxt); | ||
5239 | if (ret) | ||
5240 | goto out; | ||
5241 | |||
5242 | if (value_len) | ||
5243 | goto set_value_outside; | ||
5244 | } | ||
5245 | |||
5246 | value_len = xi->value_len; | ||
5247 | /* So we have to handle the inside block change now. */ | ||
5248 | if (value_len > OCFS2_XATTR_INLINE_SIZE) { | ||
5249 | /* | ||
5250 | * If the new value will be stored outside of block, | ||
5251 | * initalize a new empty value root and insert it first. | ||
5252 | */ | ||
5253 | local = 0; | ||
5254 | xi->value = &def_xv; | ||
5255 | xi->value_len = OCFS2_XATTR_ROOT_SIZE; | ||
5256 | } | ||
5257 | |||
5258 | ret = ocfs2_xattr_set_entry_in_bucket(inode, ctxt->handle, xi, xs, | ||
5259 | name_hash, local); | ||
5260 | if (ret) { | ||
5261 | mlog_errno(ret); | ||
5262 | goto out; | ||
5263 | } | ||
5264 | |||
5265 | if (value_len <= OCFS2_XATTR_INLINE_SIZE) | ||
5266 | goto out; | ||
5267 | |||
5268 | /* allocate the space now for the outside block storage. */ | ||
5269 | ret = ocfs2_xattr_bucket_value_truncate_xs(inode, xs, | ||
5270 | value_len, ctxt); | ||
5271 | if (ret) { | ||
5272 | mlog_errno(ret); | ||
5273 | |||
5274 | if (xs->not_found) { | ||
5275 | /* | ||
5276 | * We can't allocate enough clusters for outside | ||
5277 | * storage and we have allocated xattr already, | ||
5278 | * so need to remove it. | ||
5279 | */ | ||
5280 | ocfs2_xattr_bucket_remove_xs(inode, ctxt->handle, xs); | ||
5281 | } | ||
5282 | goto out; | ||
5283 | } | ||
5284 | |||
5285 | set_value_outside: | ||
5286 | ret = ocfs2_xattr_bucket_set_value_outside(inode, ctxt->handle, | ||
5287 | xs, val, value_len); | ||
5288 | out: | ||
5289 | return ret; | ||
5290 | } | ||
5291 | |||
5292 | /* | 5506 | /* |
5293 | * check whether the xattr bucket is filled up with the same hash value. | 5507 | * check whether the xattr bucket is filled up with the same hash value. |
5294 | * If we want to insert the xattr with the same hash, return -ENOSPC. | 5508 | * If we want to insert the xattr with the same hash, return -ENOSPC. |
@@ -5317,156 +5531,116 @@ static int ocfs2_check_xattr_bucket_collision(struct inode *inode, | |||
5317 | return 0; | 5531 | return 0; |
5318 | } | 5532 | } |
5319 | 5533 | ||
5320 | static int ocfs2_xattr_set_entry_index_block(struct inode *inode, | 5534 | /* |
5321 | struct ocfs2_xattr_info *xi, | 5535 | * Try to set the entry in the current bucket. If we fail, the caller |
5322 | struct ocfs2_xattr_search *xs, | 5536 | * will handle getting us another bucket. |
5323 | struct ocfs2_xattr_set_ctxt *ctxt) | 5537 | */ |
5538 | static int ocfs2_xattr_set_entry_bucket(struct inode *inode, | ||
5539 | struct ocfs2_xattr_info *xi, | ||
5540 | struct ocfs2_xattr_search *xs, | ||
5541 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
5324 | { | 5542 | { |
5325 | struct ocfs2_xattr_header *xh; | 5543 | int ret; |
5326 | struct ocfs2_xattr_entry *xe; | 5544 | struct ocfs2_xa_loc loc; |
5327 | u16 count, header_size, xh_free_start; | ||
5328 | int free, max_free, need, old; | ||
5329 | size_t value_size = 0, name_len = strlen(xi->name); | ||
5330 | size_t blocksize = inode->i_sb->s_blocksize; | ||
5331 | int ret, allocation = 0; | ||
5332 | |||
5333 | mlog_entry("Set xattr %s in xattr index block\n", xi->name); | ||
5334 | |||
5335 | try_again: | ||
5336 | xh = xs->header; | ||
5337 | count = le16_to_cpu(xh->xh_count); | ||
5338 | xh_free_start = le16_to_cpu(xh->xh_free_start); | ||
5339 | header_size = sizeof(struct ocfs2_xattr_header) + | ||
5340 | count * sizeof(struct ocfs2_xattr_entry); | ||
5341 | max_free = OCFS2_XATTR_BUCKET_SIZE - header_size - | ||
5342 | le16_to_cpu(xh->xh_name_value_len) - OCFS2_XATTR_HEADER_GAP; | ||
5343 | |||
5344 | mlog_bug_on_msg(header_size > blocksize, "bucket %llu has header size " | ||
5345 | "of %u which exceed block size\n", | ||
5346 | (unsigned long long)bucket_blkno(xs->bucket), | ||
5347 | header_size); | ||
5348 | 5545 | ||
5349 | if (xi->value && xi->value_len > OCFS2_XATTR_INLINE_SIZE) | 5546 | mlog_entry("Set xattr %s in xattr bucket\n", xi->xi_name); |
5350 | value_size = OCFS2_XATTR_ROOT_SIZE; | ||
5351 | else if (xi->value) | ||
5352 | value_size = OCFS2_XATTR_SIZE(xi->value_len); | ||
5353 | 5547 | ||
5354 | if (xs->not_found) | 5548 | ocfs2_init_xattr_bucket_xa_loc(&loc, xs->bucket, |
5355 | need = sizeof(struct ocfs2_xattr_entry) + | 5549 | xs->not_found ? NULL : xs->here); |
5356 | OCFS2_XATTR_SIZE(name_len) + value_size; | 5550 | ret = ocfs2_xa_set(&loc, xi, ctxt); |
5357 | else { | 5551 | if (!ret) { |
5358 | need = value_size + OCFS2_XATTR_SIZE(name_len); | 5552 | xs->here = loc.xl_entry; |
5553 | goto out; | ||
5554 | } | ||
5555 | if (ret != -ENOSPC) { | ||
5556 | mlog_errno(ret); | ||
5557 | goto out; | ||
5558 | } | ||
5359 | 5559 | ||
5360 | /* | 5560 | /* Ok, we need space. Let's try defragmenting the bucket. */ |
5361 | * We only replace the old value if the new length is smaller | 5561 | ret = ocfs2_defrag_xattr_bucket(inode, ctxt->handle, |
5362 | * than the old one. Otherwise we will allocate new space in the | 5562 | xs->bucket); |
5363 | * bucket to store it. | 5563 | if (ret) { |
5364 | */ | 5564 | mlog_errno(ret); |
5365 | xe = xs->here; | 5565 | goto out; |
5366 | if (ocfs2_xattr_is_local(xe)) | 5566 | } |
5367 | old = OCFS2_XATTR_SIZE(le64_to_cpu(xe->xe_value_size)); | ||
5368 | else | ||
5369 | old = OCFS2_XATTR_SIZE(OCFS2_XATTR_ROOT_SIZE); | ||
5370 | 5567 | ||
5371 | if (old >= value_size) | 5568 | ret = ocfs2_xa_set(&loc, xi, ctxt); |
5372 | need = 0; | 5569 | if (!ret) { |
5570 | xs->here = loc.xl_entry; | ||
5571 | goto out; | ||
5373 | } | 5572 | } |
5573 | if (ret != -ENOSPC) | ||
5574 | mlog_errno(ret); | ||
5374 | 5575 | ||
5375 | free = xh_free_start - header_size - OCFS2_XATTR_HEADER_GAP; | ||
5376 | /* | ||
5377 | * We need to make sure the new name/value pair | ||
5378 | * can exist in the same block. | ||
5379 | */ | ||
5380 | if (xh_free_start % blocksize < need) | ||
5381 | free -= xh_free_start % blocksize; | ||
5382 | |||
5383 | mlog(0, "xs->not_found = %d, in xattr bucket %llu: free = %d, " | ||
5384 | "need = %d, max_free = %d, xh_free_start = %u, xh_name_value_len =" | ||
5385 | " %u\n", xs->not_found, | ||
5386 | (unsigned long long)bucket_blkno(xs->bucket), | ||
5387 | free, need, max_free, le16_to_cpu(xh->xh_free_start), | ||
5388 | le16_to_cpu(xh->xh_name_value_len)); | ||
5389 | |||
5390 | if (free < need || | ||
5391 | (xs->not_found && | ||
5392 | count == ocfs2_xattr_max_xe_in_bucket(inode->i_sb))) { | ||
5393 | if (need <= max_free && | ||
5394 | count < ocfs2_xattr_max_xe_in_bucket(inode->i_sb)) { | ||
5395 | /* | ||
5396 | * We can create the space by defragment. Since only the | ||
5397 | * name/value will be moved, the xe shouldn't be changed | ||
5398 | * in xs. | ||
5399 | */ | ||
5400 | ret = ocfs2_defrag_xattr_bucket(inode, ctxt->handle, | ||
5401 | xs->bucket); | ||
5402 | if (ret) { | ||
5403 | mlog_errno(ret); | ||
5404 | goto out; | ||
5405 | } | ||
5406 | 5576 | ||
5407 | xh_free_start = le16_to_cpu(xh->xh_free_start); | 5577 | out: |
5408 | free = xh_free_start - header_size | 5578 | mlog_exit(ret); |
5409 | - OCFS2_XATTR_HEADER_GAP; | 5579 | return ret; |
5410 | if (xh_free_start % blocksize < need) | 5580 | } |
5411 | free -= xh_free_start % blocksize; | ||
5412 | 5581 | ||
5413 | if (free >= need) | 5582 | static int ocfs2_xattr_set_entry_index_block(struct inode *inode, |
5414 | goto xattr_set; | 5583 | struct ocfs2_xattr_info *xi, |
5584 | struct ocfs2_xattr_search *xs, | ||
5585 | struct ocfs2_xattr_set_ctxt *ctxt) | ||
5586 | { | ||
5587 | int ret; | ||
5415 | 5588 | ||
5416 | mlog(0, "Can't get enough space for xattr insert by " | 5589 | mlog_entry("Set xattr %s in xattr index block\n", xi->xi_name); |
5417 | "defragment. Need %u bytes, but we have %d, so " | ||
5418 | "allocate new bucket for it.\n", need, free); | ||
5419 | } | ||
5420 | 5590 | ||
5421 | /* | 5591 | ret = ocfs2_xattr_set_entry_bucket(inode, xi, xs, ctxt); |
5422 | * We have to add new buckets or clusters and one | 5592 | if (!ret) |
5423 | * allocation should leave us enough space for insert. | 5593 | goto out; |
5424 | */ | 5594 | if (ret != -ENOSPC) { |
5425 | BUG_ON(allocation); | 5595 | mlog_errno(ret); |
5596 | goto out; | ||
5597 | } | ||
5426 | 5598 | ||
5427 | /* | 5599 | /* Ack, need more space. Let's try to get another bucket! */ |
5428 | * We do not allow for overlapping ranges between buckets. And | ||
5429 | * the maximum number of collisions we will allow for then is | ||
5430 | * one bucket's worth, so check it here whether we need to | ||
5431 | * add a new bucket for the insert. | ||
5432 | */ | ||
5433 | ret = ocfs2_check_xattr_bucket_collision(inode, | ||
5434 | xs->bucket, | ||
5435 | xi->name); | ||
5436 | if (ret) { | ||
5437 | mlog_errno(ret); | ||
5438 | goto out; | ||
5439 | } | ||
5440 | 5600 | ||
5441 | ret = ocfs2_add_new_xattr_bucket(inode, | 5601 | /* |
5442 | xs->xattr_bh, | 5602 | * We do not allow for overlapping ranges between buckets. And |
5603 | * the maximum number of collisions we will allow for then is | ||
5604 | * one bucket's worth, so check it here whether we need to | ||
5605 | * add a new bucket for the insert. | ||
5606 | */ | ||
5607 | ret = ocfs2_check_xattr_bucket_collision(inode, | ||
5443 | xs->bucket, | 5608 | xs->bucket, |
5444 | ctxt); | 5609 | xi->xi_name); |
5445 | if (ret) { | 5610 | if (ret) { |
5446 | mlog_errno(ret); | 5611 | mlog_errno(ret); |
5447 | goto out; | 5612 | goto out; |
5448 | } | 5613 | } |
5449 | 5614 | ||
5450 | /* | 5615 | ret = ocfs2_add_new_xattr_bucket(inode, |
5451 | * ocfs2_add_new_xattr_bucket() will have updated | 5616 | xs->xattr_bh, |
5452 | * xs->bucket if it moved, but it will not have updated | 5617 | xs->bucket, |
5453 | * any of the other search fields. Thus, we drop it and | 5618 | ctxt); |
5454 | * re-search. Everything should be cached, so it'll be | 5619 | if (ret) { |
5455 | * quick. | 5620 | mlog_errno(ret); |
5456 | */ | 5621 | goto out; |
5457 | ocfs2_xattr_bucket_relse(xs->bucket); | ||
5458 | ret = ocfs2_xattr_index_block_find(inode, xs->xattr_bh, | ||
5459 | xi->name_index, | ||
5460 | xi->name, xs); | ||
5461 | if (ret && ret != -ENODATA) | ||
5462 | goto out; | ||
5463 | xs->not_found = ret; | ||
5464 | allocation = 1; | ||
5465 | goto try_again; | ||
5466 | } | 5622 | } |
5467 | 5623 | ||
5468 | xattr_set: | 5624 | /* |
5469 | ret = ocfs2_xattr_set_in_bucket(inode, xi, xs, ctxt); | 5625 | * ocfs2_add_new_xattr_bucket() will have updated |
5626 | * xs->bucket if it moved, but it will not have updated | ||
5627 | * any of the other search fields. Thus, we drop it and | ||
5628 | * re-search. Everything should be cached, so it'll be | ||
5629 | * quick. | ||
5630 | */ | ||
5631 | ocfs2_xattr_bucket_relse(xs->bucket); | ||
5632 | ret = ocfs2_xattr_index_block_find(inode, xs->xattr_bh, | ||
5633 | xi->xi_name_index, | ||
5634 | xi->xi_name, xs); | ||
5635 | if (ret && ret != -ENODATA) | ||
5636 | goto out; | ||
5637 | xs->not_found = ret; | ||
5638 | |||
5639 | /* Ok, we have a new bucket, let's try again */ | ||
5640 | ret = ocfs2_xattr_set_entry_bucket(inode, xi, xs, ctxt); | ||
5641 | if (ret && (ret != -ENOSPC)) | ||
5642 | mlog_errno(ret); | ||
5643 | |||
5470 | out: | 5644 | out: |
5471 | mlog_exit(ret); | 5645 | mlog_exit(ret); |
5472 | return ret; | 5646 | return ret; |
@@ -5678,7 +5852,7 @@ static int ocfs2_prepare_refcount_xattr(struct inode *inode, | |||
5678 | * refcount tree, and make the original extent become 3. So we will need | 5852 | * refcount tree, and make the original extent become 3. So we will need |
5679 | * 2 * cluster more extent recs at most. | 5853 | * 2 * cluster more extent recs at most. |
5680 | */ | 5854 | */ |
5681 | if (!xi->value || xi->value_len <= OCFS2_XATTR_INLINE_SIZE) { | 5855 | if (!xi->xi_value || xi->xi_value_len <= OCFS2_XATTR_INLINE_SIZE) { |
5682 | 5856 | ||
5683 | ret = ocfs2_refcounted_xattr_delete_need(inode, | 5857 | ret = ocfs2_refcounted_xattr_delete_need(inode, |
5684 | &(*ref_tree)->rf_ci, | 5858 | &(*ref_tree)->rf_ci, |
@@ -6354,9 +6528,11 @@ static int ocfs2_create_empty_xattr_block(struct inode *inode, | |||
6354 | int indexed) | 6528 | int indexed) |
6355 | { | 6529 | { |
6356 | int ret; | 6530 | int ret; |
6357 | handle_t *handle; | ||
6358 | struct ocfs2_alloc_context *meta_ac; | 6531 | struct ocfs2_alloc_context *meta_ac; |
6359 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); | 6532 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); |
6533 | struct ocfs2_xattr_set_ctxt ctxt = { | ||
6534 | .meta_ac = meta_ac, | ||
6535 | }; | ||
6360 | 6536 | ||
6361 | ret = ocfs2_reserve_new_metadata_blocks(osb, 1, &meta_ac); | 6537 | ret = ocfs2_reserve_new_metadata_blocks(osb, 1, &meta_ac); |
6362 | if (ret < 0) { | 6538 | if (ret < 0) { |
@@ -6364,21 +6540,21 @@ static int ocfs2_create_empty_xattr_block(struct inode *inode, | |||
6364 | return ret; | 6540 | return ret; |
6365 | } | 6541 | } |
6366 | 6542 | ||
6367 | handle = ocfs2_start_trans(osb, OCFS2_XATTR_BLOCK_CREATE_CREDITS); | 6543 | ctxt.handle = ocfs2_start_trans(osb, OCFS2_XATTR_BLOCK_CREATE_CREDITS); |
6368 | if (IS_ERR(handle)) { | 6544 | if (IS_ERR(ctxt.handle)) { |
6369 | ret = PTR_ERR(handle); | 6545 | ret = PTR_ERR(ctxt.handle); |
6370 | mlog_errno(ret); | 6546 | mlog_errno(ret); |
6371 | goto out; | 6547 | goto out; |
6372 | } | 6548 | } |
6373 | 6549 | ||
6374 | mlog(0, "create new xattr block for inode %llu, index = %d\n", | 6550 | mlog(0, "create new xattr block for inode %llu, index = %d\n", |
6375 | (unsigned long long)fe_bh->b_blocknr, indexed); | 6551 | (unsigned long long)fe_bh->b_blocknr, indexed); |
6376 | ret = ocfs2_create_xattr_block(handle, inode, fe_bh, | 6552 | ret = ocfs2_create_xattr_block(inode, fe_bh, &ctxt, indexed, |
6377 | meta_ac, ret_bh, indexed); | 6553 | ret_bh); |
6378 | if (ret) | 6554 | if (ret) |
6379 | mlog_errno(ret); | 6555 | mlog_errno(ret); |
6380 | 6556 | ||
6381 | ocfs2_commit_trans(osb, handle); | 6557 | ocfs2_commit_trans(osb, ctxt.handle); |
6382 | out: | 6558 | out: |
6383 | ocfs2_free_alloc_context(meta_ac); | 6559 | ocfs2_free_alloc_context(meta_ac); |
6384 | return ret; | 6560 | return ret; |
diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c index f3b7c1541f3a..75d9b5ba1d45 100644 --- a/fs/omfs/inode.c +++ b/fs/omfs/inode.c | |||
@@ -11,6 +11,7 @@ | |||
11 | #include <linux/parser.h> | 11 | #include <linux/parser.h> |
12 | #include <linux/buffer_head.h> | 12 | #include <linux/buffer_head.h> |
13 | #include <linux/vmalloc.h> | 13 | #include <linux/vmalloc.h> |
14 | #include <linux/writeback.h> | ||
14 | #include <linux/crc-itu-t.h> | 15 | #include <linux/crc-itu-t.h> |
15 | #include "omfs.h" | 16 | #include "omfs.h" |
16 | 17 | ||
@@ -89,7 +90,7 @@ static void omfs_update_checksums(struct omfs_inode *oi) | |||
89 | oi->i_head.h_check_xor = xor; | 90 | oi->i_head.h_check_xor = xor; |
90 | } | 91 | } |
91 | 92 | ||
92 | static int omfs_write_inode(struct inode *inode, int wait) | 93 | static int __omfs_write_inode(struct inode *inode, int wait) |
93 | { | 94 | { |
94 | struct omfs_inode *oi; | 95 | struct omfs_inode *oi; |
95 | struct omfs_sb_info *sbi = OMFS_SB(inode->i_sb); | 96 | struct omfs_sb_info *sbi = OMFS_SB(inode->i_sb); |
@@ -162,9 +163,14 @@ out: | |||
162 | return ret; | 163 | return ret; |
163 | } | 164 | } |
164 | 165 | ||
166 | static int omfs_write_inode(struct inode *inode, struct writeback_control *wbc) | ||
167 | { | ||
168 | return __omfs_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL); | ||
169 | } | ||
170 | |||
165 | int omfs_sync_inode(struct inode *inode) | 171 | int omfs_sync_inode(struct inode *inode) |
166 | { | 172 | { |
167 | return omfs_write_inode(inode, 1); | 173 | return __omfs_write_inode(inode, 1); |
168 | } | 174 | } |
169 | 175 | ||
170 | /* | 176 | /* |
@@ -8,7 +8,6 @@ | |||
8 | #include <linux/mm.h> | 8 | #include <linux/mm.h> |
9 | #include <linux/file.h> | 9 | #include <linux/file.h> |
10 | #include <linux/fdtable.h> | 10 | #include <linux/fdtable.h> |
11 | #include <linux/quotaops.h> | ||
12 | #include <linux/fsnotify.h> | 11 | #include <linux/fsnotify.h> |
13 | #include <linux/module.h> | 12 | #include <linux/module.h> |
14 | #include <linux/slab.h> | 13 | #include <linux/slab.h> |
@@ -271,17 +270,15 @@ static long do_sys_truncate(const char __user *pathname, loff_t length) | |||
271 | * Make sure that there are no leases. get_write_access() protects | 270 | * Make sure that there are no leases. get_write_access() protects |
272 | * against the truncate racing with a lease-granting setlease(). | 271 | * against the truncate racing with a lease-granting setlease(). |
273 | */ | 272 | */ |
274 | error = break_lease(inode, FMODE_WRITE); | 273 | error = break_lease(inode, O_WRONLY); |
275 | if (error) | 274 | if (error) |
276 | goto put_write_and_out; | 275 | goto put_write_and_out; |
277 | 276 | ||
278 | error = locks_verify_truncate(inode, NULL, length); | 277 | error = locks_verify_truncate(inode, NULL, length); |
279 | if (!error) | 278 | if (!error) |
280 | error = security_path_truncate(&path, length, 0); | 279 | error = security_path_truncate(&path, length, 0); |
281 | if (!error) { | 280 | if (!error) |
282 | vfs_dq_init(inode); | ||
283 | error = do_truncate(path.dentry, length, 0, NULL); | 281 | error = do_truncate(path.dentry, length, 0, NULL); |
284 | } | ||
285 | 282 | ||
286 | put_write_and_out: | 283 | put_write_and_out: |
287 | put_write_access(inode); | 284 | put_write_access(inode); |
diff --git a/fs/partitions/check.c b/fs/partitions/check.c index 64bc8998ac9a..e8865c11777f 100644 --- a/fs/partitions/check.c +++ b/fs/partitions/check.c | |||
@@ -412,9 +412,10 @@ struct hd_struct *add_partition(struct gendisk *disk, int partno, | |||
412 | pdev = part_to_dev(p); | 412 | pdev = part_to_dev(p); |
413 | 413 | ||
414 | p->start_sect = start; | 414 | p->start_sect = start; |
415 | p->alignment_offset = queue_sector_alignment_offset(disk->queue, start); | 415 | p->alignment_offset = |
416 | p->discard_alignment = queue_sector_discard_alignment(disk->queue, | 416 | queue_limit_alignment_offset(&disk->queue->limits, start); |
417 | start); | 417 | p->discard_alignment = |
418 | queue_limit_discard_alignment(&disk->queue->limits, start); | ||
418 | p->nr_sects = len; | 419 | p->nr_sects = len; |
419 | p->partno = partno; | 420 | p->partno = partno; |
420 | p->policy = get_disk_ro(disk); | 421 | p->policy = get_disk_ro(disk); |
diff --git a/fs/pnode.c b/fs/pnode.c index 8d5f392ec3d3..5cc564a83149 100644 --- a/fs/pnode.c +++ b/fs/pnode.c | |||
@@ -86,7 +86,7 @@ static int do_make_slave(struct vfsmount *mnt) | |||
86 | 86 | ||
87 | /* | 87 | /* |
88 | * slave 'mnt' to a peer mount that has the | 88 | * slave 'mnt' to a peer mount that has the |
89 | * same root dentry. If none is available than | 89 | * same root dentry. If none is available then |
90 | * slave it to anything that is available. | 90 | * slave it to anything that is available. |
91 | */ | 91 | */ |
92 | while ((peer_mnt = next_peer(peer_mnt)) != mnt && | 92 | while ((peer_mnt = next_peer(peer_mnt)) != mnt && |
@@ -147,6 +147,11 @@ void change_mnt_propagation(struct vfsmount *mnt, int type) | |||
147 | * get the next mount in the propagation tree. | 147 | * get the next mount in the propagation tree. |
148 | * @m: the mount seen last | 148 | * @m: the mount seen last |
149 | * @origin: the original mount from where the tree walk initiated | 149 | * @origin: the original mount from where the tree walk initiated |
150 | * | ||
151 | * Note that peer groups form contiguous segments of slave lists. | ||
152 | * We rely on that in get_source() to be able to find out if | ||
153 | * vfsmount found while iterating with propagation_next() is | ||
154 | * a peer of one we'd found earlier. | ||
150 | */ | 155 | */ |
151 | static struct vfsmount *propagation_next(struct vfsmount *m, | 156 | static struct vfsmount *propagation_next(struct vfsmount *m, |
152 | struct vfsmount *origin) | 157 | struct vfsmount *origin) |
@@ -186,10 +191,6 @@ static struct vfsmount *get_source(struct vfsmount *dest, | |||
186 | { | 191 | { |
187 | struct vfsmount *p_last_src = NULL; | 192 | struct vfsmount *p_last_src = NULL; |
188 | struct vfsmount *p_last_dest = NULL; | 193 | struct vfsmount *p_last_dest = NULL; |
189 | *type = CL_PROPAGATION; | ||
190 | |||
191 | if (IS_MNT_SHARED(dest)) | ||
192 | *type |= CL_MAKE_SHARED; | ||
193 | 194 | ||
194 | while (last_dest != dest->mnt_master) { | 195 | while (last_dest != dest->mnt_master) { |
195 | p_last_dest = last_dest; | 196 | p_last_dest = last_dest; |
@@ -202,13 +203,18 @@ static struct vfsmount *get_source(struct vfsmount *dest, | |||
202 | do { | 203 | do { |
203 | p_last_dest = next_peer(p_last_dest); | 204 | p_last_dest = next_peer(p_last_dest); |
204 | } while (IS_MNT_NEW(p_last_dest)); | 205 | } while (IS_MNT_NEW(p_last_dest)); |
206 | /* is that a peer of the earlier? */ | ||
207 | if (dest == p_last_dest) { | ||
208 | *type = CL_MAKE_SHARED; | ||
209 | return p_last_src; | ||
210 | } | ||
205 | } | 211 | } |
206 | 212 | /* slave of the earlier, then */ | |
207 | if (dest != p_last_dest) { | 213 | *type = CL_SLAVE; |
208 | *type |= CL_SLAVE; | 214 | /* beginning of peer group among the slaves? */ |
209 | return last_src; | 215 | if (IS_MNT_SHARED(dest)) |
210 | } else | 216 | *type |= CL_MAKE_SHARED; |
211 | return p_last_src; | 217 | return last_src; |
212 | } | 218 | } |
213 | 219 | ||
214 | /* | 220 | /* |
diff --git a/fs/pnode.h b/fs/pnode.h index 958665d662af..1ea4ae1efcd3 100644 --- a/fs/pnode.h +++ b/fs/pnode.h | |||
@@ -21,12 +21,11 @@ | |||
21 | #define CL_SLAVE 0x02 | 21 | #define CL_SLAVE 0x02 |
22 | #define CL_COPY_ALL 0x04 | 22 | #define CL_COPY_ALL 0x04 |
23 | #define CL_MAKE_SHARED 0x08 | 23 | #define CL_MAKE_SHARED 0x08 |
24 | #define CL_PROPAGATION 0x10 | 24 | #define CL_PRIVATE 0x10 |
25 | #define CL_PRIVATE 0x20 | ||
26 | 25 | ||
27 | static inline void set_mnt_shared(struct vfsmount *mnt) | 26 | static inline void set_mnt_shared(struct vfsmount *mnt) |
28 | { | 27 | { |
29 | mnt->mnt_flags &= ~MNT_PNODE_MASK; | 28 | mnt->mnt_flags &= ~MNT_SHARED_MASK; |
30 | mnt->mnt_flags |= MNT_SHARED; | 29 | mnt->mnt_flags |= MNT_SHARED; |
31 | } | 30 | } |
32 | 31 | ||
diff --git a/fs/proc/array.c b/fs/proc/array.c index 13b5d0708175..aa8637b81028 100644 --- a/fs/proc/array.c +++ b/fs/proc/array.c | |||
@@ -270,8 +270,10 @@ static inline void task_sig(struct seq_file *m, struct task_struct *p) | |||
270 | blocked = p->blocked; | 270 | blocked = p->blocked; |
271 | collect_sigign_sigcatch(p, &ignored, &caught); | 271 | collect_sigign_sigcatch(p, &ignored, &caught); |
272 | num_threads = atomic_read(&p->signal->count); | 272 | num_threads = atomic_read(&p->signal->count); |
273 | rcu_read_lock(); /* FIXME: is this correct? */ | ||
273 | qsize = atomic_read(&__task_cred(p)->user->sigpending); | 274 | qsize = atomic_read(&__task_cred(p)->user->sigpending); |
274 | qlim = p->signal->rlim[RLIMIT_SIGPENDING].rlim_cur; | 275 | rcu_read_unlock(); |
276 | qlim = task_rlimit(p, RLIMIT_SIGPENDING); | ||
275 | unlock_task_sighand(p, &flags); | 277 | unlock_task_sighand(p, &flags); |
276 | } | 278 | } |
277 | 279 | ||
@@ -418,7 +420,7 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns, | |||
418 | cutime = sig->cutime; | 420 | cutime = sig->cutime; |
419 | cstime = sig->cstime; | 421 | cstime = sig->cstime; |
420 | cgtime = sig->cgtime; | 422 | cgtime = sig->cgtime; |
421 | rsslim = sig->rlim[RLIMIT_RSS].rlim_cur; | 423 | rsslim = ACCESS_ONCE(sig->rlim[RLIMIT_RSS].rlim_cur); |
422 | 424 | ||
423 | /* add up live thread stats at the group level */ | 425 | /* add up live thread stats at the group level */ |
424 | if (whole) { | 426 | if (whole) { |
diff --git a/fs/proc/base.c b/fs/proc/base.c index 58324c299165..a7310841c831 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c | |||
@@ -647,17 +647,11 @@ static int mounts_release(struct inode *inode, struct file *file) | |||
647 | static unsigned mounts_poll(struct file *file, poll_table *wait) | 647 | static unsigned mounts_poll(struct file *file, poll_table *wait) |
648 | { | 648 | { |
649 | struct proc_mounts *p = file->private_data; | 649 | struct proc_mounts *p = file->private_data; |
650 | struct mnt_namespace *ns = p->ns; | ||
651 | unsigned res = POLLIN | POLLRDNORM; | 650 | unsigned res = POLLIN | POLLRDNORM; |
652 | 651 | ||
653 | poll_wait(file, &ns->poll, wait); | 652 | poll_wait(file, &p->ns->poll, wait); |
654 | 653 | if (mnt_had_events(p)) | |
655 | spin_lock(&vfsmount_lock); | ||
656 | if (p->event != ns->event) { | ||
657 | p->event = ns->event; | ||
658 | res |= POLLERR | POLLPRI; | 654 | res |= POLLERR | POLLPRI; |
659 | } | ||
660 | spin_unlock(&vfsmount_lock); | ||
661 | 655 | ||
662 | return res; | 656 | return res; |
663 | } | 657 | } |
@@ -1095,8 +1089,12 @@ static ssize_t proc_loginuid_write(struct file * file, const char __user * buf, | |||
1095 | if (!capable(CAP_AUDIT_CONTROL)) | 1089 | if (!capable(CAP_AUDIT_CONTROL)) |
1096 | return -EPERM; | 1090 | return -EPERM; |
1097 | 1091 | ||
1098 | if (current != pid_task(proc_pid(inode), PIDTYPE_PID)) | 1092 | rcu_read_lock(); |
1093 | if (current != pid_task(proc_pid(inode), PIDTYPE_PID)) { | ||
1094 | rcu_read_unlock(); | ||
1099 | return -EPERM; | 1095 | return -EPERM; |
1096 | } | ||
1097 | rcu_read_unlock(); | ||
1100 | 1098 | ||
1101 | if (count >= PAGE_SIZE) | 1099 | if (count >= PAGE_SIZE) |
1102 | count = PAGE_SIZE - 1; | 1100 | count = PAGE_SIZE - 1; |
diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 480cb1065eec..08f4d71dacd7 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c | |||
@@ -291,19 +291,17 @@ static const struct inode_operations proc_file_inode_operations = { | |||
291 | * returns the struct proc_dir_entry for "/proc/tty/driver", and | 291 | * returns the struct proc_dir_entry for "/proc/tty/driver", and |
292 | * returns "serial" in residual. | 292 | * returns "serial" in residual. |
293 | */ | 293 | */ |
294 | static int xlate_proc_name(const char *name, | 294 | static int __xlate_proc_name(const char *name, struct proc_dir_entry **ret, |
295 | struct proc_dir_entry **ret, const char **residual) | 295 | const char **residual) |
296 | { | 296 | { |
297 | const char *cp = name, *next; | 297 | const char *cp = name, *next; |
298 | struct proc_dir_entry *de; | 298 | struct proc_dir_entry *de; |
299 | int len; | 299 | int len; |
300 | int rtn = 0; | ||
301 | 300 | ||
302 | de = *ret; | 301 | de = *ret; |
303 | if (!de) | 302 | if (!de) |
304 | de = &proc_root; | 303 | de = &proc_root; |
305 | 304 | ||
306 | spin_lock(&proc_subdir_lock); | ||
307 | while (1) { | 305 | while (1) { |
308 | next = strchr(cp, '/'); | 306 | next = strchr(cp, '/'); |
309 | if (!next) | 307 | if (!next) |
@@ -315,16 +313,25 @@ static int xlate_proc_name(const char *name, | |||
315 | break; | 313 | break; |
316 | } | 314 | } |
317 | if (!de) { | 315 | if (!de) { |
318 | rtn = -ENOENT; | 316 | WARN(1, "name '%s'\n", name); |
319 | goto out; | 317 | return -ENOENT; |
320 | } | 318 | } |
321 | cp += len + 1; | 319 | cp += len + 1; |
322 | } | 320 | } |
323 | *residual = cp; | 321 | *residual = cp; |
324 | *ret = de; | 322 | *ret = de; |
325 | out: | 323 | return 0; |
324 | } | ||
325 | |||
326 | static int xlate_proc_name(const char *name, struct proc_dir_entry **ret, | ||
327 | const char **residual) | ||
328 | { | ||
329 | int rv; | ||
330 | |||
331 | spin_lock(&proc_subdir_lock); | ||
332 | rv = __xlate_proc_name(name, ret, residual); | ||
326 | spin_unlock(&proc_subdir_lock); | 333 | spin_unlock(&proc_subdir_lock); |
327 | return rtn; | 334 | return rv; |
328 | } | 335 | } |
329 | 336 | ||
330 | static DEFINE_IDA(proc_inum_ida); | 337 | static DEFINE_IDA(proc_inum_ida); |
@@ -662,6 +669,7 @@ struct proc_dir_entry *proc_symlink(const char *name, | |||
662 | } | 669 | } |
663 | return ent; | 670 | return ent; |
664 | } | 671 | } |
672 | EXPORT_SYMBOL(proc_symlink); | ||
665 | 673 | ||
666 | struct proc_dir_entry *proc_mkdir_mode(const char *name, mode_t mode, | 674 | struct proc_dir_entry *proc_mkdir_mode(const char *name, mode_t mode, |
667 | struct proc_dir_entry *parent) | 675 | struct proc_dir_entry *parent) |
@@ -700,6 +708,7 @@ struct proc_dir_entry *proc_mkdir(const char *name, | |||
700 | { | 708 | { |
701 | return proc_mkdir_mode(name, S_IRUGO | S_IXUGO, parent); | 709 | return proc_mkdir_mode(name, S_IRUGO | S_IXUGO, parent); |
702 | } | 710 | } |
711 | EXPORT_SYMBOL(proc_mkdir); | ||
703 | 712 | ||
704 | struct proc_dir_entry *create_proc_entry(const char *name, mode_t mode, | 713 | struct proc_dir_entry *create_proc_entry(const char *name, mode_t mode, |
705 | struct proc_dir_entry *parent) | 714 | struct proc_dir_entry *parent) |
@@ -728,6 +737,7 @@ struct proc_dir_entry *create_proc_entry(const char *name, mode_t mode, | |||
728 | } | 737 | } |
729 | return ent; | 738 | return ent; |
730 | } | 739 | } |
740 | EXPORT_SYMBOL(create_proc_entry); | ||
731 | 741 | ||
732 | struct proc_dir_entry *proc_create_data(const char *name, mode_t mode, | 742 | struct proc_dir_entry *proc_create_data(const char *name, mode_t mode, |
733 | struct proc_dir_entry *parent, | 743 | struct proc_dir_entry *parent, |
@@ -762,6 +772,7 @@ out_free: | |||
762 | out: | 772 | out: |
763 | return NULL; | 773 | return NULL; |
764 | } | 774 | } |
775 | EXPORT_SYMBOL(proc_create_data); | ||
765 | 776 | ||
766 | static void free_proc_entry(struct proc_dir_entry *de) | 777 | static void free_proc_entry(struct proc_dir_entry *de) |
767 | { | 778 | { |
@@ -793,11 +804,13 @@ void remove_proc_entry(const char *name, struct proc_dir_entry *parent) | |||
793 | const char *fn = name; | 804 | const char *fn = name; |
794 | int len; | 805 | int len; |
795 | 806 | ||
796 | if (xlate_proc_name(name, &parent, &fn) != 0) | 807 | spin_lock(&proc_subdir_lock); |
808 | if (__xlate_proc_name(name, &parent, &fn) != 0) { | ||
809 | spin_unlock(&proc_subdir_lock); | ||
797 | return; | 810 | return; |
811 | } | ||
798 | len = strlen(fn); | 812 | len = strlen(fn); |
799 | 813 | ||
800 | spin_lock(&proc_subdir_lock); | ||
801 | for (p = &parent->subdir; *p; p=&(*p)->next ) { | 814 | for (p = &parent->subdir; *p; p=&(*p)->next ) { |
802 | if (proc_match(len, fn, *p)) { | 815 | if (proc_match(len, fn, *p)) { |
803 | de = *p; | 816 | de = *p; |
@@ -807,8 +820,10 @@ void remove_proc_entry(const char *name, struct proc_dir_entry *parent) | |||
807 | } | 820 | } |
808 | } | 821 | } |
809 | spin_unlock(&proc_subdir_lock); | 822 | spin_unlock(&proc_subdir_lock); |
810 | if (!de) | 823 | if (!de) { |
824 | WARN(1, "name '%s'\n", name); | ||
811 | return; | 825 | return; |
826 | } | ||
812 | 827 | ||
813 | spin_lock(&de->pde_unload_lock); | 828 | spin_lock(&de->pde_unload_lock); |
814 | /* | 829 | /* |
@@ -853,3 +868,4 @@ continue_removing: | |||
853 | de->parent->name, de->name, de->subdir->name); | 868 | de->parent->name, de->name, de->subdir->name); |
854 | pde_put(de); | 869 | pde_put(de); |
855 | } | 870 | } |
871 | EXPORT_SYMBOL(remove_proc_entry); | ||
diff --git a/fs/proc/kmsg.c b/fs/proc/kmsg.c index 7ca78346d3f0..cfe90a48a6e8 100644 --- a/fs/proc/kmsg.c +++ b/fs/proc/kmsg.c | |||
@@ -12,37 +12,37 @@ | |||
12 | #include <linux/poll.h> | 12 | #include <linux/poll.h> |
13 | #include <linux/proc_fs.h> | 13 | #include <linux/proc_fs.h> |
14 | #include <linux/fs.h> | 14 | #include <linux/fs.h> |
15 | #include <linux/syslog.h> | ||
15 | 16 | ||
16 | #include <asm/uaccess.h> | 17 | #include <asm/uaccess.h> |
17 | #include <asm/io.h> | 18 | #include <asm/io.h> |
18 | 19 | ||
19 | extern wait_queue_head_t log_wait; | 20 | extern wait_queue_head_t log_wait; |
20 | 21 | ||
21 | extern int do_syslog(int type, char __user *bug, int count); | ||
22 | |||
23 | static int kmsg_open(struct inode * inode, struct file * file) | 22 | static int kmsg_open(struct inode * inode, struct file * file) |
24 | { | 23 | { |
25 | return do_syslog(1,NULL,0); | 24 | return do_syslog(SYSLOG_ACTION_OPEN, NULL, 0, SYSLOG_FROM_FILE); |
26 | } | 25 | } |
27 | 26 | ||
28 | static int kmsg_release(struct inode * inode, struct file * file) | 27 | static int kmsg_release(struct inode * inode, struct file * file) |
29 | { | 28 | { |
30 | (void) do_syslog(0,NULL,0); | 29 | (void) do_syslog(SYSLOG_ACTION_CLOSE, NULL, 0, SYSLOG_FROM_FILE); |
31 | return 0; | 30 | return 0; |
32 | } | 31 | } |
33 | 32 | ||
34 | static ssize_t kmsg_read(struct file *file, char __user *buf, | 33 | static ssize_t kmsg_read(struct file *file, char __user *buf, |
35 | size_t count, loff_t *ppos) | 34 | size_t count, loff_t *ppos) |
36 | { | 35 | { |
37 | if ((file->f_flags & O_NONBLOCK) && !do_syslog(9, NULL, 0)) | 36 | if ((file->f_flags & O_NONBLOCK) && |
37 | !do_syslog(SYSLOG_ACTION_SIZE_UNREAD, NULL, 0, SYSLOG_FROM_FILE)) | ||
38 | return -EAGAIN; | 38 | return -EAGAIN; |
39 | return do_syslog(2, buf, count); | 39 | return do_syslog(SYSLOG_ACTION_READ, buf, count, SYSLOG_FROM_FILE); |
40 | } | 40 | } |
41 | 41 | ||
42 | static unsigned int kmsg_poll(struct file *file, poll_table *wait) | 42 | static unsigned int kmsg_poll(struct file *file, poll_table *wait) |
43 | { | 43 | { |
44 | poll_wait(file, &log_wait, wait); | 44 | poll_wait(file, &log_wait, wait); |
45 | if (do_syslog(9, NULL, 0)) | 45 | if (do_syslog(SYSLOG_ACTION_SIZE_UNREAD, NULL, 0, SYSLOG_FROM_FILE)) |
46 | return POLLIN | POLLRDNORM; | 46 | return POLLIN | POLLRDNORM; |
47 | return 0; | 47 | return 0; |
48 | } | 48 | } |
diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c index 123257bb356b..f8650dce74fb 100644 --- a/fs/proc/proc_devtree.c +++ b/fs/proc/proc_devtree.c | |||
@@ -10,16 +10,19 @@ | |||
10 | #include <linux/seq_file.h> | 10 | #include <linux/seq_file.h> |
11 | #include <linux/stat.h> | 11 | #include <linux/stat.h> |
12 | #include <linux/string.h> | 12 | #include <linux/string.h> |
13 | #include <linux/of.h> | ||
14 | #include <linux/module.h> | ||
13 | #include <asm/prom.h> | 15 | #include <asm/prom.h> |
14 | #include <asm/uaccess.h> | 16 | #include <asm/uaccess.h> |
15 | #include "internal.h" | 17 | #include "internal.h" |
16 | 18 | ||
17 | #ifndef HAVE_ARCH_DEVTREE_FIXUPS | ||
18 | static inline void set_node_proc_entry(struct device_node *np, | 19 | static inline void set_node_proc_entry(struct device_node *np, |
19 | struct proc_dir_entry *de) | 20 | struct proc_dir_entry *de) |
20 | { | 21 | { |
21 | } | 22 | #ifdef HAVE_ARCH_DEVTREE_FIXUPS |
23 | np->pde = de; | ||
22 | #endif | 24 | #endif |
25 | } | ||
23 | 26 | ||
24 | static struct proc_dir_entry *proc_device_tree; | 27 | static struct proc_dir_entry *proc_device_tree; |
25 | 28 | ||
diff --git a/fs/proc/root.c b/fs/proc/root.c index b080b791d9e3..757c069f2a65 100644 --- a/fs/proc/root.c +++ b/fs/proc/root.c | |||
@@ -220,9 +220,3 @@ void pid_ns_release_proc(struct pid_namespace *ns) | |||
220 | { | 220 | { |
221 | mntput(ns->proc_mnt); | 221 | mntput(ns->proc_mnt); |
222 | } | 222 | } |
223 | |||
224 | EXPORT_SYMBOL(proc_symlink); | ||
225 | EXPORT_SYMBOL(proc_mkdir); | ||
226 | EXPORT_SYMBOL(create_proc_entry); | ||
227 | EXPORT_SYMBOL(proc_create_data); | ||
228 | EXPORT_SYMBOL(remove_proc_entry); | ||
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index f277c4a111cb..183f8ff5f400 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c | |||
@@ -16,7 +16,7 @@ | |||
16 | 16 | ||
17 | void task_mem(struct seq_file *m, struct mm_struct *mm) | 17 | void task_mem(struct seq_file *m, struct mm_struct *mm) |
18 | { | 18 | { |
19 | unsigned long data, text, lib; | 19 | unsigned long data, text, lib, swap; |
20 | unsigned long hiwater_vm, total_vm, hiwater_rss, total_rss; | 20 | unsigned long hiwater_vm, total_vm, hiwater_rss, total_rss; |
21 | 21 | ||
22 | /* | 22 | /* |
@@ -36,6 +36,7 @@ void task_mem(struct seq_file *m, struct mm_struct *mm) | |||
36 | data = mm->total_vm - mm->shared_vm - mm->stack_vm; | 36 | data = mm->total_vm - mm->shared_vm - mm->stack_vm; |
37 | text = (PAGE_ALIGN(mm->end_code) - (mm->start_code & PAGE_MASK)) >> 10; | 37 | text = (PAGE_ALIGN(mm->end_code) - (mm->start_code & PAGE_MASK)) >> 10; |
38 | lib = (mm->exec_vm << (PAGE_SHIFT-10)) - text; | 38 | lib = (mm->exec_vm << (PAGE_SHIFT-10)) - text; |
39 | swap = get_mm_counter(mm, MM_SWAPENTS); | ||
39 | seq_printf(m, | 40 | seq_printf(m, |
40 | "VmPeak:\t%8lu kB\n" | 41 | "VmPeak:\t%8lu kB\n" |
41 | "VmSize:\t%8lu kB\n" | 42 | "VmSize:\t%8lu kB\n" |
@@ -46,7 +47,8 @@ void task_mem(struct seq_file *m, struct mm_struct *mm) | |||
46 | "VmStk:\t%8lu kB\n" | 47 | "VmStk:\t%8lu kB\n" |
47 | "VmExe:\t%8lu kB\n" | 48 | "VmExe:\t%8lu kB\n" |
48 | "VmLib:\t%8lu kB\n" | 49 | "VmLib:\t%8lu kB\n" |
49 | "VmPTE:\t%8lu kB\n", | 50 | "VmPTE:\t%8lu kB\n" |
51 | "VmSwap:\t%8lu kB\n", | ||
50 | hiwater_vm << (PAGE_SHIFT-10), | 52 | hiwater_vm << (PAGE_SHIFT-10), |
51 | (total_vm - mm->reserved_vm) << (PAGE_SHIFT-10), | 53 | (total_vm - mm->reserved_vm) << (PAGE_SHIFT-10), |
52 | mm->locked_vm << (PAGE_SHIFT-10), | 54 | mm->locked_vm << (PAGE_SHIFT-10), |
@@ -54,7 +56,8 @@ void task_mem(struct seq_file *m, struct mm_struct *mm) | |||
54 | total_rss << (PAGE_SHIFT-10), | 56 | total_rss << (PAGE_SHIFT-10), |
55 | data << (PAGE_SHIFT-10), | 57 | data << (PAGE_SHIFT-10), |
56 | mm->stack_vm << (PAGE_SHIFT-10), text, lib, | 58 | mm->stack_vm << (PAGE_SHIFT-10), text, lib, |
57 | (PTRS_PER_PTE*sizeof(pte_t)*mm->nr_ptes) >> 10); | 59 | (PTRS_PER_PTE*sizeof(pte_t)*mm->nr_ptes) >> 10, |
60 | swap << (PAGE_SHIFT-10)); | ||
58 | } | 61 | } |
59 | 62 | ||
60 | unsigned long task_vsize(struct mm_struct *mm) | 63 | unsigned long task_vsize(struct mm_struct *mm) |
@@ -65,11 +68,11 @@ unsigned long task_vsize(struct mm_struct *mm) | |||
65 | int task_statm(struct mm_struct *mm, int *shared, int *text, | 68 | int task_statm(struct mm_struct *mm, int *shared, int *text, |
66 | int *data, int *resident) | 69 | int *data, int *resident) |
67 | { | 70 | { |
68 | *shared = get_mm_counter(mm, file_rss); | 71 | *shared = get_mm_counter(mm, MM_FILEPAGES); |
69 | *text = (PAGE_ALIGN(mm->end_code) - (mm->start_code & PAGE_MASK)) | 72 | *text = (PAGE_ALIGN(mm->end_code) - (mm->start_code & PAGE_MASK)) |
70 | >> PAGE_SHIFT; | 73 | >> PAGE_SHIFT; |
71 | *data = mm->total_vm - mm->shared_vm; | 74 | *data = mm->total_vm - mm->shared_vm; |
72 | *resident = *shared + get_mm_counter(mm, anon_rss); | 75 | *resident = *shared + get_mm_counter(mm, MM_ANONPAGES); |
73 | return mm->total_vm; | 76 | return mm->total_vm; |
74 | } | 77 | } |
75 | 78 | ||
diff --git a/fs/quota/Kconfig b/fs/quota/Kconfig index efc02ebb8c70..dad7fb247ddc 100644 --- a/fs/quota/Kconfig +++ b/fs/quota/Kconfig | |||
@@ -59,3 +59,8 @@ config QUOTACTL | |||
59 | bool | 59 | bool |
60 | depends on XFS_QUOTA || QUOTA | 60 | depends on XFS_QUOTA || QUOTA |
61 | default y | 61 | default y |
62 | |||
63 | config QUOTACTL_COMPAT | ||
64 | bool | ||
65 | depends on QUOTACTL && COMPAT_FOR_U64_ALIGNMENT | ||
66 | default y | ||
diff --git a/fs/quota/Makefile b/fs/quota/Makefile index 68d4f6dc0578..5f9e9e276af0 100644 --- a/fs/quota/Makefile +++ b/fs/quota/Makefile | |||
@@ -3,3 +3,5 @@ obj-$(CONFIG_QFMT_V1) += quota_v1.o | |||
3 | obj-$(CONFIG_QFMT_V2) += quota_v2.o | 3 | obj-$(CONFIG_QFMT_V2) += quota_v2.o |
4 | obj-$(CONFIG_QUOTA_TREE) += quota_tree.o | 4 | obj-$(CONFIG_QUOTA_TREE) += quota_tree.o |
5 | obj-$(CONFIG_QUOTACTL) += quota.o | 5 | obj-$(CONFIG_QUOTACTL) += quota.o |
6 | obj-$(CONFIG_QUOTACTL_COMPAT) += compat.o | ||
7 | obj-$(CONFIG_QUOTA_NETLINK_INTERFACE) += netlink.o | ||
diff --git a/fs/quota/compat.c b/fs/quota/compat.c new file mode 100644 index 000000000000..fb1892fe3e56 --- /dev/null +++ b/fs/quota/compat.c | |||
@@ -0,0 +1,118 @@ | |||
1 | |||
2 | #include <linux/syscalls.h> | ||
3 | #include <linux/compat.h> | ||
4 | #include <linux/quotaops.h> | ||
5 | |||
6 | /* | ||
7 | * This code works only for 32 bit quota tools over 64 bit OS (x86_64, ia64) | ||
8 | * and is necessary due to alignment problems. | ||
9 | */ | ||
10 | struct compat_if_dqblk { | ||
11 | compat_u64 dqb_bhardlimit; | ||
12 | compat_u64 dqb_bsoftlimit; | ||
13 | compat_u64 dqb_curspace; | ||
14 | compat_u64 dqb_ihardlimit; | ||
15 | compat_u64 dqb_isoftlimit; | ||
16 | compat_u64 dqb_curinodes; | ||
17 | compat_u64 dqb_btime; | ||
18 | compat_u64 dqb_itime; | ||
19 | compat_uint_t dqb_valid; | ||
20 | }; | ||
21 | |||
22 | /* XFS structures */ | ||
23 | struct compat_fs_qfilestat { | ||
24 | compat_u64 dqb_bhardlimit; | ||
25 | compat_u64 qfs_nblks; | ||
26 | compat_uint_t qfs_nextents; | ||
27 | }; | ||
28 | |||
29 | struct compat_fs_quota_stat { | ||
30 | __s8 qs_version; | ||
31 | __u16 qs_flags; | ||
32 | __s8 qs_pad; | ||
33 | struct compat_fs_qfilestat qs_uquota; | ||
34 | struct compat_fs_qfilestat qs_gquota; | ||
35 | compat_uint_t qs_incoredqs; | ||
36 | compat_int_t qs_btimelimit; | ||
37 | compat_int_t qs_itimelimit; | ||
38 | compat_int_t qs_rtbtimelimit; | ||
39 | __u16 qs_bwarnlimit; | ||
40 | __u16 qs_iwarnlimit; | ||
41 | }; | ||
42 | |||
43 | asmlinkage long sys32_quotactl(unsigned int cmd, const char __user *special, | ||
44 | qid_t id, void __user *addr) | ||
45 | { | ||
46 | unsigned int cmds; | ||
47 | struct if_dqblk __user *dqblk; | ||
48 | struct compat_if_dqblk __user *compat_dqblk; | ||
49 | struct fs_quota_stat __user *fsqstat; | ||
50 | struct compat_fs_quota_stat __user *compat_fsqstat; | ||
51 | compat_uint_t data; | ||
52 | u16 xdata; | ||
53 | long ret; | ||
54 | |||
55 | cmds = cmd >> SUBCMDSHIFT; | ||
56 | |||
57 | switch (cmds) { | ||
58 | case Q_GETQUOTA: | ||
59 | dqblk = compat_alloc_user_space(sizeof(struct if_dqblk)); | ||
60 | compat_dqblk = addr; | ||
61 | ret = sys_quotactl(cmd, special, id, dqblk); | ||
62 | if (ret) | ||
63 | break; | ||
64 | if (copy_in_user(compat_dqblk, dqblk, sizeof(*compat_dqblk)) || | ||
65 | get_user(data, &dqblk->dqb_valid) || | ||
66 | put_user(data, &compat_dqblk->dqb_valid)) | ||
67 | ret = -EFAULT; | ||
68 | break; | ||
69 | case Q_SETQUOTA: | ||
70 | dqblk = compat_alloc_user_space(sizeof(struct if_dqblk)); | ||
71 | compat_dqblk = addr; | ||
72 | ret = -EFAULT; | ||
73 | if (copy_in_user(dqblk, compat_dqblk, sizeof(*compat_dqblk)) || | ||
74 | get_user(data, &compat_dqblk->dqb_valid) || | ||
75 | put_user(data, &dqblk->dqb_valid)) | ||
76 | break; | ||
77 | ret = sys_quotactl(cmd, special, id, dqblk); | ||
78 | break; | ||
79 | case Q_XGETQSTAT: | ||
80 | fsqstat = compat_alloc_user_space(sizeof(struct fs_quota_stat)); | ||
81 | compat_fsqstat = addr; | ||
82 | ret = sys_quotactl(cmd, special, id, fsqstat); | ||
83 | if (ret) | ||
84 | break; | ||
85 | ret = -EFAULT; | ||
86 | /* Copying qs_version, qs_flags, qs_pad */ | ||
87 | if (copy_in_user(compat_fsqstat, fsqstat, | ||
88 | offsetof(struct compat_fs_quota_stat, qs_uquota))) | ||
89 | break; | ||
90 | /* Copying qs_uquota */ | ||
91 | if (copy_in_user(&compat_fsqstat->qs_uquota, | ||
92 | &fsqstat->qs_uquota, | ||
93 | sizeof(compat_fsqstat->qs_uquota)) || | ||
94 | get_user(data, &fsqstat->qs_uquota.qfs_nextents) || | ||
95 | put_user(data, &compat_fsqstat->qs_uquota.qfs_nextents)) | ||
96 | break; | ||
97 | /* Copying qs_gquota */ | ||
98 | if (copy_in_user(&compat_fsqstat->qs_gquota, | ||
99 | &fsqstat->qs_gquota, | ||
100 | sizeof(compat_fsqstat->qs_gquota)) || | ||
101 | get_user(data, &fsqstat->qs_gquota.qfs_nextents) || | ||
102 | put_user(data, &compat_fsqstat->qs_gquota.qfs_nextents)) | ||
103 | break; | ||
104 | /* Copying the rest */ | ||
105 | if (copy_in_user(&compat_fsqstat->qs_incoredqs, | ||
106 | &fsqstat->qs_incoredqs, | ||
107 | sizeof(struct compat_fs_quota_stat) - | ||
108 | offsetof(struct compat_fs_quota_stat, qs_incoredqs)) || | ||
109 | get_user(xdata, &fsqstat->qs_iwarnlimit) || | ||
110 | put_user(xdata, &compat_fsqstat->qs_iwarnlimit)) | ||
111 | break; | ||
112 | ret = 0; | ||
113 | break; | ||
114 | default: | ||
115 | ret = sys_quotactl(cmd, special, id, addr); | ||
116 | } | ||
117 | return ret; | ||
118 | } | ||
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index 3fc62b097bed..e0b870f4749f 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c | |||
@@ -100,9 +100,13 @@ | |||
100 | * | 100 | * |
101 | * Any operation working on dquots via inode pointers must hold dqptr_sem. If | 101 | * Any operation working on dquots via inode pointers must hold dqptr_sem. If |
102 | * operation is just reading pointers from inode (or not using them at all) the | 102 | * operation is just reading pointers from inode (or not using them at all) the |
103 | * read lock is enough. If pointers are altered function must hold write lock | 103 | * read lock is enough. If pointers are altered function must hold write lock. |
104 | * (these locking rules also apply for S_NOQUOTA flag in the inode - note that | 104 | * Special care needs to be taken about S_NOQUOTA inode flag (marking that |
105 | * for altering the flag i_mutex is also needed). | 105 | * inode is a quota file). Functions adding pointers from inode to dquots have |
106 | * to check this flag under dqptr_sem and then (if S_NOQUOTA is not set) they | ||
107 | * have to do all pointer modifications before dropping dqptr_sem. This makes | ||
108 | * sure they cannot race with quotaon which first sets S_NOQUOTA flag and | ||
109 | * then drops all pointers to dquots from an inode. | ||
106 | * | 110 | * |
107 | * Each dquot has its dq_lock mutex. Locked dquots might not be referenced | 111 | * Each dquot has its dq_lock mutex. Locked dquots might not be referenced |
108 | * from inodes (dquot_alloc_space() and such don't check the dq_lock). | 112 | * from inodes (dquot_alloc_space() and such don't check the dq_lock). |
@@ -225,6 +229,9 @@ static struct hlist_head *dquot_hash; | |||
225 | struct dqstats dqstats; | 229 | struct dqstats dqstats; |
226 | EXPORT_SYMBOL(dqstats); | 230 | EXPORT_SYMBOL(dqstats); |
227 | 231 | ||
232 | static qsize_t inode_get_rsv_space(struct inode *inode); | ||
233 | static void __dquot_initialize(struct inode *inode, int type); | ||
234 | |||
228 | static inline unsigned int | 235 | static inline unsigned int |
229 | hashfn(const struct super_block *sb, unsigned int id, int type) | 236 | hashfn(const struct super_block *sb, unsigned int id, int type) |
230 | { | 237 | { |
@@ -564,7 +571,7 @@ out: | |||
564 | } | 571 | } |
565 | EXPORT_SYMBOL(dquot_scan_active); | 572 | EXPORT_SYMBOL(dquot_scan_active); |
566 | 573 | ||
567 | int vfs_quota_sync(struct super_block *sb, int type) | 574 | int vfs_quota_sync(struct super_block *sb, int type, int wait) |
568 | { | 575 | { |
569 | struct list_head *dirty; | 576 | struct list_head *dirty; |
570 | struct dquot *dquot; | 577 | struct dquot *dquot; |
@@ -609,6 +616,33 @@ int vfs_quota_sync(struct super_block *sb, int type) | |||
609 | spin_unlock(&dq_list_lock); | 616 | spin_unlock(&dq_list_lock); |
610 | mutex_unlock(&dqopt->dqonoff_mutex); | 617 | mutex_unlock(&dqopt->dqonoff_mutex); |
611 | 618 | ||
619 | if (!wait || (sb_dqopt(sb)->flags & DQUOT_QUOTA_SYS_FILE)) | ||
620 | return 0; | ||
621 | |||
622 | /* This is not very clever (and fast) but currently I don't know about | ||
623 | * any other simple way of getting quota data to disk and we must get | ||
624 | * them there for userspace to be visible... */ | ||
625 | if (sb->s_op->sync_fs) | ||
626 | sb->s_op->sync_fs(sb, 1); | ||
627 | sync_blockdev(sb->s_bdev); | ||
628 | |||
629 | /* | ||
630 | * Now when everything is written we can discard the pagecache so | ||
631 | * that userspace sees the changes. | ||
632 | */ | ||
633 | mutex_lock(&sb_dqopt(sb)->dqonoff_mutex); | ||
634 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | ||
635 | if (type != -1 && cnt != type) | ||
636 | continue; | ||
637 | if (!sb_has_quota_active(sb, cnt)) | ||
638 | continue; | ||
639 | mutex_lock_nested(&sb_dqopt(sb)->files[cnt]->i_mutex, | ||
640 | I_MUTEX_QUOTA); | ||
641 | truncate_inode_pages(&sb_dqopt(sb)->files[cnt]->i_data, 0); | ||
642 | mutex_unlock(&sb_dqopt(sb)->files[cnt]->i_mutex); | ||
643 | } | ||
644 | mutex_unlock(&sb_dqopt(sb)->dqonoff_mutex); | ||
645 | |||
612 | return 0; | 646 | return 0; |
613 | } | 647 | } |
614 | EXPORT_SYMBOL(vfs_quota_sync); | 648 | EXPORT_SYMBOL(vfs_quota_sync); |
@@ -840,11 +874,14 @@ static int dqinit_needed(struct inode *inode, int type) | |||
840 | static void add_dquot_ref(struct super_block *sb, int type) | 874 | static void add_dquot_ref(struct super_block *sb, int type) |
841 | { | 875 | { |
842 | struct inode *inode, *old_inode = NULL; | 876 | struct inode *inode, *old_inode = NULL; |
877 | int reserved = 0; | ||
843 | 878 | ||
844 | spin_lock(&inode_lock); | 879 | spin_lock(&inode_lock); |
845 | list_for_each_entry(inode, &sb->s_inodes, i_sb_list) { | 880 | list_for_each_entry(inode, &sb->s_inodes, i_sb_list) { |
846 | if (inode->i_state & (I_FREEING|I_CLEAR|I_WILL_FREE|I_NEW)) | 881 | if (inode->i_state & (I_FREEING|I_CLEAR|I_WILL_FREE|I_NEW)) |
847 | continue; | 882 | continue; |
883 | if (unlikely(inode_get_rsv_space(inode) > 0)) | ||
884 | reserved = 1; | ||
848 | if (!atomic_read(&inode->i_writecount)) | 885 | if (!atomic_read(&inode->i_writecount)) |
849 | continue; | 886 | continue; |
850 | if (!dqinit_needed(inode, type)) | 887 | if (!dqinit_needed(inode, type)) |
@@ -854,7 +891,7 @@ static void add_dquot_ref(struct super_block *sb, int type) | |||
854 | spin_unlock(&inode_lock); | 891 | spin_unlock(&inode_lock); |
855 | 892 | ||
856 | iput(old_inode); | 893 | iput(old_inode); |
857 | sb->dq_op->initialize(inode, type); | 894 | __dquot_initialize(inode, type); |
858 | /* We hold a reference to 'inode' so it couldn't have been | 895 | /* We hold a reference to 'inode' so it couldn't have been |
859 | * removed from s_inodes list while we dropped the inode_lock. | 896 | * removed from s_inodes list while we dropped the inode_lock. |
860 | * We cannot iput the inode now as we can be holding the last | 897 | * We cannot iput the inode now as we can be holding the last |
@@ -865,6 +902,12 @@ static void add_dquot_ref(struct super_block *sb, int type) | |||
865 | } | 902 | } |
866 | spin_unlock(&inode_lock); | 903 | spin_unlock(&inode_lock); |
867 | iput(old_inode); | 904 | iput(old_inode); |
905 | |||
906 | if (reserved) { | ||
907 | printk(KERN_WARNING "VFS (%s): Writes happened before quota" | ||
908 | " was turned on thus quota information is probably " | ||
909 | "inconsistent. Please run quotacheck(8).\n", sb->s_id); | ||
910 | } | ||
868 | } | 911 | } |
869 | 912 | ||
870 | /* | 913 | /* |
@@ -978,10 +1021,12 @@ static inline void dquot_resv_space(struct dquot *dquot, qsize_t number) | |||
978 | /* | 1021 | /* |
979 | * Claim reserved quota space | 1022 | * Claim reserved quota space |
980 | */ | 1023 | */ |
981 | static void dquot_claim_reserved_space(struct dquot *dquot, | 1024 | static void dquot_claim_reserved_space(struct dquot *dquot, qsize_t number) |
982 | qsize_t number) | ||
983 | { | 1025 | { |
984 | WARN_ON(dquot->dq_dqb.dqb_rsvspace < number); | 1026 | if (dquot->dq_dqb.dqb_rsvspace < number) { |
1027 | WARN_ON_ONCE(1); | ||
1028 | number = dquot->dq_dqb.dqb_rsvspace; | ||
1029 | } | ||
985 | dquot->dq_dqb.dqb_curspace += number; | 1030 | dquot->dq_dqb.dqb_curspace += number; |
986 | dquot->dq_dqb.dqb_rsvspace -= number; | 1031 | dquot->dq_dqb.dqb_rsvspace -= number; |
987 | } | 1032 | } |
@@ -989,7 +1034,12 @@ static void dquot_claim_reserved_space(struct dquot *dquot, | |||
989 | static inline | 1034 | static inline |
990 | void dquot_free_reserved_space(struct dquot *dquot, qsize_t number) | 1035 | void dquot_free_reserved_space(struct dquot *dquot, qsize_t number) |
991 | { | 1036 | { |
992 | dquot->dq_dqb.dqb_rsvspace -= number; | 1037 | if (dquot->dq_dqb.dqb_rsvspace >= number) |
1038 | dquot->dq_dqb.dqb_rsvspace -= number; | ||
1039 | else { | ||
1040 | WARN_ON_ONCE(1); | ||
1041 | dquot->dq_dqb.dqb_rsvspace = 0; | ||
1042 | } | ||
993 | } | 1043 | } |
994 | 1044 | ||
995 | static void dquot_decr_inodes(struct dquot *dquot, qsize_t number) | 1045 | static void dquot_decr_inodes(struct dquot *dquot, qsize_t number) |
@@ -1131,13 +1181,13 @@ static int check_idq(struct dquot *dquot, qsize_t inodes, char *warntype) | |||
1131 | *warntype = QUOTA_NL_NOWARN; | 1181 | *warntype = QUOTA_NL_NOWARN; |
1132 | if (!sb_has_quota_limits_enabled(dquot->dq_sb, dquot->dq_type) || | 1182 | if (!sb_has_quota_limits_enabled(dquot->dq_sb, dquot->dq_type) || |
1133 | test_bit(DQ_FAKE_B, &dquot->dq_flags)) | 1183 | test_bit(DQ_FAKE_B, &dquot->dq_flags)) |
1134 | return QUOTA_OK; | 1184 | return 0; |
1135 | 1185 | ||
1136 | if (dquot->dq_dqb.dqb_ihardlimit && | 1186 | if (dquot->dq_dqb.dqb_ihardlimit && |
1137 | newinodes > dquot->dq_dqb.dqb_ihardlimit && | 1187 | newinodes > dquot->dq_dqb.dqb_ihardlimit && |
1138 | !ignore_hardlimit(dquot)) { | 1188 | !ignore_hardlimit(dquot)) { |
1139 | *warntype = QUOTA_NL_IHARDWARN; | 1189 | *warntype = QUOTA_NL_IHARDWARN; |
1140 | return NO_QUOTA; | 1190 | return -EDQUOT; |
1141 | } | 1191 | } |
1142 | 1192 | ||
1143 | if (dquot->dq_dqb.dqb_isoftlimit && | 1193 | if (dquot->dq_dqb.dqb_isoftlimit && |
@@ -1146,7 +1196,7 @@ static int check_idq(struct dquot *dquot, qsize_t inodes, char *warntype) | |||
1146 | get_seconds() >= dquot->dq_dqb.dqb_itime && | 1196 | get_seconds() >= dquot->dq_dqb.dqb_itime && |
1147 | !ignore_hardlimit(dquot)) { | 1197 | !ignore_hardlimit(dquot)) { |
1148 | *warntype = QUOTA_NL_ISOFTLONGWARN; | 1198 | *warntype = QUOTA_NL_ISOFTLONGWARN; |
1149 | return NO_QUOTA; | 1199 | return -EDQUOT; |
1150 | } | 1200 | } |
1151 | 1201 | ||
1152 | if (dquot->dq_dqb.dqb_isoftlimit && | 1202 | if (dquot->dq_dqb.dqb_isoftlimit && |
@@ -1157,7 +1207,7 @@ static int check_idq(struct dquot *dquot, qsize_t inodes, char *warntype) | |||
1157 | sb_dqopt(dquot->dq_sb)->info[dquot->dq_type].dqi_igrace; | 1207 | sb_dqopt(dquot->dq_sb)->info[dquot->dq_type].dqi_igrace; |
1158 | } | 1208 | } |
1159 | 1209 | ||
1160 | return QUOTA_OK; | 1210 | return 0; |
1161 | } | 1211 | } |
1162 | 1212 | ||
1163 | /* needs dq_data_lock */ | 1213 | /* needs dq_data_lock */ |
@@ -1169,7 +1219,7 @@ static int check_bdq(struct dquot *dquot, qsize_t space, int prealloc, char *war | |||
1169 | *warntype = QUOTA_NL_NOWARN; | 1219 | *warntype = QUOTA_NL_NOWARN; |
1170 | if (!sb_has_quota_limits_enabled(sb, dquot->dq_type) || | 1220 | if (!sb_has_quota_limits_enabled(sb, dquot->dq_type) || |
1171 | test_bit(DQ_FAKE_B, &dquot->dq_flags)) | 1221 | test_bit(DQ_FAKE_B, &dquot->dq_flags)) |
1172 | return QUOTA_OK; | 1222 | return 0; |
1173 | 1223 | ||
1174 | tspace = dquot->dq_dqb.dqb_curspace + dquot->dq_dqb.dqb_rsvspace | 1224 | tspace = dquot->dq_dqb.dqb_curspace + dquot->dq_dqb.dqb_rsvspace |
1175 | + space; | 1225 | + space; |
@@ -1179,7 +1229,7 @@ static int check_bdq(struct dquot *dquot, qsize_t space, int prealloc, char *war | |||
1179 | !ignore_hardlimit(dquot)) { | 1229 | !ignore_hardlimit(dquot)) { |
1180 | if (!prealloc) | 1230 | if (!prealloc) |
1181 | *warntype = QUOTA_NL_BHARDWARN; | 1231 | *warntype = QUOTA_NL_BHARDWARN; |
1182 | return NO_QUOTA; | 1232 | return -EDQUOT; |
1183 | } | 1233 | } |
1184 | 1234 | ||
1185 | if (dquot->dq_dqb.dqb_bsoftlimit && | 1235 | if (dquot->dq_dqb.dqb_bsoftlimit && |
@@ -1189,7 +1239,7 @@ static int check_bdq(struct dquot *dquot, qsize_t space, int prealloc, char *war | |||
1189 | !ignore_hardlimit(dquot)) { | 1239 | !ignore_hardlimit(dquot)) { |
1190 | if (!prealloc) | 1240 | if (!prealloc) |
1191 | *warntype = QUOTA_NL_BSOFTLONGWARN; | 1241 | *warntype = QUOTA_NL_BSOFTLONGWARN; |
1192 | return NO_QUOTA; | 1242 | return -EDQUOT; |
1193 | } | 1243 | } |
1194 | 1244 | ||
1195 | if (dquot->dq_dqb.dqb_bsoftlimit && | 1245 | if (dquot->dq_dqb.dqb_bsoftlimit && |
@@ -1205,10 +1255,10 @@ static int check_bdq(struct dquot *dquot, qsize_t space, int prealloc, char *war | |||
1205 | * We don't allow preallocation to exceed softlimit so exceeding will | 1255 | * We don't allow preallocation to exceed softlimit so exceeding will |
1206 | * be always printed | 1256 | * be always printed |
1207 | */ | 1257 | */ |
1208 | return NO_QUOTA; | 1258 | return -EDQUOT; |
1209 | } | 1259 | } |
1210 | 1260 | ||
1211 | return QUOTA_OK; | 1261 | return 0; |
1212 | } | 1262 | } |
1213 | 1263 | ||
1214 | static int info_idq_free(struct dquot *dquot, qsize_t inodes) | 1264 | static int info_idq_free(struct dquot *dquot, qsize_t inodes) |
@@ -1242,25 +1292,32 @@ static int info_bdq_free(struct dquot *dquot, qsize_t space) | |||
1242 | return QUOTA_NL_BHARDBELOW; | 1292 | return QUOTA_NL_BHARDBELOW; |
1243 | return QUOTA_NL_NOWARN; | 1293 | return QUOTA_NL_NOWARN; |
1244 | } | 1294 | } |
1295 | |||
1245 | /* | 1296 | /* |
1246 | * Initialize quota pointers in inode | 1297 | * Initialize quota pointers in inode |
1247 | * We do things in a bit complicated way but by that we avoid calling | 1298 | * |
1248 | * dqget() and thus filesystem callbacks under dqptr_sem. | 1299 | * We do things in a bit complicated way but by that we avoid calling |
1300 | * dqget() and thus filesystem callbacks under dqptr_sem. | ||
1301 | * | ||
1302 | * It is better to call this function outside of any transaction as it | ||
1303 | * might need a lot of space in journal for dquot structure allocation. | ||
1249 | */ | 1304 | */ |
1250 | int dquot_initialize(struct inode *inode, int type) | 1305 | static void __dquot_initialize(struct inode *inode, int type) |
1251 | { | 1306 | { |
1252 | unsigned int id = 0; | 1307 | unsigned int id = 0; |
1253 | int cnt, ret = 0; | 1308 | int cnt; |
1254 | struct dquot *got[MAXQUOTAS] = { NULL, NULL }; | 1309 | struct dquot *got[MAXQUOTAS]; |
1255 | struct super_block *sb = inode->i_sb; | 1310 | struct super_block *sb = inode->i_sb; |
1311 | qsize_t rsv; | ||
1256 | 1312 | ||
1257 | /* First test before acquiring mutex - solves deadlocks when we | 1313 | /* First test before acquiring mutex - solves deadlocks when we |
1258 | * re-enter the quota code and are already holding the mutex */ | 1314 | * re-enter the quota code and are already holding the mutex */ |
1259 | if (IS_NOQUOTA(inode)) | 1315 | if (!sb_any_quota_active(inode->i_sb) || IS_NOQUOTA(inode)) |
1260 | return 0; | 1316 | return; |
1261 | 1317 | ||
1262 | /* First get references to structures we might need. */ | 1318 | /* First get references to structures we might need. */ |
1263 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1319 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1320 | got[cnt] = NULL; | ||
1264 | if (type != -1 && cnt != type) | 1321 | if (type != -1 && cnt != type) |
1265 | continue; | 1322 | continue; |
1266 | switch (cnt) { | 1323 | switch (cnt) { |
@@ -1275,7 +1332,6 @@ int dquot_initialize(struct inode *inode, int type) | |||
1275 | } | 1332 | } |
1276 | 1333 | ||
1277 | down_write(&sb_dqopt(sb)->dqptr_sem); | 1334 | down_write(&sb_dqopt(sb)->dqptr_sem); |
1278 | /* Having dqptr_sem we know NOQUOTA flags can't be altered... */ | ||
1279 | if (IS_NOQUOTA(inode)) | 1335 | if (IS_NOQUOTA(inode)) |
1280 | goto out_err; | 1336 | goto out_err; |
1281 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1337 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
@@ -1287,20 +1343,31 @@ int dquot_initialize(struct inode *inode, int type) | |||
1287 | if (!inode->i_dquot[cnt]) { | 1343 | if (!inode->i_dquot[cnt]) { |
1288 | inode->i_dquot[cnt] = got[cnt]; | 1344 | inode->i_dquot[cnt] = got[cnt]; |
1289 | got[cnt] = NULL; | 1345 | got[cnt] = NULL; |
1346 | /* | ||
1347 | * Make quota reservation system happy if someone | ||
1348 | * did a write before quota was turned on | ||
1349 | */ | ||
1350 | rsv = inode_get_rsv_space(inode); | ||
1351 | if (unlikely(rsv)) | ||
1352 | dquot_resv_space(inode->i_dquot[cnt], rsv); | ||
1290 | } | 1353 | } |
1291 | } | 1354 | } |
1292 | out_err: | 1355 | out_err: |
1293 | up_write(&sb_dqopt(sb)->dqptr_sem); | 1356 | up_write(&sb_dqopt(sb)->dqptr_sem); |
1294 | /* Drop unused references */ | 1357 | /* Drop unused references */ |
1295 | dqput_all(got); | 1358 | dqput_all(got); |
1296 | return ret; | 1359 | } |
1360 | |||
1361 | void dquot_initialize(struct inode *inode) | ||
1362 | { | ||
1363 | __dquot_initialize(inode, -1); | ||
1297 | } | 1364 | } |
1298 | EXPORT_SYMBOL(dquot_initialize); | 1365 | EXPORT_SYMBOL(dquot_initialize); |
1299 | 1366 | ||
1300 | /* | 1367 | /* |
1301 | * Release all quotas referenced by inode | 1368 | * Release all quotas referenced by inode |
1302 | */ | 1369 | */ |
1303 | int dquot_drop(struct inode *inode) | 1370 | static void __dquot_drop(struct inode *inode) |
1304 | { | 1371 | { |
1305 | int cnt; | 1372 | int cnt; |
1306 | struct dquot *put[MAXQUOTAS]; | 1373 | struct dquot *put[MAXQUOTAS]; |
@@ -1312,32 +1379,31 @@ int dquot_drop(struct inode *inode) | |||
1312 | } | 1379 | } |
1313 | up_write(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1380 | up_write(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1314 | dqput_all(put); | 1381 | dqput_all(put); |
1315 | return 0; | ||
1316 | } | 1382 | } |
1317 | EXPORT_SYMBOL(dquot_drop); | ||
1318 | 1383 | ||
1319 | /* Wrapper to remove references to quota structures from inode */ | 1384 | void dquot_drop(struct inode *inode) |
1320 | void vfs_dq_drop(struct inode *inode) | 1385 | { |
1321 | { | 1386 | int cnt; |
1322 | /* Here we can get arbitrary inode from clear_inode() so we have | 1387 | |
1323 | * to be careful. OTOH we don't need locking as quota operations | 1388 | if (IS_NOQUOTA(inode)) |
1324 | * are allowed to change only at mount time */ | 1389 | return; |
1325 | if (!IS_NOQUOTA(inode) && inode->i_sb && inode->i_sb->dq_op | 1390 | |
1326 | && inode->i_sb->dq_op->drop) { | 1391 | /* |
1327 | int cnt; | 1392 | * Test before calling to rule out calls from proc and such |
1328 | /* Test before calling to rule out calls from proc and such | 1393 | * where we are not allowed to block. Note that this is |
1329 | * where we are not allowed to block. Note that this is | 1394 | * actually reliable test even without the lock - the caller |
1330 | * actually reliable test even without the lock - the caller | 1395 | * must assure that nobody can come after the DQUOT_DROP and |
1331 | * must assure that nobody can come after the DQUOT_DROP and | 1396 | * add quota pointers back anyway. |
1332 | * add quota pointers back anyway */ | 1397 | */ |
1333 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) | 1398 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1334 | if (inode->i_dquot[cnt]) | 1399 | if (inode->i_dquot[cnt]) |
1335 | break; | 1400 | break; |
1336 | if (cnt < MAXQUOTAS) | 1401 | } |
1337 | inode->i_sb->dq_op->drop(inode); | 1402 | |
1338 | } | 1403 | if (cnt < MAXQUOTAS) |
1339 | } | 1404 | __dquot_drop(inode); |
1340 | EXPORT_SYMBOL(vfs_dq_drop); | 1405 | } |
1406 | EXPORT_SYMBOL(dquot_drop); | ||
1341 | 1407 | ||
1342 | /* | 1408 | /* |
1343 | * inode_reserved_space is managed internally by quota, and protected by | 1409 | * inode_reserved_space is managed internally by quota, and protected by |
@@ -1351,28 +1417,30 @@ static qsize_t *inode_reserved_space(struct inode * inode) | |||
1351 | return inode->i_sb->dq_op->get_reserved_space(inode); | 1417 | return inode->i_sb->dq_op->get_reserved_space(inode); |
1352 | } | 1418 | } |
1353 | 1419 | ||
1354 | static void inode_add_rsv_space(struct inode *inode, qsize_t number) | 1420 | void inode_add_rsv_space(struct inode *inode, qsize_t number) |
1355 | { | 1421 | { |
1356 | spin_lock(&inode->i_lock); | 1422 | spin_lock(&inode->i_lock); |
1357 | *inode_reserved_space(inode) += number; | 1423 | *inode_reserved_space(inode) += number; |
1358 | spin_unlock(&inode->i_lock); | 1424 | spin_unlock(&inode->i_lock); |
1359 | } | 1425 | } |
1426 | EXPORT_SYMBOL(inode_add_rsv_space); | ||
1360 | 1427 | ||
1361 | 1428 | void inode_claim_rsv_space(struct inode *inode, qsize_t number) | |
1362 | static void inode_claim_rsv_space(struct inode *inode, qsize_t number) | ||
1363 | { | 1429 | { |
1364 | spin_lock(&inode->i_lock); | 1430 | spin_lock(&inode->i_lock); |
1365 | *inode_reserved_space(inode) -= number; | 1431 | *inode_reserved_space(inode) -= number; |
1366 | __inode_add_bytes(inode, number); | 1432 | __inode_add_bytes(inode, number); |
1367 | spin_unlock(&inode->i_lock); | 1433 | spin_unlock(&inode->i_lock); |
1368 | } | 1434 | } |
1435 | EXPORT_SYMBOL(inode_claim_rsv_space); | ||
1369 | 1436 | ||
1370 | static void inode_sub_rsv_space(struct inode *inode, qsize_t number) | 1437 | void inode_sub_rsv_space(struct inode *inode, qsize_t number) |
1371 | { | 1438 | { |
1372 | spin_lock(&inode->i_lock); | 1439 | spin_lock(&inode->i_lock); |
1373 | *inode_reserved_space(inode) -= number; | 1440 | *inode_reserved_space(inode) -= number; |
1374 | spin_unlock(&inode->i_lock); | 1441 | spin_unlock(&inode->i_lock); |
1375 | } | 1442 | } |
1443 | EXPORT_SYMBOL(inode_sub_rsv_space); | ||
1376 | 1444 | ||
1377 | static qsize_t inode_get_rsv_space(struct inode *inode) | 1445 | static qsize_t inode_get_rsv_space(struct inode *inode) |
1378 | { | 1446 | { |
@@ -1404,38 +1472,34 @@ static void inode_decr_space(struct inode *inode, qsize_t number, int reserve) | |||
1404 | } | 1472 | } |
1405 | 1473 | ||
1406 | /* | 1474 | /* |
1407 | * Following four functions update i_blocks+i_bytes fields and | 1475 | * This functions updates i_blocks+i_bytes fields and quota information |
1408 | * quota information (together with appropriate checks) | 1476 | * (together with appropriate checks). |
1409 | * NOTE: We absolutely rely on the fact that caller dirties | 1477 | * |
1410 | * the inode (usually macros in quotaops.h care about this) and | 1478 | * NOTE: We absolutely rely on the fact that caller dirties the inode |
1411 | * holds a handle for the current transaction so that dquot write and | 1479 | * (usually helpers in quotaops.h care about this) and holds a handle for |
1412 | * inode write go into the same transaction. | 1480 | * the current transaction so that dquot write and inode write go into the |
1481 | * same transaction. | ||
1413 | */ | 1482 | */ |
1414 | 1483 | ||
1415 | /* | 1484 | /* |
1416 | * This operation can block, but only after everything is updated | 1485 | * This operation can block, but only after everything is updated |
1417 | */ | 1486 | */ |
1418 | int __dquot_alloc_space(struct inode *inode, qsize_t number, | 1487 | int __dquot_alloc_space(struct inode *inode, qsize_t number, |
1419 | int warn, int reserve) | 1488 | int warn, int reserve) |
1420 | { | 1489 | { |
1421 | int cnt, ret = QUOTA_OK; | 1490 | int cnt, ret = 0; |
1422 | char warntype[MAXQUOTAS]; | 1491 | char warntype[MAXQUOTAS]; |
1423 | 1492 | ||
1424 | /* | 1493 | /* |
1425 | * First test before acquiring mutex - solves deadlocks when we | 1494 | * First test before acquiring mutex - solves deadlocks when we |
1426 | * re-enter the quota code and are already holding the mutex | 1495 | * re-enter the quota code and are already holding the mutex |
1427 | */ | 1496 | */ |
1428 | if (IS_NOQUOTA(inode)) { | 1497 | if (!sb_any_quota_active(inode->i_sb) || IS_NOQUOTA(inode)) { |
1429 | inode_incr_space(inode, number, reserve); | 1498 | inode_incr_space(inode, number, reserve); |
1430 | goto out; | 1499 | goto out; |
1431 | } | 1500 | } |
1432 | 1501 | ||
1433 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1502 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1434 | if (IS_NOQUOTA(inode)) { | ||
1435 | inode_incr_space(inode, number, reserve); | ||
1436 | goto out_unlock; | ||
1437 | } | ||
1438 | |||
1439 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) | 1503 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) |
1440 | warntype[cnt] = QUOTA_NL_NOWARN; | 1504 | warntype[cnt] = QUOTA_NL_NOWARN; |
1441 | 1505 | ||
@@ -1443,9 +1507,9 @@ int __dquot_alloc_space(struct inode *inode, qsize_t number, | |||
1443 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1507 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1444 | if (!inode->i_dquot[cnt]) | 1508 | if (!inode->i_dquot[cnt]) |
1445 | continue; | 1509 | continue; |
1446 | if (check_bdq(inode->i_dquot[cnt], number, warn, warntype+cnt) | 1510 | ret = check_bdq(inode->i_dquot[cnt], number, !warn, |
1447 | == NO_QUOTA) { | 1511 | warntype+cnt); |
1448 | ret = NO_QUOTA; | 1512 | if (ret) { |
1449 | spin_unlock(&dq_data_lock); | 1513 | spin_unlock(&dq_data_lock); |
1450 | goto out_flush_warn; | 1514 | goto out_flush_warn; |
1451 | } | 1515 | } |
@@ -1466,61 +1530,45 @@ int __dquot_alloc_space(struct inode *inode, qsize_t number, | |||
1466 | mark_all_dquot_dirty(inode->i_dquot); | 1530 | mark_all_dquot_dirty(inode->i_dquot); |
1467 | out_flush_warn: | 1531 | out_flush_warn: |
1468 | flush_warnings(inode->i_dquot, warntype); | 1532 | flush_warnings(inode->i_dquot, warntype); |
1469 | out_unlock: | ||
1470 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1533 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1471 | out: | 1534 | out: |
1472 | return ret; | 1535 | return ret; |
1473 | } | 1536 | } |
1474 | 1537 | EXPORT_SYMBOL(__dquot_alloc_space); | |
1475 | int dquot_alloc_space(struct inode *inode, qsize_t number, int warn) | ||
1476 | { | ||
1477 | return __dquot_alloc_space(inode, number, warn, 0); | ||
1478 | } | ||
1479 | EXPORT_SYMBOL(dquot_alloc_space); | ||
1480 | |||
1481 | int dquot_reserve_space(struct inode *inode, qsize_t number, int warn) | ||
1482 | { | ||
1483 | return __dquot_alloc_space(inode, number, warn, 1); | ||
1484 | } | ||
1485 | EXPORT_SYMBOL(dquot_reserve_space); | ||
1486 | 1538 | ||
1487 | /* | 1539 | /* |
1488 | * This operation can block, but only after everything is updated | 1540 | * This operation can block, but only after everything is updated |
1489 | */ | 1541 | */ |
1490 | int dquot_alloc_inode(const struct inode *inode, qsize_t number) | 1542 | int dquot_alloc_inode(const struct inode *inode) |
1491 | { | 1543 | { |
1492 | int cnt, ret = NO_QUOTA; | 1544 | int cnt, ret = 0; |
1493 | char warntype[MAXQUOTAS]; | 1545 | char warntype[MAXQUOTAS]; |
1494 | 1546 | ||
1495 | /* First test before acquiring mutex - solves deadlocks when we | 1547 | /* First test before acquiring mutex - solves deadlocks when we |
1496 | * re-enter the quota code and are already holding the mutex */ | 1548 | * re-enter the quota code and are already holding the mutex */ |
1497 | if (IS_NOQUOTA(inode)) | 1549 | if (!sb_any_quota_active(inode->i_sb) || IS_NOQUOTA(inode)) |
1498 | return QUOTA_OK; | 1550 | return 0; |
1499 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) | 1551 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) |
1500 | warntype[cnt] = QUOTA_NL_NOWARN; | 1552 | warntype[cnt] = QUOTA_NL_NOWARN; |
1501 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1553 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1502 | if (IS_NOQUOTA(inode)) { | ||
1503 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | ||
1504 | return QUOTA_OK; | ||
1505 | } | ||
1506 | spin_lock(&dq_data_lock); | 1554 | spin_lock(&dq_data_lock); |
1507 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1555 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1508 | if (!inode->i_dquot[cnt]) | 1556 | if (!inode->i_dquot[cnt]) |
1509 | continue; | 1557 | continue; |
1510 | if (check_idq(inode->i_dquot[cnt], number, warntype+cnt) | 1558 | ret = check_idq(inode->i_dquot[cnt], 1, warntype + cnt); |
1511 | == NO_QUOTA) | 1559 | if (ret) |
1512 | goto warn_put_all; | 1560 | goto warn_put_all; |
1513 | } | 1561 | } |
1514 | 1562 | ||
1515 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1563 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1516 | if (!inode->i_dquot[cnt]) | 1564 | if (!inode->i_dquot[cnt]) |
1517 | continue; | 1565 | continue; |
1518 | dquot_incr_inodes(inode->i_dquot[cnt], number); | 1566 | dquot_incr_inodes(inode->i_dquot[cnt], 1); |
1519 | } | 1567 | } |
1520 | ret = QUOTA_OK; | 1568 | |
1521 | warn_put_all: | 1569 | warn_put_all: |
1522 | spin_unlock(&dq_data_lock); | 1570 | spin_unlock(&dq_data_lock); |
1523 | if (ret == QUOTA_OK) | 1571 | if (ret == 0) |
1524 | mark_all_dquot_dirty(inode->i_dquot); | 1572 | mark_all_dquot_dirty(inode->i_dquot); |
1525 | flush_warnings(inode->i_dquot, warntype); | 1573 | flush_warnings(inode->i_dquot, warntype); |
1526 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1574 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); |
@@ -1528,23 +1576,19 @@ warn_put_all: | |||
1528 | } | 1576 | } |
1529 | EXPORT_SYMBOL(dquot_alloc_inode); | 1577 | EXPORT_SYMBOL(dquot_alloc_inode); |
1530 | 1578 | ||
1531 | int dquot_claim_space(struct inode *inode, qsize_t number) | 1579 | /* |
1580 | * Convert in-memory reserved quotas to real consumed quotas | ||
1581 | */ | ||
1582 | int dquot_claim_space_nodirty(struct inode *inode, qsize_t number) | ||
1532 | { | 1583 | { |
1533 | int cnt; | 1584 | int cnt; |
1534 | int ret = QUOTA_OK; | ||
1535 | 1585 | ||
1536 | if (IS_NOQUOTA(inode)) { | 1586 | if (!sb_any_quota_active(inode->i_sb) || IS_NOQUOTA(inode)) { |
1537 | inode_claim_rsv_space(inode, number); | 1587 | inode_claim_rsv_space(inode, number); |
1538 | goto out; | 1588 | return 0; |
1539 | } | 1589 | } |
1540 | 1590 | ||
1541 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1591 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1542 | if (IS_NOQUOTA(inode)) { | ||
1543 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | ||
1544 | inode_claim_rsv_space(inode, number); | ||
1545 | goto out; | ||
1546 | } | ||
1547 | |||
1548 | spin_lock(&dq_data_lock); | 1592 | spin_lock(&dq_data_lock); |
1549 | /* Claim reserved quotas to allocated quotas */ | 1593 | /* Claim reserved quotas to allocated quotas */ |
1550 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1594 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
@@ -1557,33 +1601,26 @@ int dquot_claim_space(struct inode *inode, qsize_t number) | |||
1557 | spin_unlock(&dq_data_lock); | 1601 | spin_unlock(&dq_data_lock); |
1558 | mark_all_dquot_dirty(inode->i_dquot); | 1602 | mark_all_dquot_dirty(inode->i_dquot); |
1559 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1603 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1560 | out: | 1604 | return 0; |
1561 | return ret; | ||
1562 | } | 1605 | } |
1563 | EXPORT_SYMBOL(dquot_claim_space); | 1606 | EXPORT_SYMBOL(dquot_claim_space_nodirty); |
1564 | 1607 | ||
1565 | /* | 1608 | /* |
1566 | * This operation can block, but only after everything is updated | 1609 | * This operation can block, but only after everything is updated |
1567 | */ | 1610 | */ |
1568 | int __dquot_free_space(struct inode *inode, qsize_t number, int reserve) | 1611 | void __dquot_free_space(struct inode *inode, qsize_t number, int reserve) |
1569 | { | 1612 | { |
1570 | unsigned int cnt; | 1613 | unsigned int cnt; |
1571 | char warntype[MAXQUOTAS]; | 1614 | char warntype[MAXQUOTAS]; |
1572 | 1615 | ||
1573 | /* First test before acquiring mutex - solves deadlocks when we | 1616 | /* First test before acquiring mutex - solves deadlocks when we |
1574 | * re-enter the quota code and are already holding the mutex */ | 1617 | * re-enter the quota code and are already holding the mutex */ |
1575 | if (IS_NOQUOTA(inode)) { | 1618 | if (!sb_any_quota_active(inode->i_sb) || IS_NOQUOTA(inode)) { |
1576 | out_sub: | ||
1577 | inode_decr_space(inode, number, reserve); | 1619 | inode_decr_space(inode, number, reserve); |
1578 | return QUOTA_OK; | 1620 | return; |
1579 | } | 1621 | } |
1580 | 1622 | ||
1581 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1623 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1582 | /* Now recheck reliably when holding dqptr_sem */ | ||
1583 | if (IS_NOQUOTA(inode)) { | ||
1584 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | ||
1585 | goto out_sub; | ||
1586 | } | ||
1587 | spin_lock(&dq_data_lock); | 1624 | spin_lock(&dq_data_lock); |
1588 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1625 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1589 | if (!inode->i_dquot[cnt]) | 1626 | if (!inode->i_dquot[cnt]) |
@@ -1603,56 +1640,34 @@ out_sub: | |||
1603 | out_unlock: | 1640 | out_unlock: |
1604 | flush_warnings(inode->i_dquot, warntype); | 1641 | flush_warnings(inode->i_dquot, warntype); |
1605 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1642 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1606 | return QUOTA_OK; | ||
1607 | } | ||
1608 | |||
1609 | int dquot_free_space(struct inode *inode, qsize_t number) | ||
1610 | { | ||
1611 | return __dquot_free_space(inode, number, 0); | ||
1612 | } | 1643 | } |
1613 | EXPORT_SYMBOL(dquot_free_space); | 1644 | EXPORT_SYMBOL(__dquot_free_space); |
1614 | |||
1615 | /* | ||
1616 | * Release reserved quota space | ||
1617 | */ | ||
1618 | void dquot_release_reserved_space(struct inode *inode, qsize_t number) | ||
1619 | { | ||
1620 | __dquot_free_space(inode, number, 1); | ||
1621 | |||
1622 | } | ||
1623 | EXPORT_SYMBOL(dquot_release_reserved_space); | ||
1624 | 1645 | ||
1625 | /* | 1646 | /* |
1626 | * This operation can block, but only after everything is updated | 1647 | * This operation can block, but only after everything is updated |
1627 | */ | 1648 | */ |
1628 | int dquot_free_inode(const struct inode *inode, qsize_t number) | 1649 | void dquot_free_inode(const struct inode *inode) |
1629 | { | 1650 | { |
1630 | unsigned int cnt; | 1651 | unsigned int cnt; |
1631 | char warntype[MAXQUOTAS]; | 1652 | char warntype[MAXQUOTAS]; |
1632 | 1653 | ||
1633 | /* First test before acquiring mutex - solves deadlocks when we | 1654 | /* First test before acquiring mutex - solves deadlocks when we |
1634 | * re-enter the quota code and are already holding the mutex */ | 1655 | * re-enter the quota code and are already holding the mutex */ |
1635 | if (IS_NOQUOTA(inode)) | 1656 | if (!sb_any_quota_active(inode->i_sb) || IS_NOQUOTA(inode)) |
1636 | return QUOTA_OK; | 1657 | return; |
1637 | 1658 | ||
1638 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1659 | down_read(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1639 | /* Now recheck reliably when holding dqptr_sem */ | ||
1640 | if (IS_NOQUOTA(inode)) { | ||
1641 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | ||
1642 | return QUOTA_OK; | ||
1643 | } | ||
1644 | spin_lock(&dq_data_lock); | 1660 | spin_lock(&dq_data_lock); |
1645 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1661 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1646 | if (!inode->i_dquot[cnt]) | 1662 | if (!inode->i_dquot[cnt]) |
1647 | continue; | 1663 | continue; |
1648 | warntype[cnt] = info_idq_free(inode->i_dquot[cnt], number); | 1664 | warntype[cnt] = info_idq_free(inode->i_dquot[cnt], 1); |
1649 | dquot_decr_inodes(inode->i_dquot[cnt], number); | 1665 | dquot_decr_inodes(inode->i_dquot[cnt], 1); |
1650 | } | 1666 | } |
1651 | spin_unlock(&dq_data_lock); | 1667 | spin_unlock(&dq_data_lock); |
1652 | mark_all_dquot_dirty(inode->i_dquot); | 1668 | mark_all_dquot_dirty(inode->i_dquot); |
1653 | flush_warnings(inode->i_dquot, warntype); | 1669 | flush_warnings(inode->i_dquot, warntype); |
1654 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1670 | up_read(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1655 | return QUOTA_OK; | ||
1656 | } | 1671 | } |
1657 | EXPORT_SYMBOL(dquot_free_inode); | 1672 | EXPORT_SYMBOL(dquot_free_inode); |
1658 | 1673 | ||
@@ -1662,37 +1677,31 @@ EXPORT_SYMBOL(dquot_free_inode); | |||
1662 | * This operation can block, but only after everything is updated | 1677 | * This operation can block, but only after everything is updated |
1663 | * A transaction must be started when entering this function. | 1678 | * A transaction must be started when entering this function. |
1664 | */ | 1679 | */ |
1665 | int dquot_transfer(struct inode *inode, struct iattr *iattr) | 1680 | static int __dquot_transfer(struct inode *inode, qid_t *chid, unsigned long mask) |
1666 | { | 1681 | { |
1667 | qsize_t space, cur_space; | 1682 | qsize_t space, cur_space; |
1668 | qsize_t rsv_space = 0; | 1683 | qsize_t rsv_space = 0; |
1669 | struct dquot *transfer_from[MAXQUOTAS]; | 1684 | struct dquot *transfer_from[MAXQUOTAS]; |
1670 | struct dquot *transfer_to[MAXQUOTAS]; | 1685 | struct dquot *transfer_to[MAXQUOTAS]; |
1671 | int cnt, ret = QUOTA_OK; | 1686 | int cnt, ret = 0; |
1672 | int chuid = iattr->ia_valid & ATTR_UID && inode->i_uid != iattr->ia_uid, | ||
1673 | chgid = iattr->ia_valid & ATTR_GID && inode->i_gid != iattr->ia_gid; | ||
1674 | char warntype_to[MAXQUOTAS]; | 1687 | char warntype_to[MAXQUOTAS]; |
1675 | char warntype_from_inodes[MAXQUOTAS], warntype_from_space[MAXQUOTAS]; | 1688 | char warntype_from_inodes[MAXQUOTAS], warntype_from_space[MAXQUOTAS]; |
1676 | 1689 | ||
1677 | /* First test before acquiring mutex - solves deadlocks when we | 1690 | /* First test before acquiring mutex - solves deadlocks when we |
1678 | * re-enter the quota code and are already holding the mutex */ | 1691 | * re-enter the quota code and are already holding the mutex */ |
1679 | if (IS_NOQUOTA(inode)) | 1692 | if (IS_NOQUOTA(inode)) |
1680 | return QUOTA_OK; | 1693 | return 0; |
1681 | /* Initialize the arrays */ | 1694 | /* Initialize the arrays */ |
1682 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 1695 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1683 | transfer_from[cnt] = NULL; | 1696 | transfer_from[cnt] = NULL; |
1684 | transfer_to[cnt] = NULL; | 1697 | transfer_to[cnt] = NULL; |
1685 | warntype_to[cnt] = QUOTA_NL_NOWARN; | 1698 | warntype_to[cnt] = QUOTA_NL_NOWARN; |
1686 | } | 1699 | } |
1687 | if (chuid) | 1700 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { |
1688 | transfer_to[USRQUOTA] = dqget(inode->i_sb, iattr->ia_uid, | 1701 | if (mask & (1 << cnt)) |
1689 | USRQUOTA); | 1702 | transfer_to[cnt] = dqget(inode->i_sb, chid[cnt], cnt); |
1690 | if (chgid) | 1703 | } |
1691 | transfer_to[GRPQUOTA] = dqget(inode->i_sb, iattr->ia_gid, | ||
1692 | GRPQUOTA); | ||
1693 | |||
1694 | down_write(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1704 | down_write(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1695 | /* Now recheck reliably when holding dqptr_sem */ | ||
1696 | if (IS_NOQUOTA(inode)) { /* File without quota accounting? */ | 1705 | if (IS_NOQUOTA(inode)) { /* File without quota accounting? */ |
1697 | up_write(&sb_dqopt(inode->i_sb)->dqptr_sem); | 1706 | up_write(&sb_dqopt(inode->i_sb)->dqptr_sem); |
1698 | goto put_all; | 1707 | goto put_all; |
@@ -1706,9 +1715,11 @@ int dquot_transfer(struct inode *inode, struct iattr *iattr) | |||
1706 | if (!transfer_to[cnt]) | 1715 | if (!transfer_to[cnt]) |
1707 | continue; | 1716 | continue; |
1708 | transfer_from[cnt] = inode->i_dquot[cnt]; | 1717 | transfer_from[cnt] = inode->i_dquot[cnt]; |
1709 | if (check_idq(transfer_to[cnt], 1, warntype_to + cnt) == | 1718 | ret = check_idq(transfer_to[cnt], 1, warntype_to + cnt); |
1710 | NO_QUOTA || check_bdq(transfer_to[cnt], space, 0, | 1719 | if (ret) |
1711 | warntype_to + cnt) == NO_QUOTA) | 1720 | goto over_quota; |
1721 | ret = check_bdq(transfer_to[cnt], space, 0, warntype_to + cnt); | ||
1722 | if (ret) | ||
1712 | goto over_quota; | 1723 | goto over_quota; |
1713 | } | 1724 | } |
1714 | 1725 | ||
@@ -1762,22 +1773,32 @@ over_quota: | |||
1762 | /* Clear dquot pointers we don't want to dqput() */ | 1773 | /* Clear dquot pointers we don't want to dqput() */ |
1763 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) | 1774 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) |
1764 | transfer_from[cnt] = NULL; | 1775 | transfer_from[cnt] = NULL; |
1765 | ret = NO_QUOTA; | ||
1766 | goto warn_put_all; | 1776 | goto warn_put_all; |
1767 | } | 1777 | } |
1768 | EXPORT_SYMBOL(dquot_transfer); | ||
1769 | 1778 | ||
1770 | /* Wrapper for transferring ownership of an inode */ | 1779 | /* Wrapper for transferring ownership of an inode for uid/gid only |
1771 | int vfs_dq_transfer(struct inode *inode, struct iattr *iattr) | 1780 | * Called from FSXXX_setattr() |
1781 | */ | ||
1782 | int dquot_transfer(struct inode *inode, struct iattr *iattr) | ||
1772 | { | 1783 | { |
1784 | qid_t chid[MAXQUOTAS]; | ||
1785 | unsigned long mask = 0; | ||
1786 | |||
1787 | if (iattr->ia_valid & ATTR_UID && iattr->ia_uid != inode->i_uid) { | ||
1788 | mask |= 1 << USRQUOTA; | ||
1789 | chid[USRQUOTA] = iattr->ia_uid; | ||
1790 | } | ||
1791 | if (iattr->ia_valid & ATTR_GID && iattr->ia_gid != inode->i_gid) { | ||
1792 | mask |= 1 << GRPQUOTA; | ||
1793 | chid[GRPQUOTA] = iattr->ia_gid; | ||
1794 | } | ||
1773 | if (sb_any_quota_active(inode->i_sb) && !IS_NOQUOTA(inode)) { | 1795 | if (sb_any_quota_active(inode->i_sb) && !IS_NOQUOTA(inode)) { |
1774 | vfs_dq_init(inode); | 1796 | dquot_initialize(inode); |
1775 | if (inode->i_sb->dq_op->transfer(inode, iattr) == NO_QUOTA) | 1797 | return __dquot_transfer(inode, chid, mask); |
1776 | return 1; | ||
1777 | } | 1798 | } |
1778 | return 0; | 1799 | return 0; |
1779 | } | 1800 | } |
1780 | EXPORT_SYMBOL(vfs_dq_transfer); | 1801 | EXPORT_SYMBOL(dquot_transfer); |
1781 | 1802 | ||
1782 | /* | 1803 | /* |
1783 | * Write info of quota file to disk | 1804 | * Write info of quota file to disk |
@@ -1798,13 +1819,6 @@ EXPORT_SYMBOL(dquot_commit_info); | |||
1798 | * Definitions of diskquota operations. | 1819 | * Definitions of diskquota operations. |
1799 | */ | 1820 | */ |
1800 | const struct dquot_operations dquot_operations = { | 1821 | const struct dquot_operations dquot_operations = { |
1801 | .initialize = dquot_initialize, | ||
1802 | .drop = dquot_drop, | ||
1803 | .alloc_space = dquot_alloc_space, | ||
1804 | .alloc_inode = dquot_alloc_inode, | ||
1805 | .free_space = dquot_free_space, | ||
1806 | .free_inode = dquot_free_inode, | ||
1807 | .transfer = dquot_transfer, | ||
1808 | .write_dquot = dquot_commit, | 1822 | .write_dquot = dquot_commit, |
1809 | .acquire_dquot = dquot_acquire, | 1823 | .acquire_dquot = dquot_acquire, |
1810 | .release_dquot = dquot_release, | 1824 | .release_dquot = dquot_release, |
@@ -1815,6 +1829,20 @@ const struct dquot_operations dquot_operations = { | |||
1815 | }; | 1829 | }; |
1816 | 1830 | ||
1817 | /* | 1831 | /* |
1832 | * Generic helper for ->open on filesystems supporting disk quotas. | ||
1833 | */ | ||
1834 | int dquot_file_open(struct inode *inode, struct file *file) | ||
1835 | { | ||
1836 | int error; | ||
1837 | |||
1838 | error = generic_file_open(inode, file); | ||
1839 | if (!error && (file->f_mode & FMODE_WRITE)) | ||
1840 | dquot_initialize(inode); | ||
1841 | return error; | ||
1842 | } | ||
1843 | EXPORT_SYMBOL(dquot_file_open); | ||
1844 | |||
1845 | /* | ||
1818 | * Turn quota off on a device. type == -1 ==> quotaoff for all types (umount) | 1846 | * Turn quota off on a device. type == -1 ==> quotaoff for all types (umount) |
1819 | */ | 1847 | */ |
1820 | int vfs_quota_disable(struct super_block *sb, int type, unsigned int flags) | 1848 | int vfs_quota_disable(struct super_block *sb, int type, unsigned int flags) |
@@ -1993,11 +2021,13 @@ static int vfs_load_quota_inode(struct inode *inode, int type, int format_id, | |||
1993 | } | 2021 | } |
1994 | 2022 | ||
1995 | if (!(dqopt->flags & DQUOT_QUOTA_SYS_FILE)) { | 2023 | if (!(dqopt->flags & DQUOT_QUOTA_SYS_FILE)) { |
1996 | /* As we bypass the pagecache we must now flush the inode so | 2024 | /* As we bypass the pagecache we must now flush all the |
1997 | * that we see all the changes from userspace... */ | 2025 | * dirty data and invalidate caches so that kernel sees |
1998 | write_inode_now(inode, 1); | 2026 | * changes from userspace. It is not enough to just flush |
1999 | /* And now flush the block cache so that kernel sees the | 2027 | * the quota file since if blocksize < pagesize, invalidation |
2000 | * changes */ | 2028 | * of the cache could fail because of other unrelated dirty |
2029 | * data */ | ||
2030 | sync_filesystem(sb); | ||
2001 | invalidate_bdev(sb->s_bdev); | 2031 | invalidate_bdev(sb->s_bdev); |
2002 | } | 2032 | } |
2003 | mutex_lock(&dqopt->dqonoff_mutex); | 2033 | mutex_lock(&dqopt->dqonoff_mutex); |
@@ -2010,14 +2040,16 @@ static int vfs_load_quota_inode(struct inode *inode, int type, int format_id, | |||
2010 | /* We don't want quota and atime on quota files (deadlocks | 2040 | /* We don't want quota and atime on quota files (deadlocks |
2011 | * possible) Also nobody should write to the file - we use | 2041 | * possible) Also nobody should write to the file - we use |
2012 | * special IO operations which ignore the immutable bit. */ | 2042 | * special IO operations which ignore the immutable bit. */ |
2013 | down_write(&dqopt->dqptr_sem); | ||
2014 | mutex_lock_nested(&inode->i_mutex, I_MUTEX_QUOTA); | 2043 | mutex_lock_nested(&inode->i_mutex, I_MUTEX_QUOTA); |
2015 | oldflags = inode->i_flags & (S_NOATIME | S_IMMUTABLE | | 2044 | oldflags = inode->i_flags & (S_NOATIME | S_IMMUTABLE | |
2016 | S_NOQUOTA); | 2045 | S_NOQUOTA); |
2017 | inode->i_flags |= S_NOQUOTA | S_NOATIME | S_IMMUTABLE; | 2046 | inode->i_flags |= S_NOQUOTA | S_NOATIME | S_IMMUTABLE; |
2018 | mutex_unlock(&inode->i_mutex); | 2047 | mutex_unlock(&inode->i_mutex); |
2019 | up_write(&dqopt->dqptr_sem); | 2048 | /* |
2020 | sb->dq_op->drop(inode); | 2049 | * When S_NOQUOTA is set, remove dquot references as no more |
2050 | * references can be added | ||
2051 | */ | ||
2052 | __dquot_drop(inode); | ||
2021 | } | 2053 | } |
2022 | 2054 | ||
2023 | error = -EIO; | 2055 | error = -EIO; |
@@ -2053,14 +2085,12 @@ out_file_init: | |||
2053 | iput(inode); | 2085 | iput(inode); |
2054 | out_lock: | 2086 | out_lock: |
2055 | if (oldflags != -1) { | 2087 | if (oldflags != -1) { |
2056 | down_write(&dqopt->dqptr_sem); | ||
2057 | mutex_lock_nested(&inode->i_mutex, I_MUTEX_QUOTA); | 2088 | mutex_lock_nested(&inode->i_mutex, I_MUTEX_QUOTA); |
2058 | /* Set the flags back (in the case of accidental quotaon() | 2089 | /* Set the flags back (in the case of accidental quotaon() |
2059 | * on a wrong file we don't want to mess up the flags) */ | 2090 | * on a wrong file we don't want to mess up the flags) */ |
2060 | inode->i_flags &= ~(S_NOATIME | S_NOQUOTA | S_IMMUTABLE); | 2091 | inode->i_flags &= ~(S_NOATIME | S_NOQUOTA | S_IMMUTABLE); |
2061 | inode->i_flags |= oldflags; | 2092 | inode->i_flags |= oldflags; |
2062 | mutex_unlock(&inode->i_mutex); | 2093 | mutex_unlock(&inode->i_mutex); |
2063 | up_write(&dqopt->dqptr_sem); | ||
2064 | } | 2094 | } |
2065 | mutex_unlock(&dqopt->dqonoff_mutex); | 2095 | mutex_unlock(&dqopt->dqonoff_mutex); |
2066 | out_fmt: | 2096 | out_fmt: |
diff --git a/fs/quota/netlink.c b/fs/quota/netlink.c new file mode 100644 index 000000000000..2663ed90fb03 --- /dev/null +++ b/fs/quota/netlink.c | |||
@@ -0,0 +1,95 @@ | |||
1 | |||
2 | #include <linux/cred.h> | ||
3 | #include <linux/init.h> | ||
4 | #include <linux/module.h> | ||
5 | #include <linux/kernel.h> | ||
6 | #include <linux/quotaops.h> | ||
7 | #include <linux/sched.h> | ||
8 | #include <net/netlink.h> | ||
9 | #include <net/genetlink.h> | ||
10 | |||
11 | /* Netlink family structure for quota */ | ||
12 | static struct genl_family quota_genl_family = { | ||
13 | .id = GENL_ID_GENERATE, | ||
14 | .hdrsize = 0, | ||
15 | .name = "VFS_DQUOT", | ||
16 | .version = 1, | ||
17 | .maxattr = QUOTA_NL_A_MAX, | ||
18 | }; | ||
19 | |||
20 | /** | ||
21 | * quota_send_warning - Send warning to userspace about exceeded quota | ||
22 | * @type: The quota type: USRQQUOTA, GRPQUOTA,... | ||
23 | * @id: The user or group id of the quota that was exceeded | ||
24 | * @dev: The device on which the fs is mounted (sb->s_dev) | ||
25 | * @warntype: The type of the warning: QUOTA_NL_... | ||
26 | * | ||
27 | * This can be used by filesystems (including those which don't use | ||
28 | * dquot) to send a message to userspace relating to quota limits. | ||
29 | * | ||
30 | */ | ||
31 | |||
32 | void quota_send_warning(short type, unsigned int id, dev_t dev, | ||
33 | const char warntype) | ||
34 | { | ||
35 | static atomic_t seq; | ||
36 | struct sk_buff *skb; | ||
37 | void *msg_head; | ||
38 | int ret; | ||
39 | int msg_size = 4 * nla_total_size(sizeof(u32)) + | ||
40 | 2 * nla_total_size(sizeof(u64)); | ||
41 | |||
42 | /* We have to allocate using GFP_NOFS as we are called from a | ||
43 | * filesystem performing write and thus further recursion into | ||
44 | * the fs to free some data could cause deadlocks. */ | ||
45 | skb = genlmsg_new(msg_size, GFP_NOFS); | ||
46 | if (!skb) { | ||
47 | printk(KERN_ERR | ||
48 | "VFS: Not enough memory to send quota warning.\n"); | ||
49 | return; | ||
50 | } | ||
51 | msg_head = genlmsg_put(skb, 0, atomic_add_return(1, &seq), | ||
52 | "a_genl_family, 0, QUOTA_NL_C_WARNING); | ||
53 | if (!msg_head) { | ||
54 | printk(KERN_ERR | ||
55 | "VFS: Cannot store netlink header in quota warning.\n"); | ||
56 | goto err_out; | ||
57 | } | ||
58 | ret = nla_put_u32(skb, QUOTA_NL_A_QTYPE, type); | ||
59 | if (ret) | ||
60 | goto attr_err_out; | ||
61 | ret = nla_put_u64(skb, QUOTA_NL_A_EXCESS_ID, id); | ||
62 | if (ret) | ||
63 | goto attr_err_out; | ||
64 | ret = nla_put_u32(skb, QUOTA_NL_A_WARNING, warntype); | ||
65 | if (ret) | ||
66 | goto attr_err_out; | ||
67 | ret = nla_put_u32(skb, QUOTA_NL_A_DEV_MAJOR, MAJOR(dev)); | ||
68 | if (ret) | ||
69 | goto attr_err_out; | ||
70 | ret = nla_put_u32(skb, QUOTA_NL_A_DEV_MINOR, MINOR(dev)); | ||
71 | if (ret) | ||
72 | goto attr_err_out; | ||
73 | ret = nla_put_u64(skb, QUOTA_NL_A_CAUSED_ID, current_uid()); | ||
74 | if (ret) | ||
75 | goto attr_err_out; | ||
76 | genlmsg_end(skb, msg_head); | ||
77 | |||
78 | genlmsg_multicast(skb, 0, quota_genl_family.id, GFP_NOFS); | ||
79 | return; | ||
80 | attr_err_out: | ||
81 | printk(KERN_ERR "VFS: Not enough space to compose quota message!\n"); | ||
82 | err_out: | ||
83 | kfree_skb(skb); | ||
84 | } | ||
85 | EXPORT_SYMBOL(quota_send_warning); | ||
86 | |||
87 | static int __init quota_init(void) | ||
88 | { | ||
89 | if (genl_register_family("a_genl_family) != 0) | ||
90 | printk(KERN_ERR | ||
91 | "VFS: Failed to create quota netlink interface.\n"); | ||
92 | return 0; | ||
93 | }; | ||
94 | |||
95 | module_init(quota_init); | ||
diff --git a/fs/quota/quota.c b/fs/quota/quota.c index ee91e2756950..95388f9b7356 100644 --- a/fs/quota/quota.c +++ b/fs/quota/quota.c | |||
@@ -10,7 +10,6 @@ | |||
10 | #include <linux/slab.h> | 10 | #include <linux/slab.h> |
11 | #include <asm/current.h> | 11 | #include <asm/current.h> |
12 | #include <asm/uaccess.h> | 12 | #include <asm/uaccess.h> |
13 | #include <linux/compat.h> | ||
14 | #include <linux/kernel.h> | 13 | #include <linux/kernel.h> |
15 | #include <linux/security.h> | 14 | #include <linux/security.h> |
16 | #include <linux/syscalls.h> | 15 | #include <linux/syscalls.h> |
@@ -18,220 +17,205 @@ | |||
18 | #include <linux/capability.h> | 17 | #include <linux/capability.h> |
19 | #include <linux/quotaops.h> | 18 | #include <linux/quotaops.h> |
20 | #include <linux/types.h> | 19 | #include <linux/types.h> |
21 | #include <net/netlink.h> | 20 | #include <linux/writeback.h> |
22 | #include <net/genetlink.h> | ||
23 | 21 | ||
24 | /* Check validity of generic quotactl commands */ | 22 | static int check_quotactl_permission(struct super_block *sb, int type, int cmd, |
25 | static int generic_quotactl_valid(struct super_block *sb, int type, int cmd, | 23 | qid_t id) |
26 | qid_t id) | ||
27 | { | 24 | { |
28 | if (type >= MAXQUOTAS) | ||
29 | return -EINVAL; | ||
30 | if (!sb && cmd != Q_SYNC) | ||
31 | return -ENODEV; | ||
32 | /* Is operation supported? */ | ||
33 | if (sb && !sb->s_qcop) | ||
34 | return -ENOSYS; | ||
35 | |||
36 | switch (cmd) { | 25 | switch (cmd) { |
37 | case Q_GETFMT: | 26 | /* these commands do not require any special privilegues */ |
38 | break; | 27 | case Q_GETFMT: |
39 | case Q_QUOTAON: | 28 | case Q_SYNC: |
40 | if (!sb->s_qcop->quota_on) | 29 | case Q_GETINFO: |
41 | return -ENOSYS; | 30 | case Q_XGETQSTAT: |
42 | break; | 31 | case Q_XQUOTASYNC: |
43 | case Q_QUOTAOFF: | 32 | break; |
44 | if (!sb->s_qcop->quota_off) | 33 | /* allow to query information for dquots we "own" */ |
45 | return -ENOSYS; | 34 | case Q_GETQUOTA: |
46 | break; | 35 | case Q_XGETQUOTA: |
47 | case Q_SETINFO: | 36 | if ((type == USRQUOTA && current_euid() == id) || |
48 | if (!sb->s_qcop->set_info) | 37 | (type == GRPQUOTA && in_egroup_p(id))) |
49 | return -ENOSYS; | ||
50 | break; | ||
51 | case Q_GETINFO: | ||
52 | if (!sb->s_qcop->get_info) | ||
53 | return -ENOSYS; | ||
54 | break; | ||
55 | case Q_SETQUOTA: | ||
56 | if (!sb->s_qcop->set_dqblk) | ||
57 | return -ENOSYS; | ||
58 | break; | ||
59 | case Q_GETQUOTA: | ||
60 | if (!sb->s_qcop->get_dqblk) | ||
61 | return -ENOSYS; | ||
62 | break; | ||
63 | case Q_SYNC: | ||
64 | if (sb && !sb->s_qcop->quota_sync) | ||
65 | return -ENOSYS; | ||
66 | break; | 38 | break; |
67 | default: | 39 | /*FALLTHROUGH*/ |
68 | return -EINVAL; | 40 | default: |
41 | if (!capable(CAP_SYS_ADMIN)) | ||
42 | return -EPERM; | ||
69 | } | 43 | } |
70 | 44 | ||
71 | /* Is quota turned on for commands which need it? */ | 45 | return security_quotactl(cmd, type, id, sb); |
72 | switch (cmd) { | 46 | } |
73 | case Q_GETFMT: | ||
74 | case Q_GETINFO: | ||
75 | case Q_SETINFO: | ||
76 | case Q_SETQUOTA: | ||
77 | case Q_GETQUOTA: | ||
78 | /* This is just an informative test so we are satisfied | ||
79 | * without the lock */ | ||
80 | if (!sb_has_quota_active(sb, type)) | ||
81 | return -ESRCH; | ||
82 | } | ||
83 | 47 | ||
84 | /* Check privileges */ | 48 | static int quota_sync_all(int type) |
85 | if (cmd == Q_GETQUOTA) { | 49 | { |
86 | if (((type == USRQUOTA && current_euid() != id) || | 50 | struct super_block *sb; |
87 | (type == GRPQUOTA && !in_egroup_p(id))) && | 51 | int ret; |
88 | !capable(CAP_SYS_ADMIN)) | 52 | |
89 | return -EPERM; | 53 | if (type >= MAXQUOTAS) |
54 | return -EINVAL; | ||
55 | ret = security_quotactl(Q_SYNC, type, 0, NULL); | ||
56 | if (ret) | ||
57 | return ret; | ||
58 | |||
59 | spin_lock(&sb_lock); | ||
60 | restart: | ||
61 | list_for_each_entry(sb, &super_blocks, s_list) { | ||
62 | if (!sb->s_qcop || !sb->s_qcop->quota_sync) | ||
63 | continue; | ||
64 | |||
65 | sb->s_count++; | ||
66 | spin_unlock(&sb_lock); | ||
67 | down_read(&sb->s_umount); | ||
68 | if (sb->s_root) | ||
69 | sb->s_qcop->quota_sync(sb, type, 1); | ||
70 | up_read(&sb->s_umount); | ||
71 | spin_lock(&sb_lock); | ||
72 | if (__put_super_and_need_restart(sb)) | ||
73 | goto restart; | ||
90 | } | 74 | } |
91 | else if (cmd != Q_GETFMT && cmd != Q_SYNC && cmd != Q_GETINFO) | 75 | spin_unlock(&sb_lock); |
92 | if (!capable(CAP_SYS_ADMIN)) | ||
93 | return -EPERM; | ||
94 | 76 | ||
95 | return 0; | 77 | return 0; |
96 | } | 78 | } |
97 | 79 | ||
98 | /* Check validity of XFS Quota Manager commands */ | 80 | static int quota_quotaon(struct super_block *sb, int type, int cmd, qid_t id, |
99 | static int xqm_quotactl_valid(struct super_block *sb, int type, int cmd, | 81 | void __user *addr) |
100 | qid_t id) | ||
101 | { | 82 | { |
102 | if (type >= XQM_MAXQUOTAS) | 83 | char *pathname; |
103 | return -EINVAL; | 84 | int ret = -ENOSYS; |
104 | if (!sb) | 85 | |
105 | return -ENODEV; | 86 | pathname = getname(addr); |
106 | if (!sb->s_qcop) | 87 | if (IS_ERR(pathname)) |
107 | return -ENOSYS; | 88 | return PTR_ERR(pathname); |
89 | if (sb->s_qcop->quota_on) | ||
90 | ret = sb->s_qcop->quota_on(sb, type, id, pathname, 0); | ||
91 | putname(pathname); | ||
92 | return ret; | ||
93 | } | ||
108 | 94 | ||
109 | switch (cmd) { | 95 | static int quota_getfmt(struct super_block *sb, int type, void __user *addr) |
110 | case Q_XQUOTAON: | 96 | { |
111 | case Q_XQUOTAOFF: | 97 | __u32 fmt; |
112 | case Q_XQUOTARM: | ||
113 | if (!sb->s_qcop->set_xstate) | ||
114 | return -ENOSYS; | ||
115 | break; | ||
116 | case Q_XGETQSTAT: | ||
117 | if (!sb->s_qcop->get_xstate) | ||
118 | return -ENOSYS; | ||
119 | break; | ||
120 | case Q_XSETQLIM: | ||
121 | if (!sb->s_qcop->set_xquota) | ||
122 | return -ENOSYS; | ||
123 | break; | ||
124 | case Q_XGETQUOTA: | ||
125 | if (!sb->s_qcop->get_xquota) | ||
126 | return -ENOSYS; | ||
127 | break; | ||
128 | case Q_XQUOTASYNC: | ||
129 | if (!sb->s_qcop->quota_sync) | ||
130 | return -ENOSYS; | ||
131 | break; | ||
132 | default: | ||
133 | return -EINVAL; | ||
134 | } | ||
135 | 98 | ||
136 | /* Check privileges */ | 99 | down_read(&sb_dqopt(sb)->dqptr_sem); |
137 | if (cmd == Q_XGETQUOTA) { | 100 | if (!sb_has_quota_active(sb, type)) { |
138 | if (((type == XQM_USRQUOTA && current_euid() != id) || | 101 | up_read(&sb_dqopt(sb)->dqptr_sem); |
139 | (type == XQM_GRPQUOTA && !in_egroup_p(id))) && | 102 | return -ESRCH; |
140 | !capable(CAP_SYS_ADMIN)) | ||
141 | return -EPERM; | ||
142 | } else if (cmd != Q_XGETQSTAT && cmd != Q_XQUOTASYNC) { | ||
143 | if (!capable(CAP_SYS_ADMIN)) | ||
144 | return -EPERM; | ||
145 | } | 103 | } |
104 | fmt = sb_dqopt(sb)->info[type].dqi_format->qf_fmt_id; | ||
105 | up_read(&sb_dqopt(sb)->dqptr_sem); | ||
106 | if (copy_to_user(addr, &fmt, sizeof(fmt))) | ||
107 | return -EFAULT; | ||
108 | return 0; | ||
109 | } | ||
146 | 110 | ||
111 | static int quota_getinfo(struct super_block *sb, int type, void __user *addr) | ||
112 | { | ||
113 | struct if_dqinfo info; | ||
114 | int ret; | ||
115 | |||
116 | if (!sb_has_quota_active(sb, type)) | ||
117 | return -ESRCH; | ||
118 | if (!sb->s_qcop->get_info) | ||
119 | return -ENOSYS; | ||
120 | ret = sb->s_qcop->get_info(sb, type, &info); | ||
121 | if (!ret && copy_to_user(addr, &info, sizeof(info))) | ||
122 | return -EFAULT; | ||
123 | return ret; | ||
124 | } | ||
125 | |||
126 | static int quota_setinfo(struct super_block *sb, int type, void __user *addr) | ||
127 | { | ||
128 | struct if_dqinfo info; | ||
129 | |||
130 | if (copy_from_user(&info, addr, sizeof(info))) | ||
131 | return -EFAULT; | ||
132 | if (!sb_has_quota_active(sb, type)) | ||
133 | return -ESRCH; | ||
134 | if (!sb->s_qcop->set_info) | ||
135 | return -ENOSYS; | ||
136 | return sb->s_qcop->set_info(sb, type, &info); | ||
137 | } | ||
138 | |||
139 | static int quota_getquota(struct super_block *sb, int type, qid_t id, | ||
140 | void __user *addr) | ||
141 | { | ||
142 | struct if_dqblk idq; | ||
143 | int ret; | ||
144 | |||
145 | if (!sb_has_quota_active(sb, type)) | ||
146 | return -ESRCH; | ||
147 | if (!sb->s_qcop->get_dqblk) | ||
148 | return -ENOSYS; | ||
149 | ret = sb->s_qcop->get_dqblk(sb, type, id, &idq); | ||
150 | if (ret) | ||
151 | return ret; | ||
152 | if (copy_to_user(addr, &idq, sizeof(idq))) | ||
153 | return -EFAULT; | ||
147 | return 0; | 154 | return 0; |
148 | } | 155 | } |
149 | 156 | ||
150 | static int check_quotactl_valid(struct super_block *sb, int type, int cmd, | 157 | static int quota_setquota(struct super_block *sb, int type, qid_t id, |
151 | qid_t id) | 158 | void __user *addr) |
152 | { | 159 | { |
153 | int error; | 160 | struct if_dqblk idq; |
154 | 161 | ||
155 | if (XQM_COMMAND(cmd)) | 162 | if (copy_from_user(&idq, addr, sizeof(idq))) |
156 | error = xqm_quotactl_valid(sb, type, cmd, id); | 163 | return -EFAULT; |
157 | else | 164 | if (!sb_has_quota_active(sb, type)) |
158 | error = generic_quotactl_valid(sb, type, cmd, id); | 165 | return -ESRCH; |
159 | if (!error) | 166 | if (!sb->s_qcop->set_dqblk) |
160 | error = security_quotactl(cmd, type, id, sb); | 167 | return -ENOSYS; |
161 | return error; | 168 | return sb->s_qcop->set_dqblk(sb, type, id, &idq); |
162 | } | 169 | } |
163 | 170 | ||
164 | #ifdef CONFIG_QUOTA | 171 | static int quota_setxstate(struct super_block *sb, int cmd, void __user *addr) |
165 | void sync_quota_sb(struct super_block *sb, int type) | ||
166 | { | 172 | { |
167 | int cnt; | 173 | __u32 flags; |
168 | 174 | ||
169 | if (!sb->s_qcop->quota_sync) | 175 | if (copy_from_user(&flags, addr, sizeof(flags))) |
170 | return; | 176 | return -EFAULT; |
177 | if (!sb->s_qcop->set_xstate) | ||
178 | return -ENOSYS; | ||
179 | return sb->s_qcop->set_xstate(sb, flags, cmd); | ||
180 | } | ||
171 | 181 | ||
172 | sb->s_qcop->quota_sync(sb, type); | 182 | static int quota_getxstate(struct super_block *sb, void __user *addr) |
183 | { | ||
184 | struct fs_quota_stat fqs; | ||
185 | int ret; | ||
173 | 186 | ||
174 | if (sb_dqopt(sb)->flags & DQUOT_QUOTA_SYS_FILE) | 187 | if (!sb->s_qcop->get_xstate) |
175 | return; | 188 | return -ENOSYS; |
176 | /* This is not very clever (and fast) but currently I don't know about | 189 | ret = sb->s_qcop->get_xstate(sb, &fqs); |
177 | * any other simple way of getting quota data to disk and we must get | 190 | if (!ret && copy_to_user(addr, &fqs, sizeof(fqs))) |
178 | * them there for userspace to be visible... */ | 191 | return -EFAULT; |
179 | if (sb->s_op->sync_fs) | 192 | return ret; |
180 | sb->s_op->sync_fs(sb, 1); | 193 | } |
181 | sync_blockdev(sb->s_bdev); | ||
182 | 194 | ||
183 | /* | 195 | static int quota_setxquota(struct super_block *sb, int type, qid_t id, |
184 | * Now when everything is written we can discard the pagecache so | 196 | void __user *addr) |
185 | * that userspace sees the changes. | 197 | { |
186 | */ | 198 | struct fs_disk_quota fdq; |
187 | mutex_lock(&sb_dqopt(sb)->dqonoff_mutex); | 199 | |
188 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 200 | if (copy_from_user(&fdq, addr, sizeof(fdq))) |
189 | if (type != -1 && cnt != type) | 201 | return -EFAULT; |
190 | continue; | 202 | if (!sb->s_qcop->set_xquota) |
191 | if (!sb_has_quota_active(sb, cnt)) | 203 | return -ENOSYS; |
192 | continue; | 204 | return sb->s_qcop->set_xquota(sb, type, id, &fdq); |
193 | mutex_lock_nested(&sb_dqopt(sb)->files[cnt]->i_mutex, | ||
194 | I_MUTEX_QUOTA); | ||
195 | truncate_inode_pages(&sb_dqopt(sb)->files[cnt]->i_data, 0); | ||
196 | mutex_unlock(&sb_dqopt(sb)->files[cnt]->i_mutex); | ||
197 | } | ||
198 | mutex_unlock(&sb_dqopt(sb)->dqonoff_mutex); | ||
199 | } | 205 | } |
200 | #endif | ||
201 | 206 | ||
202 | static void sync_dquots(int type) | 207 | static int quota_getxquota(struct super_block *sb, int type, qid_t id, |
208 | void __user *addr) | ||
203 | { | 209 | { |
204 | struct super_block *sb; | 210 | struct fs_disk_quota fdq; |
205 | int cnt; | 211 | int ret; |
206 | 212 | ||
207 | spin_lock(&sb_lock); | 213 | if (!sb->s_qcop->get_xquota) |
208 | restart: | 214 | return -ENOSYS; |
209 | list_for_each_entry(sb, &super_blocks, s_list) { | 215 | ret = sb->s_qcop->get_xquota(sb, type, id, &fdq); |
210 | /* This test just improves performance so it needn't be | 216 | if (!ret && copy_to_user(addr, &fdq, sizeof(fdq))) |
211 | * reliable... */ | 217 | return -EFAULT; |
212 | for (cnt = 0; cnt < MAXQUOTAS; cnt++) { | 218 | return ret; |
213 | if (type != -1 && type != cnt) | ||
214 | continue; | ||
215 | if (!sb_has_quota_active(sb, cnt)) | ||
216 | continue; | ||
217 | if (!info_dirty(&sb_dqopt(sb)->info[cnt]) && | ||
218 | list_empty(&sb_dqopt(sb)->info[cnt].dqi_dirty_list)) | ||
219 | continue; | ||
220 | break; | ||
221 | } | ||
222 | if (cnt == MAXQUOTAS) | ||
223 | continue; | ||
224 | sb->s_count++; | ||
225 | spin_unlock(&sb_lock); | ||
226 | down_read(&sb->s_umount); | ||
227 | if (sb->s_root) | ||
228 | sync_quota_sb(sb, type); | ||
229 | up_read(&sb->s_umount); | ||
230 | spin_lock(&sb_lock); | ||
231 | if (__put_super_and_need_restart(sb)) | ||
232 | goto restart; | ||
233 | } | ||
234 | spin_unlock(&sb_lock); | ||
235 | } | 219 | } |
236 | 220 | ||
237 | /* Copy parameters and call proper function */ | 221 | /* Copy parameters and call proper function */ |
@@ -240,117 +224,55 @@ static int do_quotactl(struct super_block *sb, int type, int cmd, qid_t id, | |||
240 | { | 224 | { |
241 | int ret; | 225 | int ret; |
242 | 226 | ||
227 | if (type >= (XQM_COMMAND(cmd) ? XQM_MAXQUOTAS : MAXQUOTAS)) | ||
228 | return -EINVAL; | ||
229 | if (!sb->s_qcop) | ||
230 | return -ENOSYS; | ||
231 | |||
232 | ret = check_quotactl_permission(sb, type, cmd, id); | ||
233 | if (ret < 0) | ||
234 | return ret; | ||
235 | |||
243 | switch (cmd) { | 236 | switch (cmd) { |
244 | case Q_QUOTAON: { | 237 | case Q_QUOTAON: |
245 | char *pathname; | 238 | return quota_quotaon(sb, type, cmd, id, addr); |
246 | 239 | case Q_QUOTAOFF: | |
247 | pathname = getname(addr); | 240 | if (!sb->s_qcop->quota_off) |
248 | if (IS_ERR(pathname)) | 241 | return -ENOSYS; |
249 | return PTR_ERR(pathname); | 242 | return sb->s_qcop->quota_off(sb, type, 0); |
250 | ret = sb->s_qcop->quota_on(sb, type, id, pathname, 0); | 243 | case Q_GETFMT: |
251 | putname(pathname); | 244 | return quota_getfmt(sb, type, addr); |
252 | return ret; | 245 | case Q_GETINFO: |
253 | } | 246 | return quota_getinfo(sb, type, addr); |
254 | case Q_QUOTAOFF: | 247 | case Q_SETINFO: |
255 | return sb->s_qcop->quota_off(sb, type, 0); | 248 | return quota_setinfo(sb, type, addr); |
256 | 249 | case Q_GETQUOTA: | |
257 | case Q_GETFMT: { | 250 | return quota_getquota(sb, type, id, addr); |
258 | __u32 fmt; | 251 | case Q_SETQUOTA: |
259 | 252 | return quota_setquota(sb, type, id, addr); | |
260 | down_read(&sb_dqopt(sb)->dqptr_sem); | 253 | case Q_SYNC: |
261 | if (!sb_has_quota_active(sb, type)) { | 254 | if (!sb->s_qcop->quota_sync) |
262 | up_read(&sb_dqopt(sb)->dqptr_sem); | 255 | return -ENOSYS; |
263 | return -ESRCH; | 256 | return sb->s_qcop->quota_sync(sb, type, 1); |
264 | } | 257 | case Q_XQUOTAON: |
265 | fmt = sb_dqopt(sb)->info[type].dqi_format->qf_fmt_id; | 258 | case Q_XQUOTAOFF: |
266 | up_read(&sb_dqopt(sb)->dqptr_sem); | 259 | case Q_XQUOTARM: |
267 | if (copy_to_user(addr, &fmt, sizeof(fmt))) | 260 | return quota_setxstate(sb, cmd, addr); |
268 | return -EFAULT; | 261 | case Q_XGETQSTAT: |
269 | return 0; | 262 | return quota_getxstate(sb, addr); |
270 | } | 263 | case Q_XSETQLIM: |
271 | case Q_GETINFO: { | 264 | return quota_setxquota(sb, type, id, addr); |
272 | struct if_dqinfo info; | 265 | case Q_XGETQUOTA: |
273 | 266 | return quota_getxquota(sb, type, id, addr); | |
274 | ret = sb->s_qcop->get_info(sb, type, &info); | 267 | case Q_XQUOTASYNC: |
275 | if (ret) | 268 | /* caller already holds s_umount */ |
276 | return ret; | 269 | if (sb->s_flags & MS_RDONLY) |
277 | if (copy_to_user(addr, &info, sizeof(info))) | 270 | return -EROFS; |
278 | return -EFAULT; | 271 | writeback_inodes_sb(sb); |
279 | return 0; | 272 | return 0; |
280 | } | 273 | default: |
281 | case Q_SETINFO: { | 274 | return -EINVAL; |
282 | struct if_dqinfo info; | ||
283 | |||
284 | if (copy_from_user(&info, addr, sizeof(info))) | ||
285 | return -EFAULT; | ||
286 | return sb->s_qcop->set_info(sb, type, &info); | ||
287 | } | ||
288 | case Q_GETQUOTA: { | ||
289 | struct if_dqblk idq; | ||
290 | |||
291 | ret = sb->s_qcop->get_dqblk(sb, type, id, &idq); | ||
292 | if (ret) | ||
293 | return ret; | ||
294 | if (copy_to_user(addr, &idq, sizeof(idq))) | ||
295 | return -EFAULT; | ||
296 | return 0; | ||
297 | } | ||
298 | case Q_SETQUOTA: { | ||
299 | struct if_dqblk idq; | ||
300 | |||
301 | if (copy_from_user(&idq, addr, sizeof(idq))) | ||
302 | return -EFAULT; | ||
303 | return sb->s_qcop->set_dqblk(sb, type, id, &idq); | ||
304 | } | ||
305 | case Q_SYNC: | ||
306 | if (sb) | ||
307 | sync_quota_sb(sb, type); | ||
308 | else | ||
309 | sync_dquots(type); | ||
310 | return 0; | ||
311 | |||
312 | case Q_XQUOTAON: | ||
313 | case Q_XQUOTAOFF: | ||
314 | case Q_XQUOTARM: { | ||
315 | __u32 flags; | ||
316 | |||
317 | if (copy_from_user(&flags, addr, sizeof(flags))) | ||
318 | return -EFAULT; | ||
319 | return sb->s_qcop->set_xstate(sb, flags, cmd); | ||
320 | } | ||
321 | case Q_XGETQSTAT: { | ||
322 | struct fs_quota_stat fqs; | ||
323 | |||
324 | if ((ret = sb->s_qcop->get_xstate(sb, &fqs))) | ||
325 | return ret; | ||
326 | if (copy_to_user(addr, &fqs, sizeof(fqs))) | ||
327 | return -EFAULT; | ||
328 | return 0; | ||
329 | } | ||
330 | case Q_XSETQLIM: { | ||
331 | struct fs_disk_quota fdq; | ||
332 | |||
333 | if (copy_from_user(&fdq, addr, sizeof(fdq))) | ||
334 | return -EFAULT; | ||
335 | return sb->s_qcop->set_xquota(sb, type, id, &fdq); | ||
336 | } | ||
337 | case Q_XGETQUOTA: { | ||
338 | struct fs_disk_quota fdq; | ||
339 | |||
340 | ret = sb->s_qcop->get_xquota(sb, type, id, &fdq); | ||
341 | if (ret) | ||
342 | return ret; | ||
343 | if (copy_to_user(addr, &fdq, sizeof(fdq))) | ||
344 | return -EFAULT; | ||
345 | return 0; | ||
346 | } | ||
347 | case Q_XQUOTASYNC: | ||
348 | return sb->s_qcop->quota_sync(sb, type); | ||
349 | /* We never reach here unless validity check is broken */ | ||
350 | default: | ||
351 | BUG(); | ||
352 | } | 275 | } |
353 | return 0; | ||
354 | } | 276 | } |
355 | 277 | ||
356 | /* | 278 | /* |
@@ -397,224 +319,23 @@ SYSCALL_DEFINE4(quotactl, unsigned int, cmd, const char __user *, special, | |||
397 | cmds = cmd >> SUBCMDSHIFT; | 319 | cmds = cmd >> SUBCMDSHIFT; |
398 | type = cmd & SUBCMDMASK; | 320 | type = cmd & SUBCMDMASK; |
399 | 321 | ||
400 | if (cmds != Q_SYNC || special) { | 322 | /* |
401 | sb = quotactl_block(special); | 323 | * As a special case Q_SYNC can be called without a specific device. |
402 | if (IS_ERR(sb)) | 324 | * It will iterate all superblocks that have quota enabled and call |
403 | return PTR_ERR(sb); | 325 | * the sync action on each of them. |
326 | */ | ||
327 | if (!special) { | ||
328 | if (cmds == Q_SYNC) | ||
329 | return quota_sync_all(type); | ||
330 | return -ENODEV; | ||
404 | } | 331 | } |
405 | 332 | ||
406 | ret = check_quotactl_valid(sb, type, cmds, id); | 333 | sb = quotactl_block(special); |
407 | if (ret >= 0) | 334 | if (IS_ERR(sb)) |
408 | ret = do_quotactl(sb, type, cmds, id, addr); | 335 | return PTR_ERR(sb); |
409 | if (sb) | ||
410 | drop_super(sb); | ||
411 | 336 | ||
412 | return ret; | 337 | ret = do_quotactl(sb, type, cmds, id, addr); |
413 | } | ||
414 | |||
415 | #if defined(CONFIG_COMPAT_FOR_U64_ALIGNMENT) | ||
416 | /* | ||
417 | * This code works only for 32 bit quota tools over 64 bit OS (x86_64, ia64) | ||
418 | * and is necessary due to alignment problems. | ||
419 | */ | ||
420 | struct compat_if_dqblk { | ||
421 | compat_u64 dqb_bhardlimit; | ||
422 | compat_u64 dqb_bsoftlimit; | ||
423 | compat_u64 dqb_curspace; | ||
424 | compat_u64 dqb_ihardlimit; | ||
425 | compat_u64 dqb_isoftlimit; | ||
426 | compat_u64 dqb_curinodes; | ||
427 | compat_u64 dqb_btime; | ||
428 | compat_u64 dqb_itime; | ||
429 | compat_uint_t dqb_valid; | ||
430 | }; | ||
431 | |||
432 | /* XFS structures */ | ||
433 | struct compat_fs_qfilestat { | ||
434 | compat_u64 dqb_bhardlimit; | ||
435 | compat_u64 qfs_nblks; | ||
436 | compat_uint_t qfs_nextents; | ||
437 | }; | ||
438 | |||
439 | struct compat_fs_quota_stat { | ||
440 | __s8 qs_version; | ||
441 | __u16 qs_flags; | ||
442 | __s8 qs_pad; | ||
443 | struct compat_fs_qfilestat qs_uquota; | ||
444 | struct compat_fs_qfilestat qs_gquota; | ||
445 | compat_uint_t qs_incoredqs; | ||
446 | compat_int_t qs_btimelimit; | ||
447 | compat_int_t qs_itimelimit; | ||
448 | compat_int_t qs_rtbtimelimit; | ||
449 | __u16 qs_bwarnlimit; | ||
450 | __u16 qs_iwarnlimit; | ||
451 | }; | ||
452 | |||
453 | asmlinkage long sys32_quotactl(unsigned int cmd, const char __user *special, | ||
454 | qid_t id, void __user *addr) | ||
455 | { | ||
456 | unsigned int cmds; | ||
457 | struct if_dqblk __user *dqblk; | ||
458 | struct compat_if_dqblk __user *compat_dqblk; | ||
459 | struct fs_quota_stat __user *fsqstat; | ||
460 | struct compat_fs_quota_stat __user *compat_fsqstat; | ||
461 | compat_uint_t data; | ||
462 | u16 xdata; | ||
463 | long ret; | ||
464 | 338 | ||
465 | cmds = cmd >> SUBCMDSHIFT; | 339 | drop_super(sb); |
466 | |||
467 | switch (cmds) { | ||
468 | case Q_GETQUOTA: | ||
469 | dqblk = compat_alloc_user_space(sizeof(struct if_dqblk)); | ||
470 | compat_dqblk = addr; | ||
471 | ret = sys_quotactl(cmd, special, id, dqblk); | ||
472 | if (ret) | ||
473 | break; | ||
474 | if (copy_in_user(compat_dqblk, dqblk, sizeof(*compat_dqblk)) || | ||
475 | get_user(data, &dqblk->dqb_valid) || | ||
476 | put_user(data, &compat_dqblk->dqb_valid)) | ||
477 | ret = -EFAULT; | ||
478 | break; | ||
479 | case Q_SETQUOTA: | ||
480 | dqblk = compat_alloc_user_space(sizeof(struct if_dqblk)); | ||
481 | compat_dqblk = addr; | ||
482 | ret = -EFAULT; | ||
483 | if (copy_in_user(dqblk, compat_dqblk, sizeof(*compat_dqblk)) || | ||
484 | get_user(data, &compat_dqblk->dqb_valid) || | ||
485 | put_user(data, &dqblk->dqb_valid)) | ||
486 | break; | ||
487 | ret = sys_quotactl(cmd, special, id, dqblk); | ||
488 | break; | ||
489 | case Q_XGETQSTAT: | ||
490 | fsqstat = compat_alloc_user_space(sizeof(struct fs_quota_stat)); | ||
491 | compat_fsqstat = addr; | ||
492 | ret = sys_quotactl(cmd, special, id, fsqstat); | ||
493 | if (ret) | ||
494 | break; | ||
495 | ret = -EFAULT; | ||
496 | /* Copying qs_version, qs_flags, qs_pad */ | ||
497 | if (copy_in_user(compat_fsqstat, fsqstat, | ||
498 | offsetof(struct compat_fs_quota_stat, qs_uquota))) | ||
499 | break; | ||
500 | /* Copying qs_uquota */ | ||
501 | if (copy_in_user(&compat_fsqstat->qs_uquota, | ||
502 | &fsqstat->qs_uquota, | ||
503 | sizeof(compat_fsqstat->qs_uquota)) || | ||
504 | get_user(data, &fsqstat->qs_uquota.qfs_nextents) || | ||
505 | put_user(data, &compat_fsqstat->qs_uquota.qfs_nextents)) | ||
506 | break; | ||
507 | /* Copying qs_gquota */ | ||
508 | if (copy_in_user(&compat_fsqstat->qs_gquota, | ||
509 | &fsqstat->qs_gquota, | ||
510 | sizeof(compat_fsqstat->qs_gquota)) || | ||
511 | get_user(data, &fsqstat->qs_gquota.qfs_nextents) || | ||
512 | put_user(data, &compat_fsqstat->qs_gquota.qfs_nextents)) | ||
513 | break; | ||
514 | /* Copying the rest */ | ||
515 | if (copy_in_user(&compat_fsqstat->qs_incoredqs, | ||
516 | &fsqstat->qs_incoredqs, | ||
517 | sizeof(struct compat_fs_quota_stat) - | ||
518 | offsetof(struct compat_fs_quota_stat, qs_incoredqs)) || | ||
519 | get_user(xdata, &fsqstat->qs_iwarnlimit) || | ||
520 | put_user(xdata, &compat_fsqstat->qs_iwarnlimit)) | ||
521 | break; | ||
522 | ret = 0; | ||
523 | break; | ||
524 | default: | ||
525 | ret = sys_quotactl(cmd, special, id, addr); | ||
526 | } | ||
527 | return ret; | 340 | return ret; |
528 | } | 341 | } |
529 | #endif | ||
530 | |||
531 | |||
532 | #ifdef CONFIG_QUOTA_NETLINK_INTERFACE | ||
533 | |||
534 | /* Netlink family structure for quota */ | ||
535 | static struct genl_family quota_genl_family = { | ||
536 | .id = GENL_ID_GENERATE, | ||
537 | .hdrsize = 0, | ||
538 | .name = "VFS_DQUOT", | ||
539 | .version = 1, | ||
540 | .maxattr = QUOTA_NL_A_MAX, | ||
541 | }; | ||
542 | |||
543 | /** | ||
544 | * quota_send_warning - Send warning to userspace about exceeded quota | ||
545 | * @type: The quota type: USRQQUOTA, GRPQUOTA,... | ||
546 | * @id: The user or group id of the quota that was exceeded | ||
547 | * @dev: The device on which the fs is mounted (sb->s_dev) | ||
548 | * @warntype: The type of the warning: QUOTA_NL_... | ||
549 | * | ||
550 | * This can be used by filesystems (including those which don't use | ||
551 | * dquot) to send a message to userspace relating to quota limits. | ||
552 | * | ||
553 | */ | ||
554 | |||
555 | void quota_send_warning(short type, unsigned int id, dev_t dev, | ||
556 | const char warntype) | ||
557 | { | ||
558 | static atomic_t seq; | ||
559 | struct sk_buff *skb; | ||
560 | void *msg_head; | ||
561 | int ret; | ||
562 | int msg_size = 4 * nla_total_size(sizeof(u32)) + | ||
563 | 2 * nla_total_size(sizeof(u64)); | ||
564 | |||
565 | /* We have to allocate using GFP_NOFS as we are called from a | ||
566 | * filesystem performing write and thus further recursion into | ||
567 | * the fs to free some data could cause deadlocks. */ | ||
568 | skb = genlmsg_new(msg_size, GFP_NOFS); | ||
569 | if (!skb) { | ||
570 | printk(KERN_ERR | ||
571 | "VFS: Not enough memory to send quota warning.\n"); | ||
572 | return; | ||
573 | } | ||
574 | msg_head = genlmsg_put(skb, 0, atomic_add_return(1, &seq), | ||
575 | "a_genl_family, 0, QUOTA_NL_C_WARNING); | ||
576 | if (!msg_head) { | ||
577 | printk(KERN_ERR | ||
578 | "VFS: Cannot store netlink header in quota warning.\n"); | ||
579 | goto err_out; | ||
580 | } | ||
581 | ret = nla_put_u32(skb, QUOTA_NL_A_QTYPE, type); | ||
582 | if (ret) | ||
583 | goto attr_err_out; | ||
584 | ret = nla_put_u64(skb, QUOTA_NL_A_EXCESS_ID, id); | ||
585 | if (ret) | ||
586 | goto attr_err_out; | ||
587 | ret = nla_put_u32(skb, QUOTA_NL_A_WARNING, warntype); | ||
588 | if (ret) | ||
589 | goto attr_err_out; | ||
590 | ret = nla_put_u32(skb, QUOTA_NL_A_DEV_MAJOR, MAJOR(dev)); | ||
591 | if (ret) | ||
592 | goto attr_err_out; | ||
593 | ret = nla_put_u32(skb, QUOTA_NL_A_DEV_MINOR, MINOR(dev)); | ||
594 | if (ret) | ||
595 | goto attr_err_out; | ||
596 | ret = nla_put_u64(skb, QUOTA_NL_A_CAUSED_ID, current_uid()); | ||
597 | if (ret) | ||
598 | goto attr_err_out; | ||
599 | genlmsg_end(skb, msg_head); | ||
600 | |||
601 | genlmsg_multicast(skb, 0, quota_genl_family.id, GFP_NOFS); | ||
602 | return; | ||
603 | attr_err_out: | ||
604 | printk(KERN_ERR "VFS: Not enough space to compose quota message!\n"); | ||
605 | err_out: | ||
606 | kfree_skb(skb); | ||
607 | } | ||
608 | EXPORT_SYMBOL(quota_send_warning); | ||
609 | |||
610 | static int __init quota_init(void) | ||
611 | { | ||
612 | if (genl_register_family("a_genl_family) != 0) | ||
613 | printk(KERN_ERR | ||
614 | "VFS: Failed to create quota netlink interface.\n"); | ||
615 | return 0; | ||
616 | }; | ||
617 | |||
618 | module_init(quota_init); | ||
619 | #endif | ||
620 | |||
diff --git a/fs/reiserfs/bitmap.c b/fs/reiserfs/bitmap.c index 65c872761177..dc014f7def05 100644 --- a/fs/reiserfs/bitmap.c +++ b/fs/reiserfs/bitmap.c | |||
@@ -425,7 +425,7 @@ static void _reiserfs_free_block(struct reiserfs_transaction_handle *th, | |||
425 | 425 | ||
426 | journal_mark_dirty(th, s, sbh); | 426 | journal_mark_dirty(th, s, sbh); |
427 | if (for_unformatted) | 427 | if (for_unformatted) |
428 | vfs_dq_free_block_nodirty(inode, 1); | 428 | dquot_free_block_nodirty(inode, 1); |
429 | } | 429 | } |
430 | 430 | ||
431 | void reiserfs_free_block(struct reiserfs_transaction_handle *th, | 431 | void reiserfs_free_block(struct reiserfs_transaction_handle *th, |
@@ -1049,7 +1049,7 @@ static inline int blocknrs_and_prealloc_arrays_from_search_start | |||
1049 | amount_needed, hint->inode->i_uid); | 1049 | amount_needed, hint->inode->i_uid); |
1050 | #endif | 1050 | #endif |
1051 | quota_ret = | 1051 | quota_ret = |
1052 | vfs_dq_alloc_block_nodirty(hint->inode, amount_needed); | 1052 | dquot_alloc_block_nodirty(hint->inode, amount_needed); |
1053 | if (quota_ret) /* Quota exceeded? */ | 1053 | if (quota_ret) /* Quota exceeded? */ |
1054 | return QUOTA_EXCEEDED; | 1054 | return QUOTA_EXCEEDED; |
1055 | if (hint->preallocate && hint->prealloc_size) { | 1055 | if (hint->preallocate && hint->prealloc_size) { |
@@ -1058,7 +1058,7 @@ static inline int blocknrs_and_prealloc_arrays_from_search_start | |||
1058 | "reiserquota: allocating (prealloc) %d blocks id=%u", | 1058 | "reiserquota: allocating (prealloc) %d blocks id=%u", |
1059 | hint->prealloc_size, hint->inode->i_uid); | 1059 | hint->prealloc_size, hint->inode->i_uid); |
1060 | #endif | 1060 | #endif |
1061 | quota_ret = vfs_dq_prealloc_block_nodirty(hint->inode, | 1061 | quota_ret = dquot_prealloc_block_nodirty(hint->inode, |
1062 | hint->prealloc_size); | 1062 | hint->prealloc_size); |
1063 | if (quota_ret) | 1063 | if (quota_ret) |
1064 | hint->preallocate = hint->prealloc_size = 0; | 1064 | hint->preallocate = hint->prealloc_size = 0; |
@@ -1092,7 +1092,7 @@ static inline int blocknrs_and_prealloc_arrays_from_search_start | |||
1092 | hint->inode->i_uid); | 1092 | hint->inode->i_uid); |
1093 | #endif | 1093 | #endif |
1094 | /* Free not allocated blocks */ | 1094 | /* Free not allocated blocks */ |
1095 | vfs_dq_free_block_nodirty(hint->inode, | 1095 | dquot_free_block_nodirty(hint->inode, |
1096 | amount_needed + hint->prealloc_size - | 1096 | amount_needed + hint->prealloc_size - |
1097 | nr_allocated); | 1097 | nr_allocated); |
1098 | } | 1098 | } |
@@ -1125,7 +1125,7 @@ static inline int blocknrs_and_prealloc_arrays_from_search_start | |||
1125 | REISERFS_I(hint->inode)->i_prealloc_count, | 1125 | REISERFS_I(hint->inode)->i_prealloc_count, |
1126 | hint->inode->i_uid); | 1126 | hint->inode->i_uid); |
1127 | #endif | 1127 | #endif |
1128 | vfs_dq_free_block_nodirty(hint->inode, amount_needed + | 1128 | dquot_free_block_nodirty(hint->inode, amount_needed + |
1129 | hint->prealloc_size - nr_allocated - | 1129 | hint->prealloc_size - nr_allocated - |
1130 | REISERFS_I(hint->inode)-> | 1130 | REISERFS_I(hint->inode)-> |
1131 | i_prealloc_count); | 1131 | i_prealloc_count); |
diff --git a/fs/reiserfs/file.c b/fs/reiserfs/file.c index da2dba082e2d..1d9c12714c5c 100644 --- a/fs/reiserfs/file.c +++ b/fs/reiserfs/file.c | |||
@@ -289,7 +289,7 @@ const struct file_operations reiserfs_file_operations = { | |||
289 | .compat_ioctl = reiserfs_compat_ioctl, | 289 | .compat_ioctl = reiserfs_compat_ioctl, |
290 | #endif | 290 | #endif |
291 | .mmap = reiserfs_file_mmap, | 291 | .mmap = reiserfs_file_mmap, |
292 | .open = generic_file_open, | 292 | .open = dquot_file_open, |
293 | .release = reiserfs_file_release, | 293 | .release = reiserfs_file_release, |
294 | .fsync = reiserfs_sync_file, | 294 | .fsync = reiserfs_sync_file, |
295 | .aio_read = generic_file_aio_read, | 295 | .aio_read = generic_file_aio_read, |
diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c index 2df0f5c7c60b..d1da94b82d8f 100644 --- a/fs/reiserfs/inode.c +++ b/fs/reiserfs/inode.c | |||
@@ -34,6 +34,9 @@ void reiserfs_delete_inode(struct inode *inode) | |||
34 | int depth; | 34 | int depth; |
35 | int err; | 35 | int err; |
36 | 36 | ||
37 | if (!is_bad_inode(inode)) | ||
38 | dquot_initialize(inode); | ||
39 | |||
37 | truncate_inode_pages(&inode->i_data, 0); | 40 | truncate_inode_pages(&inode->i_data, 0); |
38 | 41 | ||
39 | depth = reiserfs_write_lock_once(inode->i_sb); | 42 | depth = reiserfs_write_lock_once(inode->i_sb); |
@@ -54,7 +57,7 @@ void reiserfs_delete_inode(struct inode *inode) | |||
54 | * after delete_object so that quota updates go into the same transaction as | 57 | * after delete_object so that quota updates go into the same transaction as |
55 | * stat data deletion */ | 58 | * stat data deletion */ |
56 | if (!err) | 59 | if (!err) |
57 | vfs_dq_free_inode(inode); | 60 | dquot_free_inode(inode); |
58 | 61 | ||
59 | if (journal_end(&th, inode->i_sb, jbegin_count)) | 62 | if (journal_end(&th, inode->i_sb, jbegin_count)) |
60 | goto out; | 63 | goto out; |
@@ -1615,7 +1618,7 @@ int reiserfs_encode_fh(struct dentry *dentry, __u32 * data, int *lenp, | |||
1615 | ** to properly mark inodes for datasync and such, but only actually | 1618 | ** to properly mark inodes for datasync and such, but only actually |
1616 | ** does something when called for a synchronous update. | 1619 | ** does something when called for a synchronous update. |
1617 | */ | 1620 | */ |
1618 | int reiserfs_write_inode(struct inode *inode, int do_sync) | 1621 | int reiserfs_write_inode(struct inode *inode, struct writeback_control *wbc) |
1619 | { | 1622 | { |
1620 | struct reiserfs_transaction_handle th; | 1623 | struct reiserfs_transaction_handle th; |
1621 | int jbegin_count = 1; | 1624 | int jbegin_count = 1; |
@@ -1627,7 +1630,7 @@ int reiserfs_write_inode(struct inode *inode, int do_sync) | |||
1627 | ** inode needs to reach disk for safety, and they can safely be | 1630 | ** inode needs to reach disk for safety, and they can safely be |
1628 | ** ignored because the altered inode has already been logged. | 1631 | ** ignored because the altered inode has already been logged. |
1629 | */ | 1632 | */ |
1630 | if (do_sync && !(current->flags & PF_MEMALLOC)) { | 1633 | if (wbc->sync_mode == WB_SYNC_ALL && !(current->flags & PF_MEMALLOC)) { |
1631 | reiserfs_write_lock(inode->i_sb); | 1634 | reiserfs_write_lock(inode->i_sb); |
1632 | if (!journal_begin(&th, inode->i_sb, jbegin_count)) { | 1635 | if (!journal_begin(&th, inode->i_sb, jbegin_count)) { |
1633 | reiserfs_update_sd(&th, inode); | 1636 | reiserfs_update_sd(&th, inode); |
@@ -1765,10 +1768,10 @@ int reiserfs_new_inode(struct reiserfs_transaction_handle *th, | |||
1765 | 1768 | ||
1766 | BUG_ON(!th->t_trans_id); | 1769 | BUG_ON(!th->t_trans_id); |
1767 | 1770 | ||
1768 | if (vfs_dq_alloc_inode(inode)) { | 1771 | dquot_initialize(inode); |
1769 | err = -EDQUOT; | 1772 | err = dquot_alloc_inode(inode); |
1773 | if (err) | ||
1770 | goto out_end_trans; | 1774 | goto out_end_trans; |
1771 | } | ||
1772 | if (!dir->i_nlink) { | 1775 | if (!dir->i_nlink) { |
1773 | err = -EPERM; | 1776 | err = -EPERM; |
1774 | goto out_bad_inode; | 1777 | goto out_bad_inode; |
@@ -1959,12 +1962,12 @@ int reiserfs_new_inode(struct reiserfs_transaction_handle *th, | |||
1959 | INODE_PKEY(inode)->k_objectid = 0; | 1962 | INODE_PKEY(inode)->k_objectid = 0; |
1960 | 1963 | ||
1961 | /* Quota change must be inside a transaction for journaling */ | 1964 | /* Quota change must be inside a transaction for journaling */ |
1962 | vfs_dq_free_inode(inode); | 1965 | dquot_free_inode(inode); |
1963 | 1966 | ||
1964 | out_end_trans: | 1967 | out_end_trans: |
1965 | journal_end(th, th->t_super, th->t_blocks_allocated); | 1968 | journal_end(th, th->t_super, th->t_blocks_allocated); |
1966 | /* Drop can be outside and it needs more credits so it's better to have it outside */ | 1969 | /* Drop can be outside and it needs more credits so it's better to have it outside */ |
1967 | vfs_dq_drop(inode); | 1970 | dquot_drop(inode); |
1968 | inode->i_flags |= S_NOQUOTA; | 1971 | inode->i_flags |= S_NOQUOTA; |
1969 | make_bad_inode(inode); | 1972 | make_bad_inode(inode); |
1970 | 1973 | ||
@@ -3073,6 +3076,8 @@ int reiserfs_setattr(struct dentry *dentry, struct iattr *attr) | |||
3073 | 3076 | ||
3074 | depth = reiserfs_write_lock_once(inode->i_sb); | 3077 | depth = reiserfs_write_lock_once(inode->i_sb); |
3075 | if (attr->ia_valid & ATTR_SIZE) { | 3078 | if (attr->ia_valid & ATTR_SIZE) { |
3079 | dquot_initialize(inode); | ||
3080 | |||
3076 | /* version 2 items will be caught by the s_maxbytes check | 3081 | /* version 2 items will be caught by the s_maxbytes check |
3077 | ** done for us in vmtruncate | 3082 | ** done for us in vmtruncate |
3078 | */ | 3083 | */ |
@@ -3134,8 +3139,7 @@ int reiserfs_setattr(struct dentry *dentry, struct iattr *attr) | |||
3134 | jbegin_count); | 3139 | jbegin_count); |
3135 | if (error) | 3140 | if (error) |
3136 | goto out; | 3141 | goto out; |
3137 | error = | 3142 | error = dquot_transfer(inode, attr); |
3138 | vfs_dq_transfer(inode, attr) ? -EDQUOT : 0; | ||
3139 | if (error) { | 3143 | if (error) { |
3140 | journal_end(&th, inode->i_sb, | 3144 | journal_end(&th, inode->i_sb, |
3141 | jbegin_count); | 3145 | jbegin_count); |
diff --git a/fs/reiserfs/namei.c b/fs/reiserfs/namei.c index 9d4dcf0b07cb..96e4cbbfaa18 100644 --- a/fs/reiserfs/namei.c +++ b/fs/reiserfs/namei.c | |||
@@ -546,7 +546,7 @@ static int reiserfs_add_entry(struct reiserfs_transaction_handle *th, | |||
546 | */ | 546 | */ |
547 | static int drop_new_inode(struct inode *inode) | 547 | static int drop_new_inode(struct inode *inode) |
548 | { | 548 | { |
549 | vfs_dq_drop(inode); | 549 | dquot_drop(inode); |
550 | make_bad_inode(inode); | 550 | make_bad_inode(inode); |
551 | inode->i_flags |= S_NOQUOTA; | 551 | inode->i_flags |= S_NOQUOTA; |
552 | iput(inode); | 552 | iput(inode); |
@@ -554,7 +554,7 @@ static int drop_new_inode(struct inode *inode) | |||
554 | } | 554 | } |
555 | 555 | ||
556 | /* utility function that does setup for reiserfs_new_inode. | 556 | /* utility function that does setup for reiserfs_new_inode. |
557 | ** vfs_dq_init needs lots of credits so it's better to have it | 557 | ** dquot_initialize needs lots of credits so it's better to have it |
558 | ** outside of a transaction, so we had to pull some bits of | 558 | ** outside of a transaction, so we had to pull some bits of |
559 | ** reiserfs_new_inode out into this func. | 559 | ** reiserfs_new_inode out into this func. |
560 | */ | 560 | */ |
@@ -577,7 +577,7 @@ static int new_inode_init(struct inode *inode, struct inode *dir, int mode) | |||
577 | } else { | 577 | } else { |
578 | inode->i_gid = current_fsgid(); | 578 | inode->i_gid = current_fsgid(); |
579 | } | 579 | } |
580 | vfs_dq_init(inode); | 580 | dquot_initialize(inode); |
581 | return 0; | 581 | return 0; |
582 | } | 582 | } |
583 | 583 | ||
@@ -594,6 +594,8 @@ static int reiserfs_create(struct inode *dir, struct dentry *dentry, int mode, | |||
594 | struct reiserfs_transaction_handle th; | 594 | struct reiserfs_transaction_handle th; |
595 | struct reiserfs_security_handle security; | 595 | struct reiserfs_security_handle security; |
596 | 596 | ||
597 | dquot_initialize(dir); | ||
598 | |||
597 | if (!(inode = new_inode(dir->i_sb))) { | 599 | if (!(inode = new_inode(dir->i_sb))) { |
598 | return -ENOMEM; | 600 | return -ENOMEM; |
599 | } | 601 | } |
@@ -666,6 +668,8 @@ static int reiserfs_mknod(struct inode *dir, struct dentry *dentry, int mode, | |||
666 | if (!new_valid_dev(rdev)) | 668 | if (!new_valid_dev(rdev)) |
667 | return -EINVAL; | 669 | return -EINVAL; |
668 | 670 | ||
671 | dquot_initialize(dir); | ||
672 | |||
669 | if (!(inode = new_inode(dir->i_sb))) { | 673 | if (!(inode = new_inode(dir->i_sb))) { |
670 | return -ENOMEM; | 674 | return -ENOMEM; |
671 | } | 675 | } |
@@ -739,6 +743,8 @@ static int reiserfs_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
739 | 2 * (REISERFS_QUOTA_INIT_BLOCKS(dir->i_sb) + | 743 | 2 * (REISERFS_QUOTA_INIT_BLOCKS(dir->i_sb) + |
740 | REISERFS_QUOTA_TRANS_BLOCKS(dir->i_sb)); | 744 | REISERFS_QUOTA_TRANS_BLOCKS(dir->i_sb)); |
741 | 745 | ||
746 | dquot_initialize(dir); | ||
747 | |||
742 | #ifdef DISPLACE_NEW_PACKING_LOCALITIES | 748 | #ifdef DISPLACE_NEW_PACKING_LOCALITIES |
743 | /* set flag that new packing locality created and new blocks for the content * of that directory are not displaced yet */ | 749 | /* set flag that new packing locality created and new blocks for the content * of that directory are not displaced yet */ |
744 | REISERFS_I(dir)->new_packing_locality = 1; | 750 | REISERFS_I(dir)->new_packing_locality = 1; |
@@ -842,6 +848,8 @@ static int reiserfs_rmdir(struct inode *dir, struct dentry *dentry) | |||
842 | JOURNAL_PER_BALANCE_CNT * 2 + 2 + | 848 | JOURNAL_PER_BALANCE_CNT * 2 + 2 + |
843 | 4 * REISERFS_QUOTA_TRANS_BLOCKS(dir->i_sb); | 849 | 4 * REISERFS_QUOTA_TRANS_BLOCKS(dir->i_sb); |
844 | 850 | ||
851 | dquot_initialize(dir); | ||
852 | |||
845 | reiserfs_write_lock(dir->i_sb); | 853 | reiserfs_write_lock(dir->i_sb); |
846 | retval = journal_begin(&th, dir->i_sb, jbegin_count); | 854 | retval = journal_begin(&th, dir->i_sb, jbegin_count); |
847 | if (retval) | 855 | if (retval) |
@@ -923,6 +931,8 @@ static int reiserfs_unlink(struct inode *dir, struct dentry *dentry) | |||
923 | unsigned long savelink; | 931 | unsigned long savelink; |
924 | int depth; | 932 | int depth; |
925 | 933 | ||
934 | dquot_initialize(dir); | ||
935 | |||
926 | inode = dentry->d_inode; | 936 | inode = dentry->d_inode; |
927 | 937 | ||
928 | /* in this transaction we can be doing at max two balancings and update | 938 | /* in this transaction we can be doing at max two balancings and update |
@@ -1024,6 +1034,8 @@ static int reiserfs_symlink(struct inode *parent_dir, | |||
1024 | 2 * (REISERFS_QUOTA_INIT_BLOCKS(parent_dir->i_sb) + | 1034 | 2 * (REISERFS_QUOTA_INIT_BLOCKS(parent_dir->i_sb) + |
1025 | REISERFS_QUOTA_TRANS_BLOCKS(parent_dir->i_sb)); | 1035 | REISERFS_QUOTA_TRANS_BLOCKS(parent_dir->i_sb)); |
1026 | 1036 | ||
1037 | dquot_initialize(parent_dir); | ||
1038 | |||
1027 | if (!(inode = new_inode(parent_dir->i_sb))) { | 1039 | if (!(inode = new_inode(parent_dir->i_sb))) { |
1028 | return -ENOMEM; | 1040 | return -ENOMEM; |
1029 | } | 1041 | } |
@@ -1111,6 +1123,8 @@ static int reiserfs_link(struct dentry *old_dentry, struct inode *dir, | |||
1111 | JOURNAL_PER_BALANCE_CNT * 3 + | 1123 | JOURNAL_PER_BALANCE_CNT * 3 + |
1112 | 2 * REISERFS_QUOTA_TRANS_BLOCKS(dir->i_sb); | 1124 | 2 * REISERFS_QUOTA_TRANS_BLOCKS(dir->i_sb); |
1113 | 1125 | ||
1126 | dquot_initialize(dir); | ||
1127 | |||
1114 | reiserfs_write_lock(dir->i_sb); | 1128 | reiserfs_write_lock(dir->i_sb); |
1115 | if (inode->i_nlink >= REISERFS_LINK_MAX) { | 1129 | if (inode->i_nlink >= REISERFS_LINK_MAX) { |
1116 | //FIXME: sd_nlink is 32 bit for new files | 1130 | //FIXME: sd_nlink is 32 bit for new files |
@@ -1235,6 +1249,9 @@ static int reiserfs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
1235 | JOURNAL_PER_BALANCE_CNT * 3 + 5 + | 1249 | JOURNAL_PER_BALANCE_CNT * 3 + 5 + |
1236 | 4 * REISERFS_QUOTA_TRANS_BLOCKS(old_dir->i_sb); | 1250 | 4 * REISERFS_QUOTA_TRANS_BLOCKS(old_dir->i_sb); |
1237 | 1251 | ||
1252 | dquot_initialize(old_dir); | ||
1253 | dquot_initialize(new_dir); | ||
1254 | |||
1238 | old_inode = old_dentry->d_inode; | 1255 | old_inode = old_dentry->d_inode; |
1239 | new_dentry_inode = new_dentry->d_inode; | 1256 | new_dentry_inode = new_dentry->d_inode; |
1240 | 1257 | ||
diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c index 5fa7118f04e1..313d39d639eb 100644 --- a/fs/reiserfs/stree.c +++ b/fs/reiserfs/stree.c | |||
@@ -1299,7 +1299,7 @@ int reiserfs_delete_item(struct reiserfs_transaction_handle *th, | |||
1299 | "reiserquota delete_item(): freeing %u, id=%u type=%c", | 1299 | "reiserquota delete_item(): freeing %u, id=%u type=%c", |
1300 | quota_cut_bytes, inode->i_uid, head2type(&s_ih)); | 1300 | quota_cut_bytes, inode->i_uid, head2type(&s_ih)); |
1301 | #endif | 1301 | #endif |
1302 | vfs_dq_free_space_nodirty(inode, quota_cut_bytes); | 1302 | dquot_free_space_nodirty(inode, quota_cut_bytes); |
1303 | 1303 | ||
1304 | /* Return deleted body length */ | 1304 | /* Return deleted body length */ |
1305 | return ret_value; | 1305 | return ret_value; |
@@ -1383,7 +1383,7 @@ void reiserfs_delete_solid_item(struct reiserfs_transaction_handle *th, | |||
1383 | quota_cut_bytes, inode->i_uid, | 1383 | quota_cut_bytes, inode->i_uid, |
1384 | key2type(key)); | 1384 | key2type(key)); |
1385 | #endif | 1385 | #endif |
1386 | vfs_dq_free_space_nodirty(inode, | 1386 | dquot_free_space_nodirty(inode, |
1387 | quota_cut_bytes); | 1387 | quota_cut_bytes); |
1388 | } | 1388 | } |
1389 | break; | 1389 | break; |
@@ -1733,7 +1733,7 @@ int reiserfs_cut_from_item(struct reiserfs_transaction_handle *th, | |||
1733 | "reiserquota cut_from_item(): freeing %u id=%u type=%c", | 1733 | "reiserquota cut_from_item(): freeing %u id=%u type=%c", |
1734 | quota_cut_bytes, inode->i_uid, '?'); | 1734 | quota_cut_bytes, inode->i_uid, '?'); |
1735 | #endif | 1735 | #endif |
1736 | vfs_dq_free_space_nodirty(inode, quota_cut_bytes); | 1736 | dquot_free_space_nodirty(inode, quota_cut_bytes); |
1737 | return ret_value; | 1737 | return ret_value; |
1738 | } | 1738 | } |
1739 | 1739 | ||
@@ -1968,9 +1968,10 @@ int reiserfs_paste_into_item(struct reiserfs_transaction_handle *th, struct tree | |||
1968 | key2type(&(key->on_disk_key))); | 1968 | key2type(&(key->on_disk_key))); |
1969 | #endif | 1969 | #endif |
1970 | 1970 | ||
1971 | if (vfs_dq_alloc_space_nodirty(inode, pasted_size)) { | 1971 | retval = dquot_alloc_space_nodirty(inode, pasted_size); |
1972 | if (retval) { | ||
1972 | pathrelse(search_path); | 1973 | pathrelse(search_path); |
1973 | return -EDQUOT; | 1974 | return retval; |
1974 | } | 1975 | } |
1975 | init_tb_struct(th, &s_paste_balance, th->t_super, search_path, | 1976 | init_tb_struct(th, &s_paste_balance, th->t_super, search_path, |
1976 | pasted_size); | 1977 | pasted_size); |
@@ -2024,7 +2025,7 @@ int reiserfs_paste_into_item(struct reiserfs_transaction_handle *th, struct tree | |||
2024 | pasted_size, inode->i_uid, | 2025 | pasted_size, inode->i_uid, |
2025 | key2type(&(key->on_disk_key))); | 2026 | key2type(&(key->on_disk_key))); |
2026 | #endif | 2027 | #endif |
2027 | vfs_dq_free_space_nodirty(inode, pasted_size); | 2028 | dquot_free_space_nodirty(inode, pasted_size); |
2028 | return retval; | 2029 | return retval; |
2029 | } | 2030 | } |
2030 | 2031 | ||
@@ -2062,9 +2063,10 @@ int reiserfs_insert_item(struct reiserfs_transaction_handle *th, | |||
2062 | #endif | 2063 | #endif |
2063 | /* We can't dirty inode here. It would be immediately written but | 2064 | /* We can't dirty inode here. It would be immediately written but |
2064 | * appropriate stat item isn't inserted yet... */ | 2065 | * appropriate stat item isn't inserted yet... */ |
2065 | if (vfs_dq_alloc_space_nodirty(inode, quota_bytes)) { | 2066 | retval = dquot_alloc_space_nodirty(inode, quota_bytes); |
2067 | if (retval) { | ||
2066 | pathrelse(path); | 2068 | pathrelse(path); |
2067 | return -EDQUOT; | 2069 | return retval; |
2068 | } | 2070 | } |
2069 | } | 2071 | } |
2070 | init_tb_struct(th, &s_ins_balance, th->t_super, path, | 2072 | init_tb_struct(th, &s_ins_balance, th->t_super, path, |
@@ -2113,6 +2115,6 @@ int reiserfs_insert_item(struct reiserfs_transaction_handle *th, | |||
2113 | quota_bytes, inode->i_uid, head2type(ih)); | 2115 | quota_bytes, inode->i_uid, head2type(ih)); |
2114 | #endif | 2116 | #endif |
2115 | if (inode) | 2117 | if (inode) |
2116 | vfs_dq_free_space_nodirty(inode, quota_bytes); | 2118 | dquot_free_space_nodirty(inode, quota_bytes); |
2117 | return retval; | 2119 | return retval; |
2118 | } | 2120 | } |
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c index b4a7dd03bdb9..04bf5d791bda 100644 --- a/fs/reiserfs/super.c +++ b/fs/reiserfs/super.c | |||
@@ -246,7 +246,7 @@ static int finish_unfinished(struct super_block *s) | |||
246 | retval = remove_save_link_only(s, &save_link_key, 0); | 246 | retval = remove_save_link_only(s, &save_link_key, 0); |
247 | continue; | 247 | continue; |
248 | } | 248 | } |
249 | vfs_dq_init(inode); | 249 | dquot_initialize(inode); |
250 | 250 | ||
251 | if (truncate && S_ISDIR(inode->i_mode)) { | 251 | if (truncate && S_ISDIR(inode->i_mode)) { |
252 | /* We got a truncate request for a dir which is impossible. | 252 | /* We got a truncate request for a dir which is impossible. |
@@ -578,6 +578,11 @@ out: | |||
578 | reiserfs_write_unlock_once(inode->i_sb, lock_depth); | 578 | reiserfs_write_unlock_once(inode->i_sb, lock_depth); |
579 | } | 579 | } |
580 | 580 | ||
581 | static void reiserfs_clear_inode(struct inode *inode) | ||
582 | { | ||
583 | dquot_drop(inode); | ||
584 | } | ||
585 | |||
581 | #ifdef CONFIG_QUOTA | 586 | #ifdef CONFIG_QUOTA |
582 | static ssize_t reiserfs_quota_write(struct super_block *, int, const char *, | 587 | static ssize_t reiserfs_quota_write(struct super_block *, int, const char *, |
583 | size_t, loff_t); | 588 | size_t, loff_t); |
@@ -590,6 +595,7 @@ static const struct super_operations reiserfs_sops = { | |||
590 | .destroy_inode = reiserfs_destroy_inode, | 595 | .destroy_inode = reiserfs_destroy_inode, |
591 | .write_inode = reiserfs_write_inode, | 596 | .write_inode = reiserfs_write_inode, |
592 | .dirty_inode = reiserfs_dirty_inode, | 597 | .dirty_inode = reiserfs_dirty_inode, |
598 | .clear_inode = reiserfs_clear_inode, | ||
593 | .delete_inode = reiserfs_delete_inode, | 599 | .delete_inode = reiserfs_delete_inode, |
594 | .put_super = reiserfs_put_super, | 600 | .put_super = reiserfs_put_super, |
595 | .write_super = reiserfs_write_super, | 601 | .write_super = reiserfs_write_super, |
@@ -616,13 +622,6 @@ static int reiserfs_write_info(struct super_block *, int); | |||
616 | static int reiserfs_quota_on(struct super_block *, int, int, char *, int); | 622 | static int reiserfs_quota_on(struct super_block *, int, int, char *, int); |
617 | 623 | ||
618 | static const struct dquot_operations reiserfs_quota_operations = { | 624 | static const struct dquot_operations reiserfs_quota_operations = { |
619 | .initialize = dquot_initialize, | ||
620 | .drop = dquot_drop, | ||
621 | .alloc_space = dquot_alloc_space, | ||
622 | .alloc_inode = dquot_alloc_inode, | ||
623 | .free_space = dquot_free_space, | ||
624 | .free_inode = dquot_free_inode, | ||
625 | .transfer = dquot_transfer, | ||
626 | .write_dquot = reiserfs_write_dquot, | 625 | .write_dquot = reiserfs_write_dquot, |
627 | .acquire_dquot = reiserfs_acquire_dquot, | 626 | .acquire_dquot = reiserfs_acquire_dquot, |
628 | .release_dquot = reiserfs_release_dquot, | 627 | .release_dquot = reiserfs_release_dquot, |
diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c index 81f09fab8ae4..37d034ca7d99 100644 --- a/fs/reiserfs/xattr.c +++ b/fs/reiserfs/xattr.c | |||
@@ -61,7 +61,6 @@ | |||
61 | static int xattr_create(struct inode *dir, struct dentry *dentry, int mode) | 61 | static int xattr_create(struct inode *dir, struct dentry *dentry, int mode) |
62 | { | 62 | { |
63 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); | 63 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); |
64 | vfs_dq_init(dir); | ||
65 | return dir->i_op->create(dir, dentry, mode, NULL); | 64 | return dir->i_op->create(dir, dentry, mode, NULL); |
66 | } | 65 | } |
67 | #endif | 66 | #endif |
@@ -69,7 +68,6 @@ static int xattr_create(struct inode *dir, struct dentry *dentry, int mode) | |||
69 | static int xattr_mkdir(struct inode *dir, struct dentry *dentry, int mode) | 68 | static int xattr_mkdir(struct inode *dir, struct dentry *dentry, int mode) |
70 | { | 69 | { |
71 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); | 70 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); |
72 | vfs_dq_init(dir); | ||
73 | return dir->i_op->mkdir(dir, dentry, mode); | 71 | return dir->i_op->mkdir(dir, dentry, mode); |
74 | } | 72 | } |
75 | 73 | ||
@@ -81,7 +79,6 @@ static int xattr_unlink(struct inode *dir, struct dentry *dentry) | |||
81 | { | 79 | { |
82 | int error; | 80 | int error; |
83 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); | 81 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); |
84 | vfs_dq_init(dir); | ||
85 | 82 | ||
86 | reiserfs_mutex_lock_nested_safe(&dentry->d_inode->i_mutex, | 83 | reiserfs_mutex_lock_nested_safe(&dentry->d_inode->i_mutex, |
87 | I_MUTEX_CHILD, dir->i_sb); | 84 | I_MUTEX_CHILD, dir->i_sb); |
@@ -97,7 +94,6 @@ static int xattr_rmdir(struct inode *dir, struct dentry *dentry) | |||
97 | { | 94 | { |
98 | int error; | 95 | int error; |
99 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); | 96 | BUG_ON(!mutex_is_locked(&dir->i_mutex)); |
100 | vfs_dq_init(dir); | ||
101 | 97 | ||
102 | reiserfs_mutex_lock_nested_safe(&dentry->d_inode->i_mutex, | 98 | reiserfs_mutex_lock_nested_safe(&dentry->d_inode->i_mutex, |
103 | I_MUTEX_CHILD, dir->i_sb); | 99 | I_MUTEX_CHILD, dir->i_sb); |
diff --git a/fs/select.c b/fs/select.c index fd38ce2e32e3..73715e90030f 100644 --- a/fs/select.c +++ b/fs/select.c | |||
@@ -821,7 +821,7 @@ int do_sys_poll(struct pollfd __user *ufds, unsigned int nfds, | |||
821 | struct poll_list *walk = head; | 821 | struct poll_list *walk = head; |
822 | unsigned long todo = nfds; | 822 | unsigned long todo = nfds; |
823 | 823 | ||
824 | if (nfds > current->signal->rlim[RLIMIT_NOFILE].rlim_cur) | 824 | if (nfds > rlimit(RLIMIT_NOFILE)) |
825 | return -EINVAL; | 825 | return -EINVAL; |
826 | 826 | ||
827 | len = min_t(unsigned int, nfds, N_STACK_PPS); | 827 | len = min_t(unsigned int, nfds, N_STACK_PPS); |
diff --git a/fs/seq_file.c b/fs/seq_file.c index eae7d9dbf3ff..e1f437be6c3c 100644 --- a/fs/seq_file.c +++ b/fs/seq_file.c | |||
@@ -674,7 +674,6 @@ struct list_head *seq_list_start(struct list_head *head, loff_t pos) | |||
674 | 674 | ||
675 | return NULL; | 675 | return NULL; |
676 | } | 676 | } |
677 | |||
678 | EXPORT_SYMBOL(seq_list_start); | 677 | EXPORT_SYMBOL(seq_list_start); |
679 | 678 | ||
680 | struct list_head *seq_list_start_head(struct list_head *head, loff_t pos) | 679 | struct list_head *seq_list_start_head(struct list_head *head, loff_t pos) |
@@ -684,7 +683,6 @@ struct list_head *seq_list_start_head(struct list_head *head, loff_t pos) | |||
684 | 683 | ||
685 | return seq_list_start(head, pos - 1); | 684 | return seq_list_start(head, pos - 1); |
686 | } | 685 | } |
687 | |||
688 | EXPORT_SYMBOL(seq_list_start_head); | 686 | EXPORT_SYMBOL(seq_list_start_head); |
689 | 687 | ||
690 | struct list_head *seq_list_next(void *v, struct list_head *head, loff_t *ppos) | 688 | struct list_head *seq_list_next(void *v, struct list_head *head, loff_t *ppos) |
@@ -695,5 +693,131 @@ struct list_head *seq_list_next(void *v, struct list_head *head, loff_t *ppos) | |||
695 | ++*ppos; | 693 | ++*ppos; |
696 | return lh == head ? NULL : lh; | 694 | return lh == head ? NULL : lh; |
697 | } | 695 | } |
698 | |||
699 | EXPORT_SYMBOL(seq_list_next); | 696 | EXPORT_SYMBOL(seq_list_next); |
697 | |||
698 | /** | ||
699 | * seq_hlist_start - start an iteration of a hlist | ||
700 | * @head: the head of the hlist | ||
701 | * @pos: the start position of the sequence | ||
702 | * | ||
703 | * Called at seq_file->op->start(). | ||
704 | */ | ||
705 | struct hlist_node *seq_hlist_start(struct hlist_head *head, loff_t pos) | ||
706 | { | ||
707 | struct hlist_node *node; | ||
708 | |||
709 | hlist_for_each(node, head) | ||
710 | if (pos-- == 0) | ||
711 | return node; | ||
712 | return NULL; | ||
713 | } | ||
714 | EXPORT_SYMBOL(seq_hlist_start); | ||
715 | |||
716 | /** | ||
717 | * seq_hlist_start_head - start an iteration of a hlist | ||
718 | * @head: the head of the hlist | ||
719 | * @pos: the start position of the sequence | ||
720 | * | ||
721 | * Called at seq_file->op->start(). Call this function if you want to | ||
722 | * print a header at the top of the output. | ||
723 | */ | ||
724 | struct hlist_node *seq_hlist_start_head(struct hlist_head *head, loff_t pos) | ||
725 | { | ||
726 | if (!pos) | ||
727 | return SEQ_START_TOKEN; | ||
728 | |||
729 | return seq_hlist_start(head, pos - 1); | ||
730 | } | ||
731 | EXPORT_SYMBOL(seq_hlist_start_head); | ||
732 | |||
733 | /** | ||
734 | * seq_hlist_next - move to the next position of the hlist | ||
735 | * @v: the current iterator | ||
736 | * @head: the head of the hlist | ||
737 | * @ppos: the current position | ||
738 | * | ||
739 | * Called at seq_file->op->next(). | ||
740 | */ | ||
741 | struct hlist_node *seq_hlist_next(void *v, struct hlist_head *head, | ||
742 | loff_t *ppos) | ||
743 | { | ||
744 | struct hlist_node *node = v; | ||
745 | |||
746 | ++*ppos; | ||
747 | if (v == SEQ_START_TOKEN) | ||
748 | return head->first; | ||
749 | else | ||
750 | return node->next; | ||
751 | } | ||
752 | EXPORT_SYMBOL(seq_hlist_next); | ||
753 | |||
754 | /** | ||
755 | * seq_hlist_start_rcu - start an iteration of a hlist protected by RCU | ||
756 | * @head: the head of the hlist | ||
757 | * @pos: the start position of the sequence | ||
758 | * | ||
759 | * Called at seq_file->op->start(). | ||
760 | * | ||
761 | * This list-traversal primitive may safely run concurrently with | ||
762 | * the _rcu list-mutation primitives such as hlist_add_head_rcu() | ||
763 | * as long as the traversal is guarded by rcu_read_lock(). | ||
764 | */ | ||
765 | struct hlist_node *seq_hlist_start_rcu(struct hlist_head *head, | ||
766 | loff_t pos) | ||
767 | { | ||
768 | struct hlist_node *node; | ||
769 | |||
770 | __hlist_for_each_rcu(node, head) | ||
771 | if (pos-- == 0) | ||
772 | return node; | ||
773 | return NULL; | ||
774 | } | ||
775 | EXPORT_SYMBOL(seq_hlist_start_rcu); | ||
776 | |||
777 | /** | ||
778 | * seq_hlist_start_head_rcu - start an iteration of a hlist protected by RCU | ||
779 | * @head: the head of the hlist | ||
780 | * @pos: the start position of the sequence | ||
781 | * | ||
782 | * Called at seq_file->op->start(). Call this function if you want to | ||
783 | * print a header at the top of the output. | ||
784 | * | ||
785 | * This list-traversal primitive may safely run concurrently with | ||
786 | * the _rcu list-mutation primitives such as hlist_add_head_rcu() | ||
787 | * as long as the traversal is guarded by rcu_read_lock(). | ||
788 | */ | ||
789 | struct hlist_node *seq_hlist_start_head_rcu(struct hlist_head *head, | ||
790 | loff_t pos) | ||
791 | { | ||
792 | if (!pos) | ||
793 | return SEQ_START_TOKEN; | ||
794 | |||
795 | return seq_hlist_start_rcu(head, pos - 1); | ||
796 | } | ||
797 | EXPORT_SYMBOL(seq_hlist_start_head_rcu); | ||
798 | |||
799 | /** | ||
800 | * seq_hlist_next_rcu - move to the next position of the hlist protected by RCU | ||
801 | * @v: the current iterator | ||
802 | * @head: the head of the hlist | ||
803 | * @ppos: the current position | ||
804 | * | ||
805 | * Called at seq_file->op->next(). | ||
806 | * | ||
807 | * This list-traversal primitive may safely run concurrently with | ||
808 | * the _rcu list-mutation primitives such as hlist_add_head_rcu() | ||
809 | * as long as the traversal is guarded by rcu_read_lock(). | ||
810 | */ | ||
811 | struct hlist_node *seq_hlist_next_rcu(void *v, | ||
812 | struct hlist_head *head, | ||
813 | loff_t *ppos) | ||
814 | { | ||
815 | struct hlist_node *node = v; | ||
816 | |||
817 | ++*ppos; | ||
818 | if (v == SEQ_START_TOKEN) | ||
819 | return rcu_dereference(head->first); | ||
820 | else | ||
821 | return rcu_dereference(node->next); | ||
822 | } | ||
823 | EXPORT_SYMBOL(seq_hlist_next_rcu); | ||
diff --git a/fs/squashfs/Makefile b/fs/squashfs/Makefile index 70e3244fa30f..df8a19ef870d 100644 --- a/fs/squashfs/Makefile +++ b/fs/squashfs/Makefile | |||
@@ -4,4 +4,4 @@ | |||
4 | 4 | ||
5 | obj-$(CONFIG_SQUASHFS) += squashfs.o | 5 | obj-$(CONFIG_SQUASHFS) += squashfs.o |
6 | squashfs-y += block.o cache.o dir.o export.o file.o fragment.o id.o inode.o | 6 | squashfs-y += block.o cache.o dir.o export.o file.o fragment.o id.o inode.o |
7 | squashfs-y += namei.o super.o symlink.o | 7 | squashfs-y += namei.o super.o symlink.o zlib_wrapper.o decompressor.o |
diff --git a/fs/squashfs/block.c b/fs/squashfs/block.c index 2a7960310349..1cb0d81b164b 100644 --- a/fs/squashfs/block.c +++ b/fs/squashfs/block.c | |||
@@ -29,15 +29,14 @@ | |||
29 | #include <linux/fs.h> | 29 | #include <linux/fs.h> |
30 | #include <linux/vfs.h> | 30 | #include <linux/vfs.h> |
31 | #include <linux/slab.h> | 31 | #include <linux/slab.h> |
32 | #include <linux/mutex.h> | ||
33 | #include <linux/string.h> | 32 | #include <linux/string.h> |
34 | #include <linux/buffer_head.h> | 33 | #include <linux/buffer_head.h> |
35 | #include <linux/zlib.h> | ||
36 | 34 | ||
37 | #include "squashfs_fs.h" | 35 | #include "squashfs_fs.h" |
38 | #include "squashfs_fs_sb.h" | 36 | #include "squashfs_fs_sb.h" |
39 | #include "squashfs_fs_i.h" | 37 | #include "squashfs_fs_i.h" |
40 | #include "squashfs.h" | 38 | #include "squashfs.h" |
39 | #include "decompressor.h" | ||
41 | 40 | ||
42 | /* | 41 | /* |
43 | * Read the metadata block length, this is stored in the first two | 42 | * Read the metadata block length, this is stored in the first two |
@@ -153,72 +152,10 @@ int squashfs_read_data(struct super_block *sb, void **buffer, u64 index, | |||
153 | } | 152 | } |
154 | 153 | ||
155 | if (compressed) { | 154 | if (compressed) { |
156 | int zlib_err = 0, zlib_init = 0; | 155 | length = squashfs_decompress(msblk, buffer, bh, b, offset, |
157 | 156 | length, srclength, pages); | |
158 | /* | 157 | if (length < 0) |
159 | * Uncompress block. | 158 | goto read_failure; |
160 | */ | ||
161 | |||
162 | mutex_lock(&msblk->read_data_mutex); | ||
163 | |||
164 | msblk->stream.avail_out = 0; | ||
165 | msblk->stream.avail_in = 0; | ||
166 | |||
167 | bytes = length; | ||
168 | do { | ||
169 | if (msblk->stream.avail_in == 0 && k < b) { | ||
170 | avail = min(bytes, msblk->devblksize - offset); | ||
171 | bytes -= avail; | ||
172 | wait_on_buffer(bh[k]); | ||
173 | if (!buffer_uptodate(bh[k])) | ||
174 | goto release_mutex; | ||
175 | |||
176 | if (avail == 0) { | ||
177 | offset = 0; | ||
178 | put_bh(bh[k++]); | ||
179 | continue; | ||
180 | } | ||
181 | |||
182 | msblk->stream.next_in = bh[k]->b_data + offset; | ||
183 | msblk->stream.avail_in = avail; | ||
184 | offset = 0; | ||
185 | } | ||
186 | |||
187 | if (msblk->stream.avail_out == 0 && page < pages) { | ||
188 | msblk->stream.next_out = buffer[page++]; | ||
189 | msblk->stream.avail_out = PAGE_CACHE_SIZE; | ||
190 | } | ||
191 | |||
192 | if (!zlib_init) { | ||
193 | zlib_err = zlib_inflateInit(&msblk->stream); | ||
194 | if (zlib_err != Z_OK) { | ||
195 | ERROR("zlib_inflateInit returned" | ||
196 | " unexpected result 0x%x," | ||
197 | " srclength %d\n", zlib_err, | ||
198 | srclength); | ||
199 | goto release_mutex; | ||
200 | } | ||
201 | zlib_init = 1; | ||
202 | } | ||
203 | |||
204 | zlib_err = zlib_inflate(&msblk->stream, Z_SYNC_FLUSH); | ||
205 | |||
206 | if (msblk->stream.avail_in == 0 && k < b) | ||
207 | put_bh(bh[k++]); | ||
208 | } while (zlib_err == Z_OK); | ||
209 | |||
210 | if (zlib_err != Z_STREAM_END) { | ||
211 | ERROR("zlib_inflate error, data probably corrupt\n"); | ||
212 | goto release_mutex; | ||
213 | } | ||
214 | |||
215 | zlib_err = zlib_inflateEnd(&msblk->stream); | ||
216 | if (zlib_err != Z_OK) { | ||
217 | ERROR("zlib_inflate error, data probably corrupt\n"); | ||
218 | goto release_mutex; | ||
219 | } | ||
220 | length = msblk->stream.total_out; | ||
221 | mutex_unlock(&msblk->read_data_mutex); | ||
222 | } else { | 159 | } else { |
223 | /* | 160 | /* |
224 | * Block is uncompressed. | 161 | * Block is uncompressed. |
@@ -255,9 +192,6 @@ int squashfs_read_data(struct super_block *sb, void **buffer, u64 index, | |||
255 | kfree(bh); | 192 | kfree(bh); |
256 | return length; | 193 | return length; |
257 | 194 | ||
258 | release_mutex: | ||
259 | mutex_unlock(&msblk->read_data_mutex); | ||
260 | |||
261 | block_release: | 195 | block_release: |
262 | for (; k < b; k++) | 196 | for (; k < b; k++) |
263 | put_bh(bh[k]); | 197 | put_bh(bh[k]); |
diff --git a/fs/squashfs/cache.c b/fs/squashfs/cache.c index 40c98fa6b5d6..57314bee9059 100644 --- a/fs/squashfs/cache.c +++ b/fs/squashfs/cache.c | |||
@@ -51,7 +51,6 @@ | |||
51 | #include <linux/sched.h> | 51 | #include <linux/sched.h> |
52 | #include <linux/spinlock.h> | 52 | #include <linux/spinlock.h> |
53 | #include <linux/wait.h> | 53 | #include <linux/wait.h> |
54 | #include <linux/zlib.h> | ||
55 | #include <linux/pagemap.h> | 54 | #include <linux/pagemap.h> |
56 | 55 | ||
57 | #include "squashfs_fs.h" | 56 | #include "squashfs_fs.h" |
diff --git a/fs/squashfs/decompressor.c b/fs/squashfs/decompressor.c new file mode 100644 index 000000000000..157478da6ac9 --- /dev/null +++ b/fs/squashfs/decompressor.c | |||
@@ -0,0 +1,68 @@ | |||
1 | /* | ||
2 | * Squashfs - a compressed read only filesystem for Linux | ||
3 | * | ||
4 | * Copyright (c) 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 | ||
5 | * Phillip Lougher <phillip@lougher.demon.co.uk> | ||
6 | * | ||
7 | * This program is free software; you can redistribute it and/or | ||
8 | * modify it under the terms of the GNU General Public License | ||
9 | * as published by the Free Software Foundation; either version 2, | ||
10 | * or (at your option) any later version. | ||
11 | * | ||
12 | * This program is distributed in the hope that it will be useful, | ||
13 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
14 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
15 | * GNU General Public License for more details. | ||
16 | * | ||
17 | * You should have received a copy of the GNU General Public License | ||
18 | * along with this program; if not, write to the Free Software | ||
19 | * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
20 | * | ||
21 | * decompressor.c | ||
22 | */ | ||
23 | |||
24 | #include <linux/types.h> | ||
25 | #include <linux/mutex.h> | ||
26 | #include <linux/buffer_head.h> | ||
27 | |||
28 | #include "squashfs_fs.h" | ||
29 | #include "squashfs_fs_sb.h" | ||
30 | #include "squashfs_fs_i.h" | ||
31 | #include "decompressor.h" | ||
32 | #include "squashfs.h" | ||
33 | |||
34 | /* | ||
35 | * This file (and decompressor.h) implements a decompressor framework for | ||
36 | * Squashfs, allowing multiple decompressors to be easily supported | ||
37 | */ | ||
38 | |||
39 | static const struct squashfs_decompressor squashfs_lzma_unsupported_comp_ops = { | ||
40 | NULL, NULL, NULL, LZMA_COMPRESSION, "lzma", 0 | ||
41 | }; | ||
42 | |||
43 | static const struct squashfs_decompressor squashfs_lzo_unsupported_comp_ops = { | ||
44 | NULL, NULL, NULL, LZO_COMPRESSION, "lzo", 0 | ||
45 | }; | ||
46 | |||
47 | static const struct squashfs_decompressor squashfs_unknown_comp_ops = { | ||
48 | NULL, NULL, NULL, 0, "unknown", 0 | ||
49 | }; | ||
50 | |||
51 | static const struct squashfs_decompressor *decompressor[] = { | ||
52 | &squashfs_zlib_comp_ops, | ||
53 | &squashfs_lzma_unsupported_comp_ops, | ||
54 | &squashfs_lzo_unsupported_comp_ops, | ||
55 | &squashfs_unknown_comp_ops | ||
56 | }; | ||
57 | |||
58 | |||
59 | const struct squashfs_decompressor *squashfs_lookup_decompressor(int id) | ||
60 | { | ||
61 | int i; | ||
62 | |||
63 | for (i = 0; decompressor[i]->id; i++) | ||
64 | if (id == decompressor[i]->id) | ||
65 | break; | ||
66 | |||
67 | return decompressor[i]; | ||
68 | } | ||
diff --git a/fs/squashfs/decompressor.h b/fs/squashfs/decompressor.h new file mode 100644 index 000000000000..7425f80783f6 --- /dev/null +++ b/fs/squashfs/decompressor.h | |||
@@ -0,0 +1,55 @@ | |||
1 | #ifndef DECOMPRESSOR_H | ||
2 | #define DECOMPRESSOR_H | ||
3 | /* | ||
4 | * Squashfs - a compressed read only filesystem for Linux | ||
5 | * | ||
6 | * Copyright (c) 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 | ||
7 | * Phillip Lougher <phillip@lougher.demon.co.uk> | ||
8 | * | ||
9 | * This program is free software; you can redistribute it and/or | ||
10 | * modify it under the terms of the GNU General Public License | ||
11 | * as published by the Free Software Foundation; either version 2, | ||
12 | * or (at your option) any later version. | ||
13 | * | ||
14 | * This program is distributed in the hope that it will be useful, | ||
15 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
16 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
17 | * GNU General Public License for more details. | ||
18 | * | ||
19 | * You should have received a copy of the GNU General Public License | ||
20 | * along with this program; if not, write to the Free Software | ||
21 | * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
22 | * | ||
23 | * decompressor.h | ||
24 | */ | ||
25 | |||
26 | struct squashfs_decompressor { | ||
27 | void *(*init)(struct squashfs_sb_info *); | ||
28 | void (*free)(void *); | ||
29 | int (*decompress)(struct squashfs_sb_info *, void **, | ||
30 | struct buffer_head **, int, int, int, int, int); | ||
31 | int id; | ||
32 | char *name; | ||
33 | int supported; | ||
34 | }; | ||
35 | |||
36 | static inline void *squashfs_decompressor_init(struct squashfs_sb_info *msblk) | ||
37 | { | ||
38 | return msblk->decompressor->init(msblk); | ||
39 | } | ||
40 | |||
41 | static inline void squashfs_decompressor_free(struct squashfs_sb_info *msblk, | ||
42 | void *s) | ||
43 | { | ||
44 | if (msblk->decompressor) | ||
45 | msblk->decompressor->free(s); | ||
46 | } | ||
47 | |||
48 | static inline int squashfs_decompress(struct squashfs_sb_info *msblk, | ||
49 | void **buffer, struct buffer_head **bh, int b, int offset, int length, | ||
50 | int srclength, int pages) | ||
51 | { | ||
52 | return msblk->decompressor->decompress(msblk, buffer, bh, b, offset, | ||
53 | length, srclength, pages); | ||
54 | } | ||
55 | #endif | ||
diff --git a/fs/squashfs/dir.c b/fs/squashfs/dir.c index 566b0eaed868..12b933ac6585 100644 --- a/fs/squashfs/dir.c +++ b/fs/squashfs/dir.c | |||
@@ -30,7 +30,6 @@ | |||
30 | #include <linux/fs.h> | 30 | #include <linux/fs.h> |
31 | #include <linux/vfs.h> | 31 | #include <linux/vfs.h> |
32 | #include <linux/slab.h> | 32 | #include <linux/slab.h> |
33 | #include <linux/zlib.h> | ||
34 | 33 | ||
35 | #include "squashfs_fs.h" | 34 | #include "squashfs_fs.h" |
36 | #include "squashfs_fs_sb.h" | 35 | #include "squashfs_fs_sb.h" |
diff --git a/fs/squashfs/export.c b/fs/squashfs/export.c index 2b1b8fe5e037..7f93d5a9ee05 100644 --- a/fs/squashfs/export.c +++ b/fs/squashfs/export.c | |||
@@ -39,7 +39,6 @@ | |||
39 | #include <linux/vfs.h> | 39 | #include <linux/vfs.h> |
40 | #include <linux/dcache.h> | 40 | #include <linux/dcache.h> |
41 | #include <linux/exportfs.h> | 41 | #include <linux/exportfs.h> |
42 | #include <linux/zlib.h> | ||
43 | #include <linux/slab.h> | 42 | #include <linux/slab.h> |
44 | 43 | ||
45 | #include "squashfs_fs.h" | 44 | #include "squashfs_fs.h" |
diff --git a/fs/squashfs/file.c b/fs/squashfs/file.c index 717767d831df..a25c5060bdcb 100644 --- a/fs/squashfs/file.c +++ b/fs/squashfs/file.c | |||
@@ -47,7 +47,6 @@ | |||
47 | #include <linux/string.h> | 47 | #include <linux/string.h> |
48 | #include <linux/pagemap.h> | 48 | #include <linux/pagemap.h> |
49 | #include <linux/mutex.h> | 49 | #include <linux/mutex.h> |
50 | #include <linux/zlib.h> | ||
51 | 50 | ||
52 | #include "squashfs_fs.h" | 51 | #include "squashfs_fs.h" |
53 | #include "squashfs_fs_sb.h" | 52 | #include "squashfs_fs_sb.h" |
diff --git a/fs/squashfs/fragment.c b/fs/squashfs/fragment.c index b5a2c15bbbc7..7c90bbd6879d 100644 --- a/fs/squashfs/fragment.c +++ b/fs/squashfs/fragment.c | |||
@@ -36,7 +36,6 @@ | |||
36 | #include <linux/fs.h> | 36 | #include <linux/fs.h> |
37 | #include <linux/vfs.h> | 37 | #include <linux/vfs.h> |
38 | #include <linux/slab.h> | 38 | #include <linux/slab.h> |
39 | #include <linux/zlib.h> | ||
40 | 39 | ||
41 | #include "squashfs_fs.h" | 40 | #include "squashfs_fs.h" |
42 | #include "squashfs_fs_sb.h" | 41 | #include "squashfs_fs_sb.h" |
diff --git a/fs/squashfs/id.c b/fs/squashfs/id.c index 3795b837ba28..b7f64bcd2b70 100644 --- a/fs/squashfs/id.c +++ b/fs/squashfs/id.c | |||
@@ -34,7 +34,6 @@ | |||
34 | #include <linux/fs.h> | 34 | #include <linux/fs.h> |
35 | #include <linux/vfs.h> | 35 | #include <linux/vfs.h> |
36 | #include <linux/slab.h> | 36 | #include <linux/slab.h> |
37 | #include <linux/zlib.h> | ||
38 | 37 | ||
39 | #include "squashfs_fs.h" | 38 | #include "squashfs_fs.h" |
40 | #include "squashfs_fs_sb.h" | 39 | #include "squashfs_fs_sb.h" |
diff --git a/fs/squashfs/inode.c b/fs/squashfs/inode.c index 9101dbde39ec..49daaf669e41 100644 --- a/fs/squashfs/inode.c +++ b/fs/squashfs/inode.c | |||
@@ -40,7 +40,6 @@ | |||
40 | 40 | ||
41 | #include <linux/fs.h> | 41 | #include <linux/fs.h> |
42 | #include <linux/vfs.h> | 42 | #include <linux/vfs.h> |
43 | #include <linux/zlib.h> | ||
44 | 43 | ||
45 | #include "squashfs_fs.h" | 44 | #include "squashfs_fs.h" |
46 | #include "squashfs_fs_sb.h" | 45 | #include "squashfs_fs_sb.h" |
diff --git a/fs/squashfs/namei.c b/fs/squashfs/namei.c index 9e398653b22b..5266bd8ad932 100644 --- a/fs/squashfs/namei.c +++ b/fs/squashfs/namei.c | |||
@@ -57,7 +57,6 @@ | |||
57 | #include <linux/slab.h> | 57 | #include <linux/slab.h> |
58 | #include <linux/string.h> | 58 | #include <linux/string.h> |
59 | #include <linux/dcache.h> | 59 | #include <linux/dcache.h> |
60 | #include <linux/zlib.h> | ||
61 | 60 | ||
62 | #include "squashfs_fs.h" | 61 | #include "squashfs_fs.h" |
63 | #include "squashfs_fs_sb.h" | 62 | #include "squashfs_fs_sb.h" |
diff --git a/fs/squashfs/squashfs.h b/fs/squashfs/squashfs.h index 0e9feb6adf7e..fe2587af5512 100644 --- a/fs/squashfs/squashfs.h +++ b/fs/squashfs/squashfs.h | |||
@@ -51,6 +51,9 @@ extern struct squashfs_cache_entry *squashfs_get_datablock(struct super_block *, | |||
51 | u64, int); | 51 | u64, int); |
52 | extern int squashfs_read_table(struct super_block *, void *, u64, int); | 52 | extern int squashfs_read_table(struct super_block *, void *, u64, int); |
53 | 53 | ||
54 | /* decompressor.c */ | ||
55 | extern const struct squashfs_decompressor *squashfs_lookup_decompressor(int); | ||
56 | |||
54 | /* export.c */ | 57 | /* export.c */ |
55 | extern __le64 *squashfs_read_inode_lookup_table(struct super_block *, u64, | 58 | extern __le64 *squashfs_read_inode_lookup_table(struct super_block *, u64, |
56 | unsigned int); | 59 | unsigned int); |
@@ -71,7 +74,7 @@ extern struct inode *squashfs_iget(struct super_block *, long long, | |||
71 | extern int squashfs_read_inode(struct inode *, long long); | 74 | extern int squashfs_read_inode(struct inode *, long long); |
72 | 75 | ||
73 | /* | 76 | /* |
74 | * Inodes and files operations | 77 | * Inodes, files and decompressor operations |
75 | */ | 78 | */ |
76 | 79 | ||
77 | /* dir.c */ | 80 | /* dir.c */ |
@@ -88,3 +91,6 @@ extern const struct inode_operations squashfs_dir_inode_ops; | |||
88 | 91 | ||
89 | /* symlink.c */ | 92 | /* symlink.c */ |
90 | extern const struct address_space_operations squashfs_symlink_aops; | 93 | extern const struct address_space_operations squashfs_symlink_aops; |
94 | |||
95 | /* zlib_wrapper.c */ | ||
96 | extern const struct squashfs_decompressor squashfs_zlib_comp_ops; | ||
diff --git a/fs/squashfs/squashfs_fs.h b/fs/squashfs/squashfs_fs.h index 283daafc568e..79024245ea00 100644 --- a/fs/squashfs/squashfs_fs.h +++ b/fs/squashfs/squashfs_fs.h | |||
@@ -183,8 +183,6 @@ | |||
183 | #define SQUASHFS_MAX_FILE_SIZE (1LL << \ | 183 | #define SQUASHFS_MAX_FILE_SIZE (1LL << \ |
184 | (SQUASHFS_MAX_FILE_SIZE_LOG - 2)) | 184 | (SQUASHFS_MAX_FILE_SIZE_LOG - 2)) |
185 | 185 | ||
186 | #define SQUASHFS_MARKER_BYTE 0xff | ||
187 | |||
188 | /* meta index cache */ | 186 | /* meta index cache */ |
189 | #define SQUASHFS_META_INDEXES (SQUASHFS_METADATA_SIZE / sizeof(unsigned int)) | 187 | #define SQUASHFS_META_INDEXES (SQUASHFS_METADATA_SIZE / sizeof(unsigned int)) |
190 | #define SQUASHFS_META_ENTRIES 127 | 188 | #define SQUASHFS_META_ENTRIES 127 |
@@ -211,7 +209,9 @@ struct meta_index { | |||
211 | /* | 209 | /* |
212 | * definitions for structures on disk | 210 | * definitions for structures on disk |
213 | */ | 211 | */ |
214 | #define ZLIB_COMPRESSION 1 | 212 | #define ZLIB_COMPRESSION 1 |
213 | #define LZMA_COMPRESSION 2 | ||
214 | #define LZO_COMPRESSION 3 | ||
215 | 215 | ||
216 | struct squashfs_super_block { | 216 | struct squashfs_super_block { |
217 | __le32 s_magic; | 217 | __le32 s_magic; |
diff --git a/fs/squashfs/squashfs_fs_sb.h b/fs/squashfs/squashfs_fs_sb.h index c8c65614dd1c..2e77dc547e25 100644 --- a/fs/squashfs/squashfs_fs_sb.h +++ b/fs/squashfs/squashfs_fs_sb.h | |||
@@ -52,25 +52,25 @@ struct squashfs_cache_entry { | |||
52 | }; | 52 | }; |
53 | 53 | ||
54 | struct squashfs_sb_info { | 54 | struct squashfs_sb_info { |
55 | int devblksize; | 55 | const struct squashfs_decompressor *decompressor; |
56 | int devblksize_log2; | 56 | int devblksize; |
57 | struct squashfs_cache *block_cache; | 57 | int devblksize_log2; |
58 | struct squashfs_cache *fragment_cache; | 58 | struct squashfs_cache *block_cache; |
59 | struct squashfs_cache *read_page; | 59 | struct squashfs_cache *fragment_cache; |
60 | int next_meta_index; | 60 | struct squashfs_cache *read_page; |
61 | __le64 *id_table; | 61 | int next_meta_index; |
62 | __le64 *fragment_index; | 62 | __le64 *id_table; |
63 | unsigned int *fragment_index_2; | 63 | __le64 *fragment_index; |
64 | struct mutex read_data_mutex; | 64 | struct mutex read_data_mutex; |
65 | struct mutex meta_index_mutex; | 65 | struct mutex meta_index_mutex; |
66 | struct meta_index *meta_index; | 66 | struct meta_index *meta_index; |
67 | z_stream stream; | 67 | void *stream; |
68 | __le64 *inode_lookup_table; | 68 | __le64 *inode_lookup_table; |
69 | u64 inode_table; | 69 | u64 inode_table; |
70 | u64 directory_table; | 70 | u64 directory_table; |
71 | unsigned int block_size; | 71 | unsigned int block_size; |
72 | unsigned short block_log; | 72 | unsigned short block_log; |
73 | long long bytes_used; | 73 | long long bytes_used; |
74 | unsigned int inodes; | 74 | unsigned int inodes; |
75 | }; | 75 | }; |
76 | #endif | 76 | #endif |
diff --git a/fs/squashfs/super.c b/fs/squashfs/super.c index 6c197ef53add..3550aec2f655 100644 --- a/fs/squashfs/super.c +++ b/fs/squashfs/super.c | |||
@@ -35,34 +35,41 @@ | |||
35 | #include <linux/pagemap.h> | 35 | #include <linux/pagemap.h> |
36 | #include <linux/init.h> | 36 | #include <linux/init.h> |
37 | #include <linux/module.h> | 37 | #include <linux/module.h> |
38 | #include <linux/zlib.h> | ||
39 | #include <linux/magic.h> | 38 | #include <linux/magic.h> |
40 | 39 | ||
41 | #include "squashfs_fs.h" | 40 | #include "squashfs_fs.h" |
42 | #include "squashfs_fs_sb.h" | 41 | #include "squashfs_fs_sb.h" |
43 | #include "squashfs_fs_i.h" | 42 | #include "squashfs_fs_i.h" |
44 | #include "squashfs.h" | 43 | #include "squashfs.h" |
44 | #include "decompressor.h" | ||
45 | 45 | ||
46 | static struct file_system_type squashfs_fs_type; | 46 | static struct file_system_type squashfs_fs_type; |
47 | static const struct super_operations squashfs_super_ops; | 47 | static const struct super_operations squashfs_super_ops; |
48 | 48 | ||
49 | static int supported_squashfs_filesystem(short major, short minor, short comp) | 49 | static const struct squashfs_decompressor *supported_squashfs_filesystem(short |
50 | major, short minor, short id) | ||
50 | { | 51 | { |
52 | const struct squashfs_decompressor *decompressor; | ||
53 | |||
51 | if (major < SQUASHFS_MAJOR) { | 54 | if (major < SQUASHFS_MAJOR) { |
52 | ERROR("Major/Minor mismatch, older Squashfs %d.%d " | 55 | ERROR("Major/Minor mismatch, older Squashfs %d.%d " |
53 | "filesystems are unsupported\n", major, minor); | 56 | "filesystems are unsupported\n", major, minor); |
54 | return -EINVAL; | 57 | return NULL; |
55 | } else if (major > SQUASHFS_MAJOR || minor > SQUASHFS_MINOR) { | 58 | } else if (major > SQUASHFS_MAJOR || minor > SQUASHFS_MINOR) { |
56 | ERROR("Major/Minor mismatch, trying to mount newer " | 59 | ERROR("Major/Minor mismatch, trying to mount newer " |
57 | "%d.%d filesystem\n", major, minor); | 60 | "%d.%d filesystem\n", major, minor); |
58 | ERROR("Please update your kernel\n"); | 61 | ERROR("Please update your kernel\n"); |
59 | return -EINVAL; | 62 | return NULL; |
60 | } | 63 | } |
61 | 64 | ||
62 | if (comp != ZLIB_COMPRESSION) | 65 | decompressor = squashfs_lookup_decompressor(id); |
63 | return -EINVAL; | 66 | if (!decompressor->supported) { |
67 | ERROR("Filesystem uses \"%s\" compression. This is not " | ||
68 | "supported\n", decompressor->name); | ||
69 | return NULL; | ||
70 | } | ||
64 | 71 | ||
65 | return 0; | 72 | return decompressor; |
66 | } | 73 | } |
67 | 74 | ||
68 | 75 | ||
@@ -87,13 +94,6 @@ static int squashfs_fill_super(struct super_block *sb, void *data, int silent) | |||
87 | } | 94 | } |
88 | msblk = sb->s_fs_info; | 95 | msblk = sb->s_fs_info; |
89 | 96 | ||
90 | msblk->stream.workspace = kmalloc(zlib_inflate_workspacesize(), | ||
91 | GFP_KERNEL); | ||
92 | if (msblk->stream.workspace == NULL) { | ||
93 | ERROR("Failed to allocate zlib workspace\n"); | ||
94 | goto failure; | ||
95 | } | ||
96 | |||
97 | sblk = kzalloc(sizeof(*sblk), GFP_KERNEL); | 97 | sblk = kzalloc(sizeof(*sblk), GFP_KERNEL); |
98 | if (sblk == NULL) { | 98 | if (sblk == NULL) { |
99 | ERROR("Failed to allocate squashfs_super_block\n"); | 99 | ERROR("Failed to allocate squashfs_super_block\n"); |
@@ -120,25 +120,25 @@ static int squashfs_fill_super(struct super_block *sb, void *data, int silent) | |||
120 | goto failed_mount; | 120 | goto failed_mount; |
121 | } | 121 | } |
122 | 122 | ||
123 | err = -EINVAL; | ||
124 | |||
123 | /* Check it is a SQUASHFS superblock */ | 125 | /* Check it is a SQUASHFS superblock */ |
124 | sb->s_magic = le32_to_cpu(sblk->s_magic); | 126 | sb->s_magic = le32_to_cpu(sblk->s_magic); |
125 | if (sb->s_magic != SQUASHFS_MAGIC) { | 127 | if (sb->s_magic != SQUASHFS_MAGIC) { |
126 | if (!silent) | 128 | if (!silent) |
127 | ERROR("Can't find a SQUASHFS superblock on %s\n", | 129 | ERROR("Can't find a SQUASHFS superblock on %s\n", |
128 | bdevname(sb->s_bdev, b)); | 130 | bdevname(sb->s_bdev, b)); |
129 | err = -EINVAL; | ||
130 | goto failed_mount; | 131 | goto failed_mount; |
131 | } | 132 | } |
132 | 133 | ||
133 | /* Check the MAJOR & MINOR versions and compression type */ | 134 | /* Check the MAJOR & MINOR versions and lookup compression type */ |
134 | err = supported_squashfs_filesystem(le16_to_cpu(sblk->s_major), | 135 | msblk->decompressor = supported_squashfs_filesystem( |
136 | le16_to_cpu(sblk->s_major), | ||
135 | le16_to_cpu(sblk->s_minor), | 137 | le16_to_cpu(sblk->s_minor), |
136 | le16_to_cpu(sblk->compression)); | 138 | le16_to_cpu(sblk->compression)); |
137 | if (err < 0) | 139 | if (msblk->decompressor == NULL) |
138 | goto failed_mount; | 140 | goto failed_mount; |
139 | 141 | ||
140 | err = -EINVAL; | ||
141 | |||
142 | /* | 142 | /* |
143 | * Check if there's xattrs in the filesystem. These are not | 143 | * Check if there's xattrs in the filesystem. These are not |
144 | * supported in this version, so warn that they will be ignored. | 144 | * supported in this version, so warn that they will be ignored. |
@@ -205,6 +205,10 @@ static int squashfs_fill_super(struct super_block *sb, void *data, int silent) | |||
205 | 205 | ||
206 | err = -ENOMEM; | 206 | err = -ENOMEM; |
207 | 207 | ||
208 | msblk->stream = squashfs_decompressor_init(msblk); | ||
209 | if (msblk->stream == NULL) | ||
210 | goto failed_mount; | ||
211 | |||
208 | msblk->block_cache = squashfs_cache_init("metadata", | 212 | msblk->block_cache = squashfs_cache_init("metadata", |
209 | SQUASHFS_CACHED_BLKS, SQUASHFS_METADATA_SIZE); | 213 | SQUASHFS_CACHED_BLKS, SQUASHFS_METADATA_SIZE); |
210 | if (msblk->block_cache == NULL) | 214 | if (msblk->block_cache == NULL) |
@@ -292,17 +296,16 @@ failed_mount: | |||
292 | squashfs_cache_delete(msblk->block_cache); | 296 | squashfs_cache_delete(msblk->block_cache); |
293 | squashfs_cache_delete(msblk->fragment_cache); | 297 | squashfs_cache_delete(msblk->fragment_cache); |
294 | squashfs_cache_delete(msblk->read_page); | 298 | squashfs_cache_delete(msblk->read_page); |
299 | squashfs_decompressor_free(msblk, msblk->stream); | ||
295 | kfree(msblk->inode_lookup_table); | 300 | kfree(msblk->inode_lookup_table); |
296 | kfree(msblk->fragment_index); | 301 | kfree(msblk->fragment_index); |
297 | kfree(msblk->id_table); | 302 | kfree(msblk->id_table); |
298 | kfree(msblk->stream.workspace); | ||
299 | kfree(sb->s_fs_info); | 303 | kfree(sb->s_fs_info); |
300 | sb->s_fs_info = NULL; | 304 | sb->s_fs_info = NULL; |
301 | kfree(sblk); | 305 | kfree(sblk); |
302 | return err; | 306 | return err; |
303 | 307 | ||
304 | failure: | 308 | failure: |
305 | kfree(msblk->stream.workspace); | ||
306 | kfree(sb->s_fs_info); | 309 | kfree(sb->s_fs_info); |
307 | sb->s_fs_info = NULL; | 310 | sb->s_fs_info = NULL; |
308 | return -ENOMEM; | 311 | return -ENOMEM; |
@@ -346,10 +349,10 @@ static void squashfs_put_super(struct super_block *sb) | |||
346 | squashfs_cache_delete(sbi->block_cache); | 349 | squashfs_cache_delete(sbi->block_cache); |
347 | squashfs_cache_delete(sbi->fragment_cache); | 350 | squashfs_cache_delete(sbi->fragment_cache); |
348 | squashfs_cache_delete(sbi->read_page); | 351 | squashfs_cache_delete(sbi->read_page); |
352 | squashfs_decompressor_free(sbi, sbi->stream); | ||
349 | kfree(sbi->id_table); | 353 | kfree(sbi->id_table); |
350 | kfree(sbi->fragment_index); | 354 | kfree(sbi->fragment_index); |
351 | kfree(sbi->meta_index); | 355 | kfree(sbi->meta_index); |
352 | kfree(sbi->stream.workspace); | ||
353 | kfree(sb->s_fs_info); | 356 | kfree(sb->s_fs_info); |
354 | sb->s_fs_info = NULL; | 357 | sb->s_fs_info = NULL; |
355 | } | 358 | } |
diff --git a/fs/squashfs/symlink.c b/fs/squashfs/symlink.c index 83d87880aac8..e80be2022a7f 100644 --- a/fs/squashfs/symlink.c +++ b/fs/squashfs/symlink.c | |||
@@ -36,7 +36,6 @@ | |||
36 | #include <linux/slab.h> | 36 | #include <linux/slab.h> |
37 | #include <linux/string.h> | 37 | #include <linux/string.h> |
38 | #include <linux/pagemap.h> | 38 | #include <linux/pagemap.h> |
39 | #include <linux/zlib.h> | ||
40 | 39 | ||
41 | #include "squashfs_fs.h" | 40 | #include "squashfs_fs.h" |
42 | #include "squashfs_fs_sb.h" | 41 | #include "squashfs_fs_sb.h" |
diff --git a/fs/squashfs/zlib_wrapper.c b/fs/squashfs/zlib_wrapper.c new file mode 100644 index 000000000000..4dd70e04333b --- /dev/null +++ b/fs/squashfs/zlib_wrapper.c | |||
@@ -0,0 +1,150 @@ | |||
1 | /* | ||
2 | * Squashfs - a compressed read only filesystem for Linux | ||
3 | * | ||
4 | * Copyright (c) 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 | ||
5 | * Phillip Lougher <phillip@lougher.demon.co.uk> | ||
6 | * | ||
7 | * This program is free software; you can redistribute it and/or | ||
8 | * modify it under the terms of the GNU General Public License | ||
9 | * as published by the Free Software Foundation; either version 2, | ||
10 | * or (at your option) any later version. | ||
11 | * | ||
12 | * This program is distributed in the hope that it will be useful, | ||
13 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
14 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
15 | * GNU General Public License for more details. | ||
16 | * | ||
17 | * You should have received a copy of the GNU General Public License | ||
18 | * along with this program; if not, write to the Free Software | ||
19 | * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
20 | * | ||
21 | * zlib_wrapper.c | ||
22 | */ | ||
23 | |||
24 | |||
25 | #include <linux/mutex.h> | ||
26 | #include <linux/buffer_head.h> | ||
27 | #include <linux/zlib.h> | ||
28 | |||
29 | #include "squashfs_fs.h" | ||
30 | #include "squashfs_fs_sb.h" | ||
31 | #include "squashfs_fs_i.h" | ||
32 | #include "squashfs.h" | ||
33 | #include "decompressor.h" | ||
34 | |||
35 | static void *zlib_init(struct squashfs_sb_info *dummy) | ||
36 | { | ||
37 | z_stream *stream = kmalloc(sizeof(z_stream), GFP_KERNEL); | ||
38 | if (stream == NULL) | ||
39 | goto failed; | ||
40 | stream->workspace = kmalloc(zlib_inflate_workspacesize(), | ||
41 | GFP_KERNEL); | ||
42 | if (stream->workspace == NULL) | ||
43 | goto failed; | ||
44 | |||
45 | return stream; | ||
46 | |||
47 | failed: | ||
48 | ERROR("Failed to allocate zlib workspace\n"); | ||
49 | kfree(stream); | ||
50 | return NULL; | ||
51 | } | ||
52 | |||
53 | |||
54 | static void zlib_free(void *strm) | ||
55 | { | ||
56 | z_stream *stream = strm; | ||
57 | |||
58 | if (stream) | ||
59 | kfree(stream->workspace); | ||
60 | kfree(stream); | ||
61 | } | ||
62 | |||
63 | |||
64 | static int zlib_uncompress(struct squashfs_sb_info *msblk, void **buffer, | ||
65 | struct buffer_head **bh, int b, int offset, int length, int srclength, | ||
66 | int pages) | ||
67 | { | ||
68 | int zlib_err = 0, zlib_init = 0; | ||
69 | int avail, bytes, k = 0, page = 0; | ||
70 | z_stream *stream = msblk->stream; | ||
71 | |||
72 | mutex_lock(&msblk->read_data_mutex); | ||
73 | |||
74 | stream->avail_out = 0; | ||
75 | stream->avail_in = 0; | ||
76 | |||
77 | bytes = length; | ||
78 | do { | ||
79 | if (stream->avail_in == 0 && k < b) { | ||
80 | avail = min(bytes, msblk->devblksize - offset); | ||
81 | bytes -= avail; | ||
82 | wait_on_buffer(bh[k]); | ||
83 | if (!buffer_uptodate(bh[k])) | ||
84 | goto release_mutex; | ||
85 | |||
86 | if (avail == 0) { | ||
87 | offset = 0; | ||
88 | put_bh(bh[k++]); | ||
89 | continue; | ||
90 | } | ||
91 | |||
92 | stream->next_in = bh[k]->b_data + offset; | ||
93 | stream->avail_in = avail; | ||
94 | offset = 0; | ||
95 | } | ||
96 | |||
97 | if (stream->avail_out == 0 && page < pages) { | ||
98 | stream->next_out = buffer[page++]; | ||
99 | stream->avail_out = PAGE_CACHE_SIZE; | ||
100 | } | ||
101 | |||
102 | if (!zlib_init) { | ||
103 | zlib_err = zlib_inflateInit(stream); | ||
104 | if (zlib_err != Z_OK) { | ||
105 | ERROR("zlib_inflateInit returned unexpected " | ||
106 | "result 0x%x, srclength %d\n", | ||
107 | zlib_err, srclength); | ||
108 | goto release_mutex; | ||
109 | } | ||
110 | zlib_init = 1; | ||
111 | } | ||
112 | |||
113 | zlib_err = zlib_inflate(stream, Z_SYNC_FLUSH); | ||
114 | |||
115 | if (stream->avail_in == 0 && k < b) | ||
116 | put_bh(bh[k++]); | ||
117 | } while (zlib_err == Z_OK); | ||
118 | |||
119 | if (zlib_err != Z_STREAM_END) { | ||
120 | ERROR("zlib_inflate error, data probably corrupt\n"); | ||
121 | goto release_mutex; | ||
122 | } | ||
123 | |||
124 | zlib_err = zlib_inflateEnd(stream); | ||
125 | if (zlib_err != Z_OK) { | ||
126 | ERROR("zlib_inflate error, data probably corrupt\n"); | ||
127 | goto release_mutex; | ||
128 | } | ||
129 | |||
130 | mutex_unlock(&msblk->read_data_mutex); | ||
131 | return stream->total_out; | ||
132 | |||
133 | release_mutex: | ||
134 | mutex_unlock(&msblk->read_data_mutex); | ||
135 | |||
136 | for (; k < b; k++) | ||
137 | put_bh(bh[k]); | ||
138 | |||
139 | return -EIO; | ||
140 | } | ||
141 | |||
142 | const struct squashfs_decompressor squashfs_zlib_comp_ops = { | ||
143 | .init = zlib_init, | ||
144 | .free = zlib_free, | ||
145 | .decompress = zlib_uncompress, | ||
146 | .id = ZLIB_COMPRESSION, | ||
147 | .name = "zlib", | ||
148 | .supported = 1 | ||
149 | }; | ||
150 | |||
diff --git a/fs/super.c b/fs/super.c index aff046b0fe78..f35ac6022109 100644 --- a/fs/super.c +++ b/fs/super.c | |||
@@ -568,7 +568,7 @@ out: | |||
568 | int do_remount_sb(struct super_block *sb, int flags, void *data, int force) | 568 | int do_remount_sb(struct super_block *sb, int flags, void *data, int force) |
569 | { | 569 | { |
570 | int retval; | 570 | int retval; |
571 | int remount_rw; | 571 | int remount_rw, remount_ro; |
572 | 572 | ||
573 | if (sb->s_frozen != SB_UNFROZEN) | 573 | if (sb->s_frozen != SB_UNFROZEN) |
574 | return -EBUSY; | 574 | return -EBUSY; |
@@ -583,9 +583,12 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force) | |||
583 | shrink_dcache_sb(sb); | 583 | shrink_dcache_sb(sb); |
584 | sync_filesystem(sb); | 584 | sync_filesystem(sb); |
585 | 585 | ||
586 | remount_ro = (flags & MS_RDONLY) && !(sb->s_flags & MS_RDONLY); | ||
587 | remount_rw = !(flags & MS_RDONLY) && (sb->s_flags & MS_RDONLY); | ||
588 | |||
586 | /* If we are remounting RDONLY and current sb is read/write, | 589 | /* If we are remounting RDONLY and current sb is read/write, |
587 | make sure there are no rw files opened */ | 590 | make sure there are no rw files opened */ |
588 | if ((flags & MS_RDONLY) && !(sb->s_flags & MS_RDONLY)) { | 591 | if (remount_ro) { |
589 | if (force) | 592 | if (force) |
590 | mark_files_ro(sb); | 593 | mark_files_ro(sb); |
591 | else if (!fs_may_remount_ro(sb)) | 594 | else if (!fs_may_remount_ro(sb)) |
@@ -594,7 +597,6 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force) | |||
594 | if (retval < 0 && retval != -ENOSYS) | 597 | if (retval < 0 && retval != -ENOSYS) |
595 | return -EBUSY; | 598 | return -EBUSY; |
596 | } | 599 | } |
597 | remount_rw = !(flags & MS_RDONLY) && (sb->s_flags & MS_RDONLY); | ||
598 | 600 | ||
599 | if (sb->s_op->remount_fs) { | 601 | if (sb->s_op->remount_fs) { |
600 | retval = sb->s_op->remount_fs(sb, &flags, data); | 602 | retval = sb->s_op->remount_fs(sb, &flags, data); |
@@ -604,6 +606,16 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force) | |||
604 | sb->s_flags = (sb->s_flags & ~MS_RMT_MASK) | (flags & MS_RMT_MASK); | 606 | sb->s_flags = (sb->s_flags & ~MS_RMT_MASK) | (flags & MS_RMT_MASK); |
605 | if (remount_rw) | 607 | if (remount_rw) |
606 | vfs_dq_quota_on_remount(sb); | 608 | vfs_dq_quota_on_remount(sb); |
609 | /* | ||
610 | * Some filesystems modify their metadata via some other path than the | ||
611 | * bdev buffer cache (eg. use a private mapping, or directories in | ||
612 | * pagecache, etc). Also file data modifications go via their own | ||
613 | * mappings. So If we try to mount readonly then copy the filesystem | ||
614 | * from bdev, we could get stale data, so invalidate it to give a best | ||
615 | * effort at coherency. | ||
616 | */ | ||
617 | if (remount_ro && sb->s_bdev) | ||
618 | invalidate_bdev(sb->s_bdev); | ||
607 | return 0; | 619 | return 0; |
608 | } | 620 | } |
609 | 621 | ||
@@ -925,6 +937,9 @@ vfs_kern_mount(struct file_system_type *type, int flags, const char *name, void | |||
925 | if (!mnt) | 937 | if (!mnt) |
926 | goto out; | 938 | goto out; |
927 | 939 | ||
940 | if (flags & MS_KERNMOUNT) | ||
941 | mnt->mnt_flags = MNT_INTERNAL; | ||
942 | |||
928 | if (data && !(type->fs_flags & FS_BINARY_MOUNTDATA)) { | 943 | if (data && !(type->fs_flags & FS_BINARY_MOUNTDATA)) { |
929 | secdata = alloc_secdata(); | 944 | secdata = alloc_secdata(); |
930 | if (!secdata) | 945 | if (!secdata) |
@@ -34,14 +34,14 @@ static int __sync_filesystem(struct super_block *sb, int wait) | |||
34 | if (!sb->s_bdi) | 34 | if (!sb->s_bdi) |
35 | return 0; | 35 | return 0; |
36 | 36 | ||
37 | /* Avoid doing twice syncing and cache pruning for quota sync */ | 37 | if (sb->s_qcop && sb->s_qcop->quota_sync) |
38 | if (!wait) { | 38 | sb->s_qcop->quota_sync(sb, -1, wait); |
39 | writeout_quota_sb(sb, -1); | 39 | |
40 | writeback_inodes_sb(sb); | 40 | if (wait) |
41 | } else { | ||
42 | sync_quota_sb(sb, -1); | ||
43 | sync_inodes_sb(sb); | 41 | sync_inodes_sb(sb); |
44 | } | 42 | else |
43 | writeback_inodes_sb(sb); | ||
44 | |||
45 | if (sb->s_op->sync_fs) | 45 | if (sb->s_op->sync_fs) |
46 | sb->s_op->sync_fs(sb, wait); | 46 | sb->s_op->sync_fs(sb, wait); |
47 | return __sync_blockdev(sb->s_bdev, wait); | 47 | return __sync_blockdev(sb->s_bdev, wait); |
diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c index a0a500af24a1..e9d293593e52 100644 --- a/fs/sysfs/bin.c +++ b/fs/sysfs/bin.c | |||
@@ -54,14 +54,14 @@ fill_read(struct dentry *dentry, char *buffer, loff_t off, size_t count) | |||
54 | int rc; | 54 | int rc; |
55 | 55 | ||
56 | /* need attr_sd for attr, its parent for kobj */ | 56 | /* need attr_sd for attr, its parent for kobj */ |
57 | if (!sysfs_get_active_two(attr_sd)) | 57 | if (!sysfs_get_active(attr_sd)) |
58 | return -ENODEV; | 58 | return -ENODEV; |
59 | 59 | ||
60 | rc = -EIO; | 60 | rc = -EIO; |
61 | if (attr->read) | 61 | if (attr->read) |
62 | rc = attr->read(kobj, attr, buffer, off, count); | 62 | rc = attr->read(kobj, attr, buffer, off, count); |
63 | 63 | ||
64 | sysfs_put_active_two(attr_sd); | 64 | sysfs_put_active(attr_sd); |
65 | 65 | ||
66 | return rc; | 66 | return rc; |
67 | } | 67 | } |
@@ -125,14 +125,14 @@ flush_write(struct dentry *dentry, char *buffer, loff_t offset, size_t count) | |||
125 | int rc; | 125 | int rc; |
126 | 126 | ||
127 | /* need attr_sd for attr, its parent for kobj */ | 127 | /* need attr_sd for attr, its parent for kobj */ |
128 | if (!sysfs_get_active_two(attr_sd)) | 128 | if (!sysfs_get_active(attr_sd)) |
129 | return -ENODEV; | 129 | return -ENODEV; |
130 | 130 | ||
131 | rc = -EIO; | 131 | rc = -EIO; |
132 | if (attr->write) | 132 | if (attr->write) |
133 | rc = attr->write(kobj, attr, buffer, offset, count); | 133 | rc = attr->write(kobj, attr, buffer, offset, count); |
134 | 134 | ||
135 | sysfs_put_active_two(attr_sd); | 135 | sysfs_put_active(attr_sd); |
136 | 136 | ||
137 | return rc; | 137 | return rc; |
138 | } | 138 | } |
@@ -184,12 +184,12 @@ static void bin_vma_open(struct vm_area_struct *vma) | |||
184 | if (!bb->vm_ops || !bb->vm_ops->open) | 184 | if (!bb->vm_ops || !bb->vm_ops->open) |
185 | return; | 185 | return; |
186 | 186 | ||
187 | if (!sysfs_get_active_two(attr_sd)) | 187 | if (!sysfs_get_active(attr_sd)) |
188 | return; | 188 | return; |
189 | 189 | ||
190 | bb->vm_ops->open(vma); | 190 | bb->vm_ops->open(vma); |
191 | 191 | ||
192 | sysfs_put_active_two(attr_sd); | 192 | sysfs_put_active(attr_sd); |
193 | } | 193 | } |
194 | 194 | ||
195 | static void bin_vma_close(struct vm_area_struct *vma) | 195 | static void bin_vma_close(struct vm_area_struct *vma) |
@@ -201,12 +201,12 @@ static void bin_vma_close(struct vm_area_struct *vma) | |||
201 | if (!bb->vm_ops || !bb->vm_ops->close) | 201 | if (!bb->vm_ops || !bb->vm_ops->close) |
202 | return; | 202 | return; |
203 | 203 | ||
204 | if (!sysfs_get_active_two(attr_sd)) | 204 | if (!sysfs_get_active(attr_sd)) |
205 | return; | 205 | return; |
206 | 206 | ||
207 | bb->vm_ops->close(vma); | 207 | bb->vm_ops->close(vma); |
208 | 208 | ||
209 | sysfs_put_active_two(attr_sd); | 209 | sysfs_put_active(attr_sd); |
210 | } | 210 | } |
211 | 211 | ||
212 | static int bin_fault(struct vm_area_struct *vma, struct vm_fault *vmf) | 212 | static int bin_fault(struct vm_area_struct *vma, struct vm_fault *vmf) |
@@ -219,12 +219,12 @@ static int bin_fault(struct vm_area_struct *vma, struct vm_fault *vmf) | |||
219 | if (!bb->vm_ops || !bb->vm_ops->fault) | 219 | if (!bb->vm_ops || !bb->vm_ops->fault) |
220 | return VM_FAULT_SIGBUS; | 220 | return VM_FAULT_SIGBUS; |
221 | 221 | ||
222 | if (!sysfs_get_active_two(attr_sd)) | 222 | if (!sysfs_get_active(attr_sd)) |
223 | return VM_FAULT_SIGBUS; | 223 | return VM_FAULT_SIGBUS; |
224 | 224 | ||
225 | ret = bb->vm_ops->fault(vma, vmf); | 225 | ret = bb->vm_ops->fault(vma, vmf); |
226 | 226 | ||
227 | sysfs_put_active_two(attr_sd); | 227 | sysfs_put_active(attr_sd); |
228 | return ret; | 228 | return ret; |
229 | } | 229 | } |
230 | 230 | ||
@@ -241,12 +241,12 @@ static int bin_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) | |||
241 | if (!bb->vm_ops->page_mkwrite) | 241 | if (!bb->vm_ops->page_mkwrite) |
242 | return 0; | 242 | return 0; |
243 | 243 | ||
244 | if (!sysfs_get_active_two(attr_sd)) | 244 | if (!sysfs_get_active(attr_sd)) |
245 | return VM_FAULT_SIGBUS; | 245 | return VM_FAULT_SIGBUS; |
246 | 246 | ||
247 | ret = bb->vm_ops->page_mkwrite(vma, vmf); | 247 | ret = bb->vm_ops->page_mkwrite(vma, vmf); |
248 | 248 | ||
249 | sysfs_put_active_two(attr_sd); | 249 | sysfs_put_active(attr_sd); |
250 | return ret; | 250 | return ret; |
251 | } | 251 | } |
252 | 252 | ||
@@ -261,12 +261,12 @@ static int bin_access(struct vm_area_struct *vma, unsigned long addr, | |||
261 | if (!bb->vm_ops || !bb->vm_ops->access) | 261 | if (!bb->vm_ops || !bb->vm_ops->access) |
262 | return -EINVAL; | 262 | return -EINVAL; |
263 | 263 | ||
264 | if (!sysfs_get_active_two(attr_sd)) | 264 | if (!sysfs_get_active(attr_sd)) |
265 | return -EINVAL; | 265 | return -EINVAL; |
266 | 266 | ||
267 | ret = bb->vm_ops->access(vma, addr, buf, len, write); | 267 | ret = bb->vm_ops->access(vma, addr, buf, len, write); |
268 | 268 | ||
269 | sysfs_put_active_two(attr_sd); | 269 | sysfs_put_active(attr_sd); |
270 | return ret; | 270 | return ret; |
271 | } | 271 | } |
272 | 272 | ||
@@ -281,12 +281,12 @@ static int bin_set_policy(struct vm_area_struct *vma, struct mempolicy *new) | |||
281 | if (!bb->vm_ops || !bb->vm_ops->set_policy) | 281 | if (!bb->vm_ops || !bb->vm_ops->set_policy) |
282 | return 0; | 282 | return 0; |
283 | 283 | ||
284 | if (!sysfs_get_active_two(attr_sd)) | 284 | if (!sysfs_get_active(attr_sd)) |
285 | return -EINVAL; | 285 | return -EINVAL; |
286 | 286 | ||
287 | ret = bb->vm_ops->set_policy(vma, new); | 287 | ret = bb->vm_ops->set_policy(vma, new); |
288 | 288 | ||
289 | sysfs_put_active_two(attr_sd); | 289 | sysfs_put_active(attr_sd); |
290 | return ret; | 290 | return ret; |
291 | } | 291 | } |
292 | 292 | ||
@@ -301,12 +301,12 @@ static struct mempolicy *bin_get_policy(struct vm_area_struct *vma, | |||
301 | if (!bb->vm_ops || !bb->vm_ops->get_policy) | 301 | if (!bb->vm_ops || !bb->vm_ops->get_policy) |
302 | return vma->vm_policy; | 302 | return vma->vm_policy; |
303 | 303 | ||
304 | if (!sysfs_get_active_two(attr_sd)) | 304 | if (!sysfs_get_active(attr_sd)) |
305 | return vma->vm_policy; | 305 | return vma->vm_policy; |
306 | 306 | ||
307 | pol = bb->vm_ops->get_policy(vma, addr); | 307 | pol = bb->vm_ops->get_policy(vma, addr); |
308 | 308 | ||
309 | sysfs_put_active_two(attr_sd); | 309 | sysfs_put_active(attr_sd); |
310 | return pol; | 310 | return pol; |
311 | } | 311 | } |
312 | 312 | ||
@@ -321,12 +321,12 @@ static int bin_migrate(struct vm_area_struct *vma, const nodemask_t *from, | |||
321 | if (!bb->vm_ops || !bb->vm_ops->migrate) | 321 | if (!bb->vm_ops || !bb->vm_ops->migrate) |
322 | return 0; | 322 | return 0; |
323 | 323 | ||
324 | if (!sysfs_get_active_two(attr_sd)) | 324 | if (!sysfs_get_active(attr_sd)) |
325 | return 0; | 325 | return 0; |
326 | 326 | ||
327 | ret = bb->vm_ops->migrate(vma, from, to, flags); | 327 | ret = bb->vm_ops->migrate(vma, from, to, flags); |
328 | 328 | ||
329 | sysfs_put_active_two(attr_sd); | 329 | sysfs_put_active(attr_sd); |
330 | return ret; | 330 | return ret; |
331 | } | 331 | } |
332 | #endif | 332 | #endif |
@@ -356,7 +356,7 @@ static int mmap(struct file *file, struct vm_area_struct *vma) | |||
356 | 356 | ||
357 | /* need attr_sd for attr, its parent for kobj */ | 357 | /* need attr_sd for attr, its parent for kobj */ |
358 | rc = -ENODEV; | 358 | rc = -ENODEV; |
359 | if (!sysfs_get_active_two(attr_sd)) | 359 | if (!sysfs_get_active(attr_sd)) |
360 | goto out_unlock; | 360 | goto out_unlock; |
361 | 361 | ||
362 | rc = -EINVAL; | 362 | rc = -EINVAL; |
@@ -384,7 +384,7 @@ static int mmap(struct file *file, struct vm_area_struct *vma) | |||
384 | bb->vm_ops = vma->vm_ops; | 384 | bb->vm_ops = vma->vm_ops; |
385 | vma->vm_ops = &bin_vm_ops; | 385 | vma->vm_ops = &bin_vm_ops; |
386 | out_put: | 386 | out_put: |
387 | sysfs_put_active_two(attr_sd); | 387 | sysfs_put_active(attr_sd); |
388 | out_unlock: | 388 | out_unlock: |
389 | mutex_unlock(&bb->mutex); | 389 | mutex_unlock(&bb->mutex); |
390 | 390 | ||
@@ -399,7 +399,7 @@ static int open(struct inode * inode, struct file * file) | |||
399 | int error; | 399 | int error; |
400 | 400 | ||
401 | /* binary file operations requires both @sd and its parent */ | 401 | /* binary file operations requires both @sd and its parent */ |
402 | if (!sysfs_get_active_two(attr_sd)) | 402 | if (!sysfs_get_active(attr_sd)) |
403 | return -ENODEV; | 403 | return -ENODEV; |
404 | 404 | ||
405 | error = -EACCES; | 405 | error = -EACCES; |
@@ -426,11 +426,11 @@ static int open(struct inode * inode, struct file * file) | |||
426 | mutex_unlock(&sysfs_bin_lock); | 426 | mutex_unlock(&sysfs_bin_lock); |
427 | 427 | ||
428 | /* open succeeded, put active references */ | 428 | /* open succeeded, put active references */ |
429 | sysfs_put_active_two(attr_sd); | 429 | sysfs_put_active(attr_sd); |
430 | return 0; | 430 | return 0; |
431 | 431 | ||
432 | err_out: | 432 | err_out: |
433 | sysfs_put_active_two(attr_sd); | 433 | sysfs_put_active(attr_sd); |
434 | kfree(bb); | 434 | kfree(bb); |
435 | return error; | 435 | return error; |
436 | } | 436 | } |
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c index 699f371b9f12..590717861c7a 100644 --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c | |||
@@ -93,7 +93,7 @@ static void sysfs_unlink_sibling(struct sysfs_dirent *sd) | |||
93 | * RETURNS: | 93 | * RETURNS: |
94 | * Pointer to @sd on success, NULL on failure. | 94 | * Pointer to @sd on success, NULL on failure. |
95 | */ | 95 | */ |
96 | static struct sysfs_dirent *sysfs_get_active(struct sysfs_dirent *sd) | 96 | struct sysfs_dirent *sysfs_get_active(struct sysfs_dirent *sd) |
97 | { | 97 | { |
98 | if (unlikely(!sd)) | 98 | if (unlikely(!sd)) |
99 | return NULL; | 99 | return NULL; |
@@ -124,7 +124,7 @@ static struct sysfs_dirent *sysfs_get_active(struct sysfs_dirent *sd) | |||
124 | * Put an active reference to @sd. This function is noop if @sd | 124 | * Put an active reference to @sd. This function is noop if @sd |
125 | * is NULL. | 125 | * is NULL. |
126 | */ | 126 | */ |
127 | static void sysfs_put_active(struct sysfs_dirent *sd) | 127 | void sysfs_put_active(struct sysfs_dirent *sd) |
128 | { | 128 | { |
129 | struct completion *cmpl; | 129 | struct completion *cmpl; |
130 | int v; | 130 | int v; |
@@ -145,45 +145,6 @@ static void sysfs_put_active(struct sysfs_dirent *sd) | |||
145 | } | 145 | } |
146 | 146 | ||
147 | /** | 147 | /** |
148 | * sysfs_get_active_two - get active references to sysfs_dirent and parent | ||
149 | * @sd: sysfs_dirent of interest | ||
150 | * | ||
151 | * Get active reference to @sd and its parent. Parent's active | ||
152 | * reference is grabbed first. This function is noop if @sd is | ||
153 | * NULL. | ||
154 | * | ||
155 | * RETURNS: | ||
156 | * Pointer to @sd on success, NULL on failure. | ||
157 | */ | ||
158 | struct sysfs_dirent *sysfs_get_active_two(struct sysfs_dirent *sd) | ||
159 | { | ||
160 | if (sd) { | ||
161 | if (sd->s_parent && unlikely(!sysfs_get_active(sd->s_parent))) | ||
162 | return NULL; | ||
163 | if (unlikely(!sysfs_get_active(sd))) { | ||
164 | sysfs_put_active(sd->s_parent); | ||
165 | return NULL; | ||
166 | } | ||
167 | } | ||
168 | return sd; | ||
169 | } | ||
170 | |||
171 | /** | ||
172 | * sysfs_put_active_two - put active references to sysfs_dirent and parent | ||
173 | * @sd: sysfs_dirent of interest | ||
174 | * | ||
175 | * Put active references to @sd and its parent. This function is | ||
176 | * noop if @sd is NULL. | ||
177 | */ | ||
178 | void sysfs_put_active_two(struct sysfs_dirent *sd) | ||
179 | { | ||
180 | if (sd) { | ||
181 | sysfs_put_active(sd); | ||
182 | sysfs_put_active(sd->s_parent); | ||
183 | } | ||
184 | } | ||
185 | |||
186 | /** | ||
187 | * sysfs_deactivate - deactivate sysfs_dirent | 148 | * sysfs_deactivate - deactivate sysfs_dirent |
188 | * @sd: sysfs_dirent to deactivate | 149 | * @sd: sysfs_dirent to deactivate |
189 | * | 150 | * |
@@ -195,6 +156,10 @@ static void sysfs_deactivate(struct sysfs_dirent *sd) | |||
195 | int v; | 156 | int v; |
196 | 157 | ||
197 | BUG_ON(sd->s_sibling || !(sd->s_flags & SYSFS_FLAG_REMOVED)); | 158 | BUG_ON(sd->s_sibling || !(sd->s_flags & SYSFS_FLAG_REMOVED)); |
159 | |||
160 | if (!(sysfs_type(sd) & SYSFS_ACTIVE_REF)) | ||
161 | return; | ||
162 | |||
198 | sd->s_sibling = (void *)&wait; | 163 | sd->s_sibling = (void *)&wait; |
199 | 164 | ||
200 | rwsem_acquire(&sd->dep_map, 0, 0, _RET_IP_); | 165 | rwsem_acquire(&sd->dep_map, 0, 0, _RET_IP_); |
@@ -354,7 +319,6 @@ struct sysfs_dirent *sysfs_new_dirent(const char *name, umode_t mode, int type) | |||
354 | 319 | ||
355 | atomic_set(&sd->s_count, 1); | 320 | atomic_set(&sd->s_count, 1); |
356 | atomic_set(&sd->s_active, 0); | 321 | atomic_set(&sd->s_active, 0); |
357 | sysfs_dirent_init_lockdep(sd); | ||
358 | 322 | ||
359 | sd->s_name = name; | 323 | sd->s_name = name; |
360 | sd->s_mode = mode; | 324 | sd->s_mode = mode; |
@@ -681,7 +645,7 @@ static struct dentry * sysfs_lookup(struct inode *dir, struct dentry *dentry, | |||
681 | } | 645 | } |
682 | 646 | ||
683 | /* attach dentry and inode */ | 647 | /* attach dentry and inode */ |
684 | inode = sysfs_get_inode(sd); | 648 | inode = sysfs_get_inode(dir->i_sb, sd); |
685 | if (!inode) { | 649 | if (!inode) { |
686 | ret = ERR_PTR(-ENOMEM); | 650 | ret = ERR_PTR(-ENOMEM); |
687 | goto out_unlock; | 651 | goto out_unlock; |
@@ -837,11 +801,46 @@ static inline unsigned char dt_type(struct sysfs_dirent *sd) | |||
837 | return (sd->s_mode >> 12) & 15; | 801 | return (sd->s_mode >> 12) & 15; |
838 | } | 802 | } |
839 | 803 | ||
804 | static int sysfs_dir_release(struct inode *inode, struct file *filp) | ||
805 | { | ||
806 | sysfs_put(filp->private_data); | ||
807 | return 0; | ||
808 | } | ||
809 | |||
810 | static struct sysfs_dirent *sysfs_dir_pos(struct sysfs_dirent *parent_sd, | ||
811 | ino_t ino, struct sysfs_dirent *pos) | ||
812 | { | ||
813 | if (pos) { | ||
814 | int valid = !(pos->s_flags & SYSFS_FLAG_REMOVED) && | ||
815 | pos->s_parent == parent_sd && | ||
816 | ino == pos->s_ino; | ||
817 | sysfs_put(pos); | ||
818 | if (valid) | ||
819 | return pos; | ||
820 | } | ||
821 | pos = NULL; | ||
822 | if ((ino > 1) && (ino < INT_MAX)) { | ||
823 | pos = parent_sd->s_dir.children; | ||
824 | while (pos && (ino > pos->s_ino)) | ||
825 | pos = pos->s_sibling; | ||
826 | } | ||
827 | return pos; | ||
828 | } | ||
829 | |||
830 | static struct sysfs_dirent *sysfs_dir_next_pos(struct sysfs_dirent *parent_sd, | ||
831 | ino_t ino, struct sysfs_dirent *pos) | ||
832 | { | ||
833 | pos = sysfs_dir_pos(parent_sd, ino, pos); | ||
834 | if (pos) | ||
835 | pos = pos->s_sibling; | ||
836 | return pos; | ||
837 | } | ||
838 | |||
840 | static int sysfs_readdir(struct file * filp, void * dirent, filldir_t filldir) | 839 | static int sysfs_readdir(struct file * filp, void * dirent, filldir_t filldir) |
841 | { | 840 | { |
842 | struct dentry *dentry = filp->f_path.dentry; | 841 | struct dentry *dentry = filp->f_path.dentry; |
843 | struct sysfs_dirent * parent_sd = dentry->d_fsdata; | 842 | struct sysfs_dirent * parent_sd = dentry->d_fsdata; |
844 | struct sysfs_dirent *pos; | 843 | struct sysfs_dirent *pos = filp->private_data; |
845 | ino_t ino; | 844 | ino_t ino; |
846 | 845 | ||
847 | if (filp->f_pos == 0) { | 846 | if (filp->f_pos == 0) { |
@@ -857,29 +856,31 @@ static int sysfs_readdir(struct file * filp, void * dirent, filldir_t filldir) | |||
857 | if (filldir(dirent, "..", 2, filp->f_pos, ino, DT_DIR) == 0) | 856 | if (filldir(dirent, "..", 2, filp->f_pos, ino, DT_DIR) == 0) |
858 | filp->f_pos++; | 857 | filp->f_pos++; |
859 | } | 858 | } |
860 | if ((filp->f_pos > 1) && (filp->f_pos < INT_MAX)) { | 859 | mutex_lock(&sysfs_mutex); |
861 | mutex_lock(&sysfs_mutex); | 860 | for (pos = sysfs_dir_pos(parent_sd, filp->f_pos, pos); |
862 | 861 | pos; | |
863 | /* Skip the dentries we have already reported */ | 862 | pos = sysfs_dir_next_pos(parent_sd, filp->f_pos, pos)) { |
864 | pos = parent_sd->s_dir.children; | 863 | const char * name; |
865 | while (pos && (filp->f_pos > pos->s_ino)) | 864 | unsigned int type; |
866 | pos = pos->s_sibling; | 865 | int len, ret; |
867 | 866 | ||
868 | for ( ; pos; pos = pos->s_sibling) { | 867 | name = pos->s_name; |
869 | const char * name; | 868 | len = strlen(name); |
870 | int len; | 869 | ino = pos->s_ino; |
871 | 870 | type = dt_type(pos); | |
872 | name = pos->s_name; | 871 | filp->f_pos = ino; |
873 | len = strlen(name); | 872 | filp->private_data = sysfs_get(pos); |
874 | filp->f_pos = ino = pos->s_ino; | ||
875 | 873 | ||
876 | if (filldir(dirent, name, len, filp->f_pos, ino, | ||
877 | dt_type(pos)) < 0) | ||
878 | break; | ||
879 | } | ||
880 | if (!pos) | ||
881 | filp->f_pos = INT_MAX; | ||
882 | mutex_unlock(&sysfs_mutex); | 874 | mutex_unlock(&sysfs_mutex); |
875 | ret = filldir(dirent, name, len, filp->f_pos, ino, type); | ||
876 | mutex_lock(&sysfs_mutex); | ||
877 | if (ret < 0) | ||
878 | break; | ||
879 | } | ||
880 | mutex_unlock(&sysfs_mutex); | ||
881 | if ((filp->f_pos > 1) && !pos) { /* EOF */ | ||
882 | filp->f_pos = INT_MAX; | ||
883 | filp->private_data = NULL; | ||
883 | } | 884 | } |
884 | return 0; | 885 | return 0; |
885 | } | 886 | } |
@@ -888,5 +889,6 @@ static int sysfs_readdir(struct file * filp, void * dirent, filldir_t filldir) | |||
888 | const struct file_operations sysfs_dir_operations = { | 889 | const struct file_operations sysfs_dir_operations = { |
889 | .read = generic_read_dir, | 890 | .read = generic_read_dir, |
890 | .readdir = sysfs_readdir, | 891 | .readdir = sysfs_readdir, |
892 | .release = sysfs_dir_release, | ||
891 | .llseek = generic_file_llseek, | 893 | .llseek = generic_file_llseek, |
892 | }; | 894 | }; |
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index dc30d9e31683..e222b2582746 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c | |||
@@ -53,7 +53,7 @@ struct sysfs_buffer { | |||
53 | size_t count; | 53 | size_t count; |
54 | loff_t pos; | 54 | loff_t pos; |
55 | char * page; | 55 | char * page; |
56 | struct sysfs_ops * ops; | 56 | const struct sysfs_ops * ops; |
57 | struct mutex mutex; | 57 | struct mutex mutex; |
58 | int needs_read_fill; | 58 | int needs_read_fill; |
59 | int event; | 59 | int event; |
@@ -75,7 +75,7 @@ static int fill_read_buffer(struct dentry * dentry, struct sysfs_buffer * buffer | |||
75 | { | 75 | { |
76 | struct sysfs_dirent *attr_sd = dentry->d_fsdata; | 76 | struct sysfs_dirent *attr_sd = dentry->d_fsdata; |
77 | struct kobject *kobj = attr_sd->s_parent->s_dir.kobj; | 77 | struct kobject *kobj = attr_sd->s_parent->s_dir.kobj; |
78 | struct sysfs_ops * ops = buffer->ops; | 78 | const struct sysfs_ops * ops = buffer->ops; |
79 | int ret = 0; | 79 | int ret = 0; |
80 | ssize_t count; | 80 | ssize_t count; |
81 | 81 | ||
@@ -85,13 +85,13 @@ static int fill_read_buffer(struct dentry * dentry, struct sysfs_buffer * buffer | |||
85 | return -ENOMEM; | 85 | return -ENOMEM; |
86 | 86 | ||
87 | /* need attr_sd for attr and ops, its parent for kobj */ | 87 | /* need attr_sd for attr and ops, its parent for kobj */ |
88 | if (!sysfs_get_active_two(attr_sd)) | 88 | if (!sysfs_get_active(attr_sd)) |
89 | return -ENODEV; | 89 | return -ENODEV; |
90 | 90 | ||
91 | buffer->event = atomic_read(&attr_sd->s_attr.open->event); | 91 | buffer->event = atomic_read(&attr_sd->s_attr.open->event); |
92 | count = ops->show(kobj, attr_sd->s_attr.attr, buffer->page); | 92 | count = ops->show(kobj, attr_sd->s_attr.attr, buffer->page); |
93 | 93 | ||
94 | sysfs_put_active_two(attr_sd); | 94 | sysfs_put_active(attr_sd); |
95 | 95 | ||
96 | /* | 96 | /* |
97 | * The code works fine with PAGE_SIZE return but it's likely to | 97 | * The code works fine with PAGE_SIZE return but it's likely to |
@@ -199,16 +199,16 @@ flush_write_buffer(struct dentry * dentry, struct sysfs_buffer * buffer, size_t | |||
199 | { | 199 | { |
200 | struct sysfs_dirent *attr_sd = dentry->d_fsdata; | 200 | struct sysfs_dirent *attr_sd = dentry->d_fsdata; |
201 | struct kobject *kobj = attr_sd->s_parent->s_dir.kobj; | 201 | struct kobject *kobj = attr_sd->s_parent->s_dir.kobj; |
202 | struct sysfs_ops * ops = buffer->ops; | 202 | const struct sysfs_ops * ops = buffer->ops; |
203 | int rc; | 203 | int rc; |
204 | 204 | ||
205 | /* need attr_sd for attr and ops, its parent for kobj */ | 205 | /* need attr_sd for attr and ops, its parent for kobj */ |
206 | if (!sysfs_get_active_two(attr_sd)) | 206 | if (!sysfs_get_active(attr_sd)) |
207 | return -ENODEV; | 207 | return -ENODEV; |
208 | 208 | ||
209 | rc = ops->store(kobj, attr_sd->s_attr.attr, buffer->page, count); | 209 | rc = ops->store(kobj, attr_sd->s_attr.attr, buffer->page, count); |
210 | 210 | ||
211 | sysfs_put_active_two(attr_sd); | 211 | sysfs_put_active(attr_sd); |
212 | 212 | ||
213 | return rc; | 213 | return rc; |
214 | } | 214 | } |
@@ -335,7 +335,7 @@ static int sysfs_open_file(struct inode *inode, struct file *file) | |||
335 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | 335 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; |
336 | struct kobject *kobj = attr_sd->s_parent->s_dir.kobj; | 336 | struct kobject *kobj = attr_sd->s_parent->s_dir.kobj; |
337 | struct sysfs_buffer *buffer; | 337 | struct sysfs_buffer *buffer; |
338 | struct sysfs_ops *ops; | 338 | const struct sysfs_ops *ops; |
339 | int error = -EACCES; | 339 | int error = -EACCES; |
340 | char *p; | 340 | char *p; |
341 | 341 | ||
@@ -344,7 +344,7 @@ static int sysfs_open_file(struct inode *inode, struct file *file) | |||
344 | memmove(last_sysfs_file, p, strlen(p) + 1); | 344 | memmove(last_sysfs_file, p, strlen(p) + 1); |
345 | 345 | ||
346 | /* need attr_sd for attr and ops, its parent for kobj */ | 346 | /* need attr_sd for attr and ops, its parent for kobj */ |
347 | if (!sysfs_get_active_two(attr_sd)) | 347 | if (!sysfs_get_active(attr_sd)) |
348 | return -ENODEV; | 348 | return -ENODEV; |
349 | 349 | ||
350 | /* every kobject with an attribute needs a ktype assigned */ | 350 | /* every kobject with an attribute needs a ktype assigned */ |
@@ -393,13 +393,13 @@ static int sysfs_open_file(struct inode *inode, struct file *file) | |||
393 | goto err_free; | 393 | goto err_free; |
394 | 394 | ||
395 | /* open succeeded, put active references */ | 395 | /* open succeeded, put active references */ |
396 | sysfs_put_active_two(attr_sd); | 396 | sysfs_put_active(attr_sd); |
397 | return 0; | 397 | return 0; |
398 | 398 | ||
399 | err_free: | 399 | err_free: |
400 | kfree(buffer); | 400 | kfree(buffer); |
401 | err_out: | 401 | err_out: |
402 | sysfs_put_active_two(attr_sd); | 402 | sysfs_put_active(attr_sd); |
403 | return error; | 403 | return error; |
404 | } | 404 | } |
405 | 405 | ||
@@ -437,12 +437,12 @@ static unsigned int sysfs_poll(struct file *filp, poll_table *wait) | |||
437 | struct sysfs_open_dirent *od = attr_sd->s_attr.open; | 437 | struct sysfs_open_dirent *od = attr_sd->s_attr.open; |
438 | 438 | ||
439 | /* need parent for the kobj, grab both */ | 439 | /* need parent for the kobj, grab both */ |
440 | if (!sysfs_get_active_two(attr_sd)) | 440 | if (!sysfs_get_active(attr_sd)) |
441 | goto trigger; | 441 | goto trigger; |
442 | 442 | ||
443 | poll_wait(filp, &od->poll, wait); | 443 | poll_wait(filp, &od->poll, wait); |
444 | 444 | ||
445 | sysfs_put_active_two(attr_sd); | 445 | sysfs_put_active(attr_sd); |
446 | 446 | ||
447 | if (buffer->event != atomic_read(&od->event)) | 447 | if (buffer->event != atomic_read(&od->event)) |
448 | goto trigger; | 448 | goto trigger; |
@@ -509,6 +509,7 @@ int sysfs_add_file_mode(struct sysfs_dirent *dir_sd, | |||
509 | if (!sd) | 509 | if (!sd) |
510 | return -ENOMEM; | 510 | return -ENOMEM; |
511 | sd->s_attr.attr = (void *)attr; | 511 | sd->s_attr.attr = (void *)attr; |
512 | sysfs_dirent_init_lockdep(sd); | ||
512 | 513 | ||
513 | sysfs_addrm_start(&acxt, dir_sd); | 514 | sysfs_addrm_start(&acxt, dir_sd); |
514 | rc = sysfs_add_one(&acxt, sd); | 515 | rc = sysfs_add_one(&acxt, sd); |
@@ -542,6 +543,18 @@ int sysfs_create_file(struct kobject * kobj, const struct attribute * attr) | |||
542 | 543 | ||
543 | } | 544 | } |
544 | 545 | ||
546 | int sysfs_create_files(struct kobject *kobj, const struct attribute **ptr) | ||
547 | { | ||
548 | int err = 0; | ||
549 | int i; | ||
550 | |||
551 | for (i = 0; ptr[i] && !err; i++) | ||
552 | err = sysfs_create_file(kobj, ptr[i]); | ||
553 | if (err) | ||
554 | while (--i >= 0) | ||
555 | sysfs_remove_file(kobj, ptr[i]); | ||
556 | return err; | ||
557 | } | ||
545 | 558 | ||
546 | /** | 559 | /** |
547 | * sysfs_add_file_to_group - add an attribute file to a pre-existing group. | 560 | * sysfs_add_file_to_group - add an attribute file to a pre-existing group. |
@@ -614,6 +627,12 @@ void sysfs_remove_file(struct kobject * kobj, const struct attribute * attr) | |||
614 | sysfs_hash_and_remove(kobj->sd, attr->name); | 627 | sysfs_hash_and_remove(kobj->sd, attr->name); |
615 | } | 628 | } |
616 | 629 | ||
630 | void sysfs_remove_files(struct kobject * kobj, const struct attribute **ptr) | ||
631 | { | ||
632 | int i; | ||
633 | for (i = 0; ptr[i]; i++) | ||
634 | sysfs_remove_file(kobj, ptr[i]); | ||
635 | } | ||
617 | 636 | ||
618 | /** | 637 | /** |
619 | * sysfs_remove_file_from_group - remove an attribute file from a group. | 638 | * sysfs_remove_file_from_group - remove an attribute file from a group. |
@@ -732,3 +751,5 @@ EXPORT_SYMBOL_GPL(sysfs_schedule_callback); | |||
732 | 751 | ||
733 | EXPORT_SYMBOL_GPL(sysfs_create_file); | 752 | EXPORT_SYMBOL_GPL(sysfs_create_file); |
734 | EXPORT_SYMBOL_GPL(sysfs_remove_file); | 753 | EXPORT_SYMBOL_GPL(sysfs_remove_file); |
754 | EXPORT_SYMBOL_GPL(sysfs_remove_files); | ||
755 | EXPORT_SYMBOL_GPL(sysfs_create_files); | ||
diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c index 6a06a1d1ea7b..082daaecac1b 100644 --- a/fs/sysfs/inode.c +++ b/fs/sysfs/inode.c | |||
@@ -111,20 +111,20 @@ int sysfs_setattr(struct dentry *dentry, struct iattr *iattr) | |||
111 | if (!sd) | 111 | if (!sd) |
112 | return -EINVAL; | 112 | return -EINVAL; |
113 | 113 | ||
114 | mutex_lock(&sysfs_mutex); | ||
114 | error = inode_change_ok(inode, iattr); | 115 | error = inode_change_ok(inode, iattr); |
115 | if (error) | 116 | if (error) |
116 | return error; | 117 | goto out; |
117 | 118 | ||
118 | iattr->ia_valid &= ~ATTR_SIZE; /* ignore size changes */ | 119 | iattr->ia_valid &= ~ATTR_SIZE; /* ignore size changes */ |
119 | 120 | ||
120 | error = inode_setattr(inode, iattr); | 121 | error = inode_setattr(inode, iattr); |
121 | if (error) | 122 | if (error) |
122 | return error; | 123 | goto out; |
123 | 124 | ||
124 | mutex_lock(&sysfs_mutex); | ||
125 | error = sysfs_sd_setattr(sd, iattr); | 125 | error = sysfs_sd_setattr(sd, iattr); |
126 | out: | ||
126 | mutex_unlock(&sysfs_mutex); | 127 | mutex_unlock(&sysfs_mutex); |
127 | |||
128 | return error; | 128 | return error; |
129 | } | 129 | } |
130 | 130 | ||
@@ -283,6 +283,7 @@ static void sysfs_init_inode(struct sysfs_dirent *sd, struct inode *inode) | |||
283 | 283 | ||
284 | /** | 284 | /** |
285 | * sysfs_get_inode - get inode for sysfs_dirent | 285 | * sysfs_get_inode - get inode for sysfs_dirent |
286 | * @sb: super block | ||
286 | * @sd: sysfs_dirent to allocate inode for | 287 | * @sd: sysfs_dirent to allocate inode for |
287 | * | 288 | * |
288 | * Get inode for @sd. If such inode doesn't exist, a new inode | 289 | * Get inode for @sd. If such inode doesn't exist, a new inode |
@@ -295,11 +296,11 @@ static void sysfs_init_inode(struct sysfs_dirent *sd, struct inode *inode) | |||
295 | * RETURNS: | 296 | * RETURNS: |
296 | * Pointer to allocated inode on success, NULL on failure. | 297 | * Pointer to allocated inode on success, NULL on failure. |
297 | */ | 298 | */ |
298 | struct inode * sysfs_get_inode(struct sysfs_dirent *sd) | 299 | struct inode * sysfs_get_inode(struct super_block *sb, struct sysfs_dirent *sd) |
299 | { | 300 | { |
300 | struct inode *inode; | 301 | struct inode *inode; |
301 | 302 | ||
302 | inode = iget_locked(sysfs_sb, sd->s_ino); | 303 | inode = iget_locked(sb, sd->s_ino); |
303 | if (inode && (inode->i_state & I_NEW)) | 304 | if (inode && (inode->i_state & I_NEW)) |
304 | sysfs_init_inode(sd, inode); | 305 | sysfs_init_inode(sd, inode); |
305 | 306 | ||
diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c index 49749955ccaf..0cb10884a2fc 100644 --- a/fs/sysfs/mount.c +++ b/fs/sysfs/mount.c | |||
@@ -23,7 +23,6 @@ | |||
23 | 23 | ||
24 | 24 | ||
25 | static struct vfsmount *sysfs_mount; | 25 | static struct vfsmount *sysfs_mount; |
26 | struct super_block * sysfs_sb = NULL; | ||
27 | struct kmem_cache *sysfs_dir_cachep; | 26 | struct kmem_cache *sysfs_dir_cachep; |
28 | 27 | ||
29 | static const struct super_operations sysfs_ops = { | 28 | static const struct super_operations sysfs_ops = { |
@@ -50,11 +49,10 @@ static int sysfs_fill_super(struct super_block *sb, void *data, int silent) | |||
50 | sb->s_magic = SYSFS_MAGIC; | 49 | sb->s_magic = SYSFS_MAGIC; |
51 | sb->s_op = &sysfs_ops; | 50 | sb->s_op = &sysfs_ops; |
52 | sb->s_time_gran = 1; | 51 | sb->s_time_gran = 1; |
53 | sysfs_sb = sb; | ||
54 | 52 | ||
55 | /* get root inode, initialize and unlock it */ | 53 | /* get root inode, initialize and unlock it */ |
56 | mutex_lock(&sysfs_mutex); | 54 | mutex_lock(&sysfs_mutex); |
57 | inode = sysfs_get_inode(&sysfs_root); | 55 | inode = sysfs_get_inode(sb, &sysfs_root); |
58 | mutex_unlock(&sysfs_mutex); | 56 | mutex_unlock(&sysfs_mutex); |
59 | if (!inode) { | 57 | if (!inode) { |
60 | pr_debug("sysfs: could not get root inode\n"); | 58 | pr_debug("sysfs: could not get root inode\n"); |
diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c index c5eff49fa41b..1b9a3a1e8a17 100644 --- a/fs/sysfs/symlink.c +++ b/fs/sysfs/symlink.c | |||
@@ -123,6 +123,44 @@ void sysfs_remove_link(struct kobject * kobj, const char * name) | |||
123 | sysfs_hash_and_remove(parent_sd, name); | 123 | sysfs_hash_and_remove(parent_sd, name); |
124 | } | 124 | } |
125 | 125 | ||
126 | /** | ||
127 | * sysfs_rename_link - rename symlink in object's directory. | ||
128 | * @kobj: object we're acting for. | ||
129 | * @targ: object we're pointing to. | ||
130 | * @old: previous name of the symlink. | ||
131 | * @new: new name of the symlink. | ||
132 | * | ||
133 | * A helper function for the common rename symlink idiom. | ||
134 | */ | ||
135 | int sysfs_rename_link(struct kobject *kobj, struct kobject *targ, | ||
136 | const char *old, const char *new) | ||
137 | { | ||
138 | struct sysfs_dirent *parent_sd, *sd = NULL; | ||
139 | int result; | ||
140 | |||
141 | if (!kobj) | ||
142 | parent_sd = &sysfs_root; | ||
143 | else | ||
144 | parent_sd = kobj->sd; | ||
145 | |||
146 | result = -ENOENT; | ||
147 | sd = sysfs_get_dirent(parent_sd, old); | ||
148 | if (!sd) | ||
149 | goto out; | ||
150 | |||
151 | result = -EINVAL; | ||
152 | if (sysfs_type(sd) != SYSFS_KOBJ_LINK) | ||
153 | goto out; | ||
154 | if (sd->s_symlink.target_sd->s_dir.kobj != targ) | ||
155 | goto out; | ||
156 | |||
157 | result = sysfs_rename(sd, parent_sd, new); | ||
158 | |||
159 | out: | ||
160 | sysfs_put(sd); | ||
161 | return result; | ||
162 | } | ||
163 | |||
126 | static int sysfs_get_target_path(struct sysfs_dirent *parent_sd, | 164 | static int sysfs_get_target_path(struct sysfs_dirent *parent_sd, |
127 | struct sysfs_dirent *target_sd, char *path) | 165 | struct sysfs_dirent *target_sd, char *path) |
128 | { | 166 | { |
diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h index cdd9377a6e06..30f5a44fb5d3 100644 --- a/fs/sysfs/sysfs.h +++ b/fs/sysfs/sysfs.h | |||
@@ -66,8 +66,8 @@ struct sysfs_dirent { | |||
66 | }; | 66 | }; |
67 | 67 | ||
68 | unsigned int s_flags; | 68 | unsigned int s_flags; |
69 | unsigned short s_mode; | ||
69 | ino_t s_ino; | 70 | ino_t s_ino; |
70 | umode_t s_mode; | ||
71 | struct sysfs_inode_attrs *s_iattr; | 71 | struct sysfs_inode_attrs *s_iattr; |
72 | }; | 72 | }; |
73 | 73 | ||
@@ -79,6 +79,7 @@ struct sysfs_dirent { | |||
79 | #define SYSFS_KOBJ_BIN_ATTR 0x0004 | 79 | #define SYSFS_KOBJ_BIN_ATTR 0x0004 |
80 | #define SYSFS_KOBJ_LINK 0x0008 | 80 | #define SYSFS_KOBJ_LINK 0x0008 |
81 | #define SYSFS_COPY_NAME (SYSFS_DIR | SYSFS_KOBJ_LINK) | 81 | #define SYSFS_COPY_NAME (SYSFS_DIR | SYSFS_KOBJ_LINK) |
82 | #define SYSFS_ACTIVE_REF (SYSFS_KOBJ_ATTR | SYSFS_KOBJ_BIN_ATTR) | ||
82 | 83 | ||
83 | #define SYSFS_FLAG_MASK ~SYSFS_TYPE_MASK | 84 | #define SYSFS_FLAG_MASK ~SYSFS_TYPE_MASK |
84 | #define SYSFS_FLAG_REMOVED 0x0200 | 85 | #define SYSFS_FLAG_REMOVED 0x0200 |
@@ -91,9 +92,12 @@ static inline unsigned int sysfs_type(struct sysfs_dirent *sd) | |||
91 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | 92 | #ifdef CONFIG_DEBUG_LOCK_ALLOC |
92 | #define sysfs_dirent_init_lockdep(sd) \ | 93 | #define sysfs_dirent_init_lockdep(sd) \ |
93 | do { \ | 94 | do { \ |
94 | static struct lock_class_key __key; \ | 95 | struct attribute *attr = sd->s_attr.attr; \ |
96 | struct lock_class_key *key = attr->key; \ | ||
97 | if (!key) \ | ||
98 | key = &attr->skey; \ | ||
95 | \ | 99 | \ |
96 | lockdep_init_map(&sd->dep_map, "s_active", &__key, 0); \ | 100 | lockdep_init_map(&sd->dep_map, "s_active", key, 0); \ |
97 | } while(0) | 101 | } while(0) |
98 | #else | 102 | #else |
99 | #define sysfs_dirent_init_lockdep(sd) do {} while(0) | 103 | #define sysfs_dirent_init_lockdep(sd) do {} while(0) |
@@ -111,7 +115,6 @@ struct sysfs_addrm_cxt { | |||
111 | * mount.c | 115 | * mount.c |
112 | */ | 116 | */ |
113 | extern struct sysfs_dirent sysfs_root; | 117 | extern struct sysfs_dirent sysfs_root; |
114 | extern struct super_block *sysfs_sb; | ||
115 | extern struct kmem_cache *sysfs_dir_cachep; | 118 | extern struct kmem_cache *sysfs_dir_cachep; |
116 | 119 | ||
117 | /* | 120 | /* |
@@ -124,8 +127,8 @@ extern const struct file_operations sysfs_dir_operations; | |||
124 | extern const struct inode_operations sysfs_dir_inode_operations; | 127 | extern const struct inode_operations sysfs_dir_inode_operations; |
125 | 128 | ||
126 | struct dentry *sysfs_get_dentry(struct sysfs_dirent *sd); | 129 | struct dentry *sysfs_get_dentry(struct sysfs_dirent *sd); |
127 | struct sysfs_dirent *sysfs_get_active_two(struct sysfs_dirent *sd); | 130 | struct sysfs_dirent *sysfs_get_active(struct sysfs_dirent *sd); |
128 | void sysfs_put_active_two(struct sysfs_dirent *sd); | 131 | void sysfs_put_active(struct sysfs_dirent *sd); |
129 | void sysfs_addrm_start(struct sysfs_addrm_cxt *acxt, | 132 | void sysfs_addrm_start(struct sysfs_addrm_cxt *acxt, |
130 | struct sysfs_dirent *parent_sd); | 133 | struct sysfs_dirent *parent_sd); |
131 | int __sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd); | 134 | int __sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd); |
@@ -168,7 +171,7 @@ static inline void __sysfs_put(struct sysfs_dirent *sd) | |||
168 | /* | 171 | /* |
169 | * inode.c | 172 | * inode.c |
170 | */ | 173 | */ |
171 | struct inode *sysfs_get_inode(struct sysfs_dirent *sd); | 174 | struct inode *sysfs_get_inode(struct super_block *sb, struct sysfs_dirent *sd); |
172 | void sysfs_delete_inode(struct inode *inode); | 175 | void sysfs_delete_inode(struct inode *inode); |
173 | int sysfs_sd_setattr(struct sysfs_dirent *sd, struct iattr *iattr); | 176 | int sysfs_sd_setattr(struct sysfs_dirent *sd, struct iattr *iattr); |
174 | int sysfs_permission(struct inode *inode, int mask); | 177 | int sysfs_permission(struct inode *inode, int mask); |
diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c index 9824743832a7..4573734d723d 100644 --- a/fs/sysv/inode.c +++ b/fs/sysv/inode.c | |||
@@ -26,6 +26,7 @@ | |||
26 | #include <linux/init.h> | 26 | #include <linux/init.h> |
27 | #include <linux/buffer_head.h> | 27 | #include <linux/buffer_head.h> |
28 | #include <linux/vfs.h> | 28 | #include <linux/vfs.h> |
29 | #include <linux/writeback.h> | ||
29 | #include <linux/namei.h> | 30 | #include <linux/namei.h> |
30 | #include <asm/byteorder.h> | 31 | #include <asm/byteorder.h> |
31 | #include "sysv.h" | 32 | #include "sysv.h" |
@@ -246,7 +247,7 @@ bad_inode: | |||
246 | return ERR_PTR(-EIO); | 247 | return ERR_PTR(-EIO); |
247 | } | 248 | } |
248 | 249 | ||
249 | int sysv_write_inode(struct inode *inode, int wait) | 250 | static int __sysv_write_inode(struct inode *inode, int wait) |
250 | { | 251 | { |
251 | struct super_block * sb = inode->i_sb; | 252 | struct super_block * sb = inode->i_sb; |
252 | struct sysv_sb_info * sbi = SYSV_SB(sb); | 253 | struct sysv_sb_info * sbi = SYSV_SB(sb); |
@@ -296,9 +297,14 @@ int sysv_write_inode(struct inode *inode, int wait) | |||
296 | return 0; | 297 | return 0; |
297 | } | 298 | } |
298 | 299 | ||
300 | int sysv_write_inode(struct inode *inode, struct writeback_control *wbc) | ||
301 | { | ||
302 | return __sysv_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL); | ||
303 | } | ||
304 | |||
299 | int sysv_sync_inode(struct inode *inode) | 305 | int sysv_sync_inode(struct inode *inode) |
300 | { | 306 | { |
301 | return sysv_write_inode(inode, 1); | 307 | return __sysv_write_inode(inode, 1); |
302 | } | 308 | } |
303 | 309 | ||
304 | static void sysv_delete_inode(struct inode *inode) | 310 | static void sysv_delete_inode(struct inode *inode) |
diff --git a/fs/sysv/sysv.h b/fs/sysv/sysv.h index 53786eb5cf60..94cb9b4d76c2 100644 --- a/fs/sysv/sysv.h +++ b/fs/sysv/sysv.h | |||
@@ -142,7 +142,7 @@ extern int __sysv_write_begin(struct file *file, struct address_space *mapping, | |||
142 | 142 | ||
143 | /* inode.c */ | 143 | /* inode.c */ |
144 | extern struct inode *sysv_iget(struct super_block *, unsigned int); | 144 | extern struct inode *sysv_iget(struct super_block *, unsigned int); |
145 | extern int sysv_write_inode(struct inode *, int); | 145 | extern int sysv_write_inode(struct inode *, struct writeback_control *wbc); |
146 | extern int sysv_sync_inode(struct inode *); | 146 | extern int sysv_sync_inode(struct inode *); |
147 | extern void sysv_set_inode(struct inode *, dev_t); | 147 | extern void sysv_set_inode(struct inode *, dev_t); |
148 | extern int sysv_getattr(struct vfsmount *, struct dentry *, struct kstat *); | 148 | extern int sysv_getattr(struct vfsmount *, struct dentry *, struct kstat *); |
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c index 552fb0111fff..401e503d44a1 100644 --- a/fs/ubifs/dir.c +++ b/fs/ubifs/dir.c | |||
@@ -1120,7 +1120,7 @@ static int ubifs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
1120 | if (release) | 1120 | if (release) |
1121 | ubifs_release_budget(c, &ino_req); | 1121 | ubifs_release_budget(c, &ino_req); |
1122 | if (IS_SYNC(old_inode)) | 1122 | if (IS_SYNC(old_inode)) |
1123 | err = old_inode->i_sb->s_op->write_inode(old_inode, 1); | 1123 | err = old_inode->i_sb->s_op->write_inode(old_inode, NULL); |
1124 | return err; | 1124 | return err; |
1125 | 1125 | ||
1126 | out_cancel: | 1126 | out_cancel: |
diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c index 16a6444330ec..e26c02ab6cd5 100644 --- a/fs/ubifs/file.c +++ b/fs/ubifs/file.c | |||
@@ -1011,7 +1011,7 @@ static int ubifs_writepage(struct page *page, struct writeback_control *wbc) | |||
1011 | /* Is the page fully inside @i_size? */ | 1011 | /* Is the page fully inside @i_size? */ |
1012 | if (page->index < end_index) { | 1012 | if (page->index < end_index) { |
1013 | if (page->index >= synced_i_size >> PAGE_CACHE_SHIFT) { | 1013 | if (page->index >= synced_i_size >> PAGE_CACHE_SHIFT) { |
1014 | err = inode->i_sb->s_op->write_inode(inode, 1); | 1014 | err = inode->i_sb->s_op->write_inode(inode, NULL); |
1015 | if (err) | 1015 | if (err) |
1016 | goto out_unlock; | 1016 | goto out_unlock; |
1017 | /* | 1017 | /* |
@@ -1039,7 +1039,7 @@ static int ubifs_writepage(struct page *page, struct writeback_control *wbc) | |||
1039 | kunmap_atomic(kaddr, KM_USER0); | 1039 | kunmap_atomic(kaddr, KM_USER0); |
1040 | 1040 | ||
1041 | if (i_size > synced_i_size) { | 1041 | if (i_size > synced_i_size) { |
1042 | err = inode->i_sb->s_op->write_inode(inode, 1); | 1042 | err = inode->i_sb->s_op->write_inode(inode, NULL); |
1043 | if (err) | 1043 | if (err) |
1044 | goto out_unlock; | 1044 | goto out_unlock; |
1045 | } | 1045 | } |
@@ -1242,7 +1242,7 @@ static int do_setattr(struct ubifs_info *c, struct inode *inode, | |||
1242 | if (release) | 1242 | if (release) |
1243 | ubifs_release_budget(c, &req); | 1243 | ubifs_release_budget(c, &req); |
1244 | if (IS_SYNC(inode)) | 1244 | if (IS_SYNC(inode)) |
1245 | err = inode->i_sb->s_op->write_inode(inode, 1); | 1245 | err = inode->i_sb->s_op->write_inode(inode, NULL); |
1246 | return err; | 1246 | return err; |
1247 | 1247 | ||
1248 | out: | 1248 | out: |
@@ -1316,7 +1316,7 @@ int ubifs_fsync(struct file *file, struct dentry *dentry, int datasync) | |||
1316 | * the inode unless this is a 'datasync()' call. | 1316 | * the inode unless this is a 'datasync()' call. |
1317 | */ | 1317 | */ |
1318 | if (!datasync || (inode->i_state & I_DIRTY_DATASYNC)) { | 1318 | if (!datasync || (inode->i_state & I_DIRTY_DATASYNC)) { |
1319 | err = inode->i_sb->s_op->write_inode(inode, 1); | 1319 | err = inode->i_sb->s_op->write_inode(inode, NULL); |
1320 | if (err) | 1320 | if (err) |
1321 | return err; | 1321 | return err; |
1322 | } | 1322 | } |
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 43f9d19a6f33..4d2f2157dd3f 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c | |||
@@ -283,7 +283,7 @@ static void ubifs_destroy_inode(struct inode *inode) | |||
283 | /* | 283 | /* |
284 | * Note, Linux write-back code calls this without 'i_mutex'. | 284 | * Note, Linux write-back code calls this without 'i_mutex'. |
285 | */ | 285 | */ |
286 | static int ubifs_write_inode(struct inode *inode, int wait) | 286 | static int ubifs_write_inode(struct inode *inode, struct writeback_control *wbc) |
287 | { | 287 | { |
288 | int err = 0; | 288 | int err = 0; |
289 | struct ubifs_info *c = inode->i_sb->s_fs_info; | 289 | struct ubifs_info *c = inode->i_sb->s_fs_info; |
diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c index 82372e332f08..ccc3ad7242d4 100644 --- a/fs/udf/balloc.c +++ b/fs/udf/balloc.c | |||
@@ -208,7 +208,7 @@ static void udf_bitmap_free_blocks(struct super_block *sb, | |||
208 | ((char *)bh->b_data)[(bit + i) >> 3]); | 208 | ((char *)bh->b_data)[(bit + i) >> 3]); |
209 | } else { | 209 | } else { |
210 | if (inode) | 210 | if (inode) |
211 | vfs_dq_free_block(inode, 1); | 211 | dquot_free_block(inode, 1); |
212 | udf_add_free_space(sb, sbi->s_partition, 1); | 212 | udf_add_free_space(sb, sbi->s_partition, 1); |
213 | } | 213 | } |
214 | } | 214 | } |
@@ -260,11 +260,11 @@ static int udf_bitmap_prealloc_blocks(struct super_block *sb, | |||
260 | while (bit < (sb->s_blocksize << 3) && block_count > 0) { | 260 | while (bit < (sb->s_blocksize << 3) && block_count > 0) { |
261 | if (!udf_test_bit(bit, bh->b_data)) | 261 | if (!udf_test_bit(bit, bh->b_data)) |
262 | goto out; | 262 | goto out; |
263 | else if (vfs_dq_prealloc_block(inode, 1)) | 263 | else if (dquot_prealloc_block(inode, 1)) |
264 | goto out; | 264 | goto out; |
265 | else if (!udf_clear_bit(bit, bh->b_data)) { | 265 | else if (!udf_clear_bit(bit, bh->b_data)) { |
266 | udf_debug("bit already cleared for block %d\n", bit); | 266 | udf_debug("bit already cleared for block %d\n", bit); |
267 | vfs_dq_free_block(inode, 1); | 267 | dquot_free_block(inode, 1); |
268 | goto out; | 268 | goto out; |
269 | } | 269 | } |
270 | block_count--; | 270 | block_count--; |
@@ -390,10 +390,14 @@ got_block: | |||
390 | /* | 390 | /* |
391 | * Check quota for allocation of this block. | 391 | * Check quota for allocation of this block. |
392 | */ | 392 | */ |
393 | if (inode && vfs_dq_alloc_block(inode, 1)) { | 393 | if (inode) { |
394 | mutex_unlock(&sbi->s_alloc_mutex); | 394 | int ret = dquot_alloc_block(inode, 1); |
395 | *err = -EDQUOT; | 395 | |
396 | return 0; | 396 | if (ret) { |
397 | mutex_unlock(&sbi->s_alloc_mutex); | ||
398 | *err = ret; | ||
399 | return 0; | ||
400 | } | ||
397 | } | 401 | } |
398 | 402 | ||
399 | newblock = bit + (block_group << (sb->s_blocksize_bits + 3)) - | 403 | newblock = bit + (block_group << (sb->s_blocksize_bits + 3)) - |
@@ -449,7 +453,7 @@ static void udf_table_free_blocks(struct super_block *sb, | |||
449 | /* We do this up front - There are some error conditions that | 453 | /* We do this up front - There are some error conditions that |
450 | could occure, but.. oh well */ | 454 | could occure, but.. oh well */ |
451 | if (inode) | 455 | if (inode) |
452 | vfs_dq_free_block(inode, count); | 456 | dquot_free_block(inode, count); |
453 | udf_add_free_space(sb, sbi->s_partition, count); | 457 | udf_add_free_space(sb, sbi->s_partition, count); |
454 | 458 | ||
455 | start = bloc->logicalBlockNum + offset; | 459 | start = bloc->logicalBlockNum + offset; |
@@ -547,7 +551,7 @@ static void udf_table_free_blocks(struct super_block *sb, | |||
547 | } | 551 | } |
548 | 552 | ||
549 | if (epos.offset + (2 * adsize) > sb->s_blocksize) { | 553 | if (epos.offset + (2 * adsize) > sb->s_blocksize) { |
550 | char *sptr, *dptr; | 554 | unsigned char *sptr, *dptr; |
551 | int loffset; | 555 | int loffset; |
552 | 556 | ||
553 | brelse(oepos.bh); | 557 | brelse(oepos.bh); |
@@ -694,7 +698,7 @@ static int udf_table_prealloc_blocks(struct super_block *sb, | |||
694 | epos.offset -= adsize; | 698 | epos.offset -= adsize; |
695 | 699 | ||
696 | alloc_count = (elen >> sb->s_blocksize_bits); | 700 | alloc_count = (elen >> sb->s_blocksize_bits); |
697 | if (inode && vfs_dq_prealloc_block(inode, | 701 | if (inode && dquot_prealloc_block(inode, |
698 | alloc_count > block_count ? block_count : alloc_count)) | 702 | alloc_count > block_count ? block_count : alloc_count)) |
699 | alloc_count = 0; | 703 | alloc_count = 0; |
700 | else if (alloc_count > block_count) { | 704 | else if (alloc_count > block_count) { |
@@ -797,12 +801,13 @@ static int udf_table_new_block(struct super_block *sb, | |||
797 | newblock = goal_eloc.logicalBlockNum; | 801 | newblock = goal_eloc.logicalBlockNum; |
798 | goal_eloc.logicalBlockNum++; | 802 | goal_eloc.logicalBlockNum++; |
799 | goal_elen -= sb->s_blocksize; | 803 | goal_elen -= sb->s_blocksize; |
800 | 804 | if (inode) { | |
801 | if (inode && vfs_dq_alloc_block(inode, 1)) { | 805 | *err = dquot_alloc_block(inode, 1); |
802 | brelse(goal_epos.bh); | 806 | if (*err) { |
803 | mutex_unlock(&sbi->s_alloc_mutex); | 807 | brelse(goal_epos.bh); |
804 | *err = -EDQUOT; | 808 | mutex_unlock(&sbi->s_alloc_mutex); |
805 | return 0; | 809 | return 0; |
810 | } | ||
806 | } | 811 | } |
807 | 812 | ||
808 | if (goal_elen) | 813 | if (goal_elen) |
diff --git a/fs/udf/dir.c b/fs/udf/dir.c index 61d9a76a3a69..f0f2a436251e 100644 --- a/fs/udf/dir.c +++ b/fs/udf/dir.c | |||
@@ -45,8 +45,8 @@ static int do_udf_readdir(struct inode *dir, struct file *filp, | |||
45 | int block, iblock; | 45 | int block, iblock; |
46 | loff_t nf_pos = (filp->f_pos - 1) << 2; | 46 | loff_t nf_pos = (filp->f_pos - 1) << 2; |
47 | int flen; | 47 | int flen; |
48 | char *fname = NULL; | 48 | unsigned char *fname = NULL; |
49 | char *nameptr; | 49 | unsigned char *nameptr; |
50 | uint16_t liu; | 50 | uint16_t liu; |
51 | uint8_t lfi; | 51 | uint8_t lfi; |
52 | loff_t size = udf_ext0_offset(dir) + dir->i_size; | 52 | loff_t size = udf_ext0_offset(dir) + dir->i_size; |
diff --git a/fs/udf/file.c b/fs/udf/file.c index f311d509b6a3..1eb06774ed90 100644 --- a/fs/udf/file.c +++ b/fs/udf/file.c | |||
@@ -34,6 +34,7 @@ | |||
34 | #include <linux/errno.h> | 34 | #include <linux/errno.h> |
35 | #include <linux/smp_lock.h> | 35 | #include <linux/smp_lock.h> |
36 | #include <linux/pagemap.h> | 36 | #include <linux/pagemap.h> |
37 | #include <linux/quotaops.h> | ||
37 | #include <linux/buffer_head.h> | 38 | #include <linux/buffer_head.h> |
38 | #include <linux/aio.h> | 39 | #include <linux/aio.h> |
39 | 40 | ||
@@ -207,7 +208,7 @@ const struct file_operations udf_file_operations = { | |||
207 | .read = do_sync_read, | 208 | .read = do_sync_read, |
208 | .aio_read = generic_file_aio_read, | 209 | .aio_read = generic_file_aio_read, |
209 | .ioctl = udf_ioctl, | 210 | .ioctl = udf_ioctl, |
210 | .open = generic_file_open, | 211 | .open = dquot_file_open, |
211 | .mmap = generic_file_mmap, | 212 | .mmap = generic_file_mmap, |
212 | .write = do_sync_write, | 213 | .write = do_sync_write, |
213 | .aio_write = udf_file_aio_write, | 214 | .aio_write = udf_file_aio_write, |
@@ -217,6 +218,29 @@ const struct file_operations udf_file_operations = { | |||
217 | .llseek = generic_file_llseek, | 218 | .llseek = generic_file_llseek, |
218 | }; | 219 | }; |
219 | 220 | ||
221 | static int udf_setattr(struct dentry *dentry, struct iattr *iattr) | ||
222 | { | ||
223 | struct inode *inode = dentry->d_inode; | ||
224 | int error; | ||
225 | |||
226 | error = inode_change_ok(inode, iattr); | ||
227 | if (error) | ||
228 | return error; | ||
229 | |||
230 | if (iattr->ia_valid & ATTR_SIZE) | ||
231 | dquot_initialize(inode); | ||
232 | |||
233 | if ((iattr->ia_valid & ATTR_UID && iattr->ia_uid != inode->i_uid) || | ||
234 | (iattr->ia_valid & ATTR_GID && iattr->ia_gid != inode->i_gid)) { | ||
235 | error = dquot_transfer(inode, iattr); | ||
236 | if (error) | ||
237 | return error; | ||
238 | } | ||
239 | |||
240 | return inode_setattr(inode, iattr); | ||
241 | } | ||
242 | |||
220 | const struct inode_operations udf_file_inode_operations = { | 243 | const struct inode_operations udf_file_inode_operations = { |
221 | .truncate = udf_truncate, | 244 | .truncate = udf_truncate, |
245 | .setattr = udf_setattr, | ||
222 | }; | 246 | }; |
diff --git a/fs/udf/ialloc.c b/fs/udf/ialloc.c index c10fa39f97e2..fb68c9cd0c3e 100644 --- a/fs/udf/ialloc.c +++ b/fs/udf/ialloc.c | |||
@@ -36,8 +36,8 @@ void udf_free_inode(struct inode *inode) | |||
36 | * Note: we must free any quota before locking the superblock, | 36 | * Note: we must free any quota before locking the superblock, |
37 | * as writing the quota to disk may need the lock as well. | 37 | * as writing the quota to disk may need the lock as well. |
38 | */ | 38 | */ |
39 | vfs_dq_free_inode(inode); | 39 | dquot_free_inode(inode); |
40 | vfs_dq_drop(inode); | 40 | dquot_drop(inode); |
41 | 41 | ||
42 | clear_inode(inode); | 42 | clear_inode(inode); |
43 | 43 | ||
@@ -61,7 +61,7 @@ struct inode *udf_new_inode(struct inode *dir, int mode, int *err) | |||
61 | struct super_block *sb = dir->i_sb; | 61 | struct super_block *sb = dir->i_sb; |
62 | struct udf_sb_info *sbi = UDF_SB(sb); | 62 | struct udf_sb_info *sbi = UDF_SB(sb); |
63 | struct inode *inode; | 63 | struct inode *inode; |
64 | int block; | 64 | int block, ret; |
65 | uint32_t start = UDF_I(dir)->i_location.logicalBlockNum; | 65 | uint32_t start = UDF_I(dir)->i_location.logicalBlockNum; |
66 | struct udf_inode_info *iinfo; | 66 | struct udf_inode_info *iinfo; |
67 | struct udf_inode_info *dinfo = UDF_I(dir); | 67 | struct udf_inode_info *dinfo = UDF_I(dir); |
@@ -153,12 +153,14 @@ struct inode *udf_new_inode(struct inode *dir, int mode, int *err) | |||
153 | insert_inode_hash(inode); | 153 | insert_inode_hash(inode); |
154 | mark_inode_dirty(inode); | 154 | mark_inode_dirty(inode); |
155 | 155 | ||
156 | if (vfs_dq_alloc_inode(inode)) { | 156 | dquot_initialize(inode); |
157 | vfs_dq_drop(inode); | 157 | ret = dquot_alloc_inode(inode); |
158 | if (ret) { | ||
159 | dquot_drop(inode); | ||
158 | inode->i_flags |= S_NOQUOTA; | 160 | inode->i_flags |= S_NOQUOTA; |
159 | inode->i_nlink = 0; | 161 | inode->i_nlink = 0; |
160 | iput(inode); | 162 | iput(inode); |
161 | *err = -EDQUOT; | 163 | *err = ret; |
162 | return NULL; | 164 | return NULL; |
163 | } | 165 | } |
164 | 166 | ||
diff --git a/fs/udf/inode.c b/fs/udf/inode.c index f90231eb2916..b57ab0402d89 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c | |||
@@ -36,6 +36,7 @@ | |||
36 | #include <linux/pagemap.h> | 36 | #include <linux/pagemap.h> |
37 | #include <linux/buffer_head.h> | 37 | #include <linux/buffer_head.h> |
38 | #include <linux/writeback.h> | 38 | #include <linux/writeback.h> |
39 | #include <linux/quotaops.h> | ||
39 | #include <linux/slab.h> | 40 | #include <linux/slab.h> |
40 | #include <linux/crc-itu-t.h> | 41 | #include <linux/crc-itu-t.h> |
41 | 42 | ||
@@ -70,6 +71,9 @@ static int udf_get_block(struct inode *, sector_t, struct buffer_head *, int); | |||
70 | 71 | ||
71 | void udf_delete_inode(struct inode *inode) | 72 | void udf_delete_inode(struct inode *inode) |
72 | { | 73 | { |
74 | if (!is_bad_inode(inode)) | ||
75 | dquot_initialize(inode); | ||
76 | |||
73 | truncate_inode_pages(&inode->i_data, 0); | 77 | truncate_inode_pages(&inode->i_data, 0); |
74 | 78 | ||
75 | if (is_bad_inode(inode)) | 79 | if (is_bad_inode(inode)) |
@@ -108,6 +112,8 @@ void udf_clear_inode(struct inode *inode) | |||
108 | (unsigned long long)inode->i_size, | 112 | (unsigned long long)inode->i_size, |
109 | (unsigned long long)iinfo->i_lenExtents); | 113 | (unsigned long long)iinfo->i_lenExtents); |
110 | } | 114 | } |
115 | |||
116 | dquot_drop(inode); | ||
111 | kfree(iinfo->i_ext.i_data); | 117 | kfree(iinfo->i_ext.i_data); |
112 | iinfo->i_ext.i_data = NULL; | 118 | iinfo->i_ext.i_data = NULL; |
113 | } | 119 | } |
@@ -1373,12 +1379,12 @@ static mode_t udf_convert_permissions(struct fileEntry *fe) | |||
1373 | return mode; | 1379 | return mode; |
1374 | } | 1380 | } |
1375 | 1381 | ||
1376 | int udf_write_inode(struct inode *inode, int sync) | 1382 | int udf_write_inode(struct inode *inode, struct writeback_control *wbc) |
1377 | { | 1383 | { |
1378 | int ret; | 1384 | int ret; |
1379 | 1385 | ||
1380 | lock_kernel(); | 1386 | lock_kernel(); |
1381 | ret = udf_update_inode(inode, sync); | 1387 | ret = udf_update_inode(inode, wbc->sync_mode == WB_SYNC_ALL); |
1382 | unlock_kernel(); | 1388 | unlock_kernel(); |
1383 | 1389 | ||
1384 | return ret; | 1390 | return ret; |
@@ -1672,7 +1678,7 @@ int8_t udf_add_aext(struct inode *inode, struct extent_position *epos, | |||
1672 | return -1; | 1678 | return -1; |
1673 | 1679 | ||
1674 | if (epos->offset + (2 * adsize) > inode->i_sb->s_blocksize) { | 1680 | if (epos->offset + (2 * adsize) > inode->i_sb->s_blocksize) { |
1675 | char *sptr, *dptr; | 1681 | unsigned char *sptr, *dptr; |
1676 | struct buffer_head *nbh; | 1682 | struct buffer_head *nbh; |
1677 | int err, loffset; | 1683 | int err, loffset; |
1678 | struct kernel_lb_addr obloc = epos->block; | 1684 | struct kernel_lb_addr obloc = epos->block; |
diff --git a/fs/udf/namei.c b/fs/udf/namei.c index cd2115060fdc..db423ab078b1 100644 --- a/fs/udf/namei.c +++ b/fs/udf/namei.c | |||
@@ -34,8 +34,8 @@ | |||
34 | #include <linux/crc-itu-t.h> | 34 | #include <linux/crc-itu-t.h> |
35 | #include <linux/exportfs.h> | 35 | #include <linux/exportfs.h> |
36 | 36 | ||
37 | static inline int udf_match(int len1, const char *name1, int len2, | 37 | static inline int udf_match(int len1, const unsigned char *name1, int len2, |
38 | const char *name2) | 38 | const unsigned char *name2) |
39 | { | 39 | { |
40 | if (len1 != len2) | 40 | if (len1 != len2) |
41 | return 0; | 41 | return 0; |
@@ -142,15 +142,15 @@ int udf_write_fi(struct inode *inode, struct fileIdentDesc *cfi, | |||
142 | } | 142 | } |
143 | 143 | ||
144 | static struct fileIdentDesc *udf_find_entry(struct inode *dir, | 144 | static struct fileIdentDesc *udf_find_entry(struct inode *dir, |
145 | struct qstr *child, | 145 | const struct qstr *child, |
146 | struct udf_fileident_bh *fibh, | 146 | struct udf_fileident_bh *fibh, |
147 | struct fileIdentDesc *cfi) | 147 | struct fileIdentDesc *cfi) |
148 | { | 148 | { |
149 | struct fileIdentDesc *fi = NULL; | 149 | struct fileIdentDesc *fi = NULL; |
150 | loff_t f_pos; | 150 | loff_t f_pos; |
151 | int block, flen; | 151 | int block, flen; |
152 | char *fname = NULL; | 152 | unsigned char *fname = NULL; |
153 | char *nameptr; | 153 | unsigned char *nameptr; |
154 | uint8_t lfi; | 154 | uint8_t lfi; |
155 | uint16_t liu; | 155 | uint16_t liu; |
156 | loff_t size; | 156 | loff_t size; |
@@ -308,7 +308,7 @@ static struct fileIdentDesc *udf_add_entry(struct inode *dir, | |||
308 | { | 308 | { |
309 | struct super_block *sb = dir->i_sb; | 309 | struct super_block *sb = dir->i_sb; |
310 | struct fileIdentDesc *fi = NULL; | 310 | struct fileIdentDesc *fi = NULL; |
311 | char *name = NULL; | 311 | unsigned char *name = NULL; |
312 | int namelen; | 312 | int namelen; |
313 | loff_t f_pos; | 313 | loff_t f_pos; |
314 | loff_t size = udf_ext0_offset(dir) + dir->i_size; | 314 | loff_t size = udf_ext0_offset(dir) + dir->i_size; |
@@ -563,6 +563,8 @@ static int udf_create(struct inode *dir, struct dentry *dentry, int mode, | |||
563 | int err; | 563 | int err; |
564 | struct udf_inode_info *iinfo; | 564 | struct udf_inode_info *iinfo; |
565 | 565 | ||
566 | dquot_initialize(dir); | ||
567 | |||
566 | lock_kernel(); | 568 | lock_kernel(); |
567 | inode = udf_new_inode(dir, mode, &err); | 569 | inode = udf_new_inode(dir, mode, &err); |
568 | if (!inode) { | 570 | if (!inode) { |
@@ -616,6 +618,8 @@ static int udf_mknod(struct inode *dir, struct dentry *dentry, int mode, | |||
616 | if (!old_valid_dev(rdev)) | 618 | if (!old_valid_dev(rdev)) |
617 | return -EINVAL; | 619 | return -EINVAL; |
618 | 620 | ||
621 | dquot_initialize(dir); | ||
622 | |||
619 | lock_kernel(); | 623 | lock_kernel(); |
620 | err = -EIO; | 624 | err = -EIO; |
621 | inode = udf_new_inode(dir, mode, &err); | 625 | inode = udf_new_inode(dir, mode, &err); |
@@ -662,6 +666,8 @@ static int udf_mkdir(struct inode *dir, struct dentry *dentry, int mode) | |||
662 | struct udf_inode_info *dinfo = UDF_I(dir); | 666 | struct udf_inode_info *dinfo = UDF_I(dir); |
663 | struct udf_inode_info *iinfo; | 667 | struct udf_inode_info *iinfo; |
664 | 668 | ||
669 | dquot_initialize(dir); | ||
670 | |||
665 | lock_kernel(); | 671 | lock_kernel(); |
666 | err = -EMLINK; | 672 | err = -EMLINK; |
667 | if (dir->i_nlink >= (256 << sizeof(dir->i_nlink)) - 1) | 673 | if (dir->i_nlink >= (256 << sizeof(dir->i_nlink)) - 1) |
@@ -799,6 +805,8 @@ static int udf_rmdir(struct inode *dir, struct dentry *dentry) | |||
799 | struct fileIdentDesc *fi, cfi; | 805 | struct fileIdentDesc *fi, cfi; |
800 | struct kernel_lb_addr tloc; | 806 | struct kernel_lb_addr tloc; |
801 | 807 | ||
808 | dquot_initialize(dir); | ||
809 | |||
802 | retval = -ENOENT; | 810 | retval = -ENOENT; |
803 | lock_kernel(); | 811 | lock_kernel(); |
804 | fi = udf_find_entry(dir, &dentry->d_name, &fibh, &cfi); | 812 | fi = udf_find_entry(dir, &dentry->d_name, &fibh, &cfi); |
@@ -845,6 +853,8 @@ static int udf_unlink(struct inode *dir, struct dentry *dentry) | |||
845 | struct fileIdentDesc cfi; | 853 | struct fileIdentDesc cfi; |
846 | struct kernel_lb_addr tloc; | 854 | struct kernel_lb_addr tloc; |
847 | 855 | ||
856 | dquot_initialize(dir); | ||
857 | |||
848 | retval = -ENOENT; | 858 | retval = -ENOENT; |
849 | lock_kernel(); | 859 | lock_kernel(); |
850 | fi = udf_find_entry(dir, &dentry->d_name, &fibh, &cfi); | 860 | fi = udf_find_entry(dir, &dentry->d_name, &fibh, &cfi); |
@@ -885,20 +895,22 @@ static int udf_symlink(struct inode *dir, struct dentry *dentry, | |||
885 | { | 895 | { |
886 | struct inode *inode; | 896 | struct inode *inode; |
887 | struct pathComponent *pc; | 897 | struct pathComponent *pc; |
888 | char *compstart; | 898 | const char *compstart; |
889 | struct udf_fileident_bh fibh; | 899 | struct udf_fileident_bh fibh; |
890 | struct extent_position epos = {}; | 900 | struct extent_position epos = {}; |
891 | int eoffset, elen = 0; | 901 | int eoffset, elen = 0; |
892 | struct fileIdentDesc *fi; | 902 | struct fileIdentDesc *fi; |
893 | struct fileIdentDesc cfi; | 903 | struct fileIdentDesc cfi; |
894 | char *ea; | 904 | uint8_t *ea; |
895 | int err; | 905 | int err; |
896 | int block; | 906 | int block; |
897 | char *name = NULL; | 907 | unsigned char *name = NULL; |
898 | int namelen; | 908 | int namelen; |
899 | struct buffer_head *bh; | 909 | struct buffer_head *bh; |
900 | struct udf_inode_info *iinfo; | 910 | struct udf_inode_info *iinfo; |
901 | 911 | ||
912 | dquot_initialize(dir); | ||
913 | |||
902 | lock_kernel(); | 914 | lock_kernel(); |
903 | inode = udf_new_inode(dir, S_IFLNK, &err); | 915 | inode = udf_new_inode(dir, S_IFLNK, &err); |
904 | if (!inode) | 916 | if (!inode) |
@@ -970,7 +982,7 @@ static int udf_symlink(struct inode *dir, struct dentry *dentry, | |||
970 | 982 | ||
971 | pc = (struct pathComponent *)(ea + elen); | 983 | pc = (struct pathComponent *)(ea + elen); |
972 | 984 | ||
973 | compstart = (char *)symname; | 985 | compstart = symname; |
974 | 986 | ||
975 | do { | 987 | do { |
976 | symname++; | 988 | symname++; |
@@ -1069,6 +1081,8 @@ static int udf_link(struct dentry *old_dentry, struct inode *dir, | |||
1069 | int err; | 1081 | int err; |
1070 | struct buffer_head *bh; | 1082 | struct buffer_head *bh; |
1071 | 1083 | ||
1084 | dquot_initialize(dir); | ||
1085 | |||
1072 | lock_kernel(); | 1086 | lock_kernel(); |
1073 | if (inode->i_nlink >= (256 << sizeof(inode->i_nlink)) - 1) { | 1087 | if (inode->i_nlink >= (256 << sizeof(inode->i_nlink)) - 1) { |
1074 | unlock_kernel(); | 1088 | unlock_kernel(); |
@@ -1131,6 +1145,9 @@ static int udf_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
1131 | struct kernel_lb_addr tloc; | 1145 | struct kernel_lb_addr tloc; |
1132 | struct udf_inode_info *old_iinfo = UDF_I(old_inode); | 1146 | struct udf_inode_info *old_iinfo = UDF_I(old_inode); |
1133 | 1147 | ||
1148 | dquot_initialize(old_dir); | ||
1149 | dquot_initialize(new_dir); | ||
1150 | |||
1134 | lock_kernel(); | 1151 | lock_kernel(); |
1135 | ofi = udf_find_entry(old_dir, &old_dentry->d_name, &ofibh, &ocfi); | 1152 | ofi = udf_find_entry(old_dir, &old_dentry->d_name, &ofibh, &ocfi); |
1136 | if (ofi) { | 1153 | if (ofi) { |
diff --git a/fs/udf/symlink.c b/fs/udf/symlink.c index c3265e1385d4..852e91845688 100644 --- a/fs/udf/symlink.c +++ b/fs/udf/symlink.c | |||
@@ -32,12 +32,12 @@ | |||
32 | #include <linux/buffer_head.h> | 32 | #include <linux/buffer_head.h> |
33 | #include "udf_i.h" | 33 | #include "udf_i.h" |
34 | 34 | ||
35 | static void udf_pc_to_char(struct super_block *sb, char *from, int fromlen, | 35 | static void udf_pc_to_char(struct super_block *sb, unsigned char *from, |
36 | char *to) | 36 | int fromlen, unsigned char *to) |
37 | { | 37 | { |
38 | struct pathComponent *pc; | 38 | struct pathComponent *pc; |
39 | int elen = 0; | 39 | int elen = 0; |
40 | char *p = to; | 40 | unsigned char *p = to; |
41 | 41 | ||
42 | while (elen < fromlen) { | 42 | while (elen < fromlen) { |
43 | pc = (struct pathComponent *)(from + elen); | 43 | pc = (struct pathComponent *)(from + elen); |
@@ -75,9 +75,9 @@ static int udf_symlink_filler(struct file *file, struct page *page) | |||
75 | { | 75 | { |
76 | struct inode *inode = page->mapping->host; | 76 | struct inode *inode = page->mapping->host; |
77 | struct buffer_head *bh = NULL; | 77 | struct buffer_head *bh = NULL; |
78 | char *symlink; | 78 | unsigned char *symlink; |
79 | int err = -EIO; | 79 | int err = -EIO; |
80 | char *p = kmap(page); | 80 | unsigned char *p = kmap(page); |
81 | struct udf_inode_info *iinfo; | 81 | struct udf_inode_info *iinfo; |
82 | 82 | ||
83 | lock_kernel(); | 83 | lock_kernel(); |
diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h index 8d46f4294ee7..4223ac855da9 100644 --- a/fs/udf/udfdecl.h +++ b/fs/udf/udfdecl.h | |||
@@ -142,7 +142,7 @@ extern void udf_truncate(struct inode *); | |||
142 | extern void udf_read_inode(struct inode *); | 142 | extern void udf_read_inode(struct inode *); |
143 | extern void udf_delete_inode(struct inode *); | 143 | extern void udf_delete_inode(struct inode *); |
144 | extern void udf_clear_inode(struct inode *); | 144 | extern void udf_clear_inode(struct inode *); |
145 | extern int udf_write_inode(struct inode *, int); | 145 | extern int udf_write_inode(struct inode *, struct writeback_control *wbc); |
146 | extern long udf_block_map(struct inode *, sector_t); | 146 | extern long udf_block_map(struct inode *, sector_t); |
147 | extern int udf_extend_file(struct inode *, struct extent_position *, | 147 | extern int udf_extend_file(struct inode *, struct extent_position *, |
148 | struct kernel_long_ad *, sector_t); | 148 | struct kernel_long_ad *, sector_t); |
diff --git a/fs/ufs/balloc.c b/fs/ufs/balloc.c index 54c16ec95dff..5cfa4d85ccf2 100644 --- a/fs/ufs/balloc.c +++ b/fs/ufs/balloc.c | |||
@@ -85,7 +85,7 @@ void ufs_free_fragments(struct inode *inode, u64 fragment, unsigned count) | |||
85 | "bit already cleared for fragment %u", i); | 85 | "bit already cleared for fragment %u", i); |
86 | } | 86 | } |
87 | 87 | ||
88 | vfs_dq_free_block(inode, count); | 88 | dquot_free_block(inode, count); |
89 | 89 | ||
90 | 90 | ||
91 | fs32_add(sb, &ucg->cg_cs.cs_nffree, count); | 91 | fs32_add(sb, &ucg->cg_cs.cs_nffree, count); |
@@ -195,7 +195,7 @@ do_more: | |||
195 | ubh_setblock(UCPI_UBH(ucpi), ucpi->c_freeoff, blkno); | 195 | ubh_setblock(UCPI_UBH(ucpi), ucpi->c_freeoff, blkno); |
196 | if ((UFS_SB(sb)->s_flags & UFS_CG_MASK) == UFS_CG_44BSD) | 196 | if ((UFS_SB(sb)->s_flags & UFS_CG_MASK) == UFS_CG_44BSD) |
197 | ufs_clusteracct (sb, ucpi, blkno, 1); | 197 | ufs_clusteracct (sb, ucpi, blkno, 1); |
198 | vfs_dq_free_block(inode, uspi->s_fpb); | 198 | dquot_free_block(inode, uspi->s_fpb); |
199 | 199 | ||
200 | fs32_add(sb, &ucg->cg_cs.cs_nbfree, 1); | 200 | fs32_add(sb, &ucg->cg_cs.cs_nbfree, 1); |
201 | uspi->cs_total.cs_nbfree++; | 201 | uspi->cs_total.cs_nbfree++; |
@@ -511,6 +511,7 @@ static u64 ufs_add_fragments(struct inode *inode, u64 fragment, | |||
511 | struct ufs_cg_private_info * ucpi; | 511 | struct ufs_cg_private_info * ucpi; |
512 | struct ufs_cylinder_group * ucg; | 512 | struct ufs_cylinder_group * ucg; |
513 | unsigned cgno, fragno, fragoff, count, fragsize, i; | 513 | unsigned cgno, fragno, fragoff, count, fragsize, i; |
514 | int ret; | ||
514 | 515 | ||
515 | UFSD("ENTER, fragment %llu, oldcount %u, newcount %u\n", | 516 | UFSD("ENTER, fragment %llu, oldcount %u, newcount %u\n", |
516 | (unsigned long long)fragment, oldcount, newcount); | 517 | (unsigned long long)fragment, oldcount, newcount); |
@@ -556,8 +557,9 @@ static u64 ufs_add_fragments(struct inode *inode, u64 fragment, | |||
556 | fs32_add(sb, &ucg->cg_frsum[fragsize - count], 1); | 557 | fs32_add(sb, &ucg->cg_frsum[fragsize - count], 1); |
557 | for (i = oldcount; i < newcount; i++) | 558 | for (i = oldcount; i < newcount; i++) |
558 | ubh_clrbit (UCPI_UBH(ucpi), ucpi->c_freeoff, fragno + i); | 559 | ubh_clrbit (UCPI_UBH(ucpi), ucpi->c_freeoff, fragno + i); |
559 | if (vfs_dq_alloc_block(inode, count)) { | 560 | ret = dquot_alloc_block(inode, count); |
560 | *err = -EDQUOT; | 561 | if (ret) { |
562 | *err = ret; | ||
561 | return 0; | 563 | return 0; |
562 | } | 564 | } |
563 | 565 | ||
@@ -596,6 +598,7 @@ static u64 ufs_alloc_fragments(struct inode *inode, unsigned cgno, | |||
596 | struct ufs_cylinder_group * ucg; | 598 | struct ufs_cylinder_group * ucg; |
597 | unsigned oldcg, i, j, k, allocsize; | 599 | unsigned oldcg, i, j, k, allocsize; |
598 | u64 result; | 600 | u64 result; |
601 | int ret; | ||
599 | 602 | ||
600 | UFSD("ENTER, ino %lu, cgno %u, goal %llu, count %u\n", | 603 | UFSD("ENTER, ino %lu, cgno %u, goal %llu, count %u\n", |
601 | inode->i_ino, cgno, (unsigned long long)goal, count); | 604 | inode->i_ino, cgno, (unsigned long long)goal, count); |
@@ -664,7 +667,7 @@ cg_found: | |||
664 | for (i = count; i < uspi->s_fpb; i++) | 667 | for (i = count; i < uspi->s_fpb; i++) |
665 | ubh_setbit (UCPI_UBH(ucpi), ucpi->c_freeoff, goal + i); | 668 | ubh_setbit (UCPI_UBH(ucpi), ucpi->c_freeoff, goal + i); |
666 | i = uspi->s_fpb - count; | 669 | i = uspi->s_fpb - count; |
667 | vfs_dq_free_block(inode, i); | 670 | dquot_free_block(inode, i); |
668 | 671 | ||
669 | fs32_add(sb, &ucg->cg_cs.cs_nffree, i); | 672 | fs32_add(sb, &ucg->cg_cs.cs_nffree, i); |
670 | uspi->cs_total.cs_nffree += i; | 673 | uspi->cs_total.cs_nffree += i; |
@@ -676,8 +679,9 @@ cg_found: | |||
676 | result = ufs_bitmap_search (sb, ucpi, goal, allocsize); | 679 | result = ufs_bitmap_search (sb, ucpi, goal, allocsize); |
677 | if (result == INVBLOCK) | 680 | if (result == INVBLOCK) |
678 | return 0; | 681 | return 0; |
679 | if (vfs_dq_alloc_block(inode, count)) { | 682 | ret = dquot_alloc_block(inode, count); |
680 | *err = -EDQUOT; | 683 | if (ret) { |
684 | *err = ret; | ||
681 | return 0; | 685 | return 0; |
682 | } | 686 | } |
683 | for (i = 0; i < count; i++) | 687 | for (i = 0; i < count; i++) |
@@ -714,6 +718,7 @@ static u64 ufs_alloccg_block(struct inode *inode, | |||
714 | struct ufs_super_block_first * usb1; | 718 | struct ufs_super_block_first * usb1; |
715 | struct ufs_cylinder_group * ucg; | 719 | struct ufs_cylinder_group * ucg; |
716 | u64 result, blkno; | 720 | u64 result, blkno; |
721 | int ret; | ||
717 | 722 | ||
718 | UFSD("ENTER, goal %llu\n", (unsigned long long)goal); | 723 | UFSD("ENTER, goal %llu\n", (unsigned long long)goal); |
719 | 724 | ||
@@ -747,8 +752,9 @@ gotit: | |||
747 | ubh_clrblock (UCPI_UBH(ucpi), ucpi->c_freeoff, blkno); | 752 | ubh_clrblock (UCPI_UBH(ucpi), ucpi->c_freeoff, blkno); |
748 | if ((UFS_SB(sb)->s_flags & UFS_CG_MASK) == UFS_CG_44BSD) | 753 | if ((UFS_SB(sb)->s_flags & UFS_CG_MASK) == UFS_CG_44BSD) |
749 | ufs_clusteracct (sb, ucpi, blkno, -1); | 754 | ufs_clusteracct (sb, ucpi, blkno, -1); |
750 | if (vfs_dq_alloc_block(inode, uspi->s_fpb)) { | 755 | ret = dquot_alloc_block(inode, uspi->s_fpb); |
751 | *err = -EDQUOT; | 756 | if (ret) { |
757 | *err = ret; | ||
752 | return INVBLOCK; | 758 | return INVBLOCK; |
753 | } | 759 | } |
754 | 760 | ||
diff --git a/fs/ufs/dir.c b/fs/ufs/dir.c index 22af68f8b682..317a0d444f6b 100644 --- a/fs/ufs/dir.c +++ b/fs/ufs/dir.c | |||
@@ -31,7 +31,7 @@ | |||
31 | * len <= UFS_MAXNAMLEN and de != NULL are guaranteed by caller. | 31 | * len <= UFS_MAXNAMLEN and de != NULL are guaranteed by caller. |
32 | */ | 32 | */ |
33 | static inline int ufs_match(struct super_block *sb, int len, | 33 | static inline int ufs_match(struct super_block *sb, int len, |
34 | const char * const name, struct ufs_dir_entry * de) | 34 | const unsigned char *name, struct ufs_dir_entry *de) |
35 | { | 35 | { |
36 | if (len != ufs_get_de_namlen(sb, de)) | 36 | if (len != ufs_get_de_namlen(sb, de)) |
37 | return 0; | 37 | return 0; |
@@ -70,7 +70,7 @@ static inline unsigned long ufs_dir_pages(struct inode *inode) | |||
70 | return (inode->i_size+PAGE_CACHE_SIZE-1)>>PAGE_CACHE_SHIFT; | 70 | return (inode->i_size+PAGE_CACHE_SIZE-1)>>PAGE_CACHE_SHIFT; |
71 | } | 71 | } |
72 | 72 | ||
73 | ino_t ufs_inode_by_name(struct inode *dir, struct qstr *qstr) | 73 | ino_t ufs_inode_by_name(struct inode *dir, const struct qstr *qstr) |
74 | { | 74 | { |
75 | ino_t res = 0; | 75 | ino_t res = 0; |
76 | struct ufs_dir_entry *de; | 76 | struct ufs_dir_entry *de; |
@@ -249,11 +249,11 @@ struct ufs_dir_entry *ufs_dotdot(struct inode *dir, struct page **p) | |||
249 | * (as a parameter - res_dir). Page is returned mapped and unlocked. | 249 | * (as a parameter - res_dir). Page is returned mapped and unlocked. |
250 | * Entry is guaranteed to be valid. | 250 | * Entry is guaranteed to be valid. |
251 | */ | 251 | */ |
252 | struct ufs_dir_entry *ufs_find_entry(struct inode *dir, struct qstr *qstr, | 252 | struct ufs_dir_entry *ufs_find_entry(struct inode *dir, const struct qstr *qstr, |
253 | struct page **res_page) | 253 | struct page **res_page) |
254 | { | 254 | { |
255 | struct super_block *sb = dir->i_sb; | 255 | struct super_block *sb = dir->i_sb; |
256 | const char *name = qstr->name; | 256 | const unsigned char *name = qstr->name; |
257 | int namelen = qstr->len; | 257 | int namelen = qstr->len; |
258 | unsigned reclen = UFS_DIR_REC_LEN(namelen); | 258 | unsigned reclen = UFS_DIR_REC_LEN(namelen); |
259 | unsigned long start, n; | 259 | unsigned long start, n; |
@@ -313,7 +313,7 @@ found: | |||
313 | int ufs_add_link(struct dentry *dentry, struct inode *inode) | 313 | int ufs_add_link(struct dentry *dentry, struct inode *inode) |
314 | { | 314 | { |
315 | struct inode *dir = dentry->d_parent->d_inode; | 315 | struct inode *dir = dentry->d_parent->d_inode; |
316 | const char *name = dentry->d_name.name; | 316 | const unsigned char *name = dentry->d_name.name; |
317 | int namelen = dentry->d_name.len; | 317 | int namelen = dentry->d_name.len; |
318 | struct super_block *sb = dir->i_sb; | 318 | struct super_block *sb = dir->i_sb; |
319 | unsigned reclen = UFS_DIR_REC_LEN(namelen); | 319 | unsigned reclen = UFS_DIR_REC_LEN(namelen); |
diff --git a/fs/ufs/file.c b/fs/ufs/file.c index 73655c61240a..a8962cecde5b 100644 --- a/fs/ufs/file.c +++ b/fs/ufs/file.c | |||
@@ -24,6 +24,7 @@ | |||
24 | */ | 24 | */ |
25 | 25 | ||
26 | #include <linux/fs.h> | 26 | #include <linux/fs.h> |
27 | #include <linux/quotaops.h> | ||
27 | 28 | ||
28 | #include "ufs_fs.h" | 29 | #include "ufs_fs.h" |
29 | #include "ufs.h" | 30 | #include "ufs.h" |
@@ -40,7 +41,7 @@ const struct file_operations ufs_file_operations = { | |||
40 | .write = do_sync_write, | 41 | .write = do_sync_write, |
41 | .aio_write = generic_file_aio_write, | 42 | .aio_write = generic_file_aio_write, |
42 | .mmap = generic_file_mmap, | 43 | .mmap = generic_file_mmap, |
43 | .open = generic_file_open, | 44 | .open = dquot_file_open, |
44 | .fsync = simple_fsync, | 45 | .fsync = simple_fsync, |
45 | .splice_read = generic_file_splice_read, | 46 | .splice_read = generic_file_splice_read, |
46 | }; | 47 | }; |
diff --git a/fs/ufs/ialloc.c b/fs/ufs/ialloc.c index 3527c00fef0d..230ecf608026 100644 --- a/fs/ufs/ialloc.c +++ b/fs/ufs/ialloc.c | |||
@@ -95,8 +95,8 @@ void ufs_free_inode (struct inode * inode) | |||
95 | 95 | ||
96 | is_directory = S_ISDIR(inode->i_mode); | 96 | is_directory = S_ISDIR(inode->i_mode); |
97 | 97 | ||
98 | vfs_dq_free_inode(inode); | 98 | dquot_free_inode(inode); |
99 | vfs_dq_drop(inode); | 99 | dquot_drop(inode); |
100 | 100 | ||
101 | clear_inode (inode); | 101 | clear_inode (inode); |
102 | 102 | ||
@@ -355,9 +355,10 @@ cg_found: | |||
355 | 355 | ||
356 | unlock_super (sb); | 356 | unlock_super (sb); |
357 | 357 | ||
358 | if (vfs_dq_alloc_inode(inode)) { | 358 | dquot_initialize(inode); |
359 | vfs_dq_drop(inode); | 359 | err = dquot_alloc_inode(inode); |
360 | err = -EDQUOT; | 360 | if (err) { |
361 | dquot_drop(inode); | ||
361 | goto fail_without_unlock; | 362 | goto fail_without_unlock; |
362 | } | 363 | } |
363 | 364 | ||
diff --git a/fs/ufs/inode.c b/fs/ufs/inode.c index 7cf33379fd46..80b68c3702d1 100644 --- a/fs/ufs/inode.c +++ b/fs/ufs/inode.c | |||
@@ -36,6 +36,8 @@ | |||
36 | #include <linux/mm.h> | 36 | #include <linux/mm.h> |
37 | #include <linux/smp_lock.h> | 37 | #include <linux/smp_lock.h> |
38 | #include <linux/buffer_head.h> | 38 | #include <linux/buffer_head.h> |
39 | #include <linux/writeback.h> | ||
40 | #include <linux/quotaops.h> | ||
39 | 41 | ||
40 | #include "ufs_fs.h" | 42 | #include "ufs_fs.h" |
41 | #include "ufs.h" | 43 | #include "ufs.h" |
@@ -890,11 +892,11 @@ static int ufs_update_inode(struct inode * inode, int do_sync) | |||
890 | return 0; | 892 | return 0; |
891 | } | 893 | } |
892 | 894 | ||
893 | int ufs_write_inode (struct inode * inode, int wait) | 895 | int ufs_write_inode(struct inode *inode, struct writeback_control *wbc) |
894 | { | 896 | { |
895 | int ret; | 897 | int ret; |
896 | lock_kernel(); | 898 | lock_kernel(); |
897 | ret = ufs_update_inode (inode, wait); | 899 | ret = ufs_update_inode(inode, wbc->sync_mode == WB_SYNC_ALL); |
898 | unlock_kernel(); | 900 | unlock_kernel(); |
899 | return ret; | 901 | return ret; |
900 | } | 902 | } |
@@ -908,6 +910,9 @@ void ufs_delete_inode (struct inode * inode) | |||
908 | { | 910 | { |
909 | loff_t old_i_size; | 911 | loff_t old_i_size; |
910 | 912 | ||
913 | if (!is_bad_inode(inode)) | ||
914 | dquot_initialize(inode); | ||
915 | |||
911 | truncate_inode_pages(&inode->i_data, 0); | 916 | truncate_inode_pages(&inode->i_data, 0); |
912 | if (is_bad_inode(inode)) | 917 | if (is_bad_inode(inode)) |
913 | goto no_delete; | 918 | goto no_delete; |
diff --git a/fs/ufs/namei.c b/fs/ufs/namei.c index 4c26d9e8bc94..118556243e7a 100644 --- a/fs/ufs/namei.c +++ b/fs/ufs/namei.c | |||
@@ -30,6 +30,7 @@ | |||
30 | #include <linux/time.h> | 30 | #include <linux/time.h> |
31 | #include <linux/fs.h> | 31 | #include <linux/fs.h> |
32 | #include <linux/smp_lock.h> | 32 | #include <linux/smp_lock.h> |
33 | #include <linux/quotaops.h> | ||
33 | 34 | ||
34 | #include "ufs_fs.h" | 35 | #include "ufs_fs.h" |
35 | #include "ufs.h" | 36 | #include "ufs.h" |
@@ -84,6 +85,9 @@ static int ufs_create (struct inode * dir, struct dentry * dentry, int mode, | |||
84 | int err; | 85 | int err; |
85 | 86 | ||
86 | UFSD("BEGIN\n"); | 87 | UFSD("BEGIN\n"); |
88 | |||
89 | dquot_initialize(dir); | ||
90 | |||
87 | inode = ufs_new_inode(dir, mode); | 91 | inode = ufs_new_inode(dir, mode); |
88 | err = PTR_ERR(inode); | 92 | err = PTR_ERR(inode); |
89 | 93 | ||
@@ -107,6 +111,9 @@ static int ufs_mknod (struct inode * dir, struct dentry *dentry, int mode, dev_t | |||
107 | 111 | ||
108 | if (!old_valid_dev(rdev)) | 112 | if (!old_valid_dev(rdev)) |
109 | return -EINVAL; | 113 | return -EINVAL; |
114 | |||
115 | dquot_initialize(dir); | ||
116 | |||
110 | inode = ufs_new_inode(dir, mode); | 117 | inode = ufs_new_inode(dir, mode); |
111 | err = PTR_ERR(inode); | 118 | err = PTR_ERR(inode); |
112 | if (!IS_ERR(inode)) { | 119 | if (!IS_ERR(inode)) { |
@@ -131,6 +138,8 @@ static int ufs_symlink (struct inode * dir, struct dentry * dentry, | |||
131 | if (l > sb->s_blocksize) | 138 | if (l > sb->s_blocksize) |
132 | goto out_notlocked; | 139 | goto out_notlocked; |
133 | 140 | ||
141 | dquot_initialize(dir); | ||
142 | |||
134 | lock_kernel(); | 143 | lock_kernel(); |
135 | inode = ufs_new_inode(dir, S_IFLNK | S_IRWXUGO); | 144 | inode = ufs_new_inode(dir, S_IFLNK | S_IRWXUGO); |
136 | err = PTR_ERR(inode); | 145 | err = PTR_ERR(inode); |
@@ -176,6 +185,8 @@ static int ufs_link (struct dentry * old_dentry, struct inode * dir, | |||
176 | return -EMLINK; | 185 | return -EMLINK; |
177 | } | 186 | } |
178 | 187 | ||
188 | dquot_initialize(dir); | ||
189 | |||
179 | inode->i_ctime = CURRENT_TIME_SEC; | 190 | inode->i_ctime = CURRENT_TIME_SEC; |
180 | inode_inc_link_count(inode); | 191 | inode_inc_link_count(inode); |
181 | atomic_inc(&inode->i_count); | 192 | atomic_inc(&inode->i_count); |
@@ -193,6 +204,8 @@ static int ufs_mkdir(struct inode * dir, struct dentry * dentry, int mode) | |||
193 | if (dir->i_nlink >= UFS_LINK_MAX) | 204 | if (dir->i_nlink >= UFS_LINK_MAX) |
194 | goto out; | 205 | goto out; |
195 | 206 | ||
207 | dquot_initialize(dir); | ||
208 | |||
196 | lock_kernel(); | 209 | lock_kernel(); |
197 | inode_inc_link_count(dir); | 210 | inode_inc_link_count(dir); |
198 | 211 | ||
@@ -237,6 +250,8 @@ static int ufs_unlink(struct inode *dir, struct dentry *dentry) | |||
237 | struct page *page; | 250 | struct page *page; |
238 | int err = -ENOENT; | 251 | int err = -ENOENT; |
239 | 252 | ||
253 | dquot_initialize(dir); | ||
254 | |||
240 | de = ufs_find_entry(dir, &dentry->d_name, &page); | 255 | de = ufs_find_entry(dir, &dentry->d_name, &page); |
241 | if (!de) | 256 | if (!de) |
242 | goto out; | 257 | goto out; |
@@ -281,6 +296,9 @@ static int ufs_rename(struct inode *old_dir, struct dentry *old_dentry, | |||
281 | struct ufs_dir_entry *old_de; | 296 | struct ufs_dir_entry *old_de; |
282 | int err = -ENOENT; | 297 | int err = -ENOENT; |
283 | 298 | ||
299 | dquot_initialize(old_dir); | ||
300 | dquot_initialize(new_dir); | ||
301 | |||
284 | old_de = ufs_find_entry(old_dir, &old_dentry->d_name, &old_page); | 302 | old_de = ufs_find_entry(old_dir, &old_dentry->d_name, &old_page); |
285 | if (!old_de) | 303 | if (!old_de) |
286 | goto out; | 304 | goto out; |
diff --git a/fs/ufs/super.c b/fs/ufs/super.c index 143c20bfb04b..66b63a751615 100644 --- a/fs/ufs/super.c +++ b/fs/ufs/super.c | |||
@@ -1432,6 +1432,11 @@ static void destroy_inodecache(void) | |||
1432 | kmem_cache_destroy(ufs_inode_cachep); | 1432 | kmem_cache_destroy(ufs_inode_cachep); |
1433 | } | 1433 | } |
1434 | 1434 | ||
1435 | static void ufs_clear_inode(struct inode *inode) | ||
1436 | { | ||
1437 | dquot_drop(inode); | ||
1438 | } | ||
1439 | |||
1435 | #ifdef CONFIG_QUOTA | 1440 | #ifdef CONFIG_QUOTA |
1436 | static ssize_t ufs_quota_read(struct super_block *, int, char *,size_t, loff_t); | 1441 | static ssize_t ufs_quota_read(struct super_block *, int, char *,size_t, loff_t); |
1437 | static ssize_t ufs_quota_write(struct super_block *, int, const char *, size_t, loff_t); | 1442 | static ssize_t ufs_quota_write(struct super_block *, int, const char *, size_t, loff_t); |
@@ -1442,6 +1447,7 @@ static const struct super_operations ufs_super_ops = { | |||
1442 | .destroy_inode = ufs_destroy_inode, | 1447 | .destroy_inode = ufs_destroy_inode, |
1443 | .write_inode = ufs_write_inode, | 1448 | .write_inode = ufs_write_inode, |
1444 | .delete_inode = ufs_delete_inode, | 1449 | .delete_inode = ufs_delete_inode, |
1450 | .clear_inode = ufs_clear_inode, | ||
1445 | .put_super = ufs_put_super, | 1451 | .put_super = ufs_put_super, |
1446 | .write_super = ufs_write_super, | 1452 | .write_super = ufs_write_super, |
1447 | .sync_fs = ufs_sync_fs, | 1453 | .sync_fs = ufs_sync_fs, |
diff --git a/fs/ufs/truncate.c b/fs/ufs/truncate.c index 41dd431ce228..d3b6270cb377 100644 --- a/fs/ufs/truncate.c +++ b/fs/ufs/truncate.c | |||
@@ -44,6 +44,7 @@ | |||
44 | #include <linux/buffer_head.h> | 44 | #include <linux/buffer_head.h> |
45 | #include <linux/blkdev.h> | 45 | #include <linux/blkdev.h> |
46 | #include <linux/sched.h> | 46 | #include <linux/sched.h> |
47 | #include <linux/quotaops.h> | ||
47 | 48 | ||
48 | #include "ufs_fs.h" | 49 | #include "ufs_fs.h" |
49 | #include "ufs.h" | 50 | #include "ufs.h" |
@@ -517,9 +518,18 @@ static int ufs_setattr(struct dentry *dentry, struct iattr *attr) | |||
517 | if (error) | 518 | if (error) |
518 | return error; | 519 | return error; |
519 | 520 | ||
521 | if ((ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid) || | ||
522 | (ia_valid & ATTR_GID && attr->ia_gid != inode->i_gid)) { | ||
523 | error = dquot_transfer(inode, attr); | ||
524 | if (error) | ||
525 | return error; | ||
526 | } | ||
520 | if (ia_valid & ATTR_SIZE && | 527 | if (ia_valid & ATTR_SIZE && |
521 | attr->ia_size != i_size_read(inode)) { | 528 | attr->ia_size != i_size_read(inode)) { |
522 | loff_t old_i_size = inode->i_size; | 529 | loff_t old_i_size = inode->i_size; |
530 | |||
531 | dquot_initialize(inode); | ||
532 | |||
523 | error = vmtruncate(inode, attr->ia_size); | 533 | error = vmtruncate(inode, attr->ia_size); |
524 | if (error) | 534 | if (error) |
525 | return error; | 535 | return error; |
diff --git a/fs/ufs/ufs.h b/fs/ufs/ufs.h index 0b4c39bc0d9e..43f9f5d5670e 100644 --- a/fs/ufs/ufs.h +++ b/fs/ufs/ufs.h | |||
@@ -86,9 +86,9 @@ extern void ufs_put_cylinder (struct super_block *, unsigned); | |||
86 | /* dir.c */ | 86 | /* dir.c */ |
87 | extern const struct inode_operations ufs_dir_inode_operations; | 87 | extern const struct inode_operations ufs_dir_inode_operations; |
88 | extern int ufs_add_link (struct dentry *, struct inode *); | 88 | extern int ufs_add_link (struct dentry *, struct inode *); |
89 | extern ino_t ufs_inode_by_name(struct inode *, struct qstr *); | 89 | extern ino_t ufs_inode_by_name(struct inode *, const struct qstr *); |
90 | extern int ufs_make_empty(struct inode *, struct inode *); | 90 | extern int ufs_make_empty(struct inode *, struct inode *); |
91 | extern struct ufs_dir_entry *ufs_find_entry(struct inode *, struct qstr *, struct page **); | 91 | extern struct ufs_dir_entry *ufs_find_entry(struct inode *, const struct qstr *, struct page **); |
92 | extern int ufs_delete_entry(struct inode *, struct ufs_dir_entry *, struct page *); | 92 | extern int ufs_delete_entry(struct inode *, struct ufs_dir_entry *, struct page *); |
93 | extern int ufs_empty_dir (struct inode *); | 93 | extern int ufs_empty_dir (struct inode *); |
94 | extern struct ufs_dir_entry *ufs_dotdot(struct inode *, struct page **); | 94 | extern struct ufs_dir_entry *ufs_dotdot(struct inode *, struct page **); |
@@ -106,7 +106,7 @@ extern struct inode * ufs_new_inode (struct inode *, int); | |||
106 | 106 | ||
107 | /* inode.c */ | 107 | /* inode.c */ |
108 | extern struct inode *ufs_iget(struct super_block *, unsigned long); | 108 | extern struct inode *ufs_iget(struct super_block *, unsigned long); |
109 | extern int ufs_write_inode (struct inode *, int); | 109 | extern int ufs_write_inode (struct inode *, struct writeback_control *); |
110 | extern int ufs_sync_inode (struct inode *); | 110 | extern int ufs_sync_inode (struct inode *); |
111 | extern void ufs_delete_inode (struct inode *); | 111 | extern void ufs_delete_inode (struct inode *); |
112 | extern struct buffer_head * ufs_bread (struct inode *, unsigned, int, int *); | 112 | extern struct buffer_head * ufs_bread (struct inode *, unsigned, int, int *); |
diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile index 5c5a366aa332..b4769e40e8bc 100644 --- a/fs/xfs/Makefile +++ b/fs/xfs/Makefile | |||
@@ -105,7 +105,6 @@ xfs-y += $(addprefix $(XFS_LINUX)/, \ | |||
105 | xfs_globals.o \ | 105 | xfs_globals.o \ |
106 | xfs_ioctl.o \ | 106 | xfs_ioctl.o \ |
107 | xfs_iops.o \ | 107 | xfs_iops.o \ |
108 | xfs_lrw.o \ | ||
109 | xfs_super.o \ | 108 | xfs_super.o \ |
110 | xfs_sync.o \ | 109 | xfs_sync.o \ |
111 | xfs_xattr.o) | 110 | xfs_xattr.o) |
diff --git a/fs/xfs/linux-2.6/xfs_aops.c b/fs/xfs/linux-2.6/xfs_aops.c index 66abe36c1213..9083357f9e44 100644 --- a/fs/xfs/linux-2.6/xfs_aops.c +++ b/fs/xfs/linux-2.6/xfs_aops.c | |||
@@ -39,6 +39,7 @@ | |||
39 | #include "xfs_iomap.h" | 39 | #include "xfs_iomap.h" |
40 | #include "xfs_vnodeops.h" | 40 | #include "xfs_vnodeops.h" |
41 | #include "xfs_trace.h" | 41 | #include "xfs_trace.h" |
42 | #include "xfs_bmap.h" | ||
42 | #include <linux/mpage.h> | 43 | #include <linux/mpage.h> |
43 | #include <linux/pagevec.h> | 44 | #include <linux/pagevec.h> |
44 | #include <linux/writeback.h> | 45 | #include <linux/writeback.h> |
@@ -163,14 +164,17 @@ xfs_ioend_new_eof( | |||
163 | } | 164 | } |
164 | 165 | ||
165 | /* | 166 | /* |
166 | * Update on-disk file size now that data has been written to disk. | 167 | * Update on-disk file size now that data has been written to disk. The |
167 | * The current in-memory file size is i_size. If a write is beyond | 168 | * current in-memory file size is i_size. If a write is beyond eof i_new_size |
168 | * eof i_new_size will be the intended file size until i_size is | 169 | * will be the intended file size until i_size is updated. If this write does |
169 | * updated. If this write does not extend all the way to the valid | 170 | * not extend all the way to the valid file size then restrict this update to |
170 | * file size then restrict this update to the end of the write. | 171 | * the end of the write. |
172 | * | ||
173 | * This function does not block as blocking on the inode lock in IO completion | ||
174 | * can lead to IO completion order dependency deadlocks.. If it can't get the | ||
175 | * inode ilock it will return EAGAIN. Callers must handle this. | ||
171 | */ | 176 | */ |
172 | 177 | STATIC int | |
173 | STATIC void | ||
174 | xfs_setfilesize( | 178 | xfs_setfilesize( |
175 | xfs_ioend_t *ioend) | 179 | xfs_ioend_t *ioend) |
176 | { | 180 | { |
@@ -181,16 +185,40 @@ xfs_setfilesize( | |||
181 | ASSERT(ioend->io_type != IOMAP_READ); | 185 | ASSERT(ioend->io_type != IOMAP_READ); |
182 | 186 | ||
183 | if (unlikely(ioend->io_error)) | 187 | if (unlikely(ioend->io_error)) |
184 | return; | 188 | return 0; |
189 | |||
190 | if (!xfs_ilock_nowait(ip, XFS_ILOCK_EXCL)) | ||
191 | return EAGAIN; | ||
185 | 192 | ||
186 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
187 | isize = xfs_ioend_new_eof(ioend); | 193 | isize = xfs_ioend_new_eof(ioend); |
188 | if (isize) { | 194 | if (isize) { |
189 | ip->i_d.di_size = isize; | 195 | ip->i_d.di_size = isize; |
190 | xfs_mark_inode_dirty_sync(ip); | 196 | xfs_mark_inode_dirty(ip); |
191 | } | 197 | } |
192 | 198 | ||
193 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | 199 | xfs_iunlock(ip, XFS_ILOCK_EXCL); |
200 | return 0; | ||
201 | } | ||
202 | |||
203 | /* | ||
204 | * Schedule IO completion handling on a xfsdatad if this was | ||
205 | * the final hold on this ioend. If we are asked to wait, | ||
206 | * flush the workqueue. | ||
207 | */ | ||
208 | STATIC void | ||
209 | xfs_finish_ioend( | ||
210 | xfs_ioend_t *ioend, | ||
211 | int wait) | ||
212 | { | ||
213 | if (atomic_dec_and_test(&ioend->io_remaining)) { | ||
214 | struct workqueue_struct *wq; | ||
215 | |||
216 | wq = (ioend->io_type == IOMAP_UNWRITTEN) ? | ||
217 | xfsconvertd_workqueue : xfsdatad_workqueue; | ||
218 | queue_work(wq, &ioend->io_work); | ||
219 | if (wait) | ||
220 | flush_workqueue(wq); | ||
221 | } | ||
194 | } | 222 | } |
195 | 223 | ||
196 | /* | 224 | /* |
@@ -198,11 +226,11 @@ xfs_setfilesize( | |||
198 | */ | 226 | */ |
199 | STATIC void | 227 | STATIC void |
200 | xfs_end_io( | 228 | xfs_end_io( |
201 | struct work_struct *work) | 229 | struct work_struct *work) |
202 | { | 230 | { |
203 | xfs_ioend_t *ioend = | 231 | xfs_ioend_t *ioend = container_of(work, xfs_ioend_t, io_work); |
204 | container_of(work, xfs_ioend_t, io_work); | 232 | struct xfs_inode *ip = XFS_I(ioend->io_inode); |
205 | struct xfs_inode *ip = XFS_I(ioend->io_inode); | 233 | int error = 0; |
206 | 234 | ||
207 | /* | 235 | /* |
208 | * For unwritten extents we need to issue transactions to convert a | 236 | * For unwritten extents we need to issue transactions to convert a |
@@ -210,7 +238,6 @@ xfs_end_io( | |||
210 | */ | 238 | */ |
211 | if (ioend->io_type == IOMAP_UNWRITTEN && | 239 | if (ioend->io_type == IOMAP_UNWRITTEN && |
212 | likely(!ioend->io_error && !XFS_FORCED_SHUTDOWN(ip->i_mount))) { | 240 | likely(!ioend->io_error && !XFS_FORCED_SHUTDOWN(ip->i_mount))) { |
213 | int error; | ||
214 | 241 | ||
215 | error = xfs_iomap_write_unwritten(ip, ioend->io_offset, | 242 | error = xfs_iomap_write_unwritten(ip, ioend->io_offset, |
216 | ioend->io_size); | 243 | ioend->io_size); |
@@ -222,30 +249,23 @@ xfs_end_io( | |||
222 | * We might have to update the on-disk file size after extending | 249 | * We might have to update the on-disk file size after extending |
223 | * writes. | 250 | * writes. |
224 | */ | 251 | */ |
225 | if (ioend->io_type != IOMAP_READ) | 252 | if (ioend->io_type != IOMAP_READ) { |
226 | xfs_setfilesize(ioend); | 253 | error = xfs_setfilesize(ioend); |
227 | xfs_destroy_ioend(ioend); | 254 | ASSERT(!error || error == EAGAIN); |
228 | } | ||
229 | |||
230 | /* | ||
231 | * Schedule IO completion handling on a xfsdatad if this was | ||
232 | * the final hold on this ioend. If we are asked to wait, | ||
233 | * flush the workqueue. | ||
234 | */ | ||
235 | STATIC void | ||
236 | xfs_finish_ioend( | ||
237 | xfs_ioend_t *ioend, | ||
238 | int wait) | ||
239 | { | ||
240 | if (atomic_dec_and_test(&ioend->io_remaining)) { | ||
241 | struct workqueue_struct *wq; | ||
242 | |||
243 | wq = (ioend->io_type == IOMAP_UNWRITTEN) ? | ||
244 | xfsconvertd_workqueue : xfsdatad_workqueue; | ||
245 | queue_work(wq, &ioend->io_work); | ||
246 | if (wait) | ||
247 | flush_workqueue(wq); | ||
248 | } | 255 | } |
256 | |||
257 | /* | ||
258 | * If we didn't complete processing of the ioend, requeue it to the | ||
259 | * tail of the workqueue for another attempt later. Otherwise destroy | ||
260 | * it. | ||
261 | */ | ||
262 | if (error == EAGAIN) { | ||
263 | atomic_inc(&ioend->io_remaining); | ||
264 | xfs_finish_ioend(ioend, 0); | ||
265 | /* ensure we don't spin on blocked ioends */ | ||
266 | delay(1); | ||
267 | } else | ||
268 | xfs_destroy_ioend(ioend); | ||
249 | } | 269 | } |
250 | 270 | ||
251 | /* | 271 | /* |
@@ -341,7 +361,7 @@ xfs_submit_ioend_bio( | |||
341 | * but don't update the inode size until I/O completion. | 361 | * but don't update the inode size until I/O completion. |
342 | */ | 362 | */ |
343 | if (xfs_ioend_new_eof(ioend)) | 363 | if (xfs_ioend_new_eof(ioend)) |
344 | xfs_mark_inode_dirty_sync(XFS_I(ioend->io_inode)); | 364 | xfs_mark_inode_dirty(XFS_I(ioend->io_inode)); |
345 | 365 | ||
346 | submit_bio(wbc->sync_mode == WB_SYNC_ALL ? | 366 | submit_bio(wbc->sync_mode == WB_SYNC_ALL ? |
347 | WRITE_SYNC_PLUG : WRITE, bio); | 367 | WRITE_SYNC_PLUG : WRITE, bio); |
@@ -874,6 +894,118 @@ xfs_cluster_write( | |||
874 | } | 894 | } |
875 | } | 895 | } |
876 | 896 | ||
897 | STATIC void | ||
898 | xfs_vm_invalidatepage( | ||
899 | struct page *page, | ||
900 | unsigned long offset) | ||
901 | { | ||
902 | trace_xfs_invalidatepage(page->mapping->host, page, offset); | ||
903 | block_invalidatepage(page, offset); | ||
904 | } | ||
905 | |||
906 | /* | ||
907 | * If the page has delalloc buffers on it, we need to punch them out before we | ||
908 | * invalidate the page. If we don't, we leave a stale delalloc mapping on the | ||
909 | * inode that can trip a BUG() in xfs_get_blocks() later on if a direct IO read | ||
910 | * is done on that same region - the delalloc extent is returned when none is | ||
911 | * supposed to be there. | ||
912 | * | ||
913 | * We prevent this by truncating away the delalloc regions on the page before | ||
914 | * invalidating it. Because they are delalloc, we can do this without needing a | ||
915 | * transaction. Indeed - if we get ENOSPC errors, we have to be able to do this | ||
916 | * truncation without a transaction as there is no space left for block | ||
917 | * reservation (typically why we see a ENOSPC in writeback). | ||
918 | * | ||
919 | * This is not a performance critical path, so for now just do the punching a | ||
920 | * buffer head at a time. | ||
921 | */ | ||
922 | STATIC void | ||
923 | xfs_aops_discard_page( | ||
924 | struct page *page) | ||
925 | { | ||
926 | struct inode *inode = page->mapping->host; | ||
927 | struct xfs_inode *ip = XFS_I(inode); | ||
928 | struct buffer_head *bh, *head; | ||
929 | loff_t offset = page_offset(page); | ||
930 | ssize_t len = 1 << inode->i_blkbits; | ||
931 | |||
932 | if (!xfs_is_delayed_page(page, IOMAP_DELAY)) | ||
933 | goto out_invalidate; | ||
934 | |||
935 | xfs_fs_cmn_err(CE_ALERT, ip->i_mount, | ||
936 | "page discard on page %p, inode 0x%llx, offset %llu.", | ||
937 | page, ip->i_ino, offset); | ||
938 | |||
939 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
940 | bh = head = page_buffers(page); | ||
941 | do { | ||
942 | int done; | ||
943 | xfs_fileoff_t offset_fsb; | ||
944 | xfs_bmbt_irec_t imap; | ||
945 | int nimaps = 1; | ||
946 | int error; | ||
947 | xfs_fsblock_t firstblock; | ||
948 | xfs_bmap_free_t flist; | ||
949 | |||
950 | if (!buffer_delay(bh)) | ||
951 | goto next_buffer; | ||
952 | |||
953 | offset_fsb = XFS_B_TO_FSBT(ip->i_mount, offset); | ||
954 | |||
955 | /* | ||
956 | * Map the range first and check that it is a delalloc extent | ||
957 | * before trying to unmap the range. Otherwise we will be | ||
958 | * trying to remove a real extent (which requires a | ||
959 | * transaction) or a hole, which is probably a bad idea... | ||
960 | */ | ||
961 | error = xfs_bmapi(NULL, ip, offset_fsb, 1, | ||
962 | XFS_BMAPI_ENTIRE, NULL, 0, &imap, | ||
963 | &nimaps, NULL, NULL); | ||
964 | |||
965 | if (error) { | ||
966 | /* something screwed, just bail */ | ||
967 | xfs_fs_cmn_err(CE_ALERT, ip->i_mount, | ||
968 | "page discard failed delalloc mapping lookup."); | ||
969 | break; | ||
970 | } | ||
971 | if (!nimaps) { | ||
972 | /* nothing there */ | ||
973 | goto next_buffer; | ||
974 | } | ||
975 | if (imap.br_startblock != DELAYSTARTBLOCK) { | ||
976 | /* been converted, ignore */ | ||
977 | goto next_buffer; | ||
978 | } | ||
979 | WARN_ON(imap.br_blockcount == 0); | ||
980 | |||
981 | /* | ||
982 | * Note: while we initialise the firstblock/flist pair, they | ||
983 | * should never be used because blocks should never be | ||
984 | * allocated or freed for a delalloc extent and hence we need | ||
985 | * don't cancel or finish them after the xfs_bunmapi() call. | ||
986 | */ | ||
987 | xfs_bmap_init(&flist, &firstblock); | ||
988 | error = xfs_bunmapi(NULL, ip, offset_fsb, 1, 0, 1, &firstblock, | ||
989 | &flist, NULL, &done); | ||
990 | |||
991 | ASSERT(!flist.xbf_count && !flist.xbf_first); | ||
992 | if (error) { | ||
993 | /* something screwed, just bail */ | ||
994 | xfs_fs_cmn_err(CE_ALERT, ip->i_mount, | ||
995 | "page discard unable to remove delalloc mapping."); | ||
996 | break; | ||
997 | } | ||
998 | next_buffer: | ||
999 | offset += len; | ||
1000 | |||
1001 | } while ((bh = bh->b_this_page) != head); | ||
1002 | |||
1003 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
1004 | out_invalidate: | ||
1005 | xfs_vm_invalidatepage(page, 0); | ||
1006 | return; | ||
1007 | } | ||
1008 | |||
877 | /* | 1009 | /* |
878 | * Calling this without startio set means we are being asked to make a dirty | 1010 | * Calling this without startio set means we are being asked to make a dirty |
879 | * page ready for freeing it's buffers. When called with startio set then | 1011 | * page ready for freeing it's buffers. When called with startio set then |
@@ -1125,7 +1257,7 @@ error: | |||
1125 | */ | 1257 | */ |
1126 | if (err != -EAGAIN) { | 1258 | if (err != -EAGAIN) { |
1127 | if (!unmapped) | 1259 | if (!unmapped) |
1128 | block_invalidatepage(page, 0); | 1260 | xfs_aops_discard_page(page); |
1129 | ClearPageUptodate(page); | 1261 | ClearPageUptodate(page); |
1130 | } | 1262 | } |
1131 | return err; | 1263 | return err; |
@@ -1535,15 +1667,6 @@ xfs_vm_readpages( | |||
1535 | return mpage_readpages(mapping, pages, nr_pages, xfs_get_blocks); | 1667 | return mpage_readpages(mapping, pages, nr_pages, xfs_get_blocks); |
1536 | } | 1668 | } |
1537 | 1669 | ||
1538 | STATIC void | ||
1539 | xfs_vm_invalidatepage( | ||
1540 | struct page *page, | ||
1541 | unsigned long offset) | ||
1542 | { | ||
1543 | trace_xfs_invalidatepage(page->mapping->host, page, offset); | ||
1544 | block_invalidatepage(page, offset); | ||
1545 | } | ||
1546 | |||
1547 | const struct address_space_operations xfs_address_space_operations = { | 1670 | const struct address_space_operations xfs_address_space_operations = { |
1548 | .readpage = xfs_vm_readpage, | 1671 | .readpage = xfs_vm_readpage, |
1549 | .readpages = xfs_vm_readpages, | 1672 | .readpages = xfs_vm_readpages, |
diff --git a/fs/xfs/linux-2.6/xfs_buf.c b/fs/xfs/linux-2.6/xfs_buf.c index d50df3a8101c..6f76ba85f193 100644 --- a/fs/xfs/linux-2.6/xfs_buf.c +++ b/fs/xfs/linux-2.6/xfs_buf.c | |||
@@ -77,6 +77,27 @@ struct workqueue_struct *xfsconvertd_workqueue; | |||
77 | #define xfs_buf_deallocate(bp) \ | 77 | #define xfs_buf_deallocate(bp) \ |
78 | kmem_zone_free(xfs_buf_zone, (bp)); | 78 | kmem_zone_free(xfs_buf_zone, (bp)); |
79 | 79 | ||
80 | static inline int | ||
81 | xfs_buf_is_vmapped( | ||
82 | struct xfs_buf *bp) | ||
83 | { | ||
84 | /* | ||
85 | * Return true if the buffer is vmapped. | ||
86 | * | ||
87 | * The XBF_MAPPED flag is set if the buffer should be mapped, but the | ||
88 | * code is clever enough to know it doesn't have to map a single page, | ||
89 | * so the check has to be both for XBF_MAPPED and bp->b_page_count > 1. | ||
90 | */ | ||
91 | return (bp->b_flags & XBF_MAPPED) && bp->b_page_count > 1; | ||
92 | } | ||
93 | |||
94 | static inline int | ||
95 | xfs_buf_vmap_len( | ||
96 | struct xfs_buf *bp) | ||
97 | { | ||
98 | return (bp->b_page_count * PAGE_SIZE) - bp->b_offset; | ||
99 | } | ||
100 | |||
80 | /* | 101 | /* |
81 | * Page Region interfaces. | 102 | * Page Region interfaces. |
82 | * | 103 | * |
@@ -315,7 +336,7 @@ xfs_buf_free( | |||
315 | if (bp->b_flags & (_XBF_PAGE_CACHE|_XBF_PAGES)) { | 336 | if (bp->b_flags & (_XBF_PAGE_CACHE|_XBF_PAGES)) { |
316 | uint i; | 337 | uint i; |
317 | 338 | ||
318 | if ((bp->b_flags & XBF_MAPPED) && (bp->b_page_count > 1)) | 339 | if (xfs_buf_is_vmapped(bp)) |
319 | free_address(bp->b_addr - bp->b_offset); | 340 | free_address(bp->b_addr - bp->b_offset); |
320 | 341 | ||
321 | for (i = 0; i < bp->b_page_count; i++) { | 342 | for (i = 0; i < bp->b_page_count; i++) { |
@@ -1236,6 +1257,9 @@ xfs_buf_bio_end_io( | |||
1236 | 1257 | ||
1237 | xfs_buf_ioerror(bp, -error); | 1258 | xfs_buf_ioerror(bp, -error); |
1238 | 1259 | ||
1260 | if (!error && xfs_buf_is_vmapped(bp) && (bp->b_flags & XBF_READ)) | ||
1261 | invalidate_kernel_vmap_range(bp->b_addr, xfs_buf_vmap_len(bp)); | ||
1262 | |||
1239 | do { | 1263 | do { |
1240 | struct page *page = bvec->bv_page; | 1264 | struct page *page = bvec->bv_page; |
1241 | 1265 | ||
@@ -1345,6 +1369,10 @@ next_chunk: | |||
1345 | 1369 | ||
1346 | submit_io: | 1370 | submit_io: |
1347 | if (likely(bio->bi_size)) { | 1371 | if (likely(bio->bi_size)) { |
1372 | if (xfs_buf_is_vmapped(bp)) { | ||
1373 | flush_kernel_vmap_range(bp->b_addr, | ||
1374 | xfs_buf_vmap_len(bp)); | ||
1375 | } | ||
1348 | submit_bio(rw, bio); | 1376 | submit_bio(rw, bio); |
1349 | if (size) | 1377 | if (size) |
1350 | goto next_chunk; | 1378 | goto next_chunk; |
diff --git a/fs/xfs/linux-2.6/xfs_file.c b/fs/xfs/linux-2.6/xfs_file.c index e4caeb28ce2e..42dd3bcfba6b 100644 --- a/fs/xfs/linux-2.6/xfs_file.c +++ b/fs/xfs/linux-2.6/xfs_file.c | |||
@@ -16,6 +16,7 @@ | |||
16 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | 16 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA |
17 | */ | 17 | */ |
18 | #include "xfs.h" | 18 | #include "xfs.h" |
19 | #include "xfs_fs.h" | ||
19 | #include "xfs_bit.h" | 20 | #include "xfs_bit.h" |
20 | #include "xfs_log.h" | 21 | #include "xfs_log.h" |
21 | #include "xfs_inum.h" | 22 | #include "xfs_inum.h" |
@@ -34,52 +35,279 @@ | |||
34 | #include "xfs_dir2_sf.h" | 35 | #include "xfs_dir2_sf.h" |
35 | #include "xfs_dinode.h" | 36 | #include "xfs_dinode.h" |
36 | #include "xfs_inode.h" | 37 | #include "xfs_inode.h" |
38 | #include "xfs_inode_item.h" | ||
39 | #include "xfs_bmap.h" | ||
37 | #include "xfs_error.h" | 40 | #include "xfs_error.h" |
38 | #include "xfs_rw.h" | 41 | #include "xfs_rw.h" |
39 | #include "xfs_vnodeops.h" | 42 | #include "xfs_vnodeops.h" |
40 | #include "xfs_da_btree.h" | 43 | #include "xfs_da_btree.h" |
41 | #include "xfs_ioctl.h" | 44 | #include "xfs_ioctl.h" |
45 | #include "xfs_trace.h" | ||
42 | 46 | ||
43 | #include <linux/dcache.h> | 47 | #include <linux/dcache.h> |
44 | 48 | ||
45 | static const struct vm_operations_struct xfs_file_vm_ops; | 49 | static const struct vm_operations_struct xfs_file_vm_ops; |
46 | 50 | ||
47 | STATIC ssize_t | 51 | /* |
48 | xfs_file_aio_read( | 52 | * xfs_iozero |
49 | struct kiocb *iocb, | 53 | * |
50 | const struct iovec *iov, | 54 | * xfs_iozero clears the specified range of buffer supplied, |
51 | unsigned long nr_segs, | 55 | * and marks all the affected blocks as valid and modified. If |
52 | loff_t pos) | 56 | * an affected block is not allocated, it will be allocated. If |
57 | * an affected block is not completely overwritten, and is not | ||
58 | * valid before the operation, it will be read from disk before | ||
59 | * being partially zeroed. | ||
60 | */ | ||
61 | STATIC int | ||
62 | xfs_iozero( | ||
63 | struct xfs_inode *ip, /* inode */ | ||
64 | loff_t pos, /* offset in file */ | ||
65 | size_t count) /* size of data to zero */ | ||
53 | { | 66 | { |
54 | struct file *file = iocb->ki_filp; | 67 | struct page *page; |
55 | int ioflags = 0; | 68 | struct address_space *mapping; |
69 | int status; | ||
56 | 70 | ||
57 | BUG_ON(iocb->ki_pos != pos); | 71 | mapping = VFS_I(ip)->i_mapping; |
58 | if (unlikely(file->f_flags & O_DIRECT)) | 72 | do { |
59 | ioflags |= IO_ISDIRECT; | 73 | unsigned offset, bytes; |
60 | if (file->f_mode & FMODE_NOCMTIME) | 74 | void *fsdata; |
61 | ioflags |= IO_INVIS; | 75 | |
62 | return xfs_read(XFS_I(file->f_path.dentry->d_inode), iocb, iov, | 76 | offset = (pos & (PAGE_CACHE_SIZE -1)); /* Within page */ |
63 | nr_segs, &iocb->ki_pos, ioflags); | 77 | bytes = PAGE_CACHE_SIZE - offset; |
78 | if (bytes > count) | ||
79 | bytes = count; | ||
80 | |||
81 | status = pagecache_write_begin(NULL, mapping, pos, bytes, | ||
82 | AOP_FLAG_UNINTERRUPTIBLE, | ||
83 | &page, &fsdata); | ||
84 | if (status) | ||
85 | break; | ||
86 | |||
87 | zero_user(page, offset, bytes); | ||
88 | |||
89 | status = pagecache_write_end(NULL, mapping, pos, bytes, bytes, | ||
90 | page, fsdata); | ||
91 | WARN_ON(status <= 0); /* can't return less than zero! */ | ||
92 | pos += bytes; | ||
93 | count -= bytes; | ||
94 | status = 0; | ||
95 | } while (count); | ||
96 | |||
97 | return (-status); | ||
98 | } | ||
99 | |||
100 | STATIC int | ||
101 | xfs_file_fsync( | ||
102 | struct file *file, | ||
103 | struct dentry *dentry, | ||
104 | int datasync) | ||
105 | { | ||
106 | struct xfs_inode *ip = XFS_I(dentry->d_inode); | ||
107 | struct xfs_trans *tp; | ||
108 | int error = 0; | ||
109 | int log_flushed = 0; | ||
110 | |||
111 | xfs_itrace_entry(ip); | ||
112 | |||
113 | if (XFS_FORCED_SHUTDOWN(ip->i_mount)) | ||
114 | return -XFS_ERROR(EIO); | ||
115 | |||
116 | xfs_iflags_clear(ip, XFS_ITRUNCATED); | ||
117 | |||
118 | /* | ||
119 | * We always need to make sure that the required inode state is safe on | ||
120 | * disk. The inode might be clean but we still might need to force the | ||
121 | * log because of committed transactions that haven't hit the disk yet. | ||
122 | * Likewise, there could be unflushed non-transactional changes to the | ||
123 | * inode core that have to go to disk and this requires us to issue | ||
124 | * a synchronous transaction to capture these changes correctly. | ||
125 | * | ||
126 | * This code relies on the assumption that if the i_update_core field | ||
127 | * of the inode is clear and the inode is unpinned then it is clean | ||
128 | * and no action is required. | ||
129 | */ | ||
130 | xfs_ilock(ip, XFS_ILOCK_SHARED); | ||
131 | |||
132 | /* | ||
133 | * First check if the VFS inode is marked dirty. All the dirtying | ||
134 | * of non-transactional updates no goes through mark_inode_dirty*, | ||
135 | * which allows us to distinguish beteeen pure timestamp updates | ||
136 | * and i_size updates which need to be caught for fdatasync. | ||
137 | * After that also theck for the dirty state in the XFS inode, which | ||
138 | * might gets cleared when the inode gets written out via the AIL | ||
139 | * or xfs_iflush_cluster. | ||
140 | */ | ||
141 | if (((dentry->d_inode->i_state & I_DIRTY_DATASYNC) || | ||
142 | ((dentry->d_inode->i_state & I_DIRTY_SYNC) && !datasync)) && | ||
143 | ip->i_update_core) { | ||
144 | /* | ||
145 | * Kick off a transaction to log the inode core to get the | ||
146 | * updates. The sync transaction will also force the log. | ||
147 | */ | ||
148 | xfs_iunlock(ip, XFS_ILOCK_SHARED); | ||
149 | tp = xfs_trans_alloc(ip->i_mount, XFS_TRANS_FSYNC_TS); | ||
150 | error = xfs_trans_reserve(tp, 0, | ||
151 | XFS_FSYNC_TS_LOG_RES(ip->i_mount), 0, 0, 0); | ||
152 | if (error) { | ||
153 | xfs_trans_cancel(tp, 0); | ||
154 | return -error; | ||
155 | } | ||
156 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
157 | |||
158 | /* | ||
159 | * Note - it's possible that we might have pushed ourselves out | ||
160 | * of the way during trans_reserve which would flush the inode. | ||
161 | * But there's no guarantee that the inode buffer has actually | ||
162 | * gone out yet (it's delwri). Plus the buffer could be pinned | ||
163 | * anyway if it's part of an inode in another recent | ||
164 | * transaction. So we play it safe and fire off the | ||
165 | * transaction anyway. | ||
166 | */ | ||
167 | xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL); | ||
168 | xfs_trans_ihold(tp, ip); | ||
169 | xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE); | ||
170 | xfs_trans_set_sync(tp); | ||
171 | error = _xfs_trans_commit(tp, 0, &log_flushed); | ||
172 | |||
173 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
174 | } else { | ||
175 | /* | ||
176 | * Timestamps/size haven't changed since last inode flush or | ||
177 | * inode transaction commit. That means either nothing got | ||
178 | * written or a transaction committed which caught the updates. | ||
179 | * If the latter happened and the transaction hasn't hit the | ||
180 | * disk yet, the inode will be still be pinned. If it is, | ||
181 | * force the log. | ||
182 | */ | ||
183 | if (xfs_ipincount(ip)) { | ||
184 | error = _xfs_log_force_lsn(ip->i_mount, | ||
185 | ip->i_itemp->ili_last_lsn, | ||
186 | XFS_LOG_SYNC, &log_flushed); | ||
187 | } | ||
188 | xfs_iunlock(ip, XFS_ILOCK_SHARED); | ||
189 | } | ||
190 | |||
191 | if (ip->i_mount->m_flags & XFS_MOUNT_BARRIER) { | ||
192 | /* | ||
193 | * If the log write didn't issue an ordered tag we need | ||
194 | * to flush the disk cache for the data device now. | ||
195 | */ | ||
196 | if (!log_flushed) | ||
197 | xfs_blkdev_issue_flush(ip->i_mount->m_ddev_targp); | ||
198 | |||
199 | /* | ||
200 | * If this inode is on the RT dev we need to flush that | ||
201 | * cache as well. | ||
202 | */ | ||
203 | if (XFS_IS_REALTIME_INODE(ip)) | ||
204 | xfs_blkdev_issue_flush(ip->i_mount->m_rtdev_targp); | ||
205 | } | ||
206 | |||
207 | return -error; | ||
64 | } | 208 | } |
65 | 209 | ||
66 | STATIC ssize_t | 210 | STATIC ssize_t |
67 | xfs_file_aio_write( | 211 | xfs_file_aio_read( |
68 | struct kiocb *iocb, | 212 | struct kiocb *iocb, |
69 | const struct iovec *iov, | 213 | const struct iovec *iovp, |
70 | unsigned long nr_segs, | 214 | unsigned long nr_segs, |
71 | loff_t pos) | 215 | loff_t pos) |
72 | { | 216 | { |
73 | struct file *file = iocb->ki_filp; | 217 | struct file *file = iocb->ki_filp; |
218 | struct inode *inode = file->f_mapping->host; | ||
219 | struct xfs_inode *ip = XFS_I(inode); | ||
220 | struct xfs_mount *mp = ip->i_mount; | ||
221 | size_t size = 0; | ||
222 | ssize_t ret = 0; | ||
74 | int ioflags = 0; | 223 | int ioflags = 0; |
224 | xfs_fsize_t n; | ||
225 | unsigned long seg; | ||
226 | |||
227 | XFS_STATS_INC(xs_read_calls); | ||
75 | 228 | ||
76 | BUG_ON(iocb->ki_pos != pos); | 229 | BUG_ON(iocb->ki_pos != pos); |
230 | |||
77 | if (unlikely(file->f_flags & O_DIRECT)) | 231 | if (unlikely(file->f_flags & O_DIRECT)) |
78 | ioflags |= IO_ISDIRECT; | 232 | ioflags |= IO_ISDIRECT; |
79 | if (file->f_mode & FMODE_NOCMTIME) | 233 | if (file->f_mode & FMODE_NOCMTIME) |
80 | ioflags |= IO_INVIS; | 234 | ioflags |= IO_INVIS; |
81 | return xfs_write(XFS_I(file->f_mapping->host), iocb, iov, nr_segs, | 235 | |
82 | &iocb->ki_pos, ioflags); | 236 | /* START copy & waste from filemap.c */ |
237 | for (seg = 0; seg < nr_segs; seg++) { | ||
238 | const struct iovec *iv = &iovp[seg]; | ||
239 | |||
240 | /* | ||
241 | * If any segment has a negative length, or the cumulative | ||
242 | * length ever wraps negative then return -EINVAL. | ||
243 | */ | ||
244 | size += iv->iov_len; | ||
245 | if (unlikely((ssize_t)(size|iv->iov_len) < 0)) | ||
246 | return XFS_ERROR(-EINVAL); | ||
247 | } | ||
248 | /* END copy & waste from filemap.c */ | ||
249 | |||
250 | if (unlikely(ioflags & IO_ISDIRECT)) { | ||
251 | xfs_buftarg_t *target = | ||
252 | XFS_IS_REALTIME_INODE(ip) ? | ||
253 | mp->m_rtdev_targp : mp->m_ddev_targp; | ||
254 | if ((iocb->ki_pos & target->bt_smask) || | ||
255 | (size & target->bt_smask)) { | ||
256 | if (iocb->ki_pos == ip->i_size) | ||
257 | return 0; | ||
258 | return -XFS_ERROR(EINVAL); | ||
259 | } | ||
260 | } | ||
261 | |||
262 | n = XFS_MAXIOFFSET(mp) - iocb->ki_pos; | ||
263 | if (n <= 0 || size == 0) | ||
264 | return 0; | ||
265 | |||
266 | if (n < size) | ||
267 | size = n; | ||
268 | |||
269 | if (XFS_FORCED_SHUTDOWN(mp)) | ||
270 | return -EIO; | ||
271 | |||
272 | if (unlikely(ioflags & IO_ISDIRECT)) | ||
273 | mutex_lock(&inode->i_mutex); | ||
274 | xfs_ilock(ip, XFS_IOLOCK_SHARED); | ||
275 | |||
276 | if (DM_EVENT_ENABLED(ip, DM_EVENT_READ) && !(ioflags & IO_INVIS)) { | ||
277 | int dmflags = FILP_DELAY_FLAG(file) | DM_SEM_FLAG_RD(ioflags); | ||
278 | int iolock = XFS_IOLOCK_SHARED; | ||
279 | |||
280 | ret = -XFS_SEND_DATA(mp, DM_EVENT_READ, ip, iocb->ki_pos, size, | ||
281 | dmflags, &iolock); | ||
282 | if (ret) { | ||
283 | xfs_iunlock(ip, XFS_IOLOCK_SHARED); | ||
284 | if (unlikely(ioflags & IO_ISDIRECT)) | ||
285 | mutex_unlock(&inode->i_mutex); | ||
286 | return ret; | ||
287 | } | ||
288 | } | ||
289 | |||
290 | if (unlikely(ioflags & IO_ISDIRECT)) { | ||
291 | if (inode->i_mapping->nrpages) { | ||
292 | ret = -xfs_flushinval_pages(ip, | ||
293 | (iocb->ki_pos & PAGE_CACHE_MASK), | ||
294 | -1, FI_REMAPF_LOCKED); | ||
295 | } | ||
296 | mutex_unlock(&inode->i_mutex); | ||
297 | if (ret) { | ||
298 | xfs_iunlock(ip, XFS_IOLOCK_SHARED); | ||
299 | return ret; | ||
300 | } | ||
301 | } | ||
302 | |||
303 | trace_xfs_file_read(ip, size, iocb->ki_pos, ioflags); | ||
304 | |||
305 | ret = generic_file_aio_read(iocb, iovp, nr_segs, iocb->ki_pos); | ||
306 | if (ret > 0) | ||
307 | XFS_STATS_ADD(xs_read_bytes, ret); | ||
308 | |||
309 | xfs_iunlock(ip, XFS_IOLOCK_SHARED); | ||
310 | return ret; | ||
83 | } | 311 | } |
84 | 312 | ||
85 | STATIC ssize_t | 313 | STATIC ssize_t |
@@ -87,16 +315,44 @@ xfs_file_splice_read( | |||
87 | struct file *infilp, | 315 | struct file *infilp, |
88 | loff_t *ppos, | 316 | loff_t *ppos, |
89 | struct pipe_inode_info *pipe, | 317 | struct pipe_inode_info *pipe, |
90 | size_t len, | 318 | size_t count, |
91 | unsigned int flags) | 319 | unsigned int flags) |
92 | { | 320 | { |
321 | struct xfs_inode *ip = XFS_I(infilp->f_mapping->host); | ||
322 | struct xfs_mount *mp = ip->i_mount; | ||
93 | int ioflags = 0; | 323 | int ioflags = 0; |
324 | ssize_t ret; | ||
325 | |||
326 | XFS_STATS_INC(xs_read_calls); | ||
94 | 327 | ||
95 | if (infilp->f_mode & FMODE_NOCMTIME) | 328 | if (infilp->f_mode & FMODE_NOCMTIME) |
96 | ioflags |= IO_INVIS; | 329 | ioflags |= IO_INVIS; |
97 | 330 | ||
98 | return xfs_splice_read(XFS_I(infilp->f_path.dentry->d_inode), | 331 | if (XFS_FORCED_SHUTDOWN(ip->i_mount)) |
99 | infilp, ppos, pipe, len, flags, ioflags); | 332 | return -EIO; |
333 | |||
334 | xfs_ilock(ip, XFS_IOLOCK_SHARED); | ||
335 | |||
336 | if (DM_EVENT_ENABLED(ip, DM_EVENT_READ) && !(ioflags & IO_INVIS)) { | ||
337 | int iolock = XFS_IOLOCK_SHARED; | ||
338 | int error; | ||
339 | |||
340 | error = XFS_SEND_DATA(mp, DM_EVENT_READ, ip, *ppos, count, | ||
341 | FILP_DELAY_FLAG(infilp), &iolock); | ||
342 | if (error) { | ||
343 | xfs_iunlock(ip, XFS_IOLOCK_SHARED); | ||
344 | return -error; | ||
345 | } | ||
346 | } | ||
347 | |||
348 | trace_xfs_file_splice_read(ip, count, *ppos, ioflags); | ||
349 | |||
350 | ret = generic_file_splice_read(infilp, ppos, pipe, count, flags); | ||
351 | if (ret > 0) | ||
352 | XFS_STATS_ADD(xs_read_bytes, ret); | ||
353 | |||
354 | xfs_iunlock(ip, XFS_IOLOCK_SHARED); | ||
355 | return ret; | ||
100 | } | 356 | } |
101 | 357 | ||
102 | STATIC ssize_t | 358 | STATIC ssize_t |
@@ -104,16 +360,538 @@ xfs_file_splice_write( | |||
104 | struct pipe_inode_info *pipe, | 360 | struct pipe_inode_info *pipe, |
105 | struct file *outfilp, | 361 | struct file *outfilp, |
106 | loff_t *ppos, | 362 | loff_t *ppos, |
107 | size_t len, | 363 | size_t count, |
108 | unsigned int flags) | 364 | unsigned int flags) |
109 | { | 365 | { |
366 | struct inode *inode = outfilp->f_mapping->host; | ||
367 | struct xfs_inode *ip = XFS_I(inode); | ||
368 | struct xfs_mount *mp = ip->i_mount; | ||
369 | xfs_fsize_t isize, new_size; | ||
110 | int ioflags = 0; | 370 | int ioflags = 0; |
371 | ssize_t ret; | ||
372 | |||
373 | XFS_STATS_INC(xs_write_calls); | ||
111 | 374 | ||
112 | if (outfilp->f_mode & FMODE_NOCMTIME) | 375 | if (outfilp->f_mode & FMODE_NOCMTIME) |
113 | ioflags |= IO_INVIS; | 376 | ioflags |= IO_INVIS; |
114 | 377 | ||
115 | return xfs_splice_write(XFS_I(outfilp->f_path.dentry->d_inode), | 378 | if (XFS_FORCED_SHUTDOWN(ip->i_mount)) |
116 | pipe, outfilp, ppos, len, flags, ioflags); | 379 | return -EIO; |
380 | |||
381 | xfs_ilock(ip, XFS_IOLOCK_EXCL); | ||
382 | |||
383 | if (DM_EVENT_ENABLED(ip, DM_EVENT_WRITE) && !(ioflags & IO_INVIS)) { | ||
384 | int iolock = XFS_IOLOCK_EXCL; | ||
385 | int error; | ||
386 | |||
387 | error = XFS_SEND_DATA(mp, DM_EVENT_WRITE, ip, *ppos, count, | ||
388 | FILP_DELAY_FLAG(outfilp), &iolock); | ||
389 | if (error) { | ||
390 | xfs_iunlock(ip, XFS_IOLOCK_EXCL); | ||
391 | return -error; | ||
392 | } | ||
393 | } | ||
394 | |||
395 | new_size = *ppos + count; | ||
396 | |||
397 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
398 | if (new_size > ip->i_size) | ||
399 | ip->i_new_size = new_size; | ||
400 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
401 | |||
402 | trace_xfs_file_splice_write(ip, count, *ppos, ioflags); | ||
403 | |||
404 | ret = generic_file_splice_write(pipe, outfilp, ppos, count, flags); | ||
405 | if (ret > 0) | ||
406 | XFS_STATS_ADD(xs_write_bytes, ret); | ||
407 | |||
408 | isize = i_size_read(inode); | ||
409 | if (unlikely(ret < 0 && ret != -EFAULT && *ppos > isize)) | ||
410 | *ppos = isize; | ||
411 | |||
412 | if (*ppos > ip->i_size) { | ||
413 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
414 | if (*ppos > ip->i_size) | ||
415 | ip->i_size = *ppos; | ||
416 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
417 | } | ||
418 | |||
419 | if (ip->i_new_size) { | ||
420 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
421 | ip->i_new_size = 0; | ||
422 | if (ip->i_d.di_size > ip->i_size) | ||
423 | ip->i_d.di_size = ip->i_size; | ||
424 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
425 | } | ||
426 | xfs_iunlock(ip, XFS_IOLOCK_EXCL); | ||
427 | return ret; | ||
428 | } | ||
429 | |||
430 | /* | ||
431 | * This routine is called to handle zeroing any space in the last | ||
432 | * block of the file that is beyond the EOF. We do this since the | ||
433 | * size is being increased without writing anything to that block | ||
434 | * and we don't want anyone to read the garbage on the disk. | ||
435 | */ | ||
436 | STATIC int /* error (positive) */ | ||
437 | xfs_zero_last_block( | ||
438 | xfs_inode_t *ip, | ||
439 | xfs_fsize_t offset, | ||
440 | xfs_fsize_t isize) | ||
441 | { | ||
442 | xfs_fileoff_t last_fsb; | ||
443 | xfs_mount_t *mp = ip->i_mount; | ||
444 | int nimaps; | ||
445 | int zero_offset; | ||
446 | int zero_len; | ||
447 | int error = 0; | ||
448 | xfs_bmbt_irec_t imap; | ||
449 | |||
450 | ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL)); | ||
451 | |||
452 | zero_offset = XFS_B_FSB_OFFSET(mp, isize); | ||
453 | if (zero_offset == 0) { | ||
454 | /* | ||
455 | * There are no extra bytes in the last block on disk to | ||
456 | * zero, so return. | ||
457 | */ | ||
458 | return 0; | ||
459 | } | ||
460 | |||
461 | last_fsb = XFS_B_TO_FSBT(mp, isize); | ||
462 | nimaps = 1; | ||
463 | error = xfs_bmapi(NULL, ip, last_fsb, 1, 0, NULL, 0, &imap, | ||
464 | &nimaps, NULL, NULL); | ||
465 | if (error) { | ||
466 | return error; | ||
467 | } | ||
468 | ASSERT(nimaps > 0); | ||
469 | /* | ||
470 | * If the block underlying isize is just a hole, then there | ||
471 | * is nothing to zero. | ||
472 | */ | ||
473 | if (imap.br_startblock == HOLESTARTBLOCK) { | ||
474 | return 0; | ||
475 | } | ||
476 | /* | ||
477 | * Zero the part of the last block beyond the EOF, and write it | ||
478 | * out sync. We need to drop the ilock while we do this so we | ||
479 | * don't deadlock when the buffer cache calls back to us. | ||
480 | */ | ||
481 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
482 | |||
483 | zero_len = mp->m_sb.sb_blocksize - zero_offset; | ||
484 | if (isize + zero_len > offset) | ||
485 | zero_len = offset - isize; | ||
486 | error = xfs_iozero(ip, isize, zero_len); | ||
487 | |||
488 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
489 | ASSERT(error >= 0); | ||
490 | return error; | ||
491 | } | ||
492 | |||
493 | /* | ||
494 | * Zero any on disk space between the current EOF and the new, | ||
495 | * larger EOF. This handles the normal case of zeroing the remainder | ||
496 | * of the last block in the file and the unusual case of zeroing blocks | ||
497 | * out beyond the size of the file. This second case only happens | ||
498 | * with fixed size extents and when the system crashes before the inode | ||
499 | * size was updated but after blocks were allocated. If fill is set, | ||
500 | * then any holes in the range are filled and zeroed. If not, the holes | ||
501 | * are left alone as holes. | ||
502 | */ | ||
503 | |||
504 | int /* error (positive) */ | ||
505 | xfs_zero_eof( | ||
506 | xfs_inode_t *ip, | ||
507 | xfs_off_t offset, /* starting I/O offset */ | ||
508 | xfs_fsize_t isize) /* current inode size */ | ||
509 | { | ||
510 | xfs_mount_t *mp = ip->i_mount; | ||
511 | xfs_fileoff_t start_zero_fsb; | ||
512 | xfs_fileoff_t end_zero_fsb; | ||
513 | xfs_fileoff_t zero_count_fsb; | ||
514 | xfs_fileoff_t last_fsb; | ||
515 | xfs_fileoff_t zero_off; | ||
516 | xfs_fsize_t zero_len; | ||
517 | int nimaps; | ||
518 | int error = 0; | ||
519 | xfs_bmbt_irec_t imap; | ||
520 | |||
521 | ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL|XFS_IOLOCK_EXCL)); | ||
522 | ASSERT(offset > isize); | ||
523 | |||
524 | /* | ||
525 | * First handle zeroing the block on which isize resides. | ||
526 | * We only zero a part of that block so it is handled specially. | ||
527 | */ | ||
528 | error = xfs_zero_last_block(ip, offset, isize); | ||
529 | if (error) { | ||
530 | ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL|XFS_IOLOCK_EXCL)); | ||
531 | return error; | ||
532 | } | ||
533 | |||
534 | /* | ||
535 | * Calculate the range between the new size and the old | ||
536 | * where blocks needing to be zeroed may exist. To get the | ||
537 | * block where the last byte in the file currently resides, | ||
538 | * we need to subtract one from the size and truncate back | ||
539 | * to a block boundary. We subtract 1 in case the size is | ||
540 | * exactly on a block boundary. | ||
541 | */ | ||
542 | last_fsb = isize ? XFS_B_TO_FSBT(mp, isize - 1) : (xfs_fileoff_t)-1; | ||
543 | start_zero_fsb = XFS_B_TO_FSB(mp, (xfs_ufsize_t)isize); | ||
544 | end_zero_fsb = XFS_B_TO_FSBT(mp, offset - 1); | ||
545 | ASSERT((xfs_sfiloff_t)last_fsb < (xfs_sfiloff_t)start_zero_fsb); | ||
546 | if (last_fsb == end_zero_fsb) { | ||
547 | /* | ||
548 | * The size was only incremented on its last block. | ||
549 | * We took care of that above, so just return. | ||
550 | */ | ||
551 | return 0; | ||
552 | } | ||
553 | |||
554 | ASSERT(start_zero_fsb <= end_zero_fsb); | ||
555 | while (start_zero_fsb <= end_zero_fsb) { | ||
556 | nimaps = 1; | ||
557 | zero_count_fsb = end_zero_fsb - start_zero_fsb + 1; | ||
558 | error = xfs_bmapi(NULL, ip, start_zero_fsb, zero_count_fsb, | ||
559 | 0, NULL, 0, &imap, &nimaps, NULL, NULL); | ||
560 | if (error) { | ||
561 | ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL|XFS_IOLOCK_EXCL)); | ||
562 | return error; | ||
563 | } | ||
564 | ASSERT(nimaps > 0); | ||
565 | |||
566 | if (imap.br_state == XFS_EXT_UNWRITTEN || | ||
567 | imap.br_startblock == HOLESTARTBLOCK) { | ||
568 | /* | ||
569 | * This loop handles initializing pages that were | ||
570 | * partially initialized by the code below this | ||
571 | * loop. It basically zeroes the part of the page | ||
572 | * that sits on a hole and sets the page as P_HOLE | ||
573 | * and calls remapf if it is a mapped file. | ||
574 | */ | ||
575 | start_zero_fsb = imap.br_startoff + imap.br_blockcount; | ||
576 | ASSERT(start_zero_fsb <= (end_zero_fsb + 1)); | ||
577 | continue; | ||
578 | } | ||
579 | |||
580 | /* | ||
581 | * There are blocks we need to zero. | ||
582 | * Drop the inode lock while we're doing the I/O. | ||
583 | * We'll still have the iolock to protect us. | ||
584 | */ | ||
585 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
586 | |||
587 | zero_off = XFS_FSB_TO_B(mp, start_zero_fsb); | ||
588 | zero_len = XFS_FSB_TO_B(mp, imap.br_blockcount); | ||
589 | |||
590 | if ((zero_off + zero_len) > offset) | ||
591 | zero_len = offset - zero_off; | ||
592 | |||
593 | error = xfs_iozero(ip, zero_off, zero_len); | ||
594 | if (error) { | ||
595 | goto out_lock; | ||
596 | } | ||
597 | |||
598 | start_zero_fsb = imap.br_startoff + imap.br_blockcount; | ||
599 | ASSERT(start_zero_fsb <= (end_zero_fsb + 1)); | ||
600 | |||
601 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
602 | } | ||
603 | |||
604 | return 0; | ||
605 | |||
606 | out_lock: | ||
607 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
608 | ASSERT(error >= 0); | ||
609 | return error; | ||
610 | } | ||
611 | |||
612 | STATIC ssize_t | ||
613 | xfs_file_aio_write( | ||
614 | struct kiocb *iocb, | ||
615 | const struct iovec *iovp, | ||
616 | unsigned long nr_segs, | ||
617 | loff_t pos) | ||
618 | { | ||
619 | struct file *file = iocb->ki_filp; | ||
620 | struct address_space *mapping = file->f_mapping; | ||
621 | struct inode *inode = mapping->host; | ||
622 | struct xfs_inode *ip = XFS_I(inode); | ||
623 | struct xfs_mount *mp = ip->i_mount; | ||
624 | ssize_t ret = 0, error = 0; | ||
625 | int ioflags = 0; | ||
626 | xfs_fsize_t isize, new_size; | ||
627 | int iolock; | ||
628 | int eventsent = 0; | ||
629 | size_t ocount = 0, count; | ||
630 | int need_i_mutex; | ||
631 | |||
632 | XFS_STATS_INC(xs_write_calls); | ||
633 | |||
634 | BUG_ON(iocb->ki_pos != pos); | ||
635 | |||
636 | if (unlikely(file->f_flags & O_DIRECT)) | ||
637 | ioflags |= IO_ISDIRECT; | ||
638 | if (file->f_mode & FMODE_NOCMTIME) | ||
639 | ioflags |= IO_INVIS; | ||
640 | |||
641 | error = generic_segment_checks(iovp, &nr_segs, &ocount, VERIFY_READ); | ||
642 | if (error) | ||
643 | return error; | ||
644 | |||
645 | count = ocount; | ||
646 | if (count == 0) | ||
647 | return 0; | ||
648 | |||
649 | xfs_wait_for_freeze(mp, SB_FREEZE_WRITE); | ||
650 | |||
651 | if (XFS_FORCED_SHUTDOWN(mp)) | ||
652 | return -EIO; | ||
653 | |||
654 | relock: | ||
655 | if (ioflags & IO_ISDIRECT) { | ||
656 | iolock = XFS_IOLOCK_SHARED; | ||
657 | need_i_mutex = 0; | ||
658 | } else { | ||
659 | iolock = XFS_IOLOCK_EXCL; | ||
660 | need_i_mutex = 1; | ||
661 | mutex_lock(&inode->i_mutex); | ||
662 | } | ||
663 | |||
664 | xfs_ilock(ip, XFS_ILOCK_EXCL|iolock); | ||
665 | |||
666 | start: | ||
667 | error = -generic_write_checks(file, &pos, &count, | ||
668 | S_ISBLK(inode->i_mode)); | ||
669 | if (error) { | ||
670 | xfs_iunlock(ip, XFS_ILOCK_EXCL|iolock); | ||
671 | goto out_unlock_mutex; | ||
672 | } | ||
673 | |||
674 | if ((DM_EVENT_ENABLED(ip, DM_EVENT_WRITE) && | ||
675 | !(ioflags & IO_INVIS) && !eventsent)) { | ||
676 | int dmflags = FILP_DELAY_FLAG(file); | ||
677 | |||
678 | if (need_i_mutex) | ||
679 | dmflags |= DM_FLAGS_IMUX; | ||
680 | |||
681 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
682 | error = XFS_SEND_DATA(ip->i_mount, DM_EVENT_WRITE, ip, | ||
683 | pos, count, dmflags, &iolock); | ||
684 | if (error) { | ||
685 | goto out_unlock_internal; | ||
686 | } | ||
687 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
688 | eventsent = 1; | ||
689 | |||
690 | /* | ||
691 | * The iolock was dropped and reacquired in XFS_SEND_DATA | ||
692 | * so we have to recheck the size when appending. | ||
693 | * We will only "goto start;" once, since having sent the | ||
694 | * event prevents another call to XFS_SEND_DATA, which is | ||
695 | * what allows the size to change in the first place. | ||
696 | */ | ||
697 | if ((file->f_flags & O_APPEND) && pos != ip->i_size) | ||
698 | goto start; | ||
699 | } | ||
700 | |||
701 | if (ioflags & IO_ISDIRECT) { | ||
702 | xfs_buftarg_t *target = | ||
703 | XFS_IS_REALTIME_INODE(ip) ? | ||
704 | mp->m_rtdev_targp : mp->m_ddev_targp; | ||
705 | |||
706 | if ((pos & target->bt_smask) || (count & target->bt_smask)) { | ||
707 | xfs_iunlock(ip, XFS_ILOCK_EXCL|iolock); | ||
708 | return XFS_ERROR(-EINVAL); | ||
709 | } | ||
710 | |||
711 | if (!need_i_mutex && (mapping->nrpages || pos > ip->i_size)) { | ||
712 | xfs_iunlock(ip, XFS_ILOCK_EXCL|iolock); | ||
713 | iolock = XFS_IOLOCK_EXCL; | ||
714 | need_i_mutex = 1; | ||
715 | mutex_lock(&inode->i_mutex); | ||
716 | xfs_ilock(ip, XFS_ILOCK_EXCL|iolock); | ||
717 | goto start; | ||
718 | } | ||
719 | } | ||
720 | |||
721 | new_size = pos + count; | ||
722 | if (new_size > ip->i_size) | ||
723 | ip->i_new_size = new_size; | ||
724 | |||
725 | if (likely(!(ioflags & IO_INVIS))) | ||
726 | file_update_time(file); | ||
727 | |||
728 | /* | ||
729 | * If the offset is beyond the size of the file, we have a couple | ||
730 | * of things to do. First, if there is already space allocated | ||
731 | * we need to either create holes or zero the disk or ... | ||
732 | * | ||
733 | * If there is a page where the previous size lands, we need | ||
734 | * to zero it out up to the new size. | ||
735 | */ | ||
736 | |||
737 | if (pos > ip->i_size) { | ||
738 | error = xfs_zero_eof(ip, pos, ip->i_size); | ||
739 | if (error) { | ||
740 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
741 | goto out_unlock_internal; | ||
742 | } | ||
743 | } | ||
744 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
745 | |||
746 | /* | ||
747 | * If we're writing the file then make sure to clear the | ||
748 | * setuid and setgid bits if the process is not being run | ||
749 | * by root. This keeps people from modifying setuid and | ||
750 | * setgid binaries. | ||
751 | */ | ||
752 | error = -file_remove_suid(file); | ||
753 | if (unlikely(error)) | ||
754 | goto out_unlock_internal; | ||
755 | |||
756 | /* We can write back this queue in page reclaim */ | ||
757 | current->backing_dev_info = mapping->backing_dev_info; | ||
758 | |||
759 | if ((ioflags & IO_ISDIRECT)) { | ||
760 | if (mapping->nrpages) { | ||
761 | WARN_ON(need_i_mutex == 0); | ||
762 | error = xfs_flushinval_pages(ip, | ||
763 | (pos & PAGE_CACHE_MASK), | ||
764 | -1, FI_REMAPF_LOCKED); | ||
765 | if (error) | ||
766 | goto out_unlock_internal; | ||
767 | } | ||
768 | |||
769 | if (need_i_mutex) { | ||
770 | /* demote the lock now the cached pages are gone */ | ||
771 | xfs_ilock_demote(ip, XFS_IOLOCK_EXCL); | ||
772 | mutex_unlock(&inode->i_mutex); | ||
773 | |||
774 | iolock = XFS_IOLOCK_SHARED; | ||
775 | need_i_mutex = 0; | ||
776 | } | ||
777 | |||
778 | trace_xfs_file_direct_write(ip, count, iocb->ki_pos, ioflags); | ||
779 | ret = generic_file_direct_write(iocb, iovp, | ||
780 | &nr_segs, pos, &iocb->ki_pos, count, ocount); | ||
781 | |||
782 | /* | ||
783 | * direct-io write to a hole: fall through to buffered I/O | ||
784 | * for completing the rest of the request. | ||
785 | */ | ||
786 | if (ret >= 0 && ret != count) { | ||
787 | XFS_STATS_ADD(xs_write_bytes, ret); | ||
788 | |||
789 | pos += ret; | ||
790 | count -= ret; | ||
791 | |||
792 | ioflags &= ~IO_ISDIRECT; | ||
793 | xfs_iunlock(ip, iolock); | ||
794 | goto relock; | ||
795 | } | ||
796 | } else { | ||
797 | int enospc = 0; | ||
798 | ssize_t ret2 = 0; | ||
799 | |||
800 | write_retry: | ||
801 | trace_xfs_file_buffered_write(ip, count, iocb->ki_pos, ioflags); | ||
802 | ret2 = generic_file_buffered_write(iocb, iovp, nr_segs, | ||
803 | pos, &iocb->ki_pos, count, ret); | ||
804 | /* | ||
805 | * if we just got an ENOSPC, flush the inode now we | ||
806 | * aren't holding any page locks and retry *once* | ||
807 | */ | ||
808 | if (ret2 == -ENOSPC && !enospc) { | ||
809 | error = xfs_flush_pages(ip, 0, -1, 0, FI_NONE); | ||
810 | if (error) | ||
811 | goto out_unlock_internal; | ||
812 | enospc = 1; | ||
813 | goto write_retry; | ||
814 | } | ||
815 | ret = ret2; | ||
816 | } | ||
817 | |||
818 | current->backing_dev_info = NULL; | ||
819 | |||
820 | isize = i_size_read(inode); | ||
821 | if (unlikely(ret < 0 && ret != -EFAULT && iocb->ki_pos > isize)) | ||
822 | iocb->ki_pos = isize; | ||
823 | |||
824 | if (iocb->ki_pos > ip->i_size) { | ||
825 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
826 | if (iocb->ki_pos > ip->i_size) | ||
827 | ip->i_size = iocb->ki_pos; | ||
828 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
829 | } | ||
830 | |||
831 | if (ret == -ENOSPC && | ||
832 | DM_EVENT_ENABLED(ip, DM_EVENT_NOSPACE) && !(ioflags & IO_INVIS)) { | ||
833 | xfs_iunlock(ip, iolock); | ||
834 | if (need_i_mutex) | ||
835 | mutex_unlock(&inode->i_mutex); | ||
836 | error = XFS_SEND_NAMESP(ip->i_mount, DM_EVENT_NOSPACE, ip, | ||
837 | DM_RIGHT_NULL, ip, DM_RIGHT_NULL, NULL, NULL, | ||
838 | 0, 0, 0); /* Delay flag intentionally unused */ | ||
839 | if (need_i_mutex) | ||
840 | mutex_lock(&inode->i_mutex); | ||
841 | xfs_ilock(ip, iolock); | ||
842 | if (error) | ||
843 | goto out_unlock_internal; | ||
844 | goto start; | ||
845 | } | ||
846 | |||
847 | error = -ret; | ||
848 | if (ret <= 0) | ||
849 | goto out_unlock_internal; | ||
850 | |||
851 | XFS_STATS_ADD(xs_write_bytes, ret); | ||
852 | |||
853 | /* Handle various SYNC-type writes */ | ||
854 | if ((file->f_flags & O_DSYNC) || IS_SYNC(inode)) { | ||
855 | loff_t end = pos + ret - 1; | ||
856 | int error2; | ||
857 | |||
858 | xfs_iunlock(ip, iolock); | ||
859 | if (need_i_mutex) | ||
860 | mutex_unlock(&inode->i_mutex); | ||
861 | |||
862 | error2 = filemap_write_and_wait_range(mapping, pos, end); | ||
863 | if (!error) | ||
864 | error = error2; | ||
865 | if (need_i_mutex) | ||
866 | mutex_lock(&inode->i_mutex); | ||
867 | xfs_ilock(ip, iolock); | ||
868 | |||
869 | error2 = -xfs_file_fsync(file, file->f_path.dentry, | ||
870 | (file->f_flags & __O_SYNC) ? 0 : 1); | ||
871 | if (!error) | ||
872 | error = error2; | ||
873 | } | ||
874 | |||
875 | out_unlock_internal: | ||
876 | if (ip->i_new_size) { | ||
877 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
878 | ip->i_new_size = 0; | ||
879 | /* | ||
880 | * If this was a direct or synchronous I/O that failed (such | ||
881 | * as ENOSPC) then part of the I/O may have been written to | ||
882 | * disk before the error occured. In this case the on-disk | ||
883 | * file size may have been adjusted beyond the in-memory file | ||
884 | * size and now needs to be truncated back. | ||
885 | */ | ||
886 | if (ip->i_d.di_size > ip->i_size) | ||
887 | ip->i_d.di_size = ip->i_size; | ||
888 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
889 | } | ||
890 | xfs_iunlock(ip, iolock); | ||
891 | out_unlock_mutex: | ||
892 | if (need_i_mutex) | ||
893 | mutex_unlock(&inode->i_mutex); | ||
894 | return -error; | ||
117 | } | 895 | } |
118 | 896 | ||
119 | STATIC int | 897 | STATIC int |
@@ -160,28 +938,6 @@ xfs_file_release( | |||
160 | return -xfs_release(XFS_I(inode)); | 938 | return -xfs_release(XFS_I(inode)); |
161 | } | 939 | } |
162 | 940 | ||
163 | /* | ||
164 | * We ignore the datasync flag here because a datasync is effectively | ||
165 | * identical to an fsync. That is, datasync implies that we need to write | ||
166 | * only the metadata needed to be able to access the data that is written | ||
167 | * if we crash after the call completes. Hence if we are writing beyond | ||
168 | * EOF we have to log the inode size change as well, which makes it a | ||
169 | * full fsync. If we don't write beyond EOF, the inode core will be | ||
170 | * clean in memory and so we don't need to log the inode, just like | ||
171 | * fsync. | ||
172 | */ | ||
173 | STATIC int | ||
174 | xfs_file_fsync( | ||
175 | struct file *file, | ||
176 | struct dentry *dentry, | ||
177 | int datasync) | ||
178 | { | ||
179 | struct xfs_inode *ip = XFS_I(dentry->d_inode); | ||
180 | |||
181 | xfs_iflags_clear(ip, XFS_ITRUNCATED); | ||
182 | return -xfs_fsync(ip); | ||
183 | } | ||
184 | |||
185 | STATIC int | 941 | STATIC int |
186 | xfs_file_readdir( | 942 | xfs_file_readdir( |
187 | struct file *filp, | 943 | struct file *filp, |
@@ -203,9 +959,9 @@ xfs_file_readdir( | |||
203 | * | 959 | * |
204 | * Try to give it an estimate that's good enough, maybe at some | 960 | * Try to give it an estimate that's good enough, maybe at some |
205 | * point we can change the ->readdir prototype to include the | 961 | * point we can change the ->readdir prototype to include the |
206 | * buffer size. | 962 | * buffer size. For now we use the current glibc buffer size. |
207 | */ | 963 | */ |
208 | bufsize = (size_t)min_t(loff_t, PAGE_SIZE, ip->i_d.di_size); | 964 | bufsize = (size_t)min_t(loff_t, 32768, ip->i_d.di_size); |
209 | 965 | ||
210 | error = xfs_readdir(ip, dirent, bufsize, | 966 | error = xfs_readdir(ip, dirent, bufsize, |
211 | (xfs_off_t *)&filp->f_pos, filldir); | 967 | (xfs_off_t *)&filp->f_pos, filldir); |
diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c index e8566bbf0f00..61a99608731e 100644 --- a/fs/xfs/linux-2.6/xfs_iops.c +++ b/fs/xfs/linux-2.6/xfs_iops.c | |||
@@ -91,6 +91,16 @@ xfs_mark_inode_dirty_sync( | |||
91 | mark_inode_dirty_sync(inode); | 91 | mark_inode_dirty_sync(inode); |
92 | } | 92 | } |
93 | 93 | ||
94 | void | ||
95 | xfs_mark_inode_dirty( | ||
96 | xfs_inode_t *ip) | ||
97 | { | ||
98 | struct inode *inode = VFS_I(ip); | ||
99 | |||
100 | if (!(inode->i_state & (I_WILL_FREE|I_FREEING|I_CLEAR))) | ||
101 | mark_inode_dirty(inode); | ||
102 | } | ||
103 | |||
94 | /* | 104 | /* |
95 | * Change the requested timestamp in the given inode. | 105 | * Change the requested timestamp in the given inode. |
96 | * We don't lock across timestamp updates, and we don't log them but | 106 | * We don't lock across timestamp updates, and we don't log them but |
diff --git a/fs/xfs/linux-2.6/xfs_linux.h b/fs/xfs/linux-2.6/xfs_linux.h index 5af0c81ca1ae..facfb323a706 100644 --- a/fs/xfs/linux-2.6/xfs_linux.h +++ b/fs/xfs/linux-2.6/xfs_linux.h | |||
@@ -88,7 +88,6 @@ | |||
88 | #include <xfs_super.h> | 88 | #include <xfs_super.h> |
89 | #include <xfs_globals.h> | 89 | #include <xfs_globals.h> |
90 | #include <xfs_fs_subr.h> | 90 | #include <xfs_fs_subr.h> |
91 | #include <xfs_lrw.h> | ||
92 | #include <xfs_buf.h> | 91 | #include <xfs_buf.h> |
93 | 92 | ||
94 | /* | 93 | /* |
diff --git a/fs/xfs/linux-2.6/xfs_lrw.c b/fs/xfs/linux-2.6/xfs_lrw.c deleted file mode 100644 index eac6f80d786d..000000000000 --- a/fs/xfs/linux-2.6/xfs_lrw.c +++ /dev/null | |||
@@ -1,796 +0,0 @@ | |||
1 | /* | ||
2 | * Copyright (c) 2000-2003,2005 Silicon Graphics, Inc. | ||
3 | * All Rights Reserved. | ||
4 | * | ||
5 | * This program is free software; you can redistribute it and/or | ||
6 | * modify it under the terms of the GNU General Public License as | ||
7 | * published by the Free Software Foundation. | ||
8 | * | ||
9 | * This program is distributed in the hope that it would be useful, | ||
10 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
11 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
12 | * GNU General Public License for more details. | ||
13 | * | ||
14 | * You should have received a copy of the GNU General Public License | ||
15 | * along with this program; if not, write the Free Software Foundation, | ||
16 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | ||
17 | */ | ||
18 | #include "xfs.h" | ||
19 | #include "xfs_fs.h" | ||
20 | #include "xfs_bit.h" | ||
21 | #include "xfs_log.h" | ||
22 | #include "xfs_inum.h" | ||
23 | #include "xfs_trans.h" | ||
24 | #include "xfs_sb.h" | ||
25 | #include "xfs_ag.h" | ||
26 | #include "xfs_dir2.h" | ||
27 | #include "xfs_alloc.h" | ||
28 | #include "xfs_dmapi.h" | ||
29 | #include "xfs_quota.h" | ||
30 | #include "xfs_mount.h" | ||
31 | #include "xfs_bmap_btree.h" | ||
32 | #include "xfs_alloc_btree.h" | ||
33 | #include "xfs_ialloc_btree.h" | ||
34 | #include "xfs_dir2_sf.h" | ||
35 | #include "xfs_attr_sf.h" | ||
36 | #include "xfs_dinode.h" | ||
37 | #include "xfs_inode.h" | ||
38 | #include "xfs_bmap.h" | ||
39 | #include "xfs_btree.h" | ||
40 | #include "xfs_ialloc.h" | ||
41 | #include "xfs_rtalloc.h" | ||
42 | #include "xfs_error.h" | ||
43 | #include "xfs_itable.h" | ||
44 | #include "xfs_rw.h" | ||
45 | #include "xfs_attr.h" | ||
46 | #include "xfs_inode_item.h" | ||
47 | #include "xfs_buf_item.h" | ||
48 | #include "xfs_utils.h" | ||
49 | #include "xfs_iomap.h" | ||
50 | #include "xfs_vnodeops.h" | ||
51 | #include "xfs_trace.h" | ||
52 | |||
53 | #include <linux/capability.h> | ||
54 | #include <linux/writeback.h> | ||
55 | |||
56 | |||
57 | /* | ||
58 | * xfs_iozero | ||
59 | * | ||
60 | * xfs_iozero clears the specified range of buffer supplied, | ||
61 | * and marks all the affected blocks as valid and modified. If | ||
62 | * an affected block is not allocated, it will be allocated. If | ||
63 | * an affected block is not completely overwritten, and is not | ||
64 | * valid before the operation, it will be read from disk before | ||
65 | * being partially zeroed. | ||
66 | */ | ||
67 | STATIC int | ||
68 | xfs_iozero( | ||
69 | struct xfs_inode *ip, /* inode */ | ||
70 | loff_t pos, /* offset in file */ | ||
71 | size_t count) /* size of data to zero */ | ||
72 | { | ||
73 | struct page *page; | ||
74 | struct address_space *mapping; | ||
75 | int status; | ||
76 | |||
77 | mapping = VFS_I(ip)->i_mapping; | ||
78 | do { | ||
79 | unsigned offset, bytes; | ||
80 | void *fsdata; | ||
81 | |||
82 | offset = (pos & (PAGE_CACHE_SIZE -1)); /* Within page */ | ||
83 | bytes = PAGE_CACHE_SIZE - offset; | ||
84 | if (bytes > count) | ||
85 | bytes = count; | ||
86 | |||
87 | status = pagecache_write_begin(NULL, mapping, pos, bytes, | ||
88 | AOP_FLAG_UNINTERRUPTIBLE, | ||
89 | &page, &fsdata); | ||
90 | if (status) | ||
91 | break; | ||
92 | |||
93 | zero_user(page, offset, bytes); | ||
94 | |||
95 | status = pagecache_write_end(NULL, mapping, pos, bytes, bytes, | ||
96 | page, fsdata); | ||
97 | WARN_ON(status <= 0); /* can't return less than zero! */ | ||
98 | pos += bytes; | ||
99 | count -= bytes; | ||
100 | status = 0; | ||
101 | } while (count); | ||
102 | |||
103 | return (-status); | ||
104 | } | ||
105 | |||
106 | ssize_t /* bytes read, or (-) error */ | ||
107 | xfs_read( | ||
108 | xfs_inode_t *ip, | ||
109 | struct kiocb *iocb, | ||
110 | const struct iovec *iovp, | ||
111 | unsigned int segs, | ||
112 | loff_t *offset, | ||
113 | int ioflags) | ||
114 | { | ||
115 | struct file *file = iocb->ki_filp; | ||
116 | struct inode *inode = file->f_mapping->host; | ||
117 | xfs_mount_t *mp = ip->i_mount; | ||
118 | size_t size = 0; | ||
119 | ssize_t ret = 0; | ||
120 | xfs_fsize_t n; | ||
121 | unsigned long seg; | ||
122 | |||
123 | |||
124 | XFS_STATS_INC(xs_read_calls); | ||
125 | |||
126 | /* START copy & waste from filemap.c */ | ||
127 | for (seg = 0; seg < segs; seg++) { | ||
128 | const struct iovec *iv = &iovp[seg]; | ||
129 | |||
130 | /* | ||
131 | * If any segment has a negative length, or the cumulative | ||
132 | * length ever wraps negative then return -EINVAL. | ||
133 | */ | ||
134 | size += iv->iov_len; | ||
135 | if (unlikely((ssize_t)(size|iv->iov_len) < 0)) | ||
136 | return XFS_ERROR(-EINVAL); | ||
137 | } | ||
138 | /* END copy & waste from filemap.c */ | ||
139 | |||
140 | if (unlikely(ioflags & IO_ISDIRECT)) { | ||
141 | xfs_buftarg_t *target = | ||
142 | XFS_IS_REALTIME_INODE(ip) ? | ||
143 | mp->m_rtdev_targp : mp->m_ddev_targp; | ||
144 | if ((*offset & target->bt_smask) || | ||
145 | (size & target->bt_smask)) { | ||
146 | if (*offset == ip->i_size) { | ||
147 | return (0); | ||
148 | } | ||
149 | return -XFS_ERROR(EINVAL); | ||
150 | } | ||
151 | } | ||
152 | |||
153 | n = XFS_MAXIOFFSET(mp) - *offset; | ||
154 | if ((n <= 0) || (size == 0)) | ||
155 | return 0; | ||
156 | |||
157 | if (n < size) | ||
158 | size = n; | ||
159 | |||
160 | if (XFS_FORCED_SHUTDOWN(mp)) | ||
161 | return -EIO; | ||
162 | |||
163 | if (unlikely(ioflags & IO_ISDIRECT)) | ||
164 | mutex_lock(&inode->i_mutex); | ||
165 | xfs_ilock(ip, XFS_IOLOCK_SHARED); | ||
166 | |||
167 | if (DM_EVENT_ENABLED(ip, DM_EVENT_READ) && !(ioflags & IO_INVIS)) { | ||
168 | int dmflags = FILP_DELAY_FLAG(file) | DM_SEM_FLAG_RD(ioflags); | ||
169 | int iolock = XFS_IOLOCK_SHARED; | ||
170 | |||
171 | ret = -XFS_SEND_DATA(mp, DM_EVENT_READ, ip, *offset, size, | ||
172 | dmflags, &iolock); | ||
173 | if (ret) { | ||
174 | xfs_iunlock(ip, XFS_IOLOCK_SHARED); | ||
175 | if (unlikely(ioflags & IO_ISDIRECT)) | ||
176 | mutex_unlock(&inode->i_mutex); | ||
177 | return ret; | ||
178 | } | ||
179 | } | ||
180 | |||
181 | if (unlikely(ioflags & IO_ISDIRECT)) { | ||
182 | if (inode->i_mapping->nrpages) | ||
183 | ret = -xfs_flushinval_pages(ip, (*offset & PAGE_CACHE_MASK), | ||
184 | -1, FI_REMAPF_LOCKED); | ||
185 | mutex_unlock(&inode->i_mutex); | ||
186 | if (ret) { | ||
187 | xfs_iunlock(ip, XFS_IOLOCK_SHARED); | ||
188 | return ret; | ||
189 | } | ||
190 | } | ||
191 | |||
192 | trace_xfs_file_read(ip, size, *offset, ioflags); | ||
193 | |||
194 | iocb->ki_pos = *offset; | ||
195 | ret = generic_file_aio_read(iocb, iovp, segs, *offset); | ||
196 | if (ret > 0) | ||
197 | XFS_STATS_ADD(xs_read_bytes, ret); | ||
198 | |||
199 | xfs_iunlock(ip, XFS_IOLOCK_SHARED); | ||
200 | return ret; | ||
201 | } | ||
202 | |||
203 | ssize_t | ||
204 | xfs_splice_read( | ||
205 | xfs_inode_t *ip, | ||
206 | struct file *infilp, | ||
207 | loff_t *ppos, | ||
208 | struct pipe_inode_info *pipe, | ||
209 | size_t count, | ||
210 | int flags, | ||
211 | int ioflags) | ||
212 | { | ||
213 | xfs_mount_t *mp = ip->i_mount; | ||
214 | ssize_t ret; | ||
215 | |||
216 | XFS_STATS_INC(xs_read_calls); | ||
217 | if (XFS_FORCED_SHUTDOWN(ip->i_mount)) | ||
218 | return -EIO; | ||
219 | |||
220 | xfs_ilock(ip, XFS_IOLOCK_SHARED); | ||
221 | |||
222 | if (DM_EVENT_ENABLED(ip, DM_EVENT_READ) && !(ioflags & IO_INVIS)) { | ||
223 | int iolock = XFS_IOLOCK_SHARED; | ||
224 | int error; | ||
225 | |||
226 | error = XFS_SEND_DATA(mp, DM_EVENT_READ, ip, *ppos, count, | ||
227 | FILP_DELAY_FLAG(infilp), &iolock); | ||
228 | if (error) { | ||
229 | xfs_iunlock(ip, XFS_IOLOCK_SHARED); | ||
230 | return -error; | ||
231 | } | ||
232 | } | ||
233 | |||
234 | trace_xfs_file_splice_read(ip, count, *ppos, ioflags); | ||
235 | |||
236 | ret = generic_file_splice_read(infilp, ppos, pipe, count, flags); | ||
237 | if (ret > 0) | ||
238 | XFS_STATS_ADD(xs_read_bytes, ret); | ||
239 | |||
240 | xfs_iunlock(ip, XFS_IOLOCK_SHARED); | ||
241 | return ret; | ||
242 | } | ||
243 | |||
244 | ssize_t | ||
245 | xfs_splice_write( | ||
246 | xfs_inode_t *ip, | ||
247 | struct pipe_inode_info *pipe, | ||
248 | struct file *outfilp, | ||
249 | loff_t *ppos, | ||
250 | size_t count, | ||
251 | int flags, | ||
252 | int ioflags) | ||
253 | { | ||
254 | xfs_mount_t *mp = ip->i_mount; | ||
255 | ssize_t ret; | ||
256 | struct inode *inode = outfilp->f_mapping->host; | ||
257 | xfs_fsize_t isize, new_size; | ||
258 | |||
259 | XFS_STATS_INC(xs_write_calls); | ||
260 | if (XFS_FORCED_SHUTDOWN(ip->i_mount)) | ||
261 | return -EIO; | ||
262 | |||
263 | xfs_ilock(ip, XFS_IOLOCK_EXCL); | ||
264 | |||
265 | if (DM_EVENT_ENABLED(ip, DM_EVENT_WRITE) && !(ioflags & IO_INVIS)) { | ||
266 | int iolock = XFS_IOLOCK_EXCL; | ||
267 | int error; | ||
268 | |||
269 | error = XFS_SEND_DATA(mp, DM_EVENT_WRITE, ip, *ppos, count, | ||
270 | FILP_DELAY_FLAG(outfilp), &iolock); | ||
271 | if (error) { | ||
272 | xfs_iunlock(ip, XFS_IOLOCK_EXCL); | ||
273 | return -error; | ||
274 | } | ||
275 | } | ||
276 | |||
277 | new_size = *ppos + count; | ||
278 | |||
279 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
280 | if (new_size > ip->i_size) | ||
281 | ip->i_new_size = new_size; | ||
282 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
283 | |||
284 | trace_xfs_file_splice_write(ip, count, *ppos, ioflags); | ||
285 | |||
286 | ret = generic_file_splice_write(pipe, outfilp, ppos, count, flags); | ||
287 | if (ret > 0) | ||
288 | XFS_STATS_ADD(xs_write_bytes, ret); | ||
289 | |||
290 | isize = i_size_read(inode); | ||
291 | if (unlikely(ret < 0 && ret != -EFAULT && *ppos > isize)) | ||
292 | *ppos = isize; | ||
293 | |||
294 | if (*ppos > ip->i_size) { | ||
295 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
296 | if (*ppos > ip->i_size) | ||
297 | ip->i_size = *ppos; | ||
298 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
299 | } | ||
300 | |||
301 | if (ip->i_new_size) { | ||
302 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
303 | ip->i_new_size = 0; | ||
304 | if (ip->i_d.di_size > ip->i_size) | ||
305 | ip->i_d.di_size = ip->i_size; | ||
306 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
307 | } | ||
308 | xfs_iunlock(ip, XFS_IOLOCK_EXCL); | ||
309 | return ret; | ||
310 | } | ||
311 | |||
312 | /* | ||
313 | * This routine is called to handle zeroing any space in the last | ||
314 | * block of the file that is beyond the EOF. We do this since the | ||
315 | * size is being increased without writing anything to that block | ||
316 | * and we don't want anyone to read the garbage on the disk. | ||
317 | */ | ||
318 | STATIC int /* error (positive) */ | ||
319 | xfs_zero_last_block( | ||
320 | xfs_inode_t *ip, | ||
321 | xfs_fsize_t offset, | ||
322 | xfs_fsize_t isize) | ||
323 | { | ||
324 | xfs_fileoff_t last_fsb; | ||
325 | xfs_mount_t *mp = ip->i_mount; | ||
326 | int nimaps; | ||
327 | int zero_offset; | ||
328 | int zero_len; | ||
329 | int error = 0; | ||
330 | xfs_bmbt_irec_t imap; | ||
331 | |||
332 | ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL)); | ||
333 | |||
334 | zero_offset = XFS_B_FSB_OFFSET(mp, isize); | ||
335 | if (zero_offset == 0) { | ||
336 | /* | ||
337 | * There are no extra bytes in the last block on disk to | ||
338 | * zero, so return. | ||
339 | */ | ||
340 | return 0; | ||
341 | } | ||
342 | |||
343 | last_fsb = XFS_B_TO_FSBT(mp, isize); | ||
344 | nimaps = 1; | ||
345 | error = xfs_bmapi(NULL, ip, last_fsb, 1, 0, NULL, 0, &imap, | ||
346 | &nimaps, NULL, NULL); | ||
347 | if (error) { | ||
348 | return error; | ||
349 | } | ||
350 | ASSERT(nimaps > 0); | ||
351 | /* | ||
352 | * If the block underlying isize is just a hole, then there | ||
353 | * is nothing to zero. | ||
354 | */ | ||
355 | if (imap.br_startblock == HOLESTARTBLOCK) { | ||
356 | return 0; | ||
357 | } | ||
358 | /* | ||
359 | * Zero the part of the last block beyond the EOF, and write it | ||
360 | * out sync. We need to drop the ilock while we do this so we | ||
361 | * don't deadlock when the buffer cache calls back to us. | ||
362 | */ | ||
363 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
364 | |||
365 | zero_len = mp->m_sb.sb_blocksize - zero_offset; | ||
366 | if (isize + zero_len > offset) | ||
367 | zero_len = offset - isize; | ||
368 | error = xfs_iozero(ip, isize, zero_len); | ||
369 | |||
370 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
371 | ASSERT(error >= 0); | ||
372 | return error; | ||
373 | } | ||
374 | |||
375 | /* | ||
376 | * Zero any on disk space between the current EOF and the new, | ||
377 | * larger EOF. This handles the normal case of zeroing the remainder | ||
378 | * of the last block in the file and the unusual case of zeroing blocks | ||
379 | * out beyond the size of the file. This second case only happens | ||
380 | * with fixed size extents and when the system crashes before the inode | ||
381 | * size was updated but after blocks were allocated. If fill is set, | ||
382 | * then any holes in the range are filled and zeroed. If not, the holes | ||
383 | * are left alone as holes. | ||
384 | */ | ||
385 | |||
386 | int /* error (positive) */ | ||
387 | xfs_zero_eof( | ||
388 | xfs_inode_t *ip, | ||
389 | xfs_off_t offset, /* starting I/O offset */ | ||
390 | xfs_fsize_t isize) /* current inode size */ | ||
391 | { | ||
392 | xfs_mount_t *mp = ip->i_mount; | ||
393 | xfs_fileoff_t start_zero_fsb; | ||
394 | xfs_fileoff_t end_zero_fsb; | ||
395 | xfs_fileoff_t zero_count_fsb; | ||
396 | xfs_fileoff_t last_fsb; | ||
397 | xfs_fileoff_t zero_off; | ||
398 | xfs_fsize_t zero_len; | ||
399 | int nimaps; | ||
400 | int error = 0; | ||
401 | xfs_bmbt_irec_t imap; | ||
402 | |||
403 | ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL|XFS_IOLOCK_EXCL)); | ||
404 | ASSERT(offset > isize); | ||
405 | |||
406 | /* | ||
407 | * First handle zeroing the block on which isize resides. | ||
408 | * We only zero a part of that block so it is handled specially. | ||
409 | */ | ||
410 | error = xfs_zero_last_block(ip, offset, isize); | ||
411 | if (error) { | ||
412 | ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL|XFS_IOLOCK_EXCL)); | ||
413 | return error; | ||
414 | } | ||
415 | |||
416 | /* | ||
417 | * Calculate the range between the new size and the old | ||
418 | * where blocks needing to be zeroed may exist. To get the | ||
419 | * block where the last byte in the file currently resides, | ||
420 | * we need to subtract one from the size and truncate back | ||
421 | * to a block boundary. We subtract 1 in case the size is | ||
422 | * exactly on a block boundary. | ||
423 | */ | ||
424 | last_fsb = isize ? XFS_B_TO_FSBT(mp, isize - 1) : (xfs_fileoff_t)-1; | ||
425 | start_zero_fsb = XFS_B_TO_FSB(mp, (xfs_ufsize_t)isize); | ||
426 | end_zero_fsb = XFS_B_TO_FSBT(mp, offset - 1); | ||
427 | ASSERT((xfs_sfiloff_t)last_fsb < (xfs_sfiloff_t)start_zero_fsb); | ||
428 | if (last_fsb == end_zero_fsb) { | ||
429 | /* | ||
430 | * The size was only incremented on its last block. | ||
431 | * We took care of that above, so just return. | ||
432 | */ | ||
433 | return 0; | ||
434 | } | ||
435 | |||
436 | ASSERT(start_zero_fsb <= end_zero_fsb); | ||
437 | while (start_zero_fsb <= end_zero_fsb) { | ||
438 | nimaps = 1; | ||
439 | zero_count_fsb = end_zero_fsb - start_zero_fsb + 1; | ||
440 | error = xfs_bmapi(NULL, ip, start_zero_fsb, zero_count_fsb, | ||
441 | 0, NULL, 0, &imap, &nimaps, NULL, NULL); | ||
442 | if (error) { | ||
443 | ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL|XFS_IOLOCK_EXCL)); | ||
444 | return error; | ||
445 | } | ||
446 | ASSERT(nimaps > 0); | ||
447 | |||
448 | if (imap.br_state == XFS_EXT_UNWRITTEN || | ||
449 | imap.br_startblock == HOLESTARTBLOCK) { | ||
450 | /* | ||
451 | * This loop handles initializing pages that were | ||
452 | * partially initialized by the code below this | ||
453 | * loop. It basically zeroes the part of the page | ||
454 | * that sits on a hole and sets the page as P_HOLE | ||
455 | * and calls remapf if it is a mapped file. | ||
456 | */ | ||
457 | start_zero_fsb = imap.br_startoff + imap.br_blockcount; | ||
458 | ASSERT(start_zero_fsb <= (end_zero_fsb + 1)); | ||
459 | continue; | ||
460 | } | ||
461 | |||
462 | /* | ||
463 | * There are blocks we need to zero. | ||
464 | * Drop the inode lock while we're doing the I/O. | ||
465 | * We'll still have the iolock to protect us. | ||
466 | */ | ||
467 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
468 | |||
469 | zero_off = XFS_FSB_TO_B(mp, start_zero_fsb); | ||
470 | zero_len = XFS_FSB_TO_B(mp, imap.br_blockcount); | ||
471 | |||
472 | if ((zero_off + zero_len) > offset) | ||
473 | zero_len = offset - zero_off; | ||
474 | |||
475 | error = xfs_iozero(ip, zero_off, zero_len); | ||
476 | if (error) { | ||
477 | goto out_lock; | ||
478 | } | ||
479 | |||
480 | start_zero_fsb = imap.br_startoff + imap.br_blockcount; | ||
481 | ASSERT(start_zero_fsb <= (end_zero_fsb + 1)); | ||
482 | |||
483 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
484 | } | ||
485 | |||
486 | return 0; | ||
487 | |||
488 | out_lock: | ||
489 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
490 | ASSERT(error >= 0); | ||
491 | return error; | ||
492 | } | ||
493 | |||
494 | ssize_t /* bytes written, or (-) error */ | ||
495 | xfs_write( | ||
496 | struct xfs_inode *xip, | ||
497 | struct kiocb *iocb, | ||
498 | const struct iovec *iovp, | ||
499 | unsigned int nsegs, | ||
500 | loff_t *offset, | ||
501 | int ioflags) | ||
502 | { | ||
503 | struct file *file = iocb->ki_filp; | ||
504 | struct address_space *mapping = file->f_mapping; | ||
505 | struct inode *inode = mapping->host; | ||
506 | unsigned long segs = nsegs; | ||
507 | xfs_mount_t *mp; | ||
508 | ssize_t ret = 0, error = 0; | ||
509 | xfs_fsize_t isize, new_size; | ||
510 | int iolock; | ||
511 | int eventsent = 0; | ||
512 | size_t ocount = 0, count; | ||
513 | loff_t pos; | ||
514 | int need_i_mutex; | ||
515 | |||
516 | XFS_STATS_INC(xs_write_calls); | ||
517 | |||
518 | error = generic_segment_checks(iovp, &segs, &ocount, VERIFY_READ); | ||
519 | if (error) | ||
520 | return error; | ||
521 | |||
522 | count = ocount; | ||
523 | pos = *offset; | ||
524 | |||
525 | if (count == 0) | ||
526 | return 0; | ||
527 | |||
528 | mp = xip->i_mount; | ||
529 | |||
530 | xfs_wait_for_freeze(mp, SB_FREEZE_WRITE); | ||
531 | |||
532 | if (XFS_FORCED_SHUTDOWN(mp)) | ||
533 | return -EIO; | ||
534 | |||
535 | relock: | ||
536 | if (ioflags & IO_ISDIRECT) { | ||
537 | iolock = XFS_IOLOCK_SHARED; | ||
538 | need_i_mutex = 0; | ||
539 | } else { | ||
540 | iolock = XFS_IOLOCK_EXCL; | ||
541 | need_i_mutex = 1; | ||
542 | mutex_lock(&inode->i_mutex); | ||
543 | } | ||
544 | |||
545 | xfs_ilock(xip, XFS_ILOCK_EXCL|iolock); | ||
546 | |||
547 | start: | ||
548 | error = -generic_write_checks(file, &pos, &count, | ||
549 | S_ISBLK(inode->i_mode)); | ||
550 | if (error) { | ||
551 | xfs_iunlock(xip, XFS_ILOCK_EXCL|iolock); | ||
552 | goto out_unlock_mutex; | ||
553 | } | ||
554 | |||
555 | if ((DM_EVENT_ENABLED(xip, DM_EVENT_WRITE) && | ||
556 | !(ioflags & IO_INVIS) && !eventsent)) { | ||
557 | int dmflags = FILP_DELAY_FLAG(file); | ||
558 | |||
559 | if (need_i_mutex) | ||
560 | dmflags |= DM_FLAGS_IMUX; | ||
561 | |||
562 | xfs_iunlock(xip, XFS_ILOCK_EXCL); | ||
563 | error = XFS_SEND_DATA(xip->i_mount, DM_EVENT_WRITE, xip, | ||
564 | pos, count, dmflags, &iolock); | ||
565 | if (error) { | ||
566 | goto out_unlock_internal; | ||
567 | } | ||
568 | xfs_ilock(xip, XFS_ILOCK_EXCL); | ||
569 | eventsent = 1; | ||
570 | |||
571 | /* | ||
572 | * The iolock was dropped and reacquired in XFS_SEND_DATA | ||
573 | * so we have to recheck the size when appending. | ||
574 | * We will only "goto start;" once, since having sent the | ||
575 | * event prevents another call to XFS_SEND_DATA, which is | ||
576 | * what allows the size to change in the first place. | ||
577 | */ | ||
578 | if ((file->f_flags & O_APPEND) && pos != xip->i_size) | ||
579 | goto start; | ||
580 | } | ||
581 | |||
582 | if (ioflags & IO_ISDIRECT) { | ||
583 | xfs_buftarg_t *target = | ||
584 | XFS_IS_REALTIME_INODE(xip) ? | ||
585 | mp->m_rtdev_targp : mp->m_ddev_targp; | ||
586 | |||
587 | if ((pos & target->bt_smask) || (count & target->bt_smask)) { | ||
588 | xfs_iunlock(xip, XFS_ILOCK_EXCL|iolock); | ||
589 | return XFS_ERROR(-EINVAL); | ||
590 | } | ||
591 | |||
592 | if (!need_i_mutex && (mapping->nrpages || pos > xip->i_size)) { | ||
593 | xfs_iunlock(xip, XFS_ILOCK_EXCL|iolock); | ||
594 | iolock = XFS_IOLOCK_EXCL; | ||
595 | need_i_mutex = 1; | ||
596 | mutex_lock(&inode->i_mutex); | ||
597 | xfs_ilock(xip, XFS_ILOCK_EXCL|iolock); | ||
598 | goto start; | ||
599 | } | ||
600 | } | ||
601 | |||
602 | new_size = pos + count; | ||
603 | if (new_size > xip->i_size) | ||
604 | xip->i_new_size = new_size; | ||
605 | |||
606 | if (likely(!(ioflags & IO_INVIS))) | ||
607 | file_update_time(file); | ||
608 | |||
609 | /* | ||
610 | * If the offset is beyond the size of the file, we have a couple | ||
611 | * of things to do. First, if there is already space allocated | ||
612 | * we need to either create holes or zero the disk or ... | ||
613 | * | ||
614 | * If there is a page where the previous size lands, we need | ||
615 | * to zero it out up to the new size. | ||
616 | */ | ||
617 | |||
618 | if (pos > xip->i_size) { | ||
619 | error = xfs_zero_eof(xip, pos, xip->i_size); | ||
620 | if (error) { | ||
621 | xfs_iunlock(xip, XFS_ILOCK_EXCL); | ||
622 | goto out_unlock_internal; | ||
623 | } | ||
624 | } | ||
625 | xfs_iunlock(xip, XFS_ILOCK_EXCL); | ||
626 | |||
627 | /* | ||
628 | * If we're writing the file then make sure to clear the | ||
629 | * setuid and setgid bits if the process is not being run | ||
630 | * by root. This keeps people from modifying setuid and | ||
631 | * setgid binaries. | ||
632 | */ | ||
633 | error = -file_remove_suid(file); | ||
634 | if (unlikely(error)) | ||
635 | goto out_unlock_internal; | ||
636 | |||
637 | /* We can write back this queue in page reclaim */ | ||
638 | current->backing_dev_info = mapping->backing_dev_info; | ||
639 | |||
640 | if ((ioflags & IO_ISDIRECT)) { | ||
641 | if (mapping->nrpages) { | ||
642 | WARN_ON(need_i_mutex == 0); | ||
643 | error = xfs_flushinval_pages(xip, | ||
644 | (pos & PAGE_CACHE_MASK), | ||
645 | -1, FI_REMAPF_LOCKED); | ||
646 | if (error) | ||
647 | goto out_unlock_internal; | ||
648 | } | ||
649 | |||
650 | if (need_i_mutex) { | ||
651 | /* demote the lock now the cached pages are gone */ | ||
652 | xfs_ilock_demote(xip, XFS_IOLOCK_EXCL); | ||
653 | mutex_unlock(&inode->i_mutex); | ||
654 | |||
655 | iolock = XFS_IOLOCK_SHARED; | ||
656 | need_i_mutex = 0; | ||
657 | } | ||
658 | |||
659 | trace_xfs_file_direct_write(xip, count, *offset, ioflags); | ||
660 | ret = generic_file_direct_write(iocb, iovp, | ||
661 | &segs, pos, offset, count, ocount); | ||
662 | |||
663 | /* | ||
664 | * direct-io write to a hole: fall through to buffered I/O | ||
665 | * for completing the rest of the request. | ||
666 | */ | ||
667 | if (ret >= 0 && ret != count) { | ||
668 | XFS_STATS_ADD(xs_write_bytes, ret); | ||
669 | |||
670 | pos += ret; | ||
671 | count -= ret; | ||
672 | |||
673 | ioflags &= ~IO_ISDIRECT; | ||
674 | xfs_iunlock(xip, iolock); | ||
675 | goto relock; | ||
676 | } | ||
677 | } else { | ||
678 | int enospc = 0; | ||
679 | ssize_t ret2 = 0; | ||
680 | |||
681 | write_retry: | ||
682 | trace_xfs_file_buffered_write(xip, count, *offset, ioflags); | ||
683 | ret2 = generic_file_buffered_write(iocb, iovp, segs, | ||
684 | pos, offset, count, ret); | ||
685 | /* | ||
686 | * if we just got an ENOSPC, flush the inode now we | ||
687 | * aren't holding any page locks and retry *once* | ||
688 | */ | ||
689 | if (ret2 == -ENOSPC && !enospc) { | ||
690 | error = xfs_flush_pages(xip, 0, -1, 0, FI_NONE); | ||
691 | if (error) | ||
692 | goto out_unlock_internal; | ||
693 | enospc = 1; | ||
694 | goto write_retry; | ||
695 | } | ||
696 | ret = ret2; | ||
697 | } | ||
698 | |||
699 | current->backing_dev_info = NULL; | ||
700 | |||
701 | isize = i_size_read(inode); | ||
702 | if (unlikely(ret < 0 && ret != -EFAULT && *offset > isize)) | ||
703 | *offset = isize; | ||
704 | |||
705 | if (*offset > xip->i_size) { | ||
706 | xfs_ilock(xip, XFS_ILOCK_EXCL); | ||
707 | if (*offset > xip->i_size) | ||
708 | xip->i_size = *offset; | ||
709 | xfs_iunlock(xip, XFS_ILOCK_EXCL); | ||
710 | } | ||
711 | |||
712 | if (ret == -ENOSPC && | ||
713 | DM_EVENT_ENABLED(xip, DM_EVENT_NOSPACE) && !(ioflags & IO_INVIS)) { | ||
714 | xfs_iunlock(xip, iolock); | ||
715 | if (need_i_mutex) | ||
716 | mutex_unlock(&inode->i_mutex); | ||
717 | error = XFS_SEND_NAMESP(xip->i_mount, DM_EVENT_NOSPACE, xip, | ||
718 | DM_RIGHT_NULL, xip, DM_RIGHT_NULL, NULL, NULL, | ||
719 | 0, 0, 0); /* Delay flag intentionally unused */ | ||
720 | if (need_i_mutex) | ||
721 | mutex_lock(&inode->i_mutex); | ||
722 | xfs_ilock(xip, iolock); | ||
723 | if (error) | ||
724 | goto out_unlock_internal; | ||
725 | goto start; | ||
726 | } | ||
727 | |||
728 | error = -ret; | ||
729 | if (ret <= 0) | ||
730 | goto out_unlock_internal; | ||
731 | |||
732 | XFS_STATS_ADD(xs_write_bytes, ret); | ||
733 | |||
734 | /* Handle various SYNC-type writes */ | ||
735 | if ((file->f_flags & O_DSYNC) || IS_SYNC(inode)) { | ||
736 | loff_t end = pos + ret - 1; | ||
737 | int error2; | ||
738 | |||
739 | xfs_iunlock(xip, iolock); | ||
740 | if (need_i_mutex) | ||
741 | mutex_unlock(&inode->i_mutex); | ||
742 | |||
743 | error2 = filemap_write_and_wait_range(mapping, pos, end); | ||
744 | if (!error) | ||
745 | error = error2; | ||
746 | if (need_i_mutex) | ||
747 | mutex_lock(&inode->i_mutex); | ||
748 | xfs_ilock(xip, iolock); | ||
749 | |||
750 | error2 = xfs_fsync(xip); | ||
751 | if (!error) | ||
752 | error = error2; | ||
753 | } | ||
754 | |||
755 | out_unlock_internal: | ||
756 | if (xip->i_new_size) { | ||
757 | xfs_ilock(xip, XFS_ILOCK_EXCL); | ||
758 | xip->i_new_size = 0; | ||
759 | /* | ||
760 | * If this was a direct or synchronous I/O that failed (such | ||
761 | * as ENOSPC) then part of the I/O may have been written to | ||
762 | * disk before the error occured. In this case the on-disk | ||
763 | * file size may have been adjusted beyond the in-memory file | ||
764 | * size and now needs to be truncated back. | ||
765 | */ | ||
766 | if (xip->i_d.di_size > xip->i_size) | ||
767 | xip->i_d.di_size = xip->i_size; | ||
768 | xfs_iunlock(xip, XFS_ILOCK_EXCL); | ||
769 | } | ||
770 | xfs_iunlock(xip, iolock); | ||
771 | out_unlock_mutex: | ||
772 | if (need_i_mutex) | ||
773 | mutex_unlock(&inode->i_mutex); | ||
774 | return -error; | ||
775 | } | ||
776 | |||
777 | /* | ||
778 | * If the underlying (data/log/rt) device is readonly, there are some | ||
779 | * operations that cannot proceed. | ||
780 | */ | ||
781 | int | ||
782 | xfs_dev_is_read_only( | ||
783 | xfs_mount_t *mp, | ||
784 | char *message) | ||
785 | { | ||
786 | if (xfs_readonly_buftarg(mp->m_ddev_targp) || | ||
787 | xfs_readonly_buftarg(mp->m_logdev_targp) || | ||
788 | (mp->m_rtdev_targp && xfs_readonly_buftarg(mp->m_rtdev_targp))) { | ||
789 | cmn_err(CE_NOTE, | ||
790 | "XFS: %s required on read-only device.", message); | ||
791 | cmn_err(CE_NOTE, | ||
792 | "XFS: write access unavailable, cannot proceed."); | ||
793 | return EROFS; | ||
794 | } | ||
795 | return 0; | ||
796 | } | ||
diff --git a/fs/xfs/linux-2.6/xfs_lrw.h b/fs/xfs/linux-2.6/xfs_lrw.h deleted file mode 100644 index 342ae8c0d011..000000000000 --- a/fs/xfs/linux-2.6/xfs_lrw.h +++ /dev/null | |||
@@ -1,29 +0,0 @@ | |||
1 | /* | ||
2 | * Copyright (c) 2000-2003,2005 Silicon Graphics, Inc. | ||
3 | * All Rights Reserved. | ||
4 | * | ||
5 | * This program is free software; you can redistribute it and/or | ||
6 | * modify it under the terms of the GNU General Public License as | ||
7 | * published by the Free Software Foundation. | ||
8 | * | ||
9 | * This program is distributed in the hope that it would be useful, | ||
10 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
11 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
12 | * GNU General Public License for more details. | ||
13 | * | ||
14 | * You should have received a copy of the GNU General Public License | ||
15 | * along with this program; if not, write the Free Software Foundation, | ||
16 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | ||
17 | */ | ||
18 | #ifndef __XFS_LRW_H__ | ||
19 | #define __XFS_LRW_H__ | ||
20 | |||
21 | struct xfs_mount; | ||
22 | struct xfs_inode; | ||
23 | struct xfs_buf; | ||
24 | |||
25 | extern int xfs_dev_is_read_only(struct xfs_mount *, char *); | ||
26 | |||
27 | extern int xfs_zero_eof(struct xfs_inode *, xfs_off_t, xfs_fsize_t); | ||
28 | |||
29 | #endif /* __XFS_LRW_H__ */ | ||
diff --git a/fs/xfs/linux-2.6/xfs_quotaops.c b/fs/xfs/linux-2.6/xfs_quotaops.c index 3d4a0c84d634..1947514ce1ad 100644 --- a/fs/xfs/linux-2.6/xfs_quotaops.c +++ b/fs/xfs/linux-2.6/xfs_quotaops.c | |||
@@ -44,20 +44,6 @@ xfs_quota_type(int type) | |||
44 | } | 44 | } |
45 | 45 | ||
46 | STATIC int | 46 | STATIC int |
47 | xfs_fs_quota_sync( | ||
48 | struct super_block *sb, | ||
49 | int type) | ||
50 | { | ||
51 | struct xfs_mount *mp = XFS_M(sb); | ||
52 | |||
53 | if (sb->s_flags & MS_RDONLY) | ||
54 | return -EROFS; | ||
55 | if (!XFS_IS_QUOTA_RUNNING(mp)) | ||
56 | return -ENOSYS; | ||
57 | return -xfs_sync_data(mp, 0); | ||
58 | } | ||
59 | |||
60 | STATIC int | ||
61 | xfs_fs_get_xstate( | 47 | xfs_fs_get_xstate( |
62 | struct super_block *sb, | 48 | struct super_block *sb, |
63 | struct fs_quota_stat *fqs) | 49 | struct fs_quota_stat *fqs) |
@@ -82,8 +68,6 @@ xfs_fs_set_xstate( | |||
82 | return -EROFS; | 68 | return -EROFS; |
83 | if (op != Q_XQUOTARM && !XFS_IS_QUOTA_RUNNING(mp)) | 69 | if (op != Q_XQUOTARM && !XFS_IS_QUOTA_RUNNING(mp)) |
84 | return -ENOSYS; | 70 | return -ENOSYS; |
85 | if (!capable(CAP_SYS_ADMIN)) | ||
86 | return -EPERM; | ||
87 | 71 | ||
88 | if (uflags & XFS_QUOTA_UDQ_ACCT) | 72 | if (uflags & XFS_QUOTA_UDQ_ACCT) |
89 | flags |= XFS_UQUOTA_ACCT; | 73 | flags |= XFS_UQUOTA_ACCT; |
@@ -144,14 +128,11 @@ xfs_fs_set_xquota( | |||
144 | return -ENOSYS; | 128 | return -ENOSYS; |
145 | if (!XFS_IS_QUOTA_ON(mp)) | 129 | if (!XFS_IS_QUOTA_ON(mp)) |
146 | return -ESRCH; | 130 | return -ESRCH; |
147 | if (!capable(CAP_SYS_ADMIN)) | ||
148 | return -EPERM; | ||
149 | 131 | ||
150 | return -xfs_qm_scall_setqlim(mp, id, xfs_quota_type(type), fdq); | 132 | return -xfs_qm_scall_setqlim(mp, id, xfs_quota_type(type), fdq); |
151 | } | 133 | } |
152 | 134 | ||
153 | const struct quotactl_ops xfs_quotactl_operations = { | 135 | const struct quotactl_ops xfs_quotactl_operations = { |
154 | .quota_sync = xfs_fs_quota_sync, | ||
155 | .get_xstate = xfs_fs_get_xstate, | 136 | .get_xstate = xfs_fs_get_xstate, |
156 | .set_xstate = xfs_fs_set_xstate, | 137 | .set_xstate = xfs_fs_set_xstate, |
157 | .get_xquota = xfs_fs_get_xquota, | 138 | .get_xquota = xfs_fs_get_xquota, |
diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c index 25ea2408118f..71345a370d9f 100644 --- a/fs/xfs/linux-2.6/xfs_super.c +++ b/fs/xfs/linux-2.6/xfs_super.c | |||
@@ -1063,7 +1063,7 @@ xfs_log_inode( | |||
1063 | STATIC int | 1063 | STATIC int |
1064 | xfs_fs_write_inode( | 1064 | xfs_fs_write_inode( |
1065 | struct inode *inode, | 1065 | struct inode *inode, |
1066 | int sync) | 1066 | struct writeback_control *wbc) |
1067 | { | 1067 | { |
1068 | struct xfs_inode *ip = XFS_I(inode); | 1068 | struct xfs_inode *ip = XFS_I(inode); |
1069 | struct xfs_mount *mp = ip->i_mount; | 1069 | struct xfs_mount *mp = ip->i_mount; |
@@ -1074,11 +1074,7 @@ xfs_fs_write_inode( | |||
1074 | if (XFS_FORCED_SHUTDOWN(mp)) | 1074 | if (XFS_FORCED_SHUTDOWN(mp)) |
1075 | return XFS_ERROR(EIO); | 1075 | return XFS_ERROR(EIO); |
1076 | 1076 | ||
1077 | if (sync) { | 1077 | if (wbc->sync_mode == WB_SYNC_ALL) { |
1078 | error = xfs_wait_on_pages(ip, 0, -1); | ||
1079 | if (error) | ||
1080 | goto out; | ||
1081 | |||
1082 | /* | 1078 | /* |
1083 | * Make sure the inode has hit stable storage. By using the | 1079 | * Make sure the inode has hit stable storage. By using the |
1084 | * log and the fsync transactions we reduce the IOs we have | 1080 | * log and the fsync transactions we reduce the IOs we have |
diff --git a/fs/xfs/linux-2.6/xfs_sync.c b/fs/xfs/linux-2.6/xfs_sync.c index a9f6d20aff41..05cd85317f6f 100644 --- a/fs/xfs/linux-2.6/xfs_sync.c +++ b/fs/xfs/linux-2.6/xfs_sync.c | |||
@@ -607,7 +607,8 @@ xfssyncd( | |||
607 | set_freezable(); | 607 | set_freezable(); |
608 | timeleft = xfs_syncd_centisecs * msecs_to_jiffies(10); | 608 | timeleft = xfs_syncd_centisecs * msecs_to_jiffies(10); |
609 | for (;;) { | 609 | for (;;) { |
610 | timeleft = schedule_timeout_interruptible(timeleft); | 610 | if (list_empty(&mp->m_sync_list)) |
611 | timeleft = schedule_timeout_interruptible(timeleft); | ||
611 | /* swsusp */ | 612 | /* swsusp */ |
612 | try_to_freeze(); | 613 | try_to_freeze(); |
613 | if (kthread_should_stop() && list_empty(&mp->m_sync_list)) | 614 | if (kthread_should_stop() && list_empty(&mp->m_sync_list)) |
@@ -627,8 +628,7 @@ xfssyncd( | |||
627 | list_add_tail(&mp->m_sync_work.w_list, | 628 | list_add_tail(&mp->m_sync_work.w_list, |
628 | &mp->m_sync_list); | 629 | &mp->m_sync_list); |
629 | } | 630 | } |
630 | list_for_each_entry_safe(work, n, &mp->m_sync_list, w_list) | 631 | list_splice_init(&mp->m_sync_list, &tmp); |
631 | list_move(&work->w_list, &tmp); | ||
632 | spin_unlock(&mp->m_sync_lock); | 632 | spin_unlock(&mp->m_sync_lock); |
633 | 633 | ||
634 | list_for_each_entry_safe(work, n, &tmp, w_list) { | 634 | list_for_each_entry_safe(work, n, &tmp, w_list) { |
@@ -688,12 +688,12 @@ xfs_inode_set_reclaim_tag( | |||
688 | struct xfs_perag *pag; | 688 | struct xfs_perag *pag; |
689 | 689 | ||
690 | pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, ip->i_ino)); | 690 | pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, ip->i_ino)); |
691 | read_lock(&pag->pag_ici_lock); | 691 | write_lock(&pag->pag_ici_lock); |
692 | spin_lock(&ip->i_flags_lock); | 692 | spin_lock(&ip->i_flags_lock); |
693 | __xfs_inode_set_reclaim_tag(pag, ip); | 693 | __xfs_inode_set_reclaim_tag(pag, ip); |
694 | __xfs_iflags_set(ip, XFS_IRECLAIMABLE); | 694 | __xfs_iflags_set(ip, XFS_IRECLAIMABLE); |
695 | spin_unlock(&ip->i_flags_lock); | 695 | spin_unlock(&ip->i_flags_lock); |
696 | read_unlock(&pag->pag_ici_lock); | 696 | write_unlock(&pag->pag_ici_lock); |
697 | xfs_perag_put(pag); | 697 | xfs_perag_put(pag); |
698 | } | 698 | } |
699 | 699 | ||
diff --git a/fs/xfs/linux-2.6/xfs_trace.c b/fs/xfs/linux-2.6/xfs_trace.c index 856eb3c8d605..5a107601e969 100644 --- a/fs/xfs/linux-2.6/xfs_trace.c +++ b/fs/xfs/linux-2.6/xfs_trace.c | |||
@@ -52,22 +52,6 @@ | |||
52 | #include "quota/xfs_dquot.h" | 52 | #include "quota/xfs_dquot.h" |
53 | 53 | ||
54 | /* | 54 | /* |
55 | * Format fsblock number into a static buffer & return it. | ||
56 | */ | ||
57 | STATIC char *xfs_fmtfsblock(xfs_fsblock_t bno) | ||
58 | { | ||
59 | static char rval[50]; | ||
60 | |||
61 | if (bno == NULLFSBLOCK) | ||
62 | sprintf(rval, "NULLFSBLOCK"); | ||
63 | else if (isnullstartblock(bno)) | ||
64 | sprintf(rval, "NULLSTARTBLOCK(%lld)", startblockval(bno)); | ||
65 | else | ||
66 | sprintf(rval, "%lld", (xfs_dfsbno_t)bno); | ||
67 | return rval; | ||
68 | } | ||
69 | |||
70 | /* | ||
71 | * We include this last to have the helpers above available for the trace | 55 | * We include this last to have the helpers above available for the trace |
72 | * event implementations. | 56 | * event implementations. |
73 | */ | 57 | */ |
diff --git a/fs/xfs/linux-2.6/xfs_trace.h b/fs/xfs/linux-2.6/xfs_trace.h index a4574dcf5065..fcaa62f0799e 100644 --- a/fs/xfs/linux-2.6/xfs_trace.h +++ b/fs/xfs/linux-2.6/xfs_trace.h | |||
@@ -197,13 +197,13 @@ TRACE_EVENT(xfs_iext_insert, | |||
197 | __entry->caller_ip = caller_ip; | 197 | __entry->caller_ip = caller_ip; |
198 | ), | 198 | ), |
199 | TP_printk("dev %d:%d ino 0x%llx state %s idx %ld " | 199 | TP_printk("dev %d:%d ino 0x%llx state %s idx %ld " |
200 | "offset %lld block %s count %lld flag %d caller %pf", | 200 | "offset %lld block %lld count %lld flag %d caller %pf", |
201 | MAJOR(__entry->dev), MINOR(__entry->dev), | 201 | MAJOR(__entry->dev), MINOR(__entry->dev), |
202 | __entry->ino, | 202 | __entry->ino, |
203 | __print_flags(__entry->bmap_state, "|", XFS_BMAP_EXT_FLAGS), | 203 | __print_flags(__entry->bmap_state, "|", XFS_BMAP_EXT_FLAGS), |
204 | (long)__entry->idx, | 204 | (long)__entry->idx, |
205 | __entry->startoff, | 205 | __entry->startoff, |
206 | xfs_fmtfsblock(__entry->startblock), | 206 | (__int64_t)__entry->startblock, |
207 | __entry->blockcount, | 207 | __entry->blockcount, |
208 | __entry->state, | 208 | __entry->state, |
209 | (char *)__entry->caller_ip) | 209 | (char *)__entry->caller_ip) |
@@ -241,13 +241,13 @@ DECLARE_EVENT_CLASS(xfs_bmap_class, | |||
241 | __entry->caller_ip = caller_ip; | 241 | __entry->caller_ip = caller_ip; |
242 | ), | 242 | ), |
243 | TP_printk("dev %d:%d ino 0x%llx state %s idx %ld " | 243 | TP_printk("dev %d:%d ino 0x%llx state %s idx %ld " |
244 | "offset %lld block %s count %lld flag %d caller %pf", | 244 | "offset %lld block %lld count %lld flag %d caller %pf", |
245 | MAJOR(__entry->dev), MINOR(__entry->dev), | 245 | MAJOR(__entry->dev), MINOR(__entry->dev), |
246 | __entry->ino, | 246 | __entry->ino, |
247 | __print_flags(__entry->bmap_state, "|", XFS_BMAP_EXT_FLAGS), | 247 | __print_flags(__entry->bmap_state, "|", XFS_BMAP_EXT_FLAGS), |
248 | (long)__entry->idx, | 248 | (long)__entry->idx, |
249 | __entry->startoff, | 249 | __entry->startoff, |
250 | xfs_fmtfsblock(__entry->startblock), | 250 | (__int64_t)__entry->startblock, |
251 | __entry->blockcount, | 251 | __entry->blockcount, |
252 | __entry->state, | 252 | __entry->state, |
253 | (char *)__entry->caller_ip) | 253 | (char *)__entry->caller_ip) |
@@ -593,7 +593,7 @@ DECLARE_EVENT_CLASS(xfs_dquot_class, | |||
593 | TP_ARGS(dqp), | 593 | TP_ARGS(dqp), |
594 | TP_STRUCT__entry( | 594 | TP_STRUCT__entry( |
595 | __field(dev_t, dev) | 595 | __field(dev_t, dev) |
596 | __field(__be32, id) | 596 | __field(u32, id) |
597 | __field(unsigned, flags) | 597 | __field(unsigned, flags) |
598 | __field(unsigned, nrefs) | 598 | __field(unsigned, nrefs) |
599 | __field(unsigned long long, res_bcount) | 599 | __field(unsigned long long, res_bcount) |
@@ -606,7 +606,7 @@ DECLARE_EVENT_CLASS(xfs_dquot_class, | |||
606 | ), \ | 606 | ), \ |
607 | TP_fast_assign( | 607 | TP_fast_assign( |
608 | __entry->dev = dqp->q_mount->m_super->s_dev; | 608 | __entry->dev = dqp->q_mount->m_super->s_dev; |
609 | __entry->id = dqp->q_core.d_id; | 609 | __entry->id = be32_to_cpu(dqp->q_core.d_id); |
610 | __entry->flags = dqp->dq_flags; | 610 | __entry->flags = dqp->dq_flags; |
611 | __entry->nrefs = dqp->q_nrefs; | 611 | __entry->nrefs = dqp->q_nrefs; |
612 | __entry->res_bcount = dqp->q_res_bcount; | 612 | __entry->res_bcount = dqp->q_res_bcount; |
@@ -622,10 +622,10 @@ DECLARE_EVENT_CLASS(xfs_dquot_class, | |||
622 | be64_to_cpu(dqp->q_core.d_ino_softlimit); | 622 | be64_to_cpu(dqp->q_core.d_ino_softlimit); |
623 | ), | 623 | ), |
624 | TP_printk("dev %d:%d id 0x%x flags %s nrefs %u res_bc 0x%llx " | 624 | TP_printk("dev %d:%d id 0x%x flags %s nrefs %u res_bc 0x%llx " |
625 | "bcnt 0x%llx [hard 0x%llx | soft 0x%llx] " | 625 | "bcnt 0x%llx bhardlimit 0x%llx bsoftlimit 0x%llx " |
626 | "icnt 0x%llx [hard 0x%llx | soft 0x%llx]", | 626 | "icnt 0x%llx ihardlimit 0x%llx isoftlimit 0x%llx]", |
627 | MAJOR(__entry->dev), MINOR(__entry->dev), | 627 | MAJOR(__entry->dev), MINOR(__entry->dev), |
628 | be32_to_cpu(__entry->id), | 628 | __entry->id, |
629 | __print_flags(__entry->flags, "|", XFS_DQ_FLAGS), | 629 | __print_flags(__entry->flags, "|", XFS_DQ_FLAGS), |
630 | __entry->nrefs, | 630 | __entry->nrefs, |
631 | __entry->res_bcount, | 631 | __entry->res_bcount, |
@@ -881,7 +881,7 @@ TRACE_EVENT(name, \ | |||
881 | ), \ | 881 | ), \ |
882 | TP_printk("dev %d:%d ino 0x%llx size 0x%llx new_size 0x%llx " \ | 882 | TP_printk("dev %d:%d ino 0x%llx size 0x%llx new_size 0x%llx " \ |
883 | "offset 0x%llx count %zd flags %s " \ | 883 | "offset 0x%llx count %zd flags %s " \ |
884 | "startoff 0x%llx startblock %s blockcount 0x%llx", \ | 884 | "startoff 0x%llx startblock %lld blockcount 0x%llx", \ |
885 | MAJOR(__entry->dev), MINOR(__entry->dev), \ | 885 | MAJOR(__entry->dev), MINOR(__entry->dev), \ |
886 | __entry->ino, \ | 886 | __entry->ino, \ |
887 | __entry->size, \ | 887 | __entry->size, \ |
@@ -890,7 +890,7 @@ TRACE_EVENT(name, \ | |||
890 | __entry->count, \ | 890 | __entry->count, \ |
891 | __print_flags(__entry->flags, "|", BMAPI_FLAGS), \ | 891 | __print_flags(__entry->flags, "|", BMAPI_FLAGS), \ |
892 | __entry->startoff, \ | 892 | __entry->startoff, \ |
893 | xfs_fmtfsblock(__entry->startblock), \ | 893 | (__int64_t)__entry->startblock, \ |
894 | __entry->blockcount) \ | 894 | __entry->blockcount) \ |
895 | ) | 895 | ) |
896 | DEFINE_IOMAP_EVENT(xfs_iomap_enter); | 896 | DEFINE_IOMAP_EVENT(xfs_iomap_enter); |
diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c index 1869fb973819..5c11e4d17010 100644 --- a/fs/xfs/xfs_bmap.c +++ b/fs/xfs/xfs_bmap.c | |||
@@ -2550,22 +2550,134 @@ xfs_bmap_rtalloc( | |||
2550 | } | 2550 | } |
2551 | 2551 | ||
2552 | STATIC int | 2552 | STATIC int |
2553 | xfs_bmap_btalloc_nullfb( | ||
2554 | struct xfs_bmalloca *ap, | ||
2555 | struct xfs_alloc_arg *args, | ||
2556 | xfs_extlen_t *blen) | ||
2557 | { | ||
2558 | struct xfs_mount *mp = ap->ip->i_mount; | ||
2559 | struct xfs_perag *pag; | ||
2560 | xfs_agnumber_t ag, startag; | ||
2561 | int notinit = 0; | ||
2562 | int error; | ||
2563 | |||
2564 | if (ap->userdata && xfs_inode_is_filestream(ap->ip)) | ||
2565 | args->type = XFS_ALLOCTYPE_NEAR_BNO; | ||
2566 | else | ||
2567 | args->type = XFS_ALLOCTYPE_START_BNO; | ||
2568 | args->total = ap->total; | ||
2569 | |||
2570 | /* | ||
2571 | * Search for an allocation group with a single extent large enough | ||
2572 | * for the request. If one isn't found, then adjust the minimum | ||
2573 | * allocation size to the largest space found. | ||
2574 | */ | ||
2575 | startag = ag = XFS_FSB_TO_AGNO(mp, args->fsbno); | ||
2576 | if (startag == NULLAGNUMBER) | ||
2577 | startag = ag = 0; | ||
2578 | |||
2579 | pag = xfs_perag_get(mp, ag); | ||
2580 | while (*blen < ap->alen) { | ||
2581 | if (!pag->pagf_init) { | ||
2582 | error = xfs_alloc_pagf_init(mp, args->tp, ag, | ||
2583 | XFS_ALLOC_FLAG_TRYLOCK); | ||
2584 | if (error) { | ||
2585 | xfs_perag_put(pag); | ||
2586 | return error; | ||
2587 | } | ||
2588 | } | ||
2589 | |||
2590 | /* | ||
2591 | * See xfs_alloc_fix_freelist... | ||
2592 | */ | ||
2593 | if (pag->pagf_init) { | ||
2594 | xfs_extlen_t longest; | ||
2595 | longest = xfs_alloc_longest_free_extent(mp, pag); | ||
2596 | if (*blen < longest) | ||
2597 | *blen = longest; | ||
2598 | } else | ||
2599 | notinit = 1; | ||
2600 | |||
2601 | if (xfs_inode_is_filestream(ap->ip)) { | ||
2602 | if (*blen >= ap->alen) | ||
2603 | break; | ||
2604 | |||
2605 | if (ap->userdata) { | ||
2606 | /* | ||
2607 | * If startag is an invalid AG, we've | ||
2608 | * come here once before and | ||
2609 | * xfs_filestream_new_ag picked the | ||
2610 | * best currently available. | ||
2611 | * | ||
2612 | * Don't continue looping, since we | ||
2613 | * could loop forever. | ||
2614 | */ | ||
2615 | if (startag == NULLAGNUMBER) | ||
2616 | break; | ||
2617 | |||
2618 | error = xfs_filestream_new_ag(ap, &ag); | ||
2619 | xfs_perag_put(pag); | ||
2620 | if (error) | ||
2621 | return error; | ||
2622 | |||
2623 | /* loop again to set 'blen'*/ | ||
2624 | startag = NULLAGNUMBER; | ||
2625 | pag = xfs_perag_get(mp, ag); | ||
2626 | continue; | ||
2627 | } | ||
2628 | } | ||
2629 | if (++ag == mp->m_sb.sb_agcount) | ||
2630 | ag = 0; | ||
2631 | if (ag == startag) | ||
2632 | break; | ||
2633 | xfs_perag_put(pag); | ||
2634 | pag = xfs_perag_get(mp, ag); | ||
2635 | } | ||
2636 | xfs_perag_put(pag); | ||
2637 | |||
2638 | /* | ||
2639 | * Since the above loop did a BUF_TRYLOCK, it is | ||
2640 | * possible that there is space for this request. | ||
2641 | */ | ||
2642 | if (notinit || *blen < ap->minlen) | ||
2643 | args->minlen = ap->minlen; | ||
2644 | /* | ||
2645 | * If the best seen length is less than the request | ||
2646 | * length, use the best as the minimum. | ||
2647 | */ | ||
2648 | else if (*blen < ap->alen) | ||
2649 | args->minlen = *blen; | ||
2650 | /* | ||
2651 | * Otherwise we've seen an extent as big as alen, | ||
2652 | * use that as the minimum. | ||
2653 | */ | ||
2654 | else | ||
2655 | args->minlen = ap->alen; | ||
2656 | |||
2657 | /* | ||
2658 | * set the failure fallback case to look in the selected | ||
2659 | * AG as the stream may have moved. | ||
2660 | */ | ||
2661 | if (xfs_inode_is_filestream(ap->ip)) | ||
2662 | ap->rval = args->fsbno = XFS_AGB_TO_FSB(mp, ag, 0); | ||
2663 | |||
2664 | return 0; | ||
2665 | } | ||
2666 | |||
2667 | STATIC int | ||
2553 | xfs_bmap_btalloc( | 2668 | xfs_bmap_btalloc( |
2554 | xfs_bmalloca_t *ap) /* bmap alloc argument struct */ | 2669 | xfs_bmalloca_t *ap) /* bmap alloc argument struct */ |
2555 | { | 2670 | { |
2556 | xfs_mount_t *mp; /* mount point structure */ | 2671 | xfs_mount_t *mp; /* mount point structure */ |
2557 | xfs_alloctype_t atype = 0; /* type for allocation routines */ | 2672 | xfs_alloctype_t atype = 0; /* type for allocation routines */ |
2558 | xfs_extlen_t align; /* minimum allocation alignment */ | 2673 | xfs_extlen_t align; /* minimum allocation alignment */ |
2559 | xfs_agnumber_t ag; | ||
2560 | xfs_agnumber_t fb_agno; /* ag number of ap->firstblock */ | 2674 | xfs_agnumber_t fb_agno; /* ag number of ap->firstblock */ |
2561 | xfs_agnumber_t startag; | 2675 | xfs_agnumber_t ag; |
2562 | xfs_alloc_arg_t args; | 2676 | xfs_alloc_arg_t args; |
2563 | xfs_extlen_t blen; | 2677 | xfs_extlen_t blen; |
2564 | xfs_extlen_t nextminlen = 0; | 2678 | xfs_extlen_t nextminlen = 0; |
2565 | xfs_perag_t *pag; | ||
2566 | int nullfb; /* true if ap->firstblock isn't set */ | 2679 | int nullfb; /* true if ap->firstblock isn't set */ |
2567 | int isaligned; | 2680 | int isaligned; |
2568 | int notinit; | ||
2569 | int tryagain; | 2681 | int tryagain; |
2570 | int error; | 2682 | int error; |
2571 | 2683 | ||
@@ -2612,103 +2724,9 @@ xfs_bmap_btalloc( | |||
2612 | args.firstblock = ap->firstblock; | 2724 | args.firstblock = ap->firstblock; |
2613 | blen = 0; | 2725 | blen = 0; |
2614 | if (nullfb) { | 2726 | if (nullfb) { |
2615 | if (ap->userdata && xfs_inode_is_filestream(ap->ip)) | 2727 | error = xfs_bmap_btalloc_nullfb(ap, &args, &blen); |
2616 | args.type = XFS_ALLOCTYPE_NEAR_BNO; | 2728 | if (error) |
2617 | else | 2729 | return error; |
2618 | args.type = XFS_ALLOCTYPE_START_BNO; | ||
2619 | args.total = ap->total; | ||
2620 | |||
2621 | /* | ||
2622 | * Search for an allocation group with a single extent | ||
2623 | * large enough for the request. | ||
2624 | * | ||
2625 | * If one isn't found, then adjust the minimum allocation | ||
2626 | * size to the largest space found. | ||
2627 | */ | ||
2628 | startag = ag = XFS_FSB_TO_AGNO(mp, args.fsbno); | ||
2629 | if (startag == NULLAGNUMBER) | ||
2630 | startag = ag = 0; | ||
2631 | notinit = 0; | ||
2632 | pag = xfs_perag_get(mp, ag); | ||
2633 | while (blen < ap->alen) { | ||
2634 | if (!pag->pagf_init && | ||
2635 | (error = xfs_alloc_pagf_init(mp, args.tp, | ||
2636 | ag, XFS_ALLOC_FLAG_TRYLOCK))) { | ||
2637 | xfs_perag_put(pag); | ||
2638 | return error; | ||
2639 | } | ||
2640 | /* | ||
2641 | * See xfs_alloc_fix_freelist... | ||
2642 | */ | ||
2643 | if (pag->pagf_init) { | ||
2644 | xfs_extlen_t longest; | ||
2645 | longest = xfs_alloc_longest_free_extent(mp, pag); | ||
2646 | if (blen < longest) | ||
2647 | blen = longest; | ||
2648 | } else | ||
2649 | notinit = 1; | ||
2650 | |||
2651 | if (xfs_inode_is_filestream(ap->ip)) { | ||
2652 | if (blen >= ap->alen) | ||
2653 | break; | ||
2654 | |||
2655 | if (ap->userdata) { | ||
2656 | /* | ||
2657 | * If startag is an invalid AG, we've | ||
2658 | * come here once before and | ||
2659 | * xfs_filestream_new_ag picked the | ||
2660 | * best currently available. | ||
2661 | * | ||
2662 | * Don't continue looping, since we | ||
2663 | * could loop forever. | ||
2664 | */ | ||
2665 | if (startag == NULLAGNUMBER) | ||
2666 | break; | ||
2667 | |||
2668 | error = xfs_filestream_new_ag(ap, &ag); | ||
2669 | xfs_perag_put(pag); | ||
2670 | if (error) | ||
2671 | return error; | ||
2672 | |||
2673 | /* loop again to set 'blen'*/ | ||
2674 | startag = NULLAGNUMBER; | ||
2675 | pag = xfs_perag_get(mp, ag); | ||
2676 | continue; | ||
2677 | } | ||
2678 | } | ||
2679 | if (++ag == mp->m_sb.sb_agcount) | ||
2680 | ag = 0; | ||
2681 | if (ag == startag) | ||
2682 | break; | ||
2683 | xfs_perag_put(pag); | ||
2684 | pag = xfs_perag_get(mp, ag); | ||
2685 | } | ||
2686 | xfs_perag_put(pag); | ||
2687 | /* | ||
2688 | * Since the above loop did a BUF_TRYLOCK, it is | ||
2689 | * possible that there is space for this request. | ||
2690 | */ | ||
2691 | if (notinit || blen < ap->minlen) | ||
2692 | args.minlen = ap->minlen; | ||
2693 | /* | ||
2694 | * If the best seen length is less than the request | ||
2695 | * length, use the best as the minimum. | ||
2696 | */ | ||
2697 | else if (blen < ap->alen) | ||
2698 | args.minlen = blen; | ||
2699 | /* | ||
2700 | * Otherwise we've seen an extent as big as alen, | ||
2701 | * use that as the minimum. | ||
2702 | */ | ||
2703 | else | ||
2704 | args.minlen = ap->alen; | ||
2705 | |||
2706 | /* | ||
2707 | * set the failure fallback case to look in the selected | ||
2708 | * AG as the stream may have moved. | ||
2709 | */ | ||
2710 | if (xfs_inode_is_filestream(ap->ip)) | ||
2711 | ap->rval = args.fsbno = XFS_AGB_TO_FSB(mp, ag, 0); | ||
2712 | } else if (ap->low) { | 2730 | } else if (ap->low) { |
2713 | if (xfs_inode_is_filestream(ap->ip)) | 2731 | if (xfs_inode_is_filestream(ap->ip)) |
2714 | args.type = XFS_ALLOCTYPE_FIRST_AG; | 2732 | args.type = XFS_ALLOCTYPE_FIRST_AG; |
diff --git a/fs/xfs/xfs_fs.h b/fs/xfs/xfs_fs.h index f52ac276277e..7cf7220e7d5f 100644 --- a/fs/xfs/xfs_fs.h +++ b/fs/xfs/xfs_fs.h | |||
@@ -292,7 +292,8 @@ typedef struct xfs_bstat { | |||
292 | __s32 bs_extents; /* number of extents */ | 292 | __s32 bs_extents; /* number of extents */ |
293 | __u32 bs_gen; /* generation count */ | 293 | __u32 bs_gen; /* generation count */ |
294 | __u16 bs_projid; /* project id */ | 294 | __u16 bs_projid; /* project id */ |
295 | unsigned char bs_pad[14]; /* pad space, unused */ | 295 | __u16 bs_forkoff; /* inode fork offset in bytes */ |
296 | unsigned char bs_pad[12]; /* pad space, unused */ | ||
296 | __u32 bs_dmevmask; /* DMIG event mask */ | 297 | __u32 bs_dmevmask; /* DMIG event mask */ |
297 | __u16 bs_dmstate; /* DMIG state info */ | 298 | __u16 bs_dmstate; /* DMIG state info */ |
298 | __u16 bs_aextents; /* attribute number of extents */ | 299 | __u16 bs_aextents; /* attribute number of extents */ |
diff --git a/fs/xfs/xfs_iget.c b/fs/xfs/xfs_iget.c index e281eb4a1c49..6845db90818f 100644 --- a/fs/xfs/xfs_iget.c +++ b/fs/xfs/xfs_iget.c | |||
@@ -190,13 +190,12 @@ xfs_iget_cache_hit( | |||
190 | trace_xfs_iget_reclaim(ip); | 190 | trace_xfs_iget_reclaim(ip); |
191 | 191 | ||
192 | /* | 192 | /* |
193 | * We need to set XFS_INEW atomically with clearing the | 193 | * We need to set XFS_IRECLAIM to prevent xfs_reclaim_inode |
194 | * reclaimable tag so that we do have an indicator of the | 194 | * from stomping over us while we recycle the inode. We can't |
195 | * inode still being initialized. | 195 | * clear the radix tree reclaimable tag yet as it requires |
196 | * pag_ici_lock to be held exclusive. | ||
196 | */ | 197 | */ |
197 | ip->i_flags |= XFS_INEW; | 198 | ip->i_flags |= XFS_IRECLAIM; |
198 | ip->i_flags &= ~XFS_IRECLAIMABLE; | ||
199 | __xfs_inode_clear_reclaim_tag(mp, pag, ip); | ||
200 | 199 | ||
201 | spin_unlock(&ip->i_flags_lock); | 200 | spin_unlock(&ip->i_flags_lock); |
202 | read_unlock(&pag->pag_ici_lock); | 201 | read_unlock(&pag->pag_ici_lock); |
@@ -216,7 +215,15 @@ xfs_iget_cache_hit( | |||
216 | trace_xfs_iget_reclaim(ip); | 215 | trace_xfs_iget_reclaim(ip); |
217 | goto out_error; | 216 | goto out_error; |
218 | } | 217 | } |
218 | |||
219 | write_lock(&pag->pag_ici_lock); | ||
220 | spin_lock(&ip->i_flags_lock); | ||
221 | ip->i_flags &= ~(XFS_IRECLAIMABLE | XFS_IRECLAIM); | ||
222 | ip->i_flags |= XFS_INEW; | ||
223 | __xfs_inode_clear_reclaim_tag(mp, pag, ip); | ||
219 | inode->i_state = I_NEW; | 224 | inode->i_state = I_NEW; |
225 | spin_unlock(&ip->i_flags_lock); | ||
226 | write_unlock(&pag->pag_ici_lock); | ||
220 | } else { | 227 | } else { |
221 | /* If the VFS inode is being torn down, pause and try again. */ | 228 | /* If the VFS inode is being torn down, pause and try again. */ |
222 | if (!igrab(inode)) { | 229 | if (!igrab(inode)) { |
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c index fa31360046d4..0ffd56447045 100644 --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c | |||
@@ -2439,75 +2439,31 @@ xfs_idestroy_fork( | |||
2439 | } | 2439 | } |
2440 | 2440 | ||
2441 | /* | 2441 | /* |
2442 | * Increment the pin count of the given buffer. | 2442 | * This is called to unpin an inode. The caller must have the inode locked |
2443 | * This value is protected by ipinlock spinlock in the mount structure. | 2443 | * in at least shared mode so that the buffer cannot be subsequently pinned |
2444 | * once someone is waiting for it to be unpinned. | ||
2444 | */ | 2445 | */ |
2445 | void | 2446 | static void |
2446 | xfs_ipin( | 2447 | xfs_iunpin_nowait( |
2447 | xfs_inode_t *ip) | 2448 | struct xfs_inode *ip) |
2448 | { | ||
2449 | ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL)); | ||
2450 | |||
2451 | atomic_inc(&ip->i_pincount); | ||
2452 | } | ||
2453 | |||
2454 | /* | ||
2455 | * Decrement the pin count of the given inode, and wake up | ||
2456 | * anyone in xfs_iwait_unpin() if the count goes to 0. The | ||
2457 | * inode must have been previously pinned with a call to xfs_ipin(). | ||
2458 | */ | ||
2459 | void | ||
2460 | xfs_iunpin( | ||
2461 | xfs_inode_t *ip) | ||
2462 | { | ||
2463 | ASSERT(atomic_read(&ip->i_pincount) > 0); | ||
2464 | |||
2465 | if (atomic_dec_and_test(&ip->i_pincount)) | ||
2466 | wake_up(&ip->i_ipin_wait); | ||
2467 | } | ||
2468 | |||
2469 | /* | ||
2470 | * This is called to unpin an inode. It can be directed to wait or to return | ||
2471 | * immediately without waiting for the inode to be unpinned. The caller must | ||
2472 | * have the inode locked in at least shared mode so that the buffer cannot be | ||
2473 | * subsequently pinned once someone is waiting for it to be unpinned. | ||
2474 | */ | ||
2475 | STATIC void | ||
2476 | __xfs_iunpin_wait( | ||
2477 | xfs_inode_t *ip, | ||
2478 | int wait) | ||
2479 | { | 2449 | { |
2480 | xfs_inode_log_item_t *iip = ip->i_itemp; | ||
2481 | |||
2482 | ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL|XFS_ILOCK_SHARED)); | 2450 | ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL|XFS_ILOCK_SHARED)); |
2483 | if (atomic_read(&ip->i_pincount) == 0) | ||
2484 | return; | ||
2485 | 2451 | ||
2486 | /* Give the log a push to start the unpinning I/O */ | 2452 | /* Give the log a push to start the unpinning I/O */ |
2487 | if (iip && iip->ili_last_lsn) | 2453 | xfs_log_force_lsn(ip->i_mount, ip->i_itemp->ili_last_lsn, 0); |
2488 | xfs_log_force_lsn(ip->i_mount, iip->ili_last_lsn, 0); | ||
2489 | else | ||
2490 | xfs_log_force(ip->i_mount, 0); | ||
2491 | 2454 | ||
2492 | if (wait) | ||
2493 | wait_event(ip->i_ipin_wait, (atomic_read(&ip->i_pincount) == 0)); | ||
2494 | } | 2455 | } |
2495 | 2456 | ||
2496 | void | 2457 | void |
2497 | xfs_iunpin_wait( | 2458 | xfs_iunpin_wait( |
2498 | xfs_inode_t *ip) | 2459 | struct xfs_inode *ip) |
2499 | { | 2460 | { |
2500 | __xfs_iunpin_wait(ip, 1); | 2461 | if (xfs_ipincount(ip)) { |
2501 | } | 2462 | xfs_iunpin_nowait(ip); |
2502 | 2463 | wait_event(ip->i_ipin_wait, (xfs_ipincount(ip) == 0)); | |
2503 | static inline void | 2464 | } |
2504 | xfs_iunpin_nowait( | ||
2505 | xfs_inode_t *ip) | ||
2506 | { | ||
2507 | __xfs_iunpin_wait(ip, 0); | ||
2508 | } | 2465 | } |
2509 | 2466 | ||
2510 | |||
2511 | /* | 2467 | /* |
2512 | * xfs_iextents_copy() | 2468 | * xfs_iextents_copy() |
2513 | * | 2469 | * |
diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h index 6c912b027596..9965e40a4615 100644 --- a/fs/xfs/xfs_inode.h +++ b/fs/xfs/xfs_inode.h | |||
@@ -471,8 +471,6 @@ int xfs_itruncate_finish(struct xfs_trans **, xfs_inode_t *, | |||
471 | int xfs_iunlink(struct xfs_trans *, xfs_inode_t *); | 471 | int xfs_iunlink(struct xfs_trans *, xfs_inode_t *); |
472 | 472 | ||
473 | void xfs_iext_realloc(xfs_inode_t *, int, int); | 473 | void xfs_iext_realloc(xfs_inode_t *, int, int); |
474 | void xfs_ipin(xfs_inode_t *); | ||
475 | void xfs_iunpin(xfs_inode_t *); | ||
476 | void xfs_iunpin_wait(xfs_inode_t *); | 474 | void xfs_iunpin_wait(xfs_inode_t *); |
477 | int xfs_iflush(xfs_inode_t *, uint); | 475 | int xfs_iflush(xfs_inode_t *, uint); |
478 | void xfs_ichgtime(xfs_inode_t *, int); | 476 | void xfs_ichgtime(xfs_inode_t *, int); |
@@ -480,6 +478,7 @@ void xfs_lock_inodes(xfs_inode_t **, int, uint); | |||
480 | void xfs_lock_two_inodes(xfs_inode_t *, xfs_inode_t *, uint); | 478 | void xfs_lock_two_inodes(xfs_inode_t *, xfs_inode_t *, uint); |
481 | 479 | ||
482 | void xfs_synchronize_times(xfs_inode_t *); | 480 | void xfs_synchronize_times(xfs_inode_t *); |
481 | void xfs_mark_inode_dirty(xfs_inode_t *); | ||
483 | void xfs_mark_inode_dirty_sync(xfs_inode_t *); | 482 | void xfs_mark_inode_dirty_sync(xfs_inode_t *); |
484 | 483 | ||
485 | #define IHOLD(ip) \ | 484 | #define IHOLD(ip) \ |
diff --git a/fs/xfs/xfs_inode_item.c b/fs/xfs/xfs_inode_item.c index d4dc063111f8..7bfea8540159 100644 --- a/fs/xfs/xfs_inode_item.c +++ b/fs/xfs/xfs_inode_item.c | |||
@@ -535,23 +535,23 @@ xfs_inode_item_format( | |||
535 | 535 | ||
536 | /* | 536 | /* |
537 | * This is called to pin the inode associated with the inode log | 537 | * This is called to pin the inode associated with the inode log |
538 | * item in memory so it cannot be written out. Do this by calling | 538 | * item in memory so it cannot be written out. |
539 | * xfs_ipin() to bump the pin count in the inode while holding the | ||
540 | * inode pin lock. | ||
541 | */ | 539 | */ |
542 | STATIC void | 540 | STATIC void |
543 | xfs_inode_item_pin( | 541 | xfs_inode_item_pin( |
544 | xfs_inode_log_item_t *iip) | 542 | xfs_inode_log_item_t *iip) |
545 | { | 543 | { |
546 | ASSERT(xfs_isilocked(iip->ili_inode, XFS_ILOCK_EXCL)); | 544 | ASSERT(xfs_isilocked(iip->ili_inode, XFS_ILOCK_EXCL)); |
547 | xfs_ipin(iip->ili_inode); | 545 | |
546 | atomic_inc(&iip->ili_inode->i_pincount); | ||
548 | } | 547 | } |
549 | 548 | ||
550 | 549 | ||
551 | /* | 550 | /* |
552 | * This is called to unpin the inode associated with the inode log | 551 | * This is called to unpin the inode associated with the inode log |
553 | * item which was previously pinned with a call to xfs_inode_item_pin(). | 552 | * item which was previously pinned with a call to xfs_inode_item_pin(). |
554 | * Just call xfs_iunpin() on the inode to do this. | 553 | * |
554 | * Also wake up anyone in xfs_iunpin_wait() if the count goes to 0. | ||
555 | */ | 555 | */ |
556 | /* ARGSUSED */ | 556 | /* ARGSUSED */ |
557 | STATIC void | 557 | STATIC void |
@@ -559,7 +559,11 @@ xfs_inode_item_unpin( | |||
559 | xfs_inode_log_item_t *iip, | 559 | xfs_inode_log_item_t *iip, |
560 | int stale) | 560 | int stale) |
561 | { | 561 | { |
562 | xfs_iunpin(iip->ili_inode); | 562 | struct xfs_inode *ip = iip->ili_inode; |
563 | |||
564 | ASSERT(atomic_read(&ip->i_pincount) > 0); | ||
565 | if (atomic_dec_and_test(&ip->i_pincount)) | ||
566 | wake_up(&ip->i_ipin_wait); | ||
563 | } | 567 | } |
564 | 568 | ||
565 | /* ARGSUSED */ | 569 | /* ARGSUSED */ |
@@ -568,7 +572,7 @@ xfs_inode_item_unpin_remove( | |||
568 | xfs_inode_log_item_t *iip, | 572 | xfs_inode_log_item_t *iip, |
569 | xfs_trans_t *tp) | 573 | xfs_trans_t *tp) |
570 | { | 574 | { |
571 | xfs_iunpin(iip->ili_inode); | 575 | xfs_inode_item_unpin(iip, 0); |
572 | } | 576 | } |
573 | 577 | ||
574 | /* | 578 | /* |
diff --git a/fs/xfs/xfs_itable.c b/fs/xfs/xfs_itable.c index 3af02314c605..b1b801e4a28e 100644 --- a/fs/xfs/xfs_itable.c +++ b/fs/xfs/xfs_itable.c | |||
@@ -106,6 +106,7 @@ xfs_bulkstat_one_iget( | |||
106 | buf->bs_dmevmask = dic->di_dmevmask; | 106 | buf->bs_dmevmask = dic->di_dmevmask; |
107 | buf->bs_dmstate = dic->di_dmstate; | 107 | buf->bs_dmstate = dic->di_dmstate; |
108 | buf->bs_aextents = dic->di_anextents; | 108 | buf->bs_aextents = dic->di_anextents; |
109 | buf->bs_forkoff = XFS_IFORK_BOFF(ip); | ||
109 | 110 | ||
110 | switch (dic->di_format) { | 111 | switch (dic->di_format) { |
111 | case XFS_DINODE_FMT_DEV: | 112 | case XFS_DINODE_FMT_DEV: |
@@ -176,6 +177,7 @@ xfs_bulkstat_one_dinode( | |||
176 | buf->bs_dmevmask = be32_to_cpu(dic->di_dmevmask); | 177 | buf->bs_dmevmask = be32_to_cpu(dic->di_dmevmask); |
177 | buf->bs_dmstate = be16_to_cpu(dic->di_dmstate); | 178 | buf->bs_dmstate = be16_to_cpu(dic->di_dmstate); |
178 | buf->bs_aextents = be16_to_cpu(dic->di_anextents); | 179 | buf->bs_aextents = be16_to_cpu(dic->di_anextents); |
180 | buf->bs_forkoff = XFS_DFORK_BOFF(dic); | ||
179 | 181 | ||
180 | switch (dic->di_format) { | 182 | switch (dic->di_format) { |
181 | case XFS_DINODE_FMT_DEV: | 183 | case XFS_DINODE_FMT_DEV: |
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index 4f16be4b6ee5..e8fba92d7cd9 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c | |||
@@ -60,7 +60,7 @@ STATIC int xlog_space_left(xlog_t *log, int cycle, int bytes); | |||
60 | STATIC int xlog_sync(xlog_t *log, xlog_in_core_t *iclog); | 60 | STATIC int xlog_sync(xlog_t *log, xlog_in_core_t *iclog); |
61 | STATIC void xlog_dealloc_log(xlog_t *log); | 61 | STATIC void xlog_dealloc_log(xlog_t *log); |
62 | STATIC int xlog_write(xfs_mount_t *mp, xfs_log_iovec_t region[], | 62 | STATIC int xlog_write(xfs_mount_t *mp, xfs_log_iovec_t region[], |
63 | int nentries, xfs_log_ticket_t tic, | 63 | int nentries, struct xlog_ticket *tic, |
64 | xfs_lsn_t *start_lsn, | 64 | xfs_lsn_t *start_lsn, |
65 | xlog_in_core_t **commit_iclog, | 65 | xlog_in_core_t **commit_iclog, |
66 | uint flags); | 66 | uint flags); |
@@ -243,14 +243,14 @@ xlog_tic_add_region(xlog_ticket_t *tic, uint len, uint type) | |||
243 | * out when the next write occurs. | 243 | * out when the next write occurs. |
244 | */ | 244 | */ |
245 | xfs_lsn_t | 245 | xfs_lsn_t |
246 | xfs_log_done(xfs_mount_t *mp, | 246 | xfs_log_done( |
247 | xfs_log_ticket_t xtic, | 247 | struct xfs_mount *mp, |
248 | void **iclog, | 248 | struct xlog_ticket *ticket, |
249 | uint flags) | 249 | struct xlog_in_core **iclog, |
250 | uint flags) | ||
250 | { | 251 | { |
251 | xlog_t *log = mp->m_log; | 252 | struct log *log = mp->m_log; |
252 | xlog_ticket_t *ticket = (xfs_log_ticket_t) xtic; | 253 | xfs_lsn_t lsn = 0; |
253 | xfs_lsn_t lsn = 0; | ||
254 | 254 | ||
255 | if (XLOG_FORCED_SHUTDOWN(log) || | 255 | if (XLOG_FORCED_SHUTDOWN(log) || |
256 | /* | 256 | /* |
@@ -258,8 +258,7 @@ xfs_log_done(xfs_mount_t *mp, | |||
258 | * If we get an error, just continue and give back the log ticket. | 258 | * If we get an error, just continue and give back the log ticket. |
259 | */ | 259 | */ |
260 | (((ticket->t_flags & XLOG_TIC_INITED) == 0) && | 260 | (((ticket->t_flags & XLOG_TIC_INITED) == 0) && |
261 | (xlog_commit_record(mp, ticket, | 261 | (xlog_commit_record(mp, ticket, iclog, &lsn)))) { |
262 | (xlog_in_core_t **)iclog, &lsn)))) { | ||
263 | lsn = (xfs_lsn_t) -1; | 262 | lsn = (xfs_lsn_t) -1; |
264 | if (ticket->t_flags & XLOG_TIC_PERM_RESERV) { | 263 | if (ticket->t_flags & XLOG_TIC_PERM_RESERV) { |
265 | flags |= XFS_LOG_REL_PERM_RESERV; | 264 | flags |= XFS_LOG_REL_PERM_RESERV; |
@@ -289,7 +288,7 @@ xfs_log_done(xfs_mount_t *mp, | |||
289 | } | 288 | } |
290 | 289 | ||
291 | return lsn; | 290 | return lsn; |
292 | } /* xfs_log_done */ | 291 | } |
293 | 292 | ||
294 | /* | 293 | /* |
295 | * Attaches a new iclog I/O completion callback routine during | 294 | * Attaches a new iclog I/O completion callback routine during |
@@ -298,11 +297,11 @@ xfs_log_done(xfs_mount_t *mp, | |||
298 | * executing the callback at an appropriate time. | 297 | * executing the callback at an appropriate time. |
299 | */ | 298 | */ |
300 | int | 299 | int |
301 | xfs_log_notify(xfs_mount_t *mp, /* mount of partition */ | 300 | xfs_log_notify( |
302 | void *iclog_hndl, /* iclog to hang callback off */ | 301 | struct xfs_mount *mp, |
303 | xfs_log_callback_t *cb) | 302 | struct xlog_in_core *iclog, |
303 | xfs_log_callback_t *cb) | ||
304 | { | 304 | { |
305 | xlog_in_core_t *iclog = (xlog_in_core_t *)iclog_hndl; | ||
306 | int abortflg; | 305 | int abortflg; |
307 | 306 | ||
308 | spin_lock(&iclog->ic_callback_lock); | 307 | spin_lock(&iclog->ic_callback_lock); |
@@ -316,16 +315,14 @@ xfs_log_notify(xfs_mount_t *mp, /* mount of partition */ | |||
316 | } | 315 | } |
317 | spin_unlock(&iclog->ic_callback_lock); | 316 | spin_unlock(&iclog->ic_callback_lock); |
318 | return abortflg; | 317 | return abortflg; |
319 | } /* xfs_log_notify */ | 318 | } |
320 | 319 | ||
321 | int | 320 | int |
322 | xfs_log_release_iclog(xfs_mount_t *mp, | 321 | xfs_log_release_iclog( |
323 | void *iclog_hndl) | 322 | struct xfs_mount *mp, |
323 | struct xlog_in_core *iclog) | ||
324 | { | 324 | { |
325 | xlog_t *log = mp->m_log; | 325 | if (xlog_state_release_iclog(mp->m_log, iclog)) { |
326 | xlog_in_core_t *iclog = (xlog_in_core_t *)iclog_hndl; | ||
327 | |||
328 | if (xlog_state_release_iclog(log, iclog)) { | ||
329 | xfs_force_shutdown(mp, SHUTDOWN_LOG_IO_ERROR); | 326 | xfs_force_shutdown(mp, SHUTDOWN_LOG_IO_ERROR); |
330 | return EIO; | 327 | return EIO; |
331 | } | 328 | } |
@@ -344,17 +341,18 @@ xfs_log_release_iclog(xfs_mount_t *mp, | |||
344 | * reservation, we prevent over allocation problems. | 341 | * reservation, we prevent over allocation problems. |
345 | */ | 342 | */ |
346 | int | 343 | int |
347 | xfs_log_reserve(xfs_mount_t *mp, | 344 | xfs_log_reserve( |
348 | int unit_bytes, | 345 | struct xfs_mount *mp, |
349 | int cnt, | 346 | int unit_bytes, |
350 | xfs_log_ticket_t *ticket, | 347 | int cnt, |
351 | __uint8_t client, | 348 | struct xlog_ticket **ticket, |
352 | uint flags, | 349 | __uint8_t client, |
353 | uint t_type) | 350 | uint flags, |
351 | uint t_type) | ||
354 | { | 352 | { |
355 | xlog_t *log = mp->m_log; | 353 | struct log *log = mp->m_log; |
356 | xlog_ticket_t *internal_ticket; | 354 | struct xlog_ticket *internal_ticket; |
357 | int retval = 0; | 355 | int retval = 0; |
358 | 356 | ||
359 | ASSERT(client == XFS_TRANSACTION || client == XFS_LOG); | 357 | ASSERT(client == XFS_TRANSACTION || client == XFS_LOG); |
360 | ASSERT((flags & XFS_LOG_NOSLEEP) == 0); | 358 | ASSERT((flags & XFS_LOG_NOSLEEP) == 0); |
@@ -367,7 +365,7 @@ xfs_log_reserve(xfs_mount_t *mp, | |||
367 | 365 | ||
368 | if (*ticket != NULL) { | 366 | if (*ticket != NULL) { |
369 | ASSERT(flags & XFS_LOG_PERM_RESERV); | 367 | ASSERT(flags & XFS_LOG_PERM_RESERV); |
370 | internal_ticket = (xlog_ticket_t *)*ticket; | 368 | internal_ticket = *ticket; |
371 | 369 | ||
372 | trace_xfs_log_reserve(log, internal_ticket); | 370 | trace_xfs_log_reserve(log, internal_ticket); |
373 | 371 | ||
@@ -519,7 +517,7 @@ xfs_log_unmount_write(xfs_mount_t *mp) | |||
519 | xlog_in_core_t *first_iclog; | 517 | xlog_in_core_t *first_iclog; |
520 | #endif | 518 | #endif |
521 | xfs_log_iovec_t reg[1]; | 519 | xfs_log_iovec_t reg[1]; |
522 | xfs_log_ticket_t tic = NULL; | 520 | xlog_ticket_t *tic = NULL; |
523 | xfs_lsn_t lsn; | 521 | xfs_lsn_t lsn; |
524 | int error; | 522 | int error; |
525 | 523 | ||
@@ -656,24 +654,24 @@ xfs_log_unmount(xfs_mount_t *mp) | |||
656 | * transaction occur with one call to xfs_log_write(). | 654 | * transaction occur with one call to xfs_log_write(). |
657 | */ | 655 | */ |
658 | int | 656 | int |
659 | xfs_log_write(xfs_mount_t * mp, | 657 | xfs_log_write( |
660 | xfs_log_iovec_t reg[], | 658 | struct xfs_mount *mp, |
661 | int nentries, | 659 | struct xfs_log_iovec reg[], |
662 | xfs_log_ticket_t tic, | 660 | int nentries, |
663 | xfs_lsn_t *start_lsn) | 661 | struct xlog_ticket *tic, |
662 | xfs_lsn_t *start_lsn) | ||
664 | { | 663 | { |
665 | int error; | 664 | struct log *log = mp->m_log; |
666 | xlog_t *log = mp->m_log; | 665 | int error; |
667 | 666 | ||
668 | if (XLOG_FORCED_SHUTDOWN(log)) | 667 | if (XLOG_FORCED_SHUTDOWN(log)) |
669 | return XFS_ERROR(EIO); | 668 | return XFS_ERROR(EIO); |
670 | 669 | ||
671 | if ((error = xlog_write(mp, reg, nentries, tic, start_lsn, NULL, 0))) { | 670 | error = xlog_write(mp, reg, nentries, tic, start_lsn, NULL, 0); |
671 | if (error) | ||
672 | xfs_force_shutdown(mp, SHUTDOWN_LOG_IO_ERROR); | 672 | xfs_force_shutdown(mp, SHUTDOWN_LOG_IO_ERROR); |
673 | } | ||
674 | return error; | 673 | return error; |
675 | } /* xfs_log_write */ | 674 | } |
676 | |||
677 | 675 | ||
678 | void | 676 | void |
679 | xfs_log_move_tail(xfs_mount_t *mp, | 677 | xfs_log_move_tail(xfs_mount_t *mp, |
@@ -1642,16 +1640,16 @@ xlog_print_tic_res(xfs_mount_t *mp, xlog_ticket_t *ticket) | |||
1642 | * bytes have been written out. | 1640 | * bytes have been written out. |
1643 | */ | 1641 | */ |
1644 | STATIC int | 1642 | STATIC int |
1645 | xlog_write(xfs_mount_t * mp, | 1643 | xlog_write( |
1646 | xfs_log_iovec_t reg[], | 1644 | struct xfs_mount *mp, |
1647 | int nentries, | 1645 | struct xfs_log_iovec reg[], |
1648 | xfs_log_ticket_t tic, | 1646 | int nentries, |
1649 | xfs_lsn_t *start_lsn, | 1647 | struct xlog_ticket *ticket, |
1650 | xlog_in_core_t **commit_iclog, | 1648 | xfs_lsn_t *start_lsn, |
1651 | uint flags) | 1649 | struct xlog_in_core **commit_iclog, |
1650 | uint flags) | ||
1652 | { | 1651 | { |
1653 | xlog_t *log = mp->m_log; | 1652 | xlog_t *log = mp->m_log; |
1654 | xlog_ticket_t *ticket = (xlog_ticket_t *)tic; | ||
1655 | xlog_in_core_t *iclog = NULL; /* ptr to current in-core log */ | 1653 | xlog_in_core_t *iclog = NULL; /* ptr to current in-core log */ |
1656 | xlog_op_header_t *logop_head; /* ptr to log operation header */ | 1654 | xlog_op_header_t *logop_head; /* ptr to log operation header */ |
1657 | __psint_t ptr; /* copy address into data region */ | 1655 | __psint_t ptr; /* copy address into data region */ |
@@ -1765,7 +1763,7 @@ xlog_write(xfs_mount_t * mp, | |||
1765 | default: | 1763 | default: |
1766 | xfs_fs_cmn_err(CE_WARN, mp, | 1764 | xfs_fs_cmn_err(CE_WARN, mp, |
1767 | "Bad XFS transaction clientid 0x%x in ticket 0x%p", | 1765 | "Bad XFS transaction clientid 0x%x in ticket 0x%p", |
1768 | logop_head->oh_clientid, tic); | 1766 | logop_head->oh_clientid, ticket); |
1769 | return XFS_ERROR(EIO); | 1767 | return XFS_ERROR(EIO); |
1770 | } | 1768 | } |
1771 | 1769 | ||
diff --git a/fs/xfs/xfs_log.h b/fs/xfs/xfs_log.h index 7074be9d13e9..97a24c7795a4 100644 --- a/fs/xfs/xfs_log.h +++ b/fs/xfs/xfs_log.h | |||
@@ -110,8 +110,6 @@ typedef struct xfs_log_iovec { | |||
110 | uint i_type; /* type of region */ | 110 | uint i_type; /* type of region */ |
111 | } xfs_log_iovec_t; | 111 | } xfs_log_iovec_t; |
112 | 112 | ||
113 | typedef void* xfs_log_ticket_t; | ||
114 | |||
115 | /* | 113 | /* |
116 | * Structure used to pass callback function and the function's argument | 114 | * Structure used to pass callback function and the function's argument |
117 | * to the log manager. | 115 | * to the log manager. |
@@ -126,10 +124,12 @@ typedef struct xfs_log_callback { | |||
126 | #ifdef __KERNEL__ | 124 | #ifdef __KERNEL__ |
127 | /* Log manager interfaces */ | 125 | /* Log manager interfaces */ |
128 | struct xfs_mount; | 126 | struct xfs_mount; |
127 | struct xlog_in_core; | ||
129 | struct xlog_ticket; | 128 | struct xlog_ticket; |
129 | |||
130 | xfs_lsn_t xfs_log_done(struct xfs_mount *mp, | 130 | xfs_lsn_t xfs_log_done(struct xfs_mount *mp, |
131 | xfs_log_ticket_t ticket, | 131 | struct xlog_ticket *ticket, |
132 | void **iclog, | 132 | struct xlog_in_core **iclog, |
133 | uint flags); | 133 | uint flags); |
134 | int _xfs_log_force(struct xfs_mount *mp, | 134 | int _xfs_log_force(struct xfs_mount *mp, |
135 | uint flags, | 135 | uint flags, |
@@ -151,21 +151,21 @@ int xfs_log_mount_finish(struct xfs_mount *mp); | |||
151 | void xfs_log_move_tail(struct xfs_mount *mp, | 151 | void xfs_log_move_tail(struct xfs_mount *mp, |
152 | xfs_lsn_t tail_lsn); | 152 | xfs_lsn_t tail_lsn); |
153 | int xfs_log_notify(struct xfs_mount *mp, | 153 | int xfs_log_notify(struct xfs_mount *mp, |
154 | void *iclog, | 154 | struct xlog_in_core *iclog, |
155 | xfs_log_callback_t *callback_entry); | 155 | xfs_log_callback_t *callback_entry); |
156 | int xfs_log_release_iclog(struct xfs_mount *mp, | 156 | int xfs_log_release_iclog(struct xfs_mount *mp, |
157 | void *iclog_hndl); | 157 | struct xlog_in_core *iclog); |
158 | int xfs_log_reserve(struct xfs_mount *mp, | 158 | int xfs_log_reserve(struct xfs_mount *mp, |
159 | int length, | 159 | int length, |
160 | int count, | 160 | int count, |
161 | xfs_log_ticket_t *ticket, | 161 | struct xlog_ticket **ticket, |
162 | __uint8_t clientid, | 162 | __uint8_t clientid, |
163 | uint flags, | 163 | uint flags, |
164 | uint t_type); | 164 | uint t_type); |
165 | int xfs_log_write(struct xfs_mount *mp, | 165 | int xfs_log_write(struct xfs_mount *mp, |
166 | xfs_log_iovec_t region[], | 166 | xfs_log_iovec_t region[], |
167 | int nentries, | 167 | int nentries, |
168 | xfs_log_ticket_t ticket, | 168 | struct xlog_ticket *ticket, |
169 | xfs_lsn_t *start_lsn); | 169 | xfs_lsn_t *start_lsn); |
170 | int xfs_log_unmount_write(struct xfs_mount *mp); | 170 | int xfs_log_unmount_write(struct xfs_mount *mp); |
171 | void xfs_log_unmount(struct xfs_mount *mp); | 171 | void xfs_log_unmount(struct xfs_mount *mp); |
diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index 6afaaeb2950a..e79b56b4bca6 100644 --- a/fs/xfs/xfs_mount.c +++ b/fs/xfs/xfs_mount.c | |||
@@ -1097,13 +1097,15 @@ xfs_default_resblks(xfs_mount_t *mp) | |||
1097 | __uint64_t resblks; | 1097 | __uint64_t resblks; |
1098 | 1098 | ||
1099 | /* | 1099 | /* |
1100 | * We default to 5% or 1024 fsbs of space reserved, whichever is smaller. | 1100 | * We default to 5% or 8192 fsbs of space reserved, whichever is |
1101 | * This may drive us straight to ENOSPC on mount, but that implies | 1101 | * smaller. This is intended to cover concurrent allocation |
1102 | * we were already there on the last unmount. Warn if this occurs. | 1102 | * transactions when we initially hit enospc. These each require a 4 |
1103 | * block reservation. Hence by default we cover roughly 2000 concurrent | ||
1104 | * allocation reservations. | ||
1103 | */ | 1105 | */ |
1104 | resblks = mp->m_sb.sb_dblocks; | 1106 | resblks = mp->m_sb.sb_dblocks; |
1105 | do_div(resblks, 20); | 1107 | do_div(resblks, 20); |
1106 | resblks = min_t(__uint64_t, resblks, 1024); | 1108 | resblks = min_t(__uint64_t, resblks, 8192); |
1107 | return resblks; | 1109 | return resblks; |
1108 | } | 1110 | } |
1109 | 1111 | ||
@@ -1417,6 +1419,9 @@ xfs_mountfs( | |||
1417 | * when at ENOSPC. This is needed for operations like create with | 1419 | * when at ENOSPC. This is needed for operations like create with |
1418 | * attr, unwritten extent conversion at ENOSPC, etc. Data allocations | 1420 | * attr, unwritten extent conversion at ENOSPC, etc. Data allocations |
1419 | * are not allowed to use this reserved space. | 1421 | * are not allowed to use this reserved space. |
1422 | * | ||
1423 | * This may drive us straight to ENOSPC on mount, but that implies | ||
1424 | * we were already there on the last unmount. Warn if this occurs. | ||
1420 | */ | 1425 | */ |
1421 | if (!(mp->m_flags & XFS_MOUNT_RDONLY)) { | 1426 | if (!(mp->m_flags & XFS_MOUNT_RDONLY)) { |
1422 | resblks = xfs_default_resblks(mp); | 1427 | resblks = xfs_default_resblks(mp); |
@@ -1725,26 +1730,30 @@ xfs_mod_incore_sb_unlocked( | |||
1725 | lcounter += rem; | 1730 | lcounter += rem; |
1726 | } | 1731 | } |
1727 | } else { /* Taking blocks away */ | 1732 | } else { /* Taking blocks away */ |
1728 | |||
1729 | lcounter += delta; | 1733 | lcounter += delta; |
1734 | if (lcounter >= 0) { | ||
1735 | mp->m_sb.sb_fdblocks = lcounter + | ||
1736 | XFS_ALLOC_SET_ASIDE(mp); | ||
1737 | return 0; | ||
1738 | } | ||
1730 | 1739 | ||
1731 | /* | 1740 | /* |
1732 | * If were out of blocks, use any available reserved blocks if | 1741 | * We are out of blocks, use any available reserved |
1733 | * were allowed to. | 1742 | * blocks if were allowed to. |
1734 | */ | 1743 | */ |
1744 | if (!rsvd) | ||
1745 | return XFS_ERROR(ENOSPC); | ||
1735 | 1746 | ||
1736 | if (lcounter < 0) { | 1747 | lcounter = (long long)mp->m_resblks_avail + delta; |
1737 | if (rsvd) { | 1748 | if (lcounter >= 0) { |
1738 | lcounter = (long long)mp->m_resblks_avail + delta; | 1749 | mp->m_resblks_avail = lcounter; |
1739 | if (lcounter < 0) { | 1750 | return 0; |
1740 | return XFS_ERROR(ENOSPC); | ||
1741 | } | ||
1742 | mp->m_resblks_avail = lcounter; | ||
1743 | return 0; | ||
1744 | } else { /* not reserved */ | ||
1745 | return XFS_ERROR(ENOSPC); | ||
1746 | } | ||
1747 | } | 1751 | } |
1752 | printk_once(KERN_WARNING | ||
1753 | "Filesystem \"%s\": reserve blocks depleted! " | ||
1754 | "Consider increasing reserve pool size.", | ||
1755 | mp->m_fsname); | ||
1756 | return XFS_ERROR(ENOSPC); | ||
1748 | } | 1757 | } |
1749 | 1758 | ||
1750 | mp->m_sb.sb_fdblocks = lcounter + XFS_ALLOC_SET_ASIDE(mp); | 1759 | mp->m_sb.sb_fdblocks = lcounter + XFS_ALLOC_SET_ASIDE(mp); |
@@ -2052,6 +2061,26 @@ xfs_mount_log_sb( | |||
2052 | return error; | 2061 | return error; |
2053 | } | 2062 | } |
2054 | 2063 | ||
2064 | /* | ||
2065 | * If the underlying (data/log/rt) device is readonly, there are some | ||
2066 | * operations that cannot proceed. | ||
2067 | */ | ||
2068 | int | ||
2069 | xfs_dev_is_read_only( | ||
2070 | struct xfs_mount *mp, | ||
2071 | char *message) | ||
2072 | { | ||
2073 | if (xfs_readonly_buftarg(mp->m_ddev_targp) || | ||
2074 | xfs_readonly_buftarg(mp->m_logdev_targp) || | ||
2075 | (mp->m_rtdev_targp && xfs_readonly_buftarg(mp->m_rtdev_targp))) { | ||
2076 | cmn_err(CE_NOTE, | ||
2077 | "XFS: %s required on read-only device.", message); | ||
2078 | cmn_err(CE_NOTE, | ||
2079 | "XFS: write access unavailable, cannot proceed."); | ||
2080 | return EROFS; | ||
2081 | } | ||
2082 | return 0; | ||
2083 | } | ||
2055 | 2084 | ||
2056 | #ifdef HAVE_PERCPU_SB | 2085 | #ifdef HAVE_PERCPU_SB |
2057 | /* | 2086 | /* |
diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h index 70504fcf14cd..4fa0bc7b983e 100644 --- a/fs/xfs/xfs_mount.h +++ b/fs/xfs/xfs_mount.h | |||
@@ -245,7 +245,7 @@ typedef struct xfs_mount { | |||
245 | struct xfs_qmops *m_qm_ops; /* vector of XQM ops */ | 245 | struct xfs_qmops *m_qm_ops; /* vector of XQM ops */ |
246 | atomic_t m_active_trans; /* number trans frozen */ | 246 | atomic_t m_active_trans; /* number trans frozen */ |
247 | #ifdef HAVE_PERCPU_SB | 247 | #ifdef HAVE_PERCPU_SB |
248 | xfs_icsb_cnts_t *m_sb_cnts; /* per-cpu superblock counters */ | 248 | xfs_icsb_cnts_t __percpu *m_sb_cnts; /* per-cpu superblock counters */ |
249 | unsigned long m_icsb_counters; /* disabled per-cpu counters */ | 249 | unsigned long m_icsb_counters; /* disabled per-cpu counters */ |
250 | struct notifier_block m_icsb_notifier; /* hotplug cpu notifier */ | 250 | struct notifier_block m_icsb_notifier; /* hotplug cpu notifier */ |
251 | struct mutex m_icsb_mutex; /* balancer sync lock */ | 251 | struct mutex m_icsb_mutex; /* balancer sync lock */ |
@@ -436,6 +436,8 @@ extern void xfs_freesb(xfs_mount_t *); | |||
436 | extern int xfs_fs_writable(xfs_mount_t *); | 436 | extern int xfs_fs_writable(xfs_mount_t *); |
437 | extern int xfs_sb_validate_fsb_count(struct xfs_sb *, __uint64_t); | 437 | extern int xfs_sb_validate_fsb_count(struct xfs_sb *, __uint64_t); |
438 | 438 | ||
439 | extern int xfs_dev_is_read_only(struct xfs_mount *, char *); | ||
440 | |||
439 | extern int xfs_dmops_get(struct xfs_mount *); | 441 | extern int xfs_dmops_get(struct xfs_mount *); |
440 | extern void xfs_dmops_put(struct xfs_mount *); | 442 | extern void xfs_dmops_put(struct xfs_mount *); |
441 | 443 | ||
diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c index be942d4e3324..f73e358bae8d 100644 --- a/fs/xfs/xfs_trans.c +++ b/fs/xfs/xfs_trans.c | |||
@@ -796,7 +796,7 @@ _xfs_trans_commit( | |||
796 | int sync; | 796 | int sync; |
797 | #define XFS_TRANS_LOGVEC_COUNT 16 | 797 | #define XFS_TRANS_LOGVEC_COUNT 16 |
798 | xfs_log_iovec_t log_vector_fast[XFS_TRANS_LOGVEC_COUNT]; | 798 | xfs_log_iovec_t log_vector_fast[XFS_TRANS_LOGVEC_COUNT]; |
799 | void *commit_iclog; | 799 | struct xlog_in_core *commit_iclog; |
800 | int shutdown; | 800 | int shutdown; |
801 | 801 | ||
802 | commit_lsn = -1; | 802 | commit_lsn = -1; |
diff --git a/fs/xfs/xfs_trans.h b/fs/xfs/xfs_trans.h index c93e3a102857..79c8bab9dfff 100644 --- a/fs/xfs/xfs_trans.h +++ b/fs/xfs/xfs_trans.h | |||
@@ -910,7 +910,7 @@ typedef struct xfs_trans { | |||
910 | unsigned int t_blk_res_used; /* # of resvd blocks used */ | 910 | unsigned int t_blk_res_used; /* # of resvd blocks used */ |
911 | unsigned int t_rtx_res; /* # of rt extents resvd */ | 911 | unsigned int t_rtx_res; /* # of rt extents resvd */ |
912 | unsigned int t_rtx_res_used; /* # of resvd rt extents used */ | 912 | unsigned int t_rtx_res_used; /* # of resvd rt extents used */ |
913 | xfs_log_ticket_t t_ticket; /* log mgr ticket */ | 913 | struct xlog_ticket *t_ticket; /* log mgr ticket */ |
914 | xfs_lsn_t t_lsn; /* log seq num of start of | 914 | xfs_lsn_t t_lsn; /* log seq num of start of |
915 | * transaction. */ | 915 | * transaction. */ |
916 | xfs_lsn_t t_commit_lsn; /* log seq num of end of | 916 | xfs_lsn_t t_commit_lsn; /* log seq num of end of |
diff --git a/fs/xfs/xfs_trans_buf.c b/fs/xfs/xfs_trans_buf.c index 5ffd544434eb..fb586360d1c9 100644 --- a/fs/xfs/xfs_trans_buf.c +++ b/fs/xfs/xfs_trans_buf.c | |||
@@ -46,6 +46,65 @@ STATIC xfs_buf_t *xfs_trans_buf_item_match(xfs_trans_t *, xfs_buftarg_t *, | |||
46 | STATIC xfs_buf_t *xfs_trans_buf_item_match_all(xfs_trans_t *, xfs_buftarg_t *, | 46 | STATIC xfs_buf_t *xfs_trans_buf_item_match_all(xfs_trans_t *, xfs_buftarg_t *, |
47 | xfs_daddr_t, int); | 47 | xfs_daddr_t, int); |
48 | 48 | ||
49 | /* | ||
50 | * Add the locked buffer to the transaction. | ||
51 | * | ||
52 | * The buffer must be locked, and it cannot be associated with any | ||
53 | * transaction. | ||
54 | * | ||
55 | * If the buffer does not yet have a buf log item associated with it, | ||
56 | * then allocate one for it. Then add the buf item to the transaction. | ||
57 | */ | ||
58 | STATIC void | ||
59 | _xfs_trans_bjoin( | ||
60 | struct xfs_trans *tp, | ||
61 | struct xfs_buf *bp, | ||
62 | int reset_recur) | ||
63 | { | ||
64 | struct xfs_buf_log_item *bip; | ||
65 | |||
66 | ASSERT(XFS_BUF_ISBUSY(bp)); | ||
67 | ASSERT(XFS_BUF_FSPRIVATE2(bp, void *) == NULL); | ||
68 | |||
69 | /* | ||
70 | * The xfs_buf_log_item pointer is stored in b_fsprivate. If | ||
71 | * it doesn't have one yet, then allocate one and initialize it. | ||
72 | * The checks to see if one is there are in xfs_buf_item_init(). | ||
73 | */ | ||
74 | xfs_buf_item_init(bp, tp->t_mountp); | ||
75 | bip = XFS_BUF_FSPRIVATE(bp, xfs_buf_log_item_t *); | ||
76 | ASSERT(!(bip->bli_flags & XFS_BLI_STALE)); | ||
77 | ASSERT(!(bip->bli_format.blf_flags & XFS_BLI_CANCEL)); | ||
78 | ASSERT(!(bip->bli_flags & XFS_BLI_LOGGED)); | ||
79 | if (reset_recur) | ||
80 | bip->bli_recur = 0; | ||
81 | |||
82 | /* | ||
83 | * Take a reference for this transaction on the buf item. | ||
84 | */ | ||
85 | atomic_inc(&bip->bli_refcount); | ||
86 | |||
87 | /* | ||
88 | * Get a log_item_desc to point at the new item. | ||
89 | */ | ||
90 | (void) xfs_trans_add_item(tp, (xfs_log_item_t *)bip); | ||
91 | |||
92 | /* | ||
93 | * Initialize b_fsprivate2 so we can find it with incore_match() | ||
94 | * in xfs_trans_get_buf() and friends above. | ||
95 | */ | ||
96 | XFS_BUF_SET_FSPRIVATE2(bp, tp); | ||
97 | |||
98 | } | ||
99 | |||
100 | void | ||
101 | xfs_trans_bjoin( | ||
102 | struct xfs_trans *tp, | ||
103 | struct xfs_buf *bp) | ||
104 | { | ||
105 | _xfs_trans_bjoin(tp, bp, 0); | ||
106 | trace_xfs_trans_bjoin(bp->b_fspriv); | ||
107 | } | ||
49 | 108 | ||
50 | /* | 109 | /* |
51 | * Get and lock the buffer for the caller if it is not already | 110 | * Get and lock the buffer for the caller if it is not already |
@@ -132,40 +191,8 @@ xfs_trans_get_buf(xfs_trans_t *tp, | |||
132 | 191 | ||
133 | ASSERT(!XFS_BUF_GETERROR(bp)); | 192 | ASSERT(!XFS_BUF_GETERROR(bp)); |
134 | 193 | ||
135 | /* | 194 | _xfs_trans_bjoin(tp, bp, 1); |
136 | * The xfs_buf_log_item pointer is stored in b_fsprivate. If | 195 | trace_xfs_trans_get_buf(bp->b_fspriv); |
137 | * it doesn't have one yet, then allocate one and initialize it. | ||
138 | * The checks to see if one is there are in xfs_buf_item_init(). | ||
139 | */ | ||
140 | xfs_buf_item_init(bp, tp->t_mountp); | ||
141 | |||
142 | /* | ||
143 | * Set the recursion count for the buffer within this transaction | ||
144 | * to 0. | ||
145 | */ | ||
146 | bip = XFS_BUF_FSPRIVATE(bp, xfs_buf_log_item_t*); | ||
147 | ASSERT(!(bip->bli_flags & XFS_BLI_STALE)); | ||
148 | ASSERT(!(bip->bli_format.blf_flags & XFS_BLI_CANCEL)); | ||
149 | ASSERT(!(bip->bli_flags & XFS_BLI_LOGGED)); | ||
150 | bip->bli_recur = 0; | ||
151 | |||
152 | /* | ||
153 | * Take a reference for this transaction on the buf item. | ||
154 | */ | ||
155 | atomic_inc(&bip->bli_refcount); | ||
156 | |||
157 | /* | ||
158 | * Get a log_item_desc to point at the new item. | ||
159 | */ | ||
160 | (void) xfs_trans_add_item(tp, (xfs_log_item_t*)bip); | ||
161 | |||
162 | /* | ||
163 | * Initialize b_fsprivate2 so we can find it with incore_match() | ||
164 | * above. | ||
165 | */ | ||
166 | XFS_BUF_SET_FSPRIVATE2(bp, tp); | ||
167 | |||
168 | trace_xfs_trans_get_buf(bip); | ||
169 | return (bp); | 196 | return (bp); |
170 | } | 197 | } |
171 | 198 | ||
@@ -210,44 +237,11 @@ xfs_trans_getsb(xfs_trans_t *tp, | |||
210 | } | 237 | } |
211 | 238 | ||
212 | bp = xfs_getsb(mp, flags); | 239 | bp = xfs_getsb(mp, flags); |
213 | if (bp == NULL) { | 240 | if (bp == NULL) |
214 | return NULL; | 241 | return NULL; |
215 | } | ||
216 | |||
217 | /* | ||
218 | * The xfs_buf_log_item pointer is stored in b_fsprivate. If | ||
219 | * it doesn't have one yet, then allocate one and initialize it. | ||
220 | * The checks to see if one is there are in xfs_buf_item_init(). | ||
221 | */ | ||
222 | xfs_buf_item_init(bp, mp); | ||
223 | |||
224 | /* | ||
225 | * Set the recursion count for the buffer within this transaction | ||
226 | * to 0. | ||
227 | */ | ||
228 | bip = XFS_BUF_FSPRIVATE(bp, xfs_buf_log_item_t*); | ||
229 | ASSERT(!(bip->bli_flags & XFS_BLI_STALE)); | ||
230 | ASSERT(!(bip->bli_format.blf_flags & XFS_BLI_CANCEL)); | ||
231 | ASSERT(!(bip->bli_flags & XFS_BLI_LOGGED)); | ||
232 | bip->bli_recur = 0; | ||
233 | |||
234 | /* | ||
235 | * Take a reference for this transaction on the buf item. | ||
236 | */ | ||
237 | atomic_inc(&bip->bli_refcount); | ||
238 | |||
239 | /* | ||
240 | * Get a log_item_desc to point at the new item. | ||
241 | */ | ||
242 | (void) xfs_trans_add_item(tp, (xfs_log_item_t*)bip); | ||
243 | |||
244 | /* | ||
245 | * Initialize b_fsprivate2 so we can find it with incore_match() | ||
246 | * above. | ||
247 | */ | ||
248 | XFS_BUF_SET_FSPRIVATE2(bp, tp); | ||
249 | 242 | ||
250 | trace_xfs_trans_getsb(bip); | 243 | _xfs_trans_bjoin(tp, bp, 1); |
244 | trace_xfs_trans_getsb(bp->b_fspriv); | ||
251 | return (bp); | 245 | return (bp); |
252 | } | 246 | } |
253 | 247 | ||
@@ -425,40 +419,9 @@ xfs_trans_read_buf( | |||
425 | if (XFS_FORCED_SHUTDOWN(mp)) | 419 | if (XFS_FORCED_SHUTDOWN(mp)) |
426 | goto shutdown_abort; | 420 | goto shutdown_abort; |
427 | 421 | ||
428 | /* | 422 | _xfs_trans_bjoin(tp, bp, 1); |
429 | * The xfs_buf_log_item pointer is stored in b_fsprivate. If | 423 | trace_xfs_trans_read_buf(bp->b_fspriv); |
430 | * it doesn't have one yet, then allocate one and initialize it. | ||
431 | * The checks to see if one is there are in xfs_buf_item_init(). | ||
432 | */ | ||
433 | xfs_buf_item_init(bp, tp->t_mountp); | ||
434 | 424 | ||
435 | /* | ||
436 | * Set the recursion count for the buffer within this transaction | ||
437 | * to 0. | ||
438 | */ | ||
439 | bip = XFS_BUF_FSPRIVATE(bp, xfs_buf_log_item_t*); | ||
440 | ASSERT(!(bip->bli_flags & XFS_BLI_STALE)); | ||
441 | ASSERT(!(bip->bli_format.blf_flags & XFS_BLI_CANCEL)); | ||
442 | ASSERT(!(bip->bli_flags & XFS_BLI_LOGGED)); | ||
443 | bip->bli_recur = 0; | ||
444 | |||
445 | /* | ||
446 | * Take a reference for this transaction on the buf item. | ||
447 | */ | ||
448 | atomic_inc(&bip->bli_refcount); | ||
449 | |||
450 | /* | ||
451 | * Get a log_item_desc to point at the new item. | ||
452 | */ | ||
453 | (void) xfs_trans_add_item(tp, (xfs_log_item_t*)bip); | ||
454 | |||
455 | /* | ||
456 | * Initialize b_fsprivate2 so we can find it with incore_match() | ||
457 | * above. | ||
458 | */ | ||
459 | XFS_BUF_SET_FSPRIVATE2(bp, tp); | ||
460 | |||
461 | trace_xfs_trans_read_buf(bip); | ||
462 | *bpp = bp; | 425 | *bpp = bp; |
463 | return 0; | 426 | return 0; |
464 | 427 | ||
@@ -623,53 +586,6 @@ xfs_trans_brelse(xfs_trans_t *tp, | |||
623 | } | 586 | } |
624 | 587 | ||
625 | /* | 588 | /* |
626 | * Add the locked buffer to the transaction. | ||
627 | * The buffer must be locked, and it cannot be associated with any | ||
628 | * transaction. | ||
629 | * | ||
630 | * If the buffer does not yet have a buf log item associated with it, | ||
631 | * then allocate one for it. Then add the buf item to the transaction. | ||
632 | */ | ||
633 | void | ||
634 | xfs_trans_bjoin(xfs_trans_t *tp, | ||
635 | xfs_buf_t *bp) | ||
636 | { | ||
637 | xfs_buf_log_item_t *bip; | ||
638 | |||
639 | ASSERT(XFS_BUF_ISBUSY(bp)); | ||
640 | ASSERT(XFS_BUF_FSPRIVATE2(bp, void *) == NULL); | ||
641 | |||
642 | /* | ||
643 | * The xfs_buf_log_item pointer is stored in b_fsprivate. If | ||
644 | * it doesn't have one yet, then allocate one and initialize it. | ||
645 | * The checks to see if one is there are in xfs_buf_item_init(). | ||
646 | */ | ||
647 | xfs_buf_item_init(bp, tp->t_mountp); | ||
648 | bip = XFS_BUF_FSPRIVATE(bp, xfs_buf_log_item_t *); | ||
649 | ASSERT(!(bip->bli_flags & XFS_BLI_STALE)); | ||
650 | ASSERT(!(bip->bli_format.blf_flags & XFS_BLI_CANCEL)); | ||
651 | ASSERT(!(bip->bli_flags & XFS_BLI_LOGGED)); | ||
652 | |||
653 | /* | ||
654 | * Take a reference for this transaction on the buf item. | ||
655 | */ | ||
656 | atomic_inc(&bip->bli_refcount); | ||
657 | |||
658 | /* | ||
659 | * Get a log_item_desc to point at the new item. | ||
660 | */ | ||
661 | (void) xfs_trans_add_item(tp, (xfs_log_item_t *)bip); | ||
662 | |||
663 | /* | ||
664 | * Initialize b_fsprivate2 so we can find it with incore_match() | ||
665 | * in xfs_trans_get_buf() and friends above. | ||
666 | */ | ||
667 | XFS_BUF_SET_FSPRIVATE2(bp, tp); | ||
668 | |||
669 | trace_xfs_trans_bjoin(bip); | ||
670 | } | ||
671 | |||
672 | /* | ||
673 | * Mark the buffer as not needing to be unlocked when the buf item's | 589 | * Mark the buffer as not needing to be unlocked when the buf item's |
674 | * IOP_UNLOCK() routine is called. The buffer must already be locked | 590 | * IOP_UNLOCK() routine is called. The buffer must already be locked |
675 | * and associated with the given transaction. | 591 | * and associated with the given transaction. |
diff --git a/fs/xfs/xfs_vnodeops.c b/fs/xfs/xfs_vnodeops.c index ddd2c5d1b854..9d376be0ea38 100644 --- a/fs/xfs/xfs_vnodeops.c +++ b/fs/xfs/xfs_vnodeops.c | |||
@@ -584,113 +584,6 @@ xfs_readlink( | |||
584 | } | 584 | } |
585 | 585 | ||
586 | /* | 586 | /* |
587 | * xfs_fsync | ||
588 | * | ||
589 | * This is called to sync the inode and its data out to disk. We need to hold | ||
590 | * the I/O lock while flushing the data, and the inode lock while flushing the | ||
591 | * inode. The inode lock CANNOT be held while flushing the data, so acquire | ||
592 | * after we're done with that. | ||
593 | */ | ||
594 | int | ||
595 | xfs_fsync( | ||
596 | xfs_inode_t *ip) | ||
597 | { | ||
598 | xfs_trans_t *tp; | ||
599 | int error = 0; | ||
600 | int log_flushed = 0; | ||
601 | |||
602 | xfs_itrace_entry(ip); | ||
603 | |||
604 | if (XFS_FORCED_SHUTDOWN(ip->i_mount)) | ||
605 | return XFS_ERROR(EIO); | ||
606 | |||
607 | /* | ||
608 | * We always need to make sure that the required inode state is safe on | ||
609 | * disk. The inode might be clean but we still might need to force the | ||
610 | * log because of committed transactions that haven't hit the disk yet. | ||
611 | * Likewise, there could be unflushed non-transactional changes to the | ||
612 | * inode core that have to go to disk and this requires us to issue | ||
613 | * a synchronous transaction to capture these changes correctly. | ||
614 | * | ||
615 | * This code relies on the assumption that if the update_* fields | ||
616 | * of the inode are clear and the inode is unpinned then it is clean | ||
617 | * and no action is required. | ||
618 | */ | ||
619 | xfs_ilock(ip, XFS_ILOCK_SHARED); | ||
620 | |||
621 | if (!ip->i_update_core) { | ||
622 | /* | ||
623 | * Timestamps/size haven't changed since last inode flush or | ||
624 | * inode transaction commit. That means either nothing got | ||
625 | * written or a transaction committed which caught the updates. | ||
626 | * If the latter happened and the transaction hasn't hit the | ||
627 | * disk yet, the inode will be still be pinned. If it is, | ||
628 | * force the log. | ||
629 | */ | ||
630 | xfs_iunlock(ip, XFS_ILOCK_SHARED); | ||
631 | if (xfs_ipincount(ip)) { | ||
632 | if (ip->i_itemp->ili_last_lsn) { | ||
633 | error = _xfs_log_force_lsn(ip->i_mount, | ||
634 | ip->i_itemp->ili_last_lsn, | ||
635 | XFS_LOG_SYNC, &log_flushed); | ||
636 | } else { | ||
637 | error = _xfs_log_force(ip->i_mount, | ||
638 | XFS_LOG_SYNC, &log_flushed); | ||
639 | } | ||
640 | } | ||
641 | } else { | ||
642 | /* | ||
643 | * Kick off a transaction to log the inode core to get the | ||
644 | * updates. The sync transaction will also force the log. | ||
645 | */ | ||
646 | xfs_iunlock(ip, XFS_ILOCK_SHARED); | ||
647 | tp = xfs_trans_alloc(ip->i_mount, XFS_TRANS_FSYNC_TS); | ||
648 | error = xfs_trans_reserve(tp, 0, | ||
649 | XFS_FSYNC_TS_LOG_RES(ip->i_mount), 0, 0, 0); | ||
650 | if (error) { | ||
651 | xfs_trans_cancel(tp, 0); | ||
652 | return error; | ||
653 | } | ||
654 | xfs_ilock(ip, XFS_ILOCK_EXCL); | ||
655 | |||
656 | /* | ||
657 | * Note - it's possible that we might have pushed ourselves out | ||
658 | * of the way during trans_reserve which would flush the inode. | ||
659 | * But there's no guarantee that the inode buffer has actually | ||
660 | * gone out yet (it's delwri). Plus the buffer could be pinned | ||
661 | * anyway if it's part of an inode in another recent | ||
662 | * transaction. So we play it safe and fire off the | ||
663 | * transaction anyway. | ||
664 | */ | ||
665 | xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL); | ||
666 | xfs_trans_ihold(tp, ip); | ||
667 | xfs_trans_log_inode(tp, ip, XFS_ILOG_CORE); | ||
668 | xfs_trans_set_sync(tp); | ||
669 | error = _xfs_trans_commit(tp, 0, &log_flushed); | ||
670 | |||
671 | xfs_iunlock(ip, XFS_ILOCK_EXCL); | ||
672 | } | ||
673 | |||
674 | if (ip->i_mount->m_flags & XFS_MOUNT_BARRIER) { | ||
675 | /* | ||
676 | * If the log write didn't issue an ordered tag we need | ||
677 | * to flush the disk cache for the data device now. | ||
678 | */ | ||
679 | if (!log_flushed) | ||
680 | xfs_blkdev_issue_flush(ip->i_mount->m_ddev_targp); | ||
681 | |||
682 | /* | ||
683 | * If this inode is on the RT dev we need to flush that | ||
684 | * cache as well. | ||
685 | */ | ||
686 | if (XFS_IS_REALTIME_INODE(ip)) | ||
687 | xfs_blkdev_issue_flush(ip->i_mount->m_rtdev_targp); | ||
688 | } | ||
689 | |||
690 | return error; | ||
691 | } | ||
692 | |||
693 | /* | ||
694 | * Flags for xfs_free_eofblocks | 587 | * Flags for xfs_free_eofblocks |
695 | */ | 588 | */ |
696 | #define XFS_FREE_EOF_TRYLOCK (1<<0) | 589 | #define XFS_FREE_EOF_TRYLOCK (1<<0) |
diff --git a/fs/xfs/xfs_vnodeops.h b/fs/xfs/xfs_vnodeops.h index 774f40729ca1..d8dfa8d0dadd 100644 --- a/fs/xfs/xfs_vnodeops.h +++ b/fs/xfs/xfs_vnodeops.h | |||
@@ -21,7 +21,6 @@ int xfs_setattr(struct xfs_inode *ip, struct iattr *vap, int flags); | |||
21 | #define XFS_ATTR_NOACL 0x08 /* Don't call xfs_acl_chmod */ | 21 | #define XFS_ATTR_NOACL 0x08 /* Don't call xfs_acl_chmod */ |
22 | 22 | ||
23 | int xfs_readlink(struct xfs_inode *ip, char *link); | 23 | int xfs_readlink(struct xfs_inode *ip, char *link); |
24 | int xfs_fsync(struct xfs_inode *ip); | ||
25 | int xfs_release(struct xfs_inode *ip); | 24 | int xfs_release(struct xfs_inode *ip); |
26 | int xfs_inactive(struct xfs_inode *ip); | 25 | int xfs_inactive(struct xfs_inode *ip); |
27 | int xfs_lookup(struct xfs_inode *dp, struct xfs_name *name, | 26 | int xfs_lookup(struct xfs_inode *dp, struct xfs_name *name, |
@@ -50,18 +49,6 @@ int xfs_attr_set(struct xfs_inode *dp, const unsigned char *name, | |||
50 | int xfs_attr_remove(struct xfs_inode *dp, const unsigned char *name, int flags); | 49 | int xfs_attr_remove(struct xfs_inode *dp, const unsigned char *name, int flags); |
51 | int xfs_attr_list(struct xfs_inode *dp, char *buffer, int bufsize, | 50 | int xfs_attr_list(struct xfs_inode *dp, char *buffer, int bufsize, |
52 | int flags, struct attrlist_cursor_kern *cursor); | 51 | int flags, struct attrlist_cursor_kern *cursor); |
53 | ssize_t xfs_read(struct xfs_inode *ip, struct kiocb *iocb, | ||
54 | const struct iovec *iovp, unsigned int segs, | ||
55 | loff_t *offset, int ioflags); | ||
56 | ssize_t xfs_splice_read(struct xfs_inode *ip, struct file *infilp, | ||
57 | loff_t *ppos, struct pipe_inode_info *pipe, size_t count, | ||
58 | int flags, int ioflags); | ||
59 | ssize_t xfs_splice_write(struct xfs_inode *ip, | ||
60 | struct pipe_inode_info *pipe, struct file *outfilp, | ||
61 | loff_t *ppos, size_t count, int flags, int ioflags); | ||
62 | ssize_t xfs_write(struct xfs_inode *xip, struct kiocb *iocb, | ||
63 | const struct iovec *iovp, unsigned int nsegs, | ||
64 | loff_t *offset, int ioflags); | ||
65 | int xfs_bmap(struct xfs_inode *ip, xfs_off_t offset, ssize_t count, | 52 | int xfs_bmap(struct xfs_inode *ip, xfs_off_t offset, ssize_t count, |
66 | int flags, struct xfs_iomap *iomapp, int *niomaps); | 53 | int flags, struct xfs_iomap *iomapp, int *niomaps); |
67 | void xfs_tosspages(struct xfs_inode *inode, xfs_off_t first, | 54 | void xfs_tosspages(struct xfs_inode *inode, xfs_off_t first, |
@@ -72,4 +59,6 @@ int xfs_flush_pages(struct xfs_inode *ip, xfs_off_t first, | |||
72 | xfs_off_t last, uint64_t flags, int fiopt); | 59 | xfs_off_t last, uint64_t flags, int fiopt); |
73 | int xfs_wait_on_pages(struct xfs_inode *ip, xfs_off_t first, xfs_off_t last); | 60 | int xfs_wait_on_pages(struct xfs_inode *ip, xfs_off_t first, xfs_off_t last); |
74 | 61 | ||
62 | int xfs_zero_eof(struct xfs_inode *, xfs_off_t, xfs_fsize_t); | ||
63 | |||
75 | #endif /* _XFS_VNODEOPS_H */ | 64 | #endif /* _XFS_VNODEOPS_H */ |