diff options
author | Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | 2010-10-18 01:28:50 -0400 |
---|---|---|
committer | Artem Bityutskiy <Artem.Bityutskiy@nokia.com> | 2010-10-21 04:15:18 -0400 |
commit | 39037559e651c417fb68b828926dc61cd5d6e5e2 (patch) | |
tree | 4b014d5e625c42cda030b4711186ee3ba381396b /fs | |
parent | 7d08ae3c9205b559f90c3d7a3abba3c6479673c7 (diff) |
UBIFS: remove a bit of unneeded code
This is a clean-up patch which:
1. Removes explicite 'hrtimer_cancel()' after 'ubifs_wbuf_sync()' in
'ubifs_remount_ro()', because the timers will be canceled by
'ubifs_wbuf_sync()', no need to cancel them for the second time.
2. Remove "if (c->jheads)" check from 'ubifs_put_super()', because
at journal heads must always be allocated there, since we checked
earlier that we were mounted R/W, and the olny situation when
journal heads are not allocated is when mounter or re-mounted R/O.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/ubifs/super.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index bb6ed5da2d10..6ff2f802bd7e 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c | |||
@@ -1686,10 +1686,8 @@ static void ubifs_remount_ro(struct ubifs_info *c) | |||
1686 | 1686 | ||
1687 | dbg_save_space_info(c); | 1687 | dbg_save_space_info(c); |
1688 | 1688 | ||
1689 | for (i = 0; i < c->jhead_cnt; i++) { | 1689 | for (i = 0; i < c->jhead_cnt; i++) |
1690 | ubifs_wbuf_sync(&c->jheads[i].wbuf); | 1690 | ubifs_wbuf_sync(&c->jheads[i].wbuf); |
1691 | hrtimer_cancel(&c->jheads[i].wbuf.timer); | ||
1692 | } | ||
1693 | 1691 | ||
1694 | c->mst_node->flags &= ~cpu_to_le32(UBIFS_MST_DIRTY); | 1692 | c->mst_node->flags &= ~cpu_to_le32(UBIFS_MST_DIRTY); |
1695 | c->mst_node->flags |= cpu_to_le32(UBIFS_MST_NO_ORPHS); | 1693 | c->mst_node->flags |= cpu_to_le32(UBIFS_MST_NO_ORPHS); |
@@ -1754,9 +1752,8 @@ static void ubifs_put_super(struct super_block *sb) | |||
1754 | int err; | 1752 | int err; |
1755 | 1753 | ||
1756 | /* Synchronize write-buffers */ | 1754 | /* Synchronize write-buffers */ |
1757 | if (c->jheads) | 1755 | for (i = 0; i < c->jhead_cnt; i++) |
1758 | for (i = 0; i < c->jhead_cnt; i++) | 1756 | ubifs_wbuf_sync(&c->jheads[i].wbuf); |
1759 | ubifs_wbuf_sync(&c->jheads[i].wbuf); | ||
1760 | 1757 | ||
1761 | /* | 1758 | /* |
1762 | * We are being cleanly unmounted which means the | 1759 | * We are being cleanly unmounted which means the |