Merge branch 'for-linus' of git://linux-nfs.org/~bfields/linux

* 'for-linus' of git://linux-nfs.org/~bfields/linux:
  SUNPRC: Fix printk format warning
  nfsd: clean up svc_reserve_auth()
  NLM: don't requeue block if it was invalidated while GRANT_MSG was in flight
  NLM: don't reattempt GRANT_MSG when there is already an RPC in flight
  NLM: have server-side RPC clients default to soft RPC tasks
  NLM: set RPC_CLNT_CREATE_NOPING for NLM RPC clients

2 files changed, 33 insertions, 5 deletions

diff --git a/fs/lockd/host.c b/fs/lockd/host.c
index ca6b16fc3101..f1ef49fff118 100644
--- a/fs/lockd/host.c
+++ b/fs/lockd/host.c
@@ -243,10 +243,18 @@ nlm_bind_host(struct nlm_host *host)
                         .program        = &nlm_program,
                         .version        = host->h_version,
                         .authflavor     = RPC_AUTH_UNIX,
-                        .flags          = (RPC_CLNT_CREATE_HARDRTRY |
+                        .flags          = (RPC_CLNT_CREATE_NOPING |
                                            RPC_CLNT_CREATE_AUTOBIND),
                 };
 
+                /*
+                 * lockd retries server side blocks automatically so we want
+                 * those to be soft RPC calls. Client side calls need to be
+                 * hard RPC tasks.
+                 */
+                if (!host->h_server)
+                        args.flags |= RPC_CLNT_CREATE_HARDRTRY;
+
                 clnt = rpc_create(&args);
                 if (!IS_ERR(clnt))
                         host->h_rpcclnt = clnt;
diff --git a/fs/lockd/svclock.c b/fs/lockd/svclock.c
index 2f4d8fa66689..fe9bdb4a220c 100644
--- a/fs/lockd/svclock.c
+++ b/fs/lockd/svclock.c
@@ -763,11 +763,20 @@ callback:
         dprintk("lockd: GRANTing blocked lock.\n");
         block->b_granted = 1;
 
-        /* Schedule next grant callback in 30 seconds */
-        nlmsvc_insert_block(block, 30 * HZ);
+        /* keep block on the list, but don't reattempt until the RPC
+         * completes or the submission fails
+         */
+        nlmsvc_insert_block(block, NLM_NEVER);
+
+        /* Call the client -- use a soft RPC task since nlmsvc_retry_blocked
+         * will queue up a new one if this one times out
+         */
+        error = nlm_async_call(block->b_call, NLMPROC_GRANTED_MSG,
+                                &nlmsvc_grant_ops);
 
-        /* Call the client */
-        nlm_async_call(block->b_call, NLMPROC_GRANTED_MSG, &nlmsvc_grant_ops);
+        /* RPC submission failed, wait a bit and retry */
+        if (error < 0)
+                nlmsvc_insert_block(block, 10 * HZ);
 }
 
 /*
@@ -786,6 +795,17 @@ static void nlmsvc_grant_callback(struct rpc_task *task, void *data)
 
         dprintk("lockd: GRANT_MSG RPC callback\n");
 
+        /* if the block is not on a list at this point then it has
+         * been invalidated. Don't try to requeue it.
+         *
+         * FIXME: it's possible that the block is removed from the list
+         * after this check but before the nlmsvc_insert_block. In that
+         * case it will be added back. Perhaps we need better locking
+         * for nlm_blocked?
+         */
+        if (list_empty(&block->b_list))
+                return;
+
         /* Technically, we should down the file semaphore here. Since we
          * move the block towards the head of the queue only, no harm
          * can be done, though. */