diff options
author | NeilBrown <neilb@suse.de> | 2006-03-26 04:37:17 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-26 11:56:55 -0500 |
commit | 3978d7179d3849848df8a37dd0a5acc20bcb8750 (patch) | |
tree | f6a60c588d54ffc482764e7846aabf7ba6135aa4 /fs | |
parent | 5f921ae96f1529a55966f25cd5c70fab11d38be7 (diff) |
[PATCH] Make address_space_operations->sync_page return void
The only user ignores the return value, and the only instanace
(block_sync_page) always returns 0...
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/buffer.c | 3 | ||||
-rw-r--r-- | fs/cifs/file.c | 6 |
2 files changed, 5 insertions, 4 deletions
diff --git a/fs/buffer.c b/fs/buffer.c index 3b3ab5281920..0b9456fd074f 100644 --- a/fs/buffer.c +++ b/fs/buffer.c | |||
@@ -3007,7 +3007,7 @@ out: | |||
3007 | } | 3007 | } |
3008 | EXPORT_SYMBOL(try_to_free_buffers); | 3008 | EXPORT_SYMBOL(try_to_free_buffers); |
3009 | 3009 | ||
3010 | int block_sync_page(struct page *page) | 3010 | void block_sync_page(struct page *page) |
3011 | { | 3011 | { |
3012 | struct address_space *mapping; | 3012 | struct address_space *mapping; |
3013 | 3013 | ||
@@ -3015,7 +3015,6 @@ int block_sync_page(struct page *page) | |||
3015 | mapping = page_mapping(page); | 3015 | mapping = page_mapping(page); |
3016 | if (mapping) | 3016 | if (mapping) |
3017 | blk_run_backing_dev(mapping->backing_dev_info, page); | 3017 | blk_run_backing_dev(mapping->backing_dev_info, page); |
3018 | return 0; | ||
3019 | } | 3018 | } |
3020 | 3019 | ||
3021 | /* | 3020 | /* |
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 165d67426381..fb49aef1f2ec 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c | |||
@@ -1339,7 +1339,7 @@ int cifs_fsync(struct file *file, struct dentry *dentry, int datasync) | |||
1339 | return rc; | 1339 | return rc; |
1340 | } | 1340 | } |
1341 | 1341 | ||
1342 | /* static int cifs_sync_page(struct page *page) | 1342 | /* static void cifs_sync_page(struct page *page) |
1343 | { | 1343 | { |
1344 | struct address_space *mapping; | 1344 | struct address_space *mapping; |
1345 | struct inode *inode; | 1345 | struct inode *inode; |
@@ -1353,16 +1353,18 @@ int cifs_fsync(struct file *file, struct dentry *dentry, int datasync) | |||
1353 | return 0; | 1353 | return 0; |
1354 | inode = mapping->host; | 1354 | inode = mapping->host; |
1355 | if (!inode) | 1355 | if (!inode) |
1356 | return 0; */ | 1356 | return; */ |
1357 | 1357 | ||
1358 | /* fill in rpages then | 1358 | /* fill in rpages then |
1359 | result = cifs_pagein_inode(inode, index, rpages); */ /* BB finish */ | 1359 | result = cifs_pagein_inode(inode, index, rpages); */ /* BB finish */ |
1360 | 1360 | ||
1361 | /* cFYI(1, ("rpages is %d for sync page of Index %ld ", rpages, index)); | 1361 | /* cFYI(1, ("rpages is %d for sync page of Index %ld ", rpages, index)); |
1362 | 1362 | ||
1363 | #if 0 | ||
1363 | if (rc < 0) | 1364 | if (rc < 0) |
1364 | return rc; | 1365 | return rc; |
1365 | return 0; | 1366 | return 0; |
1367 | #endif | ||
1366 | } */ | 1368 | } */ |
1367 | 1369 | ||
1368 | /* | 1370 | /* |