diff options
author | Eric Paris <eparis@redhat.com> | 2009-12-17 21:24:21 -0500 |
---|---|---|
committer | Eric Paris <eparis@redhat.com> | 2010-07-28 09:58:32 -0400 |
commit | 2a12a9d7814631e918dec93abad856e692d5286d (patch) | |
tree | 12817004ae9667bf83f869606f38050636edeb61 /fs | |
parent | 8112e2d6a7356e8c3ff1f7f3c86f375ed0305705 (diff) |
fsnotify: pass a file instead of an inode to open, read, and write
fanotify, the upcoming notification system actually needs a struct path so it can
do opens in the context of listeners, and it needs a file so it can get f_flags
from the original process. Close was the only operation that already was passing
a struct file to the notification hook. This patch passes a file for access,
modify, and open as well as they are easily available to these hooks.
Signed-off-by: Eric Paris <eparis@redhat.com>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/compat.c | 5 | ||||
-rw-r--r-- | fs/exec.c | 4 | ||||
-rw-r--r-- | fs/nfsd/vfs.c | 4 | ||||
-rw-r--r-- | fs/open.c | 2 | ||||
-rw-r--r-- | fs/read_write.c | 8 |
5 files changed, 11 insertions, 12 deletions
diff --git a/fs/compat.c b/fs/compat.c index 6490d2134ff3..ce02278b9c83 100644 --- a/fs/compat.c +++ b/fs/compat.c | |||
@@ -1193,11 +1193,10 @@ out: | |||
1193 | if (iov != iovstack) | 1193 | if (iov != iovstack) |
1194 | kfree(iov); | 1194 | kfree(iov); |
1195 | if ((ret + (type == READ)) > 0) { | 1195 | if ((ret + (type == READ)) > 0) { |
1196 | struct dentry *dentry = file->f_path.dentry; | ||
1197 | if (type == READ) | 1196 | if (type == READ) |
1198 | fsnotify_access(dentry); | 1197 | fsnotify_access(file); |
1199 | else | 1198 | else |
1200 | fsnotify_modify(dentry); | 1199 | fsnotify_modify(file); |
1201 | } | 1200 | } |
1202 | return ret; | 1201 | return ret; |
1203 | } | 1202 | } |
@@ -129,7 +129,7 @@ SYSCALL_DEFINE1(uselib, const char __user *, library) | |||
129 | if (file->f_path.mnt->mnt_flags & MNT_NOEXEC) | 129 | if (file->f_path.mnt->mnt_flags & MNT_NOEXEC) |
130 | goto exit; | 130 | goto exit; |
131 | 131 | ||
132 | fsnotify_open(file->f_path.dentry); | 132 | fsnotify_open(file); |
133 | 133 | ||
134 | error = -ENOEXEC; | 134 | error = -ENOEXEC; |
135 | if(file->f_op) { | 135 | if(file->f_op) { |
@@ -683,7 +683,7 @@ struct file *open_exec(const char *name) | |||
683 | if (file->f_path.mnt->mnt_flags & MNT_NOEXEC) | 683 | if (file->f_path.mnt->mnt_flags & MNT_NOEXEC) |
684 | goto exit; | 684 | goto exit; |
685 | 685 | ||
686 | fsnotify_open(file->f_path.dentry); | 686 | fsnotify_open(file); |
687 | 687 | ||
688 | err = deny_write_access(file); | 688 | err = deny_write_access(file); |
689 | if (err) | 689 | if (err) |
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 3c111120b619..16114a8e79d4 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c | |||
@@ -951,7 +951,7 @@ nfsd_vfs_read(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file, | |||
951 | nfsdstats.io_read += host_err; | 951 | nfsdstats.io_read += host_err; |
952 | *count = host_err; | 952 | *count = host_err; |
953 | err = 0; | 953 | err = 0; |
954 | fsnotify_access(file->f_path.dentry); | 954 | fsnotify_access(file); |
955 | } else | 955 | } else |
956 | err = nfserrno(host_err); | 956 | err = nfserrno(host_err); |
957 | out: | 957 | out: |
@@ -1062,7 +1062,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file, | |||
1062 | goto out_nfserr; | 1062 | goto out_nfserr; |
1063 | *cnt = host_err; | 1063 | *cnt = host_err; |
1064 | nfsdstats.io_write += host_err; | 1064 | nfsdstats.io_write += host_err; |
1065 | fsnotify_modify(file->f_path.dentry); | 1065 | fsnotify_modify(file); |
1066 | 1066 | ||
1067 | /* clear setuid/setgid flag after write */ | 1067 | /* clear setuid/setgid flag after write */ |
1068 | if (inode->i_mode & (S_ISUID | S_ISGID)) | 1068 | if (inode->i_mode & (S_ISUID | S_ISGID)) |
@@ -889,7 +889,7 @@ long do_sys_open(int dfd, const char __user *filename, int flags, int mode) | |||
889 | put_unused_fd(fd); | 889 | put_unused_fd(fd); |
890 | fd = PTR_ERR(f); | 890 | fd = PTR_ERR(f); |
891 | } else { | 891 | } else { |
892 | fsnotify_open(f->f_path.dentry); | 892 | fsnotify_open(f); |
893 | fd_install(fd, f); | 893 | fd_install(fd, f); |
894 | } | 894 | } |
895 | } | 895 | } |
diff --git a/fs/read_write.c b/fs/read_write.c index 9c0485236e68..74e36586e4d3 100644 --- a/fs/read_write.c +++ b/fs/read_write.c | |||
@@ -311,7 +311,7 @@ ssize_t vfs_read(struct file *file, char __user *buf, size_t count, loff_t *pos) | |||
311 | else | 311 | else |
312 | ret = do_sync_read(file, buf, count, pos); | 312 | ret = do_sync_read(file, buf, count, pos); |
313 | if (ret > 0) { | 313 | if (ret > 0) { |
314 | fsnotify_access(file->f_path.dentry); | 314 | fsnotify_access(file); |
315 | add_rchar(current, ret); | 315 | add_rchar(current, ret); |
316 | } | 316 | } |
317 | inc_syscr(current); | 317 | inc_syscr(current); |
@@ -367,7 +367,7 @@ ssize_t vfs_write(struct file *file, const char __user *buf, size_t count, loff_ | |||
367 | else | 367 | else |
368 | ret = do_sync_write(file, buf, count, pos); | 368 | ret = do_sync_write(file, buf, count, pos); |
369 | if (ret > 0) { | 369 | if (ret > 0) { |
370 | fsnotify_modify(file->f_path.dentry); | 370 | fsnotify_modify(file); |
371 | add_wchar(current, ret); | 371 | add_wchar(current, ret); |
372 | } | 372 | } |
373 | inc_syscw(current); | 373 | inc_syscw(current); |
@@ -675,9 +675,9 @@ out: | |||
675 | kfree(iov); | 675 | kfree(iov); |
676 | if ((ret + (type == READ)) > 0) { | 676 | if ((ret + (type == READ)) > 0) { |
677 | if (type == READ) | 677 | if (type == READ) |
678 | fsnotify_access(file->f_path.dentry); | 678 | fsnotify_access(file); |
679 | else | 679 | else |
680 | fsnotify_modify(file->f_path.dentry); | 680 | fsnotify_modify(file); |
681 | } | 681 | } |
682 | return ret; | 682 | return ret; |
683 | } | 683 | } |