aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorEric W. Biederman <ebiederm@xmission.com>2006-06-26 03:25:42 -0400
committerLinus Torvalds <torvalds@g5.osdl.org>2006-06-26 12:58:23 -0400
commit167965495153ba9829d0a34b6800dbf5d94de8c8 (patch)
treeee923581fc2fb1a9bcae7920a8a362fed7b55705 /fs
parentff9724a3f7a69f7b443c05981f84e28017c2fc5a (diff)
[PATCH] proc: Remove unnecessary and misleading assignments from proc_pid_make_inode
The removed fields are already set by proc_alloc_inode. Initializing them in proc_alloc_inode implies they need it for proper cleanup. At least ei->pde was not set on all paths making it look like proc_alloc_inode was buggy. So just remove the redundant assignments. Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/proc/base.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/proc/base.c b/fs/proc/base.c
index 7169a713da1b..0762bc34d98b 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -1357,7 +1357,6 @@ static struct inode *proc_pid_make_inode(struct super_block * sb, struct task_st
1357 1357
1358 /* Common stuff */ 1358 /* Common stuff */
1359 ei = PROC_I(inode); 1359 ei = PROC_I(inode);
1360 ei->task = NULL;
1361 inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; 1360 inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
1362 inode->i_ino = fake_ino(task->pid, ino); 1361 inode->i_ino = fake_ino(task->pid, ino);
1363 1362
@@ -1382,7 +1381,6 @@ out:
1382 return inode; 1381 return inode;
1383 1382
1384out_unlock: 1383out_unlock:
1385 ei->pde = NULL;
1386 iput(inode); 1384 iput(inode);
1387 return NULL; 1385 return NULL;
1388} 1386}