diff options
author | Jens Axboe <jens.axboe@oracle.com> | 2008-12-23 06:46:21 -0500 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2008-12-29 02:29:53 -0500 |
commit | d3f761104b097738932afcc310fbbbbfb007ef92 (patch) | |
tree | 5acda986824cab2a8c54690258a49df61b898389 /fs | |
parent | f735b5eeb9fcbb001e0cf2a5296b19c4bbaec55f (diff) |
bio: get rid of bio_vec clearing
We don't need to clear the memory used for adding bio_vec entries,
since nobody should be looking at members unitialized. Any valid
use should be below bio->bi_vcnt, and that members up until that count
must be valid since they were added through bio_add_page().
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/bio.c | 6 |
1 files changed, 1 insertions, 5 deletions
@@ -180,7 +180,7 @@ struct bio_vec *bvec_alloc_bs(gfp_t gfp_mask, int nr, unsigned long *idx, | |||
180 | * kzalloc() for the exact number of vecs right away. | 180 | * kzalloc() for the exact number of vecs right away. |
181 | */ | 181 | */ |
182 | if (!bs) | 182 | if (!bs) |
183 | bvl = kzalloc(nr * sizeof(struct bio_vec), gfp_mask); | 183 | bvl = kmalloc(nr * sizeof(struct bio_vec), gfp_mask); |
184 | 184 | ||
185 | /* | 185 | /* |
186 | * see comment near bvec_array define! | 186 | * see comment near bvec_array define! |
@@ -237,9 +237,6 @@ fallback: | |||
237 | } | 237 | } |
238 | } | 238 | } |
239 | 239 | ||
240 | if (bvl) | ||
241 | memset(bvl, 0, bvec_nr_vecs(*idx) * sizeof(struct bio_vec)); | ||
242 | |||
243 | return bvl; | 240 | return bvl; |
244 | } | 241 | } |
245 | 242 | ||
@@ -325,7 +322,6 @@ struct bio *bio_alloc_bioset(gfp_t gfp_mask, int nr_iovecs, struct bio_set *bs) | |||
325 | idx = 0; | 322 | idx = 0; |
326 | bvl = bio->bi_inline_vecs; | 323 | bvl = bio->bi_inline_vecs; |
327 | nr_iovecs = BIO_INLINE_VECS; | 324 | nr_iovecs = BIO_INLINE_VECS; |
328 | memset(bvl, 0, BIO_INLINE_VECS * sizeof(*bvl)); | ||
329 | } else { | 325 | } else { |
330 | bvl = bvec_alloc_bs(gfp_mask, nr_iovecs, &idx, | 326 | bvl = bvec_alloc_bs(gfp_mask, nr_iovecs, &idx, |
331 | bs); | 327 | bs); |