diff options
author | Jeff Moyer <jmoyer@redhat.com> | 2007-10-17 02:27:20 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-17 11:42:53 -0400 |
commit | 41d10da3717409de33d5441f2f6d8f072ab3fbb6 (patch) | |
tree | 4822afef881132248a7c91ba6eb33065f3209f2b /fs | |
parent | c17ac85504efec5f3a9b0c5b05bffd6f30e5b655 (diff) |
aio: account I/O wait time properly
Some months back I proposed changing the schedule() call in
read_events to an io_schedule():
http://osdir.com/ml/linux.kernel.aio.general/2006-10/msg00024.html
This was rejected as there are AIO operations that do not initiate
disk I/O. I've had another look at the problem, and the only AIO
operation that will not initiate disk I/O is IOCB_CMD_NOOP. However,
this command isn't even wired up!
Given that it doesn't work, and hasn't for *years*, I'm going to
suggest again that we do proper I/O accounting when using AIO.
Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Acked-by: Zach Brown <zach.brown@oracle.com>
Cc: Benjamin LaHaise <bcrl@kvack.org>
Cc: Suparna Bhattacharya <suparna@in.ibm.com>
Cc: Badari Pulavarty <pbadari@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/aio.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -303,7 +303,7 @@ static void wait_for_all_aios(struct kioctx *ctx) | |||
303 | set_task_state(tsk, TASK_UNINTERRUPTIBLE); | 303 | set_task_state(tsk, TASK_UNINTERRUPTIBLE); |
304 | while (ctx->reqs_active) { | 304 | while (ctx->reqs_active) { |
305 | spin_unlock_irq(&ctx->ctx_lock); | 305 | spin_unlock_irq(&ctx->ctx_lock); |
306 | schedule(); | 306 | io_schedule(); |
307 | set_task_state(tsk, TASK_UNINTERRUPTIBLE); | 307 | set_task_state(tsk, TASK_UNINTERRUPTIBLE); |
308 | spin_lock_irq(&ctx->ctx_lock); | 308 | spin_lock_irq(&ctx->ctx_lock); |
309 | } | 309 | } |
@@ -323,7 +323,7 @@ ssize_t fastcall wait_on_sync_kiocb(struct kiocb *iocb) | |||
323 | set_current_state(TASK_UNINTERRUPTIBLE); | 323 | set_current_state(TASK_UNINTERRUPTIBLE); |
324 | if (!iocb->ki_users) | 324 | if (!iocb->ki_users) |
325 | break; | 325 | break; |
326 | schedule(); | 326 | io_schedule(); |
327 | } | 327 | } |
328 | __set_current_state(TASK_RUNNING); | 328 | __set_current_state(TASK_RUNNING); |
329 | return iocb->ki_user_data; | 329 | return iocb->ki_user_data; |
@@ -1170,7 +1170,7 @@ retry: | |||
1170 | ret = 0; | 1170 | ret = 0; |
1171 | if (to.timed_out) /* Only check after read evt */ | 1171 | if (to.timed_out) /* Only check after read evt */ |
1172 | break; | 1172 | break; |
1173 | schedule(); | 1173 | io_schedule(); |
1174 | if (signal_pending(tsk)) { | 1174 | if (signal_pending(tsk)) { |
1175 | ret = -EINTR; | 1175 | ret = -EINTR; |
1176 | break; | 1176 | break; |