diff options
author | Sage Weil <sage@newdream.net> | 2011-05-27 16:41:56 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2011-05-28 01:02:50 -0400 |
commit | cf0f0536fa65ca1353476c49feed34891f3f7134 (patch) | |
tree | f75e2b40e072821fe4ebfd19ab8b074cdd642cca /fs | |
parent | 873ae4d5a8b282c6e2bbc09c6d59eeb1bec97ef7 (diff) |
jffs2: remove unnecessary dentry_unhash from rmdir, dir rename
jffs2 does not have problems with references to unlinked directories.
CC: David Woodhouse <dwmw2@infradead.org>
CC: linux-mtd@lists.infradead.org
Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/jffs2/dir.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/fs/jffs2/dir.c b/fs/jffs2/dir.c index 05f73328b28b..82faddd1f321 100644 --- a/fs/jffs2/dir.c +++ b/fs/jffs2/dir.c | |||
@@ -609,8 +609,6 @@ static int jffs2_rmdir (struct inode *dir_i, struct dentry *dentry) | |||
609 | int ret; | 609 | int ret; |
610 | uint32_t now = get_seconds(); | 610 | uint32_t now = get_seconds(); |
611 | 611 | ||
612 | dentry_unhash(dentry); | ||
613 | |||
614 | for (fd = f->dents ; fd; fd = fd->next) { | 612 | for (fd = f->dents ; fd; fd = fd->next) { |
615 | if (fd->ino) | 613 | if (fd->ino) |
616 | return -ENOTEMPTY; | 614 | return -ENOTEMPTY; |
@@ -786,9 +784,6 @@ static int jffs2_rename (struct inode *old_dir_i, struct dentry *old_dentry, | |||
786 | uint8_t type; | 784 | uint8_t type; |
787 | uint32_t now; | 785 | uint32_t now; |
788 | 786 | ||
789 | if (new_dentry->d_inode && S_ISDIR(new_dentry->d_inode->i_mode)) | ||
790 | dentry_unhash(new_dentry); | ||
791 | |||
792 | /* The VFS will check for us and prevent trying to rename a | 787 | /* The VFS will check for us and prevent trying to rename a |
793 | * file over a directory and vice versa, but if it's a directory, | 788 | * file over a directory and vice versa, but if it's a directory, |
794 | * the VFS can't check whether the victim is empty. The filesystem | 789 | * the VFS can't check whether the victim is empty. The filesystem |