aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2013-10-16 08:25:11 -0400
committerTheodore Ts'o <tytso@mit.edu>2013-10-16 08:25:11 -0400
commit78371a45dfa8f2a2f3892b983c39863a67c66b11 (patch)
tree73ee2382d47fe0e92a41bfd3b67714afa858a82d /fs
parent61e6cfa80de5760bbe406f4e815b7739205754d2 (diff)
ext4: fix assertion in ext4_add_complete_io()
It doesn't make sense to require io_end->handle when we are in nojournal mode. So update the assertion accordingly to avoid false warnings from ext4_add_complete_io(). Reported-by: Eric Whitney <enwlinux@gmail.com> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs')
-rw-r--r--fs/ext4/page-io.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
index d7d0c7b46ed4..d488f80ee32d 100644
--- a/fs/ext4/page-io.c
+++ b/fs/ext4/page-io.c
@@ -197,14 +197,15 @@ static void dump_completed_IO(struct inode *inode, struct list_head *head)
197static void ext4_add_complete_io(ext4_io_end_t *io_end) 197static void ext4_add_complete_io(ext4_io_end_t *io_end)
198{ 198{
199 struct ext4_inode_info *ei = EXT4_I(io_end->inode); 199 struct ext4_inode_info *ei = EXT4_I(io_end->inode);
200 struct ext4_sb_info *sbi = EXT4_SB(io_end->inode->i_sb);
200 struct workqueue_struct *wq; 201 struct workqueue_struct *wq;
201 unsigned long flags; 202 unsigned long flags;
202 203
203 /* Only reserved conversions from writeback should enter here */ 204 /* Only reserved conversions from writeback should enter here */
204 WARN_ON(!(io_end->flag & EXT4_IO_END_UNWRITTEN)); 205 WARN_ON(!(io_end->flag & EXT4_IO_END_UNWRITTEN));
205 WARN_ON(!io_end->handle); 206 WARN_ON(!io_end->handle && sbi->s_journal);
206 spin_lock_irqsave(&ei->i_completed_io_lock, flags); 207 spin_lock_irqsave(&ei->i_completed_io_lock, flags);
207 wq = EXT4_SB(io_end->inode->i_sb)->rsv_conversion_wq; 208 wq = sbi->rsv_conversion_wq;
208 if (list_empty(&ei->i_rsv_conversion_list)) 209 if (list_empty(&ei->i_rsv_conversion_list))
209 queue_work(wq, &ei->i_rsv_conversion_work); 210 queue_work(wq, &ei->i_rsv_conversion_work);
210 list_add_tail(&io_end->list, &ei->i_rsv_conversion_list); 211 list_add_tail(&io_end->list, &ei->i_rsv_conversion_list);