diff options
author | Julia Lawall <julia@diku.dk> | 2010-05-26 17:44:23 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-05-27 12:12:53 -0400 |
commit | cccad8f9f0f1be585c9dc534857ca9c67e538836 (patch) | |
tree | 6db36d8244a1fc169fbb2a82dc294e2d5f9e0432 /fs | |
parent | 2fd74e25df46ecb0b54700aba242dcaeb2d75f4a (diff) |
fs/affs: use ERR_CAST
Use ERR_CAST(x) rather than ERR_PTR(PTR_ERR(x)). The former makes more
clear what is the purpose of the operation, which otherwise looks like a
no-op.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
type T;
T x;
identifier f;
@@
T f (...) { <+...
- ERR_PTR(PTR_ERR(x))
+ x
...+> }
@@
expression x;
@@
- ERR_PTR(PTR_ERR(x))
+ ERR_CAST(x)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/affs/namei.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/affs/namei.c b/fs/affs/namei.c index d70bbbac6b7b..914d1c0bc07a 100644 --- a/fs/affs/namei.c +++ b/fs/affs/namei.c | |||
@@ -224,7 +224,7 @@ affs_lookup(struct inode *dir, struct dentry *dentry, struct nameidata *nd) | |||
224 | affs_brelse(bh); | 224 | affs_brelse(bh); |
225 | inode = affs_iget(sb, ino); | 225 | inode = affs_iget(sb, ino); |
226 | if (IS_ERR(inode)) | 226 | if (IS_ERR(inode)) |
227 | return ERR_PTR(PTR_ERR(inode)); | 227 | return ERR_CAST(inode); |
228 | } | 228 | } |
229 | dentry->d_op = AFFS_SB(sb)->s_flags & SF_INTL ? &affs_intl_dentry_operations : &affs_dentry_operations; | 229 | dentry->d_op = AFFS_SB(sb)->s_flags & SF_INTL ? &affs_intl_dentry_operations : &affs_dentry_operations; |
230 | d_add(dentry, inode); | 230 | d_add(dentry, inode); |