diff options
author | Eric Paris <eparis@redhat.com> | 2009-12-17 21:24:22 -0500 |
---|---|---|
committer | Eric Paris <eparis@redhat.com> | 2010-07-28 09:58:51 -0400 |
commit | 0d2e2a1d00d7d23e5bd9bb0935cde7c3d5835c56 (patch) | |
tree | 1c6bbbcbb143a364838d6749aa086af3c019f965 /fs | |
parent | 220d14df0dc587c06b97762829a41157c9375b94 (diff) |
fsnotify: drop mask argument from fsnotify_alloc_group
Nothing uses the mask argument to fsnotify_alloc_group. This patch drops
that argument.
Signed-off-by: Eric Paris <eparis@redhat.com>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/notify/dnotify/dnotify.c | 2 | ||||
-rw-r--r-- | fs/notify/group.c | 8 | ||||
-rw-r--r-- | fs/notify/inotify/inotify_user.c | 2 |
3 files changed, 3 insertions, 9 deletions
diff --git a/fs/notify/dnotify/dnotify.c b/fs/notify/dnotify/dnotify.c index 51e4fe33d6bb..e0a847bd53be 100644 --- a/fs/notify/dnotify/dnotify.c +++ b/fs/notify/dnotify/dnotify.c | |||
@@ -433,7 +433,7 @@ static int __init dnotify_init(void) | |||
433 | dnotify_struct_cache = KMEM_CACHE(dnotify_struct, SLAB_PANIC); | 433 | dnotify_struct_cache = KMEM_CACHE(dnotify_struct, SLAB_PANIC); |
434 | dnotify_mark_entry_cache = KMEM_CACHE(dnotify_mark_entry, SLAB_PANIC); | 434 | dnotify_mark_entry_cache = KMEM_CACHE(dnotify_mark_entry, SLAB_PANIC); |
435 | 435 | ||
436 | dnotify_group = fsnotify_alloc_group(0, &dnotify_fsnotify_ops); | 436 | dnotify_group = fsnotify_alloc_group(&dnotify_fsnotify_ops); |
437 | if (IS_ERR(dnotify_group)) | 437 | if (IS_ERR(dnotify_group)) |
438 | panic("unable to allocate fsnotify group for dnotify\n"); | 438 | panic("unable to allocate fsnotify group for dnotify\n"); |
439 | return 0; | 439 | return 0; |
diff --git a/fs/notify/group.c b/fs/notify/group.c index 1d20d26d5fee..1657349c30a6 100644 --- a/fs/notify/group.c +++ b/fs/notify/group.c | |||
@@ -164,8 +164,7 @@ void fsnotify_put_group(struct fsnotify_group *group) | |||
164 | /* | 164 | /* |
165 | * Create a new fsnotify_group and hold a reference for the group returned. | 165 | * Create a new fsnotify_group and hold a reference for the group returned. |
166 | */ | 166 | */ |
167 | struct fsnotify_group *fsnotify_alloc_group(__u32 mask, | 167 | struct fsnotify_group *fsnotify_alloc_group(const struct fsnotify_ops *ops) |
168 | const struct fsnotify_ops *ops) | ||
169 | { | 168 | { |
170 | struct fsnotify_group *group; | 169 | struct fsnotify_group *group; |
171 | 170 | ||
@@ -175,8 +174,6 @@ struct fsnotify_group *fsnotify_alloc_group(__u32 mask, | |||
175 | 174 | ||
176 | atomic_set(&group->refcnt, 1); | 175 | atomic_set(&group->refcnt, 1); |
177 | 176 | ||
178 | group->mask = mask; | ||
179 | |||
180 | mutex_init(&group->notification_mutex); | 177 | mutex_init(&group->notification_mutex); |
181 | INIT_LIST_HEAD(&group->notification_list); | 178 | INIT_LIST_HEAD(&group->notification_list); |
182 | init_waitqueue_head(&group->notification_waitq); | 179 | init_waitqueue_head(&group->notification_waitq); |
@@ -196,8 +193,5 @@ struct fsnotify_group *fsnotify_alloc_group(__u32 mask, | |||
196 | 193 | ||
197 | mutex_unlock(&fsnotify_grp_mutex); | 194 | mutex_unlock(&fsnotify_grp_mutex); |
198 | 195 | ||
199 | if (mask) | ||
200 | fsnotify_recalc_global_mask(); | ||
201 | |||
202 | return group; | 196 | return group; |
203 | } | 197 | } |
diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c index 25a2854186e9..a48d68a68b25 100644 --- a/fs/notify/inotify/inotify_user.c +++ b/fs/notify/inotify/inotify_user.c | |||
@@ -695,7 +695,7 @@ static struct fsnotify_group *inotify_new_group(struct user_struct *user, unsign | |||
695 | { | 695 | { |
696 | struct fsnotify_group *group; | 696 | struct fsnotify_group *group; |
697 | 697 | ||
698 | group = fsnotify_alloc_group(0, &inotify_fsnotify_ops); | 698 | group = fsnotify_alloc_group(&inotify_fsnotify_ops); |
699 | if (IS_ERR(group)) | 699 | if (IS_ERR(group)) |
700 | return group; | 700 | return group; |
701 | 701 | ||