diff options
author | Jeremy Fitzhardinge <jeremy@goop.org> | 2006-12-13 03:34:49 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.osdl.org> | 2006-12-13 12:05:51 -0500 |
commit | 90aef12e6dd609e1ad7fb70044eedc78ca55ee5e (patch) | |
tree | 35ff39f80d010c548df660d3a3e53c5861741777 /fs | |
parent | 74c383f1400f559562aa517d6d62f77245bddf52 (diff) |
[PATCH] Use activate_mm() in fs/aio.c:use_mm()
activate_mm() is not the right thing to be using in use_mm(). It should be
switch_mm().
On normal x86, they're synonymous, but for the Xen patches I'm adding a
hook which assumes that activate_mm is only used the first time a new mm
is used after creation (I have another hook for dealing with dup_mm). I
think this use of activate_mm() is the only place where it could be used
a second time on an mm.
>From a quick look at the other architectures I think this is OK (most
simply implement one in terms of the other), but some are doing some
subtly different stuff between the two.
Acked-by: David Miller <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/aio.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -586,7 +586,7 @@ static void use_mm(struct mm_struct *mm) | |||
586 | * Note that on UML this *requires* PF_BORROWED_MM to be set, otherwise | 586 | * Note that on UML this *requires* PF_BORROWED_MM to be set, otherwise |
587 | * it won't work. Update it accordingly if you change it here | 587 | * it won't work. Update it accordingly if you change it here |
588 | */ | 588 | */ |
589 | activate_mm(active_mm, mm); | 589 | switch_mm(active_mm, mm, tsk); |
590 | task_unlock(tsk); | 590 | task_unlock(tsk); |
591 | 591 | ||
592 | mmdrop(active_mm); | 592 | mmdrop(active_mm); |