diff options
author | Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp> | 2006-07-10 07:43:56 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-07-10 16:24:13 -0400 |
commit | 73ce5934e2d855db436566297f12966eb507a435 (patch) | |
tree | 8e3e2fa1690dbd2f5a389ea5c5b151287f9e0297 /fs | |
parent | 0808925ea5684a0ce25483b30e94d4f398804978 (diff) |
[PATCH] reiserfs: fix journaling issue regarding fsync()
When write() extends a file(i_size is increased) and fsync() is called,
change of inode must be written to journaling area through fsync().
But,currently the i_trans_id is not correctly updated when i_size is
increased. So fsync() does not kick the journal writer.
Reiserfs_file_write() already updates the transaction when blocks are
allocated, but the case when i_size increases and new blocks are not added
is not correctly treated.
Following patch fix this bug.
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: Chris Mason <mason@suse.com>
Cc: Hans Reiser <reiser@namesys.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/reiserfs/file.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/fs/reiserfs/file.c b/fs/reiserfs/file.c index 752cea12e30f..f318b58510fd 100644 --- a/fs/reiserfs/file.c +++ b/fs/reiserfs/file.c | |||
@@ -860,8 +860,12 @@ static int reiserfs_submit_file_region_for_write(struct reiserfs_transaction_han | |||
860 | // this sets the proper flags for O_SYNC to trigger a commit | 860 | // this sets the proper flags for O_SYNC to trigger a commit |
861 | mark_inode_dirty(inode); | 861 | mark_inode_dirty(inode); |
862 | reiserfs_write_unlock(inode->i_sb); | 862 | reiserfs_write_unlock(inode->i_sb); |
863 | } else | 863 | } else { |
864 | reiserfs_write_lock(inode->i_sb); | ||
865 | reiserfs_update_inode_transaction(inode); | ||
864 | mark_inode_dirty(inode); | 866 | mark_inode_dirty(inode); |
867 | reiserfs_write_unlock(inode->i_sb); | ||
868 | } | ||
865 | 869 | ||
866 | sd_update = 1; | 870 | sd_update = 1; |
867 | } | 871 | } |