diff options
author | Jeff Garzik <jeff@garzik.org> | 2006-10-04 07:57:18 -0400 |
---|---|---|
committer | David Woodhouse <dwmw2@infradead.org> | 2006-10-04 09:31:01 -0400 |
commit | a6b1d82d079a99d09761ee5fbc66c49f33b42324 (patch) | |
tree | e7adfec8ee481659eeab676487b2db541ef93eee /fs | |
parent | 78b656b8bf933101b42409b4492734b23427bfc3 (diff) |
[JFFS2] kill warning RE debug-only variables
gcc emits the following warning on a 'allmodconfig' build:
fs/jffs2/xattr.c: In function ‘unrefer_xattr_datum’:
fs/jffs2/xattr.c:402: warning: unused variable ‘version’
fs/jffs2/xattr.c:402: warning: unused variable ‘xid’
Given that these variables are only used in the debug printk, and they
merely remove a deref, we can easily kill the warning by adding the
derefs to the debug printk.
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/jffs2/xattr.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/fs/jffs2/xattr.c b/fs/jffs2/xattr.c index 4da09ce1d1f5..4bb3f1897330 100644 --- a/fs/jffs2/xattr.c +++ b/fs/jffs2/xattr.c | |||
@@ -399,8 +399,6 @@ static void unrefer_xattr_datum(struct jffs2_sb_info *c, struct jffs2_xattr_datu | |||
399 | { | 399 | { |
400 | /* must be called under down_write(xattr_sem) */ | 400 | /* must be called under down_write(xattr_sem) */ |
401 | if (atomic_dec_and_lock(&xd->refcnt, &c->erase_completion_lock)) { | 401 | if (atomic_dec_and_lock(&xd->refcnt, &c->erase_completion_lock)) { |
402 | uint32_t xid = xd->xid, version = xd->version; | ||
403 | |||
404 | unload_xattr_datum(c, xd); | 402 | unload_xattr_datum(c, xd); |
405 | xd->flags |= JFFS2_XFLAGS_DEAD; | 403 | xd->flags |= JFFS2_XFLAGS_DEAD; |
406 | if (xd->node == (void *)xd) { | 404 | if (xd->node == (void *)xd) { |
@@ -411,7 +409,8 @@ static void unrefer_xattr_datum(struct jffs2_sb_info *c, struct jffs2_xattr_datu | |||
411 | } | 409 | } |
412 | spin_unlock(&c->erase_completion_lock); | 410 | spin_unlock(&c->erase_completion_lock); |
413 | 411 | ||
414 | dbg_xattr("xdatum(xid=%u, version=%u) was removed.\n", xid, version); | 412 | dbg_xattr("xdatum(xid=%u, version=%u) was removed.\n", |
413 | xd->xid, xd->version); | ||
415 | } | 414 | } |
416 | } | 415 | } |
417 | 416 | ||