aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorOleg Drokin <Oleg.Drokin@Sun.COM>2008-01-11 21:57:35 -0500
committerJ. Bruce Fields <bfields@citi.umich.edu>2008-02-01 16:42:07 -0500
commit54ca95eb362d6988a577965ffb77c08702adb890 (patch)
treea18ff136ce9d530eaa90a42831d9b85a91ab6321 /fs
parent8838dc43d6544570e8969a74ddc4a0d21abffde6 (diff)
Leak in nlmsvc_testlock for async GETFL case
Fix nlm_block leak for the case of supplied blocking lock info. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Diffstat (limited to 'fs')
-rw-r--r--fs/lockd/svclock.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/lockd/svclock.c b/fs/lockd/svclock.c
index 84c4d5e04ebb..2f4d8fa66689 100644
--- a/fs/lockd/svclock.c
+++ b/fs/lockd/svclock.c
@@ -505,12 +505,12 @@ nlmsvc_testlock(struct svc_rqst *rqstp, struct nlm_file *file,
505 goto out; 505 goto out;
506 } 506 }
507 if (block->b_flags & B_GOT_CALLBACK) { 507 if (block->b_flags & B_GOT_CALLBACK) {
508 nlmsvc_unlink_block(block);
508 if (block->b_fl != NULL 509 if (block->b_fl != NULL
509 && block->b_fl->fl_type != F_UNLCK) { 510 && block->b_fl->fl_type != F_UNLCK) {
510 lock->fl = *block->b_fl; 511 lock->fl = *block->b_fl;
511 goto conf_lock; 512 goto conf_lock;
512 } else { 513 } else {
513 nlmsvc_unlink_block(block);
514 ret = nlm_granted; 514 ret = nlm_granted;
515 goto out; 515 goto out;
516 } 516 }