diff options
author | J. Bruce Fields <bfields@fieldses.org> | 2009-01-20 19:32:59 -0500 |
---|---|---|
committer | J. Bruce Fields <bfields@pig.fieldses.org> | 2009-01-27 17:26:58 -0500 |
commit | bf935a78814cc9b96d09f612912178adc964ce9c (patch) | |
tree | 2c23a05d1c4433e309f3434ce8bdd6a5a0ed8838 /fs | |
parent | ce0cf6622c9a6f18c2723ea4bef7616799a1ca39 (diff) |
nfsd: fix null dereference on error path
We're forgetting to check the return value from groups_alloc().
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/nfsd/auth.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/nfsd/auth.c b/fs/nfsd/auth.c index c903e04aa217..b860d3484cd7 100644 --- a/fs/nfsd/auth.c +++ b/fs/nfsd/auth.c | |||
@@ -49,6 +49,8 @@ int nfsd_setuser(struct svc_rqst *rqstp, struct svc_export *exp) | |||
49 | new->fsuid = exp->ex_anon_uid; | 49 | new->fsuid = exp->ex_anon_uid; |
50 | new->fsgid = exp->ex_anon_gid; | 50 | new->fsgid = exp->ex_anon_gid; |
51 | gi = groups_alloc(0); | 51 | gi = groups_alloc(0); |
52 | if (!gi) | ||
53 | goto oom; | ||
52 | } else if (flags & NFSEXP_ROOTSQUASH) { | 54 | } else if (flags & NFSEXP_ROOTSQUASH) { |
53 | if (!new->fsuid) | 55 | if (!new->fsuid) |
54 | new->fsuid = exp->ex_anon_uid; | 56 | new->fsuid = exp->ex_anon_uid; |