aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2008-07-16 09:51:03 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2008-07-26 20:53:19 -0400
commit8bb79224b87aab92071e94d46e70bd160d89bf34 (patch)
treedab47cbb434876e5916f18b738ef8bd3fe1e1ce1 /fs
parentdb2e747b14991a4c6a5c98b0e5f552a193237c03 (diff)
[PATCH] permission checks for chdir need special treatment only on the last step
... so we ought to pass MAY_CHDIR to vfs_permission() instead of having it triggered on every step of preceding pathname resolution. LOOKUP_CHDIR is killed by that. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs')
-rw-r--r--fs/namei.c2
-rw-r--r--fs/open.c5
2 files changed, 2 insertions, 5 deletions
diff --git a/fs/namei.c b/fs/namei.c
index ae0e56fdb742..6c76e1ee9c45 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -268,8 +268,6 @@ int permission(struct inode *inode, int mask, struct nameidata *nd)
268 if (nd) { 268 if (nd) {
269 if (nd->flags & LOOKUP_ACCESS) 269 if (nd->flags & LOOKUP_ACCESS)
270 extra |= MAY_ACCESS; 270 extra |= MAY_ACCESS;
271 if (nd->flags & LOOKUP_CHDIR)
272 extra |= MAY_CHDIR;
273 if (nd->flags & LOOKUP_OPEN) 271 if (nd->flags & LOOKUP_OPEN)
274 extra |= MAY_OPEN; 272 extra |= MAY_OPEN;
275 } 273 }
diff --git a/fs/open.c b/fs/open.c
index b2e4c93aed03..8e02d42bfe44 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -501,12 +501,11 @@ asmlinkage long sys_chdir(const char __user * filename)
501 struct nameidata nd; 501 struct nameidata nd;
502 int error; 502 int error;
503 503
504 error = __user_walk(filename, 504 error = __user_walk(filename, LOOKUP_FOLLOW|LOOKUP_DIRECTORY, &nd);
505 LOOKUP_FOLLOW|LOOKUP_DIRECTORY|LOOKUP_CHDIR, &nd);
506 if (error) 505 if (error)
507 goto out; 506 goto out;
508 507
509 error = vfs_permission(&nd, MAY_EXEC); 508 error = vfs_permission(&nd, MAY_EXEC | MAY_CHDIR);
510 if (error) 509 if (error)
511 goto dput_and_out; 510 goto dput_and_out;
512 511