switch vfs_path_lookup() to struct path

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

3 files changed, 20 insertions, 21 deletions

diff --git a/fs/namei.c b/fs/namei.c
index b45a039216c7..7e6ba8c80e77 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1575,16 +1575,22 @@ int kern_path(const char *name, unsigned int flags, struct path *path)
  * @mnt: pointer to vfs mount of the base directory
  * @name: pointer to file name
  * @flags: lookup flags
- * @nd: pointer to nameidata
+ * @path: pointer to struct path to fill
  */
 int vfs_path_lookup(struct dentry *dentry, struct vfsmount *mnt,
                     const char *name, unsigned int flags,
-                    struct nameidata *nd)
+                    struct path *path)
 {
-        nd->root.dentry = dentry;
-        nd->root.mnt = mnt;
+        struct nameidata nd;
+        int err;
+        nd.root.dentry = dentry;
+        nd.root.mnt = mnt;
+        BUG_ON(flags & LOOKUP_PARENT);
         /* the first argument of do_path_lookup() is ignored with LOOKUP_ROOT */
-        return do_path_lookup(AT_FDCWD, name, flags | LOOKUP_ROOT, nd);
+        err = do_path_lookup(AT_FDCWD, name, flags | LOOKUP_ROOT, &nd);
+        if (!err)
+                *path = nd.path;
+        return err;
 }
 
 static struct dentry *__lookup_hash(struct qstr *name,
diff --git a/fs/nfs/cache_lib.c b/fs/nfs/cache_lib.c
index 84690319e625..c98b439332fc 100644
--- a/fs/nfs/cache_lib.c
+++ b/fs/nfs/cache_lib.c
@@ -113,19 +113,18 @@ int nfs_cache_wait_for_upcall(struct nfs_cache_defer_req *dreq)
 
 int nfs_cache_register(struct cache_detail *cd)
 {
-        struct nameidata nd;
         struct vfsmount *mnt;
+        struct path path;
         int ret;
 
         mnt = rpc_get_mount();
         if (IS_ERR(mnt))
                 return PTR_ERR(mnt);
-        ret = vfs_path_lookup(mnt->mnt_root, mnt, "/cache", 0, &nd);
+        ret = vfs_path_lookup(mnt->mnt_root, mnt, "/cache", 0, &path);
         if (ret)
                 goto err;
-        ret = sunrpc_cache_register_pipefs(nd.path.dentry,
-                        cd->name, 0600, cd);
-        path_put(&nd.path);
+        ret = sunrpc_cache_register_pipefs(path.dentry, cd->name, 0600, cd);
+        path_put(&path);
         if (!ret)
                 return ret;
 err:
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index ce40e5c568ba..b961ceac66b4 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -2773,16 +2773,12 @@ static void nfs_referral_loop_unprotect(void)
 static struct dentry *nfs_follow_remote_path(struct vfsmount *root_mnt,
                 const char *export_path)
 {
-        struct nameidata *nd = NULL;
         struct mnt_namespace *ns_private;
         struct super_block *s;
         struct dentry *dentry;
+        struct path path;
         int ret;
 
-        nd = kmalloc(sizeof(*nd), GFP_KERNEL);
-        if (nd == NULL)
-                return ERR_PTR(-ENOMEM);
-
         ns_private = create_mnt_ns(root_mnt);
         ret = PTR_ERR(ns_private);
         if (IS_ERR(ns_private))
@@ -2793,7 +2789,7 @@ static struct dentry *nfs_follow_remote_path(struct vfsmount *root_mnt,
                 goto out_put_mnt_ns;
 
         ret = vfs_path_lookup(root_mnt->mnt_root, root_mnt,
-                        export_path, LOOKUP_FOLLOW, nd);
+                        export_path, LOOKUP_FOLLOW, &path);
 
         nfs_referral_loop_unprotect();
         put_mnt_ns(ns_private);
@@ -2801,12 +2797,11 @@ static struct dentry *nfs_follow_remote_path(struct vfsmount *root_mnt,
         if (ret != 0)
                 goto out_err;
 
-        s = nd->path.mnt->mnt_sb;
+        s = path.mnt->mnt_sb;
         atomic_inc(&s->s_active);
-        dentry = dget(nd->path.dentry);
+        dentry = dget(path.dentry);
 
-        path_put(&nd->path);
-        kfree(nd);
+        path_put(&path);
         down_write(&s->s_umount);
         return dentry;
 out_put_mnt_ns:
@@ -2814,7 +2809,6 @@ out_put_mnt_ns:
 out_mntput:
         mntput(root_mnt);
 out_err:
-        kfree(nd);
         return ERR_PTR(ret);
 }