diff options
author | Jaegeuk Kim <jaegeuk.kim@samsung.com> | 2014-03-19 00:45:52 -0400 |
---|---|---|
committer | Jaegeuk Kim <jaegeuk.kim@samsung.com> | 2014-03-20 09:10:09 -0400 |
commit | a5f420101db326e27ef5c2ab737c8c1b0e3559e3 (patch) | |
tree | 25614bc20d540070ac2e57e270d2156885b1f77a /fs | |
parent | cdfc41c134d48c1923066bcfa6630b94588ad6bc (diff) |
f2fs: remove unnecessary threshold
The NM_WOUT_THRESHOLD is now obsolete since f2fs starts to control on a basis
of the memory footprint.
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/f2fs/debug.c | 8 | ||||
-rw-r--r-- | fs/f2fs/node.c | 5 | ||||
-rw-r--r-- | fs/f2fs/node.h | 3 |
3 files changed, 5 insertions, 11 deletions
diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c index b7111c44a918..b52c12cf5873 100644 --- a/fs/f2fs/debug.c +++ b/fs/f2fs/debug.c | |||
@@ -250,10 +250,10 @@ static int stat_show(struct seq_file *s, void *v) | |||
250 | si->ndirty_dent, si->ndirty_dirs); | 250 | si->ndirty_dent, si->ndirty_dirs); |
251 | seq_printf(s, " - meta: %4d in %4d\n", | 251 | seq_printf(s, " - meta: %4d in %4d\n", |
252 | si->ndirty_meta, si->meta_pages); | 252 | si->ndirty_meta, si->meta_pages); |
253 | seq_printf(s, " - NATs: %5d > %lu\n", | 253 | seq_printf(s, " - NATs: %9d\n - SITs: %9d\n", |
254 | si->nats, NM_WOUT_THRESHOLD); | 254 | si->nats, si->sits); |
255 | seq_printf(s, " - SITs: %5d\n - free_nids: %5d\n", | 255 | seq_printf(s, " - free_nids: %9d\n", |
256 | si->sits, si->fnids); | 256 | si->fnids); |
257 | seq_puts(s, "\nDistribution of User Blocks:"); | 257 | seq_puts(s, "\nDistribution of User Blocks:"); |
258 | seq_puts(s, " [ valid | invalid | free ]\n"); | 258 | seq_puts(s, " [ valid | invalid | free ]\n"); |
259 | seq_puts(s, " ["); | 259 | seq_puts(s, " ["); |
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index fec4967fb8d2..daf644c57eae 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c | |||
@@ -224,7 +224,7 @@ int try_to_free_nats(struct f2fs_sb_info *sbi, int nr_shrink) | |||
224 | { | 224 | { |
225 | struct f2fs_nm_info *nm_i = NM_I(sbi); | 225 | struct f2fs_nm_info *nm_i = NM_I(sbi); |
226 | 226 | ||
227 | if (available_free_memory(nm_i, NAT_ENTRIES) || nr_shrink <= 0) | 227 | if (available_free_memory(nm_i, NAT_ENTRIES)) |
228 | return 0; | 228 | return 0; |
229 | 229 | ||
230 | write_lock(&nm_i->nat_tree_lock); | 230 | write_lock(&nm_i->nat_tree_lock); |
@@ -1830,9 +1830,6 @@ flush_now: | |||
1830 | if (!flushed) | 1830 | if (!flushed) |
1831 | mutex_unlock(&curseg->curseg_mutex); | 1831 | mutex_unlock(&curseg->curseg_mutex); |
1832 | f2fs_put_page(page, 1); | 1832 | f2fs_put_page(page, 1); |
1833 | |||
1834 | /* 2) shrink nat caches if necessary */ | ||
1835 | try_to_free_nats(sbi, nm_i->nat_cnt - NM_WOUT_THRESHOLD); | ||
1836 | } | 1833 | } |
1837 | 1834 | ||
1838 | static int init_node_manager(struct f2fs_sb_info *sbi) | 1835 | static int init_node_manager(struct f2fs_sb_info *sbi) |
diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h index c97215432100..c2015b71ff87 100644 --- a/fs/f2fs/node.h +++ b/fs/f2fs/node.h | |||
@@ -20,9 +20,6 @@ | |||
20 | /* maximum readahead size for node during getting data blocks */ | 20 | /* maximum readahead size for node during getting data blocks */ |
21 | #define MAX_RA_NODE 128 | 21 | #define MAX_RA_NODE 128 |
22 | 22 | ||
23 | /* maximum cached nat entries to manage memory footprint */ | ||
24 | #define NM_WOUT_THRESHOLD (64 * NAT_ENTRY_PER_BLOCK) | ||
25 | |||
26 | /* control the memory footprint threshold (10MB per 1GB ram) */ | 23 | /* control the memory footprint threshold (10MB per 1GB ram) */ |
27 | #define DEF_RAM_THRESHOLD 10 | 24 | #define DEF_RAM_THRESHOLD 10 |
28 | 25 | ||