aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorJan Blunck <jblunck@suse.de>2008-02-14 22:34:31 -0500
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2008-02-15 00:13:32 -0500
commit429731b1553bacf9a331c260c317a28aaa878edb (patch)
treed9feaea03f5abe2eb3ac6a40cbd4e4e3b4638e6a /fs
parentdb74ece990ea59a9ec9f00f8881026059ef5caf5 (diff)
Remove path_release_on_umount()
path_release_on_umount() should only be called from sys_umount(). I merged the function into sys_umount() instead of having in in namei.c. Signed-off-by: Jan Blunck <jblunck@suse.de> Acked-by: Christoph Hellwig <hch@lst.de> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/namei.c10
-rw-r--r--fs/namespace.c4
2 files changed, 3 insertions, 11 deletions
diff --git a/fs/namei.c b/fs/namei.c
index 52703986323a..3ed4d7576d6d 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -368,16 +368,6 @@ void path_release(struct nameidata *nd)
368 mntput(nd->mnt); 368 mntput(nd->mnt);
369} 369}
370 370
371/*
372 * umount() mustn't call path_release()/mntput() as that would clear
373 * mnt_expiry_mark
374 */
375void path_release_on_umount(struct nameidata *nd)
376{
377 dput(nd->dentry);
378 mntput_no_expire(nd->mnt);
379}
380
381/** 371/**
382 * release_open_intent - free up open intent resources 372 * release_open_intent - free up open intent resources
383 * @nd: pointer to nameidata 373 * @nd: pointer to nameidata
diff --git a/fs/namespace.c b/fs/namespace.c
index 63ced21c12dc..7937d30a6732 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -690,7 +690,9 @@ asmlinkage long sys_umount(char __user * name, int flags)
690 690
691 retval = do_umount(nd.mnt, flags); 691 retval = do_umount(nd.mnt, flags);
692dput_and_out: 692dput_and_out:
693 path_release_on_umount(&nd); 693 /* we mustn't call path_put() as that would clear mnt_expiry_mark */
694 dput(nd.dentry);
695 mntput_no_expire(nd.mnt);
694out: 696out:
695 return retval; 697 return retval;
696} 698}