[XFS] remove most calls to VN_RELE

Most VN_RELE calls either directly contain a XFS_ITOV or have the
corresponding xfs_inode already in scope. Use the IRELE helper instead of
VN_RELE to clarify the code. With a little more work we can kill VN_RELE
altogether and define IRELE in terms of iput directly.

SGI-PV: 976035
SGI-Modid: xfs-linux-melb:xfs-kern:30710a

Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>

6 files changed, 21 insertions, 19 deletions

diff --git a/fs/xfs/quota/xfs_qm.c b/fs/xfs/quota/xfs_qm.c
index 8e9c5ae6504d..adbc7bb9fbaa 100644
--- a/fs/xfs/quota/xfs_qm.c
+++ b/fs/xfs/quota/xfs_qm.c
@@ -1810,7 +1810,7 @@ xfs_qm_dqusage_adjust(
          * Now release the inode. This will send it to 'inactive', and
          * possibly even free blocks.
          */
-        VN_RELE(XFS_ITOV(ip));
+        IRELE(ip);
 
         /*
          * Goto next inode.
@@ -1968,7 +1968,7 @@ xfs_qm_init_quotainos(
                         if ((error = xfs_iget(mp, NULL, mp->m_sb.sb_gquotino,
                                              0, 0, &gip, 0))) {
                                 if (uip)
-                                        VN_RELE(XFS_ITOV(uip));
+                                        IRELE(uip);
                                 return XFS_ERROR(error);
                         }
                 }
@@ -1999,7 +1999,7 @@ xfs_qm_init_quotainos(
                                           sbflags | XFS_SB_GQUOTINO, flags);
                 if (error) {
                         if (uip)
-                                VN_RELE(XFS_ITOV(uip));
+                                IRELE(uip);
 
                         return XFS_ERROR(error);
                 }
diff --git a/fs/xfs/quota/xfs_qm_syscalls.c b/fs/xfs/quota/xfs_qm_syscalls.c
index d2b8be7e75f9..3dc161f39d13 100644
--- a/fs/xfs/quota/xfs_qm_syscalls.c
+++ b/fs/xfs/quota/xfs_qm_syscalls.c
@@ -386,7 +386,7 @@ xfs_qm_scall_trunc_qfiles(
                 error = xfs_iget(mp, NULL, mp->m_sb.sb_uquotino, 0, 0, &qip, 0);
                 if (! error) {
                         (void) xfs_truncate_file(mp, qip);
-                        VN_RELE(XFS_ITOV(qip));
+                        IRELE(qip);
                 }
         }
 
@@ -395,7 +395,7 @@ xfs_qm_scall_trunc_qfiles(
                 error = xfs_iget(mp, NULL, mp->m_sb.sb_gquotino, 0, 0, &qip, 0);
                 if (! error) {
                         (void) xfs_truncate_file(mp, qip);
-                        VN_RELE(XFS_ITOV(qip));
+                        IRELE(qip);
                 }
         }
 
@@ -552,13 +552,13 @@ xfs_qm_scall_getqstat(
                 out->qs_uquota.qfs_nblks = uip->i_d.di_nblocks;
                 out->qs_uquota.qfs_nextents = uip->i_d.di_nextents;
                 if (tempuqip)
-                        VN_RELE(XFS_ITOV(uip));
+                        IRELE(uip);
         }
         if (gip) {
                 out->qs_gquota.qfs_nblks = gip->i_d.di_nblocks;
                 out->qs_gquota.qfs_nextents = gip->i_d.di_nextents;
                 if (tempgqip)
-                        VN_RELE(XFS_ITOV(gip));
+                        IRELE(gip);
         }
         if (mp->m_quotainfo) {
                 out->qs_incoredqs = XFS_QI_MPLNDQUOTS(mp);
@@ -1095,7 +1095,7 @@ again:
                  * inactive code in hell.
                  */
                 if (vnode_refd)
-                        VN_RELE(vp);
+                        IRELE(ip);
                 XFS_MOUNT_ILOCK(mp);
                 /*
                  * If an inode was inserted or removed, we gotta
diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index cd24711ae276..962d74a9ea7e 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -46,6 +46,7 @@
 #include "xfs_trans_priv.h"
 #include "xfs_quota.h"
 #include "xfs_rw.h"
+#include "xfs_utils.h"
 
 STATIC int      xlog_find_zeroed(xlog_t *, xfs_daddr_t *);
 STATIC int      xlog_clear_stale_blocks(xlog_t *, xfs_lsn_t);
@@ -3248,7 +3249,7 @@ xlog_recover_process_iunlinks(
                                         if (ip->i_d.di_mode == 0)
                                                 xfs_iput_new(ip, 0);
                                         else
-                                                VN_RELE(XFS_ITOV(ip));
+                                                IRELE(ip);
                                 } else {
                                         /*
                                          * We can't read in the inode
diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
index 41b690e6896c..c2aafeb8c6cb 100644
--- a/fs/xfs/xfs_mount.c
+++ b/fs/xfs/xfs_mount.c
@@ -43,6 +43,7 @@
 #include "xfs_rw.h"
 #include "xfs_quota.h"
 #include "xfs_fsops.h"
+#include "xfs_utils.h"
 
 STATIC void     xfs_mount_log_sb(xfs_mount_t *, __int64_t);
 STATIC int      xfs_uuid_mount(xfs_mount_t *);
@@ -956,7 +957,6 @@ xfs_mountfs(
 {
         xfs_sb_t        *sbp = &(mp->m_sb);
         xfs_inode_t     *rip;
-        bhv_vnode_t     *rvp = NULL;
         __uint64_t      resblks;
         __int64_t       update_flags = 0LL;
         uint            quotamount, quotaflags;
@@ -1158,7 +1158,6 @@ xfs_mountfs(
         }
 
         ASSERT(rip != NULL);
-        rvp = XFS_ITOV(rip);
 
         if (unlikely((rip->i_d.di_mode & S_IFMT) != S_IFDIR)) {
                 cmn_err(CE_WARN, "XFS: corrupted root inode");
@@ -1241,7 +1240,7 @@ xfs_mountfs(
         /*
          * Free up the root inode.
          */
-        VN_RELE(rvp);
+        IRELE(rip);
  error3:
         xfs_log_unmount_dealloc(mp);
  error2:
diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
index 47082c01872d..9cd6471cd60f 100644
--- a/fs/xfs/xfs_rtalloc.c
+++ b/fs/xfs/xfs_rtalloc.c
@@ -44,6 +44,7 @@
 #include "xfs_rw.h"
 #include "xfs_inode_item.h"
 #include "xfs_trans_space.h"
+#include "xfs_utils.h"
 
 
 /*
@@ -2278,7 +2279,7 @@ xfs_rtmount_inodes(
         ASSERT(sbp->sb_rsumino != NULLFSINO);
         error = xfs_iget(mp, NULL, sbp->sb_rsumino, 0, 0, &mp->m_rsumip, 0);
         if (error) {
-                VN_RELE(XFS_ITOV(mp->m_rbmip));
+                IRELE(mp->m_rbmip);
                 return error;
         }
         ASSERT(mp->m_rsumip != NULL);
diff --git a/fs/xfs/xfs_vfsops.c b/fs/xfs/xfs_vfsops.c
index 4c132a87d437..c21e4d168297 100644
--- a/fs/xfs/xfs_vfsops.c
+++ b/fs/xfs/xfs_vfsops.c
@@ -55,6 +55,7 @@
 #include "xfs_fsops.h"
 #include "xfs_vnodeops.h"
 #include "xfs_vfsops.h"
+#include "xfs_utils.h"
 
 
 int __init
@@ -595,7 +596,7 @@ xfs_unmount(
         /*
          * Drop the reference count
          */
-        VN_RELE(rvp);
+        IRELE(rip);
 
         /*
          * If we're forcing a shutdown, typically because of a media error,
@@ -777,8 +778,8 @@ xfs_unmount_flush(
                 goto fscorrupt_out2;
 
         if (rbmip) {
-                VN_RELE(XFS_ITOV(rbmip));
-                VN_RELE(XFS_ITOV(rsumip));
+                IRELE(rbmip);
+                IRELE(rsumip);
         }
 
         xfs_iunlock(rip, XFS_ILOCK_EXCL);
@@ -1156,10 +1157,10 @@ xfs_sync_inodes(
                          * above, then wait until after we've unlocked
                          * the inode to release the reference.  This is
                          * because we can be already holding the inode
-                         * lock when VN_RELE() calls xfs_inactive().
+                         * lock when IRELE() calls xfs_inactive().
                          *
                          * Make sure to drop the mount lock before calling
-                         * VN_RELE() so that we don't trip over ourselves if
+                         * IRELE() so that we don't trip over ourselves if
                          * we have to go for the mount lock again in the
                          * inactive code.
                          */
@@ -1167,7 +1168,7 @@ xfs_sync_inodes(
                                 IPOINTER_INSERT(ip, mp);
                         }
 
-                        VN_RELE(vp);
+                        IRELE(ip);
 
                         vnode_refed = B_FALSE;
                 }