diff options
author | Nick Piggin <npiggin@suse.de> | 2008-08-02 06:01:03 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-08-05 00:31:34 -0400 |
commit | 529ae9aaa08378cfe2a4350bded76f32cc8ff0ce (patch) | |
tree | d3ae998f9876c72a83a022805103a92111852b21 /fs | |
parent | e9ba9698187ddbc0c5bfcf41de0349a662d23d02 (diff) |
mm: rename page trylock
Converting page lock to new locking bitops requires a change of page flag
operation naming, so we might as well convert it to something nicer
(!TestSetPageLocked_Lock => trylock_page, SetPageLocked => set_page_locked).
This also facilitates lockdeping of page lock.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Acked-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/afs/write.c | 2 | ||||
-rw-r--r-- | fs/cifs/file.c | 2 | ||||
-rw-r--r-- | fs/jbd/commit.c | 4 | ||||
-rw-r--r-- | fs/jbd2/commit.c | 2 | ||||
-rw-r--r-- | fs/reiserfs/journal.c | 2 | ||||
-rw-r--r-- | fs/splice.c | 2 | ||||
-rw-r--r-- | fs/xfs/linux-2.6/xfs_aops.c | 4 |
7 files changed, 9 insertions, 9 deletions
diff --git a/fs/afs/write.c b/fs/afs/write.c index 9a849ad3c489..065b4e10681a 100644 --- a/fs/afs/write.c +++ b/fs/afs/write.c | |||
@@ -404,7 +404,7 @@ static int afs_write_back_from_locked_page(struct afs_writeback *wb, | |||
404 | page = pages[loop]; | 404 | page = pages[loop]; |
405 | if (page->index > wb->last) | 405 | if (page->index > wb->last) |
406 | break; | 406 | break; |
407 | if (TestSetPageLocked(page)) | 407 | if (!trylock_page(page)) |
408 | break; | 408 | break; |
409 | if (!PageDirty(page) || | 409 | if (!PageDirty(page) || |
410 | page_private(page) != (unsigned long) wb) { | 410 | page_private(page) != (unsigned long) wb) { |
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 0aac824371a5..e692c42f24b5 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c | |||
@@ -1280,7 +1280,7 @@ retry: | |||
1280 | 1280 | ||
1281 | if (first < 0) | 1281 | if (first < 0) |
1282 | lock_page(page); | 1282 | lock_page(page); |
1283 | else if (TestSetPageLocked(page)) | 1283 | else if (!trylock_page(page)) |
1284 | break; | 1284 | break; |
1285 | 1285 | ||
1286 | if (unlikely(page->mapping != mapping)) { | 1286 | if (unlikely(page->mapping != mapping)) { |
diff --git a/fs/jbd/commit.c b/fs/jbd/commit.c index 2eccbfaa1d48..81a9ad7177ca 100644 --- a/fs/jbd/commit.c +++ b/fs/jbd/commit.c | |||
@@ -63,7 +63,7 @@ static void release_buffer_page(struct buffer_head *bh) | |||
63 | goto nope; | 63 | goto nope; |
64 | 64 | ||
65 | /* OK, it's a truncated page */ | 65 | /* OK, it's a truncated page */ |
66 | if (TestSetPageLocked(page)) | 66 | if (!trylock_page(page)) |
67 | goto nope; | 67 | goto nope; |
68 | 68 | ||
69 | page_cache_get(page); | 69 | page_cache_get(page); |
@@ -446,7 +446,7 @@ void journal_commit_transaction(journal_t *journal) | |||
446 | spin_lock(&journal->j_list_lock); | 446 | spin_lock(&journal->j_list_lock); |
447 | } | 447 | } |
448 | if (unlikely(!buffer_uptodate(bh))) { | 448 | if (unlikely(!buffer_uptodate(bh))) { |
449 | if (TestSetPageLocked(bh->b_page)) { | 449 | if (!trylock_page(bh->b_page)) { |
450 | spin_unlock(&journal->j_list_lock); | 450 | spin_unlock(&journal->j_list_lock); |
451 | lock_page(bh->b_page); | 451 | lock_page(bh->b_page); |
452 | spin_lock(&journal->j_list_lock); | 452 | spin_lock(&journal->j_list_lock); |
diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c index adf0395f318e..f2ad061e95ec 100644 --- a/fs/jbd2/commit.c +++ b/fs/jbd2/commit.c | |||
@@ -67,7 +67,7 @@ static void release_buffer_page(struct buffer_head *bh) | |||
67 | goto nope; | 67 | goto nope; |
68 | 68 | ||
69 | /* OK, it's a truncated page */ | 69 | /* OK, it's a truncated page */ |
70 | if (TestSetPageLocked(page)) | 70 | if (!trylock_page(page)) |
71 | goto nope; | 71 | goto nope; |
72 | 72 | ||
73 | page_cache_get(page); | 73 | page_cache_get(page); |
diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c index c8f60ee183b5..ce2208b27118 100644 --- a/fs/reiserfs/journal.c +++ b/fs/reiserfs/journal.c | |||
@@ -627,7 +627,7 @@ static int journal_list_still_alive(struct super_block *s, | |||
627 | static void release_buffer_page(struct buffer_head *bh) | 627 | static void release_buffer_page(struct buffer_head *bh) |
628 | { | 628 | { |
629 | struct page *page = bh->b_page; | 629 | struct page *page = bh->b_page; |
630 | if (!page->mapping && !TestSetPageLocked(page)) { | 630 | if (!page->mapping && trylock_page(page)) { |
631 | page_cache_get(page); | 631 | page_cache_get(page); |
632 | put_bh(bh); | 632 | put_bh(bh); |
633 | if (!page->mapping) | 633 | if (!page->mapping) |
diff --git a/fs/splice.c b/fs/splice.c index b30311ba8af6..1bbc6f4bb09c 100644 --- a/fs/splice.c +++ b/fs/splice.c | |||
@@ -371,7 +371,7 @@ __generic_file_splice_read(struct file *in, loff_t *ppos, | |||
371 | * for an in-flight io page | 371 | * for an in-flight io page |
372 | */ | 372 | */ |
373 | if (flags & SPLICE_F_NONBLOCK) { | 373 | if (flags & SPLICE_F_NONBLOCK) { |
374 | if (TestSetPageLocked(page)) { | 374 | if (!trylock_page(page)) { |
375 | error = -EAGAIN; | 375 | error = -EAGAIN; |
376 | break; | 376 | break; |
377 | } | 377 | } |
diff --git a/fs/xfs/linux-2.6/xfs_aops.c b/fs/xfs/linux-2.6/xfs_aops.c index 0b211cba1909..fa73179233ad 100644 --- a/fs/xfs/linux-2.6/xfs_aops.c +++ b/fs/xfs/linux-2.6/xfs_aops.c | |||
@@ -675,7 +675,7 @@ xfs_probe_cluster( | |||
675 | } else | 675 | } else |
676 | pg_offset = PAGE_CACHE_SIZE; | 676 | pg_offset = PAGE_CACHE_SIZE; |
677 | 677 | ||
678 | if (page->index == tindex && !TestSetPageLocked(page)) { | 678 | if (page->index == tindex && trylock_page(page)) { |
679 | pg_len = xfs_probe_page(page, pg_offset, mapped); | 679 | pg_len = xfs_probe_page(page, pg_offset, mapped); |
680 | unlock_page(page); | 680 | unlock_page(page); |
681 | } | 681 | } |
@@ -759,7 +759,7 @@ xfs_convert_page( | |||
759 | 759 | ||
760 | if (page->index != tindex) | 760 | if (page->index != tindex) |
761 | goto fail; | 761 | goto fail; |
762 | if (TestSetPageLocked(page)) | 762 | if (!trylock_page(page)) |
763 | goto fail; | 763 | goto fail; |
764 | if (PageWriteback(page)) | 764 | if (PageWriteback(page)) |
765 | goto fail_unlock_page; | 765 | goto fail_unlock_page; |