aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2010-10-25 01:02:56 -0400
committerSteve French <sfrench@us.ibm.com>2010-10-26 14:22:38 -0400
commitb235f371a2572d7c86a121d96d889eee02ed00e2 (patch)
tree72ae25c83a6ba59926a599e28d47b67bfa0ad863 /fs
parent21e733930be6458e0c33482b6783e7c15ba984eb (diff)
cifs: cifs_convert_address() returns zero on error
The cifs_convert_address() returns zero on error but this caller is testing for negative returns. Btw. "i" is unsigned here, so it's never negative. Reviewed-by: Jeff Layton <jlayton@samba.org> Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/cifs/connect.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index c5807d39dced..dd9a4ae1d21d 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1067,7 +1067,7 @@ cifs_parse_mount_options(char *options, const char *devname,
1067 } 1067 }
1068 i = cifs_convert_address((struct sockaddr *)&vol->srcaddr, 1068 i = cifs_convert_address((struct sockaddr *)&vol->srcaddr,
1069 value, strlen(value)); 1069 value, strlen(value));
1070 if (i < 0) { 1070 if (i == 0) {
1071 printk(KERN_WARNING "CIFS: Could not parse" 1071 printk(KERN_WARNING "CIFS: Could not parse"
1072 " srcaddr: %s\n", 1072 " srcaddr: %s\n",
1073 value); 1073 value);