diff options
author | Akinobu Mita <akinobu.mita@gmail.com> | 2006-10-18 23:24:42 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2006-11-16 17:30:26 -0500 |
commit | 7bb0386f102ece8819182ccf7fffe8bbebc32b19 (patch) | |
tree | 5ddc131df9f106bd7826714ee419fa5e944482bb /fs | |
parent | e45413eb708c1cf21082764457692c8eeac0ca97 (diff) |
debugfs: check return value correctly
The return value is stored in "*dentry", not in "dentry".
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/debugfs/inode.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index e77676df6713..a736d44989c4 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c | |||
@@ -147,13 +147,13 @@ static int debugfs_create_by_name(const char *name, mode_t mode, | |||
147 | *dentry = NULL; | 147 | *dentry = NULL; |
148 | mutex_lock(&parent->d_inode->i_mutex); | 148 | mutex_lock(&parent->d_inode->i_mutex); |
149 | *dentry = lookup_one_len(name, parent, strlen(name)); | 149 | *dentry = lookup_one_len(name, parent, strlen(name)); |
150 | if (!IS_ERR(dentry)) { | 150 | if (!IS_ERR(*dentry)) { |
151 | if ((mode & S_IFMT) == S_IFDIR) | 151 | if ((mode & S_IFMT) == S_IFDIR) |
152 | error = debugfs_mkdir(parent->d_inode, *dentry, mode); | 152 | error = debugfs_mkdir(parent->d_inode, *dentry, mode); |
153 | else | 153 | else |
154 | error = debugfs_create(parent->d_inode, *dentry, mode); | 154 | error = debugfs_create(parent->d_inode, *dentry, mode); |
155 | } else | 155 | } else |
156 | error = PTR_ERR(dentry); | 156 | error = PTR_ERR(*dentry); |
157 | mutex_unlock(&parent->d_inode->i_mutex); | 157 | mutex_unlock(&parent->d_inode->i_mutex); |
158 | 158 | ||
159 | return error; | 159 | return error; |