diff options
| author | Andrew Morton <akpm@linux-foundation.org> | 2007-03-23 03:10:02 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-03-23 14:01:22 -0400 |
| commit | 105fd108a66ceff2b0fb710582b97d61ee4c9d40 (patch) | |
| tree | 33d5acd7ec1acd625ae76be9b8b969c5b4a9a814 /fs | |
| parent | cee9e8c5cb1554e9e85ad764d27b6c808555ed89 (diff) | |
[PATCH] "ext[34]: EA block reference count racing fix" performance fix
A little mistake in 8a2bfdcbfa441d8b0e5cb9c9a7f45f77f80da465 is making all
transactions synchronous, which reduces ext3 performance to comical levels.
Cc: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/ext3/xattr.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ext3/xattr.c b/fs/ext3/xattr.c index 12f7dda1232c..f58cbb26323e 100644 --- a/fs/ext3/xattr.c +++ b/fs/ext3/xattr.c | |||
| @@ -495,7 +495,8 @@ ext3_xattr_release_block(handle_t *handle, struct inode *inode, | |||
| 495 | BHDR(bh)->h_refcount = cpu_to_le32( | 495 | BHDR(bh)->h_refcount = cpu_to_le32( |
| 496 | le32_to_cpu(BHDR(bh)->h_refcount) - 1); | 496 | le32_to_cpu(BHDR(bh)->h_refcount) - 1); |
| 497 | error = ext3_journal_dirty_metadata(handle, bh); | 497 | error = ext3_journal_dirty_metadata(handle, bh); |
| 498 | handle->h_sync = 1; | 498 | if (IS_SYNC(inode)) |
| 499 | handle->h_sync = 1; | ||
| 499 | DQUOT_FREE_BLOCK(inode, 1); | 500 | DQUOT_FREE_BLOCK(inode, 1); |
| 500 | ea_bdebug(bh, "refcount now=%d; releasing", | 501 | ea_bdebug(bh, "refcount now=%d; releasing", |
| 501 | le32_to_cpu(BHDR(bh)->h_refcount)); | 502 | le32_to_cpu(BHDR(bh)->h_refcount)); |