aboutsummaryrefslogtreecommitdiffstats
path: root/fs/xfs
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2011-01-14 07:07:30 -0500
committerAl Viro <viro@zeniv.linux.org.uk>2011-01-17 02:25:30 -0500
commit64c23e86873ee410554d6d1c76b60da47025e96f (patch)
treeb30c5ff8782ebfdec6956d7834f796731fd3a1d4 /fs/xfs
parenteb745dbccce56f1bbe3f80b95ad2a325145171c2 (diff)
make the feature checks in ->fallocate future proof
Instead of various home grown checks that might need updates for new flags just check for any bit outside the mask of the features supported by the filesystem. This makes the check future proof for any newly added flag. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/xfs')
-rw-r--r--fs/xfs/linux-2.6/xfs_iops.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c
index da54403633b6..a4ecc2188a09 100644
--- a/fs/xfs/linux-2.6/xfs_iops.c
+++ b/fs/xfs/linux-2.6/xfs_iops.c
@@ -518,6 +518,9 @@ xfs_vn_fallocate(
518 xfs_inode_t *ip = XFS_I(inode); 518 xfs_inode_t *ip = XFS_I(inode);
519 int cmd = XFS_IOC_RESVSP; 519 int cmd = XFS_IOC_RESVSP;
520 520
521 if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE))
522 return -EOPNOTSUPP;
523
521 /* preallocation on directories not yet supported */ 524 /* preallocation on directories not yet supported */
522 error = -ENODEV; 525 error = -ENODEV;
523 if (S_ISDIR(inode->i_mode)) 526 if (S_ISDIR(inode->i_mode))